)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"dc8144b27b63d5114a6562db6797130bb46cff61","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"907dcccb_55264ccf","updated":"2023-02-06 22:34:15.000000000","message":"Thank you for the review.","commit_id":"e14566ff95f316aca5c170da53b197a7d8b51225"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"8afef350248d9ca31cd777ab8cf7595153df0a27","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a81e52a3_09bdbc6d","updated":"2023-02-08 22:18:29.000000000","message":"Thank you for the review.","commit_id":"9233d9a3aa95e82347936e6d9030eabbf570271e"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"875f819d5e954e912d8e6a055063247587091b85","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d8a0dd27_fdd240ba","updated":"2023-02-08 07:19:31.000000000","message":"Thanks for your patch, let me confirm one thing before the review.\n\nThis patch seems to be only for VNF (openstack vim), but is there a future expansion to CNF (k8s/helm vim) on other patch?\n\nI think that the `_make_vnfc_info_id` method can be moved to a common function if it will extend to CNF and possible moving.","commit_id":"9233d9a3aa95e82347936e6d9030eabbf570271e"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"0263b392822cd75dac2023d26c08cb65fb9094b6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c528a229_49d0c6a0","updated":"2023-02-07 12:06:24.000000000","message":"This patch is the prototype implements for ETSI Feedbacks I mentioned in Tacker IRC.\nPlease kindly review and feedback from PTL and Cores.","commit_id":"9233d9a3aa95e82347936e6d9030eabbf570271e"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"ff08822094e2ff606e613a512b75ed975c19fd83","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7401100d_132a081e","in_reply_to":"44275647_cb2b6191","updated":"2023-02-22 00:40:57.000000000","message":"Thank you for discussion, ueha-san.\n\u003e other approach need to be considered for CNF.\nYes, ETSI NFV-SOL members proposed us to cooperate with k8s for vnfc identification in CNF case.\nOur team will consider them, thanks.","commit_id":"9233d9a3aa95e82347936e6d9030eabbf570271e"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"8afef350248d9ca31cd777ab8cf7595153df0a27","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f0647bed_f1a76f7f","in_reply_to":"d8a0dd27_fdd240ba","updated":"2023-02-08 22:18:29.000000000","message":"As mentioned commit message this assumes \"individual vnfc management\" (using StandardUserData (i.e. openstack vim only)) which manages vnfcs by index.","commit_id":"9233d9a3aa95e82347936e6d9030eabbf570271e"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b6bde57c274f263b426ea43d1ab057a2193ef90c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"44275647_cb2b6191","in_reply_to":"f0647bed_f1a76f7f","updated":"2023-02-20 13:30:08.000000000","message":"Thanks for your answer,\nI understand that this approach is only for VNF (\"individual vnfc management\" using StandardUserData), and other approach need to be considered for CNF.\nhttps://etherpad.opendev.org/p/tacker-etsinfv40#L35","commit_id":"9233d9a3aa95e82347936e6d9030eabbf570271e"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"7377dc3026b26b851618fb84e4b9e98e047517c4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"ff8fc732_530730f7","updated":"2023-02-22 00:17:48.000000000","message":"LGTM","commit_id":"4f371b8627b9956505c11582e64c66e7434fdda0"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b6bde57c274f263b426ea43d1ab057a2193ef90c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"0d47184f_08b62030","updated":"2023-02-20 13:30:08.000000000","message":"LGTM.","commit_id":"4f371b8627b9956505c11582e64c66e7434fdda0"}],"tacker/tests/functional/sol_v2/test_individual_vnfc_mgmt.py":[{"author":{"_account_id":31668},"change_message_id":"fe8cc55ea1f9a1c3154df46cd5b8e6f604b2c256","unresolved":true,"context_lines":[{"line_number":254,"context_line":"                         self._get_vnfc_id(inst_3, \u0027VDU1\u0027, 2))"},{"line_number":255,"context_line":"        self.assertEqual(self._get_vnfc_id(inst_2, \u0027VDU2\u0027, 0),"},{"line_number":256,"context_line":"                         self._get_vnfc_id(inst_3, \u0027VDU2\u0027, 0))"},{"line_number":257,"context_line":"        # but vnfcInfo id is not changed."},{"line_number":258,"context_line":"        self.assertEqual(\u0027a-010\u0027, self._get_vnfc_info_id(inst_3, \u0027VDU1\u0027, 1))"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"        # 4. Scale in operation"}],"source_content_type":"text/x-python","patch_set":2,"id":"264f69f9_84301bae","line":257,"updated":"2023-02-06 09:30:44.000000000","message":"According to other comments, it is better to:\n* check vnfcInfo id of VDU1-1 is not changed.","commit_id":"eb1537cb50b6d0328a0a92a153fff1adf0dd7b4a"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"dc8144b27b63d5114a6562db6797130bb46cff61","unresolved":true,"context_lines":[{"line_number":254,"context_line":"                         self._get_vnfc_id(inst_3, \u0027VDU1\u0027, 2))"},{"line_number":255,"context_line":"        self.assertEqual(self._get_vnfc_id(inst_2, \u0027VDU2\u0027, 0),"},{"line_number":256,"context_line":"                         self._get_vnfc_id(inst_3, \u0027VDU2\u0027, 0))"},{"line_number":257,"context_line":"        # but vnfcInfo id is not changed."},{"line_number":258,"context_line":"        self.assertEqual(\u0027a-010\u0027, self._get_vnfc_info_id(inst_3, \u0027VDU1\u0027, 1))"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"        # 4. Scale in operation"}],"source_content_type":"text/x-python","patch_set":2,"id":"4ec75764_1895a575","line":257,"in_reply_to":"264f69f9_84301bae","updated":"2023-02-06 22:34:15.000000000","message":"OK, I will fix.","commit_id":"eb1537cb50b6d0328a0a92a153fff1adf0dd7b4a"},{"author":{"_account_id":31668},"change_message_id":"021122f0d98d82bc3bc519f795edf0440ebd2c49","unresolved":false,"context_lines":[{"line_number":254,"context_line":"                         self._get_vnfc_id(inst_3, \u0027VDU1\u0027, 2))"},{"line_number":255,"context_line":"        self.assertEqual(self._get_vnfc_id(inst_2, \u0027VDU2\u0027, 0),"},{"line_number":256,"context_line":"                         self._get_vnfc_id(inst_3, \u0027VDU2\u0027, 0))"},{"line_number":257,"context_line":"        # but vnfcInfo id is not changed."},{"line_number":258,"context_line":"        self.assertEqual(\u0027a-010\u0027, self._get_vnfc_info_id(inst_3, \u0027VDU1\u0027, 1))"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"        # 4. Scale in operation"}],"source_content_type":"text/x-python","patch_set":2,"id":"288b161b_76125646","line":257,"in_reply_to":"4ec75764_1895a575","updated":"2023-02-07 00:07:00.000000000","message":"Done","commit_id":"eb1537cb50b6d0328a0a92a153fff1adf0dd7b4a"},{"author":{"_account_id":31668},"change_message_id":"fe8cc55ea1f9a1c3154df46cd5b8e6f604b2c256","unresolved":true,"context_lines":[{"line_number":340,"context_line":"            self._get_vnfc_cp_net_id(inst_6, \u0027VDU1\u0027, 1, \u0027VDU1_CP1\u0027))"},{"line_number":341,"context_line":"        self.assertEqual(net_ids[\u0027net0\u0027],"},{"line_number":342,"context_line":"            self._get_vnfc_cp_net_id(inst_6, \u0027VDU2\u0027, 0, \u0027VDU2_CP1\u0027))"},{"line_number":343,"context_line":"        # vnfcInfo ids are not changed."},{"line_number":344,"context_line":"        self.assertEqual(\u0027a-001\u0027, self._get_vnfc_info_id(inst_6, \u0027VDU1\u0027, 0))"},{"line_number":345,"context_line":"        self.assertEqual(\u0027a-010\u0027, self._get_vnfc_info_id(inst_6, \u0027VDU1\u0027, 1))"},{"line_number":346,"context_line":"        self.assertEqual(\u0027b-000\u0027, self._get_vnfc_info_id(inst_6, \u0027VDU2\u0027, 0))"}],"source_content_type":"text/x-python","patch_set":2,"id":"58649c3a_fc9de7c4","line":343,"updated":"2023-02-06 09:30:44.000000000","message":"According to other comments, it is better to:\n* check all vnfcInfo ids are not changed.","commit_id":"eb1537cb50b6d0328a0a92a153fff1adf0dd7b4a"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"dc8144b27b63d5114a6562db6797130bb46cff61","unresolved":true,"context_lines":[{"line_number":340,"context_line":"            self._get_vnfc_cp_net_id(inst_6, \u0027VDU1\u0027, 1, \u0027VDU1_CP1\u0027))"},{"line_number":341,"context_line":"        self.assertEqual(net_ids[\u0027net0\u0027],"},{"line_number":342,"context_line":"            self._get_vnfc_cp_net_id(inst_6, \u0027VDU2\u0027, 0, \u0027VDU2_CP1\u0027))"},{"line_number":343,"context_line":"        # vnfcInfo ids are not changed."},{"line_number":344,"context_line":"        self.assertEqual(\u0027a-001\u0027, self._get_vnfc_info_id(inst_6, \u0027VDU1\u0027, 0))"},{"line_number":345,"context_line":"        self.assertEqual(\u0027a-010\u0027, self._get_vnfc_info_id(inst_6, \u0027VDU1\u0027, 1))"},{"line_number":346,"context_line":"        self.assertEqual(\u0027b-000\u0027, self._get_vnfc_info_id(inst_6, \u0027VDU2\u0027, 0))"}],"source_content_type":"text/x-python","patch_set":2,"id":"5c8c3f24_4963a3da","line":343,"in_reply_to":"58649c3a_fc9de7c4","updated":"2023-02-06 22:34:15.000000000","message":"OK, I will fix.","commit_id":"eb1537cb50b6d0328a0a92a153fff1adf0dd7b4a"},{"author":{"_account_id":31668},"change_message_id":"021122f0d98d82bc3bc519f795edf0440ebd2c49","unresolved":false,"context_lines":[{"line_number":340,"context_line":"            self._get_vnfc_cp_net_id(inst_6, \u0027VDU1\u0027, 1, \u0027VDU1_CP1\u0027))"},{"line_number":341,"context_line":"        self.assertEqual(net_ids[\u0027net0\u0027],"},{"line_number":342,"context_line":"            self._get_vnfc_cp_net_id(inst_6, \u0027VDU2\u0027, 0, \u0027VDU2_CP1\u0027))"},{"line_number":343,"context_line":"        # vnfcInfo ids are not changed."},{"line_number":344,"context_line":"        self.assertEqual(\u0027a-001\u0027, self._get_vnfc_info_id(inst_6, \u0027VDU1\u0027, 0))"},{"line_number":345,"context_line":"        self.assertEqual(\u0027a-010\u0027, self._get_vnfc_info_id(inst_6, \u0027VDU1\u0027, 1))"},{"line_number":346,"context_line":"        self.assertEqual(\u0027b-000\u0027, self._get_vnfc_info_id(inst_6, \u0027VDU2\u0027, 0))"}],"source_content_type":"text/x-python","patch_set":2,"id":"17edc7e7_358c6b90","line":343,"in_reply_to":"5c8c3f24_4963a3da","updated":"2023-02-07 00:07:00.000000000","message":"Done","commit_id":"eb1537cb50b6d0328a0a92a153fff1adf0dd7b4a"}]}