)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"577205c865a6927e5eacfa575b68f94230ceb40e","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     YiFeng \u003cfengyi@fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-02-21 15:03:23 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add support cnf auto scale via threshold interface"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add the Performance Management Threshold API and CLI to support"},{"line_number":10,"context_line":"AutoScale. The Performance Management Threshold API is based on"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"20f287a1_dda9178e","line":7,"range":{"start_line":7,"start_character":12,"end_line":7,"end_character":15},"updated":"2023-02-22 01:54:27.000000000","message":"nits: cnf -\u003e CNF","commit_id":"32aba1ae2780c5c78006909d2d0c15068d28d259"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"577205c865a6927e5eacfa575b68f94230ceb40e","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     YiFeng \u003cfengyi@fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-02-21 15:03:23 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add support cnf auto scale via threshold interface"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add the Performance Management Threshold API and CLI to support"},{"line_number":10,"context_line":"AutoScale. The Performance Management Threshold API is based on"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"71107840_fe8c8108","line":7,"range":{"start_line":7,"start_character":31,"end_line":7,"end_character":40},"updated":"2023-02-22 01:54:27.000000000","message":"nits: threshold -\u003e PM Threshold","commit_id":"32aba1ae2780c5c78006909d2d0c15068d28d259"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"2cd62639d648f31abacdb149f39c1bb20b962160","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     YiFeng \u003cfengyi@fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-02-21 15:03:23 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add support cnf auto scale via threshold interface"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add the Performance Management Threshold API and CLI to support"},{"line_number":10,"context_line":"AutoScale. The Performance Management Threshold API is based on"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"8b259a33_fcdde469","line":7,"range":{"start_line":7,"start_character":12,"end_line":7,"end_character":15},"in_reply_to":"20f287a1_dda9178e","updated":"2023-02-22 10:46:40.000000000","message":"I fixed it in Patchset 9.","commit_id":"32aba1ae2780c5c78006909d2d0c15068d28d259"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"2cd62639d648f31abacdb149f39c1bb20b962160","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     YiFeng \u003cfengyi@fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-02-21 15:03:23 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add support cnf auto scale via threshold interface"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add the Performance Management Threshold API and CLI to support"},{"line_number":10,"context_line":"AutoScale. The Performance Management Threshold API is based on"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"e028b980_b5436e50","line":7,"range":{"start_line":7,"start_character":31,"end_line":7,"end_character":40},"in_reply_to":"71107840_fe8c8108","updated":"2023-02-22 10:46:40.000000000","message":"I fixed it in Patchset 9.","commit_id":"32aba1ae2780c5c78006909d2d0c15068d28d259"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"6a8db94725d7495bbc76eb5d43ada966e291bfbe","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     YiFeng \u003cfengyi@fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-02-21 15:03:23 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add support cnf auto scale via threshold interface"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add the Performance Management Threshold API and CLI to support"},{"line_number":10,"context_line":"AutoScale. The Performance Management Threshold API is based on"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"1a9ab4a8_3c0deb31","line":7,"range":{"start_line":7,"start_character":12,"end_line":7,"end_character":15},"in_reply_to":"8b259a33_fcdde469","updated":"2023-03-02 03:54:37.000000000","message":"Done","commit_id":"32aba1ae2780c5c78006909d2d0c15068d28d259"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"6a8db94725d7495bbc76eb5d43ada966e291bfbe","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     YiFeng \u003cfengyi@fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-02-21 15:03:23 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add support cnf auto scale via threshold interface"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add the Performance Management Threshold API and CLI to support"},{"line_number":10,"context_line":"AutoScale. The Performance Management Threshold API is based on"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"f2d223ec_ac55d15e","line":7,"range":{"start_line":7,"start_character":31,"end_line":7,"end_character":40},"in_reply_to":"e028b980_b5436e50","updated":"2023-03-02 03:54:37.000000000","message":"Done","commit_id":"32aba1ae2780c5c78006909d2d0c15068d28d259"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"c73af81e192f81dfa85e207a9a84b5cb65620e17","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add the Performance Management Threshold API and CLI to support"},{"line_number":10,"context_line":"AutoScale. The Performance Management Threshold API is based on"},{"line_number":11,"context_line":"ETSI NFV-SOL 002 v3.3.1 and ETSI NFV-SOL 003 v3.3.1, which is"},{"line_number":12,"context_line":"Version \"2.0.0\" API of Tacker. Add the Prometheus Plugin that"},{"line_number":13,"context_line":"has a interface between tacker and Prometheus as a sample of"},{"line_number":14,"context_line":"External Monitoring Tool."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"feda010e_190748ae","line":12,"range":{"start_line":11,"start_character":53,"end_line":12,"end_character":30},"updated":"2023-02-22 00:30:41.000000000","message":"I think the following is better.\nwhich is Version \"2.0.0\" API of Tacker.\n-\u003e on which v2 VNF LCM API of Tacker is based.","commit_id":"32aba1ae2780c5c78006909d2d0c15068d28d259"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"764aa5e8339fd7da967e397048cff462c9426d9f","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add the Performance Management Threshold API and CLI to support"},{"line_number":10,"context_line":"AutoScale. The Performance Management Threshold API is based on"},{"line_number":11,"context_line":"ETSI NFV-SOL 002 v3.3.1 and ETSI NFV-SOL 003 v3.3.1, which is"},{"line_number":12,"context_line":"Version \"2.0.0\" API of Tacker. Add the Prometheus Plugin that"},{"line_number":13,"context_line":"has a interface between tacker and Prometheus as a sample of"},{"line_number":14,"context_line":"External Monitoring Tool."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"292af895_8be1e6a9","line":12,"range":{"start_line":11,"start_character":53,"end_line":12,"end_character":30},"in_reply_to":"bb4f3cd0_cd17363f","updated":"2023-02-24 02:08:57.000000000","message":"Done","commit_id":"32aba1ae2780c5c78006909d2d0c15068d28d259"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"2cd62639d648f31abacdb149f39c1bb20b962160","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add the Performance Management Threshold API and CLI to support"},{"line_number":10,"context_line":"AutoScale. The Performance Management Threshold API is based on"},{"line_number":11,"context_line":"ETSI NFV-SOL 002 v3.3.1 and ETSI NFV-SOL 003 v3.3.1, which is"},{"line_number":12,"context_line":"Version \"2.0.0\" API of Tacker. Add the Prometheus Plugin that"},{"line_number":13,"context_line":"has a interface between tacker and Prometheus as a sample of"},{"line_number":14,"context_line":"External Monitoring Tool."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"bb4f3cd0_cd17363f","line":12,"range":{"start_line":11,"start_character":53,"end_line":12,"end_character":30},"in_reply_to":"feda010e_190748ae","updated":"2023-02-22 10:46:40.000000000","message":"I fixed it in Patchset 9.","commit_id":"32aba1ae2780c5c78006909d2d0c15068d28d259"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"c73af81e192f81dfa85e207a9a84b5cb65620e17","unresolved":true,"context_lines":[{"line_number":10,"context_line":"AutoScale. The Performance Management Threshold API is based on"},{"line_number":11,"context_line":"ETSI NFV-SOL 002 v3.3.1 and ETSI NFV-SOL 003 v3.3.1, which is"},{"line_number":12,"context_line":"Version \"2.0.0\" API of Tacker. Add the Prometheus Plugin that"},{"line_number":13,"context_line":"has a interface between tacker and Prometheus as a sample of"},{"line_number":14,"context_line":"External Monitoring Tool."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Implements: blueprint support-auto-lcm"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"93b7246f_acfca2dc","line":13,"updated":"2023-02-22 00:30:41.000000000","message":"nit: a interface -\u003e an interface","commit_id":"32aba1ae2780c5c78006909d2d0c15068d28d259"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"577205c865a6927e5eacfa575b68f94230ceb40e","unresolved":true,"context_lines":[{"line_number":10,"context_line":"AutoScale. The Performance Management Threshold API is based on"},{"line_number":11,"context_line":"ETSI NFV-SOL 002 v3.3.1 and ETSI NFV-SOL 003 v3.3.1, which is"},{"line_number":12,"context_line":"Version \"2.0.0\" API of Tacker. Add the Prometheus Plugin that"},{"line_number":13,"context_line":"has a interface between tacker and Prometheus as a sample of"},{"line_number":14,"context_line":"External Monitoring Tool."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Implements: blueprint support-auto-lcm"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"706b755d_25bd588f","line":13,"range":{"start_line":13,"start_character":24,"end_line":13,"end_character":30},"updated":"2023-02-22 01:54:27.000000000","message":"nits: tacker -\u003e Tacker","commit_id":"32aba1ae2780c5c78006909d2d0c15068d28d259"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"2cd62639d648f31abacdb149f39c1bb20b962160","unresolved":true,"context_lines":[{"line_number":10,"context_line":"AutoScale. The Performance Management Threshold API is based on"},{"line_number":11,"context_line":"ETSI NFV-SOL 002 v3.3.1 and ETSI NFV-SOL 003 v3.3.1, which is"},{"line_number":12,"context_line":"Version \"2.0.0\" API of Tacker. Add the Prometheus Plugin that"},{"line_number":13,"context_line":"has a interface between tacker and Prometheus as a sample of"},{"line_number":14,"context_line":"External Monitoring Tool."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Implements: blueprint support-auto-lcm"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"966b6820_bb55c239","line":13,"range":{"start_line":13,"start_character":24,"end_line":13,"end_character":30},"in_reply_to":"706b755d_25bd588f","updated":"2023-02-22 10:46:40.000000000","message":"I fixed it in Patchset 9.","commit_id":"32aba1ae2780c5c78006909d2d0c15068d28d259"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"2cd62639d648f31abacdb149f39c1bb20b962160","unresolved":true,"context_lines":[{"line_number":10,"context_line":"AutoScale. The Performance Management Threshold API is based on"},{"line_number":11,"context_line":"ETSI NFV-SOL 002 v3.3.1 and ETSI NFV-SOL 003 v3.3.1, which is"},{"line_number":12,"context_line":"Version \"2.0.0\" API of Tacker. Add the Prometheus Plugin that"},{"line_number":13,"context_line":"has a interface between tacker and Prometheus as a sample of"},{"line_number":14,"context_line":"External Monitoring Tool."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Implements: blueprint support-auto-lcm"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"c5eb654f_893abaf2","line":13,"in_reply_to":"93b7246f_acfca2dc","updated":"2023-02-22 10:46:40.000000000","message":"I fixed it in Patchset 9.","commit_id":"32aba1ae2780c5c78006909d2d0c15068d28d259"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"6a8db94725d7495bbc76eb5d43ada966e291bfbe","unresolved":false,"context_lines":[{"line_number":10,"context_line":"AutoScale. The Performance Management Threshold API is based on"},{"line_number":11,"context_line":"ETSI NFV-SOL 002 v3.3.1 and ETSI NFV-SOL 003 v3.3.1, which is"},{"line_number":12,"context_line":"Version \"2.0.0\" API of Tacker. Add the Prometheus Plugin that"},{"line_number":13,"context_line":"has a interface between tacker and Prometheus as a sample of"},{"line_number":14,"context_line":"External Monitoring Tool."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Implements: blueprint support-auto-lcm"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"5802088c_b71bcefb","line":13,"range":{"start_line":13,"start_character":24,"end_line":13,"end_character":30},"in_reply_to":"966b6820_bb55c239","updated":"2023-03-02 03:54:37.000000000","message":"Done","commit_id":"32aba1ae2780c5c78006909d2d0c15068d28d259"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"764aa5e8339fd7da967e397048cff462c9426d9f","unresolved":false,"context_lines":[{"line_number":10,"context_line":"AutoScale. The Performance Management Threshold API is based on"},{"line_number":11,"context_line":"ETSI NFV-SOL 002 v3.3.1 and ETSI NFV-SOL 003 v3.3.1, which is"},{"line_number":12,"context_line":"Version \"2.0.0\" API of Tacker. Add the Prometheus Plugin that"},{"line_number":13,"context_line":"has a interface between tacker and Prometheus as a sample of"},{"line_number":14,"context_line":"External Monitoring Tool."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Implements: blueprint support-auto-lcm"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"2778173a_67697288","line":13,"in_reply_to":"c5eb654f_893abaf2","updated":"2023-02-24 02:08:57.000000000","message":"Done","commit_id":"32aba1ae2780c5c78006909d2d0c15068d28d259"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"a37e2e80a7bc6d9e2f477ff6880f50fa4b0210da","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Yi Feng \u003cfengyi@fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-02-27 01:12:25 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add support CNF auto scale via PM Threshold interface"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add the Performance Management Threshold API and CLI to support"},{"line_number":10,"context_line":"AutoScale. The Performance Management Threshold API is based on"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"4e776163_11c42cb3","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":53},"updated":"2023-02-27 13:59:55.000000000","message":"Could you follow the guideline for commit message?\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure\n\u003e The first line should be limited to 50 characters and should not end with a period.\n\nI think the following is good:\n\u003e Support CNF auto scale via PM Threshold interface","commit_id":"684824f35fd01773b0d4e9d14eeeaad4709c08e6"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"f7bd401b26a54e33d54fcc00aac5c215b35c1f4f","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Yi Feng \u003cfengyi@fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-02-27 01:12:25 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add support CNF auto scale via PM Threshold interface"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add the Performance Management Threshold API and CLI to support"},{"line_number":10,"context_line":"AutoScale. The Performance Management Threshold API is based on"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"b4e80aa6_be3c20f9","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":53},"in_reply_to":"4e776163_11c42cb3","updated":"2023-03-01 08:16:58.000000000","message":"I fixed it in patchset 15.","commit_id":"684824f35fd01773b0d4e9d14eeeaad4709c08e6"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"39fddcd86ac23ded4748b17b6c009639502b1a2f","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Yi Feng \u003cfengyi@fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-02-27 01:12:25 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add support CNF auto scale via PM Threshold interface"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add the Performance Management Threshold API and CLI to support"},{"line_number":10,"context_line":"AutoScale. The Performance Management Threshold API is based on"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"6d464b0c_02a87345","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":53},"in_reply_to":"4e776163_11c42cb3","updated":"2023-03-01 08:16:13.000000000","message":"ping","commit_id":"684824f35fd01773b0d4e9d14eeeaad4709c08e6"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"598c3bc7dbe57a9d7bd6c130736edbe170c54745","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Yi Feng \u003cfengyi@fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-02-27 01:12:25 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add support CNF auto scale via PM Threshold interface"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add the Performance Management Threshold API and CLI to support"},{"line_number":10,"context_line":"AutoScale. The Performance Management Threshold API is based on"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"3c6a73d2_b5407737","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":53},"in_reply_to":"b4e80aa6_be3c20f9","updated":"2023-03-01 08:19:46.000000000","message":"Thank you! I\u0027ve confirm it.","commit_id":"684824f35fd01773b0d4e9d14eeeaad4709c08e6"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"b3e1069b95f07e746a88aa0d6c16f0e0f367f9f0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7f9f9d29_74973829","updated":"2023-02-13 10:58:10.000000000","message":"recheck, infra failure in sol and sol-separated-nfvo job","commit_id":"da2e841d45f2c44940ef553ae74cbbec5dbbdc6d"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"577205c865a6927e5eacfa575b68f94230ceb40e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"b88b4d93_460f6321","updated":"2023-02-22 01:54:27.000000000","message":"Thank you for the patch. Please kindly check my comments.","commit_id":"32aba1ae2780c5c78006909d2d0c15068d28d259"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"59e6c30ea331334107e28f84e0e5b0dd0e950df3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"ff122526_e3249a75","updated":"2023-03-01 05:43:06.000000000","message":"A supplement to my comment.","commit_id":"684824f35fd01773b0d4e9d14eeeaad4709c08e6"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"a37e2e80a7bc6d9e2f477ff6880f50fa4b0210da","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"d2b722d2_2d56e12d","updated":"2023-02-27 13:59:55.000000000","message":"Thanks for your patch, please kindly find my comments.","commit_id":"684824f35fd01773b0d4e9d14eeeaad4709c08e6"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"6a8db94725d7495bbc76eb5d43ada966e291bfbe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"67dcce88_a7083e65","updated":"2023-03-02 03:54:37.000000000","message":"Thank you for re-work!","commit_id":"8fc611a2db8c615c44f8fdf276148a5cd465cfba"},{"author":{"_account_id":32707,"name":"Kenta Fukaya","email":"kenta.fukaya.xv@hco.ntt.co.jp","username":"fukayan"},"change_message_id":"f3c1b05229277a92587727aea80102a7043230f3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"574f7376_ffd58027","updated":"2023-03-02 05:29:51.000000000","message":"Thanks for your patch, please kindly find my comments.\n","commit_id":"8fc611a2db8c615c44f8fdf276148a5cd465cfba"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"4b6e0dd5b7980f359da3335c49ab31c3c2838ee5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"7a1aeb4c_c1baf107","updated":"2023-03-03 07:37:05.000000000","message":"Thank you for re-work. Please kindly check my additional comment.","commit_id":"bf609a878a67444cf7865650c5321badb9aa1cad"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"56dfe3903b9a0b66735f2b886f38eed520edb23a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"9b04cb9c_948ebec8","updated":"2023-03-07 03:03:47.000000000","message":"Thank you for great re-work! Please kindly check my comments.","commit_id":"ba8f07016cc719c62a264a14b914afd9b0d7d85d"},{"author":{"_account_id":35016,"name":"Koji Shimizu","email":"shimizu.koji@fujitsu.com","username":"shimizu-koji"},"change_message_id":"9b7c06b352fe85854c4cba1a764c3a43aaf45114","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"9004e917_7eed984e","updated":"2023-03-07 00:41:29.000000000","message":"Thank you for the patch, please kindly check my comments.","commit_id":"ba8f07016cc719c62a264a14b914afd9b0d7d85d"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"44b7f8fc31425dc896c881675d8f0f65a1da16e2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"3a24c7f6_f0dd1e0c","updated":"2023-03-07 01:02:26.000000000","message":"Thanks for your update, please kindly find my comments.","commit_id":"ba8f07016cc719c62a264a14b914afd9b0d7d85d"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"4452ce72041c8be511f16c4e9b26c700e7a63030","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"b7fce50a_d3e28d82","updated":"2023-03-07 06:48:02.000000000","message":"Thanks for your quick reply and re-work!","commit_id":"510bc9433989f4cd362899bb97cdb01dae663257"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"dc16bcedf94f5bbf9cd3b459b2afd2fa69f694a4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"a2e5e5e3_62b7620b","updated":"2023-03-08 02:32:42.000000000","message":"Thank you for re-work! Almost LGTM, but please check my additonal nit comments.","commit_id":"ab7e028ce5fe89cf6ee2d1cc9bf3f625d6fecf79"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"70b1a74aed0ab5e41e1dbac45a788b76f262f97f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"d1e721f3_f5d32715","updated":"2023-03-07 12:20:57.000000000","message":"Thanks for your rework, LGTM.","commit_id":"ab7e028ce5fe89cf6ee2d1cc9bf3f625d6fecf79"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"67b6c05f0a1acfd9c3c3a8c709cfed0446196059","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"1373d035_6d7156bc","updated":"2023-03-08 06:18:03.000000000","message":"Thank you for the patch. Please kindly check my comments.","commit_id":"0048f07fd3abb9a6d79b9cc311fb4985c73c034d"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"17d1f26c99e46296b23ca02aa9f19fef1a1db349","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"9230114f_aedfeb87","updated":"2023-03-08 05:52:58.000000000","message":"Thanks for your quick re-work! LGTM","commit_id":"0048f07fd3abb9a6d79b9cc311fb4985c73c034d"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"bfa4c0ad28030aed72bef1e4e055af0771c70503","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"8c786493_2997fcc9","updated":"2023-03-08 09:27:46.000000000","message":"Thank you for re-work! \nPlease kindly check my additional comments.","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"6595bda8fa2a5bfac0f6e5dfa2bf868e058494e7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"6b449f96_8c97d924","updated":"2023-03-08 12:10:14.000000000","message":"Thanks for great re-work. Please kindly check my additional comments.","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"8096f634da5f4bec8e0dc92cb09c6a7255f1dc94","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"f7d76c1f_8df1bf44","updated":"2023-03-10 07:12:53.000000000","message":"Thanks for re-work. Please kindly check my additional comments.","commit_id":"6d2ab6d58817c4fc0e337011e6ed80413de2db1d"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"6a4ce7e18be5903b66bb84f1f21c90c9319c153a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"ba903a68_606fa28c","updated":"2023-03-10 06:20:04.000000000","message":"Thanks for your great re-work!","commit_id":"6d2ab6d58817c4fc0e337011e6ed80413de2db1d"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"aa7951f8cc6d8430870e4d9df65ee74d638c9c5a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"5b22f5cc_1103b9d7","updated":"2023-03-10 20:24:11.000000000","message":"Sorry for the late reply. Please confirm my tiny comments.","commit_id":"7fead4150349fec4a219f23636c4ee68777035df"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"137d4ea4ec430515571763a7d521abc724e926a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"d8f447d8_aa1f7f91","updated":"2023-03-10 11:13:09.000000000","message":"recheck -infra failure","commit_id":"7fead4150349fec4a219f23636c4ee68777035df"},{"author":{"_account_id":35016,"name":"Koji Shimizu","email":"shimizu.koji@fujitsu.com","username":"shimizu-koji"},"change_message_id":"e414cd59831c8d7a0d63b7c55ba76f411c43b099","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"a722ae31_966bbce1","updated":"2023-03-10 19:54:39.000000000","message":"recheck, infra failure","commit_id":"7fead4150349fec4a219f23636c4ee68777035df"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"8d68546ea5fb3ce285a9fa6d0c957d576c924147","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":30,"id":"358df6ac_7fd1e564","updated":"2023-03-14 00:33:11.000000000","message":"Thanks for all your reviews and great re-works! LGTM","commit_id":"f75827612f0f27a59fa21dda718704d805faaf63"},{"author":{"_account_id":35016,"name":"Koji Shimizu","email":"shimizu.koji@fujitsu.com","username":"shimizu-koji"},"change_message_id":"bd7ea84f6b07a6863f0515c2d1409aa052d98629","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":30,"id":"623edb8d_1f0d1a4f","updated":"2023-03-13 10:54:28.000000000","message":"recheck, Mar 13 08:50:01.248085 np0033445066 tacker-conductor[23932]: 2023-03-13 08:50:01.246 ERROR tacker.sol_refactored.conductor.conductor_v2 [req-20bdb8a5-0456-4b6f-84e1-3b67fda2158f nfv_user nfv] PROCESSING INSTANTIATE failed: tacker.sol_refactored.common.exceptions.StackOperationFailed: Resource CREATE failed: BadRequest: resources.VDU1_scale_group.resources.5yindseuuf22.resources.VDU1: Port c05b5c3d-cb5f-4326-9da6-ebc20484ddb3 requires a FixedIP in order to be used. (HTTP 400) (Request-ID: req-b8db5d96-74ed-46af-b58c-d7585c4a9407)","commit_id":"f75827612f0f27a59fa21dda718704d805faaf63"}],"releasenotes/notes/support-cnf-pm-threshold-d982ece0ab57506b.yaml":[{"author":{"_account_id":31668,"deleted":true},"change_message_id":"c73af81e192f81dfa85e207a9a84b5cb65620e17","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    Add the Performance Management Threshold interfaces and CLI to support"},{"line_number":5,"context_line":"    AutoScale."},{"line_number":6,"context_line":"    The Performance Management Threshold interfaces are based on ETSI NFV-SOL"},{"line_number":7,"context_line":"    003 v3.3.1, which are Version \"2.0.0\" API of Tacker."},{"line_number":8,"context_line":"    Add the Prometheus Plugin that has a interface between tacker and the"},{"line_number":9,"context_line":"    External Monitoring Tool."},{"line_number":10,"context_line":"    Prometheus Plugin supports data model conversion from Prometheus format"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"fdd210a5_7a59c624","line":7,"updated":"2023-02-22 00:30:41.000000000","message":"I think the following is better.\nwhich are Version \"2.0.0\" API of Tacker.\n-\u003e on which v2 VNF LCM API of Tacker is based.","commit_id":"32aba1ae2780c5c78006909d2d0c15068d28d259"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"764aa5e8339fd7da967e397048cff462c9426d9f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Add the Performance Management Threshold interfaces and CLI to support"},{"line_number":5,"context_line":"    AutoScale."},{"line_number":6,"context_line":"    The Performance Management Threshold interfaces are based on ETSI NFV-SOL"},{"line_number":7,"context_line":"    003 v3.3.1, which are Version \"2.0.0\" API of Tacker."},{"line_number":8,"context_line":"    Add the Prometheus Plugin that has a interface between tacker and the"},{"line_number":9,"context_line":"    External Monitoring Tool."},{"line_number":10,"context_line":"    Prometheus Plugin supports data model conversion from Prometheus format"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"4d3cb198_ece5c5cd","line":7,"in_reply_to":"40bfc921_54d73303","updated":"2023-02-24 02:08:57.000000000","message":"Done","commit_id":"32aba1ae2780c5c78006909d2d0c15068d28d259"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"2cd62639d648f31abacdb149f39c1bb20b962160","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    Add the Performance Management Threshold interfaces and CLI to support"},{"line_number":5,"context_line":"    AutoScale."},{"line_number":6,"context_line":"    The Performance Management Threshold interfaces are based on ETSI NFV-SOL"},{"line_number":7,"context_line":"    003 v3.3.1, which are Version \"2.0.0\" API of Tacker."},{"line_number":8,"context_line":"    Add the Prometheus Plugin that has a interface between tacker and the"},{"line_number":9,"context_line":"    External Monitoring Tool."},{"line_number":10,"context_line":"    Prometheus Plugin supports data model conversion from Prometheus format"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"40bfc921_54d73303","line":7,"in_reply_to":"fdd210a5_7a59c624","updated":"2023-02-22 10:46:40.000000000","message":"I fixed it in Patchset 9.","commit_id":"32aba1ae2780c5c78006909d2d0c15068d28d259"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"c73af81e192f81dfa85e207a9a84b5cb65620e17","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    AutoScale."},{"line_number":6,"context_line":"    The Performance Management Threshold interfaces are based on ETSI NFV-SOL"},{"line_number":7,"context_line":"    003 v3.3.1, which are Version \"2.0.0\" API of Tacker."},{"line_number":8,"context_line":"    Add the Prometheus Plugin that has a interface between tacker and the"},{"line_number":9,"context_line":"    External Monitoring Tool."},{"line_number":10,"context_line":"    Prometheus Plugin supports data model conversion from Prometheus format"},{"line_number":11,"context_line":"    data to SOL based PM Threshold schema, and vice versa."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"f67e128a_aa58ddb3","line":8,"updated":"2023-02-22 00:30:41.000000000","message":"nit: a interface -\u003e an interface","commit_id":"32aba1ae2780c5c78006909d2d0c15068d28d259"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"577205c865a6927e5eacfa575b68f94230ceb40e","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    AutoScale."},{"line_number":6,"context_line":"    The Performance Management Threshold interfaces are based on ETSI NFV-SOL"},{"line_number":7,"context_line":"    003 v3.3.1, which are Version \"2.0.0\" API of Tacker."},{"line_number":8,"context_line":"    Add the Prometheus Plugin that has a interface between tacker and the"},{"line_number":9,"context_line":"    External Monitoring Tool."},{"line_number":10,"context_line":"    Prometheus Plugin supports data model conversion from Prometheus format"},{"line_number":11,"context_line":"    data to SOL based PM Threshold schema, and vice versa."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"501ff1bb_86f79ec6","line":8,"range":{"start_line":8,"start_character":59,"end_line":8,"end_character":65},"updated":"2023-02-22 01:54:27.000000000","message":"nits: tacker -\u003e Tacker","commit_id":"32aba1ae2780c5c78006909d2d0c15068d28d259"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"2cd62639d648f31abacdb149f39c1bb20b962160","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    AutoScale."},{"line_number":6,"context_line":"    The Performance Management Threshold interfaces are based on ETSI NFV-SOL"},{"line_number":7,"context_line":"    003 v3.3.1, which are Version \"2.0.0\" API of Tacker."},{"line_number":8,"context_line":"    Add the Prometheus Plugin that has a interface between tacker and the"},{"line_number":9,"context_line":"    External Monitoring Tool."},{"line_number":10,"context_line":"    Prometheus Plugin supports data model conversion from Prometheus format"},{"line_number":11,"context_line":"    data to SOL based PM Threshold schema, and vice versa."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"dc3cba98_74e93bff","line":8,"range":{"start_line":8,"start_character":59,"end_line":8,"end_character":65},"in_reply_to":"501ff1bb_86f79ec6","updated":"2023-02-22 10:46:40.000000000","message":"I fixed it in Patchset 9.","commit_id":"32aba1ae2780c5c78006909d2d0c15068d28d259"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"764aa5e8339fd7da967e397048cff462c9426d9f","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    AutoScale."},{"line_number":6,"context_line":"    The Performance Management Threshold interfaces are based on ETSI NFV-SOL"},{"line_number":7,"context_line":"    003 v3.3.1, which are Version \"2.0.0\" API of Tacker."},{"line_number":8,"context_line":"    Add the Prometheus Plugin that has a interface between tacker and the"},{"line_number":9,"context_line":"    External Monitoring Tool."},{"line_number":10,"context_line":"    Prometheus Plugin supports data model conversion from Prometheus format"},{"line_number":11,"context_line":"    data to SOL based PM Threshold schema, and vice versa."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"346c1a8b_294de229","line":8,"in_reply_to":"804beadc_30f39575","updated":"2023-02-24 02:08:57.000000000","message":"Done","commit_id":"32aba1ae2780c5c78006909d2d0c15068d28d259"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"4b6e0dd5b7980f359da3335c49ab31c3c2838ee5","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    AutoScale."},{"line_number":6,"context_line":"    The Performance Management Threshold interfaces are based on ETSI NFV-SOL"},{"line_number":7,"context_line":"    003 v3.3.1, which are Version \"2.0.0\" API of Tacker."},{"line_number":8,"context_line":"    Add the Prometheus Plugin that has a interface between tacker and the"},{"line_number":9,"context_line":"    External Monitoring Tool."},{"line_number":10,"context_line":"    Prometheus Plugin supports data model conversion from Prometheus format"},{"line_number":11,"context_line":"    data to SOL based PM Threshold schema, and vice versa."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"676e8765_2d275d2e","line":8,"range":{"start_line":8,"start_character":59,"end_line":8,"end_character":65},"in_reply_to":"dc3cba98_74e93bff","updated":"2023-03-03 07:37:05.000000000","message":"Done","commit_id":"32aba1ae2780c5c78006909d2d0c15068d28d259"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"2cd62639d648f31abacdb149f39c1bb20b962160","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    AutoScale."},{"line_number":6,"context_line":"    The Performance Management Threshold interfaces are based on ETSI NFV-SOL"},{"line_number":7,"context_line":"    003 v3.3.1, which are Version \"2.0.0\" API of Tacker."},{"line_number":8,"context_line":"    Add the Prometheus Plugin that has a interface between tacker and the"},{"line_number":9,"context_line":"    External Monitoring Tool."},{"line_number":10,"context_line":"    Prometheus Plugin supports data model conversion from Prometheus format"},{"line_number":11,"context_line":"    data to SOL based PM Threshold schema, and vice versa."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"804beadc_30f39575","line":8,"in_reply_to":"f67e128a_aa58ddb3","updated":"2023-02-22 10:46:40.000000000","message":"I fixed it in Patchset 9.","commit_id":"32aba1ae2780c5c78006909d2d0c15068d28d259"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"aa7951f8cc6d8430870e4d9df65ee74d638c9c5a","unresolved":true,"context_lines":[{"line_number":9,"context_line":"    External Monitoring Tool."},{"line_number":10,"context_line":"    Prometheus Plugin supports data model conversion from Prometheus format"},{"line_number":11,"context_line":"    data to SOL based PM Threshold schema, and vice versa."},{"line_number":12,"context_line":"    At the same time, a user guide is also made to help users understand the"},{"line_number":13,"context_line":"    function."}],"source_content_type":"text/x-yaml","patch_set":28,"id":"0f21f7f4_894cd326","line":13,"range":{"start_line":12,"start_character":4,"end_line":13,"end_character":13},"updated":"2023-03-10 20:24:11.000000000","message":"It seems no need to say here as an introduce of new feature.","commit_id":"7fead4150349fec4a219f23636c4ee68777035df"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"31e314b9399ded8bbefa5b1165d1003e3ae4fd1e","unresolved":true,"context_lines":[{"line_number":9,"context_line":"    External Monitoring Tool."},{"line_number":10,"context_line":"    Prometheus Plugin supports data model conversion from Prometheus format"},{"line_number":11,"context_line":"    data to SOL based PM Threshold schema, and vice versa."},{"line_number":12,"context_line":"    At the same time, a user guide is also made to help users understand the"},{"line_number":13,"context_line":"    function."}],"source_content_type":"text/x-yaml","patch_set":28,"id":"9ce0dc8b_67ef8e08","line":13,"range":{"start_line":12,"start_character":4,"end_line":13,"end_character":13},"in_reply_to":"0f21f7f4_894cd326","updated":"2023-03-13 06:26:19.000000000","message":"I removed it in patchset 29.","commit_id":"7fead4150349fec4a219f23636c4ee68777035df"}],"tacker/db/migration/alembic_migrations/versions/2531c976c0f1_add_pm_threshold_table.py":[{"author":{"_account_id":31668,"deleted":true},"change_message_id":"c73af81e192f81dfa85e207a9a84b5cb65620e17","unresolved":true,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"def upgrade(active_plugins\u003dNone, options\u003dNone):"},{"line_number":35,"context_line":"    op.create_table(\u0027PmThresholdV2\u0027,"},{"line_number":36,"context_line":"        sa.Column(\u0027id\u0027, sa.String(length\u003d255), nullable\u003dFalse),"},{"line_number":37,"context_line":"        sa.Column(\u0027objectType\u0027, sa.String(length\u003d32), nullable\u003dFalse),"},{"line_number":38,"context_line":"        sa.Column(\u0027objectInstanceId\u0027, sa.String(length\u003d255), nullable\u003dFalse),"}],"source_content_type":"text/x-python","patch_set":8,"id":"8543519b_e17beda7","line":35,"updated":"2023-02-22 00:30:41.000000000","message":"The table names used in the v2 API match the SOL descriptions.\nCould you change it to \"ThresholdV2\"?\n\"ThresholdV2\" is also described in the Spec.\nhttps://specs.openstack.org/openstack/tacker-specs/specs/2023.1/support-threshold-pm-interface.html","commit_id":"32aba1ae2780c5c78006909d2d0c15068d28d259"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"764aa5e8339fd7da967e397048cff462c9426d9f","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"def upgrade(active_plugins\u003dNone, options\u003dNone):"},{"line_number":35,"context_line":"    op.create_table(\u0027PmThresholdV2\u0027,"},{"line_number":36,"context_line":"        sa.Column(\u0027id\u0027, sa.String(length\u003d255), nullable\u003dFalse),"},{"line_number":37,"context_line":"        sa.Column(\u0027objectType\u0027, sa.String(length\u003d32), nullable\u003dFalse),"},{"line_number":38,"context_line":"        sa.Column(\u0027objectInstanceId\u0027, sa.String(length\u003d255), nullable\u003dFalse),"}],"source_content_type":"text/x-python","patch_set":8,"id":"2c4d2b25_f9bcfe68","line":35,"in_reply_to":"248e366d_42537324","updated":"2023-02-24 02:08:57.000000000","message":"Done","commit_id":"32aba1ae2780c5c78006909d2d0c15068d28d259"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"2cd62639d648f31abacdb149f39c1bb20b962160","unresolved":true,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"def upgrade(active_plugins\u003dNone, options\u003dNone):"},{"line_number":35,"context_line":"    op.create_table(\u0027PmThresholdV2\u0027,"},{"line_number":36,"context_line":"        sa.Column(\u0027id\u0027, sa.String(length\u003d255), nullable\u003dFalse),"},{"line_number":37,"context_line":"        sa.Column(\u0027objectType\u0027, sa.String(length\u003d32), nullable\u003dFalse),"},{"line_number":38,"context_line":"        sa.Column(\u0027objectInstanceId\u0027, sa.String(length\u003d255), nullable\u003dFalse),"}],"source_content_type":"text/x-python","patch_set":8,"id":"248e366d_42537324","line":35,"in_reply_to":"8543519b_e17beda7","updated":"2023-02-22 10:46:40.000000000","message":"I changed it to `ThresholdV2` in Patchset 9.","commit_id":"32aba1ae2780c5c78006909d2d0c15068d28d259"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"577205c865a6927e5eacfa575b68f94230ceb40e","unresolved":true,"context_lines":[{"line_number":51,"context_line":"        sa.Column(\u0027objectInstanceId\u0027, sa.String(length\u003d255), nullable\u003dFalse),"},{"line_number":52,"context_line":"        sa.Column(\u0027subObjectInstanceId\u0027, sa.String(length\u003d255),"},{"line_number":53,"context_line":"                  nullable\u003dTrue),"},{"line_number":54,"context_line":"        sa.Column(\u0027performanceValue\u0027, sa.String(length\u003d255), nullable\u003dTrue),"},{"line_number":55,"context_line":"        sa.PrimaryKeyConstraint(\u0027id\u0027),"},{"line_number":56,"context_line":"        mysql_engine\u003d\u0027InnoDB\u0027"},{"line_number":57,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a567e5c_8da8e833","line":54,"range":{"start_line":54,"start_character":61,"end_line":54,"end_character":74},"updated":"2023-02-22 01:54:27.000000000","message":"The cardinality of \"performanceValue\" is `1` by referring to ETSI NFV-SOL 003 v3.3.1[1], so I think `nullable\u003dFalse` is right.\nWhat do you think?\n\n[1]https://www.etsi.org/deliver/etsi_gs/NFV-SOL/001_099/003/03.03.01_60/gs_nfv-sol003v030301p.pdf","commit_id":"32aba1ae2780c5c78006909d2d0c15068d28d259"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"4b6e0dd5b7980f359da3335c49ab31c3c2838ee5","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        sa.Column(\u0027objectInstanceId\u0027, sa.String(length\u003d255), nullable\u003dFalse),"},{"line_number":52,"context_line":"        sa.Column(\u0027subObjectInstanceId\u0027, sa.String(length\u003d255),"},{"line_number":53,"context_line":"                  nullable\u003dTrue),"},{"line_number":54,"context_line":"        sa.Column(\u0027performanceValue\u0027, sa.String(length\u003d255), nullable\u003dTrue),"},{"line_number":55,"context_line":"        sa.PrimaryKeyConstraint(\u0027id\u0027),"},{"line_number":56,"context_line":"        mysql_engine\u003d\u0027InnoDB\u0027"},{"line_number":57,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":8,"id":"17de1555_762d70cc","line":54,"range":{"start_line":54,"start_character":61,"end_line":54,"end_character":74},"in_reply_to":"44938efb_53070a5d","updated":"2023-03-03 07:37:05.000000000","message":"Done","commit_id":"32aba1ae2780c5c78006909d2d0c15068d28d259"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"2cd62639d648f31abacdb149f39c1bb20b962160","unresolved":true,"context_lines":[{"line_number":51,"context_line":"        sa.Column(\u0027objectInstanceId\u0027, sa.String(length\u003d255), nullable\u003dFalse),"},{"line_number":52,"context_line":"        sa.Column(\u0027subObjectInstanceId\u0027, sa.String(length\u003d255),"},{"line_number":53,"context_line":"                  nullable\u003dTrue),"},{"line_number":54,"context_line":"        sa.Column(\u0027performanceValue\u0027, sa.String(length\u003d255), nullable\u003dTrue),"},{"line_number":55,"context_line":"        sa.PrimaryKeyConstraint(\u0027id\u0027),"},{"line_number":56,"context_line":"        mysql_engine\u003d\u0027InnoDB\u0027"},{"line_number":57,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":8,"id":"44938efb_53070a5d","line":54,"range":{"start_line":54,"start_character":61,"end_line":54,"end_character":74},"in_reply_to":"5a567e5c_8da8e833","updated":"2023-02-22 10:46:40.000000000","message":"I changed it to `nullable\u003dFalse` in Patchset 9.","commit_id":"32aba1ae2780c5c78006909d2d0c15068d28d259"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"4b6e0dd5b7980f359da3335c49ab31c3c2838ee5","unresolved":true,"context_lines":[{"line_number":44,"context_line":"        sa.PrimaryKeyConstraint(\u0027id\u0027),"},{"line_number":45,"context_line":"        mysql_engine\u003d\u0027InnoDB\u0027"},{"line_number":46,"context_line":"    )"},{"line_number":47,"context_line":"    op.create_table(\u0027ThresholdStateV2\u0027,"},{"line_number":48,"context_line":"        sa.Column(\u0027id\u0027, sa.String(length\u003d255), nullable\u003dFalse),"},{"line_number":49,"context_line":"        sa.Column(\u0027thresholdId\u0027, sa.String(length\u003d255), nullable\u003dFalse),"},{"line_number":50,"context_line":"        sa.Column(\u0027objectType\u0027, sa.String(length\u003d32), nullable\u003dFalse),"}],"source_content_type":"text/x-python","patch_set":21,"id":"e8e37d4b_70e9bdba","line":47,"updated":"2023-03-03 07:37:05.000000000","message":"`Threshold` data model is defined in ETSI-NFV SOL003 v3.3.1[1],\nbut `ThresholdState` is not defined, so this implementation policy\nis not based on standard specifications.\nTherefore, please reimplementation these function based `ThresholdV2` table only.\nSorry for the short period,, could you try it?\n\n[1] https://www.etsi.org/deliver/etsi_gs/NFV-SOL/001_099/003/03.03.01_60/gs_nfv-sol003v030301p.pdf","commit_id":"bf609a878a67444cf7865650c5321badb9aa1cad"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"4452ce72041c8be511f16c4e9b26c700e7a63030","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        sa.PrimaryKeyConstraint(\u0027id\u0027),"},{"line_number":45,"context_line":"        mysql_engine\u003d\u0027InnoDB\u0027"},{"line_number":46,"context_line":"    )"},{"line_number":47,"context_line":"    op.create_table(\u0027ThresholdStateV2\u0027,"},{"line_number":48,"context_line":"        sa.Column(\u0027id\u0027, sa.String(length\u003d255), nullable\u003dFalse),"},{"line_number":49,"context_line":"        sa.Column(\u0027thresholdId\u0027, sa.String(length\u003d255), nullable\u003dFalse),"},{"line_number":50,"context_line":"        sa.Column(\u0027objectType\u0027, sa.String(length\u003d32), nullable\u003dFalse),"}],"source_content_type":"text/x-python","patch_set":21,"id":"a3d0af60_c87ae229","line":47,"in_reply_to":"1b41249c_51ab7fa9","updated":"2023-03-07 06:48:02.000000000","message":"Thanks for your great re-work.\nThe new impementation is based on `Threshold` data model (Table) defined in ETSI-NFV SOL003 v3.3.1.\nDone.","commit_id":"bf609a878a67444cf7865650c5321badb9aa1cad"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"9df219dafe8e4275c867fdd758eca5ce9f4a6b91","unresolved":true,"context_lines":[{"line_number":44,"context_line":"        sa.PrimaryKeyConstraint(\u0027id\u0027),"},{"line_number":45,"context_line":"        mysql_engine\u003d\u0027InnoDB\u0027"},{"line_number":46,"context_line":"    )"},{"line_number":47,"context_line":"    op.create_table(\u0027ThresholdStateV2\u0027,"},{"line_number":48,"context_line":"        sa.Column(\u0027id\u0027, sa.String(length\u003d255), nullable\u003dFalse),"},{"line_number":49,"context_line":"        sa.Column(\u0027thresholdId\u0027, sa.String(length\u003d255), nullable\u003dFalse),"},{"line_number":50,"context_line":"        sa.Column(\u0027objectType\u0027, sa.String(length\u003d32), nullable\u003dFalse),"}],"source_content_type":"text/x-python","patch_set":21,"id":"1b41249c_51ab7fa9","line":47,"in_reply_to":"b5c01931_744c6ea8","updated":"2023-03-06 00:15:54.000000000","message":"Thanks for your cooperation.\nIf any trobles, please share to Tacker teams.\n\n*fix my previous comment: please reimplementation -\u003e please reimplement","commit_id":"bf609a878a67444cf7865650c5321badb9aa1cad"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"c67d390b8f14955da4fb8ffc0ae5811fde38d066","unresolved":true,"context_lines":[{"line_number":44,"context_line":"        sa.PrimaryKeyConstraint(\u0027id\u0027),"},{"line_number":45,"context_line":"        mysql_engine\u003d\u0027InnoDB\u0027"},{"line_number":46,"context_line":"    )"},{"line_number":47,"context_line":"    op.create_table(\u0027ThresholdStateV2\u0027,"},{"line_number":48,"context_line":"        sa.Column(\u0027id\u0027, sa.String(length\u003d255), nullable\u003dFalse),"},{"line_number":49,"context_line":"        sa.Column(\u0027thresholdId\u0027, sa.String(length\u003d255), nullable\u003dFalse),"},{"line_number":50,"context_line":"        sa.Column(\u0027objectType\u0027, sa.String(length\u003d32), nullable\u003dFalse),"}],"source_content_type":"text/x-python","patch_set":21,"id":"b5c01931_744c6ea8","line":47,"in_reply_to":"e8e37d4b_70e9bdba","updated":"2023-03-03 09:00:46.000000000","message":"Ok, I will revise it as soon as possible, and then submit it.","commit_id":"bf609a878a67444cf7865650c5321badb9aa1cad"}],"tacker/sol_refactored/api/policies/vnfpm_v2.py":[{"author":{"_account_id":31668,"deleted":true},"change_message_id":"2bed95f895abe6c12974e1bc996e2dd295eee2ec","unresolved":true,"context_lines":[{"line_number":133,"context_line":"    policy.DocumentedRuleDefault(\r"},{"line_number":134,"context_line":"        name\u003dPOLICY_NAME.format(\u0027create_threshold\u0027),\r"},{"line_number":135,"context_line":"        check_str\u003dRULE_ANY,\r"},{"line_number":136,"context_line":"        description\u003d\"Create a threshold.\",\r"},{"line_number":137,"context_line":"        operations\u003d[\r"},{"line_number":138,"context_line":"            {\r"},{"line_number":139,"context_line":"                \u0027method\u0027: \u0027POST\u0027,\r"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a4e4edb_2016643d","line":136,"updated":"2023-02-22 10:12:21.000000000","message":"nit: threshold -\u003e PM threshold","commit_id":"32aba1ae2780c5c78006909d2d0c15068d28d259"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"b73fe49253c115861f045aa7929bf13485a296fb","unresolved":true,"context_lines":[{"line_number":133,"context_line":"    policy.DocumentedRuleDefault(\r"},{"line_number":134,"context_line":"        name\u003dPOLICY_NAME.format(\u0027create_threshold\u0027),\r"},{"line_number":135,"context_line":"        check_str\u003dRULE_ANY,\r"},{"line_number":136,"context_line":"        description\u003d\"Create a threshold.\",\r"},{"line_number":137,"context_line":"        operations\u003d[\r"},{"line_number":138,"context_line":"            {\r"},{"line_number":139,"context_line":"                \u0027method\u0027: \u0027POST\u0027,\r"}],"source_content_type":"text/x-python","patch_set":8,"id":"7ac95608_8d60a012","line":136,"in_reply_to":"5a4e4edb_2016643d","updated":"2023-02-23 06:27:50.000000000","message":"I fixed it in Patchset 11.","commit_id":"32aba1ae2780c5c78006909d2d0c15068d28d259"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"764aa5e8339fd7da967e397048cff462c9426d9f","unresolved":false,"context_lines":[{"line_number":133,"context_line":"    policy.DocumentedRuleDefault(\r"},{"line_number":134,"context_line":"        name\u003dPOLICY_NAME.format(\u0027create_threshold\u0027),\r"},{"line_number":135,"context_line":"        check_str\u003dRULE_ANY,\r"},{"line_number":136,"context_line":"        description\u003d\"Create a threshold.\",\r"},{"line_number":137,"context_line":"        operations\u003d[\r"},{"line_number":138,"context_line":"            {\r"},{"line_number":139,"context_line":"                \u0027method\u0027: \u0027POST\u0027,\r"}],"source_content_type":"text/x-python","patch_set":8,"id":"b68c3b10_90a747ca","line":136,"in_reply_to":"7ac95608_8d60a012","updated":"2023-02-24 02:08:57.000000000","message":"Done","commit_id":"32aba1ae2780c5c78006909d2d0c15068d28d259"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"2bed95f895abe6c12974e1bc996e2dd295eee2ec","unresolved":true,"context_lines":[{"line_number":144,"context_line":"    policy.DocumentedRuleDefault(\r"},{"line_number":145,"context_line":"        name\u003dPOLICY_NAME.format(\u0027index_threshold\u0027),\r"},{"line_number":146,"context_line":"        check_str\u003dRULE_ANY,\r"},{"line_number":147,"context_line":"        description\u003d\"Query thresholds.\",\r"},{"line_number":148,"context_line":"        operations\u003d[\r"},{"line_number":149,"context_line":"            {\r"},{"line_number":150,"context_line":"                \u0027method\u0027: \u0027GET\u0027,\r"}],"source_content_type":"text/x-python","patch_set":8,"id":"67972714_3f783c44","line":147,"updated":"2023-02-22 10:12:21.000000000","message":"nit: thresholds -\u003e PM thresholds","commit_id":"32aba1ae2780c5c78006909d2d0c15068d28d259"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"b73fe49253c115861f045aa7929bf13485a296fb","unresolved":true,"context_lines":[{"line_number":144,"context_line":"    policy.DocumentedRuleDefault(\r"},{"line_number":145,"context_line":"        name\u003dPOLICY_NAME.format(\u0027index_threshold\u0027),\r"},{"line_number":146,"context_line":"        check_str\u003dRULE_ANY,\r"},{"line_number":147,"context_line":"        description\u003d\"Query thresholds.\",\r"},{"line_number":148,"context_line":"        operations\u003d[\r"},{"line_number":149,"context_line":"            {\r"},{"line_number":150,"context_line":"                \u0027method\u0027: \u0027GET\u0027,\r"}],"source_content_type":"text/x-python","patch_set":8,"id":"b4b06d14_5075e8c1","line":147,"in_reply_to":"67972714_3f783c44","updated":"2023-02-23 06:27:50.000000000","message":"I fixed it in Patchset 11.","commit_id":"32aba1ae2780c5c78006909d2d0c15068d28d259"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"764aa5e8339fd7da967e397048cff462c9426d9f","unresolved":false,"context_lines":[{"line_number":144,"context_line":"    policy.DocumentedRuleDefault(\r"},{"line_number":145,"context_line":"        name\u003dPOLICY_NAME.format(\u0027index_threshold\u0027),\r"},{"line_number":146,"context_line":"        check_str\u003dRULE_ANY,\r"},{"line_number":147,"context_line":"        description\u003d\"Query thresholds.\",\r"},{"line_number":148,"context_line":"        operations\u003d[\r"},{"line_number":149,"context_line":"            {\r"},{"line_number":150,"context_line":"                \u0027method\u0027: \u0027GET\u0027,\r"}],"source_content_type":"text/x-python","patch_set":8,"id":"4addfcbc_38210969","line":147,"in_reply_to":"b4b06d14_5075e8c1","updated":"2023-02-24 02:08:57.000000000","message":"Done","commit_id":"32aba1ae2780c5c78006909d2d0c15068d28d259"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"2bed95f895abe6c12974e1bc996e2dd295eee2ec","unresolved":true,"context_lines":[{"line_number":155,"context_line":"    policy.DocumentedRuleDefault(\r"},{"line_number":156,"context_line":"        name\u003dPOLICY_NAME.format(\u0027show_threshold\u0027),\r"},{"line_number":157,"context_line":"        check_str\u003dRULE_ANY,\r"},{"line_number":158,"context_line":"        description\u003d\"Read a single threshold.\",\r"},{"line_number":159,"context_line":"        operations\u003d[\r"},{"line_number":160,"context_line":"            {\r"},{"line_number":161,"context_line":"                \u0027method\u0027: \u0027GET\u0027,\r"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f4fee67_b673770a","line":158,"updated":"2023-02-22 10:12:21.000000000","message":"The following is better, consistent with the descriptions in L.71 and L.95.\n\"Get an individual PM threshold.\"","commit_id":"32aba1ae2780c5c78006909d2d0c15068d28d259"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"822e7028d5cf349c417f0ff6235675aeff7ec225","unresolved":false,"context_lines":[{"line_number":155,"context_line":"    policy.DocumentedRuleDefault(\r"},{"line_number":156,"context_line":"        name\u003dPOLICY_NAME.format(\u0027show_threshold\u0027),\r"},{"line_number":157,"context_line":"        check_str\u003dRULE_ANY,\r"},{"line_number":158,"context_line":"        description\u003d\"Read a single threshold.\",\r"},{"line_number":159,"context_line":"        operations\u003d[\r"},{"line_number":160,"context_line":"            {\r"},{"line_number":161,"context_line":"                \u0027method\u0027: \u0027GET\u0027,\r"}],"source_content_type":"text/x-python","patch_set":8,"id":"c90b1e59_3d150cd1","line":158,"in_reply_to":"33a3e7d5_42c67420","updated":"2023-03-02 02:07:27.000000000","message":"Done","commit_id":"32aba1ae2780c5c78006909d2d0c15068d28d259"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"b73fe49253c115861f045aa7929bf13485a296fb","unresolved":true,"context_lines":[{"line_number":155,"context_line":"    policy.DocumentedRuleDefault(\r"},{"line_number":156,"context_line":"        name\u003dPOLICY_NAME.format(\u0027show_threshold\u0027),\r"},{"line_number":157,"context_line":"        check_str\u003dRULE_ANY,\r"},{"line_number":158,"context_line":"        description\u003d\"Read a single threshold.\",\r"},{"line_number":159,"context_line":"        operations\u003d[\r"},{"line_number":160,"context_line":"            {\r"},{"line_number":161,"context_line":"                \u0027method\u0027: \u0027GET\u0027,\r"}],"source_content_type":"text/x-python","patch_set":8,"id":"a624873e_0a659196","line":158,"in_reply_to":"3f4fee67_b673770a","updated":"2023-02-23 06:27:50.000000000","message":"I fixed it in Patchset 11.","commit_id":"32aba1ae2780c5c78006909d2d0c15068d28d259"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"c56b8094a8756046679a7b80d91fec8419ff92fe","unresolved":true,"context_lines":[{"line_number":155,"context_line":"    policy.DocumentedRuleDefault(\r"},{"line_number":156,"context_line":"        name\u003dPOLICY_NAME.format(\u0027show_threshold\u0027),\r"},{"line_number":157,"context_line":"        check_str\u003dRULE_ANY,\r"},{"line_number":158,"context_line":"        description\u003d\"Read a single threshold.\",\r"},{"line_number":159,"context_line":"        operations\u003d[\r"},{"line_number":160,"context_line":"            {\r"},{"line_number":161,"context_line":"                \u0027method\u0027: \u0027GET\u0027,\r"}],"source_content_type":"text/x-python","patch_set":8,"id":"33a3e7d5_42c67420","line":158,"in_reply_to":"70958e65_7f27128c","updated":"2023-02-24 05:51:35.000000000","message":"Sorry, I missed `PM` and fixed it in Patchset 12.","commit_id":"32aba1ae2780c5c78006909d2d0c15068d28d259"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"764aa5e8339fd7da967e397048cff462c9426d9f","unresolved":true,"context_lines":[{"line_number":155,"context_line":"    policy.DocumentedRuleDefault(\r"},{"line_number":156,"context_line":"        name\u003dPOLICY_NAME.format(\u0027show_threshold\u0027),\r"},{"line_number":157,"context_line":"        check_str\u003dRULE_ANY,\r"},{"line_number":158,"context_line":"        description\u003d\"Read a single threshold.\",\r"},{"line_number":159,"context_line":"        operations\u003d[\r"},{"line_number":160,"context_line":"            {\r"},{"line_number":161,"context_line":"                \u0027method\u0027: \u0027GET\u0027,\r"}],"source_content_type":"text/x-python","patch_set":8,"id":"70958e65_7f27128c","line":158,"in_reply_to":"a624873e_0a659196","updated":"2023-02-24 02:08:57.000000000","message":"nit: threshold -\u003e PM threshold","commit_id":"32aba1ae2780c5c78006909d2d0c15068d28d259"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"2bed95f895abe6c12974e1bc996e2dd295eee2ec","unresolved":true,"context_lines":[{"line_number":166,"context_line":"    policy.DocumentedRuleDefault(\r"},{"line_number":167,"context_line":"        name\u003dPOLICY_NAME.format(\u0027update_threshold\u0027),\r"},{"line_number":168,"context_line":"        check_str\u003dRULE_ANY,\r"},{"line_number":169,"context_line":"        description\u003d\"Update threshold callback.\",\r"},{"line_number":170,"context_line":"        operations\u003d[\r"},{"line_number":171,"context_line":"            {\r"},{"line_number":172,"context_line":"                \u0027method\u0027: \u0027PATCH\u0027,\r"}],"source_content_type":"text/x-python","patch_set":8,"id":"a365365e_c76af5a8","line":169,"updated":"2023-02-22 10:12:21.000000000","message":"The following is better, consistent with the descriptions in L.60.\n\"Update a PM threshold callback.\"","commit_id":"32aba1ae2780c5c78006909d2d0c15068d28d259"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"764aa5e8339fd7da967e397048cff462c9426d9f","unresolved":false,"context_lines":[{"line_number":166,"context_line":"    policy.DocumentedRuleDefault(\r"},{"line_number":167,"context_line":"        name\u003dPOLICY_NAME.format(\u0027update_threshold\u0027),\r"},{"line_number":168,"context_line":"        check_str\u003dRULE_ANY,\r"},{"line_number":169,"context_line":"        description\u003d\"Update threshold callback.\",\r"},{"line_number":170,"context_line":"        operations\u003d[\r"},{"line_number":171,"context_line":"            {\r"},{"line_number":172,"context_line":"                \u0027method\u0027: \u0027PATCH\u0027,\r"}],"source_content_type":"text/x-python","patch_set":8,"id":"3ba3986b_14b093e3","line":169,"in_reply_to":"1bea598f_ef25bb69","updated":"2023-02-24 02:08:57.000000000","message":"Done","commit_id":"32aba1ae2780c5c78006909d2d0c15068d28d259"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"b73fe49253c115861f045aa7929bf13485a296fb","unresolved":true,"context_lines":[{"line_number":166,"context_line":"    policy.DocumentedRuleDefault(\r"},{"line_number":167,"context_line":"        name\u003dPOLICY_NAME.format(\u0027update_threshold\u0027),\r"},{"line_number":168,"context_line":"        check_str\u003dRULE_ANY,\r"},{"line_number":169,"context_line":"        description\u003d\"Update threshold callback.\",\r"},{"line_number":170,"context_line":"        operations\u003d[\r"},{"line_number":171,"context_line":"            {\r"},{"line_number":172,"context_line":"                \u0027method\u0027: \u0027PATCH\u0027,\r"}],"source_content_type":"text/x-python","patch_set":8,"id":"1bea598f_ef25bb69","line":169,"in_reply_to":"a365365e_c76af5a8","updated":"2023-02-23 06:27:50.000000000","message":"I fixed it in Patchset 11.","commit_id":"32aba1ae2780c5c78006909d2d0c15068d28d259"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"2bed95f895abe6c12974e1bc996e2dd295eee2ec","unresolved":true,"context_lines":[{"line_number":177,"context_line":"    policy.DocumentedRuleDefault(\r"},{"line_number":178,"context_line":"        name\u003dPOLICY_NAME.format(\u0027delete_threshold\u0027),\r"},{"line_number":179,"context_line":"        check_str\u003dRULE_ANY,\r"},{"line_number":180,"context_line":"        description\u003d\"Delete a threshold.\",\r"},{"line_number":181,"context_line":"        operations\u003d[\r"},{"line_number":182,"context_line":"            {\r"},{"line_number":183,"context_line":"                \u0027method\u0027: \u0027DELETE\u0027,\r"}],"source_content_type":"text/x-python","patch_set":8,"id":"6d1315da_8aacea9c","line":180,"updated":"2023-02-22 10:12:21.000000000","message":"nit: threshold -\u003e PM threshold","commit_id":"32aba1ae2780c5c78006909d2d0c15068d28d259"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"b73fe49253c115861f045aa7929bf13485a296fb","unresolved":true,"context_lines":[{"line_number":177,"context_line":"    policy.DocumentedRuleDefault(\r"},{"line_number":178,"context_line":"        name\u003dPOLICY_NAME.format(\u0027delete_threshold\u0027),\r"},{"line_number":179,"context_line":"        check_str\u003dRULE_ANY,\r"},{"line_number":180,"context_line":"        description\u003d\"Delete a threshold.\",\r"},{"line_number":181,"context_line":"        operations\u003d[\r"},{"line_number":182,"context_line":"            {\r"},{"line_number":183,"context_line":"                \u0027method\u0027: \u0027DELETE\u0027,\r"}],"source_content_type":"text/x-python","patch_set":8,"id":"d04459f3_bd1f2d85","line":180,"in_reply_to":"6d1315da_8aacea9c","updated":"2023-02-23 06:27:50.000000000","message":"I fixed it in Patchset 11.","commit_id":"32aba1ae2780c5c78006909d2d0c15068d28d259"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"764aa5e8339fd7da967e397048cff462c9426d9f","unresolved":false,"context_lines":[{"line_number":177,"context_line":"    policy.DocumentedRuleDefault(\r"},{"line_number":178,"context_line":"        name\u003dPOLICY_NAME.format(\u0027delete_threshold\u0027),\r"},{"line_number":179,"context_line":"        check_str\u003dRULE_ANY,\r"},{"line_number":180,"context_line":"        description\u003d\"Delete a threshold.\",\r"},{"line_number":181,"context_line":"        operations\u003d[\r"},{"line_number":182,"context_line":"            {\r"},{"line_number":183,"context_line":"                \u0027method\u0027: \u0027DELETE\u0027,\r"}],"source_content_type":"text/x-python","patch_set":8,"id":"a2e7e5db_86096f35","line":180,"in_reply_to":"d04459f3_bd1f2d85","updated":"2023-02-24 02:08:57.000000000","message":"Done","commit_id":"32aba1ae2780c5c78006909d2d0c15068d28d259"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"2bed95f895abe6c12974e1bc996e2dd295eee2ec","unresolved":true,"context_lines":[{"line_number":189,"context_line":"        name\u003dPOLICY_NAME_PROM_PLUGIN.format(\u0027pm_threshold\u0027),\r"},{"line_number":190,"context_line":"        check_str\u003dRULE_ANY,\r"},{"line_number":191,"context_line":"        description\u003d\"Receive the PM threshold sent from \"\r"},{"line_number":192,"context_line":"                    \"External Monitoring Tool\",\r"},{"line_number":193,"context_line":"        operations\u003d[\r"},{"line_number":194,"context_line":"            {\r"},{"line_number":195,"context_line":"                \u0027method\u0027: \u0027POST\u0027,\r"}],"source_content_type":"text/x-python","patch_set":8,"id":"de154c43_d5e3d9dd","line":192,"updated":"2023-02-22 10:12:21.000000000","message":"nit: Tool -\u003e Tool.","commit_id":"32aba1ae2780c5c78006909d2d0c15068d28d259"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"764aa5e8339fd7da967e397048cff462c9426d9f","unresolved":false,"context_lines":[{"line_number":189,"context_line":"        name\u003dPOLICY_NAME_PROM_PLUGIN.format(\u0027pm_threshold\u0027),\r"},{"line_number":190,"context_line":"        check_str\u003dRULE_ANY,\r"},{"line_number":191,"context_line":"        description\u003d\"Receive the PM threshold sent from \"\r"},{"line_number":192,"context_line":"                    \"External Monitoring Tool\",\r"},{"line_number":193,"context_line":"        operations\u003d[\r"},{"line_number":194,"context_line":"            {\r"},{"line_number":195,"context_line":"                \u0027method\u0027: \u0027POST\u0027,\r"}],"source_content_type":"text/x-python","patch_set":8,"id":"8e42f08c_2322ec1a","line":192,"in_reply_to":"8d28adb9_d8fb7487","updated":"2023-02-24 02:08:57.000000000","message":"Done","commit_id":"32aba1ae2780c5c78006909d2d0c15068d28d259"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"b73fe49253c115861f045aa7929bf13485a296fb","unresolved":true,"context_lines":[{"line_number":189,"context_line":"        name\u003dPOLICY_NAME_PROM_PLUGIN.format(\u0027pm_threshold\u0027),\r"},{"line_number":190,"context_line":"        check_str\u003dRULE_ANY,\r"},{"line_number":191,"context_line":"        description\u003d\"Receive the PM threshold sent from \"\r"},{"line_number":192,"context_line":"                    \"External Monitoring Tool\",\r"},{"line_number":193,"context_line":"        operations\u003d[\r"},{"line_number":194,"context_line":"            {\r"},{"line_number":195,"context_line":"                \u0027method\u0027: \u0027POST\u0027,\r"}],"source_content_type":"text/x-python","patch_set":8,"id":"8d28adb9_d8fb7487","line":192,"in_reply_to":"de154c43_d5e3d9dd","updated":"2023-02-23 06:27:50.000000000","message":"I fixed it in Patchset 11.","commit_id":"32aba1ae2780c5c78006909d2d0c15068d28d259"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"aa7951f8cc6d8430870e4d9df65ee74d638c9c5a","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2022 Fujitsu\r"},{"line_number":2,"context_line":"# All Rights Reserved.\r"},{"line_number":3,"context_line":"#\r"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may\r"}],"source_content_type":"text/x-python","patch_set":22,"id":"d205b7e2_5b9a4a50","side":"PARENT","line":1,"updated":"2023-03-10 20:24:11.000000000","message":"Could I confirm why so many lines not changed are colored here?","commit_id":"5d1b463ac5c69baf10073bbb1cb7e377073b7673"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"31e314b9399ded8bbefa5b1165d1003e3ae4fd1e","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2022 Fujitsu\r"},{"line_number":2,"context_line":"# All Rights Reserved.\r"},{"line_number":3,"context_line":"#\r"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may\r"}],"source_content_type":"text/x-python","patch_set":22,"id":"54282d5f_efb84293","side":"PARENT","line":1,"in_reply_to":"d205b7e2_5b9a4a50","updated":"2023-03-13 06:26:19.000000000","message":"Line breaks were `CRLF` before patch 19, and have been replaced by `LF` since version 20.","commit_id":"5d1b463ac5c69baf10073bbb1cb7e377073b7673"}],"tacker/sol_refactored/common/common_script_utils.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"aa7951f8cc6d8430870e4d9df65ee74d638c9c5a","unresolved":true,"context_lines":[{"line_number":304,"context_line":"        auth \u003d objects.SubscriptionAuthentication("},{"line_number":305,"context_line":"            authType\u003dauth_req[\u0027authType\u0027]"},{"line_number":306,"context_line":"        )"},{"line_number":307,"context_line":"        if \u0027OAUTH2_CLIENT_CERT\u0027 in auth.authType:"},{"line_number":308,"context_line":"            param \u003d obj_data.authentication.paramsOauth2ClientCert"},{"line_number":309,"context_line":"            ca_cert \u003d CONF.v2_vnfm.notification_mtls_ca_cert_file"},{"line_number":310,"context_line":"            client_cert \u003d CONF.v2_vnfm.notification_mtls_client_cert_file"}],"source_content_type":"text/x-python","patch_set":28,"id":"3775b01e_62316650","line":307,"range":{"start_line":307,"start_character":12,"end_line":307,"end_character":30},"updated":"2023-03-10 20:24:11.000000000","message":"Why don\u0027t you make auth types as a variable as notify types?","commit_id":"7fead4150349fec4a219f23636c4ee68777035df"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"31e314b9399ded8bbefa5b1165d1003e3ae4fd1e","unresolved":true,"context_lines":[{"line_number":304,"context_line":"        auth \u003d objects.SubscriptionAuthentication("},{"line_number":305,"context_line":"            authType\u003dauth_req[\u0027authType\u0027]"},{"line_number":306,"context_line":"        )"},{"line_number":307,"context_line":"        if \u0027OAUTH2_CLIENT_CERT\u0027 in auth.authType:"},{"line_number":308,"context_line":"            param \u003d obj_data.authentication.paramsOauth2ClientCert"},{"line_number":309,"context_line":"            ca_cert \u003d CONF.v2_vnfm.notification_mtls_ca_cert_file"},{"line_number":310,"context_line":"            client_cert \u003d CONF.v2_vnfm.notification_mtls_client_cert_file"}],"source_content_type":"text/x-python","patch_set":28,"id":"dc020088_26783c65","line":307,"range":{"start_line":307,"start_character":12,"end_line":307,"end_character":30},"in_reply_to":"3775b01e_62316650","updated":"2023-03-13 06:26:19.000000000","message":"I created variables of auth types.","commit_id":"7fead4150349fec4a219f23636c4ee68777035df"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"aa7951f8cc6d8430870e4d9df65ee74d638c9c5a","unresolved":true,"context_lines":[{"line_number":371,"context_line":"            url, \"POST\", expected_status\u003d[204], body\u003dnotif_data)"},{"line_number":372,"context_line":"    except sol_ex.SolException:"},{"line_number":373,"context_line":"        # it may occur if test_notification was not executed."},{"line_number":374,"context_line":"        LOG.exception(\"send_notification failed\")"},{"line_number":375,"context_line":""},{"line_number":376,"context_line":"    if resp.status_code !\u003d 204:"},{"line_number":377,"context_line":"        LOG.error(\"send_notification failed: %d\" % resp.status_code)"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"def test_notification(obj_data, notify_type\u003dNone):"}],"source_content_type":"text/x-python","patch_set":28,"id":"b7e38015_24df3452","line":377,"range":{"start_line":374,"start_character":0,"end_line":377,"end_character":68},"updated":"2023-03-10 20:24:11.000000000","message":"Why don\u0027t you describe something more, or useless for a maintainer.","commit_id":"7fead4150349fec4a219f23636c4ee68777035df"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"31e314b9399ded8bbefa5b1165d1003e3ae4fd1e","unresolved":true,"context_lines":[{"line_number":371,"context_line":"            url, \"POST\", expected_status\u003d[204], body\u003dnotif_data)"},{"line_number":372,"context_line":"    except sol_ex.SolException:"},{"line_number":373,"context_line":"        # it may occur if test_notification was not executed."},{"line_number":374,"context_line":"        LOG.exception(\"send_notification failed\")"},{"line_number":375,"context_line":""},{"line_number":376,"context_line":"    if resp.status_code !\u003d 204:"},{"line_number":377,"context_line":"        LOG.error(\"send_notification failed: %d\" % resp.status_code)"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"def test_notification(obj_data, notify_type\u003dNone):"}],"source_content_type":"text/x-python","patch_set":28,"id":"6f13e5ec_f9323ae9","line":377,"range":{"start_line":374,"start_character":0,"end_line":377,"end_character":68},"in_reply_to":"b7e38015_24df3452","updated":"2023-03-13 06:26:19.000000000","message":"I output the response and exception in the log.","commit_id":"7fead4150349fec4a219f23636c4ee68777035df"}],"tacker/sol_refactored/common/config.py":[{"author":{"_account_id":31668,"deleted":true},"change_message_id":"a21d7446ba894cf9058e1eb91b90301c33c9198b","unresolved":true,"context_lines":[{"line_number":258,"context_line":"                help\u003d_(\u0027Enable rule file validation using promtool.\u0027)),"},{"line_number":259,"context_line":"    cfg.IntOpt(\u0027reporting_period_threshold\u0027,"},{"line_number":260,"context_line":"               default\u003d90,"},{"line_number":261,"context_line":"               help\u003d_(\u0027The time of reportingPeriod for the pm Threshold.\u0027"},{"line_number":262,"context_line":"                      \u0027If there is a PromQL \u0027"},{"line_number":263,"context_line":"                      \u0027that requires `reporting_period`,\u0027"},{"line_number":264,"context_line":"                      \u0027it is read from the configuration file.\u0027"}],"source_content_type":"text/x-python","patch_set":13,"id":"db262925_ac3728c9","line":261,"updated":"2023-02-27 06:23:10.000000000","message":"nit: pm -\u003e PM\n\nAnd please put a space at the end.","commit_id":"684824f35fd01773b0d4e9d14eeeaad4709c08e6"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"822e7028d5cf349c417f0ff6235675aeff7ec225","unresolved":false,"context_lines":[{"line_number":258,"context_line":"                help\u003d_(\u0027Enable rule file validation using promtool.\u0027)),"},{"line_number":259,"context_line":"    cfg.IntOpt(\u0027reporting_period_threshold\u0027,"},{"line_number":260,"context_line":"               default\u003d90,"},{"line_number":261,"context_line":"               help\u003d_(\u0027The time of reportingPeriod for the pm Threshold.\u0027"},{"line_number":262,"context_line":"                      \u0027If there is a PromQL \u0027"},{"line_number":263,"context_line":"                      \u0027that requires `reporting_period`,\u0027"},{"line_number":264,"context_line":"                      \u0027it is read from the configuration file.\u0027"}],"source_content_type":"text/x-python","patch_set":13,"id":"70e7681c_4ff870f4","line":261,"in_reply_to":"12e0ce68_3279d6a8","updated":"2023-03-02 02:07:27.000000000","message":"Done","commit_id":"684824f35fd01773b0d4e9d14eeeaad4709c08e6"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"41273f8fda983cfc1f00f66688f8468915ef945f","unresolved":true,"context_lines":[{"line_number":258,"context_line":"                help\u003d_(\u0027Enable rule file validation using promtool.\u0027)),"},{"line_number":259,"context_line":"    cfg.IntOpt(\u0027reporting_period_threshold\u0027,"},{"line_number":260,"context_line":"               default\u003d90,"},{"line_number":261,"context_line":"               help\u003d_(\u0027The time of reportingPeriod for the pm Threshold.\u0027"},{"line_number":262,"context_line":"                      \u0027If there is a PromQL \u0027"},{"line_number":263,"context_line":"                      \u0027that requires `reporting_period`,\u0027"},{"line_number":264,"context_line":"                      \u0027it is read from the configuration file.\u0027"}],"source_content_type":"text/x-python","patch_set":13,"id":"12e0ce68_3279d6a8","line":261,"in_reply_to":"db262925_ac3728c9","updated":"2023-03-01 08:05:06.000000000","message":"I fixed it in patchset 14.","commit_id":"684824f35fd01773b0d4e9d14eeeaad4709c08e6"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"a21d7446ba894cf9058e1eb91b90301c33c9198b","unresolved":true,"context_lines":[{"line_number":260,"context_line":"               default\u003d90,"},{"line_number":261,"context_line":"               help\u003d_(\u0027The time of reportingPeriod for the pm Threshold.\u0027"},{"line_number":262,"context_line":"                      \u0027If there is a PromQL \u0027"},{"line_number":263,"context_line":"                      \u0027that requires `reporting_period`,\u0027"},{"line_number":264,"context_line":"                      \u0027it is read from the configuration file.\u0027"},{"line_number":265,"context_line":"                      \u0027The unit shall be seconds\u0027)),"},{"line_number":266,"context_line":"    cfg.IntOpt(\u0027collection_period_threshold\u0027,"},{"line_number":267,"context_line":"               default\u003d30,"},{"line_number":268,"context_line":"               help\u003d_(\u0027The time of collectionPeriod for the pm threshold.\u0027"}],"source_content_type":"text/x-python","patch_set":13,"id":"83743a5a_52c5b3e5","line":265,"range":{"start_line":263,"start_character":0,"end_line":265,"end_character":52},"updated":"2023-02-27 06:23:10.000000000","message":"Please put a space at the end.","commit_id":"684824f35fd01773b0d4e9d14eeeaad4709c08e6"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"a21d7446ba894cf9058e1eb91b90301c33c9198b","unresolved":true,"context_lines":[{"line_number":262,"context_line":"                      \u0027If there is a PromQL \u0027"},{"line_number":263,"context_line":"                      \u0027that requires `reporting_period`,\u0027"},{"line_number":264,"context_line":"                      \u0027it is read from the configuration file.\u0027"},{"line_number":265,"context_line":"                      \u0027The unit shall be seconds\u0027)),"},{"line_number":266,"context_line":"    cfg.IntOpt(\u0027collection_period_threshold\u0027,"},{"line_number":267,"context_line":"               default\u003d30,"},{"line_number":268,"context_line":"               help\u003d_(\u0027The time of collectionPeriod for the pm threshold.\u0027"}],"source_content_type":"text/x-python","patch_set":13,"id":"0da05887_a6e68779","line":265,"updated":"2023-02-27 06:23:10.000000000","message":"nit: seconds -\u003e seconds.","commit_id":"684824f35fd01773b0d4e9d14eeeaad4709c08e6"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"41273f8fda983cfc1f00f66688f8468915ef945f","unresolved":true,"context_lines":[{"line_number":262,"context_line":"                      \u0027If there is a PromQL \u0027"},{"line_number":263,"context_line":"                      \u0027that requires `reporting_period`,\u0027"},{"line_number":264,"context_line":"                      \u0027it is read from the configuration file.\u0027"},{"line_number":265,"context_line":"                      \u0027The unit shall be seconds\u0027)),"},{"line_number":266,"context_line":"    cfg.IntOpt(\u0027collection_period_threshold\u0027,"},{"line_number":267,"context_line":"               default\u003d30,"},{"line_number":268,"context_line":"               help\u003d_(\u0027The time of collectionPeriod for the pm threshold.\u0027"}],"source_content_type":"text/x-python","patch_set":13,"id":"68b5dd1f_11f304c9","line":265,"in_reply_to":"0da05887_a6e68779","updated":"2023-03-01 08:05:06.000000000","message":"I fixed it in patchset 14.","commit_id":"684824f35fd01773b0d4e9d14eeeaad4709c08e6"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"822e7028d5cf349c417f0ff6235675aeff7ec225","unresolved":false,"context_lines":[{"line_number":260,"context_line":"               default\u003d90,"},{"line_number":261,"context_line":"               help\u003d_(\u0027The time of reportingPeriod for the pm Threshold.\u0027"},{"line_number":262,"context_line":"                      \u0027If there is a PromQL \u0027"},{"line_number":263,"context_line":"                      \u0027that requires `reporting_period`,\u0027"},{"line_number":264,"context_line":"                      \u0027it is read from the configuration file.\u0027"},{"line_number":265,"context_line":"                      \u0027The unit shall be seconds\u0027)),"},{"line_number":266,"context_line":"    cfg.IntOpt(\u0027collection_period_threshold\u0027,"},{"line_number":267,"context_line":"               default\u003d30,"},{"line_number":268,"context_line":"               help\u003d_(\u0027The time of collectionPeriod for the pm threshold.\u0027"}],"source_content_type":"text/x-python","patch_set":13,"id":"59c83097_c3e009d1","line":265,"range":{"start_line":263,"start_character":0,"end_line":265,"end_character":52},"in_reply_to":"44695c1a_685a012b","updated":"2023-03-02 02:07:27.000000000","message":"Done","commit_id":"684824f35fd01773b0d4e9d14eeeaad4709c08e6"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"822e7028d5cf349c417f0ff6235675aeff7ec225","unresolved":false,"context_lines":[{"line_number":262,"context_line":"                      \u0027If there is a PromQL \u0027"},{"line_number":263,"context_line":"                      \u0027that requires `reporting_period`,\u0027"},{"line_number":264,"context_line":"                      \u0027it is read from the configuration file.\u0027"},{"line_number":265,"context_line":"                      \u0027The unit shall be seconds\u0027)),"},{"line_number":266,"context_line":"    cfg.IntOpt(\u0027collection_period_threshold\u0027,"},{"line_number":267,"context_line":"               default\u003d30,"},{"line_number":268,"context_line":"               help\u003d_(\u0027The time of collectionPeriod for the pm threshold.\u0027"}],"source_content_type":"text/x-python","patch_set":13,"id":"41ad0b1f_dd1e73fb","line":265,"in_reply_to":"68b5dd1f_11f304c9","updated":"2023-03-02 02:07:27.000000000","message":"Done","commit_id":"684824f35fd01773b0d4e9d14eeeaad4709c08e6"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"41273f8fda983cfc1f00f66688f8468915ef945f","unresolved":true,"context_lines":[{"line_number":260,"context_line":"               default\u003d90,"},{"line_number":261,"context_line":"               help\u003d_(\u0027The time of reportingPeriod for the pm Threshold.\u0027"},{"line_number":262,"context_line":"                      \u0027If there is a PromQL \u0027"},{"line_number":263,"context_line":"                      \u0027that requires `reporting_period`,\u0027"},{"line_number":264,"context_line":"                      \u0027it is read from the configuration file.\u0027"},{"line_number":265,"context_line":"                      \u0027The unit shall be seconds\u0027)),"},{"line_number":266,"context_line":"    cfg.IntOpt(\u0027collection_period_threshold\u0027,"},{"line_number":267,"context_line":"               default\u003d30,"},{"line_number":268,"context_line":"               help\u003d_(\u0027The time of collectionPeriod for the pm threshold.\u0027"}],"source_content_type":"text/x-python","patch_set":13,"id":"44695c1a_685a012b","line":265,"range":{"start_line":263,"start_character":0,"end_line":265,"end_character":52},"in_reply_to":"83743a5a_52c5b3e5","updated":"2023-03-01 08:05:06.000000000","message":"I fixed it in patchset 14.","commit_id":"684824f35fd01773b0d4e9d14eeeaad4709c08e6"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"a21d7446ba894cf9058e1eb91b90301c33c9198b","unresolved":true,"context_lines":[{"line_number":265,"context_line":"                      \u0027The unit shall be seconds\u0027)),"},{"line_number":266,"context_line":"    cfg.IntOpt(\u0027collection_period_threshold\u0027,"},{"line_number":267,"context_line":"               default\u003d30,"},{"line_number":268,"context_line":"               help\u003d_(\u0027The time of collectionPeriod for the pm threshold.\u0027"},{"line_number":269,"context_line":"                      \u0027If there is a PromQL \u0027"},{"line_number":270,"context_line":"                      \u0027that requires `collection_period`,\u0027"},{"line_number":271,"context_line":"                      \u0027it is read from the configuration file.\u0027"}],"source_content_type":"text/x-python","patch_set":13,"id":"33ea7102_9d43b5e6","line":268,"updated":"2023-02-27 06:23:10.000000000","message":"nit: pm -\u003e PM\n\nAnd please put a space at the end.","commit_id":"684824f35fd01773b0d4e9d14eeeaad4709c08e6"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"41273f8fda983cfc1f00f66688f8468915ef945f","unresolved":true,"context_lines":[{"line_number":265,"context_line":"                      \u0027The unit shall be seconds\u0027)),"},{"line_number":266,"context_line":"    cfg.IntOpt(\u0027collection_period_threshold\u0027,"},{"line_number":267,"context_line":"               default\u003d30,"},{"line_number":268,"context_line":"               help\u003d_(\u0027The time of collectionPeriod for the pm threshold.\u0027"},{"line_number":269,"context_line":"                      \u0027If there is a PromQL \u0027"},{"line_number":270,"context_line":"                      \u0027that requires `collection_period`,\u0027"},{"line_number":271,"context_line":"                      \u0027it is read from the configuration file.\u0027"}],"source_content_type":"text/x-python","patch_set":13,"id":"d4113732_d7755011","line":268,"in_reply_to":"33ea7102_9d43b5e6","updated":"2023-03-01 08:05:06.000000000","message":"I fixed it in patchset 14.","commit_id":"684824f35fd01773b0d4e9d14eeeaad4709c08e6"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"822e7028d5cf349c417f0ff6235675aeff7ec225","unresolved":false,"context_lines":[{"line_number":265,"context_line":"                      \u0027The unit shall be seconds\u0027)),"},{"line_number":266,"context_line":"    cfg.IntOpt(\u0027collection_period_threshold\u0027,"},{"line_number":267,"context_line":"               default\u003d30,"},{"line_number":268,"context_line":"               help\u003d_(\u0027The time of collectionPeriod for the pm threshold.\u0027"},{"line_number":269,"context_line":"                      \u0027If there is a PromQL \u0027"},{"line_number":270,"context_line":"                      \u0027that requires `collection_period`,\u0027"},{"line_number":271,"context_line":"                      \u0027it is read from the configuration file.\u0027"}],"source_content_type":"text/x-python","patch_set":13,"id":"75785c80_7affd631","line":268,"in_reply_to":"d4113732_d7755011","updated":"2023-03-02 02:07:27.000000000","message":"Done","commit_id":"684824f35fd01773b0d4e9d14eeeaad4709c08e6"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"a21d7446ba894cf9058e1eb91b90301c33c9198b","unresolved":true,"context_lines":[{"line_number":267,"context_line":"               default\u003d30,"},{"line_number":268,"context_line":"               help\u003d_(\u0027The time of collectionPeriod for the pm threshold.\u0027"},{"line_number":269,"context_line":"                      \u0027If there is a PromQL \u0027"},{"line_number":270,"context_line":"                      \u0027that requires `collection_period`,\u0027"},{"line_number":271,"context_line":"                      \u0027it is read from the configuration file.\u0027"},{"line_number":272,"context_line":"                      \u0027The unit shall be seconds\u0027)),"},{"line_number":273,"context_line":"]"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"CONF.register_opts(PROMETHEUS_PLUGIN_OPTS, \u0027prometheus_plugin\u0027)"}],"source_content_type":"text/x-python","patch_set":13,"id":"c976d69b_56b3ce51","line":272,"range":{"start_line":270,"start_character":0,"end_line":272,"end_character":52},"updated":"2023-02-27 06:23:10.000000000","message":"Please put a space at the end.","commit_id":"684824f35fd01773b0d4e9d14eeeaad4709c08e6"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"a21d7446ba894cf9058e1eb91b90301c33c9198b","unresolved":true,"context_lines":[{"line_number":269,"context_line":"                      \u0027If there is a PromQL \u0027"},{"line_number":270,"context_line":"                      \u0027that requires `collection_period`,\u0027"},{"line_number":271,"context_line":"                      \u0027it is read from the configuration file.\u0027"},{"line_number":272,"context_line":"                      \u0027The unit shall be seconds\u0027)),"},{"line_number":273,"context_line":"]"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"CONF.register_opts(PROMETHEUS_PLUGIN_OPTS, \u0027prometheus_plugin\u0027)"}],"source_content_type":"text/x-python","patch_set":13,"id":"7567dbdf_d9fcb4b1","line":272,"updated":"2023-02-27 06:23:10.000000000","message":"nit: seconds -\u003e seconds.","commit_id":"684824f35fd01773b0d4e9d14eeeaad4709c08e6"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"822e7028d5cf349c417f0ff6235675aeff7ec225","unresolved":false,"context_lines":[{"line_number":269,"context_line":"                      \u0027If there is a PromQL \u0027"},{"line_number":270,"context_line":"                      \u0027that requires `collection_period`,\u0027"},{"line_number":271,"context_line":"                      \u0027it is read from the configuration file.\u0027"},{"line_number":272,"context_line":"                      \u0027The unit shall be seconds\u0027)),"},{"line_number":273,"context_line":"]"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"CONF.register_opts(PROMETHEUS_PLUGIN_OPTS, \u0027prometheus_plugin\u0027)"}],"source_content_type":"text/x-python","patch_set":13,"id":"a75987b7_1edee971","line":272,"in_reply_to":"04b283b0_e2c84abf","updated":"2023-03-02 02:07:27.000000000","message":"Done","commit_id":"684824f35fd01773b0d4e9d14eeeaad4709c08e6"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"41273f8fda983cfc1f00f66688f8468915ef945f","unresolved":true,"context_lines":[{"line_number":269,"context_line":"                      \u0027If there is a PromQL \u0027"},{"line_number":270,"context_line":"                      \u0027that requires `collection_period`,\u0027"},{"line_number":271,"context_line":"                      \u0027it is read from the configuration file.\u0027"},{"line_number":272,"context_line":"                      \u0027The unit shall be seconds\u0027)),"},{"line_number":273,"context_line":"]"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"CONF.register_opts(PROMETHEUS_PLUGIN_OPTS, \u0027prometheus_plugin\u0027)"}],"source_content_type":"text/x-python","patch_set":13,"id":"04b283b0_e2c84abf","line":272,"in_reply_to":"7567dbdf_d9fcb4b1","updated":"2023-03-01 08:05:06.000000000","message":"I fixed it in patchset 14.","commit_id":"684824f35fd01773b0d4e9d14eeeaad4709c08e6"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"822e7028d5cf349c417f0ff6235675aeff7ec225","unresolved":false,"context_lines":[{"line_number":267,"context_line":"               default\u003d30,"},{"line_number":268,"context_line":"               help\u003d_(\u0027The time of collectionPeriod for the pm threshold.\u0027"},{"line_number":269,"context_line":"                      \u0027If there is a PromQL \u0027"},{"line_number":270,"context_line":"                      \u0027that requires `collection_period`,\u0027"},{"line_number":271,"context_line":"                      \u0027it is read from the configuration file.\u0027"},{"line_number":272,"context_line":"                      \u0027The unit shall be seconds\u0027)),"},{"line_number":273,"context_line":"]"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"CONF.register_opts(PROMETHEUS_PLUGIN_OPTS, \u0027prometheus_plugin\u0027)"}],"source_content_type":"text/x-python","patch_set":13,"id":"e5811977_548bfda5","line":272,"range":{"start_line":270,"start_character":0,"end_line":272,"end_character":52},"in_reply_to":"c4d5eb7c_47d5fe2f","updated":"2023-03-02 02:07:27.000000000","message":"Done","commit_id":"684824f35fd01773b0d4e9d14eeeaad4709c08e6"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"41273f8fda983cfc1f00f66688f8468915ef945f","unresolved":true,"context_lines":[{"line_number":267,"context_line":"               default\u003d30,"},{"line_number":268,"context_line":"               help\u003d_(\u0027The time of collectionPeriod for the pm threshold.\u0027"},{"line_number":269,"context_line":"                      \u0027If there is a PromQL \u0027"},{"line_number":270,"context_line":"                      \u0027that requires `collection_period`,\u0027"},{"line_number":271,"context_line":"                      \u0027it is read from the configuration file.\u0027"},{"line_number":272,"context_line":"                      \u0027The unit shall be seconds\u0027)),"},{"line_number":273,"context_line":"]"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"CONF.register_opts(PROMETHEUS_PLUGIN_OPTS, \u0027prometheus_plugin\u0027)"}],"source_content_type":"text/x-python","patch_set":13,"id":"c4d5eb7c_47d5fe2f","line":272,"range":{"start_line":270,"start_character":0,"end_line":272,"end_character":52},"in_reply_to":"c976d69b_56b3ce51","updated":"2023-03-01 08:05:06.000000000","message":"I fixed it in patchset 14.","commit_id":"684824f35fd01773b0d4e9d14eeeaad4709c08e6"}],"tacker/sol_refactored/common/pm_threshold_utils.py":[{"author":{"_account_id":31668,"deleted":true},"change_message_id":"a21d7446ba894cf9058e1eb91b90301c33c9198b","unresolved":true,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"def get_pm_threshold_all(context, marker\u003dNone):"},{"line_number":36,"context_line":"    # get all pm threshold"},{"line_number":37,"context_line":"    return objects.ThresholdV2.get_all(context, marker)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"bf998fd6_3e12e897","line":36,"updated":"2023-02-27 06:23:10.000000000","message":"nit: pm -\u003e PM\nnit: threshold -\u003e Threshold","commit_id":"684824f35fd01773b0d4e9d14eeeaad4709c08e6"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"822e7028d5cf349c417f0ff6235675aeff7ec225","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"def get_pm_threshold_all(context, marker\u003dNone):"},{"line_number":36,"context_line":"    # get all pm threshold"},{"line_number":37,"context_line":"    return objects.ThresholdV2.get_all(context, marker)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"08681e6b_9ad8ec3f","line":36,"in_reply_to":"9d0a981c_7241cddc","updated":"2023-03-02 02:07:27.000000000","message":"Done","commit_id":"684824f35fd01773b0d4e9d14eeeaad4709c08e6"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"41273f8fda983cfc1f00f66688f8468915ef945f","unresolved":true,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"def get_pm_threshold_all(context, marker\u003dNone):"},{"line_number":36,"context_line":"    # get all pm threshold"},{"line_number":37,"context_line":"    return objects.ThresholdV2.get_all(context, marker)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"9d0a981c_7241cddc","line":36,"in_reply_to":"bf998fd6_3e12e897","updated":"2023-03-01 08:05:06.000000000","message":"I fixed it in patchset 14.","commit_id":"684824f35fd01773b0d4e9d14eeeaad4709c08e6"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"a21d7446ba894cf9058e1eb91b90301c33c9198b","unresolved":true,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"def get_pm_threshold(context, pm_threshold_id):"},{"line_number":41,"context_line":"    # get the PM threshold from DB."},{"line_number":42,"context_line":"    pm_threshold \u003d objects.ThresholdV2.get_by_id(context, pm_threshold_id)"},{"line_number":43,"context_line":"    if pm_threshold is None:"},{"line_number":44,"context_line":"        raise sol_ex.PMThresholdNotExist()"}],"source_content_type":"text/x-python","patch_set":13,"id":"f625fa89_4826b5e1","line":41,"updated":"2023-02-27 06:23:10.000000000","message":"nit: threshold -\u003e Threshold","commit_id":"684824f35fd01773b0d4e9d14eeeaad4709c08e6"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"822e7028d5cf349c417f0ff6235675aeff7ec225","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"def get_pm_threshold(context, pm_threshold_id):"},{"line_number":41,"context_line":"    # get the PM threshold from DB."},{"line_number":42,"context_line":"    pm_threshold \u003d objects.ThresholdV2.get_by_id(context, pm_threshold_id)"},{"line_number":43,"context_line":"    if pm_threshold is None:"},{"line_number":44,"context_line":"        raise sol_ex.PMThresholdNotExist()"}],"source_content_type":"text/x-python","patch_set":13,"id":"a1da4c9f_2fa2c8bf","line":41,"in_reply_to":"2b9dceff_751e443e","updated":"2023-03-02 02:07:27.000000000","message":"Done","commit_id":"684824f35fd01773b0d4e9d14eeeaad4709c08e6"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"41273f8fda983cfc1f00f66688f8468915ef945f","unresolved":true,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"def get_pm_threshold(context, pm_threshold_id):"},{"line_number":41,"context_line":"    # get the PM threshold from DB."},{"line_number":42,"context_line":"    pm_threshold \u003d objects.ThresholdV2.get_by_id(context, pm_threshold_id)"},{"line_number":43,"context_line":"    if pm_threshold is None:"},{"line_number":44,"context_line":"        raise sol_ex.PMThresholdNotExist()"}],"source_content_type":"text/x-python","patch_set":13,"id":"2b9dceff_751e443e","line":41,"in_reply_to":"f625fa89_4826b5e1","updated":"2023-03-01 08:05:06.000000000","message":"I fixed it in patchset 14.","commit_id":"684824f35fd01773b0d4e9d14eeeaad4709c08e6"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"a21d7446ba894cf9058e1eb91b90301c33c9198b","unresolved":true,"context_lines":[{"line_number":48,"context_line":"def get_pm_threshold_state(context, pm_threshold_id, objectType,"},{"line_number":49,"context_line":"                           object_instance_id, sub_object_instance_id):"},{"line_number":50,"context_line":"    if sub_object_instance_id:"},{"line_number":51,"context_line":"        pm_threshold_states \u003d objects.ThresholdStateV2.get_by_filter("},{"line_number":52,"context_line":"            context,"},{"line_number":53,"context_line":"            thresholdId\u003dpm_threshold_id,"},{"line_number":54,"context_line":"            objectType\u003dobjectType,"}],"source_content_type":"text/x-python","patch_set":13,"id":"d90f5149_49a82f03","line":51,"updated":"2023-02-27 06:23:10.000000000","message":"Cardinarities of id, objectType and objectInstanceId of Threshold are 1.\nWhat is the reason for filtering by objectType and objectInstanceId?\nI feel that there is no problem if filtered by thresholdId and subObjectInstanceId.","commit_id":"684824f35fd01773b0d4e9d14eeeaad4709c08e6"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"822e7028d5cf349c417f0ff6235675aeff7ec225","unresolved":false,"context_lines":[{"line_number":48,"context_line":"def get_pm_threshold_state(context, pm_threshold_id, objectType,"},{"line_number":49,"context_line":"                           object_instance_id, sub_object_instance_id):"},{"line_number":50,"context_line":"    if sub_object_instance_id:"},{"line_number":51,"context_line":"        pm_threshold_states \u003d objects.ThresholdStateV2.get_by_filter("},{"line_number":52,"context_line":"            context,"},{"line_number":53,"context_line":"            thresholdId\u003dpm_threshold_id,"},{"line_number":54,"context_line":"            objectType\u003dobjectType,"}],"source_content_type":"text/x-python","patch_set":13,"id":"1bfbcfd9_d57cd1c0","line":51,"in_reply_to":"5b652d14_9418737e","updated":"2023-03-02 02:07:27.000000000","message":"Done","commit_id":"684824f35fd01773b0d4e9d14eeeaad4709c08e6"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"41273f8fda983cfc1f00f66688f8468915ef945f","unresolved":true,"context_lines":[{"line_number":48,"context_line":"def get_pm_threshold_state(context, pm_threshold_id, objectType,"},{"line_number":49,"context_line":"                           object_instance_id, sub_object_instance_id):"},{"line_number":50,"context_line":"    if sub_object_instance_id:"},{"line_number":51,"context_line":"        pm_threshold_states \u003d objects.ThresholdStateV2.get_by_filter("},{"line_number":52,"context_line":"            context,"},{"line_number":53,"context_line":"            thresholdId\u003dpm_threshold_id,"},{"line_number":54,"context_line":"            objectType\u003dobjectType,"}],"source_content_type":"text/x-python","patch_set":13,"id":"5b652d14_9418737e","line":51,"in_reply_to":"d90f5149_49a82f03","updated":"2023-03-01 08:05:06.000000000","message":"I removed the filter conditions `objectType` and `objectInstanceId`.","commit_id":"684824f35fd01773b0d4e9d14eeeaad4709c08e6"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"a21d7446ba894cf9058e1eb91b90301c33c9198b","unresolved":true,"context_lines":[{"line_number":56,"context_line":"            subObjectInstanceId\u003dsub_object_instance_id"},{"line_number":57,"context_line":"        )"},{"line_number":58,"context_line":"    else:"},{"line_number":59,"context_line":"        pm_threshold_states \u003d objects.ThresholdStateV2.get_by_filter("},{"line_number":60,"context_line":"            context,"},{"line_number":61,"context_line":"            thresholdId\u003dpm_threshold_id,"},{"line_number":62,"context_line":"            objectType\u003dobjectType,"}],"source_content_type":"text/x-python","patch_set":13,"id":"12955e6c_e16f1176","line":59,"updated":"2023-02-27 06:23:10.000000000","message":"Cardinarities of id, objectType and objectInstanceId of Threshold are 1.\nWhat is the reason for filtering by objectType and objectInstanceId?\nI feel that there is no problem if filtered by thresholdId.","commit_id":"684824f35fd01773b0d4e9d14eeeaad4709c08e6"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"41273f8fda983cfc1f00f66688f8468915ef945f","unresolved":true,"context_lines":[{"line_number":56,"context_line":"            subObjectInstanceId\u003dsub_object_instance_id"},{"line_number":57,"context_line":"        )"},{"line_number":58,"context_line":"    else:"},{"line_number":59,"context_line":"        pm_threshold_states \u003d objects.ThresholdStateV2.get_by_filter("},{"line_number":60,"context_line":"            context,"},{"line_number":61,"context_line":"            thresholdId\u003dpm_threshold_id,"},{"line_number":62,"context_line":"            objectType\u003dobjectType,"}],"source_content_type":"text/x-python","patch_set":13,"id":"3baea2f7_48518f02","line":59,"in_reply_to":"12955e6c_e16f1176","updated":"2023-03-01 08:05:06.000000000","message":"I removed the filter conditions `objectType` and `objectInstanceId`.","commit_id":"684824f35fd01773b0d4e9d14eeeaad4709c08e6"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"822e7028d5cf349c417f0ff6235675aeff7ec225","unresolved":false,"context_lines":[{"line_number":56,"context_line":"            subObjectInstanceId\u003dsub_object_instance_id"},{"line_number":57,"context_line":"        )"},{"line_number":58,"context_line":"    else:"},{"line_number":59,"context_line":"        pm_threshold_states \u003d objects.ThresholdStateV2.get_by_filter("},{"line_number":60,"context_line":"            context,"},{"line_number":61,"context_line":"            thresholdId\u003dpm_threshold_id,"},{"line_number":62,"context_line":"            objectType\u003dobjectType,"}],"source_content_type":"text/x-python","patch_set":13,"id":"346c23d3_81976099","line":59,"in_reply_to":"3baea2f7_48518f02","updated":"2023-03-02 02:07:27.000000000","message":"Done","commit_id":"684824f35fd01773b0d4e9d14eeeaad4709c08e6"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"a21d7446ba894cf9058e1eb91b90301c33c9198b","unresolved":true,"context_lines":[{"line_number":96,"context_line":"    return threshold_state"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"def _get_notification_auth_handle(threshold):"},{"line_number":100,"context_line":"    if not threshold.obj_attr_is_set(\u0027authentication\u0027):"},{"line_number":101,"context_line":"        verify \u003d CONF.v2_vnfm.notification_verify_cert"},{"line_number":102,"context_line":"        if verify and CONF.v2_vnfm.notification_ca_cert_file:"}],"source_content_type":"text/x-python","patch_set":13,"id":"b0b8c536_2caf4996","line":99,"updated":"2023-02-27 06:23:10.000000000","message":"For the methods below,\n* _get_notification_auth_handle\n* test_notification\n* async_call\n* send_notification\n\nthe processing seems to be almost same in the following utils.\n* tacker/sol_refactored/common/fm_subscription_utils.py\n* tacker/sol_refactored/common/pm_job_utils.py\n* tacker/sol_refactored/common/subscription_utils.py\n\nShould these utils have separate methods defined?\nConsidering future maintenance, how about making it a common method for the four utils?","commit_id":"684824f35fd01773b0d4e9d14eeeaad4709c08e6"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"41273f8fda983cfc1f00f66688f8468915ef945f","unresolved":true,"context_lines":[{"line_number":96,"context_line":"    return threshold_state"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"def _get_notification_auth_handle(threshold):"},{"line_number":100,"context_line":"    if not threshold.obj_attr_is_set(\u0027authentication\u0027):"},{"line_number":101,"context_line":"        verify \u003d CONF.v2_vnfm.notification_verify_cert"},{"line_number":102,"context_line":"        if verify and CONF.v2_vnfm.notification_ca_cert_file:"}],"source_content_type":"text/x-python","patch_set":13,"id":"d7a5366a_60ed444f","line":99,"in_reply_to":"28aaf50f_63414f74","updated":"2023-03-01 08:05:06.000000000","message":"\u003e Should these utils have separate methods defined?\n\u003e Considering future maintenance, how about making it a common method for the four utils?\nI created the common methods in file `tacker/tacker/sol_refactored/common/common_script_utils.py`.","commit_id":"684824f35fd01773b0d4e9d14eeeaad4709c08e6"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"59e6c30ea331334107e28f84e0e5b0dd0e950df3","unresolved":true,"context_lines":[{"line_number":96,"context_line":"    return threshold_state"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"def _get_notification_auth_handle(threshold):"},{"line_number":100,"context_line":"    if not threshold.obj_attr_is_set(\u0027authentication\u0027):"},{"line_number":101,"context_line":"        verify \u003d CONF.v2_vnfm.notification_verify_cert"},{"line_number":102,"context_line":"        if verify and CONF.v2_vnfm.notification_ca_cert_file:"}],"source_content_type":"text/x-python","patch_set":13,"id":"28aaf50f_63414f74","line":99,"in_reply_to":"b0b8c536_2caf4996","updated":"2023-03-01 05:43:06.000000000","message":"As the processing logic, please unify the processing of subscription_utils.py.\nhttps://opendev.org/openstack/tacker/src/branch/master/tacker/sol_refactored/common/subscription_utils.py#L53\n\nI think that it should be judged by authType and the one with high security strength should be adopted.","commit_id":"684824f35fd01773b0d4e9d14eeeaad4709c08e6"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"f7bd401b26a54e33d54fcc00aac5c215b35c1f4f","unresolved":true,"context_lines":[{"line_number":96,"context_line":"    return threshold_state"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"def _get_notification_auth_handle(threshold):"},{"line_number":100,"context_line":"    if not threshold.obj_attr_is_set(\u0027authentication\u0027):"},{"line_number":101,"context_line":"        verify \u003d CONF.v2_vnfm.notification_verify_cert"},{"line_number":102,"context_line":"        if verify and CONF.v2_vnfm.notification_ca_cert_file:"}],"source_content_type":"text/x-python","patch_set":13,"id":"f1505261_51ae1751","line":99,"in_reply_to":"d7a5366a_60ed444f","updated":"2023-03-01 08:16:58.000000000","message":"\u003e I think that it should be judged by authType and the one with high security strength should be adopted.\nAt present I combine them to judge. Is this OK?","commit_id":"684824f35fd01773b0d4e9d14eeeaad4709c08e6"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"822e7028d5cf349c417f0ff6235675aeff7ec225","unresolved":true,"context_lines":[{"line_number":96,"context_line":"    return threshold_state"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"def _get_notification_auth_handle(threshold):"},{"line_number":100,"context_line":"    if not threshold.obj_attr_is_set(\u0027authentication\u0027):"},{"line_number":101,"context_line":"        verify \u003d CONF.v2_vnfm.notification_verify_cert"},{"line_number":102,"context_line":"        if verify and CONF.v2_vnfm.notification_ca_cert_file:"}],"source_content_type":"text/x-python","patch_set":13,"id":"f852ed64_1ebb32f5","line":99,"in_reply_to":"f1505261_51ae1751","updated":"2023-03-02 02:07:27.000000000","message":"Thanks for the fix!\nI would like you to choose one with stronger security.\nI think it would be better to use the same logic as below.\nhttps://opendev.org/openstack/tacker/src/branch/master/tacker/sol_refactored/common/subscription_utils.py#L54-L75","commit_id":"684824f35fd01773b0d4e9d14eeeaad4709c08e6"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"7659d01a1c866b671389894c2206d45c39b8215e","unresolved":false,"context_lines":[{"line_number":96,"context_line":"    return threshold_state"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"def _get_notification_auth_handle(threshold):"},{"line_number":100,"context_line":"    if not threshold.obj_attr_is_set(\u0027authentication\u0027):"},{"line_number":101,"context_line":"        verify \u003d CONF.v2_vnfm.notification_verify_cert"},{"line_number":102,"context_line":"        if verify and CONF.v2_vnfm.notification_ca_cert_file:"}],"source_content_type":"text/x-python","patch_set":13,"id":"641ad2b5_5e906b61","line":99,"in_reply_to":"f55ed968_fa0bec75","updated":"2023-03-03 00:52:43.000000000","message":"Done","commit_id":"684824f35fd01773b0d4e9d14eeeaad4709c08e6"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"bbef9a977ae4015d4fa99579206417a878a0c882","unresolved":true,"context_lines":[{"line_number":96,"context_line":"    return threshold_state"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"def _get_notification_auth_handle(threshold):"},{"line_number":100,"context_line":"    if not threshold.obj_attr_is_set(\u0027authentication\u0027):"},{"line_number":101,"context_line":"        verify \u003d CONF.v2_vnfm.notification_verify_cert"},{"line_number":102,"context_line":"        if verify and CONF.v2_vnfm.notification_ca_cert_file:"}],"source_content_type":"text/x-python","patch_set":13,"id":"f55ed968_fa0bec75","line":99,"in_reply_to":"f852ed64_1ebb32f5","updated":"2023-03-02 12:15:17.000000000","message":"I modified it according to the above logic.","commit_id":"684824f35fd01773b0d4e9d14eeeaad4709c08e6"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"56dfe3903b9a0b66735f2b886f38eed520edb23a","unresolved":true,"context_lines":[{"line_number":45,"context_line":"    if not pm_threshold.obj_attr_is_set(\u0027metadata\u0027):"},{"line_number":46,"context_line":"        return pm_threshold_state"},{"line_number":47,"context_line":"    if not pm_threshold.metadata.get(\u0027threshold_state\u0027):"},{"line_number":48,"context_line":"        return pm_threshold_state"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    pm_threshold_states \u003d pm_threshold.metadata[\u0027threshold_state\u0027]"},{"line_number":51,"context_line":"    for pm_threshold_state in pm_threshold_states:"}],"source_content_type":"text/x-python","patch_set":22,"id":"10061580_bacf4548","line":48,"updated":"2023-03-07 03:03:47.000000000","message":"It is better to connect `or` like this:\n```\n    if (not pm_threshold.obj_attr_is_set(\u0027metadata\u0027) or\n            not pm_threshold.metadata.get(\u0027threshold_state\u0027)):\n        return pm_threshold_state\n```","commit_id":"ba8f07016cc719c62a264a14b914afd9b0d7d85d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"2f6ad2697def74db2ec26090a90112d34865447d","unresolved":true,"context_lines":[{"line_number":45,"context_line":"    if not pm_threshold.obj_attr_is_set(\u0027metadata\u0027):"},{"line_number":46,"context_line":"        return pm_threshold_state"},{"line_number":47,"context_line":"    if not pm_threshold.metadata.get(\u0027threshold_state\u0027):"},{"line_number":48,"context_line":"        return pm_threshold_state"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    pm_threshold_states \u003d pm_threshold.metadata[\u0027threshold_state\u0027]"},{"line_number":51,"context_line":"    for pm_threshold_state in pm_threshold_states:"}],"source_content_type":"text/x-python","patch_set":22,"id":"96e31a2b_7e616f0d","line":48,"in_reply_to":"10061580_bacf4548","updated":"2023-03-07 06:11:12.000000000","message":"I fixed it in patchset 23.","commit_id":"ba8f07016cc719c62a264a14b914afd9b0d7d85d"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"4452ce72041c8be511f16c4e9b26c700e7a63030","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    if not pm_threshold.obj_attr_is_set(\u0027metadata\u0027):"},{"line_number":46,"context_line":"        return pm_threshold_state"},{"line_number":47,"context_line":"    if not pm_threshold.metadata.get(\u0027threshold_state\u0027):"},{"line_number":48,"context_line":"        return pm_threshold_state"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    pm_threshold_states \u003d pm_threshold.metadata[\u0027threshold_state\u0027]"},{"line_number":51,"context_line":"    for pm_threshold_state in pm_threshold_states:"}],"source_content_type":"text/x-python","patch_set":22,"id":"9fd637d9_8c3e31f0","line":48,"in_reply_to":"96e31a2b_7e616f0d","updated":"2023-03-07 06:48:02.000000000","message":"Done","commit_id":"ba8f07016cc719c62a264a14b914afd9b0d7d85d"},{"author":{"_account_id":35016,"name":"Koji Shimizu","email":"shimizu.koji@fujitsu.com","username":"shimizu-koji"},"change_message_id":"9b7c06b352fe85854c4cba1a764c3a43aaf45114","unresolved":true,"context_lines":[{"line_number":72,"context_line":"    pm_threshold \u003d get_pm_threshold(context, threshold_id)"},{"line_number":73,"context_line":"    threshold_state_info \u003d {"},{"line_number":74,"context_line":"        \u0027thresholdId\u0027: threshold_id,"},{"line_number":75,"context_line":"        \u0027subObjectInstanceId\u0027: pm_threshold_state[\u0027subObjectInstanceId\u0027],"},{"line_number":76,"context_line":"        \u0027performanceValue\u0027: pm_threshold_state[\u0027performanceValue\u0027],"},{"line_number":77,"context_line":"        \u0027metrics\u0027: pm_threshold_state[\u0027metrics\u0027],"},{"line_number":78,"context_line":"        \u0027crossingDirection\u0027: pm_threshold_state[\u0027crossingDirection\u0027]"}],"source_content_type":"text/x-python","patch_set":22,"id":"df363496_5fe0b120","line":75,"updated":"2023-03-07 00:41:29.000000000","message":"I think \u0027thresholdId\u0027 is redundant.\nAre Threshold.id and Threshold.metadata.threshold_state[*].thresholdId always same value?","commit_id":"ba8f07016cc719c62a264a14b914afd9b0d7d85d"},{"author":{"_account_id":35016,"name":"Koji Shimizu","email":"shimizu.koji@fujitsu.com","username":"shimizu-koji"},"change_message_id":"a3c3eff8f01bc088ad22fae89b404f9158b1bcef","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    pm_threshold \u003d get_pm_threshold(context, threshold_id)"},{"line_number":73,"context_line":"    threshold_state_info \u003d {"},{"line_number":74,"context_line":"        \u0027thresholdId\u0027: threshold_id,"},{"line_number":75,"context_line":"        \u0027subObjectInstanceId\u0027: pm_threshold_state[\u0027subObjectInstanceId\u0027],"},{"line_number":76,"context_line":"        \u0027performanceValue\u0027: pm_threshold_state[\u0027performanceValue\u0027],"},{"line_number":77,"context_line":"        \u0027metrics\u0027: pm_threshold_state[\u0027metrics\u0027],"},{"line_number":78,"context_line":"        \u0027crossingDirection\u0027: pm_threshold_state[\u0027crossingDirection\u0027]"}],"source_content_type":"text/x-python","patch_set":22,"id":"9b6df307_d98ec845","line":75,"in_reply_to":"db07126f_468174e2","updated":"2023-03-07 06:29:52.000000000","message":"Done","commit_id":"ba8f07016cc719c62a264a14b914afd9b0d7d85d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"2f6ad2697def74db2ec26090a90112d34865447d","unresolved":true,"context_lines":[{"line_number":72,"context_line":"    pm_threshold \u003d get_pm_threshold(context, threshold_id)"},{"line_number":73,"context_line":"    threshold_state_info \u003d {"},{"line_number":74,"context_line":"        \u0027thresholdId\u0027: threshold_id,"},{"line_number":75,"context_line":"        \u0027subObjectInstanceId\u0027: pm_threshold_state[\u0027subObjectInstanceId\u0027],"},{"line_number":76,"context_line":"        \u0027performanceValue\u0027: pm_threshold_state[\u0027performanceValue\u0027],"},{"line_number":77,"context_line":"        \u0027metrics\u0027: pm_threshold_state[\u0027metrics\u0027],"},{"line_number":78,"context_line":"        \u0027crossingDirection\u0027: pm_threshold_state[\u0027crossingDirection\u0027]"}],"source_content_type":"text/x-python","patch_set":22,"id":"db07126f_468174e2","line":75,"in_reply_to":"df363496_5fe0b120","updated":"2023-03-07 06:11:12.000000000","message":"I removed saving of `thresholdId` in DB.","commit_id":"ba8f07016cc719c62a264a14b914afd9b0d7d85d"},{"author":{"_account_id":35016,"name":"Koji Shimizu","email":"shimizu.koji@fujitsu.com","username":"shimizu-koji"},"change_message_id":"9b7c06b352fe85854c4cba1a764c3a43aaf45114","unresolved":true,"context_lines":[{"line_number":82,"context_line":"            pm_threshold.metadata.update({"},{"line_number":83,"context_line":"                \u0027threshold_state\u0027: [threshold_state_info]})"},{"line_number":84,"context_line":"        else:"},{"line_number":85,"context_line":"            pm_threshold.metadata[\u0027threshold_state\u0027].append("},{"line_number":86,"context_line":"                threshold_state_info)"},{"line_number":87,"context_line":"    else:"},{"line_number":88,"context_line":"        pm_threshold.metadata \u003d {"}],"source_content_type":"text/x-python","patch_set":22,"id":"6412b323_30356e15","line":85,"updated":"2023-03-07 00:41:29.000000000","message":"I think it is better to use camelCase for the key name.","commit_id":"ba8f07016cc719c62a264a14b914afd9b0d7d85d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"2f6ad2697def74db2ec26090a90112d34865447d","unresolved":true,"context_lines":[{"line_number":82,"context_line":"            pm_threshold.metadata.update({"},{"line_number":83,"context_line":"                \u0027threshold_state\u0027: [threshold_state_info]})"},{"line_number":84,"context_line":"        else:"},{"line_number":85,"context_line":"            pm_threshold.metadata[\u0027threshold_state\u0027].append("},{"line_number":86,"context_line":"                threshold_state_info)"},{"line_number":87,"context_line":"    else:"},{"line_number":88,"context_line":"        pm_threshold.metadata \u003d {"}],"source_content_type":"text/x-python","patch_set":22,"id":"e2ef1b3c_e54df885","line":85,"in_reply_to":"6412b323_30356e15","updated":"2023-03-07 06:11:12.000000000","message":"I replaced `threshold_state` with `thresholdState`.","commit_id":"ba8f07016cc719c62a264a14b914afd9b0d7d85d"},{"author":{"_account_id":35016,"name":"Koji Shimizu","email":"shimizu.koji@fujitsu.com","username":"shimizu-koji"},"change_message_id":"a3c3eff8f01bc088ad22fae89b404f9158b1bcef","unresolved":false,"context_lines":[{"line_number":82,"context_line":"            pm_threshold.metadata.update({"},{"line_number":83,"context_line":"                \u0027threshold_state\u0027: [threshold_state_info]})"},{"line_number":84,"context_line":"        else:"},{"line_number":85,"context_line":"            pm_threshold.metadata[\u0027threshold_state\u0027].append("},{"line_number":86,"context_line":"                threshold_state_info)"},{"line_number":87,"context_line":"    else:"},{"line_number":88,"context_line":"        pm_threshold.metadata \u003d {"}],"source_content_type":"text/x-python","patch_set":22,"id":"4fd6761d_6ebb6117","line":85,"in_reply_to":"e2ef1b3c_e54df885","updated":"2023-03-07 06:29:52.000000000","message":"Done","commit_id":"ba8f07016cc719c62a264a14b914afd9b0d7d85d"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"67b6c05f0a1acfd9c3c3a8c709cfed0446196059","unresolved":true,"context_lines":[{"line_number":44,"context_line":"    pm_threshold_state \u003d None"},{"line_number":45,"context_line":"    if (not pm_threshold.obj_attr_is_set(\u0027metadata\u0027) or"},{"line_number":46,"context_line":"            not pm_threshold.metadata.get(\u0027thresholdState\u0027)):"},{"line_number":47,"context_line":"        return pm_threshold_state"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    pm_threshold_states \u003d pm_threshold.metadata[\u0027thresholdState\u0027]"},{"line_number":50,"context_line":"    for pm_threshold_state in pm_threshold_states:"}],"source_content_type":"text/x-python","patch_set":25,"id":"37344b3e_5d07110f","line":47,"updated":"2023-03-08 06:18:03.000000000","message":"I think the initialization with `None` is unnecessary.\n\n```\n    pm_threshold_state \u003d None\n    if (not pm_threshold.obj_attr_is_set(\u0027metadata\u0027) or\n            not pm_threshold.metadata.get(\u0027thresholdState\u0027)):\n        return pm_threshold_state\n```\n-\u003e\n```\n    if (not pm_threshold.obj_attr_is_set(\u0027metadata\u0027) or\n            not pm_threshold.metadata.get(\u0027thresholdState\u0027)):\n        return None\n```","commit_id":"0048f07fd3abb9a6d79b9cc311fb4985c73c034d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"7fcf570f4a61c3222f5015890f250629cff12a84","unresolved":true,"context_lines":[{"line_number":44,"context_line":"    pm_threshold_state \u003d None"},{"line_number":45,"context_line":"    if (not pm_threshold.obj_attr_is_set(\u0027metadata\u0027) or"},{"line_number":46,"context_line":"            not pm_threshold.metadata.get(\u0027thresholdState\u0027)):"},{"line_number":47,"context_line":"        return pm_threshold_state"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    pm_threshold_states \u003d pm_threshold.metadata[\u0027thresholdState\u0027]"},{"line_number":50,"context_line":"    for pm_threshold_state in pm_threshold_states:"}],"source_content_type":"text/x-python","patch_set":25,"id":"3d9ebbc1_dc33b3fe","line":47,"in_reply_to":"37344b3e_5d07110f","updated":"2023-03-08 08:30:16.000000000","message":"I fixed it in patchset 26.","commit_id":"0048f07fd3abb9a6d79b9cc311fb4985c73c034d"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"bfa4c0ad28030aed72bef1e4e055af0771c70503","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    pm_threshold_state \u003d None"},{"line_number":45,"context_line":"    if (not pm_threshold.obj_attr_is_set(\u0027metadata\u0027) or"},{"line_number":46,"context_line":"            not pm_threshold.metadata.get(\u0027thresholdState\u0027)):"},{"line_number":47,"context_line":"        return pm_threshold_state"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    pm_threshold_states \u003d pm_threshold.metadata[\u0027thresholdState\u0027]"},{"line_number":50,"context_line":"    for pm_threshold_state in pm_threshold_states:"}],"source_content_type":"text/x-python","patch_set":25,"id":"a714fc24_fd392704","line":47,"in_reply_to":"3d9ebbc1_dc33b3fe","updated":"2023-03-08 09:27:46.000000000","message":"Done","commit_id":"0048f07fd3abb9a6d79b9cc311fb4985c73c034d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"205515ec6e2c288236f50270e6b08fc27466157c","unresolved":true,"context_lines":[{"line_number":93,"context_line":"def make_threshold_notif_data(timestamp, threshold_state,"},{"line_number":94,"context_line":"                              endpoint, pm_threshold):"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    notif_data \u003d objects.ThresholdCrossedNotificationV2("},{"line_number":97,"context_line":"        id\u003duuidutils.generate_uuid(),"},{"line_number":98,"context_line":"        notificationType\u003d\"PerformanceThresholdNotification\","},{"line_number":99,"context_line":"        timeStamp\u003dtimestamp,"}],"source_content_type":"text/x-python","patch_set":25,"id":"4a9af667_6fbbda43","line":96,"updated":"2023-03-08 06:28:13.000000000","message":"Is it okay to not set \"context\"?","commit_id":"0048f07fd3abb9a6d79b9cc311fb4985c73c034d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"ffcbe62c7d93958ce4d3e37c19eefb313a24f4aa","unresolved":true,"context_lines":[{"line_number":93,"context_line":"def make_threshold_notif_data(timestamp, threshold_state,"},{"line_number":94,"context_line":"                              endpoint, pm_threshold):"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    notif_data \u003d objects.ThresholdCrossedNotificationV2("},{"line_number":97,"context_line":"        id\u003duuidutils.generate_uuid(),"},{"line_number":98,"context_line":"        notificationType\u003d\"PerformanceThresholdNotification\","},{"line_number":99,"context_line":"        timeStamp\u003dtimestamp,"}],"source_content_type":"text/x-python","patch_set":25,"id":"f8e44698_2194f84e","line":96,"in_reply_to":"1972cea1_8ebe2c34","updated":"2023-03-10 05:24:39.000000000","message":"I appended note in `ThresholdCrossedNotificationV2` and also removed `context\u003dNone`.","commit_id":"0048f07fd3abb9a6d79b9cc311fb4985c73c034d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"7fcf570f4a61c3222f5015890f250629cff12a84","unresolved":true,"context_lines":[{"line_number":93,"context_line":"def make_threshold_notif_data(timestamp, threshold_state,"},{"line_number":94,"context_line":"                              endpoint, pm_threshold):"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    notif_data \u003d objects.ThresholdCrossedNotificationV2("},{"line_number":97,"context_line":"        id\u003duuidutils.generate_uuid(),"},{"line_number":98,"context_line":"        notificationType\u003d\"PerformanceThresholdNotification\","},{"line_number":99,"context_line":"        timeStamp\u003dtimestamp,"}],"source_content_type":"text/x-python","patch_set":25,"id":"f4a7bf30_8f12d7d0","line":96,"in_reply_to":"4a9af667_6fbbda43","updated":"2023-03-08 08:30:16.000000000","message":"Since no value is assigned to `context`, it is not set.\nNow I append `context\u003dNone`.","commit_id":"0048f07fd3abb9a6d79b9cc311fb4985c73c034d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"502d8a480ed50e06fb6674b5ae77b544b3d9472e","unresolved":true,"context_lines":[{"line_number":93,"context_line":"def make_threshold_notif_data(timestamp, threshold_state,"},{"line_number":94,"context_line":"                              endpoint, pm_threshold):"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    notif_data \u003d objects.ThresholdCrossedNotificationV2("},{"line_number":97,"context_line":"        id\u003duuidutils.generate_uuid(),"},{"line_number":98,"context_line":"        notificationType\u003d\"PerformanceThresholdNotification\","},{"line_number":99,"context_line":"        timeStamp\u003dtimestamp,"}],"source_content_type":"text/x-python","patch_set":25,"id":"1972cea1_8ebe2c34","line":96,"in_reply_to":"f4a7bf30_8f12d7d0","updated":"2023-03-08 09:34:23.000000000","message":"I don\u0027t think the value needs to be set if it\u0027s not supported now.\nCould you please comment that the Object class does not support it?\nhttps://review.opendev.org/c/openstack/tacker/+/872831/26/tacker/sol_refactored/objects/v2/threshold_crossed_notification.py#41","commit_id":"0048f07fd3abb9a6d79b9cc311fb4985c73c034d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"8f06305958ef940b7db0ad505c6afd11351558ea","unresolved":false,"context_lines":[{"line_number":93,"context_line":"def make_threshold_notif_data(timestamp, threshold_state,"},{"line_number":94,"context_line":"                              endpoint, pm_threshold):"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    notif_data \u003d objects.ThresholdCrossedNotificationV2("},{"line_number":97,"context_line":"        id\u003duuidutils.generate_uuid(),"},{"line_number":98,"context_line":"        notificationType\u003d\"PerformanceThresholdNotification\","},{"line_number":99,"context_line":"        timeStamp\u003dtimestamp,"}],"source_content_type":"text/x-python","patch_set":25,"id":"a3745091_7b5b417c","line":96,"in_reply_to":"f8e44698_2194f84e","updated":"2023-03-10 07:29:52.000000000","message":"Done","commit_id":"0048f07fd3abb9a6d79b9cc311fb4985c73c034d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"205515ec6e2c288236f50270e6b08fc27466157c","unresolved":true,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    notif_data \u003d objects.ThresholdCrossedNotificationV2("},{"line_number":97,"context_line":"        id\u003duuidutils.generate_uuid(),"},{"line_number":98,"context_line":"        notificationType\u003d\"PerformanceThresholdNotification\","},{"line_number":99,"context_line":"        timeStamp\u003dtimestamp,"},{"line_number":100,"context_line":"        thresholdId\u003dpm_threshold.id,"},{"line_number":101,"context_line":"        objectType\u003dpm_threshold.objectType,"}],"source_content_type":"text/x-python","patch_set":25,"id":"9ef90e25_602d7fdd","line":98,"updated":"2023-03-08 06:28:13.000000000","message":"SOL003 v3.3.1 Table 6.5.2.4-1 has the following description.\n```\nDiscriminator for the different notification types.\nShall be set to \"ThresholdCrossedNotification\" for this notification type.\n```\n\nCould you please set the \"ThresholdCrossedNotification\"?","commit_id":"0048f07fd3abb9a6d79b9cc311fb4985c73c034d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"502d8a480ed50e06fb6674b5ae77b544b3d9472e","unresolved":false,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    notif_data \u003d objects.ThresholdCrossedNotificationV2("},{"line_number":97,"context_line":"        id\u003duuidutils.generate_uuid(),"},{"line_number":98,"context_line":"        notificationType\u003d\"PerformanceThresholdNotification\","},{"line_number":99,"context_line":"        timeStamp\u003dtimestamp,"},{"line_number":100,"context_line":"        thresholdId\u003dpm_threshold.id,"},{"line_number":101,"context_line":"        objectType\u003dpm_threshold.objectType,"}],"source_content_type":"text/x-python","patch_set":25,"id":"db5bfd69_cab004a6","line":98,"in_reply_to":"88bb62df_ff775a81","updated":"2023-03-08 09:34:23.000000000","message":"Done","commit_id":"0048f07fd3abb9a6d79b9cc311fb4985c73c034d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"7fcf570f4a61c3222f5015890f250629cff12a84","unresolved":true,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    notif_data \u003d objects.ThresholdCrossedNotificationV2("},{"line_number":97,"context_line":"        id\u003duuidutils.generate_uuid(),"},{"line_number":98,"context_line":"        notificationType\u003d\"PerformanceThresholdNotification\","},{"line_number":99,"context_line":"        timeStamp\u003dtimestamp,"},{"line_number":100,"context_line":"        thresholdId\u003dpm_threshold.id,"},{"line_number":101,"context_line":"        objectType\u003dpm_threshold.objectType,"}],"source_content_type":"text/x-python","patch_set":25,"id":"88bb62df_ff775a81","line":98,"in_reply_to":"9ef90e25_602d7fdd","updated":"2023-03-08 08:30:16.000000000","message":"I fixed it in patchset 26.","commit_id":"0048f07fd3abb9a6d79b9cc311fb4985c73c034d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"205515ec6e2c288236f50270e6b08fc27466157c","unresolved":true,"context_lines":[{"line_number":102,"context_line":"        objectInstanceId\u003dpm_threshold.objectInstanceId,"},{"line_number":103,"context_line":"        performanceMetric\u003dthreshold_state[\u0027metrics\u0027],"},{"line_number":104,"context_line":"        performanceValue\u003dthreshold_state[\u0027performanceValue\u0027],"},{"line_number":105,"context_line":"        crossingDirection\u003dthreshold_state[\u0027crossingDirection\u0027],"},{"line_number":106,"context_line":"        _links\u003dobjects.ThresholdCrossedNotificationV2_Links("},{"line_number":107,"context_line":"            objectInstance\u003dobjects.NotificationLink("},{"line_number":108,"context_line":"                href\u003dinst_utils.inst_href("}],"source_content_type":"text/x-python","patch_set":25,"id":"20792377_d4abd539","line":105,"updated":"2023-03-08 06:28:13.000000000","message":"This is an attribute that is not defined in SOL003 v3.3.1 Table 6.5.2.4-1, is it necessary?","commit_id":"0048f07fd3abb9a6d79b9cc311fb4985c73c034d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"b2394450d3f9b89894f2dc8e40425371d6dfbb2a","unresolved":true,"context_lines":[{"line_number":102,"context_line":"        objectInstanceId\u003dpm_threshold.objectInstanceId,"},{"line_number":103,"context_line":"        performanceMetric\u003dthreshold_state[\u0027metrics\u0027],"},{"line_number":104,"context_line":"        performanceValue\u003dthreshold_state[\u0027performanceValue\u0027],"},{"line_number":105,"context_line":"        crossingDirection\u003dthreshold_state[\u0027crossingDirection\u0027],"},{"line_number":106,"context_line":"        _links\u003dobjects.ThresholdCrossedNotificationV2_Links("},{"line_number":107,"context_line":"            objectInstance\u003dobjects.NotificationLink("},{"line_number":108,"context_line":"                href\u003dinst_utils.inst_href("}],"source_content_type":"text/x-python","patch_set":25,"id":"5dcdc714_45f67fea","line":105,"in_reply_to":"20792377_d4abd539","updated":"2023-03-08 06:41:19.000000000","message":"It\u0027s my mistake, it\u0027s written in SOL...\nPlease write in the order as defined by SOL.\n\"crossingDirection\" should be written between \"thresholdId\" and \"objectType\".","commit_id":"0048f07fd3abb9a6d79b9cc311fb4985c73c034d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"502d8a480ed50e06fb6674b5ae77b544b3d9472e","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        objectInstanceId\u003dpm_threshold.objectInstanceId,"},{"line_number":103,"context_line":"        performanceMetric\u003dthreshold_state[\u0027metrics\u0027],"},{"line_number":104,"context_line":"        performanceValue\u003dthreshold_state[\u0027performanceValue\u0027],"},{"line_number":105,"context_line":"        crossingDirection\u003dthreshold_state[\u0027crossingDirection\u0027],"},{"line_number":106,"context_line":"        _links\u003dobjects.ThresholdCrossedNotificationV2_Links("},{"line_number":107,"context_line":"            objectInstance\u003dobjects.NotificationLink("},{"line_number":108,"context_line":"                href\u003dinst_utils.inst_href("}],"source_content_type":"text/x-python","patch_set":25,"id":"a6224790_14d62656","line":105,"in_reply_to":"2b977642_f5b8f5d7","updated":"2023-03-08 09:34:23.000000000","message":"Done","commit_id":"0048f07fd3abb9a6d79b9cc311fb4985c73c034d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"7fcf570f4a61c3222f5015890f250629cff12a84","unresolved":true,"context_lines":[{"line_number":102,"context_line":"        objectInstanceId\u003dpm_threshold.objectInstanceId,"},{"line_number":103,"context_line":"        performanceMetric\u003dthreshold_state[\u0027metrics\u0027],"},{"line_number":104,"context_line":"        performanceValue\u003dthreshold_state[\u0027performanceValue\u0027],"},{"line_number":105,"context_line":"        crossingDirection\u003dthreshold_state[\u0027crossingDirection\u0027],"},{"line_number":106,"context_line":"        _links\u003dobjects.ThresholdCrossedNotificationV2_Links("},{"line_number":107,"context_line":"            objectInstance\u003dobjects.NotificationLink("},{"line_number":108,"context_line":"                href\u003dinst_utils.inst_href("}],"source_content_type":"text/x-python","patch_set":25,"id":"2b977642_f5b8f5d7","line":105,"in_reply_to":"5dcdc714_45f67fea","updated":"2023-03-08 08:30:16.000000000","message":"I fixed it in patchset 26.","commit_id":"0048f07fd3abb9a6d79b9cc311fb4985c73c034d"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"aa7951f8cc6d8430870e4d9df65ee74d638c9c5a","unresolved":true,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"def get_pm_threshold_all(context, marker\u003dNone):"},{"line_number":31,"context_line":"    # get all PM Threshold"},{"line_number":32,"context_line":"    return objects.ThresholdV2.get_all(context, marker)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"d366459f_17b1964c","line":31,"updated":"2023-03-10 20:24:11.000000000","message":"It must be a useless comment.","commit_id":"7fead4150349fec4a219f23636c4ee68777035df"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"31e314b9399ded8bbefa5b1165d1003e3ae4fd1e","unresolved":true,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"def get_pm_threshold_all(context, marker\u003dNone):"},{"line_number":31,"context_line":"    # get all PM Threshold"},{"line_number":32,"context_line":"    return objects.ThresholdV2.get_all(context, marker)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"fef77f71_40ad0196","line":31,"in_reply_to":"d366459f_17b1964c","updated":"2023-03-13 06:26:19.000000000","message":"I removed it in patchset 29.","commit_id":"7fead4150349fec4a219f23636c4ee68777035df"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"aa7951f8cc6d8430870e4d9df65ee74d638c9c5a","unresolved":true,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"def get_pm_threshold(context, pm_threshold_id):"},{"line_number":36,"context_line":"    # get the PM Threshold from DB."},{"line_number":37,"context_line":"    pm_threshold \u003d objects.ThresholdV2.get_by_id(context, pm_threshold_id)"},{"line_number":38,"context_line":"    if pm_threshold is None:"},{"line_number":39,"context_line":"        raise sol_ex.PMThresholdNotExist()"}],"source_content_type":"text/x-python","patch_set":28,"id":"e0655110_b90fe73b","line":36,"updated":"2023-03-10 20:24:11.000000000","message":"ditto","commit_id":"7fead4150349fec4a219f23636c4ee68777035df"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"31e314b9399ded8bbefa5b1165d1003e3ae4fd1e","unresolved":true,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"def get_pm_threshold(context, pm_threshold_id):"},{"line_number":36,"context_line":"    # get the PM Threshold from DB."},{"line_number":37,"context_line":"    pm_threshold \u003d objects.ThresholdV2.get_by_id(context, pm_threshold_id)"},{"line_number":38,"context_line":"    if pm_threshold is None:"},{"line_number":39,"context_line":"        raise sol_ex.PMThresholdNotExist()"}],"source_content_type":"text/x-python","patch_set":28,"id":"68523fee_a21b6d8c","line":36,"in_reply_to":"e0655110_b90fe73b","updated":"2023-03-13 06:26:19.000000000","message":"I removed it in patchset 29.","commit_id":"7fead4150349fec4a219f23636c4ee68777035df"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"aa7951f8cc6d8430870e4d9df65ee74d638c9c5a","unresolved":true,"context_lines":[{"line_number":35,"context_line":"def get_pm_threshold(context, pm_threshold_id):"},{"line_number":36,"context_line":"    # get the PM Threshold from DB."},{"line_number":37,"context_line":"    pm_threshold \u003d objects.ThresholdV2.get_by_id(context, pm_threshold_id)"},{"line_number":38,"context_line":"    if pm_threshold is None:"},{"line_number":39,"context_line":"        raise sol_ex.PMThresholdNotExist()"},{"line_number":40,"context_line":"    return pm_threshold"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"61911ee1_5bb63b97","line":39,"range":{"start_line":38,"start_character":4,"end_line":39,"end_character":42},"updated":"2023-03-10 20:24:11.000000000","message":"Could I confirm is there any reason to raise the exception if just the threshold not found? Is it not enough to return empty or None instead?","commit_id":"7fead4150349fec4a219f23636c4ee68777035df"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"31e314b9399ded8bbefa5b1165d1003e3ae4fd1e","unresolved":true,"context_lines":[{"line_number":35,"context_line":"def get_pm_threshold(context, pm_threshold_id):"},{"line_number":36,"context_line":"    # get the PM Threshold from DB."},{"line_number":37,"context_line":"    pm_threshold \u003d objects.ThresholdV2.get_by_id(context, pm_threshold_id)"},{"line_number":38,"context_line":"    if pm_threshold is None:"},{"line_number":39,"context_line":"        raise sol_ex.PMThresholdNotExist()"},{"line_number":40,"context_line":"    return pm_threshold"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"169f518c_34dfd4df","line":39,"range":{"start_line":38,"start_character":4,"end_line":39,"end_character":42},"in_reply_to":"61911ee1_5bb63b97","updated":"2023-03-13 06:26:19.000000000","message":"I modified it to look at this function.\nNow if the corresponding threshold is not found, no exception will be raised, and None will be returned.","commit_id":"7fead4150349fec4a219f23636c4ee68777035df"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"aa7951f8cc6d8430870e4d9df65ee74d638c9c5a","unresolved":true,"context_lines":[{"line_number":67,"context_line":"@coordinate.lock_resources(\u0027{threshold_id}\u0027)"},{"line_number":68,"context_line":"def update_threshold_state_data(context, threshold_id,"},{"line_number":69,"context_line":"                                threshold_state_data):"},{"line_number":70,"context_line":"    pm_threshold \u003d get_pm_threshold(context, threshold_id)"},{"line_number":71,"context_line":"    if pm_threshold.obj_attr_is_set(\u0027metadata\u0027):"},{"line_number":72,"context_line":"        if \u0027thresholdState\u0027 not in pm_threshold.metadata.keys():"},{"line_number":73,"context_line":"            pm_threshold.metadata.update({"}],"source_content_type":"text/x-python","patch_set":28,"id":"d76f1e23_cee14b04","line":70,"range":{"start_line":70,"start_character":19,"end_line":70,"end_character":35},"updated":"2023-03-10 20:24:11.000000000","message":"Is there no need to catch an exception from the function?","commit_id":"7fead4150349fec4a219f23636c4ee68777035df"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"31e314b9399ded8bbefa5b1165d1003e3ae4fd1e","unresolved":true,"context_lines":[{"line_number":67,"context_line":"@coordinate.lock_resources(\u0027{threshold_id}\u0027)"},{"line_number":68,"context_line":"def update_threshold_state_data(context, threshold_id,"},{"line_number":69,"context_line":"                                threshold_state_data):"},{"line_number":70,"context_line":"    pm_threshold \u003d get_pm_threshold(context, threshold_id)"},{"line_number":71,"context_line":"    if pm_threshold.obj_attr_is_set(\u0027metadata\u0027):"},{"line_number":72,"context_line":"        if \u0027thresholdState\u0027 not in pm_threshold.metadata.keys():"},{"line_number":73,"context_line":"            pm_threshold.metadata.update({"}],"source_content_type":"text/x-python","patch_set":28,"id":"61d2576b_0b7f12d2","line":70,"range":{"start_line":70,"start_character":19,"end_line":70,"end_character":35},"in_reply_to":"d76f1e23_cee14b04","updated":"2023-03-13 06:26:19.000000000","message":"I modified `get_pm_threshold` and no longer raises an exception, so there should be no need to catch here.","commit_id":"7fead4150349fec4a219f23636c4ee68777035df"}],"tacker/sol_refactored/common/prometheus_plugin.py":[{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"dc16bcedf94f5bbf9cd3b459b2afd2fa69f694a4","unresolved":true,"context_lines":[{"line_number":71,"context_line":"            self._alert(kwargs[\u0027request\u0027], body\u003dkwargs[\u0027body\u0027])"},{"line_number":72,"context_line":"        except Exception as e:"},{"line_number":73,"context_line":"            # All exceptions are ignored here and 204 response will always"},{"line_number":74,"context_line":"            # be returned because when tacker responds error to alertmanager,"},{"line_number":75,"context_line":"            # alertmanager may repeat the same reports."},{"line_number":76,"context_line":"            LOG.error(\"%s: %s\", e.__class__.__name__, e.args[0])"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"8b46594d_54c5ca3d","line":74,"range":{"start_line":74,"start_character":39,"end_line":74,"end_character":60},"updated":"2023-03-08 02:32:42.000000000","message":"nits: tacker responds error -\u003e Tacker responds errors","commit_id":"ab7e028ce5fe89cf6ee2d1cc9bf3f625d6fecf79"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"f75f7f73969c2f79cb01be214ace79a8fa8387bb","unresolved":false,"context_lines":[{"line_number":71,"context_line":"            self._alert(kwargs[\u0027request\u0027], body\u003dkwargs[\u0027body\u0027])"},{"line_number":72,"context_line":"        except Exception as e:"},{"line_number":73,"context_line":"            # All exceptions are ignored here and 204 response will always"},{"line_number":74,"context_line":"            # be returned because when tacker responds error to alertmanager,"},{"line_number":75,"context_line":"            # alertmanager may repeat the same reports."},{"line_number":76,"context_line":"            LOG.error(\"%s: %s\", e.__class__.__name__, e.args[0])"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"1488a109_19cfec7a","line":74,"range":{"start_line":74,"start_character":39,"end_line":74,"end_character":60},"in_reply_to":"4e3c34cf_23a849bc","updated":"2023-03-08 05:53:57.000000000","message":"Done","commit_id":"ab7e028ce5fe89cf6ee2d1cc9bf3f625d6fecf79"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"4ddeadaa7680c0634569737042684193d11de2e6","unresolved":true,"context_lines":[{"line_number":71,"context_line":"            self._alert(kwargs[\u0027request\u0027], body\u003dkwargs[\u0027body\u0027])"},{"line_number":72,"context_line":"        except Exception as e:"},{"line_number":73,"context_line":"            # All exceptions are ignored here and 204 response will always"},{"line_number":74,"context_line":"            # be returned because when tacker responds error to alertmanager,"},{"line_number":75,"context_line":"            # alertmanager may repeat the same reports."},{"line_number":76,"context_line":"            LOG.error(\"%s: %s\", e.__class__.__name__, e.args[0])"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"4e3c34cf_23a849bc","line":74,"range":{"start_line":74,"start_character":39,"end_line":74,"end_character":60},"in_reply_to":"8b46594d_54c5ca3d","updated":"2023-03-08 03:07:02.000000000","message":"I fixed it in patchset 25.","commit_id":"ab7e028ce5fe89cf6ee2d1cc9bf3f625d6fecf79"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"dc16bcedf94f5bbf9cd3b459b2afd2fa69f694a4","unresolved":true,"context_lines":[{"line_number":752,"context_line":""},{"line_number":753,"context_line":"    def set_crossing_direction(self, threshold_new_value, threshold_last_value,"},{"line_number":754,"context_line":"                               threshold_value, threshold_hysteresis):"},{"line_number":755,"context_line":"        # \"IN\" is simply used to mark not to send ThresholdCrossedNotification."},{"line_number":756,"context_line":"        crossing_direction \u003d \"IN\""},{"line_number":757,"context_line":"        if (threshold_new_value \u003e (threshold_value + threshold_hysteresis) \u003e\u003d"},{"line_number":758,"context_line":"                threshold_last_value):"}],"source_content_type":"text/x-python","patch_set":24,"id":"01556d8d_33d7167b","line":755,"range":{"start_line":755,"start_character":9,"end_line":755,"end_character":10},"updated":"2023-03-08 02:32:42.000000000","message":"nits: Please add `NOTE:`","commit_id":"ab7e028ce5fe89cf6ee2d1cc9bf3f625d6fecf79"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"4ddeadaa7680c0634569737042684193d11de2e6","unresolved":true,"context_lines":[{"line_number":752,"context_line":""},{"line_number":753,"context_line":"    def set_crossing_direction(self, threshold_new_value, threshold_last_value,"},{"line_number":754,"context_line":"                               threshold_value, threshold_hysteresis):"},{"line_number":755,"context_line":"        # \"IN\" is simply used to mark not to send ThresholdCrossedNotification."},{"line_number":756,"context_line":"        crossing_direction \u003d \"IN\""},{"line_number":757,"context_line":"        if (threshold_new_value \u003e (threshold_value + threshold_hysteresis) \u003e\u003d"},{"line_number":758,"context_line":"                threshold_last_value):"}],"source_content_type":"text/x-python","patch_set":24,"id":"dd44ea82_2b46de41","line":755,"range":{"start_line":755,"start_character":9,"end_line":755,"end_character":10},"in_reply_to":"01556d8d_33d7167b","updated":"2023-03-08 03:07:02.000000000","message":"I fixed it in patchset 25.","commit_id":"ab7e028ce5fe89cf6ee2d1cc9bf3f625d6fecf79"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"f75f7f73969c2f79cb01be214ace79a8fa8387bb","unresolved":false,"context_lines":[{"line_number":752,"context_line":""},{"line_number":753,"context_line":"    def set_crossing_direction(self, threshold_new_value, threshold_last_value,"},{"line_number":754,"context_line":"                               threshold_value, threshold_hysteresis):"},{"line_number":755,"context_line":"        # \"IN\" is simply used to mark not to send ThresholdCrossedNotification."},{"line_number":756,"context_line":"        crossing_direction \u003d \"IN\""},{"line_number":757,"context_line":"        if (threshold_new_value \u003e (threshold_value + threshold_hysteresis) \u003e\u003d"},{"line_number":758,"context_line":"                threshold_last_value):"}],"source_content_type":"text/x-python","patch_set":24,"id":"1919faef_3a455012","line":755,"range":{"start_line":755,"start_character":9,"end_line":755,"end_character":10},"in_reply_to":"dd44ea82_2b46de41","updated":"2023-03-08 05:53:57.000000000","message":"Done","commit_id":"ab7e028ce5fe89cf6ee2d1cc9bf3f625d6fecf79"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"67b6c05f0a1acfd9c3c3a8c709cfed0446196059","unresolved":true,"context_lines":[{"line_number":702,"context_line":"                \"Not constructor but instance() should be used.\")"},{"line_number":703,"context_line":"        super(PrometheusPluginThreshold, self).__init__()"},{"line_number":704,"context_line":"        self.notification_callback \u003d None"},{"line_number":705,"context_line":"        self.notification_callback \u003d self.default_callback"},{"line_number":706,"context_line":"        PrometheusPluginThreshold._instance \u003d self"},{"line_number":707,"context_line":""},{"line_number":708,"context_line":"    def create_threshold(self, **kwargs):"}],"source_content_type":"text/x-python","patch_set":25,"id":"85f72d63_3a1c31d6","line":705,"updated":"2023-03-08 06:18:03.000000000","message":"I think the initialization with `None` is unnecessary.\n\n```\nself.notification_callback \u003d None\nself.notification_callback \u003d self.default_callback\n```\n-\u003e\n```\nself.notification_callback \u003d self.default_callback\n```","commit_id":"0048f07fd3abb9a6d79b9cc311fb4985c73c034d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"7fcf570f4a61c3222f5015890f250629cff12a84","unresolved":true,"context_lines":[{"line_number":702,"context_line":"                \"Not constructor but instance() should be used.\")"},{"line_number":703,"context_line":"        super(PrometheusPluginThreshold, self).__init__()"},{"line_number":704,"context_line":"        self.notification_callback \u003d None"},{"line_number":705,"context_line":"        self.notification_callback \u003d self.default_callback"},{"line_number":706,"context_line":"        PrometheusPluginThreshold._instance \u003d self"},{"line_number":707,"context_line":""},{"line_number":708,"context_line":"    def create_threshold(self, **kwargs):"}],"source_content_type":"text/x-python","patch_set":25,"id":"a4fe172e_9f9ab8e8","line":705,"in_reply_to":"85f72d63_3a1c31d6","updated":"2023-03-08 08:30:16.000000000","message":"I fixed it in patchset 26.","commit_id":"0048f07fd3abb9a6d79b9cc311fb4985c73c034d"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"bfa4c0ad28030aed72bef1e4e055af0771c70503","unresolved":false,"context_lines":[{"line_number":702,"context_line":"                \"Not constructor but instance() should be used.\")"},{"line_number":703,"context_line":"        super(PrometheusPluginThreshold, self).__init__()"},{"line_number":704,"context_line":"        self.notification_callback \u003d None"},{"line_number":705,"context_line":"        self.notification_callback \u003d self.default_callback"},{"line_number":706,"context_line":"        PrometheusPluginThreshold._instance \u003d self"},{"line_number":707,"context_line":""},{"line_number":708,"context_line":"    def create_threshold(self, **kwargs):"}],"source_content_type":"text/x-python","patch_set":25,"id":"fdb5c4e9_131adaaa","line":705,"in_reply_to":"a4fe172e_9f9ab8e8","updated":"2023-03-08 09:27:46.000000000","message":"Done","commit_id":"0048f07fd3abb9a6d79b9cc311fb4985c73c034d"}],"tacker/sol_refactored/conductor/vnfpm_driver_v2.py":[{"author":{"_account_id":31668,"deleted":true},"change_message_id":"a21d7446ba894cf9058e1eb91b90301c33c9198b","unresolved":true,"context_lines":[{"line_number":53,"context_line":"            # used to set \u0027pm_threshold_state_id\u0027 to"},{"line_number":54,"context_line":"            # prevent null value exceptions in \u0027coordinate\u0027"},{"line_number":55,"context_line":"            if threshold_state[\u0027id\u0027] is None:"},{"line_number":56,"context_line":"                threshold_state[\u0027id\u0027] \u003d f\u0027{uuidutils.generate_uuid()}0\u0027"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"            pm_threshold_state_id \u003d threshold_state[\u0027id\u0027]"},{"line_number":59,"context_line":"            pm_threshold_state \u003d ("}],"source_content_type":"text/x-python","patch_set":13,"id":"30ce5711_5126ba8a","line":56,"updated":"2023-02-27 06:23:10.000000000","message":"Instead of setting a fake UUID here, why not just leave it as None?\nIn create_or_update_pm_threshold_state of pm_threshold_utils, I felt that it would be better to determine whether pm_threshold_state_id is None, and if it is None, create a UUID and perform create processing.","commit_id":"684824f35fd01773b0d4e9d14eeeaad4709c08e6"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"41273f8fda983cfc1f00f66688f8468915ef945f","unresolved":true,"context_lines":[{"line_number":53,"context_line":"            # used to set \u0027pm_threshold_state_id\u0027 to"},{"line_number":54,"context_line":"            # prevent null value exceptions in \u0027coordinate\u0027"},{"line_number":55,"context_line":"            if threshold_state[\u0027id\u0027] is None:"},{"line_number":56,"context_line":"                threshold_state[\u0027id\u0027] \u003d f\u0027{uuidutils.generate_uuid()}0\u0027"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"            pm_threshold_state_id \u003d threshold_state[\u0027id\u0027]"},{"line_number":59,"context_line":"            pm_threshold_state \u003d ("}],"source_content_type":"text/x-python","patch_set":13,"id":"d5b5fb5e_40d192eb","line":56,"in_reply_to":"30ce5711_5126ba8a","updated":"2023-03-01 08:05:06.000000000","message":"At the beginning, I also wanted to do this, but considering that in `@coordinate.lock_resources`, if the input parameter is None, an error may be reported, so I didn\u0027t do it.","commit_id":"684824f35fd01773b0d4e9d14eeeaad4709c08e6"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"7659d01a1c866b671389894c2206d45c39b8215e","unresolved":false,"context_lines":[{"line_number":53,"context_line":"            # used to set \u0027pm_threshold_state_id\u0027 to"},{"line_number":54,"context_line":"            # prevent null value exceptions in \u0027coordinate\u0027"},{"line_number":55,"context_line":"            if threshold_state[\u0027id\u0027] is None:"},{"line_number":56,"context_line":"                threshold_state[\u0027id\u0027] \u003d f\u0027{uuidutils.generate_uuid()}0\u0027"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"            pm_threshold_state_id \u003d threshold_state[\u0027id\u0027]"},{"line_number":59,"context_line":"            pm_threshold_state \u003d ("}],"source_content_type":"text/x-python","patch_set":13,"id":"3368cb68_e7b8e8a4","line":56,"in_reply_to":"d1c1fee3_5639425c","updated":"2023-03-03 00:52:43.000000000","message":"Done","commit_id":"684824f35fd01773b0d4e9d14eeeaad4709c08e6"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"822e7028d5cf349c417f0ff6235675aeff7ec225","unresolved":true,"context_lines":[{"line_number":53,"context_line":"            # used to set \u0027pm_threshold_state_id\u0027 to"},{"line_number":54,"context_line":"            # prevent null value exceptions in \u0027coordinate\u0027"},{"line_number":55,"context_line":"            if threshold_state[\u0027id\u0027] is None:"},{"line_number":56,"context_line":"                threshold_state[\u0027id\u0027] \u003d f\u0027{uuidutils.generate_uuid()}0\u0027"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"            pm_threshold_state_id \u003d threshold_state[\u0027id\u0027]"},{"line_number":59,"context_line":"            pm_threshold_state \u003d ("}],"source_content_type":"text/x-python","patch_set":13,"id":"da66d3f4_324c6f78","line":56,"in_reply_to":"d5b5fb5e_40d192eb","updated":"2023-03-02 02:07:27.000000000","message":"Thank you for your explanation.\nI could understand the problem with setting None.\n\nBut creating a fake UUID is no good, so how about splitting \"create_or_update_pm_threshold_state\" into \"create_pm_threshold_state\" and \"update_pm_threshold_state\"?\n\nIf there\u0027s a reason these can\u0027t be separated, how about adding a create flag and setting \"True\" if the UUID is created?","commit_id":"684824f35fd01773b0d4e9d14eeeaad4709c08e6"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"bbef9a977ae4015d4fa99579206417a878a0c882","unresolved":true,"context_lines":[{"line_number":53,"context_line":"            # used to set \u0027pm_threshold_state_id\u0027 to"},{"line_number":54,"context_line":"            # prevent null value exceptions in \u0027coordinate\u0027"},{"line_number":55,"context_line":"            if threshold_state[\u0027id\u0027] is None:"},{"line_number":56,"context_line":"                threshold_state[\u0027id\u0027] \u003d f\u0027{uuidutils.generate_uuid()}0\u0027"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"            pm_threshold_state_id \u003d threshold_state[\u0027id\u0027]"},{"line_number":59,"context_line":"            pm_threshold_state \u003d ("}],"source_content_type":"text/x-python","patch_set":13,"id":"d1c1fee3_5639425c","line":56,"in_reply_to":"da66d3f4_324c6f78","updated":"2023-03-02 12:15:17.000000000","message":"I split them into two functions in patch 18.","commit_id":"684824f35fd01773b0d4e9d14eeeaad4709c08e6"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"205515ec6e2c288236f50270e6b08fc27466157c","unresolved":true,"context_lines":[{"line_number":53,"context_line":"            pm_threshold_state \u003d ("},{"line_number":54,"context_line":"                pm_threshold_utils.update_threshold_state_data("},{"line_number":55,"context_line":"                    context, threshold_state,"},{"line_number":56,"context_line":"                    threshold_state[\u0027thresholdId\u0027]))"},{"line_number":57,"context_line":"            datetime_now \u003d datetime.datetime.now(datetime.timezone.utc)"},{"line_number":58,"context_line":"            threshold \u003d pm_threshold_utils.get_pm_threshold("},{"line_number":59,"context_line":"                context, threshold_state[\u0027thresholdId\u0027])"}],"source_content_type":"text/x-python","patch_set":25,"id":"cd836b73_cf6837fd","line":56,"updated":"2023-03-08 06:28:13.000000000","message":"Since \"threshold_state\" is already set, I don\u0027t think a \"thresholdId\" needs to be set separately.","commit_id":"0048f07fd3abb9a6d79b9cc311fb4985c73c034d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"ffcbe62c7d93958ce4d3e37c19eefb313a24f4aa","unresolved":true,"context_lines":[{"line_number":53,"context_line":"            pm_threshold_state \u003d ("},{"line_number":54,"context_line":"                pm_threshold_utils.update_threshold_state_data("},{"line_number":55,"context_line":"                    context, threshold_state,"},{"line_number":56,"context_line":"                    threshold_state[\u0027thresholdId\u0027]))"},{"line_number":57,"context_line":"            datetime_now \u003d datetime.datetime.now(datetime.timezone.utc)"},{"line_number":58,"context_line":"            threshold \u003d pm_threshold_utils.get_pm_threshold("},{"line_number":59,"context_line":"                context, threshold_state[\u0027thresholdId\u0027])"}],"source_content_type":"text/x-python","patch_set":25,"id":"f7c48eb9_b8841cfa","line":56,"in_reply_to":"42af0a95_2ce10faa","updated":"2023-03-10 05:24:39.000000000","message":"I fixed it in patchset 27.","commit_id":"0048f07fd3abb9a6d79b9cc311fb4985c73c034d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"502d8a480ed50e06fb6674b5ae77b544b3d9472e","unresolved":true,"context_lines":[{"line_number":53,"context_line":"            pm_threshold_state \u003d ("},{"line_number":54,"context_line":"                pm_threshold_utils.update_threshold_state_data("},{"line_number":55,"context_line":"                    context, threshold_state,"},{"line_number":56,"context_line":"                    threshold_state[\u0027thresholdId\u0027]))"},{"line_number":57,"context_line":"            datetime_now \u003d datetime.datetime.now(datetime.timezone.utc)"},{"line_number":58,"context_line":"            threshold \u003d pm_threshold_utils.get_pm_threshold("},{"line_number":59,"context_line":"                context, threshold_state[\u0027thresholdId\u0027])"}],"source_content_type":"text/x-python","patch_set":25,"id":"42af0a95_2ce10faa","line":56,"in_reply_to":"97926913_461be6e7","updated":"2023-03-08 09:34:23.000000000","message":"Thank you for your explanation.\nI understand why it has to be set.\nIt seems better to create \"threshold_state_info\" in store_threshold_info and set it to update_threshold_state_data, what do you think?","commit_id":"0048f07fd3abb9a6d79b9cc311fb4985c73c034d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"7fcf570f4a61c3222f5015890f250629cff12a84","unresolved":true,"context_lines":[{"line_number":53,"context_line":"            pm_threshold_state \u003d ("},{"line_number":54,"context_line":"                pm_threshold_utils.update_threshold_state_data("},{"line_number":55,"context_line":"                    context, threshold_state,"},{"line_number":56,"context_line":"                    threshold_state[\u0027thresholdId\u0027]))"},{"line_number":57,"context_line":"            datetime_now \u003d datetime.datetime.now(datetime.timezone.utc)"},{"line_number":58,"context_line":"            threshold \u003d pm_threshold_utils.get_pm_threshold("},{"line_number":59,"context_line":"                context, threshold_state[\u0027thresholdId\u0027])"}],"source_content_type":"text/x-python","patch_set":25,"id":"97926913_461be6e7","line":56,"in_reply_to":"cd836b73_cf6837fd","updated":"2023-03-08 08:30:16.000000000","message":"The `thresholdId` here is used for `@coordinate.lock_resources(\u0027{threshold_id}\u0027)`.\nhttps://review.opendev.org/c/openstack/tacker/+/872831/25/tacker/sol_refactored/common/pm_threshold_utils.py#68","commit_id":"0048f07fd3abb9a6d79b9cc311fb4985c73c034d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"8f06305958ef940b7db0ad505c6afd11351558ea","unresolved":false,"context_lines":[{"line_number":53,"context_line":"            pm_threshold_state \u003d ("},{"line_number":54,"context_line":"                pm_threshold_utils.update_threshold_state_data("},{"line_number":55,"context_line":"                    context, threshold_state,"},{"line_number":56,"context_line":"                    threshold_state[\u0027thresholdId\u0027]))"},{"line_number":57,"context_line":"            datetime_now \u003d datetime.datetime.now(datetime.timezone.utc)"},{"line_number":58,"context_line":"            threshold \u003d pm_threshold_utils.get_pm_threshold("},{"line_number":59,"context_line":"                context, threshold_state[\u0027thresholdId\u0027])"}],"source_content_type":"text/x-python","patch_set":25,"id":"629450c5_2a0fa9c6","line":56,"in_reply_to":"f7c48eb9_b8841cfa","updated":"2023-03-10 07:29:52.000000000","message":"Done","commit_id":"0048f07fd3abb9a6d79b9cc311fb4985c73c034d"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"67b6c05f0a1acfd9c3c3a8c709cfed0446196059","unresolved":true,"context_lines":[{"line_number":57,"context_line":"            datetime_now \u003d datetime.datetime.now(datetime.timezone.utc)"},{"line_number":58,"context_line":"            threshold \u003d pm_threshold_utils.get_pm_threshold("},{"line_number":59,"context_line":"                context, threshold_state[\u0027thresholdId\u0027])"},{"line_number":60,"context_line":"            if pm_threshold_state[\u0027crossingDirection\u0027] !\u003d \"IN\":"},{"line_number":61,"context_line":"                notif_data \u003d pm_threshold_utils.make_threshold_notif_data("},{"line_number":62,"context_line":"                    datetime_now, pm_threshold_state,"},{"line_number":63,"context_line":"                    self.endpoint, threshold)"}],"source_content_type":"text/x-python","patch_set":25,"id":"0e41f257_f6079ca4","line":60,"updated":"2023-03-08 06:18:03.000000000","message":"`crossingDirection` is `UP` or `DOWN` in SOL003.\nCould you change the if condition?\n\n```\nif pm_threshold_state[\u0027crossingDirection\u0027] !\u003d \"IN\":\n```\n-\u003e\n```\nif pm_threshold_state[\u0027crossingDirection\u0027] in {\"UP\", \"DOWN\"}:\n```","commit_id":"0048f07fd3abb9a6d79b9cc311fb4985c73c034d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"7fcf570f4a61c3222f5015890f250629cff12a84","unresolved":true,"context_lines":[{"line_number":57,"context_line":"            datetime_now \u003d datetime.datetime.now(datetime.timezone.utc)"},{"line_number":58,"context_line":"            threshold \u003d pm_threshold_utils.get_pm_threshold("},{"line_number":59,"context_line":"                context, threshold_state[\u0027thresholdId\u0027])"},{"line_number":60,"context_line":"            if pm_threshold_state[\u0027crossingDirection\u0027] !\u003d \"IN\":"},{"line_number":61,"context_line":"                notif_data \u003d pm_threshold_utils.make_threshold_notif_data("},{"line_number":62,"context_line":"                    datetime_now, pm_threshold_state,"},{"line_number":63,"context_line":"                    self.endpoint, threshold)"}],"source_content_type":"text/x-python","patch_set":25,"id":"e8b4dafe_6c03df35","line":60,"in_reply_to":"0e41f257_f6079ca4","updated":"2023-03-08 08:30:16.000000000","message":"I fixed it in patchset 26.","commit_id":"0048f07fd3abb9a6d79b9cc311fb4985c73c034d"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"bfa4c0ad28030aed72bef1e4e055af0771c70503","unresolved":false,"context_lines":[{"line_number":57,"context_line":"            datetime_now \u003d datetime.datetime.now(datetime.timezone.utc)"},{"line_number":58,"context_line":"            threshold \u003d pm_threshold_utils.get_pm_threshold("},{"line_number":59,"context_line":"                context, threshold_state[\u0027thresholdId\u0027])"},{"line_number":60,"context_line":"            if pm_threshold_state[\u0027crossingDirection\u0027] !\u003d \"IN\":"},{"line_number":61,"context_line":"                notif_data \u003d pm_threshold_utils.make_threshold_notif_data("},{"line_number":62,"context_line":"                    datetime_now, pm_threshold_state,"},{"line_number":63,"context_line":"                    self.endpoint, threshold)"}],"source_content_type":"text/x-python","patch_set":25,"id":"f1e9587c_57ed435d","line":60,"in_reply_to":"e8b4dafe_6c03df35","updated":"2023-03-08 09:27:46.000000000","message":"Done","commit_id":"0048f07fd3abb9a6d79b9cc311fb4985c73c034d"}],"tacker/sol_refactored/controller/vnfpm_v2.py":[{"author":{"_account_id":31668,"deleted":true},"change_message_id":"a21d7446ba894cf9058e1eb91b90301c33c9198b","unresolved":true,"context_lines":[{"line_number":304,"context_line":"        if body[\"criteria\"][\"thresholdType\"] !\u003d \"SIMPLE\":"},{"line_number":305,"context_line":"            raise sol_ex.PMThresholdInvalidRequest"},{"line_number":306,"context_line":"        # check criteria.thresholdType and criteria.ThresholdDetails"},{"line_number":307,"context_line":"        if (body[\"criteria\"][\"thresholdType\"] \u003d\u003d \"SIMPLE\""},{"line_number":308,"context_line":"                and not body[\"criteria\"].get(\"simpleThresholdDetails\")):"},{"line_number":309,"context_line":"            raise sol_ex.PMThresholdInvalidRequest"},{"line_number":310,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"f4aa21e8_92ffa134","line":307,"updated":"2023-02-27 06:23:10.000000000","message":"Isn\u0027t the following condition unnecessary?\n* body[\"criteria\"][\"thresholdType\"] \u003d\u003d \"SIMPLE\"","commit_id":"684824f35fd01773b0d4e9d14eeeaad4709c08e6"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"822e7028d5cf349c417f0ff6235675aeff7ec225","unresolved":false,"context_lines":[{"line_number":304,"context_line":"        if body[\"criteria\"][\"thresholdType\"] !\u003d \"SIMPLE\":"},{"line_number":305,"context_line":"            raise sol_ex.PMThresholdInvalidRequest"},{"line_number":306,"context_line":"        # check criteria.thresholdType and criteria.ThresholdDetails"},{"line_number":307,"context_line":"        if (body[\"criteria\"][\"thresholdType\"] \u003d\u003d \"SIMPLE\""},{"line_number":308,"context_line":"                and not body[\"criteria\"].get(\"simpleThresholdDetails\")):"},{"line_number":309,"context_line":"            raise sol_ex.PMThresholdInvalidRequest"},{"line_number":310,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"9ba776eb_c0560222","line":307,"in_reply_to":"e07453f5_050fb9cb","updated":"2023-03-02 02:07:27.000000000","message":"Done","commit_id":"684824f35fd01773b0d4e9d14eeeaad4709c08e6"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"41273f8fda983cfc1f00f66688f8468915ef945f","unresolved":true,"context_lines":[{"line_number":304,"context_line":"        if body[\"criteria\"][\"thresholdType\"] !\u003d \"SIMPLE\":"},{"line_number":305,"context_line":"            raise sol_ex.PMThresholdInvalidRequest"},{"line_number":306,"context_line":"        # check criteria.thresholdType and criteria.ThresholdDetails"},{"line_number":307,"context_line":"        if (body[\"criteria\"][\"thresholdType\"] \u003d\u003d \"SIMPLE\""},{"line_number":308,"context_line":"                and not body[\"criteria\"].get(\"simpleThresholdDetails\")):"},{"line_number":309,"context_line":"            raise sol_ex.PMThresholdInvalidRequest"},{"line_number":310,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"e07453f5_050fb9cb","line":307,"in_reply_to":"f4aa21e8_92ffa134","updated":"2023-03-01 08:05:06.000000000","message":"I removed this judgment condition.","commit_id":"684824f35fd01773b0d4e9d14eeeaad4709c08e6"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"a21d7446ba894cf9058e1eb91b90301c33c9198b","unresolved":true,"context_lines":[{"line_number":358,"context_line":"        try:"},{"line_number":359,"context_line":"            self.threshold_plugin.create_threshold("},{"line_number":360,"context_line":"                context\u003dcontext,"},{"line_number":361,"context_line":"                pm_threshold\u003dthreshold,)"},{"line_number":362,"context_line":"        except sol_ex.PrometheusPluginError as e:"},{"line_number":363,"context_line":"            LOG.error(\"Failed to create PM threshold: %s\", e.args[0])"},{"line_number":364,"context_line":"            raise sol_ex.PrometheusSettingFailed from e"}],"source_content_type":"text/x-python","patch_set":13,"id":"82459830_98f18859","line":361,"updated":"2023-02-27 06:23:10.000000000","message":"nit: pm_threshold\u003dthreshold,) -\u003e pm_threshold\u003dthreshold)","commit_id":"684824f35fd01773b0d4e9d14eeeaad4709c08e6"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"822e7028d5cf349c417f0ff6235675aeff7ec225","unresolved":false,"context_lines":[{"line_number":358,"context_line":"        try:"},{"line_number":359,"context_line":"            self.threshold_plugin.create_threshold("},{"line_number":360,"context_line":"                context\u003dcontext,"},{"line_number":361,"context_line":"                pm_threshold\u003dthreshold,)"},{"line_number":362,"context_line":"        except sol_ex.PrometheusPluginError as e:"},{"line_number":363,"context_line":"            LOG.error(\"Failed to create PM threshold: %s\", e.args[0])"},{"line_number":364,"context_line":"            raise sol_ex.PrometheusSettingFailed from e"}],"source_content_type":"text/x-python","patch_set":13,"id":"e1dd0a98_935f36ff","line":361,"in_reply_to":"75f554c2_1951a44c","updated":"2023-03-02 02:07:27.000000000","message":"Done","commit_id":"684824f35fd01773b0d4e9d14eeeaad4709c08e6"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"41273f8fda983cfc1f00f66688f8468915ef945f","unresolved":true,"context_lines":[{"line_number":358,"context_line":"        try:"},{"line_number":359,"context_line":"            self.threshold_plugin.create_threshold("},{"line_number":360,"context_line":"                context\u003dcontext,"},{"line_number":361,"context_line":"                pm_threshold\u003dthreshold,)"},{"line_number":362,"context_line":"        except sol_ex.PrometheusPluginError as e:"},{"line_number":363,"context_line":"            LOG.error(\"Failed to create PM threshold: %s\", e.args[0])"},{"line_number":364,"context_line":"            raise sol_ex.PrometheusSettingFailed from e"}],"source_content_type":"text/x-python","patch_set":13,"id":"75f554c2_1951a44c","line":361,"in_reply_to":"82459830_98f18859","updated":"2023-03-01 08:05:06.000000000","message":"I fixed it in patchset 14.","commit_id":"684824f35fd01773b0d4e9d14eeeaad4709c08e6"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"a21d7446ba894cf9058e1eb91b90301c33c9198b","unresolved":true,"context_lines":[{"line_number":360,"context_line":"                context\u003dcontext,"},{"line_number":361,"context_line":"                pm_threshold\u003dthreshold,)"},{"line_number":362,"context_line":"        except sol_ex.PrometheusPluginError as e:"},{"line_number":363,"context_line":"            LOG.error(\"Failed to create PM threshold: %s\", e.args[0])"},{"line_number":364,"context_line":"            raise sol_ex.PrometheusSettingFailed from e"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"        threshold.create(context)"}],"source_content_type":"text/x-python","patch_set":13,"id":"ada144d0_47087494","line":363,"updated":"2023-02-27 06:23:10.000000000","message":"nit: threshold -\u003e Threshold","commit_id":"684824f35fd01773b0d4e9d14eeeaad4709c08e6"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"41273f8fda983cfc1f00f66688f8468915ef945f","unresolved":true,"context_lines":[{"line_number":360,"context_line":"                context\u003dcontext,"},{"line_number":361,"context_line":"                pm_threshold\u003dthreshold,)"},{"line_number":362,"context_line":"        except sol_ex.PrometheusPluginError as e:"},{"line_number":363,"context_line":"            LOG.error(\"Failed to create PM threshold: %s\", e.args[0])"},{"line_number":364,"context_line":"            raise sol_ex.PrometheusSettingFailed from e"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"        threshold.create(context)"}],"source_content_type":"text/x-python","patch_set":13,"id":"f00eef67_9e55afd6","line":363,"in_reply_to":"ada144d0_47087494","updated":"2023-03-01 08:05:06.000000000","message":"I fixed it in patchset 14.","commit_id":"684824f35fd01773b0d4e9d14eeeaad4709c08e6"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"822e7028d5cf349c417f0ff6235675aeff7ec225","unresolved":false,"context_lines":[{"line_number":360,"context_line":"                context\u003dcontext,"},{"line_number":361,"context_line":"                pm_threshold\u003dthreshold,)"},{"line_number":362,"context_line":"        except sol_ex.PrometheusPluginError as e:"},{"line_number":363,"context_line":"            LOG.error(\"Failed to create PM threshold: %s\", e.args[0])"},{"line_number":364,"context_line":"            raise sol_ex.PrometheusSettingFailed from e"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"        threshold.create(context)"}],"source_content_type":"text/x-python","patch_set":13,"id":"bcdfe5cc_a1d95733","line":363,"in_reply_to":"f00eef67_9e55afd6","updated":"2023-03-02 02:07:27.000000000","message":"Done","commit_id":"684824f35fd01773b0d4e9d14eeeaad4709c08e6"},{"author":{"_account_id":32707,"name":"Kenta Fukaya","email":"kenta.fukaya.xv@hco.ntt.co.jp","username":"fukayan"},"change_message_id":"f3c1b05229277a92587727aea80102a7043230f3","unresolved":true,"context_lines":[{"line_number":323,"context_line":"        if inst.instantiationState \u003d\u003d \u0027NOT_INSTANTIATED\u0027:"},{"line_number":324,"context_line":"            raise sol_ex.VnfInstanceIsNotInstantiated(inst_id\u003dinst_id)"},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"        # threshold.criteria"},{"line_number":327,"context_line":"        threshold_criteria \u003d objects.ThresholdCriteriaV2("},{"line_number":328,"context_line":"            performanceMetric\u003dperformance_metric,"},{"line_number":329,"context_line":"            thresholdType\u003dbody[\"criteria\"][\u0027thresholdType\u0027]"}],"source_content_type":"text/x-python","patch_set":17,"id":"2fe916eb_918ef6b2","line":326,"updated":"2023-03-02 05:29:51.000000000","message":"Sorry I can\u0027t understand this notes.\nPlease write more information like L318 or remove this notes.","commit_id":"8fc611a2db8c615c44f8fdf276148a5cd465cfba"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"bbef9a977ae4015d4fa99579206417a878a0c882","unresolved":true,"context_lines":[{"line_number":323,"context_line":"        if inst.instantiationState \u003d\u003d \u0027NOT_INSTANTIATED\u0027:"},{"line_number":324,"context_line":"            raise sol_ex.VnfInstanceIsNotInstantiated(inst_id\u003dinst_id)"},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"        # threshold.criteria"},{"line_number":327,"context_line":"        threshold_criteria \u003d objects.ThresholdCriteriaV2("},{"line_number":328,"context_line":"            performanceMetric\u003dperformance_metric,"},{"line_number":329,"context_line":"            thresholdType\u003dbody[\"criteria\"][\u0027thresholdType\u0027]"}],"source_content_type":"text/x-python","patch_set":17,"id":"f84136d4_9738e9a4","line":326,"in_reply_to":"2fe916eb_918ef6b2","updated":"2023-03-02 12:15:17.000000000","message":"I removed it in patchset 18.","commit_id":"8fc611a2db8c615c44f8fdf276148a5cd465cfba"},{"author":{"_account_id":32707,"name":"Kenta Fukaya","email":"kenta.fukaya.xv@hco.ntt.co.jp","username":"fukayan"},"change_message_id":"4397f88c6712e96649759bd8d0a9a9336838e6c6","unresolved":false,"context_lines":[{"line_number":323,"context_line":"        if inst.instantiationState \u003d\u003d \u0027NOT_INSTANTIATED\u0027:"},{"line_number":324,"context_line":"            raise sol_ex.VnfInstanceIsNotInstantiated(inst_id\u003dinst_id)"},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"        # threshold.criteria"},{"line_number":327,"context_line":"        threshold_criteria \u003d objects.ThresholdCriteriaV2("},{"line_number":328,"context_line":"            performanceMetric\u003dperformance_metric,"},{"line_number":329,"context_line":"            thresholdType\u003dbody[\"criteria\"][\u0027thresholdType\u0027]"}],"source_content_type":"text/x-python","patch_set":17,"id":"b35c97e5_6ad3681b","line":326,"in_reply_to":"f84136d4_9738e9a4","updated":"2023-03-10 02:22:22.000000000","message":"Done","commit_id":"8fc611a2db8c615c44f8fdf276148a5cd465cfba"},{"author":{"_account_id":32707,"name":"Kenta Fukaya","email":"kenta.fukaya.xv@hco.ntt.co.jp","username":"fukayan"},"change_message_id":"f3c1b05229277a92587727aea80102a7043230f3","unresolved":true,"context_lines":[{"line_number":334,"context_line":"                hysteresis\u003dthreshold_hysteresis)"},{"line_number":335,"context_line":"            threshold_criteria.simpleThresholdDetails \u003d threshold_details"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"        # threshold"},{"line_number":338,"context_line":"        threshold_id \u003d uuidutils.generate_uuid()"},{"line_number":339,"context_line":"        threshold \u003d objects.ThresholdV2("},{"line_number":340,"context_line":"            id\u003dthreshold_id,"}],"source_content_type":"text/x-python","patch_set":17,"id":"a1a0f382_d381511b","line":337,"updated":"2023-03-02 05:29:51.000000000","message":"ditto","commit_id":"8fc611a2db8c615c44f8fdf276148a5cd465cfba"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"bbef9a977ae4015d4fa99579206417a878a0c882","unresolved":true,"context_lines":[{"line_number":334,"context_line":"                hysteresis\u003dthreshold_hysteresis)"},{"line_number":335,"context_line":"            threshold_criteria.simpleThresholdDetails \u003d threshold_details"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"        # threshold"},{"line_number":338,"context_line":"        threshold_id \u003d uuidutils.generate_uuid()"},{"line_number":339,"context_line":"        threshold \u003d objects.ThresholdV2("},{"line_number":340,"context_line":"            id\u003dthreshold_id,"}],"source_content_type":"text/x-python","patch_set":17,"id":"d14d20b9_2f1e03f0","line":337,"in_reply_to":"a1a0f382_d381511b","updated":"2023-03-02 12:15:17.000000000","message":"I removed it in patchset 18.","commit_id":"8fc611a2db8c615c44f8fdf276148a5cd465cfba"},{"author":{"_account_id":32707,"name":"Kenta Fukaya","email":"kenta.fukaya.xv@hco.ntt.co.jp","username":"fukayan"},"change_message_id":"4397f88c6712e96649759bd8d0a9a9336838e6c6","unresolved":false,"context_lines":[{"line_number":334,"context_line":"                hysteresis\u003dthreshold_hysteresis)"},{"line_number":335,"context_line":"            threshold_criteria.simpleThresholdDetails \u003d threshold_details"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"        # threshold"},{"line_number":338,"context_line":"        threshold_id \u003d uuidutils.generate_uuid()"},{"line_number":339,"context_line":"        threshold \u003d objects.ThresholdV2("},{"line_number":340,"context_line":"            id\u003dthreshold_id,"}],"source_content_type":"text/x-python","patch_set":17,"id":"53460a32_3f0b071e","line":337,"in_reply_to":"d14d20b9_2f1e03f0","updated":"2023-03-10 02:22:22.000000000","message":"Done","commit_id":"8fc611a2db8c615c44f8fdf276148a5cd465cfba"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"67b6c05f0a1acfd9c3c3a8c709cfed0446196059","unresolved":true,"context_lines":[{"line_number":327,"context_line":"            performanceMetric\u003dperformance_metric,"},{"line_number":328,"context_line":"            thresholdType\u003dbody[\"criteria\"][\u0027thresholdType\u0027]"},{"line_number":329,"context_line":"        )"},{"line_number":330,"context_line":"        if body[\u0027criteria\u0027].get(\u0027simpleThresholdDetails\u0027):"},{"line_number":331,"context_line":"            threshold_details \u003d objects.SimpleThresholdDetails("},{"line_number":332,"context_line":"                thresholdValue\u003dthreshold_value,"},{"line_number":333,"context_line":"                hysteresis\u003dthreshold_hysteresis)"}],"source_content_type":"text/x-python","patch_set":24,"id":"b3b93bd9_ef767996","line":330,"updated":"2023-03-08 06:18:03.000000000","message":"`body[\u0027criteria\u0027].get(\u0027simpleThresholdDetails\u0027)` is already checked in line 310.","commit_id":"ab7e028ce5fe89cf6ee2d1cc9bf3f625d6fecf79"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"bfa4c0ad28030aed72bef1e4e055af0771c70503","unresolved":false,"context_lines":[{"line_number":327,"context_line":"            performanceMetric\u003dperformance_metric,"},{"line_number":328,"context_line":"            thresholdType\u003dbody[\"criteria\"][\u0027thresholdType\u0027]"},{"line_number":329,"context_line":"        )"},{"line_number":330,"context_line":"        if body[\u0027criteria\u0027].get(\u0027simpleThresholdDetails\u0027):"},{"line_number":331,"context_line":"            threshold_details \u003d objects.SimpleThresholdDetails("},{"line_number":332,"context_line":"                thresholdValue\u003dthreshold_value,"},{"line_number":333,"context_line":"                hysteresis\u003dthreshold_hysteresis)"}],"source_content_type":"text/x-python","patch_set":24,"id":"93d4627b_ea72be3c","line":330,"in_reply_to":"7a63ecde_7f9b8f0c","updated":"2023-03-08 09:27:46.000000000","message":"Done","commit_id":"ab7e028ce5fe89cf6ee2d1cc9bf3f625d6fecf79"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"7fcf570f4a61c3222f5015890f250629cff12a84","unresolved":true,"context_lines":[{"line_number":327,"context_line":"            performanceMetric\u003dperformance_metric,"},{"line_number":328,"context_line":"            thresholdType\u003dbody[\"criteria\"][\u0027thresholdType\u0027]"},{"line_number":329,"context_line":"        )"},{"line_number":330,"context_line":"        if body[\u0027criteria\u0027].get(\u0027simpleThresholdDetails\u0027):"},{"line_number":331,"context_line":"            threshold_details \u003d objects.SimpleThresholdDetails("},{"line_number":332,"context_line":"                thresholdValue\u003dthreshold_value,"},{"line_number":333,"context_line":"                hysteresis\u003dthreshold_hysteresis)"}],"source_content_type":"text/x-python","patch_set":24,"id":"7a63ecde_7f9b8f0c","line":330,"in_reply_to":"b3b93bd9_ef767996","updated":"2023-03-08 08:30:16.000000000","message":"I removed it in patchset 26.","commit_id":"ab7e028ce5fe89cf6ee2d1cc9bf3f625d6fecf79"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"502d8a480ed50e06fb6674b5ae77b544b3d9472e","unresolved":true,"context_lines":[{"line_number":297,"context_line":"        performance_metric \u003d body[\"criteria\"][\u0027performanceMetric\u0027]"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"        # Check if the type in performance metric matches the standard type."},{"line_number":300,"context_line":"        if performance_metric:"},{"line_number":301,"context_line":"            _check_metric_and_obj_type(performance_metric, object_type)"},{"line_number":302,"context_line":"        else:"},{"line_number":303,"context_line":"            raise sol_ex.PMThresholdInvalidRequest"}],"source_content_type":"text/x-python","patch_set":26,"id":"43095ae2_7aefc862","line":300,"updated":"2023-03-08 09:34:23.000000000","message":"Since \"performanceMetric\" has already been checked in the schema, isn\u0027t this conditional branch unnecessary?","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"8f06305958ef940b7db0ad505c6afd11351558ea","unresolved":false,"context_lines":[{"line_number":297,"context_line":"        performance_metric \u003d body[\"criteria\"][\u0027performanceMetric\u0027]"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"        # Check if the type in performance metric matches the standard type."},{"line_number":300,"context_line":"        if performance_metric:"},{"line_number":301,"context_line":"            _check_metric_and_obj_type(performance_metric, object_type)"},{"line_number":302,"context_line":"        else:"},{"line_number":303,"context_line":"            raise sol_ex.PMThresholdInvalidRequest"}],"source_content_type":"text/x-python","patch_set":26,"id":"60d66afa_197b1148","line":300,"in_reply_to":"0ee435dd_616081cd","updated":"2023-03-10 07:29:52.000000000","message":"Done","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"ffcbe62c7d93958ce4d3e37c19eefb313a24f4aa","unresolved":true,"context_lines":[{"line_number":297,"context_line":"        performance_metric \u003d body[\"criteria\"][\u0027performanceMetric\u0027]"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"        # Check if the type in performance metric matches the standard type."},{"line_number":300,"context_line":"        if performance_metric:"},{"line_number":301,"context_line":"            _check_metric_and_obj_type(performance_metric, object_type)"},{"line_number":302,"context_line":"        else:"},{"line_number":303,"context_line":"            raise sol_ex.PMThresholdInvalidRequest"}],"source_content_type":"text/x-python","patch_set":26,"id":"0ee435dd_616081cd","line":300,"in_reply_to":"43095ae2_7aefc862","updated":"2023-03-10 05:24:39.000000000","message":"I removed this check.","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"502d8a480ed50e06fb6674b5ae77b544b3d9472e","unresolved":true,"context_lines":[{"line_number":317,"context_line":""},{"line_number":318,"context_line":"        # check vnf instance status"},{"line_number":319,"context_line":"        inst_id \u003d body.get(\"objectInstanceId\")"},{"line_number":320,"context_line":"        if not inst_id:"},{"line_number":321,"context_line":"            raise sol_ex.PMThresholdInvalidRequest"},{"line_number":322,"context_line":"        inst \u003d inst_utils.get_inst(context, inst_id)"},{"line_number":323,"context_line":"        if inst.instantiationState \u003d\u003d \u0027NOT_INSTANTIATED\u0027:"}],"source_content_type":"text/x-python","patch_set":26,"id":"a528009b_b6689c4f","line":320,"updated":"2023-03-08 09:34:23.000000000","message":"Since \"objectInstanceId\" has already been checked in the schema, isn\u0027t this conditional branch unnecessary?","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"8f06305958ef940b7db0ad505c6afd11351558ea","unresolved":false,"context_lines":[{"line_number":317,"context_line":""},{"line_number":318,"context_line":"        # check vnf instance status"},{"line_number":319,"context_line":"        inst_id \u003d body.get(\"objectInstanceId\")"},{"line_number":320,"context_line":"        if not inst_id:"},{"line_number":321,"context_line":"            raise sol_ex.PMThresholdInvalidRequest"},{"line_number":322,"context_line":"        inst \u003d inst_utils.get_inst(context, inst_id)"},{"line_number":323,"context_line":"        if inst.instantiationState \u003d\u003d \u0027NOT_INSTANTIATED\u0027:"}],"source_content_type":"text/x-python","patch_set":26,"id":"663f5df2_a35b1019","line":320,"in_reply_to":"62783d02_eef25df1","updated":"2023-03-10 07:29:52.000000000","message":"Done","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"ffcbe62c7d93958ce4d3e37c19eefb313a24f4aa","unresolved":true,"context_lines":[{"line_number":317,"context_line":""},{"line_number":318,"context_line":"        # check vnf instance status"},{"line_number":319,"context_line":"        inst_id \u003d body.get(\"objectInstanceId\")"},{"line_number":320,"context_line":"        if not inst_id:"},{"line_number":321,"context_line":"            raise sol_ex.PMThresholdInvalidRequest"},{"line_number":322,"context_line":"        inst \u003d inst_utils.get_inst(context, inst_id)"},{"line_number":323,"context_line":"        if inst.instantiationState \u003d\u003d \u0027NOT_INSTANTIATED\u0027:"}],"source_content_type":"text/x-python","patch_set":26,"id":"62783d02_eef25df1","line":320,"in_reply_to":"a528009b_b6689c4f","updated":"2023-03-10 05:24:39.000000000","message":"I removed this check.","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"502d8a480ed50e06fb6674b5ae77b544b3d9472e","unresolved":true,"context_lines":[{"line_number":335,"context_line":"        threshold_id \u003d uuidutils.generate_uuid()"},{"line_number":336,"context_line":"        threshold \u003d objects.ThresholdV2("},{"line_number":337,"context_line":"            id\u003dthreshold_id,"},{"line_number":338,"context_line":"            objectType\u003dbody[\"objectType\"],"},{"line_number":339,"context_line":"            objectInstanceId\u003dinst_id,"},{"line_number":340,"context_line":"            criteria\u003dthreshold_criteria,"},{"line_number":341,"context_line":"            callbackUri\u003dbody[\"callbackUri\"],"}],"source_content_type":"text/x-python","patch_set":26,"id":"887cb957_a92ba1c0","line":338,"updated":"2023-03-08 09:34:23.000000000","message":"The following is better.\n* objectType\u003dobject_type","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"ffcbe62c7d93958ce4d3e37c19eefb313a24f4aa","unresolved":true,"context_lines":[{"line_number":335,"context_line":"        threshold_id \u003d uuidutils.generate_uuid()"},{"line_number":336,"context_line":"        threshold \u003d objects.ThresholdV2("},{"line_number":337,"context_line":"            id\u003dthreshold_id,"},{"line_number":338,"context_line":"            objectType\u003dbody[\"objectType\"],"},{"line_number":339,"context_line":"            objectInstanceId\u003dinst_id,"},{"line_number":340,"context_line":"            criteria\u003dthreshold_criteria,"},{"line_number":341,"context_line":"            callbackUri\u003dbody[\"callbackUri\"],"}],"source_content_type":"text/x-python","patch_set":26,"id":"e73768ed_5f1a94e7","line":338,"in_reply_to":"887cb957_a92ba1c0","updated":"2023-03-10 05:24:39.000000000","message":"I fixed it in patchset 27.","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"8f06305958ef940b7db0ad505c6afd11351558ea","unresolved":false,"context_lines":[{"line_number":335,"context_line":"        threshold_id \u003d uuidutils.generate_uuid()"},{"line_number":336,"context_line":"        threshold \u003d objects.ThresholdV2("},{"line_number":337,"context_line":"            id\u003dthreshold_id,"},{"line_number":338,"context_line":"            objectType\u003dbody[\"objectType\"],"},{"line_number":339,"context_line":"            objectInstanceId\u003dinst_id,"},{"line_number":340,"context_line":"            criteria\u003dthreshold_criteria,"},{"line_number":341,"context_line":"            callbackUri\u003dbody[\"callbackUri\"],"}],"source_content_type":"text/x-python","patch_set":26,"id":"1bbf3754_2ee07181","line":338,"in_reply_to":"e73768ed_5f1a94e7","updated":"2023-03-10 07:29:52.000000000","message":"Done","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"502d8a480ed50e06fb6674b5ae77b544b3d9472e","unresolved":true,"context_lines":[{"line_number":343,"context_line":"        if body.get(\"subObjectInstanceIds\"):"},{"line_number":344,"context_line":"            threshold.subObjectInstanceIds \u003d body[\"subObjectInstanceIds\"]"},{"line_number":345,"context_line":"        metadata \u003d body.get(\u0027metadata\u0027)"},{"line_number":346,"context_line":"        if metadata:"},{"line_number":347,"context_line":"            threshold.metadata \u003d metadata"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"        auth_req \u003d body.get(\u0027authentication\u0027)"}],"source_content_type":"text/x-python","patch_set":26,"id":"4758a1f8_0d46a96c","line":346,"updated":"2023-03-08 09:34:23.000000000","message":"Cardinarity of metadata is 1 in Spec.\nhttps://specs.openstack.org/openstack/tacker-specs/specs/2023.1/support-threshold-pm-interface.html\nShouldn\u0027t it be better to raise PMThresholdInvalidRequest if it\u0027s not set?","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"ffcbe62c7d93958ce4d3e37c19eefb313a24f4aa","unresolved":true,"context_lines":[{"line_number":343,"context_line":"        if body.get(\"subObjectInstanceIds\"):"},{"line_number":344,"context_line":"            threshold.subObjectInstanceIds \u003d body[\"subObjectInstanceIds\"]"},{"line_number":345,"context_line":"        metadata \u003d body.get(\u0027metadata\u0027)"},{"line_number":346,"context_line":"        if metadata:"},{"line_number":347,"context_line":"            threshold.metadata \u003d metadata"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"        auth_req \u003d body.get(\u0027authentication\u0027)"}],"source_content_type":"text/x-python","patch_set":26,"id":"d0843cdf_d1f2d02f","line":346,"in_reply_to":"4758a1f8_0d46a96c","updated":"2023-03-10 05:24:39.000000000","message":"I fixed it in patchset 27.","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"8f06305958ef940b7db0ad505c6afd11351558ea","unresolved":false,"context_lines":[{"line_number":343,"context_line":"        if body.get(\"subObjectInstanceIds\"):"},{"line_number":344,"context_line":"            threshold.subObjectInstanceIds \u003d body[\"subObjectInstanceIds\"]"},{"line_number":345,"context_line":"        metadata \u003d body.get(\u0027metadata\u0027)"},{"line_number":346,"context_line":"        if metadata:"},{"line_number":347,"context_line":"            threshold.metadata \u003d metadata"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"        auth_req \u003d body.get(\u0027authentication\u0027)"}],"source_content_type":"text/x-python","patch_set":26,"id":"521f335e_97d0f908","line":346,"in_reply_to":"d0843cdf_d1f2d02f","updated":"2023-03-10 07:29:52.000000000","message":"Done","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"}],"tacker/sol_refactored/controller/vnfpm_view.py":[{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"bfa4c0ad28030aed72bef1e4e055af0771c70503","unresolved":true,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        resp \u003d threshold.to_dict()"},{"line_number":71,"context_line":"        if resp.get(\u0027authentication\u0027):"},{"line_number":72,"context_line":"            resp.pop(\u0027authentication\u0027, None)"},{"line_number":73,"context_line":"        if resp.get(\u0027metadata\u0027):"},{"line_number":74,"context_line":"            resp.pop(\u0027metadata\u0027, None)"},{"line_number":75,"context_line":"        if selector is not None:"}],"source_content_type":"text/x-python","patch_set":26,"id":"868849f3_61bfc353","line":72,"updated":"2023-03-08 09:27:46.000000000","message":"If the value of `resp.get(\u0027authentication\u0027)` is empty, should the key remain?\nif key is unneccesary, I think `if resp.get(\u0027authentication\u0027):`is also unneccesary.\n\n```\nif resp.get(\u0027authentication\u0027):\n    resp.pop(\u0027authentication\u0027, None)\n```\n-\u003e\n```\nresp.pop(\u0027authentication\u0027, None)\n```","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"ffcbe62c7d93958ce4d3e37c19eefb313a24f4aa","unresolved":true,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        resp \u003d threshold.to_dict()"},{"line_number":71,"context_line":"        if resp.get(\u0027authentication\u0027):"},{"line_number":72,"context_line":"            resp.pop(\u0027authentication\u0027, None)"},{"line_number":73,"context_line":"        if resp.get(\u0027metadata\u0027):"},{"line_number":74,"context_line":"            resp.pop(\u0027metadata\u0027, None)"},{"line_number":75,"context_line":"        if selector is not None:"}],"source_content_type":"text/x-python","patch_set":26,"id":"aae0f5ac_2529d8ff","line":72,"in_reply_to":"868849f3_61bfc353","updated":"2023-03-10 05:24:39.000000000","message":"I removed the if judgment.","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"8096f634da5f4bec8e0dc92cb09c6a7255f1dc94","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        resp \u003d threshold.to_dict()"},{"line_number":71,"context_line":"        if resp.get(\u0027authentication\u0027):"},{"line_number":72,"context_line":"            resp.pop(\u0027authentication\u0027, None)"},{"line_number":73,"context_line":"        if resp.get(\u0027metadata\u0027):"},{"line_number":74,"context_line":"            resp.pop(\u0027metadata\u0027, None)"},{"line_number":75,"context_line":"        if selector is not None:"}],"source_content_type":"text/x-python","patch_set":26,"id":"c6aa322c_7963afa4","line":72,"in_reply_to":"aae0f5ac_2529d8ff","updated":"2023-03-10 07:12:53.000000000","message":"Done","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"bfa4c0ad28030aed72bef1e4e055af0771c70503","unresolved":true,"context_lines":[{"line_number":71,"context_line":"        if resp.get(\u0027authentication\u0027):"},{"line_number":72,"context_line":"            resp.pop(\u0027authentication\u0027, None)"},{"line_number":73,"context_line":"        if resp.get(\u0027metadata\u0027):"},{"line_number":74,"context_line":"            resp.pop(\u0027metadata\u0027, None)"},{"line_number":75,"context_line":"        if selector is not None:"},{"line_number":76,"context_line":"            resp \u003d selector.filter(threshold, resp)"},{"line_number":77,"context_line":"        return resp"}],"source_content_type":"text/x-python","patch_set":26,"id":"f6d81b61_7ecde5a0","line":74,"updated":"2023-03-08 09:27:46.000000000","message":"ditto.","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"8096f634da5f4bec8e0dc92cb09c6a7255f1dc94","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        if resp.get(\u0027authentication\u0027):"},{"line_number":72,"context_line":"            resp.pop(\u0027authentication\u0027, None)"},{"line_number":73,"context_line":"        if resp.get(\u0027metadata\u0027):"},{"line_number":74,"context_line":"            resp.pop(\u0027metadata\u0027, None)"},{"line_number":75,"context_line":"        if selector is not None:"},{"line_number":76,"context_line":"            resp \u003d selector.filter(threshold, resp)"},{"line_number":77,"context_line":"        return resp"}],"source_content_type":"text/x-python","patch_set":26,"id":"886c9e76_0ed427e7","line":74,"in_reply_to":"2da30af4_42329a51","updated":"2023-03-10 07:12:53.000000000","message":"Done","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"ffcbe62c7d93958ce4d3e37c19eefb313a24f4aa","unresolved":true,"context_lines":[{"line_number":71,"context_line":"        if resp.get(\u0027authentication\u0027):"},{"line_number":72,"context_line":"            resp.pop(\u0027authentication\u0027, None)"},{"line_number":73,"context_line":"        if resp.get(\u0027metadata\u0027):"},{"line_number":74,"context_line":"            resp.pop(\u0027metadata\u0027, None)"},{"line_number":75,"context_line":"        if selector is not None:"},{"line_number":76,"context_line":"            resp \u003d selector.filter(threshold, resp)"},{"line_number":77,"context_line":"        return resp"}],"source_content_type":"text/x-python","patch_set":26,"id":"2da30af4_42329a51","line":74,"in_reply_to":"f6d81b61_7ecde5a0","updated":"2023-03-10 05:24:39.000000000","message":"I removed the if judgment.","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"}],"tacker/sol_refactored/db/sqlalchemy/models.py":[{"author":{"_account_id":31668,"deleted":true},"change_message_id":"764aa5e8339fd7da967e397048cff462c9426d9f","unresolved":true,"context_lines":[{"line_number":249,"context_line":"    metadata__ \u003d sa.Column(\"metadata\", sa.JSON(), nullable\u003dTrue)"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"class ThresholdStateV2(model_base.BASE):"},{"line_number":253,"context_line":"    \"\"\"Type: ThresholdState"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"    Additional content"}],"source_content_type":"text/x-python","patch_set":11,"id":"e48cc90a_577b61b2","line":252,"updated":"2023-02-24 02:08:57.000000000","message":"This table is very similar to ThresholdV2.\nIs it possible to include performanceValue in metadata of ThresholdV2 and remove ThresholdStateV2?\nI don\u0027t think it\u0027s a good idea to create a table that doesn\u0027t follow the SOL definition...\nIf you definitely need this table, could you please add in the comments why you would create this table separately?","commit_id":"e4cc48a2cf04ea9803f11d36363525903b926901"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"a21d7446ba894cf9058e1eb91b90301c33c9198b","unresolved":false,"context_lines":[{"line_number":249,"context_line":"    metadata__ \u003d sa.Column(\"metadata\", sa.JSON(), nullable\u003dTrue)"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"class ThresholdStateV2(model_base.BASE):"},{"line_number":253,"context_line":"    \"\"\"Type: ThresholdState"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"    Additional content"}],"source_content_type":"text/x-python","patch_set":11,"id":"fe0aefea_440156ca","line":252,"in_reply_to":"d1eb889d_6b62626a","updated":"2023-02-27 06:23:10.000000000","message":"Thank you for your explanation.\nI understand.","commit_id":"e4cc48a2cf04ea9803f11d36363525903b926901"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"c56b8094a8756046679a7b80d91fec8419ff92fe","unresolved":true,"context_lines":[{"line_number":249,"context_line":"    metadata__ \u003d sa.Column(\"metadata\", sa.JSON(), nullable\u003dTrue)"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"class ThresholdStateV2(model_base.BASE):"},{"line_number":253,"context_line":"    \"\"\"Type: ThresholdState"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"    Additional content"}],"source_content_type":"text/x-python","patch_set":11,"id":"d1eb889d_6b62626a","line":252,"in_reply_to":"e48cc90a_577b61b2","updated":"2023-02-24 05:51:35.000000000","message":"It is true that their fields are similar, but in `ThresholdV2`, subObjectInstanceId can have multiple values.\nSo if we want to make `performanceValue` correspond to them one by one, it will cause a lot of data to be stored in `metadata` (assuming there are many subObjectInstanceIds).\nI don\u0027t think this is a good way to handle it, so I created this table.","commit_id":"e4cc48a2cf04ea9803f11d36363525903b926901"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"a21d7446ba894cf9058e1eb91b90301c33c9198b","unresolved":true,"context_lines":[{"line_number":252,"context_line":"class ThresholdStateV2(model_base.BASE):"},{"line_number":253,"context_line":"    \"\"\"Type: ThresholdState"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"    Additional content"},{"line_number":256,"context_line":"    \"\"\""},{"line_number":257,"context_line":"    __tablename__ \u003d \u0027ThresholdStateV2\u0027"},{"line_number":258,"context_line":"    id \u003d sa.Column(sa.String(255), nullable\u003dFalse, primary_key\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":13,"id":"82689d17_f75fb259","line":255,"updated":"2023-02-27 06:23:10.000000000","message":"Since there is no description in SOL, please add an overview of this database table here.","commit_id":"684824f35fd01773b0d4e9d14eeeaad4709c08e6"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"41273f8fda983cfc1f00f66688f8468915ef945f","unresolved":true,"context_lines":[{"line_number":252,"context_line":"class ThresholdStateV2(model_base.BASE):"},{"line_number":253,"context_line":"    \"\"\"Type: ThresholdState"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"    Additional content"},{"line_number":256,"context_line":"    \"\"\""},{"line_number":257,"context_line":"    __tablename__ \u003d \u0027ThresholdStateV2\u0027"},{"line_number":258,"context_line":"    id \u003d sa.Column(sa.String(255), nullable\u003dFalse, primary_key\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":13,"id":"db36f1f7_d2f37291","line":255,"in_reply_to":"82689d17_f75fb259","updated":"2023-03-01 08:05:06.000000000","message":"I appended a description of the table.","commit_id":"684824f35fd01773b0d4e9d14eeeaad4709c08e6"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"502d8a480ed50e06fb6674b5ae77b544b3d9472e","unresolved":false,"context_lines":[{"line_number":252,"context_line":"class ThresholdStateV2(model_base.BASE):"},{"line_number":253,"context_line":"    \"\"\"Type: ThresholdState"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"    Additional content"},{"line_number":256,"context_line":"    \"\"\""},{"line_number":257,"context_line":"    __tablename__ \u003d \u0027ThresholdStateV2\u0027"},{"line_number":258,"context_line":"    id \u003d sa.Column(sa.String(255), nullable\u003dFalse, primary_key\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":13,"id":"8da116e8_94e563b4","line":255,"in_reply_to":"db36f1f7_d2f37291","updated":"2023-03-08 09:34:23.000000000","message":"This comment is closed because this table is no longer needed.","commit_id":"684824f35fd01773b0d4e9d14eeeaad4709c08e6"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"44b7f8fc31425dc896c881675d8f0f65a1da16e2","unresolved":true,"context_lines":[{"line_number":242,"context_line":"    criteria \u003d sa.Column(sa.JSON(), nullable\u003dFalse)"},{"line_number":243,"context_line":"    callbackUri \u003d sa.Column(sa.String(255), nullable\u003dFalse)"},{"line_number":244,"context_line":"    # NOTE: \u0027authentication\u0027 attribute is not included in the"},{"line_number":245,"context_line":"    #       original \u0027PmThreshold\u0027 data type definition."},{"line_number":246,"context_line":"    authentication \u003d sa.Column(sa.JSON(), nullable\u003dTrue)"},{"line_number":247,"context_line":"    # NOTE: \u0027metadata\u0027 attribute is not included in the"},{"line_number":248,"context_line":"    #       original \u0027PmThreshold\u0027 data type definition."}],"source_content_type":"text/x-python","patch_set":22,"id":"69f95e74_5d6f537d","line":245,"range":{"start_line":245,"start_character":22,"end_line":245,"end_character":33},"updated":"2023-03-07 01:02:26.000000000","message":"I think `Threshold` is correct, could you change to `Threshold`?","commit_id":"ba8f07016cc719c62a264a14b914afd9b0d7d85d"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"56dfe3903b9a0b66735f2b886f38eed520edb23a","unresolved":true,"context_lines":[{"line_number":242,"context_line":"    criteria \u003d sa.Column(sa.JSON(), nullable\u003dFalse)"},{"line_number":243,"context_line":"    callbackUri \u003d sa.Column(sa.String(255), nullable\u003dFalse)"},{"line_number":244,"context_line":"    # NOTE: \u0027authentication\u0027 attribute is not included in the"},{"line_number":245,"context_line":"    #       original \u0027PmThreshold\u0027 data type definition."},{"line_number":246,"context_line":"    authentication \u003d sa.Column(sa.JSON(), nullable\u003dTrue)"},{"line_number":247,"context_line":"    # NOTE: \u0027metadata\u0027 attribute is not included in the"},{"line_number":248,"context_line":"    #       original \u0027PmThreshold\u0027 data type definition."}],"source_content_type":"text/x-python","patch_set":22,"id":"ec0fb53a_9939d69d","line":245,"range":{"start_line":245,"start_character":22,"end_line":245,"end_character":33},"updated":"2023-03-07 03:03:47.000000000","message":"nits: PmThreshold -\u003e Threshold","commit_id":"ba8f07016cc719c62a264a14b914afd9b0d7d85d"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"70b1a74aed0ab5e41e1dbac45a788b76f262f97f","unresolved":false,"context_lines":[{"line_number":242,"context_line":"    criteria \u003d sa.Column(sa.JSON(), nullable\u003dFalse)"},{"line_number":243,"context_line":"    callbackUri \u003d sa.Column(sa.String(255), nullable\u003dFalse)"},{"line_number":244,"context_line":"    # NOTE: \u0027authentication\u0027 attribute is not included in the"},{"line_number":245,"context_line":"    #       original \u0027PmThreshold\u0027 data type definition."},{"line_number":246,"context_line":"    authentication \u003d sa.Column(sa.JSON(), nullable\u003dTrue)"},{"line_number":247,"context_line":"    # NOTE: \u0027metadata\u0027 attribute is not included in the"},{"line_number":248,"context_line":"    #       original \u0027PmThreshold\u0027 data type definition."}],"source_content_type":"text/x-python","patch_set":22,"id":"f780f705_91f40dc6","line":245,"range":{"start_line":245,"start_character":22,"end_line":245,"end_character":33},"in_reply_to":"49788755_ac63debc","updated":"2023-03-07 12:20:57.000000000","message":"Ack","commit_id":"ba8f07016cc719c62a264a14b914afd9b0d7d85d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"2f6ad2697def74db2ec26090a90112d34865447d","unresolved":true,"context_lines":[{"line_number":242,"context_line":"    criteria \u003d sa.Column(sa.JSON(), nullable\u003dFalse)"},{"line_number":243,"context_line":"    callbackUri \u003d sa.Column(sa.String(255), nullable\u003dFalse)"},{"line_number":244,"context_line":"    # NOTE: \u0027authentication\u0027 attribute is not included in the"},{"line_number":245,"context_line":"    #       original \u0027PmThreshold\u0027 data type definition."},{"line_number":246,"context_line":"    authentication \u003d sa.Column(sa.JSON(), nullable\u003dTrue)"},{"line_number":247,"context_line":"    # NOTE: \u0027metadata\u0027 attribute is not included in the"},{"line_number":248,"context_line":"    #       original \u0027PmThreshold\u0027 data type definition."}],"source_content_type":"text/x-python","patch_set":22,"id":"49788755_ac63debc","line":245,"range":{"start_line":245,"start_character":22,"end_line":245,"end_character":33},"in_reply_to":"69f95e74_5d6f537d","updated":"2023-03-07 06:11:12.000000000","message":"I replaced `PmThreshold` with `Threshold `.","commit_id":"ba8f07016cc719c62a264a14b914afd9b0d7d85d"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"4452ce72041c8be511f16c4e9b26c700e7a63030","unresolved":false,"context_lines":[{"line_number":242,"context_line":"    criteria \u003d sa.Column(sa.JSON(), nullable\u003dFalse)"},{"line_number":243,"context_line":"    callbackUri \u003d sa.Column(sa.String(255), nullable\u003dFalse)"},{"line_number":244,"context_line":"    # NOTE: \u0027authentication\u0027 attribute is not included in the"},{"line_number":245,"context_line":"    #       original \u0027PmThreshold\u0027 data type definition."},{"line_number":246,"context_line":"    authentication \u003d sa.Column(sa.JSON(), nullable\u003dTrue)"},{"line_number":247,"context_line":"    # NOTE: \u0027metadata\u0027 attribute is not included in the"},{"line_number":248,"context_line":"    #       original \u0027PmThreshold\u0027 data type definition."}],"source_content_type":"text/x-python","patch_set":22,"id":"9c526c7b_45a5e2e8","line":245,"range":{"start_line":245,"start_character":22,"end_line":245,"end_character":33},"in_reply_to":"9fb48ed9_164aef9d","updated":"2023-03-07 06:48:02.000000000","message":"Thanks, Done.\n(Sorry for duplicate comments with ueha-san..)","commit_id":"ba8f07016cc719c62a264a14b914afd9b0d7d85d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"2f6ad2697def74db2ec26090a90112d34865447d","unresolved":true,"context_lines":[{"line_number":242,"context_line":"    criteria \u003d sa.Column(sa.JSON(), nullable\u003dFalse)"},{"line_number":243,"context_line":"    callbackUri \u003d sa.Column(sa.String(255), nullable\u003dFalse)"},{"line_number":244,"context_line":"    # NOTE: \u0027authentication\u0027 attribute is not included in the"},{"line_number":245,"context_line":"    #       original \u0027PmThreshold\u0027 data type definition."},{"line_number":246,"context_line":"    authentication \u003d sa.Column(sa.JSON(), nullable\u003dTrue)"},{"line_number":247,"context_line":"    # NOTE: \u0027metadata\u0027 attribute is not included in the"},{"line_number":248,"context_line":"    #       original \u0027PmThreshold\u0027 data type definition."}],"source_content_type":"text/x-python","patch_set":22,"id":"9fb48ed9_164aef9d","line":245,"range":{"start_line":245,"start_character":22,"end_line":245,"end_character":33},"in_reply_to":"ec0fb53a_9939d69d","updated":"2023-03-07 06:11:12.000000000","message":"I fixed it in patchset 23.","commit_id":"ba8f07016cc719c62a264a14b914afd9b0d7d85d"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"44b7f8fc31425dc896c881675d8f0f65a1da16e2","unresolved":true,"context_lines":[{"line_number":245,"context_line":"    #       original \u0027PmThreshold\u0027 data type definition."},{"line_number":246,"context_line":"    authentication \u003d sa.Column(sa.JSON(), nullable\u003dTrue)"},{"line_number":247,"context_line":"    # NOTE: \u0027metadata\u0027 attribute is not included in the"},{"line_number":248,"context_line":"    #       original \u0027PmThreshold\u0027 data type definition."},{"line_number":249,"context_line":"    metadata__ \u003d sa.Column(\"metadata\", sa.JSON(), nullable\u003dTrue)"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"87c631fb_0766c9b9","line":248,"range":{"start_line":248,"start_character":22,"end_line":248,"end_character":33},"updated":"2023-03-07 01:02:26.000000000","message":"ditto.","commit_id":"ba8f07016cc719c62a264a14b914afd9b0d7d85d"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"56dfe3903b9a0b66735f2b886f38eed520edb23a","unresolved":true,"context_lines":[{"line_number":245,"context_line":"    #       original \u0027PmThreshold\u0027 data type definition."},{"line_number":246,"context_line":"    authentication \u003d sa.Column(sa.JSON(), nullable\u003dTrue)"},{"line_number":247,"context_line":"    # NOTE: \u0027metadata\u0027 attribute is not included in the"},{"line_number":248,"context_line":"    #       original \u0027PmThreshold\u0027 data type definition."},{"line_number":249,"context_line":"    metadata__ \u003d sa.Column(\"metadata\", sa.JSON(), nullable\u003dTrue)"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"9e7a931f_0778e351","line":248,"range":{"start_line":248,"start_character":22,"end_line":248,"end_character":33},"updated":"2023-03-07 03:03:47.000000000","message":"ditto.","commit_id":"ba8f07016cc719c62a264a14b914afd9b0d7d85d"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"4452ce72041c8be511f16c4e9b26c700e7a63030","unresolved":false,"context_lines":[{"line_number":245,"context_line":"    #       original \u0027PmThreshold\u0027 data type definition."},{"line_number":246,"context_line":"    authentication \u003d sa.Column(sa.JSON(), nullable\u003dTrue)"},{"line_number":247,"context_line":"    # NOTE: \u0027metadata\u0027 attribute is not included in the"},{"line_number":248,"context_line":"    #       original \u0027PmThreshold\u0027 data type definition."},{"line_number":249,"context_line":"    metadata__ \u003d sa.Column(\"metadata\", sa.JSON(), nullable\u003dTrue)"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"7317bbf9_aeef49b0","line":248,"range":{"start_line":248,"start_character":22,"end_line":248,"end_character":33},"in_reply_to":"232224ed_3d5aad2f","updated":"2023-03-07 06:48:02.000000000","message":"Done","commit_id":"ba8f07016cc719c62a264a14b914afd9b0d7d85d"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"70b1a74aed0ab5e41e1dbac45a788b76f262f97f","unresolved":false,"context_lines":[{"line_number":245,"context_line":"    #       original \u0027PmThreshold\u0027 data type definition."},{"line_number":246,"context_line":"    authentication \u003d sa.Column(sa.JSON(), nullable\u003dTrue)"},{"line_number":247,"context_line":"    # NOTE: \u0027metadata\u0027 attribute is not included in the"},{"line_number":248,"context_line":"    #       original \u0027PmThreshold\u0027 data type definition."},{"line_number":249,"context_line":"    metadata__ \u003d sa.Column(\"metadata\", sa.JSON(), nullable\u003dTrue)"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"73d52d0c_8f7338a1","line":248,"range":{"start_line":248,"start_character":22,"end_line":248,"end_character":33},"in_reply_to":"7a62556d_5905127b","updated":"2023-03-07 12:20:57.000000000","message":"Ack","commit_id":"ba8f07016cc719c62a264a14b914afd9b0d7d85d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"2f6ad2697def74db2ec26090a90112d34865447d","unresolved":true,"context_lines":[{"line_number":245,"context_line":"    #       original \u0027PmThreshold\u0027 data type definition."},{"line_number":246,"context_line":"    authentication \u003d sa.Column(sa.JSON(), nullable\u003dTrue)"},{"line_number":247,"context_line":"    # NOTE: \u0027metadata\u0027 attribute is not included in the"},{"line_number":248,"context_line":"    #       original \u0027PmThreshold\u0027 data type definition."},{"line_number":249,"context_line":"    metadata__ \u003d sa.Column(\"metadata\", sa.JSON(), nullable\u003dTrue)"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"7a62556d_5905127b","line":248,"range":{"start_line":248,"start_character":22,"end_line":248,"end_character":33},"in_reply_to":"87c631fb_0766c9b9","updated":"2023-03-07 06:11:12.000000000","message":"I replaced `PmThreshold` with `Threshold `.","commit_id":"ba8f07016cc719c62a264a14b914afd9b0d7d85d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"2f6ad2697def74db2ec26090a90112d34865447d","unresolved":true,"context_lines":[{"line_number":245,"context_line":"    #       original \u0027PmThreshold\u0027 data type definition."},{"line_number":246,"context_line":"    authentication \u003d sa.Column(sa.JSON(), nullable\u003dTrue)"},{"line_number":247,"context_line":"    # NOTE: \u0027metadata\u0027 attribute is not included in the"},{"line_number":248,"context_line":"    #       original \u0027PmThreshold\u0027 data type definition."},{"line_number":249,"context_line":"    metadata__ \u003d sa.Column(\"metadata\", sa.JSON(), nullable\u003dTrue)"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"232224ed_3d5aad2f","line":248,"range":{"start_line":248,"start_character":22,"end_line":248,"end_character":33},"in_reply_to":"9e7a931f_0778e351","updated":"2023-03-07 06:11:12.000000000","message":"I fixed it in patchset 23.","commit_id":"ba8f07016cc719c62a264a14b914afd9b0d7d85d"}],"tacker/sol_refactored/objects/__init__.py":[{"author":{"_account_id":31668,"deleted":true},"change_message_id":"502d8a480ed50e06fb6674b5ae77b544b3d9472e","unresolved":true,"context_lines":[{"line_number":71,"context_line":"    __import__(objects_root + \u0027.v2.change_ext_vnf_connectivity_request\u0027)"},{"line_number":72,"context_line":"    __import__(objects_root + \u0027.v2.change_vnf_flavour_request\u0027)"},{"line_number":73,"context_line":"    __import__(objects_root + \u0027.v2.cp_protocol_info\u0027)"},{"line_number":74,"context_line":"    __import__(objects_root + \u0027.v2.create_pm_threshold_request\u0027)"},{"line_number":75,"context_line":"    __import__(objects_root + \u0027.v2.create_vnf_pkg_info_request\u0027)"},{"line_number":76,"context_line":"    __import__(objects_root + \u0027.v2.create_vnf_request\u0027)"},{"line_number":77,"context_line":"    __import__(objects_root + \u0027.v2.create_vnf_snapshot_info_request\u0027)"}],"source_content_type":"text/x-python","patch_set":26,"id":"f41df16d_085a959c","line":74,"updated":"2023-03-08 09:34:23.000000000","message":"The following is better because it matches the description of SOL.\n* \u0027.v2.create_threshold_request\u0027\nCould you change the file name?","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"8f06305958ef940b7db0ad505c6afd11351558ea","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    __import__(objects_root + \u0027.v2.change_ext_vnf_connectivity_request\u0027)"},{"line_number":72,"context_line":"    __import__(objects_root + \u0027.v2.change_vnf_flavour_request\u0027)"},{"line_number":73,"context_line":"    __import__(objects_root + \u0027.v2.cp_protocol_info\u0027)"},{"line_number":74,"context_line":"    __import__(objects_root + \u0027.v2.create_pm_threshold_request\u0027)"},{"line_number":75,"context_line":"    __import__(objects_root + \u0027.v2.create_vnf_pkg_info_request\u0027)"},{"line_number":76,"context_line":"    __import__(objects_root + \u0027.v2.create_vnf_request\u0027)"},{"line_number":77,"context_line":"    __import__(objects_root + \u0027.v2.create_vnf_snapshot_info_request\u0027)"}],"source_content_type":"text/x-python","patch_set":26,"id":"036ac861_5ec4b743","line":74,"in_reply_to":"0e698295_8e96d1b3","updated":"2023-03-10 07:29:52.000000000","message":"Done","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"ffcbe62c7d93958ce4d3e37c19eefb313a24f4aa","unresolved":true,"context_lines":[{"line_number":71,"context_line":"    __import__(objects_root + \u0027.v2.change_ext_vnf_connectivity_request\u0027)"},{"line_number":72,"context_line":"    __import__(objects_root + \u0027.v2.change_vnf_flavour_request\u0027)"},{"line_number":73,"context_line":"    __import__(objects_root + \u0027.v2.cp_protocol_info\u0027)"},{"line_number":74,"context_line":"    __import__(objects_root + \u0027.v2.create_pm_threshold_request\u0027)"},{"line_number":75,"context_line":"    __import__(objects_root + \u0027.v2.create_vnf_pkg_info_request\u0027)"},{"line_number":76,"context_line":"    __import__(objects_root + \u0027.v2.create_vnf_request\u0027)"},{"line_number":77,"context_line":"    __import__(objects_root + \u0027.v2.create_vnf_snapshot_info_request\u0027)"}],"source_content_type":"text/x-python","patch_set":26,"id":"0e698295_8e96d1b3","line":74,"in_reply_to":"f41df16d_085a959c","updated":"2023-03-10 05:24:39.000000000","message":"I fixed it in patchset 27.","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"502d8a480ed50e06fb6674b5ae77b544b3d9472e","unresolved":true,"context_lines":[{"line_number":101,"context_line":"    __import__(objects_root + \u0027.v2.pm_job_criteria\u0027)"},{"line_number":102,"context_line":"    __import__(objects_root + \u0027.v2.pm_job_modification\u0027)"},{"line_number":103,"context_line":"    __import__(objects_root + \u0027.v2.pm_report\u0027)"},{"line_number":104,"context_line":"    __import__(objects_root + \u0027.v2.pm_threshold\u0027)"},{"line_number":105,"context_line":"    __import__(objects_root + \u0027.v2.pm_threshold_criteria\u0027)"},{"line_number":106,"context_line":"    __import__(objects_root + \u0027.v2.pm_threshold_modifications\u0027)"},{"line_number":107,"context_line":"    __import__(objects_root + \u0027.v2.revert_to_vnf_snapshot_request\u0027)"}],"source_content_type":"text/x-python","patch_set":26,"id":"79150a1c_05585c28","line":104,"updated":"2023-03-08 09:34:23.000000000","message":"The following is better because it matches the description of SOL.\n* \u0027.v2.threshold\u0027\nCould you change the file name?","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"89d8eecf4d6eafa01ecd3d477d835a9dd7fc61ab","unresolved":true,"context_lines":[{"line_number":101,"context_line":"    __import__(objects_root + \u0027.v2.pm_job_criteria\u0027)"},{"line_number":102,"context_line":"    __import__(objects_root + \u0027.v2.pm_job_modification\u0027)"},{"line_number":103,"context_line":"    __import__(objects_root + \u0027.v2.pm_report\u0027)"},{"line_number":104,"context_line":"    __import__(objects_root + \u0027.v2.pm_threshold\u0027)"},{"line_number":105,"context_line":"    __import__(objects_root + \u0027.v2.pm_threshold_criteria\u0027)"},{"line_number":106,"context_line":"    __import__(objects_root + \u0027.v2.pm_threshold_modifications\u0027)"},{"line_number":107,"context_line":"    __import__(objects_root + \u0027.v2.revert_to_vnf_snapshot_request\u0027)"}],"source_content_type":"text/x-python","patch_set":26,"id":"846b109d_46726173","line":104,"in_reply_to":"263dc7ab_4217ca64","updated":"2023-03-10 07:56:26.000000000","message":"I fixed it in patchset 28.","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"ffcbe62c7d93958ce4d3e37c19eefb313a24f4aa","unresolved":true,"context_lines":[{"line_number":101,"context_line":"    __import__(objects_root + \u0027.v2.pm_job_criteria\u0027)"},{"line_number":102,"context_line":"    __import__(objects_root + \u0027.v2.pm_job_modification\u0027)"},{"line_number":103,"context_line":"    __import__(objects_root + \u0027.v2.pm_report\u0027)"},{"line_number":104,"context_line":"    __import__(objects_root + \u0027.v2.pm_threshold\u0027)"},{"line_number":105,"context_line":"    __import__(objects_root + \u0027.v2.pm_threshold_criteria\u0027)"},{"line_number":106,"context_line":"    __import__(objects_root + \u0027.v2.pm_threshold_modifications\u0027)"},{"line_number":107,"context_line":"    __import__(objects_root + \u0027.v2.revert_to_vnf_snapshot_request\u0027)"}],"source_content_type":"text/x-python","patch_set":26,"id":"f689d9b0_6d93531b","line":104,"in_reply_to":"79150a1c_05585c28","updated":"2023-03-10 05:24:39.000000000","message":"I fixed it in patchset 27.","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"35e9ae8d489d2fe7250560fb24617d821b22d861","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    __import__(objects_root + \u0027.v2.pm_job_criteria\u0027)"},{"line_number":102,"context_line":"    __import__(objects_root + \u0027.v2.pm_job_modification\u0027)"},{"line_number":103,"context_line":"    __import__(objects_root + \u0027.v2.pm_report\u0027)"},{"line_number":104,"context_line":"    __import__(objects_root + \u0027.v2.pm_threshold\u0027)"},{"line_number":105,"context_line":"    __import__(objects_root + \u0027.v2.pm_threshold_criteria\u0027)"},{"line_number":106,"context_line":"    __import__(objects_root + \u0027.v2.pm_threshold_modifications\u0027)"},{"line_number":107,"context_line":"    __import__(objects_root + \u0027.v2.revert_to_vnf_snapshot_request\u0027)"}],"source_content_type":"text/x-python","patch_set":26,"id":"5d9bd491_d593a4b2","line":104,"in_reply_to":"846b109d_46726173","updated":"2023-03-10 09:25:42.000000000","message":"Done","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"8f06305958ef940b7db0ad505c6afd11351558ea","unresolved":true,"context_lines":[{"line_number":101,"context_line":"    __import__(objects_root + \u0027.v2.pm_job_criteria\u0027)"},{"line_number":102,"context_line":"    __import__(objects_root + \u0027.v2.pm_job_modification\u0027)"},{"line_number":103,"context_line":"    __import__(objects_root + \u0027.v2.pm_report\u0027)"},{"line_number":104,"context_line":"    __import__(objects_root + \u0027.v2.pm_threshold\u0027)"},{"line_number":105,"context_line":"    __import__(objects_root + \u0027.v2.pm_threshold_criteria\u0027)"},{"line_number":106,"context_line":"    __import__(objects_root + \u0027.v2.pm_threshold_modifications\u0027)"},{"line_number":107,"context_line":"    __import__(objects_root + \u0027.v2.revert_to_vnf_snapshot_request\u0027)"}],"source_content_type":"text/x-python","patch_set":26,"id":"263dc7ab_4217ca64","line":104,"in_reply_to":"f689d9b0_6d93531b","updated":"2023-03-10 07:29:52.000000000","message":"Thank you for the fix.\nIs it okay if it is not listed in alphabetical order?","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"502d8a480ed50e06fb6674b5ae77b544b3d9472e","unresolved":true,"context_lines":[{"line_number":102,"context_line":"    __import__(objects_root + \u0027.v2.pm_job_modification\u0027)"},{"line_number":103,"context_line":"    __import__(objects_root + \u0027.v2.pm_report\u0027)"},{"line_number":104,"context_line":"    __import__(objects_root + \u0027.v2.pm_threshold\u0027)"},{"line_number":105,"context_line":"    __import__(objects_root + \u0027.v2.pm_threshold_criteria\u0027)"},{"line_number":106,"context_line":"    __import__(objects_root + \u0027.v2.pm_threshold_modifications\u0027)"},{"line_number":107,"context_line":"    __import__(objects_root + \u0027.v2.revert_to_vnf_snapshot_request\u0027)"},{"line_number":108,"context_line":"    __import__(objects_root + \u0027.v2.scale_info\u0027)"}],"source_content_type":"text/x-python","patch_set":26,"id":"5e8a7b43_bba93f95","line":105,"updated":"2023-03-08 09:34:23.000000000","message":"The following is better because it matches the description of SOL.\n* \u0027.v2.threshold_criteria\u0027\nCould you change the file name?","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"ffcbe62c7d93958ce4d3e37c19eefb313a24f4aa","unresolved":true,"context_lines":[{"line_number":102,"context_line":"    __import__(objects_root + \u0027.v2.pm_job_modification\u0027)"},{"line_number":103,"context_line":"    __import__(objects_root + \u0027.v2.pm_report\u0027)"},{"line_number":104,"context_line":"    __import__(objects_root + \u0027.v2.pm_threshold\u0027)"},{"line_number":105,"context_line":"    __import__(objects_root + \u0027.v2.pm_threshold_criteria\u0027)"},{"line_number":106,"context_line":"    __import__(objects_root + \u0027.v2.pm_threshold_modifications\u0027)"},{"line_number":107,"context_line":"    __import__(objects_root + \u0027.v2.revert_to_vnf_snapshot_request\u0027)"},{"line_number":108,"context_line":"    __import__(objects_root + \u0027.v2.scale_info\u0027)"}],"source_content_type":"text/x-python","patch_set":26,"id":"fc7eca5d_a0fc20f1","line":105,"in_reply_to":"5e8a7b43_bba93f95","updated":"2023-03-10 05:24:39.000000000","message":"I fixed it in patchset 27.","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"89d8eecf4d6eafa01ecd3d477d835a9dd7fc61ab","unresolved":true,"context_lines":[{"line_number":102,"context_line":"    __import__(objects_root + \u0027.v2.pm_job_modification\u0027)"},{"line_number":103,"context_line":"    __import__(objects_root + \u0027.v2.pm_report\u0027)"},{"line_number":104,"context_line":"    __import__(objects_root + \u0027.v2.pm_threshold\u0027)"},{"line_number":105,"context_line":"    __import__(objects_root + \u0027.v2.pm_threshold_criteria\u0027)"},{"line_number":106,"context_line":"    __import__(objects_root + \u0027.v2.pm_threshold_modifications\u0027)"},{"line_number":107,"context_line":"    __import__(objects_root + \u0027.v2.revert_to_vnf_snapshot_request\u0027)"},{"line_number":108,"context_line":"    __import__(objects_root + \u0027.v2.scale_info\u0027)"}],"source_content_type":"text/x-python","patch_set":26,"id":"f6bddc10_bae79c2c","line":105,"in_reply_to":"f4052390_8d22a2c9","updated":"2023-03-10 07:56:26.000000000","message":"I fixed it in patchset 28.","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"35e9ae8d489d2fe7250560fb24617d821b22d861","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    __import__(objects_root + \u0027.v2.pm_job_modification\u0027)"},{"line_number":103,"context_line":"    __import__(objects_root + \u0027.v2.pm_report\u0027)"},{"line_number":104,"context_line":"    __import__(objects_root + \u0027.v2.pm_threshold\u0027)"},{"line_number":105,"context_line":"    __import__(objects_root + \u0027.v2.pm_threshold_criteria\u0027)"},{"line_number":106,"context_line":"    __import__(objects_root + \u0027.v2.pm_threshold_modifications\u0027)"},{"line_number":107,"context_line":"    __import__(objects_root + \u0027.v2.revert_to_vnf_snapshot_request\u0027)"},{"line_number":108,"context_line":"    __import__(objects_root + \u0027.v2.scale_info\u0027)"}],"source_content_type":"text/x-python","patch_set":26,"id":"54c30426_e270faa1","line":105,"in_reply_to":"f6bddc10_bae79c2c","updated":"2023-03-10 09:25:42.000000000","message":"Done","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"8f06305958ef940b7db0ad505c6afd11351558ea","unresolved":true,"context_lines":[{"line_number":102,"context_line":"    __import__(objects_root + \u0027.v2.pm_job_modification\u0027)"},{"line_number":103,"context_line":"    __import__(objects_root + \u0027.v2.pm_report\u0027)"},{"line_number":104,"context_line":"    __import__(objects_root + \u0027.v2.pm_threshold\u0027)"},{"line_number":105,"context_line":"    __import__(objects_root + \u0027.v2.pm_threshold_criteria\u0027)"},{"line_number":106,"context_line":"    __import__(objects_root + \u0027.v2.pm_threshold_modifications\u0027)"},{"line_number":107,"context_line":"    __import__(objects_root + \u0027.v2.revert_to_vnf_snapshot_request\u0027)"},{"line_number":108,"context_line":"    __import__(objects_root + \u0027.v2.scale_info\u0027)"}],"source_content_type":"text/x-python","patch_set":26,"id":"f4052390_8d22a2c9","line":105,"in_reply_to":"fc7eca5d_a0fc20f1","updated":"2023-03-10 07:29:52.000000000","message":"ditto","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"502d8a480ed50e06fb6674b5ae77b544b3d9472e","unresolved":true,"context_lines":[{"line_number":103,"context_line":"    __import__(objects_root + \u0027.v2.pm_report\u0027)"},{"line_number":104,"context_line":"    __import__(objects_root + \u0027.v2.pm_threshold\u0027)"},{"line_number":105,"context_line":"    __import__(objects_root + \u0027.v2.pm_threshold_criteria\u0027)"},{"line_number":106,"context_line":"    __import__(objects_root + \u0027.v2.pm_threshold_modifications\u0027)"},{"line_number":107,"context_line":"    __import__(objects_root + \u0027.v2.revert_to_vnf_snapshot_request\u0027)"},{"line_number":108,"context_line":"    __import__(objects_root + \u0027.v2.scale_info\u0027)"},{"line_number":109,"context_line":"    __import__(objects_root + \u0027.v2.scale_vnf_request\u0027)"}],"source_content_type":"text/x-python","patch_set":26,"id":"61376dbf_8d87ab46","line":106,"updated":"2023-03-08 09:34:23.000000000","message":"The following is better because it matches the description of SOL.\n* \u0027.v2.threshold_modifications\u0027\nCould you change the file name?","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"35e9ae8d489d2fe7250560fb24617d821b22d861","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    __import__(objects_root + \u0027.v2.pm_report\u0027)"},{"line_number":104,"context_line":"    __import__(objects_root + \u0027.v2.pm_threshold\u0027)"},{"line_number":105,"context_line":"    __import__(objects_root + \u0027.v2.pm_threshold_criteria\u0027)"},{"line_number":106,"context_line":"    __import__(objects_root + \u0027.v2.pm_threshold_modifications\u0027)"},{"line_number":107,"context_line":"    __import__(objects_root + \u0027.v2.revert_to_vnf_snapshot_request\u0027)"},{"line_number":108,"context_line":"    __import__(objects_root + \u0027.v2.scale_info\u0027)"},{"line_number":109,"context_line":"    __import__(objects_root + \u0027.v2.scale_vnf_request\u0027)"}],"source_content_type":"text/x-python","patch_set":26,"id":"3e99c4d3_44d33772","line":106,"in_reply_to":"03d95550_28182500","updated":"2023-03-10 09:25:42.000000000","message":"Done","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"ffcbe62c7d93958ce4d3e37c19eefb313a24f4aa","unresolved":true,"context_lines":[{"line_number":103,"context_line":"    __import__(objects_root + \u0027.v2.pm_report\u0027)"},{"line_number":104,"context_line":"    __import__(objects_root + \u0027.v2.pm_threshold\u0027)"},{"line_number":105,"context_line":"    __import__(objects_root + \u0027.v2.pm_threshold_criteria\u0027)"},{"line_number":106,"context_line":"    __import__(objects_root + \u0027.v2.pm_threshold_modifications\u0027)"},{"line_number":107,"context_line":"    __import__(objects_root + \u0027.v2.revert_to_vnf_snapshot_request\u0027)"},{"line_number":108,"context_line":"    __import__(objects_root + \u0027.v2.scale_info\u0027)"},{"line_number":109,"context_line":"    __import__(objects_root + \u0027.v2.scale_vnf_request\u0027)"}],"source_content_type":"text/x-python","patch_set":26,"id":"7d43d2ab_44528f17","line":106,"in_reply_to":"61376dbf_8d87ab46","updated":"2023-03-10 05:24:39.000000000","message":"I fixed it in patchset 27.","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"8f06305958ef940b7db0ad505c6afd11351558ea","unresolved":true,"context_lines":[{"line_number":103,"context_line":"    __import__(objects_root + \u0027.v2.pm_report\u0027)"},{"line_number":104,"context_line":"    __import__(objects_root + \u0027.v2.pm_threshold\u0027)"},{"line_number":105,"context_line":"    __import__(objects_root + \u0027.v2.pm_threshold_criteria\u0027)"},{"line_number":106,"context_line":"    __import__(objects_root + \u0027.v2.pm_threshold_modifications\u0027)"},{"line_number":107,"context_line":"    __import__(objects_root + \u0027.v2.revert_to_vnf_snapshot_request\u0027)"},{"line_number":108,"context_line":"    __import__(objects_root + \u0027.v2.scale_info\u0027)"},{"line_number":109,"context_line":"    __import__(objects_root + \u0027.v2.scale_vnf_request\u0027)"}],"source_content_type":"text/x-python","patch_set":26,"id":"b12a698b_ffc2328c","line":106,"in_reply_to":"7d43d2ab_44528f17","updated":"2023-03-10 07:29:52.000000000","message":"ditto","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"89d8eecf4d6eafa01ecd3d477d835a9dd7fc61ab","unresolved":true,"context_lines":[{"line_number":103,"context_line":"    __import__(objects_root + \u0027.v2.pm_report\u0027)"},{"line_number":104,"context_line":"    __import__(objects_root + \u0027.v2.pm_threshold\u0027)"},{"line_number":105,"context_line":"    __import__(objects_root + \u0027.v2.pm_threshold_criteria\u0027)"},{"line_number":106,"context_line":"    __import__(objects_root + \u0027.v2.pm_threshold_modifications\u0027)"},{"line_number":107,"context_line":"    __import__(objects_root + \u0027.v2.revert_to_vnf_snapshot_request\u0027)"},{"line_number":108,"context_line":"    __import__(objects_root + \u0027.v2.scale_info\u0027)"},{"line_number":109,"context_line":"    __import__(objects_root + \u0027.v2.scale_vnf_request\u0027)"}],"source_content_type":"text/x-python","patch_set":26,"id":"03d95550_28182500","line":106,"in_reply_to":"b12a698b_ffc2328c","updated":"2023-03-10 07:56:26.000000000","message":"I fixed it in patchset 28.","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"}],"tacker/sol_refactored/objects/v2/pm_threshold.py":[{"author":{"_account_id":31668,"deleted":true},"change_message_id":"502d8a480ed50e06fb6674b5ae77b544b3d9472e","unresolved":true,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":50,"context_line":"class VnfThresholdV2_Links(base.TackerObject, base.TackerObjectDictCompat):"},{"line_number":51,"context_line":"    # Version 1.0: Initial version"},{"line_number":52,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"00bff42d_b42643e6","line":50,"updated":"2023-03-08 09:34:23.000000000","message":"The following is better.\n* ThresholdV2_Links","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"ffcbe62c7d93958ce4d3e37c19eefb313a24f4aa","unresolved":true,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":50,"context_line":"class VnfThresholdV2_Links(base.TackerObject, base.TackerObjectDictCompat):"},{"line_number":51,"context_line":"    # Version 1.0: Initial version"},{"line_number":52,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"94656dd0_219da4a7","line":50,"in_reply_to":"00bff42d_b42643e6","updated":"2023-03-10 05:24:39.000000000","message":"I fixed it in patchset 27.","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"8f06305958ef940b7db0ad505c6afd11351558ea","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":50,"context_line":"class VnfThresholdV2_Links(base.TackerObject, base.TackerObjectDictCompat):"},{"line_number":51,"context_line":"    # Version 1.0: Initial version"},{"line_number":52,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"5c922f57_50e0327e","line":50,"in_reply_to":"94656dd0_219da4a7","updated":"2023-03-10 07:29:52.000000000","message":"Done","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"}],"tacker/sol_refactored/objects/v2/pm_threshold_criteria.py":[{"author":{"_account_id":31668,"deleted":true},"change_message_id":"a21d7446ba894cf9058e1eb91b90301c33c9198b","unresolved":true,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# NFV-SOL 003"},{"line_number":21,"context_line":"# - v3.3.1 6.5.3.4 (API version: 2.0.0)"},{"line_number":22,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":23,"context_line":"class ThresholdCriteriaV2(base.TackerObject, base.TackerObjectDictCompat):"},{"line_number":24,"context_line":"    # Version 1.0: Initial version"}],"source_content_type":"text/x-python","patch_set":13,"id":"f153ad60_9c7a5186","line":21,"updated":"2023-02-27 06:23:10.000000000","message":"Isn\u0027t API version 2.1.0?","commit_id":"684824f35fd01773b0d4e9d14eeeaad4709c08e6"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"822e7028d5cf349c417f0ff6235675aeff7ec225","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# NFV-SOL 003"},{"line_number":21,"context_line":"# - v3.3.1 6.5.3.4 (API version: 2.0.0)"},{"line_number":22,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":23,"context_line":"class ThresholdCriteriaV2(base.TackerObject, base.TackerObjectDictCompat):"},{"line_number":24,"context_line":"    # Version 1.0: Initial version"}],"source_content_type":"text/x-python","patch_set":13,"id":"73da2de9_421fe3d4","line":21,"in_reply_to":"beae37b5_f20ee8f6","updated":"2023-03-02 02:07:27.000000000","message":"Done","commit_id":"684824f35fd01773b0d4e9d14eeeaad4709c08e6"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"41273f8fda983cfc1f00f66688f8468915ef945f","unresolved":true,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# NFV-SOL 003"},{"line_number":21,"context_line":"# - v3.3.1 6.5.3.4 (API version: 2.0.0)"},{"line_number":22,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":23,"context_line":"class ThresholdCriteriaV2(base.TackerObject, base.TackerObjectDictCompat):"},{"line_number":24,"context_line":"    # Version 1.0: Initial version"}],"source_content_type":"text/x-python","patch_set":13,"id":"beae37b5_f20ee8f6","line":21,"in_reply_to":"f153ad60_9c7a5186","updated":"2023-03-01 08:05:06.000000000","message":"I fixed it in patchset 14.","commit_id":"684824f35fd01773b0d4e9d14eeeaad4709c08e6"}],"tacker/sol_refactored/objects/v2/pm_threshold_state.py":[{"author":{"_account_id":31668,"deleted":true},"change_message_id":"a21d7446ba894cf9058e1eb91b90301c33c9198b","unresolved":true,"context_lines":[{"line_number":17,"context_line":"from tacker.sol_refactored.objects import fields"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# Additional content"},{"line_number":21,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":22,"context_line":"class ThresholdStateV2(base.TackerPersistentObject,"},{"line_number":23,"context_line":"                       base.TackerObjectDictCompat):"}],"source_content_type":"text/x-python","patch_set":13,"id":"9766c1f3_ed241b9f","line":20,"updated":"2023-02-27 06:23:10.000000000","message":"Since there is no description in SOL, please add an overview of this object class here.","commit_id":"684824f35fd01773b0d4e9d14eeeaad4709c08e6"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"502d8a480ed50e06fb6674b5ae77b544b3d9472e","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from tacker.sol_refactored.objects import fields"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# Additional content"},{"line_number":21,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":22,"context_line":"class ThresholdStateV2(base.TackerPersistentObject,"},{"line_number":23,"context_line":"                       base.TackerObjectDictCompat):"}],"source_content_type":"text/x-python","patch_set":13,"id":"1e1fab58_7d013908","line":20,"in_reply_to":"6b9aab02_c8c4939a","updated":"2023-03-08 09:34:23.000000000","message":"This comment is closed because this object is no longer needed.","commit_id":"684824f35fd01773b0d4e9d14eeeaad4709c08e6"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"41273f8fda983cfc1f00f66688f8468915ef945f","unresolved":true,"context_lines":[{"line_number":17,"context_line":"from tacker.sol_refactored.objects import fields"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# Additional content"},{"line_number":21,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":22,"context_line":"class ThresholdStateV2(base.TackerPersistentObject,"},{"line_number":23,"context_line":"                       base.TackerObjectDictCompat):"}],"source_content_type":"text/x-python","patch_set":13,"id":"6b9aab02_c8c4939a","line":20,"in_reply_to":"9766c1f3_ed241b9f","updated":"2023-03-01 08:05:06.000000000","message":"I appended a description of the object.","commit_id":"684824f35fd01773b0d4e9d14eeeaad4709c08e6"}],"tacker/tests/functional/sol_kubernetes_v2/base_v2.py":[{"author":{"_account_id":31668,"deleted":true},"change_message_id":"45447a724915d25e12c4999542d15f6abbcda10a","unresolved":true,"context_lines":[{"line_number":384,"context_line":"    def update_pm_threshold(self, pm_threshold_id, req_body):"},{"line_number":385,"context_line":"        path \u003d f\"/vnfpm/v2/thresholds/{pm_threshold_id}\""},{"line_number":386,"context_line":"        return self.tacker_client.do_request("},{"line_number":387,"context_line":"            path, \"PATCH\", body\u003dreq_body, version\u003d\"2.1.0\")"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"    def pm_threshold(self, req_body):"},{"line_number":390,"context_line":"        path \u003d \"/pm_threshold\""}],"source_content_type":"text/x-python","patch_set":26,"id":"8e36fb1b_20e79a20","line":387,"updated":"2023-03-09 02:41:09.000000000","message":"Tacker also allows \"application/json\", but the correct definition in SOL is \"application/mergepatch+json\".\n```\nThe Content-Type header shall be set to \"application/mergepatch+json\" according to IETF RFC 7396.\n```\nIt is better to set \"application/mergepatch+json\" for testing.","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"8f06305958ef940b7db0ad505c6afd11351558ea","unresolved":false,"context_lines":[{"line_number":384,"context_line":"    def update_pm_threshold(self, pm_threshold_id, req_body):"},{"line_number":385,"context_line":"        path \u003d f\"/vnfpm/v2/thresholds/{pm_threshold_id}\""},{"line_number":386,"context_line":"        return self.tacker_client.do_request("},{"line_number":387,"context_line":"            path, \"PATCH\", body\u003dreq_body, version\u003d\"2.1.0\")"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"    def pm_threshold(self, req_body):"},{"line_number":390,"context_line":"        path \u003d \"/pm_threshold\""}],"source_content_type":"text/x-python","patch_set":26,"id":"80fc6d63_116af3fd","line":387,"in_reply_to":"47068930_aaf8628e","updated":"2023-03-10 07:29:52.000000000","message":"Done","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"ffcbe62c7d93958ce4d3e37c19eefb313a24f4aa","unresolved":true,"context_lines":[{"line_number":384,"context_line":"    def update_pm_threshold(self, pm_threshold_id, req_body):"},{"line_number":385,"context_line":"        path \u003d f\"/vnfpm/v2/thresholds/{pm_threshold_id}\""},{"line_number":386,"context_line":"        return self.tacker_client.do_request("},{"line_number":387,"context_line":"            path, \"PATCH\", body\u003dreq_body, version\u003d\"2.1.0\")"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"    def pm_threshold(self, req_body):"},{"line_number":390,"context_line":"        path \u003d \"/pm_threshold\""}],"source_content_type":"text/x-python","patch_set":26,"id":"47068930_aaf8628e","line":387,"in_reply_to":"8e36fb1b_20e79a20","updated":"2023-03-10 05:24:39.000000000","message":"I append `content_type\u003d\"application/mergepatch+json\"` here.\nAt the same time, corresponding modifications have been made in `vnfpm_v2.py`.","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"}],"tacker/tests/functional/sol_kubernetes_v2/paramgen.py":[{"author":{"_account_id":31668,"deleted":true},"change_message_id":"87afa00cc95b7fa0ca1badb3a06dda58aef49f7c","unresolved":true,"context_lines":[{"line_number":153,"context_line":"    }"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"def scale_out():"},{"line_number":157,"context_line":"    return {"},{"line_number":158,"context_line":"        \"type\": \"SCALE_OUT\","},{"line_number":159,"context_line":"        \"aspectId\": \"vdu2_aspect\","}],"source_content_type":"text/x-python","patch_set":13,"id":"33ea034e_22954574","line":156,"updated":"2023-02-28 08:16:32.000000000","message":"Could you also add it to pkggen.py so that scale_out request can be created?\nhttps://opendev.org/openstack/tacker/src/branch/master/tacker/tests/functional/sol_kubernetes_v2/samples/test_instantiate_cnf_resources/pkggen.py","commit_id":"684824f35fd01773b0d4e9d14eeeaad4709c08e6"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"41273f8fda983cfc1f00f66688f8468915ef945f","unresolved":true,"context_lines":[{"line_number":153,"context_line":"    }"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"def scale_out():"},{"line_number":157,"context_line":"    return {"},{"line_number":158,"context_line":"        \"type\": \"SCALE_OUT\","},{"line_number":159,"context_line":"        \"aspectId\": \"vdu2_aspect\","}],"source_content_type":"text/x-python","patch_set":13,"id":"945c6116_ffb67efd","line":156,"in_reply_to":"33ea034e_22954574","updated":"2023-03-01 08:05:06.000000000","message":"I fixed it in patchset 14.","commit_id":"684824f35fd01773b0d4e9d14eeeaad4709c08e6"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"822e7028d5cf349c417f0ff6235675aeff7ec225","unresolved":false,"context_lines":[{"line_number":153,"context_line":"    }"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"def scale_out():"},{"line_number":157,"context_line":"    return {"},{"line_number":158,"context_line":"        \"type\": \"SCALE_OUT\","},{"line_number":159,"context_line":"        \"aspectId\": \"vdu2_aspect\","}],"source_content_type":"text/x-python","patch_set":13,"id":"4abafd69_afb3fcba","line":156,"in_reply_to":"945c6116_ffb67efd","updated":"2023-03-02 02:07:27.000000000","message":"Done","commit_id":"684824f35fd01773b0d4e9d14eeeaad4709c08e6"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"45447a724915d25e12c4999542d15f6abbcda10a","unresolved":true,"context_lines":[{"line_number":916,"context_line":"    metric \u003d f\"VCpuUsageMeanVnf.{inst_id}\""},{"line_number":917,"context_line":"    if p_metric:"},{"line_number":918,"context_line":"        metric \u003d f\"{p_metric}\""},{"line_number":919,"context_line":"    return {"},{"line_number":920,"context_line":"        \"receiver\": \"receiver\","},{"line_number":921,"context_line":"        \"status\": \"firing\","},{"line_number":922,"context_line":"        \"alerts\": ["}],"source_content_type":"text/x-python","patch_set":26,"id":"26694491_7b3fb606","line":919,"updated":"2023-03-09 02:41:09.000000000","message":"No attributes other than \"alerts\" are defined in the Spec.\nCould you please add a comment explaining why an attribute other than \"alerts\" is used as test data?","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"35e9ae8d489d2fe7250560fb24617d821b22d861","unresolved":false,"context_lines":[{"line_number":916,"context_line":"    metric \u003d f\"VCpuUsageMeanVnf.{inst_id}\""},{"line_number":917,"context_line":"    if p_metric:"},{"line_number":918,"context_line":"        metric \u003d f\"{p_metric}\""},{"line_number":919,"context_line":"    return {"},{"line_number":920,"context_line":"        \"receiver\": \"receiver\","},{"line_number":921,"context_line":"        \"status\": \"firing\","},{"line_number":922,"context_line":"        \"alerts\": ["}],"source_content_type":"text/x-python","patch_set":26,"id":"95d553bf_908c5574","line":919,"in_reply_to":"08485f42_c5d691f1","updated":"2023-03-10 09:25:42.000000000","message":"Done","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"89d8eecf4d6eafa01ecd3d477d835a9dd7fc61ab","unresolved":true,"context_lines":[{"line_number":916,"context_line":"    metric \u003d f\"VCpuUsageMeanVnf.{inst_id}\""},{"line_number":917,"context_line":"    if p_metric:"},{"line_number":918,"context_line":"        metric \u003d f\"{p_metric}\""},{"line_number":919,"context_line":"    return {"},{"line_number":920,"context_line":"        \"receiver\": \"receiver\","},{"line_number":921,"context_line":"        \"status\": \"firing\","},{"line_number":922,"context_line":"        \"alerts\": ["}],"source_content_type":"text/x-python","patch_set":26,"id":"08485f42_c5d691f1","line":919,"in_reply_to":"2010af81_1b9b351d","updated":"2023-03-10 07:56:26.000000000","message":"I fixed it in patchset 28.","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"ffcbe62c7d93958ce4d3e37c19eefb313a24f4aa","unresolved":true,"context_lines":[{"line_number":916,"context_line":"    metric \u003d f\"VCpuUsageMeanVnf.{inst_id}\""},{"line_number":917,"context_line":"    if p_metric:"},{"line_number":918,"context_line":"        metric \u003d f\"{p_metric}\""},{"line_number":919,"context_line":"    return {"},{"line_number":920,"context_line":"        \"receiver\": \"receiver\","},{"line_number":921,"context_line":"        \"status\": \"firing\","},{"line_number":922,"context_line":"        \"alerts\": ["}],"source_content_type":"text/x-python","patch_set":26,"id":"d3d13d2c_062f96de","line":919,"in_reply_to":"26694491_7b3fb606","updated":"2023-03-10 05:24:39.000000000","message":"I appended a comment.","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"8f06305958ef940b7db0ad505c6afd11351558ea","unresolved":true,"context_lines":[{"line_number":916,"context_line":"    metric \u003d f\"VCpuUsageMeanVnf.{inst_id}\""},{"line_number":917,"context_line":"    if p_metric:"},{"line_number":918,"context_line":"        metric \u003d f\"{p_metric}\""},{"line_number":919,"context_line":"    return {"},{"line_number":920,"context_line":"        \"receiver\": \"receiver\","},{"line_number":921,"context_line":"        \"status\": \"firing\","},{"line_number":922,"context_line":"        \"alerts\": ["}],"source_content_type":"text/x-python","patch_set":26,"id":"2010af81_1b9b351d","line":919,"in_reply_to":"d3d13d2c_062f96de","updated":"2023-03-10 07:29:52.000000000","message":"Thank you for adding the comment.\nSince the definition of request data is also described in documents other than Spec, how about simply describing it as follows?\n* This data simulates the complete request body sent by alertmanager.","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"}],"tacker/tests/functional/sol_kubernetes_v2/test_threshold_prometheus_plugin.py":[{"author":{"_account_id":31668,"deleted":true},"change_message_id":"2bed95f895abe6c12974e1bc996e2dd295eee2ec","unresolved":true,"context_lines":[{"line_number":51,"context_line":"            response_headers\u003d{\"Content-Type\": \"text/plain\"})"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def test_performance_management_autoscaling_min(self):"},{"line_number":54,"context_line":"        \"\"\"Test PM Threshold operations with all attributes set"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        * About attributes:"},{"line_number":57,"context_line":"          Omit except for required attributes."}],"source_content_type":"text/x-python","patch_set":8,"id":"48562399_b487b170","line":54,"updated":"2023-02-22 10:12:21.000000000","message":"Since it is a min pattern test, could you Fix as follows?\n* Test PM Threshold operations with omitting except for required attributes","commit_id":"32aba1ae2780c5c78006909d2d0c15068d28d259"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"b73fe49253c115861f045aa7929bf13485a296fb","unresolved":true,"context_lines":[{"line_number":51,"context_line":"            response_headers\u003d{\"Content-Type\": \"text/plain\"})"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def test_performance_management_autoscaling_min(self):"},{"line_number":54,"context_line":"        \"\"\"Test PM Threshold operations with all attributes set"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        * About attributes:"},{"line_number":57,"context_line":"          Omit except for required attributes."}],"source_content_type":"text/x-python","patch_set":8,"id":"daf18d84_3c2d9864","line":54,"in_reply_to":"48562399_b487b170","updated":"2023-02-23 06:27:50.000000000","message":"I fixed it in Patchset 11.","commit_id":"32aba1ae2780c5c78006909d2d0c15068d28d259"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"764aa5e8339fd7da967e397048cff462c9426d9f","unresolved":false,"context_lines":[{"line_number":51,"context_line":"            response_headers\u003d{\"Content-Type\": \"text/plain\"})"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def test_performance_management_autoscaling_min(self):"},{"line_number":54,"context_line":"        \"\"\"Test PM Threshold operations with all attributes set"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        * About attributes:"},{"line_number":57,"context_line":"          Omit except for required attributes."}],"source_content_type":"text/x-python","patch_set":8,"id":"71ee8cee_e19f0b86","line":54,"in_reply_to":"daf18d84_3c2d9864","updated":"2023-02-24 02:08:57.000000000","message":"Done","commit_id":"32aba1ae2780c5c78006909d2d0c15068d28d259"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"2bed95f895abe6c12974e1bc996e2dd295eee2ec","unresolved":true,"context_lines":[{"line_number":76,"context_line":"          - 13. Delete a VNF instance"},{"line_number":77,"context_line":"        \"\"\""},{"line_number":78,"context_line":"        # 1. LCM-Create: Create a new VNF instance resource"},{"line_number":79,"context_line":"        # NOTE: extensions and vnfConfigurableProperties are omitted"},{"line_number":80,"context_line":"        # because they are commented out in etsi_nfv_sol001."},{"line_number":81,"context_line":"        create_req \u003d paramgen.pm_instantiate_cnf_resources_create("},{"line_number":82,"context_line":"            self.vnfd_id_1)"},{"line_number":83,"context_line":"        resp, body \u003d self.create_vnf_instance(create_req)"}],"source_content_type":"text/x-python","patch_set":8,"id":"b04e8a66_cec1a1b9","line":80,"range":{"start_line":79,"start_character":8,"end_line":80,"end_character":60},"updated":"2023-02-22 10:12:21.000000000","message":"In this test, the attributes returned by Create processing are not checked.\nSo I don\u0027t think this NOTE is necessary.","commit_id":"32aba1ae2780c5c78006909d2d0c15068d28d259"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"764aa5e8339fd7da967e397048cff462c9426d9f","unresolved":false,"context_lines":[{"line_number":76,"context_line":"          - 13. Delete a VNF instance"},{"line_number":77,"context_line":"        \"\"\""},{"line_number":78,"context_line":"        # 1. LCM-Create: Create a new VNF instance resource"},{"line_number":79,"context_line":"        # NOTE: extensions and vnfConfigurableProperties are omitted"},{"line_number":80,"context_line":"        # because they are commented out in etsi_nfv_sol001."},{"line_number":81,"context_line":"        create_req \u003d paramgen.pm_instantiate_cnf_resources_create("},{"line_number":82,"context_line":"            self.vnfd_id_1)"},{"line_number":83,"context_line":"        resp, body \u003d self.create_vnf_instance(create_req)"}],"source_content_type":"text/x-python","patch_set":8,"id":"e0ff3546_e0045717","line":80,"range":{"start_line":79,"start_character":8,"end_line":80,"end_character":60},"in_reply_to":"adc16827_f9792779","updated":"2023-02-24 02:08:57.000000000","message":"Done","commit_id":"32aba1ae2780c5c78006909d2d0c15068d28d259"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"b73fe49253c115861f045aa7929bf13485a296fb","unresolved":true,"context_lines":[{"line_number":76,"context_line":"          - 13. Delete a VNF instance"},{"line_number":77,"context_line":"        \"\"\""},{"line_number":78,"context_line":"        # 1. LCM-Create: Create a new VNF instance resource"},{"line_number":79,"context_line":"        # NOTE: extensions and vnfConfigurableProperties are omitted"},{"line_number":80,"context_line":"        # because they are commented out in etsi_nfv_sol001."},{"line_number":81,"context_line":"        create_req \u003d paramgen.pm_instantiate_cnf_resources_create("},{"line_number":82,"context_line":"            self.vnfd_id_1)"},{"line_number":83,"context_line":"        resp, body \u003d self.create_vnf_instance(create_req)"}],"source_content_type":"text/x-python","patch_set":8,"id":"adc16827_f9792779","line":80,"range":{"start_line":79,"start_character":8,"end_line":80,"end_character":60},"in_reply_to":"b04e8a66_cec1a1b9","updated":"2023-02-23 06:27:50.000000000","message":"I fixed it in Patchset 11.","commit_id":"32aba1ae2780c5c78006909d2d0c15068d28d259"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"6595bda8fa2a5bfac0f6e5dfa2bf868e058494e7","unresolved":true,"context_lines":[{"line_number":50,"context_line":"            status_code\u003d202,"},{"line_number":51,"context_line":"            response_headers\u003d{\"Content-Type\": \"text/plain\"})"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def test_performance_management_autoscaling_min(self):"},{"line_number":54,"context_line":"        \"\"\"Test PM Threshold operations with omitting except for required attributes"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        * About attributes:"}],"source_content_type":"text/x-python","patch_set":26,"id":"9bebd069_fe30eaca","line":53,"updated":"2023-03-08 12:10:14.000000000","message":"Could you change the test name to `test_pm_threshold_autoscaling_min()`?","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"6a4ce7e18be5903b66bb84f1f21c90c9319c153a","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            status_code\u003d202,"},{"line_number":51,"context_line":"            response_headers\u003d{\"Content-Type\": \"text/plain\"})"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def test_performance_management_autoscaling_min(self):"},{"line_number":54,"context_line":"        \"\"\"Test PM Threshold operations with omitting except for required attributes"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        * About attributes:"}],"source_content_type":"text/x-python","patch_set":26,"id":"9823dff6_0764d401","line":53,"in_reply_to":"6654baa2_bbc06448","updated":"2023-03-10 06:20:04.000000000","message":"Done","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"6a4ce7e18be5903b66bb84f1f21c90c9319c153a","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            status_code\u003d202,"},{"line_number":51,"context_line":"            response_headers\u003d{\"Content-Type\": \"text/plain\"})"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def test_performance_management_autoscaling_min(self):"},{"line_number":54,"context_line":"        \"\"\"Test PM Threshold operations with omitting except for required attributes"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        * About attributes:"}],"source_content_type":"text/x-python","patch_set":26,"id":"fc6b4b88_07a896c2","line":53,"in_reply_to":"6654baa2_bbc06448","updated":"2023-03-10 06:20:04.000000000","message":"Done","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"ffcbe62c7d93958ce4d3e37c19eefb313a24f4aa","unresolved":true,"context_lines":[{"line_number":50,"context_line":"            status_code\u003d202,"},{"line_number":51,"context_line":"            response_headers\u003d{\"Content-Type\": \"text/plain\"})"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def test_performance_management_autoscaling_min(self):"},{"line_number":54,"context_line":"        \"\"\"Test PM Threshold operations with omitting except for required attributes"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        * About attributes:"}],"source_content_type":"text/x-python","patch_set":26,"id":"6654baa2_bbc06448","line":53,"in_reply_to":"9bebd069_fe30eaca","updated":"2023-03-10 05:24:39.000000000","message":"I fixed it in patchset 27.","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"bfa4c0ad28030aed72bef1e4e055af0771c70503","unresolved":true,"context_lines":[{"line_number":74,"context_line":"          - 11. PM-Threshold 4"},{"line_number":75,"context_line":"          - 12. Terminate a VNF instance"},{"line_number":76,"context_line":"          - 13. Delete a VNF instance"},{"line_number":77,"context_line":"        \"\"\""},{"line_number":78,"context_line":"        # 1. LCM-Create: Create a new VNF instance resource"},{"line_number":79,"context_line":"        create_req \u003d paramgen.pm_instantiate_cnf_resources_create("},{"line_number":80,"context_line":"            self.vnfd_id_1)"}],"source_content_type":"text/x-python","patch_set":26,"id":"14c86e71_739c5b24","line":77,"updated":"2023-03-08 09:27:46.000000000","message":"Could you add the differences in PMThreshold-Create/PM-Threshold 1-4 to the comment-out?","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"ffcbe62c7d93958ce4d3e37c19eefb313a24f4aa","unresolved":true,"context_lines":[{"line_number":74,"context_line":"          - 11. PM-Threshold 4"},{"line_number":75,"context_line":"          - 12. Terminate a VNF instance"},{"line_number":76,"context_line":"          - 13. Delete a VNF instance"},{"line_number":77,"context_line":"        \"\"\""},{"line_number":78,"context_line":"        # 1. LCM-Create: Create a new VNF instance resource"},{"line_number":79,"context_line":"        create_req \u003d paramgen.pm_instantiate_cnf_resources_create("},{"line_number":80,"context_line":"            self.vnfd_id_1)"}],"source_content_type":"text/x-python","patch_set":26,"id":"40ea4430_c3a83a9f","line":77,"in_reply_to":"14c86e71_739c5b24","updated":"2023-03-10 05:24:39.000000000","message":"I appended the comments about `PMThreshold-Create/PM-Threshold 1-4`.","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"8096f634da5f4bec8e0dc92cb09c6a7255f1dc94","unresolved":true,"context_lines":[{"line_number":74,"context_line":"          - 11. PM-Threshold 4"},{"line_number":75,"context_line":"          - 12. Terminate a VNF instance"},{"line_number":76,"context_line":"          - 13. Delete a VNF instance"},{"line_number":77,"context_line":"        \"\"\""},{"line_number":78,"context_line":"        # 1. LCM-Create: Create a new VNF instance resource"},{"line_number":79,"context_line":"        create_req \u003d paramgen.pm_instantiate_cnf_resources_create("},{"line_number":80,"context_line":"            self.vnfd_id_1)"}],"source_content_type":"text/x-python","patch_set":26,"id":"a99cda57_eaca21fd","line":77,"in_reply_to":"40ea4430_c3a83a9f","updated":"2023-03-10 07:12:53.000000000","message":"`PM-Threshold 3` \u003e `metric` \u003e  `ByteIncomingVnfIntCp` is missing double quotes.\nByteIncomingVnfIntCp -\u003e \"ByteIncomingVnfIntCp\"","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"89d8eecf4d6eafa01ecd3d477d835a9dd7fc61ab","unresolved":true,"context_lines":[{"line_number":74,"context_line":"          - 11. PM-Threshold 4"},{"line_number":75,"context_line":"          - 12. Terminate a VNF instance"},{"line_number":76,"context_line":"          - 13. Delete a VNF instance"},{"line_number":77,"context_line":"        \"\"\""},{"line_number":78,"context_line":"        # 1. LCM-Create: Create a new VNF instance resource"},{"line_number":79,"context_line":"        create_req \u003d paramgen.pm_instantiate_cnf_resources_create("},{"line_number":80,"context_line":"            self.vnfd_id_1)"}],"source_content_type":"text/x-python","patch_set":26,"id":"ede202b8_77abbe8c","line":77,"in_reply_to":"a99cda57_eaca21fd","updated":"2023-03-10 07:56:26.000000000","message":"I fixed it in patchset 28.","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"a5f68ccbb33fd7bf336cec7bbe3b04ca7541a5d8","unresolved":false,"context_lines":[{"line_number":74,"context_line":"          - 11. PM-Threshold 4"},{"line_number":75,"context_line":"          - 12. Terminate a VNF instance"},{"line_number":76,"context_line":"          - 13. Delete a VNF instance"},{"line_number":77,"context_line":"        \"\"\""},{"line_number":78,"context_line":"        # 1. LCM-Create: Create a new VNF instance resource"},{"line_number":79,"context_line":"        create_req \u003d paramgen.pm_instantiate_cnf_resources_create("},{"line_number":80,"context_line":"            self.vnfd_id_1)"}],"source_content_type":"text/x-python","patch_set":26,"id":"f9d23070_aee4deb4","line":77,"in_reply_to":"ede202b8_77abbe8c","updated":"2023-03-13 03:09:39.000000000","message":"Done","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"45447a724915d25e12c4999542d15f6abbcda10a","unresolved":true,"context_lines":[{"line_number":152,"context_line":"            \u0027callbackUri\u0027,"},{"line_number":153,"context_line":"            \u0027_links\u0027"},{"line_number":154,"context_line":"        ]"},{"line_number":155,"context_line":"        callback_url \u003d os.path.join(base_v2.MOCK_NOTIFY_CALLBACK_URL,"},{"line_number":156,"context_line":"                                    self._testMethodName)"},{"line_number":157,"context_line":"        callback_uri \u003d (\u0027http://localhost:\u0027"},{"line_number":158,"context_line":"                        f\u0027{base_v2.FAKE_SERVER_MANAGER.SERVER_PORT}\u0027"},{"line_number":159,"context_line":"                        f\u0027{callback_url}\u0027)"},{"line_number":160,"context_line":"        sub_req \u003d paramgen.pm_threshold_min("},{"line_number":161,"context_line":"            callback_uri, inst_id, self.fake_prometheus_ip,"},{"line_number":162,"context_line":"            objectType\u003d\"Vnfc\","}],"source_content_type":"text/x-python","patch_set":26,"id":"9cc7ffc5_4b80458f","line":159,"range":{"start_line":155,"start_character":0,"end_line":159,"end_character":42},"updated":"2023-03-09 02:41:09.000000000","message":"What is the reason for recreating the \"callback_url\" and \"callback_uri\"?\nIf it needs to be recreated, please add the reason in the comments.","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"ffcbe62c7d93958ce4d3e37c19eefb313a24f4aa","unresolved":true,"context_lines":[{"line_number":152,"context_line":"            \u0027callbackUri\u0027,"},{"line_number":153,"context_line":"            \u0027_links\u0027"},{"line_number":154,"context_line":"        ]"},{"line_number":155,"context_line":"        callback_url \u003d os.path.join(base_v2.MOCK_NOTIFY_CALLBACK_URL,"},{"line_number":156,"context_line":"                                    self._testMethodName)"},{"line_number":157,"context_line":"        callback_uri \u003d (\u0027http://localhost:\u0027"},{"line_number":158,"context_line":"                        f\u0027{base_v2.FAKE_SERVER_MANAGER.SERVER_PORT}\u0027"},{"line_number":159,"context_line":"                        f\u0027{callback_url}\u0027)"},{"line_number":160,"context_line":"        sub_req \u003d paramgen.pm_threshold_min("},{"line_number":161,"context_line":"            callback_uri, inst_id, self.fake_prometheus_ip,"},{"line_number":162,"context_line":"            objectType\u003d\"Vnfc\","}],"source_content_type":"text/x-python","patch_set":26,"id":"d12188eb_b93d99e5","line":159,"range":{"start_line":155,"start_character":0,"end_line":159,"end_character":42},"in_reply_to":"9cc7ffc5_4b80458f","updated":"2023-03-10 05:24:39.000000000","message":"I removed them in patchset 27.","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"8f06305958ef940b7db0ad505c6afd11351558ea","unresolved":false,"context_lines":[{"line_number":152,"context_line":"            \u0027callbackUri\u0027,"},{"line_number":153,"context_line":"            \u0027_links\u0027"},{"line_number":154,"context_line":"        ]"},{"line_number":155,"context_line":"        callback_url \u003d os.path.join(base_v2.MOCK_NOTIFY_CALLBACK_URL,"},{"line_number":156,"context_line":"                                    self._testMethodName)"},{"line_number":157,"context_line":"        callback_uri \u003d (\u0027http://localhost:\u0027"},{"line_number":158,"context_line":"                        f\u0027{base_v2.FAKE_SERVER_MANAGER.SERVER_PORT}\u0027"},{"line_number":159,"context_line":"                        f\u0027{callback_url}\u0027)"},{"line_number":160,"context_line":"        sub_req \u003d paramgen.pm_threshold_min("},{"line_number":161,"context_line":"            callback_uri, inst_id, self.fake_prometheus_ip,"},{"line_number":162,"context_line":"            objectType\u003d\"Vnfc\","}],"source_content_type":"text/x-python","patch_set":26,"id":"888432b3_03333081","line":159,"range":{"start_line":155,"start_character":0,"end_line":159,"end_character":42},"in_reply_to":"d12188eb_b93d99e5","updated":"2023-03-10 07:29:52.000000000","message":"Done","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"6595bda8fa2a5bfac0f6e5dfa2bf868e058494e7","unresolved":true,"context_lines":[{"line_number":291,"context_line":"        resp, body \u003d self.show_vnf_instance(inst_id)"},{"line_number":292,"context_line":"        self.assertEqual(404, resp.status_code)"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"    def test_performance_management_autoscaling_max(self):"},{"line_number":295,"context_line":"        \"\"\"Test PM Threshold operations with all attributes set"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"        * About attributes:"}],"source_content_type":"text/x-python","patch_set":26,"id":"41394b5d_eef8dd70","line":294,"updated":"2023-03-08 12:10:14.000000000","message":"Could you change the test name to `test_pm_threshold_autoscaling_max()`?","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"ffcbe62c7d93958ce4d3e37c19eefb313a24f4aa","unresolved":true,"context_lines":[{"line_number":291,"context_line":"        resp, body \u003d self.show_vnf_instance(inst_id)"},{"line_number":292,"context_line":"        self.assertEqual(404, resp.status_code)"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"    def test_performance_management_autoscaling_max(self):"},{"line_number":295,"context_line":"        \"\"\"Test PM Threshold operations with all attributes set"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"        * About attributes:"}],"source_content_type":"text/x-python","patch_set":26,"id":"a983068a_beda85d0","line":294,"in_reply_to":"41394b5d_eef8dd70","updated":"2023-03-10 05:24:39.000000000","message":"I fixed it in patchset 27.","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"6a4ce7e18be5903b66bb84f1f21c90c9319c153a","unresolved":false,"context_lines":[{"line_number":291,"context_line":"        resp, body \u003d self.show_vnf_instance(inst_id)"},{"line_number":292,"context_line":"        self.assertEqual(404, resp.status_code)"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"    def test_performance_management_autoscaling_max(self):"},{"line_number":295,"context_line":"        \"\"\"Test PM Threshold operations with all attributes set"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"        * About attributes:"}],"source_content_type":"text/x-python","patch_set":26,"id":"b1bbc599_00f074ae","line":294,"in_reply_to":"a983068a_beda85d0","updated":"2023-03-10 06:20:04.000000000","message":"Done","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"bfa4c0ad28030aed72bef1e4e055af0771c70503","unresolved":true,"context_lines":[{"line_number":316,"context_line":"          - 10. PMThreshold-Create 4"},{"line_number":317,"context_line":"          - 11. PM-Threshold 4"},{"line_number":318,"context_line":"          - 12. Terminate a VNF instance"},{"line_number":319,"context_line":"          - 13. Delete a VNF instance"},{"line_number":320,"context_line":"        \"\"\""},{"line_number":321,"context_line":"        # 1. LCM-Create: Create a new VNF instance resource"},{"line_number":322,"context_line":"        # NOTE: extensions and vnfConfigurableProperties are omitted"}],"source_content_type":"text/x-python","patch_set":26,"id":"9de6fc61_0fbe8df3","line":319,"updated":"2023-03-08 09:27:46.000000000","message":"ditto.","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"8096f634da5f4bec8e0dc92cb09c6a7255f1dc94","unresolved":true,"context_lines":[{"line_number":316,"context_line":"          - 10. PMThreshold-Create 4"},{"line_number":317,"context_line":"          - 11. PM-Threshold 4"},{"line_number":318,"context_line":"          - 12. Terminate a VNF instance"},{"line_number":319,"context_line":"          - 13. Delete a VNF instance"},{"line_number":320,"context_line":"        \"\"\""},{"line_number":321,"context_line":"        # 1. LCM-Create: Create a new VNF instance resource"},{"line_number":322,"context_line":"        # NOTE: extensions and vnfConfigurableProperties are omitted"}],"source_content_type":"text/x-python","patch_set":26,"id":"ce89d142_46192667","line":319,"in_reply_to":"2f0ade64_5fe533db","updated":"2023-03-10 07:12:53.000000000","message":"`PM-Threshold 3` \u003e `metric` \u003e  `ByteIncomingVnfIntCp` is missing double quotes.\nByteIncomingVnfIntCp -\u003e \"ByteIncomingVnfIntCp\"","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"ffcbe62c7d93958ce4d3e37c19eefb313a24f4aa","unresolved":true,"context_lines":[{"line_number":316,"context_line":"          - 10. PMThreshold-Create 4"},{"line_number":317,"context_line":"          - 11. PM-Threshold 4"},{"line_number":318,"context_line":"          - 12. Terminate a VNF instance"},{"line_number":319,"context_line":"          - 13. Delete a VNF instance"},{"line_number":320,"context_line":"        \"\"\""},{"line_number":321,"context_line":"        # 1. LCM-Create: Create a new VNF instance resource"},{"line_number":322,"context_line":"        # NOTE: extensions and vnfConfigurableProperties are omitted"}],"source_content_type":"text/x-python","patch_set":26,"id":"2f0ade64_5fe533db","line":319,"in_reply_to":"9de6fc61_0fbe8df3","updated":"2023-03-10 05:24:39.000000000","message":"I appended the comments about `PMThreshold-Create/PM-Threshold 1-4`.","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"a5f68ccbb33fd7bf336cec7bbe3b04ca7541a5d8","unresolved":false,"context_lines":[{"line_number":316,"context_line":"          - 10. PMThreshold-Create 4"},{"line_number":317,"context_line":"          - 11. PM-Threshold 4"},{"line_number":318,"context_line":"          - 12. Terminate a VNF instance"},{"line_number":319,"context_line":"          - 13. Delete a VNF instance"},{"line_number":320,"context_line":"        \"\"\""},{"line_number":321,"context_line":"        # 1. LCM-Create: Create a new VNF instance resource"},{"line_number":322,"context_line":"        # NOTE: extensions and vnfConfigurableProperties are omitted"}],"source_content_type":"text/x-python","patch_set":26,"id":"88f3f869_3d78e9aa","line":319,"in_reply_to":"a5be3ee6_43808690","updated":"2023-03-13 03:09:39.000000000","message":"Done","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"89d8eecf4d6eafa01ecd3d477d835a9dd7fc61ab","unresolved":true,"context_lines":[{"line_number":316,"context_line":"          - 10. PMThreshold-Create 4"},{"line_number":317,"context_line":"          - 11. PM-Threshold 4"},{"line_number":318,"context_line":"          - 12. Terminate a VNF instance"},{"line_number":319,"context_line":"          - 13. Delete a VNF instance"},{"line_number":320,"context_line":"        \"\"\""},{"line_number":321,"context_line":"        # 1. LCM-Create: Create a new VNF instance resource"},{"line_number":322,"context_line":"        # NOTE: extensions and vnfConfigurableProperties are omitted"}],"source_content_type":"text/x-python","patch_set":26,"id":"a5be3ee6_43808690","line":319,"in_reply_to":"ce89d142_46192667","updated":"2023-03-10 07:56:26.000000000","message":"I fixed it in patchset 28.","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"45447a724915d25e12c4999542d15f6abbcda10a","unresolved":true,"context_lines":[{"line_number":373,"context_line":"        # The creation of \"pm_threshold\" will be asynchronous"},{"line_number":374,"context_line":"        # and wait for the creation to end"},{"line_number":375,"context_line":"        time.sleep(5)"},{"line_number":376,"context_line":"        self._check_notification("},{"line_number":377,"context_line":"            callback_url, \u0027ThresholdCrossedNotification\u0027)"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"        # 5. LCM-Scale"}],"source_content_type":"text/x-python","patch_set":26,"id":"5d2497ff_097a7bbe","line":376,"updated":"2023-03-09 02:41:09.000000000","message":"Is there a process to check if the \"crossingDirection\" is \"UP\"?","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"ffcbe62c7d93958ce4d3e37c19eefb313a24f4aa","unresolved":true,"context_lines":[{"line_number":373,"context_line":"        # The creation of \"pm_threshold\" will be asynchronous"},{"line_number":374,"context_line":"        # and wait for the creation to end"},{"line_number":375,"context_line":"        time.sleep(5)"},{"line_number":376,"context_line":"        self._check_notification("},{"line_number":377,"context_line":"            callback_url, \u0027ThresholdCrossedNotification\u0027)"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"        # 5. LCM-Scale"}],"source_content_type":"text/x-python","patch_set":26,"id":"5fad6781_68e693c6","line":376,"in_reply_to":"5d2497ff_097a7bbe","updated":"2023-03-10 05:24:39.000000000","message":"I appended assertion on `crossingDirection`.","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"8f06305958ef940b7db0ad505c6afd11351558ea","unresolved":false,"context_lines":[{"line_number":373,"context_line":"        # The creation of \"pm_threshold\" will be asynchronous"},{"line_number":374,"context_line":"        # and wait for the creation to end"},{"line_number":375,"context_line":"        time.sleep(5)"},{"line_number":376,"context_line":"        self._check_notification("},{"line_number":377,"context_line":"            callback_url, \u0027ThresholdCrossedNotification\u0027)"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"        # 5. LCM-Scale"}],"source_content_type":"text/x-python","patch_set":26,"id":"ea8c771f_884bf384","line":376,"in_reply_to":"5fad6781_68e693c6","updated":"2023-03-10 07:29:52.000000000","message":"Done","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"45447a724915d25e12c4999542d15f6abbcda10a","unresolved":true,"context_lines":[{"line_number":396,"context_line":"            \u0027callbackUri\u0027,"},{"line_number":397,"context_line":"            \u0027_links\u0027"},{"line_number":398,"context_line":"        ]"},{"line_number":399,"context_line":"        callback_url \u003d os.path.join(base_v2.MOCK_NOTIFY_CALLBACK_URL,"},{"line_number":400,"context_line":"                                    self._testMethodName)"},{"line_number":401,"context_line":"        callback_uri \u003d (\u0027http://localhost:\u0027"},{"line_number":402,"context_line":"                        f\u0027{base_v2.FAKE_SERVER_MANAGER.SERVER_PORT}\u0027"},{"line_number":403,"context_line":"                        f\u0027{callback_url}\u0027)"},{"line_number":404,"context_line":"        sub_req \u003d paramgen.pm_threshold_max("},{"line_number":405,"context_line":"            callback_uri, inst_id, self.fake_prometheus_ip,"},{"line_number":406,"context_line":"            objectType\u003d\"Vnfc\","}],"source_content_type":"text/x-python","patch_set":26,"id":"578b04f6_f70a1d88","line":403,"range":{"start_line":399,"start_character":0,"end_line":403,"end_character":42},"updated":"2023-03-09 02:41:09.000000000","message":"What is the reason for recreating the \"callback_url\" and \"callback_uri\"?\nIf it needs to be recreated, please add the reason in the comments.","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"ffcbe62c7d93958ce4d3e37c19eefb313a24f4aa","unresolved":true,"context_lines":[{"line_number":396,"context_line":"            \u0027callbackUri\u0027,"},{"line_number":397,"context_line":"            \u0027_links\u0027"},{"line_number":398,"context_line":"        ]"},{"line_number":399,"context_line":"        callback_url \u003d os.path.join(base_v2.MOCK_NOTIFY_CALLBACK_URL,"},{"line_number":400,"context_line":"                                    self._testMethodName)"},{"line_number":401,"context_line":"        callback_uri \u003d (\u0027http://localhost:\u0027"},{"line_number":402,"context_line":"                        f\u0027{base_v2.FAKE_SERVER_MANAGER.SERVER_PORT}\u0027"},{"line_number":403,"context_line":"                        f\u0027{callback_url}\u0027)"},{"line_number":404,"context_line":"        sub_req \u003d paramgen.pm_threshold_max("},{"line_number":405,"context_line":"            callback_uri, inst_id, self.fake_prometheus_ip,"},{"line_number":406,"context_line":"            objectType\u003d\"Vnfc\","}],"source_content_type":"text/x-python","patch_set":26,"id":"ceab3472_53dc5f9a","line":403,"range":{"start_line":399,"start_character":0,"end_line":403,"end_character":42},"in_reply_to":"578b04f6_f70a1d88","updated":"2023-03-10 05:24:39.000000000","message":"I removed them in patchset 27.","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"8f06305958ef940b7db0ad505c6afd11351558ea","unresolved":false,"context_lines":[{"line_number":396,"context_line":"            \u0027callbackUri\u0027,"},{"line_number":397,"context_line":"            \u0027_links\u0027"},{"line_number":398,"context_line":"        ]"},{"line_number":399,"context_line":"        callback_url \u003d os.path.join(base_v2.MOCK_NOTIFY_CALLBACK_URL,"},{"line_number":400,"context_line":"                                    self._testMethodName)"},{"line_number":401,"context_line":"        callback_uri \u003d (\u0027http://localhost:\u0027"},{"line_number":402,"context_line":"                        f\u0027{base_v2.FAKE_SERVER_MANAGER.SERVER_PORT}\u0027"},{"line_number":403,"context_line":"                        f\u0027{callback_url}\u0027)"},{"line_number":404,"context_line":"        sub_req \u003d paramgen.pm_threshold_max("},{"line_number":405,"context_line":"            callback_uri, inst_id, self.fake_prometheus_ip,"},{"line_number":406,"context_line":"            objectType\u003d\"Vnfc\","}],"source_content_type":"text/x-python","patch_set":26,"id":"d7ae6737_14703015","line":403,"range":{"start_line":399,"start_character":0,"end_line":403,"end_character":42},"in_reply_to":"ceab3472_53dc5f9a","updated":"2023-03-10 07:29:52.000000000","message":"Done","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"45447a724915d25e12c4999542d15f6abbcda10a","unresolved":true,"context_lines":[{"line_number":424,"context_line":"        # The creation of \"pm_threshold\" will be asynchronous"},{"line_number":425,"context_line":"        # and wait for the creation to end"},{"line_number":426,"context_line":"        time.sleep(5)"},{"line_number":427,"context_line":"        self._check_notification("},{"line_number":428,"context_line":"            callback_url, \u0027ThresholdCrossedNotification\u0027)"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"        # 8. PMThreshold-Create 3"}],"source_content_type":"text/x-python","patch_set":26,"id":"9d5766e5_b80dfcec","line":427,"updated":"2023-03-09 02:41:09.000000000","message":"Is there a process to check if the \"crossingDirection\" is \"UP\"?","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"ffcbe62c7d93958ce4d3e37c19eefb313a24f4aa","unresolved":true,"context_lines":[{"line_number":424,"context_line":"        # The creation of \"pm_threshold\" will be asynchronous"},{"line_number":425,"context_line":"        # and wait for the creation to end"},{"line_number":426,"context_line":"        time.sleep(5)"},{"line_number":427,"context_line":"        self._check_notification("},{"line_number":428,"context_line":"            callback_url, \u0027ThresholdCrossedNotification\u0027)"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"        # 8. PMThreshold-Create 3"}],"source_content_type":"text/x-python","patch_set":26,"id":"f1373e3b_fe80edca","line":427,"in_reply_to":"9d5766e5_b80dfcec","updated":"2023-03-10 05:24:39.000000000","message":"I appended assertion on `crossingDirection`.","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"8f06305958ef940b7db0ad505c6afd11351558ea","unresolved":false,"context_lines":[{"line_number":424,"context_line":"        # The creation of \"pm_threshold\" will be asynchronous"},{"line_number":425,"context_line":"        # and wait for the creation to end"},{"line_number":426,"context_line":"        time.sleep(5)"},{"line_number":427,"context_line":"        self._check_notification("},{"line_number":428,"context_line":"            callback_url, \u0027ThresholdCrossedNotification\u0027)"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"        # 8. PMThreshold-Create 3"}],"source_content_type":"text/x-python","patch_set":26,"id":"0dc7f6d4_b74d002b","line":427,"in_reply_to":"f1373e3b_fe80edca","updated":"2023-03-10 07:29:52.000000000","message":"Done","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"45447a724915d25e12c4999542d15f6abbcda10a","unresolved":true,"context_lines":[{"line_number":458,"context_line":"        # The creation of \"pm_threshold\" will be asynchronous"},{"line_number":459,"context_line":"        # and wait for the creation to end"},{"line_number":460,"context_line":"        time.sleep(5)"},{"line_number":461,"context_line":"        self._check_notification("},{"line_number":462,"context_line":"            callback_url, \u0027ThresholdCrossedNotification\u0027)"},{"line_number":463,"context_line":""},{"line_number":464,"context_line":"        # 10. PMThreshold-Create 4"}],"source_content_type":"text/x-python","patch_set":26,"id":"38594d7a_c645f452","line":461,"updated":"2023-03-09 02:41:09.000000000","message":"Is there a process to check if the \"crossingDirection\" is \"UP\"?","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"ffcbe62c7d93958ce4d3e37c19eefb313a24f4aa","unresolved":true,"context_lines":[{"line_number":458,"context_line":"        # The creation of \"pm_threshold\" will be asynchronous"},{"line_number":459,"context_line":"        # and wait for the creation to end"},{"line_number":460,"context_line":"        time.sleep(5)"},{"line_number":461,"context_line":"        self._check_notification("},{"line_number":462,"context_line":"            callback_url, \u0027ThresholdCrossedNotification\u0027)"},{"line_number":463,"context_line":""},{"line_number":464,"context_line":"        # 10. PMThreshold-Create 4"}],"source_content_type":"text/x-python","patch_set":26,"id":"c693041d_828fb7c3","line":461,"in_reply_to":"38594d7a_c645f452","updated":"2023-03-10 05:24:39.000000000","message":"I appended assertion on `crossingDirection`.","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"8f06305958ef940b7db0ad505c6afd11351558ea","unresolved":false,"context_lines":[{"line_number":458,"context_line":"        # The creation of \"pm_threshold\" will be asynchronous"},{"line_number":459,"context_line":"        # and wait for the creation to end"},{"line_number":460,"context_line":"        time.sleep(5)"},{"line_number":461,"context_line":"        self._check_notification("},{"line_number":462,"context_line":"            callback_url, \u0027ThresholdCrossedNotification\u0027)"},{"line_number":463,"context_line":""},{"line_number":464,"context_line":"        # 10. PMThreshold-Create 4"}],"source_content_type":"text/x-python","patch_set":26,"id":"7a78c163_eaa1568a","line":461,"in_reply_to":"c693041d_828fb7c3","updated":"2023-03-10 07:29:52.000000000","message":"Done","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"45447a724915d25e12c4999542d15f6abbcda10a","unresolved":true,"context_lines":[{"line_number":492,"context_line":"        # The creation of \"pm_threshold\" will be asynchronous"},{"line_number":493,"context_line":"        # and wait for the creation to end"},{"line_number":494,"context_line":"        time.sleep(5)"},{"line_number":495,"context_line":"        self._check_notification("},{"line_number":496,"context_line":"            callback_url, \u0027ThresholdCrossedNotification\u0027)"},{"line_number":497,"context_line":""},{"line_number":498,"context_line":"        resp, body \u003d self.delete_pm_threshold(pm_threshold_id_1)"}],"source_content_type":"text/x-python","patch_set":26,"id":"4f0d7982_b0eb0c86","line":495,"updated":"2023-03-09 02:41:09.000000000","message":"Is there a process to check if the \"crossingDirection\" is \"UP\"?","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"ffcbe62c7d93958ce4d3e37c19eefb313a24f4aa","unresolved":true,"context_lines":[{"line_number":492,"context_line":"        # The creation of \"pm_threshold\" will be asynchronous"},{"line_number":493,"context_line":"        # and wait for the creation to end"},{"line_number":494,"context_line":"        time.sleep(5)"},{"line_number":495,"context_line":"        self._check_notification("},{"line_number":496,"context_line":"            callback_url, \u0027ThresholdCrossedNotification\u0027)"},{"line_number":497,"context_line":""},{"line_number":498,"context_line":"        resp, body \u003d self.delete_pm_threshold(pm_threshold_id_1)"}],"source_content_type":"text/x-python","patch_set":26,"id":"f7e883ef_40206788","line":495,"in_reply_to":"4f0d7982_b0eb0c86","updated":"2023-03-10 05:24:39.000000000","message":"I appended assertion on `crossingDirection`.","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"8f06305958ef940b7db0ad505c6afd11351558ea","unresolved":false,"context_lines":[{"line_number":492,"context_line":"        # The creation of \"pm_threshold\" will be asynchronous"},{"line_number":493,"context_line":"        # and wait for the creation to end"},{"line_number":494,"context_line":"        time.sleep(5)"},{"line_number":495,"context_line":"        self._check_notification("},{"line_number":496,"context_line":"            callback_url, \u0027ThresholdCrossedNotification\u0027)"},{"line_number":497,"context_line":""},{"line_number":498,"context_line":"        resp, body \u003d self.delete_pm_threshold(pm_threshold_id_1)"}],"source_content_type":"text/x-python","patch_set":26,"id":"344ff281_c2acb041","line":495,"in_reply_to":"f7e883ef_40206788","updated":"2023-03-10 07:29:52.000000000","message":"Done","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"6595bda8fa2a5bfac0f6e5dfa2bf868e058494e7","unresolved":true,"context_lines":[{"line_number":539,"context_line":"        resp, body \u003d self.show_vnf_instance(inst_id)"},{"line_number":540,"context_line":"        self.assertEqual(404, resp.status_code)"},{"line_number":541,"context_line":""},{"line_number":542,"context_line":"    def test_performance_management_other(self):"},{"line_number":543,"context_line":"        \"\"\"Test PM Threshold operations with all attributes set"},{"line_number":544,"context_line":""},{"line_number":545,"context_line":"        * About attributes:"}],"source_content_type":"text/x-python","patch_set":26,"id":"7079396a_6395e6b5","line":542,"updated":"2023-03-08 12:10:14.000000000","message":"`test_performance_management_other` means difficult to understand this threshold test.\nCould you change the test name to `test_pm_threshold_with_all_attibutes`?","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"6a4ce7e18be5903b66bb84f1f21c90c9319c153a","unresolved":false,"context_lines":[{"line_number":539,"context_line":"        resp, body \u003d self.show_vnf_instance(inst_id)"},{"line_number":540,"context_line":"        self.assertEqual(404, resp.status_code)"},{"line_number":541,"context_line":""},{"line_number":542,"context_line":"    def test_performance_management_other(self):"},{"line_number":543,"context_line":"        \"\"\"Test PM Threshold operations with all attributes set"},{"line_number":544,"context_line":""},{"line_number":545,"context_line":"        * About attributes:"}],"source_content_type":"text/x-python","patch_set":26,"id":"b28a9d0e_b67a6d9d","line":542,"in_reply_to":"30510dae_eee47ed3","updated":"2023-03-10 06:20:04.000000000","message":"Done","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"ffcbe62c7d93958ce4d3e37c19eefb313a24f4aa","unresolved":true,"context_lines":[{"line_number":539,"context_line":"        resp, body \u003d self.show_vnf_instance(inst_id)"},{"line_number":540,"context_line":"        self.assertEqual(404, resp.status_code)"},{"line_number":541,"context_line":""},{"line_number":542,"context_line":"    def test_performance_management_other(self):"},{"line_number":543,"context_line":"        \"\"\"Test PM Threshold operations with all attributes set"},{"line_number":544,"context_line":""},{"line_number":545,"context_line":"        * About attributes:"}],"source_content_type":"text/x-python","patch_set":26,"id":"30510dae_eee47ed3","line":542,"in_reply_to":"7079396a_6395e6b5","updated":"2023-03-10 05:24:39.000000000","message":"I fixed it in patchset 27.","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"bfa4c0ad28030aed72bef1e4e055af0771c70503","unresolved":true,"context_lines":[{"line_number":562,"context_line":"          - 8. PM-Threshold 5-5"},{"line_number":563,"context_line":"          - 9. PM-Threshold 5-6"},{"line_number":564,"context_line":"          - 10. Terminate a VNF instance"},{"line_number":565,"context_line":"          - 11. Delete a VNF instance"},{"line_number":566,"context_line":"        \"\"\""},{"line_number":567,"context_line":"        # 1. LCM-Create: Create a new VNF instance resource"},{"line_number":568,"context_line":"        # NOTE: extensions and vnfConfigurableProperties are omitted"}],"source_content_type":"text/x-python","patch_set":26,"id":"1aea53c7_33a428e5","line":565,"updated":"2023-03-08 09:27:46.000000000","message":"ditto.","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"ffcbe62c7d93958ce4d3e37c19eefb313a24f4aa","unresolved":true,"context_lines":[{"line_number":562,"context_line":"          - 8. PM-Threshold 5-5"},{"line_number":563,"context_line":"          - 9. PM-Threshold 5-6"},{"line_number":564,"context_line":"          - 10. Terminate a VNF instance"},{"line_number":565,"context_line":"          - 11. Delete a VNF instance"},{"line_number":566,"context_line":"        \"\"\""},{"line_number":567,"context_line":"        # 1. LCM-Create: Create a new VNF instance resource"},{"line_number":568,"context_line":"        # NOTE: extensions and vnfConfigurableProperties are omitted"}],"source_content_type":"text/x-python","patch_set":26,"id":"bc366fea_2b18b094","line":565,"in_reply_to":"1aea53c7_33a428e5","updated":"2023-03-10 05:24:39.000000000","message":"I appended the comments about `PMThreshold-Create 5/PM-Threshold 5-1~6`.","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"8096f634da5f4bec8e0dc92cb09c6a7255f1dc94","unresolved":false,"context_lines":[{"line_number":562,"context_line":"          - 8. PM-Threshold 5-5"},{"line_number":563,"context_line":"          - 9. PM-Threshold 5-6"},{"line_number":564,"context_line":"          - 10. Terminate a VNF instance"},{"line_number":565,"context_line":"          - 11. Delete a VNF instance"},{"line_number":566,"context_line":"        \"\"\""},{"line_number":567,"context_line":"        # 1. LCM-Create: Create a new VNF instance resource"},{"line_number":568,"context_line":"        # NOTE: extensions and vnfConfigurableProperties are omitted"}],"source_content_type":"text/x-python","patch_set":26,"id":"46e96af2_8b405eaa","line":565,"in_reply_to":"bc366fea_2b18b094","updated":"2023-03-10 07:12:53.000000000","message":"Done","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"45447a724915d25e12c4999542d15f6abbcda10a","unresolved":true,"context_lines":[{"line_number":619,"context_line":"        # wait a bit because there is a bit time lag between lcmocc DB"},{"line_number":620,"context_line":"        # update and terminate completion."},{"line_number":621,"context_line":"        time.sleep(5)"},{"line_number":622,"context_line":"        self._check_notification("},{"line_number":623,"context_line":"            callback_url, \u0027ThresholdCrossedNotification\u0027)"},{"line_number":624,"context_line":""},{"line_number":625,"context_line":"        # 5. PM-Threshold 5-2"}],"source_content_type":"text/x-python","patch_set":26,"id":"bf86839d_169dc9f8","line":622,"updated":"2023-03-09 02:41:09.000000000","message":"Is there a process to check if the \"crossingDirection\" is \"UP\"?","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"ffcbe62c7d93958ce4d3e37c19eefb313a24f4aa","unresolved":true,"context_lines":[{"line_number":619,"context_line":"        # wait a bit because there is a bit time lag between lcmocc DB"},{"line_number":620,"context_line":"        # update and terminate completion."},{"line_number":621,"context_line":"        time.sleep(5)"},{"line_number":622,"context_line":"        self._check_notification("},{"line_number":623,"context_line":"            callback_url, \u0027ThresholdCrossedNotification\u0027)"},{"line_number":624,"context_line":""},{"line_number":625,"context_line":"        # 5. PM-Threshold 5-2"}],"source_content_type":"text/x-python","patch_set":26,"id":"d29f89c3_30de562f","line":622,"in_reply_to":"bf86839d_169dc9f8","updated":"2023-03-10 05:24:39.000000000","message":"I appended assertion on `crossingDirection`.","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"8f06305958ef940b7db0ad505c6afd11351558ea","unresolved":false,"context_lines":[{"line_number":619,"context_line":"        # wait a bit because there is a bit time lag between lcmocc DB"},{"line_number":620,"context_line":"        # update and terminate completion."},{"line_number":621,"context_line":"        time.sleep(5)"},{"line_number":622,"context_line":"        self._check_notification("},{"line_number":623,"context_line":"            callback_url, \u0027ThresholdCrossedNotification\u0027)"},{"line_number":624,"context_line":""},{"line_number":625,"context_line":"        # 5. PM-Threshold 5-2"}],"source_content_type":"text/x-python","patch_set":26,"id":"d13b28d0_572c9940","line":622,"in_reply_to":"d29f89c3_30de562f","updated":"2023-03-10 07:29:52.000000000","message":"Done","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"45447a724915d25e12c4999542d15f6abbcda10a","unresolved":true,"context_lines":[{"line_number":622,"context_line":"        self._check_notification("},{"line_number":623,"context_line":"            callback_url, \u0027ThresholdCrossedNotification\u0027)"},{"line_number":624,"context_line":""},{"line_number":625,"context_line":"        # 5. PM-Threshold 5-2"},{"line_number":626,"context_line":"        sub_req \u003d paramgen.pm_threshold("},{"line_number":627,"context_line":"            pm_threshold_id_5, inst_id,"},{"line_number":628,"context_line":"            value\u003d105,"}],"source_content_type":"text/x-python","patch_set":26,"id":"1c56c702_4d79c344","line":625,"updated":"2023-03-09 02:41:09.000000000","message":"Is it unnecessary to check if notification is not notified?","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"ffcbe62c7d93958ce4d3e37c19eefb313a24f4aa","unresolved":true,"context_lines":[{"line_number":622,"context_line":"        self._check_notification("},{"line_number":623,"context_line":"            callback_url, \u0027ThresholdCrossedNotification\u0027)"},{"line_number":624,"context_line":""},{"line_number":625,"context_line":"        # 5. PM-Threshold 5-2"},{"line_number":626,"context_line":"        sub_req \u003d paramgen.pm_threshold("},{"line_number":627,"context_line":"            pm_threshold_id_5, inst_id,"},{"line_number":628,"context_line":"            value\u003d105,"}],"source_content_type":"text/x-python","patch_set":26,"id":"99bbce40_7539d798","line":625,"in_reply_to":"1c56c702_4d79c344","updated":"2023-03-10 05:24:39.000000000","message":"I appended checks for notifications not being sent.","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"8f06305958ef940b7db0ad505c6afd11351558ea","unresolved":false,"context_lines":[{"line_number":622,"context_line":"        self._check_notification("},{"line_number":623,"context_line":"            callback_url, \u0027ThresholdCrossedNotification\u0027)"},{"line_number":624,"context_line":""},{"line_number":625,"context_line":"        # 5. PM-Threshold 5-2"},{"line_number":626,"context_line":"        sub_req \u003d paramgen.pm_threshold("},{"line_number":627,"context_line":"            pm_threshold_id_5, inst_id,"},{"line_number":628,"context_line":"            value\u003d105,"}],"source_content_type":"text/x-python","patch_set":26,"id":"8b03b018_4eb8aa2a","line":625,"in_reply_to":"99bbce40_7539d798","updated":"2023-03-10 07:29:52.000000000","message":"Done","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"45447a724915d25e12c4999542d15f6abbcda10a","unresolved":true,"context_lines":[{"line_number":633,"context_line":"        # update and terminate completion."},{"line_number":634,"context_line":"        time.sleep(5)"},{"line_number":635,"context_line":""},{"line_number":636,"context_line":"        # 6. PM-Threshold 5-3"},{"line_number":637,"context_line":"        sub_req \u003d paramgen.pm_threshold("},{"line_number":638,"context_line":"            pm_threshold_id_5, inst_id,"},{"line_number":639,"context_line":"            value\u003d80"}],"source_content_type":"text/x-python","patch_set":26,"id":"90c15e9f_3a5f27e4","line":636,"updated":"2023-03-09 02:41:09.000000000","message":"ditto","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"8f06305958ef940b7db0ad505c6afd11351558ea","unresolved":false,"context_lines":[{"line_number":633,"context_line":"        # update and terminate completion."},{"line_number":634,"context_line":"        time.sleep(5)"},{"line_number":635,"context_line":""},{"line_number":636,"context_line":"        # 6. PM-Threshold 5-3"},{"line_number":637,"context_line":"        sub_req \u003d paramgen.pm_threshold("},{"line_number":638,"context_line":"            pm_threshold_id_5, inst_id,"},{"line_number":639,"context_line":"            value\u003d80"}],"source_content_type":"text/x-python","patch_set":26,"id":"eb736470_4990bf13","line":636,"in_reply_to":"75c3f2b4_9b7840d9","updated":"2023-03-10 07:29:52.000000000","message":"Done","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"ffcbe62c7d93958ce4d3e37c19eefb313a24f4aa","unresolved":true,"context_lines":[{"line_number":633,"context_line":"        # update and terminate completion."},{"line_number":634,"context_line":"        time.sleep(5)"},{"line_number":635,"context_line":""},{"line_number":636,"context_line":"        # 6. PM-Threshold 5-3"},{"line_number":637,"context_line":"        sub_req \u003d paramgen.pm_threshold("},{"line_number":638,"context_line":"            pm_threshold_id_5, inst_id,"},{"line_number":639,"context_line":"            value\u003d80"}],"source_content_type":"text/x-python","patch_set":26,"id":"75c3f2b4_9b7840d9","line":636,"in_reply_to":"90c15e9f_3a5f27e4","updated":"2023-03-10 05:24:39.000000000","message":"I appended checks for notifications not being sent.","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"45447a724915d25e12c4999542d15f6abbcda10a","unresolved":true,"context_lines":[{"line_number":644,"context_line":"        # update and terminate completion."},{"line_number":645,"context_line":"        time.sleep(5)"},{"line_number":646,"context_line":""},{"line_number":647,"context_line":"        # 7. PM-Threshold 5-4"},{"line_number":648,"context_line":"        sub_req \u003d paramgen.pm_threshold("},{"line_number":649,"context_line":"            pm_threshold_id_5, inst_id,"},{"line_number":650,"context_line":"            value\u003d40"}],"source_content_type":"text/x-python","patch_set":26,"id":"d8775f95_6a121728","line":647,"updated":"2023-03-09 02:41:09.000000000","message":"ditto","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"8f06305958ef940b7db0ad505c6afd11351558ea","unresolved":false,"context_lines":[{"line_number":644,"context_line":"        # update and terminate completion."},{"line_number":645,"context_line":"        time.sleep(5)"},{"line_number":646,"context_line":""},{"line_number":647,"context_line":"        # 7. PM-Threshold 5-4"},{"line_number":648,"context_line":"        sub_req \u003d paramgen.pm_threshold("},{"line_number":649,"context_line":"            pm_threshold_id_5, inst_id,"},{"line_number":650,"context_line":"            value\u003d40"}],"source_content_type":"text/x-python","patch_set":26,"id":"f5e994e9_e33e873c","line":647,"in_reply_to":"a2d5c8a7_19ac74ee","updated":"2023-03-10 07:29:52.000000000","message":"Done","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"ffcbe62c7d93958ce4d3e37c19eefb313a24f4aa","unresolved":true,"context_lines":[{"line_number":644,"context_line":"        # update and terminate completion."},{"line_number":645,"context_line":"        time.sleep(5)"},{"line_number":646,"context_line":""},{"line_number":647,"context_line":"        # 7. PM-Threshold 5-4"},{"line_number":648,"context_line":"        sub_req \u003d paramgen.pm_threshold("},{"line_number":649,"context_line":"            pm_threshold_id_5, inst_id,"},{"line_number":650,"context_line":"            value\u003d40"}],"source_content_type":"text/x-python","patch_set":26,"id":"a2d5c8a7_19ac74ee","line":647,"in_reply_to":"d8775f95_6a121728","updated":"2023-03-10 05:24:39.000000000","message":"I appended checks for notifications not being sent.","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"45447a724915d25e12c4999542d15f6abbcda10a","unresolved":true,"context_lines":[{"line_number":665,"context_line":"        # wait a bit because there is a bit time lag between lcmocc DB"},{"line_number":666,"context_line":"        # update and terminate completion."},{"line_number":667,"context_line":"        time.sleep(5)"},{"line_number":668,"context_line":"        self._check_notification("},{"line_number":669,"context_line":"            callback_url, \u0027ThresholdCrossedNotification\u0027)"},{"line_number":670,"context_line":""},{"line_number":671,"context_line":"        # 9. PM-Threshold 5-6"}],"source_content_type":"text/x-python","patch_set":26,"id":"0b5001fc_51e225c5","line":668,"updated":"2023-03-09 02:41:09.000000000","message":"Is there a process to check if the \"crossingDirection\" is \"DOWN\"?","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"ffcbe62c7d93958ce4d3e37c19eefb313a24f4aa","unresolved":true,"context_lines":[{"line_number":665,"context_line":"        # wait a bit because there is a bit time lag between lcmocc DB"},{"line_number":666,"context_line":"        # update and terminate completion."},{"line_number":667,"context_line":"        time.sleep(5)"},{"line_number":668,"context_line":"        self._check_notification("},{"line_number":669,"context_line":"            callback_url, \u0027ThresholdCrossedNotification\u0027)"},{"line_number":670,"context_line":""},{"line_number":671,"context_line":"        # 9. PM-Threshold 5-6"}],"source_content_type":"text/x-python","patch_set":26,"id":"c8c426e6_2c1b2284","line":668,"in_reply_to":"0b5001fc_51e225c5","updated":"2023-03-10 05:24:39.000000000","message":"I appended assertion on  crossingDirection .","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"8f06305958ef940b7db0ad505c6afd11351558ea","unresolved":false,"context_lines":[{"line_number":665,"context_line":"        # wait a bit because there is a bit time lag between lcmocc DB"},{"line_number":666,"context_line":"        # update and terminate completion."},{"line_number":667,"context_line":"        time.sleep(5)"},{"line_number":668,"context_line":"        self._check_notification("},{"line_number":669,"context_line":"            callback_url, \u0027ThresholdCrossedNotification\u0027)"},{"line_number":670,"context_line":""},{"line_number":671,"context_line":"        # 9. PM-Threshold 5-6"}],"source_content_type":"text/x-python","patch_set":26,"id":"3e9f505a_a2e1cbaf","line":668,"in_reply_to":"c8c426e6_2c1b2284","updated":"2023-03-10 07:29:52.000000000","message":"Done","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"45447a724915d25e12c4999542d15f6abbcda10a","unresolved":true,"context_lines":[{"line_number":668,"context_line":"        self._check_notification("},{"line_number":669,"context_line":"            callback_url, \u0027ThresholdCrossedNotification\u0027)"},{"line_number":670,"context_line":""},{"line_number":671,"context_line":"        # 9. PM-Threshold 5-6"},{"line_number":672,"context_line":"        sub_req \u003d paramgen.pm_threshold("},{"line_number":673,"context_line":"            pm_threshold_id_5, inst_id,"},{"line_number":674,"context_line":"            value\u003d10"}],"source_content_type":"text/x-python","patch_set":26,"id":"192af2d7_503a6e77","line":671,"updated":"2023-03-09 02:41:09.000000000","message":"Is it unnecessary to check if notification is not notified?","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"ffcbe62c7d93958ce4d3e37c19eefb313a24f4aa","unresolved":true,"context_lines":[{"line_number":668,"context_line":"        self._check_notification("},{"line_number":669,"context_line":"            callback_url, \u0027ThresholdCrossedNotification\u0027)"},{"line_number":670,"context_line":""},{"line_number":671,"context_line":"        # 9. PM-Threshold 5-6"},{"line_number":672,"context_line":"        sub_req \u003d paramgen.pm_threshold("},{"line_number":673,"context_line":"            pm_threshold_id_5, inst_id,"},{"line_number":674,"context_line":"            value\u003d10"}],"source_content_type":"text/x-python","patch_set":26,"id":"acd322eb_8bcdde37","line":671,"in_reply_to":"192af2d7_503a6e77","updated":"2023-03-10 05:24:39.000000000","message":"I appended checks for notifications not being sent.","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"8f06305958ef940b7db0ad505c6afd11351558ea","unresolved":false,"context_lines":[{"line_number":668,"context_line":"        self._check_notification("},{"line_number":669,"context_line":"            callback_url, \u0027ThresholdCrossedNotification\u0027)"},{"line_number":670,"context_line":""},{"line_number":671,"context_line":"        # 9. PM-Threshold 5-6"},{"line_number":672,"context_line":"        sub_req \u003d paramgen.pm_threshold("},{"line_number":673,"context_line":"            pm_threshold_id_5, inst_id,"},{"line_number":674,"context_line":"            value\u003d10"}],"source_content_type":"text/x-python","patch_set":26,"id":"7b517873_2b58606a","line":671,"in_reply_to":"acd322eb_8bcdde37","updated":"2023-03-10 07:29:52.000000000","message":"Done","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"}],"tacker/tests/functional/sol_kubernetes_v2/test_vnfpm_threshold_basic.py":[{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"6595bda8fa2a5bfac0f6e5dfa2bf868e058494e7","unresolved":true,"context_lines":[{"line_number":47,"context_line":"            status_code\u003d202,"},{"line_number":48,"context_line":"            response_headers\u003d{\"Content-Type\": \"text/plain\"})"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def test_performance_management_interface_min(self):"},{"line_number":51,"context_line":"        \"\"\"Test PM Threshold operations with all attributes set"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        * About attributes:"}],"source_content_type":"text/x-python","patch_set":26,"id":"3629f6e6_0ef8a9dd","line":50,"updated":"2023-03-08 12:10:14.000000000","message":"This test name is almost the same as the existing　test_performancemanagement_interface_min() in test_vnfpm_basic.py[1].\nCould you change the test name to `test_pm_threshold_interface_min()`?\n\n[1] https://opendev.org/openstack/tacker/src/branch/master/tacker/tests/functional/sol_kubernetes_v2/test_vnfpm_basic.py#L49","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"ffcbe62c7d93958ce4d3e37c19eefb313a24f4aa","unresolved":true,"context_lines":[{"line_number":47,"context_line":"            status_code\u003d202,"},{"line_number":48,"context_line":"            response_headers\u003d{\"Content-Type\": \"text/plain\"})"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def test_performance_management_interface_min(self):"},{"line_number":51,"context_line":"        \"\"\"Test PM Threshold operations with all attributes set"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        * About attributes:"}],"source_content_type":"text/x-python","patch_set":26,"id":"4767c146_ab3bfa58","line":50,"in_reply_to":"3629f6e6_0ef8a9dd","updated":"2023-03-10 05:24:39.000000000","message":"I fixed it in patchset 27.","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"6a4ce7e18be5903b66bb84f1f21c90c9319c153a","unresolved":false,"context_lines":[{"line_number":47,"context_line":"            status_code\u003d202,"},{"line_number":48,"context_line":"            response_headers\u003d{\"Content-Type\": \"text/plain\"})"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def test_performance_management_interface_min(self):"},{"line_number":51,"context_line":"        \"\"\"Test PM Threshold operations with all attributes set"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        * About attributes:"}],"source_content_type":"text/x-python","patch_set":26,"id":"c161d210_d19af2c3","line":50,"in_reply_to":"4767c146_ab3bfa58","updated":"2023-03-10 06:20:04.000000000","message":"Done","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"c91b4e23c97bd4585fbe79ba14b509a60f79b35a","unresolved":true,"context_lines":[{"line_number":123,"context_line":"        callback_uri \u003d (\u0027http://localhost:\u0027"},{"line_number":124,"context_line":"                        f\u0027{base_v2.FAKE_SERVER_MANAGER.SERVER_PORT}\u0027"},{"line_number":125,"context_line":"                        f\u0027{callback_url}\u0027)"},{"line_number":126,"context_line":"        base_v2.FAKE_SERVER_MANAGER.set_callback("},{"line_number":127,"context_line":"            \u0027GET\u0027, callback_url, status_code\u003d204)"},{"line_number":128,"context_line":"        base_v2.FAKE_SERVER_MANAGER.set_callback("},{"line_number":129,"context_line":"            \u0027POST\u0027, callback_url, status_code\u003d204)"},{"line_number":130,"context_line":"        update_req \u003d paramgen.update_pm_threshold(callback_uri)"},{"line_number":131,"context_line":"        resp, body \u003d self.update_pm_threshold(pm_threshold_id, update_req)"},{"line_number":132,"context_line":"        self.assertEqual(200, resp.status_code)"}],"source_content_type":"text/x-python","patch_set":26,"id":"beeda0f5_f0d4a2b6","line":129,"range":{"start_line":126,"start_character":0,"end_line":129,"end_character":50},"updated":"2023-03-09 09:40:03.000000000","message":"Could you please add a comment as to why these are set?","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"8f06305958ef940b7db0ad505c6afd11351558ea","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        callback_uri \u003d (\u0027http://localhost:\u0027"},{"line_number":124,"context_line":"                        f\u0027{base_v2.FAKE_SERVER_MANAGER.SERVER_PORT}\u0027"},{"line_number":125,"context_line":"                        f\u0027{callback_url}\u0027)"},{"line_number":126,"context_line":"        base_v2.FAKE_SERVER_MANAGER.set_callback("},{"line_number":127,"context_line":"            \u0027GET\u0027, callback_url, status_code\u003d204)"},{"line_number":128,"context_line":"        base_v2.FAKE_SERVER_MANAGER.set_callback("},{"line_number":129,"context_line":"            \u0027POST\u0027, callback_url, status_code\u003d204)"},{"line_number":130,"context_line":"        update_req \u003d paramgen.update_pm_threshold(callback_uri)"},{"line_number":131,"context_line":"        resp, body \u003d self.update_pm_threshold(pm_threshold_id, update_req)"},{"line_number":132,"context_line":"        self.assertEqual(200, resp.status_code)"}],"source_content_type":"text/x-python","patch_set":26,"id":"1f3a472d_23c3ce49","line":129,"range":{"start_line":126,"start_character":0,"end_line":129,"end_character":50},"in_reply_to":"28ccb08e_932ee013","updated":"2023-03-10 07:29:52.000000000","message":"Done","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"ffcbe62c7d93958ce4d3e37c19eefb313a24f4aa","unresolved":true,"context_lines":[{"line_number":123,"context_line":"        callback_uri \u003d (\u0027http://localhost:\u0027"},{"line_number":124,"context_line":"                        f\u0027{base_v2.FAKE_SERVER_MANAGER.SERVER_PORT}\u0027"},{"line_number":125,"context_line":"                        f\u0027{callback_url}\u0027)"},{"line_number":126,"context_line":"        base_v2.FAKE_SERVER_MANAGER.set_callback("},{"line_number":127,"context_line":"            \u0027GET\u0027, callback_url, status_code\u003d204)"},{"line_number":128,"context_line":"        base_v2.FAKE_SERVER_MANAGER.set_callback("},{"line_number":129,"context_line":"            \u0027POST\u0027, callback_url, status_code\u003d204)"},{"line_number":130,"context_line":"        update_req \u003d paramgen.update_pm_threshold(callback_uri)"},{"line_number":131,"context_line":"        resp, body \u003d self.update_pm_threshold(pm_threshold_id, update_req)"},{"line_number":132,"context_line":"        self.assertEqual(200, resp.status_code)"}],"source_content_type":"text/x-python","patch_set":26,"id":"28ccb08e_932ee013","line":129,"range":{"start_line":126,"start_character":0,"end_line":129,"end_character":50},"in_reply_to":"beeda0f5_f0d4a2b6","updated":"2023-03-10 05:24:39.000000000","message":"I appended a comment.","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"c91b4e23c97bd4585fbe79ba14b509a60f79b35a","unresolved":true,"context_lines":[{"line_number":130,"context_line":"        update_req \u003d paramgen.update_pm_threshold(callback_uri)"},{"line_number":131,"context_line":"        resp, body \u003d self.update_pm_threshold(pm_threshold_id, update_req)"},{"line_number":132,"context_line":"        self.assertEqual(200, resp.status_code)"},{"line_number":133,"context_line":"        self.check_resp_headers_in_delete(resp)"},{"line_number":134,"context_line":"        # Test notification"},{"line_number":135,"context_line":"        self.assert_notification_get(callback_url)"},{"line_number":136,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"46c83c34_074ff60a","line":133,"updated":"2023-03-09 09:40:03.000000000","message":"In case of update, there is a response body.\nI think it\u0027s good to use \"check_resp_headers_in_get\" for checking.\n\nIs there no problem without checking the response body?","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"8f06305958ef940b7db0ad505c6afd11351558ea","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        update_req \u003d paramgen.update_pm_threshold(callback_uri)"},{"line_number":131,"context_line":"        resp, body \u003d self.update_pm_threshold(pm_threshold_id, update_req)"},{"line_number":132,"context_line":"        self.assertEqual(200, resp.status_code)"},{"line_number":133,"context_line":"        self.check_resp_headers_in_delete(resp)"},{"line_number":134,"context_line":"        # Test notification"},{"line_number":135,"context_line":"        self.assert_notification_get(callback_url)"},{"line_number":136,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"b076995a_8f264f63","line":133,"in_reply_to":"102ce336_7ecd8963","updated":"2023-03-10 07:29:52.000000000","message":"Done","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"ffcbe62c7d93958ce4d3e37c19eefb313a24f4aa","unresolved":true,"context_lines":[{"line_number":130,"context_line":"        update_req \u003d paramgen.update_pm_threshold(callback_uri)"},{"line_number":131,"context_line":"        resp, body \u003d self.update_pm_threshold(pm_threshold_id, update_req)"},{"line_number":132,"context_line":"        self.assertEqual(200, resp.status_code)"},{"line_number":133,"context_line":"        self.check_resp_headers_in_delete(resp)"},{"line_number":134,"context_line":"        # Test notification"},{"line_number":135,"context_line":"        self.assert_notification_get(callback_url)"},{"line_number":136,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"102ce336_7ecd8963","line":133,"in_reply_to":"46c83c34_074ff60a","updated":"2023-03-10 05:24:39.000000000","message":"I fixed it in patchset 27.","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"6595bda8fa2a5bfac0f6e5dfa2bf868e058494e7","unresolved":true,"context_lines":[{"line_number":189,"context_line":"        resp, body \u003d self.show_vnf_instance(inst_id)"},{"line_number":190,"context_line":"        self.assertEqual(404, resp.status_code)"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"    def test_performance_management_interface_max(self):"},{"line_number":193,"context_line":"        \"\"\"Test PM Threshold operations with all attributes set"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        * About attributes:"}],"source_content_type":"text/x-python","patch_set":26,"id":"c5a5af22_f48fbada","line":192,"updated":"2023-03-08 12:10:14.000000000","message":"ditto. \nCould you change the test name to `test_pm_threshold_interface_max()`?","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"6a4ce7e18be5903b66bb84f1f21c90c9319c153a","unresolved":false,"context_lines":[{"line_number":189,"context_line":"        resp, body \u003d self.show_vnf_instance(inst_id)"},{"line_number":190,"context_line":"        self.assertEqual(404, resp.status_code)"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"    def test_performance_management_interface_max(self):"},{"line_number":193,"context_line":"        \"\"\"Test PM Threshold operations with all attributes set"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        * About attributes:"}],"source_content_type":"text/x-python","patch_set":26,"id":"b937e667_77b6ecd6","line":192,"in_reply_to":"9f3d06bc_10759ae3","updated":"2023-03-10 06:20:04.000000000","message":"Done","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"ffcbe62c7d93958ce4d3e37c19eefb313a24f4aa","unresolved":true,"context_lines":[{"line_number":189,"context_line":"        resp, body \u003d self.show_vnf_instance(inst_id)"},{"line_number":190,"context_line":"        self.assertEqual(404, resp.status_code)"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"    def test_performance_management_interface_max(self):"},{"line_number":193,"context_line":"        \"\"\"Test PM Threshold operations with all attributes set"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        * About attributes:"}],"source_content_type":"text/x-python","patch_set":26,"id":"9f3d06bc_10759ae3","line":192,"in_reply_to":"c5a5af22_f48fbada","updated":"2023-03-10 05:24:39.000000000","message":"I fixed it in patchset 27.","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"c91b4e23c97bd4585fbe79ba14b509a60f79b35a","unresolved":true,"context_lines":[{"line_number":263,"context_line":"        callback_uri \u003d (\u0027http://localhost:\u0027"},{"line_number":264,"context_line":"                        f\u0027{base_v2.FAKE_SERVER_MANAGER.SERVER_PORT}\u0027"},{"line_number":265,"context_line":"                        f\u0027{callback_url}\u0027)"},{"line_number":266,"context_line":"        base_v2.FAKE_SERVER_MANAGER.set_callback("},{"line_number":267,"context_line":"            \u0027GET\u0027, callback_url, status_code\u003d204)"},{"line_number":268,"context_line":"        base_v2.FAKE_SERVER_MANAGER.set_callback("},{"line_number":269,"context_line":"            \u0027POST\u0027, callback_url, status_code\u003d204)"},{"line_number":270,"context_line":"        update_req \u003d paramgen.update_pm_threshold(callback_uri)"},{"line_number":271,"context_line":"        resp, body \u003d self.update_pm_threshold(pm_threshold_id, update_req)"},{"line_number":272,"context_line":"        self.assertEqual(200, resp.status_code)"}],"source_content_type":"text/x-python","patch_set":26,"id":"dccf5699_1eb30fe4","line":269,"range":{"start_line":266,"start_character":0,"end_line":269,"end_character":50},"updated":"2023-03-09 09:40:03.000000000","message":"Could you please add a comment as to why these are set?","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"8f06305958ef940b7db0ad505c6afd11351558ea","unresolved":false,"context_lines":[{"line_number":263,"context_line":"        callback_uri \u003d (\u0027http://localhost:\u0027"},{"line_number":264,"context_line":"                        f\u0027{base_v2.FAKE_SERVER_MANAGER.SERVER_PORT}\u0027"},{"line_number":265,"context_line":"                        f\u0027{callback_url}\u0027)"},{"line_number":266,"context_line":"        base_v2.FAKE_SERVER_MANAGER.set_callback("},{"line_number":267,"context_line":"            \u0027GET\u0027, callback_url, status_code\u003d204)"},{"line_number":268,"context_line":"        base_v2.FAKE_SERVER_MANAGER.set_callback("},{"line_number":269,"context_line":"            \u0027POST\u0027, callback_url, status_code\u003d204)"},{"line_number":270,"context_line":"        update_req \u003d paramgen.update_pm_threshold(callback_uri)"},{"line_number":271,"context_line":"        resp, body \u003d self.update_pm_threshold(pm_threshold_id, update_req)"},{"line_number":272,"context_line":"        self.assertEqual(200, resp.status_code)"}],"source_content_type":"text/x-python","patch_set":26,"id":"5595e8af_06090d91","line":269,"range":{"start_line":266,"start_character":0,"end_line":269,"end_character":50},"in_reply_to":"0d6a886c_dd4d85ba","updated":"2023-03-10 07:29:52.000000000","message":"Done","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"ffcbe62c7d93958ce4d3e37c19eefb313a24f4aa","unresolved":true,"context_lines":[{"line_number":263,"context_line":"        callback_uri \u003d (\u0027http://localhost:\u0027"},{"line_number":264,"context_line":"                        f\u0027{base_v2.FAKE_SERVER_MANAGER.SERVER_PORT}\u0027"},{"line_number":265,"context_line":"                        f\u0027{callback_url}\u0027)"},{"line_number":266,"context_line":"        base_v2.FAKE_SERVER_MANAGER.set_callback("},{"line_number":267,"context_line":"            \u0027GET\u0027, callback_url, status_code\u003d204)"},{"line_number":268,"context_line":"        base_v2.FAKE_SERVER_MANAGER.set_callback("},{"line_number":269,"context_line":"            \u0027POST\u0027, callback_url, status_code\u003d204)"},{"line_number":270,"context_line":"        update_req \u003d paramgen.update_pm_threshold(callback_uri)"},{"line_number":271,"context_line":"        resp, body \u003d self.update_pm_threshold(pm_threshold_id, update_req)"},{"line_number":272,"context_line":"        self.assertEqual(200, resp.status_code)"}],"source_content_type":"text/x-python","patch_set":26,"id":"0d6a886c_dd4d85ba","line":269,"range":{"start_line":266,"start_character":0,"end_line":269,"end_character":50},"in_reply_to":"dccf5699_1eb30fe4","updated":"2023-03-10 05:24:39.000000000","message":"I appended a comment.","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"c91b4e23c97bd4585fbe79ba14b509a60f79b35a","unresolved":true,"context_lines":[{"line_number":270,"context_line":"        update_req \u003d paramgen.update_pm_threshold(callback_uri)"},{"line_number":271,"context_line":"        resp, body \u003d self.update_pm_threshold(pm_threshold_id, update_req)"},{"line_number":272,"context_line":"        self.assertEqual(200, resp.status_code)"},{"line_number":273,"context_line":"        self.check_resp_headers_in_delete(resp)"},{"line_number":274,"context_line":"        # Test notification"},{"line_number":275,"context_line":"        self.assert_notification_get(callback_url)"},{"line_number":276,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"79563c43_2da4c926","line":273,"updated":"2023-03-09 09:40:03.000000000","message":"In case of update, there is a response body.\nI think it\u0027s good to use \"check_resp_headers_in_get\" for checking.\n\nIs there no problem without checking the response body?","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"8f06305958ef940b7db0ad505c6afd11351558ea","unresolved":false,"context_lines":[{"line_number":270,"context_line":"        update_req \u003d paramgen.update_pm_threshold(callback_uri)"},{"line_number":271,"context_line":"        resp, body \u003d self.update_pm_threshold(pm_threshold_id, update_req)"},{"line_number":272,"context_line":"        self.assertEqual(200, resp.status_code)"},{"line_number":273,"context_line":"        self.check_resp_headers_in_delete(resp)"},{"line_number":274,"context_line":"        # Test notification"},{"line_number":275,"context_line":"        self.assert_notification_get(callback_url)"},{"line_number":276,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"811288eb_ae7c5fdf","line":273,"in_reply_to":"499e004f_233b64c4","updated":"2023-03-10 07:29:52.000000000","message":"Done","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"ffcbe62c7d93958ce4d3e37c19eefb313a24f4aa","unresolved":true,"context_lines":[{"line_number":270,"context_line":"        update_req \u003d paramgen.update_pm_threshold(callback_uri)"},{"line_number":271,"context_line":"        resp, body \u003d self.update_pm_threshold(pm_threshold_id, update_req)"},{"line_number":272,"context_line":"        self.assertEqual(200, resp.status_code)"},{"line_number":273,"context_line":"        self.check_resp_headers_in_delete(resp)"},{"line_number":274,"context_line":"        # Test notification"},{"line_number":275,"context_line":"        self.assert_notification_get(callback_url)"},{"line_number":276,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"499e004f_233b64c4","line":273,"in_reply_to":"79563c43_2da4c926","updated":"2023-03-10 05:24:39.000000000","message":"I fixed it in patchset 27.","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"}],"tacker/tests/unit/sol_refactored/common/test_pm_threshold_utils.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"44b7f8fc31425dc896c881675d8f0f65a1da16e2","unresolved":true,"context_lines":[{"line_number":63,"context_line":"            pm_threshold, \u0027subObjectInstanceId\u0027)"},{"line_number":64,"context_line":"        self.assertIsNone(result)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def test_get_pm_threshold_state_1(self):"},{"line_number":67,"context_line":"        pm_threshold \u003d objects.ThresholdV2("},{"line_number":68,"context_line":"            id\u003d\u0027pm_threshold_1\u0027,"},{"line_number":69,"context_line":"            metadata\u003d{})"}],"source_content_type":"text/x-python","patch_set":22,"id":"a563ad3d_ae125820","line":66,"range":{"start_line":66,"start_character":36,"end_line":66,"end_character":37},"updated":"2023-03-07 01:02:26.000000000","message":"Could you change the method name to clarify the purpose of this test?\nFor this test method, like `test_get_pm_threshold_state_with_empty_metadata`?","commit_id":"ba8f07016cc719c62a264a14b914afd9b0d7d85d"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"70b1a74aed0ab5e41e1dbac45a788b76f262f97f","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            pm_threshold, \u0027subObjectInstanceId\u0027)"},{"line_number":64,"context_line":"        self.assertIsNone(result)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def test_get_pm_threshold_state_1(self):"},{"line_number":67,"context_line":"        pm_threshold \u003d objects.ThresholdV2("},{"line_number":68,"context_line":"            id\u003d\u0027pm_threshold_1\u0027,"},{"line_number":69,"context_line":"            metadata\u003d{})"}],"source_content_type":"text/x-python","patch_set":22,"id":"794ca70b_cc90cc83","line":66,"range":{"start_line":66,"start_character":36,"end_line":66,"end_character":37},"in_reply_to":"988e141c_abf64b3d","updated":"2023-03-07 12:20:57.000000000","message":"Ack","commit_id":"ba8f07016cc719c62a264a14b914afd9b0d7d85d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"2f6ad2697def74db2ec26090a90112d34865447d","unresolved":true,"context_lines":[{"line_number":63,"context_line":"            pm_threshold, \u0027subObjectInstanceId\u0027)"},{"line_number":64,"context_line":"        self.assertIsNone(result)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def test_get_pm_threshold_state_1(self):"},{"line_number":67,"context_line":"        pm_threshold \u003d objects.ThresholdV2("},{"line_number":68,"context_line":"            id\u003d\u0027pm_threshold_1\u0027,"},{"line_number":69,"context_line":"            metadata\u003d{})"}],"source_content_type":"text/x-python","patch_set":22,"id":"988e141c_abf64b3d","line":66,"range":{"start_line":66,"start_character":36,"end_line":66,"end_character":37},"in_reply_to":"a563ad3d_ae125820","updated":"2023-03-07 06:11:12.000000000","message":"I fixed it in patchset 23.","commit_id":"ba8f07016cc719c62a264a14b914afd9b0d7d85d"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"44b7f8fc31425dc896c881675d8f0f65a1da16e2","unresolved":true,"context_lines":[{"line_number":72,"context_line":"            pm_threshold, \u0027subObjectInstanceId\u0027)"},{"line_number":73,"context_line":"        self.assertIsNone(result)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def test_get_pm_threshold_state_2(self):"},{"line_number":76,"context_line":"        pm_threshold \u003d objects.ThresholdV2("},{"line_number":77,"context_line":"            id\u003d\u0027pm_threshold_1\u0027,"},{"line_number":78,"context_line":"            metadata\u003d{"}],"source_content_type":"text/x-python","patch_set":22,"id":"a371c860_1d20cb18","line":75,"range":{"start_line":75,"start_character":36,"end_line":75,"end_character":37},"updated":"2023-03-07 01:02:26.000000000","message":"ditto.","commit_id":"ba8f07016cc719c62a264a14b914afd9b0d7d85d"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"70b1a74aed0ab5e41e1dbac45a788b76f262f97f","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            pm_threshold, \u0027subObjectInstanceId\u0027)"},{"line_number":73,"context_line":"        self.assertIsNone(result)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def test_get_pm_threshold_state_2(self):"},{"line_number":76,"context_line":"        pm_threshold \u003d objects.ThresholdV2("},{"line_number":77,"context_line":"            id\u003d\u0027pm_threshold_1\u0027,"},{"line_number":78,"context_line":"            metadata\u003d{"}],"source_content_type":"text/x-python","patch_set":22,"id":"186af54a_6cb141cc","line":75,"range":{"start_line":75,"start_character":36,"end_line":75,"end_character":37},"in_reply_to":"254ad3d5_1d6529cd","updated":"2023-03-07 12:20:57.000000000","message":"Ack","commit_id":"ba8f07016cc719c62a264a14b914afd9b0d7d85d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"2f6ad2697def74db2ec26090a90112d34865447d","unresolved":true,"context_lines":[{"line_number":72,"context_line":"            pm_threshold, \u0027subObjectInstanceId\u0027)"},{"line_number":73,"context_line":"        self.assertIsNone(result)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def test_get_pm_threshold_state_2(self):"},{"line_number":76,"context_line":"        pm_threshold \u003d objects.ThresholdV2("},{"line_number":77,"context_line":"            id\u003d\u0027pm_threshold_1\u0027,"},{"line_number":78,"context_line":"            metadata\u003d{"}],"source_content_type":"text/x-python","patch_set":22,"id":"254ad3d5_1d6529cd","line":75,"range":{"start_line":75,"start_character":36,"end_line":75,"end_character":37},"in_reply_to":"a371c860_1d20cb18","updated":"2023-03-07 06:11:12.000000000","message":"I fixed it in patchset 23.","commit_id":"ba8f07016cc719c62a264a14b914afd9b0d7d85d"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"56dfe3903b9a0b66735f2b886f38eed520edb23a","unresolved":true,"context_lines":[{"line_number":113,"context_line":"            id\u003d\u0027pm_threshold_1\u0027)"},{"line_number":114,"context_line":"        mock_create.return_value \u003d None"},{"line_number":115,"context_line":"        mock_update.return_value \u003d None"},{"line_number":116,"context_line":"        threshold_state \u003d {"},{"line_number":117,"context_line":"            \u0027thresholdId\u0027: \u0027pm_threshold_1\u0027,"},{"line_number":118,"context_line":"            \u0027subObjectInstanceId\u0027: \u0027sub_id_1\u0027,"},{"line_number":119,"context_line":"            \u0027performanceValue\u0027: \u0027200.5\u0027,"}],"source_content_type":"text/x-python","patch_set":22,"id":"57f24a81_87dee672","line":116,"range":{"start_line":116,"start_character":8,"end_line":116,"end_character":23},"updated":"2023-03-07 03:03:47.000000000","message":"The following variable names should be given the same naming convention.\n- threshold_state  (L.116)\n- pm_threshold_state_1  (L.128)\n\nRefer to thresholdId, how about changing it this way?\n- threshold_state -\u003e pm_threshold_state_1  (L.116)\n- pm_threshold_state_1 - \u003e pm_threshold_state_2.  (L.128)","commit_id":"ba8f07016cc719c62a264a14b914afd9b0d7d85d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"2f6ad2697def74db2ec26090a90112d34865447d","unresolved":true,"context_lines":[{"line_number":113,"context_line":"            id\u003d\u0027pm_threshold_1\u0027)"},{"line_number":114,"context_line":"        mock_create.return_value \u003d None"},{"line_number":115,"context_line":"        mock_update.return_value \u003d None"},{"line_number":116,"context_line":"        threshold_state \u003d {"},{"line_number":117,"context_line":"            \u0027thresholdId\u0027: \u0027pm_threshold_1\u0027,"},{"line_number":118,"context_line":"            \u0027subObjectInstanceId\u0027: \u0027sub_id_1\u0027,"},{"line_number":119,"context_line":"            \u0027performanceValue\u0027: \u0027200.5\u0027,"}],"source_content_type":"text/x-python","patch_set":22,"id":"b11751d5_3cebdf9e","line":116,"range":{"start_line":116,"start_character":8,"end_line":116,"end_character":23},"in_reply_to":"57f24a81_87dee672","updated":"2023-03-07 06:11:12.000000000","message":"\u003e - threshold_state -\u003e pm_threshold_state_1  (L.116)\nI fixed it in patchset 23.\n\u003e - pm_threshold_state_1 - \u003e pm_threshold_state_2.  (L.128)\nI removed it in patchset 23.","commit_id":"ba8f07016cc719c62a264a14b914afd9b0d7d85d"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"4452ce72041c8be511f16c4e9b26c700e7a63030","unresolved":false,"context_lines":[{"line_number":113,"context_line":"            id\u003d\u0027pm_threshold_1\u0027)"},{"line_number":114,"context_line":"        mock_create.return_value \u003d None"},{"line_number":115,"context_line":"        mock_update.return_value \u003d None"},{"line_number":116,"context_line":"        threshold_state \u003d {"},{"line_number":117,"context_line":"            \u0027thresholdId\u0027: \u0027pm_threshold_1\u0027,"},{"line_number":118,"context_line":"            \u0027subObjectInstanceId\u0027: \u0027sub_id_1\u0027,"},{"line_number":119,"context_line":"            \u0027performanceValue\u0027: \u0027200.5\u0027,"}],"source_content_type":"text/x-python","patch_set":22,"id":"7b253f86_29c7d8b7","line":116,"range":{"start_line":116,"start_character":8,"end_line":116,"end_character":23},"in_reply_to":"b11751d5_3cebdf9e","updated":"2023-03-07 06:48:02.000000000","message":"Done","commit_id":"ba8f07016cc719c62a264a14b914afd9b0d7d85d"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"56dfe3903b9a0b66735f2b886f38eed520edb23a","unresolved":true,"context_lines":[{"line_number":132,"context_line":"            \u0027metrics\u0027: \u0027VCpuUsageMeanVnf.VNF\u0027,"},{"line_number":133,"context_line":"            \u0027crossingDirection\u0027: \u0027DOWN\u0027"},{"line_number":134,"context_line":"        }"},{"line_number":135,"context_line":"        res \u003d pm_threshold_utils.update_threshold_state_data("},{"line_number":136,"context_line":"            self.context, pm_threshold_state_1,"},{"line_number":137,"context_line":"            pm_threshold_state_1[\u0027thresholdId\u0027])"},{"line_number":138,"context_line":"        threshold_id \u003d res[\u0027thresholdId\u0027]"}],"source_content_type":"text/x-python","patch_set":22,"id":"ff468e6a_0fd16934","line":135,"range":{"start_line":135,"start_character":8,"end_line":135,"end_character":11},"updated":"2023-03-07 03:03:47.000000000","message":"What is the deferences between L123-L126 and L135-139?\nIt seems that the deferences of threshold_state are `subObjectInstanceId` and \u0027performanceValue\u0027, but it seems that almost same UTs are being implemented.\nIt should be unified or omitted.","commit_id":"ba8f07016cc719c62a264a14b914afd9b0d7d85d"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"4452ce72041c8be511f16c4e9b26c700e7a63030","unresolved":false,"context_lines":[{"line_number":132,"context_line":"            \u0027metrics\u0027: \u0027VCpuUsageMeanVnf.VNF\u0027,"},{"line_number":133,"context_line":"            \u0027crossingDirection\u0027: \u0027DOWN\u0027"},{"line_number":134,"context_line":"        }"},{"line_number":135,"context_line":"        res \u003d pm_threshold_utils.update_threshold_state_data("},{"line_number":136,"context_line":"            self.context, pm_threshold_state_1,"},{"line_number":137,"context_line":"            pm_threshold_state_1[\u0027thresholdId\u0027])"},{"line_number":138,"context_line":"        threshold_id \u003d res[\u0027thresholdId\u0027]"}],"source_content_type":"text/x-python","patch_set":22,"id":"a462155b_4e0bf5b9","line":135,"range":{"start_line":135,"start_character":8,"end_line":135,"end_character":11},"in_reply_to":"27794330_e1437480","updated":"2023-03-07 06:48:02.000000000","message":"Done","commit_id":"ba8f07016cc719c62a264a14b914afd9b0d7d85d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"2f6ad2697def74db2ec26090a90112d34865447d","unresolved":true,"context_lines":[{"line_number":132,"context_line":"            \u0027metrics\u0027: \u0027VCpuUsageMeanVnf.VNF\u0027,"},{"line_number":133,"context_line":"            \u0027crossingDirection\u0027: \u0027DOWN\u0027"},{"line_number":134,"context_line":"        }"},{"line_number":135,"context_line":"        res \u003d pm_threshold_utils.update_threshold_state_data("},{"line_number":136,"context_line":"            self.context, pm_threshold_state_1,"},{"line_number":137,"context_line":"            pm_threshold_state_1[\u0027thresholdId\u0027])"},{"line_number":138,"context_line":"        threshold_id \u003d res[\u0027thresholdId\u0027]"}],"source_content_type":"text/x-python","patch_set":22,"id":"27794330_e1437480","line":135,"range":{"start_line":135,"start_character":8,"end_line":135,"end_character":11},"in_reply_to":"ff468e6a_0fd16934","updated":"2023-03-07 06:11:12.000000000","message":"I removed it in patchset 23.","commit_id":"ba8f07016cc719c62a264a14b914afd9b0d7d85d"}],"tacker/tests/unit/sol_refactored/common/test_prometheus_plugin.py":[{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"56dfe3903b9a0b66735f2b886f38eed520edb23a","unresolved":true,"context_lines":[{"line_number":973,"context_line":"        with freezegun.freeze_time(datetime_test):"},{"line_number":974,"context_line":"            result \u003d pp._alert(self.request, body\u003d_body_pm_threshold1)"},{"line_number":975,"context_line":"            self.assertTrue(len(result) \u003e 0)"},{"line_number":976,"context_line":"            self.assertEqual(result[0][\u0027performanceValue\u0027], 510)"},{"line_number":977,"context_line":""},{"line_number":978,"context_line":"    @mock.patch.object(pm_threshold_utils, \u0027get_pm_threshold_state\u0027)"},{"line_number":979,"context_line":"    @mock.patch.object(pm_threshold_utils, \u0027get_pm_threshold\u0027)"}],"source_content_type":"text/x-python","patch_set":22,"id":"fae5bf46_1d149c1c","line":976,"range":{"start_line":976,"start_character":60,"end_line":976,"end_character":63},"updated":"2023-03-07 03:03:47.000000000","message":"Why is the value of `performanceValue` checked by \"510\"?\nI don\u0027t understood why you use this value for the assert.\nThe value of `performanceValue` shows \"200.5\" in _pm_threshold_state.","commit_id":"ba8f07016cc719c62a264a14b914afd9b0d7d85d"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"4452ce72041c8be511f16c4e9b26c700e7a63030","unresolved":false,"context_lines":[{"line_number":973,"context_line":"        with freezegun.freeze_time(datetime_test):"},{"line_number":974,"context_line":"            result \u003d pp._alert(self.request, body\u003d_body_pm_threshold1)"},{"line_number":975,"context_line":"            self.assertTrue(len(result) \u003e 0)"},{"line_number":976,"context_line":"            self.assertEqual(result[0][\u0027performanceValue\u0027], 510)"},{"line_number":977,"context_line":""},{"line_number":978,"context_line":"    @mock.patch.object(pm_threshold_utils, \u0027get_pm_threshold_state\u0027)"},{"line_number":979,"context_line":"    @mock.patch.object(pm_threshold_utils, \u0027get_pm_threshold\u0027)"}],"source_content_type":"text/x-python","patch_set":22,"id":"1e08ef36_af9afbcb","line":976,"range":{"start_line":976,"start_character":60,"end_line":976,"end_character":63},"in_reply_to":"4ffc6942_6f4bc0b9","updated":"2023-03-07 06:48:02.000000000","message":"Thank you for reply and sorry for my misunderstanding..\nI confirmed that the value of `_body_pm_threshold_alert1` is \"510\".\nDone","commit_id":"ba8f07016cc719c62a264a14b914afd9b0d7d85d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"2f6ad2697def74db2ec26090a90112d34865447d","unresolved":true,"context_lines":[{"line_number":973,"context_line":"        with freezegun.freeze_time(datetime_test):"},{"line_number":974,"context_line":"            result \u003d pp._alert(self.request, body\u003d_body_pm_threshold1)"},{"line_number":975,"context_line":"            self.assertTrue(len(result) \u003e 0)"},{"line_number":976,"context_line":"            self.assertEqual(result[0][\u0027performanceValue\u0027], 510)"},{"line_number":977,"context_line":""},{"line_number":978,"context_line":"    @mock.patch.object(pm_threshold_utils, \u0027get_pm_threshold_state\u0027)"},{"line_number":979,"context_line":"    @mock.patch.object(pm_threshold_utils, \u0027get_pm_threshold\u0027)"}],"source_content_type":"text/x-python","patch_set":22,"id":"4ffc6942_6f4bc0b9","line":976,"range":{"start_line":976,"start_character":60,"end_line":976,"end_character":63},"in_reply_to":"fae5bf46_1d149c1c","updated":"2023-03-07 06:11:12.000000000","message":"The `performanceValue` in `_pm_threshold_state` is the value in the last alert.\nWhat is asserted here is `performanceValue` in this alert, so it is the value in `_body_pm_threshold1`, which is 510.","commit_id":"ba8f07016cc719c62a264a14b914afd9b0d7d85d"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"56dfe3903b9a0b66735f2b886f38eed520edb23a","unresolved":true,"context_lines":[{"line_number":1010,"context_line":"        with freezegun.freeze_time(datetime_test):"},{"line_number":1011,"context_line":"            result \u003d pp._alert(self.request, body\u003d_body_pm_threshold1)"},{"line_number":1012,"context_line":"            self.assertTrue(len(result) \u003e 0)"},{"line_number":1013,"context_line":"            self.assertEqual(result[0][\u0027performanceValue\u0027], 510)"},{"line_number":1014,"context_line":""},{"line_number":1015,"context_line":"    @mock.patch.object(pm_threshold_utils, \u0027get_pm_threshold_state\u0027)"},{"line_number":1016,"context_line":"    @mock.patch.object(pm_threshold_utils, \u0027get_pm_threshold\u0027)"}],"source_content_type":"text/x-python","patch_set":22,"id":"1f949226_e96c822e","line":1013,"range":{"start_line":1013,"start_character":60,"end_line":1013,"end_character":63},"updated":"2023-03-07 03:03:47.000000000","message":"ditto.","commit_id":"ba8f07016cc719c62a264a14b914afd9b0d7d85d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"2f6ad2697def74db2ec26090a90112d34865447d","unresolved":true,"context_lines":[{"line_number":1010,"context_line":"        with freezegun.freeze_time(datetime_test):"},{"line_number":1011,"context_line":"            result \u003d pp._alert(self.request, body\u003d_body_pm_threshold1)"},{"line_number":1012,"context_line":"            self.assertTrue(len(result) \u003e 0)"},{"line_number":1013,"context_line":"            self.assertEqual(result[0][\u0027performanceValue\u0027], 510)"},{"line_number":1014,"context_line":""},{"line_number":1015,"context_line":"    @mock.patch.object(pm_threshold_utils, \u0027get_pm_threshold_state\u0027)"},{"line_number":1016,"context_line":"    @mock.patch.object(pm_threshold_utils, \u0027get_pm_threshold\u0027)"}],"source_content_type":"text/x-python","patch_set":22,"id":"c6e61c04_1c56eefb","line":1013,"range":{"start_line":1013,"start_character":60,"end_line":1013,"end_character":63},"in_reply_to":"1f949226_e96c822e","updated":"2023-03-07 06:11:12.000000000","message":"The `performanceValue` in `_pm_threshold_state` is the value in the last alert.\nWhat is asserted here is `performanceValue` in this alert, so it is the value in `_body_pm_threshold1`, which is 510.","commit_id":"ba8f07016cc719c62a264a14b914afd9b0d7d85d"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"4452ce72041c8be511f16c4e9b26c700e7a63030","unresolved":false,"context_lines":[{"line_number":1010,"context_line":"        with freezegun.freeze_time(datetime_test):"},{"line_number":1011,"context_line":"            result \u003d pp._alert(self.request, body\u003d_body_pm_threshold1)"},{"line_number":1012,"context_line":"            self.assertTrue(len(result) \u003e 0)"},{"line_number":1013,"context_line":"            self.assertEqual(result[0][\u0027performanceValue\u0027], 510)"},{"line_number":1014,"context_line":""},{"line_number":1015,"context_line":"    @mock.patch.object(pm_threshold_utils, \u0027get_pm_threshold_state\u0027)"},{"line_number":1016,"context_line":"    @mock.patch.object(pm_threshold_utils, \u0027get_pm_threshold\u0027)"}],"source_content_type":"text/x-python","patch_set":22,"id":"f3065b03_4e937271","line":1013,"range":{"start_line":1013,"start_character":60,"end_line":1013,"end_character":63},"in_reply_to":"c6e61c04_1c56eefb","updated":"2023-03-07 06:48:02.000000000","message":"Done","commit_id":"ba8f07016cc719c62a264a14b914afd9b0d7d85d"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"56dfe3903b9a0b66735f2b886f38eed520edb23a","unresolved":true,"context_lines":[{"line_number":1030,"context_line":"        with freezegun.freeze_time(datetime_test):"},{"line_number":1031,"context_line":"            result \u003d pp._alert(self.request, body\u003d_body_pm_threshold1)"},{"line_number":1032,"context_line":"            self.assertTrue(len(result) \u003e 0)"},{"line_number":1033,"context_line":"            self.assertEqual(result[0][\u0027performanceValue\u0027], 510)"},{"line_number":1034,"context_line":""},{"line_number":1035,"context_line":"    def test_pm_threshold_error_access_info(self):"},{"line_number":1036,"context_line":"        self.config_fixture.config("}],"source_content_type":"text/x-python","patch_set":22,"id":"caa6b6ad_c43021db","line":1033,"range":{"start_line":1033,"start_character":0,"end_line":1033,"end_character":63},"updated":"2023-03-07 03:03:47.000000000","message":"ditto.","commit_id":"ba8f07016cc719c62a264a14b914afd9b0d7d85d"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"4452ce72041c8be511f16c4e9b26c700e7a63030","unresolved":false,"context_lines":[{"line_number":1030,"context_line":"        with freezegun.freeze_time(datetime_test):"},{"line_number":1031,"context_line":"            result \u003d pp._alert(self.request, body\u003d_body_pm_threshold1)"},{"line_number":1032,"context_line":"            self.assertTrue(len(result) \u003e 0)"},{"line_number":1033,"context_line":"            self.assertEqual(result[0][\u0027performanceValue\u0027], 510)"},{"line_number":1034,"context_line":""},{"line_number":1035,"context_line":"    def test_pm_threshold_error_access_info(self):"},{"line_number":1036,"context_line":"        self.config_fixture.config("}],"source_content_type":"text/x-python","patch_set":22,"id":"eee5bf04_558c42f5","line":1033,"range":{"start_line":1033,"start_character":0,"end_line":1033,"end_character":63},"in_reply_to":"70acac03_ebf80f6e","updated":"2023-03-07 06:48:02.000000000","message":"Done","commit_id":"ba8f07016cc719c62a264a14b914afd9b0d7d85d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"2f6ad2697def74db2ec26090a90112d34865447d","unresolved":true,"context_lines":[{"line_number":1030,"context_line":"        with freezegun.freeze_time(datetime_test):"},{"line_number":1031,"context_line":"            result \u003d pp._alert(self.request, body\u003d_body_pm_threshold1)"},{"line_number":1032,"context_line":"            self.assertTrue(len(result) \u003e 0)"},{"line_number":1033,"context_line":"            self.assertEqual(result[0][\u0027performanceValue\u0027], 510)"},{"line_number":1034,"context_line":""},{"line_number":1035,"context_line":"    def test_pm_threshold_error_access_info(self):"},{"line_number":1036,"context_line":"        self.config_fixture.config("}],"source_content_type":"text/x-python","patch_set":22,"id":"70acac03_ebf80f6e","line":1033,"range":{"start_line":1033,"start_character":0,"end_line":1033,"end_character":63},"in_reply_to":"caa6b6ad_c43021db","updated":"2023-03-07 06:11:12.000000000","message":"The `performanceValue` in `_pm_threshold_state` is the value in the last alert.\nWhat is asserted here is `performanceValue` in this alert, so it is the value in `_body_pm_threshold1`, which is 510.","commit_id":"ba8f07016cc719c62a264a14b914afd9b0d7d85d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"c91b4e23c97bd4585fbe79ba14b509a60f79b35a","unresolved":true,"context_lines":[{"line_number":106,"context_line":"    },"},{"line_number":107,"context_line":"    \u0027startsAt\u0027: \u00272022-06-21T23:47:36.453Z\u0027,"},{"line_number":108,"context_line":"    \u0027endsAt\u0027: \u00270001-01-01T00:00:00Z\u0027,"},{"line_number":109,"context_line":"    \u0027generatorURL\u0027: \u0027http://controller147:9090/graph?g0.expr\u003d\u0027"},{"line_number":110,"context_line":"                    \u0027up%7Bjob%3D%22node%22%7D+%3D%3D+0\u0026g0.tab\u003d1\u0027,"},{"line_number":111,"context_line":"    \u0027fingerprint\u0027: \u00275ef77f1f8a3ecb8d\u0027"},{"line_number":112,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":26,"id":"97cd2b1e_dc3aff89","line":109,"updated":"2023-03-09 09:40:03.000000000","message":"It seems that \"generatorURL\" is not described in Spec.\nIs it required as test data?\nPlease add a comment as to why if necessary.","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"8f06305958ef940b7db0ad505c6afd11351558ea","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    },"},{"line_number":107,"context_line":"    \u0027startsAt\u0027: \u00272022-06-21T23:47:36.453Z\u0027,"},{"line_number":108,"context_line":"    \u0027endsAt\u0027: \u00270001-01-01T00:00:00Z\u0027,"},{"line_number":109,"context_line":"    \u0027generatorURL\u0027: \u0027http://controller147:9090/graph?g0.expr\u003d\u0027"},{"line_number":110,"context_line":"                    \u0027up%7Bjob%3D%22node%22%7D+%3D%3D+0\u0026g0.tab\u003d1\u0027,"},{"line_number":111,"context_line":"    \u0027fingerprint\u0027: \u00275ef77f1f8a3ecb8d\u0027"},{"line_number":112,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":26,"id":"a2dc3fd2_8bb8be11","line":109,"in_reply_to":"0898268c_83cfff60","updated":"2023-03-10 07:29:52.000000000","message":"Done","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"ffcbe62c7d93958ce4d3e37c19eefb313a24f4aa","unresolved":true,"context_lines":[{"line_number":106,"context_line":"    },"},{"line_number":107,"context_line":"    \u0027startsAt\u0027: \u00272022-06-21T23:47:36.453Z\u0027,"},{"line_number":108,"context_line":"    \u0027endsAt\u0027: \u00270001-01-01T00:00:00Z\u0027,"},{"line_number":109,"context_line":"    \u0027generatorURL\u0027: \u0027http://controller147:9090/graph?g0.expr\u003d\u0027"},{"line_number":110,"context_line":"                    \u0027up%7Bjob%3D%22node%22%7D+%3D%3D+0\u0026g0.tab\u003d1\u0027,"},{"line_number":111,"context_line":"    \u0027fingerprint\u0027: \u00275ef77f1f8a3ecb8d\u0027"},{"line_number":112,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":26,"id":"0898268c_83cfff60","line":109,"in_reply_to":"97cd2b1e_dc3aff89","updated":"2023-03-10 05:24:39.000000000","message":"I removed it in patchset 27.","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"c91b4e23c97bd4585fbe79ba14b509a60f79b35a","unresolved":true,"context_lines":[{"line_number":120,"context_line":"_body_pm_threshold_alert3[\u0027labels\u0027][\u0027object_instance_id\u0027] \u003d ("},{"line_number":121,"context_line":"    \u0027obj_instance_mismatch\u0027)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"# object_instance_id mismatch"},{"line_number":124,"context_line":"_body_pm_threshold_alert4 \u003d copy.deepcopy(_body_pm_threshold_alert1)"},{"line_number":125,"context_line":"_body_pm_threshold_alert4[\u0027labels\u0027][\u0027sub_object_instance_id\u0027] \u003d ("},{"line_number":126,"context_line":"    \u0027sub_object_mismatch\u0027)"}],"source_content_type":"text/x-python","patch_set":26,"id":"20ced1cb_42cb4b56","line":123,"updated":"2023-03-09 09:40:03.000000000","message":"object_instance_id -\u003e sub_object_instance_id","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"ffcbe62c7d93958ce4d3e37c19eefb313a24f4aa","unresolved":true,"context_lines":[{"line_number":120,"context_line":"_body_pm_threshold_alert3[\u0027labels\u0027][\u0027object_instance_id\u0027] \u003d ("},{"line_number":121,"context_line":"    \u0027obj_instance_mismatch\u0027)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"# object_instance_id mismatch"},{"line_number":124,"context_line":"_body_pm_threshold_alert4 \u003d copy.deepcopy(_body_pm_threshold_alert1)"},{"line_number":125,"context_line":"_body_pm_threshold_alert4[\u0027labels\u0027][\u0027sub_object_instance_id\u0027] \u003d ("},{"line_number":126,"context_line":"    \u0027sub_object_mismatch\u0027)"}],"source_content_type":"text/x-python","patch_set":26,"id":"2bfc542a_fa46868e","line":123,"in_reply_to":"20ced1cb_42cb4b56","updated":"2023-03-10 05:24:39.000000000","message":"I removed it in patchset 27.","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"8f06305958ef940b7db0ad505c6afd11351558ea","unresolved":false,"context_lines":[{"line_number":120,"context_line":"_body_pm_threshold_alert3[\u0027labels\u0027][\u0027object_instance_id\u0027] \u003d ("},{"line_number":121,"context_line":"    \u0027obj_instance_mismatch\u0027)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"# object_instance_id mismatch"},{"line_number":124,"context_line":"_body_pm_threshold_alert4 \u003d copy.deepcopy(_body_pm_threshold_alert1)"},{"line_number":125,"context_line":"_body_pm_threshold_alert4[\u0027labels\u0027][\u0027sub_object_instance_id\u0027] \u003d ("},{"line_number":126,"context_line":"    \u0027sub_object_mismatch\u0027)"}],"source_content_type":"text/x-python","patch_set":26,"id":"59edfcf3_0389a0a4","line":123,"in_reply_to":"2bfc542a_fa46868e","updated":"2023-03-10 07:29:52.000000000","message":"Done","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"}],"tacker/tests/unit/sol_refactored/controller/test_vnfpm_v2.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"a37e2e80a7bc6d9e2f477ff6880f50fa4b0210da","unresolved":true,"context_lines":[{"line_number":474,"context_line":"                          request\u003dself.request, body\u003dbody)"},{"line_number":475,"context_line":""},{"line_number":476,"context_line":"    # \u0027objectInstanceId\u0027 is None"},{"line_number":477,"context_line":"    def test_create_pm_threshold_error_6(self, ):"},{"line_number":478,"context_line":"        _ThresholdCriteria_V2 \u003d {"},{"line_number":479,"context_line":"            \u0027performanceMetric\u0027: \u0027VCpuUsageMeanVnf.VNF\u0027,"},{"line_number":480,"context_line":"            \u0027thresholdType\u0027: \u0027SIMPLE\u0027,"}],"source_content_type":"text/x-python","patch_set":13,"id":"5e0dca85_094a4d1d","line":477,"range":{"start_line":477,"start_character":39,"end_line":477,"end_character":40},"updated":"2023-02-27 13:59:55.000000000","message":"Just a question, why does the last number jump to 6 from 3?","commit_id":"684824f35fd01773b0d4e9d14eeeaad4709c08e6"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"39fddcd86ac23ded4748b17b6c009639502b1a2f","unresolved":false,"context_lines":[{"line_number":474,"context_line":"                          request\u003dself.request, body\u003dbody)"},{"line_number":475,"context_line":""},{"line_number":476,"context_line":"    # \u0027objectInstanceId\u0027 is None"},{"line_number":477,"context_line":"    def test_create_pm_threshold_error_6(self, ):"},{"line_number":478,"context_line":"        _ThresholdCriteria_V2 \u003d {"},{"line_number":479,"context_line":"            \u0027performanceMetric\u0027: \u0027VCpuUsageMeanVnf.VNF\u0027,"},{"line_number":480,"context_line":"            \u0027thresholdType\u0027: \u0027SIMPLE\u0027,"}],"source_content_type":"text/x-python","patch_set":13,"id":"71844026_ef574e72","line":477,"range":{"start_line":477,"start_character":39,"end_line":477,"end_character":40},"in_reply_to":"57457a9e_17bf8991","updated":"2023-03-01 08:16:13.000000000","message":"Ack","commit_id":"684824f35fd01773b0d4e9d14eeeaad4709c08e6"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"41273f8fda983cfc1f00f66688f8468915ef945f","unresolved":true,"context_lines":[{"line_number":474,"context_line":"                          request\u003dself.request, body\u003dbody)"},{"line_number":475,"context_line":""},{"line_number":476,"context_line":"    # \u0027objectInstanceId\u0027 is None"},{"line_number":477,"context_line":"    def test_create_pm_threshold_error_6(self, ):"},{"line_number":478,"context_line":"        _ThresholdCriteria_V2 \u003d {"},{"line_number":479,"context_line":"            \u0027performanceMetric\u0027: \u0027VCpuUsageMeanVnf.VNF\u0027,"},{"line_number":480,"context_line":"            \u0027thresholdType\u0027: \u0027SIMPLE\u0027,"}],"source_content_type":"text/x-python","patch_set":13,"id":"57457a9e_17bf8991","line":477,"range":{"start_line":477,"start_character":39,"end_line":477,"end_character":40},"in_reply_to":"5e0dca85_094a4d1d","updated":"2023-03-01 08:05:06.000000000","message":"The numbers are wrong here, I have renumbered them.","commit_id":"684824f35fd01773b0d4e9d14eeeaad4709c08e6"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"c91b4e23c97bd4585fbe79ba14b509a60f79b35a","unresolved":true,"context_lines":[{"line_number":390,"context_line":"        result \u003d self.controller.supported_api_versions(\u0027create\u0027)"},{"line_number":391,"context_line":"        self.assertEqual([\u00272.1.0\u0027], result)"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"    # \u0027performanceMetric\u0027 don\u0027t match objectType"},{"line_number":394,"context_line":"    def test_create_pm_threshold_error_1(self):"},{"line_number":395,"context_line":"        _ThresholdCriteria_V2 \u003d {"},{"line_number":396,"context_line":"            \u0027performanceMetric\u0027: \u0027ByteIncomingVnfIntCp.VNF\u0027,"}],"source_content_type":"text/x-python","patch_set":26,"id":"753549a8_9f4b5c9a","line":393,"updated":"2023-03-09 09:40:03.000000000","message":"don\u0027t -\u003e doesn\u0027t","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"ffcbe62c7d93958ce4d3e37c19eefb313a24f4aa","unresolved":true,"context_lines":[{"line_number":390,"context_line":"        result \u003d self.controller.supported_api_versions(\u0027create\u0027)"},{"line_number":391,"context_line":"        self.assertEqual([\u00272.1.0\u0027], result)"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"    # \u0027performanceMetric\u0027 don\u0027t match objectType"},{"line_number":394,"context_line":"    def test_create_pm_threshold_error_1(self):"},{"line_number":395,"context_line":"        _ThresholdCriteria_V2 \u003d {"},{"line_number":396,"context_line":"            \u0027performanceMetric\u0027: \u0027ByteIncomingVnfIntCp.VNF\u0027,"}],"source_content_type":"text/x-python","patch_set":26,"id":"d3c98761_e85a01d2","line":393,"in_reply_to":"753549a8_9f4b5c9a","updated":"2023-03-10 05:24:39.000000000","message":"I removed it in patchset 27.","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"8f06305958ef940b7db0ad505c6afd11351558ea","unresolved":false,"context_lines":[{"line_number":390,"context_line":"        result \u003d self.controller.supported_api_versions(\u0027create\u0027)"},{"line_number":391,"context_line":"        self.assertEqual([\u00272.1.0\u0027], result)"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"    # \u0027performanceMetric\u0027 don\u0027t match objectType"},{"line_number":394,"context_line":"    def test_create_pm_threshold_error_1(self):"},{"line_number":395,"context_line":"        _ThresholdCriteria_V2 \u003d {"},{"line_number":396,"context_line":"            \u0027performanceMetric\u0027: \u0027ByteIncomingVnfIntCp.VNF\u0027,"}],"source_content_type":"text/x-python","patch_set":26,"id":"51e62ff4_f08fa8af","line":393,"in_reply_to":"d3c98761_e85a01d2","updated":"2023-03-10 07:29:52.000000000","message":"Done","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"c91b4e23c97bd4585fbe79ba14b509a60f79b35a","unresolved":true,"context_lines":[{"line_number":450,"context_line":""},{"line_number":451,"context_line":"    # \u0027simpleThresholdDetails\u0027 is \u0027\u0027"},{"line_number":452,"context_line":"    def test_create_pm_threshold_error_3(self):"},{"line_number":453,"context_line":"        _ThresholdCriteria_V2 \u003d {"},{"line_number":454,"context_line":"            \u0027performanceMetric\u0027: \u0027VCpuUsageMeanVnf.VNF\u0027,"},{"line_number":455,"context_line":"            \u0027thresholdType\u0027: \u0027SIMPLE\u0027,"},{"line_number":456,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":26,"id":"a62a6142_82f99d04","line":453,"updated":"2023-03-09 09:40:03.000000000","message":"It doesn\u0027t seem to match the comment above.\nShouldn\u0027t it be set as follows?\n* \u0027simpleThresholdDetails\u0027: \u0027\u0027","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"8f06305958ef940b7db0ad505c6afd11351558ea","unresolved":false,"context_lines":[{"line_number":450,"context_line":""},{"line_number":451,"context_line":"    # \u0027simpleThresholdDetails\u0027 is \u0027\u0027"},{"line_number":452,"context_line":"    def test_create_pm_threshold_error_3(self):"},{"line_number":453,"context_line":"        _ThresholdCriteria_V2 \u003d {"},{"line_number":454,"context_line":"            \u0027performanceMetric\u0027: \u0027VCpuUsageMeanVnf.VNF\u0027,"},{"line_number":455,"context_line":"            \u0027thresholdType\u0027: \u0027SIMPLE\u0027,"},{"line_number":456,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":26,"id":"8c185344_c3928d2c","line":453,"in_reply_to":"7d6ba42e_d36de80b","updated":"2023-03-10 07:29:52.000000000","message":"Done","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"ffcbe62c7d93958ce4d3e37c19eefb313a24f4aa","unresolved":true,"context_lines":[{"line_number":450,"context_line":""},{"line_number":451,"context_line":"    # \u0027simpleThresholdDetails\u0027 is \u0027\u0027"},{"line_number":452,"context_line":"    def test_create_pm_threshold_error_3(self):"},{"line_number":453,"context_line":"        _ThresholdCriteria_V2 \u003d {"},{"line_number":454,"context_line":"            \u0027performanceMetric\u0027: \u0027VCpuUsageMeanVnf.VNF\u0027,"},{"line_number":455,"context_line":"            \u0027thresholdType\u0027: \u0027SIMPLE\u0027,"},{"line_number":456,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":26,"id":"7d6ba42e_d36de80b","line":453,"in_reply_to":"a62a6142_82f99d04","updated":"2023-03-10 05:24:39.000000000","message":"I modified the comment.","commit_id":"fc4e247ef4d886c09b9f971aa12add595b06e254"}]}