)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"476daf7db825dbcc20eb93605be2a1d0f61ca067","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix error attribute of LCM notification"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"According to ESTI spec, \"error\" attribute of"},{"line_number":10,"context_line":"VnfLcmOperationOccurrenceNotification shall be present if the"},{"line_number":11,"context_line":"\"operationState\" attribute is \"FAILED_TEMP\",\"FAILED\" or"},{"line_number":12,"context_line":"\"ROLLED_BACK\" and shall be absent otherwise."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"927c9767_a95e5190","line":9,"range":{"start_line":9,"start_character":13,"end_line":9,"end_character":22},"updated":"2023-02-20 00:29:02.000000000","message":"nits: ETSI spec -\u003e ETSI NFV-SOL 003 v3.3.1","commit_id":"c21dd2971694dc8f0e35190c935adb4be0e8abe0"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"07a721d6f4d57ef6c7b4e39b7e984a7267e90f23","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix error attribute of LCM notification"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"According to ESTI spec, \"error\" attribute of"},{"line_number":10,"context_line":"VnfLcmOperationOccurrenceNotification shall be present if the"},{"line_number":11,"context_line":"\"operationState\" attribute is \"FAILED_TEMP\",\"FAILED\" or"},{"line_number":12,"context_line":"\"ROLLED_BACK\" and shall be absent otherwise."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"190f1f9b_ecd1d96b","line":9,"range":{"start_line":9,"start_character":13,"end_line":9,"end_character":22},"in_reply_to":"3d15d37b_5de01be6","updated":"2023-02-20 04:47:18.000000000","message":"Done","commit_id":"c21dd2971694dc8f0e35190c935adb4be0e8abe0"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"d8ffab4ef1f29292126f26ca3cb4cb4689829bfa","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix error attribute of LCM notification"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"According to ESTI spec, \"error\" attribute of"},{"line_number":10,"context_line":"VnfLcmOperationOccurrenceNotification shall be present if the"},{"line_number":11,"context_line":"\"operationState\" attribute is \"FAILED_TEMP\",\"FAILED\" or"},{"line_number":12,"context_line":"\"ROLLED_BACK\" and shall be absent otherwise."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3d15d37b_5de01be6","line":9,"range":{"start_line":9,"start_character":13,"end_line":9,"end_character":22},"in_reply_to":"927c9767_a95e5190","updated":"2023-02-20 01:29:33.000000000","message":"I will fix.","commit_id":"c21dd2971694dc8f0e35190c935adb4be0e8abe0"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"476daf7db825dbcc20eb93605be2a1d0f61ca067","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"698ec6c9_c06722fa","updated":"2023-02-20 00:29:02.000000000","message":"Thank you for the patch. Please kindly check my comments.","commit_id":"c21dd2971694dc8f0e35190c935adb4be0e8abe0"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"d8ffab4ef1f29292126f26ca3cb4cb4689829bfa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"21679a38_e7557548","updated":"2023-02-20 01:29:33.000000000","message":"Thank you for the review.","commit_id":"c21dd2971694dc8f0e35190c935adb4be0e8abe0"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"41b0df6e47fd792c1684230578cb2f5dd369fa52","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6047795a_7c4fc956","updated":"2023-02-20 09:44:27.000000000","message":"LGTM.","commit_id":"dbc2caac583ddf47ffccf9fc9ac8743d95f50779"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"0d9ce8bd29b97227f23724daa7991efb84b92bed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f4712e82_ffafca23","updated":"2023-02-20 04:48:29.000000000","message":"Please kindly review the patch.","commit_id":"dbc2caac583ddf47ffccf9fc9ac8743d95f50779"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"07a721d6f4d57ef6c7b4e39b7e984a7267e90f23","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"52fea3e1_e3297016","updated":"2023-02-20 04:47:18.000000000","message":"Thank you for re-work! LGTM","commit_id":"dbc2caac583ddf47ffccf9fc9ac8743d95f50779"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"72650a7125e1b7b0f84b6119df6c7ea7c43c0540","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1dcab100_e40cf394","updated":"2023-02-20 13:12:50.000000000","message":"Thanks for your patch, LGTM.","commit_id":"dbc2caac583ddf47ffccf9fc9ac8743d95f50779"}],"tacker/tests/unit/sol_refactored/common/test_lcm_op_occ_utils.py":[{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"476daf7db825dbcc20eb93605be2a1d0f61ca067","unresolved":true,"context_lines":[{"line_number":2400,"context_line":"        self.assertEqual(expected_result.fail.href, result.fail.href)"},{"line_number":2401,"context_line":""},{"line_number":2402,"context_line":"    def test_make_lcmocc_notif_data(self):"},{"line_number":2403,"context_line":"        subsc_short \u003d objects.LccnSubscriptionV2("},{"line_number":2404,"context_line":"            id\u003d\u0027sub-1\u0027, verbosity\u003d\u0027SHORT\u0027)"},{"line_number":2405,"context_line":"        subsc_full \u003d objects.LccnSubscriptionV2("},{"line_number":2406,"context_line":"            id\u003d\u0027sub-1\u0027, verbosity\u003d\u0027FULL\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f3844e7_bcd7564b","line":2403,"range":{"start_line":2403,"start_character":8,"end_line":2403,"end_character":19},"updated":"2023-02-20 00:29:02.000000000","message":"Just a question, these changes make it the same as the type of \"verbosity\", isn\u0027t it?","commit_id":"c21dd2971694dc8f0e35190c935adb4be0e8abe0"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"d8ffab4ef1f29292126f26ca3cb4cb4689829bfa","unresolved":true,"context_lines":[{"line_number":2400,"context_line":"        self.assertEqual(expected_result.fail.href, result.fail.href)"},{"line_number":2401,"context_line":""},{"line_number":2402,"context_line":"    def test_make_lcmocc_notif_data(self):"},{"line_number":2403,"context_line":"        subsc_short \u003d objects.LccnSubscriptionV2("},{"line_number":2404,"context_line":"            id\u003d\u0027sub-1\u0027, verbosity\u003d\u0027SHORT\u0027)"},{"line_number":2405,"context_line":"        subsc_full \u003d objects.LccnSubscriptionV2("},{"line_number":2406,"context_line":"            id\u003d\u0027sub-1\u0027, verbosity\u003d\u0027FULL\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"a5d9c7c7_b1221b66","line":2403,"range":{"start_line":2403,"start_character":8,"end_line":2403,"end_character":19},"in_reply_to":"9f3844e7_bcd7564b","updated":"2023-02-20 01:29:33.000000000","message":"yes. this became to be used by L.2420 (for inst) too. I think subsc_short/subsc_full is better than subsc_modify/subsc_inst.","commit_id":"c21dd2971694dc8f0e35190c935adb4be0e8abe0"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"07a721d6f4d57ef6c7b4e39b7e984a7267e90f23","unresolved":false,"context_lines":[{"line_number":2400,"context_line":"        self.assertEqual(expected_result.fail.href, result.fail.href)"},{"line_number":2401,"context_line":""},{"line_number":2402,"context_line":"    def test_make_lcmocc_notif_data(self):"},{"line_number":2403,"context_line":"        subsc_short \u003d objects.LccnSubscriptionV2("},{"line_number":2404,"context_line":"            id\u003d\u0027sub-1\u0027, verbosity\u003d\u0027SHORT\u0027)"},{"line_number":2405,"context_line":"        subsc_full \u003d objects.LccnSubscriptionV2("},{"line_number":2406,"context_line":"            id\u003d\u0027sub-1\u0027, verbosity\u003d\u0027FULL\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"28839a98_0c1723ec","line":2403,"range":{"start_line":2403,"start_character":8,"end_line":2403,"end_character":19},"in_reply_to":"a5d9c7c7_b1221b66","updated":"2023-02-20 04:47:18.000000000","message":"Thanks for your reply, I understood and agree with your changes!+1","commit_id":"c21dd2971694dc8f0e35190c935adb4be0e8abe0"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"476daf7db825dbcc20eb93605be2a1d0f61ca067","unresolved":true,"context_lines":[{"line_number":2422,"context_line":"        self.assertEqual(\u0027START\u0027, modify_result.notificationStatus)"},{"line_number":2423,"context_line":"        self.assertIsNotNone(inst_result.affectedVnfcs)"},{"line_number":2424,"context_line":"        self.assertIsNotNone(inst_result.changedInfo)"},{"line_number":2425,"context_line":"        self.assertNotIn(inst_result, \u0027error\u0027)"},{"line_number":2426,"context_line":"        self.assertEqual(\u0027error_detail\u0027, inst_result_error.error.detail)"},{"line_number":2427,"context_line":""},{"line_number":2428,"context_line":"    @mock.patch.object(objects.base.TackerPersistentObject, \u0027get_by_filter\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"2db80d7d_fc93e738","line":2425,"updated":"2023-02-20 00:29:02.000000000","message":"assertNotIn(x, y) means `x` not in `y`, so I think that `self.assertNotIn(\u0027error\u0027, inst_result)` is right.\nThis UT (assertNotIn) maybe need to check `\"error\"` not in `inst_result (lcmocc_notif_data)`.","commit_id":"c21dd2971694dc8f0e35190c935adb4be0e8abe0"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"d8ffab4ef1f29292126f26ca3cb4cb4689829bfa","unresolved":true,"context_lines":[{"line_number":2422,"context_line":"        self.assertEqual(\u0027START\u0027, modify_result.notificationStatus)"},{"line_number":2423,"context_line":"        self.assertIsNotNone(inst_result.affectedVnfcs)"},{"line_number":2424,"context_line":"        self.assertIsNotNone(inst_result.changedInfo)"},{"line_number":2425,"context_line":"        self.assertNotIn(inst_result, \u0027error\u0027)"},{"line_number":2426,"context_line":"        self.assertEqual(\u0027error_detail\u0027, inst_result_error.error.detail)"},{"line_number":2427,"context_line":""},{"line_number":2428,"context_line":"    @mock.patch.object(objects.base.TackerPersistentObject, \u0027get_by_filter\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"c112f26c_14c98d12","line":2425,"in_reply_to":"2db80d7d_fc93e738","updated":"2023-02-20 01:29:33.000000000","message":"You are right. I will fix.","commit_id":"c21dd2971694dc8f0e35190c935adb4be0e8abe0"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"07a721d6f4d57ef6c7b4e39b7e984a7267e90f23","unresolved":false,"context_lines":[{"line_number":2422,"context_line":"        self.assertEqual(\u0027START\u0027, modify_result.notificationStatus)"},{"line_number":2423,"context_line":"        self.assertIsNotNone(inst_result.affectedVnfcs)"},{"line_number":2424,"context_line":"        self.assertIsNotNone(inst_result.changedInfo)"},{"line_number":2425,"context_line":"        self.assertNotIn(inst_result, \u0027error\u0027)"},{"line_number":2426,"context_line":"        self.assertEqual(\u0027error_detail\u0027, inst_result_error.error.detail)"},{"line_number":2427,"context_line":""},{"line_number":2428,"context_line":"    @mock.patch.object(objects.base.TackerPersistentObject, \u0027get_by_filter\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5b802cc0_b2317dfc","line":2425,"in_reply_to":"c112f26c_14c98d12","updated":"2023-02-20 04:47:18.000000000","message":"Done","commit_id":"c21dd2971694dc8f0e35190c935adb4be0e8abe0"}]}