)]}'
{".zuul.yaml":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b03bd0c9ab6a803ec8623fe38e1e37ef70aa7dd2","unresolved":true,"context_lines":[{"line_number":298,"context_line":"              prometheus_plugin:"},{"line_number":299,"context_line":"                auto_scaling: true"},{"line_number":300,"context_line":"                auto_healing: true"},{"line_number":301,"context_line":"              v2_vnfm:"},{"line_number":302,"context_line":"                vnf_instance_page_size: 1"},{"line_number":303,"context_line":"                lcm_op_occ_page_size: 3"},{"line_number":304,"context_line":"        tox_envlist: dsvm-functional-sol-v2"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"- job:"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"68b253c8_6024af58","line":303,"range":{"start_line":301,"start_character":0,"end_line":303,"end_character":39},"updated":"2023-03-10 06:06:22.000000000","message":"Why do you change page_size config of this job?","commit_id":"0ee7a54c759b3b0772ac1b227e9b6fc54346ba90"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"05e31c55462ca219d246626bf4d94c0a7785d2c4","unresolved":false,"context_lines":[{"line_number":298,"context_line":"              prometheus_plugin:"},{"line_number":299,"context_line":"                auto_scaling: true"},{"line_number":300,"context_line":"                auto_healing: true"},{"line_number":301,"context_line":"              v2_vnfm:"},{"line_number":302,"context_line":"                vnf_instance_page_size: 1"},{"line_number":303,"context_line":"                lcm_op_occ_page_size: 3"},{"line_number":304,"context_line":"        tox_envlist: dsvm-functional-sol-v2"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"- job:"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"4d6f4090_75be25d3","line":303,"range":{"start_line":301,"start_character":0,"end_line":303,"end_character":39},"in_reply_to":"38bbe828_c0401470","updated":"2023-03-10 07:42:32.000000000","message":"Ack","commit_id":"0ee7a54c759b3b0772ac1b227e9b6fc54346ba90"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"b94da400bb968821d20052466de353d841130286","unresolved":true,"context_lines":[{"line_number":298,"context_line":"              prometheus_plugin:"},{"line_number":299,"context_line":"                auto_scaling: true"},{"line_number":300,"context_line":"                auto_healing: true"},{"line_number":301,"context_line":"              v2_vnfm:"},{"line_number":302,"context_line":"                vnf_instance_page_size: 1"},{"line_number":303,"context_line":"                lcm_op_occ_page_size: 3"},{"line_number":304,"context_line":"        tox_envlist: dsvm-functional-sol-v2"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"- job:"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"38bbe828_c0401470","line":303,"range":{"start_line":301,"start_character":0,"end_line":303,"end_character":39},"in_reply_to":"68b253c8_6024af58","updated":"2023-03-10 06:26:36.000000000","message":"I fixed it in PS31.","commit_id":"0ee7a54c759b3b0772ac1b227e9b6fc54346ba90"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b03bd0c9ab6a803ec8623fe38e1e37ef70aa7dd2","unresolved":true,"context_lines":[{"line_number":377,"context_line":"      controller-tacker:"},{"line_number":378,"context_line":"        devstack_local_conf:"},{"line_number":379,"context_line":"          post-config:"},{"line_number":380,"context_line":"            $TACKER_CONF:"},{"line_number":381,"context_line":"              v2_vnfm:"},{"line_number":382,"context_line":"                vnf_instance_page_size: 1"},{"line_number":383,"context_line":"                lcm_op_occ_page_size: 1"},{"line_number":384,"context_line":"        tox_envlist: dsvm-functional-sol-v2-individual-vnfc-mgmt"},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"- job:"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"62d215b9_7776dca6","line":383,"range":{"start_line":380,"start_character":25,"end_line":383,"end_character":39},"updated":"2023-03-10 06:06:22.000000000","message":"Why do you change page_size config of this job?\n\nDoes responding to the following comments (independent VNF instance for each test) make this change unnecessary?\n\u003e It is desirable that the VNF Instacne used for each test be independent.\n\u003e Could you please execute the create process in each test?","commit_id":"0ee7a54c759b3b0772ac1b227e9b6fc54346ba90"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"05e31c55462ca219d246626bf4d94c0a7785d2c4","unresolved":false,"context_lines":[{"line_number":377,"context_line":"      controller-tacker:"},{"line_number":378,"context_line":"        devstack_local_conf:"},{"line_number":379,"context_line":"          post-config:"},{"line_number":380,"context_line":"            $TACKER_CONF:"},{"line_number":381,"context_line":"              v2_vnfm:"},{"line_number":382,"context_line":"                vnf_instance_page_size: 1"},{"line_number":383,"context_line":"                lcm_op_occ_page_size: 1"},{"line_number":384,"context_line":"        tox_envlist: dsvm-functional-sol-v2-individual-vnfc-mgmt"},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"- job:"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"0bfa9b50_8c1dcb93","line":383,"range":{"start_line":380,"start_character":25,"end_line":383,"end_character":39},"in_reply_to":"41f8ea5b_916d51e6","updated":"2023-03-10 07:42:32.000000000","message":"Thanks for your explanation, I understand.","commit_id":"0ee7a54c759b3b0772ac1b227e9b6fc54346ba90"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"b94da400bb968821d20052466de353d841130286","unresolved":true,"context_lines":[{"line_number":377,"context_line":"      controller-tacker:"},{"line_number":378,"context_line":"        devstack_local_conf:"},{"line_number":379,"context_line":"          post-config:"},{"line_number":380,"context_line":"            $TACKER_CONF:"},{"line_number":381,"context_line":"              v2_vnfm:"},{"line_number":382,"context_line":"                vnf_instance_page_size: 1"},{"line_number":383,"context_line":"                lcm_op_occ_page_size: 1"},{"line_number":384,"context_line":"        tox_envlist: dsvm-functional-sol-v2-individual-vnfc-mgmt"},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"- job:"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"41f8ea5b_916d51e6","line":383,"range":{"start_line":380,"start_character":25,"end_line":383,"end_character":39},"in_reply_to":"62d215b9_7776dca6","updated":"2023-03-10 06:26:36.000000000","message":"No. This job needs to check Link Header in List API\u0027s response body.\nThe \u0027Link\u0027 Header is returned only if page_size is not 0.","commit_id":"0ee7a54c759b3b0772ac1b227e9b6fc54346ba90"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"88548870bdeae44cf82f25cb0a9108729bb72ca2","unresolved":true,"context_lines":[{"line_number":764,"context_line":"            voting: false"},{"line_number":765,"context_line":"        - tacker-functional-devstack-multinode-sol-v2"},{"line_number":766,"context_line":"        - tacker-functional-devstack-multinode-sol-separated-nfvo-v2"},{"line_number":767,"context_line":"        - tacker-functional-devstack-multinode-sol-v2-individual-vnfc-mgmt"},{"line_number":768,"context_line":"        - tacker-functional-devstack-multinode-sol-v2-ubuntu-focal"},{"line_number":769,"context_line":"        - tacker-functional-devstack-multinode-sol-kubernetes-v2"},{"line_number":770,"context_line":"        - tacker-functional-devstack-multinode-sol-multi-tenant"}],"source_content_type":"text/x-yaml","patch_set":42,"id":"5c44de30_bfdb2f8f","line":767,"range":{"start_line":767,"start_character":10,"end_line":767,"end_character":74},"updated":"2023-04-17 12:54:23.000000000","message":"As the job definition is added after \"tacker-functional-devstack-sol-v2-ubuntu-focal\" [1], for consistency please specify job execution in the same order i.e. after sol-v2-ubuntu-focal job. \n\n[1] https://review.opendev.org/c/openstack/tacker/+/873477/42/.zuul.yaml#367","commit_id":"af2c56764f9c8c256e9f2d75a43d461fab13e4d4"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"8a9df843948600460518da46b2cde2b152537ad6","unresolved":true,"context_lines":[{"line_number":764,"context_line":"            voting: false"},{"line_number":765,"context_line":"        - tacker-functional-devstack-multinode-sol-v2"},{"line_number":766,"context_line":"        - tacker-functional-devstack-multinode-sol-separated-nfvo-v2"},{"line_number":767,"context_line":"        - tacker-functional-devstack-multinode-sol-v2-individual-vnfc-mgmt"},{"line_number":768,"context_line":"        - tacker-functional-devstack-multinode-sol-v2-ubuntu-focal"},{"line_number":769,"context_line":"        - tacker-functional-devstack-multinode-sol-kubernetes-v2"},{"line_number":770,"context_line":"        - tacker-functional-devstack-multinode-sol-multi-tenant"}],"source_content_type":"text/x-yaml","patch_set":42,"id":"66f2b66b_1c65cbdf","line":767,"range":{"start_line":767,"start_character":10,"end_line":767,"end_character":74},"in_reply_to":"5c44de30_bfdb2f8f","updated":"2023-04-28 04:39:58.000000000","message":"I fixed it in PS46.","commit_id":"af2c56764f9c8c256e9f2d75a43d461fab13e4d4"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"bd4f48ee64df55c28eae8c9d6a8ea396192f46c9","unresolved":false,"context_lines":[{"line_number":764,"context_line":"            voting: false"},{"line_number":765,"context_line":"        - tacker-functional-devstack-multinode-sol-v2"},{"line_number":766,"context_line":"        - tacker-functional-devstack-multinode-sol-separated-nfvo-v2"},{"line_number":767,"context_line":"        - tacker-functional-devstack-multinode-sol-v2-individual-vnfc-mgmt"},{"line_number":768,"context_line":"        - tacker-functional-devstack-multinode-sol-v2-ubuntu-focal"},{"line_number":769,"context_line":"        - tacker-functional-devstack-multinode-sol-kubernetes-v2"},{"line_number":770,"context_line":"        - tacker-functional-devstack-multinode-sol-multi-tenant"}],"source_content_type":"text/x-yaml","patch_set":42,"id":"d2f35a22_e7935a96","line":767,"range":{"start_line":767,"start_character":10,"end_line":767,"end_character":74},"in_reply_to":"66f2b66b_1c65cbdf","updated":"2023-05-05 09:03:16.000000000","message":"Ack","commit_id":"af2c56764f9c8c256e9f2d75a43d461fab13e4d4"}],"/COMMIT_MSG":[{"author":{"_account_id":31668},"change_message_id":"7a80155badbd39e63b238399dd9b322616cc0849","unresolved":true,"context_lines":[{"line_number":17,"context_line":"    * Test rollback change external VNF connectivity and update VNF"},{"line_number":18,"context_line":"    * Test rollback change current VNF Package"},{"line_number":19,"context_line":"    * Test various lcm operations before/after"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I0da080418a1f1de803b950a9d0c8676e833a1f3e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"587bb6b6_bc647a56","line":20,"updated":"2023-03-03 01:04:01.000000000","message":"Could you please add the following?\n* Implements: blueprint individual-vnfc-management\n\nAnd please change the Topic to the following.\n* bp/individual-vnfc-management","commit_id":"feed9c78524aefbdd74cea7d38e9cbc91eaa8223"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"04fcc3655dd8ea9a2ba096809ffe2b095aae8d7c","unresolved":true,"context_lines":[{"line_number":17,"context_line":"    * Test rollback change external VNF connectivity and update VNF"},{"line_number":18,"context_line":"    * Test rollback change current VNF Package"},{"line_number":19,"context_line":"    * Test various lcm operations before/after"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I0da080418a1f1de803b950a9d0c8676e833a1f3e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"8eda0c6c_9f0e16fc","line":20,"in_reply_to":"587bb6b6_bc647a56","updated":"2023-03-03 01:29:22.000000000","message":"I fixed them in PS10.","commit_id":"feed9c78524aefbdd74cea7d38e9cbc91eaa8223"},{"author":{"_account_id":31668},"change_message_id":"75d4d5da6db5660184c1e89fbd1440126063e695","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    * Test rollback change external VNF connectivity and update VNF"},{"line_number":18,"context_line":"    * Test rollback change current VNF Package"},{"line_number":19,"context_line":"    * Test various lcm operations before/after"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I0da080418a1f1de803b950a9d0c8676e833a1f3e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"a101b656_dc847ec1","line":20,"in_reply_to":"8eda0c6c_9f0e16fc","updated":"2023-03-07 01:54:46.000000000","message":"Done","commit_id":"feed9c78524aefbdd74cea7d38e9cbc91eaa8223"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"7eee81198d7cdd08a62dbc1aa84c1f65af2a6e3d","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Shuwen Cai \u003ccaishuwen@fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-03-03 11:43:40 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Extend FT tests for Individual Vnfc Mgmt"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch extends the FT test items related to individual vnfc"},{"line_number":10,"context_line":"mgmt to make the test coverage of this function more comprehensive."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"c2fd3591_17cfda5e","line":7,"range":{"start_line":7,"start_character":7,"end_line":7,"end_character":15},"updated":"2023-03-06 04:06:32.000000000","message":"nits: FT tests -\u003e Functional tests","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"d55617e8836d80895ddeb621bc1abe32b0f71263","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Shuwen Cai \u003ccaishuwen@fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-03-03 11:43:40 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Extend FT tests for Individual Vnfc Mgmt"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch extends the FT test items related to individual vnfc"},{"line_number":10,"context_line":"mgmt to make the test coverage of this function more comprehensive."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"eaf88159_c853353a","line":7,"range":{"start_line":7,"start_character":7,"end_line":7,"end_character":15},"in_reply_to":"c2fd3591_17cfda5e","updated":"2023-03-07 03:07:09.000000000","message":"I fixed it in PS17.","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"f19e5ec3c81954db706cbc026364ed9a58b20ce0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Shuwen Cai \u003ccaishuwen@fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-03-03 11:43:40 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Extend FT tests for Individual Vnfc Mgmt"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch extends the FT test items related to individual vnfc"},{"line_number":10,"context_line":"mgmt to make the test coverage of this function more comprehensive."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"a747a2cc_2767afde","line":7,"range":{"start_line":7,"start_character":7,"end_line":7,"end_character":15},"in_reply_to":"eaf88159_c853353a","updated":"2023-04-05 08:17:27.000000000","message":"Done","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"7eee81198d7cdd08a62dbc1aa84c1f65af2a6e3d","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Extend FT tests for Individual Vnfc Mgmt"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch extends the FT test items related to individual vnfc"},{"line_number":10,"context_line":"mgmt to make the test coverage of this function more comprehensive."},{"line_number":11,"context_line":"The following seven patterns are added."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"a65e1e9b_fa45d44a","line":9,"range":{"start_line":9,"start_character":23,"end_line":9,"end_character":30},"updated":"2023-03-06 04:06:32.000000000","message":"nits: FT test items -\u003e functional test items","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"f19e5ec3c81954db706cbc026364ed9a58b20ce0","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Extend FT tests for Individual Vnfc Mgmt"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch extends the FT test items related to individual vnfc"},{"line_number":10,"context_line":"mgmt to make the test coverage of this function more comprehensive."},{"line_number":11,"context_line":"The following seven patterns are added."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"bd0aa27c_978c5eaa","line":9,"range":{"start_line":9,"start_character":23,"end_line":9,"end_character":30},"in_reply_to":"a6190856_4d9256ef","updated":"2023-04-05 08:17:27.000000000","message":"Done","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"d55617e8836d80895ddeb621bc1abe32b0f71263","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Extend FT tests for Individual Vnfc Mgmt"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch extends the FT test items related to individual vnfc"},{"line_number":10,"context_line":"mgmt to make the test coverage of this function more comprehensive."},{"line_number":11,"context_line":"The following seven patterns are added."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"a6190856_4d9256ef","line":9,"range":{"start_line":9,"start_character":23,"end_line":9,"end_character":30},"in_reply_to":"a65e1e9b_fa45d44a","updated":"2023-03-07 03:07:09.000000000","message":"I fixed it in PS17.","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"7eee81198d7cdd08a62dbc1aa84c1f65af2a6e3d","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Extend FT tests for Individual Vnfc Mgmt"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch extends the FT test items related to individual vnfc"},{"line_number":10,"context_line":"mgmt to make the test coverage of this function more comprehensive."},{"line_number":11,"context_line":"The following seven patterns are added."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    * Test basic lcms Max pattern"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"d0f46d97_f5733055","line":10,"range":{"start_line":10,"start_character":4,"end_line":10,"end_character":5},"updated":"2023-03-06 04:06:32.000000000","message":"Could you please add (StandardUserData) here?\n`individual vnfc mgmt (StandardUserData) to make`","commit_id":"873f927585c6aba5c634df3e99e9e8f18b1595b7"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"f19e5ec3c81954db706cbc026364ed9a58b20ce0","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Extend FT tests for Individual Vnfc Mgmt"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch extends the FT test items related to individual vnfc"},{"line_number":10,"context_line":"mgmt to make the test coverage of this function more comprehensive."},{"line_number":11,"context_line":"The following seven patterns are added."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    * Test basic lcms Max pattern"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"5145fb01_ead993cf","line":10,"range":{"start_line":10,"start_character":4,"end_line":10,"end_character":5},"in_reply_to":"7d0b7beb_a16c6bfc","updated":"2023-04-05 08:17:27.000000000","message":"Done","commit_id":"873f927585c6aba5c634df3e99e9e8f18b1595b7"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"d55617e8836d80895ddeb621bc1abe32b0f71263","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Extend FT tests for Individual Vnfc Mgmt"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch extends the FT test items related to individual vnfc"},{"line_number":10,"context_line":"mgmt to make the test coverage of this function more comprehensive."},{"line_number":11,"context_line":"The following seven patterns are added."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    * Test basic lcms Max pattern"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"7d0b7beb_a16c6bfc","line":10,"range":{"start_line":10,"start_character":4,"end_line":10,"end_character":5},"in_reply_to":"d0f46d97_f5733055","updated":"2023-03-07 03:07:09.000000000","message":"I fixed it in PS17.","commit_id":"873f927585c6aba5c634df3e99e9e8f18b1595b7"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"7eee81198d7cdd08a62dbc1aa84c1f65af2a6e3d","unresolved":true,"context_lines":[{"line_number":10,"context_line":"mgmt to make the test coverage of this function more comprehensive."},{"line_number":11,"context_line":"The following seven patterns are added."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    * Test basic lcms Max pattern"},{"line_number":14,"context_line":"    * Test basic lcms Min pattern"},{"line_number":15,"context_line":"    * Test retry/rollback scale out"},{"line_number":16,"context_line":"    * Test rollback instantiate"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"401f652e_1cd04a61","line":13,"range":{"start_line":13,"start_character":17,"end_line":13,"end_character":21},"updated":"2023-03-06 04:06:32.000000000","message":"nits: LCMs","commit_id":"873f927585c6aba5c634df3e99e9e8f18b1595b7"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"f19e5ec3c81954db706cbc026364ed9a58b20ce0","unresolved":false,"context_lines":[{"line_number":10,"context_line":"mgmt to make the test coverage of this function more comprehensive."},{"line_number":11,"context_line":"The following seven patterns are added."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    * Test basic lcms Max pattern"},{"line_number":14,"context_line":"    * Test basic lcms Min pattern"},{"line_number":15,"context_line":"    * Test retry/rollback scale out"},{"line_number":16,"context_line":"    * Test rollback instantiate"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"87d66828_8c35acf2","line":13,"range":{"start_line":13,"start_character":17,"end_line":13,"end_character":21},"in_reply_to":"0e91446e_d198c2b5","updated":"2023-04-05 08:17:27.000000000","message":"Done","commit_id":"873f927585c6aba5c634df3e99e9e8f18b1595b7"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"d55617e8836d80895ddeb621bc1abe32b0f71263","unresolved":true,"context_lines":[{"line_number":10,"context_line":"mgmt to make the test coverage of this function more comprehensive."},{"line_number":11,"context_line":"The following seven patterns are added."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    * Test basic lcms Max pattern"},{"line_number":14,"context_line":"    * Test basic lcms Min pattern"},{"line_number":15,"context_line":"    * Test retry/rollback scale out"},{"line_number":16,"context_line":"    * Test rollback instantiate"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"0e91446e_d198c2b5","line":13,"range":{"start_line":13,"start_character":17,"end_line":13,"end_character":21},"in_reply_to":"401f652e_1cd04a61","updated":"2023-03-07 03:07:09.000000000","message":"I fixed it in PS17.","commit_id":"873f927585c6aba5c634df3e99e9e8f18b1595b7"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"7eee81198d7cdd08a62dbc1aa84c1f65af2a6e3d","unresolved":true,"context_lines":[{"line_number":11,"context_line":"The following seven patterns are added."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    * Test basic lcms Max pattern"},{"line_number":14,"context_line":"    * Test basic lcms Min pattern"},{"line_number":15,"context_line":"    * Test retry/rollback scale out"},{"line_number":16,"context_line":"    * Test rollback instantiate"},{"line_number":17,"context_line":"    * Test rollback change external VNF connectivity and update VNF"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"78476d98_b3550d79","line":14,"range":{"start_line":14,"start_character":17,"end_line":14,"end_character":21},"updated":"2023-03-06 04:06:32.000000000","message":"nits: LCMs","commit_id":"873f927585c6aba5c634df3e99e9e8f18b1595b7"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"f19e5ec3c81954db706cbc026364ed9a58b20ce0","unresolved":false,"context_lines":[{"line_number":11,"context_line":"The following seven patterns are added."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    * Test basic lcms Max pattern"},{"line_number":14,"context_line":"    * Test basic lcms Min pattern"},{"line_number":15,"context_line":"    * Test retry/rollback scale out"},{"line_number":16,"context_line":"    * Test rollback instantiate"},{"line_number":17,"context_line":"    * Test rollback change external VNF connectivity and update VNF"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"30ff95dc_d78f3f66","line":14,"range":{"start_line":14,"start_character":17,"end_line":14,"end_character":21},"in_reply_to":"03bcd1f6_de444637","updated":"2023-04-05 08:17:27.000000000","message":"Done","commit_id":"873f927585c6aba5c634df3e99e9e8f18b1595b7"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"d55617e8836d80895ddeb621bc1abe32b0f71263","unresolved":true,"context_lines":[{"line_number":11,"context_line":"The following seven patterns are added."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    * Test basic lcms Max pattern"},{"line_number":14,"context_line":"    * Test basic lcms Min pattern"},{"line_number":15,"context_line":"    * Test retry/rollback scale out"},{"line_number":16,"context_line":"    * Test rollback instantiate"},{"line_number":17,"context_line":"    * Test rollback change external VNF connectivity and update VNF"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"03bcd1f6_de444637","line":14,"range":{"start_line":14,"start_character":17,"end_line":14,"end_character":21},"in_reply_to":"78476d98_b3550d79","updated":"2023-03-07 03:07:09.000000000","message":"ditto","commit_id":"873f927585c6aba5c634df3e99e9e8f18b1595b7"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"7eee81198d7cdd08a62dbc1aa84c1f65af2a6e3d","unresolved":true,"context_lines":[{"line_number":16,"context_line":"    * Test rollback instantiate"},{"line_number":17,"context_line":"    * Test rollback change external VNF connectivity and update VNF"},{"line_number":18,"context_line":"    * Test rollback change current VNF Package"},{"line_number":19,"context_line":"    * Test various lcm operations before/after"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Implements: blueprint individual-vnfc-management"},{"line_number":22,"context_line":"Change-Id: I0da080418a1f1de803b950a9d0c8676e833a1f3e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"b38b0f4d_bd1515b3","line":19,"range":{"start_line":19,"start_character":19,"end_line":19,"end_character":22},"updated":"2023-03-06 04:06:32.000000000","message":"nits: lcm -\u003e LCM","commit_id":"873f927585c6aba5c634df3e99e9e8f18b1595b7"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"d55617e8836d80895ddeb621bc1abe32b0f71263","unresolved":true,"context_lines":[{"line_number":16,"context_line":"    * Test rollback instantiate"},{"line_number":17,"context_line":"    * Test rollback change external VNF connectivity and update VNF"},{"line_number":18,"context_line":"    * Test rollback change current VNF Package"},{"line_number":19,"context_line":"    * Test various lcm operations before/after"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Implements: blueprint individual-vnfc-management"},{"line_number":22,"context_line":"Change-Id: I0da080418a1f1de803b950a9d0c8676e833a1f3e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"e4404091_8795365b","line":19,"range":{"start_line":19,"start_character":19,"end_line":19,"end_character":22},"in_reply_to":"b38b0f4d_bd1515b3","updated":"2023-03-07 03:07:09.000000000","message":"ditto","commit_id":"873f927585c6aba5c634df3e99e9e8f18b1595b7"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"f19e5ec3c81954db706cbc026364ed9a58b20ce0","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    * Test rollback instantiate"},{"line_number":17,"context_line":"    * Test rollback change external VNF connectivity and update VNF"},{"line_number":18,"context_line":"    * Test rollback change current VNF Package"},{"line_number":19,"context_line":"    * Test various lcm operations before/after"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Implements: blueprint individual-vnfc-management"},{"line_number":22,"context_line":"Change-Id: I0da080418a1f1de803b950a9d0c8676e833a1f3e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"0d4ff494_93a7e5f1","line":19,"range":{"start_line":19,"start_character":19,"end_line":19,"end_character":22},"in_reply_to":"e4404091_8795365b","updated":"2023-04-05 08:17:27.000000000","message":"Done","commit_id":"873f927585c6aba5c634df3e99e9e8f18b1595b7"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"65d93aa2141f41cfc6e7c812581ce0317f1035ac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7b56b82f_f0e1a597","updated":"2023-02-22 06:08:08.000000000","message":"Thank you for your comment.\nI answered this question.\nPlease check it again.","commit_id":"41554135599574540113f4008f640beb97c699e0"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"0b9b03c7908183209cf896017dec6fb1eb1c5283","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"395e0a0d_b5401724","updated":"2023-02-21 14:36:47.000000000","message":"Thanks for your patch, please kindly find my comment.","commit_id":"41554135599574540113f4008f640beb97c699e0"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"d91956bcd9192e95e1cb1a621d87a0286954880c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"49faccfa_09039aff","updated":"2023-03-02 08:18:53.000000000","message":"I modified this patch according to the latest discussion result.\nPlease check it again in PS8.","commit_id":"8a3eef52dc01eba50ecf147b3874b6069f750892"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"04fcc3655dd8ea9a2ba096809ffe2b095aae8d7c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"b86b87fc_447fd1cc","updated":"2023-03-03 01:29:22.000000000","message":"Thank you for your comments.\nI fixed them in PS10.\nPleas kindly check them again.","commit_id":"bae10ade5a2b743c0b0776daea2eb06769ab5c37"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"b479a27b4a9e9438364f41c3c7468798d85351f2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"200796af_3e2fc66a","updated":"2023-03-06 00:27:01.000000000","message":"recheck - infra failure","commit_id":"873f927585c6aba5c634df3e99e9e8f18b1595b7"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"7eee81198d7cdd08a62dbc1aa84c1f65af2a6e3d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"c97f381f_9c096130","updated":"2023-03-06 04:06:32.000000000","message":"Thank you for the patch. Please kindly check my comments.","commit_id":"acda363b4b1b4b0a69fd955c12e496e6c644aa48"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"4992cc1edadf22c8ec276afd205b261efe35e452","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"6f4d807f_1cf9116a","updated":"2023-03-07 00:35:29.000000000","message":"recheck - sol-v2 infra failure","commit_id":"6ff2f4c756f954ca20adba0a9d2b10fd02989031"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"652a4f7405468fafc989c63f1c27a7fcebef60a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"94cb870b_34f29fd2","updated":"2023-03-06 10:54:26.000000000","message":"recheck - sol-v2 time out","commit_id":"6ff2f4c756f954ca20adba0a9d2b10fd02989031"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"d55617e8836d80895ddeb621bc1abe32b0f71263","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"1c255d80_45f4ddcd","updated":"2023-03-07 03:07:09.000000000","message":"Thank you for your comments.\nI fixed them in PS17,PS18.\nPlease kindly check them again.","commit_id":"efcc00e64f815d780119ef7adb179723a58e32f6"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"32ba83d2bbbc5ef3837ffaf9195d953ece0b5d89","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"3e62efce_7fb8dc35","updated":"2023-03-08 04:59:21.000000000","message":"Thank you for your new comments.\nI fixed them in latest PS.\nPlease kindly check them again.","commit_id":"a9e18ba275d3dfce39721c64d90e9a930e375f0d"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"c13b4416b761b31c0b069c3cede57b77614b365c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"c9e79c81_597f2e61","updated":"2023-03-08 03:46:10.000000000","message":"recheck - sol-kubernetes infra-failure\n        - sol-v2-ubuntu-focal time out","commit_id":"a9e18ba275d3dfce39721c64d90e9a930e375f0d"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"352a09f52e3a2b3b8f937ecbe213d6868951a24f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"ce689b11_3e7a70aa","updated":"2023-03-08 00:28:42.000000000","message":"recheck - sol-v2 infra failure\ntacker.sol_refactored.common.exceptions.StackOperationFailed: Resource CREATE failed: BadRequest: resources.VDU1_scale_group.resources.jk4a5gztjkvq.resources.VDU1: Port fee5f91b-cffd-43f8-9f97-a1d5fd379e2e requires a FixedIP in order to be used. (HTTP 400) (Request-ID: req-f2f38a3f-6433-4237-b2d7-668aed65f9c6)","commit_id":"a9e18ba275d3dfce39721c64d90e9a930e375f0d"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"2da4b2b79ef2fa5b72194729a4297df0571cc82c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"93dba557_55264c9e","updated":"2023-03-08 08:30:53.000000000","message":"recheck - tox error","commit_id":"a9e18ba275d3dfce39721c64d90e9a930e375f0d"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"2d79736e04f9d6c80b298dbdb53c862983f82eac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"31882254_3c9ae0c5","updated":"2023-03-08 22:43:09.000000000","message":"recheck - infra failure","commit_id":"db7592dfc9a0c7b8e84cfdb39306102cd6a7dc84"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b03bd0c9ab6a803ec8623fe38e1e37ef70aa7dd2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"0db3a4e0_69f62400","updated":"2023-03-10 06:06:22.000000000","message":"Thanks for your continuous work, please find my comments. ","commit_id":"0ee7a54c759b3b0772ac1b227e9b6fc54346ba90"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"b94da400bb968821d20052466de353d841130286","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":31,"id":"27eb50de_16abc450","updated":"2023-03-10 06:26:36.000000000","message":"Thank you for you comment.\nI fixed it in PS31.\nPlease kindly check it again.","commit_id":"1fcc9b222ed88b6a4ca5860c379ffcf15414e258"},{"author":{"_account_id":31668},"change_message_id":"7d7c9db679e6e9e88f919368404cb615e4a56383","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":32,"id":"646f7801_8e258dfe","updated":"2023-03-10 09:43:36.000000000","message":"Thank you for the fix！","commit_id":"8b3c90da45827a66cc83b1a4c3ac0c8e543811e9"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"f048e7704eb5c256bfe4498a5cdddb65e220474c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":32,"id":"ba2868a9_83e3b331","updated":"2023-03-10 07:52:35.000000000","message":"Thank you for your comments.\nI fixed them in PS32.\nPlease kindly check them again.","commit_id":"8b3c90da45827a66cc83b1a4c3ac0c8e543811e9"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"c6bbffd1eeb9e4ed3b833c6536550c00a39e463f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":32,"id":"d4d085b2_249d3c67","updated":"2023-03-14 02:55:20.000000000","message":"Thanks for your great re-work. Unfortunately, this patch has moved the target to the next Bobcat due to lack of reviews..\nWe will restart our review soon, so please wait for a while, thanks.","commit_id":"8b3c90da45827a66cc83b1a4c3ac0c8e543811e9"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"040796c7352f0e4ac2794dcaa7a80c9ad63dcd30","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":34,"id":"4cce70b4_fa76b742","updated":"2023-03-27 06:13:15.000000000","message":"To Ai Hamano:\nThank you for your comments.\nI fixed them in PS34.\nPlease kindly check them again.","commit_id":"7cf70ac342921e604f446cf6414705572f2b10f5"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"4a102c41b54cdce09fe076165fe8cc75eeaa7570","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":34,"id":"7a77b417_4912b43d","updated":"2023-03-24 04:34:33.000000000","message":"recheck - infra failure","commit_id":"7cf70ac342921e604f446cf6414705572f2b10f5"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"8a6c1adc8bd75d0ae65dd2c08dd027a7afd72834","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":34,"id":"8030d8d1_c193307f","updated":"2023-03-27 01:57:15.000000000","message":"recheck - infra failure","commit_id":"7cf70ac342921e604f446cf6414705572f2b10f5"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"33224d71181f8387cc93956d49714ef460927b1a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":34,"id":"c6d6468a_cf64c338","updated":"2023-03-24 07:13:43.000000000","message":"recheck - infra failure","commit_id":"7cf70ac342921e604f446cf6414705572f2b10f5"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"878d3176b1efb13b1e3dea24e56f20ccebdf0ece","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":37,"id":"d36b273d_fb565f88","updated":"2023-04-03 08:46:10.000000000","message":"Thank you for your detailed comment.\nI fixed them in PS37.\nPlease kindly check them again.","commit_id":"e6db6a662a5fd52ecabea4b834a5c2013d8d95e1"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"f19e5ec3c81954db706cbc026364ed9a58b20ce0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":37,"id":"88f5a22c_1b3c7adb","updated":"2023-04-05 08:17:27.000000000","message":"Thanks for your re-work and sorry for my late review. Please kindly check my comments.","commit_id":"e6db6a662a5fd52ecabea4b834a5c2013d8d95e1"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"2af3376165484707348a813352ffd66391542d9e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":39,"id":"fa4c7edc_74fafce0","updated":"2023-04-10 05:36:03.000000000","message":"Thank you for your comments. I fixed them in PS39.\nPlease kindly check them again.","commit_id":"d33035a4e24da0e0be9771c0ab10784a4fe56e2e"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"d3681bf4f43b84418266298f452e31b00679f1fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":39,"id":"76524cd8_dae574ad","updated":"2023-04-10 05:36:31.000000000","message":"recheck - infra failure","commit_id":"d33035a4e24da0e0be9771c0ab10784a4fe56e2e"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"9b79d3962734baafda9c42b7df33a7730784bfa5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":41,"id":"2a3026fb_c02efaee","updated":"2023-04-13 02:42:00.000000000","message":"Thanks for your great re-work!","commit_id":"108e8953dbc98ea24d3130aeedb02e5e8b72fbc7"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"8a07c3e805cdfa32a9498248bd09d78fbafd5137","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":41,"id":"31ce9810_43b66254","updated":"2023-04-13 05:41:36.000000000","message":"recheck - infra failure","commit_id":"108e8953dbc98ea24d3130aeedb02e5e8b72fbc7"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"6d581d963f0dc8da8293e93f03741f73f8e54d52","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":41,"id":"775f1b6e_4333df14","updated":"2023-04-12 09:11:17.000000000","message":"recheck - infra failure","commit_id":"108e8953dbc98ea24d3130aeedb02e5e8b72fbc7"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"434cc0312daefe9fad6d887be8268d6d924328a5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":41,"id":"8187eca9_14db33ce","updated":"2023-04-13 00:31:59.000000000","message":"recheck - infra failure","commit_id":"108e8953dbc98ea24d3130aeedb02e5e8b72fbc7"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"87ada88f2d9bfb9f1378fc39bab9a09aa6d329f2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":42,"id":"ca7aaa71_7800f91e","updated":"2023-04-17 01:48:45.000000000","message":"Thank you for your comments.\nI fixed them in PS42.\nPlease kindly check them again.","commit_id":"af2c56764f9c8c256e9f2d75a43d461fab13e4d4"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"88548870bdeae44cf82f25cb0a9108729bb72ca2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":42,"id":"ee79a48e_b92ed79b","updated":"2023-04-17 12:54:23.000000000","message":"Thanks for your patch. Please find a comment.","commit_id":"af2c56764f9c8c256e9f2d75a43d461fab13e4d4"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"e46c813f34fcdf56668997626e85f6139b318c55","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":43,"id":"49cf790e_51e0bd96","updated":"2023-04-19 00:37:49.000000000","message":"recheck - infra failure","commit_id":"9f56bec5fde32d8d310aa897b48fa6e2cef7bc77"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"ffc9b963b0ff515a45ae887b23911f3d54a9c11c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":43,"id":"5e339d10_48ec1abb","updated":"2023-04-19 04:42:46.000000000","message":"recheck - infra failure","commit_id":"9f56bec5fde32d8d310aa897b48fa6e2cef7bc77"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"dcd867fd34a1cbc2f37a3af5c06ebab2b2945642","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":44,"id":"5566aa91_eef48117","updated":"2023-04-20 07:57:27.000000000","message":"recheck - infra failure","commit_id":"66737bbd9ab62455191a3a5354e88d1801f68708"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"4c0480aae2dbd3bc5f71a78dfd927a365ddf0fea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":44,"id":"8e24ab81_abe3d94c","updated":"2023-04-20 04:36:05.000000000","message":"recheck - infra failure","commit_id":"66737bbd9ab62455191a3a5354e88d1801f68708"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"1496b7c6b377c418db63e3d893894f0bd95050b7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":45,"id":"8d6d0a99_ffa16feb","updated":"2023-04-27 11:25:08.000000000","message":"recheck - FT(tacker-functional-devstack-enhanced-policy-sol) timed out","commit_id":"6c40c4d3fc33cf236e8c92845a0bb002869c0066"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"c3c7cd93097f719a29d84afdd29adb9d8ad78592","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":45,"id":"12a675fd_c5856f71","updated":"2023-04-28 00:26:29.000000000","message":"recheck - heat error (tacker.sol_refactored.common.exceptions.StackOperationFailed: Resource CREATE failed: BadRequest: resources.VDU1-0.resources.VDU1: Port c2fe73c1-06f4-4991-bd7d-1758888ee237 requires a FixedIP in order to be used. (HTTP 400))","commit_id":"6c40c4d3fc33cf236e8c92845a0bb002869c0066"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"de8a2633190173a9ebd9ae36103de8a25db3e6cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":45,"id":"0428904c_06f286bd","updated":"2023-04-27 00:24:09.000000000","message":"recheck - infra failure","commit_id":"6c40c4d3fc33cf236e8c92845a0bb002869c0066"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"bfd0c626fa458396d0cfe8417493fb4ea1c70516","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":45,"id":"222f66a6_b1d5cd35","updated":"2023-04-27 05:35:43.000000000","message":"recheck - infra failure","commit_id":"6c40c4d3fc33cf236e8c92845a0bb002869c0066"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"91933b71554ef9a8922494a3ae7ebff0442a97f0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":45,"id":"73dac580_f3632302","updated":"2023-04-27 03:04:37.000000000","message":"recheck - infra failure","commit_id":"6c40c4d3fc33cf236e8c92845a0bb002869c0066"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"aac94b4d4cf16f25e862b1a225ee28f35839876b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":45,"id":"a18cbdf1_224c64b9","updated":"2023-04-24 00:25:35.000000000","message":"recheck - infra failure","commit_id":"6c40c4d3fc33cf236e8c92845a0bb002869c0066"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"fb7f3e21b0cd116ba83e2b09f937b63aad21885a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":45,"id":"fefdbe1b_b3b043d9","updated":"2023-04-26 07:43:11.000000000","message":"recheck - infra failure","commit_id":"6c40c4d3fc33cf236e8c92845a0bb002869c0066"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"066482a0eab8a4cae92ec2e4af6e75666556f5d9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":45,"id":"307a62bd_15e4abd6","updated":"2023-04-26 00:41:46.000000000","message":"recheck - retry limit error","commit_id":"6c40c4d3fc33cf236e8c92845a0bb002869c0066"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"dd949d37daa72c7aac74db8cde98f9b4d6541b49","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":45,"id":"bf50cc14_536ad3eb","updated":"2023-04-25 08:22:16.000000000","message":"recheck - retry limit error","commit_id":"6c40c4d3fc33cf236e8c92845a0bb002869c0066"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"9fe739019d59d9a7993f8134e0276bc92f583652","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":45,"id":"c1e37ed7_61faade8","updated":"2023-04-24 04:34:28.000000000","message":"recheck - retry limit error","commit_id":"6c40c4d3fc33cf236e8c92845a0bb002869c0066"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"4eef555344146228e7d73b97dde6db7a92ee0754","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":45,"id":"56cafb1e_32c706ae","updated":"2023-04-28 02:53:14.000000000","message":"recheck - sol-v2 heat error - Resource CREATE failed: IpAddressAlreadyAllocatedClient: resources.VDU2_CP2: IP address 100.100.100.11 already allocated in subnet 7571783a-03ed-4143-b708-1716c5eee440","commit_id":"6c40c4d3fc33cf236e8c92845a0bb002869c0066"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"8a9df843948600460518da46b2cde2b152537ad6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":46,"id":"c47e89f7_a52a474d","updated":"2023-04-28 04:39:58.000000000","message":"Thank you for your comments. I fixed them in PS46.\nPlease kindly check them again.","commit_id":"7b7913658cc796d78226796404881d0bee6a5cef"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"bd4f48ee64df55c28eae8c9d6a8ea396192f46c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":46,"id":"8bc48fb5_708de967","updated":"2023-05-05 09:03:16.000000000","message":"Thanks for rework. LGTM!","commit_id":"7b7913658cc796d78226796404881d0bee6a5cef"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"c5ab8f0d040b29574eeecc082af8cb88a2b5951b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":46,"id":"ba09ec98_cbf1318d","updated":"2023-05-09 00:09:27.000000000","message":"Thanks for your great work!LGTM","commit_id":"7b7913658cc796d78226796404881d0bee6a5cef"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"70588e0aeb91af2050b17f3baa5169bad7e95c05","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":46,"id":"c495b4a5_2a707b77","updated":"2023-05-05 01:37:24.000000000","message":"recheck - infra failure","commit_id":"7b7913658cc796d78226796404881d0bee6a5cef"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"49755b46982842597d06c4cf676f77f83da8f721","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":46,"id":"9314b9fe_867b946f","updated":"2023-05-05 04:32:49.000000000","message":"recheck - sol-kubernetes infra failure","commit_id":"7b7913658cc796d78226796404881d0bee6a5cef"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"f3244ac785d8eccd1fd9463b95d9e8fa8850ef2d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":46,"id":"f8dbb217_fe0ca118","updated":"2023-04-28 07:22:02.000000000","message":"recheck - tacker-functional-devstack-multinode-sol infra failure","commit_id":"7b7913658cc796d78226796404881d0bee6a5cef"}],"tacker/tests/functional/sol_v2/test_individual_vnfc_mgmt_basic.py":[{"author":{"_account_id":31668},"change_message_id":"7a80155badbd39e63b238399dd9b322616cc0849","unresolved":true,"context_lines":[{"line_number":331,"context_line":"          - 28. Show VNF instance(check for change-vnfpkg)"},{"line_number":332,"context_line":"          - 29. Terminate VNF"},{"line_number":333,"context_line":"        \"\"\""},{"line_number":334,"context_line":"        # 1. Instantiate VNF instance"},{"line_number":335,"context_line":"        instantiate_req \u003d paramgen.instantiate_vnf_max("},{"line_number":336,"context_line":"            self.net_ids, self.subnet_ids, None, self.auth_url,"},{"line_number":337,"context_line":"            user_data\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":9,"id":"849f5021_003fcd11","line":334,"updated":"2023-03-03 01:04:01.000000000","message":"It is better to match the description with L.303.\n* Instantiate VNF instance -\u003e Instantiate VNF","commit_id":"feed9c78524aefbdd74cea7d38e9cbc91eaa8223"},{"author":{"_account_id":31668},"change_message_id":"75d4d5da6db5660184c1e89fbd1440126063e695","unresolved":false,"context_lines":[{"line_number":331,"context_line":"          - 28. Show VNF instance(check for change-vnfpkg)"},{"line_number":332,"context_line":"          - 29. Terminate VNF"},{"line_number":333,"context_line":"        \"\"\""},{"line_number":334,"context_line":"        # 1. Instantiate VNF instance"},{"line_number":335,"context_line":"        instantiate_req \u003d paramgen.instantiate_vnf_max("},{"line_number":336,"context_line":"            self.net_ids, self.subnet_ids, None, self.auth_url,"},{"line_number":337,"context_line":"            user_data\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":9,"id":"dee22de0_43dfc423","line":334,"in_reply_to":"6bdc9b8e_6fa7f5ea","updated":"2023-03-07 01:54:46.000000000","message":"Done","commit_id":"feed9c78524aefbdd74cea7d38e9cbc91eaa8223"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"04fcc3655dd8ea9a2ba096809ffe2b095aae8d7c","unresolved":true,"context_lines":[{"line_number":331,"context_line":"          - 28. Show VNF instance(check for change-vnfpkg)"},{"line_number":332,"context_line":"          - 29. Terminate VNF"},{"line_number":333,"context_line":"        \"\"\""},{"line_number":334,"context_line":"        # 1. Instantiate VNF instance"},{"line_number":335,"context_line":"        instantiate_req \u003d paramgen.instantiate_vnf_max("},{"line_number":336,"context_line":"            self.net_ids, self.subnet_ids, None, self.auth_url,"},{"line_number":337,"context_line":"            user_data\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":9,"id":"6bdc9b8e_6fa7f5ea","line":334,"in_reply_to":"849f5021_003fcd11","updated":"2023-03-03 01:29:22.000000000","message":"I fixed it in PS10.","commit_id":"feed9c78524aefbdd74cea7d38e9cbc91eaa8223"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"7eee81198d7cdd08a62dbc1aa84c1f65af2a6e3d","unresolved":true,"context_lines":[{"line_number":2342,"context_line":"        self.assertEqual(fields.VnfInstanceState.NOT_INSTANTIATED,"},{"line_number":2343,"context_line":"                         body[\u0027instantiationState\u0027])"},{"line_number":2344,"context_line":""},{"line_number":2345,"context_line":"        # Multiple test items share this vnf instance. Therefore, you need to"},{"line_number":2346,"context_line":"        # restore the vnfdId to the original one after the test ends."},{"line_number":2347,"context_line":"        update_req \u003d paramgen.update_vnf_min_with_parameter(self.vnfd_id_1)"},{"line_number":2348,"context_line":"        resp, body \u003d self.update_vnf_instance(self.inst_id_1, update_req)"}],"source_content_type":"text/x-python","patch_set":14,"id":"3d7dba10_a54c03db","line":2345,"range":{"start_line":2345,"start_character":41,"end_line":2345,"end_character":44},"updated":"2023-03-06 04:06:32.000000000","message":"nits: vnf -\u003e VNF","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"d55617e8836d80895ddeb621bc1abe32b0f71263","unresolved":true,"context_lines":[{"line_number":2342,"context_line":"        self.assertEqual(fields.VnfInstanceState.NOT_INSTANTIATED,"},{"line_number":2343,"context_line":"                         body[\u0027instantiationState\u0027])"},{"line_number":2344,"context_line":""},{"line_number":2345,"context_line":"        # Multiple test items share this vnf instance. Therefore, you need to"},{"line_number":2346,"context_line":"        # restore the vnfdId to the original one after the test ends."},{"line_number":2347,"context_line":"        update_req \u003d paramgen.update_vnf_min_with_parameter(self.vnfd_id_1)"},{"line_number":2348,"context_line":"        resp, body \u003d self.update_vnf_instance(self.inst_id_1, update_req)"}],"source_content_type":"text/x-python","patch_set":14,"id":"ffb9fd78_be82bf90","line":2345,"range":{"start_line":2345,"start_character":41,"end_line":2345,"end_character":44},"in_reply_to":"3d7dba10_a54c03db","updated":"2023-03-07 03:07:09.000000000","message":"I fixed it in PS17.","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"f19e5ec3c81954db706cbc026364ed9a58b20ce0","unresolved":false,"context_lines":[{"line_number":2342,"context_line":"        self.assertEqual(fields.VnfInstanceState.NOT_INSTANTIATED,"},{"line_number":2343,"context_line":"                         body[\u0027instantiationState\u0027])"},{"line_number":2344,"context_line":""},{"line_number":2345,"context_line":"        # Multiple test items share this vnf instance. Therefore, you need to"},{"line_number":2346,"context_line":"        # restore the vnfdId to the original one after the test ends."},{"line_number":2347,"context_line":"        update_req \u003d paramgen.update_vnf_min_with_parameter(self.vnfd_id_1)"},{"line_number":2348,"context_line":"        resp, body \u003d self.update_vnf_instance(self.inst_id_1, update_req)"}],"source_content_type":"text/x-python","patch_set":14,"id":"b14d6ef3_35701aeb","line":2345,"range":{"start_line":2345,"start_character":41,"end_line":2345,"end_character":44},"in_reply_to":"ffb9fd78_be82bf90","updated":"2023-04-05 08:17:27.000000000","message":"Done","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"}],"tacker/tests/functional/sol_v2_common/base_v2.py":[{"author":{"_account_id":31668},"change_message_id":"7a80155badbd39e63b238399dd9b322616cc0849","unresolved":true,"context_lines":[{"line_number":551,"context_line":"        self._check_resp_headers(resp, supported_headers)"},{"line_number":552,"context_line":""},{"line_number":553,"context_line":"    def check_resp_headers_in_get(self, resp):"},{"line_number":554,"context_line":"        # includes response body and no location header"},{"line_number":555,"context_line":"        supported_headers \u003d [\u0027Version\u0027, \u0027Content-Type\u0027,"},{"line_number":556,"context_line":"                             \u0027Accept-Ranges\u0027]"},{"line_number":557,"context_line":"        self._check_resp_headers(resp, supported_headers)"}],"source_content_type":"text/x-python","patch_set":9,"id":"9432fbd7_37e48657","line":554,"updated":"2023-03-03 01:04:01.000000000","message":"nit: includes response body -\u003e includes a single data in response body","commit_id":"feed9c78524aefbdd74cea7d38e9cbc91eaa8223"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"04fcc3655dd8ea9a2ba096809ffe2b095aae8d7c","unresolved":true,"context_lines":[{"line_number":551,"context_line":"        self._check_resp_headers(resp, supported_headers)"},{"line_number":552,"context_line":""},{"line_number":553,"context_line":"    def check_resp_headers_in_get(self, resp):"},{"line_number":554,"context_line":"        # includes response body and no location header"},{"line_number":555,"context_line":"        supported_headers \u003d [\u0027Version\u0027, \u0027Content-Type\u0027,"},{"line_number":556,"context_line":"                             \u0027Accept-Ranges\u0027]"},{"line_number":557,"context_line":"        self._check_resp_headers(resp, supported_headers)"}],"source_content_type":"text/x-python","patch_set":9,"id":"f22b6bb5_9761308b","line":554,"in_reply_to":"9432fbd7_37e48657","updated":"2023-03-03 01:29:22.000000000","message":"I fixed it in PS10.","commit_id":"feed9c78524aefbdd74cea7d38e9cbc91eaa8223"},{"author":{"_account_id":31668},"change_message_id":"75d4d5da6db5660184c1e89fbd1440126063e695","unresolved":false,"context_lines":[{"line_number":551,"context_line":"        self._check_resp_headers(resp, supported_headers)"},{"line_number":552,"context_line":""},{"line_number":553,"context_line":"    def check_resp_headers_in_get(self, resp):"},{"line_number":554,"context_line":"        # includes response body and no location header"},{"line_number":555,"context_line":"        supported_headers \u003d [\u0027Version\u0027, \u0027Content-Type\u0027,"},{"line_number":556,"context_line":"                             \u0027Accept-Ranges\u0027]"},{"line_number":557,"context_line":"        self._check_resp_headers(resp, supported_headers)"}],"source_content_type":"text/x-python","patch_set":9,"id":"bf1b7ef4_cc2281a7","line":554,"in_reply_to":"f22b6bb5_9761308b","updated":"2023-03-07 01:54:46.000000000","message":"Done","commit_id":"feed9c78524aefbdd74cea7d38e9cbc91eaa8223"},{"author":{"_account_id":31668},"change_message_id":"7a80155badbd39e63b238399dd9b322616cc0849","unresolved":true,"context_lines":[{"line_number":557,"context_line":"        self._check_resp_headers(resp, supported_headers)"},{"line_number":558,"context_line":""},{"line_number":559,"context_line":"    def check_resp_headers_in_index(self, resp):"},{"line_number":560,"context_line":"        # includes response body and no location header"},{"line_number":561,"context_line":"        supported_headers \u003d [\u0027Version\u0027, \u0027Content-Type\u0027,"},{"line_number":562,"context_line":"                             \u0027Accept-Ranges\u0027, \u0027Link\u0027]"},{"line_number":563,"context_line":"        self._check_resp_headers(resp, supported_headers)"}],"source_content_type":"text/x-python","patch_set":9,"id":"1cd9e1d1_77687762","line":560,"updated":"2023-03-03 01:04:01.000000000","message":"nit: includes response body -\u003e includes some data in response body","commit_id":"feed9c78524aefbdd74cea7d38e9cbc91eaa8223"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"04fcc3655dd8ea9a2ba096809ffe2b095aae8d7c","unresolved":true,"context_lines":[{"line_number":557,"context_line":"        self._check_resp_headers(resp, supported_headers)"},{"line_number":558,"context_line":""},{"line_number":559,"context_line":"    def check_resp_headers_in_index(self, resp):"},{"line_number":560,"context_line":"        # includes response body and no location header"},{"line_number":561,"context_line":"        supported_headers \u003d [\u0027Version\u0027, \u0027Content-Type\u0027,"},{"line_number":562,"context_line":"                             \u0027Accept-Ranges\u0027, \u0027Link\u0027]"},{"line_number":563,"context_line":"        self._check_resp_headers(resp, supported_headers)"}],"source_content_type":"text/x-python","patch_set":9,"id":"c0e2541c_963b63fb","line":560,"in_reply_to":"1cd9e1d1_77687762","updated":"2023-03-03 01:29:22.000000000","message":"I fixed it in PS10.","commit_id":"feed9c78524aefbdd74cea7d38e9cbc91eaa8223"},{"author":{"_account_id":31668},"change_message_id":"75d4d5da6db5660184c1e89fbd1440126063e695","unresolved":false,"context_lines":[{"line_number":557,"context_line":"        self._check_resp_headers(resp, supported_headers)"},{"line_number":558,"context_line":""},{"line_number":559,"context_line":"    def check_resp_headers_in_index(self, resp):"},{"line_number":560,"context_line":"        # includes response body and no location header"},{"line_number":561,"context_line":"        supported_headers \u003d [\u0027Version\u0027, \u0027Content-Type\u0027,"},{"line_number":562,"context_line":"                             \u0027Accept-Ranges\u0027, \u0027Link\u0027]"},{"line_number":563,"context_line":"        self._check_resp_headers(resp, supported_headers)"}],"source_content_type":"text/x-python","patch_set":9,"id":"5be9fe90_f9576be0","line":560,"in_reply_to":"c0e2541c_963b63fb","updated":"2023-03-07 01:54:46.000000000","message":"Done","commit_id":"feed9c78524aefbdd74cea7d38e9cbc91eaa8223"}],"tacker/tests/functional/sol_v2_common/paramgen.py":[{"author":{"_account_id":31668},"change_message_id":"ca231a1a1843f1cfabe76a1149f6ada7e897d70b","unresolved":true,"context_lines":[{"line_number":1670,"context_line":"                {"},{"line_number":1671,"context_line":"                    \"vdu_id\": \"VDU2\","},{"line_number":1672,"context_line":"                    \"old_vnfc_param\": {"},{"line_number":1673,"context_line":"                        \"cp_name\": \"VDU2_CP2\","},{"line_number":1674,"context_line":"                        \"username\": \"ubuntu\","},{"line_number":1675,"context_line":"                        \"password\": \"ubuntu\""},{"line_number":1676,"context_line":"                    },"}],"source_content_type":"text/x-python","patch_set":19,"id":"819063ac_fcdc7c64","line":1673,"updated":"2023-03-07 06:49:38.000000000","message":"Is it okay not to set \"VDU2_CP1\"?","commit_id":"72f65b96afd95b4c9e7f3529e7771b1a332d63f8"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"2af3376165484707348a813352ffd66391542d9e","unresolved":true,"context_lines":[{"line_number":1670,"context_line":"                {"},{"line_number":1671,"context_line":"                    \"vdu_id\": \"VDU2\","},{"line_number":1672,"context_line":"                    \"old_vnfc_param\": {"},{"line_number":1673,"context_line":"                        \"cp_name\": \"VDU2_CP2\","},{"line_number":1674,"context_line":"                        \"username\": \"ubuntu\","},{"line_number":1675,"context_line":"                        \"password\": \"ubuntu\""},{"line_number":1676,"context_line":"                    },"}],"source_content_type":"text/x-python","patch_set":19,"id":"2b5d5892_01cd8e16","line":1673,"in_reply_to":"019ca6ec_4fe446be","updated":"2023-04-10 05:36:03.000000000","message":"The request of max has been used in the third step. This is to test that when the request of min is used, the rollback operation can be successful even after failure.","commit_id":"72f65b96afd95b4c9e7f3529e7771b1a332d63f8"},{"author":{"_account_id":31668},"change_message_id":"4c5937e136c86b08773e33086dcb0e7988fa0cad","unresolved":false,"context_lines":[{"line_number":1670,"context_line":"                {"},{"line_number":1671,"context_line":"                    \"vdu_id\": \"VDU2\","},{"line_number":1672,"context_line":"                    \"old_vnfc_param\": {"},{"line_number":1673,"context_line":"                        \"cp_name\": \"VDU2_CP2\","},{"line_number":1674,"context_line":"                        \"username\": \"ubuntu\","},{"line_number":1675,"context_line":"                        \"password\": \"ubuntu\""},{"line_number":1676,"context_line":"                    },"}],"source_content_type":"text/x-python","patch_set":19,"id":"8761787b_94409fe5","line":1673,"in_reply_to":"2b5d5892_01cd8e16","updated":"2023-04-10 07:33:44.000000000","message":"Thank you for your explanation.\nI could understand your intention.","commit_id":"72f65b96afd95b4c9e7f3529e7771b1a332d63f8"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"32ba83d2bbbc5ef3837ffaf9195d953ece0b5d89","unresolved":true,"context_lines":[{"line_number":1670,"context_line":"                {"},{"line_number":1671,"context_line":"                    \"vdu_id\": \"VDU2\","},{"line_number":1672,"context_line":"                    \"old_vnfc_param\": {"},{"line_number":1673,"context_line":"                        \"cp_name\": \"VDU2_CP2\","},{"line_number":1674,"context_line":"                        \"username\": \"ubuntu\","},{"line_number":1675,"context_line":"                        \"password\": \"ubuntu\""},{"line_number":1676,"context_line":"                    },"}],"source_content_type":"text/x-python","patch_set":19,"id":"a539dc3f_3da0ab42","line":1673,"in_reply_to":"819063ac_fcdc7c64","updated":"2023-03-08 04:59:21.000000000","message":"In rollback_test, the old_vnf_package is basic_lcms_max_individual_vnfc, so the VDU2_CP1 does not exist, should use VDU2_CP2.\nI separated the rollback and basic_min tests in PS21.\nrollback will use VDU2_CP2, basic_min will use VDU2_CP1.","commit_id":"72f65b96afd95b4c9e7f3529e7771b1a332d63f8"},{"author":{"_account_id":31668},"change_message_id":"6c130455c201fba62834a757d693a170d3a19767","unresolved":true,"context_lines":[{"line_number":1670,"context_line":"                {"},{"line_number":1671,"context_line":"                    \"vdu_id\": \"VDU2\","},{"line_number":1672,"context_line":"                    \"old_vnfc_param\": {"},{"line_number":1673,"context_line":"                        \"cp_name\": \"VDU2_CP2\","},{"line_number":1674,"context_line":"                        \"username\": \"ubuntu\","},{"line_number":1675,"context_line":"                        \"password\": \"ubuntu\""},{"line_number":1676,"context_line":"                    },"}],"source_content_type":"text/x-python","patch_set":19,"id":"019ca6ec_4fe446be","line":1673,"in_reply_to":"a539dc3f_3da0ab42","updated":"2023-04-05 06:40:11.000000000","message":"Related to the comment below, I think it\u0027s better to use max pattern requests for rollback.\nhttps://review.opendev.org/c/openstack/tacker/+/873477/37/tacker/tests/functional/sol_v2_individual_vnfc_mgmt/test_individual_vnfc_mgmt_basic.py#1745","commit_id":"72f65b96afd95b4c9e7f3529e7771b1a332d63f8"}],"tacker/tests/functional/sol_v2_common/samples/basic_lcms_max_individual_vnfc/contents/BaseHOT/simple/nested/VDU1.yaml":[{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"7eee81198d7cdd08a62dbc1aa84c1f65af2a6e3d","unresolved":true,"context_lines":[{"line_number":37,"context_line":"          get_resource: VDU1_CP1"},{"line_number":38,"context_line":"      - port:"},{"line_number":39,"context_line":"          get_resource: VDU1_CP2"},{"line_number":40,"context_line":"# replace the following line to Port ID when extmanagedVLs\u0027 Ports are specified in instantiatevnfrequest"},{"line_number":41,"context_line":"      - port:"},{"line_number":42,"context_line":"          get_resource: VDU1_CP3"},{"line_number":43,"context_line":"      - port:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"6f4144a9_149ce619","line":40,"range":{"start_line":40,"start_character":83,"end_line":40,"end_character":104},"updated":"2023-03-06 04:06:32.000000000","message":"nits: InstantiateVnfRequest","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"f19e5ec3c81954db706cbc026364ed9a58b20ce0","unresolved":false,"context_lines":[{"line_number":37,"context_line":"          get_resource: VDU1_CP1"},{"line_number":38,"context_line":"      - port:"},{"line_number":39,"context_line":"          get_resource: VDU1_CP2"},{"line_number":40,"context_line":"# replace the following line to Port ID when extmanagedVLs\u0027 Ports are specified in instantiatevnfrequest"},{"line_number":41,"context_line":"      - port:"},{"line_number":42,"context_line":"          get_resource: VDU1_CP3"},{"line_number":43,"context_line":"      - port:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"5107e4b5_af2b5924","line":40,"range":{"start_line":40,"start_character":83,"end_line":40,"end_character":104},"in_reply_to":"2e136bc4_239644fb","updated":"2023-04-05 08:17:27.000000000","message":"Done","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"d55617e8836d80895ddeb621bc1abe32b0f71263","unresolved":true,"context_lines":[{"line_number":37,"context_line":"          get_resource: VDU1_CP1"},{"line_number":38,"context_line":"      - port:"},{"line_number":39,"context_line":"          get_resource: VDU1_CP2"},{"line_number":40,"context_line":"# replace the following line to Port ID when extmanagedVLs\u0027 Ports are specified in instantiatevnfrequest"},{"line_number":41,"context_line":"      - port:"},{"line_number":42,"context_line":"          get_resource: VDU1_CP3"},{"line_number":43,"context_line":"      - port:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"2e136bc4_239644fb","line":40,"range":{"start_line":40,"start_character":83,"end_line":40,"end_character":104},"in_reply_to":"6f4144a9_149ce619","updated":"2023-03-07 03:07:09.000000000","message":"I fixed it in PS17.","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"7eee81198d7cdd08a62dbc1aa84c1f65af2a6e3d","unresolved":true,"context_lines":[{"line_number":69,"context_line":"      fixed_ips:"},{"line_number":70,"context_line":"      - subnet: { get_param: subnet2}"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"# delete the following line when extmanagedVLs\u0027 Ports are specified in instantiatevnfrequest"},{"line_number":73,"context_line":"  VDU1_CP3:"},{"line_number":74,"context_line":"    type: OS::Neutron::Port"},{"line_number":75,"context_line":"    properties:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"b2577377_5e4b0007","line":72,"range":{"start_line":72,"start_character":71,"end_line":72,"end_character":92},"updated":"2023-03-06 04:06:32.000000000","message":"ditto.","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"f19e5ec3c81954db706cbc026364ed9a58b20ce0","unresolved":false,"context_lines":[{"line_number":69,"context_line":"      fixed_ips:"},{"line_number":70,"context_line":"      - subnet: { get_param: subnet2}"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"# delete the following line when extmanagedVLs\u0027 Ports are specified in instantiatevnfrequest"},{"line_number":73,"context_line":"  VDU1_CP3:"},{"line_number":74,"context_line":"    type: OS::Neutron::Port"},{"line_number":75,"context_line":"    properties:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"45be5c0a_3cc4fe7e","line":72,"range":{"start_line":72,"start_character":71,"end_line":72,"end_character":92},"in_reply_to":"46ac1358_81a3dab5","updated":"2023-04-05 08:17:27.000000000","message":"Done","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"d55617e8836d80895ddeb621bc1abe32b0f71263","unresolved":true,"context_lines":[{"line_number":69,"context_line":"      fixed_ips:"},{"line_number":70,"context_line":"      - subnet: { get_param: subnet2}"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"# delete the following line when extmanagedVLs\u0027 Ports are specified in instantiatevnfrequest"},{"line_number":73,"context_line":"  VDU1_CP3:"},{"line_number":74,"context_line":"    type: OS::Neutron::Port"},{"line_number":75,"context_line":"    properties:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"46ac1358_81a3dab5","line":72,"range":{"start_line":72,"start_character":71,"end_line":72,"end_character":92},"in_reply_to":"b2577377_5e4b0007","updated":"2023-03-07 03:07:09.000000000","message":"ditto","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"}],"tacker/tests/functional/sol_v2_common/samples/basic_lcms_max_individual_vnfc/contents/BaseHOT/simple/nested/VDU2.yaml":[{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"7eee81198d7cdd08a62dbc1aa84c1f65af2a6e3d","unresolved":true,"context_lines":[{"line_number":8,"context_line":"    type: string"},{"line_number":9,"context_line":"  zone:"},{"line_number":10,"context_line":"    type: string"},{"line_number":11,"context_line":"# The individual vnfc mgmt does not support ext-port now."},{"line_number":12,"context_line":"#  port1-1:"},{"line_number":13,"context_line":"#    type: string"},{"line_number":14,"context_line":"#  port1-2:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"74892389_844d79eb","line":11,"range":{"start_line":11,"start_character":44,"end_line":11,"end_character":52},"updated":"2023-03-06 04:06:32.000000000","message":"It is better to use SOL-based terms instead of \"ext-port\".\nFor example, external CP Port? What do you think?\n\nIf changed, please apply it to other points.","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"7eee81198d7cdd08a62dbc1aa84c1f65af2a6e3d","unresolved":true,"context_lines":[{"line_number":8,"context_line":"    type: string"},{"line_number":9,"context_line":"  zone:"},{"line_number":10,"context_line":"    type: string"},{"line_number":11,"context_line":"# The individual vnfc mgmt does not support ext-port now."},{"line_number":12,"context_line":"#  port1-1:"},{"line_number":13,"context_line":"#    type: string"},{"line_number":14,"context_line":"#  port1-2:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"d37fdd56_75cdaee1","line":11,"range":{"start_line":11,"start_character":26,"end_line":11,"end_character":27},"updated":"2023-03-06 04:06:32.000000000","message":"please add (StandardUserData) here.\n`The individual vnfc mgmt (StandardUserData)`","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"d55617e8836d80895ddeb621bc1abe32b0f71263","unresolved":true,"context_lines":[{"line_number":8,"context_line":"    type: string"},{"line_number":9,"context_line":"  zone:"},{"line_number":10,"context_line":"    type: string"},{"line_number":11,"context_line":"# The individual vnfc mgmt does not support ext-port now."},{"line_number":12,"context_line":"#  port1-1:"},{"line_number":13,"context_line":"#    type: string"},{"line_number":14,"context_line":"#  port1-2:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"e35af202_549d317d","line":11,"range":{"start_line":11,"start_character":44,"end_line":11,"end_character":52},"in_reply_to":"7264de6d_9969b96f","updated":"2023-03-07 03:07:09.000000000","message":"I think extVirtualLink Port is better. I fixed it in PS17.","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"cd71529e502bf2ceca5f004c5b8d36649e5e6fb9","unresolved":true,"context_lines":[{"line_number":8,"context_line":"    type: string"},{"line_number":9,"context_line":"  zone:"},{"line_number":10,"context_line":"    type: string"},{"line_number":11,"context_line":"# The individual vnfc mgmt does not support ext-port now."},{"line_number":12,"context_line":"#  port1-1:"},{"line_number":13,"context_line":"#    type: string"},{"line_number":14,"context_line":"#  port1-2:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"7264de6d_9969b96f","line":11,"range":{"start_line":11,"start_character":44,"end_line":11,"end_character":52},"in_reply_to":"74892389_844d79eb","updated":"2023-03-06 04:31:59.000000000","message":"Sorry, extVirtualLink Port is much better? What do you think?","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"f19e5ec3c81954db706cbc026364ed9a58b20ce0","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    type: string"},{"line_number":9,"context_line":"  zone:"},{"line_number":10,"context_line":"    type: string"},{"line_number":11,"context_line":"# The individual vnfc mgmt does not support ext-port now."},{"line_number":12,"context_line":"#  port1-1:"},{"line_number":13,"context_line":"#    type: string"},{"line_number":14,"context_line":"#  port1-2:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"9fa5cb2f_567fb35b","line":11,"range":{"start_line":11,"start_character":26,"end_line":11,"end_character":27},"in_reply_to":"97c7e985_30bbf05a","updated":"2023-04-05 08:17:27.000000000","message":"Done","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"d55617e8836d80895ddeb621bc1abe32b0f71263","unresolved":true,"context_lines":[{"line_number":8,"context_line":"    type: string"},{"line_number":9,"context_line":"  zone:"},{"line_number":10,"context_line":"    type: string"},{"line_number":11,"context_line":"# The individual vnfc mgmt does not support ext-port now."},{"line_number":12,"context_line":"#  port1-1:"},{"line_number":13,"context_line":"#    type: string"},{"line_number":14,"context_line":"#  port1-2:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"97c7e985_30bbf05a","line":11,"range":{"start_line":11,"start_character":26,"end_line":11,"end_character":27},"in_reply_to":"d37fdd56_75cdaee1","updated":"2023-03-07 03:07:09.000000000","message":"I fixed it in PS17.","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"f19e5ec3c81954db706cbc026364ed9a58b20ce0","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    type: string"},{"line_number":9,"context_line":"  zone:"},{"line_number":10,"context_line":"    type: string"},{"line_number":11,"context_line":"# The individual vnfc mgmt does not support ext-port now."},{"line_number":12,"context_line":"#  port1-1:"},{"line_number":13,"context_line":"#    type: string"},{"line_number":14,"context_line":"#  port1-2:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"6fa85adc_af3fb814","line":11,"range":{"start_line":11,"start_character":44,"end_line":11,"end_character":52},"in_reply_to":"e35af202_549d317d","updated":"2023-04-05 08:17:27.000000000","message":"Done","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"7eee81198d7cdd08a62dbc1aa84c1f65af2a6e3d","unresolved":true,"context_lines":[{"line_number":71,"context_line":"  VDU2_CP3:"},{"line_number":72,"context_line":"    type: OS::Neutron::Port"},{"line_number":73,"context_line":"    properties:"},{"line_number":74,"context_line":"# replace the following line to VL\u0027s ID when extmanagedVLs are specified in instantiatevnfrequest"},{"line_number":75,"context_line":"      network: { get_param: net3 }"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"  VDU2_CP4:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"47775a65_bd28c4f2","line":74,"range":{"start_line":74,"start_character":76,"end_line":74,"end_character":97},"updated":"2023-03-06 04:06:32.000000000","message":"nits: InstantiateVnfRequest","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"d55617e8836d80895ddeb621bc1abe32b0f71263","unresolved":true,"context_lines":[{"line_number":71,"context_line":"  VDU2_CP3:"},{"line_number":72,"context_line":"    type: OS::Neutron::Port"},{"line_number":73,"context_line":"    properties:"},{"line_number":74,"context_line":"# replace the following line to VL\u0027s ID when extmanagedVLs are specified in instantiatevnfrequest"},{"line_number":75,"context_line":"      network: { get_param: net3 }"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"  VDU2_CP4:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"bca81e02_a6ebb88e","line":74,"range":{"start_line":74,"start_character":76,"end_line":74,"end_character":97},"in_reply_to":"47775a65_bd28c4f2","updated":"2023-03-07 03:07:09.000000000","message":"ditto","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"f19e5ec3c81954db706cbc026364ed9a58b20ce0","unresolved":false,"context_lines":[{"line_number":71,"context_line":"  VDU2_CP3:"},{"line_number":72,"context_line":"    type: OS::Neutron::Port"},{"line_number":73,"context_line":"    properties:"},{"line_number":74,"context_line":"# replace the following line to VL\u0027s ID when extmanagedVLs are specified in instantiatevnfrequest"},{"line_number":75,"context_line":"      network: { get_param: net3 }"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"  VDU2_CP4:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"0c48588d_b0487795","line":74,"range":{"start_line":74,"start_character":76,"end_line":74,"end_character":97},"in_reply_to":"bca81e02_a6ebb88e","updated":"2023-04-05 08:17:27.000000000","message":"Done","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"7eee81198d7cdd08a62dbc1aa84c1f65af2a6e3d","unresolved":true,"context_lines":[{"line_number":77,"context_line":"  VDU2_CP4:"},{"line_number":78,"context_line":"    type: OS::Neutron::Port"},{"line_number":79,"context_line":"    properties:"},{"line_number":80,"context_line":"# replace the following line to VL\u0027s ID when extmanagedVLs are specified in instantiatevnfrequest"},{"line_number":81,"context_line":"      network: { get_param: net4 }"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"  VDU2_CP5:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"9f24b6d4_78d18126","line":80,"range":{"start_line":80,"start_character":76,"end_line":80,"end_character":97},"updated":"2023-03-06 04:06:32.000000000","message":"ditto.","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"d55617e8836d80895ddeb621bc1abe32b0f71263","unresolved":true,"context_lines":[{"line_number":77,"context_line":"  VDU2_CP4:"},{"line_number":78,"context_line":"    type: OS::Neutron::Port"},{"line_number":79,"context_line":"    properties:"},{"line_number":80,"context_line":"# replace the following line to VL\u0027s ID when extmanagedVLs are specified in instantiatevnfrequest"},{"line_number":81,"context_line":"      network: { get_param: net4 }"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"  VDU2_CP5:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"bd9b2eb6_abe09ad7","line":80,"range":{"start_line":80,"start_character":76,"end_line":80,"end_character":97},"in_reply_to":"9f24b6d4_78d18126","updated":"2023-03-07 03:07:09.000000000","message":"ditto","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"f19e5ec3c81954db706cbc026364ed9a58b20ce0","unresolved":false,"context_lines":[{"line_number":77,"context_line":"  VDU2_CP4:"},{"line_number":78,"context_line":"    type: OS::Neutron::Port"},{"line_number":79,"context_line":"    properties:"},{"line_number":80,"context_line":"# replace the following line to VL\u0027s ID when extmanagedVLs are specified in instantiatevnfrequest"},{"line_number":81,"context_line":"      network: { get_param: net4 }"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"  VDU2_CP5:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"0ab4f8b2_f147f062","line":80,"range":{"start_line":80,"start_character":76,"end_line":80,"end_character":97},"in_reply_to":"bd9b2eb6_abe09ad7","updated":"2023-04-05 08:17:27.000000000","message":"Done","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"7eee81198d7cdd08a62dbc1aa84c1f65af2a6e3d","unresolved":true,"context_lines":[{"line_number":83,"context_line":"  VDU2_CP5:"},{"line_number":84,"context_line":"    type: OS::Neutron::Port"},{"line_number":85,"context_line":"    properties:"},{"line_number":86,"context_line":"# replace the following line to VL\u0027s ID when extmanagedVLs are specified in instantiatevnfrequest"},{"line_number":87,"context_line":"      network: { get_param: net5 }"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"6e114e49_31a69896","line":86,"range":{"start_line":86,"start_character":76,"end_line":86,"end_character":97},"updated":"2023-03-06 04:06:32.000000000","message":"ditto.","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"d55617e8836d80895ddeb621bc1abe32b0f71263","unresolved":true,"context_lines":[{"line_number":83,"context_line":"  VDU2_CP5:"},{"line_number":84,"context_line":"    type: OS::Neutron::Port"},{"line_number":85,"context_line":"    properties:"},{"line_number":86,"context_line":"# replace the following line to VL\u0027s ID when extmanagedVLs are specified in instantiatevnfrequest"},{"line_number":87,"context_line":"      network: { get_param: net5 }"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"9f945ded_4102834d","line":86,"range":{"start_line":86,"start_character":76,"end_line":86,"end_character":97},"in_reply_to":"6e114e49_31a69896","updated":"2023-03-07 03:07:09.000000000","message":"ditto","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"f19e5ec3c81954db706cbc026364ed9a58b20ce0","unresolved":false,"context_lines":[{"line_number":83,"context_line":"  VDU2_CP5:"},{"line_number":84,"context_line":"    type: OS::Neutron::Port"},{"line_number":85,"context_line":"    properties:"},{"line_number":86,"context_line":"# replace the following line to VL\u0027s ID when extmanagedVLs are specified in instantiatevnfrequest"},{"line_number":87,"context_line":"      network: { get_param: net5 }"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"ec1a3b86_53999aa4","line":86,"range":{"start_line":86,"start_character":76,"end_line":86,"end_character":97},"in_reply_to":"9f945ded_4102834d","updated":"2023-04-05 08:17:27.000000000","message":"Done","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"}],"tacker/tests/functional/sol_v2_common/samples/basic_lcms_max_individual_vnfc/contents/BaseHOT/simple/sample3.yaml":[{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"7eee81198d7cdd08a62dbc1aa84c1f65af2a6e3d","unresolved":true,"context_lines":[{"line_number":22,"context_line":"      volume_type: { get_resource: VDU1-VolumeType }"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# NOTE: Resource definition of OS::Heat::ScalingPolicy is omitted."},{"line_number":25,"context_line":"# It is not used by v2 scale implementation unlike v1."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"  VDU1-VolumeType:"},{"line_number":28,"context_line":"    type: OS::Cinder::VolumeType"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"e49a71a1_05ca567e","line":25,"range":{"start_line":25,"start_character":51,"end_line":25,"end_character":53},"updated":"2023-03-06 04:06:32.000000000","message":"nits: v1API","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"7eee81198d7cdd08a62dbc1aa84c1f65af2a6e3d","unresolved":true,"context_lines":[{"line_number":22,"context_line":"      volume_type: { get_resource: VDU1-VolumeType }"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# NOTE: Resource definition of OS::Heat::ScalingPolicy is omitted."},{"line_number":25,"context_line":"# It is not used by v2 scale implementation unlike v1."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"  VDU1-VolumeType:"},{"line_number":28,"context_line":"    type: OS::Cinder::VolumeType"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"5a5d3c91_6969e2a1","line":25,"range":{"start_line":25,"start_character":20,"end_line":25,"end_character":22},"updated":"2023-03-06 04:06:32.000000000","message":"nits: v2API","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"f19e5ec3c81954db706cbc026364ed9a58b20ce0","unresolved":false,"context_lines":[{"line_number":22,"context_line":"      volume_type: { get_resource: VDU1-VolumeType }"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# NOTE: Resource definition of OS::Heat::ScalingPolicy is omitted."},{"line_number":25,"context_line":"# It is not used by v2 scale implementation unlike v1."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"  VDU1-VolumeType:"},{"line_number":28,"context_line":"    type: OS::Cinder::VolumeType"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"fa5d7ad6_e3106115","line":25,"range":{"start_line":25,"start_character":51,"end_line":25,"end_character":53},"in_reply_to":"0bad55f8_2901b286","updated":"2023-04-05 08:17:27.000000000","message":"Done","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"d55617e8836d80895ddeb621bc1abe32b0f71263","unresolved":true,"context_lines":[{"line_number":22,"context_line":"      volume_type: { get_resource: VDU1-VolumeType }"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# NOTE: Resource definition of OS::Heat::ScalingPolicy is omitted."},{"line_number":25,"context_line":"# It is not used by v2 scale implementation unlike v1."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"  VDU1-VolumeType:"},{"line_number":28,"context_line":"    type: OS::Cinder::VolumeType"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"fff459d5_94e846c9","line":25,"range":{"start_line":25,"start_character":20,"end_line":25,"end_character":22},"in_reply_to":"5a5d3c91_6969e2a1","updated":"2023-03-07 03:07:09.000000000","message":"I fixed it in PS17.","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"d55617e8836d80895ddeb621bc1abe32b0f71263","unresolved":true,"context_lines":[{"line_number":22,"context_line":"      volume_type: { get_resource: VDU1-VolumeType }"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# NOTE: Resource definition of OS::Heat::ScalingPolicy is omitted."},{"line_number":25,"context_line":"# It is not used by v2 scale implementation unlike v1."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"  VDU1-VolumeType:"},{"line_number":28,"context_line":"    type: OS::Cinder::VolumeType"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"0bad55f8_2901b286","line":25,"range":{"start_line":25,"start_character":51,"end_line":25,"end_character":53},"in_reply_to":"e49a71a1_05ca567e","updated":"2023-03-07 03:07:09.000000000","message":"I fixed it in PS17.","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"f19e5ec3c81954db706cbc026364ed9a58b20ce0","unresolved":false,"context_lines":[{"line_number":22,"context_line":"      volume_type: { get_resource: VDU1-VolumeType }"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# NOTE: Resource definition of OS::Heat::ScalingPolicy is omitted."},{"line_number":25,"context_line":"# It is not used by v2 scale implementation unlike v1."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"  VDU1-VolumeType:"},{"line_number":28,"context_line":"    type: OS::Cinder::VolumeType"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"b4cdcaac_28dc4dd4","line":25,"range":{"start_line":25,"start_character":20,"end_line":25,"end_character":22},"in_reply_to":"fff459d5_94e846c9","updated":"2023-04-05 08:17:27.000000000","message":"Done","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"7eee81198d7cdd08a62dbc1aa84c1f65af2a6e3d","unresolved":true,"context_lines":[{"line_number":54,"context_line":"      name: VDU2-multi"},{"line_number":55,"context_line":"      metadata: { multiattach: \"\u003cis\u003e True\" }"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"# delete the following lines when extmanagedVLs are specified in instantiatevnfrequest"},{"line_number":58,"context_line":"  internalVL1:"},{"line_number":59,"context_line":"    type: OS::Neutron::Net"},{"line_number":60,"context_line":"  internalVL2:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"3d1ec735_f27fa3ee","line":57,"range":{"start_line":57,"start_character":65,"end_line":57,"end_character":86},"updated":"2023-03-06 04:06:32.000000000","message":"nits: InstantiateVnfRequest","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"d55617e8836d80895ddeb621bc1abe32b0f71263","unresolved":true,"context_lines":[{"line_number":54,"context_line":"      name: VDU2-multi"},{"line_number":55,"context_line":"      metadata: { multiattach: \"\u003cis\u003e True\" }"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"# delete the following lines when extmanagedVLs are specified in instantiatevnfrequest"},{"line_number":58,"context_line":"  internalVL1:"},{"line_number":59,"context_line":"    type: OS::Neutron::Net"},{"line_number":60,"context_line":"  internalVL2:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"ff72e5bf_5e6af498","line":57,"range":{"start_line":57,"start_character":65,"end_line":57,"end_character":86},"in_reply_to":"3d1ec735_f27fa3ee","updated":"2023-03-07 03:07:09.000000000","message":"I fixed it in PS17.","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"f19e5ec3c81954db706cbc026364ed9a58b20ce0","unresolved":false,"context_lines":[{"line_number":54,"context_line":"      name: VDU2-multi"},{"line_number":55,"context_line":"      metadata: { multiattach: \"\u003cis\u003e True\" }"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"# delete the following lines when extmanagedVLs are specified in instantiatevnfrequest"},{"line_number":58,"context_line":"  internalVL1:"},{"line_number":59,"context_line":"    type: OS::Neutron::Net"},{"line_number":60,"context_line":"  internalVL2:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"a40afdf8_e007d7fe","line":57,"range":{"start_line":57,"start_character":65,"end_line":57,"end_character":86},"in_reply_to":"ff72e5bf_5e6af498","updated":"2023-04-05 08:17:27.000000000","message":"Done","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"}],"tacker/tests/functional/sol_v2_common/samples/basic_lcms_max_individual_vnfc/contents/Definitions/v2_sample3_types.yaml":[{"author":{"_account_id":31668},"change_message_id":"7a80155badbd39e63b238399dd9b322616cc0849","unresolved":true,"context_lines":[{"line_number":52,"context_line":"          capability: tosca.capabilities.nfv.VirtualLinkable"},{"line_number":53,"context_line":"    interfaces:"},{"line_number":54,"context_line":"      Vnflcm:"},{"line_number":55,"context_line":"        type: tosca.interfaces.nfv.Vnflcm"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"f076e7e0_0c832489","line":55,"updated":"2023-03-03 01:04:01.000000000","message":"Please add an empty line.","commit_id":"feed9c78524aefbdd74cea7d38e9cbc91eaa8223"},{"author":{"_account_id":31668},"change_message_id":"75d4d5da6db5660184c1e89fbd1440126063e695","unresolved":false,"context_lines":[{"line_number":52,"context_line":"          capability: tosca.capabilities.nfv.VirtualLinkable"},{"line_number":53,"context_line":"    interfaces:"},{"line_number":54,"context_line":"      Vnflcm:"},{"line_number":55,"context_line":"        type: tosca.interfaces.nfv.Vnflcm"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"a0c05e01_81bc05aa","line":55,"in_reply_to":"d41198f9_80eb48e9","updated":"2023-03-07 01:54:46.000000000","message":"Done","commit_id":"feed9c78524aefbdd74cea7d38e9cbc91eaa8223"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"04fcc3655dd8ea9a2ba096809ffe2b095aae8d7c","unresolved":true,"context_lines":[{"line_number":52,"context_line":"          capability: tosca.capabilities.nfv.VirtualLinkable"},{"line_number":53,"context_line":"    interfaces:"},{"line_number":54,"context_line":"      Vnflcm:"},{"line_number":55,"context_line":"        type: tosca.interfaces.nfv.Vnflcm"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"d41198f9_80eb48e9","line":55,"in_reply_to":"f076e7e0_0c832489","updated":"2023-03-03 01:29:22.000000000","message":"I added an empty line in PS10.","commit_id":"feed9c78524aefbdd74cea7d38e9cbc91eaa8223"}],"tacker/tests/functional/sol_v2_common/samples/basic_lcms_max_individual_vnfc/contents/UserData/userdata_standard.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"0b9b03c7908183209cf896017dec6fb1eb1c5283","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"47afcfe3_8564cd69","updated":"2023-02-21 14:36:47.000000000","message":"What is the difference from the file under \"infra_drivers/openstack\" folder [1]?\n\nCan\u0027t you put the file to the \"infra_drivers/openstack\" folder,\nand is it possible to create a package by specifying a file path like `min pattern \npackage` [2]?\nIf the `userdata_standard.py` files used in the `max pattern test` are all the same, I think it is better to be one file for future maintenance.\nWhat do you think?\n\n[1] https://opendev.org/openstack/tacker/src/branch/master/tacker/sol_refactored/infra_drivers/openstack/userdata_standard.py\n[2] https://review.opendev.org/c/openstack/tacker/+/873477/5/tacker/tests/functional/sol_v2/test_individual_vnfc_mgmt_basic.py#55","commit_id":"41554135599574540113f4008f640beb97c699e0"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"41c45a8eba676769d25468d20b79d07db18f58f2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b523817e_fc2550ca","in_reply_to":"04079017_f7e86c40","updated":"2023-03-02 09:06:07.000000000","message":"I understand and confirmed, thank you.","commit_id":"41554135599574540113f4008f640beb97c699e0"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"0f97f63bc60cb158fe73a0f9c3835b4640033d67","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"39b4f8a8_1019f0f6","in_reply_to":"3613d690_c21b2bc6","updated":"2023-02-27 13:04:05.000000000","message":"Thanks for your explanation, I understand this file is for handling port.\nIs it possible to add this file as like `userdata_stadard_port_handling.py` to [1] directory, and refer like the following?\n\n```\n        userdata_port_handling_file \u003d \"userdata_standard_port_handling.py\"\n        userdata_port_handling_path \u003d os.path.abspath(\n            os.path.join(userdata_dir, userdata_port_handling_file ))\n\n        # vnf package for basic lcms tests max pattern\n        pkg_path_1 \u003d os.path.join(cur_dir,\n            \"../sol_v2_common/samples/basic_lcms_max_individual_vnfc\")\n        cls.vnf_pkg_1, cls.vnfd_id_1 \u003d cls.create_vnf_package(\n            pkg_path_1, image_path\u003dimage_path,\n            userdata_path\u003duserdata_port_handling_path)\n```","commit_id":"41554135599574540113f4008f640beb97c699e0"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"d91956bcd9192e95e1cb1a621d87a0286954880c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"04079017_f7e86c40","in_reply_to":"39b4f8a8_1019f0f6","updated":"2023-03-02 08:18:53.000000000","message":"In the latest discussion, individual_vnfc_mgmt currently does not support the case of port, so the corresponding part is deleted in PS8 and only the original userdata_standard.py file is used.\nPlease kindly check it again.","commit_id":"41554135599574540113f4008f640beb97c699e0"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"65d93aa2141f41cfc6e7c812581ce0317f1035ac","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3613d690_c21b2bc6","in_reply_to":"47afcfe3_8564cd69","updated":"2023-02-22 06:08:08.000000000","message":"It is not the same as userdata_standard.py file in infra_drivers/openstack folder.\nIt adds handling of port. This is similar to the previous pattern of max.\nhttps://opendev.org/openstack/tacker/src/branch/master/tacker/sol_refactored/infra_drivers/openstack/userdata_default.py#L117-L135\nhttps://opendev.org/openstack/tacker/src/branch/master/tacker/tests/functional/sol_v2_common/samples/basic_lcms_max/contents/UserData/userdata.py#L97-L106\nSo I think by default, there should be no handling of port. So I appended this file to max pattern to add the port handler.\nhttps://review.opendev.org/c/openstack/tacker/+/873477/5/tacker/tests/functional/sol_v2_common/samples/basic_lcms_max_individual_vnfc/contents/UserData/userdata_standard.py#262","commit_id":"41554135599574540113f4008f640beb97c699e0"}],"tacker/tests/functional/sol_v2_common/samples/basic_lcms_max_individual_vnfc/pkggen.py":[{"author":{"_account_id":31668},"change_message_id":"75d4d5da6db5660184c1e89fbd1440126063e695","unresolved":true,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"create_req \u003d paramgen.create_vnf_max("},{"line_number":58,"context_line":"    vnfd_id, descprion\u003d\u0027test for basic_max_individual_vnfc\u0027)"},{"line_number":59,"context_line":"scaleout_req \u003d paramgen.scaleout_vnf_max()"},{"line_number":60,"context_line":"add_additional_params(scaleout_req)"},{"line_number":61,"context_line":"scalein_req \u003d paramgen.scalein_vnf_max()"}],"source_content_type":"text/x-python","patch_set":17,"id":"8f29c374_321c9296","line":58,"updated":"2023-03-07 01:54:46.000000000","message":"descprion -\u003e description","commit_id":"6ff2f4c756f954ca20adba0a9d2b10fd02989031"},{"author":{"_account_id":31668},"change_message_id":"408819a00c17ed71ed77dc5ba2835c4bf1a96111","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"create_req \u003d paramgen.create_vnf_max("},{"line_number":58,"context_line":"    vnfd_id, descprion\u003d\u0027test for basic_max_individual_vnfc\u0027)"},{"line_number":59,"context_line":"scaleout_req \u003d paramgen.scaleout_vnf_max()"},{"line_number":60,"context_line":"add_additional_params(scaleout_req)"},{"line_number":61,"context_line":"scalein_req \u003d paramgen.scalein_vnf_max()"}],"source_content_type":"text/x-python","patch_set":17,"id":"ae829534_ce6753d9","line":58,"in_reply_to":"7093eb92_e17ea7fa","updated":"2023-03-07 04:40:55.000000000","message":"Done","commit_id":"6ff2f4c756f954ca20adba0a9d2b10fd02989031"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"d55617e8836d80895ddeb621bc1abe32b0f71263","unresolved":true,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"create_req \u003d paramgen.create_vnf_max("},{"line_number":58,"context_line":"    vnfd_id, descprion\u003d\u0027test for basic_max_individual_vnfc\u0027)"},{"line_number":59,"context_line":"scaleout_req \u003d paramgen.scaleout_vnf_max()"},{"line_number":60,"context_line":"add_additional_params(scaleout_req)"},{"line_number":61,"context_line":"scalein_req \u003d paramgen.scalein_vnf_max()"}],"source_content_type":"text/x-python","patch_set":17,"id":"7093eb92_e17ea7fa","line":58,"in_reply_to":"8f29c374_321c9296","updated":"2023-03-07 03:07:09.000000000","message":"I fixed it in PS18.","commit_id":"6ff2f4c756f954ca20adba0a9d2b10fd02989031"},{"author":{"_account_id":31668},"change_message_id":"75d4d5da6db5660184c1e89fbd1440126063e695","unresolved":true,"context_lines":[{"line_number":76,"context_line":"    \u0027ft-net1\u0027])"},{"line_number":77,"context_line":"subnet_ids \u003d utils.get_subnet_ids([\u0027subnet0\u0027, \u0027subnet1\u0027, \u0027ft-ipv4-subnet0\u0027,"},{"line_number":78,"context_line":"    \u0027ft-ipv6-subnet0\u0027, \u0027ft-ipv4-subnet1\u0027, \u0027ft-ipv6-subnet1\u0027])"},{"line_number":79,"context_line":"port_ids \u003d utils.get_port_ids([\u0027VDU2_CP1-1\u0027, \u0027VDU2_CP1-2\u0027])"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"instantiate_req \u003d paramgen.instantiate_vnf_max("},{"line_number":82,"context_line":"    net_ids, subnet_ids, port_ids, \"http://localhost/identity/v3\")"}],"source_content_type":"text/x-python","patch_set":17,"id":"e441e94c_1c7e17d0","line":79,"updated":"2023-03-07 01:54:46.000000000","message":"The following error will occur when pkggen.py is executed, so please check.\n$ python3 pre.py\n$ python3 pkggen.py\n```\nTraceback (most recent call last):\n  File \"/opt/stack/tacker/tacker/tests/functional/sol_v2_common/samples/basic_lcms_max_individual_vnfc/pkggen.py\", line 79, in \u003cmodule\u003e\n    port_ids \u003d utils.get_port_ids([\u0027VDU2_CP1-1\u0027, \u0027VDU2_CP1-2\u0027])\n  File \"/opt/stack/tacker/tacker/tests/functional/sol_v2_common/utils.py\", line 126, in get_port_ids\n    port_ids[port] \u003d json.loads(p.stdout)[\u0027id\u0027]\n  File \"/usr/lib/python3.10/json/__init__.py\", line 346, in loads\n    return _default_decoder.decode(s)\n  File \"/usr/lib/python3.10/json/decoder.py\", line 337, in decode\n    obj, end \u003d self.raw_decode(s, idx\u003d_w(s, 0).end())\n  File \"/usr/lib/python3.10/json/decoder.py\", line 355, in raw_decode\n    raise JSONDecodeError(\"Expecting value\", s, err.value) from None\njson.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)\n```\n\nIf my operation seems wrong, please point it out.","commit_id":"6ff2f4c756f954ca20adba0a9d2b10fd02989031"},{"author":{"_account_id":31668},"change_message_id":"408819a00c17ed71ed77dc5ba2835c4bf1a96111","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    \u0027ft-net1\u0027])"},{"line_number":77,"context_line":"subnet_ids \u003d utils.get_subnet_ids([\u0027subnet0\u0027, \u0027subnet1\u0027, \u0027ft-ipv4-subnet0\u0027,"},{"line_number":78,"context_line":"    \u0027ft-ipv6-subnet0\u0027, \u0027ft-ipv4-subnet1\u0027, \u0027ft-ipv6-subnet1\u0027])"},{"line_number":79,"context_line":"port_ids \u003d utils.get_port_ids([\u0027VDU2_CP1-1\u0027, \u0027VDU2_CP1-2\u0027])"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"instantiate_req \u003d paramgen.instantiate_vnf_max("},{"line_number":82,"context_line":"    net_ids, subnet_ids, port_ids, \"http://localhost/identity/v3\")"}],"source_content_type":"text/x-python","patch_set":17,"id":"594c1231_98e5507e","line":79,"in_reply_to":"77d8fded_98e3a341","updated":"2023-03-07 04:40:55.000000000","message":"Done","commit_id":"6ff2f4c756f954ca20adba0a9d2b10fd02989031"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"d55617e8836d80895ddeb621bc1abe32b0f71263","unresolved":true,"context_lines":[{"line_number":76,"context_line":"    \u0027ft-net1\u0027])"},{"line_number":77,"context_line":"subnet_ids \u003d utils.get_subnet_ids([\u0027subnet0\u0027, \u0027subnet1\u0027, \u0027ft-ipv4-subnet0\u0027,"},{"line_number":78,"context_line":"    \u0027ft-ipv6-subnet0\u0027, \u0027ft-ipv4-subnet1\u0027, \u0027ft-ipv6-subnet1\u0027])"},{"line_number":79,"context_line":"port_ids \u003d utils.get_port_ids([\u0027VDU2_CP1-1\u0027, \u0027VDU2_CP1-2\u0027])"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"instantiate_req \u003d paramgen.instantiate_vnf_max("},{"line_number":82,"context_line":"    net_ids, subnet_ids, port_ids, \"http://localhost/identity/v3\")"}],"source_content_type":"text/x-python","patch_set":17,"id":"77d8fded_98e3a341","line":79,"in_reply_to":"e441e94c_1c7e17d0","updated":"2023-03-07 03:07:09.000000000","message":"The \u0027VDU2_CP1-1\u0027, \u0027VDU2_CP1-2\u0027 are not currently supported in individual vnfc mgmt, so they have been removed from the code. I forgot to delete them here.\nI fixed it in PS18.","commit_id":"6ff2f4c756f954ca20adba0a9d2b10fd02989031"},{"author":{"_account_id":31668},"change_message_id":"408819a00c17ed71ed77dc5ba2835c4bf1a96111","unresolved":true,"context_lines":[{"line_number":78,"context_line":"    \u0027ft-ipv6-subnet0\u0027, \u0027ft-ipv4-subnet1\u0027, \u0027ft-ipv6-subnet1\u0027])"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"instantiate_req \u003d paramgen.instantiate_vnf_max("},{"line_number":81,"context_line":"    net_ids, subnet_ids, None, \"http://localhost/identity/v3\")"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"# fake vnfc id, should be get from show vnf"},{"line_number":84,"context_line":"vnfc_ids \u003d [\u0027VDU1-9300a3cb-bd3b-45e4-9967-095040caf827\u0027,"}],"source_content_type":"text/x-python","patch_set":18,"id":"dc298a62_d08dca7d","line":81,"updated":"2023-03-07 04:40:55.000000000","message":"The following error will occur when pkggen.py is executed, so please check.\n$ python3 pre.py\n$ python3 pkggen.py\n```\nTraceback (most recent call last):\n  File \"/opt/stack/tacker/tacker/tests/functional/sol_v2_common/samples/basic_lcms_max_individual_vnfc/pkggen.py\", line 80, in \u003cmodule\u003e\n    instantiate_req \u003d paramgen.instantiate_vnf_max(\n  File \"/opt/stack/tacker/tacker/tests/functional/sol_v2_common/paramgen.py\", line 427, in instantiate_vnf_max\n    \"nfv\": {\"CP\": {\"VDU2_CP1-2\": {\"port\": ports[\u0027VDU2_CP1-2\u0027]}}}\nTypeError: \u0027NoneType\u0027 object is not subscriptable\n```","commit_id":"efcc00e64f815d780119ef7adb179723a58e32f6"},{"author":{"_account_id":31668},"change_message_id":"0a0918eb3a26f2036739cb33911ef8583a19896d","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    \u0027ft-ipv6-subnet0\u0027, \u0027ft-ipv4-subnet1\u0027, \u0027ft-ipv6-subnet1\u0027])"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"instantiate_req \u003d paramgen.instantiate_vnf_max("},{"line_number":81,"context_line":"    net_ids, subnet_ids, None, \"http://localhost/identity/v3\")"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"# fake vnfc id, should be get from show vnf"},{"line_number":84,"context_line":"vnfc_ids \u003d [\u0027VDU1-9300a3cb-bd3b-45e4-9967-095040caf827\u0027,"}],"source_content_type":"text/x-python","patch_set":18,"id":"60644a90_893a1ed7","line":81,"in_reply_to":"d7a855f3_62fec8dc","updated":"2023-03-23 05:52:35.000000000","message":"Done","commit_id":"efcc00e64f815d780119ef7adb179723a58e32f6"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"32ba83d2bbbc5ef3837ffaf9195d953ece0b5d89","unresolved":true,"context_lines":[{"line_number":78,"context_line":"    \u0027ft-ipv6-subnet0\u0027, \u0027ft-ipv4-subnet1\u0027, \u0027ft-ipv6-subnet1\u0027])"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"instantiate_req \u003d paramgen.instantiate_vnf_max("},{"line_number":81,"context_line":"    net_ids, subnet_ids, None, \"http://localhost/identity/v3\")"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"# fake vnfc id, should be get from show vnf"},{"line_number":84,"context_line":"vnfc_ids \u003d [\u0027VDU1-9300a3cb-bd3b-45e4-9967-095040caf827\u0027,"}],"source_content_type":"text/x-python","patch_set":18,"id":"d7a855f3_62fec8dc","line":81,"in_reply_to":"dc298a62_d08dca7d","updated":"2023-03-08 04:59:21.000000000","message":"I fixed it in PS19.","commit_id":"efcc00e64f815d780119ef7adb179723a58e32f6"},{"author":{"_account_id":31668},"change_message_id":"e899f3e35ae18d8aac877828de8250507e050678","unresolved":true,"context_lines":[{"line_number":106,"context_line":"add_additional_params(change_ext_conn_max_req)"},{"line_number":107,"context_line":"# Only this package have external connectivity."},{"line_number":108,"context_line":"# So min pattern also use this package."},{"line_number":109,"context_line":"change_ext_conn_min_req \u003d paramgen.change_ext_conn_min(net_ids, subnet_ids)"},{"line_number":110,"context_line":"add_additional_params(change_ext_conn_min_req)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"with open(\"create_req\", \"w\", encoding\u003d\u0027utf-8\u0027) as f:"}],"source_content_type":"text/x-python","patch_set":33,"id":"11f2175b_cfe74572","line":109,"updated":"2023-03-23 07:52:44.000000000","message":"There doesn\u0027t seem to be a test to make sure change-ext-conn succeeds using this request.\nIt seems to be used for rollback testing, but is it okay if I don\u0027t confirm that it succeeds?\nhttps://review.opendev.org/c/openstack/tacker/+/873477/33/tacker/tests/functional/sol_v2_individual_vnfc_mgmt/test_individual_vnfc_mgmt_basic.py#1509","commit_id":"57977db8e78bd5252c28eb855691d57affb77d05"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"040796c7352f0e4ac2794dcaa7a80c9ad63dcd30","unresolved":true,"context_lines":[{"line_number":106,"context_line":"add_additional_params(change_ext_conn_max_req)"},{"line_number":107,"context_line":"# Only this package have external connectivity."},{"line_number":108,"context_line":"# So min pattern also use this package."},{"line_number":109,"context_line":"change_ext_conn_min_req \u003d paramgen.change_ext_conn_min(net_ids, subnet_ids)"},{"line_number":110,"context_line":"add_additional_params(change_ext_conn_min_req)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"with open(\"create_req\", \"w\", encoding\u003d\u0027utf-8\u0027) as f:"}],"source_content_type":"text/x-python","patch_set":33,"id":"51c5f0f3_f667db36","line":109,"in_reply_to":"11f2175b_cfe74572","updated":"2023-03-27 06:13:15.000000000","message":"Yes, it is used for rollback testing in this test. But I have used it locally for a normal system test, and there is no problem. \nAt the same time, the rollback_change_ext_conn test is an error that occurs when executing the `change_external_connectivity_end` method of mgmt_drvier. The error occurs because the `change_external_connectivity_end` file is created in advance, so if the mgmt_driver is not executed, the operation can be successful, so the request_body itself is correct.","commit_id":"57977db8e78bd5252c28eb855691d57affb77d05"},{"author":{"_account_id":31668},"change_message_id":"4c5937e136c86b08773e33086dcb0e7988fa0cad","unresolved":false,"context_lines":[{"line_number":106,"context_line":"add_additional_params(change_ext_conn_max_req)"},{"line_number":107,"context_line":"# Only this package have external connectivity."},{"line_number":108,"context_line":"# So min pattern also use this package."},{"line_number":109,"context_line":"change_ext_conn_min_req \u003d paramgen.change_ext_conn_min(net_ids, subnet_ids)"},{"line_number":110,"context_line":"add_additional_params(change_ext_conn_min_req)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"with open(\"create_req\", \"w\", encoding\u003d\u0027utf-8\u0027) as f:"}],"source_content_type":"text/x-python","patch_set":33,"id":"7e99349e_5a817e16","line":109,"in_reply_to":"33a940fc_819207d3","updated":"2023-04-10 07:33:44.000000000","message":"Done","commit_id":"57977db8e78bd5252c28eb855691d57affb77d05"},{"author":{"_account_id":31668},"change_message_id":"7f72cf6a9e291cdff550128501ac67d4e4ee737d","unresolved":true,"context_lines":[{"line_number":106,"context_line":"add_additional_params(change_ext_conn_max_req)"},{"line_number":107,"context_line":"# Only this package have external connectivity."},{"line_number":108,"context_line":"# So min pattern also use this package."},{"line_number":109,"context_line":"change_ext_conn_min_req \u003d paramgen.change_ext_conn_min(net_ids, subnet_ids)"},{"line_number":110,"context_line":"add_additional_params(change_ext_conn_min_req)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"with open(\"create_req\", \"w\", encoding\u003d\u0027utf-8\u0027) as f:"}],"source_content_type":"text/x-python","patch_set":33,"id":"a1e6b956_5b2811dc","line":109,"in_reply_to":"51c5f0f3_f667db36","updated":"2023-03-28 10:09:49.000000000","message":"Thank you for your explanation.\nJust to be sure, please let me check if the FT succeeds in both cases below.\n・Failed before change_external_connectivity_end processing and became FAILED_TEMP -\u003e rollback succeeded\n・Failed change_external_connectivity_end processing and became FAILED_TEMP -\u003e rollback succeeded\n\nI would like to know if FT can detect when change_ext_conn fails unintentionally.","commit_id":"57977db8e78bd5252c28eb855691d57affb77d05"},{"author":{"_account_id":31668},"change_message_id":"a2c4b01b4880d2e8b5a6492071fb856f65accb77","unresolved":true,"context_lines":[{"line_number":106,"context_line":"add_additional_params(change_ext_conn_max_req)"},{"line_number":107,"context_line":"# Only this package have external connectivity."},{"line_number":108,"context_line":"# So min pattern also use this package."},{"line_number":109,"context_line":"change_ext_conn_min_req \u003d paramgen.change_ext_conn_min(net_ids, subnet_ids)"},{"line_number":110,"context_line":"add_additional_params(change_ext_conn_min_req)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"with open(\"create_req\", \"w\", encoding\u003d\u0027utf-8\u0027) as f:"}],"source_content_type":"text/x-python","patch_set":33,"id":"a80bfa94_29fff42c","line":109,"in_reply_to":"7657be7f_baa12297","updated":"2023-04-04 08:01:02.000000000","message":"I don\u0027t think we need to add one more test.\nWhen create/instantiate is executed with the min pattern, there is no extVirtualLinks, so the OpenStack resource changes are not actually executed.\n(In the v2 API, if non-existing extVirtualLinks are specified in the request, the information is only added to the instantiatedVnfInfo of VnfInstance without adding CP.)\nI don\u0027t think this makes much sense as a test, so how about changing the VnfPackage used in this test to the max pattern?\nCould you also add a confirmation that the opocc err detail includes \"change_external_connectivity_end failed\" after change_ext_conn fails?\nSince it is a different check item from other tests, please add the purpose of checking in the comments.\nIf this is confirmed, I think it will be clear that no error occurred before change_external_connectivity_end.\n\nPlease suggest if there is another better way.","commit_id":"57977db8e78bd5252c28eb855691d57affb77d05"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"878d3176b1efb13b1e3dea24e56f20ccebdf0ece","unresolved":true,"context_lines":[{"line_number":106,"context_line":"add_additional_params(change_ext_conn_max_req)"},{"line_number":107,"context_line":"# Only this package have external connectivity."},{"line_number":108,"context_line":"# So min pattern also use this package."},{"line_number":109,"context_line":"change_ext_conn_min_req \u003d paramgen.change_ext_conn_min(net_ids, subnet_ids)"},{"line_number":110,"context_line":"add_additional_params(change_ext_conn_min_req)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"with open(\"create_req\", \"w\", encoding\u003d\u0027utf-8\u0027) as f:"}],"source_content_type":"text/x-python","patch_set":33,"id":"7657be7f_baa12297","line":109,"in_reply_to":"a1e6b956_5b2811dc","updated":"2023-04-03 08:46:10.000000000","message":"Do you mean to add a procedure in test_rollback_chgextconn_and_update to check both two cases?","commit_id":"57977db8e78bd5252c28eb855691d57affb77d05"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"2af3376165484707348a813352ffd66391542d9e","unresolved":true,"context_lines":[{"line_number":106,"context_line":"add_additional_params(change_ext_conn_max_req)"},{"line_number":107,"context_line":"# Only this package have external connectivity."},{"line_number":108,"context_line":"# So min pattern also use this package."},{"line_number":109,"context_line":"change_ext_conn_min_req \u003d paramgen.change_ext_conn_min(net_ids, subnet_ids)"},{"line_number":110,"context_line":"add_additional_params(change_ext_conn_min_req)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"with open(\"create_req\", \"w\", encoding\u003d\u0027utf-8\u0027) as f:"}],"source_content_type":"text/x-python","patch_set":33,"id":"33a940fc_819207d3","line":109,"in_reply_to":"a80bfa94_29fff42c","updated":"2023-04-10 05:36:03.000000000","message":"I modified to max pattern and added a check to lcmopocc body\u0027s error.","commit_id":"57977db8e78bd5252c28eb855691d57affb77d05"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"9933929ef24f1cb70c638c6151eb4c46e8cc12fd","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":34,"id":"7acfd1b1_ece1ff86","updated":"2023-03-27 09:13:56.000000000","message":"Could you add `update_req`?\nhttps://review.opendev.org/c/openstack/tacker/+/873477/34/tacker/tests/functional/sol_v2_individual_vnfc_mgmt/test_individual_vnfc_mgmt_basic.py#772","commit_id":"7cf70ac342921e604f446cf6414705572f2b10f5"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"878d3176b1efb13b1e3dea24e56f20ccebdf0ece","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":34,"id":"b0f3dd98_d7dd527b","in_reply_to":"7acfd1b1_ece1ff86","updated":"2023-04-03 08:46:10.000000000","message":"I added update_req in PS35.","commit_id":"7cf70ac342921e604f446cf6414705572f2b10f5"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"1b9517c43cd5c18462401eab99c669214523adab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":34,"id":"fc1c4510_c4a49297","in_reply_to":"b0f3dd98_d7dd527b","updated":"2023-04-03 23:40:21.000000000","message":"Done","commit_id":"7cf70ac342921e604f446cf6414705572f2b10f5"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"9933929ef24f1cb70c638c6151eb4c46e8cc12fd","unresolved":true,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"create_req \u003d paramgen.create_vnf_max("},{"line_number":59,"context_line":"    vnfd_id, description\u003d\u0027test for basic_max_individual_vnfc\u0027)"},{"line_number":60,"context_line":"scaleout_req \u003d paramgen.scaleout_vnf_max()"},{"line_number":61,"context_line":"add_additional_params(scaleout_req)"},{"line_number":62,"context_line":"scalein_req \u003d paramgen.scalein_vnf_max()"}],"source_content_type":"text/x-python","patch_set":34,"id":"3f6e7838_de6ce282","line":59,"range":{"start_line":59,"start_character":35,"end_line":59,"end_character":60},"updated":"2023-03-27 09:13:56.000000000","message":"I think the following is better.\nbasic_max_individual_vnfc -\u003e basic_lcms_max_individual_vnfc","commit_id":"7cf70ac342921e604f446cf6414705572f2b10f5"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"878d3176b1efb13b1e3dea24e56f20ccebdf0ece","unresolved":true,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"create_req \u003d paramgen.create_vnf_max("},{"line_number":59,"context_line":"    vnfd_id, description\u003d\u0027test for basic_max_individual_vnfc\u0027)"},{"line_number":60,"context_line":"scaleout_req \u003d paramgen.scaleout_vnf_max()"},{"line_number":61,"context_line":"add_additional_params(scaleout_req)"},{"line_number":62,"context_line":"scalein_req \u003d paramgen.scalein_vnf_max()"}],"source_content_type":"text/x-python","patch_set":34,"id":"85307311_0b63ef15","line":59,"range":{"start_line":59,"start_character":35,"end_line":59,"end_character":60},"in_reply_to":"3f6e7838_de6ce282","updated":"2023-04-03 08:46:10.000000000","message":"I fixed it in PS35.","commit_id":"7cf70ac342921e604f446cf6414705572f2b10f5"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"1b9517c43cd5c18462401eab99c669214523adab","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"create_req \u003d paramgen.create_vnf_max("},{"line_number":59,"context_line":"    vnfd_id, description\u003d\u0027test for basic_max_individual_vnfc\u0027)"},{"line_number":60,"context_line":"scaleout_req \u003d paramgen.scaleout_vnf_max()"},{"line_number":61,"context_line":"add_additional_params(scaleout_req)"},{"line_number":62,"context_line":"scalein_req \u003d paramgen.scalein_vnf_max()"}],"source_content_type":"text/x-python","patch_set":34,"id":"b463aade_8725b44c","line":59,"range":{"start_line":59,"start_character":35,"end_line":59,"end_character":60},"in_reply_to":"85307311_0b63ef15","updated":"2023-04-03 23:40:21.000000000","message":"Done","commit_id":"7cf70ac342921e604f446cf6414705572f2b10f5"}],"tacker/tests/functional/sol_v2_common/samples/change_vnfpkg_max_individual_vnfc/contents/BaseHOT/simple/nested/VDU1-after.yaml":[{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"7eee81198d7cdd08a62dbc1aa84c1f65af2a6e3d","unresolved":true,"context_lines":[{"line_number":39,"context_line":"          get_resource: VDU1_CP1"},{"line_number":40,"context_line":"      - port:"},{"line_number":41,"context_line":"          get_resource: VDU1_CP2"},{"line_number":42,"context_line":"# replace the following line to Port ID when extmanagedVLs\u0027 Ports are specified in instantiatevnfrequest"},{"line_number":43,"context_line":"      - port:"},{"line_number":44,"context_line":"          get_resource: VDU1_CP3"},{"line_number":45,"context_line":"      - port:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"1a7cd369_c9576675","line":42,"range":{"start_line":42,"start_character":83,"end_line":42,"end_character":104},"updated":"2023-03-06 04:06:32.000000000","message":"nits: InstantiateVnfRequest","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"d55617e8836d80895ddeb621bc1abe32b0f71263","unresolved":true,"context_lines":[{"line_number":39,"context_line":"          get_resource: VDU1_CP1"},{"line_number":40,"context_line":"      - port:"},{"line_number":41,"context_line":"          get_resource: VDU1_CP2"},{"line_number":42,"context_line":"# replace the following line to Port ID when extmanagedVLs\u0027 Ports are specified in instantiatevnfrequest"},{"line_number":43,"context_line":"      - port:"},{"line_number":44,"context_line":"          get_resource: VDU1_CP3"},{"line_number":45,"context_line":"      - port:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"97d6c39f_5acd2672","line":42,"range":{"start_line":42,"start_character":83,"end_line":42,"end_character":104},"in_reply_to":"1a7cd369_c9576675","updated":"2023-03-07 03:07:09.000000000","message":"ditto","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"f19e5ec3c81954db706cbc026364ed9a58b20ce0","unresolved":false,"context_lines":[{"line_number":39,"context_line":"          get_resource: VDU1_CP1"},{"line_number":40,"context_line":"      - port:"},{"line_number":41,"context_line":"          get_resource: VDU1_CP2"},{"line_number":42,"context_line":"# replace the following line to Port ID when extmanagedVLs\u0027 Ports are specified in instantiatevnfrequest"},{"line_number":43,"context_line":"      - port:"},{"line_number":44,"context_line":"          get_resource: VDU1_CP3"},{"line_number":45,"context_line":"      - port:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"51d5b470_8904c162","line":42,"range":{"start_line":42,"start_character":83,"end_line":42,"end_character":104},"in_reply_to":"97d6c39f_5acd2672","updated":"2023-04-05 08:17:27.000000000","message":"Done","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"7eee81198d7cdd08a62dbc1aa84c1f65af2a6e3d","unresolved":true,"context_lines":[{"line_number":73,"context_line":"      fixed_ips:"},{"line_number":74,"context_line":"      - subnet: { get_param: subnet2}"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"# delete the following line when extmanagedVLs\u0027 Ports are specified in instantiatevnfrequest"},{"line_number":77,"context_line":"  VDU1_CP3:"},{"line_number":78,"context_line":"    type: OS::Neutron::Port"},{"line_number":79,"context_line":"    properties:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"832ed750_80eaec2e","line":76,"range":{"start_line":76,"start_character":71,"end_line":76,"end_character":92},"updated":"2023-03-06 04:06:32.000000000","message":"ditto.","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"f19e5ec3c81954db706cbc026364ed9a58b20ce0","unresolved":false,"context_lines":[{"line_number":73,"context_line":"      fixed_ips:"},{"line_number":74,"context_line":"      - subnet: { get_param: subnet2}"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"# delete the following line when extmanagedVLs\u0027 Ports are specified in instantiatevnfrequest"},{"line_number":77,"context_line":"  VDU1_CP3:"},{"line_number":78,"context_line":"    type: OS::Neutron::Port"},{"line_number":79,"context_line":"    properties:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"f889a484_35688187","line":76,"range":{"start_line":76,"start_character":71,"end_line":76,"end_character":92},"in_reply_to":"19939533_215e4bc2","updated":"2023-04-05 08:17:27.000000000","message":"Done","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"d55617e8836d80895ddeb621bc1abe32b0f71263","unresolved":true,"context_lines":[{"line_number":73,"context_line":"      fixed_ips:"},{"line_number":74,"context_line":"      - subnet: { get_param: subnet2}"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"# delete the following line when extmanagedVLs\u0027 Ports are specified in instantiatevnfrequest"},{"line_number":77,"context_line":"  VDU1_CP3:"},{"line_number":78,"context_line":"    type: OS::Neutron::Port"},{"line_number":79,"context_line":"    properties:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"19939533_215e4bc2","line":76,"range":{"start_line":76,"start_character":71,"end_line":76,"end_character":92},"in_reply_to":"832ed750_80eaec2e","updated":"2023-03-07 03:07:09.000000000","message":"ditto","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"}],"tacker/tests/functional/sol_v2_common/samples/change_vnfpkg_max_individual_vnfc/contents/BaseHOT/simple/nested/VDU2-after.yaml":[{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"7eee81198d7cdd08a62dbc1aa84c1f65af2a6e3d","unresolved":true,"context_lines":[{"line_number":75,"context_line":"  VDU2_CP3:"},{"line_number":76,"context_line":"    type: OS::Neutron::Port"},{"line_number":77,"context_line":"    properties:"},{"line_number":78,"context_line":"# replace the following line to VL\u0027s ID when extmanagedVLs are specified in instantiatevnfrequest"},{"line_number":79,"context_line":"      network: { get_param: net3 }"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"  VDU2_CP4:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"22a0969c_7d3ef52b","line":78,"range":{"start_line":78,"start_character":76,"end_line":78,"end_character":97},"updated":"2023-03-06 04:06:32.000000000","message":"nits: InstantiateVnfRequest","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"d55617e8836d80895ddeb621bc1abe32b0f71263","unresolved":true,"context_lines":[{"line_number":75,"context_line":"  VDU2_CP3:"},{"line_number":76,"context_line":"    type: OS::Neutron::Port"},{"line_number":77,"context_line":"    properties:"},{"line_number":78,"context_line":"# replace the following line to VL\u0027s ID when extmanagedVLs are specified in instantiatevnfrequest"},{"line_number":79,"context_line":"      network: { get_param: net3 }"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"  VDU2_CP4:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"4e991e44_aff5c4d0","line":78,"range":{"start_line":78,"start_character":76,"end_line":78,"end_character":97},"in_reply_to":"22a0969c_7d3ef52b","updated":"2023-03-07 03:07:09.000000000","message":"ditto","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"f19e5ec3c81954db706cbc026364ed9a58b20ce0","unresolved":false,"context_lines":[{"line_number":75,"context_line":"  VDU2_CP3:"},{"line_number":76,"context_line":"    type: OS::Neutron::Port"},{"line_number":77,"context_line":"    properties:"},{"line_number":78,"context_line":"# replace the following line to VL\u0027s ID when extmanagedVLs are specified in instantiatevnfrequest"},{"line_number":79,"context_line":"      network: { get_param: net3 }"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"  VDU2_CP4:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"8ccffaca_3e5deee7","line":78,"range":{"start_line":78,"start_character":76,"end_line":78,"end_character":97},"in_reply_to":"4e991e44_aff5c4d0","updated":"2023-04-05 08:17:27.000000000","message":"Done","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"7eee81198d7cdd08a62dbc1aa84c1f65af2a6e3d","unresolved":true,"context_lines":[{"line_number":81,"context_line":"  VDU2_CP4:"},{"line_number":82,"context_line":"    type: OS::Neutron::Port"},{"line_number":83,"context_line":"    properties:"},{"line_number":84,"context_line":"# replace the following line to VL\u0027s ID when extmanagedVLs are specified in instantiatevnfrequest"},{"line_number":85,"context_line":"      network: { get_param: net4 }"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"  VDU2_CP5:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"f6c59998_a7a062dc","line":84,"range":{"start_line":84,"start_character":76,"end_line":84,"end_character":97},"updated":"2023-03-06 04:06:32.000000000","message":"ditto.","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"f19e5ec3c81954db706cbc026364ed9a58b20ce0","unresolved":false,"context_lines":[{"line_number":81,"context_line":"  VDU2_CP4:"},{"line_number":82,"context_line":"    type: OS::Neutron::Port"},{"line_number":83,"context_line":"    properties:"},{"line_number":84,"context_line":"# replace the following line to VL\u0027s ID when extmanagedVLs are specified in instantiatevnfrequest"},{"line_number":85,"context_line":"      network: { get_param: net4 }"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"  VDU2_CP5:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"451c81b2_02a0433e","line":84,"range":{"start_line":84,"start_character":76,"end_line":84,"end_character":97},"in_reply_to":"a94ffa10_fcc23ecf","updated":"2023-04-05 08:17:27.000000000","message":"Done","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"d55617e8836d80895ddeb621bc1abe32b0f71263","unresolved":true,"context_lines":[{"line_number":81,"context_line":"  VDU2_CP4:"},{"line_number":82,"context_line":"    type: OS::Neutron::Port"},{"line_number":83,"context_line":"    properties:"},{"line_number":84,"context_line":"# replace the following line to VL\u0027s ID when extmanagedVLs are specified in instantiatevnfrequest"},{"line_number":85,"context_line":"      network: { get_param: net4 }"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"  VDU2_CP5:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"a94ffa10_fcc23ecf","line":84,"range":{"start_line":84,"start_character":76,"end_line":84,"end_character":97},"in_reply_to":"f6c59998_a7a062dc","updated":"2023-03-07 03:07:09.000000000","message":"ditto","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"7eee81198d7cdd08a62dbc1aa84c1f65af2a6e3d","unresolved":true,"context_lines":[{"line_number":87,"context_line":"  VDU2_CP5:"},{"line_number":88,"context_line":"    type: OS::Neutron::Port"},{"line_number":89,"context_line":"    properties:"},{"line_number":90,"context_line":"# replace the following line to VL\u0027s ID when extmanagedVLs are specified in instantiatevnfrequest"},{"line_number":91,"context_line":"      network: { get_param: net5 }"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"  VDU2_CP6:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"9ce520d7_94704e7b","line":90,"range":{"start_line":90,"start_character":76,"end_line":90,"end_character":97},"updated":"2023-03-06 04:06:32.000000000","message":"ditto.","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"f19e5ec3c81954db706cbc026364ed9a58b20ce0","unresolved":false,"context_lines":[{"line_number":87,"context_line":"  VDU2_CP5:"},{"line_number":88,"context_line":"    type: OS::Neutron::Port"},{"line_number":89,"context_line":"    properties:"},{"line_number":90,"context_line":"# replace the following line to VL\u0027s ID when extmanagedVLs are specified in instantiatevnfrequest"},{"line_number":91,"context_line":"      network: { get_param: net5 }"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"  VDU2_CP6:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"7a9817b9_d922db40","line":90,"range":{"start_line":90,"start_character":76,"end_line":90,"end_character":97},"in_reply_to":"6560be1f_dcab4f05","updated":"2023-04-05 08:17:27.000000000","message":"Done","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"d55617e8836d80895ddeb621bc1abe32b0f71263","unresolved":true,"context_lines":[{"line_number":87,"context_line":"  VDU2_CP5:"},{"line_number":88,"context_line":"    type: OS::Neutron::Port"},{"line_number":89,"context_line":"    properties:"},{"line_number":90,"context_line":"# replace the following line to VL\u0027s ID when extmanagedVLs are specified in instantiatevnfrequest"},{"line_number":91,"context_line":"      network: { get_param: net5 }"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"  VDU2_CP6:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"6560be1f_dcab4f05","line":90,"range":{"start_line":90,"start_character":76,"end_line":90,"end_character":97},"in_reply_to":"9ce520d7_94704e7b","updated":"2023-03-07 03:07:09.000000000","message":"ditto","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"}],"tacker/tests/functional/sol_v2_common/samples/change_vnfpkg_max_individual_vnfc/contents/BaseHOT/simple/sample3.yaml":[{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"7eee81198d7cdd08a62dbc1aa84c1f65af2a6e3d","unresolved":true,"context_lines":[{"line_number":23,"context_line":"      volume_type: { get_resource: VDU1-VolumeType }"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# NOTE: Resource definition of OS::Heat::ScalingPolicy is omitted."},{"line_number":26,"context_line":"# It is not used by v2 scale implementation unlike v1."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"  VDU1-VolumeType:"},{"line_number":29,"context_line":"    type: OS::Cinder::VolumeType"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"17d32a2c_da3fac5b","line":26,"range":{"start_line":26,"start_character":51,"end_line":26,"end_character":53},"updated":"2023-03-06 04:06:32.000000000","message":"nits: v1API","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"7eee81198d7cdd08a62dbc1aa84c1f65af2a6e3d","unresolved":true,"context_lines":[{"line_number":23,"context_line":"      volume_type: { get_resource: VDU1-VolumeType }"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# NOTE: Resource definition of OS::Heat::ScalingPolicy is omitted."},{"line_number":26,"context_line":"# It is not used by v2 scale implementation unlike v1."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"  VDU1-VolumeType:"},{"line_number":29,"context_line":"    type: OS::Cinder::VolumeType"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"0765718d_b448e6b7","line":26,"range":{"start_line":26,"start_character":20,"end_line":26,"end_character":22},"updated":"2023-03-06 04:06:32.000000000","message":"nits: v2API","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"d55617e8836d80895ddeb621bc1abe32b0f71263","unresolved":true,"context_lines":[{"line_number":23,"context_line":"      volume_type: { get_resource: VDU1-VolumeType }"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# NOTE: Resource definition of OS::Heat::ScalingPolicy is omitted."},{"line_number":26,"context_line":"# It is not used by v2 scale implementation unlike v1."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"  VDU1-VolumeType:"},{"line_number":29,"context_line":"    type: OS::Cinder::VolumeType"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"6753bd49_19fa634f","line":26,"range":{"start_line":26,"start_character":20,"end_line":26,"end_character":22},"in_reply_to":"0765718d_b448e6b7","updated":"2023-03-07 03:07:09.000000000","message":"ditto","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"d55617e8836d80895ddeb621bc1abe32b0f71263","unresolved":true,"context_lines":[{"line_number":23,"context_line":"      volume_type: { get_resource: VDU1-VolumeType }"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# NOTE: Resource definition of OS::Heat::ScalingPolicy is omitted."},{"line_number":26,"context_line":"# It is not used by v2 scale implementation unlike v1."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"  VDU1-VolumeType:"},{"line_number":29,"context_line":"    type: OS::Cinder::VolumeType"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"c234f14b_54d7e902","line":26,"range":{"start_line":26,"start_character":51,"end_line":26,"end_character":53},"in_reply_to":"17d32a2c_da3fac5b","updated":"2023-03-07 03:07:09.000000000","message":"ditto","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"f19e5ec3c81954db706cbc026364ed9a58b20ce0","unresolved":false,"context_lines":[{"line_number":23,"context_line":"      volume_type: { get_resource: VDU1-VolumeType }"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# NOTE: Resource definition of OS::Heat::ScalingPolicy is omitted."},{"line_number":26,"context_line":"# It is not used by v2 scale implementation unlike v1."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"  VDU1-VolumeType:"},{"line_number":29,"context_line":"    type: OS::Cinder::VolumeType"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"d5e64428_8b3bc29f","line":26,"range":{"start_line":26,"start_character":20,"end_line":26,"end_character":22},"in_reply_to":"6753bd49_19fa634f","updated":"2023-04-05 08:17:27.000000000","message":"Done","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"f19e5ec3c81954db706cbc026364ed9a58b20ce0","unresolved":false,"context_lines":[{"line_number":23,"context_line":"      volume_type: { get_resource: VDU1-VolumeType }"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# NOTE: Resource definition of OS::Heat::ScalingPolicy is omitted."},{"line_number":26,"context_line":"# It is not used by v2 scale implementation unlike v1."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"  VDU1-VolumeType:"},{"line_number":29,"context_line":"    type: OS::Cinder::VolumeType"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"828a60b6_31c96197","line":26,"range":{"start_line":26,"start_character":51,"end_line":26,"end_character":53},"in_reply_to":"c234f14b_54d7e902","updated":"2023-04-05 08:17:27.000000000","message":"Done","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"7eee81198d7cdd08a62dbc1aa84c1f65af2a6e3d","unresolved":true,"context_lines":[{"line_number":56,"context_line":"      name: VDU2-multi"},{"line_number":57,"context_line":"      metadata: { multiattach: \"\u003cis\u003e True\" }"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"# delete the following lines when extmanagedVLs are specified in instantiatevnfrequest"},{"line_number":60,"context_line":"  internalVL1:"},{"line_number":61,"context_line":"    type: OS::Neutron::Net"},{"line_number":62,"context_line":"  internalVL2:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"c7030f68_97f62dd4","line":59,"range":{"start_line":59,"start_character":65,"end_line":59,"end_character":86},"updated":"2023-03-06 04:06:32.000000000","message":"nits: InstantiateVnfRequest","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"f19e5ec3c81954db706cbc026364ed9a58b20ce0","unresolved":false,"context_lines":[{"line_number":56,"context_line":"      name: VDU2-multi"},{"line_number":57,"context_line":"      metadata: { multiattach: \"\u003cis\u003e True\" }"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"# delete the following lines when extmanagedVLs are specified in instantiatevnfrequest"},{"line_number":60,"context_line":"  internalVL1:"},{"line_number":61,"context_line":"    type: OS::Neutron::Net"},{"line_number":62,"context_line":"  internalVL2:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"54c62825_0f75d4b8","line":59,"range":{"start_line":59,"start_character":65,"end_line":59,"end_character":86},"in_reply_to":"4db62c07_9548f6cf","updated":"2023-04-05 08:17:27.000000000","message":"Done","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"d55617e8836d80895ddeb621bc1abe32b0f71263","unresolved":true,"context_lines":[{"line_number":56,"context_line":"      name: VDU2-multi"},{"line_number":57,"context_line":"      metadata: { multiattach: \"\u003cis\u003e True\" }"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"# delete the following lines when extmanagedVLs are specified in instantiatevnfrequest"},{"line_number":60,"context_line":"  internalVL1:"},{"line_number":61,"context_line":"    type: OS::Neutron::Net"},{"line_number":62,"context_line":"  internalVL2:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"4db62c07_9548f6cf","line":59,"range":{"start_line":59,"start_character":65,"end_line":59,"end_character":86},"in_reply_to":"c7030f68_97f62dd4","updated":"2023-03-07 03:07:09.000000000","message":"ditto","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"}],"tacker/tests/functional/sol_v2_common/samples/change_vnfpkg_max_individual_vnfc/pkggen.py":[{"author":{"_account_id":31668},"change_message_id":"75d4d5da6db5660184c1e89fbd1440126063e695","unresolved":true,"context_lines":[{"line_number":39,"context_line":"shutil.copy(os.path.join(tmp_dir, zip_file_name), \".\")"},{"line_number":40,"context_line":"shutil.rmtree(tmp_dir)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"net_ids \u003d utils.get_network_ids([\u0027net0\u0027, \u0027net1\u0027, \u0027net_mgmt\u0027, \u0027ft-net0\u0027,"},{"line_number":43,"context_line":"    \u0027ft-net1\u0027])"},{"line_number":44,"context_line":"subnet_ids \u003d utils.get_subnet_ids([\u0027subnet0\u0027, \u0027subnet1\u0027, \u0027ft-ipv4-subnet0\u0027,"},{"line_number":45,"context_line":"    \u0027ft-ipv6-subnet0\u0027, \u0027ft-ipv4-subnet1\u0027, \u0027ft-ipv6-subnet1\u0027])"}],"source_content_type":"text/x-python","patch_set":17,"id":"3ed57fbe_95e29e84","line":42,"updated":"2023-03-07 01:54:46.000000000","message":"Shouldn\u0027t the resource be added using pre.yaml?","commit_id":"6ff2f4c756f954ca20adba0a9d2b10fd02989031"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"d55617e8836d80895ddeb621bc1abe32b0f71263","unresolved":true,"context_lines":[{"line_number":39,"context_line":"shutil.copy(os.path.join(tmp_dir, zip_file_name), \".\")"},{"line_number":40,"context_line":"shutil.rmtree(tmp_dir)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"net_ids \u003d utils.get_network_ids([\u0027net0\u0027, \u0027net1\u0027, \u0027net_mgmt\u0027, \u0027ft-net0\u0027,"},{"line_number":43,"context_line":"    \u0027ft-net1\u0027])"},{"line_number":44,"context_line":"subnet_ids \u003d utils.get_subnet_ids([\u0027subnet0\u0027, \u0027subnet1\u0027, \u0027ft-ipv4-subnet0\u0027,"},{"line_number":45,"context_line":"    \u0027ft-ipv6-subnet0\u0027, \u0027ft-ipv4-subnet1\u0027, \u0027ft-ipv6-subnet1\u0027])"}],"source_content_type":"text/x-python","patch_set":17,"id":"da0b764a_72537294","line":42,"in_reply_to":"3ed57fbe_95e29e84","updated":"2023-03-07 03:07:09.000000000","message":"Instead of adding resources, we just get the id of the pre-created network as the content in the request_body.\nResources to be created in advance are added to pre.py.\nThis section is similar to the following link.\nhttps://opendev.org/openstack/tacker/src/branch/master/tacker/tests/functional/sol_v2_common/samples/userdata_standard_change_vnfpkg_nw/pkggen.py#L49","commit_id":"6ff2f4c756f954ca20adba0a9d2b10fd02989031"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"32ba83d2bbbc5ef3837ffaf9195d953ece0b5d89","unresolved":true,"context_lines":[{"line_number":39,"context_line":"shutil.copy(os.path.join(tmp_dir, zip_file_name), \".\")"},{"line_number":40,"context_line":"shutil.rmtree(tmp_dir)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"net_ids \u003d utils.get_network_ids([\u0027net0\u0027, \u0027net1\u0027, \u0027net_mgmt\u0027, \u0027ft-net0\u0027,"},{"line_number":43,"context_line":"    \u0027ft-net1\u0027])"},{"line_number":44,"context_line":"subnet_ids \u003d utils.get_subnet_ids([\u0027subnet0\u0027, \u0027subnet1\u0027, \u0027ft-ipv4-subnet0\u0027,"},{"line_number":45,"context_line":"    \u0027ft-ipv6-subnet0\u0027, \u0027ft-ipv4-subnet1\u0027, \u0027ft-ipv6-subnet1\u0027])"}],"source_content_type":"text/x-python","patch_set":17,"id":"d2ff1dbb_9f8c0119","line":42,"in_reply_to":"6e42a57e_2cd52520","updated":"2023-03-08 04:59:21.000000000","message":"I added the pre.py in PS19.","commit_id":"6ff2f4c756f954ca20adba0a9d2b10fd02989031"},{"author":{"_account_id":31668},"change_message_id":"0a0918eb3a26f2036739cb33911ef8583a19896d","unresolved":false,"context_lines":[{"line_number":39,"context_line":"shutil.copy(os.path.join(tmp_dir, zip_file_name), \".\")"},{"line_number":40,"context_line":"shutil.rmtree(tmp_dir)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"net_ids \u003d utils.get_network_ids([\u0027net0\u0027, \u0027net1\u0027, \u0027net_mgmt\u0027, \u0027ft-net0\u0027,"},{"line_number":43,"context_line":"    \u0027ft-net1\u0027])"},{"line_number":44,"context_line":"subnet_ids \u003d utils.get_subnet_ids([\u0027subnet0\u0027, \u0027subnet1\u0027, \u0027ft-ipv4-subnet0\u0027,"},{"line_number":45,"context_line":"    \u0027ft-ipv6-subnet0\u0027, \u0027ft-ipv4-subnet1\u0027, \u0027ft-ipv6-subnet1\u0027])"}],"source_content_type":"text/x-python","patch_set":17,"id":"34a3a0f9_e7022f61","line":42,"in_reply_to":"d2ff1dbb_9f8c0119","updated":"2023-03-23 05:52:35.000000000","message":"Done","commit_id":"6ff2f4c756f954ca20adba0a9d2b10fd02989031"},{"author":{"_account_id":31668},"change_message_id":"408819a00c17ed71ed77dc5ba2835c4bf1a96111","unresolved":true,"context_lines":[{"line_number":39,"context_line":"shutil.copy(os.path.join(tmp_dir, zip_file_name), \".\")"},{"line_number":40,"context_line":"shutil.rmtree(tmp_dir)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"net_ids \u003d utils.get_network_ids([\u0027net0\u0027, \u0027net1\u0027, \u0027net_mgmt\u0027, \u0027ft-net0\u0027,"},{"line_number":43,"context_line":"    \u0027ft-net1\u0027])"},{"line_number":44,"context_line":"subnet_ids \u003d utils.get_subnet_ids([\u0027subnet0\u0027, \u0027subnet1\u0027, \u0027ft-ipv4-subnet0\u0027,"},{"line_number":45,"context_line":"    \u0027ft-ipv6-subnet0\u0027, \u0027ft-ipv4-subnet1\u0027, \u0027ft-ipv6-subnet1\u0027])"}],"source_content_type":"text/x-python","patch_set":17,"id":"6e42a57e_2cd52520","line":42,"in_reply_to":"da0b764a_72537294","updated":"2023-03-07 04:40:55.000000000","message":"The following networks are created when devstack is built, so they don\u0027t need to be added by pre.yaml.\n* net0\n* net1\n* net_mgmt\n\nBut for the networks below, I think they should be added by pre.yaml as well as \"basic_lcms_max_individual_vnfc\".\n* ft-net0\n* ft-net1\n\nhttps://review.opendev.org/c/openstack/tacker/+/873477/18/tacker/tests/functional/sol_v2_common/samples/basic_lcms_max_individual_vnfc/pre.py\n\nI think each sample should be independent, what do you think?","commit_id":"6ff2f4c756f954ca20adba0a9d2b10fd02989031"},{"author":{"_account_id":31668},"change_message_id":"0a0918eb3a26f2036739cb33911ef8583a19896d","unresolved":true,"context_lines":[{"line_number":56,"context_line":"change_vnf_pkg_individual_vnfc_max \u003d ("},{"line_number":57,"context_line":"    paramgen.change_vnf_pkg_individual_vnfc_max(vnfd_id, net_ids, subnet_ids))"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"with open(\"change_vnf_pkg_individual_vnfc_max\", \"w\") as f:"},{"line_number":60,"context_line":"    f.write(json.dumps(change_vnf_pkg_individual_vnfc_max, indent\u003d2))"}],"source_content_type":"text/x-python","patch_set":32,"id":"5029b6fe_dfd5842e","line":59,"updated":"2023-03-23 05:52:35.000000000","message":"I think that \"_req\" is better at the end like others.\n* change_vnf_pkg_individual_vnfc_max_req","commit_id":"8b3c90da45827a66cc83b1a4c3ac0c8e543811e9"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"040796c7352f0e4ac2794dcaa7a80c9ad63dcd30","unresolved":true,"context_lines":[{"line_number":56,"context_line":"change_vnf_pkg_individual_vnfc_max \u003d ("},{"line_number":57,"context_line":"    paramgen.change_vnf_pkg_individual_vnfc_max(vnfd_id, net_ids, subnet_ids))"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"with open(\"change_vnf_pkg_individual_vnfc_max\", \"w\") as f:"},{"line_number":60,"context_line":"    f.write(json.dumps(change_vnf_pkg_individual_vnfc_max, indent\u003d2))"}],"source_content_type":"text/x-python","patch_set":32,"id":"c251b554_b339b0a7","line":59,"in_reply_to":"5029b6fe_dfd5842e","updated":"2023-03-27 06:13:15.000000000","message":"I fixed it in PS33","commit_id":"8b3c90da45827a66cc83b1a4c3ac0c8e543811e9"},{"author":{"_account_id":31668},"change_message_id":"7f72cf6a9e291cdff550128501ac67d4e4ee737d","unresolved":false,"context_lines":[{"line_number":56,"context_line":"change_vnf_pkg_individual_vnfc_max \u003d ("},{"line_number":57,"context_line":"    paramgen.change_vnf_pkg_individual_vnfc_max(vnfd_id, net_ids, subnet_ids))"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"with open(\"change_vnf_pkg_individual_vnfc_max\", \"w\") as f:"},{"line_number":60,"context_line":"    f.write(json.dumps(change_vnf_pkg_individual_vnfc_max, indent\u003d2))"}],"source_content_type":"text/x-python","patch_set":32,"id":"a03d85dc_40318d61","line":59,"in_reply_to":"c251b554_b339b0a7","updated":"2023-03-28 10:09:49.000000000","message":"Done","commit_id":"8b3c90da45827a66cc83b1a4c3ac0c8e543811e9"}],"tacker/tests/functional/sol_v2_common/samples/change_vnfpkg_or_update_min_individual_vnfc/contents/Definitions/v2_sample4_df_simple.yaml":[{"author":{"_account_id":31668},"change_message_id":"ca231a1a1843f1cfabe76a1149f6ada7e897d70b","unresolved":true,"context_lines":[{"line_number":95,"context_line":"      artifacts:"},{"line_number":96,"context_line":"        sw_image:"},{"line_number":97,"context_line":"          type: tosca.artifacts.nfv.SwImage"},{"line_number":98,"context_line":"          file: ../Files/images/cirros-0.5.2-x86_64-disk.img"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    VDU2:"},{"line_number":101,"context_line":"      type: tosca.nodes.nfv.Vdu.Compute"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"1314ed3a_69aeea83","line":98,"updated":"2023-03-07 06:49:38.000000000","message":"\"change_vnfpkg_or_update_min_individual_vnfc.zip\" created by pkggen.py does not contain a Files directory, so change-vnfpkg fails with an error.\n```\n{\n  \"title\": \"Grant failed\",\n  \"status\": 403,\n  \"detail\": \"glance image create failed\"\n}\n```\n```\nopenstack.exceptions.SDKException: Image creation failed: [Errno 2] No such file or directory: \u0027/opt/stack/data/tacker/vnfpackage\n/38d69421-3575-4e59-a561-68106c345353/Files/images/cirros-0.5.2-x86_64-disk.img\u0027\n```\n\nAn \"image_path\" must be specified in make_zip to include Files directory.\nPlease check.\nhttps://opendev.org/openstack/tacker/src/branch/master/tacker/tests/functional/sol_v2_common/utils.py#L26","commit_id":"72f65b96afd95b4c9e7f3529e7771b1a332d63f8"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"32ba83d2bbbc5ef3837ffaf9195d953ece0b5d89","unresolved":true,"context_lines":[{"line_number":95,"context_line":"      artifacts:"},{"line_number":96,"context_line":"        sw_image:"},{"line_number":97,"context_line":"          type: tosca.artifacts.nfv.SwImage"},{"line_number":98,"context_line":"          file: ../Files/images/cirros-0.5.2-x86_64-disk.img"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    VDU2:"},{"line_number":101,"context_line":"      type: tosca.nodes.nfv.Vdu.Compute"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"3dd6af10_36582ac1","line":98,"in_reply_to":"1314ed3a_69aeea83","updated":"2023-03-08 04:59:21.000000000","message":"I fixed it in PS20.","commit_id":"72f65b96afd95b4c9e7f3529e7771b1a332d63f8"},{"author":{"_account_id":31668},"change_message_id":"0a0918eb3a26f2036739cb33911ef8583a19896d","unresolved":false,"context_lines":[{"line_number":95,"context_line":"      artifacts:"},{"line_number":96,"context_line":"        sw_image:"},{"line_number":97,"context_line":"          type: tosca.artifacts.nfv.SwImage"},{"line_number":98,"context_line":"          file: ../Files/images/cirros-0.5.2-x86_64-disk.img"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    VDU2:"},{"line_number":101,"context_line":"      type: tosca.nodes.nfv.Vdu.Compute"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"2720ba9d_15acb3b1","line":98,"in_reply_to":"3dd6af10_36582ac1","updated":"2023-03-23 05:52:35.000000000","message":"Done","commit_id":"72f65b96afd95b4c9e7f3529e7771b1a332d63f8"}],"tacker/tests/functional/sol_v2_common/samples/change_vnfpkg_or_update_min_individual_vnfc/pkggen.py":[{"author":{"_account_id":31668},"change_message_id":"0a0918eb3a26f2036739cb33911ef8583a19896d","unresolved":true,"context_lines":[{"line_number":50,"context_line":"change_vnf_pkg_individual_vnfc_min \u003d ("},{"line_number":51,"context_line":"    paramgen.change_vnf_pkg_individual_vnfc_min(vnfd_id))"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"with open(\"change_vnf_pkg_individual_vnfc_min\", \"w\") as f:"},{"line_number":54,"context_line":"    f.write(json.dumps(change_vnf_pkg_individual_vnfc_min, indent\u003d2))"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"with open(\"update_min_req\", \"w\", encoding\u003d\u0027utf-8\u0027) as f:"}],"source_content_type":"text/x-python","patch_set":32,"id":"dcf3d95a_0aacef8d","line":53,"updated":"2023-03-23 05:52:35.000000000","message":"I think that \"_req\" is better at the end like others.\n* change_vnf_pkg_individual_vnfc_min_req","commit_id":"8b3c90da45827a66cc83b1a4c3ac0c8e543811e9"},{"author":{"_account_id":31668},"change_message_id":"7f72cf6a9e291cdff550128501ac67d4e4ee737d","unresolved":false,"context_lines":[{"line_number":50,"context_line":"change_vnf_pkg_individual_vnfc_min \u003d ("},{"line_number":51,"context_line":"    paramgen.change_vnf_pkg_individual_vnfc_min(vnfd_id))"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"with open(\"change_vnf_pkg_individual_vnfc_min\", \"w\") as f:"},{"line_number":54,"context_line":"    f.write(json.dumps(change_vnf_pkg_individual_vnfc_min, indent\u003d2))"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"with open(\"update_min_req\", \"w\", encoding\u003d\u0027utf-8\u0027) as f:"}],"source_content_type":"text/x-python","patch_set":32,"id":"2abb1247_9b1fa73f","line":53,"in_reply_to":"2e61cf65_ab5efd62","updated":"2023-03-28 10:09:49.000000000","message":"Done","commit_id":"8b3c90da45827a66cc83b1a4c3ac0c8e543811e9"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"040796c7352f0e4ac2794dcaa7a80c9ad63dcd30","unresolved":true,"context_lines":[{"line_number":50,"context_line":"change_vnf_pkg_individual_vnfc_min \u003d ("},{"line_number":51,"context_line":"    paramgen.change_vnf_pkg_individual_vnfc_min(vnfd_id))"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"with open(\"change_vnf_pkg_individual_vnfc_min\", \"w\") as f:"},{"line_number":54,"context_line":"    f.write(json.dumps(change_vnf_pkg_individual_vnfc_min, indent\u003d2))"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"with open(\"update_min_req\", \"w\", encoding\u003d\u0027utf-8\u0027) as f:"}],"source_content_type":"text/x-python","patch_set":32,"id":"2e61cf65_ab5efd62","line":53,"in_reply_to":"dcf3d95a_0aacef8d","updated":"2023-03-27 06:13:15.000000000","message":"I fixed it in PS33.","commit_id":"8b3c90da45827a66cc83b1a4c3ac0c8e543811e9"}],"tacker/tests/functional/sol_v2_common/samples/update_vnf_max_individual_vnfc/contents/BaseHOT/simple/nested/VDU1.yaml":[{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"7eee81198d7cdd08a62dbc1aa84c1f65af2a6e3d","unresolved":true,"context_lines":[{"line_number":37,"context_line":"          get_resource: VDU1_CP1"},{"line_number":38,"context_line":"      - port:"},{"line_number":39,"context_line":"          get_resource: VDU1_CP2"},{"line_number":40,"context_line":"# replace the following line to Port ID when extmanagedVLs\u0027 Ports are specified in instantiatevnfrequest"},{"line_number":41,"context_line":"      - port:"},{"line_number":42,"context_line":"          get_resource: VDU1_CP3"},{"line_number":43,"context_line":"      - port:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"4c451f6d_5f3fc09e","line":40,"range":{"start_line":40,"start_character":83,"end_line":40,"end_character":104},"updated":"2023-03-06 04:06:32.000000000","message":"nits: InstantiateVnfRequest","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"f19e5ec3c81954db706cbc026364ed9a58b20ce0","unresolved":false,"context_lines":[{"line_number":37,"context_line":"          get_resource: VDU1_CP1"},{"line_number":38,"context_line":"      - port:"},{"line_number":39,"context_line":"          get_resource: VDU1_CP2"},{"line_number":40,"context_line":"# replace the following line to Port ID when extmanagedVLs\u0027 Ports are specified in instantiatevnfrequest"},{"line_number":41,"context_line":"      - port:"},{"line_number":42,"context_line":"          get_resource: VDU1_CP3"},{"line_number":43,"context_line":"      - port:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"0c896186_ccc0d76b","line":40,"range":{"start_line":40,"start_character":83,"end_line":40,"end_character":104},"in_reply_to":"2ca9b792_e52eb363","updated":"2023-04-05 08:17:27.000000000","message":"Done","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"d55617e8836d80895ddeb621bc1abe32b0f71263","unresolved":true,"context_lines":[{"line_number":37,"context_line":"          get_resource: VDU1_CP1"},{"line_number":38,"context_line":"      - port:"},{"line_number":39,"context_line":"          get_resource: VDU1_CP2"},{"line_number":40,"context_line":"# replace the following line to Port ID when extmanagedVLs\u0027 Ports are specified in instantiatevnfrequest"},{"line_number":41,"context_line":"      - port:"},{"line_number":42,"context_line":"          get_resource: VDU1_CP3"},{"line_number":43,"context_line":"      - port:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"2ca9b792_e52eb363","line":40,"range":{"start_line":40,"start_character":83,"end_line":40,"end_character":104},"in_reply_to":"4c451f6d_5f3fc09e","updated":"2023-03-07 03:07:09.000000000","message":"ditto","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"7eee81198d7cdd08a62dbc1aa84c1f65af2a6e3d","unresolved":true,"context_lines":[{"line_number":69,"context_line":"      fixed_ips:"},{"line_number":70,"context_line":"      - subnet: { get_param: subnet2}"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"# delete the following line when extmanagedVLs\u0027 Ports are specified in instantiatevnfrequest"},{"line_number":73,"context_line":"  VDU1_CP3:"},{"line_number":74,"context_line":"    type: OS::Neutron::Port"},{"line_number":75,"context_line":"    properties:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"2af95e53_fbfd8bfb","line":72,"range":{"start_line":72,"start_character":71,"end_line":72,"end_character":92},"updated":"2023-03-06 04:06:32.000000000","message":"ditto.","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"d55617e8836d80895ddeb621bc1abe32b0f71263","unresolved":true,"context_lines":[{"line_number":69,"context_line":"      fixed_ips:"},{"line_number":70,"context_line":"      - subnet: { get_param: subnet2}"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"# delete the following line when extmanagedVLs\u0027 Ports are specified in instantiatevnfrequest"},{"line_number":73,"context_line":"  VDU1_CP3:"},{"line_number":74,"context_line":"    type: OS::Neutron::Port"},{"line_number":75,"context_line":"    properties:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"5c769d36_a617ee01","line":72,"range":{"start_line":72,"start_character":71,"end_line":72,"end_character":92},"in_reply_to":"2af95e53_fbfd8bfb","updated":"2023-03-07 03:07:09.000000000","message":"ditto","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"f19e5ec3c81954db706cbc026364ed9a58b20ce0","unresolved":false,"context_lines":[{"line_number":69,"context_line":"      fixed_ips:"},{"line_number":70,"context_line":"      - subnet: { get_param: subnet2}"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"# delete the following line when extmanagedVLs\u0027 Ports are specified in instantiatevnfrequest"},{"line_number":73,"context_line":"  VDU1_CP3:"},{"line_number":74,"context_line":"    type: OS::Neutron::Port"},{"line_number":75,"context_line":"    properties:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"ec12cfce_10365273","line":72,"range":{"start_line":72,"start_character":71,"end_line":72,"end_character":92},"in_reply_to":"5c769d36_a617ee01","updated":"2023-04-05 08:17:27.000000000","message":"Done","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"}],"tacker/tests/functional/sol_v2_common/samples/update_vnf_max_individual_vnfc/contents/BaseHOT/simple/nested/VDU2.yaml":[{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"7eee81198d7cdd08a62dbc1aa84c1f65af2a6e3d","unresolved":true,"context_lines":[{"line_number":71,"context_line":"  VDU2_CP3:"},{"line_number":72,"context_line":"    type: OS::Neutron::Port"},{"line_number":73,"context_line":"    properties:"},{"line_number":74,"context_line":"# replace the following line to VL\u0027s ID when extmanagedVLs are specified in instantiatevnfrequest"},{"line_number":75,"context_line":"      network: { get_param: net3 }"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"  VDU2_CP4:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"614175a9_a1d251df","line":74,"range":{"start_line":74,"start_character":76,"end_line":74,"end_character":97},"updated":"2023-03-06 04:06:32.000000000","message":"nits: InstantiateVnfRequest","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"d55617e8836d80895ddeb621bc1abe32b0f71263","unresolved":true,"context_lines":[{"line_number":71,"context_line":"  VDU2_CP3:"},{"line_number":72,"context_line":"    type: OS::Neutron::Port"},{"line_number":73,"context_line":"    properties:"},{"line_number":74,"context_line":"# replace the following line to VL\u0027s ID when extmanagedVLs are specified in instantiatevnfrequest"},{"line_number":75,"context_line":"      network: { get_param: net3 }"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"  VDU2_CP4:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"f7464e62_1170c29b","line":74,"range":{"start_line":74,"start_character":76,"end_line":74,"end_character":97},"in_reply_to":"614175a9_a1d251df","updated":"2023-03-07 03:07:09.000000000","message":"ditto","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"f19e5ec3c81954db706cbc026364ed9a58b20ce0","unresolved":false,"context_lines":[{"line_number":71,"context_line":"  VDU2_CP3:"},{"line_number":72,"context_line":"    type: OS::Neutron::Port"},{"line_number":73,"context_line":"    properties:"},{"line_number":74,"context_line":"# replace the following line to VL\u0027s ID when extmanagedVLs are specified in instantiatevnfrequest"},{"line_number":75,"context_line":"      network: { get_param: net3 }"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"  VDU2_CP4:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"8940dcff_780a64a9","line":74,"range":{"start_line":74,"start_character":76,"end_line":74,"end_character":97},"in_reply_to":"f7464e62_1170c29b","updated":"2023-04-05 08:17:27.000000000","message":"Done","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"7eee81198d7cdd08a62dbc1aa84c1f65af2a6e3d","unresolved":true,"context_lines":[{"line_number":77,"context_line":"  VDU2_CP4:"},{"line_number":78,"context_line":"    type: OS::Neutron::Port"},{"line_number":79,"context_line":"    properties:"},{"line_number":80,"context_line":"# replace the following line to VL\u0027s ID when extmanagedVLs are specified in instantiatevnfrequest"},{"line_number":81,"context_line":"      network: { get_param: net4 }"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"  VDU2_CP5:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"9b310247_542079b1","line":80,"range":{"start_line":80,"start_character":76,"end_line":80,"end_character":97},"updated":"2023-03-06 04:06:32.000000000","message":"ditto.","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"f19e5ec3c81954db706cbc026364ed9a58b20ce0","unresolved":false,"context_lines":[{"line_number":77,"context_line":"  VDU2_CP4:"},{"line_number":78,"context_line":"    type: OS::Neutron::Port"},{"line_number":79,"context_line":"    properties:"},{"line_number":80,"context_line":"# replace the following line to VL\u0027s ID when extmanagedVLs are specified in instantiatevnfrequest"},{"line_number":81,"context_line":"      network: { get_param: net4 }"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"  VDU2_CP5:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"e086ed7e_6ade7de3","line":80,"range":{"start_line":80,"start_character":76,"end_line":80,"end_character":97},"in_reply_to":"94176e8b_c73bf9b1","updated":"2023-04-05 08:17:27.000000000","message":"Done","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"d55617e8836d80895ddeb621bc1abe32b0f71263","unresolved":true,"context_lines":[{"line_number":77,"context_line":"  VDU2_CP4:"},{"line_number":78,"context_line":"    type: OS::Neutron::Port"},{"line_number":79,"context_line":"    properties:"},{"line_number":80,"context_line":"# replace the following line to VL\u0027s ID when extmanagedVLs are specified in instantiatevnfrequest"},{"line_number":81,"context_line":"      network: { get_param: net4 }"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"  VDU2_CP5:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"94176e8b_c73bf9b1","line":80,"range":{"start_line":80,"start_character":76,"end_line":80,"end_character":97},"in_reply_to":"9b310247_542079b1","updated":"2023-03-07 03:07:09.000000000","message":"ditto","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"7eee81198d7cdd08a62dbc1aa84c1f65af2a6e3d","unresolved":true,"context_lines":[{"line_number":83,"context_line":"  VDU2_CP5:"},{"line_number":84,"context_line":"    type: OS::Neutron::Port"},{"line_number":85,"context_line":"    properties:"},{"line_number":86,"context_line":"# replace the following line to VL\u0027s ID when extmanagedVLs are specified in instantiatevnfrequest"},{"line_number":87,"context_line":"      network: { get_param: net5 }"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"f19e237b_1e453fba","line":86,"range":{"start_line":86,"start_character":76,"end_line":86,"end_character":97},"updated":"2023-03-06 04:06:32.000000000","message":"ditto.","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"f19e5ec3c81954db706cbc026364ed9a58b20ce0","unresolved":false,"context_lines":[{"line_number":83,"context_line":"  VDU2_CP5:"},{"line_number":84,"context_line":"    type: OS::Neutron::Port"},{"line_number":85,"context_line":"    properties:"},{"line_number":86,"context_line":"# replace the following line to VL\u0027s ID when extmanagedVLs are specified in instantiatevnfrequest"},{"line_number":87,"context_line":"      network: { get_param: net5 }"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"2e72d1d1_af6d847b","line":86,"range":{"start_line":86,"start_character":76,"end_line":86,"end_character":97},"in_reply_to":"170ad4b1_71b25097","updated":"2023-04-05 08:17:27.000000000","message":"Done","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"d55617e8836d80895ddeb621bc1abe32b0f71263","unresolved":true,"context_lines":[{"line_number":83,"context_line":"  VDU2_CP5:"},{"line_number":84,"context_line":"    type: OS::Neutron::Port"},{"line_number":85,"context_line":"    properties:"},{"line_number":86,"context_line":"# replace the following line to VL\u0027s ID when extmanagedVLs are specified in instantiatevnfrequest"},{"line_number":87,"context_line":"      network: { get_param: net5 }"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"170ad4b1_71b25097","line":86,"range":{"start_line":86,"start_character":76,"end_line":86,"end_character":97},"in_reply_to":"f19e237b_1e453fba","updated":"2023-03-07 03:07:09.000000000","message":"ditto","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"}],"tacker/tests/functional/sol_v2_common/samples/update_vnf_max_individual_vnfc/contents/BaseHOT/simple/sample3.yaml":[{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"7eee81198d7cdd08a62dbc1aa84c1f65af2a6e3d","unresolved":true,"context_lines":[{"line_number":22,"context_line":"      volume_type: { get_resource: VDU1-VolumeType }"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# NOTE: Resource definition of OS::Heat::ScalingPolicy is omitted."},{"line_number":25,"context_line":"# It is not used by v2 scale implementation unlike v1."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"  VDU1-VolumeType:"},{"line_number":28,"context_line":"    type: OS::Cinder::VolumeType"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"3bd87517_945fac8e","line":25,"range":{"start_line":25,"start_character":51,"end_line":25,"end_character":53},"updated":"2023-03-06 04:06:32.000000000","message":"nits: v1API","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"7eee81198d7cdd08a62dbc1aa84c1f65af2a6e3d","unresolved":true,"context_lines":[{"line_number":22,"context_line":"      volume_type: { get_resource: VDU1-VolumeType }"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# NOTE: Resource definition of OS::Heat::ScalingPolicy is omitted."},{"line_number":25,"context_line":"# It is not used by v2 scale implementation unlike v1."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"  VDU1-VolumeType:"},{"line_number":28,"context_line":"    type: OS::Cinder::VolumeType"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"2ea867ba_d4a54bc7","line":25,"range":{"start_line":25,"start_character":20,"end_line":25,"end_character":22},"updated":"2023-03-06 04:06:32.000000000","message":"nits: v2API","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"d55617e8836d80895ddeb621bc1abe32b0f71263","unresolved":true,"context_lines":[{"line_number":22,"context_line":"      volume_type: { get_resource: VDU1-VolumeType }"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# NOTE: Resource definition of OS::Heat::ScalingPolicy is omitted."},{"line_number":25,"context_line":"# It is not used by v2 scale implementation unlike v1."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"  VDU1-VolumeType:"},{"line_number":28,"context_line":"    type: OS::Cinder::VolumeType"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"ca42eca0_686e3f92","line":25,"range":{"start_line":25,"start_character":20,"end_line":25,"end_character":22},"in_reply_to":"2ea867ba_d4a54bc7","updated":"2023-03-07 03:07:09.000000000","message":"ditto","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"f19e5ec3c81954db706cbc026364ed9a58b20ce0","unresolved":false,"context_lines":[{"line_number":22,"context_line":"      volume_type: { get_resource: VDU1-VolumeType }"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# NOTE: Resource definition of OS::Heat::ScalingPolicy is omitted."},{"line_number":25,"context_line":"# It is not used by v2 scale implementation unlike v1."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"  VDU1-VolumeType:"},{"line_number":28,"context_line":"    type: OS::Cinder::VolumeType"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"6f3c588d_61dd55ca","line":25,"range":{"start_line":25,"start_character":51,"end_line":25,"end_character":53},"in_reply_to":"3a7ef92c_6f1e6cb7","updated":"2023-04-05 08:17:27.000000000","message":"Done","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"d55617e8836d80895ddeb621bc1abe32b0f71263","unresolved":true,"context_lines":[{"line_number":22,"context_line":"      volume_type: { get_resource: VDU1-VolumeType }"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# NOTE: Resource definition of OS::Heat::ScalingPolicy is omitted."},{"line_number":25,"context_line":"# It is not used by v2 scale implementation unlike v1."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"  VDU1-VolumeType:"},{"line_number":28,"context_line":"    type: OS::Cinder::VolumeType"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"3a7ef92c_6f1e6cb7","line":25,"range":{"start_line":25,"start_character":51,"end_line":25,"end_character":53},"in_reply_to":"3bd87517_945fac8e","updated":"2023-03-07 03:07:09.000000000","message":"ditto","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"f19e5ec3c81954db706cbc026364ed9a58b20ce0","unresolved":false,"context_lines":[{"line_number":22,"context_line":"      volume_type: { get_resource: VDU1-VolumeType }"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# NOTE: Resource definition of OS::Heat::ScalingPolicy is omitted."},{"line_number":25,"context_line":"# It is not used by v2 scale implementation unlike v1."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"  VDU1-VolumeType:"},{"line_number":28,"context_line":"    type: OS::Cinder::VolumeType"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"c86f5e5c_52a20cd1","line":25,"range":{"start_line":25,"start_character":20,"end_line":25,"end_character":22},"in_reply_to":"ca42eca0_686e3f92","updated":"2023-04-05 08:17:27.000000000","message":"Done","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"7eee81198d7cdd08a62dbc1aa84c1f65af2a6e3d","unresolved":true,"context_lines":[{"line_number":54,"context_line":"      name: VDU2-multi"},{"line_number":55,"context_line":"      metadata: { multiattach: \"\u003cis\u003e True\" }"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"# delete the following lines when extmanagedVLs are specified in instantiatevnfrequest"},{"line_number":58,"context_line":"  internalVL1:"},{"line_number":59,"context_line":"    type: OS::Neutron::Net"},{"line_number":60,"context_line":"  internalVL2:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"1492a9cf_18fa25a8","line":57,"range":{"start_line":57,"start_character":65,"end_line":57,"end_character":86},"updated":"2023-03-06 04:06:32.000000000","message":"nits: InstantiateVnfRequest","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"d55617e8836d80895ddeb621bc1abe32b0f71263","unresolved":true,"context_lines":[{"line_number":54,"context_line":"      name: VDU2-multi"},{"line_number":55,"context_line":"      metadata: { multiattach: \"\u003cis\u003e True\" }"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"# delete the following lines when extmanagedVLs are specified in instantiatevnfrequest"},{"line_number":58,"context_line":"  internalVL1:"},{"line_number":59,"context_line":"    type: OS::Neutron::Net"},{"line_number":60,"context_line":"  internalVL2:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"6e42e48a_09cc350d","line":57,"range":{"start_line":57,"start_character":65,"end_line":57,"end_character":86},"in_reply_to":"1492a9cf_18fa25a8","updated":"2023-03-07 03:07:09.000000000","message":"ditto","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"f19e5ec3c81954db706cbc026364ed9a58b20ce0","unresolved":false,"context_lines":[{"line_number":54,"context_line":"      name: VDU2-multi"},{"line_number":55,"context_line":"      metadata: { multiattach: \"\u003cis\u003e True\" }"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"# delete the following lines when extmanagedVLs are specified in instantiatevnfrequest"},{"line_number":58,"context_line":"  internalVL1:"},{"line_number":59,"context_line":"    type: OS::Neutron::Net"},{"line_number":60,"context_line":"  internalVL2:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"18e59622_72db8139","line":57,"range":{"start_line":57,"start_character":65,"end_line":57,"end_character":86},"in_reply_to":"6e42e48a_09cc350d","updated":"2023-04-05 08:17:27.000000000","message":"Done","commit_id":"6dcd61e11fc706b5ff189baadf55c229d330b614"}],"tacker/tests/functional/sol_v2_individual_vnfc_mgmt/test_individual_vnfc_mgmt_basic.py":[{"author":{"_account_id":31668},"change_message_id":"592c4806744c43ba85272904d233c184b0f88674","unresolved":true,"context_lines":[{"line_number":75,"context_line":"            \"change_vnfpkg_or_update_min_individual_vnfc\")"},{"line_number":76,"context_line":"        cls.vnf_pkg_5, cls.vnfd_id_5 \u003d cls.create_vnf_package("},{"line_number":77,"context_line":"            pkg_path_5, image_path\u003dimage_path, userdata_path\u003duserdata_path)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        create_req \u003d paramgen.create_vnf_max("},{"line_number":80,"context_line":"            cls.vnfd_id_1, description\u003d\"test for basic_max_individual_vnfc\")"},{"line_number":81,"context_line":"        _, body \u003d cls.create_vnf_instance(cls, create_req)"},{"line_number":82,"context_line":"        cls.inst_id_1 \u003d body[\u0027id\u0027]"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        create_req \u003d paramgen.create_vnf_min(cls.vnfd_id_2)"},{"line_number":85,"context_line":"        _, body \u003d cls.create_vnf_instance(cls, create_req)"},{"line_number":86,"context_line":"        cls.inst_id_2 \u003d body[\u0027id\u0027]"},{"line_number":87,"context_line":"        cls._pre_setting()"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    @classmethod"},{"line_number":90,"context_line":"    def tearDownClass(cls):"}],"source_content_type":"text/x-python","patch_set":27,"id":"484014e0_7803ade3","line":87,"range":{"start_line":78,"start_character":0,"end_line":87,"end_character":26},"updated":"2023-03-09 23:45:17.000000000","message":"It is desirable that the VNF Instacne used for each test be independent.\nCould you please execute the create process in each test?","commit_id":"a0d1cec73b5724b48f50100a5bb978f14b222cbc"},{"author":{"_account_id":31668},"change_message_id":"7d7c9db679e6e9e88f919368404cb615e4a56383","unresolved":false,"context_lines":[{"line_number":75,"context_line":"            \"change_vnfpkg_or_update_min_individual_vnfc\")"},{"line_number":76,"context_line":"        cls.vnf_pkg_5, cls.vnfd_id_5 \u003d cls.create_vnf_package("},{"line_number":77,"context_line":"            pkg_path_5, image_path\u003dimage_path, userdata_path\u003duserdata_path)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        create_req \u003d paramgen.create_vnf_max("},{"line_number":80,"context_line":"            cls.vnfd_id_1, description\u003d\"test for basic_max_individual_vnfc\")"},{"line_number":81,"context_line":"        _, body \u003d cls.create_vnf_instance(cls, create_req)"},{"line_number":82,"context_line":"        cls.inst_id_1 \u003d body[\u0027id\u0027]"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        create_req \u003d paramgen.create_vnf_min(cls.vnfd_id_2)"},{"line_number":85,"context_line":"        _, body \u003d cls.create_vnf_instance(cls, create_req)"},{"line_number":86,"context_line":"        cls.inst_id_2 \u003d body[\u0027id\u0027]"},{"line_number":87,"context_line":"        cls._pre_setting()"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    @classmethod"},{"line_number":90,"context_line":"    def tearDownClass(cls):"}],"source_content_type":"text/x-python","patch_set":27,"id":"aa668611_a47002d5","line":87,"range":{"start_line":78,"start_character":0,"end_line":87,"end_character":26},"in_reply_to":"0de7f464_e082b9ac","updated":"2023-03-10 09:43:36.000000000","message":"Done","commit_id":"a0d1cec73b5724b48f50100a5bb978f14b222cbc"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"f048e7704eb5c256bfe4498a5cdddb65e220474c","unresolved":true,"context_lines":[{"line_number":75,"context_line":"            \"change_vnfpkg_or_update_min_individual_vnfc\")"},{"line_number":76,"context_line":"        cls.vnf_pkg_5, cls.vnfd_id_5 \u003d cls.create_vnf_package("},{"line_number":77,"context_line":"            pkg_path_5, image_path\u003dimage_path, userdata_path\u003duserdata_path)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        create_req \u003d paramgen.create_vnf_max("},{"line_number":80,"context_line":"            cls.vnfd_id_1, description\u003d\"test for basic_max_individual_vnfc\")"},{"line_number":81,"context_line":"        _, body \u003d cls.create_vnf_instance(cls, create_req)"},{"line_number":82,"context_line":"        cls.inst_id_1 \u003d body[\u0027id\u0027]"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        create_req \u003d paramgen.create_vnf_min(cls.vnfd_id_2)"},{"line_number":85,"context_line":"        _, body \u003d cls.create_vnf_instance(cls, create_req)"},{"line_number":86,"context_line":"        cls.inst_id_2 \u003d body[\u0027id\u0027]"},{"line_number":87,"context_line":"        cls._pre_setting()"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    @classmethod"},{"line_number":90,"context_line":"    def tearDownClass(cls):"}],"source_content_type":"text/x-python","patch_set":27,"id":"0de7f464_e082b9ac","line":87,"range":{"start_line":78,"start_character":0,"end_line":87,"end_character":26},"in_reply_to":"484014e0_7803ade3","updated":"2023-03-10 07:52:35.000000000","message":"I made it independent in PS32.","commit_id":"a0d1cec73b5724b48f50100a5bb978f14b222cbc"},{"author":{"_account_id":31668},"change_message_id":"592c4806744c43ba85272904d233c184b0f88674","unresolved":true,"context_lines":[{"line_number":89,"context_line":"    @classmethod"},{"line_number":90,"context_line":"    def tearDownClass(cls):"},{"line_number":91,"context_line":"        super(IndividualVnfcMgmtBasicTest, cls).tearDownClass()"},{"line_number":92,"context_line":"        cls.delete_vnf_instance(cls, cls.inst_id_1)"},{"line_number":93,"context_line":"        cls.delete_vnf_instance(cls, cls.inst_id_2)"},{"line_number":94,"context_line":"        cls.delete_vnf_package(cls.vnf_pkg_1)"},{"line_number":95,"context_line":"        cls.delete_vnf_package(cls.vnf_pkg_2)"},{"line_number":96,"context_line":"        cls.delete_vnf_package(cls.vnf_pkg_3)"}],"source_content_type":"text/x-python","patch_set":27,"id":"0cb3edb6_fba720fb","line":93,"range":{"start_line":92,"start_character":0,"end_line":93,"end_character":51},"updated":"2023-03-09 23:45:17.000000000","message":"It is desirable that the VNF Instacne used for each test be independent.\nCould you please execute the delete process in each test?","commit_id":"a0d1cec73b5724b48f50100a5bb978f14b222cbc"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"f048e7704eb5c256bfe4498a5cdddb65e220474c","unresolved":true,"context_lines":[{"line_number":89,"context_line":"    @classmethod"},{"line_number":90,"context_line":"    def tearDownClass(cls):"},{"line_number":91,"context_line":"        super(IndividualVnfcMgmtBasicTest, cls).tearDownClass()"},{"line_number":92,"context_line":"        cls.delete_vnf_instance(cls, cls.inst_id_1)"},{"line_number":93,"context_line":"        cls.delete_vnf_instance(cls, cls.inst_id_2)"},{"line_number":94,"context_line":"        cls.delete_vnf_package(cls.vnf_pkg_1)"},{"line_number":95,"context_line":"        cls.delete_vnf_package(cls.vnf_pkg_2)"},{"line_number":96,"context_line":"        cls.delete_vnf_package(cls.vnf_pkg_3)"}],"source_content_type":"text/x-python","patch_set":27,"id":"2035e0d7_7ea5121d","line":93,"range":{"start_line":92,"start_character":0,"end_line":93,"end_character":51},"in_reply_to":"0cb3edb6_fba720fb","updated":"2023-03-10 07:52:35.000000000","message":"I made it independent in PS32.","commit_id":"a0d1cec73b5724b48f50100a5bb978f14b222cbc"},{"author":{"_account_id":31668},"change_message_id":"7d7c9db679e6e9e88f919368404cb615e4a56383","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    @classmethod"},{"line_number":90,"context_line":"    def tearDownClass(cls):"},{"line_number":91,"context_line":"        super(IndividualVnfcMgmtBasicTest, cls).tearDownClass()"},{"line_number":92,"context_line":"        cls.delete_vnf_instance(cls, cls.inst_id_1)"},{"line_number":93,"context_line":"        cls.delete_vnf_instance(cls, cls.inst_id_2)"},{"line_number":94,"context_line":"        cls.delete_vnf_package(cls.vnf_pkg_1)"},{"line_number":95,"context_line":"        cls.delete_vnf_package(cls.vnf_pkg_2)"},{"line_number":96,"context_line":"        cls.delete_vnf_package(cls.vnf_pkg_3)"}],"source_content_type":"text/x-python","patch_set":27,"id":"1abda068_fddf1ae7","line":93,"range":{"start_line":92,"start_character":0,"end_line":93,"end_character":51},"in_reply_to":"2035e0d7_7ea5121d","updated":"2023-03-10 09:43:36.000000000","message":"Done","commit_id":"a0d1cec73b5724b48f50100a5bb978f14b222cbc"},{"author":{"_account_id":31668},"change_message_id":"0a0918eb3a26f2036739cb33911ef8583a19896d","unresolved":true,"context_lines":[{"line_number":351,"context_line":"        self.assertEqual(\u0027nova\u0027, vdu1_az)"},{"line_number":352,"context_line":"        self.assertEqual(\u0027nova\u0027, vdu2_az)"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"        # 2. Show VNF instance(check for instantiate)"},{"line_number":355,"context_line":"        expected_inst_attrs \u003d ["},{"line_number":356,"context_line":"            \u0027id\u0027,"},{"line_number":357,"context_line":"            \u0027vnfInstanceName\u0027,"}],"source_content_type":"text/x-python","patch_set":32,"id":"337d257b_a6841a44","line":354,"updated":"2023-03-23 05:52:35.000000000","message":"Could you please add the following?\n```\n        # NOTE: extensions and vnfConfigurableProperties are omitted\n        # because they are commented out in etsi_nfv_sol001.\n```","commit_id":"8b3c90da45827a66cc83b1a4c3ac0c8e543811e9"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"040796c7352f0e4ac2794dcaa7a80c9ad63dcd30","unresolved":true,"context_lines":[{"line_number":351,"context_line":"        self.assertEqual(\u0027nova\u0027, vdu1_az)"},{"line_number":352,"context_line":"        self.assertEqual(\u0027nova\u0027, vdu2_az)"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"        # 2. Show VNF instance(check for instantiate)"},{"line_number":355,"context_line":"        expected_inst_attrs \u003d ["},{"line_number":356,"context_line":"            \u0027id\u0027,"},{"line_number":357,"context_line":"            \u0027vnfInstanceName\u0027,"}],"source_content_type":"text/x-python","patch_set":32,"id":"605e3662_67788186","line":354,"in_reply_to":"337d257b_a6841a44","updated":"2023-03-27 06:13:15.000000000","message":"I added this note in PS33.","commit_id":"8b3c90da45827a66cc83b1a4c3ac0c8e543811e9"},{"author":{"_account_id":31668},"change_message_id":"7f72cf6a9e291cdff550128501ac67d4e4ee737d","unresolved":false,"context_lines":[{"line_number":351,"context_line":"        self.assertEqual(\u0027nova\u0027, vdu1_az)"},{"line_number":352,"context_line":"        self.assertEqual(\u0027nova\u0027, vdu2_az)"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"        # 2. Show VNF instance(check for instantiate)"},{"line_number":355,"context_line":"        expected_inst_attrs \u003d ["},{"line_number":356,"context_line":"            \u0027id\u0027,"},{"line_number":357,"context_line":"            \u0027vnfInstanceName\u0027,"}],"source_content_type":"text/x-python","patch_set":32,"id":"23748676_0a1cadfd","line":354,"in_reply_to":"605e3662_67788186","updated":"2023-03-28 10:09:49.000000000","message":"Done","commit_id":"8b3c90da45827a66cc83b1a4c3ac0c8e543811e9"},{"author":{"_account_id":31668},"change_message_id":"0a0918eb3a26f2036739cb33911ef8583a19896d","unresolved":true,"context_lines":[{"line_number":369,"context_line":"            # \u0027extensions\u0027, # omitted"},{"line_number":370,"context_line":"            \u0027_links\u0027"},{"line_number":371,"context_line":"        ]"},{"line_number":372,"context_line":"        additional_inst_attrs \u003d ["},{"line_number":373,"context_line":"            \u0027vimConnectionInfo\u0027,"},{"line_number":374,"context_line":"            \u0027instantiatedVnfInfo\u0027"},{"line_number":375,"context_line":"        ]"},{"line_number":376,"context_line":"        expected_inst_attrs.extend(additional_inst_attrs)"},{"line_number":377,"context_line":"        vdu_result \u003d {\u0027VDU1\u0027: {0}, \u0027VDU2\u0027: {0}}"},{"line_number":378,"context_line":"        image_result \u003d {\u0027VDU1\u0027: {\u0027image-VDU1-VirtualStorage-0\u0027},"},{"line_number":379,"context_line":"                        \u0027VDU2\u0027: {\u0027image-VDU2-VirtualStorage-0\u0027}}"}],"source_content_type":"text/x-python","patch_set":32,"id":"c72588a8_a9965d1d","line":376,"range":{"start_line":372,"start_character":0,"end_line":376,"end_character":57},"updated":"2023-03-23 05:52:35.000000000","message":"In this test, the attributes of VNF Instance in NOT_INSTANTIATED state is not checked.\nHow about setting all attributes to expected_inst_attrs without dividing them?","commit_id":"8b3c90da45827a66cc83b1a4c3ac0c8e543811e9"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"040796c7352f0e4ac2794dcaa7a80c9ad63dcd30","unresolved":true,"context_lines":[{"line_number":369,"context_line":"            # \u0027extensions\u0027, # omitted"},{"line_number":370,"context_line":"            \u0027_links\u0027"},{"line_number":371,"context_line":"        ]"},{"line_number":372,"context_line":"        additional_inst_attrs \u003d ["},{"line_number":373,"context_line":"            \u0027vimConnectionInfo\u0027,"},{"line_number":374,"context_line":"            \u0027instantiatedVnfInfo\u0027"},{"line_number":375,"context_line":"        ]"},{"line_number":376,"context_line":"        expected_inst_attrs.extend(additional_inst_attrs)"},{"line_number":377,"context_line":"        vdu_result \u003d {\u0027VDU1\u0027: {0}, \u0027VDU2\u0027: {0}}"},{"line_number":378,"context_line":"        image_result \u003d {\u0027VDU1\u0027: {\u0027image-VDU1-VirtualStorage-0\u0027},"},{"line_number":379,"context_line":"                        \u0027VDU2\u0027: {\u0027image-VDU2-VirtualStorage-0\u0027}}"}],"source_content_type":"text/x-python","patch_set":32,"id":"eef47470_5c5a36bc","line":376,"range":{"start_line":372,"start_character":0,"end_line":376,"end_character":57},"in_reply_to":"c72588a8_a9965d1d","updated":"2023-03-27 06:13:15.000000000","message":"I deleted additional_inst_attrs in PS33.","commit_id":"8b3c90da45827a66cc83b1a4c3ac0c8e543811e9"},{"author":{"_account_id":31668},"change_message_id":"7f72cf6a9e291cdff550128501ac67d4e4ee737d","unresolved":false,"context_lines":[{"line_number":369,"context_line":"            # \u0027extensions\u0027, # omitted"},{"line_number":370,"context_line":"            \u0027_links\u0027"},{"line_number":371,"context_line":"        ]"},{"line_number":372,"context_line":"        additional_inst_attrs \u003d ["},{"line_number":373,"context_line":"            \u0027vimConnectionInfo\u0027,"},{"line_number":374,"context_line":"            \u0027instantiatedVnfInfo\u0027"},{"line_number":375,"context_line":"        ]"},{"line_number":376,"context_line":"        expected_inst_attrs.extend(additional_inst_attrs)"},{"line_number":377,"context_line":"        vdu_result \u003d {\u0027VDU1\u0027: {0}, \u0027VDU2\u0027: {0}}"},{"line_number":378,"context_line":"        image_result \u003d {\u0027VDU1\u0027: {\u0027image-VDU1-VirtualStorage-0\u0027},"},{"line_number":379,"context_line":"                        \u0027VDU2\u0027: {\u0027image-VDU2-VirtualStorage-0\u0027}}"}],"source_content_type":"text/x-python","patch_set":32,"id":"ed3b531a_1b16a37a","line":376,"range":{"start_line":372,"start_character":0,"end_line":376,"end_character":57},"in_reply_to":"eef47470_5c5a36bc","updated":"2023-03-28 10:09:49.000000000","message":"Done","commit_id":"8b3c90da45827a66cc83b1a4c3ac0c8e543811e9"},{"author":{"_account_id":31668},"change_message_id":"0a0918eb3a26f2036739cb33911ef8583a19896d","unresolved":true,"context_lines":[{"line_number":451,"context_line":"            \u0027stateEnteredTime\u0027,"},{"line_number":452,"context_line":"            \u0027startTime\u0027,"},{"line_number":453,"context_line":"            \u0027vnfInstanceId\u0027,"},{"line_number":454,"context_line":"            # \u0027grantId\u0027, # omitted"},{"line_number":455,"context_line":"            \u0027operation\u0027,"},{"line_number":456,"context_line":"            \u0027isAutomaticInvocation\u0027,"},{"line_number":457,"context_line":"            \u0027operationParams\u0027,"}],"source_content_type":"text/x-python","patch_set":32,"id":"4da37458_05d01776","line":454,"updated":"2023-03-23 05:52:35.000000000","message":"The `grantId` is also set from the Yoga version, so it is better to check the `grantId` without omitting it.","commit_id":"8b3c90da45827a66cc83b1a4c3ac0c8e543811e9"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"040796c7352f0e4ac2794dcaa7a80c9ad63dcd30","unresolved":true,"context_lines":[{"line_number":451,"context_line":"            \u0027stateEnteredTime\u0027,"},{"line_number":452,"context_line":"            \u0027startTime\u0027,"},{"line_number":453,"context_line":"            \u0027vnfInstanceId\u0027,"},{"line_number":454,"context_line":"            # \u0027grantId\u0027, # omitted"},{"line_number":455,"context_line":"            \u0027operation\u0027,"},{"line_number":456,"context_line":"            \u0027isAutomaticInvocation\u0027,"},{"line_number":457,"context_line":"            \u0027operationParams\u0027,"}],"source_content_type":"text/x-python","patch_set":32,"id":"d336436a_aaad7477","line":454,"in_reply_to":"4da37458_05d01776","updated":"2023-03-27 06:13:15.000000000","message":"I added grantId to check info in PS33.","commit_id":"8b3c90da45827a66cc83b1a4c3ac0c8e543811e9"},{"author":{"_account_id":31668},"change_message_id":"7f72cf6a9e291cdff550128501ac67d4e4ee737d","unresolved":false,"context_lines":[{"line_number":451,"context_line":"            \u0027stateEnteredTime\u0027,"},{"line_number":452,"context_line":"            \u0027startTime\u0027,"},{"line_number":453,"context_line":"            \u0027vnfInstanceId\u0027,"},{"line_number":454,"context_line":"            # \u0027grantId\u0027, # omitted"},{"line_number":455,"context_line":"            \u0027operation\u0027,"},{"line_number":456,"context_line":"            \u0027isAutomaticInvocation\u0027,"},{"line_number":457,"context_line":"            \u0027operationParams\u0027,"}],"source_content_type":"text/x-python","patch_set":32,"id":"f1efc8f4_5b0311e4","line":454,"in_reply_to":"d336436a_aaad7477","updated":"2023-03-28 10:09:49.000000000","message":"Done","commit_id":"8b3c90da45827a66cc83b1a4c3ac0c8e543811e9"},{"author":{"_account_id":31668},"change_message_id":"0a0918eb3a26f2036739cb33911ef8583a19896d","unresolved":true,"context_lines":[{"line_number":481,"context_line":""},{"line_number":482,"context_line":"        # 6. Show VNF instance(check for heal)"},{"line_number":483,"context_line":"        vdu_result \u003d {\u0027VDU1\u0027: {0}, \u0027VDU2\u0027: {0}}"},{"line_number":484,"context_line":"        inst_7 \u003d self._check_for_show_operation("},{"line_number":485,"context_line":"            \u0027HEAL\u0027, expected_inst_attrs, inst_id, vdu_result)"},{"line_number":486,"context_line":"        # check all ids of VDU changed"},{"line_number":487,"context_line":"        self.assertNotEqual(self._get_vnfc_id(inst_2, \u0027VDU1\u0027, 0),"}],"source_content_type":"text/x-python","patch_set":32,"id":"ad20e3cc_2ca1893a","line":484,"updated":"2023-03-23 05:52:35.000000000","message":"Why is 7 used in the number?\nI think 6 is better to match the test number.","commit_id":"8b3c90da45827a66cc83b1a4c3ac0c8e543811e9"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"040796c7352f0e4ac2794dcaa7a80c9ad63dcd30","unresolved":true,"context_lines":[{"line_number":481,"context_line":""},{"line_number":482,"context_line":"        # 6. Show VNF instance(check for heal)"},{"line_number":483,"context_line":"        vdu_result \u003d {\u0027VDU1\u0027: {0}, \u0027VDU2\u0027: {0}}"},{"line_number":484,"context_line":"        inst_7 \u003d self._check_for_show_operation("},{"line_number":485,"context_line":"            \u0027HEAL\u0027, expected_inst_attrs, inst_id, vdu_result)"},{"line_number":486,"context_line":"        # check all ids of VDU changed"},{"line_number":487,"context_line":"        self.assertNotEqual(self._get_vnfc_id(inst_2, \u0027VDU1\u0027, 0),"}],"source_content_type":"text/x-python","patch_set":32,"id":"d849760a_dbec7386","line":484,"in_reply_to":"ad20e3cc_2ca1893a","updated":"2023-03-27 06:13:15.000000000","message":"I changed it in PS33.","commit_id":"8b3c90da45827a66cc83b1a4c3ac0c8e543811e9"},{"author":{"_account_id":31668},"change_message_id":"7f72cf6a9e291cdff550128501ac67d4e4ee737d","unresolved":false,"context_lines":[{"line_number":481,"context_line":""},{"line_number":482,"context_line":"        # 6. Show VNF instance(check for heal)"},{"line_number":483,"context_line":"        vdu_result \u003d {\u0027VDU1\u0027: {0}, \u0027VDU2\u0027: {0}}"},{"line_number":484,"context_line":"        inst_7 \u003d self._check_for_show_operation("},{"line_number":485,"context_line":"            \u0027HEAL\u0027, expected_inst_attrs, inst_id, vdu_result)"},{"line_number":486,"context_line":"        # check all ids of VDU changed"},{"line_number":487,"context_line":"        self.assertNotEqual(self._get_vnfc_id(inst_2, \u0027VDU1\u0027, 0),"}],"source_content_type":"text/x-python","patch_set":32,"id":"c029d1c8_760bae59","line":484,"in_reply_to":"d849760a_dbec7386","updated":"2023-03-28 10:09:49.000000000","message":"Done","commit_id":"8b3c90da45827a66cc83b1a4c3ac0c8e543811e9"},{"author":{"_account_id":31668},"change_message_id":"0a0918eb3a26f2036739cb33911ef8583a19896d","unresolved":true,"context_lines":[{"line_number":483,"context_line":"        vdu_result \u003d {\u0027VDU1\u0027: {0}, \u0027VDU2\u0027: {0}}"},{"line_number":484,"context_line":"        inst_7 \u003d self._check_for_show_operation("},{"line_number":485,"context_line":"            \u0027HEAL\u0027, expected_inst_attrs, inst_id, vdu_result)"},{"line_number":486,"context_line":"        # check all ids of VDU changed"},{"line_number":487,"context_line":"        self.assertNotEqual(self._get_vnfc_id(inst_2, \u0027VDU1\u0027, 0),"},{"line_number":488,"context_line":"                            self._get_vnfc_id(inst_7, \u0027VDU1\u0027, 0))"},{"line_number":489,"context_line":"        self.assertNotEqual(self._get_vnfc_id(inst_2, \u0027VDU2\u0027, 0),"}],"source_content_type":"text/x-python","patch_set":32,"id":"edb7b49f_08de1a33","line":486,"updated":"2023-03-23 05:52:35.000000000","message":"nit: ids of VDU changed -\u003e ids of VDU are changed","commit_id":"8b3c90da45827a66cc83b1a4c3ac0c8e543811e9"},{"author":{"_account_id":31668},"change_message_id":"7f72cf6a9e291cdff550128501ac67d4e4ee737d","unresolved":false,"context_lines":[{"line_number":483,"context_line":"        vdu_result \u003d {\u0027VDU1\u0027: {0}, \u0027VDU2\u0027: {0}}"},{"line_number":484,"context_line":"        inst_7 \u003d self._check_for_show_operation("},{"line_number":485,"context_line":"            \u0027HEAL\u0027, expected_inst_attrs, inst_id, vdu_result)"},{"line_number":486,"context_line":"        # check all ids of VDU changed"},{"line_number":487,"context_line":"        self.assertNotEqual(self._get_vnfc_id(inst_2, \u0027VDU1\u0027, 0),"},{"line_number":488,"context_line":"                            self._get_vnfc_id(inst_7, \u0027VDU1\u0027, 0))"},{"line_number":489,"context_line":"        self.assertNotEqual(self._get_vnfc_id(inst_2, \u0027VDU2\u0027, 0),"}],"source_content_type":"text/x-python","patch_set":32,"id":"6fd18526_ccfde424","line":486,"in_reply_to":"4ea00eea_5fff5bd1","updated":"2023-03-28 10:09:49.000000000","message":"Done","commit_id":"8b3c90da45827a66cc83b1a4c3ac0c8e543811e9"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"040796c7352f0e4ac2794dcaa7a80c9ad63dcd30","unresolved":true,"context_lines":[{"line_number":483,"context_line":"        vdu_result \u003d {\u0027VDU1\u0027: {0}, \u0027VDU2\u0027: {0}}"},{"line_number":484,"context_line":"        inst_7 \u003d self._check_for_show_operation("},{"line_number":485,"context_line":"            \u0027HEAL\u0027, expected_inst_attrs, inst_id, vdu_result)"},{"line_number":486,"context_line":"        # check all ids of VDU changed"},{"line_number":487,"context_line":"        self.assertNotEqual(self._get_vnfc_id(inst_2, \u0027VDU1\u0027, 0),"},{"line_number":488,"context_line":"                            self._get_vnfc_id(inst_7, \u0027VDU1\u0027, 0))"},{"line_number":489,"context_line":"        self.assertNotEqual(self._get_vnfc_id(inst_2, \u0027VDU2\u0027, 0),"}],"source_content_type":"text/x-python","patch_set":32,"id":"4ea00eea_5fff5bd1","line":486,"in_reply_to":"edb7b49f_08de1a33","updated":"2023-03-27 06:13:15.000000000","message":"I fixed it in PS33.","commit_id":"8b3c90da45827a66cc83b1a4c3ac0c8e543811e9"},{"author":{"_account_id":31668},"change_message_id":"0a0918eb3a26f2036739cb33911ef8583a19896d","unresolved":true,"context_lines":[{"line_number":551,"context_line":"        vdu_result \u003d {\u0027VDU1\u0027: {0}, \u0027VDU2\u0027: {0}}"},{"line_number":552,"context_line":"        inst_9 \u003d self._check_for_show_operation("},{"line_number":553,"context_line":"            \u0027HEAL\u0027, expected_inst_attrs, inst_id, vdu_result)"},{"line_number":554,"context_line":"        # check all ids of VDU changed"},{"line_number":555,"context_line":"        self.assertNotEqual(self._get_vnfc_id(inst_7, \u0027VDU1\u0027, 0),"},{"line_number":556,"context_line":"                            self._get_vnfc_id(inst_9, \u0027VDU1\u0027, 0))"},{"line_number":557,"context_line":"        self.assertNotEqual(self._get_vnfc_id(inst_7, \u0027VDU2\u0027, 0),"}],"source_content_type":"text/x-python","patch_set":32,"id":"bc4e8b7b_71db537e","line":554,"updated":"2023-03-23 05:52:35.000000000","message":"nit: ids of VDU changed -\u003e ids of VDU are changed","commit_id":"8b3c90da45827a66cc83b1a4c3ac0c8e543811e9"},{"author":{"_account_id":31668},"change_message_id":"7f72cf6a9e291cdff550128501ac67d4e4ee737d","unresolved":false,"context_lines":[{"line_number":551,"context_line":"        vdu_result \u003d {\u0027VDU1\u0027: {0}, \u0027VDU2\u0027: {0}}"},{"line_number":552,"context_line":"        inst_9 \u003d self._check_for_show_operation("},{"line_number":553,"context_line":"            \u0027HEAL\u0027, expected_inst_attrs, inst_id, vdu_result)"},{"line_number":554,"context_line":"        # check all ids of VDU changed"},{"line_number":555,"context_line":"        self.assertNotEqual(self._get_vnfc_id(inst_7, \u0027VDU1\u0027, 0),"},{"line_number":556,"context_line":"                            self._get_vnfc_id(inst_9, \u0027VDU1\u0027, 0))"},{"line_number":557,"context_line":"        self.assertNotEqual(self._get_vnfc_id(inst_7, \u0027VDU2\u0027, 0),"}],"source_content_type":"text/x-python","patch_set":32,"id":"ad310d60_aa848f4c","line":554,"in_reply_to":"6c37f188_466a6fa5","updated":"2023-03-28 10:09:49.000000000","message":"Done","commit_id":"8b3c90da45827a66cc83b1a4c3ac0c8e543811e9"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"040796c7352f0e4ac2794dcaa7a80c9ad63dcd30","unresolved":true,"context_lines":[{"line_number":551,"context_line":"        vdu_result \u003d {\u0027VDU1\u0027: {0}, \u0027VDU2\u0027: {0}}"},{"line_number":552,"context_line":"        inst_9 \u003d self._check_for_show_operation("},{"line_number":553,"context_line":"            \u0027HEAL\u0027, expected_inst_attrs, inst_id, vdu_result)"},{"line_number":554,"context_line":"        # check all ids of VDU changed"},{"line_number":555,"context_line":"        self.assertNotEqual(self._get_vnfc_id(inst_7, \u0027VDU1\u0027, 0),"},{"line_number":556,"context_line":"                            self._get_vnfc_id(inst_9, \u0027VDU1\u0027, 0))"},{"line_number":557,"context_line":"        self.assertNotEqual(self._get_vnfc_id(inst_7, \u0027VDU2\u0027, 0),"}],"source_content_type":"text/x-python","patch_set":32,"id":"6c37f188_466a6fa5","line":554,"in_reply_to":"bc4e8b7b_71db537e","updated":"2023-03-27 06:13:15.000000000","message":"ditto","commit_id":"8b3c90da45827a66cc83b1a4c3ac0c8e543811e9"},{"author":{"_account_id":31668},"change_message_id":"0a0918eb3a26f2036739cb33911ef8583a19896d","unresolved":true,"context_lines":[{"line_number":561,"context_line":"                            self._get_vnfc_storage_ids(inst_9, \u0027VDU1\u0027, 0))"},{"line_number":562,"context_line":"        self.assertNotEqual(self._get_vnfc_storage_ids(inst_7, \u0027VDU2\u0027, 0),"},{"line_number":563,"context_line":"                            self._get_vnfc_storage_ids(inst_9, \u0027VDU2\u0027, 0))"},{"line_number":564,"context_line":"        # check cp are changed"},{"line_number":565,"context_line":"        for cp_1 in [\u0027VDU1_CP1\u0027, \u0027VDU1_CP2\u0027, \u0027VDU2_CP2\u0027]:"},{"line_number":566,"context_line":"            self.assertNotEqual("},{"line_number":567,"context_line":"                self._get_vnf_ext_cp_id(inst_7, cp_1.split(\u0027_\u0027)[0], 0, cp_1),"}],"source_content_type":"text/x-python","patch_set":32,"id":"b9f11bff_f4a1399f","line":564,"updated":"2023-03-23 05:52:35.000000000","message":"nit: cp are changed -\u003e cps are changed","commit_id":"8b3c90da45827a66cc83b1a4c3ac0c8e543811e9"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"040796c7352f0e4ac2794dcaa7a80c9ad63dcd30","unresolved":true,"context_lines":[{"line_number":561,"context_line":"                            self._get_vnfc_storage_ids(inst_9, \u0027VDU1\u0027, 0))"},{"line_number":562,"context_line":"        self.assertNotEqual(self._get_vnfc_storage_ids(inst_7, \u0027VDU2\u0027, 0),"},{"line_number":563,"context_line":"                            self._get_vnfc_storage_ids(inst_9, \u0027VDU2\u0027, 0))"},{"line_number":564,"context_line":"        # check cp are changed"},{"line_number":565,"context_line":"        for cp_1 in [\u0027VDU1_CP1\u0027, \u0027VDU1_CP2\u0027, \u0027VDU2_CP2\u0027]:"},{"line_number":566,"context_line":"            self.assertNotEqual("},{"line_number":567,"context_line":"                self._get_vnf_ext_cp_id(inst_7, cp_1.split(\u0027_\u0027)[0], 0, cp_1),"}],"source_content_type":"text/x-python","patch_set":32,"id":"da452061_c4e7acb4","line":564,"in_reply_to":"b9f11bff_f4a1399f","updated":"2023-03-27 06:13:15.000000000","message":"ditto","commit_id":"8b3c90da45827a66cc83b1a4c3ac0c8e543811e9"},{"author":{"_account_id":31668},"change_message_id":"7f72cf6a9e291cdff550128501ac67d4e4ee737d","unresolved":false,"context_lines":[{"line_number":561,"context_line":"                            self._get_vnfc_storage_ids(inst_9, \u0027VDU1\u0027, 0))"},{"line_number":562,"context_line":"        self.assertNotEqual(self._get_vnfc_storage_ids(inst_7, \u0027VDU2\u0027, 0),"},{"line_number":563,"context_line":"                            self._get_vnfc_storage_ids(inst_9, \u0027VDU2\u0027, 0))"},{"line_number":564,"context_line":"        # check cp are changed"},{"line_number":565,"context_line":"        for cp_1 in [\u0027VDU1_CP1\u0027, \u0027VDU1_CP2\u0027, \u0027VDU2_CP2\u0027]:"},{"line_number":566,"context_line":"            self.assertNotEqual("},{"line_number":567,"context_line":"                self._get_vnf_ext_cp_id(inst_7, cp_1.split(\u0027_\u0027)[0], 0, cp_1),"}],"source_content_type":"text/x-python","patch_set":32,"id":"fcac7a9b_56330618","line":564,"in_reply_to":"da452061_c4e7acb4","updated":"2023-03-28 10:09:49.000000000","message":"Done","commit_id":"8b3c90da45827a66cc83b1a4c3ac0c8e543811e9"},{"author":{"_account_id":31668},"change_message_id":"0a0918eb3a26f2036739cb33911ef8583a19896d","unresolved":true,"context_lines":[{"line_number":625,"context_line":"        vdu_result \u003d {\u0027VDU1\u0027: {0}, \u0027VDU2\u0027: {0}}"},{"line_number":626,"context_line":"        inst_15 \u003d self._check_for_show_operation("},{"line_number":627,"context_line":"            \u0027HEAL\u0027, expected_inst_attrs, inst_id, vdu_result)"},{"line_number":628,"context_line":"        # check id of VDU2 changed"},{"line_number":629,"context_line":"        self.assertNotEqual(self._get_vnfc_id(inst_13, \u0027VDU2\u0027, 0),"},{"line_number":630,"context_line":"                            self._get_vnfc_id(inst_15, \u0027VDU2\u0027, 0))"},{"line_number":631,"context_line":"        # check image of VDU2 not change"}],"source_content_type":"text/x-python","patch_set":32,"id":"52420618_a8d793f7","line":628,"updated":"2023-03-23 05:52:35.000000000","message":"nit: id of VDU2 changed -\u003e id of VDU2 is changed","commit_id":"8b3c90da45827a66cc83b1a4c3ac0c8e543811e9"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"040796c7352f0e4ac2794dcaa7a80c9ad63dcd30","unresolved":true,"context_lines":[{"line_number":625,"context_line":"        vdu_result \u003d {\u0027VDU1\u0027: {0}, \u0027VDU2\u0027: {0}}"},{"line_number":626,"context_line":"        inst_15 \u003d self._check_for_show_operation("},{"line_number":627,"context_line":"            \u0027HEAL\u0027, expected_inst_attrs, inst_id, vdu_result)"},{"line_number":628,"context_line":"        # check id of VDU2 changed"},{"line_number":629,"context_line":"        self.assertNotEqual(self._get_vnfc_id(inst_13, \u0027VDU2\u0027, 0),"},{"line_number":630,"context_line":"                            self._get_vnfc_id(inst_15, \u0027VDU2\u0027, 0))"},{"line_number":631,"context_line":"        # check image of VDU2 not change"}],"source_content_type":"text/x-python","patch_set":32,"id":"5528f462_6b253c1a","line":628,"in_reply_to":"52420618_a8d793f7","updated":"2023-03-27 06:13:15.000000000","message":"ditto","commit_id":"8b3c90da45827a66cc83b1a4c3ac0c8e543811e9"},{"author":{"_account_id":31668},"change_message_id":"7f72cf6a9e291cdff550128501ac67d4e4ee737d","unresolved":false,"context_lines":[{"line_number":625,"context_line":"        vdu_result \u003d {\u0027VDU1\u0027: {0}, \u0027VDU2\u0027: {0}}"},{"line_number":626,"context_line":"        inst_15 \u003d self._check_for_show_operation("},{"line_number":627,"context_line":"            \u0027HEAL\u0027, expected_inst_attrs, inst_id, vdu_result)"},{"line_number":628,"context_line":"        # check id of VDU2 changed"},{"line_number":629,"context_line":"        self.assertNotEqual(self._get_vnfc_id(inst_13, \u0027VDU2\u0027, 0),"},{"line_number":630,"context_line":"                            self._get_vnfc_id(inst_15, \u0027VDU2\u0027, 0))"},{"line_number":631,"context_line":"        # check image of VDU2 not change"}],"source_content_type":"text/x-python","patch_set":32,"id":"7470e5fc_e8fba787","line":628,"in_reply_to":"5528f462_6b253c1a","updated":"2023-03-28 10:09:49.000000000","message":"Done","commit_id":"8b3c90da45827a66cc83b1a4c3ac0c8e543811e9"},{"author":{"_account_id":31668},"change_message_id":"0a0918eb3a26f2036739cb33911ef8583a19896d","unresolved":true,"context_lines":[{"line_number":628,"context_line":"        # check id of VDU2 changed"},{"line_number":629,"context_line":"        self.assertNotEqual(self._get_vnfc_id(inst_13, \u0027VDU2\u0027, 0),"},{"line_number":630,"context_line":"                            self._get_vnfc_id(inst_15, \u0027VDU2\u0027, 0))"},{"line_number":631,"context_line":"        # check image of VDU2 not change"},{"line_number":632,"context_line":"        self.assertEqual(self._get_vnfc_image(inst_13, \u0027VDU2\u0027, 0),"},{"line_number":633,"context_line":"                         self._get_vnfc_image(inst_15, \u0027VDU2\u0027, 0))"},{"line_number":634,"context_line":""}],"source_content_type":"text/x-python","patch_set":32,"id":"54237161_220c53bf","line":631,"updated":"2023-03-23 05:52:35.000000000","message":"nit: image of VDU2 not change -\u003e image of VDU2 is not change","commit_id":"8b3c90da45827a66cc83b1a4c3ac0c8e543811e9"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"878d3176b1efb13b1e3dea24e56f20ccebdf0ece","unresolved":true,"context_lines":[{"line_number":628,"context_line":"        # check id of VDU2 changed"},{"line_number":629,"context_line":"        self.assertNotEqual(self._get_vnfc_id(inst_13, \u0027VDU2\u0027, 0),"},{"line_number":630,"context_line":"                            self._get_vnfc_id(inst_15, \u0027VDU2\u0027, 0))"},{"line_number":631,"context_line":"        # check image of VDU2 not change"},{"line_number":632,"context_line":"        self.assertEqual(self._get_vnfc_image(inst_13, \u0027VDU2\u0027, 0),"},{"line_number":633,"context_line":"                         self._get_vnfc_image(inst_15, \u0027VDU2\u0027, 0))"},{"line_number":634,"context_line":""}],"source_content_type":"text/x-python","patch_set":32,"id":"834a5437_0492e454","line":631,"in_reply_to":"048305dd_062eede3","updated":"2023-04-03 08:46:10.000000000","message":"I fixed it in PS37.","commit_id":"8b3c90da45827a66cc83b1a4c3ac0c8e543811e9"},{"author":{"_account_id":31668},"change_message_id":"7f72cf6a9e291cdff550128501ac67d4e4ee737d","unresolved":true,"context_lines":[{"line_number":628,"context_line":"        # check id of VDU2 changed"},{"line_number":629,"context_line":"        self.assertNotEqual(self._get_vnfc_id(inst_13, \u0027VDU2\u0027, 0),"},{"line_number":630,"context_line":"                            self._get_vnfc_id(inst_15, \u0027VDU2\u0027, 0))"},{"line_number":631,"context_line":"        # check image of VDU2 not change"},{"line_number":632,"context_line":"        self.assertEqual(self._get_vnfc_image(inst_13, \u0027VDU2\u0027, 0),"},{"line_number":633,"context_line":"                         self._get_vnfc_image(inst_15, \u0027VDU2\u0027, 0))"},{"line_number":634,"context_line":""}],"source_content_type":"text/x-python","patch_set":32,"id":"048305dd_062eede3","line":631,"in_reply_to":"515fa662_dc46e0e4","updated":"2023-03-28 10:09:49.000000000","message":"nit: image of VDU2 is not change -\u003e image of VDU2 is not changed","commit_id":"8b3c90da45827a66cc83b1a4c3ac0c8e543811e9"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"040796c7352f0e4ac2794dcaa7a80c9ad63dcd30","unresolved":true,"context_lines":[{"line_number":628,"context_line":"        # check id of VDU2 changed"},{"line_number":629,"context_line":"        self.assertNotEqual(self._get_vnfc_id(inst_13, \u0027VDU2\u0027, 0),"},{"line_number":630,"context_line":"                            self._get_vnfc_id(inst_15, \u0027VDU2\u0027, 0))"},{"line_number":631,"context_line":"        # check image of VDU2 not change"},{"line_number":632,"context_line":"        self.assertEqual(self._get_vnfc_image(inst_13, \u0027VDU2\u0027, 0),"},{"line_number":633,"context_line":"                         self._get_vnfc_image(inst_15, \u0027VDU2\u0027, 0))"},{"line_number":634,"context_line":""}],"source_content_type":"text/x-python","patch_set":32,"id":"515fa662_dc46e0e4","line":631,"in_reply_to":"54237161_220c53bf","updated":"2023-03-27 06:13:15.000000000","message":"ditto","commit_id":"8b3c90da45827a66cc83b1a4c3ac0c8e543811e9"},{"author":{"_account_id":31668},"change_message_id":"a2c4b01b4880d2e8b5a6492071fb856f65accb77","unresolved":false,"context_lines":[{"line_number":628,"context_line":"        # check id of VDU2 changed"},{"line_number":629,"context_line":"        self.assertNotEqual(self._get_vnfc_id(inst_13, \u0027VDU2\u0027, 0),"},{"line_number":630,"context_line":"                            self._get_vnfc_id(inst_15, \u0027VDU2\u0027, 0))"},{"line_number":631,"context_line":"        # check image of VDU2 not change"},{"line_number":632,"context_line":"        self.assertEqual(self._get_vnfc_image(inst_13, \u0027VDU2\u0027, 0),"},{"line_number":633,"context_line":"                         self._get_vnfc_image(inst_15, \u0027VDU2\u0027, 0))"},{"line_number":634,"context_line":""}],"source_content_type":"text/x-python","patch_set":32,"id":"e02d5925_ce48a919","line":631,"in_reply_to":"834a5437_0492e454","updated":"2023-04-04 08:01:02.000000000","message":"Done","commit_id":"8b3c90da45827a66cc83b1a4c3ac0c8e543811e9"},{"author":{"_account_id":31668},"change_message_id":"0a0918eb3a26f2036739cb33911ef8583a19896d","unresolved":true,"context_lines":[{"line_number":645,"context_line":"        # 17. Show VNF instance(check for change-ext-conn)"},{"line_number":646,"context_line":"        vdu_result \u003d {\u0027VDU1\u0027: {0}, \u0027VDU2\u0027: {0}}"},{"line_number":647,"context_line":"        inst_17 \u003d self._check_for_show_operation("},{"line_number":648,"context_line":"            \u0027CHANGE-EXT-CONN\u0027, expected_inst_attrs, inst_id, vdu_result)"},{"line_number":649,"context_line":"        # check vnfExtCPId of VDU changed"},{"line_number":650,"context_line":"        for cp_1 in [\u0027VDU1_CP1\u0027, \u0027VDU2_CP2\u0027]:"},{"line_number":651,"context_line":"            self.assertNotEqual("}],"source_content_type":"text/x-python","patch_set":32,"id":"6aba91de_0dfa335b","line":648,"updated":"2023-03-23 05:52:35.000000000","message":"It is better to set it to `CHANGE_EXT_CONN` according to the OperationParams value described in SOL.","commit_id":"8b3c90da45827a66cc83b1a4c3ac0c8e543811e9"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"040796c7352f0e4ac2794dcaa7a80c9ad63dcd30","unresolved":true,"context_lines":[{"line_number":645,"context_line":"        # 17. Show VNF instance(check for change-ext-conn)"},{"line_number":646,"context_line":"        vdu_result \u003d {\u0027VDU1\u0027: {0}, \u0027VDU2\u0027: {0}}"},{"line_number":647,"context_line":"        inst_17 \u003d self._check_for_show_operation("},{"line_number":648,"context_line":"            \u0027CHANGE-EXT-CONN\u0027, expected_inst_attrs, inst_id, vdu_result)"},{"line_number":649,"context_line":"        # check vnfExtCPId of VDU changed"},{"line_number":650,"context_line":"        for cp_1 in [\u0027VDU1_CP1\u0027, \u0027VDU2_CP2\u0027]:"},{"line_number":651,"context_line":"            self.assertNotEqual("}],"source_content_type":"text/x-python","patch_set":32,"id":"9dbb705b_333d75f2","line":648,"in_reply_to":"6aba91de_0dfa335b","updated":"2023-03-27 06:13:15.000000000","message":"I modified it to  CHANGE_EXT_CONN in PS33.","commit_id":"8b3c90da45827a66cc83b1a4c3ac0c8e543811e9"},{"author":{"_account_id":31668},"change_message_id":"7f72cf6a9e291cdff550128501ac67d4e4ee737d","unresolved":false,"context_lines":[{"line_number":645,"context_line":"        # 17. Show VNF instance(check for change-ext-conn)"},{"line_number":646,"context_line":"        vdu_result \u003d {\u0027VDU1\u0027: {0}, \u0027VDU2\u0027: {0}}"},{"line_number":647,"context_line":"        inst_17 \u003d self._check_for_show_operation("},{"line_number":648,"context_line":"            \u0027CHANGE-EXT-CONN\u0027, expected_inst_attrs, inst_id, vdu_result)"},{"line_number":649,"context_line":"        # check vnfExtCPId of VDU changed"},{"line_number":650,"context_line":"        for cp_1 in [\u0027VDU1_CP1\u0027, \u0027VDU2_CP2\u0027]:"},{"line_number":651,"context_line":"            self.assertNotEqual("}],"source_content_type":"text/x-python","patch_set":32,"id":"1088de96_bbf91c4c","line":648,"in_reply_to":"9dbb705b_333d75f2","updated":"2023-03-28 10:09:49.000000000","message":"Done","commit_id":"8b3c90da45827a66cc83b1a4c3ac0c8e543811e9"},{"author":{"_account_id":31668},"change_message_id":"0a0918eb3a26f2036739cb33911ef8583a19896d","unresolved":true,"context_lines":[{"line_number":646,"context_line":"        vdu_result \u003d {\u0027VDU1\u0027: {0}, \u0027VDU2\u0027: {0}}"},{"line_number":647,"context_line":"        inst_17 \u003d self._check_for_show_operation("},{"line_number":648,"context_line":"            \u0027CHANGE-EXT-CONN\u0027, expected_inst_attrs, inst_id, vdu_result)"},{"line_number":649,"context_line":"        # check vnfExtCPId of VDU changed"},{"line_number":650,"context_line":"        for cp_1 in [\u0027VDU1_CP1\u0027, \u0027VDU2_CP2\u0027]:"},{"line_number":651,"context_line":"            self.assertNotEqual("},{"line_number":652,"context_line":"                self._get_vnf_ext_cp_id(inst_15, cp_1.split(\u0027_\u0027)[0], 0, cp_1),"}],"source_content_type":"text/x-python","patch_set":32,"id":"18cd58db_c48fda60","line":649,"updated":"2023-03-23 05:52:35.000000000","message":"nit: vnfExtCPId of VDU changed -\u003e vnfExtCPIds of VDU are changed","commit_id":"8b3c90da45827a66cc83b1a4c3ac0c8e543811e9"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"040796c7352f0e4ac2794dcaa7a80c9ad63dcd30","unresolved":true,"context_lines":[{"line_number":646,"context_line":"        vdu_result \u003d {\u0027VDU1\u0027: {0}, \u0027VDU2\u0027: {0}}"},{"line_number":647,"context_line":"        inst_17 \u003d self._check_for_show_operation("},{"line_number":648,"context_line":"            \u0027CHANGE-EXT-CONN\u0027, expected_inst_attrs, inst_id, vdu_result)"},{"line_number":649,"context_line":"        # check vnfExtCPId of VDU changed"},{"line_number":650,"context_line":"        for cp_1 in [\u0027VDU1_CP1\u0027, \u0027VDU2_CP2\u0027]:"},{"line_number":651,"context_line":"            self.assertNotEqual("},{"line_number":652,"context_line":"                self._get_vnf_ext_cp_id(inst_15, cp_1.split(\u0027_\u0027)[0], 0, cp_1),"}],"source_content_type":"text/x-python","patch_set":32,"id":"d70ba4c7_beebf19a","line":649,"in_reply_to":"18cd58db_c48fda60","updated":"2023-03-27 06:13:15.000000000","message":"I fixed it in PS33.","commit_id":"8b3c90da45827a66cc83b1a4c3ac0c8e543811e9"},{"author":{"_account_id":31668},"change_message_id":"7f72cf6a9e291cdff550128501ac67d4e4ee737d","unresolved":false,"context_lines":[{"line_number":646,"context_line":"        vdu_result \u003d {\u0027VDU1\u0027: {0}, \u0027VDU2\u0027: {0}}"},{"line_number":647,"context_line":"        inst_17 \u003d self._check_for_show_operation("},{"line_number":648,"context_line":"            \u0027CHANGE-EXT-CONN\u0027, expected_inst_attrs, inst_id, vdu_result)"},{"line_number":649,"context_line":"        # check vnfExtCPId of VDU changed"},{"line_number":650,"context_line":"        for cp_1 in [\u0027VDU1_CP1\u0027, \u0027VDU2_CP2\u0027]:"},{"line_number":651,"context_line":"            self.assertNotEqual("},{"line_number":652,"context_line":"                self._get_vnf_ext_cp_id(inst_15, cp_1.split(\u0027_\u0027)[0], 0, cp_1),"}],"source_content_type":"text/x-python","patch_set":32,"id":"1fbc1bd7_bee705e7","line":649,"in_reply_to":"d70ba4c7_beebf19a","updated":"2023-03-28 10:09:49.000000000","message":"Done","commit_id":"8b3c90da45827a66cc83b1a4c3ac0c8e543811e9"},{"author":{"_account_id":31668},"change_message_id":"0a0918eb3a26f2036739cb33911ef8583a19896d","unresolved":true,"context_lines":[{"line_number":667,"context_line":"        vdu_result \u003d {\u0027VDU1\u0027: {0}, \u0027VDU2\u0027: {0}}"},{"line_number":668,"context_line":"        inst_19 \u003d self._check_for_show_operation("},{"line_number":669,"context_line":"            \u0027HEAL\u0027, expected_inst_attrs, inst_id, vdu_result)"},{"line_number":670,"context_line":"        # check all ids of VDU changed"},{"line_number":671,"context_line":"        self.assertNotEqual(self._get_vnfc_id(inst_17, \u0027VDU1\u0027, 0),"},{"line_number":672,"context_line":"                            self._get_vnfc_id(inst_19, \u0027VDU1\u0027, 0))"},{"line_number":673,"context_line":"        self.assertNotEqual(self._get_vnfc_id(inst_17, \u0027VDU2\u0027, 0),"}],"source_content_type":"text/x-python","patch_set":32,"id":"f9013db1_22da8343","line":670,"updated":"2023-03-23 05:52:35.000000000","message":"nit: ids of VDU changed -\u003e ids of VDU are changed","commit_id":"8b3c90da45827a66cc83b1a4c3ac0c8e543811e9"},{"author":{"_account_id":31668},"change_message_id":"7f72cf6a9e291cdff550128501ac67d4e4ee737d","unresolved":false,"context_lines":[{"line_number":667,"context_line":"        vdu_result \u003d {\u0027VDU1\u0027: {0}, \u0027VDU2\u0027: {0}}"},{"line_number":668,"context_line":"        inst_19 \u003d self._check_for_show_operation("},{"line_number":669,"context_line":"            \u0027HEAL\u0027, expected_inst_attrs, inst_id, vdu_result)"},{"line_number":670,"context_line":"        # check all ids of VDU changed"},{"line_number":671,"context_line":"        self.assertNotEqual(self._get_vnfc_id(inst_17, \u0027VDU1\u0027, 0),"},{"line_number":672,"context_line":"                            self._get_vnfc_id(inst_19, \u0027VDU1\u0027, 0))"},{"line_number":673,"context_line":"        self.assertNotEqual(self._get_vnfc_id(inst_17, \u0027VDU2\u0027, 0),"}],"source_content_type":"text/x-python","patch_set":32,"id":"91c75fcf_da50fec7","line":670,"in_reply_to":"b07bf451_d91bc625","updated":"2023-03-28 10:09:49.000000000","message":"Done","commit_id":"8b3c90da45827a66cc83b1a4c3ac0c8e543811e9"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"040796c7352f0e4ac2794dcaa7a80c9ad63dcd30","unresolved":true,"context_lines":[{"line_number":667,"context_line":"        vdu_result \u003d {\u0027VDU1\u0027: {0}, \u0027VDU2\u0027: {0}}"},{"line_number":668,"context_line":"        inst_19 \u003d self._check_for_show_operation("},{"line_number":669,"context_line":"            \u0027HEAL\u0027, expected_inst_attrs, inst_id, vdu_result)"},{"line_number":670,"context_line":"        # check all ids of VDU changed"},{"line_number":671,"context_line":"        self.assertNotEqual(self._get_vnfc_id(inst_17, \u0027VDU1\u0027, 0),"},{"line_number":672,"context_line":"                            self._get_vnfc_id(inst_19, \u0027VDU1\u0027, 0))"},{"line_number":673,"context_line":"        self.assertNotEqual(self._get_vnfc_id(inst_17, \u0027VDU2\u0027, 0),"}],"source_content_type":"text/x-python","patch_set":32,"id":"b07bf451_d91bc625","line":670,"in_reply_to":"f9013db1_22da8343","updated":"2023-03-27 06:13:15.000000000","message":"ditto","commit_id":"8b3c90da45827a66cc83b1a4c3ac0c8e543811e9"},{"author":{"_account_id":31668},"change_message_id":"0a0918eb3a26f2036739cb33911ef8583a19896d","unresolved":true,"context_lines":[{"line_number":693,"context_line":"        vdu_result \u003d {\u0027VDU1\u0027: {0}, \u0027VDU2\u0027: {0}}"},{"line_number":694,"context_line":"        inst_21 \u003d self._check_for_show_operation("},{"line_number":695,"context_line":"            \u0027HEAL\u0027, expected_inst_attrs, inst_id, vdu_result)"},{"line_number":696,"context_line":"        # check all ids of VDU changed"},{"line_number":697,"context_line":"        self.assertNotEqual(self._get_vnfc_id(inst_19, \u0027VDU1\u0027, 0),"},{"line_number":698,"context_line":"                            self._get_vnfc_id(inst_21, \u0027VDU1\u0027, 0))"},{"line_number":699,"context_line":"        self.assertNotEqual(self._get_vnfc_id(inst_19, \u0027VDU2\u0027, 0),"}],"source_content_type":"text/x-python","patch_set":32,"id":"1c7bb612_30279fd7","line":696,"updated":"2023-03-23 05:52:35.000000000","message":"nit: ids of VDU changed -\u003e ids of VDU are changed","commit_id":"8b3c90da45827a66cc83b1a4c3ac0c8e543811e9"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"040796c7352f0e4ac2794dcaa7a80c9ad63dcd30","unresolved":true,"context_lines":[{"line_number":693,"context_line":"        vdu_result \u003d {\u0027VDU1\u0027: {0}, \u0027VDU2\u0027: {0}}"},{"line_number":694,"context_line":"        inst_21 \u003d self._check_for_show_operation("},{"line_number":695,"context_line":"            \u0027HEAL\u0027, expected_inst_attrs, inst_id, vdu_result)"},{"line_number":696,"context_line":"        # check all ids of VDU changed"},{"line_number":697,"context_line":"        self.assertNotEqual(self._get_vnfc_id(inst_19, \u0027VDU1\u0027, 0),"},{"line_number":698,"context_line":"                            self._get_vnfc_id(inst_21, \u0027VDU1\u0027, 0))"},{"line_number":699,"context_line":"        self.assertNotEqual(self._get_vnfc_id(inst_19, \u0027VDU2\u0027, 0),"}],"source_content_type":"text/x-python","patch_set":32,"id":"521efa24_f5cbce8d","line":696,"in_reply_to":"1c7bb612_30279fd7","updated":"2023-03-27 06:13:15.000000000","message":"ditto","commit_id":"8b3c90da45827a66cc83b1a4c3ac0c8e543811e9"},{"author":{"_account_id":31668},"change_message_id":"7f72cf6a9e291cdff550128501ac67d4e4ee737d","unresolved":false,"context_lines":[{"line_number":693,"context_line":"        vdu_result \u003d {\u0027VDU1\u0027: {0}, \u0027VDU2\u0027: {0}}"},{"line_number":694,"context_line":"        inst_21 \u003d self._check_for_show_operation("},{"line_number":695,"context_line":"            \u0027HEAL\u0027, expected_inst_attrs, inst_id, vdu_result)"},{"line_number":696,"context_line":"        # check all ids of VDU changed"},{"line_number":697,"context_line":"        self.assertNotEqual(self._get_vnfc_id(inst_19, \u0027VDU1\u0027, 0),"},{"line_number":698,"context_line":"                            self._get_vnfc_id(inst_21, \u0027VDU1\u0027, 0))"},{"line_number":699,"context_line":"        self.assertNotEqual(self._get_vnfc_id(inst_19, \u0027VDU2\u0027, 0),"}],"source_content_type":"text/x-python","patch_set":32,"id":"c6ef7a84_c7e27333","line":696,"in_reply_to":"521efa24_f5cbce8d","updated":"2023-03-28 10:09:49.000000000","message":"Done","commit_id":"8b3c90da45827a66cc83b1a4c3ac0c8e543811e9"},{"author":{"_account_id":31668},"change_message_id":"0a0918eb3a26f2036739cb33911ef8583a19896d","unresolved":true,"context_lines":[{"line_number":719,"context_line":"        vdu_result \u003d {\u0027VDU1\u0027: {0}, \u0027VDU2\u0027: {0}}"},{"line_number":720,"context_line":"        inst_23 \u003d self._check_for_show_operation("},{"line_number":721,"context_line":"            \u0027HEAL\u0027, expected_inst_attrs, inst_id, vdu_result)"},{"line_number":722,"context_line":"        # check all ids of VDU changed"},{"line_number":723,"context_line":"        self.assertNotEqual(self._get_vnfc_id(inst_21, \u0027VDU1\u0027, 0),"},{"line_number":724,"context_line":"                            self._get_vnfc_id(inst_23, \u0027VDU1\u0027, 0))"},{"line_number":725,"context_line":"        self.assertNotEqual(self._get_vnfc_id(inst_21, \u0027VDU2\u0027, 0),"}],"source_content_type":"text/x-python","patch_set":32,"id":"06dd4dc7_9da5da1c","line":722,"updated":"2023-03-23 05:52:35.000000000","message":"nit: ids of VDU changed -\u003e ids of VDU are changed","commit_id":"8b3c90da45827a66cc83b1a4c3ac0c8e543811e9"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"040796c7352f0e4ac2794dcaa7a80c9ad63dcd30","unresolved":true,"context_lines":[{"line_number":719,"context_line":"        vdu_result \u003d {\u0027VDU1\u0027: {0}, \u0027VDU2\u0027: {0}}"},{"line_number":720,"context_line":"        inst_23 \u003d self._check_for_show_operation("},{"line_number":721,"context_line":"            \u0027HEAL\u0027, expected_inst_attrs, inst_id, vdu_result)"},{"line_number":722,"context_line":"        # check all ids of VDU changed"},{"line_number":723,"context_line":"        self.assertNotEqual(self._get_vnfc_id(inst_21, \u0027VDU1\u0027, 0),"},{"line_number":724,"context_line":"                            self._get_vnfc_id(inst_23, \u0027VDU1\u0027, 0))"},{"line_number":725,"context_line":"        self.assertNotEqual(self._get_vnfc_id(inst_21, \u0027VDU2\u0027, 0),"}],"source_content_type":"text/x-python","patch_set":32,"id":"aa1638a5_31f63411","line":722,"in_reply_to":"06dd4dc7_9da5da1c","updated":"2023-03-27 06:13:15.000000000","message":"ditto","commit_id":"8b3c90da45827a66cc83b1a4c3ac0c8e543811e9"},{"author":{"_account_id":31668},"change_message_id":"7f72cf6a9e291cdff550128501ac67d4e4ee737d","unresolved":false,"context_lines":[{"line_number":719,"context_line":"        vdu_result \u003d {\u0027VDU1\u0027: {0}, \u0027VDU2\u0027: {0}}"},{"line_number":720,"context_line":"        inst_23 \u003d self._check_for_show_operation("},{"line_number":721,"context_line":"            \u0027HEAL\u0027, expected_inst_attrs, inst_id, vdu_result)"},{"line_number":722,"context_line":"        # check all ids of VDU changed"},{"line_number":723,"context_line":"        self.assertNotEqual(self._get_vnfc_id(inst_21, \u0027VDU1\u0027, 0),"},{"line_number":724,"context_line":"                            self._get_vnfc_id(inst_23, \u0027VDU1\u0027, 0))"},{"line_number":725,"context_line":"        self.assertNotEqual(self._get_vnfc_id(inst_21, \u0027VDU2\u0027, 0),"}],"source_content_type":"text/x-python","patch_set":32,"id":"0f721d0c_e772733c","line":722,"in_reply_to":"aa1638a5_31f63411","updated":"2023-03-28 10:09:49.000000000","message":"Done","commit_id":"8b3c90da45827a66cc83b1a4c3ac0c8e543811e9"},{"author":{"_account_id":31668},"change_message_id":"0a0918eb3a26f2036739cb33911ef8583a19896d","unresolved":true,"context_lines":[{"line_number":802,"context_line":"            \u0027CHANGE_VNFPKG\u0027, expected_inst_attrs, inst_id, vdu_result)"},{"line_number":803,"context_line":"        # check vnfdId"},{"line_number":804,"context_line":"        self.assertEqual(self.vnfd_id_4, inst_28[\u0027vnfdId\u0027])"},{"line_number":805,"context_line":"        # check all ids of VDU changed"},{"line_number":806,"context_line":"        self.assertNotEqual(self._get_vnfc_id(inst_25, \u0027VDU1\u0027, 0),"},{"line_number":807,"context_line":"                            self._get_vnfc_id(inst_28, \u0027VDU1\u0027, 0))"},{"line_number":808,"context_line":"        self.assertNotEqual(self._get_vnfc_id(inst_25, \u0027VDU2\u0027, 0),"}],"source_content_type":"text/x-python","patch_set":32,"id":"a9bc7593_6b839a70","line":805,"updated":"2023-03-23 05:52:35.000000000","message":"nit: ids of VDU changed -\u003e ids of VDU are changed","commit_id":"8b3c90da45827a66cc83b1a4c3ac0c8e543811e9"},{"author":{"_account_id":31668},"change_message_id":"7f72cf6a9e291cdff550128501ac67d4e4ee737d","unresolved":false,"context_lines":[{"line_number":802,"context_line":"            \u0027CHANGE_VNFPKG\u0027, expected_inst_attrs, inst_id, vdu_result)"},{"line_number":803,"context_line":"        # check vnfdId"},{"line_number":804,"context_line":"        self.assertEqual(self.vnfd_id_4, inst_28[\u0027vnfdId\u0027])"},{"line_number":805,"context_line":"        # check all ids of VDU changed"},{"line_number":806,"context_line":"        self.assertNotEqual(self._get_vnfc_id(inst_25, \u0027VDU1\u0027, 0),"},{"line_number":807,"context_line":"                            self._get_vnfc_id(inst_28, \u0027VDU1\u0027, 0))"},{"line_number":808,"context_line":"        self.assertNotEqual(self._get_vnfc_id(inst_25, \u0027VDU2\u0027, 0),"}],"source_content_type":"text/x-python","patch_set":32,"id":"28ed876d_12ef3c53","line":805,"in_reply_to":"5a3a9a6c_7a656f1a","updated":"2023-03-28 10:09:49.000000000","message":"Done","commit_id":"8b3c90da45827a66cc83b1a4c3ac0c8e543811e9"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"040796c7352f0e4ac2794dcaa7a80c9ad63dcd30","unresolved":true,"context_lines":[{"line_number":802,"context_line":"            \u0027CHANGE_VNFPKG\u0027, expected_inst_attrs, inst_id, vdu_result)"},{"line_number":803,"context_line":"        # check vnfdId"},{"line_number":804,"context_line":"        self.assertEqual(self.vnfd_id_4, inst_28[\u0027vnfdId\u0027])"},{"line_number":805,"context_line":"        # check all ids of VDU changed"},{"line_number":806,"context_line":"        self.assertNotEqual(self._get_vnfc_id(inst_25, \u0027VDU1\u0027, 0),"},{"line_number":807,"context_line":"                            self._get_vnfc_id(inst_28, \u0027VDU1\u0027, 0))"},{"line_number":808,"context_line":"        self.assertNotEqual(self._get_vnfc_id(inst_25, \u0027VDU2\u0027, 0),"}],"source_content_type":"text/x-python","patch_set":32,"id":"5a3a9a6c_7a656f1a","line":805,"in_reply_to":"a9bc7593_6b839a70","updated":"2023-03-27 06:13:15.000000000","message":"ditto","commit_id":"8b3c90da45827a66cc83b1a4c3ac0c8e543811e9"},{"author":{"_account_id":31668},"change_message_id":"0a0918eb3a26f2036739cb33911ef8583a19896d","unresolved":true,"context_lines":[{"line_number":819,"context_line":"        # check flavor is changed (VDU2 only)"},{"line_number":820,"context_line":"        self.assertNotEqual(self._get_vnfc_flavor(inst_25, \u0027VDU2\u0027, 0),"},{"line_number":821,"context_line":"                            self._get_vnfc_flavor(inst_28, \u0027VDU2\u0027, 0))"},{"line_number":822,"context_line":"        # check vnfExtCPId of VDU1_CP1 changed"},{"line_number":823,"context_line":"        self.assertNotEqual("},{"line_number":824,"context_line":"            self._get_vnf_ext_cp_id(inst_25, \u0027VDU1\u0027, 0, \u0027VDU1_CP1\u0027),"},{"line_number":825,"context_line":"            self._get_vnf_ext_cp_id(inst_28, \u0027VDU1\u0027, 0, \u0027VDU1_CP1\u0027))"}],"source_content_type":"text/x-python","patch_set":32,"id":"5a692f43_34cdef7a","line":822,"updated":"2023-03-23 05:52:35.000000000","message":"nit: VDU1_CP1 changed -\u003e VDU1_CP1 is changed","commit_id":"8b3c90da45827a66cc83b1a4c3ac0c8e543811e9"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"040796c7352f0e4ac2794dcaa7a80c9ad63dcd30","unresolved":true,"context_lines":[{"line_number":819,"context_line":"        # check flavor is changed (VDU2 only)"},{"line_number":820,"context_line":"        self.assertNotEqual(self._get_vnfc_flavor(inst_25, \u0027VDU2\u0027, 0),"},{"line_number":821,"context_line":"                            self._get_vnfc_flavor(inst_28, \u0027VDU2\u0027, 0))"},{"line_number":822,"context_line":"        # check vnfExtCPId of VDU1_CP1 changed"},{"line_number":823,"context_line":"        self.assertNotEqual("},{"line_number":824,"context_line":"            self._get_vnf_ext_cp_id(inst_25, \u0027VDU1\u0027, 0, \u0027VDU1_CP1\u0027),"},{"line_number":825,"context_line":"            self._get_vnf_ext_cp_id(inst_28, \u0027VDU1\u0027, 0, \u0027VDU1_CP1\u0027))"}],"source_content_type":"text/x-python","patch_set":32,"id":"b2b3da2d_13ed5b3b","line":822,"in_reply_to":"5a692f43_34cdef7a","updated":"2023-03-27 06:13:15.000000000","message":"ditto","commit_id":"8b3c90da45827a66cc83b1a4c3ac0c8e543811e9"},{"author":{"_account_id":31668},"change_message_id":"7f72cf6a9e291cdff550128501ac67d4e4ee737d","unresolved":false,"context_lines":[{"line_number":819,"context_line":"        # check flavor is changed (VDU2 only)"},{"line_number":820,"context_line":"        self.assertNotEqual(self._get_vnfc_flavor(inst_25, \u0027VDU2\u0027, 0),"},{"line_number":821,"context_line":"                            self._get_vnfc_flavor(inst_28, \u0027VDU2\u0027, 0))"},{"line_number":822,"context_line":"        # check vnfExtCPId of VDU1_CP1 changed"},{"line_number":823,"context_line":"        self.assertNotEqual("},{"line_number":824,"context_line":"            self._get_vnf_ext_cp_id(inst_25, \u0027VDU1\u0027, 0, \u0027VDU1_CP1\u0027),"},{"line_number":825,"context_line":"            self._get_vnf_ext_cp_id(inst_28, \u0027VDU1\u0027, 0, \u0027VDU1_CP1\u0027))"}],"source_content_type":"text/x-python","patch_set":32,"id":"226c4959_ccbbe5ee","line":822,"in_reply_to":"b2b3da2d_13ed5b3b","updated":"2023-03-28 10:09:49.000000000","message":"Done","commit_id":"8b3c90da45827a66cc83b1a4c3ac0c8e543811e9"},{"author":{"_account_id":31668},"change_message_id":"e899f3e35ae18d8aac877828de8250507e050678","unresolved":true,"context_lines":[{"line_number":748,"context_line":"        # 25. Show VNF instance(check for update)"},{"line_number":749,"context_line":"        vdu_result \u003d {\u0027VDU1\u0027: {0}, \u0027VDU2\u0027: {0}}"},{"line_number":750,"context_line":"        inst_25 \u003d self._check_for_show_operation("},{"line_number":751,"context_line":"            \u0027UPDATE\u0027, expected_inst_attrs, inst_id, vdu_result)"},{"line_number":752,"context_line":"        # check usageState of VNF Package 1"},{"line_number":753,"context_line":"        self._check_package_usage(self.vnf_pkg_1)"},{"line_number":754,"context_line":"        # check usageState of VNF Package 3"}],"source_content_type":"text/x-python","patch_set":33,"id":"85f600ef_c33eac0c","line":751,"updated":"2023-03-23 07:52:44.000000000","message":"It is better to set it to `MODIFY_INFO` according to the OperationParams value described in SOL.","commit_id":"57977db8e78bd5252c28eb855691d57affb77d05"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"040796c7352f0e4ac2794dcaa7a80c9ad63dcd30","unresolved":true,"context_lines":[{"line_number":748,"context_line":"        # 25. Show VNF instance(check for update)"},{"line_number":749,"context_line":"        vdu_result \u003d {\u0027VDU1\u0027: {0}, \u0027VDU2\u0027: {0}}"},{"line_number":750,"context_line":"        inst_25 \u003d self._check_for_show_operation("},{"line_number":751,"context_line":"            \u0027UPDATE\u0027, expected_inst_attrs, inst_id, vdu_result)"},{"line_number":752,"context_line":"        # check usageState of VNF Package 1"},{"line_number":753,"context_line":"        self._check_package_usage(self.vnf_pkg_1)"},{"line_number":754,"context_line":"        # check usageState of VNF Package 3"}],"source_content_type":"text/x-python","patch_set":33,"id":"ed6a97b5_a8738327","line":751,"in_reply_to":"85f600ef_c33eac0c","updated":"2023-03-27 06:13:15.000000000","message":"I fixed it in PS34.","commit_id":"57977db8e78bd5252c28eb855691d57affb77d05"},{"author":{"_account_id":31668},"change_message_id":"7f72cf6a9e291cdff550128501ac67d4e4ee737d","unresolved":false,"context_lines":[{"line_number":748,"context_line":"        # 25. Show VNF instance(check for update)"},{"line_number":749,"context_line":"        vdu_result \u003d {\u0027VDU1\u0027: {0}, \u0027VDU2\u0027: {0}}"},{"line_number":750,"context_line":"        inst_25 \u003d self._check_for_show_operation("},{"line_number":751,"context_line":"            \u0027UPDATE\u0027, expected_inst_attrs, inst_id, vdu_result)"},{"line_number":752,"context_line":"        # check usageState of VNF Package 1"},{"line_number":753,"context_line":"        self._check_package_usage(self.vnf_pkg_1)"},{"line_number":754,"context_line":"        # check usageState of VNF Package 3"}],"source_content_type":"text/x-python","patch_set":33,"id":"3a6eba9d_c033bbeb","line":751,"in_reply_to":"ed6a97b5_a8738327","updated":"2023-03-28 10:09:49.000000000","message":"Done","commit_id":"57977db8e78bd5252c28eb855691d57affb77d05"},{"author":{"_account_id":31668},"change_message_id":"e899f3e35ae18d8aac877828de8250507e050678","unresolved":true,"context_lines":[{"line_number":918,"context_line":"        vdu2_host \u003d vdu2_details[\u0027hostId\u0027]"},{"line_number":919,"context_line":"        self.assertEqual(vdu1_host, vdu2_host)"},{"line_number":920,"context_line":""},{"line_number":921,"context_line":"        # 2. Show VNF instance"},{"line_number":922,"context_line":"        expected_inst_attrs \u003d ["},{"line_number":923,"context_line":"            \u0027id\u0027,"},{"line_number":924,"context_line":"            # \u0027vnfInstanceName\u0027, # omitted"}],"source_content_type":"text/x-python","patch_set":33,"id":"bf79f02a_1852bb90","line":921,"updated":"2023-03-23 07:52:44.000000000","message":"According to L.880, I think the following is better.\n* 2. Show VNF instance(check for instantiate)","commit_id":"57977db8e78bd5252c28eb855691d57affb77d05"},{"author":{"_account_id":31668},"change_message_id":"7f72cf6a9e291cdff550128501ac67d4e4ee737d","unresolved":false,"context_lines":[{"line_number":918,"context_line":"        vdu2_host \u003d vdu2_details[\u0027hostId\u0027]"},{"line_number":919,"context_line":"        self.assertEqual(vdu1_host, vdu2_host)"},{"line_number":920,"context_line":""},{"line_number":921,"context_line":"        # 2. Show VNF instance"},{"line_number":922,"context_line":"        expected_inst_attrs \u003d ["},{"line_number":923,"context_line":"            \u0027id\u0027,"},{"line_number":924,"context_line":"            # \u0027vnfInstanceName\u0027, # omitted"}],"source_content_type":"text/x-python","patch_set":33,"id":"dc4547bf_87e4f838","line":921,"in_reply_to":"685f0ab0_b8a3d763","updated":"2023-03-28 10:09:49.000000000","message":"Done","commit_id":"57977db8e78bd5252c28eb855691d57affb77d05"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"040796c7352f0e4ac2794dcaa7a80c9ad63dcd30","unresolved":true,"context_lines":[{"line_number":918,"context_line":"        vdu2_host \u003d vdu2_details[\u0027hostId\u0027]"},{"line_number":919,"context_line":"        self.assertEqual(vdu1_host, vdu2_host)"},{"line_number":920,"context_line":""},{"line_number":921,"context_line":"        # 2. Show VNF instance"},{"line_number":922,"context_line":"        expected_inst_attrs \u003d ["},{"line_number":923,"context_line":"            \u0027id\u0027,"},{"line_number":924,"context_line":"            # \u0027vnfInstanceName\u0027, # omitted"}],"source_content_type":"text/x-python","patch_set":33,"id":"685f0ab0_b8a3d763","line":921,"in_reply_to":"bf79f02a_1852bb90","updated":"2023-03-27 06:13:15.000000000","message":"I fixed it in PS34.","commit_id":"57977db8e78bd5252c28eb855691d57affb77d05"},{"author":{"_account_id":31668},"change_message_id":"e899f3e35ae18d8aac877828de8250507e050678","unresolved":true,"context_lines":[{"line_number":936,"context_line":"            # \u0027extensions\u0027, # omitted"},{"line_number":937,"context_line":"            \u0027_links\u0027"},{"line_number":938,"context_line":"        ]"},{"line_number":939,"context_line":"        additional_inst_attrs \u003d ["},{"line_number":940,"context_line":"            \u0027vimConnectionInfo\u0027,"},{"line_number":941,"context_line":"            \u0027instantiatedVnfInfo\u0027"},{"line_number":942,"context_line":"        ]"},{"line_number":943,"context_line":"        expected_inst_attrs.extend(additional_inst_attrs)"},{"line_number":944,"context_line":"        vdu_result \u003d {\u0027VDU1\u0027: {0}, \u0027VDU2\u0027: {0}}"},{"line_number":945,"context_line":"        image_result \u003d {\u0027VDU1\u0027: {\u0027image-VDU1-0\u0027},"},{"line_number":946,"context_line":"                        \u0027VDU2\u0027: {\u0027image-VDU2-0\u0027}}"}],"source_content_type":"text/x-python","patch_set":33,"id":"ae7ecf7f_cc660bef","line":943,"range":{"start_line":939,"start_character":0,"end_line":943,"end_character":57},"updated":"2023-03-23 07:52:44.000000000","message":"In this test, the attributes of VNF Instance in NOT_INSTANTIATED state is not checked.\nHow about setting all attributes to expected_inst_attrs without dividing them?","commit_id":"57977db8e78bd5252c28eb855691d57affb77d05"},{"author":{"_account_id":31668},"change_message_id":"7f72cf6a9e291cdff550128501ac67d4e4ee737d","unresolved":false,"context_lines":[{"line_number":936,"context_line":"            # \u0027extensions\u0027, # omitted"},{"line_number":937,"context_line":"            \u0027_links\u0027"},{"line_number":938,"context_line":"        ]"},{"line_number":939,"context_line":"        additional_inst_attrs \u003d ["},{"line_number":940,"context_line":"            \u0027vimConnectionInfo\u0027,"},{"line_number":941,"context_line":"            \u0027instantiatedVnfInfo\u0027"},{"line_number":942,"context_line":"        ]"},{"line_number":943,"context_line":"        expected_inst_attrs.extend(additional_inst_attrs)"},{"line_number":944,"context_line":"        vdu_result \u003d {\u0027VDU1\u0027: {0}, \u0027VDU2\u0027: {0}}"},{"line_number":945,"context_line":"        image_result \u003d {\u0027VDU1\u0027: {\u0027image-VDU1-0\u0027},"},{"line_number":946,"context_line":"                        \u0027VDU2\u0027: {\u0027image-VDU2-0\u0027}}"}],"source_content_type":"text/x-python","patch_set":33,"id":"9acb3515_2bb4ae2c","line":943,"range":{"start_line":939,"start_character":0,"end_line":943,"end_character":57},"in_reply_to":"2758b2ea_3949ff81","updated":"2023-03-28 10:09:49.000000000","message":"Done","commit_id":"57977db8e78bd5252c28eb855691d57affb77d05"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"040796c7352f0e4ac2794dcaa7a80c9ad63dcd30","unresolved":true,"context_lines":[{"line_number":936,"context_line":"            # \u0027extensions\u0027, # omitted"},{"line_number":937,"context_line":"            \u0027_links\u0027"},{"line_number":938,"context_line":"        ]"},{"line_number":939,"context_line":"        additional_inst_attrs \u003d ["},{"line_number":940,"context_line":"            \u0027vimConnectionInfo\u0027,"},{"line_number":941,"context_line":"            \u0027instantiatedVnfInfo\u0027"},{"line_number":942,"context_line":"        ]"},{"line_number":943,"context_line":"        expected_inst_attrs.extend(additional_inst_attrs)"},{"line_number":944,"context_line":"        vdu_result \u003d {\u0027VDU1\u0027: {0}, \u0027VDU2\u0027: {0}}"},{"line_number":945,"context_line":"        image_result \u003d {\u0027VDU1\u0027: {\u0027image-VDU1-0\u0027},"},{"line_number":946,"context_line":"                        \u0027VDU2\u0027: {\u0027image-VDU2-0\u0027}}"}],"source_content_type":"text/x-python","patch_set":33,"id":"2758b2ea_3949ff81","line":943,"range":{"start_line":939,"start_character":0,"end_line":943,"end_character":57},"in_reply_to":"ae7ecf7f_cc660bef","updated":"2023-03-27 06:13:15.000000000","message":"I fixed it in PS34.","commit_id":"57977db8e78bd5252c28eb855691d57affb77d05"},{"author":{"_account_id":31668},"change_message_id":"e899f3e35ae18d8aac877828de8250507e050678","unresolved":true,"context_lines":[{"line_number":999,"context_line":""},{"line_number":1000,"context_line":"        # 8. Show VNF instance(check for update)"},{"line_number":1001,"context_line":"        inst_8 \u003d self._check_for_show_operation("},{"line_number":1002,"context_line":"            \u0027UPDATE\u0027, expected_inst_attrs, inst_id)"},{"line_number":1003,"context_line":"        self.assertEqual(self.vnfd_id_5, inst_8[\u0027vnfdId\u0027])"},{"line_number":1004,"context_line":""},{"line_number":1005,"context_line":"        # 9. Heal VNF(vnfc)"}],"source_content_type":"text/x-python","patch_set":33,"id":"0acca379_151544fa","line":1002,"updated":"2023-03-23 07:52:44.000000000","message":"It is better to set it to `MODIFY_INFO` according to the OperationParams value described in SOL.","commit_id":"57977db8e78bd5252c28eb855691d57affb77d05"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"040796c7352f0e4ac2794dcaa7a80c9ad63dcd30","unresolved":true,"context_lines":[{"line_number":999,"context_line":""},{"line_number":1000,"context_line":"        # 8. Show VNF instance(check for update)"},{"line_number":1001,"context_line":"        inst_8 \u003d self._check_for_show_operation("},{"line_number":1002,"context_line":"            \u0027UPDATE\u0027, expected_inst_attrs, inst_id)"},{"line_number":1003,"context_line":"        self.assertEqual(self.vnfd_id_5, inst_8[\u0027vnfdId\u0027])"},{"line_number":1004,"context_line":""},{"line_number":1005,"context_line":"        # 9. Heal VNF(vnfc)"}],"source_content_type":"text/x-python","patch_set":33,"id":"80857d78_41f5b2ae","line":1002,"in_reply_to":"0acca379_151544fa","updated":"2023-03-27 06:13:15.000000000","message":"I fixed it in PS34.","commit_id":"57977db8e78bd5252c28eb855691d57affb77d05"},{"author":{"_account_id":31668},"change_message_id":"7f72cf6a9e291cdff550128501ac67d4e4ee737d","unresolved":false,"context_lines":[{"line_number":999,"context_line":""},{"line_number":1000,"context_line":"        # 8. Show VNF instance(check for update)"},{"line_number":1001,"context_line":"        inst_8 \u003d self._check_for_show_operation("},{"line_number":1002,"context_line":"            \u0027UPDATE\u0027, expected_inst_attrs, inst_id)"},{"line_number":1003,"context_line":"        self.assertEqual(self.vnfd_id_5, inst_8[\u0027vnfdId\u0027])"},{"line_number":1004,"context_line":""},{"line_number":1005,"context_line":"        # 9. Heal VNF(vnfc)"}],"source_content_type":"text/x-python","patch_set":33,"id":"fe2f904b_ce9b0466","line":1002,"in_reply_to":"80857d78_41f5b2ae","updated":"2023-03-28 10:09:49.000000000","message":"Done","commit_id":"57977db8e78bd5252c28eb855691d57affb77d05"},{"author":{"_account_id":31668},"change_message_id":"e899f3e35ae18d8aac877828de8250507e050678","unresolved":true,"context_lines":[{"line_number":1019,"context_line":"        vdu_result \u003d {\u0027VDU1\u0027: {0, 1}, \u0027VDU2\u0027: {0}}"},{"line_number":1020,"context_line":"        inst_10 \u003d self._check_for_show_operation("},{"line_number":1021,"context_line":"            \u0027HEAL\u0027, expected_inst_attrs, inst_id, vdu_result)"},{"line_number":1022,"context_line":"        # check id of VDU1 with index 1 is changed, with index 0 is not change"},{"line_number":1023,"context_line":"        self.assertNotEqual(self._get_vnfc_id(inst_8, \u0027VDU1\u0027, 1),"},{"line_number":1024,"context_line":"                            self._get_vnfc_id(inst_10, \u0027VDU1\u0027, 1))"},{"line_number":1025,"context_line":"        self.assertEqual(self._get_vnfc_id(inst_8, \u0027VDU1\u0027, 0),"}],"source_content_type":"text/x-python","patch_set":33,"id":"006c0cfa_c2f3c2d9","line":1022,"updated":"2023-03-23 07:52:44.000000000","message":"nit: with index 0 is not change -\u003e with index 0 is not changed","commit_id":"57977db8e78bd5252c28eb855691d57affb77d05"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"040796c7352f0e4ac2794dcaa7a80c9ad63dcd30","unresolved":true,"context_lines":[{"line_number":1019,"context_line":"        vdu_result \u003d {\u0027VDU1\u0027: {0, 1}, \u0027VDU2\u0027: {0}}"},{"line_number":1020,"context_line":"        inst_10 \u003d self._check_for_show_operation("},{"line_number":1021,"context_line":"            \u0027HEAL\u0027, expected_inst_attrs, inst_id, vdu_result)"},{"line_number":1022,"context_line":"        # check id of VDU1 with index 1 is changed, with index 0 is not change"},{"line_number":1023,"context_line":"        self.assertNotEqual(self._get_vnfc_id(inst_8, \u0027VDU1\u0027, 1),"},{"line_number":1024,"context_line":"                            self._get_vnfc_id(inst_10, \u0027VDU1\u0027, 1))"},{"line_number":1025,"context_line":"        self.assertEqual(self._get_vnfc_id(inst_8, \u0027VDU1\u0027, 0),"}],"source_content_type":"text/x-python","patch_set":33,"id":"d6ee6d6e_6d30c6cf","line":1022,"in_reply_to":"006c0cfa_c2f3c2d9","updated":"2023-03-27 06:13:15.000000000","message":"I fixed it in PS34.","commit_id":"57977db8e78bd5252c28eb855691d57affb77d05"},{"author":{"_account_id":31668},"change_message_id":"7f72cf6a9e291cdff550128501ac67d4e4ee737d","unresolved":false,"context_lines":[{"line_number":1019,"context_line":"        vdu_result \u003d {\u0027VDU1\u0027: {0, 1}, \u0027VDU2\u0027: {0}}"},{"line_number":1020,"context_line":"        inst_10 \u003d self._check_for_show_operation("},{"line_number":1021,"context_line":"            \u0027HEAL\u0027, expected_inst_attrs, inst_id, vdu_result)"},{"line_number":1022,"context_line":"        # check id of VDU1 with index 1 is changed, with index 0 is not change"},{"line_number":1023,"context_line":"        self.assertNotEqual(self._get_vnfc_id(inst_8, \u0027VDU1\u0027, 1),"},{"line_number":1024,"context_line":"                            self._get_vnfc_id(inst_10, \u0027VDU1\u0027, 1))"},{"line_number":1025,"context_line":"        self.assertEqual(self._get_vnfc_id(inst_8, \u0027VDU1\u0027, 0),"}],"source_content_type":"text/x-python","patch_set":33,"id":"ce88f1ce_46f2f68a","line":1022,"in_reply_to":"d6ee6d6e_6d30c6cf","updated":"2023-03-28 10:09:49.000000000","message":"Done","commit_id":"57977db8e78bd5252c28eb855691d57affb77d05"},{"author":{"_account_id":31668},"change_message_id":"e899f3e35ae18d8aac877828de8250507e050678","unresolved":true,"context_lines":[{"line_number":1024,"context_line":"                            self._get_vnfc_id(inst_10, \u0027VDU1\u0027, 1))"},{"line_number":1025,"context_line":"        self.assertEqual(self._get_vnfc_id(inst_8, \u0027VDU1\u0027, 0),"},{"line_number":1026,"context_line":"                         self._get_vnfc_id(inst_10, \u0027VDU1\u0027, 0))"},{"line_number":1027,"context_line":"        # check image value of image-VDU1-1 is changed, others are not change"},{"line_number":1028,"context_line":"        self.assertNotEqual(self._get_vnfc_image(inst_8, \u0027VDU1\u0027, 1),"},{"line_number":1029,"context_line":"                            self._get_vnfc_image(inst_10, \u0027VDU1\u0027, 1))"},{"line_number":1030,"context_line":"        self.assertEqual(self._get_vnfc_image(inst_8, \u0027VDU1\u0027, 0),"}],"source_content_type":"text/x-python","patch_set":33,"id":"e18b68c1_9b92b4be","line":1027,"updated":"2023-03-23 07:52:44.000000000","message":"nit: others are not change -\u003e others are not changed","commit_id":"57977db8e78bd5252c28eb855691d57affb77d05"},{"author":{"_account_id":31668},"change_message_id":"7f72cf6a9e291cdff550128501ac67d4e4ee737d","unresolved":false,"context_lines":[{"line_number":1024,"context_line":"                            self._get_vnfc_id(inst_10, \u0027VDU1\u0027, 1))"},{"line_number":1025,"context_line":"        self.assertEqual(self._get_vnfc_id(inst_8, \u0027VDU1\u0027, 0),"},{"line_number":1026,"context_line":"                         self._get_vnfc_id(inst_10, \u0027VDU1\u0027, 0))"},{"line_number":1027,"context_line":"        # check image value of image-VDU1-1 is changed, others are not change"},{"line_number":1028,"context_line":"        self.assertNotEqual(self._get_vnfc_image(inst_8, \u0027VDU1\u0027, 1),"},{"line_number":1029,"context_line":"                            self._get_vnfc_image(inst_10, \u0027VDU1\u0027, 1))"},{"line_number":1030,"context_line":"        self.assertEqual(self._get_vnfc_image(inst_8, \u0027VDU1\u0027, 0),"}],"source_content_type":"text/x-python","patch_set":33,"id":"ac301f6c_9ffe5c27","line":1027,"in_reply_to":"0211f646_b31cb7a6","updated":"2023-03-28 10:09:49.000000000","message":"Done","commit_id":"57977db8e78bd5252c28eb855691d57affb77d05"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"040796c7352f0e4ac2794dcaa7a80c9ad63dcd30","unresolved":true,"context_lines":[{"line_number":1024,"context_line":"                            self._get_vnfc_id(inst_10, \u0027VDU1\u0027, 1))"},{"line_number":1025,"context_line":"        self.assertEqual(self._get_vnfc_id(inst_8, \u0027VDU1\u0027, 0),"},{"line_number":1026,"context_line":"                         self._get_vnfc_id(inst_10, \u0027VDU1\u0027, 0))"},{"line_number":1027,"context_line":"        # check image value of image-VDU1-1 is changed, others are not change"},{"line_number":1028,"context_line":"        self.assertNotEqual(self._get_vnfc_image(inst_8, \u0027VDU1\u0027, 1),"},{"line_number":1029,"context_line":"                            self._get_vnfc_image(inst_10, \u0027VDU1\u0027, 1))"},{"line_number":1030,"context_line":"        self.assertEqual(self._get_vnfc_image(inst_8, \u0027VDU1\u0027, 0),"}],"source_content_type":"text/x-python","patch_set":33,"id":"0211f646_b31cb7a6","line":1027,"in_reply_to":"e18b68c1_9b92b4be","updated":"2023-03-27 06:13:15.000000000","message":"I fixed it in PS34.","commit_id":"57977db8e78bd5252c28eb855691d57affb77d05"},{"author":{"_account_id":31668},"change_message_id":"e899f3e35ae18d8aac877828de8250507e050678","unresolved":true,"context_lines":[{"line_number":1072,"context_line":"        self.wait_lcmocc_complete(lcmocc_id)"},{"line_number":1073,"context_line":"        # check usageState of VNF Package 2"},{"line_number":1074,"context_line":"        self._check_package_usage(self.vnf_pkg_2, \u0027IN_USE\u0027)"},{"line_number":1075,"context_line":"        # check usageState of VNF Package 3"},{"line_number":1076,"context_line":"        self._check_package_usage(self.vnf_pkg_5)"},{"line_number":1077,"context_line":""},{"line_number":1078,"context_line":"        # 15. Instantiate VNF again"}],"source_content_type":"text/x-python","patch_set":33,"id":"9e60f0f4_06d5536b","line":1075,"updated":"2023-03-23 07:52:44.000000000","message":"VNF Package 3 -\u003e VNF Package 5","commit_id":"57977db8e78bd5252c28eb855691d57affb77d05"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"040796c7352f0e4ac2794dcaa7a80c9ad63dcd30","unresolved":true,"context_lines":[{"line_number":1072,"context_line":"        self.wait_lcmocc_complete(lcmocc_id)"},{"line_number":1073,"context_line":"        # check usageState of VNF Package 2"},{"line_number":1074,"context_line":"        self._check_package_usage(self.vnf_pkg_2, \u0027IN_USE\u0027)"},{"line_number":1075,"context_line":"        # check usageState of VNF Package 3"},{"line_number":1076,"context_line":"        self._check_package_usage(self.vnf_pkg_5)"},{"line_number":1077,"context_line":""},{"line_number":1078,"context_line":"        # 15. Instantiate VNF again"}],"source_content_type":"text/x-python","patch_set":33,"id":"eb442a48_c16fcea0","line":1075,"in_reply_to":"9e60f0f4_06d5536b","updated":"2023-03-27 06:13:15.000000000","message":"I fixed it in PS34.","commit_id":"57977db8e78bd5252c28eb855691d57affb77d05"},{"author":{"_account_id":31668},"change_message_id":"7f72cf6a9e291cdff550128501ac67d4e4ee737d","unresolved":false,"context_lines":[{"line_number":1072,"context_line":"        self.wait_lcmocc_complete(lcmocc_id)"},{"line_number":1073,"context_line":"        # check usageState of VNF Package 2"},{"line_number":1074,"context_line":"        self._check_package_usage(self.vnf_pkg_2, \u0027IN_USE\u0027)"},{"line_number":1075,"context_line":"        # check usageState of VNF Package 3"},{"line_number":1076,"context_line":"        self._check_package_usage(self.vnf_pkg_5)"},{"line_number":1077,"context_line":""},{"line_number":1078,"context_line":"        # 15. Instantiate VNF again"}],"source_content_type":"text/x-python","patch_set":33,"id":"36ed07f0_85dbc2f2","line":1075,"in_reply_to":"eb442a48_c16fcea0","updated":"2023-03-28 10:09:49.000000000","message":"Done","commit_id":"57977db8e78bd5252c28eb855691d57affb77d05"},{"author":{"_account_id":31668},"change_message_id":"e899f3e35ae18d8aac877828de8250507e050678","unresolved":true,"context_lines":[{"line_number":1104,"context_line":"            \u0027CHANGE_VNFPKG\u0027, expected_inst_attrs, inst_id)"},{"line_number":1105,"context_line":"        # check vnfdId"},{"line_number":1106,"context_line":"        self.assertEqual(self.vnfd_id_5, inst_17[\u0027vnfdId\u0027])"},{"line_number":1107,"context_line":"        # check id of VDU is not change"},{"line_number":1108,"context_line":"        self.assertEqual(self._get_vnfc_id(inst_15, \u0027VDU1\u0027, 0),"},{"line_number":1109,"context_line":"                         self._get_vnfc_id(inst_17, \u0027VDU1\u0027, 0))"},{"line_number":1110,"context_line":"        self.assertEqual(self._get_vnfc_id(inst_15, \u0027VDU2\u0027, 0),"}],"source_content_type":"text/x-python","patch_set":33,"id":"661c39dd_5768e86a","line":1107,"updated":"2023-03-23 07:52:44.000000000","message":"nit: id of VDU is not change -\u003e ids of VDU are not changed","commit_id":"57977db8e78bd5252c28eb855691d57affb77d05"},{"author":{"_account_id":31668},"change_message_id":"7f72cf6a9e291cdff550128501ac67d4e4ee737d","unresolved":false,"context_lines":[{"line_number":1104,"context_line":"            \u0027CHANGE_VNFPKG\u0027, expected_inst_attrs, inst_id)"},{"line_number":1105,"context_line":"        # check vnfdId"},{"line_number":1106,"context_line":"        self.assertEqual(self.vnfd_id_5, inst_17[\u0027vnfdId\u0027])"},{"line_number":1107,"context_line":"        # check id of VDU is not change"},{"line_number":1108,"context_line":"        self.assertEqual(self._get_vnfc_id(inst_15, \u0027VDU1\u0027, 0),"},{"line_number":1109,"context_line":"                         self._get_vnfc_id(inst_17, \u0027VDU1\u0027, 0))"},{"line_number":1110,"context_line":"        self.assertEqual(self._get_vnfc_id(inst_15, \u0027VDU2\u0027, 0),"}],"source_content_type":"text/x-python","patch_set":33,"id":"f67d9e4f_66b47e9b","line":1107,"in_reply_to":"2cbf102f_dea338ea","updated":"2023-03-28 10:09:49.000000000","message":"Done","commit_id":"57977db8e78bd5252c28eb855691d57affb77d05"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"040796c7352f0e4ac2794dcaa7a80c9ad63dcd30","unresolved":true,"context_lines":[{"line_number":1104,"context_line":"            \u0027CHANGE_VNFPKG\u0027, expected_inst_attrs, inst_id)"},{"line_number":1105,"context_line":"        # check vnfdId"},{"line_number":1106,"context_line":"        self.assertEqual(self.vnfd_id_5, inst_17[\u0027vnfdId\u0027])"},{"line_number":1107,"context_line":"        # check id of VDU is not change"},{"line_number":1108,"context_line":"        self.assertEqual(self._get_vnfc_id(inst_15, \u0027VDU1\u0027, 0),"},{"line_number":1109,"context_line":"                         self._get_vnfc_id(inst_17, \u0027VDU1\u0027, 0))"},{"line_number":1110,"context_line":"        self.assertEqual(self._get_vnfc_id(inst_15, \u0027VDU2\u0027, 0),"}],"source_content_type":"text/x-python","patch_set":33,"id":"2cbf102f_dea338ea","line":1107,"in_reply_to":"661c39dd_5768e86a","updated":"2023-03-27 06:13:15.000000000","message":"I fixed it in PS34.","commit_id":"57977db8e78bd5252c28eb855691d57affb77d05"},{"author":{"_account_id":31668},"change_message_id":"e899f3e35ae18d8aac877828de8250507e050678","unresolved":true,"context_lines":[{"line_number":1112,"context_line":"        # check image of VDU1 is changed"},{"line_number":1113,"context_line":"        self.assertNotEqual(self._get_vnfc_image(inst_15, \u0027VDU1\u0027, 0),"},{"line_number":1114,"context_line":"                            self._get_vnfc_image(inst_17, \u0027VDU1\u0027, 0))"},{"line_number":1115,"context_line":"        # check flavor is not change"},{"line_number":1116,"context_line":"        self.assertEqual(self._get_vnfc_flavor(inst_15, \u0027VDU1\u0027, 0),"},{"line_number":1117,"context_line":"                         self._get_vnfc_flavor(inst_17, \u0027VDU1\u0027, 0))"},{"line_number":1118,"context_line":"        self.assertEqual(self._get_vnfc_flavor(inst_15, \u0027VDU2\u0027, 0),"}],"source_content_type":"text/x-python","patch_set":33,"id":"cf82d724_7e7de0b8","line":1115,"updated":"2023-03-23 07:52:44.000000000","message":"nit: flavor is not change -\u003e flavors of VDU are not changed","commit_id":"57977db8e78bd5252c28eb855691d57affb77d05"},{"author":{"_account_id":31668},"change_message_id":"7f72cf6a9e291cdff550128501ac67d4e4ee737d","unresolved":false,"context_lines":[{"line_number":1112,"context_line":"        # check image of VDU1 is changed"},{"line_number":1113,"context_line":"        self.assertNotEqual(self._get_vnfc_image(inst_15, \u0027VDU1\u0027, 0),"},{"line_number":1114,"context_line":"                            self._get_vnfc_image(inst_17, \u0027VDU1\u0027, 0))"},{"line_number":1115,"context_line":"        # check flavor is not change"},{"line_number":1116,"context_line":"        self.assertEqual(self._get_vnfc_flavor(inst_15, \u0027VDU1\u0027, 0),"},{"line_number":1117,"context_line":"                         self._get_vnfc_flavor(inst_17, \u0027VDU1\u0027, 0))"},{"line_number":1118,"context_line":"        self.assertEqual(self._get_vnfc_flavor(inst_15, \u0027VDU2\u0027, 0),"}],"source_content_type":"text/x-python","patch_set":33,"id":"5bec3b1e_d09b8661","line":1115,"in_reply_to":"83ea14b6_dca6a9a7","updated":"2023-03-28 10:09:49.000000000","message":"Done","commit_id":"57977db8e78bd5252c28eb855691d57affb77d05"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"040796c7352f0e4ac2794dcaa7a80c9ad63dcd30","unresolved":true,"context_lines":[{"line_number":1112,"context_line":"        # check image of VDU1 is changed"},{"line_number":1113,"context_line":"        self.assertNotEqual(self._get_vnfc_image(inst_15, \u0027VDU1\u0027, 0),"},{"line_number":1114,"context_line":"                            self._get_vnfc_image(inst_17, \u0027VDU1\u0027, 0))"},{"line_number":1115,"context_line":"        # check flavor is not change"},{"line_number":1116,"context_line":"        self.assertEqual(self._get_vnfc_flavor(inst_15, \u0027VDU1\u0027, 0),"},{"line_number":1117,"context_line":"                         self._get_vnfc_flavor(inst_17, \u0027VDU1\u0027, 0))"},{"line_number":1118,"context_line":"        self.assertEqual(self._get_vnfc_flavor(inst_15, \u0027VDU2\u0027, 0),"}],"source_content_type":"text/x-python","patch_set":33,"id":"83ea14b6_dca6a9a7","line":1115,"in_reply_to":"cf82d724_7e7de0b8","updated":"2023-03-27 06:13:15.000000000","message":"I fixed it in PS34.","commit_id":"57977db8e78bd5252c28eb855691d57affb77d05"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"9933929ef24f1cb70c638c6151eb4c46e8cc12fd","unresolved":true,"context_lines":[{"line_number":325,"context_line":"        \"\"\""},{"line_number":326,"context_line":"        # 0. Create VNF"},{"line_number":327,"context_line":"        create_req \u003d paramgen.create_vnf_max("},{"line_number":328,"context_line":"            self.vnfd_id_1, description\u003d\"test for basic_max_individual_vnfc\")"},{"line_number":329,"context_line":"        _, body \u003d self.create_vnf_instance(create_req)"},{"line_number":330,"context_line":"        inst_id \u003d body[\u0027id\u0027]"},{"line_number":331,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"c72f7c6e_d1602ea1","line":328,"range":{"start_line":328,"start_character":50,"end_line":328,"end_character":75},"updated":"2023-03-27 09:13:56.000000000","message":"I think the following is better.\nbasic_max_individual_vnfc -\u003e basic_lcms_max_individual_vnfc","commit_id":"7cf70ac342921e604f446cf6414705572f2b10f5"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"1b9517c43cd5c18462401eab99c669214523adab","unresolved":false,"context_lines":[{"line_number":325,"context_line":"        \"\"\""},{"line_number":326,"context_line":"        # 0. Create VNF"},{"line_number":327,"context_line":"        create_req \u003d paramgen.create_vnf_max("},{"line_number":328,"context_line":"            self.vnfd_id_1, description\u003d\"test for basic_max_individual_vnfc\")"},{"line_number":329,"context_line":"        _, body \u003d self.create_vnf_instance(create_req)"},{"line_number":330,"context_line":"        inst_id \u003d body[\u0027id\u0027]"},{"line_number":331,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"488a222e_cc93f0b1","line":328,"range":{"start_line":328,"start_character":50,"end_line":328,"end_character":75},"in_reply_to":"12484eda_91eb8d35","updated":"2023-04-03 23:40:21.000000000","message":"Done","commit_id":"7cf70ac342921e604f446cf6414705572f2b10f5"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"878d3176b1efb13b1e3dea24e56f20ccebdf0ece","unresolved":true,"context_lines":[{"line_number":325,"context_line":"        \"\"\""},{"line_number":326,"context_line":"        # 0. Create VNF"},{"line_number":327,"context_line":"        create_req \u003d paramgen.create_vnf_max("},{"line_number":328,"context_line":"            self.vnfd_id_1, description\u003d\"test for basic_max_individual_vnfc\")"},{"line_number":329,"context_line":"        _, body \u003d self.create_vnf_instance(create_req)"},{"line_number":330,"context_line":"        inst_id \u003d body[\u0027id\u0027]"},{"line_number":331,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"12484eda_91eb8d35","line":328,"range":{"start_line":328,"start_character":50,"end_line":328,"end_character":75},"in_reply_to":"c72f7c6e_d1602ea1","updated":"2023-04-03 08:46:10.000000000","message":"I fixed it in PS37.","commit_id":"7cf70ac342921e604f446cf6414705572f2b10f5"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"9933929ef24f1cb70c638c6151eb4c46e8cc12fd","unresolved":true,"context_lines":[{"line_number":772,"context_line":"        update_req \u003d paramgen.update_vnf_min_with_parameter(self.vnfd_id_1)"},{"line_number":773,"context_line":"        resp, body \u003d self.update_vnf_instance(inst_id, update_req)"},{"line_number":774,"context_line":"        self.assertEqual(202, resp.status_code)"},{"line_number":775,"context_line":"        self.wait_lcmocc_complete(lcmocc_id)"},{"line_number":776,"context_line":""},{"line_number":777,"context_line":"        # 27. Change current VNF Package"},{"line_number":778,"context_line":"        # check usageState of VNF Package 1"}],"source_content_type":"text/x-python","patch_set":34,"id":"cc9eb503_85a28dc3","line":775,"updated":"2023-03-27 09:13:56.000000000","message":"I think `lcmocc_id \u003d os.path.basename(resp.headers[\u0027Location\u0027])` is necessary.","commit_id":"7cf70ac342921e604f446cf6414705572f2b10f5"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"1b9517c43cd5c18462401eab99c669214523adab","unresolved":false,"context_lines":[{"line_number":772,"context_line":"        update_req \u003d paramgen.update_vnf_min_with_parameter(self.vnfd_id_1)"},{"line_number":773,"context_line":"        resp, body \u003d self.update_vnf_instance(inst_id, update_req)"},{"line_number":774,"context_line":"        self.assertEqual(202, resp.status_code)"},{"line_number":775,"context_line":"        self.wait_lcmocc_complete(lcmocc_id)"},{"line_number":776,"context_line":""},{"line_number":777,"context_line":"        # 27. Change current VNF Package"},{"line_number":778,"context_line":"        # check usageState of VNF Package 1"}],"source_content_type":"text/x-python","patch_set":34,"id":"936e15df_7ad494b9","line":775,"in_reply_to":"27e8517d_1ee95a40","updated":"2023-04-03 23:40:21.000000000","message":"Done","commit_id":"7cf70ac342921e604f446cf6414705572f2b10f5"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"878d3176b1efb13b1e3dea24e56f20ccebdf0ece","unresolved":true,"context_lines":[{"line_number":772,"context_line":"        update_req \u003d paramgen.update_vnf_min_with_parameter(self.vnfd_id_1)"},{"line_number":773,"context_line":"        resp, body \u003d self.update_vnf_instance(inst_id, update_req)"},{"line_number":774,"context_line":"        self.assertEqual(202, resp.status_code)"},{"line_number":775,"context_line":"        self.wait_lcmocc_complete(lcmocc_id)"},{"line_number":776,"context_line":""},{"line_number":777,"context_line":"        # 27. Change current VNF Package"},{"line_number":778,"context_line":"        # check usageState of VNF Package 1"}],"source_content_type":"text/x-python","patch_set":34,"id":"27e8517d_1ee95a40","line":775,"in_reply_to":"cc9eb503_85a28dc3","updated":"2023-04-03 08:46:10.000000000","message":"I fixed it in PS37.","commit_id":"7cf70ac342921e604f446cf6414705572f2b10f5"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"9933929ef24f1cb70c638c6151eb4c46e8cc12fd","unresolved":true,"context_lines":[{"line_number":850,"context_line":"        self.assertEqual(fields.VnfInstanceState.NOT_INSTANTIATED,"},{"line_number":851,"context_line":"                         body[\u0027instantiationState\u0027])"},{"line_number":852,"context_line":""},{"line_number":853,"context_line":"        # wait a bit because there is a bit time lag between lcmocc DB"},{"line_number":854,"context_line":"        # update and terminate completion."},{"line_number":855,"context_line":"        time.sleep(10)"},{"line_number":856,"context_line":""},{"line_number":857,"context_line":"        # 30. Delete VNF"},{"line_number":858,"context_line":"        self.delete_vnf_instance(inst_id)"}],"source_content_type":"text/x-python","patch_set":34,"id":"7d1fb74b_c85704d7","line":855,"range":{"start_line":853,"start_character":0,"end_line":855,"end_character":22},"updated":"2023-03-27 09:13:56.000000000","message":"I think this sleep() is unnesessary, because it is already running.\nhttps://review.opendev.org/c/openstack/tacker/+/873477/34/tacker/tests/functional/sol_v2_individual_vnfc_mgmt/test_individual_vnfc_mgmt_basic.py#845","commit_id":"7cf70ac342921e604f446cf6414705572f2b10f5"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"1b9517c43cd5c18462401eab99c669214523adab","unresolved":false,"context_lines":[{"line_number":850,"context_line":"        self.assertEqual(fields.VnfInstanceState.NOT_INSTANTIATED,"},{"line_number":851,"context_line":"                         body[\u0027instantiationState\u0027])"},{"line_number":852,"context_line":""},{"line_number":853,"context_line":"        # wait a bit because there is a bit time lag between lcmocc DB"},{"line_number":854,"context_line":"        # update and terminate completion."},{"line_number":855,"context_line":"        time.sleep(10)"},{"line_number":856,"context_line":""},{"line_number":857,"context_line":"        # 30. Delete VNF"},{"line_number":858,"context_line":"        self.delete_vnf_instance(inst_id)"}],"source_content_type":"text/x-python","patch_set":34,"id":"b5110a28_584ebc2d","line":855,"range":{"start_line":853,"start_character":0,"end_line":855,"end_character":22},"in_reply_to":"205c58b7_c5d6b874","updated":"2023-04-03 23:40:21.000000000","message":"Done","commit_id":"7cf70ac342921e604f446cf6414705572f2b10f5"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"878d3176b1efb13b1e3dea24e56f20ccebdf0ece","unresolved":true,"context_lines":[{"line_number":850,"context_line":"        self.assertEqual(fields.VnfInstanceState.NOT_INSTANTIATED,"},{"line_number":851,"context_line":"                         body[\u0027instantiationState\u0027])"},{"line_number":852,"context_line":""},{"line_number":853,"context_line":"        # wait a bit because there is a bit time lag between lcmocc DB"},{"line_number":854,"context_line":"        # update and terminate completion."},{"line_number":855,"context_line":"        time.sleep(10)"},{"line_number":856,"context_line":""},{"line_number":857,"context_line":"        # 30. Delete VNF"},{"line_number":858,"context_line":"        self.delete_vnf_instance(inst_id)"}],"source_content_type":"text/x-python","patch_set":34,"id":"205c58b7_c5d6b874","line":855,"range":{"start_line":853,"start_character":0,"end_line":855,"end_character":22},"in_reply_to":"7d1fb74b_c85704d7","updated":"2023-04-03 08:46:10.000000000","message":"I fixed it in PS37.","commit_id":"7cf70ac342921e604f446cf6414705572f2b10f5"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"06fd39f4da942aceeb1c9abae8292667bf5a36f3","unresolved":true,"context_lines":[{"line_number":1130,"context_line":""},{"line_number":1131,"context_line":"        # wait a bit because there is a bit time lag between lcmocc DB"},{"line_number":1132,"context_line":"        # update and terminate completion."},{"line_number":1133,"context_line":"        time.sleep(10)"},{"line_number":1134,"context_line":""},{"line_number":1135,"context_line":"        # 19. Delete VNF"},{"line_number":1136,"context_line":"        self.delete_vnf_instance(inst_id)"}],"source_content_type":"text/x-python","patch_set":34,"id":"d735cf56_7b3e80fe","line":1133,"updated":"2023-03-29 05:04:35.000000000","message":"I think this sleep() is unnecessary, because already waited in `wait_lcmocc_complete`(L.1123).","commit_id":"7cf70ac342921e604f446cf6414705572f2b10f5"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"878d3176b1efb13b1e3dea24e56f20ccebdf0ece","unresolved":true,"context_lines":[{"line_number":1130,"context_line":""},{"line_number":1131,"context_line":"        # wait a bit because there is a bit time lag between lcmocc DB"},{"line_number":1132,"context_line":"        # update and terminate completion."},{"line_number":1133,"context_line":"        time.sleep(10)"},{"line_number":1134,"context_line":""},{"line_number":1135,"context_line":"        # 19. Delete VNF"},{"line_number":1136,"context_line":"        self.delete_vnf_instance(inst_id)"}],"source_content_type":"text/x-python","patch_set":34,"id":"f8d0d27b_c9a72d51","line":1133,"in_reply_to":"d735cf56_7b3e80fe","updated":"2023-04-03 08:46:10.000000000","message":"I fixed it in PS37.","commit_id":"7cf70ac342921e604f446cf6414705572f2b10f5"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"1b9517c43cd5c18462401eab99c669214523adab","unresolved":false,"context_lines":[{"line_number":1130,"context_line":""},{"line_number":1131,"context_line":"        # wait a bit because there is a bit time lag between lcmocc DB"},{"line_number":1132,"context_line":"        # update and terminate completion."},{"line_number":1133,"context_line":"        time.sleep(10)"},{"line_number":1134,"context_line":""},{"line_number":1135,"context_line":"        # 19. Delete VNF"},{"line_number":1136,"context_line":"        self.delete_vnf_instance(inst_id)"}],"source_content_type":"text/x-python","patch_set":34,"id":"f506bf49_2c4dda52","line":1133,"in_reply_to":"f8d0d27b_c9a72d51","updated":"2023-04-03 23:40:21.000000000","message":"Done","commit_id":"7cf70ac342921e604f446cf6414705572f2b10f5"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"06fd39f4da942aceeb1c9abae8292667bf5a36f3","unresolved":true,"context_lines":[{"line_number":1304,"context_line":""},{"line_number":1305,"context_line":"        # wait a bit because there is a bit time lag between VNF instance DB"},{"line_number":1306,"context_line":"        # terminate and delete completion."},{"line_number":1307,"context_line":"        time.sleep(5)"},{"line_number":1308,"context_line":""},{"line_number":1309,"context_line":"        # 10. Delete VNF"},{"line_number":1310,"context_line":"        self.delete_vnf_instance(inst_id)"}],"source_content_type":"text/x-python","patch_set":34,"id":"c312048e_e81a90af","line":1307,"updated":"2023-03-29 05:04:35.000000000","message":"ditto.","commit_id":"7cf70ac342921e604f446cf6414705572f2b10f5"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"1b9517c43cd5c18462401eab99c669214523adab","unresolved":false,"context_lines":[{"line_number":1304,"context_line":""},{"line_number":1305,"context_line":"        # wait a bit because there is a bit time lag between VNF instance DB"},{"line_number":1306,"context_line":"        # terminate and delete completion."},{"line_number":1307,"context_line":"        time.sleep(5)"},{"line_number":1308,"context_line":""},{"line_number":1309,"context_line":"        # 10. Delete VNF"},{"line_number":1310,"context_line":"        self.delete_vnf_instance(inst_id)"}],"source_content_type":"text/x-python","patch_set":34,"id":"aa58d808_a32b2475","line":1307,"in_reply_to":"2496c267_7ff1a515","updated":"2023-04-03 23:40:21.000000000","message":"Done","commit_id":"7cf70ac342921e604f446cf6414705572f2b10f5"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"878d3176b1efb13b1e3dea24e56f20ccebdf0ece","unresolved":true,"context_lines":[{"line_number":1304,"context_line":""},{"line_number":1305,"context_line":"        # wait a bit because there is a bit time lag between VNF instance DB"},{"line_number":1306,"context_line":"        # terminate and delete completion."},{"line_number":1307,"context_line":"        time.sleep(5)"},{"line_number":1308,"context_line":""},{"line_number":1309,"context_line":"        # 10. Delete VNF"},{"line_number":1310,"context_line":"        self.delete_vnf_instance(inst_id)"}],"source_content_type":"text/x-python","patch_set":34,"id":"2496c267_7ff1a515","line":1307,"in_reply_to":"c312048e_e81a90af","updated":"2023-04-03 08:46:10.000000000","message":"ditto","commit_id":"7cf70ac342921e604f446cf6414705572f2b10f5"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"06fd39f4da942aceeb1c9abae8292667bf5a36f3","unresolved":true,"context_lines":[{"line_number":1611,"context_line":""},{"line_number":1612,"context_line":"        # wait a bit because there is a bit time lag between lcmocc DB"},{"line_number":1613,"context_line":"        # update and terminate completion."},{"line_number":1614,"context_line":"        time.sleep(10)"},{"line_number":1615,"context_line":""},{"line_number":1616,"context_line":"        # check instantiationState of VNF"},{"line_number":1617,"context_line":"        resp, body \u003d self.show_vnf_instance(inst_id)"}],"source_content_type":"text/x-python","patch_set":34,"id":"57eaf47d_462143fe","line":1614,"updated":"2023-03-29 05:04:35.000000000","message":"ditto.","commit_id":"7cf70ac342921e604f446cf6414705572f2b10f5"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"878d3176b1efb13b1e3dea24e56f20ccebdf0ece","unresolved":true,"context_lines":[{"line_number":1611,"context_line":""},{"line_number":1612,"context_line":"        # wait a bit because there is a bit time lag between lcmocc DB"},{"line_number":1613,"context_line":"        # update and terminate completion."},{"line_number":1614,"context_line":"        time.sleep(10)"},{"line_number":1615,"context_line":""},{"line_number":1616,"context_line":"        # check instantiationState of VNF"},{"line_number":1617,"context_line":"        resp, body \u003d self.show_vnf_instance(inst_id)"}],"source_content_type":"text/x-python","patch_set":34,"id":"b92c2d0e_28eb5971","line":1614,"in_reply_to":"57eaf47d_462143fe","updated":"2023-04-03 08:46:10.000000000","message":"ditto","commit_id":"7cf70ac342921e604f446cf6414705572f2b10f5"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"1b9517c43cd5c18462401eab99c669214523adab","unresolved":false,"context_lines":[{"line_number":1611,"context_line":""},{"line_number":1612,"context_line":"        # wait a bit because there is a bit time lag between lcmocc DB"},{"line_number":1613,"context_line":"        # update and terminate completion."},{"line_number":1614,"context_line":"        time.sleep(10)"},{"line_number":1615,"context_line":""},{"line_number":1616,"context_line":"        # check instantiationState of VNF"},{"line_number":1617,"context_line":"        resp, body \u003d self.show_vnf_instance(inst_id)"}],"source_content_type":"text/x-python","patch_set":34,"id":"30005523_0dab96b9","line":1614,"in_reply_to":"b92c2d0e_28eb5971","updated":"2023-04-03 23:40:21.000000000","message":"Done","commit_id":"7cf70ac342921e604f446cf6414705572f2b10f5"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"06fd39f4da942aceeb1c9abae8292667bf5a36f3","unresolved":true,"context_lines":[{"line_number":1739,"context_line":"        self.check_resp_body(body, expected_attrs)"},{"line_number":1740,"context_line":""},{"line_number":1741,"context_line":"        # 6. Show VNF instance"},{"line_number":1742,"context_line":"        _, inst_5 \u003d self.show_vnf_instance(inst_id)"},{"line_number":1743,"context_line":"        # check vnfdId"},{"line_number":1744,"context_line":"        self.assertEqual(self.vnfd_id_1, inst_5[\u0027vnfdId\u0027])"},{"line_number":1745,"context_line":"        # check images of VDU are not change"}],"source_content_type":"text/x-python","patch_set":34,"id":"7923c0a2_39ad4fd2","line":1742,"range":{"start_line":1742,"start_character":11,"end_line":1742,"end_character":17},"updated":"2023-03-29 05:04:35.000000000","message":"nits: inst_5 -\u003e inst_6","commit_id":"7cf70ac342921e604f446cf6414705572f2b10f5"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"1b9517c43cd5c18462401eab99c669214523adab","unresolved":false,"context_lines":[{"line_number":1739,"context_line":"        self.check_resp_body(body, expected_attrs)"},{"line_number":1740,"context_line":""},{"line_number":1741,"context_line":"        # 6. Show VNF instance"},{"line_number":1742,"context_line":"        _, inst_5 \u003d self.show_vnf_instance(inst_id)"},{"line_number":1743,"context_line":"        # check vnfdId"},{"line_number":1744,"context_line":"        self.assertEqual(self.vnfd_id_1, inst_5[\u0027vnfdId\u0027])"},{"line_number":1745,"context_line":"        # check images of VDU are not change"}],"source_content_type":"text/x-python","patch_set":34,"id":"4cec7516_8faef535","line":1742,"range":{"start_line":1742,"start_character":11,"end_line":1742,"end_character":17},"in_reply_to":"0f1b7cf1_9e2fbbc4","updated":"2023-04-03 23:40:21.000000000","message":"Done","commit_id":"7cf70ac342921e604f446cf6414705572f2b10f5"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"878d3176b1efb13b1e3dea24e56f20ccebdf0ece","unresolved":true,"context_lines":[{"line_number":1739,"context_line":"        self.check_resp_body(body, expected_attrs)"},{"line_number":1740,"context_line":""},{"line_number":1741,"context_line":"        # 6. Show VNF instance"},{"line_number":1742,"context_line":"        _, inst_5 \u003d self.show_vnf_instance(inst_id)"},{"line_number":1743,"context_line":"        # check vnfdId"},{"line_number":1744,"context_line":"        self.assertEqual(self.vnfd_id_1, inst_5[\u0027vnfdId\u0027])"},{"line_number":1745,"context_line":"        # check images of VDU are not change"}],"source_content_type":"text/x-python","patch_set":34,"id":"0f1b7cf1_9e2fbbc4","line":1742,"range":{"start_line":1742,"start_character":11,"end_line":1742,"end_character":17},"in_reply_to":"7923c0a2_39ad4fd2","updated":"2023-04-03 08:46:10.000000000","message":"I fixed it in PS37.","commit_id":"7cf70ac342921e604f446cf6414705572f2b10f5"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"06fd39f4da942aceeb1c9abae8292667bf5a36f3","unresolved":true,"context_lines":[{"line_number":1827,"context_line":""},{"line_number":1828,"context_line":"        # wait a bit because there is a bit time lag between lcmocc DB"},{"line_number":1829,"context_line":"        # update and terminate completion."},{"line_number":1830,"context_line":"        time.sleep(10)"},{"line_number":1831,"context_line":""},{"line_number":1832,"context_line":"        # 12. Terminate VNF"},{"line_number":1833,"context_line":"        terminate_req \u003d paramgen.terminate_vnf_min()"}],"source_content_type":"text/x-python","patch_set":34,"id":"b581a257_8d7e784a","line":1830,"updated":"2023-03-29 05:04:35.000000000","message":"I think this sleep() is unnecessary, because already waited in `wait_lcmocc_rolled_back`(L.1783).","commit_id":"7cf70ac342921e604f446cf6414705572f2b10f5"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"92e98d73235a0042a746732e13daaaa492e3de68","unresolved":false,"context_lines":[{"line_number":1827,"context_line":""},{"line_number":1828,"context_line":"        # wait a bit because there is a bit time lag between lcmocc DB"},{"line_number":1829,"context_line":"        # update and terminate completion."},{"line_number":1830,"context_line":"        time.sleep(10)"},{"line_number":1831,"context_line":""},{"line_number":1832,"context_line":"        # 12. Terminate VNF"},{"line_number":1833,"context_line":"        terminate_req \u003d paramgen.terminate_vnf_min()"}],"source_content_type":"text/x-python","patch_set":34,"id":"f21b89a7_9f5547d2","line":1830,"in_reply_to":"abbef510_4754087b","updated":"2023-04-05 06:41:34.000000000","message":"Done","commit_id":"7cf70ac342921e604f446cf6414705572f2b10f5"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"878d3176b1efb13b1e3dea24e56f20ccebdf0ece","unresolved":true,"context_lines":[{"line_number":1827,"context_line":""},{"line_number":1828,"context_line":"        # wait a bit because there is a bit time lag between lcmocc DB"},{"line_number":1829,"context_line":"        # update and terminate completion."},{"line_number":1830,"context_line":"        time.sleep(10)"},{"line_number":1831,"context_line":""},{"line_number":1832,"context_line":"        # 12. Terminate VNF"},{"line_number":1833,"context_line":"        terminate_req \u003d paramgen.terminate_vnf_min()"}],"source_content_type":"text/x-python","patch_set":34,"id":"abbef510_4754087b","line":1830,"in_reply_to":"b581a257_8d7e784a","updated":"2023-04-03 08:46:10.000000000","message":"I fixed it in PS37.","commit_id":"7cf70ac342921e604f446cf6414705572f2b10f5"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"06fd39f4da942aceeb1c9abae8292667bf5a36f3","unresolved":true,"context_lines":[{"line_number":1886,"context_line":"          - 23. Scale in operation"},{"line_number":1887,"context_line":"          - 24. Show VNF instance(check for scale)"},{"line_number":1888,"context_line":"          - 25. Update VNF"},{"line_number":1889,"context_line":"          - 26. Show VNF instance"},{"line_number":1890,"context_line":"          - 27. Scale out operation"},{"line_number":1891,"context_line":"          - 28. Heal VNF(all with omit all parameter)"},{"line_number":1892,"context_line":"          - 29. Heal VNF(all with all\u003dFalse parameter)"}],"source_content_type":"text/x-python","patch_set":34,"id":"663306d4_1337e0e0","line":1889,"range":{"start_line":1889,"start_character":16,"end_line":1889,"end_character":33},"updated":"2023-03-29 05:04:35.000000000","message":"nits: Show VNF instance -\u003e Show VNF instance(check for update)","commit_id":"7cf70ac342921e604f446cf6414705572f2b10f5"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"1b9517c43cd5c18462401eab99c669214523adab","unresolved":false,"context_lines":[{"line_number":1886,"context_line":"          - 23. Scale in operation"},{"line_number":1887,"context_line":"          - 24. Show VNF instance(check for scale)"},{"line_number":1888,"context_line":"          - 25. Update VNF"},{"line_number":1889,"context_line":"          - 26. Show VNF instance"},{"line_number":1890,"context_line":"          - 27. Scale out operation"},{"line_number":1891,"context_line":"          - 28. Heal VNF(all with omit all parameter)"},{"line_number":1892,"context_line":"          - 29. Heal VNF(all with all\u003dFalse parameter)"}],"source_content_type":"text/x-python","patch_set":34,"id":"dd3ee9ff_857b6e48","line":1889,"range":{"start_line":1889,"start_character":16,"end_line":1889,"end_character":33},"in_reply_to":"43168e36_d1e25600","updated":"2023-04-03 23:40:21.000000000","message":"Done","commit_id":"7cf70ac342921e604f446cf6414705572f2b10f5"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"878d3176b1efb13b1e3dea24e56f20ccebdf0ece","unresolved":true,"context_lines":[{"line_number":1886,"context_line":"          - 23. Scale in operation"},{"line_number":1887,"context_line":"          - 24. Show VNF instance(check for scale)"},{"line_number":1888,"context_line":"          - 25. Update VNF"},{"line_number":1889,"context_line":"          - 26. Show VNF instance"},{"line_number":1890,"context_line":"          - 27. Scale out operation"},{"line_number":1891,"context_line":"          - 28. Heal VNF(all with omit all parameter)"},{"line_number":1892,"context_line":"          - 29. Heal VNF(all with all\u003dFalse parameter)"}],"source_content_type":"text/x-python","patch_set":34,"id":"43168e36_d1e25600","line":1889,"range":{"start_line":1889,"start_character":16,"end_line":1889,"end_character":33},"in_reply_to":"663306d4_1337e0e0","updated":"2023-04-03 08:46:10.000000000","message":"I fixed it in PS37.","commit_id":"7cf70ac342921e604f446cf6414705572f2b10f5"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"06fd39f4da942aceeb1c9abae8292667bf5a36f3","unresolved":true,"context_lines":[{"line_number":2204,"context_line":"        lcmocc_id \u003d os.path.basename(resp.headers[\u0027Location\u0027])"},{"line_number":2205,"context_line":"        self.wait_lcmocc_complete(lcmocc_id)"},{"line_number":2206,"context_line":""},{"line_number":2207,"context_line":"        # 26. Show VNF instance"},{"line_number":2208,"context_line":"        vdu_result \u003d {\u0027VDU1\u0027: {0}, \u0027VDU2\u0027: {0}}"},{"line_number":2209,"context_line":"        inst_26 \u003d self._check_for_show_operation("},{"line_number":2210,"context_line":"            \u0027UPDATE\u0027, expected_inst_attrs, inst_id, vdu_result)"}],"source_content_type":"text/x-python","patch_set":34,"id":"14c5fb53_97efddf0","line":2207,"updated":"2023-03-29 05:04:35.000000000","message":"ditto.","commit_id":"7cf70ac342921e604f446cf6414705572f2b10f5"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"878d3176b1efb13b1e3dea24e56f20ccebdf0ece","unresolved":true,"context_lines":[{"line_number":2204,"context_line":"        lcmocc_id \u003d os.path.basename(resp.headers[\u0027Location\u0027])"},{"line_number":2205,"context_line":"        self.wait_lcmocc_complete(lcmocc_id)"},{"line_number":2206,"context_line":""},{"line_number":2207,"context_line":"        # 26. Show VNF instance"},{"line_number":2208,"context_line":"        vdu_result \u003d {\u0027VDU1\u0027: {0}, \u0027VDU2\u0027: {0}}"},{"line_number":2209,"context_line":"        inst_26 \u003d self._check_for_show_operation("},{"line_number":2210,"context_line":"            \u0027UPDATE\u0027, expected_inst_attrs, inst_id, vdu_result)"}],"source_content_type":"text/x-python","patch_set":34,"id":"82b23d53_11fd03f3","line":2207,"in_reply_to":"14c5fb53_97efddf0","updated":"2023-04-03 08:46:10.000000000","message":"ditto","commit_id":"7cf70ac342921e604f446cf6414705572f2b10f5"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"1b9517c43cd5c18462401eab99c669214523adab","unresolved":false,"context_lines":[{"line_number":2204,"context_line":"        lcmocc_id \u003d os.path.basename(resp.headers[\u0027Location\u0027])"},{"line_number":2205,"context_line":"        self.wait_lcmocc_complete(lcmocc_id)"},{"line_number":2206,"context_line":""},{"line_number":2207,"context_line":"        # 26. Show VNF instance"},{"line_number":2208,"context_line":"        vdu_result \u003d {\u0027VDU1\u0027: {0}, \u0027VDU2\u0027: {0}}"},{"line_number":2209,"context_line":"        inst_26 \u003d self._check_for_show_operation("},{"line_number":2210,"context_line":"            \u0027UPDATE\u0027, expected_inst_attrs, inst_id, vdu_result)"}],"source_content_type":"text/x-python","patch_set":34,"id":"98160811_fe4f5775","line":2207,"in_reply_to":"82b23d53_11fd03f3","updated":"2023-04-03 23:40:21.000000000","message":"Done","commit_id":"7cf70ac342921e604f446cf6414705572f2b10f5"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"06fd39f4da942aceeb1c9abae8292667bf5a36f3","unresolved":true,"context_lines":[{"line_number":2207,"context_line":"        # 26. Show VNF instance"},{"line_number":2208,"context_line":"        vdu_result \u003d {\u0027VDU1\u0027: {0}, \u0027VDU2\u0027: {0}}"},{"line_number":2209,"context_line":"        inst_26 \u003d self._check_for_show_operation("},{"line_number":2210,"context_line":"            \u0027UPDATE\u0027, expected_inst_attrs, inst_id, vdu_result)"},{"line_number":2211,"context_line":"        # check usageState of VNF Package 1"},{"line_number":2212,"context_line":"        self._check_package_usage(self.vnf_pkg_1)"},{"line_number":2213,"context_line":"        # check usageState of VNF Package 3"}],"source_content_type":"text/x-python","patch_set":34,"id":"31d0c43f_cbedc7d6","line":2210,"updated":"2023-03-29 05:04:35.000000000","message":"In v2LCM, this operation name is `MODIFY_INFO`.\n`UPDATE` -\u003e `MODIFY_INFO`","commit_id":"7cf70ac342921e604f446cf6414705572f2b10f5"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"878d3176b1efb13b1e3dea24e56f20ccebdf0ece","unresolved":true,"context_lines":[{"line_number":2207,"context_line":"        # 26. Show VNF instance"},{"line_number":2208,"context_line":"        vdu_result \u003d {\u0027VDU1\u0027: {0}, \u0027VDU2\u0027: {0}}"},{"line_number":2209,"context_line":"        inst_26 \u003d self._check_for_show_operation("},{"line_number":2210,"context_line":"            \u0027UPDATE\u0027, expected_inst_attrs, inst_id, vdu_result)"},{"line_number":2211,"context_line":"        # check usageState of VNF Package 1"},{"line_number":2212,"context_line":"        self._check_package_usage(self.vnf_pkg_1)"},{"line_number":2213,"context_line":"        # check usageState of VNF Package 3"}],"source_content_type":"text/x-python","patch_set":34,"id":"fa113ee1_09463ec5","line":2210,"in_reply_to":"31d0c43f_cbedc7d6","updated":"2023-04-03 08:46:10.000000000","message":"I fixed it in PS37.","commit_id":"7cf70ac342921e604f446cf6414705572f2b10f5"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"1b9517c43cd5c18462401eab99c669214523adab","unresolved":false,"context_lines":[{"line_number":2207,"context_line":"        # 26. Show VNF instance"},{"line_number":2208,"context_line":"        vdu_result \u003d {\u0027VDU1\u0027: {0}, \u0027VDU2\u0027: {0}}"},{"line_number":2209,"context_line":"        inst_26 \u003d self._check_for_show_operation("},{"line_number":2210,"context_line":"            \u0027UPDATE\u0027, expected_inst_attrs, inst_id, vdu_result)"},{"line_number":2211,"context_line":"        # check usageState of VNF Package 1"},{"line_number":2212,"context_line":"        self._check_package_usage(self.vnf_pkg_1)"},{"line_number":2213,"context_line":"        # check usageState of VNF Package 3"}],"source_content_type":"text/x-python","patch_set":34,"id":"efe5742d_b154a2a3","line":2210,"in_reply_to":"fa113ee1_09463ec5","updated":"2023-04-03 23:40:21.000000000","message":"Done","commit_id":"7cf70ac342921e604f446cf6414705572f2b10f5"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"06fd39f4da942aceeb1c9abae8292667bf5a36f3","unresolved":true,"context_lines":[{"line_number":2381,"context_line":""},{"line_number":2382,"context_line":"        # wait a bit because there is a bit time lag between lcmocc DB"},{"line_number":2383,"context_line":"        # update and terminate completion."},{"line_number":2384,"context_line":"        time.sleep(10)"},{"line_number":2385,"context_line":""},{"line_number":2386,"context_line":"        # check instantiationState of VNF"},{"line_number":2387,"context_line":"        resp, body \u003d self.show_vnf_instance(inst_id)"}],"source_content_type":"text/x-python","patch_set":34,"id":"a92e7258_619179b0","line":2384,"updated":"2023-03-29 05:04:35.000000000","message":"I think this sleep() is unnecessary, because already waited in `wait_lcmocc_complete`(L.2380).","commit_id":"7cf70ac342921e604f446cf6414705572f2b10f5"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"1b9517c43cd5c18462401eab99c669214523adab","unresolved":false,"context_lines":[{"line_number":2381,"context_line":""},{"line_number":2382,"context_line":"        # wait a bit because there is a bit time lag between lcmocc DB"},{"line_number":2383,"context_line":"        # update and terminate completion."},{"line_number":2384,"context_line":"        time.sleep(10)"},{"line_number":2385,"context_line":""},{"line_number":2386,"context_line":"        # check instantiationState of VNF"},{"line_number":2387,"context_line":"        resp, body \u003d self.show_vnf_instance(inst_id)"}],"source_content_type":"text/x-python","patch_set":34,"id":"e88702a2_c05e1957","line":2384,"in_reply_to":"45235b98_62ada3fd","updated":"2023-04-03 23:40:21.000000000","message":"Done","commit_id":"7cf70ac342921e604f446cf6414705572f2b10f5"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"878d3176b1efb13b1e3dea24e56f20ccebdf0ece","unresolved":true,"context_lines":[{"line_number":2381,"context_line":""},{"line_number":2382,"context_line":"        # wait a bit because there is a bit time lag between lcmocc DB"},{"line_number":2383,"context_line":"        # update and terminate completion."},{"line_number":2384,"context_line":"        time.sleep(10)"},{"line_number":2385,"context_line":""},{"line_number":2386,"context_line":"        # check instantiationState of VNF"},{"line_number":2387,"context_line":"        resp, body \u003d self.show_vnf_instance(inst_id)"}],"source_content_type":"text/x-python","patch_set":34,"id":"45235b98_62ada3fd","line":2384,"in_reply_to":"a92e7258_619179b0","updated":"2023-04-03 08:46:10.000000000","message":"I fixed it in PS37.","commit_id":"7cf70ac342921e604f446cf6414705572f2b10f5"},{"author":{"_account_id":31668},"change_message_id":"7f72cf6a9e291cdff550128501ac67d4e4ee737d","unresolved":true,"context_lines":[{"line_number":670,"context_line":"                            self._get_vnfc_id(inst_19, \u0027VDU1\u0027, 0))"},{"line_number":671,"context_line":"        self.assertNotEqual(self._get_vnfc_id(inst_17, \u0027VDU2\u0027, 0),"},{"line_number":672,"context_line":"                            self._get_vnfc_id(inst_19, \u0027VDU2\u0027, 0))"},{"line_number":673,"context_line":"        # check images are not change"},{"line_number":674,"context_line":"        self.assertEqual(self._get_vnfc_image(inst_17, \u0027VDU1\u0027, 0),"},{"line_number":675,"context_line":"                         self._get_vnfc_image(inst_19, \u0027VDU1\u0027, 0))"},{"line_number":676,"context_line":"        self.assertEqual(self._get_vnfc_image(inst_17, \u0027VDU2\u0027, 0),"}],"source_content_type":"text/x-python","patch_set":35,"id":"51d82c45_de0db724","line":673,"updated":"2023-03-28 10:09:49.000000000","message":"nit: images are not change -\u003e images are not changed","commit_id":"a22d54ed544a7fd9ffeb06ef47b8520299dfad10"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"878d3176b1efb13b1e3dea24e56f20ccebdf0ece","unresolved":true,"context_lines":[{"line_number":670,"context_line":"                            self._get_vnfc_id(inst_19, \u0027VDU1\u0027, 0))"},{"line_number":671,"context_line":"        self.assertNotEqual(self._get_vnfc_id(inst_17, \u0027VDU2\u0027, 0),"},{"line_number":672,"context_line":"                            self._get_vnfc_id(inst_19, \u0027VDU2\u0027, 0))"},{"line_number":673,"context_line":"        # check images are not change"},{"line_number":674,"context_line":"        self.assertEqual(self._get_vnfc_image(inst_17, \u0027VDU1\u0027, 0),"},{"line_number":675,"context_line":"                         self._get_vnfc_image(inst_19, \u0027VDU1\u0027, 0))"},{"line_number":676,"context_line":"        self.assertEqual(self._get_vnfc_image(inst_17, \u0027VDU2\u0027, 0),"}],"source_content_type":"text/x-python","patch_set":35,"id":"be1dd776_ac5a2c66","line":673,"in_reply_to":"51d82c45_de0db724","updated":"2023-04-03 08:46:10.000000000","message":"I fixed it in PS37.","commit_id":"a22d54ed544a7fd9ffeb06ef47b8520299dfad10"},{"author":{"_account_id":31668},"change_message_id":"a2c4b01b4880d2e8b5a6492071fb856f65accb77","unresolved":false,"context_lines":[{"line_number":670,"context_line":"                            self._get_vnfc_id(inst_19, \u0027VDU1\u0027, 0))"},{"line_number":671,"context_line":"        self.assertNotEqual(self._get_vnfc_id(inst_17, \u0027VDU2\u0027, 0),"},{"line_number":672,"context_line":"                            self._get_vnfc_id(inst_19, \u0027VDU2\u0027, 0))"},{"line_number":673,"context_line":"        # check images are not change"},{"line_number":674,"context_line":"        self.assertEqual(self._get_vnfc_image(inst_17, \u0027VDU1\u0027, 0),"},{"line_number":675,"context_line":"                         self._get_vnfc_image(inst_19, \u0027VDU1\u0027, 0))"},{"line_number":676,"context_line":"        self.assertEqual(self._get_vnfc_image(inst_17, \u0027VDU2\u0027, 0),"}],"source_content_type":"text/x-python","patch_set":35,"id":"b602f9d8_b808966a","line":673,"in_reply_to":"be1dd776_ac5a2c66","updated":"2023-04-04 08:01:02.000000000","message":"Done","commit_id":"a22d54ed544a7fd9ffeb06ef47b8520299dfad10"},{"author":{"_account_id":31668},"change_message_id":"7f72cf6a9e291cdff550128501ac67d4e4ee737d","unresolved":true,"context_lines":[{"line_number":696,"context_line":"                            self._get_vnfc_id(inst_21, \u0027VDU1\u0027, 0))"},{"line_number":697,"context_line":"        self.assertNotEqual(self._get_vnfc_id(inst_19, \u0027VDU2\u0027, 0),"},{"line_number":698,"context_line":"                            self._get_vnfc_id(inst_21, \u0027VDU2\u0027, 0))"},{"line_number":699,"context_line":"        # check images are not change"},{"line_number":700,"context_line":"        self.assertEqual(self._get_vnfc_image(inst_19, \u0027VDU1\u0027, 0),"},{"line_number":701,"context_line":"                         self._get_vnfc_image(inst_21, \u0027VDU1\u0027, 0))"},{"line_number":702,"context_line":"        self.assertEqual(self._get_vnfc_image(inst_19, \u0027VDU2\u0027, 0),"}],"source_content_type":"text/x-python","patch_set":35,"id":"54dc4bc4_7020029d","line":699,"updated":"2023-03-28 10:09:49.000000000","message":"nit: images are not change -\u003e images are not changed","commit_id":"a22d54ed544a7fd9ffeb06ef47b8520299dfad10"},{"author":{"_account_id":31668},"change_message_id":"a2c4b01b4880d2e8b5a6492071fb856f65accb77","unresolved":false,"context_lines":[{"line_number":696,"context_line":"                            self._get_vnfc_id(inst_21, \u0027VDU1\u0027, 0))"},{"line_number":697,"context_line":"        self.assertNotEqual(self._get_vnfc_id(inst_19, \u0027VDU2\u0027, 0),"},{"line_number":698,"context_line":"                            self._get_vnfc_id(inst_21, \u0027VDU2\u0027, 0))"},{"line_number":699,"context_line":"        # check images are not change"},{"line_number":700,"context_line":"        self.assertEqual(self._get_vnfc_image(inst_19, \u0027VDU1\u0027, 0),"},{"line_number":701,"context_line":"                         self._get_vnfc_image(inst_21, \u0027VDU1\u0027, 0))"},{"line_number":702,"context_line":"        self.assertEqual(self._get_vnfc_image(inst_19, \u0027VDU2\u0027, 0),"}],"source_content_type":"text/x-python","patch_set":35,"id":"0e098941_122a23c6","line":699,"in_reply_to":"27103dbc_0fa7c1e9","updated":"2023-04-04 08:01:02.000000000","message":"Done","commit_id":"a22d54ed544a7fd9ffeb06ef47b8520299dfad10"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"878d3176b1efb13b1e3dea24e56f20ccebdf0ece","unresolved":true,"context_lines":[{"line_number":696,"context_line":"                            self._get_vnfc_id(inst_21, \u0027VDU1\u0027, 0))"},{"line_number":697,"context_line":"        self.assertNotEqual(self._get_vnfc_id(inst_19, \u0027VDU2\u0027, 0),"},{"line_number":698,"context_line":"                            self._get_vnfc_id(inst_21, \u0027VDU2\u0027, 0))"},{"line_number":699,"context_line":"        # check images are not change"},{"line_number":700,"context_line":"        self.assertEqual(self._get_vnfc_image(inst_19, \u0027VDU1\u0027, 0),"},{"line_number":701,"context_line":"                         self._get_vnfc_image(inst_21, \u0027VDU1\u0027, 0))"},{"line_number":702,"context_line":"        self.assertEqual(self._get_vnfc_image(inst_19, \u0027VDU2\u0027, 0),"}],"source_content_type":"text/x-python","patch_set":35,"id":"27103dbc_0fa7c1e9","line":699,"in_reply_to":"54dc4bc4_7020029d","updated":"2023-04-03 08:46:10.000000000","message":"I fixed it in PS37.","commit_id":"a22d54ed544a7fd9ffeb06ef47b8520299dfad10"},{"author":{"_account_id":31668},"change_message_id":"7a082d5a1f90e6c4f2c99f108cf1588aec6c4d05","unresolved":true,"context_lines":[{"line_number":853,"context_line":"                         body[\u0027instantiationState\u0027])"},{"line_number":854,"context_line":""},{"line_number":855,"context_line":"        # 30. Delete VNF"},{"line_number":856,"context_line":"        self.delete_vnf_instance(inst_id)"},{"line_number":857,"context_line":""},{"line_number":858,"context_line":"    def test_basic_lcms_min(self):"},{"line_number":859,"context_line":"        \"\"\"Test LCM operations with omitting except for required attributes"}],"source_content_type":"text/x-python","patch_set":35,"id":"0db81931_d11cc037","line":856,"updated":"2023-03-30 01:04:41.000000000","message":"When using local_nfvo, a notification call is just a method call (not an asynchronous call), and by extension it can take some time to delete the glance image.\nTherefore, there is a time lag from when the VnfLcmOpOcc operationState becomes COMPLETED until the terminate process is completed.\n\nFor this reason, it is better to include retry processing when deleting.\nCould you please move the following method to `delete_vnf_instance` of `tacker/tests/functional/sol_v2_common/base_v2.py` and retry the delete process of this test as necessary?\nhttps://opendev.org/openstack/tacker/src/branch/stable/2023.1/tacker/tests/functional/sol_v2/test_individual_vnfc_mgmt.py#L162-L173","commit_id":"a22d54ed544a7fd9ffeb06ef47b8520299dfad10"},{"author":{"_account_id":31668},"change_message_id":"97e622dfec63eb7b64753dbb34055e6e4bde7bd2","unresolved":true,"context_lines":[{"line_number":853,"context_line":"                         body[\u0027instantiationState\u0027])"},{"line_number":854,"context_line":""},{"line_number":855,"context_line":"        # 30. Delete VNF"},{"line_number":856,"context_line":"        self.delete_vnf_instance(inst_id)"},{"line_number":857,"context_line":""},{"line_number":858,"context_line":"    def test_basic_lcms_min(self):"},{"line_number":859,"context_line":"        \"\"\"Test LCM operations with omitting except for required attributes"}],"source_content_type":"text/x-python","patch_set":35,"id":"69ed00b6_a71835ad","line":856,"in_reply_to":"0db81931_d11cc037","updated":"2023-03-30 02:19:44.000000000","message":"Sorry, modifying \"delete_vnf_instance\" in `base_v2.py` has a large impact on others, so could you just add \"_delete_instance\" to `test_individual_vnfc_mgmt_basic.py` in this patch?\nPlease refer to `test_individual_vnfc_mgmt.py`.\nhttps://opendev.org/openstack/tacker/src/branch/stable/2023.1/tacker/tests/functional/sol_v2/test_individual_vnfc_mgmt.py#L393\nPlease fix the following as well.\n* L.1134\n* L.1308\n* L.1621\n* L.1846\n* L.2391\n\nI think it would be better to fix `base_v2.py` in another patch in the future.","commit_id":"a22d54ed544a7fd9ffeb06ef47b8520299dfad10"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"878d3176b1efb13b1e3dea24e56f20ccebdf0ece","unresolved":true,"context_lines":[{"line_number":853,"context_line":"                         body[\u0027instantiationState\u0027])"},{"line_number":854,"context_line":""},{"line_number":855,"context_line":"        # 30. Delete VNF"},{"line_number":856,"context_line":"        self.delete_vnf_instance(inst_id)"},{"line_number":857,"context_line":""},{"line_number":858,"context_line":"    def test_basic_lcms_min(self):"},{"line_number":859,"context_line":"        \"\"\"Test LCM operations with omitting except for required attributes"}],"source_content_type":"text/x-python","patch_set":35,"id":"eac3fe10_8783ece9","line":856,"in_reply_to":"69ed00b6_a71835ad","updated":"2023-04-03 08:46:10.000000000","message":"I fixed it in PS37.","commit_id":"a22d54ed544a7fd9ffeb06ef47b8520299dfad10"},{"author":{"_account_id":31668},"change_message_id":"a2c4b01b4880d2e8b5a6492071fb856f65accb77","unresolved":false,"context_lines":[{"line_number":853,"context_line":"                         body[\u0027instantiationState\u0027])"},{"line_number":854,"context_line":""},{"line_number":855,"context_line":"        # 30. Delete VNF"},{"line_number":856,"context_line":"        self.delete_vnf_instance(inst_id)"},{"line_number":857,"context_line":""},{"line_number":858,"context_line":"    def test_basic_lcms_min(self):"},{"line_number":859,"context_line":"        \"\"\"Test LCM operations with omitting except for required attributes"}],"source_content_type":"text/x-python","patch_set":35,"id":"db762c50_8c7867bc","line":856,"in_reply_to":"eac3fe10_8783ece9","updated":"2023-04-04 08:01:02.000000000","message":"Done","commit_id":"a22d54ed544a7fd9ffeb06ef47b8520299dfad10"},{"author":{"_account_id":31668},"change_message_id":"7f72cf6a9e291cdff550128501ac67d4e4ee737d","unresolved":true,"context_lines":[{"line_number":1195,"context_line":"            # \u0027extensions\u0027, # omitted"},{"line_number":1196,"context_line":"            \u0027_links\u0027"},{"line_number":1197,"context_line":"        ]"},{"line_number":1198,"context_line":"        additional_inst_attrs \u003d ["},{"line_number":1199,"context_line":"            \u0027vimConnectionInfo\u0027,"},{"line_number":1200,"context_line":"            \u0027instantiatedVnfInfo\u0027"},{"line_number":1201,"context_line":"        ]"},{"line_number":1202,"context_line":"        expected_inst_attrs.extend(additional_inst_attrs)"},{"line_number":1203,"context_line":"        _ \u003d self._check_for_show_operation("},{"line_number":1204,"context_line":"            \u0027INSTANTIATE\u0027, expected_inst_attrs, inst_id)"},{"line_number":1205,"context_line":""}],"source_content_type":"text/x-python","patch_set":35,"id":"a5675557_e56404d2","line":1202,"range":{"start_line":1198,"start_character":0,"end_line":1202,"end_character":57},"updated":"2023-03-28 10:09:49.000000000","message":"In this test, the attributes of VNF Instance in NOT_INSTANTIATED state is not checked.\nHow about setting all attributes to expected_inst_attrs without dividing them?","commit_id":"a22d54ed544a7fd9ffeb06ef47b8520299dfad10"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"878d3176b1efb13b1e3dea24e56f20ccebdf0ece","unresolved":true,"context_lines":[{"line_number":1195,"context_line":"            # \u0027extensions\u0027, # omitted"},{"line_number":1196,"context_line":"            \u0027_links\u0027"},{"line_number":1197,"context_line":"        ]"},{"line_number":1198,"context_line":"        additional_inst_attrs \u003d ["},{"line_number":1199,"context_line":"            \u0027vimConnectionInfo\u0027,"},{"line_number":1200,"context_line":"            \u0027instantiatedVnfInfo\u0027"},{"line_number":1201,"context_line":"        ]"},{"line_number":1202,"context_line":"        expected_inst_attrs.extend(additional_inst_attrs)"},{"line_number":1203,"context_line":"        _ \u003d self._check_for_show_operation("},{"line_number":1204,"context_line":"            \u0027INSTANTIATE\u0027, expected_inst_attrs, inst_id)"},{"line_number":1205,"context_line":""}],"source_content_type":"text/x-python","patch_set":35,"id":"c061fb85_f3bcebee","line":1202,"range":{"start_line":1198,"start_character":0,"end_line":1202,"end_character":57},"in_reply_to":"a5675557_e56404d2","updated":"2023-04-03 08:46:10.000000000","message":"I fixed it in PS37.","commit_id":"a22d54ed544a7fd9ffeb06ef47b8520299dfad10"},{"author":{"_account_id":31668},"change_message_id":"a2c4b01b4880d2e8b5a6492071fb856f65accb77","unresolved":false,"context_lines":[{"line_number":1195,"context_line":"            # \u0027extensions\u0027, # omitted"},{"line_number":1196,"context_line":"            \u0027_links\u0027"},{"line_number":1197,"context_line":"        ]"},{"line_number":1198,"context_line":"        additional_inst_attrs \u003d ["},{"line_number":1199,"context_line":"            \u0027vimConnectionInfo\u0027,"},{"line_number":1200,"context_line":"            \u0027instantiatedVnfInfo\u0027"},{"line_number":1201,"context_line":"        ]"},{"line_number":1202,"context_line":"        expected_inst_attrs.extend(additional_inst_attrs)"},{"line_number":1203,"context_line":"        _ \u003d self._check_for_show_operation("},{"line_number":1204,"context_line":"            \u0027INSTANTIATE\u0027, expected_inst_attrs, inst_id)"},{"line_number":1205,"context_line":""}],"source_content_type":"text/x-python","patch_set":35,"id":"8e8d8082_c70c754c","line":1202,"range":{"start_line":1198,"start_character":0,"end_line":1202,"end_character":57},"in_reply_to":"c061fb85_f3bcebee","updated":"2023-04-04 08:01:02.000000000","message":"Done","commit_id":"a22d54ed544a7fd9ffeb06ef47b8520299dfad10"},{"author":{"_account_id":31668},"change_message_id":"6eadbab656b7010e1cfd5b7c902502e04e0371cd","unresolved":true,"context_lines":[{"line_number":1265,"context_line":"            \u0027stateEnteredTime\u0027,"},{"line_number":1266,"context_line":"            \u0027startTime\u0027,"},{"line_number":1267,"context_line":"            \u0027vnfInstanceId\u0027,"},{"line_number":1268,"context_line":"            # \u0027grantId\u0027, # omitted"},{"line_number":1269,"context_line":"            \u0027operation\u0027,"},{"line_number":1270,"context_line":"            \u0027isAutomaticInvocation\u0027,"},{"line_number":1271,"context_line":"            # \u0027operationParams\u0027, # omitted"}],"source_content_type":"text/x-python","patch_set":35,"id":"b0241665_f2e0cf9d","line":1268,"updated":"2023-03-29 10:00:53.000000000","message":"The grantId is also set, so please don\u0027t omit it.","commit_id":"a22d54ed544a7fd9ffeb06ef47b8520299dfad10"},{"author":{"_account_id":31668},"change_message_id":"fde66f73213d2e9c386e4ddcd374e484e02b1982","unresolved":false,"context_lines":[{"line_number":1265,"context_line":"            \u0027stateEnteredTime\u0027,"},{"line_number":1266,"context_line":"            \u0027startTime\u0027,"},{"line_number":1267,"context_line":"            \u0027vnfInstanceId\u0027,"},{"line_number":1268,"context_line":"            # \u0027grantId\u0027, # omitted"},{"line_number":1269,"context_line":"            \u0027operation\u0027,"},{"line_number":1270,"context_line":"            \u0027isAutomaticInvocation\u0027,"},{"line_number":1271,"context_line":"            # \u0027operationParams\u0027, # omitted"}],"source_content_type":"text/x-python","patch_set":35,"id":"da32be18_9b4ba9f1","line":1268,"in_reply_to":"b0241665_f2e0cf9d","updated":"2023-03-31 07:12:05.000000000","message":"For modify, grantId is not set, so it can be omitted.\nI will withdraw this comment.","commit_id":"a22d54ed544a7fd9ffeb06ef47b8520299dfad10"},{"author":{"_account_id":31668},"change_message_id":"6eadbab656b7010e1cfd5b7c902502e04e0371cd","unresolved":true,"context_lines":[{"line_number":1268,"context_line":"            # \u0027grantId\u0027, # omitted"},{"line_number":1269,"context_line":"            \u0027operation\u0027,"},{"line_number":1270,"context_line":"            \u0027isAutomaticInvocation\u0027,"},{"line_number":1271,"context_line":"            # \u0027operationParams\u0027, # omitted"},{"line_number":1272,"context_line":"            \u0027isCancelPending\u0027,"},{"line_number":1273,"context_line":"            # \u0027cancelMode\u0027, # omitted"},{"line_number":1274,"context_line":"            # \u0027error\u0027, # omitted"}],"source_content_type":"text/x-python","patch_set":35,"id":"a888120a_347ae575","line":1271,"updated":"2023-03-29 10:00:53.000000000","message":"The operationParams is also set, so please don\u0027t omit it.","commit_id":"a22d54ed544a7fd9ffeb06ef47b8520299dfad10"},{"author":{"_account_id":31668},"change_message_id":"a2c4b01b4880d2e8b5a6492071fb856f65accb77","unresolved":false,"context_lines":[{"line_number":1268,"context_line":"            # \u0027grantId\u0027, # omitted"},{"line_number":1269,"context_line":"            \u0027operation\u0027,"},{"line_number":1270,"context_line":"            \u0027isAutomaticInvocation\u0027,"},{"line_number":1271,"context_line":"            # \u0027operationParams\u0027, # omitted"},{"line_number":1272,"context_line":"            \u0027isCancelPending\u0027,"},{"line_number":1273,"context_line":"            # \u0027cancelMode\u0027, # omitted"},{"line_number":1274,"context_line":"            # \u0027error\u0027, # omitted"}],"source_content_type":"text/x-python","patch_set":35,"id":"9621ddb2_95b61902","line":1271,"in_reply_to":"2c7a929c_a45ce650","updated":"2023-04-04 08:01:02.000000000","message":"Thank you for confirmation.\nI misunderstood it as the case of specifying \"all_fields\"...\nPlease omit it.","commit_id":"a22d54ed544a7fd9ffeb06ef47b8520299dfad10"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"878d3176b1efb13b1e3dea24e56f20ccebdf0ece","unresolved":true,"context_lines":[{"line_number":1268,"context_line":"            # \u0027grantId\u0027, # omitted"},{"line_number":1269,"context_line":"            \u0027operation\u0027,"},{"line_number":1270,"context_line":"            \u0027isAutomaticInvocation\u0027,"},{"line_number":1271,"context_line":"            # \u0027operationParams\u0027, # omitted"},{"line_number":1272,"context_line":"            \u0027isCancelPending\u0027,"},{"line_number":1273,"context_line":"            # \u0027cancelMode\u0027, # omitted"},{"line_number":1274,"context_line":"            # \u0027error\u0027, # omitted"}],"source_content_type":"text/x-python","patch_set":35,"id":"2c7a929c_a45ce650","line":1271,"in_reply_to":"a888120a_347ae575","updated":"2023-04-03 08:46:10.000000000","message":"The operationParams parameter does not return when use \u0027list vnflcmopocc\u0027 API.\nRefer to https://opendev.org/openstack/tacker/src/branch/master/tacker/sol_refactored/controller/vnflcm_view.py#L375-L380","commit_id":"a22d54ed544a7fd9ffeb06ef47b8520299dfad10"},{"author":{"_account_id":31668},"change_message_id":"6eadbab656b7010e1cfd5b7c902502e04e0371cd","unresolved":true,"context_lines":[{"line_number":1410,"context_line":"            \u0027stateEnteredTime\u0027,"},{"line_number":1411,"context_line":"            \u0027startTime\u0027,"},{"line_number":1412,"context_line":"            \u0027vnfInstanceId\u0027,"},{"line_number":1413,"context_line":"            # \u0027grantId\u0027, # omitted"},{"line_number":1414,"context_line":"            \u0027operation\u0027,"},{"line_number":1415,"context_line":"            \u0027isAutomaticInvocation\u0027,"},{"line_number":1416,"context_line":"            # \u0027operationParams\u0027, # omitted"}],"source_content_type":"text/x-python","patch_set":35,"id":"fea64adb_ada9292a","line":1413,"updated":"2023-03-29 10:00:53.000000000","message":"The grantId is also set, so please don\u0027t omit it.","commit_id":"a22d54ed544a7fd9ffeb06ef47b8520299dfad10"},{"author":{"_account_id":31668},"change_message_id":"fde66f73213d2e9c386e4ddcd374e484e02b1982","unresolved":false,"context_lines":[{"line_number":1410,"context_line":"            \u0027stateEnteredTime\u0027,"},{"line_number":1411,"context_line":"            \u0027startTime\u0027,"},{"line_number":1412,"context_line":"            \u0027vnfInstanceId\u0027,"},{"line_number":1413,"context_line":"            # \u0027grantId\u0027, # omitted"},{"line_number":1414,"context_line":"            \u0027operation\u0027,"},{"line_number":1415,"context_line":"            \u0027isAutomaticInvocation\u0027,"},{"line_number":1416,"context_line":"            # \u0027operationParams\u0027, # omitted"}],"source_content_type":"text/x-python","patch_set":35,"id":"e79a032f_8f859674","line":1413,"in_reply_to":"fea64adb_ada9292a","updated":"2023-03-31 07:12:05.000000000","message":"ditto","commit_id":"a22d54ed544a7fd9ffeb06ef47b8520299dfad10"},{"author":{"_account_id":31668},"change_message_id":"6eadbab656b7010e1cfd5b7c902502e04e0371cd","unresolved":true,"context_lines":[{"line_number":1413,"context_line":"            # \u0027grantId\u0027, # omitted"},{"line_number":1414,"context_line":"            \u0027operation\u0027,"},{"line_number":1415,"context_line":"            \u0027isAutomaticInvocation\u0027,"},{"line_number":1416,"context_line":"            # \u0027operationParams\u0027, # omitted"},{"line_number":1417,"context_line":"            \u0027isCancelPending\u0027,"},{"line_number":1418,"context_line":"            # \u0027cancelMode\u0027, # omitted"},{"line_number":1419,"context_line":"            # \u0027error\u0027, # omitted"}],"source_content_type":"text/x-python","patch_set":35,"id":"7dadbf61_b8b29df3","line":1416,"updated":"2023-03-29 10:00:53.000000000","message":"The operationParams is also set, so please don\u0027t omit it.","commit_id":"a22d54ed544a7fd9ffeb06ef47b8520299dfad10"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"878d3176b1efb13b1e3dea24e56f20ccebdf0ece","unresolved":true,"context_lines":[{"line_number":1413,"context_line":"            # \u0027grantId\u0027, # omitted"},{"line_number":1414,"context_line":"            \u0027operation\u0027,"},{"line_number":1415,"context_line":"            \u0027isAutomaticInvocation\u0027,"},{"line_number":1416,"context_line":"            # \u0027operationParams\u0027, # omitted"},{"line_number":1417,"context_line":"            \u0027isCancelPending\u0027,"},{"line_number":1418,"context_line":"            # \u0027cancelMode\u0027, # omitted"},{"line_number":1419,"context_line":"            # \u0027error\u0027, # omitted"}],"source_content_type":"text/x-python","patch_set":35,"id":"fb9a8d19_f2d472f7","line":1416,"in_reply_to":"7dadbf61_b8b29df3","updated":"2023-04-03 08:46:10.000000000","message":"ditto","commit_id":"a22d54ed544a7fd9ffeb06ef47b8520299dfad10"},{"author":{"_account_id":31668},"change_message_id":"a2c4b01b4880d2e8b5a6492071fb856f65accb77","unresolved":false,"context_lines":[{"line_number":1413,"context_line":"            # \u0027grantId\u0027, # omitted"},{"line_number":1414,"context_line":"            \u0027operation\u0027,"},{"line_number":1415,"context_line":"            \u0027isAutomaticInvocation\u0027,"},{"line_number":1416,"context_line":"            # \u0027operationParams\u0027, # omitted"},{"line_number":1417,"context_line":"            \u0027isCancelPending\u0027,"},{"line_number":1418,"context_line":"            # \u0027cancelMode\u0027, # omitted"},{"line_number":1419,"context_line":"            # \u0027error\u0027, # omitted"}],"source_content_type":"text/x-python","patch_set":35,"id":"c162df64_28f6914f","line":1416,"in_reply_to":"fb9a8d19_f2d472f7","updated":"2023-04-04 08:01:02.000000000","message":"ditto","commit_id":"a22d54ed544a7fd9ffeb06ef47b8520299dfad10"},{"author":{"_account_id":31668},"change_message_id":"fde66f73213d2e9c386e4ddcd374e484e02b1982","unresolved":true,"context_lines":[{"line_number":1487,"context_line":"            \u0027vnfSoftwareVersion\u0027,"},{"line_number":1488,"context_line":"            \u0027vnfdVersion\u0027,"},{"line_number":1489,"context_line":"            # \u0027vnfConfigurableProperties\u0027, # omitted"},{"line_number":1490,"context_line":"            # \u0027vimConnectionInfo\u0027, # omitted"},{"line_number":1491,"context_line":"            \u0027instantiationState\u0027,"},{"line_number":1492,"context_line":"            # \u0027instantiatedVnfInfo\u0027, # omitted"},{"line_number":1493,"context_line":"            # \u0027metadata\u0027, # omitted"}],"source_content_type":"text/x-python","patch_set":35,"id":"98416e65_7dc6f4ed","line":1490,"updated":"2023-03-31 07:12:05.000000000","message":"The vimConnectionInfo is also set, so please don\u0027t omit it.","commit_id":"a22d54ed544a7fd9ffeb06ef47b8520299dfad10"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"878d3176b1efb13b1e3dea24e56f20ccebdf0ece","unresolved":true,"context_lines":[{"line_number":1487,"context_line":"            \u0027vnfSoftwareVersion\u0027,"},{"line_number":1488,"context_line":"            \u0027vnfdVersion\u0027,"},{"line_number":1489,"context_line":"            # \u0027vnfConfigurableProperties\u0027, # omitted"},{"line_number":1490,"context_line":"            # \u0027vimConnectionInfo\u0027, # omitted"},{"line_number":1491,"context_line":"            \u0027instantiationState\u0027,"},{"line_number":1492,"context_line":"            # \u0027instantiatedVnfInfo\u0027, # omitted"},{"line_number":1493,"context_line":"            # \u0027metadata\u0027, # omitted"}],"source_content_type":"text/x-python","patch_set":35,"id":"ad374588_27a71720","line":1490,"in_reply_to":"98416e65_7dc6f4ed","updated":"2023-04-03 08:46:10.000000000","message":"I fixed it in PS37.","commit_id":"a22d54ed544a7fd9ffeb06ef47b8520299dfad10"},{"author":{"_account_id":31668},"change_message_id":"a2c4b01b4880d2e8b5a6492071fb856f65accb77","unresolved":false,"context_lines":[{"line_number":1487,"context_line":"            \u0027vnfSoftwareVersion\u0027,"},{"line_number":1488,"context_line":"            \u0027vnfdVersion\u0027,"},{"line_number":1489,"context_line":"            # \u0027vnfConfigurableProperties\u0027, # omitted"},{"line_number":1490,"context_line":"            # \u0027vimConnectionInfo\u0027, # omitted"},{"line_number":1491,"context_line":"            \u0027instantiationState\u0027,"},{"line_number":1492,"context_line":"            # \u0027instantiatedVnfInfo\u0027, # omitted"},{"line_number":1493,"context_line":"            # \u0027metadata\u0027, # omitted"}],"source_content_type":"text/x-python","patch_set":35,"id":"5be45a88_5c69cbd8","line":1490,"in_reply_to":"ad374588_27a71720","updated":"2023-04-04 08:01:02.000000000","message":"Done","commit_id":"a22d54ed544a7fd9ffeb06ef47b8520299dfad10"},{"author":{"_account_id":31668},"change_message_id":"fde66f73213d2e9c386e4ddcd374e484e02b1982","unresolved":true,"context_lines":[{"line_number":1489,"context_line":"            # \u0027vnfConfigurableProperties\u0027, # omitted"},{"line_number":1490,"context_line":"            # \u0027vimConnectionInfo\u0027, # omitted"},{"line_number":1491,"context_line":"            \u0027instantiationState\u0027,"},{"line_number":1492,"context_line":"            # \u0027instantiatedVnfInfo\u0027, # omitted"},{"line_number":1493,"context_line":"            # \u0027metadata\u0027, # omitted"},{"line_number":1494,"context_line":"            # \u0027extensions\u0027, # omitted"},{"line_number":1495,"context_line":"            \u0027_links\u0027"}],"source_content_type":"text/x-python","patch_set":35,"id":"22544df6_d74b86a8","line":1492,"updated":"2023-03-31 07:12:05.000000000","message":"The instantiatedVnfInfo is also set, so please don\u0027t omit it.","commit_id":"a22d54ed544a7fd9ffeb06ef47b8520299dfad10"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"878d3176b1efb13b1e3dea24e56f20ccebdf0ece","unresolved":true,"context_lines":[{"line_number":1489,"context_line":"            # \u0027vnfConfigurableProperties\u0027, # omitted"},{"line_number":1490,"context_line":"            # \u0027vimConnectionInfo\u0027, # omitted"},{"line_number":1491,"context_line":"            \u0027instantiationState\u0027,"},{"line_number":1492,"context_line":"            # \u0027instantiatedVnfInfo\u0027, # omitted"},{"line_number":1493,"context_line":"            # \u0027metadata\u0027, # omitted"},{"line_number":1494,"context_line":"            # \u0027extensions\u0027, # omitted"},{"line_number":1495,"context_line":"            \u0027_links\u0027"}],"source_content_type":"text/x-python","patch_set":35,"id":"d37259f3_5c7b770d","line":1492,"in_reply_to":"22544df6_d74b86a8","updated":"2023-04-03 08:46:10.000000000","message":"I fixed it in PS37.","commit_id":"a22d54ed544a7fd9ffeb06ef47b8520299dfad10"},{"author":{"_account_id":31668},"change_message_id":"a2c4b01b4880d2e8b5a6492071fb856f65accb77","unresolved":false,"context_lines":[{"line_number":1489,"context_line":"            # \u0027vnfConfigurableProperties\u0027, # omitted"},{"line_number":1490,"context_line":"            # \u0027vimConnectionInfo\u0027, # omitted"},{"line_number":1491,"context_line":"            \u0027instantiationState\u0027,"},{"line_number":1492,"context_line":"            # \u0027instantiatedVnfInfo\u0027, # omitted"},{"line_number":1493,"context_line":"            # \u0027metadata\u0027, # omitted"},{"line_number":1494,"context_line":"            # \u0027extensions\u0027, # omitted"},{"line_number":1495,"context_line":"            \u0027_links\u0027"}],"source_content_type":"text/x-python","patch_set":35,"id":"f70115d8_1bd3ac25","line":1492,"in_reply_to":"d37259f3_5c7b770d","updated":"2023-04-04 08:01:02.000000000","message":"Done","commit_id":"a22d54ed544a7fd9ffeb06ef47b8520299dfad10"},{"author":{"_account_id":31668},"change_message_id":"fde66f73213d2e9c386e4ddcd374e484e02b1982","unresolved":true,"context_lines":[{"line_number":1525,"context_line":"            # \u0027grantId\u0027, # omitted"},{"line_number":1526,"context_line":"            \u0027operation\u0027,"},{"line_number":1527,"context_line":"            \u0027isAutomaticInvocation\u0027,"},{"line_number":1528,"context_line":"            # \u0027operationParams\u0027, # omitted"},{"line_number":1529,"context_line":"            \u0027isCancelPending\u0027,"},{"line_number":1530,"context_line":"            # \u0027cancelMode\u0027, # omitted"},{"line_number":1531,"context_line":"            # \u0027error\u0027, # omitted"}],"source_content_type":"text/x-python","patch_set":35,"id":"e29acae1_bf325373","line":1528,"updated":"2023-03-31 07:12:05.000000000","message":"The operationParams is also set, so please don\u0027t omit it.","commit_id":"a22d54ed544a7fd9ffeb06ef47b8520299dfad10"},{"author":{"_account_id":31668},"change_message_id":"a2c4b01b4880d2e8b5a6492071fb856f65accb77","unresolved":false,"context_lines":[{"line_number":1525,"context_line":"            # \u0027grantId\u0027, # omitted"},{"line_number":1526,"context_line":"            \u0027operation\u0027,"},{"line_number":1527,"context_line":"            \u0027isAutomaticInvocation\u0027,"},{"line_number":1528,"context_line":"            # \u0027operationParams\u0027, # omitted"},{"line_number":1529,"context_line":"            \u0027isCancelPending\u0027,"},{"line_number":1530,"context_line":"            # \u0027cancelMode\u0027, # omitted"},{"line_number":1531,"context_line":"            # \u0027error\u0027, # omitted"}],"source_content_type":"text/x-python","patch_set":35,"id":"15b163d3_38eabf76","line":1528,"in_reply_to":"0fa526d5_311e8adb","updated":"2023-04-04 08:01:02.000000000","message":"Done","commit_id":"a22d54ed544a7fd9ffeb06ef47b8520299dfad10"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"878d3176b1efb13b1e3dea24e56f20ccebdf0ece","unresolved":true,"context_lines":[{"line_number":1525,"context_line":"            # \u0027grantId\u0027, # omitted"},{"line_number":1526,"context_line":"            \u0027operation\u0027,"},{"line_number":1527,"context_line":"            \u0027isAutomaticInvocation\u0027,"},{"line_number":1528,"context_line":"            # \u0027operationParams\u0027, # omitted"},{"line_number":1529,"context_line":"            \u0027isCancelPending\u0027,"},{"line_number":1530,"context_line":"            # \u0027cancelMode\u0027, # omitted"},{"line_number":1531,"context_line":"            # \u0027error\u0027, # omitted"}],"source_content_type":"text/x-python","patch_set":35,"id":"0fa526d5_311e8adb","line":1528,"in_reply_to":"e29acae1_bf325373","updated":"2023-04-03 08:46:10.000000000","message":"I fixed it in PS37.","commit_id":"a22d54ed544a7fd9ffeb06ef47b8520299dfad10"},{"author":{"_account_id":31668},"change_message_id":"fde66f73213d2e9c386e4ddcd374e484e02b1982","unresolved":true,"context_lines":[{"line_number":1528,"context_line":"            # \u0027operationParams\u0027, # omitted"},{"line_number":1529,"context_line":"            \u0027isCancelPending\u0027,"},{"line_number":1530,"context_line":"            # \u0027cancelMode\u0027, # omitted"},{"line_number":1531,"context_line":"            # \u0027error\u0027, # omitted"},{"line_number":1532,"context_line":"            # \u0027resourceChanges\u0027, # omitted"},{"line_number":1533,"context_line":"            # \u0027changedInfo\u0027, # omitted"},{"line_number":1534,"context_line":"            # \u0027changedExtConnectivity\u0027, # omitted"}],"source_content_type":"text/x-python","patch_set":35,"id":"63b0dacb_2368dfb3","line":1531,"updated":"2023-03-31 07:12:05.000000000","message":"The error is also set, so please don\u0027t omit it.","commit_id":"a22d54ed544a7fd9ffeb06ef47b8520299dfad10"},{"author":{"_account_id":31668},"change_message_id":"a2c4b01b4880d2e8b5a6492071fb856f65accb77","unresolved":false,"context_lines":[{"line_number":1528,"context_line":"            # \u0027operationParams\u0027, # omitted"},{"line_number":1529,"context_line":"            \u0027isCancelPending\u0027,"},{"line_number":1530,"context_line":"            # \u0027cancelMode\u0027, # omitted"},{"line_number":1531,"context_line":"            # \u0027error\u0027, # omitted"},{"line_number":1532,"context_line":"            # \u0027resourceChanges\u0027, # omitted"},{"line_number":1533,"context_line":"            # \u0027changedInfo\u0027, # omitted"},{"line_number":1534,"context_line":"            # \u0027changedExtConnectivity\u0027, # omitted"}],"source_content_type":"text/x-python","patch_set":35,"id":"39993a20_9272b997","line":1531,"in_reply_to":"5ba348a2_43f4482b","updated":"2023-04-04 08:01:02.000000000","message":"Done","commit_id":"a22d54ed544a7fd9ffeb06ef47b8520299dfad10"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"878d3176b1efb13b1e3dea24e56f20ccebdf0ece","unresolved":true,"context_lines":[{"line_number":1528,"context_line":"            # \u0027operationParams\u0027, # omitted"},{"line_number":1529,"context_line":"            \u0027isCancelPending\u0027,"},{"line_number":1530,"context_line":"            # \u0027cancelMode\u0027, # omitted"},{"line_number":1531,"context_line":"            # \u0027error\u0027, # omitted"},{"line_number":1532,"context_line":"            # \u0027resourceChanges\u0027, # omitted"},{"line_number":1533,"context_line":"            # \u0027changedInfo\u0027, # omitted"},{"line_number":1534,"context_line":"            # \u0027changedExtConnectivity\u0027, # omitted"}],"source_content_type":"text/x-python","patch_set":35,"id":"5ba348a2_43f4482b","line":1531,"in_reply_to":"63b0dacb_2368dfb3","updated":"2023-04-03 08:46:10.000000000","message":"I fixed it in PS37.","commit_id":"a22d54ed544a7fd9ffeb06ef47b8520299dfad10"},{"author":{"_account_id":31668},"change_message_id":"fde66f73213d2e9c386e4ddcd374e484e02b1982","unresolved":true,"context_lines":[{"line_number":1546,"context_line":"        self.assertEqual(200, resp.status_code)"},{"line_number":1547,"context_line":"        self.check_resp_headers_in_index(resp)"},{"line_number":1548,"context_line":"        for lcmocc in body:"},{"line_number":1549,"context_line":"            self.check_resp_body(lcmocc, expected_attrs)"},{"line_number":1550,"context_line":""},{"line_number":1551,"context_line":"        # 7. Update VNF(will fail)"},{"line_number":1552,"context_line":"        self._put_fail_file(\u0027modify_information_start\u0027)"}],"source_content_type":"text/x-python","patch_set":35,"id":"26c8723a_6164edda","line":1549,"updated":"2023-03-31 07:12:05.000000000","message":"It is better to use expected_attrs with the same content as L.1407.","commit_id":"a22d54ed544a7fd9ffeb06ef47b8520299dfad10"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"878d3176b1efb13b1e3dea24e56f20ccebdf0ece","unresolved":true,"context_lines":[{"line_number":1546,"context_line":"        self.assertEqual(200, resp.status_code)"},{"line_number":1547,"context_line":"        self.check_resp_headers_in_index(resp)"},{"line_number":1548,"context_line":"        for lcmocc in body:"},{"line_number":1549,"context_line":"            self.check_resp_body(lcmocc, expected_attrs)"},{"line_number":1550,"context_line":""},{"line_number":1551,"context_line":"        # 7. Update VNF(will fail)"},{"line_number":1552,"context_line":"        self._put_fail_file(\u0027modify_information_start\u0027)"}],"source_content_type":"text/x-python","patch_set":35,"id":"bd40ac8b_71e57307","line":1549,"in_reply_to":"26c8723a_6164edda","updated":"2023-04-03 08:46:10.000000000","message":"I fixed it in PS37.","commit_id":"a22d54ed544a7fd9ffeb06ef47b8520299dfad10"},{"author":{"_account_id":31668},"change_message_id":"a2c4b01b4880d2e8b5a6492071fb856f65accb77","unresolved":false,"context_lines":[{"line_number":1546,"context_line":"        self.assertEqual(200, resp.status_code)"},{"line_number":1547,"context_line":"        self.check_resp_headers_in_index(resp)"},{"line_number":1548,"context_line":"        for lcmocc in body:"},{"line_number":1549,"context_line":"            self.check_resp_body(lcmocc, expected_attrs)"},{"line_number":1550,"context_line":""},{"line_number":1551,"context_line":"        # 7. Update VNF(will fail)"},{"line_number":1552,"context_line":"        self._put_fail_file(\u0027modify_information_start\u0027)"}],"source_content_type":"text/x-python","patch_set":35,"id":"a4f1c874_f64103b9","line":1549,"in_reply_to":"bd40ac8b_71e57307","updated":"2023-04-04 08:01:02.000000000","message":"Done","commit_id":"a22d54ed544a7fd9ffeb06ef47b8520299dfad10"},{"author":{"_account_id":31668},"change_message_id":"fde66f73213d2e9c386e4ddcd374e484e02b1982","unresolved":true,"context_lines":[{"line_number":1575,"context_line":"            # \u0027grantId\u0027, # omitted"},{"line_number":1576,"context_line":"            \u0027operation\u0027,"},{"line_number":1577,"context_line":"            \u0027isAutomaticInvocation\u0027,"},{"line_number":1578,"context_line":"            # \u0027operationParams\u0027, # omitted"},{"line_number":1579,"context_line":"            \u0027isCancelPending\u0027,"},{"line_number":1580,"context_line":"            # \u0027cancelMode\u0027, # omitted"},{"line_number":1581,"context_line":"            # \u0027error\u0027, # omitted"}],"source_content_type":"text/x-python","patch_set":35,"id":"ba4ce39f_0c2278b4","line":1578,"updated":"2023-03-31 07:12:05.000000000","message":"The operationParams is also set, so please don\u0027t omit it.","commit_id":"a22d54ed544a7fd9ffeb06ef47b8520299dfad10"},{"author":{"_account_id":31668},"change_message_id":"a2c4b01b4880d2e8b5a6492071fb856f65accb77","unresolved":false,"context_lines":[{"line_number":1575,"context_line":"            # \u0027grantId\u0027, # omitted"},{"line_number":1576,"context_line":"            \u0027operation\u0027,"},{"line_number":1577,"context_line":"            \u0027isAutomaticInvocation\u0027,"},{"line_number":1578,"context_line":"            # \u0027operationParams\u0027, # omitted"},{"line_number":1579,"context_line":"            \u0027isCancelPending\u0027,"},{"line_number":1580,"context_line":"            # \u0027cancelMode\u0027, # omitted"},{"line_number":1581,"context_line":"            # \u0027error\u0027, # omitted"}],"source_content_type":"text/x-python","patch_set":35,"id":"2397b045_b4755fe4","line":1578,"in_reply_to":"6dbdbc29_3b404360","updated":"2023-04-04 08:01:02.000000000","message":"Done","commit_id":"a22d54ed544a7fd9ffeb06ef47b8520299dfad10"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"878d3176b1efb13b1e3dea24e56f20ccebdf0ece","unresolved":true,"context_lines":[{"line_number":1575,"context_line":"            # \u0027grantId\u0027, # omitted"},{"line_number":1576,"context_line":"            \u0027operation\u0027,"},{"line_number":1577,"context_line":"            \u0027isAutomaticInvocation\u0027,"},{"line_number":1578,"context_line":"            # \u0027operationParams\u0027, # omitted"},{"line_number":1579,"context_line":"            \u0027isCancelPending\u0027,"},{"line_number":1580,"context_line":"            # \u0027cancelMode\u0027, # omitted"},{"line_number":1581,"context_line":"            # \u0027error\u0027, # omitted"}],"source_content_type":"text/x-python","patch_set":35,"id":"6dbdbc29_3b404360","line":1578,"in_reply_to":"ba4ce39f_0c2278b4","updated":"2023-04-03 08:46:10.000000000","message":"I fixed it in PS37.","commit_id":"a22d54ed544a7fd9ffeb06ef47b8520299dfad10"},{"author":{"_account_id":31668},"change_message_id":"fde66f73213d2e9c386e4ddcd374e484e02b1982","unresolved":true,"context_lines":[{"line_number":1578,"context_line":"            # \u0027operationParams\u0027, # omitted"},{"line_number":1579,"context_line":"            \u0027isCancelPending\u0027,"},{"line_number":1580,"context_line":"            # \u0027cancelMode\u0027, # omitted"},{"line_number":1581,"context_line":"            # \u0027error\u0027, # omitted"},{"line_number":1582,"context_line":"            # \u0027resourceChanges\u0027, # omitted"},{"line_number":1583,"context_line":"            # \u0027changedInfo\u0027, # omitted"},{"line_number":1584,"context_line":"            # \u0027changedExtConnectivity\u0027, # omitted"}],"source_content_type":"text/x-python","patch_set":35,"id":"72403ab7_8fc5445f","line":1581,"updated":"2023-03-31 07:12:05.000000000","message":"The error is also set, so please don\u0027t omit it.","commit_id":"a22d54ed544a7fd9ffeb06ef47b8520299dfad10"},{"author":{"_account_id":31668},"change_message_id":"a2c4b01b4880d2e8b5a6492071fb856f65accb77","unresolved":false,"context_lines":[{"line_number":1578,"context_line":"            # \u0027operationParams\u0027, # omitted"},{"line_number":1579,"context_line":"            \u0027isCancelPending\u0027,"},{"line_number":1580,"context_line":"            # \u0027cancelMode\u0027, # omitted"},{"line_number":1581,"context_line":"            # \u0027error\u0027, # omitted"},{"line_number":1582,"context_line":"            # \u0027resourceChanges\u0027, # omitted"},{"line_number":1583,"context_line":"            # \u0027changedInfo\u0027, # omitted"},{"line_number":1584,"context_line":"            # \u0027changedExtConnectivity\u0027, # omitted"}],"source_content_type":"text/x-python","patch_set":35,"id":"485100a2_5e7ca811","line":1581,"in_reply_to":"04b84c7f_ce7a5bc0","updated":"2023-04-04 08:01:02.000000000","message":"Done","commit_id":"a22d54ed544a7fd9ffeb06ef47b8520299dfad10"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"878d3176b1efb13b1e3dea24e56f20ccebdf0ece","unresolved":true,"context_lines":[{"line_number":1578,"context_line":"            # \u0027operationParams\u0027, # omitted"},{"line_number":1579,"context_line":"            \u0027isCancelPending\u0027,"},{"line_number":1580,"context_line":"            # \u0027cancelMode\u0027, # omitted"},{"line_number":1581,"context_line":"            # \u0027error\u0027, # omitted"},{"line_number":1582,"context_line":"            # \u0027resourceChanges\u0027, # omitted"},{"line_number":1583,"context_line":"            # \u0027changedInfo\u0027, # omitted"},{"line_number":1584,"context_line":"            # \u0027changedExtConnectivity\u0027, # omitted"}],"source_content_type":"text/x-python","patch_set":35,"id":"04b84c7f_ce7a5bc0","line":1581,"in_reply_to":"72403ab7_8fc5445f","updated":"2023-04-03 08:46:10.000000000","message":"I fixed it in PS37.","commit_id":"a22d54ed544a7fd9ffeb06ef47b8520299dfad10"},{"author":{"_account_id":31668},"change_message_id":"fde66f73213d2e9c386e4ddcd374e484e02b1982","unresolved":true,"context_lines":[{"line_number":1596,"context_line":"        self.assertEqual(200, resp.status_code)"},{"line_number":1597,"context_line":"        self.check_resp_headers_in_index(resp)"},{"line_number":1598,"context_line":"        for lcmocc in body:"},{"line_number":1599,"context_line":"            self.check_resp_body(lcmocc, expected_attrs)"},{"line_number":1600,"context_line":""},{"line_number":1601,"context_line":"        # 11. Terminate VNF"},{"line_number":1602,"context_line":"        terminate_req \u003d paramgen.terminate_vnf_min()"}],"source_content_type":"text/x-python","patch_set":35,"id":"ac3fb424_9fb01a68","line":1599,"updated":"2023-03-31 07:12:05.000000000","message":"It is better to use expected_attrs with the same content as L.1407.","commit_id":"a22d54ed544a7fd9ffeb06ef47b8520299dfad10"},{"author":{"_account_id":31668},"change_message_id":"a2c4b01b4880d2e8b5a6492071fb856f65accb77","unresolved":false,"context_lines":[{"line_number":1596,"context_line":"        self.assertEqual(200, resp.status_code)"},{"line_number":1597,"context_line":"        self.check_resp_headers_in_index(resp)"},{"line_number":1598,"context_line":"        for lcmocc in body:"},{"line_number":1599,"context_line":"            self.check_resp_body(lcmocc, expected_attrs)"},{"line_number":1600,"context_line":""},{"line_number":1601,"context_line":"        # 11. Terminate VNF"},{"line_number":1602,"context_line":"        terminate_req \u003d paramgen.terminate_vnf_min()"}],"source_content_type":"text/x-python","patch_set":35,"id":"22c3b9ce_4d779358","line":1599,"in_reply_to":"1102ed7d_23434e23","updated":"2023-04-04 08:01:02.000000000","message":"Done","commit_id":"a22d54ed544a7fd9ffeb06ef47b8520299dfad10"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"878d3176b1efb13b1e3dea24e56f20ccebdf0ece","unresolved":true,"context_lines":[{"line_number":1596,"context_line":"        self.assertEqual(200, resp.status_code)"},{"line_number":1597,"context_line":"        self.check_resp_headers_in_index(resp)"},{"line_number":1598,"context_line":"        for lcmocc in body:"},{"line_number":1599,"context_line":"            self.check_resp_body(lcmocc, expected_attrs)"},{"line_number":1600,"context_line":""},{"line_number":1601,"context_line":"        # 11. Terminate VNF"},{"line_number":1602,"context_line":"        terminate_req \u003d paramgen.terminate_vnf_min()"}],"source_content_type":"text/x-python","patch_set":35,"id":"1102ed7d_23434e23","line":1599,"in_reply_to":"ac3fb424_9fb01a68","updated":"2023-04-03 08:46:10.000000000","message":"I fixed it in PS37.","commit_id":"a22d54ed544a7fd9ffeb06ef47b8520299dfad10"},{"author":{"_account_id":31668},"change_message_id":"a2c4b01b4880d2e8b5a6492071fb856f65accb77","unresolved":true,"context_lines":[{"line_number":85,"context_line":"            # \u0027grantId\u0027, # omitted"},{"line_number":86,"context_line":"            \u0027operation\u0027,"},{"line_number":87,"context_line":"            \u0027isAutomaticInvocation\u0027,"},{"line_number":88,"context_line":"            # \u0027operationParams\u0027,"},{"line_number":89,"context_line":"            \u0027isCancelPending\u0027,"},{"line_number":90,"context_line":"            # \u0027cancelMode\u0027, # omitted"},{"line_number":91,"context_line":"            # \u0027error\u0027, # omitted"}],"source_content_type":"text/x-python","patch_set":37,"id":"e4045af0_a0023c40","line":88,"updated":"2023-04-04 08:01:02.000000000","message":"nit: # \u0027operationParams\u0027, -\u003e # \u0027operationParams\u0027, # omitted","commit_id":"e6db6a662a5fd52ecabea4b834a5c2013d8d95e1"},{"author":{"_account_id":31668},"change_message_id":"4c5937e136c86b08773e33086dcb0e7988fa0cad","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            # \u0027grantId\u0027, # omitted"},{"line_number":86,"context_line":"            \u0027operation\u0027,"},{"line_number":87,"context_line":"            \u0027isAutomaticInvocation\u0027,"},{"line_number":88,"context_line":"            # \u0027operationParams\u0027,"},{"line_number":89,"context_line":"            \u0027isCancelPending\u0027,"},{"line_number":90,"context_line":"            # \u0027cancelMode\u0027, # omitted"},{"line_number":91,"context_line":"            # \u0027error\u0027, # omitted"}],"source_content_type":"text/x-python","patch_set":37,"id":"eaed2384_8a307908","line":88,"in_reply_to":"6d3b3100_d851d0b6","updated":"2023-04-10 07:33:44.000000000","message":"Done","commit_id":"e6db6a662a5fd52ecabea4b834a5c2013d8d95e1"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"2af3376165484707348a813352ffd66391542d9e","unresolved":true,"context_lines":[{"line_number":85,"context_line":"            # \u0027grantId\u0027, # omitted"},{"line_number":86,"context_line":"            \u0027operation\u0027,"},{"line_number":87,"context_line":"            \u0027isAutomaticInvocation\u0027,"},{"line_number":88,"context_line":"            # \u0027operationParams\u0027,"},{"line_number":89,"context_line":"            \u0027isCancelPending\u0027,"},{"line_number":90,"context_line":"            # \u0027cancelMode\u0027, # omitted"},{"line_number":91,"context_line":"            # \u0027error\u0027, # omitted"}],"source_content_type":"text/x-python","patch_set":37,"id":"6d3b3100_d851d0b6","line":88,"in_reply_to":"e4045af0_a0023c40","updated":"2023-04-10 05:36:03.000000000","message":"I fixed it in PS38.","commit_id":"e6db6a662a5fd52ecabea4b834a5c2013d8d95e1"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"f19e5ec3c81954db706cbc026364ed9a58b20ce0","unresolved":true,"context_lines":[{"line_number":333,"context_line":"          - 6. Show VNF instance(check for heal)"},{"line_number":334,"context_line":"          - 7. List VNF LCM operation occurrence with attribute-based"},{"line_number":335,"context_line":"               filtering"},{"line_number":336,"context_line":"          - 8. Heal VNF(all with all\u003dtrue parameter)"},{"line_number":337,"context_line":"          - 9. Show VNF instance(check for heal)"},{"line_number":338,"context_line":"          - 10. Scale out operation"},{"line_number":339,"context_line":"          - 11. Show VNF instance(check for scale)"}],"source_content_type":"text/x-python","patch_set":37,"id":"128c38cc_d09829e5","line":336,"range":{"start_line":336,"start_character":37,"end_line":336,"end_character":41},"updated":"2023-04-05 08:17:27.000000000","message":"nits: true -\u003e True","commit_id":"e6db6a662a5fd52ecabea4b834a5c2013d8d95e1"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"2af3376165484707348a813352ffd66391542d9e","unresolved":true,"context_lines":[{"line_number":333,"context_line":"          - 6. Show VNF instance(check for heal)"},{"line_number":334,"context_line":"          - 7. List VNF LCM operation occurrence with attribute-based"},{"line_number":335,"context_line":"               filtering"},{"line_number":336,"context_line":"          - 8. Heal VNF(all with all\u003dtrue parameter)"},{"line_number":337,"context_line":"          - 9. Show VNF instance(check for heal)"},{"line_number":338,"context_line":"          - 10. Scale out operation"},{"line_number":339,"context_line":"          - 11. Show VNF instance(check for scale)"}],"source_content_type":"text/x-python","patch_set":37,"id":"ab605821_251444fb","line":336,"range":{"start_line":336,"start_character":37,"end_line":336,"end_character":41},"in_reply_to":"128c38cc_d09829e5","updated":"2023-04-10 05:36:03.000000000","message":"I fixed it in PS38.","commit_id":"e6db6a662a5fd52ecabea4b834a5c2013d8d95e1"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"9b79d3962734baafda9c42b7df33a7730784bfa5","unresolved":false,"context_lines":[{"line_number":333,"context_line":"          - 6. Show VNF instance(check for heal)"},{"line_number":334,"context_line":"          - 7. List VNF LCM operation occurrence with attribute-based"},{"line_number":335,"context_line":"               filtering"},{"line_number":336,"context_line":"          - 8. Heal VNF(all with all\u003dtrue parameter)"},{"line_number":337,"context_line":"          - 9. Show VNF instance(check for heal)"},{"line_number":338,"context_line":"          - 10. Scale out operation"},{"line_number":339,"context_line":"          - 11. Show VNF instance(check for scale)"}],"source_content_type":"text/x-python","patch_set":37,"id":"3a04b791_8c4ad0d2","line":336,"range":{"start_line":336,"start_character":37,"end_line":336,"end_character":41},"in_reply_to":"ab605821_251444fb","updated":"2023-04-13 02:42:00.000000000","message":"Done","commit_id":"e6db6a662a5fd52ecabea4b834a5c2013d8d95e1"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"f19e5ec3c81954db706cbc026364ed9a58b20ce0","unresolved":true,"context_lines":[{"line_number":347,"context_line":"          - 19. Show VNF instance(check for heal)"},{"line_number":348,"context_line":"          - 20. Heal VNF(vnfc with all\u003dfalse parameter)"},{"line_number":349,"context_line":"          - 21. Show VNF instance(check for heal)"},{"line_number":350,"context_line":"          - 22. Heal VNF(vnfc with all\u003dtrue parameter)"},{"line_number":351,"context_line":"          - 23. Show VNF instance(check for heal)"},{"line_number":352,"context_line":"          - 24. Update VNF"},{"line_number":353,"context_line":"          - 25. Show VNF instance(check for update)"}],"source_content_type":"text/x-python","patch_set":37,"id":"39e0aaed_553f48fa","line":350,"range":{"start_line":350,"start_character":39,"end_line":350,"end_character":43},"updated":"2023-04-05 08:17:27.000000000","message":"ditto.","commit_id":"e6db6a662a5fd52ecabea4b834a5c2013d8d95e1"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"9b79d3962734baafda9c42b7df33a7730784bfa5","unresolved":false,"context_lines":[{"line_number":347,"context_line":"          - 19. Show VNF instance(check for heal)"},{"line_number":348,"context_line":"          - 20. Heal VNF(vnfc with all\u003dfalse parameter)"},{"line_number":349,"context_line":"          - 21. Show VNF instance(check for heal)"},{"line_number":350,"context_line":"          - 22. Heal VNF(vnfc with all\u003dtrue parameter)"},{"line_number":351,"context_line":"          - 23. Show VNF instance(check for heal)"},{"line_number":352,"context_line":"          - 24. Update VNF"},{"line_number":353,"context_line":"          - 25. Show VNF instance(check for update)"}],"source_content_type":"text/x-python","patch_set":37,"id":"865c55b3_c58d7cbd","line":350,"range":{"start_line":350,"start_character":39,"end_line":350,"end_character":43},"in_reply_to":"014da077_c75ba5d4","updated":"2023-04-13 02:42:00.000000000","message":"Done","commit_id":"e6db6a662a5fd52ecabea4b834a5c2013d8d95e1"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"2af3376165484707348a813352ffd66391542d9e","unresolved":true,"context_lines":[{"line_number":347,"context_line":"          - 19. Show VNF instance(check for heal)"},{"line_number":348,"context_line":"          - 20. Heal VNF(vnfc with all\u003dfalse parameter)"},{"line_number":349,"context_line":"          - 21. Show VNF instance(check for heal)"},{"line_number":350,"context_line":"          - 22. Heal VNF(vnfc with all\u003dtrue parameter)"},{"line_number":351,"context_line":"          - 23. Show VNF instance(check for heal)"},{"line_number":352,"context_line":"          - 24. Update VNF"},{"line_number":353,"context_line":"          - 25. Show VNF instance(check for update)"}],"source_content_type":"text/x-python","patch_set":37,"id":"014da077_c75ba5d4","line":350,"range":{"start_line":350,"start_character":39,"end_line":350,"end_character":43},"in_reply_to":"39e0aaed_553f48fa","updated":"2023-04-10 05:36:03.000000000","message":"ditto","commit_id":"e6db6a662a5fd52ecabea4b834a5c2013d8d95e1"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"f19e5ec3c81954db706cbc026364ed9a58b20ce0","unresolved":true,"context_lines":[{"line_number":520,"context_line":"                            self._get_vnfc_id(inst_6, \u0027VDU1\u0027, 0))"},{"line_number":521,"context_line":"        self.assertNotEqual(self._get_vnfc_id(inst_2, \u0027VDU2\u0027, 0),"},{"line_number":522,"context_line":"                            self._get_vnfc_id(inst_6, \u0027VDU2\u0027, 0))"},{"line_number":523,"context_line":"        # check images are not change"},{"line_number":524,"context_line":"        self.assertEqual(self._get_vnfc_image(inst_2, \u0027VDU1\u0027, 0),"},{"line_number":525,"context_line":"                         self._get_vnfc_image(inst_6, \u0027VDU1\u0027, 0))"},{"line_number":526,"context_line":"        self.assertEqual(self._get_vnfc_image(inst_2, \u0027VDU2\u0027, 0),"}],"source_content_type":"text/x-python","patch_set":37,"id":"9a4cd6c6_ea4d1b40","line":523,"range":{"start_line":523,"start_character":10,"end_line":523,"end_character":37},"updated":"2023-04-05 08:17:27.000000000","message":"nits: check images are not change -\u003e check images are not changed.","commit_id":"e6db6a662a5fd52ecabea4b834a5c2013d8d95e1"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"9b79d3962734baafda9c42b7df33a7730784bfa5","unresolved":false,"context_lines":[{"line_number":520,"context_line":"                            self._get_vnfc_id(inst_6, \u0027VDU1\u0027, 0))"},{"line_number":521,"context_line":"        self.assertNotEqual(self._get_vnfc_id(inst_2, \u0027VDU2\u0027, 0),"},{"line_number":522,"context_line":"                            self._get_vnfc_id(inst_6, \u0027VDU2\u0027, 0))"},{"line_number":523,"context_line":"        # check images are not change"},{"line_number":524,"context_line":"        self.assertEqual(self._get_vnfc_image(inst_2, \u0027VDU1\u0027, 0),"},{"line_number":525,"context_line":"                         self._get_vnfc_image(inst_6, \u0027VDU1\u0027, 0))"},{"line_number":526,"context_line":"        self.assertEqual(self._get_vnfc_image(inst_2, \u0027VDU2\u0027, 0),"}],"source_content_type":"text/x-python","patch_set":37,"id":"2350c39e_b5b4e035","line":523,"range":{"start_line":523,"start_character":10,"end_line":523,"end_character":37},"in_reply_to":"021ee43a_b364bdaf","updated":"2023-04-13 02:42:00.000000000","message":"Done","commit_id":"e6db6a662a5fd52ecabea4b834a5c2013d8d95e1"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"2af3376165484707348a813352ffd66391542d9e","unresolved":true,"context_lines":[{"line_number":520,"context_line":"                            self._get_vnfc_id(inst_6, \u0027VDU1\u0027, 0))"},{"line_number":521,"context_line":"        self.assertNotEqual(self._get_vnfc_id(inst_2, \u0027VDU2\u0027, 0),"},{"line_number":522,"context_line":"                            self._get_vnfc_id(inst_6, \u0027VDU2\u0027, 0))"},{"line_number":523,"context_line":"        # check images are not change"},{"line_number":524,"context_line":"        self.assertEqual(self._get_vnfc_image(inst_2, \u0027VDU1\u0027, 0),"},{"line_number":525,"context_line":"                         self._get_vnfc_image(inst_6, \u0027VDU1\u0027, 0))"},{"line_number":526,"context_line":"        self.assertEqual(self._get_vnfc_image(inst_2, \u0027VDU2\u0027, 0),"}],"source_content_type":"text/x-python","patch_set":37,"id":"021ee43a_b364bdaf","line":523,"range":{"start_line":523,"start_character":10,"end_line":523,"end_character":37},"in_reply_to":"9a4cd6c6_ea4d1b40","updated":"2023-04-10 05:36:03.000000000","message":"I fixed it in PS38.","commit_id":"e6db6a662a5fd52ecabea4b834a5c2013d8d95e1"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"f19e5ec3c81954db706cbc026364ed9a58b20ce0","unresolved":true,"context_lines":[{"line_number":570,"context_line":"            self.assertNotIn(\u0027operationParams\u0027, lcmocc)"},{"line_number":571,"context_line":"            self.assertNotIn(\u0027resourceChanges\u0027, lcmocc)"},{"line_number":572,"context_line":""},{"line_number":573,"context_line":"        # 8. Heal VNF(all with all\u003dtrue parameter)"},{"line_number":574,"context_line":"        heal_req \u003d paramgen.heal_vnf_all_max_with_parameter(True)"},{"line_number":575,"context_line":"        self._add_additional_params(heal_req)"},{"line_number":576,"context_line":"        resp, body \u003d self.heal_vnf_instance(inst_id, heal_req)"}],"source_content_type":"text/x-python","patch_set":37,"id":"dcd14909_d205e844","line":573,"range":{"start_line":573,"start_character":35,"end_line":573,"end_character":39},"updated":"2023-04-05 08:17:27.000000000","message":"nits: true -\u003e True","commit_id":"e6db6a662a5fd52ecabea4b834a5c2013d8d95e1"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"9b79d3962734baafda9c42b7df33a7730784bfa5","unresolved":false,"context_lines":[{"line_number":570,"context_line":"            self.assertNotIn(\u0027operationParams\u0027, lcmocc)"},{"line_number":571,"context_line":"            self.assertNotIn(\u0027resourceChanges\u0027, lcmocc)"},{"line_number":572,"context_line":""},{"line_number":573,"context_line":"        # 8. Heal VNF(all with all\u003dtrue parameter)"},{"line_number":574,"context_line":"        heal_req \u003d paramgen.heal_vnf_all_max_with_parameter(True)"},{"line_number":575,"context_line":"        self._add_additional_params(heal_req)"},{"line_number":576,"context_line":"        resp, body \u003d self.heal_vnf_instance(inst_id, heal_req)"}],"source_content_type":"text/x-python","patch_set":37,"id":"2b7114fd_0c8948b6","line":573,"range":{"start_line":573,"start_character":35,"end_line":573,"end_character":39},"in_reply_to":"25528847_0043b586","updated":"2023-04-13 02:42:00.000000000","message":"Done","commit_id":"e6db6a662a5fd52ecabea4b834a5c2013d8d95e1"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"2af3376165484707348a813352ffd66391542d9e","unresolved":true,"context_lines":[{"line_number":570,"context_line":"            self.assertNotIn(\u0027operationParams\u0027, lcmocc)"},{"line_number":571,"context_line":"            self.assertNotIn(\u0027resourceChanges\u0027, lcmocc)"},{"line_number":572,"context_line":""},{"line_number":573,"context_line":"        # 8. Heal VNF(all with all\u003dtrue parameter)"},{"line_number":574,"context_line":"        heal_req \u003d paramgen.heal_vnf_all_max_with_parameter(True)"},{"line_number":575,"context_line":"        self._add_additional_params(heal_req)"},{"line_number":576,"context_line":"        resp, body \u003d self.heal_vnf_instance(inst_id, heal_req)"}],"source_content_type":"text/x-python","patch_set":37,"id":"25528847_0043b586","line":573,"range":{"start_line":573,"start_character":35,"end_line":573,"end_character":39},"in_reply_to":"dcd14909_d205e844","updated":"2023-04-10 05:36:03.000000000","message":"I fixed it in PS38.","commit_id":"e6db6a662a5fd52ecabea4b834a5c2013d8d95e1"},{"author":{"_account_id":31668},"change_message_id":"6c130455c201fba62834a757d693a170d3a19767","unresolved":true,"context_lines":[{"line_number":679,"context_line":"        inst_17 \u003d self._check_for_show_operation("},{"line_number":680,"context_line":"            \u0027CHANGE_EXT_CONN\u0027, expected_inst_attrs, inst_id, vdu_result)"},{"line_number":681,"context_line":"        # check vnfExtCPIds of VDU are changed"},{"line_number":682,"context_line":"        for cp_1 in [\u0027VDU1_CP1\u0027, \u0027VDU2_CP2\u0027]:"},{"line_number":683,"context_line":"            self.assertNotEqual("},{"line_number":684,"context_line":"                self._get_vnf_ext_cp_id(inst_15, cp_1.split(\u0027_\u0027)[0], 0, cp_1),"},{"line_number":685,"context_line":"                self._get_vnf_ext_cp_id(inst_17, cp_1.split(\u0027_\u0027)[0], 0, cp_1))"}],"source_content_type":"text/x-python","patch_set":37,"id":"7cb319f5_ff12ccdc","line":682,"updated":"2023-04-05 06:40:11.000000000","message":"It also contains CP2, so what about as `ext_cp` instead of `cp_1`?","commit_id":"e6db6a662a5fd52ecabea4b834a5c2013d8d95e1"},{"author":{"_account_id":31668},"change_message_id":"4c5937e136c86b08773e33086dcb0e7988fa0cad","unresolved":false,"context_lines":[{"line_number":679,"context_line":"        inst_17 \u003d self._check_for_show_operation("},{"line_number":680,"context_line":"            \u0027CHANGE_EXT_CONN\u0027, expected_inst_attrs, inst_id, vdu_result)"},{"line_number":681,"context_line":"        # check vnfExtCPIds of VDU are changed"},{"line_number":682,"context_line":"        for cp_1 in [\u0027VDU1_CP1\u0027, \u0027VDU2_CP2\u0027]:"},{"line_number":683,"context_line":"            self.assertNotEqual("},{"line_number":684,"context_line":"                self._get_vnf_ext_cp_id(inst_15, cp_1.split(\u0027_\u0027)[0], 0, cp_1),"},{"line_number":685,"context_line":"                self._get_vnf_ext_cp_id(inst_17, cp_1.split(\u0027_\u0027)[0], 0, cp_1))"}],"source_content_type":"text/x-python","patch_set":37,"id":"1fcb8903_46c5fb96","line":682,"in_reply_to":"06bfcb49_84669566","updated":"2023-04-10 07:33:44.000000000","message":"Done","commit_id":"e6db6a662a5fd52ecabea4b834a5c2013d8d95e1"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"2af3376165484707348a813352ffd66391542d9e","unresolved":true,"context_lines":[{"line_number":679,"context_line":"        inst_17 \u003d self._check_for_show_operation("},{"line_number":680,"context_line":"            \u0027CHANGE_EXT_CONN\u0027, expected_inst_attrs, inst_id, vdu_result)"},{"line_number":681,"context_line":"        # check vnfExtCPIds of VDU are changed"},{"line_number":682,"context_line":"        for cp_1 in [\u0027VDU1_CP1\u0027, \u0027VDU2_CP2\u0027]:"},{"line_number":683,"context_line":"            self.assertNotEqual("},{"line_number":684,"context_line":"                self._get_vnf_ext_cp_id(inst_15, cp_1.split(\u0027_\u0027)[0], 0, cp_1),"},{"line_number":685,"context_line":"                self._get_vnf_ext_cp_id(inst_17, cp_1.split(\u0027_\u0027)[0], 0, cp_1))"}],"source_content_type":"text/x-python","patch_set":37,"id":"06bfcb49_84669566","line":682,"in_reply_to":"7cb319f5_ff12ccdc","updated":"2023-04-10 05:36:03.000000000","message":"I fixed it in PS39.","commit_id":"e6db6a662a5fd52ecabea4b834a5c2013d8d95e1"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"f19e5ec3c81954db706cbc026364ed9a58b20ce0","unresolved":true,"context_lines":[{"line_number":736,"context_line":"        self.assertEqual(self._get_vnfc_image(inst_19, \u0027VDU2\u0027, 0),"},{"line_number":737,"context_line":"                         self._get_vnfc_image(inst_21, \u0027VDU2\u0027, 0))"},{"line_number":738,"context_line":""},{"line_number":739,"context_line":"        # 22. Heal VNF(vnfc with all\u003dtrue parameter)"},{"line_number":740,"context_line":"        vnfc_info \u003d inst_21[\u0027instantiatedVnfInfo\u0027][\u0027vnfcInfo\u0027]"},{"line_number":741,"context_line":"        vnfc_ids \u003d [vnfc[\u0027id\u0027] for vnfc in vnfc_info]"},{"line_number":742,"context_line":"        heal_req \u003d paramgen.heal_vnf_vnfc_max_with_parameter(vnfc_ids, True)"}],"source_content_type":"text/x-python","patch_set":37,"id":"269ae275_b44f087a","line":739,"range":{"start_line":739,"start_character":37,"end_line":739,"end_character":41},"updated":"2023-04-05 08:17:27.000000000","message":"ditto.","commit_id":"e6db6a662a5fd52ecabea4b834a5c2013d8d95e1"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"2af3376165484707348a813352ffd66391542d9e","unresolved":true,"context_lines":[{"line_number":736,"context_line":"        self.assertEqual(self._get_vnfc_image(inst_19, \u0027VDU2\u0027, 0),"},{"line_number":737,"context_line":"                         self._get_vnfc_image(inst_21, \u0027VDU2\u0027, 0))"},{"line_number":738,"context_line":""},{"line_number":739,"context_line":"        # 22. Heal VNF(vnfc with all\u003dtrue parameter)"},{"line_number":740,"context_line":"        vnfc_info \u003d inst_21[\u0027instantiatedVnfInfo\u0027][\u0027vnfcInfo\u0027]"},{"line_number":741,"context_line":"        vnfc_ids \u003d [vnfc[\u0027id\u0027] for vnfc in vnfc_info]"},{"line_number":742,"context_line":"        heal_req \u003d paramgen.heal_vnf_vnfc_max_with_parameter(vnfc_ids, True)"}],"source_content_type":"text/x-python","patch_set":37,"id":"71dac952_0bff7650","line":739,"range":{"start_line":739,"start_character":37,"end_line":739,"end_character":41},"in_reply_to":"269ae275_b44f087a","updated":"2023-04-10 05:36:03.000000000","message":"ditto","commit_id":"e6db6a662a5fd52ecabea4b834a5c2013d8d95e1"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"9b79d3962734baafda9c42b7df33a7730784bfa5","unresolved":false,"context_lines":[{"line_number":736,"context_line":"        self.assertEqual(self._get_vnfc_image(inst_19, \u0027VDU2\u0027, 0),"},{"line_number":737,"context_line":"                         self._get_vnfc_image(inst_21, \u0027VDU2\u0027, 0))"},{"line_number":738,"context_line":""},{"line_number":739,"context_line":"        # 22. Heal VNF(vnfc with all\u003dtrue parameter)"},{"line_number":740,"context_line":"        vnfc_info \u003d inst_21[\u0027instantiatedVnfInfo\u0027][\u0027vnfcInfo\u0027]"},{"line_number":741,"context_line":"        vnfc_ids \u003d [vnfc[\u0027id\u0027] for vnfc in vnfc_info]"},{"line_number":742,"context_line":"        heal_req \u003d paramgen.heal_vnf_vnfc_max_with_parameter(vnfc_ids, True)"}],"source_content_type":"text/x-python","patch_set":37,"id":"41dab683_e31af928","line":739,"range":{"start_line":739,"start_character":37,"end_line":739,"end_character":41},"in_reply_to":"71dac952_0bff7650","updated":"2023-04-13 02:42:00.000000000","message":"Done","commit_id":"e6db6a662a5fd52ecabea4b834a5c2013d8d95e1"},{"author":{"_account_id":31668},"change_message_id":"a2c4b01b4880d2e8b5a6492071fb856f65accb77","unresolved":true,"context_lines":[{"line_number":1662,"context_line":"            # \u0027extensions\u0027, # omitted"},{"line_number":1663,"context_line":"            \u0027_links\u0027"},{"line_number":1664,"context_line":"        ]"},{"line_number":1665,"context_line":"        additional_inst_attrs \u003d ["},{"line_number":1666,"context_line":"            \u0027vimConnectionInfo\u0027,"},{"line_number":1667,"context_line":"            \u0027instantiatedVnfInfo\u0027"},{"line_number":1668,"context_line":"        ]"},{"line_number":1669,"context_line":"        expected_inst_attrs.extend(additional_inst_attrs)"},{"line_number":1670,"context_line":"        inst_2 \u003d self._check_for_show_operation("},{"line_number":1671,"context_line":"            \u0027INSTANTIATE\u0027, expected_inst_attrs, inst_id)"},{"line_number":1672,"context_line":""}],"source_content_type":"text/x-python","patch_set":37,"id":"2e9d822a_2676bf60","line":1669,"range":{"start_line":1665,"start_character":0,"end_line":1669,"end_character":57},"updated":"2023-04-04 08:01:02.000000000","message":"n this test, the attributes of VNF Instance in NOT_INSTANTIATED state is not checked.\nHow about setting all attributes to expected_inst_attrs without dividing them?","commit_id":"e6db6a662a5fd52ecabea4b834a5c2013d8d95e1"},{"author":{"_account_id":31668},"change_message_id":"4c5937e136c86b08773e33086dcb0e7988fa0cad","unresolved":false,"context_lines":[{"line_number":1662,"context_line":"            # \u0027extensions\u0027, # omitted"},{"line_number":1663,"context_line":"            \u0027_links\u0027"},{"line_number":1664,"context_line":"        ]"},{"line_number":1665,"context_line":"        additional_inst_attrs \u003d ["},{"line_number":1666,"context_line":"            \u0027vimConnectionInfo\u0027,"},{"line_number":1667,"context_line":"            \u0027instantiatedVnfInfo\u0027"},{"line_number":1668,"context_line":"        ]"},{"line_number":1669,"context_line":"        expected_inst_attrs.extend(additional_inst_attrs)"},{"line_number":1670,"context_line":"        inst_2 \u003d self._check_for_show_operation("},{"line_number":1671,"context_line":"            \u0027INSTANTIATE\u0027, expected_inst_attrs, inst_id)"},{"line_number":1672,"context_line":""}],"source_content_type":"text/x-python","patch_set":37,"id":"70e36525_4063e1e4","line":1669,"range":{"start_line":1665,"start_character":0,"end_line":1669,"end_character":57},"in_reply_to":"1f0b3861_c365a26a","updated":"2023-04-10 07:33:44.000000000","message":"Done","commit_id":"e6db6a662a5fd52ecabea4b834a5c2013d8d95e1"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"2af3376165484707348a813352ffd66391542d9e","unresolved":true,"context_lines":[{"line_number":1662,"context_line":"            # \u0027extensions\u0027, # omitted"},{"line_number":1663,"context_line":"            \u0027_links\u0027"},{"line_number":1664,"context_line":"        ]"},{"line_number":1665,"context_line":"        additional_inst_attrs \u003d ["},{"line_number":1666,"context_line":"            \u0027vimConnectionInfo\u0027,"},{"line_number":1667,"context_line":"            \u0027instantiatedVnfInfo\u0027"},{"line_number":1668,"context_line":"        ]"},{"line_number":1669,"context_line":"        expected_inst_attrs.extend(additional_inst_attrs)"},{"line_number":1670,"context_line":"        inst_2 \u003d self._check_for_show_operation("},{"line_number":1671,"context_line":"            \u0027INSTANTIATE\u0027, expected_inst_attrs, inst_id)"},{"line_number":1672,"context_line":""}],"source_content_type":"text/x-python","patch_set":37,"id":"1f0b3861_c365a26a","line":1669,"range":{"start_line":1665,"start_character":0,"end_line":1669,"end_character":57},"in_reply_to":"2e9d822a_2676bf60","updated":"2023-04-10 05:36:03.000000000","message":"I fixed it in PS38.","commit_id":"e6db6a662a5fd52ecabea4b834a5c2013d8d95e1"},{"author":{"_account_id":31668},"change_message_id":"a2c4b01b4880d2e8b5a6492071fb856f65accb77","unresolved":true,"context_lines":[{"line_number":1700,"context_line":"            \u0027operationParams\u0027,"},{"line_number":1701,"context_line":"            \u0027isCancelPending\u0027,"},{"line_number":1702,"context_line":"            # \u0027cancelMode\u0027, # omitted"},{"line_number":1703,"context_line":"            # \u0027error\u0027, # omitted"},{"line_number":1704,"context_line":"            # \u0027resourceChanges\u0027, # omitted"},{"line_number":1705,"context_line":"            # \u0027changedInfo\u0027, # omitted"},{"line_number":1706,"context_line":"            # \u0027changedExtConnectivity\u0027, # omitted"}],"source_content_type":"text/x-python","patch_set":37,"id":"fef233b2_cbb46d8d","line":1703,"updated":"2023-04-04 08:01:02.000000000","message":"The error is also set, so please don\u0027t omit it.","commit_id":"e6db6a662a5fd52ecabea4b834a5c2013d8d95e1"},{"author":{"_account_id":31668},"change_message_id":"4c5937e136c86b08773e33086dcb0e7988fa0cad","unresolved":false,"context_lines":[{"line_number":1700,"context_line":"            \u0027operationParams\u0027,"},{"line_number":1701,"context_line":"            \u0027isCancelPending\u0027,"},{"line_number":1702,"context_line":"            # \u0027cancelMode\u0027, # omitted"},{"line_number":1703,"context_line":"            # \u0027error\u0027, # omitted"},{"line_number":1704,"context_line":"            # \u0027resourceChanges\u0027, # omitted"},{"line_number":1705,"context_line":"            # \u0027changedInfo\u0027, # omitted"},{"line_number":1706,"context_line":"            # \u0027changedExtConnectivity\u0027, # omitted"}],"source_content_type":"text/x-python","patch_set":37,"id":"c58939ff_304366bb","line":1703,"in_reply_to":"94ebb3bd_6b76276e","updated":"2023-04-10 07:33:44.000000000","message":"Done","commit_id":"e6db6a662a5fd52ecabea4b834a5c2013d8d95e1"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"2af3376165484707348a813352ffd66391542d9e","unresolved":true,"context_lines":[{"line_number":1700,"context_line":"            \u0027operationParams\u0027,"},{"line_number":1701,"context_line":"            \u0027isCancelPending\u0027,"},{"line_number":1702,"context_line":"            # \u0027cancelMode\u0027, # omitted"},{"line_number":1703,"context_line":"            # \u0027error\u0027, # omitted"},{"line_number":1704,"context_line":"            # \u0027resourceChanges\u0027, # omitted"},{"line_number":1705,"context_line":"            # \u0027changedInfo\u0027, # omitted"},{"line_number":1706,"context_line":"            # \u0027changedExtConnectivity\u0027, # omitted"}],"source_content_type":"text/x-python","patch_set":37,"id":"94ebb3bd_6b76276e","line":1703,"in_reply_to":"fef233b2_cbb46d8d","updated":"2023-04-10 05:36:03.000000000","message":"I fixed it in PS38.","commit_id":"e6db6a662a5fd52ecabea4b834a5c2013d8d95e1"},{"author":{"_account_id":31668},"change_message_id":"a2c4b01b4880d2e8b5a6492071fb856f65accb77","unresolved":true,"context_lines":[{"line_number":1717,"context_line":"        _, inst_6 \u003d self.show_vnf_instance(inst_id)"},{"line_number":1718,"context_line":"        # check vnfdId"},{"line_number":1719,"context_line":"        self.assertEqual(self.vnfd_id_1, inst_6[\u0027vnfdId\u0027])"},{"line_number":1720,"context_line":"        # check images of VDU are not change"},{"line_number":1721,"context_line":"        self.assertEqual(self._get_vnfc_image(inst_2, \u0027VDU1\u0027, 0),"},{"line_number":1722,"context_line":"                         self._get_vnfc_image(inst_6, \u0027VDU1\u0027, 0))"},{"line_number":1723,"context_line":"        self.assertEqual(self._get_vnfc_image(inst_2, \u0027VDU2\u0027, 0),"}],"source_content_type":"text/x-python","patch_set":37,"id":"58a69cda_76028292","line":1720,"updated":"2023-04-04 08:01:02.000000000","message":"nit: images of VDU are not change -\u003e images of VDU are not changed","commit_id":"e6db6a662a5fd52ecabea4b834a5c2013d8d95e1"},{"author":{"_account_id":31668},"change_message_id":"4c5937e136c86b08773e33086dcb0e7988fa0cad","unresolved":false,"context_lines":[{"line_number":1717,"context_line":"        _, inst_6 \u003d self.show_vnf_instance(inst_id)"},{"line_number":1718,"context_line":"        # check vnfdId"},{"line_number":1719,"context_line":"        self.assertEqual(self.vnfd_id_1, inst_6[\u0027vnfdId\u0027])"},{"line_number":1720,"context_line":"        # check images of VDU are not change"},{"line_number":1721,"context_line":"        self.assertEqual(self._get_vnfc_image(inst_2, \u0027VDU1\u0027, 0),"},{"line_number":1722,"context_line":"                         self._get_vnfc_image(inst_6, \u0027VDU1\u0027, 0))"},{"line_number":1723,"context_line":"        self.assertEqual(self._get_vnfc_image(inst_2, \u0027VDU2\u0027, 0),"}],"source_content_type":"text/x-python","patch_set":37,"id":"888f5a24_89e4e8b5","line":1720,"in_reply_to":"21bd53bd_cf684a99","updated":"2023-04-10 07:33:44.000000000","message":"Done","commit_id":"e6db6a662a5fd52ecabea4b834a5c2013d8d95e1"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"2af3376165484707348a813352ffd66391542d9e","unresolved":true,"context_lines":[{"line_number":1717,"context_line":"        _, inst_6 \u003d self.show_vnf_instance(inst_id)"},{"line_number":1718,"context_line":"        # check vnfdId"},{"line_number":1719,"context_line":"        self.assertEqual(self.vnfd_id_1, inst_6[\u0027vnfdId\u0027])"},{"line_number":1720,"context_line":"        # check images of VDU are not change"},{"line_number":1721,"context_line":"        self.assertEqual(self._get_vnfc_image(inst_2, \u0027VDU1\u0027, 0),"},{"line_number":1722,"context_line":"                         self._get_vnfc_image(inst_6, \u0027VDU1\u0027, 0))"},{"line_number":1723,"context_line":"        self.assertEqual(self._get_vnfc_image(inst_2, \u0027VDU2\u0027, 0),"}],"source_content_type":"text/x-python","patch_set":37,"id":"21bd53bd_cf684a99","line":1720,"in_reply_to":"58a69cda_76028292","updated":"2023-04-10 05:36:03.000000000","message":"I fixed it in PS38.","commit_id":"e6db6a662a5fd52ecabea4b834a5c2013d8d95e1"},{"author":{"_account_id":31668},"change_message_id":"a2c4b01b4880d2e8b5a6492071fb856f65accb77","unresolved":true,"context_lines":[{"line_number":1722,"context_line":"                         self._get_vnfc_image(inst_6, \u0027VDU1\u0027, 0))"},{"line_number":1723,"context_line":"        self.assertEqual(self._get_vnfc_image(inst_2, \u0027VDU2\u0027, 0),"},{"line_number":1724,"context_line":"                         self._get_vnfc_image(inst_6, \u0027VDU2\u0027, 0))"},{"line_number":1725,"context_line":"        # check flavor of VDU2 is not change"},{"line_number":1726,"context_line":"        self.assertEqual(self._get_vnfc_flavor(inst_2, \u0027VDU2\u0027, 0),"},{"line_number":1727,"context_line":"                         self._get_vnfc_flavor(inst_6, \u0027VDU2\u0027, 0))"},{"line_number":1728,"context_line":"        # check external CPs, VDU1_CP6 and VDU2_CP6 not be added"}],"source_content_type":"text/x-python","patch_set":37,"id":"7c4a100c_e29dd171","line":1725,"updated":"2023-04-04 08:01:02.000000000","message":"nit: flavor of VDU2 is not change -\u003e flavor of VDU2 is not changed","commit_id":"e6db6a662a5fd52ecabea4b834a5c2013d8d95e1"},{"author":{"_account_id":31668},"change_message_id":"4c5937e136c86b08773e33086dcb0e7988fa0cad","unresolved":false,"context_lines":[{"line_number":1722,"context_line":"                         self._get_vnfc_image(inst_6, \u0027VDU1\u0027, 0))"},{"line_number":1723,"context_line":"        self.assertEqual(self._get_vnfc_image(inst_2, \u0027VDU2\u0027, 0),"},{"line_number":1724,"context_line":"                         self._get_vnfc_image(inst_6, \u0027VDU2\u0027, 0))"},{"line_number":1725,"context_line":"        # check flavor of VDU2 is not change"},{"line_number":1726,"context_line":"        self.assertEqual(self._get_vnfc_flavor(inst_2, \u0027VDU2\u0027, 0),"},{"line_number":1727,"context_line":"                         self._get_vnfc_flavor(inst_6, \u0027VDU2\u0027, 0))"},{"line_number":1728,"context_line":"        # check external CPs, VDU1_CP6 and VDU2_CP6 not be added"}],"source_content_type":"text/x-python","patch_set":37,"id":"db0f392b_de9ad904","line":1725,"in_reply_to":"63d9fb88_aaf42e3a","updated":"2023-04-10 07:33:44.000000000","message":"Done","commit_id":"e6db6a662a5fd52ecabea4b834a5c2013d8d95e1"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"2af3376165484707348a813352ffd66391542d9e","unresolved":true,"context_lines":[{"line_number":1722,"context_line":"                         self._get_vnfc_image(inst_6, \u0027VDU1\u0027, 0))"},{"line_number":1723,"context_line":"        self.assertEqual(self._get_vnfc_image(inst_2, \u0027VDU2\u0027, 0),"},{"line_number":1724,"context_line":"                         self._get_vnfc_image(inst_6, \u0027VDU2\u0027, 0))"},{"line_number":1725,"context_line":"        # check flavor of VDU2 is not change"},{"line_number":1726,"context_line":"        self.assertEqual(self._get_vnfc_flavor(inst_2, \u0027VDU2\u0027, 0),"},{"line_number":1727,"context_line":"                         self._get_vnfc_flavor(inst_6, \u0027VDU2\u0027, 0))"},{"line_number":1728,"context_line":"        # check external CPs, VDU1_CP6 and VDU2_CP6 not be added"}],"source_content_type":"text/x-python","patch_set":37,"id":"63d9fb88_aaf42e3a","line":1725,"in_reply_to":"7c4a100c_e29dd171","updated":"2023-04-10 05:36:03.000000000","message":"I fixed it in PS38.","commit_id":"e6db6a662a5fd52ecabea4b834a5c2013d8d95e1"},{"author":{"_account_id":31668},"change_message_id":"a2c4b01b4880d2e8b5a6492071fb856f65accb77","unresolved":true,"context_lines":[{"line_number":1725,"context_line":"        # check flavor of VDU2 is not change"},{"line_number":1726,"context_line":"        self.assertEqual(self._get_vnfc_flavor(inst_2, \u0027VDU2\u0027, 0),"},{"line_number":1727,"context_line":"                         self._get_vnfc_flavor(inst_6, \u0027VDU2\u0027, 0))"},{"line_number":1728,"context_line":"        # check external CPs, VDU1_CP6 and VDU2_CP6 not be added"},{"line_number":1729,"context_line":"        self.assertFalse(\u0027VDU1_CP6\u0027 in self._get_vnfc_cps(inst_2, \u0027VDU1\u0027, 0))"},{"line_number":1730,"context_line":"        self.assertFalse(\u0027VDU2_CP6\u0027 in self._get_vnfc_cps(inst_2, \u0027VDU2\u0027, 0))"},{"line_number":1731,"context_line":"        self.assertFalse(\u0027VDU1_CP6\u0027 in self._get_vnfc_cps(inst_6, \u0027VDU1\u0027, 0))"}],"source_content_type":"text/x-python","patch_set":37,"id":"377745a6_4393dab1","line":1728,"updated":"2023-04-04 08:01:02.000000000","message":"nit: external CPs, VDU1_CP6 and VDU2_CP6 not be added -\u003e external CPs, VDU1_CP6 and VDU2_CP6 are not added","commit_id":"e6db6a662a5fd52ecabea4b834a5c2013d8d95e1"},{"author":{"_account_id":31668},"change_message_id":"4c5937e136c86b08773e33086dcb0e7988fa0cad","unresolved":false,"context_lines":[{"line_number":1725,"context_line":"        # check flavor of VDU2 is not change"},{"line_number":1726,"context_line":"        self.assertEqual(self._get_vnfc_flavor(inst_2, \u0027VDU2\u0027, 0),"},{"line_number":1727,"context_line":"                         self._get_vnfc_flavor(inst_6, \u0027VDU2\u0027, 0))"},{"line_number":1728,"context_line":"        # check external CPs, VDU1_CP6 and VDU2_CP6 not be added"},{"line_number":1729,"context_line":"        self.assertFalse(\u0027VDU1_CP6\u0027 in self._get_vnfc_cps(inst_2, \u0027VDU1\u0027, 0))"},{"line_number":1730,"context_line":"        self.assertFalse(\u0027VDU2_CP6\u0027 in self._get_vnfc_cps(inst_2, \u0027VDU2\u0027, 0))"},{"line_number":1731,"context_line":"        self.assertFalse(\u0027VDU1_CP6\u0027 in self._get_vnfc_cps(inst_6, \u0027VDU1\u0027, 0))"}],"source_content_type":"text/x-python","patch_set":37,"id":"523fb46e_89542cc8","line":1728,"in_reply_to":"16e1e0f4_4846c6e4","updated":"2023-04-10 07:33:44.000000000","message":"Done","commit_id":"e6db6a662a5fd52ecabea4b834a5c2013d8d95e1"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"2af3376165484707348a813352ffd66391542d9e","unresolved":true,"context_lines":[{"line_number":1725,"context_line":"        # check flavor of VDU2 is not change"},{"line_number":1726,"context_line":"        self.assertEqual(self._get_vnfc_flavor(inst_2, \u0027VDU2\u0027, 0),"},{"line_number":1727,"context_line":"                         self._get_vnfc_flavor(inst_6, \u0027VDU2\u0027, 0))"},{"line_number":1728,"context_line":"        # check external CPs, VDU1_CP6 and VDU2_CP6 not be added"},{"line_number":1729,"context_line":"        self.assertFalse(\u0027VDU1_CP6\u0027 in self._get_vnfc_cps(inst_2, \u0027VDU1\u0027, 0))"},{"line_number":1730,"context_line":"        self.assertFalse(\u0027VDU2_CP6\u0027 in self._get_vnfc_cps(inst_2, \u0027VDU2\u0027, 0))"},{"line_number":1731,"context_line":"        self.assertFalse(\u0027VDU1_CP6\u0027 in self._get_vnfc_cps(inst_6, \u0027VDU1\u0027, 0))"}],"source_content_type":"text/x-python","patch_set":37,"id":"16e1e0f4_4846c6e4","line":1728,"in_reply_to":"377745a6_4393dab1","updated":"2023-04-10 05:36:03.000000000","message":"I fixed it in PS38.","commit_id":"e6db6a662a5fd52ecabea4b834a5c2013d8d95e1"},{"author":{"_account_id":31668},"change_message_id":"a2c4b01b4880d2e8b5a6492071fb856f65accb77","unresolved":true,"context_lines":[{"line_number":1730,"context_line":"        self.assertFalse(\u0027VDU2_CP6\u0027 in self._get_vnfc_cps(inst_2, \u0027VDU2\u0027, 0))"},{"line_number":1731,"context_line":"        self.assertFalse(\u0027VDU1_CP6\u0027 in self._get_vnfc_cps(inst_6, \u0027VDU1\u0027, 0))"},{"line_number":1732,"context_line":"        self.assertFalse(\u0027VDU2_CP6\u0027 in self._get_vnfc_cps(inst_6, \u0027VDU2\u0027, 0))"},{"line_number":1733,"context_line":"        # check internal CPs, VDU1_CP5 and VDU2_CP5 are not change"},{"line_number":1734,"context_line":"        self.assertEqual(\"internalVL3\", self._get_vnfc_cp_net_name("},{"line_number":1735,"context_line":"            inst_2, \u0027VDU1\u0027, 0, \u0027VDU1_CP5\u0027))"},{"line_number":1736,"context_line":"        self.assertEqual(\"internalVL3\", self._get_vnfc_cp_net_name("}],"source_content_type":"text/x-python","patch_set":37,"id":"dfebf589_117e41ed","line":1733,"updated":"2023-04-04 08:01:02.000000000","message":"nit: internal CPs, VDU1_CP5 and VDU2_CP5 are not change -\u003e internal CPs, VDU1_CP5 and VDU2_CP5 are not changed","commit_id":"e6db6a662a5fd52ecabea4b834a5c2013d8d95e1"},{"author":{"_account_id":31668},"change_message_id":"4c5937e136c86b08773e33086dcb0e7988fa0cad","unresolved":false,"context_lines":[{"line_number":1730,"context_line":"        self.assertFalse(\u0027VDU2_CP6\u0027 in self._get_vnfc_cps(inst_2, \u0027VDU2\u0027, 0))"},{"line_number":1731,"context_line":"        self.assertFalse(\u0027VDU1_CP6\u0027 in self._get_vnfc_cps(inst_6, \u0027VDU1\u0027, 0))"},{"line_number":1732,"context_line":"        self.assertFalse(\u0027VDU2_CP6\u0027 in self._get_vnfc_cps(inst_6, \u0027VDU2\u0027, 0))"},{"line_number":1733,"context_line":"        # check internal CPs, VDU1_CP5 and VDU2_CP5 are not change"},{"line_number":1734,"context_line":"        self.assertEqual(\"internalVL3\", self._get_vnfc_cp_net_name("},{"line_number":1735,"context_line":"            inst_2, \u0027VDU1\u0027, 0, \u0027VDU1_CP5\u0027))"},{"line_number":1736,"context_line":"        self.assertEqual(\"internalVL3\", self._get_vnfc_cp_net_name("}],"source_content_type":"text/x-python","patch_set":37,"id":"e1a82226_a5f42041","line":1733,"in_reply_to":"28612be0_b70ad0b5","updated":"2023-04-10 07:33:44.000000000","message":"Done","commit_id":"e6db6a662a5fd52ecabea4b834a5c2013d8d95e1"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"2af3376165484707348a813352ffd66391542d9e","unresolved":true,"context_lines":[{"line_number":1730,"context_line":"        self.assertFalse(\u0027VDU2_CP6\u0027 in self._get_vnfc_cps(inst_2, \u0027VDU2\u0027, 0))"},{"line_number":1731,"context_line":"        self.assertFalse(\u0027VDU1_CP6\u0027 in self._get_vnfc_cps(inst_6, \u0027VDU1\u0027, 0))"},{"line_number":1732,"context_line":"        self.assertFalse(\u0027VDU2_CP6\u0027 in self._get_vnfc_cps(inst_6, \u0027VDU2\u0027, 0))"},{"line_number":1733,"context_line":"        # check internal CPs, VDU1_CP5 and VDU2_CP5 are not change"},{"line_number":1734,"context_line":"        self.assertEqual(\"internalVL3\", self._get_vnfc_cp_net_name("},{"line_number":1735,"context_line":"            inst_2, \u0027VDU1\u0027, 0, \u0027VDU1_CP5\u0027))"},{"line_number":1736,"context_line":"        self.assertEqual(\"internalVL3\", self._get_vnfc_cp_net_name("}],"source_content_type":"text/x-python","patch_set":37,"id":"28612be0_b70ad0b5","line":1733,"in_reply_to":"dfebf589_117e41ed","updated":"2023-04-10 05:36:03.000000000","message":"I fixed it in PS38.","commit_id":"e6db6a662a5fd52ecabea4b834a5c2013d8d95e1"},{"author":{"_account_id":31668},"change_message_id":"6c130455c201fba62834a757d693a170d3a19767","unresolved":true,"context_lines":[{"line_number":1742,"context_line":""},{"line_number":1743,"context_line":"        # 7. Change Current VNF Package(will fail)"},{"line_number":1744,"context_line":"        self._put_fail_file(\u0027change_vnfpkg\u0027)"},{"line_number":1745,"context_line":"        change_vnf_pkg_req \u003d paramgen.change_vnf_pkg_individual_vnfc_min("},{"line_number":1746,"context_line":"            self.vnfd_id_5, vdu2_old_vnfc\u003d\u0027VDU2_CP2\u0027)"},{"line_number":1747,"context_line":"        resp, body \u003d self.change_vnfpkg(inst_id, change_vnf_pkg_req)"},{"line_number":1748,"context_line":"        self.assertEqual(202, resp.status_code)"}],"source_content_type":"text/x-python","patch_set":37,"id":"067e37f4_ed032c7e","line":1745,"updated":"2023-04-05 06:40:11.000000000","message":"Why are min pattern request used?\nSince max pattern VnfPackage is used in this test, I think it would be better if max pattern request was used.","commit_id":"e6db6a662a5fd52ecabea4b834a5c2013d8d95e1"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"2af3376165484707348a813352ffd66391542d9e","unresolved":true,"context_lines":[{"line_number":1742,"context_line":""},{"line_number":1743,"context_line":"        # 7. Change Current VNF Package(will fail)"},{"line_number":1744,"context_line":"        self._put_fail_file(\u0027change_vnfpkg\u0027)"},{"line_number":1745,"context_line":"        change_vnf_pkg_req \u003d paramgen.change_vnf_pkg_individual_vnfc_min("},{"line_number":1746,"context_line":"            self.vnfd_id_5, vdu2_old_vnfc\u003d\u0027VDU2_CP2\u0027)"},{"line_number":1747,"context_line":"        resp, body \u003d self.change_vnfpkg(inst_id, change_vnf_pkg_req)"},{"line_number":1748,"context_line":"        self.assertEqual(202, resp.status_code)"}],"source_content_type":"text/x-python","patch_set":37,"id":"183dad47_c2ad0721","line":1745,"in_reply_to":"067e37f4_ed032c7e","updated":"2023-04-10 05:36:03.000000000","message":"The request of max has been used in the third step. This is to test that when the request of min is used, the rollback operation can be successful even after failure.","commit_id":"e6db6a662a5fd52ecabea4b834a5c2013d8d95e1"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"87ada88f2d9bfb9f1378fc39bab9a09aa6d329f2","unresolved":true,"context_lines":[{"line_number":1742,"context_line":""},{"line_number":1743,"context_line":"        # 7. Change Current VNF Package(will fail)"},{"line_number":1744,"context_line":"        self._put_fail_file(\u0027change_vnfpkg\u0027)"},{"line_number":1745,"context_line":"        change_vnf_pkg_req \u003d paramgen.change_vnf_pkg_individual_vnfc_min("},{"line_number":1746,"context_line":"            self.vnfd_id_5, vdu2_old_vnfc\u003d\u0027VDU2_CP2\u0027)"},{"line_number":1747,"context_line":"        resp, body \u003d self.change_vnfpkg(inst_id, change_vnf_pkg_req)"},{"line_number":1748,"context_line":"        self.assertEqual(202, resp.status_code)"}],"source_content_type":"text/x-python","patch_set":37,"id":"2ab8f02b_1715b2a2","line":1745,"in_reply_to":"0ade045c_e49fb224","updated":"2023-04-17 01:48:45.000000000","message":"I added this check in PS42.","commit_id":"e6db6a662a5fd52ecabea4b834a5c2013d8d95e1"},{"author":{"_account_id":31668},"change_message_id":"4c5937e136c86b08773e33086dcb0e7988fa0cad","unresolved":true,"context_lines":[{"line_number":1742,"context_line":""},{"line_number":1743,"context_line":"        # 7. Change Current VNF Package(will fail)"},{"line_number":1744,"context_line":"        self._put_fail_file(\u0027change_vnfpkg\u0027)"},{"line_number":1745,"context_line":"        change_vnf_pkg_req \u003d paramgen.change_vnf_pkg_individual_vnfc_min("},{"line_number":1746,"context_line":"            self.vnfd_id_5, vdu2_old_vnfc\u003d\u0027VDU2_CP2\u0027)"},{"line_number":1747,"context_line":"        resp, body \u003d self.change_vnfpkg(inst_id, change_vnf_pkg_req)"},{"line_number":1748,"context_line":"        self.assertEqual(202, resp.status_code)"}],"source_content_type":"text/x-python","patch_set":37,"id":"0ade045c_e49fb224","line":1745,"in_reply_to":"183dad47_c2ad0721","updated":"2023-04-10 07:33:44.000000000","message":"Thank you for your explanation.\nIf it is also meaningful to test for the case of min pattern requests, could you add a check for error.detail like change_ext_conn?\nhttps://review.opendev.org/c/openstack/tacker/+/873477/33..39/tacker/tests/functional/sol_v2_individual_vnfc_mgmt/test_individual_vnfc_mgmt_basic.py#1532","commit_id":"e6db6a662a5fd52ecabea4b834a5c2013d8d95e1"},{"author":{"_account_id":31668},"change_message_id":"600216e691356b714ce45783dfa00a4cc1f726b0","unresolved":false,"context_lines":[{"line_number":1742,"context_line":""},{"line_number":1743,"context_line":"        # 7. Change Current VNF Package(will fail)"},{"line_number":1744,"context_line":"        self._put_fail_file(\u0027change_vnfpkg\u0027)"},{"line_number":1745,"context_line":"        change_vnf_pkg_req \u003d paramgen.change_vnf_pkg_individual_vnfc_min("},{"line_number":1746,"context_line":"            self.vnfd_id_5, vdu2_old_vnfc\u003d\u0027VDU2_CP2\u0027)"},{"line_number":1747,"context_line":"        resp, body \u003d self.change_vnfpkg(inst_id, change_vnf_pkg_req)"},{"line_number":1748,"context_line":"        self.assertEqual(202, resp.status_code)"}],"source_content_type":"text/x-python","patch_set":37,"id":"bb5ded5d_4b9773b7","line":1745,"in_reply_to":"203a7ffd_8cf02e53","updated":"2023-04-28 07:14:16.000000000","message":"Done","commit_id":"e6db6a662a5fd52ecabea4b834a5c2013d8d95e1"},{"author":{"_account_id":31668},"change_message_id":"1230b7fbfed75bdd3b503dba690be747c63c3b7e","unresolved":true,"context_lines":[{"line_number":1742,"context_line":""},{"line_number":1743,"context_line":"        # 7. Change Current VNF Package(will fail)"},{"line_number":1744,"context_line":"        self._put_fail_file(\u0027change_vnfpkg\u0027)"},{"line_number":1745,"context_line":"        change_vnf_pkg_req \u003d paramgen.change_vnf_pkg_individual_vnfc_min("},{"line_number":1746,"context_line":"            self.vnfd_id_5, vdu2_old_vnfc\u003d\u0027VDU2_CP2\u0027)"},{"line_number":1747,"context_line":"        resp, body \u003d self.change_vnfpkg(inst_id, change_vnf_pkg_req)"},{"line_number":1748,"context_line":"        self.assertEqual(202, resp.status_code)"}],"source_content_type":"text/x-python","patch_set":37,"id":"8412577b_d511a114","line":1745,"in_reply_to":"2ab8f02b_1715b2a2","updated":"2023-04-19 06:46:44.000000000","message":"If it fails in the Coordination script, the error is:\n```\n{\n      \"title\": \"Coordinate VNF execution failed\",\n      \"status\": 422,\n      \"detail\": \"b\u0027test change_vnfpkg error\u0027\"\n}\n```\n\nIn this test, an unsupported change_vnfpkg from vnf_pkg_1(sol_v2_common/samples/basic_lcms_max_individual_vnfc) to vnf_pkg_5(sol_v2_common/samples/change_vnfpkg_or_update_min_individual_vnfc) is performed, and an error occurs in the stack update before processing the Coordination script.\n(For image updates, currently only the following are supported.)\n```\n1. change VM created by image to VM created by new image\n2. change VM created by volume to VM created by new volume\n```\nhttps://docs.openstack.org/tacker/2023.1/user/etsi_vnf_change_current_vnf_package_with_standard_user_data.html\n\nWhich is supposed to be checked by this test?\n[1] Even if the Coordination script fails after the stack update succeeds with the min request, it can be rolled back correctly.\n[2] Even if unsupported change_vnfpkg is executed and stack update fails, rollback can be performed correctly.\n\nIn the case of [1], I think it is necessary to use a VNF Package for which chnage_vnfpkg succeeds within the scope of Tacker\u0027s support.\nHowever, an error occurs in the Coordination script after updating VDU1, and VDU2 is not updated, so I don\u0027t think it is possible to fully test the min request with this method.\n\nIn the case of [2], it is not necessary to create a change_vnfpkg file, and I think it would be better to add a comment that an operation outside the scope of support was intentionally performed to make it FAILED_TEMP.","commit_id":"e6db6a662a5fd52ecabea4b834a5c2013d8d95e1"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"8a9df843948600460518da46b2cde2b152537ad6","unresolved":true,"context_lines":[{"line_number":1742,"context_line":""},{"line_number":1743,"context_line":"        # 7. Change Current VNF Package(will fail)"},{"line_number":1744,"context_line":"        self._put_fail_file(\u0027change_vnfpkg\u0027)"},{"line_number":1745,"context_line":"        change_vnf_pkg_req \u003d paramgen.change_vnf_pkg_individual_vnfc_min("},{"line_number":1746,"context_line":"            self.vnfd_id_5, vdu2_old_vnfc\u003d\u0027VDU2_CP2\u0027)"},{"line_number":1747,"context_line":"        resp, body \u003d self.change_vnfpkg(inst_id, change_vnf_pkg_req)"},{"line_number":1748,"context_line":"        self.assertEqual(202, resp.status_code)"}],"source_content_type":"text/x-python","patch_set":37,"id":"203a7ffd_8cf02e53","line":1745,"in_reply_to":"8412577b_d511a114","updated":"2023-04-28 04:39:58.000000000","message":"The case of [2] is checked by this test. I added a comment to this operation in PS46.","commit_id":"e6db6a662a5fd52ecabea4b834a5c2013d8d95e1"},{"author":{"_account_id":31668},"change_message_id":"a2c4b01b4880d2e8b5a6492071fb856f65accb77","unresolved":true,"context_lines":[{"line_number":1770,"context_line":"            \u0027operationParams\u0027,"},{"line_number":1771,"context_line":"            \u0027isCancelPending\u0027,"},{"line_number":1772,"context_line":"            # \u0027cancelMode\u0027, # omitted"},{"line_number":1773,"context_line":"            # \u0027error\u0027, # omitted"},{"line_number":1774,"context_line":"            # \u0027resourceChanges\u0027, # omitted"},{"line_number":1775,"context_line":"            # \u0027changedInfo\u0027, # omitted"},{"line_number":1776,"context_line":"            # \u0027changedExtConnectivity\u0027, # omitted"}],"source_content_type":"text/x-python","patch_set":37,"id":"9e1d0927_52830d12","line":1773,"updated":"2023-04-04 08:01:02.000000000","message":"The error is also set, so please don\u0027t omit it.","commit_id":"e6db6a662a5fd52ecabea4b834a5c2013d8d95e1"},{"author":{"_account_id":31668},"change_message_id":"4c5937e136c86b08773e33086dcb0e7988fa0cad","unresolved":false,"context_lines":[{"line_number":1770,"context_line":"            \u0027operationParams\u0027,"},{"line_number":1771,"context_line":"            \u0027isCancelPending\u0027,"},{"line_number":1772,"context_line":"            # \u0027cancelMode\u0027, # omitted"},{"line_number":1773,"context_line":"            # \u0027error\u0027, # omitted"},{"line_number":1774,"context_line":"            # \u0027resourceChanges\u0027, # omitted"},{"line_number":1775,"context_line":"            # \u0027changedInfo\u0027, # omitted"},{"line_number":1776,"context_line":"            # \u0027changedExtConnectivity\u0027, # omitted"}],"source_content_type":"text/x-python","patch_set":37,"id":"6cb5f363_a6933a7c","line":1773,"in_reply_to":"11e7a565_ffbb0e39","updated":"2023-04-10 07:33:44.000000000","message":"Done","commit_id":"e6db6a662a5fd52ecabea4b834a5c2013d8d95e1"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"2af3376165484707348a813352ffd66391542d9e","unresolved":true,"context_lines":[{"line_number":1770,"context_line":"            \u0027operationParams\u0027,"},{"line_number":1771,"context_line":"            \u0027isCancelPending\u0027,"},{"line_number":1772,"context_line":"            # \u0027cancelMode\u0027, # omitted"},{"line_number":1773,"context_line":"            # \u0027error\u0027, # omitted"},{"line_number":1774,"context_line":"            # \u0027resourceChanges\u0027, # omitted"},{"line_number":1775,"context_line":"            # \u0027changedInfo\u0027, # omitted"},{"line_number":1776,"context_line":"            # \u0027changedExtConnectivity\u0027, # omitted"}],"source_content_type":"text/x-python","patch_set":37,"id":"11e7a565_ffbb0e39","line":1773,"in_reply_to":"9e1d0927_52830d12","updated":"2023-04-10 05:36:03.000000000","message":"I fixed it in PS38.","commit_id":"e6db6a662a5fd52ecabea4b834a5c2013d8d95e1"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"f19e5ec3c81954db706cbc026364ed9a58b20ce0","unresolved":true,"context_lines":[{"line_number":1794,"context_line":"        _, inst_11 \u003d self.show_vnf_instance(inst_id)"},{"line_number":1795,"context_line":"        # check vnfdId"},{"line_number":1796,"context_line":"        self.assertEqual(self.vnfd_id_1, inst_11[\u0027vnfdId\u0027])"},{"line_number":1797,"context_line":"        # check image of VDU are not change"},{"line_number":1798,"context_line":"        self.assertEqual(self._get_vnfc_image(inst_2, \u0027VDU1\u0027, 0),"},{"line_number":1799,"context_line":"                         self._get_vnfc_image(inst_11, \u0027VDU1\u0027, 0))"},{"line_number":1800,"context_line":"        self.assertEqual(self._get_vnfc_image(inst_2, \u0027VDU2\u0027, 0),"}],"source_content_type":"text/x-python","patch_set":37,"id":"827409a7_43511dbb","line":1797,"range":{"start_line":1797,"start_character":10,"end_line":1797,"end_character":43},"updated":"2023-04-05 08:17:27.000000000","message":"nits: check image of VDU are not change -\u003e check image of VDU are not changed","commit_id":"e6db6a662a5fd52ecabea4b834a5c2013d8d95e1"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"c5ab8f0d040b29574eeecc082af8cb88a2b5951b","unresolved":false,"context_lines":[{"line_number":1794,"context_line":"        _, inst_11 \u003d self.show_vnf_instance(inst_id)"},{"line_number":1795,"context_line":"        # check vnfdId"},{"line_number":1796,"context_line":"        self.assertEqual(self.vnfd_id_1, inst_11[\u0027vnfdId\u0027])"},{"line_number":1797,"context_line":"        # check image of VDU are not change"},{"line_number":1798,"context_line":"        self.assertEqual(self._get_vnfc_image(inst_2, \u0027VDU1\u0027, 0),"},{"line_number":1799,"context_line":"                         self._get_vnfc_image(inst_11, \u0027VDU1\u0027, 0))"},{"line_number":1800,"context_line":"        self.assertEqual(self._get_vnfc_image(inst_2, \u0027VDU2\u0027, 0),"}],"source_content_type":"text/x-python","patch_set":37,"id":"3796963a_fec8c72b","line":1797,"range":{"start_line":1797,"start_character":10,"end_line":1797,"end_character":43},"in_reply_to":"02613d40_f7fca40c","updated":"2023-05-09 00:09:27.000000000","message":"Sorry for unresolved..\nDone","commit_id":"e6db6a662a5fd52ecabea4b834a5c2013d8d95e1"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"2af3376165484707348a813352ffd66391542d9e","unresolved":true,"context_lines":[{"line_number":1794,"context_line":"        _, inst_11 \u003d self.show_vnf_instance(inst_id)"},{"line_number":1795,"context_line":"        # check vnfdId"},{"line_number":1796,"context_line":"        self.assertEqual(self.vnfd_id_1, inst_11[\u0027vnfdId\u0027])"},{"line_number":1797,"context_line":"        # check image of VDU are not change"},{"line_number":1798,"context_line":"        self.assertEqual(self._get_vnfc_image(inst_2, \u0027VDU1\u0027, 0),"},{"line_number":1799,"context_line":"                         self._get_vnfc_image(inst_11, \u0027VDU1\u0027, 0))"},{"line_number":1800,"context_line":"        self.assertEqual(self._get_vnfc_image(inst_2, \u0027VDU2\u0027, 0),"}],"source_content_type":"text/x-python","patch_set":37,"id":"02613d40_f7fca40c","line":1797,"range":{"start_line":1797,"start_character":10,"end_line":1797,"end_character":43},"in_reply_to":"827409a7_43511dbb","updated":"2023-04-10 05:36:03.000000000","message":"I fixed it in PS38.","commit_id":"e6db6a662a5fd52ecabea4b834a5c2013d8d95e1"},{"author":{"_account_id":31668},"change_message_id":"6c130455c201fba62834a757d693a170d3a19767","unresolved":true,"context_lines":[{"line_number":1901,"context_line":"            # \u0027extensions\u0027, # omitted"},{"line_number":1902,"context_line":"            \u0027_links\u0027"},{"line_number":1903,"context_line":"        ]"},{"line_number":1904,"context_line":"        additional_inst_attrs \u003d ["},{"line_number":1905,"context_line":"            \u0027vimConnectionInfo\u0027,"},{"line_number":1906,"context_line":"            \u0027instantiatedVnfInfo\u0027"},{"line_number":1907,"context_line":"        ]"},{"line_number":1908,"context_line":"        expected_inst_attrs.extend(additional_inst_attrs)"},{"line_number":1909,"context_line":"        vdu_result \u003d {\u0027VDU1\u0027: {0}, \u0027VDU2\u0027: {0}}"},{"line_number":1910,"context_line":"        image_result \u003d {\u0027VDU1\u0027: {\u0027image-VDU1-VirtualStorage-0\u0027},"},{"line_number":1911,"context_line":"                        \u0027VDU2\u0027: {\u0027image-VDU2-VirtualStorage-0\u0027}}"}],"source_content_type":"text/x-python","patch_set":37,"id":"e935f875_3ad9d386","line":1908,"range":{"start_line":1904,"start_character":0,"end_line":1908,"end_character":57},"updated":"2023-04-05 06:40:11.000000000","message":"In this test, the attributes of VNF Instance in NOT_INSTANTIATED state is not checked.\nHow about setting all attributes to expected_inst_attrs without dividing them?","commit_id":"e6db6a662a5fd52ecabea4b834a5c2013d8d95e1"},{"author":{"_account_id":31668},"change_message_id":"4c5937e136c86b08773e33086dcb0e7988fa0cad","unresolved":false,"context_lines":[{"line_number":1901,"context_line":"            # \u0027extensions\u0027, # omitted"},{"line_number":1902,"context_line":"            \u0027_links\u0027"},{"line_number":1903,"context_line":"        ]"},{"line_number":1904,"context_line":"        additional_inst_attrs \u003d ["},{"line_number":1905,"context_line":"            \u0027vimConnectionInfo\u0027,"},{"line_number":1906,"context_line":"            \u0027instantiatedVnfInfo\u0027"},{"line_number":1907,"context_line":"        ]"},{"line_number":1908,"context_line":"        expected_inst_attrs.extend(additional_inst_attrs)"},{"line_number":1909,"context_line":"        vdu_result \u003d {\u0027VDU1\u0027: {0}, \u0027VDU2\u0027: {0}}"},{"line_number":1910,"context_line":"        image_result \u003d {\u0027VDU1\u0027: {\u0027image-VDU1-VirtualStorage-0\u0027},"},{"line_number":1911,"context_line":"                        \u0027VDU2\u0027: {\u0027image-VDU2-VirtualStorage-0\u0027}}"}],"source_content_type":"text/x-python","patch_set":37,"id":"02f29b32_955b69d6","line":1908,"range":{"start_line":1904,"start_character":0,"end_line":1908,"end_character":57},"in_reply_to":"dd65741e_e88f0f8a","updated":"2023-04-10 07:33:44.000000000","message":"Done","commit_id":"e6db6a662a5fd52ecabea4b834a5c2013d8d95e1"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"2af3376165484707348a813352ffd66391542d9e","unresolved":true,"context_lines":[{"line_number":1901,"context_line":"            # \u0027extensions\u0027, # omitted"},{"line_number":1902,"context_line":"            \u0027_links\u0027"},{"line_number":1903,"context_line":"        ]"},{"line_number":1904,"context_line":"        additional_inst_attrs \u003d ["},{"line_number":1905,"context_line":"            \u0027vimConnectionInfo\u0027,"},{"line_number":1906,"context_line":"            \u0027instantiatedVnfInfo\u0027"},{"line_number":1907,"context_line":"        ]"},{"line_number":1908,"context_line":"        expected_inst_attrs.extend(additional_inst_attrs)"},{"line_number":1909,"context_line":"        vdu_result \u003d {\u0027VDU1\u0027: {0}, \u0027VDU2\u0027: {0}}"},{"line_number":1910,"context_line":"        image_result \u003d {\u0027VDU1\u0027: {\u0027image-VDU1-VirtualStorage-0\u0027},"},{"line_number":1911,"context_line":"                        \u0027VDU2\u0027: {\u0027image-VDU2-VirtualStorage-0\u0027}}"}],"source_content_type":"text/x-python","patch_set":37,"id":"dd65741e_e88f0f8a","line":1908,"range":{"start_line":1904,"start_character":0,"end_line":1908,"end_character":57},"in_reply_to":"e935f875_3ad9d386","updated":"2023-04-10 05:36:03.000000000","message":"I fixed it in PS39.","commit_id":"e6db6a662a5fd52ecabea4b834a5c2013d8d95e1"},{"author":{"_account_id":31668},"change_message_id":"6c130455c201fba62834a757d693a170d3a19767","unresolved":true,"context_lines":[{"line_number":1951,"context_line":"        # check id of VDU1 with index 1 is changed"},{"line_number":1952,"context_line":"        self.assertNotEqual(self._get_vnfc_id(inst_4, \u0027VDU1\u0027, 1),"},{"line_number":1953,"context_line":"                            self._get_vnfc_id(inst_6, \u0027VDU1\u0027, 1))"},{"line_number":1954,"context_line":"        # check image of VDU1 with index 1 is not change"},{"line_number":1955,"context_line":"        self.assertEqual(self._get_vnfc_image(inst_4, \u0027VDU1\u0027, 1),"},{"line_number":1956,"context_line":"                         self._get_vnfc_image(inst_6, \u0027VDU1\u0027, 1))"},{"line_number":1957,"context_line":""}],"source_content_type":"text/x-python","patch_set":37,"id":"1059e318_ee305fd4","line":1954,"updated":"2023-04-05 06:40:11.000000000","message":"nit: image of VDU1 with index 1 is not change -\u003e image of VDU1 with index 1 is not changed","commit_id":"e6db6a662a5fd52ecabea4b834a5c2013d8d95e1"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"2af3376165484707348a813352ffd66391542d9e","unresolved":true,"context_lines":[{"line_number":1951,"context_line":"        # check id of VDU1 with index 1 is changed"},{"line_number":1952,"context_line":"        self.assertNotEqual(self._get_vnfc_id(inst_4, \u0027VDU1\u0027, 1),"},{"line_number":1953,"context_line":"                            self._get_vnfc_id(inst_6, \u0027VDU1\u0027, 1))"},{"line_number":1954,"context_line":"        # check image of VDU1 with index 1 is not change"},{"line_number":1955,"context_line":"        self.assertEqual(self._get_vnfc_image(inst_4, \u0027VDU1\u0027, 1),"},{"line_number":1956,"context_line":"                         self._get_vnfc_image(inst_6, \u0027VDU1\u0027, 1))"},{"line_number":1957,"context_line":""}],"source_content_type":"text/x-python","patch_set":37,"id":"6c662d8f_297f7303","line":1954,"in_reply_to":"1059e318_ee305fd4","updated":"2023-04-10 05:36:03.000000000","message":"I fixed it in PS39.","commit_id":"e6db6a662a5fd52ecabea4b834a5c2013d8d95e1"},{"author":{"_account_id":31668},"change_message_id":"4c5937e136c86b08773e33086dcb0e7988fa0cad","unresolved":false,"context_lines":[{"line_number":1951,"context_line":"        # check id of VDU1 with index 1 is changed"},{"line_number":1952,"context_line":"        self.assertNotEqual(self._get_vnfc_id(inst_4, \u0027VDU1\u0027, 1),"},{"line_number":1953,"context_line":"                            self._get_vnfc_id(inst_6, \u0027VDU1\u0027, 1))"},{"line_number":1954,"context_line":"        # check image of VDU1 with index 1 is not change"},{"line_number":1955,"context_line":"        self.assertEqual(self._get_vnfc_image(inst_4, \u0027VDU1\u0027, 1),"},{"line_number":1956,"context_line":"                         self._get_vnfc_image(inst_6, \u0027VDU1\u0027, 1))"},{"line_number":1957,"context_line":""}],"source_content_type":"text/x-python","patch_set":37,"id":"78f07f1c_d42fc2a2","line":1954,"in_reply_to":"6c662d8f_297f7303","updated":"2023-04-10 07:33:44.000000000","message":"Done","commit_id":"e6db6a662a5fd52ecabea4b834a5c2013d8d95e1"},{"author":{"_account_id":31668},"change_message_id":"6c130455c201fba62834a757d693a170d3a19767","unresolved":true,"context_lines":[{"line_number":2019,"context_line":"                            self._get_vnfc_storage_ids(inst_12, \u0027VDU1\u0027, 1))"},{"line_number":2020,"context_line":"        self.assertNotEqual(self._get_vnfc_storage_ids(inst_10, \u0027VDU2\u0027, 0),"},{"line_number":2021,"context_line":"                            self._get_vnfc_storage_ids(inst_12, \u0027VDU2\u0027, 0))"},{"line_number":2022,"context_line":""},{"line_number":2023,"context_line":"        # 13. Scale in operation"},{"line_number":2024,"context_line":"        scalein_req \u003d paramgen.scalein_vnf_max()"},{"line_number":2025,"context_line":"        self._add_additional_params(scalein_req)"}],"source_content_type":"text/x-python","patch_set":37,"id":"b0ed95cf_1ae80fc8","line":2022,"updated":"2023-04-05 06:40:11.000000000","message":"Could you also check the CP like L.596-L.607?","commit_id":"e6db6a662a5fd52ecabea4b834a5c2013d8d95e1"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"87ada88f2d9bfb9f1378fc39bab9a09aa6d329f2","unresolved":true,"context_lines":[{"line_number":2019,"context_line":"                            self._get_vnfc_storage_ids(inst_12, \u0027VDU1\u0027, 1))"},{"line_number":2020,"context_line":"        self.assertNotEqual(self._get_vnfc_storage_ids(inst_10, \u0027VDU2\u0027, 0),"},{"line_number":2021,"context_line":"                            self._get_vnfc_storage_ids(inst_12, \u0027VDU2\u0027, 0))"},{"line_number":2022,"context_line":""},{"line_number":2023,"context_line":"        # 13. Scale in operation"},{"line_number":2024,"context_line":"        scalein_req \u003d paramgen.scalein_vnf_max()"},{"line_number":2025,"context_line":"        self._add_additional_params(scalein_req)"}],"source_content_type":"text/x-python","patch_set":37,"id":"d3bbf767_0637353e","line":2022,"in_reply_to":"172ae795_815d9231","updated":"2023-04-17 01:48:45.000000000","message":"I added this check in PS42.","commit_id":"e6db6a662a5fd52ecabea4b834a5c2013d8d95e1"},{"author":{"_account_id":31668},"change_message_id":"4c5937e136c86b08773e33086dcb0e7988fa0cad","unresolved":true,"context_lines":[{"line_number":2019,"context_line":"                            self._get_vnfc_storage_ids(inst_12, \u0027VDU1\u0027, 1))"},{"line_number":2020,"context_line":"        self.assertNotEqual(self._get_vnfc_storage_ids(inst_10, \u0027VDU2\u0027, 0),"},{"line_number":2021,"context_line":"                            self._get_vnfc_storage_ids(inst_12, \u0027VDU2\u0027, 0))"},{"line_number":2022,"context_line":""},{"line_number":2023,"context_line":"        # 13. Scale in operation"},{"line_number":2024,"context_line":"        scalein_req \u003d paramgen.scalein_vnf_max()"},{"line_number":2025,"context_line":"        self._add_additional_params(scalein_req)"}],"source_content_type":"text/x-python","patch_set":37,"id":"172ae795_815d9231","line":2022,"in_reply_to":"4c1896f3_411be5a4","updated":"2023-04-10 07:33:44.000000000","message":"Thank you for the fix.\nCould you also check the CP of VDU1-1?","commit_id":"e6db6a662a5fd52ecabea4b834a5c2013d8d95e1"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"2af3376165484707348a813352ffd66391542d9e","unresolved":true,"context_lines":[{"line_number":2019,"context_line":"                            self._get_vnfc_storage_ids(inst_12, \u0027VDU1\u0027, 1))"},{"line_number":2020,"context_line":"        self.assertNotEqual(self._get_vnfc_storage_ids(inst_10, \u0027VDU2\u0027, 0),"},{"line_number":2021,"context_line":"                            self._get_vnfc_storage_ids(inst_12, \u0027VDU2\u0027, 0))"},{"line_number":2022,"context_line":""},{"line_number":2023,"context_line":"        # 13. Scale in operation"},{"line_number":2024,"context_line":"        scalein_req \u003d paramgen.scalein_vnf_max()"},{"line_number":2025,"context_line":"        self._add_additional_params(scalein_req)"}],"source_content_type":"text/x-python","patch_set":37,"id":"4c1896f3_411be5a4","line":2022,"in_reply_to":"b0ed95cf_1ae80fc8","updated":"2023-04-10 05:36:03.000000000","message":"I fixed it in PS39.","commit_id":"e6db6a662a5fd52ecabea4b834a5c2013d8d95e1"},{"author":{"_account_id":31668},"change_message_id":"1230b7fbfed75bdd3b503dba690be747c63c3b7e","unresolved":false,"context_lines":[{"line_number":2019,"context_line":"                            self._get_vnfc_storage_ids(inst_12, \u0027VDU1\u0027, 1))"},{"line_number":2020,"context_line":"        self.assertNotEqual(self._get_vnfc_storage_ids(inst_10, \u0027VDU2\u0027, 0),"},{"line_number":2021,"context_line":"                            self._get_vnfc_storage_ids(inst_12, \u0027VDU2\u0027, 0))"},{"line_number":2022,"context_line":""},{"line_number":2023,"context_line":"        # 13. Scale in operation"},{"line_number":2024,"context_line":"        scalein_req \u003d paramgen.scalein_vnf_max()"},{"line_number":2025,"context_line":"        self._add_additional_params(scalein_req)"}],"source_content_type":"text/x-python","patch_set":37,"id":"3fe059d6_529ad1a7","line":2022,"in_reply_to":"d3bbf767_0637353e","updated":"2023-04-19 06:46:44.000000000","message":"Done","commit_id":"e6db6a662a5fd52ecabea4b834a5c2013d8d95e1"},{"author":{"_account_id":31668},"change_message_id":"6c130455c201fba62834a757d693a170d3a19767","unresolved":true,"context_lines":[{"line_number":2057,"context_line":"        # check id of VDU1 with index 0 is changed"},{"line_number":2058,"context_line":"        self.assertNotEqual(self._get_vnfc_id(inst_14, \u0027VDU1\u0027, 0),"},{"line_number":2059,"context_line":"                            self._get_vnfc_id(inst_16, \u0027VDU1\u0027, 0))"},{"line_number":2060,"context_line":"        # check image of VDU1 with index 0 is not change"},{"line_number":2061,"context_line":"        self.assertEqual(self._get_vnfc_image(inst_14, \u0027VDU1\u0027, 0),"},{"line_number":2062,"context_line":"                         self._get_vnfc_image(inst_16, \u0027VDU1\u0027, 0))"},{"line_number":2063,"context_line":""}],"source_content_type":"text/x-python","patch_set":37,"id":"cf4c66da_d4f71e5d","line":2060,"updated":"2023-04-05 06:40:11.000000000","message":"nit: image of VDU1 with index 0 is not change -\u003e image of VDU1 with index 0 is not changed","commit_id":"e6db6a662a5fd52ecabea4b834a5c2013d8d95e1"},{"author":{"_account_id":31668},"change_message_id":"4c5937e136c86b08773e33086dcb0e7988fa0cad","unresolved":false,"context_lines":[{"line_number":2057,"context_line":"        # check id of VDU1 with index 0 is changed"},{"line_number":2058,"context_line":"        self.assertNotEqual(self._get_vnfc_id(inst_14, \u0027VDU1\u0027, 0),"},{"line_number":2059,"context_line":"                            self._get_vnfc_id(inst_16, \u0027VDU1\u0027, 0))"},{"line_number":2060,"context_line":"        # check image of VDU1 with index 0 is not change"},{"line_number":2061,"context_line":"        self.assertEqual(self._get_vnfc_image(inst_14, \u0027VDU1\u0027, 0),"},{"line_number":2062,"context_line":"                         self._get_vnfc_image(inst_16, \u0027VDU1\u0027, 0))"},{"line_number":2063,"context_line":""}],"source_content_type":"text/x-python","patch_set":37,"id":"ff942a80_ae8be28d","line":2060,"in_reply_to":"0d76fe44_b452d4fe","updated":"2023-04-10 07:33:44.000000000","message":"Done","commit_id":"e6db6a662a5fd52ecabea4b834a5c2013d8d95e1"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"2af3376165484707348a813352ffd66391542d9e","unresolved":true,"context_lines":[{"line_number":2057,"context_line":"        # check id of VDU1 with index 0 is changed"},{"line_number":2058,"context_line":"        self.assertNotEqual(self._get_vnfc_id(inst_14, \u0027VDU1\u0027, 0),"},{"line_number":2059,"context_line":"                            self._get_vnfc_id(inst_16, \u0027VDU1\u0027, 0))"},{"line_number":2060,"context_line":"        # check image of VDU1 with index 0 is not change"},{"line_number":2061,"context_line":"        self.assertEqual(self._get_vnfc_image(inst_14, \u0027VDU1\u0027, 0),"},{"line_number":2062,"context_line":"                         self._get_vnfc_image(inst_16, \u0027VDU1\u0027, 0))"},{"line_number":2063,"context_line":""}],"source_content_type":"text/x-python","patch_set":37,"id":"0d76fe44_b452d4fe","line":2060,"in_reply_to":"cf4c66da_d4f71e5d","updated":"2023-04-10 05:36:03.000000000","message":"I fixed it in PS39.","commit_id":"e6db6a662a5fd52ecabea4b834a5c2013d8d95e1"},{"author":{"_account_id":31668},"change_message_id":"6c130455c201fba62834a757d693a170d3a19767","unresolved":true,"context_lines":[{"line_number":2106,"context_line":"                            self._get_vnfc_storage_ids(inst_20, \u0027VDU1\u0027, 1))"},{"line_number":2107,"context_line":"        self.assertNotEqual(self._get_vnfc_storage_ids(inst_18, \u0027VDU2\u0027, 0),"},{"line_number":2108,"context_line":"                            self._get_vnfc_storage_ids(inst_20, \u0027VDU2\u0027, 0))"},{"line_number":2109,"context_line":""},{"line_number":2110,"context_line":"        # 21. Change external connectivity"},{"line_number":2111,"context_line":"        change_ext_conn_req \u003d paramgen.change_ext_conn_max("},{"line_number":2112,"context_line":"            self.net_ids, self.subnet_ids, self.auth_url)"}],"source_content_type":"text/x-python","patch_set":37,"id":"c99a51ce_4ae66ac8","line":2109,"updated":"2023-04-05 06:40:11.000000000","message":"Could you also check the CP like L.596-L.607?","commit_id":"e6db6a662a5fd52ecabea4b834a5c2013d8d95e1"},{"author":{"_account_id":31668},"change_message_id":"1230b7fbfed75bdd3b503dba690be747c63c3b7e","unresolved":false,"context_lines":[{"line_number":2106,"context_line":"                            self._get_vnfc_storage_ids(inst_20, \u0027VDU1\u0027, 1))"},{"line_number":2107,"context_line":"        self.assertNotEqual(self._get_vnfc_storage_ids(inst_18, \u0027VDU2\u0027, 0),"},{"line_number":2108,"context_line":"                            self._get_vnfc_storage_ids(inst_20, \u0027VDU2\u0027, 0))"},{"line_number":2109,"context_line":""},{"line_number":2110,"context_line":"        # 21. Change external connectivity"},{"line_number":2111,"context_line":"        change_ext_conn_req \u003d paramgen.change_ext_conn_max("},{"line_number":2112,"context_line":"            self.net_ids, self.subnet_ids, self.auth_url)"}],"source_content_type":"text/x-python","patch_set":37,"id":"24beff5b_57cc1c43","line":2109,"in_reply_to":"1e6609e5_123608b6","updated":"2023-04-19 06:46:44.000000000","message":"Done","commit_id":"e6db6a662a5fd52ecabea4b834a5c2013d8d95e1"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"87ada88f2d9bfb9f1378fc39bab9a09aa6d329f2","unresolved":true,"context_lines":[{"line_number":2106,"context_line":"                            self._get_vnfc_storage_ids(inst_20, \u0027VDU1\u0027, 1))"},{"line_number":2107,"context_line":"        self.assertNotEqual(self._get_vnfc_storage_ids(inst_18, \u0027VDU2\u0027, 0),"},{"line_number":2108,"context_line":"                            self._get_vnfc_storage_ids(inst_20, \u0027VDU2\u0027, 0))"},{"line_number":2109,"context_line":""},{"line_number":2110,"context_line":"        # 21. Change external connectivity"},{"line_number":2111,"context_line":"        change_ext_conn_req \u003d paramgen.change_ext_conn_max("},{"line_number":2112,"context_line":"            self.net_ids, self.subnet_ids, self.auth_url)"}],"source_content_type":"text/x-python","patch_set":37,"id":"1e6609e5_123608b6","line":2109,"in_reply_to":"91d8aed6_77655639","updated":"2023-04-17 01:48:45.000000000","message":"I added this check in PS42.","commit_id":"e6db6a662a5fd52ecabea4b834a5c2013d8d95e1"},{"author":{"_account_id":31668},"change_message_id":"4c5937e136c86b08773e33086dcb0e7988fa0cad","unresolved":true,"context_lines":[{"line_number":2106,"context_line":"                            self._get_vnfc_storage_ids(inst_20, \u0027VDU1\u0027, 1))"},{"line_number":2107,"context_line":"        self.assertNotEqual(self._get_vnfc_storage_ids(inst_18, \u0027VDU2\u0027, 0),"},{"line_number":2108,"context_line":"                            self._get_vnfc_storage_ids(inst_20, \u0027VDU2\u0027, 0))"},{"line_number":2109,"context_line":""},{"line_number":2110,"context_line":"        # 21. Change external connectivity"},{"line_number":2111,"context_line":"        change_ext_conn_req \u003d paramgen.change_ext_conn_max("},{"line_number":2112,"context_line":"            self.net_ids, self.subnet_ids, self.auth_url)"}],"source_content_type":"text/x-python","patch_set":37,"id":"91d8aed6_77655639","line":2109,"in_reply_to":"933d609c_fca2ac27","updated":"2023-04-10 07:33:44.000000000","message":"Thank you for the fix.\nCould you also check the CP of VDU1-1?","commit_id":"e6db6a662a5fd52ecabea4b834a5c2013d8d95e1"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"2af3376165484707348a813352ffd66391542d9e","unresolved":true,"context_lines":[{"line_number":2106,"context_line":"                            self._get_vnfc_storage_ids(inst_20, \u0027VDU1\u0027, 1))"},{"line_number":2107,"context_line":"        self.assertNotEqual(self._get_vnfc_storage_ids(inst_18, \u0027VDU2\u0027, 0),"},{"line_number":2108,"context_line":"                            self._get_vnfc_storage_ids(inst_20, \u0027VDU2\u0027, 0))"},{"line_number":2109,"context_line":""},{"line_number":2110,"context_line":"        # 21. Change external connectivity"},{"line_number":2111,"context_line":"        change_ext_conn_req \u003d paramgen.change_ext_conn_max("},{"line_number":2112,"context_line":"            self.net_ids, self.subnet_ids, self.auth_url)"}],"source_content_type":"text/x-python","patch_set":37,"id":"933d609c_fca2ac27","line":2109,"in_reply_to":"c99a51ce_4ae66ac8","updated":"2023-04-10 05:36:03.000000000","message":"I fixed it in PS39.","commit_id":"e6db6a662a5fd52ecabea4b834a5c2013d8d95e1"},{"author":{"_account_id":31668},"change_message_id":"6c130455c201fba62834a757d693a170d3a19767","unresolved":true,"context_lines":[{"line_number":2121,"context_line":"        inst_22 \u003d self._check_for_show_operation("},{"line_number":2122,"context_line":"            \u0027CHANGE_EXT_CONN\u0027, expected_inst_attrs, inst_id)"},{"line_number":2123,"context_line":"        # check vnfExtCPIds of VDU are changed"},{"line_number":2124,"context_line":"        for cp_1 in [\u0027VDU1_CP1\u0027, \u0027VDU2_CP2\u0027]:"},{"line_number":2125,"context_line":"            self.assertNotEqual("},{"line_number":2126,"context_line":"                self._get_vnf_ext_cp_id(inst_20, cp_1.split(\u0027_\u0027)[0], 0, cp_1),"},{"line_number":2127,"context_line":"                self._get_vnf_ext_cp_id(inst_22, cp_1.split(\u0027_\u0027)[0], 0, cp_1))"}],"source_content_type":"text/x-python","patch_set":37,"id":"5d0ceb0f_03050913","line":2124,"updated":"2023-04-05 06:40:11.000000000","message":"It also contains CP2, so what about as `ext_cp` instead of `cp_1`?","commit_id":"e6db6a662a5fd52ecabea4b834a5c2013d8d95e1"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"2af3376165484707348a813352ffd66391542d9e","unresolved":true,"context_lines":[{"line_number":2121,"context_line":"        inst_22 \u003d self._check_for_show_operation("},{"line_number":2122,"context_line":"            \u0027CHANGE_EXT_CONN\u0027, expected_inst_attrs, inst_id)"},{"line_number":2123,"context_line":"        # check vnfExtCPIds of VDU are changed"},{"line_number":2124,"context_line":"        for cp_1 in [\u0027VDU1_CP1\u0027, \u0027VDU2_CP2\u0027]:"},{"line_number":2125,"context_line":"            self.assertNotEqual("},{"line_number":2126,"context_line":"                self._get_vnf_ext_cp_id(inst_20, cp_1.split(\u0027_\u0027)[0], 0, cp_1),"},{"line_number":2127,"context_line":"                self._get_vnf_ext_cp_id(inst_22, cp_1.split(\u0027_\u0027)[0], 0, cp_1))"}],"source_content_type":"text/x-python","patch_set":37,"id":"e1a6b735_6110e72a","line":2124,"in_reply_to":"5d0ceb0f_03050913","updated":"2023-04-10 05:36:03.000000000","message":"I fixed it in PS39.","commit_id":"e6db6a662a5fd52ecabea4b834a5c2013d8d95e1"},{"author":{"_account_id":31668},"change_message_id":"4c5937e136c86b08773e33086dcb0e7988fa0cad","unresolved":false,"context_lines":[{"line_number":2121,"context_line":"        inst_22 \u003d self._check_for_show_operation("},{"line_number":2122,"context_line":"            \u0027CHANGE_EXT_CONN\u0027, expected_inst_attrs, inst_id)"},{"line_number":2123,"context_line":"        # check vnfExtCPIds of VDU are changed"},{"line_number":2124,"context_line":"        for cp_1 in [\u0027VDU1_CP1\u0027, \u0027VDU2_CP2\u0027]:"},{"line_number":2125,"context_line":"            self.assertNotEqual("},{"line_number":2126,"context_line":"                self._get_vnf_ext_cp_id(inst_20, cp_1.split(\u0027_\u0027)[0], 0, cp_1),"},{"line_number":2127,"context_line":"                self._get_vnf_ext_cp_id(inst_22, cp_1.split(\u0027_\u0027)[0], 0, cp_1))"}],"source_content_type":"text/x-python","patch_set":37,"id":"e3b2bc6a_ebe26fee","line":2124,"in_reply_to":"e1a6b735_6110e72a","updated":"2023-04-10 07:33:44.000000000","message":"Done","commit_id":"e6db6a662a5fd52ecabea4b834a5c2013d8d95e1"},{"author":{"_account_id":31668},"change_message_id":"6c130455c201fba62834a757d693a170d3a19767","unresolved":true,"context_lines":[{"line_number":2342,"context_line":"                         network_stack_after_heal[\u0027resource_status\u0027])"},{"line_number":2343,"context_line":""},{"line_number":2344,"context_line":"        # 31. Terminate VNF"},{"line_number":2345,"context_line":"        terminate_req \u003d paramgen.terminate_vnf_min()"},{"line_number":2346,"context_line":"        resp, body \u003d self.terminate_vnf_instance(inst_id, terminate_req)"},{"line_number":2347,"context_line":"        self.assertEqual(202, resp.status_code)"},{"line_number":2348,"context_line":"        self.check_resp_headers_in_operation_task(resp)"}],"source_content_type":"text/x-python","patch_set":37,"id":"2f1b6ac8_c5387213","line":2345,"updated":"2023-04-05 06:40:11.000000000","message":"Could you please use the max pattern request?","commit_id":"e6db6a662a5fd52ecabea4b834a5c2013d8d95e1"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"2af3376165484707348a813352ffd66391542d9e","unresolved":true,"context_lines":[{"line_number":2342,"context_line":"                         network_stack_after_heal[\u0027resource_status\u0027])"},{"line_number":2343,"context_line":""},{"line_number":2344,"context_line":"        # 31. Terminate VNF"},{"line_number":2345,"context_line":"        terminate_req \u003d paramgen.terminate_vnf_min()"},{"line_number":2346,"context_line":"        resp, body \u003d self.terminate_vnf_instance(inst_id, terminate_req)"},{"line_number":2347,"context_line":"        self.assertEqual(202, resp.status_code)"},{"line_number":2348,"context_line":"        self.check_resp_headers_in_operation_task(resp)"}],"source_content_type":"text/x-python","patch_set":37,"id":"f7ecc46b_fdfc84de","line":2345,"in_reply_to":"2f1b6ac8_c5387213","updated":"2023-04-10 05:36:03.000000000","message":"I fixed it in PS39.","commit_id":"e6db6a662a5fd52ecabea4b834a5c2013d8d95e1"},{"author":{"_account_id":31668},"change_message_id":"4c5937e136c86b08773e33086dcb0e7988fa0cad","unresolved":false,"context_lines":[{"line_number":2342,"context_line":"                         network_stack_after_heal[\u0027resource_status\u0027])"},{"line_number":2343,"context_line":""},{"line_number":2344,"context_line":"        # 31. Terminate VNF"},{"line_number":2345,"context_line":"        terminate_req \u003d paramgen.terminate_vnf_min()"},{"line_number":2346,"context_line":"        resp, body \u003d self.terminate_vnf_instance(inst_id, terminate_req)"},{"line_number":2347,"context_line":"        self.assertEqual(202, resp.status_code)"},{"line_number":2348,"context_line":"        self.check_resp_headers_in_operation_task(resp)"}],"source_content_type":"text/x-python","patch_set":37,"id":"58ea8e07_e2b557b9","line":2345,"in_reply_to":"f7ecc46b_fdfc84de","updated":"2023-04-10 07:33:44.000000000","message":"Done","commit_id":"e6db6a662a5fd52ecabea4b834a5c2013d8d95e1"},{"author":{"_account_id":31668},"change_message_id":"3a8cb43f2e1850fd7af234df384cc21780d41935","unresolved":true,"context_lines":[{"line_number":2044,"context_line":"        for link_port_cp in [\u0027VDU1_CP3\u0027, \u0027VDU1_CP4\u0027, \u0027VDU1_CP5\u0027]:"},{"line_number":2045,"context_line":"            self.assertNotEqual("},{"line_number":2046,"context_line":"                self._get_vnf_link_port_id("},{"line_number":2047,"context_line":"                    inst_10, link_port_cp.split(\u0027_\u0027)[0], 0, link_port_cp),"},{"line_number":2048,"context_line":"                self._get_vnf_link_port_id("},{"line_number":2049,"context_line":"                    inst_12, link_port_cp.split(\u0027_\u0027)[0], 0, link_port_cp))"},{"line_number":2050,"context_line":""}],"source_content_type":"text/x-python","patch_set":41,"id":"27ba580d_01f77f1c","line":2047,"updated":"2023-04-13 09:36:41.000000000","message":"I think it\u0027s 1 not 0.\n0, link_port_cp -\u003e 1, link_port_cp","commit_id":"108e8953dbc98ea24d3130aeedb02e5e8b72fbc7"},{"author":{"_account_id":31668},"change_message_id":"1230b7fbfed75bdd3b503dba690be747c63c3b7e","unresolved":false,"context_lines":[{"line_number":2044,"context_line":"        for link_port_cp in [\u0027VDU1_CP3\u0027, \u0027VDU1_CP4\u0027, \u0027VDU1_CP5\u0027]:"},{"line_number":2045,"context_line":"            self.assertNotEqual("},{"line_number":2046,"context_line":"                self._get_vnf_link_port_id("},{"line_number":2047,"context_line":"                    inst_10, link_port_cp.split(\u0027_\u0027)[0], 0, link_port_cp),"},{"line_number":2048,"context_line":"                self._get_vnf_link_port_id("},{"line_number":2049,"context_line":"                    inst_12, link_port_cp.split(\u0027_\u0027)[0], 0, link_port_cp))"},{"line_number":2050,"context_line":""}],"source_content_type":"text/x-python","patch_set":41,"id":"fbf4c140_514326cf","line":2047,"in_reply_to":"238d9174_957304e7","updated":"2023-04-19 06:46:44.000000000","message":"Done","commit_id":"108e8953dbc98ea24d3130aeedb02e5e8b72fbc7"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"87ada88f2d9bfb9f1378fc39bab9a09aa6d329f2","unresolved":true,"context_lines":[{"line_number":2044,"context_line":"        for link_port_cp in [\u0027VDU1_CP3\u0027, \u0027VDU1_CP4\u0027, \u0027VDU1_CP5\u0027]:"},{"line_number":2045,"context_line":"            self.assertNotEqual("},{"line_number":2046,"context_line":"                self._get_vnf_link_port_id("},{"line_number":2047,"context_line":"                    inst_10, link_port_cp.split(\u0027_\u0027)[0], 0, link_port_cp),"},{"line_number":2048,"context_line":"                self._get_vnf_link_port_id("},{"line_number":2049,"context_line":"                    inst_12, link_port_cp.split(\u0027_\u0027)[0], 0, link_port_cp))"},{"line_number":2050,"context_line":""}],"source_content_type":"text/x-python","patch_set":41,"id":"238d9174_957304e7","line":2047,"in_reply_to":"27ba580d_01f77f1c","updated":"2023-04-17 01:48:45.000000000","message":"I fixed in in PS42.","commit_id":"108e8953dbc98ea24d3130aeedb02e5e8b72fbc7"},{"author":{"_account_id":31668},"change_message_id":"3a8cb43f2e1850fd7af234df384cc21780d41935","unresolved":true,"context_lines":[{"line_number":2046,"context_line":"                self._get_vnf_link_port_id("},{"line_number":2047,"context_line":"                    inst_10, link_port_cp.split(\u0027_\u0027)[0], 0, link_port_cp),"},{"line_number":2048,"context_line":"                self._get_vnf_link_port_id("},{"line_number":2049,"context_line":"                    inst_12, link_port_cp.split(\u0027_\u0027)[0], 0, link_port_cp))"},{"line_number":2050,"context_line":""},{"line_number":2051,"context_line":"        # 13. Scale in operation"},{"line_number":2052,"context_line":"        scalein_req \u003d paramgen.scalein_vnf_max()"}],"source_content_type":"text/x-python","patch_set":41,"id":"81b68571_ea2ae16a","line":2049,"updated":"2023-04-13 09:36:41.000000000","message":"ditto","commit_id":"108e8953dbc98ea24d3130aeedb02e5e8b72fbc7"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"87ada88f2d9bfb9f1378fc39bab9a09aa6d329f2","unresolved":true,"context_lines":[{"line_number":2046,"context_line":"                self._get_vnf_link_port_id("},{"line_number":2047,"context_line":"                    inst_10, link_port_cp.split(\u0027_\u0027)[0], 0, link_port_cp),"},{"line_number":2048,"context_line":"                self._get_vnf_link_port_id("},{"line_number":2049,"context_line":"                    inst_12, link_port_cp.split(\u0027_\u0027)[0], 0, link_port_cp))"},{"line_number":2050,"context_line":""},{"line_number":2051,"context_line":"        # 13. Scale in operation"},{"line_number":2052,"context_line":"        scalein_req \u003d paramgen.scalein_vnf_max()"}],"source_content_type":"text/x-python","patch_set":41,"id":"e110a767_096f8d93","line":2049,"in_reply_to":"81b68571_ea2ae16a","updated":"2023-04-17 01:48:45.000000000","message":"ditto","commit_id":"108e8953dbc98ea24d3130aeedb02e5e8b72fbc7"},{"author":{"_account_id":31668},"change_message_id":"1230b7fbfed75bdd3b503dba690be747c63c3b7e","unresolved":false,"context_lines":[{"line_number":2046,"context_line":"                self._get_vnf_link_port_id("},{"line_number":2047,"context_line":"                    inst_10, link_port_cp.split(\u0027_\u0027)[0], 0, link_port_cp),"},{"line_number":2048,"context_line":"                self._get_vnf_link_port_id("},{"line_number":2049,"context_line":"                    inst_12, link_port_cp.split(\u0027_\u0027)[0], 0, link_port_cp))"},{"line_number":2050,"context_line":""},{"line_number":2051,"context_line":"        # 13. Scale in operation"},{"line_number":2052,"context_line":"        scalein_req \u003d paramgen.scalein_vnf_max()"}],"source_content_type":"text/x-python","patch_set":41,"id":"d933bcef_ad35f1cf","line":2049,"in_reply_to":"e110a767_096f8d93","updated":"2023-04-19 06:46:44.000000000","message":"Done","commit_id":"108e8953dbc98ea24d3130aeedb02e5e8b72fbc7"},{"author":{"_account_id":31668},"change_message_id":"3a8cb43f2e1850fd7af234df384cc21780d41935","unresolved":true,"context_lines":[{"line_number":2155,"context_line":"        for link_port_cp in [\u0027VDU1_CP3\u0027, \u0027VDU1_CP4\u0027, \u0027VDU1_CP5\u0027]:"},{"line_number":2156,"context_line":"            self.assertNotEqual("},{"line_number":2157,"context_line":"                self._get_vnf_link_port_id("},{"line_number":2158,"context_line":"                    inst_10, link_port_cp.split(\u0027_\u0027)[0], 0, link_port_cp),"},{"line_number":2159,"context_line":"                self._get_vnf_link_port_id("},{"line_number":2160,"context_line":"                    inst_12, link_port_cp.split(\u0027_\u0027)[0], 0, link_port_cp))"},{"line_number":2161,"context_line":""}],"source_content_type":"text/x-python","patch_set":41,"id":"aef6792f_069ea372","line":2158,"updated":"2023-04-13 09:36:41.000000000","message":"ditto","commit_id":"108e8953dbc98ea24d3130aeedb02e5e8b72fbc7"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"87ada88f2d9bfb9f1378fc39bab9a09aa6d329f2","unresolved":true,"context_lines":[{"line_number":2155,"context_line":"        for link_port_cp in [\u0027VDU1_CP3\u0027, \u0027VDU1_CP4\u0027, \u0027VDU1_CP5\u0027]:"},{"line_number":2156,"context_line":"            self.assertNotEqual("},{"line_number":2157,"context_line":"                self._get_vnf_link_port_id("},{"line_number":2158,"context_line":"                    inst_10, link_port_cp.split(\u0027_\u0027)[0], 0, link_port_cp),"},{"line_number":2159,"context_line":"                self._get_vnf_link_port_id("},{"line_number":2160,"context_line":"                    inst_12, link_port_cp.split(\u0027_\u0027)[0], 0, link_port_cp))"},{"line_number":2161,"context_line":""}],"source_content_type":"text/x-python","patch_set":41,"id":"c09ec4db_2f11d658","line":2158,"in_reply_to":"aef6792f_069ea372","updated":"2023-04-17 01:48:45.000000000","message":"ditto","commit_id":"108e8953dbc98ea24d3130aeedb02e5e8b72fbc7"},{"author":{"_account_id":31668},"change_message_id":"1230b7fbfed75bdd3b503dba690be747c63c3b7e","unresolved":false,"context_lines":[{"line_number":2155,"context_line":"        for link_port_cp in [\u0027VDU1_CP3\u0027, \u0027VDU1_CP4\u0027, \u0027VDU1_CP5\u0027]:"},{"line_number":2156,"context_line":"            self.assertNotEqual("},{"line_number":2157,"context_line":"                self._get_vnf_link_port_id("},{"line_number":2158,"context_line":"                    inst_10, link_port_cp.split(\u0027_\u0027)[0], 0, link_port_cp),"},{"line_number":2159,"context_line":"                self._get_vnf_link_port_id("},{"line_number":2160,"context_line":"                    inst_12, link_port_cp.split(\u0027_\u0027)[0], 0, link_port_cp))"},{"line_number":2161,"context_line":""}],"source_content_type":"text/x-python","patch_set":41,"id":"92c03444_ad5f4b54","line":2158,"in_reply_to":"c09ec4db_2f11d658","updated":"2023-04-19 06:46:44.000000000","message":"Done","commit_id":"108e8953dbc98ea24d3130aeedb02e5e8b72fbc7"},{"author":{"_account_id":31668},"change_message_id":"3a8cb43f2e1850fd7af234df384cc21780d41935","unresolved":true,"context_lines":[{"line_number":2157,"context_line":"                self._get_vnf_link_port_id("},{"line_number":2158,"context_line":"                    inst_10, link_port_cp.split(\u0027_\u0027)[0], 0, link_port_cp),"},{"line_number":2159,"context_line":"                self._get_vnf_link_port_id("},{"line_number":2160,"context_line":"                    inst_12, link_port_cp.split(\u0027_\u0027)[0], 0, link_port_cp))"},{"line_number":2161,"context_line":""},{"line_number":2162,"context_line":"        # 21. Change external connectivity"},{"line_number":2163,"context_line":"        change_ext_conn_req \u003d paramgen.change_ext_conn_max("}],"source_content_type":"text/x-python","patch_set":41,"id":"07bdbacb_2945fffc","line":2160,"updated":"2023-04-13 09:36:41.000000000","message":"ditto","commit_id":"108e8953dbc98ea24d3130aeedb02e5e8b72fbc7"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"87ada88f2d9bfb9f1378fc39bab9a09aa6d329f2","unresolved":true,"context_lines":[{"line_number":2157,"context_line":"                self._get_vnf_link_port_id("},{"line_number":2158,"context_line":"                    inst_10, link_port_cp.split(\u0027_\u0027)[0], 0, link_port_cp),"},{"line_number":2159,"context_line":"                self._get_vnf_link_port_id("},{"line_number":2160,"context_line":"                    inst_12, link_port_cp.split(\u0027_\u0027)[0], 0, link_port_cp))"},{"line_number":2161,"context_line":""},{"line_number":2162,"context_line":"        # 21. Change external connectivity"},{"line_number":2163,"context_line":"        change_ext_conn_req \u003d paramgen.change_ext_conn_max("}],"source_content_type":"text/x-python","patch_set":41,"id":"b337e6ee_654e250c","line":2160,"in_reply_to":"07bdbacb_2945fffc","updated":"2023-04-17 01:48:45.000000000","message":"ditto","commit_id":"108e8953dbc98ea24d3130aeedb02e5e8b72fbc7"},{"author":{"_account_id":31668},"change_message_id":"1230b7fbfed75bdd3b503dba690be747c63c3b7e","unresolved":false,"context_lines":[{"line_number":2157,"context_line":"                self._get_vnf_link_port_id("},{"line_number":2158,"context_line":"                    inst_10, link_port_cp.split(\u0027_\u0027)[0], 0, link_port_cp),"},{"line_number":2159,"context_line":"                self._get_vnf_link_port_id("},{"line_number":2160,"context_line":"                    inst_12, link_port_cp.split(\u0027_\u0027)[0], 0, link_port_cp))"},{"line_number":2161,"context_line":""},{"line_number":2162,"context_line":"        # 21. Change external connectivity"},{"line_number":2163,"context_line":"        change_ext_conn_req \u003d paramgen.change_ext_conn_max("}],"source_content_type":"text/x-python","patch_set":41,"id":"c5042851_30f95626","line":2160,"in_reply_to":"b337e6ee_654e250c","updated":"2023-04-19 06:46:44.000000000","message":"Done","commit_id":"108e8953dbc98ea24d3130aeedb02e5e8b72fbc7"},{"author":{"_account_id":31668},"change_message_id":"df737206523d76423659e3f13324be2679b7d964","unresolved":true,"context_lines":[{"line_number":1751,"context_line":"        # supported cases:"},{"line_number":1752,"context_line":"        #   1. change VM created by image to VM created by new image"},{"line_number":1753,"context_line":"        #   2. change VM created by volume to VM created by new volume"},{"line_number":1754,"context_line":"        self._put_fail_file(\u0027change_vnfpkg\u0027)"},{"line_number":1755,"context_line":"        change_vnf_pkg_req \u003d paramgen.change_vnf_pkg_individual_vnfc_min("},{"line_number":1756,"context_line":"            self.vnfd_id_5, vdu2_old_vnfc\u003d\u0027VDU2_CP2\u0027)"},{"line_number":1757,"context_line":"        resp, body \u003d self.change_vnfpkg(inst_id, change_vnf_pkg_req)"}],"source_content_type":"text/x-python","patch_set":44,"id":"f1eb69af_8f896dbe","line":1754,"updated":"2023-04-20 09:46:04.000000000","message":"Does /tmp/change_vnfpkg need to be created?","commit_id":"66737bbd9ab62455191a3a5354e88d1801f68708"},{"author":{"_account_id":31668},"change_message_id":"600216e691356b714ce45783dfa00a4cc1f726b0","unresolved":false,"context_lines":[{"line_number":1751,"context_line":"        # supported cases:"},{"line_number":1752,"context_line":"        #   1. change VM created by image to VM created by new image"},{"line_number":1753,"context_line":"        #   2. change VM created by volume to VM created by new volume"},{"line_number":1754,"context_line":"        self._put_fail_file(\u0027change_vnfpkg\u0027)"},{"line_number":1755,"context_line":"        change_vnf_pkg_req \u003d paramgen.change_vnf_pkg_individual_vnfc_min("},{"line_number":1756,"context_line":"            self.vnfd_id_5, vdu2_old_vnfc\u003d\u0027VDU2_CP2\u0027)"},{"line_number":1757,"context_line":"        resp, body \u003d self.change_vnfpkg(inst_id, change_vnf_pkg_req)"}],"source_content_type":"text/x-python","patch_set":44,"id":"e1eb61c3_5c5e51ef","line":1754,"in_reply_to":"2744ae97_2ee57a33","updated":"2023-04-28 07:14:16.000000000","message":"Done","commit_id":"66737bbd9ab62455191a3a5354e88d1801f68708"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"8a9df843948600460518da46b2cde2b152537ad6","unresolved":true,"context_lines":[{"line_number":1751,"context_line":"        # supported cases:"},{"line_number":1752,"context_line":"        #   1. change VM created by image to VM created by new image"},{"line_number":1753,"context_line":"        #   2. change VM created by volume to VM created by new volume"},{"line_number":1754,"context_line":"        self._put_fail_file(\u0027change_vnfpkg\u0027)"},{"line_number":1755,"context_line":"        change_vnf_pkg_req \u003d paramgen.change_vnf_pkg_individual_vnfc_min("},{"line_number":1756,"context_line":"            self.vnfd_id_5, vdu2_old_vnfc\u003d\u0027VDU2_CP2\u0027)"},{"line_number":1757,"context_line":"        resp, body \u003d self.change_vnfpkg(inst_id, change_vnf_pkg_req)"}],"source_content_type":"text/x-python","patch_set":44,"id":"2744ae97_2ee57a33","line":1754,"in_reply_to":"f1eb69af_8f896dbe","updated":"2023-04-28 04:39:58.000000000","message":"I fixed it in PS46.","commit_id":"66737bbd9ab62455191a3a5354e88d1801f68708"},{"author":{"_account_id":31668},"change_message_id":"df737206523d76423659e3f13324be2679b7d964","unresolved":true,"context_lines":[{"line_number":1759,"context_line":"        self.check_resp_headers_in_operation_task(resp)"},{"line_number":1760,"context_line":"        lcmocc_id \u003d os.path.basename(resp.headers[\u0027Location\u0027])"},{"line_number":1761,"context_line":"        self.wait_lcmocc_failed_temp(lcmocc_id)"},{"line_number":1762,"context_line":"        self._rm_fail_file(\u0027change_vnfpkg\u0027)"},{"line_number":1763,"context_line":""},{"line_number":1764,"context_line":"        # 8. Rollback change_vnfpkg operation"},{"line_number":1765,"context_line":"        resp, body \u003d self.rollback_lcmocc(lcmocc_id)"}],"source_content_type":"text/x-python","patch_set":44,"id":"700d51c5_90a0cad7","line":1762,"updated":"2023-04-20 09:46:04.000000000","message":"ditto","commit_id":"66737bbd9ab62455191a3a5354e88d1801f68708"},{"author":{"_account_id":31668},"change_message_id":"600216e691356b714ce45783dfa00a4cc1f726b0","unresolved":false,"context_lines":[{"line_number":1759,"context_line":"        self.check_resp_headers_in_operation_task(resp)"},{"line_number":1760,"context_line":"        lcmocc_id \u003d os.path.basename(resp.headers[\u0027Location\u0027])"},{"line_number":1761,"context_line":"        self.wait_lcmocc_failed_temp(lcmocc_id)"},{"line_number":1762,"context_line":"        self._rm_fail_file(\u0027change_vnfpkg\u0027)"},{"line_number":1763,"context_line":""},{"line_number":1764,"context_line":"        # 8. Rollback change_vnfpkg operation"},{"line_number":1765,"context_line":"        resp, body \u003d self.rollback_lcmocc(lcmocc_id)"}],"source_content_type":"text/x-python","patch_set":44,"id":"2b6eb7fc_563abb0e","line":1762,"in_reply_to":"6697f588_a18fbc3b","updated":"2023-04-28 07:14:16.000000000","message":"Done","commit_id":"66737bbd9ab62455191a3a5354e88d1801f68708"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"8a9df843948600460518da46b2cde2b152537ad6","unresolved":true,"context_lines":[{"line_number":1759,"context_line":"        self.check_resp_headers_in_operation_task(resp)"},{"line_number":1760,"context_line":"        lcmocc_id \u003d os.path.basename(resp.headers[\u0027Location\u0027])"},{"line_number":1761,"context_line":"        self.wait_lcmocc_failed_temp(lcmocc_id)"},{"line_number":1762,"context_line":"        self._rm_fail_file(\u0027change_vnfpkg\u0027)"},{"line_number":1763,"context_line":""},{"line_number":1764,"context_line":"        # 8. Rollback change_vnfpkg operation"},{"line_number":1765,"context_line":"        resp, body \u003d self.rollback_lcmocc(lcmocc_id)"}],"source_content_type":"text/x-python","patch_set":44,"id":"6697f588_a18fbc3b","line":1762,"in_reply_to":"700d51c5_90a0cad7","updated":"2023-04-28 04:39:58.000000000","message":"ditto","commit_id":"66737bbd9ab62455191a3a5354e88d1801f68708"}]}
