)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"85ccb7c8707be230496e5a053331ad743dd60fa2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"8db99e44_40a654c2","updated":"2023-09-11 04:19:20.000000000","message":"Thanks for your patch and sorry for the late review.\nPlease kindly find my comments.","commit_id":"eeeea84b12c02627a5aae3f51262a7c8b393e6e3"}],"doc/source/admin/mgmt_driver_error_handling.rst":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"85ccb7c8707be230496e5a053331ad743dd60fa2","unresolved":true,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"The definition of ``ProblemDetails`` is as follows."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":".. csv-table::  Table 6.3-1: Definition of the ``ProblemDetails`` data type `ETSI GS NFV-SOL 013 v2.6.1`_"},{"line_number":29,"context_line":"    :header: Attribute name, Data type, Cardinality, Description"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    type,Uri,0..1, \"A URI reference according to `IETF RFC 3986`_ that identifies"},{"line_number":32,"context_line":"    the problem type. It is encouraged that the URI provides"},{"line_number":33,"context_line":"    human-readable documentation for the problem (e.g. using"},{"line_number":34,"context_line":"    HTML) when dereferenced. When this member is not present,"},{"line_number":35,"context_line":"    its value is assumed to be \u0027about:blank\u0027.\""},{"line_number":36,"context_line":"    title,String,0..1, \"A short, human-readable summary of the problem type."},{"line_number":37,"context_line":"    It should not change from occurrence to occurrence of the problem,"},{"line_number":38,"context_line":"    except for purposes of localization. If type is given and other"},{"line_number":39,"context_line":"    than \u0027about:blank\u0027, this attribute shall also be provided.\""},{"line_number":40,"context_line":"    status,Integer,1, \"The HTTP status code for this"},{"line_number":41,"context_line":"    occurrence of the problem.\""},{"line_number":42,"context_line":"    detail,String,1, \"A human-readable explanation specific"},{"line_number":43,"context_line":"    to this occurrence of the problem.\""},{"line_number":44,"context_line":"    instance,Uri,0..1, \"A URI reference that identifies the specific"},{"line_number":45,"context_line":"    occurrence of the problem. It may yield further"},{"line_number":46,"context_line":"    information if dereferenced\""},{"line_number":47,"context_line":"    (additional attributes),Not specified.,0..N, \"Any number of additional"},{"line_number":48,"context_line":"    attributes, as defined in a specification or by an implementation.\""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"To implement the rule, there is a base exception class"},{"line_number":51,"context_line":"complied with ``ProblemDetails`` in Tacker side, which can be"}],"source_content_type":"text/x-rst","patch_set":11,"id":"a1a5edbb_afbe4901","line":48,"range":{"start_line":28,"start_character":0,"end_line":48,"end_character":71},"updated":"2023-09-11 04:19:20.000000000","message":"How about you change to use `list-table` instead of `csv-table`?\n\nexample:\nhttps://opendev.org/openstack/tacker/src/branch/master/doc/source/contributor/vagrant_devstack.rst?display\u003dsource#L106-L130","commit_id":"eeeea84b12c02627a5aae3f51262a7c8b393e6e3"}],"samples/mgmt_driver/ansible/exceptions.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"85ccb7c8707be230496e5a053331ad743dd60fa2","unresolved":true,"context_lines":[{"line_number":44,"context_line":"      - ex_type: the exception type"},{"line_number":45,"context_line":"      - details: the exception message or error information"},{"line_number":46,"context_line":"    \"\"\""},{"line_number":47,"context_line":"    message \u003d \"Parameter conversion error. \"\\"},{"line_number":48,"context_line":"        + \"Error encountered in configuring parser: [%(ex_type)s, %(details)s]\""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"class ConfigParserParsingError(AnsibleDriverException):"}],"source_content_type":"text/x-python","patch_set":11,"id":"6a851e38_ac232563","line":48,"range":{"start_line":47,"start_character":44,"end_line":48,"end_character":9},"updated":"2023-09-11 04:19:20.000000000","message":"Could you change to the following?\n* Change to not use backslashes as newlines\n* Change concatenated strings to not use `+`","commit_id":"eeeea84b12c02627a5aae3f51262a7c8b393e6e3"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"85ccb7c8707be230496e5a053331ad743dd60fa2","unresolved":true,"context_lines":[{"line_number":56,"context_line":"      - ex_type: the exception type"},{"line_number":57,"context_line":"      - details: the exception message or error information"},{"line_number":58,"context_line":"    \"\"\""},{"line_number":59,"context_line":"    message \u003d \"Parameter conversion error. \"\\"},{"line_number":60,"context_line":"        + \"Encountered error in parsing \u0027%(cmd)s\u0027: [%(ex_type)s, %(details)s]\""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"class ConfigValidationError(AnsibleDriverException):"}],"source_content_type":"text/x-python","patch_set":11,"id":"ecd629c5_d46c9932","line":60,"range":{"start_line":59,"start_character":44,"end_line":60,"end_character":9},"updated":"2023-09-11 04:19:20.000000000","message":"ditto.","commit_id":"eeeea84b12c02627a5aae3f51262a7c8b393e6e3"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"85ccb7c8707be230496e5a053331ad743dd60fa2","unresolved":true,"context_lines":[{"line_number":75,"context_line":"    Define the following upon using this exception:"},{"line_number":76,"context_line":"      - key: the offending key"},{"line_number":77,"context_line":"    \"\"\""},{"line_number":78,"context_line":"    message \u003d \"Config file validation error. \"\\"},{"line_number":79,"context_line":"        + \"The key \u0027%(key)s\u0027 is not defined.\""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"class InvalidValueError(AnsibleDriverException):"}],"source_content_type":"text/x-python","patch_set":11,"id":"e4da4be6_c286f1da","line":79,"range":{"start_line":78,"start_character":46,"end_line":79,"end_character":9},"updated":"2023-09-11 04:19:20.000000000","message":"ditto.","commit_id":"eeeea84b12c02627a5aae3f51262a7c8b393e6e3"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"85ccb7c8707be230496e5a053331ad743dd60fa2","unresolved":true,"context_lines":[{"line_number":85,"context_line":"    Define the following upon using this exception:"},{"line_number":86,"context_line":"      - key: the offending key"},{"line_number":87,"context_line":"    \"\"\""},{"line_number":88,"context_line":"    message \u003d \"Config file validation error. \"\\"},{"line_number":89,"context_line":"        + \"Invalid value of \u0027%(key)s\u0027 is defined.\""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"class PlaybooksCommandsNotFound(AnsibleDriverException):"}],"source_content_type":"text/x-python","patch_set":11,"id":"0eddd875_bb976dd6","line":89,"range":{"start_line":88,"start_character":46,"end_line":89,"end_character":9},"updated":"2023-09-11 04:19:20.000000000","message":"ditto.","commit_id":"eeeea84b12c02627a5aae3f51262a7c8b393e6e3"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"85ccb7c8707be230496e5a053331ad743dd60fa2","unresolved":true,"context_lines":[{"line_number":95,"context_line":"    Define the following upon using this exception:"},{"line_number":96,"context_line":"      - key: the offending action key"},{"line_number":97,"context_line":"    \"\"\""},{"line_number":98,"context_line":"    message \u003d \"Config file validation error. \"\\"},{"line_number":99,"context_line":"        + \"Playbooks or commands not found for action key: %(key)s\""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"class InvalidKeyError(AnsibleDriverException):"}],"source_content_type":"text/x-python","patch_set":11,"id":"940973d7_f76757f6","line":99,"range":{"start_line":98,"start_character":46,"end_line":99,"end_character":9},"updated":"2023-09-11 04:19:20.000000000","message":"ditto.","commit_id":"eeeea84b12c02627a5aae3f51262a7c8b393e6e3"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"85ccb7c8707be230496e5a053331ad743dd60fa2","unresolved":true,"context_lines":[{"line_number":133,"context_line":"      - host: the target host for execution"},{"line_number":134,"context_line":"      - cmd: the command executed that caused the error"},{"line_number":135,"context_line":"    \"\"\""},{"line_number":136,"context_line":"    message \u003d \"Command execution has reached timeout. \"\\"},{"line_number":137,"context_line":"        + \"Target: %(host)s Command: %(cmd)s\""},{"line_number":138,"context_line":""},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"class CommandConnectionLimitReached(AnsibleDriverException):"}],"source_content_type":"text/x-python","patch_set":11,"id":"c1706bb6_e47d5996","line":137,"range":{"start_line":136,"start_character":55,"end_line":137,"end_character":9},"updated":"2023-09-11 04:19:20.000000000","message":"ditto.","commit_id":"eeeea84b12c02627a5aae3f51262a7c8b393e6e3"}],"tacker/tests/unit/conductor/test_conductor_server.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"85ccb7c8707be230496e5a053331ad743dd60fa2","unresolved":true,"context_lines":[{"line_number":970,"context_line":"            mock_build_instantiated_vnf_info,"},{"line_number":971,"context_line":"            mock_change_vnf_status):"},{"line_number":972,"context_line":"        lcm_op_occs_data \u003d fakes.get_lcm_op_occs_data()"},{"line_number":973,"context_line":"        mock_vnf_by_id.return_value \u003d \\"},{"line_number":974,"context_line":"            objects.VnfLcmOpOcc(context\u003dself.context,"},{"line_number":975,"context_line":"                                **lcm_op_occs_data)"},{"line_number":976,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"209e04ac_fa21c926","line":973,"range":{"start_line":973,"start_character":38,"end_line":973,"end_character":39},"updated":"2023-09-11 04:19:20.000000000","message":"nits: Could you change to not use backslash as a line break?\nThis can write like the following:\n```\n        mock_vnf_by_id.return_value \u003d objects.VnfLcmOpOcc(\n            context\u003dself.context, **lcm_op_occs_data)\n```","commit_id":"eeeea84b12c02627a5aae3f51262a7c8b393e6e3"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"85ccb7c8707be230496e5a053331ad743dd60fa2","unresolved":true,"context_lines":[{"line_number":1015,"context_line":"            mock_build_instantiated_vnf_info,"},{"line_number":1016,"context_line":"            mock_change_vnf_status):"},{"line_number":1017,"context_line":"        lcm_op_occs_data \u003d fakes.get_lcm_op_occs_data()"},{"line_number":1018,"context_line":"        mock_vnf_by_id.return_value \u003d \\"},{"line_number":1019,"context_line":"            objects.VnfLcmOpOcc(context\u003dself.context,"},{"line_number":1020,"context_line":"                                **lcm_op_occs_data)"},{"line_number":1021,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"20456f1b_f15664f2","line":1018,"range":{"start_line":1018,"start_character":38,"end_line":1018,"end_character":39},"updated":"2023-09-11 04:19:20.000000000","message":"ditto.","commit_id":"eeeea84b12c02627a5aae3f51262a7c8b393e6e3"}],"tacker/tests/unit/vnfm/test_plugin.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"85ccb7c8707be230496e5a053331ad743dd60fa2","unresolved":true,"context_lines":[{"line_number":832,"context_line":"                         vnf_dict[\u0027status\u0027])"},{"line_number":833,"context_line":"        mock_set_vnf_error_status_reason.assert_called_once_with(self.context,"},{"line_number":834,"context_line":"                                                          dummy_vnf_obj[\u0027id\u0027],"},{"line_number":835,"context_line":"                                                   \u0027test_title\u0027)"},{"line_number":836,"context_line":""},{"line_number":837,"context_line":"    @patch(\u0027tacker.db.vnfm.vnfm_db.VNFMPluginDb.set_vnf_error_status_reason\u0027)"},{"line_number":838,"context_line":"    def test_update_vnf_fail_update_wait_error(self,"}],"source_content_type":"text/x-python","patch_set":11,"id":"2352bfe3_a5ade234","line":835,"range":{"start_line":835,"start_character":51,"end_line":835,"end_character":64},"updated":"2023-09-11 04:19:20.000000000","message":"Could you adjust indentation or revise to like the following?\n```\n        mock_set_vnf_error_status_reason.assert_called_once_with(\n            self.context, dummy_vnf_obj[\u0027id\u0027], \u0027test_title\u0027)\n```","commit_id":"eeeea84b12c02627a5aae3f51262a7c8b393e6e3"}]}