)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"0b75b6955fa0b8fa0250752de5fae7b7878bde4d","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Kenta Fukaya \u003ckenta.fukaya.xv@hco.ntt.co.jp\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-04-03 10:17:49 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Import i18n Library to Fix Bug that __ is not defined"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch fix bug that __ is not defined."},{"line_number":10,"context_line":"This bug coused by i18n library is not imported."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"0a5abd99_48208b06","line":7,"range":{"start_line":7,"start_character":1,"end_line":7,"end_character":42},"updated":"2023-04-11 11:13:35.000000000","message":"Additionally please refer OpenStack Commit message Guidelines, as the commit message title restricts to 50 chars. \n\nhttps://wiki.openstack.org/wiki/Fuel/Code_Review_Rules","commit_id":"9a54ea8ef5741748b2cb70e155d597c8377c439e"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"9d63ac62e3ce6a33e55c6181c9b1dc21d6e4d4f3","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Kenta Fukaya \u003ckenta.fukaya.xv@hco.ntt.co.jp\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-04-03 10:17:49 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Import i18n Library to Fix Bug that __ is not defined"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch fix bug that __ is not defined."},{"line_number":10,"context_line":"This bug coused by i18n library is not imported."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"92458b01_66fd082b","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":53},"updated":"2023-04-04 10:06:42.000000000","message":"How about this? Starting with \"Fix\" makes other developers to find that this patch fixes something bugs.\n`Fix missing import for i18n`","commit_id":"9a54ea8ef5741748b2cb70e155d597c8377c439e"},{"author":{"_account_id":32707,"name":"Kenta Fukaya","email":"kenta.fukaya.xv@hco.ntt.co.jp","username":"fukayan"},"change_message_id":"73986909c2a6efde4f91b06a30d3bc62510fc42b","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Kenta Fukaya \u003ckenta.fukaya.xv@hco.ntt.co.jp\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-04-03 10:17:49 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Import i18n Library to Fix Bug that __ is not defined"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch fix bug that __ is not defined."},{"line_number":10,"context_line":"This bug coused by i18n library is not imported."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"f2ac6466_893a4a8a","line":7,"range":{"start_line":7,"start_character":1,"end_line":7,"end_character":42},"in_reply_to":"0a5abd99_48208b06","updated":"2023-04-24 05:36:15.000000000","message":"Thank for your comment.\nI fixed my title in PS4.","commit_id":"9a54ea8ef5741748b2cb70e155d597c8377c439e"},{"author":{"_account_id":32707,"name":"Kenta Fukaya","email":"kenta.fukaya.xv@hco.ntt.co.jp","username":"fukayan"},"change_message_id":"73986909c2a6efde4f91b06a30d3bc62510fc42b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Kenta Fukaya \u003ckenta.fukaya.xv@hco.ntt.co.jp\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-04-03 10:17:49 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Import i18n Library to Fix Bug that __ is not defined"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch fix bug that __ is not defined."},{"line_number":10,"context_line":"This bug coused by i18n library is not imported."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5e265e66_b1627a78","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":53},"in_reply_to":"92458b01_66fd082b","updated":"2023-04-24 05:36:15.000000000","message":"Thank for your comments.\nI fixed my title in PS4.","commit_id":"9a54ea8ef5741748b2cb70e155d597c8377c439e"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"9d63ac62e3ce6a33e55c6181c9b1dc21d6e4d4f3","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Import i18n Library to Fix Bug that __ is not defined"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch fix bug that __ is not defined."},{"line_number":10,"context_line":"This bug coused by i18n library is not imported."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: #2013427"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ec40df91_176f355f","line":9,"range":{"start_line":9,"start_character":24,"end_line":9,"end_character":26},"updated":"2023-04-04 10:06:42.000000000","message":"This might be `_`.\nAny problems to use `_`?","commit_id":"9a54ea8ef5741748b2cb70e155d597c8377c439e"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"9d63ac62e3ce6a33e55c6181c9b1dc21d6e4d4f3","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Import i18n Library to Fix Bug that __ is not defined"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch fix bug that __ is not defined."},{"line_number":10,"context_line":"This bug coused by i18n library is not imported."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: #2013427"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"385ccc49_e8f07ccf","line":9,"range":{"start_line":9,"start_character":11,"end_line":9,"end_character":15},"updated":"2023-04-04 10:06:42.000000000","message":"fixes","commit_id":"9a54ea8ef5741748b2cb70e155d597c8377c439e"},{"author":{"_account_id":32707,"name":"Kenta Fukaya","email":"kenta.fukaya.xv@hco.ntt.co.jp","username":"fukayan"},"change_message_id":"73986909c2a6efde4f91b06a30d3bc62510fc42b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Import i18n Library to Fix Bug that __ is not defined"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch fix bug that __ is not defined."},{"line_number":10,"context_line":"This bug coused by i18n library is not imported."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: #2013427"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"c455759e_c2aced8a","line":9,"range":{"start_line":9,"start_character":11,"end_line":9,"end_character":15},"in_reply_to":"385ccc49_e8f07ccf","updated":"2023-04-24 05:36:15.000000000","message":"Ditto","commit_id":"9a54ea8ef5741748b2cb70e155d597c8377c439e"},{"author":{"_account_id":32707,"name":"Kenta Fukaya","email":"kenta.fukaya.xv@hco.ntt.co.jp","username":"fukayan"},"change_message_id":"73986909c2a6efde4f91b06a30d3bc62510fc42b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Import i18n Library to Fix Bug that __ is not defined"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch fix bug that __ is not defined."},{"line_number":10,"context_line":"This bug coused by i18n library is not imported."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: #2013427"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"61dff330_34e95261","line":9,"range":{"start_line":9,"start_character":24,"end_line":9,"end_character":26},"in_reply_to":"ec40df91_176f355f","updated":"2023-04-24 05:36:15.000000000","message":"Ditto","commit_id":"9a54ea8ef5741748b2cb70e155d597c8377c439e"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"9d63ac62e3ce6a33e55c6181c9b1dc21d6e4d4f3","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Import i18n Library to Fix Bug that __ is not defined"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch fix bug that __ is not defined."},{"line_number":10,"context_line":"This bug coused by i18n library is not imported."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: #2013427"},{"line_number":13,"context_line":"Change-Id: Idb6afbf44cb9b6326d024f7c6d41814274ec8ea9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5420d859_fcdf00dd","line":10,"updated":"2023-04-04 10:06:42.000000000","message":"It\u0027s better to describe that `_` is used as an alias for i18n library.\n\nFor example:\n\n```\nIn general, Tacker uses _ as an alias for i18n.\nTherefore, this bug caused by i18n library is not imported.\n```","commit_id":"9a54ea8ef5741748b2cb70e155d597c8377c439e"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"9d63ac62e3ce6a33e55c6181c9b1dc21d6e4d4f3","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Import i18n Library to Fix Bug that __ is not defined"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch fix bug that __ is not defined."},{"line_number":10,"context_line":"This bug coused by i18n library is not imported."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: #2013427"},{"line_number":13,"context_line":"Change-Id: Idb6afbf44cb9b6326d024f7c6d41814274ec8ea9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"a91b8f8b_c5e8555f","line":10,"range":{"start_line":10,"start_character":9,"end_line":10,"end_character":15},"updated":"2023-04-04 10:06:42.000000000","message":"caused?","commit_id":"9a54ea8ef5741748b2cb70e155d597c8377c439e"},{"author":{"_account_id":32707,"name":"Kenta Fukaya","email":"kenta.fukaya.xv@hco.ntt.co.jp","username":"fukayan"},"change_message_id":"73986909c2a6efde4f91b06a30d3bc62510fc42b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Import i18n Library to Fix Bug that __ is not defined"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch fix bug that __ is not defined."},{"line_number":10,"context_line":"This bug coused by i18n library is not imported."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: #2013427"},{"line_number":13,"context_line":"Change-Id: Idb6afbf44cb9b6326d024f7c6d41814274ec8ea9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1bee1e78_a4fc2ad1","line":10,"in_reply_to":"5420d859_fcdf00dd","updated":"2023-04-24 05:36:15.000000000","message":"Ditto","commit_id":"9a54ea8ef5741748b2cb70e155d597c8377c439e"},{"author":{"_account_id":32707,"name":"Kenta Fukaya","email":"kenta.fukaya.xv@hco.ntt.co.jp","username":"fukayan"},"change_message_id":"73986909c2a6efde4f91b06a30d3bc62510fc42b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Import i18n Library to Fix Bug that __ is not defined"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch fix bug that __ is not defined."},{"line_number":10,"context_line":"This bug coused by i18n library is not imported."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: #2013427"},{"line_number":13,"context_line":"Change-Id: Idb6afbf44cb9b6326d024f7c6d41814274ec8ea9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5635e109_155bb672","line":10,"range":{"start_line":10,"start_character":9,"end_line":10,"end_character":15},"in_reply_to":"a91b8f8b_c5e8555f","updated":"2023-04-24 05:36:15.000000000","message":"Ditto","commit_id":"9a54ea8ef5741748b2cb70e155d597c8377c439e"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"9d63ac62e3ce6a33e55c6181c9b1dc21d6e4d4f3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5fd0161f_50b3865b","updated":"2023-04-04 10:06:42.000000000","message":"Thank you for the patch.\nPlease kindly find my comments.","commit_id":"9a54ea8ef5741748b2cb70e155d597c8377c439e"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"0b75b6955fa0b8fa0250752de5fae7b7878bde4d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"491d9706_7f49d42e","updated":"2023-04-11 11:13:35.000000000","message":"Thanks for your patch.","commit_id":"9a54ea8ef5741748b2cb70e155d597c8377c439e"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"83e2f187104f50cb405635bfea5d050ff48a8541","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3dbb4b66_57bffe07","updated":"2023-04-25 03:35:59.000000000","message":"Could I confirm all the missing importing is really required. In other word, no need to drop `_()` instead of importing i18n?","commit_id":"5b5cd158451ee773460c1c239640ea96ba1ebf8b"},{"author":{"_account_id":32707,"name":"Kenta Fukaya","email":"kenta.fukaya.xv@hco.ntt.co.jp","username":"fukayan"},"change_message_id":"ad9f8cee086051eafd110ba957c4c5a55ff42992","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1c1ae79d_1195d03a","in_reply_to":"3dbb4b66_57bffe07","updated":"2023-04-25 06:59:48.000000000","message":"Thanks for your comment.\nI think your opinion is correct.\nHowever, I cannot determine whether _() is necessary or not.\nSo I think it is better to fix all errors once and if unnecessary import is exist, I remove them with other patches.\n\nPlease let me know if you have any evaluation criteria to drop _().","commit_id":"5b5cd158451ee773460c1c239640ea96ba1ebf8b"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"7324a1b68f1ebce031bd8d5e11892e16ac3ca1d9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"4b8e90d5_daf2b1c1","updated":"2023-07-13 10:16:27.000000000","message":"LGTM.","commit_id":"83e61aeef2339db36b2362431620a59bb9c2eeda"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"46ba1b84709d0ca5147bfd5300314b6a6829fa95","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"2c473255_8b9b4394","updated":"2023-07-12 13:44:46.000000000","message":"recheck - for unexpected failure","commit_id":"83e61aeef2339db36b2362431620a59bb9c2eeda"}],"tacker/vnflcm/vnflcm_driver.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"83e2f187104f50cb405635bfea5d050ff48a8541","unresolved":true,"context_lines":[{"line_number":355,"context_line":"            vnf_package_path\u003dvnf_package_path)"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"        # save the vnf resources in the db"},{"line_number":358,"context_line":"        for _, resources in vnf_resources.items():"},{"line_number":359,"context_line":"            for vnf_resource in resources:"},{"line_number":360,"context_line":"                vnf_resource.create()"},{"line_number":361,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"cd473c33_6378e1f4","side":"PARENT","line":358,"updated":"2023-04-25 03:35:59.000000000","message":"No need to modify here actually, but it\u0027s better to remain the prefix `_`, such as `_i` or so, to show it\u0027s not interested itself.","commit_id":"05fe9fa42c3f717e17e2ea8b33f1b78e3e4b63da"},{"author":{"_account_id":32707,"name":"Kenta Fukaya","email":"kenta.fukaya.xv@hco.ntt.co.jp","username":"fukayan"},"change_message_id":"ad9f8cee086051eafd110ba957c4c5a55ff42992","unresolved":true,"context_lines":[{"line_number":355,"context_line":"            vnf_package_path\u003dvnf_package_path)"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"        # save the vnf resources in the db"},{"line_number":358,"context_line":"        for _, resources in vnf_resources.items():"},{"line_number":359,"context_line":"            for vnf_resource in resources:"},{"line_number":360,"context_line":"                vnf_resource.create()"},{"line_number":361,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"48037815_e7c5183a","side":"PARENT","line":358,"in_reply_to":"cd473c33_6378e1f4","updated":"2023-04-25 06:59:48.000000000","message":"I fixed it on PS5.","commit_id":"05fe9fa42c3f717e17e2ea8b33f1b78e3e4b63da"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"83e2f187104f50cb405635bfea5d050ff48a8541","unresolved":true,"context_lines":[{"line_number":1488,"context_line":"                region_name\u003dvim_connection_info.access_info.get(\u0027region_name\u0027)"},{"line_number":1489,"context_line":"            )"},{"line_number":1490,"context_line":"        else:"},{"line_number":1491,"context_line":"            for _ in range(scale_vnf_request.number_of_steps):"},{"line_number":1492,"context_line":"                last_event_id \u003d self._vnf_manager.invoke("},{"line_number":1493,"context_line":"                    vim_connection_info.vim_type,"},{"line_number":1494,"context_line":"                    \u0027scale\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5051879f_ea38a1af","side":"PARENT","line":1491,"updated":"2023-04-25 03:35:59.000000000","message":"ditto","commit_id":"05fe9fa42c3f717e17e2ea8b33f1b78e3e4b63da"},{"author":{"_account_id":32707,"name":"Kenta Fukaya","email":"kenta.fukaya.xv@hco.ntt.co.jp","username":"fukayan"},"change_message_id":"ad9f8cee086051eafd110ba957c4c5a55ff42992","unresolved":true,"context_lines":[{"line_number":1488,"context_line":"                region_name\u003dvim_connection_info.access_info.get(\u0027region_name\u0027)"},{"line_number":1489,"context_line":"            )"},{"line_number":1490,"context_line":"        else:"},{"line_number":1491,"context_line":"            for _ in range(scale_vnf_request.number_of_steps):"},{"line_number":1492,"context_line":"                last_event_id \u003d self._vnf_manager.invoke("},{"line_number":1493,"context_line":"                    vim_connection_info.vim_type,"},{"line_number":1494,"context_line":"                    \u0027scale\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"a1f8b95b_200288d6","side":"PARENT","line":1491,"in_reply_to":"5051879f_ea38a1af","updated":"2023-04-25 06:59:48.000000000","message":"I fixed it on PS5.","commit_id":"05fe9fa42c3f717e17e2ea8b33f1b78e3e4b63da"}]}
