)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"6a3b80d6b51de82c6dca33eca455396f22f24f1d","unresolved":true,"context_lines":[{"line_number":11,"context_line":"  included in VnfLcmOpOcc when the change_vnfpkg v2 API is executed"},{"line_number":12,"context_line":"  finished in COMPLETED."},{"line_number":13,"context_line":"* According to SOL002 specification, vnfcInfo id should be unique"},{"line_number":14,"context_line":"  in the VNF. Currently there is no check uniqueness of vnfcInfo id"},{"line_number":15,"context_line":"  when user set metadata[\u0027VDU_VNFc_mapping\u0027], so implement uniquness"},{"line_number":16,"context_line":"  and format check when VnfInstance creation and Modify VNF"},{"line_number":17,"context_line":"  Information operation."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"c272123d_a9115d67","line":14,"range":{"start_line":14,"start_character":9,"end_line":14,"end_character":12},"updated":"2023-04-21 12:34:08.000000000","message":"nits: VNF-\u003eVNFs","commit_id":"26e174abd9fcef57c9e8bab44dea35d4e0a86bc4"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"aab358403503493905f7b202eb885978d6bac885","unresolved":false,"context_lines":[{"line_number":11,"context_line":"  included in VnfLcmOpOcc when the change_vnfpkg v2 API is executed"},{"line_number":12,"context_line":"  finished in COMPLETED."},{"line_number":13,"context_line":"* According to SOL002 specification, vnfcInfo id should be unique"},{"line_number":14,"context_line":"  in the VNF. Currently there is no check uniqueness of vnfcInfo id"},{"line_number":15,"context_line":"  when user set metadata[\u0027VDU_VNFc_mapping\u0027], so implement uniquness"},{"line_number":16,"context_line":"  and format check when VnfInstance creation and Modify VNF"},{"line_number":17,"context_line":"  Information operation."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fe670194_6e4b0b6e","line":14,"range":{"start_line":14,"start_character":9,"end_line":14,"end_character":12},"in_reply_to":"256dd8d2_2d91ccfc","updated":"2023-06-09 06:03:05.000000000","message":"Done","commit_id":"26e174abd9fcef57c9e8bab44dea35d4e0a86bc4"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"8c9d1f9b89fcb5cbac37fbf5030db7721c65e388","unresolved":true,"context_lines":[{"line_number":11,"context_line":"  included in VnfLcmOpOcc when the change_vnfpkg v2 API is executed"},{"line_number":12,"context_line":"  finished in COMPLETED."},{"line_number":13,"context_line":"* According to SOL002 specification, vnfcInfo id should be unique"},{"line_number":14,"context_line":"  in the VNF. Currently there is no check uniqueness of vnfcInfo id"},{"line_number":15,"context_line":"  when user set metadata[\u0027VDU_VNFc_mapping\u0027], so implement uniquness"},{"line_number":16,"context_line":"  and format check when VnfInstance creation and Modify VNF"},{"line_number":17,"context_line":"  Information operation."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"256dd8d2_2d91ccfc","line":14,"range":{"start_line":14,"start_character":9,"end_line":14,"end_character":12},"in_reply_to":"c272123d_a9115d67","updated":"2023-04-24 01:13:48.000000000","message":"I will fix.","commit_id":"26e174abd9fcef57c9e8bab44dea35d4e0a86bc4"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"6a3b80d6b51de82c6dca33eca455396f22f24f1d","unresolved":true,"context_lines":[{"line_number":12,"context_line":"  finished in COMPLETED."},{"line_number":13,"context_line":"* According to SOL002 specification, vnfcInfo id should be unique"},{"line_number":14,"context_line":"  in the VNF. Currently there is no check uniqueness of vnfcInfo id"},{"line_number":15,"context_line":"  when user set metadata[\u0027VDU_VNFc_mapping\u0027], so implement uniquness"},{"line_number":16,"context_line":"  and format check when VnfInstance creation and Modify VNF"},{"line_number":17,"context_line":"  Information operation."},{"line_number":18,"context_line":"* Fixed to keep the current VnfInstance metadata when vnfdId is"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"034be832_2c9b8366","line":15,"range":{"start_line":15,"start_character":12,"end_line":15,"end_character":15},"updated":"2023-04-21 12:34:08.000000000","message":"nits: set-\u003esets","commit_id":"26e174abd9fcef57c9e8bab44dea35d4e0a86bc4"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"8c9d1f9b89fcb5cbac37fbf5030db7721c65e388","unresolved":true,"context_lines":[{"line_number":12,"context_line":"  finished in COMPLETED."},{"line_number":13,"context_line":"* According to SOL002 specification, vnfcInfo id should be unique"},{"line_number":14,"context_line":"  in the VNF. Currently there is no check uniqueness of vnfcInfo id"},{"line_number":15,"context_line":"  when user set metadata[\u0027VDU_VNFc_mapping\u0027], so implement uniquness"},{"line_number":16,"context_line":"  and format check when VnfInstance creation and Modify VNF"},{"line_number":17,"context_line":"  Information operation."},{"line_number":18,"context_line":"* Fixed to keep the current VnfInstance metadata when vnfdId is"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"54899874_07dd4bb5","line":15,"range":{"start_line":15,"start_character":12,"end_line":15,"end_character":15},"in_reply_to":"034be832_2c9b8366","updated":"2023-04-24 01:13:48.000000000","message":"I will fix.","commit_id":"26e174abd9fcef57c9e8bab44dea35d4e0a86bc4"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"490833683bc16d5d706dbdef984aa87d5f8fc09d","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  finished in COMPLETED."},{"line_number":13,"context_line":"* According to SOL002 specification, vnfcInfo id should be unique"},{"line_number":14,"context_line":"  in the VNF. Currently there is no check uniqueness of vnfcInfo id"},{"line_number":15,"context_line":"  when user set metadata[\u0027VDU_VNFc_mapping\u0027], so implement uniquness"},{"line_number":16,"context_line":"  and format check when VnfInstance creation and Modify VNF"},{"line_number":17,"context_line":"  Information operation."},{"line_number":18,"context_line":"* Fixed to keep the current VnfInstance metadata when vnfdId is"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ea03f1a0_93f98eac","line":15,"range":{"start_line":15,"start_character":12,"end_line":15,"end_character":15},"in_reply_to":"54899874_07dd4bb5","updated":"2023-06-15 19:15:25.000000000","message":"Done","commit_id":"26e174abd9fcef57c9e8bab44dea35d4e0a86bc4"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"6a3b80d6b51de82c6dca33eca455396f22f24f1d","unresolved":true,"context_lines":[{"line_number":13,"context_line":"* According to SOL002 specification, vnfcInfo id should be unique"},{"line_number":14,"context_line":"  in the VNF. Currently there is no check uniqueness of vnfcInfo id"},{"line_number":15,"context_line":"  when user set metadata[\u0027VDU_VNFc_mapping\u0027], so implement uniquness"},{"line_number":16,"context_line":"  and format check when VnfInstance creation and Modify VNF"},{"line_number":17,"context_line":"  Information operation."},{"line_number":18,"context_line":"* Fixed to keep the current VnfInstance metadata when vnfdId is"},{"line_number":19,"context_line":"  changed in Modify VNF Information."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ddfcbea0_fe305e11","line":16,"range":{"start_line":16,"start_character":13,"end_line":16,"end_character":18},"updated":"2023-04-21 12:34:08.000000000","message":"nits: check-\u003echecks","commit_id":"26e174abd9fcef57c9e8bab44dea35d4e0a86bc4"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"aab358403503493905f7b202eb885978d6bac885","unresolved":false,"context_lines":[{"line_number":13,"context_line":"* According to SOL002 specification, vnfcInfo id should be unique"},{"line_number":14,"context_line":"  in the VNF. Currently there is no check uniqueness of vnfcInfo id"},{"line_number":15,"context_line":"  when user set metadata[\u0027VDU_VNFc_mapping\u0027], so implement uniquness"},{"line_number":16,"context_line":"  and format check when VnfInstance creation and Modify VNF"},{"line_number":17,"context_line":"  Information operation."},{"line_number":18,"context_line":"* Fixed to keep the current VnfInstance metadata when vnfdId is"},{"line_number":19,"context_line":"  changed in Modify VNF Information."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fba7bd6c_5edb516e","line":16,"range":{"start_line":16,"start_character":13,"end_line":16,"end_character":18},"in_reply_to":"165668fd_6e998a5d","updated":"2023-06-09 06:03:05.000000000","message":"Done","commit_id":"26e174abd9fcef57c9e8bab44dea35d4e0a86bc4"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"8c9d1f9b89fcb5cbac37fbf5030db7721c65e388","unresolved":true,"context_lines":[{"line_number":13,"context_line":"* According to SOL002 specification, vnfcInfo id should be unique"},{"line_number":14,"context_line":"  in the VNF. Currently there is no check uniqueness of vnfcInfo id"},{"line_number":15,"context_line":"  when user set metadata[\u0027VDU_VNFc_mapping\u0027], so implement uniquness"},{"line_number":16,"context_line":"  and format check when VnfInstance creation and Modify VNF"},{"line_number":17,"context_line":"  Information operation."},{"line_number":18,"context_line":"* Fixed to keep the current VnfInstance metadata when vnfdId is"},{"line_number":19,"context_line":"  changed in Modify VNF Information."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"165668fd_6e998a5d","line":16,"range":{"start_line":16,"start_character":13,"end_line":16,"end_character":18},"in_reply_to":"ddfcbea0_fe305e11","updated":"2023-04-24 01:13:48.000000000","message":"I will fix.","commit_id":"26e174abd9fcef57c9e8bab44dea35d4e0a86bc4"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"95168e5e13c8f97731f266b6471865e18fcc1624","unresolved":true,"context_lines":[{"line_number":12,"context_line":"  finished in COMPLETED."},{"line_number":13,"context_line":"* According to SOL002 specification, vnfcInfo id should be unique"},{"line_number":14,"context_line":"  in the VNFs. Currently there is no check uniqueness of vnfcInfo id"},{"line_number":15,"context_line":"  when user sets metadata[\u0027VDU_VNFc_mapping\u0027], so implement uniquness"},{"line_number":16,"context_line":"  and format checks when VnfInstance creation and Modify VNF"},{"line_number":17,"context_line":"  Information operation."},{"line_number":18,"context_line":"* Fixed to keep the current VnfInstance metadata when vnfdId is"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3c2eb27b_633effa0","line":15,"updated":"2023-05-22 09:20:52.000000000","message":"typo: uniquness -\u003e uniqueness","commit_id":"98a8574462f57011b6d8b0d5681ace3e841d87fc"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"0e53f8c91ef8a941c7a131f17efa0493f8a463eb","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  finished in COMPLETED."},{"line_number":13,"context_line":"* According to SOL002 specification, vnfcInfo id should be unique"},{"line_number":14,"context_line":"  in the VNFs. Currently there is no check uniqueness of vnfcInfo id"},{"line_number":15,"context_line":"  when user sets metadata[\u0027VDU_VNFc_mapping\u0027], so implement uniquness"},{"line_number":16,"context_line":"  and format checks when VnfInstance creation and Modify VNF"},{"line_number":17,"context_line":"  Information operation."},{"line_number":18,"context_line":"* Fixed to keep the current VnfInstance metadata when vnfdId is"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"0f45460e_115e8fab","line":15,"in_reply_to":"0dec479f_89739dff","updated":"2023-05-26 00:06:25.000000000","message":"Done","commit_id":"98a8574462f57011b6d8b0d5681ace3e841d87fc"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"7c1893e684e03f8d248739c42049aa45086a0f05","unresolved":true,"context_lines":[{"line_number":12,"context_line":"  finished in COMPLETED."},{"line_number":13,"context_line":"* According to SOL002 specification, vnfcInfo id should be unique"},{"line_number":14,"context_line":"  in the VNFs. Currently there is no check uniqueness of vnfcInfo id"},{"line_number":15,"context_line":"  when user sets metadata[\u0027VDU_VNFc_mapping\u0027], so implement uniquness"},{"line_number":16,"context_line":"  and format checks when VnfInstance creation and Modify VNF"},{"line_number":17,"context_line":"  Information operation."},{"line_number":18,"context_line":"* Fixed to keep the current VnfInstance metadata when vnfdId is"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"0dec479f_89739dff","line":15,"in_reply_to":"3c2eb27b_633effa0","updated":"2023-05-24 01:50:02.000000000","message":"I will fix.","commit_id":"98a8574462f57011b6d8b0d5681ace3e841d87fc"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"74df0e31b96d080c788597ae1ec1d26694c42fc9","unresolved":true,"context_lines":[{"line_number":15,"context_line":"  when user sets metadata[\u0027VDU_VNFc_mapping\u0027], so implement uniqueness"},{"line_number":16,"context_line":"  and format checks when VnfInstance creation and Modify VNF"},{"line_number":17,"context_line":"  Information operation."},{"line_number":18,"context_line":"* Fixed to keep the current VnfInstance \"vnfConfigurableProperties\""},{"line_number":19,"context_line":"  \"extensions\" \"metadata\" when vnfdId is changed in"},{"line_number":20,"context_line":"  Modify VNF Information."},{"line_number":21,"context_line":"  This is according to specification of change_vnfpkg v2 API."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"8b054425_5559ab08","line":18,"updated":"2023-06-14 00:05:47.000000000","message":"nit: Fixed -\u003e Fix\nnit: \"vnfConfigurableProperties\" -\u003e \"vnfConfigurableProperties\",","commit_id":"52c14278822760fd4dc5cd060373e19d25cff653"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"e5e75af5eca80febabddef9928a8b1f9932b74c5","unresolved":true,"context_lines":[{"line_number":15,"context_line":"  when user sets metadata[\u0027VDU_VNFc_mapping\u0027], so implement uniqueness"},{"line_number":16,"context_line":"  and format checks when VnfInstance creation and Modify VNF"},{"line_number":17,"context_line":"  Information operation."},{"line_number":18,"context_line":"* Fixed to keep the current VnfInstance \"vnfConfigurableProperties\""},{"line_number":19,"context_line":"  \"extensions\" \"metadata\" when vnfdId is changed in"},{"line_number":20,"context_line":"  Modify VNF Information."},{"line_number":21,"context_line":"  This is according to specification of change_vnfpkg v2 API."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"92b00cc7_4e098650","line":18,"in_reply_to":"8b054425_5559ab08","updated":"2023-06-14 04:44:22.000000000","message":"I will fix.","commit_id":"52c14278822760fd4dc5cd060373e19d25cff653"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"1c997ed2562a3d1acab3c1329480992cd25795bc","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  when user sets metadata[\u0027VDU_VNFc_mapping\u0027], so implement uniqueness"},{"line_number":16,"context_line":"  and format checks when VnfInstance creation and Modify VNF"},{"line_number":17,"context_line":"  Information operation."},{"line_number":18,"context_line":"* Fixed to keep the current VnfInstance \"vnfConfigurableProperties\""},{"line_number":19,"context_line":"  \"extensions\" \"metadata\" when vnfdId is changed in"},{"line_number":20,"context_line":"  Modify VNF Information."},{"line_number":21,"context_line":"  This is according to specification of change_vnfpkg v2 API."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"26dc89cb_0ac63723","line":18,"in_reply_to":"92b00cc7_4e098650","updated":"2023-06-15 00:45:06.000000000","message":"Done","commit_id":"52c14278822760fd4dc5cd060373e19d25cff653"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"74df0e31b96d080c788597ae1ec1d26694c42fc9","unresolved":true,"context_lines":[{"line_number":16,"context_line":"  and format checks when VnfInstance creation and Modify VNF"},{"line_number":17,"context_line":"  Information operation."},{"line_number":18,"context_line":"* Fixed to keep the current VnfInstance \"vnfConfigurableProperties\""},{"line_number":19,"context_line":"  \"extensions\" \"metadata\" when vnfdId is changed in"},{"line_number":20,"context_line":"  Modify VNF Information."},{"line_number":21,"context_line":"  This is according to specification of change_vnfpkg v2 API."},{"line_number":22,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3e5478bd_114d68b5","line":19,"updated":"2023-06-14 00:05:47.000000000","message":"nit: \"extensions\" \"metadata\" -\u003e \"extensions\", and \"metadata\"","commit_id":"52c14278822760fd4dc5cd060373e19d25cff653"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"e5e75af5eca80febabddef9928a8b1f9932b74c5","unresolved":true,"context_lines":[{"line_number":16,"context_line":"  and format checks when VnfInstance creation and Modify VNF"},{"line_number":17,"context_line":"  Information operation."},{"line_number":18,"context_line":"* Fixed to keep the current VnfInstance \"vnfConfigurableProperties\""},{"line_number":19,"context_line":"  \"extensions\" \"metadata\" when vnfdId is changed in"},{"line_number":20,"context_line":"  Modify VNF Information."},{"line_number":21,"context_line":"  This is according to specification of change_vnfpkg v2 API."},{"line_number":22,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"f02ee137_f3b8d1d6","line":19,"in_reply_to":"3e5478bd_114d68b5","updated":"2023-06-14 04:44:22.000000000","message":"I will fix.","commit_id":"52c14278822760fd4dc5cd060373e19d25cff653"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"1c997ed2562a3d1acab3c1329480992cd25795bc","unresolved":false,"context_lines":[{"line_number":16,"context_line":"  and format checks when VnfInstance creation and Modify VNF"},{"line_number":17,"context_line":"  Information operation."},{"line_number":18,"context_line":"* Fixed to keep the current VnfInstance \"vnfConfigurableProperties\""},{"line_number":19,"context_line":"  \"extensions\" \"metadata\" when vnfdId is changed in"},{"line_number":20,"context_line":"  Modify VNF Information."},{"line_number":21,"context_line":"  This is according to specification of change_vnfpkg v2 API."},{"line_number":22,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"1ddf6ebb_8082283e","line":19,"in_reply_to":"f02ee137_f3b8d1d6","updated":"2023-06-15 00:45:06.000000000","message":"Done","commit_id":"52c14278822760fd4dc5cd060373e19d25cff653"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"8c9d1f9b89fcb5cbac37fbf5030db7721c65e388","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0937f2fb_0ac30923","updated":"2023-04-24 01:13:48.000000000","message":"Thank you for the review.","commit_id":"26e174abd9fcef57c9e8bab44dea35d4e0a86bc4"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"6a3b80d6b51de82c6dca33eca455396f22f24f1d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7a60a125_e8129261","updated":"2023-04-21 12:34:08.000000000","message":"Thanks for your patch. Please kindly check my comments.","commit_id":"26e174abd9fcef57c9e8bab44dea35d4e0a86bc4"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"7c1893e684e03f8d248739c42049aa45086a0f05","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9066131c_6fa3d66d","updated":"2023-05-24 01:50:02.000000000","message":"Thank you for the review.","commit_id":"98a8574462f57011b6d8b0d5681ace3e841d87fc"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"645522a7aa663829ab0cf07c6d1a85b44370f9bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"aeebdc7a_4c1c1b15","updated":"2023-05-25 06:49:21.000000000","message":"Thank you for your comment.","commit_id":"98a8574462f57011b6d8b0d5681ace3e841d87fc"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"95168e5e13c8f97731f266b6471865e18fcc1624","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9e03c414_e5220846","updated":"2023-05-22 09:20:52.000000000","message":"When actually setting vnfcInfo.id, is it okay to not check duplication?\nAlthough it is a rare case, if the id that is actually set in vnfcInfo.id is not registered in metadata, it is possible to duplicate and register it as a new different vnfcInfo.id.","commit_id":"98a8574462f57011b6d8b0d5681ace3e841d87fc"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"645522a7aa663829ab0cf07c6d1a85b44370f9bf","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d4c2bd6c_370869e6","in_reply_to":"51590d3f_ed2eda83","updated":"2023-05-25 06:49:21.000000000","message":"Sorry, I didn\u0027t understand your intention.\nSince that is a rare case, this patch does not support it.\nBut if vnfcResourceInfoId is unchange, the current vnfcInfo.id is used,\nso fix it to be set from the metadata.","commit_id":"98a8574462f57011b6d8b0d5681ace3e841d87fc"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"9c401589efdc02f300680b1ff1276fecda95ea4e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"51590d3f_ed2eda83","in_reply_to":"85a50bbd_707bd7a4","updated":"2023-05-24 07:21:22.000000000","message":"This comment is intended to confirm whether it is not necessary to check vnfcInfo.id against each other when setting vnfcInfo.id.\nSince metadata can be freely set by the user, it is also possible to set the vnfcInfo.id that has already been set by passing the validation check. (If it is not set in metadata, operation error, etc.)\nIn this case, the bug below does not resolve...\nhttps://bugs.launchpad.net/tacker/+bug/2015944\nIs it correct to understand that this patch does not take care of these because they are rare cases?","commit_id":"98a8574462f57011b6d8b0d5681ace3e841d87fc"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"7c1893e684e03f8d248739c42049aa45086a0f05","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"85a50bbd_707bd7a4","in_reply_to":"9e03c414_e5220846","updated":"2023-05-24 01:50:02.000000000","message":"I don\u0027t think it\u0027s necessary to check duplication between the value specified in metadata VDU_VNFc_mapping and vnfcInfo.id because instantiatedVnfInfo is recreated after heat processing in API and set in vnfcInfo.id.","commit_id":"98a8574462f57011b6d8b0d5681ace3e841d87fc"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"74df0e31b96d080c788597ae1ec1d26694c42fc9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2469ec77_12fc97f1","in_reply_to":"d4c2bd6c_370869e6","updated":"2023-06-14 00:05:47.000000000","message":"Done","commit_id":"98a8574462f57011b6d8b0d5681ace3e841d87fc"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"cf5292eedf6f0d62a3e94e80a94911b3feb9ad0a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"30837f0f_13d6b853","updated":"2023-05-26 06:25:05.000000000","message":"Thank you for the review.","commit_id":"eba82dec8a0ff316476d5fe865d0a5952abcae51"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"11a6aaaa7e15df24e22ca8371fec43c6702e4130","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"08975379_0a12d1c2","updated":"2023-06-12 00:08:54.000000000","message":"Thank you for the review.","commit_id":"ecafe0ae3c4fba975bbdcd514a821d21b21ee4be"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"aab358403503493905f7b202eb885978d6bac885","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"5492cfb2_231d1032","updated":"2023-06-09 06:03:05.000000000","message":"Thanks for your re-work. Please kindly check my additional comment.","commit_id":"ecafe0ae3c4fba975bbdcd514a821d21b21ee4be"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"e5e75af5eca80febabddef9928a8b1f9932b74c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"669f08d5_a2bc32b6","updated":"2023-06-14 04:44:22.000000000","message":"Thak you for the review.","commit_id":"52c14278822760fd4dc5cd060373e19d25cff653"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"7b167f7b15b2002aa2e66fe9e43190fba2ddd2a4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"87254a21_c7a84e59","updated":"2023-06-13 05:18:40.000000000","message":"recheck infra-failure","commit_id":"52c14278822760fd4dc5cd060373e19d25cff653"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"1c997ed2562a3d1acab3c1329480992cd25795bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"fbaa888c_83802cf9","updated":"2023-06-15 00:45:06.000000000","message":"LGTM","commit_id":"d530aadbc3f33d1213cde83232a780dba97b4be6"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"1c74c46455afe07567f412e62c32eff14ef57781","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"855410be_8d1db893","updated":"2023-06-15 19:16:10.000000000","message":"Please kindly review the patch, thanks.","commit_id":"d530aadbc3f33d1213cde83232a780dba97b4be6"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"17d0e0d1ce24189fb0bf68438f8e21d3ee69c6fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"18b1eb03_a3feb0cf","updated":"2023-06-28 04:31:09.000000000","message":"Thank you for the review.","commit_id":"d530aadbc3f33d1213cde83232a780dba97b4be6"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"490833683bc16d5d706dbdef984aa87d5f8fc09d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"7833706b_b4ceadf4","updated":"2023-06-15 19:15:25.000000000","message":"Thanks for your re-work! LGTM.","commit_id":"d530aadbc3f33d1213cde83232a780dba97b4be6"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"92102ea36e8f768328ff6f8ad5a22a95701e85b5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"04e35d41_9e678d98","updated":"2023-07-31 14:56:38.000000000","message":"LGTM, thanks for your patch.","commit_id":"f5599a3e575ed42bc1d4e7dff688eb19dce22d90"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"b66c598e212906e95d511c9e00826bbd882e38c2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"bd05b6ce_5ff0cfc2","updated":"2023-06-28 22:31:06.000000000","message":"recheck infra-failure","commit_id":"f5599a3e575ed42bc1d4e7dff688eb19dce22d90"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"5e8a3b720eecf2702873e77425a865b5a7860d20","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"d279dda8_3c91ba9a","updated":"2023-07-09 22:55:37.000000000","message":"recheck infra-failure","commit_id":"f5599a3e575ed42bc1d4e7dff688eb19dce22d90"}],"tacker/sol_refactored/common/lcm_op_occ_utils.py":[{"author":{"_account_id":31668,"deleted":true},"change_message_id":"0e53f8c91ef8a941c7a131f17efa0493f8a463eb","unresolved":true,"context_lines":[{"line_number":301,"context_line":""},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"def _check_modification_inst(obj, inst_saved, inst):"},{"line_number":304,"context_line":"    obj.vnfdId \u003d inst.vnfdId"},{"line_number":305,"context_line":"    if inst_saved.vnfProvider !\u003d inst.vnfProvider:"},{"line_number":306,"context_line":"        obj.vnfProvider \u003d inst.vnfProvider"},{"line_number":307,"context_line":"    if inst_saved.vnfProductName !\u003d inst.vnfProductName:"}],"source_content_type":"text/x-python","patch_set":5,"id":"27869678_3bb5dd7c","line":304,"updated":"2023-05-26 00:06:25.000000000","message":"As defined in SOL003 v3.3.1 5.5.3.21, the Cardinality of ModificationsTriggeredByVnfPkgChange.vnfdId is \"0..1\".\nIt seems to always be set in Tacker, is there no problem?","commit_id":"eba82dec8a0ff316476d5fe865d0a5952abcae51"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"cf5292eedf6f0d62a3e94e80a94911b3feb9ad0a","unresolved":true,"context_lines":[{"line_number":301,"context_line":""},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"def _check_modification_inst(obj, inst_saved, inst):"},{"line_number":304,"context_line":"    obj.vnfdId \u003d inst.vnfdId"},{"line_number":305,"context_line":"    if inst_saved.vnfProvider !\u003d inst.vnfProvider:"},{"line_number":306,"context_line":"        obj.vnfProvider \u003d inst.vnfProvider"},{"line_number":307,"context_line":"    if inst_saved.vnfProductName !\u003d inst.vnfProductName:"}],"source_content_type":"text/x-python","patch_set":5,"id":"56a33cfc_17e1a79f","line":304,"in_reply_to":"27869678_3bb5dd7c","updated":"2023-05-26 06:25:05.000000000","message":"Since the vnfdId is usually different in ChangeCurrentVnfPkg, I don\u0027t think this code should be changed.","commit_id":"eba82dec8a0ff316476d5fe865d0a5952abcae51"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"74df0e31b96d080c788597ae1ec1d26694c42fc9","unresolved":false,"context_lines":[{"line_number":301,"context_line":""},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"def _check_modification_inst(obj, inst_saved, inst):"},{"line_number":304,"context_line":"    obj.vnfdId \u003d inst.vnfdId"},{"line_number":305,"context_line":"    if inst_saved.vnfProvider !\u003d inst.vnfProvider:"},{"line_number":306,"context_line":"        obj.vnfProvider \u003d inst.vnfProvider"},{"line_number":307,"context_line":"    if inst_saved.vnfProductName !\u003d inst.vnfProductName:"}],"source_content_type":"text/x-python","patch_set":5,"id":"ac9b0201_031a26ca","line":304,"in_reply_to":"56a33cfc_17e1a79f","updated":"2023-06-14 00:05:47.000000000","message":"I have confirmed that the following is also stated in the SOL.\n```\nIf present, this attribute signals the new value of the\n\"vnfdId\" attribute in \"VnfInstance\".\n```\n\nI understand that Tacker has a policy of not distinguishing whether the `new value` is the same Id or a different Id.","commit_id":"eba82dec8a0ff316476d5fe865d0a5952abcae51"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"85d1a4623475b62df5e3c6444e626e57e3c090a9","unresolved":true,"context_lines":[{"line_number":369,"context_line":""},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"def _create_modifications_triggered_by_vnfpkg_change(lcmocc, inst_saved, inst):"},{"line_number":372,"context_line":"    modifications_vnfpkg_change \u003d ("},{"line_number":373,"context_line":"        objects.ModificationsTriggeredByVnfPkgChangeV2())"},{"line_number":374,"context_line":"    _check_modification_inst(modifications_vnfpkg_change, inst_saved, inst)"},{"line_number":375,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"d9e12cb2_9439ab7a","line":372,"range":{"start_line":372,"start_character":4,"end_line":372,"end_character":35},"updated":"2023-06-27 11:28:32.000000000","message":"nit: A shorter name is enough for such a case. It\u0027s also no need to use useless parentheses `()` if you use short name.","commit_id":"d530aadbc3f33d1213cde83232a780dba97b4be6"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"17d0e0d1ce24189fb0bf68438f8e21d3ee69c6fd","unresolved":true,"context_lines":[{"line_number":369,"context_line":""},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"def _create_modifications_triggered_by_vnfpkg_change(lcmocc, inst_saved, inst):"},{"line_number":372,"context_line":"    modifications_vnfpkg_change \u003d ("},{"line_number":373,"context_line":"        objects.ModificationsTriggeredByVnfPkgChangeV2())"},{"line_number":374,"context_line":"    _check_modification_inst(modifications_vnfpkg_change, inst_saved, inst)"},{"line_number":375,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"fe54a1ad_7ce06605","line":372,"range":{"start_line":372,"start_character":4,"end_line":372,"end_character":35},"in_reply_to":"d9e12cb2_9439ab7a","updated":"2023-06-28 04:31:09.000000000","message":"I will fix.","commit_id":"d530aadbc3f33d1213cde83232a780dba97b4be6"}],"tacker/sol_refactored/common/vnf_instance_utils.py":[{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"6a3b80d6b51de82c6dca33eca455396f22f24f1d","unresolved":true,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"def check_metadata(metadata):"},{"line_number":87,"context_line":"    # Check VnfInstance.metadata format"},{"line_number":88,"context_line":"    # NOTE: This method checks keys which tacker supports originally."},{"line_number":89,"context_line":"    # The key supporting is only \u0027VDU_VNFc_mapping\u0027 for the moment."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    _vdu_vnfc_mapping \u003d {"}],"source_content_type":"text/x-python","patch_set":2,"id":"69bde505_19673431","line":88,"range":{"start_line":88,"start_character":42,"end_line":88,"end_character":48},"updated":"2023-04-21 12:34:08.000000000","message":"nits: tacker-\u003eTacker","commit_id":"26e174abd9fcef57c9e8bab44dea35d4e0a86bc4"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"8c9d1f9b89fcb5cbac37fbf5030db7721c65e388","unresolved":true,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"def check_metadata(metadata):"},{"line_number":87,"context_line":"    # Check VnfInstance.metadata format"},{"line_number":88,"context_line":"    # NOTE: This method checks keys which tacker supports originally."},{"line_number":89,"context_line":"    # The key supporting is only \u0027VDU_VNFc_mapping\u0027 for the moment."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    _vdu_vnfc_mapping \u003d {"}],"source_content_type":"text/x-python","patch_set":2,"id":"ed87390d_1bbfec5a","line":88,"range":{"start_line":88,"start_character":42,"end_line":88,"end_character":48},"in_reply_to":"69bde505_19673431","updated":"2023-04-24 01:13:48.000000000","message":"I will fix.","commit_id":"26e174abd9fcef57c9e8bab44dea35d4e0a86bc4"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"aab358403503493905f7b202eb885978d6bac885","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"def check_metadata(metadata):"},{"line_number":87,"context_line":"    # Check VnfInstance.metadata format"},{"line_number":88,"context_line":"    # NOTE: This method checks keys which tacker supports originally."},{"line_number":89,"context_line":"    # The key supporting is only \u0027VDU_VNFc_mapping\u0027 for the moment."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    _vdu_vnfc_mapping \u003d {"}],"source_content_type":"text/x-python","patch_set":2,"id":"21ffcc15_fcf4142a","line":88,"range":{"start_line":88,"start_character":42,"end_line":88,"end_character":48},"in_reply_to":"ed87390d_1bbfec5a","updated":"2023-06-09 06:03:05.000000000","message":"Done","commit_id":"26e174abd9fcef57c9e8bab44dea35d4e0a86bc4"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"85d1a4623475b62df5e3c6444e626e57e3c090a9","unresolved":true,"context_lines":[{"line_number":83,"context_line":"        return vim_info"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"def check_metadata(metadata):"},{"line_number":87,"context_line":"    # Check VnfInstance.metadata format"},{"line_number":88,"context_line":"    # NOTE: This method checks keys which Tacker supports originally."},{"line_number":89,"context_line":"    # The key supporting is only \u0027VDU_VNFc_mapping\u0027 for the moment."}],"source_content_type":"text/x-python","patch_set":8,"id":"9bf6a14a_e83ca079","line":86,"range":{"start_line":86,"start_character":4,"end_line":86,"end_character":18},"updated":"2023-06-27 11:28:32.000000000","message":"IMO, it seems better to use more specific name, `check_metadata_format` in this case. What do you think?","commit_id":"d530aadbc3f33d1213cde83232a780dba97b4be6"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"17d0e0d1ce24189fb0bf68438f8e21d3ee69c6fd","unresolved":true,"context_lines":[{"line_number":83,"context_line":"        return vim_info"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"def check_metadata(metadata):"},{"line_number":87,"context_line":"    # Check VnfInstance.metadata format"},{"line_number":88,"context_line":"    # NOTE: This method checks keys which Tacker supports originally."},{"line_number":89,"context_line":"    # The key supporting is only \u0027VDU_VNFc_mapping\u0027 for the moment."}],"source_content_type":"text/x-python","patch_set":8,"id":"7c58d0f5_8e04406a","line":86,"range":{"start_line":86,"start_character":4,"end_line":86,"end_character":18},"in_reply_to":"9bf6a14a_e83ca079","updated":"2023-06-28 04:31:09.000000000","message":"I think it is better. I will fix it.","commit_id":"d530aadbc3f33d1213cde83232a780dba97b4be6"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"85d1a4623475b62df5e3c6444e626e57e3c090a9","unresolved":true,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"def check_metadata(metadata):"},{"line_number":87,"context_line":"    # Check VnfInstance.metadata format"},{"line_number":88,"context_line":"    # NOTE: This method checks keys which Tacker supports originally."},{"line_number":89,"context_line":"    # The key supporting is only \u0027VDU_VNFc_mapping\u0027 for the moment."},{"line_number":90,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"41576525_fbcd5b71","line":87,"updated":"2023-06-27 11:28:32.000000000","message":"Can you describe it as a docstring for such a public method?","commit_id":"d530aadbc3f33d1213cde83232a780dba97b4be6"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"17d0e0d1ce24189fb0bf68438f8e21d3ee69c6fd","unresolved":true,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"def check_metadata(metadata):"},{"line_number":87,"context_line":"    # Check VnfInstance.metadata format"},{"line_number":88,"context_line":"    # NOTE: This method checks keys which Tacker supports originally."},{"line_number":89,"context_line":"    # The key supporting is only \u0027VDU_VNFc_mapping\u0027 for the moment."},{"line_number":90,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"08d5e9c9_ec7d2cd4","line":87,"in_reply_to":"41576525_fbcd5b71","updated":"2023-06-28 04:31:09.000000000","message":"I understand. I will fix.","commit_id":"d530aadbc3f33d1213cde83232a780dba97b4be6"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"85d1a4623475b62df5e3c6444e626e57e3c090a9","unresolved":true,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"def check_metadata(metadata):"},{"line_number":87,"context_line":"    # Check VnfInstance.metadata format"},{"line_number":88,"context_line":"    # NOTE: This method checks keys which Tacker supports originally."},{"line_number":89,"context_line":"    # The key supporting is only \u0027VDU_VNFc_mapping\u0027 for the moment."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    _vdu_vnfc_mapping \u003d {"}],"source_content_type":"text/x-python","patch_set":8,"id":"45d4d097_a7ac361f","line":88,"range":{"start_line":88,"start_character":12,"end_line":88,"end_character":69},"updated":"2023-06-27 11:28:32.000000000","message":"Is it needed actually?","commit_id":"d530aadbc3f33d1213cde83232a780dba97b4be6"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"17d0e0d1ce24189fb0bf68438f8e21d3ee69c6fd","unresolved":true,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"def check_metadata(metadata):"},{"line_number":87,"context_line":"    # Check VnfInstance.metadata format"},{"line_number":88,"context_line":"    # NOTE: This method checks keys which Tacker supports originally."},{"line_number":89,"context_line":"    # The key supporting is only \u0027VDU_VNFc_mapping\u0027 for the moment."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    _vdu_vnfc_mapping \u003d {"}],"source_content_type":"text/x-python","patch_set":8,"id":"997176a2_33b7ad18","line":88,"range":{"start_line":88,"start_character":12,"end_line":88,"end_character":69},"in_reply_to":"45d4d097_a7ac361f","updated":"2023-06-28 04:31:09.000000000","message":"I think this comment is necessary, because \"VDU_VNFc_mapping\" is a key not in the SOL spec.","commit_id":"d530aadbc3f33d1213cde83232a780dba97b4be6"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"85d1a4623475b62df5e3c6444e626e57e3c090a9","unresolved":true,"context_lines":[{"line_number":99,"context_line":"    }"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    if \u0027VDU_VNFc_mapping\u0027 in metadata:"},{"line_number":102,"context_line":"        schema_validator \u003d validator.SolSchemaValidator(_vdu_vnfc_mapping)"},{"line_number":103,"context_line":"        try:"},{"line_number":104,"context_line":"            schema_validator.validate(metadata[\u0027VDU_VNFc_mapping\u0027])"},{"line_number":105,"context_line":"        except sol_ex.SolValidationError as ex:"}],"source_content_type":"text/x-python","patch_set":8,"id":"23d7a7b0_df308293","line":102,"updated":"2023-06-27 11:28:32.000000000","message":"No need to catch an exception from this validation? I think it can raise `tacker.common.exceptions.ValidationError` if the given json is invalid.","commit_id":"d530aadbc3f33d1213cde83232a780dba97b4be6"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"17d0e0d1ce24189fb0bf68438f8e21d3ee69c6fd","unresolved":true,"context_lines":[{"line_number":99,"context_line":"    }"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    if \u0027VDU_VNFc_mapping\u0027 in metadata:"},{"line_number":102,"context_line":"        schema_validator \u003d validator.SolSchemaValidator(_vdu_vnfc_mapping)"},{"line_number":103,"context_line":"        try:"},{"line_number":104,"context_line":"            schema_validator.validate(metadata[\u0027VDU_VNFc_mapping\u0027])"},{"line_number":105,"context_line":"        except sol_ex.SolValidationError as ex:"}],"source_content_type":"text/x-python","patch_set":8,"id":"311d382c_c50c6b55","line":102,"in_reply_to":"23d7a7b0_df308293","updated":"2023-06-28 04:31:09.000000000","message":"It doesn\u0027t need to catch exception, so it only changes the detail.\nI will fix.","commit_id":"d530aadbc3f33d1213cde83232a780dba97b4be6"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"85d1a4623475b62df5e3c6444e626e57e3c090a9","unresolved":true,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        if len(all_vnfc_info_ids) \u003e len(set(all_vnfc_info_ids)):"},{"line_number":114,"context_line":"            raise sol_ex.SolValidationError("},{"line_number":115,"context_line":"                detail\u003d\"Duplicate vnfcInfo ids found in \""},{"line_number":116,"context_line":"                \"metadata[\u0027VDU_VNFc_mapping\u0027].\")"}],"source_content_type":"text/x-python","patch_set":8,"id":"ce91e60a_2f515ba0","line":116,"range":{"start_line":115,"start_character":24,"end_line":116,"end_character":45},"updated":"2023-06-27 11:28:32.000000000","message":"nit: Why don\u0027t you show duplicated ID? Anyway, \"Duplicated vnfcInfo ids ...\" is more exactly.","commit_id":"d530aadbc3f33d1213cde83232a780dba97b4be6"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"17d0e0d1ce24189fb0bf68438f8e21d3ee69c6fd","unresolved":true,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        if len(all_vnfc_info_ids) \u003e len(set(all_vnfc_info_ids)):"},{"line_number":114,"context_line":"            raise sol_ex.SolValidationError("},{"line_number":115,"context_line":"                detail\u003d\"Duplicate vnfcInfo ids found in \""},{"line_number":116,"context_line":"                \"metadata[\u0027VDU_VNFc_mapping\u0027].\")"}],"source_content_type":"text/x-python","patch_set":8,"id":"56c97710_0f6891c6","line":116,"range":{"start_line":115,"start_character":24,"end_line":116,"end_character":45},"in_reply_to":"ce91e60a_2f515ba0","updated":"2023-06-28 04:31:09.000000000","message":"I will fix the detail. I don\u0027t think it is necessary because it is hard to display the duplicated ID.","commit_id":"d530aadbc3f33d1213cde83232a780dba97b4be6"}],"tacker/sol_refactored/conductor/vnflcm_driver_v2.py":[{"author":{"_account_id":31668,"deleted":true},"change_message_id":"0e53f8c91ef8a941c7a131f17efa0493f8a463eb","unresolved":true,"context_lines":[{"line_number":1138,"context_line":""},{"line_number":1139,"context_line":"        attrs \u003d [\u0027vnfConfigurableProperties\u0027, \u0027extensions\u0027]"},{"line_number":1140,"context_line":"        for attr in attrs:"},{"line_number":1141,"context_line":"            self._modify_from_req(inst, req, attr)"},{"line_number":1142,"context_line":""},{"line_number":1143,"context_line":"    def change_vnfpkg_rollback("},{"line_number":1144,"context_line":"            self, context, lcmocc, inst, grant_req, grant, vnfd):"}],"source_content_type":"text/x-python","patch_set":5,"id":"26137b94_51dab50f","line":1141,"updated":"2023-05-26 00:06:25.000000000","message":"Is it okay if the comments below are not fixed?\n* https://opendev.org/openstack/tacker/src/branch/stable/2023.1/tacker/sol_refactored/objects/v2/change_current_vnf_pkg_request.py#L38-L39\n* https://opendev.org/openstack/tacker/src/branch/stable/2023.1/tacker/sol_refactored/objects/v2/change_current_vnf_pkg_request.py#L41-L42","commit_id":"eba82dec8a0ff316476d5fe865d0a5952abcae51"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"cf5292eedf6f0d62a3e94e80a94911b3feb9ad0a","unresolved":true,"context_lines":[{"line_number":1138,"context_line":""},{"line_number":1139,"context_line":"        attrs \u003d [\u0027vnfConfigurableProperties\u0027, \u0027extensions\u0027]"},{"line_number":1140,"context_line":"        for attr in attrs:"},{"line_number":1141,"context_line":"            self._modify_from_req(inst, req, attr)"},{"line_number":1142,"context_line":""},{"line_number":1143,"context_line":"    def change_vnfpkg_rollback("},{"line_number":1144,"context_line":"            self, context, lcmocc, inst, grant_req, grant, vnfd):"}],"source_content_type":"text/x-python","patch_set":5,"id":"aa17eeb7_c0592d75","line":1141,"in_reply_to":"26137b94_51dab50f","updated":"2023-05-26 06:25:05.000000000","message":"As this comment is unnecessary, I will delete it.","commit_id":"eba82dec8a0ff316476d5fe865d0a5952abcae51"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"74df0e31b96d080c788597ae1ec1d26694c42fc9","unresolved":false,"context_lines":[{"line_number":1138,"context_line":""},{"line_number":1139,"context_line":"        attrs \u003d [\u0027vnfConfigurableProperties\u0027, \u0027extensions\u0027]"},{"line_number":1140,"context_line":"        for attr in attrs:"},{"line_number":1141,"context_line":"            self._modify_from_req(inst, req, attr)"},{"line_number":1142,"context_line":""},{"line_number":1143,"context_line":"    def change_vnfpkg_rollback("},{"line_number":1144,"context_line":"            self, context, lcmocc, inst, grant_req, grant, vnfd):"}],"source_content_type":"text/x-python","patch_set":5,"id":"f3acfff8_a77a0dd5","line":1141,"in_reply_to":"aa17eeb7_c0592d75","updated":"2023-06-14 00:05:47.000000000","message":"Done","commit_id":"eba82dec8a0ff316476d5fe865d0a5952abcae51"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"aab358403503493905f7b202eb885978d6bac885","unresolved":true,"context_lines":[{"line_number":794,"context_line":"        inst.metadata \u003d inst_utils.json_merge_patch("},{"line_number":795,"context_line":"            base, vnfd_prop.get(\u0027metadata\u0027, {}))"},{"line_number":796,"context_line":""},{"line_number":797,"context_line":"        attrs \u003d [\u0027vnfConfigurableProperties\u0027, \u0027extensions\u0027]"},{"line_number":798,"context_line":"        for attr in attrs:"},{"line_number":799,"context_line":"            self._modify_from_vnfd_prop(inst, vnfd_prop, attr)"},{"line_number":800,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"2d46ae4e_21496a17","line":797,"updated":"2023-06-09 06:03:05.000000000","message":"Regarding `vnfConfigurableProperties` and `extensions`, based on the SOL003 v3.3.1 5.4.11a.3.1 POST and Tacker\u0027s implementation, I think that the information in the old (source) VNF should be carried over (JSON Merge Patch) to the new (dest) VNF.\nWhat do you think?","commit_id":"ecafe0ae3c4fba975bbdcd514a821d21b21ee4be"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"11a6aaaa7e15df24e22ca8371fec43c6702e4130","unresolved":true,"context_lines":[{"line_number":794,"context_line":"        inst.metadata \u003d inst_utils.json_merge_patch("},{"line_number":795,"context_line":"            base, vnfd_prop.get(\u0027metadata\u0027, {}))"},{"line_number":796,"context_line":""},{"line_number":797,"context_line":"        attrs \u003d [\u0027vnfConfigurableProperties\u0027, \u0027extensions\u0027]"},{"line_number":798,"context_line":"        for attr in attrs:"},{"line_number":799,"context_line":"            self._modify_from_vnfd_prop(inst, vnfd_prop, attr)"},{"line_number":800,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9c3dd225_38729ce9","line":797,"in_reply_to":"2d46ae4e_21496a17","updated":"2023-06-12 00:08:54.000000000","message":"I checked the SOL003 v3.3.1 5.4.11a.3.1. I also think I should keep the source `vnfConfigurableProperties` and `extensions`, and merge it with the dest VNFD.\nI will fix it.","commit_id":"ecafe0ae3c4fba975bbdcd514a821d21b21ee4be"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"490833683bc16d5d706dbdef984aa87d5f8fc09d","unresolved":false,"context_lines":[{"line_number":794,"context_line":"        inst.metadata \u003d inst_utils.json_merge_patch("},{"line_number":795,"context_line":"            base, vnfd_prop.get(\u0027metadata\u0027, {}))"},{"line_number":796,"context_line":""},{"line_number":797,"context_line":"        attrs \u003d [\u0027vnfConfigurableProperties\u0027, \u0027extensions\u0027]"},{"line_number":798,"context_line":"        for attr in attrs:"},{"line_number":799,"context_line":"            self._modify_from_vnfd_prop(inst, vnfd_prop, attr)"},{"line_number":800,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"b607a707_b8198aac","line":797,"in_reply_to":"9c3dd225_38729ce9","updated":"2023-06-15 19:15:25.000000000","message":"Thanks for your great works! Done.","commit_id":"ecafe0ae3c4fba975bbdcd514a821d21b21ee4be"}]}