)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":33920,"name":"Yusuke Niimi","email":"niimi.yusuke@fujitsu.com","username":"yniimi"},"change_message_id":"4d300b91f8f41bc0e659fafc6d41fde6d9399953","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"6a832075_0d22edb4","updated":"2023-05-10 04:38:57.000000000","message":"recheck - infra failure","commit_id":"24d35a93d36d358bdcd51671871499a66efa3843"},{"author":{"_account_id":33920,"name":"Yusuke Niimi","email":"niimi.yusuke@fujitsu.com","username":"yniimi"},"change_message_id":"85ca170f6241179d736445e8ce39108dac416aaf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"ab5bc495_d40f70a0","updated":"2023-08-31 06:31:14.000000000","message":"recheck - infra failure","commit_id":"50fc76c0b2653c291b879d3d408783dfe90c27cc"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"e68211e4a93f15dcfc210fab986f5922e6e8f894","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":32,"id":"e8af6a93_2eada1c4","updated":"2023-09-06 15:38:40.000000000","message":"Thanks for your patch, please kindly find my comments.","commit_id":"72cfe7a85007f0513a16e99e4b535b8f9f508f75"},{"author":{"_account_id":33920,"name":"Yusuke Niimi","email":"niimi.yusuke@fujitsu.com","username":"yniimi"},"change_message_id":"96146ebd39abeec49a4a924a485ec8aea2ece14b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":32,"id":"cd5e72b1_1fd9ffc0","updated":"2023-09-06 01:02:55.000000000","message":"recheck - infra failure","commit_id":"72cfe7a85007f0513a16e99e4b535b8f9f508f75"},{"author":{"_account_id":33920,"name":"Yusuke Niimi","email":"niimi.yusuke@fujitsu.com","username":"yniimi"},"change_message_id":"e74e44a50f048615060f71d222ba415d9727ed45","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":33,"id":"09cc447e_f5106025","updated":"2023-09-07 11:23:30.000000000","message":"Thank you for your comment.\nI have fixed the commented points.","commit_id":"27d0a035ef6a019931690341dcd509422290576b"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"ca649993ca09656e2319b00da1d99ec1b45a4603","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":33,"id":"d7ee7d13_020e959d","updated":"2023-09-07 13:05:03.000000000","message":"Thanks for your rework, LGTM.","commit_id":"27d0a035ef6a019931690341dcd509422290576b"}],"tacker/common/crypt_utils.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"e68211e4a93f15dcfc210fab986f5922e6e8f894","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2023 FUJITSU"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":32,"id":"cc9255d8_577f3e0b","line":1,"range":{"start_line":1,"start_character":21,"end_line":1,"end_character":28},"updated":"2023-09-06 15:38:40.000000000","message":"nits: How about you change it to `Fujitsu` according to the other files in this patch?","commit_id":"72cfe7a85007f0513a16e99e4b535b8f9f508f75"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"ca649993ca09656e2319b00da1d99ec1b45a4603","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2023 FUJITSU"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":32,"id":"0e1c546b_04287233","line":1,"range":{"start_line":1,"start_character":21,"end_line":1,"end_character":28},"in_reply_to":"3e34ddc5_497edc9a","updated":"2023-09-07 13:05:03.000000000","message":"Ack","commit_id":"72cfe7a85007f0513a16e99e4b535b8f9f508f75"},{"author":{"_account_id":33920,"name":"Yusuke Niimi","email":"niimi.yusuke@fujitsu.com","username":"yniimi"},"change_message_id":"e74e44a50f048615060f71d222ba415d9727ed45","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2023 FUJITSU"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":32,"id":"3e34ddc5_497edc9a","line":1,"range":{"start_line":1,"start_character":21,"end_line":1,"end_character":28},"in_reply_to":"cc9255d8_577f3e0b","updated":"2023-09-07 11:23:30.000000000","message":"Fixed in patchset 33.","commit_id":"72cfe7a85007f0513a16e99e4b535b8f9f508f75"}],"tacker/db/migration/alembic_migrations/versions/ca2ad037c320_add_cryptkey_db.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"e68211e4a93f15dcfc210fab986f5922e6e8f894","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright 2023 OpenStack Foundation"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":32,"id":"cec470d0_b584cb7c","line":1,"range":{"start_line":1,"start_character":17,"end_line":1,"end_character":37},"updated":"2023-09-06 15:38:40.000000000","message":"Could you change it to `Fujitsu`?","commit_id":"72cfe7a85007f0513a16e99e4b535b8f9f508f75"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"ca649993ca09656e2319b00da1d99ec1b45a4603","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2023 OpenStack Foundation"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":32,"id":"ad5104e0_36d688c5","line":1,"range":{"start_line":1,"start_character":17,"end_line":1,"end_character":37},"in_reply_to":"86b10c52_8371e026","updated":"2023-09-07 13:05:03.000000000","message":"Ack","commit_id":"72cfe7a85007f0513a16e99e4b535b8f9f508f75"},{"author":{"_account_id":33920,"name":"Yusuke Niimi","email":"niimi.yusuke@fujitsu.com","username":"yniimi"},"change_message_id":"e74e44a50f048615060f71d222ba415d9727ed45","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright 2023 OpenStack Foundation"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":32,"id":"86b10c52_8371e026","line":1,"range":{"start_line":1,"start_character":17,"end_line":1,"end_character":37},"in_reply_to":"cec470d0_b584cb7c","updated":"2023-09-07 11:23:30.000000000","message":"Fixed in patchset 33.","commit_id":"72cfe7a85007f0513a16e99e4b535b8f9f508f75"}],"tacker/sol_refactored/controller/vnflcm_view.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"e68211e4a93f15dcfc210fab986f5922e6e8f894","unresolved":true,"context_lines":[{"line_number":361,"context_line":"        # see SOL003 4.4.1.6"},{"line_number":362,"context_line":"        cred_data \u003d [\u0027password\u0027, \u0027bearer_token\u0027, \u0027client_secret\u0027]"},{"line_number":363,"context_line":"        for vim_info in resp.get(\u0027vimConnectionInfo\u0027, {}).values():"},{"line_number":364,"context_line":"            if (\u0027accessInfo\u0027 in vim_info):"},{"line_number":365,"context_line":"                for cred_key in cred_data:"},{"line_number":366,"context_line":"                    if cred_key in vim_info[\u0027accessInfo\u0027]:"},{"line_number":367,"context_line":"                        vim_info[\u0027accessInfo\u0027].pop(cred_key)"}],"source_content_type":"text/x-python","patch_set":32,"id":"89d83571_73176128","line":364,"range":{"start_line":364,"start_character":15,"end_line":364,"end_character":16},"updated":"2023-09-06 15:38:40.000000000","message":"nits: Can you remove the parentheses?","commit_id":"72cfe7a85007f0513a16e99e4b535b8f9f508f75"},{"author":{"_account_id":33920,"name":"Yusuke Niimi","email":"niimi.yusuke@fujitsu.com","username":"yniimi"},"change_message_id":"e74e44a50f048615060f71d222ba415d9727ed45","unresolved":true,"context_lines":[{"line_number":361,"context_line":"        # see SOL003 4.4.1.6"},{"line_number":362,"context_line":"        cred_data \u003d [\u0027password\u0027, \u0027bearer_token\u0027, \u0027client_secret\u0027]"},{"line_number":363,"context_line":"        for vim_info in resp.get(\u0027vimConnectionInfo\u0027, {}).values():"},{"line_number":364,"context_line":"            if (\u0027accessInfo\u0027 in vim_info):"},{"line_number":365,"context_line":"                for cred_key in cred_data:"},{"line_number":366,"context_line":"                    if cred_key in vim_info[\u0027accessInfo\u0027]:"},{"line_number":367,"context_line":"                        vim_info[\u0027accessInfo\u0027].pop(cred_key)"}],"source_content_type":"text/x-python","patch_set":32,"id":"b6ab9631_11c67c71","line":364,"range":{"start_line":364,"start_character":15,"end_line":364,"end_character":16},"in_reply_to":"89d83571_73176128","updated":"2023-09-07 11:23:30.000000000","message":"Fixed in patchset 33.","commit_id":"72cfe7a85007f0513a16e99e4b535b8f9f508f75"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"ca649993ca09656e2319b00da1d99ec1b45a4603","unresolved":false,"context_lines":[{"line_number":361,"context_line":"        # see SOL003 4.4.1.6"},{"line_number":362,"context_line":"        cred_data \u003d [\u0027password\u0027, \u0027bearer_token\u0027, \u0027client_secret\u0027]"},{"line_number":363,"context_line":"        for vim_info in resp.get(\u0027vimConnectionInfo\u0027, {}).values():"},{"line_number":364,"context_line":"            if (\u0027accessInfo\u0027 in vim_info):"},{"line_number":365,"context_line":"                for cred_key in cred_data:"},{"line_number":366,"context_line":"                    if cred_key in vim_info[\u0027accessInfo\u0027]:"},{"line_number":367,"context_line":"                        vim_info[\u0027accessInfo\u0027].pop(cred_key)"}],"source_content_type":"text/x-python","patch_set":32,"id":"26b94bdc_c2029d5a","line":364,"range":{"start_line":364,"start_character":15,"end_line":364,"end_character":16},"in_reply_to":"b6ab9631_11c67c71","updated":"2023-09-07 13:05:03.000000000","message":"Ack","commit_id":"72cfe7a85007f0513a16e99e4b535b8f9f508f75"}],"tacker/tests/functional/base_v2.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"e68211e4a93f15dcfc210fab986f5922e6e8f894","unresolved":true,"context_lines":[{"line_number":386,"context_line":""},{"line_number":387,"context_line":"            raise Exception(f\"Operation failed. state: {state}\")"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"    def wait_lcmocc_failed(self, lcmocc_id):"},{"line_number":390,"context_line":"        # NOTE: It is not necessary to set timeout because the operation"},{"line_number":391,"context_line":"        # itself set timeout and the state will become \u0027FAILED_TEMP\u0027."},{"line_number":392,"context_line":"        path \u003d f\"/vnflcm/v2/vnf_lcm_op_occs/{lcmocc_id}\""},{"line_number":393,"context_line":"        while True:"},{"line_number":394,"context_line":"            time.sleep(RETRY_WAIT_TIME)"},{"line_number":395,"context_line":"            _, body \u003d self.tacker_client.do_request("},{"line_number":396,"context_line":"                path, \"GET\", expected_status\u003d[200], version\u003dVNFLCM_V2_VERSION)"},{"line_number":397,"context_line":"            state \u003d body[\u0027operationState\u0027]"},{"line_number":398,"context_line":"            if state \u003d\u003d \u0027FAILED\u0027:"},{"line_number":399,"context_line":"                return"},{"line_number":400,"context_line":"            elif state in [\u0027STARTING\u0027, \u0027PROCESSING\u0027]:"},{"line_number":401,"context_line":"                continue"},{"line_number":402,"context_line":"            else:  # FAILED_TEMP or ROLLED_BACK"},{"line_number":403,"context_line":"                raise Exception(f\"Operation failed. state: {state}\")"},{"line_number":404,"context_line":""},{"line_number":405,"context_line":"    def put_fail_file(self, operation):"},{"line_number":406,"context_line":"        with open(f\u0027/tmp/{operation}\u0027, \u0027w\u0027):"}],"source_content_type":"text/x-python","patch_set":32,"id":"cfb36d83_4a34a312","line":403,"range":{"start_line":389,"start_character":0,"end_line":403,"end_character":68},"updated":"2023-09-06 15:38:40.000000000","message":"Currently, if the `openstack vnflcm op fail` operation is run, it will already be `FAILED` state when returning a 200 response.\nSo I think there is no need to wait. Or is there needed to wait for DB writes?\n\nIf you need check it, wouldn\u0027t it be better to make sure it\u0027s in the `FAILED` state instead of waiting?\nWhat do you think?","commit_id":"72cfe7a85007f0513a16e99e4b535b8f9f508f75"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"ca649993ca09656e2319b00da1d99ec1b45a4603","unresolved":false,"context_lines":[{"line_number":386,"context_line":""},{"line_number":387,"context_line":"            raise Exception(f\"Operation failed. state: {state}\")"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"    def wait_lcmocc_failed(self, lcmocc_id):"},{"line_number":390,"context_line":"        # NOTE: It is not necessary to set timeout because the operation"},{"line_number":391,"context_line":"        # itself set timeout and the state will become \u0027FAILED_TEMP\u0027."},{"line_number":392,"context_line":"        path \u003d f\"/vnflcm/v2/vnf_lcm_op_occs/{lcmocc_id}\""},{"line_number":393,"context_line":"        while True:"},{"line_number":394,"context_line":"            time.sleep(RETRY_WAIT_TIME)"},{"line_number":395,"context_line":"            _, body \u003d self.tacker_client.do_request("},{"line_number":396,"context_line":"                path, \"GET\", expected_status\u003d[200], version\u003dVNFLCM_V2_VERSION)"},{"line_number":397,"context_line":"            state \u003d body[\u0027operationState\u0027]"},{"line_number":398,"context_line":"            if state \u003d\u003d \u0027FAILED\u0027:"},{"line_number":399,"context_line":"                return"},{"line_number":400,"context_line":"            elif state in [\u0027STARTING\u0027, \u0027PROCESSING\u0027]:"},{"line_number":401,"context_line":"                continue"},{"line_number":402,"context_line":"            else:  # FAILED_TEMP or ROLLED_BACK"},{"line_number":403,"context_line":"                raise Exception(f\"Operation failed. state: {state}\")"},{"line_number":404,"context_line":""},{"line_number":405,"context_line":"    def put_fail_file(self, operation):"},{"line_number":406,"context_line":"        with open(f\u0027/tmp/{operation}\u0027, \u0027w\u0027):"}],"source_content_type":"text/x-python","patch_set":32,"id":"4519a307_cc58c07a","line":403,"range":{"start_line":389,"start_character":0,"end_line":403,"end_character":68},"in_reply_to":"688bf2fc_9d0bb62e","updated":"2023-09-07 13:05:03.000000000","message":"Ack","commit_id":"72cfe7a85007f0513a16e99e4b535b8f9f508f75"},{"author":{"_account_id":33920,"name":"Yusuke Niimi","email":"niimi.yusuke@fujitsu.com","username":"yniimi"},"change_message_id":"e74e44a50f048615060f71d222ba415d9727ed45","unresolved":true,"context_lines":[{"line_number":386,"context_line":""},{"line_number":387,"context_line":"            raise Exception(f\"Operation failed. state: {state}\")"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"    def wait_lcmocc_failed(self, lcmocc_id):"},{"line_number":390,"context_line":"        # NOTE: It is not necessary to set timeout because the operation"},{"line_number":391,"context_line":"        # itself set timeout and the state will become \u0027FAILED_TEMP\u0027."},{"line_number":392,"context_line":"        path \u003d f\"/vnflcm/v2/vnf_lcm_op_occs/{lcmocc_id}\""},{"line_number":393,"context_line":"        while True:"},{"line_number":394,"context_line":"            time.sleep(RETRY_WAIT_TIME)"},{"line_number":395,"context_line":"            _, body \u003d self.tacker_client.do_request("},{"line_number":396,"context_line":"                path, \"GET\", expected_status\u003d[200], version\u003dVNFLCM_V2_VERSION)"},{"line_number":397,"context_line":"            state \u003d body[\u0027operationState\u0027]"},{"line_number":398,"context_line":"            if state \u003d\u003d \u0027FAILED\u0027:"},{"line_number":399,"context_line":"                return"},{"line_number":400,"context_line":"            elif state in [\u0027STARTING\u0027, \u0027PROCESSING\u0027]:"},{"line_number":401,"context_line":"                continue"},{"line_number":402,"context_line":"            else:  # FAILED_TEMP or ROLLED_BACK"},{"line_number":403,"context_line":"                raise Exception(f\"Operation failed. state: {state}\")"},{"line_number":404,"context_line":""},{"line_number":405,"context_line":"    def put_fail_file(self, operation):"},{"line_number":406,"context_line":"        with open(f\u0027/tmp/{operation}\u0027, \u0027w\u0027):"}],"source_content_type":"text/x-python","patch_set":32,"id":"688bf2fc_9d0bb62e","line":403,"range":{"start_line":389,"start_character":0,"end_line":403,"end_character":68},"in_reply_to":"cfb36d83_4a34a312","updated":"2023-09-07 11:23:30.000000000","message":"As you pointed out, the wait method was removed in patchset 33 because it is unnecessary.","commit_id":"72cfe7a85007f0513a16e99e4b535b8f9f508f75"}],"tacker/tests/functional/sol_encrypt_cred_v2/paramgen.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"e68211e4a93f15dcfc210fab986f5922e6e8f894","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2022 Fujitsu"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":32,"id":"8a36c99d_14bb3f7d","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"updated":"2023-09-06 15:38:40.000000000","message":"2023","commit_id":"72cfe7a85007f0513a16e99e4b535b8f9f508f75"},{"author":{"_account_id":33920,"name":"Yusuke Niimi","email":"niimi.yusuke@fujitsu.com","username":"yniimi"},"change_message_id":"e74e44a50f048615060f71d222ba415d9727ed45","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2022 Fujitsu"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":32,"id":"c8a01970_306afc41","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"in_reply_to":"8a36c99d_14bb3f7d","updated":"2023-09-07 11:23:30.000000000","message":"Fixed in patchset 33.","commit_id":"72cfe7a85007f0513a16e99e4b535b8f9f508f75"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"ca649993ca09656e2319b00da1d99ec1b45a4603","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2022 Fujitsu"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":32,"id":"d9d40fc9_633261cc","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"in_reply_to":"c8a01970_306afc41","updated":"2023-09-07 13:05:03.000000000","message":"Ack","commit_id":"72cfe7a85007f0513a16e99e4b535b8f9f508f75"}],"tacker/tests/functional/sol_encrypt_cred_v2/test_encrypt_credentials.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"e68211e4a93f15dcfc210fab986f5922e6e8f894","unresolved":true,"context_lines":[{"line_number":513,"context_line":"        resp, body \u003d self.fail_lcmocc(lcmocc_id)"},{"line_number":514,"context_line":"        self.assertEqual(200, resp.status_code)"},{"line_number":515,"context_line":""},{"line_number":516,"context_line":"        self.wait_lcmocc_failed(lcmocc_id)"},{"line_number":517,"context_line":""},{"line_number":518,"context_line":"        # check not saved VnfLcmOpOccV2 additionalParams"},{"line_number":519,"context_line":"        opocc \u003d self._get_vnflcm_op_occs_by_id(self.context, lcmocc_id)"}],"source_content_type":"text/x-python","patch_set":32,"id":"7cfa8806_fb1ea8e3","line":516,"range":{"start_line":516,"start_character":8,"end_line":516,"end_character":42},"updated":"2023-09-06 15:38:40.000000000","message":"Currently, if the `openstack vnflcm op fail` operation is run, it will already be `FAILED` state when returning a 200 response.\nSo I think there is no need to wait. Or is there needed to wait for DB writes?\n\nIf you need check it, wouldn\u0027t it be better to make sure it\u0027s in the `FAILED` state instead of waiting?\nWhat do you think?","commit_id":"72cfe7a85007f0513a16e99e4b535b8f9f508f75"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"ca649993ca09656e2319b00da1d99ec1b45a4603","unresolved":false,"context_lines":[{"line_number":513,"context_line":"        resp, body \u003d self.fail_lcmocc(lcmocc_id)"},{"line_number":514,"context_line":"        self.assertEqual(200, resp.status_code)"},{"line_number":515,"context_line":""},{"line_number":516,"context_line":"        self.wait_lcmocc_failed(lcmocc_id)"},{"line_number":517,"context_line":""},{"line_number":518,"context_line":"        # check not saved VnfLcmOpOccV2 additionalParams"},{"line_number":519,"context_line":"        opocc \u003d self._get_vnflcm_op_occs_by_id(self.context, lcmocc_id)"}],"source_content_type":"text/x-python","patch_set":32,"id":"dea5c72f_fba2da5e","line":516,"range":{"start_line":516,"start_character":8,"end_line":516,"end_character":42},"in_reply_to":"13b76f36_39cc5951","updated":"2023-09-07 13:05:03.000000000","message":"Ack","commit_id":"72cfe7a85007f0513a16e99e4b535b8f9f508f75"},{"author":{"_account_id":33920,"name":"Yusuke Niimi","email":"niimi.yusuke@fujitsu.com","username":"yniimi"},"change_message_id":"e74e44a50f048615060f71d222ba415d9727ed45","unresolved":true,"context_lines":[{"line_number":513,"context_line":"        resp, body \u003d self.fail_lcmocc(lcmocc_id)"},{"line_number":514,"context_line":"        self.assertEqual(200, resp.status_code)"},{"line_number":515,"context_line":""},{"line_number":516,"context_line":"        self.wait_lcmocc_failed(lcmocc_id)"},{"line_number":517,"context_line":""},{"line_number":518,"context_line":"        # check not saved VnfLcmOpOccV2 additionalParams"},{"line_number":519,"context_line":"        opocc \u003d self._get_vnflcm_op_occs_by_id(self.context, lcmocc_id)"}],"source_content_type":"text/x-python","patch_set":32,"id":"13b76f36_39cc5951","line":516,"range":{"start_line":516,"start_character":8,"end_line":516,"end_character":42},"in_reply_to":"7cfa8806_fb1ea8e3","updated":"2023-09-07 11:23:30.000000000","message":"As you pointed out, the wait method was removed in patchset 33 because it is unnecessary.","commit_id":"72cfe7a85007f0513a16e99e4b535b8f9f508f75"}],"tacker/tests/unit/common/fakes.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"e68211e4a93f15dcfc210fab986f5922e6e8f894","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2023 OpenStack Foundation."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":32,"id":"aa1187de_74b6f8a6","line":1,"range":{"start_line":1,"start_character":21,"end_line":1,"end_character":42},"updated":"2023-09-06 15:38:40.000000000","message":"Could you change it to `Fujitsu`?","commit_id":"72cfe7a85007f0513a16e99e4b535b8f9f508f75"},{"author":{"_account_id":33920,"name":"Yusuke Niimi","email":"niimi.yusuke@fujitsu.com","username":"yniimi"},"change_message_id":"e74e44a50f048615060f71d222ba415d9727ed45","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2023 OpenStack Foundation."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":32,"id":"df4db1b0_f0d37608","line":1,"range":{"start_line":1,"start_character":21,"end_line":1,"end_character":42},"in_reply_to":"aa1187de_74b6f8a6","updated":"2023-09-07 11:23:30.000000000","message":"Fixed in patchset 33.","commit_id":"72cfe7a85007f0513a16e99e4b535b8f9f508f75"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"ca649993ca09656e2319b00da1d99ec1b45a4603","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2023 OpenStack Foundation."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":32,"id":"0e808045_1ddf7bc7","line":1,"range":{"start_line":1,"start_character":21,"end_line":1,"end_character":42},"in_reply_to":"df4db1b0_f0d37608","updated":"2023-09-07 13:05:03.000000000","message":"Ack","commit_id":"72cfe7a85007f0513a16e99e4b535b8f9f508f75"}],"tacker/tests/unit/common/test_crypt_utils.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"e68211e4a93f15dcfc210fab986f5922e6e8f894","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2023 OpenStack Foundation."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":32,"id":"a87f0ab2_f8093136","line":1,"range":{"start_line":1,"start_character":21,"end_line":1,"end_character":42},"updated":"2023-09-06 15:38:40.000000000","message":"Could you change it to `Fujitsu`?","commit_id":"72cfe7a85007f0513a16e99e4b535b8f9f508f75"},{"author":{"_account_id":33920,"name":"Yusuke Niimi","email":"niimi.yusuke@fujitsu.com","username":"yniimi"},"change_message_id":"e74e44a50f048615060f71d222ba415d9727ed45","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2023 OpenStack Foundation."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":32,"id":"fa188774_cc8cee1d","line":1,"range":{"start_line":1,"start_character":21,"end_line":1,"end_character":42},"in_reply_to":"a87f0ab2_f8093136","updated":"2023-09-07 11:23:30.000000000","message":"Fixed in patchset 33.","commit_id":"72cfe7a85007f0513a16e99e4b535b8f9f508f75"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"ca649993ca09656e2319b00da1d99ec1b45a4603","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2023 OpenStack Foundation."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":32,"id":"197e5daa_94182670","line":1,"range":{"start_line":1,"start_character":21,"end_line":1,"end_character":42},"in_reply_to":"fa188774_cc8cee1d","updated":"2023-09-07 13:05:03.000000000","message":"Ack","commit_id":"72cfe7a85007f0513a16e99e4b535b8f9f508f75"}]}