)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"d57ffd0fe78fc501823cb3653f565bd409e23e92","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Fix missing volume id in storageResourceIds"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When instantiate v2 API is called with a non-boot volume,"},{"line_number":10,"context_line":"its volume id was missing storageResourceIds."},{"line_number":11,"context_line":"This patch fixes this problem."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #2020716"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"28621c5c_3319ebb2","line":10,"updated":"2023-06-12 06:29:52.000000000","message":"nits: missing storageResourceIds -\u003e missing in storageResourceIds","commit_id":"50c60d70feef90007147040a86c34d0bf37b8b65"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"b9646718dce6caeca8ffc3a69613b98232f2af89","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Fix missing volume id in storageResourceIds"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When instantiate v2 API is called with a non-boot volume,"},{"line_number":10,"context_line":"its volume id was missing storageResourceIds."},{"line_number":11,"context_line":"This patch fixes this problem."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #2020716"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3ec5128f_5206a298","line":10,"in_reply_to":"28621c5c_3319ebb2","updated":"2023-06-13 00:30:49.000000000","message":"I will fix.","commit_id":"50c60d70feef90007147040a86c34d0bf37b8b65"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"93b00cdbc63ff1a98a3dab5765f3d87e535f109a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix missing volume id in storageResourceIds"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When instantiate v2 API is called with a non-boot volume,"},{"line_number":10,"context_line":"its volume id was missing storageResourceIds."},{"line_number":11,"context_line":"This patch fixes this problem."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #2020716"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"4dce9f05_51a0cb38","line":10,"in_reply_to":"3ec5128f_5206a298","updated":"2023-06-15 19:16:54.000000000","message":"Done","commit_id":"50c60d70feef90007147040a86c34d0bf37b8b65"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"b9646718dce6caeca8ffc3a69613b98232f2af89","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f3710f85_75d34da3","updated":"2023-06-13 00:30:49.000000000","message":"Thank you for the review.","commit_id":"50c60d70feef90007147040a86c34d0bf37b8b65"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"d57ffd0fe78fc501823cb3653f565bd409e23e92","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"db73907c_2c17eec1","updated":"2023-06-12 06:29:52.000000000","message":"Thanks for your patch. Please kindly check my nit comments.","commit_id":"50c60d70feef90007147040a86c34d0bf37b8b65"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"19d38ad54ba51cb9f1a0c018d1bf54beb919c513","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c34b188f_5ab7b555","updated":"2023-06-15 09:15:23.000000000","message":"Thank you for the review.","commit_id":"0cc569569a8423982f09c95b2378a2f68b5eff45"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"93b00cdbc63ff1a98a3dab5765f3d87e535f109a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7157f95b_de00a106","updated":"2023-06-15 19:16:54.000000000","message":"Thank you for re-work.","commit_id":"d3f3d5cf29ce2e7113dc2187a1634d99e8ac6012"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"f3b2048ea260c8ab9176441edbe6037696796968","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ee221afd_68e85dab","updated":"2023-06-20 09:13:12.000000000","message":"Thank you for the review.","commit_id":"d3f3d5cf29ce2e7113dc2187a1634d99e8ac6012"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"6149ffc0baf05180b62516bc2ec48b8c374a7d21","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ac1f5d4c_76e09092","updated":"2023-06-20 02:10:20.000000000","message":"recheck infra-failure","commit_id":"d3f3d5cf29ce2e7113dc2187a1634d99e8ac6012"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"43a2da2fa335d16d79fa7b3bdb15e43c793d72dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d76ccf32_1a7a7f61","updated":"2023-07-06 01:40:52.000000000","message":"Thank you for the review.","commit_id":"a60ae747c7f5a491d34dd868ce9ec4c4d834065e"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"e298a2ffe47e45fa65b9255df425956fefb3e22e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a5fc5434_305ddb34","updated":"2023-06-27 22:45:32.000000000","message":"recheck infra-failure","commit_id":"a60ae747c7f5a491d34dd868ce9ec4c4d834065e"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"5f8318174d734997062ab177ff6137d85b428ae5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"50a720fc_118e8b96","updated":"2023-07-10 01:33:01.000000000","message":"LGTM","commit_id":"b57a1f1619b569170faaadf3708e50feab3b6524"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"eb3aef28467c11e4cc3234bdfac016b853681aae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f2480399_80a860cf","updated":"2023-08-02 16:48:17.000000000","message":"Thanks for your patch, LGTM.","commit_id":"b57a1f1619b569170faaadf3708e50feab3b6524"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"90995d29a124d1ac7a14f12db22a0d32cdbcfec7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"0693eca4_80ff656a","updated":"2023-07-06 22:02:27.000000000","message":"recheck infra-failure","commit_id":"b57a1f1619b569170faaadf3708e50feab3b6524"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"204db60eb0abb558c43e8771755aea5690e9ca3e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"69b4c555_f54644cd","updated":"2023-07-09 22:51:59.000000000","message":"recheck infra-failure","commit_id":"b57a1f1619b569170faaadf3708e50feab3b6524"}],"tacker/tests/functional/sol_v2/test_individual_vnfc_mgmt.py":[{"author":{"_account_id":31668,"deleted":true},"change_message_id":"a000ab6767003f5e0fd8e83addeb0420517af020","unresolved":true,"context_lines":[{"line_number":78,"context_line":"        # for attach non-boot volume to VDU test"},{"line_number":79,"context_line":"        pkg_path_4 \u003d os.path.join(cur_dir,"},{"line_number":80,"context_line":"            \"../sol_v2_common/samples/userdata_standard_with_non_boot_volume\")"},{"line_number":81,"context_line":"        cls.vnf_pkg_4, cls.vnfd_id_4 \u003d cls.create_vnf_package("},{"line_number":82,"context_line":"            pkg_path_4, image_path\u003dimage_path, userdata_path\u003duserdata_path)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":3,"id":"c551f4b4_1d9e2c81","line":81,"updated":"2023-06-20 07:01:42.000000000","message":"Could you change \"vnf_pkg_4\" and \"vnfd_id_4\" to names that are easier to understand?\n\"vnf_pkg_1-3\" and \"vnfd_id_1-3\" have already been changed by the following patch, so please rebase after the following patch is merged.\nhttps://review.opendev.org/c/openstack/tacker/+/881181/15/tacker/tests/functional/sol_v2/test_individual_vnfc_mgmt.py#b63","commit_id":"d3f3d5cf29ce2e7113dc2187a1634d99e8ac6012"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"d6d534ff1f64c02657d7e2ec1b50a1b167abfced","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        # for attach non-boot volume to VDU test"},{"line_number":79,"context_line":"        pkg_path_4 \u003d os.path.join(cur_dir,"},{"line_number":80,"context_line":"            \"../sol_v2_common/samples/userdata_standard_with_non_boot_volume\")"},{"line_number":81,"context_line":"        cls.vnf_pkg_4, cls.vnfd_id_4 \u003d cls.create_vnf_package("},{"line_number":82,"context_line":"            pkg_path_4, image_path\u003dimage_path, userdata_path\u003duserdata_path)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":3,"id":"604def50_7b68a8e9","line":81,"in_reply_to":"10e9c658_8eaaff79","updated":"2023-07-05 08:11:13.000000000","message":"Done","commit_id":"d3f3d5cf29ce2e7113dc2187a1634d99e8ac6012"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"f3b2048ea260c8ab9176441edbe6037696796968","unresolved":true,"context_lines":[{"line_number":78,"context_line":"        # for attach non-boot volume to VDU test"},{"line_number":79,"context_line":"        pkg_path_4 \u003d os.path.join(cur_dir,"},{"line_number":80,"context_line":"            \"../sol_v2_common/samples/userdata_standard_with_non_boot_volume\")"},{"line_number":81,"context_line":"        cls.vnf_pkg_4, cls.vnfd_id_4 \u003d cls.create_vnf_package("},{"line_number":82,"context_line":"            pkg_path_4, image_path\u003dimage_path, userdata_path\u003duserdata_path)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":3,"id":"10e9c658_8eaaff79","line":81,"in_reply_to":"c551f4b4_1d9e2c81","updated":"2023-06-20 09:13:12.000000000","message":"I understand. I will fix it after merge.","commit_id":"d3f3d5cf29ce2e7113dc2187a1634d99e8ac6012"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"d6d534ff1f64c02657d7e2ec1b50a1b167abfced","unresolved":true,"context_lines":[{"line_number":875,"context_line":"        # Delete VNF instance"},{"line_number":876,"context_line":"        self.exec_lcm_operation(self.delete_vnf_instance, inst_id)"},{"line_number":877,"context_line":""},{"line_number":878,"context_line":"    def test_instantiate_attach_non_boot_volume(self):"},{"line_number":879,"context_line":"        \"\"\"Test Instantiate with non-boot volume attached to VDU"},{"line_number":880,"context_line":""},{"line_number":881,"context_line":"        * Note:"}],"source_content_type":"text/x-python","patch_set":4,"id":"404c024a_d221f068","line":878,"updated":"2023-07-05 08:11:13.000000000","message":"There is no test for \"scale out\" and \"change vnf pacakge\"/\"modify (change vnfdId)\", is that okay?","commit_id":"a60ae747c7f5a491d34dd868ce9ec4c4d834065e"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"43a2da2fa335d16d79fa7b3bdb15e43c793d72dd","unresolved":true,"context_lines":[{"line_number":875,"context_line":"        # Delete VNF instance"},{"line_number":876,"context_line":"        self.exec_lcm_operation(self.delete_vnf_instance, inst_id)"},{"line_number":877,"context_line":""},{"line_number":878,"context_line":"    def test_instantiate_attach_non_boot_volume(self):"},{"line_number":879,"context_line":"        \"\"\"Test Instantiate with non-boot volume attached to VDU"},{"line_number":880,"context_line":""},{"line_number":881,"context_line":"        * Note:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f7ac55a_b0bbfbab","line":878,"in_reply_to":"404c024a_d221f068","updated":"2023-07-06 01:40:52.000000000","message":"I think it is enough to check that the volume is included in \"vnfcResourceInfo.storageResourceIds\" with \"instantiate\" and \"heal\", because \"vnfcResourceInfo.storageResourceIds\" creation process for \"scale\" and \"change_vnfpkg\" is the same as \"instantiate\" and \"heal\".","commit_id":"a60ae747c7f5a491d34dd868ce9ec4c4d834065e"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"e67d06789d41be8cbceae4b52baf3199cc1482cc","unresolved":false,"context_lines":[{"line_number":875,"context_line":"        # Delete VNF instance"},{"line_number":876,"context_line":"        self.exec_lcm_operation(self.delete_vnf_instance, inst_id)"},{"line_number":877,"context_line":""},{"line_number":878,"context_line":"    def test_instantiate_attach_non_boot_volume(self):"},{"line_number":879,"context_line":"        \"\"\"Test Instantiate with non-boot volume attached to VDU"},{"line_number":880,"context_line":""},{"line_number":881,"context_line":"        * Note:"}],"source_content_type":"text/x-python","patch_set":4,"id":"53129367_66df7801","line":878,"in_reply_to":"9f7ac55a_b0bbfbab","updated":"2023-07-06 05:07:20.000000000","message":"Ack","commit_id":"a60ae747c7f5a491d34dd868ce9ec4c4d834065e"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"d6d534ff1f64c02657d7e2ec1b50a1b167abfced","unresolved":true,"context_lines":[{"line_number":927,"context_line":"        # 2. Heal operation(\"all\"\u003dTrue)"},{"line_number":928,"context_line":"        # VDU1-0 to heal"},{"line_number":929,"context_line":"        vnfc_info_id \u003d self._get_vnfc_info_id(inst_1, \u0027VDU1\u0027, 0)"},{"line_number":930,"context_line":"        heal_req \u003d paramgen.sample7_heal(vnfc_info_id)"},{"line_number":931,"context_line":"        resp, body \u003d self.heal_vnf_instance(inst_id, heal_req)"},{"line_number":932,"context_line":"        self.assertEqual(202, resp.status_code)"},{"line_number":933,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"df572553_b1b95fba","line":930,"updated":"2023-07-05 08:11:13.000000000","message":"How about specifying \"a-001\" directly for vnfcInstanceId?\nI think that it is also effective as confirmation that vnfcInfo.id is set correctly by instantiate.","commit_id":"a60ae747c7f5a491d34dd868ce9ec4c4d834065e"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"e67d06789d41be8cbceae4b52baf3199cc1482cc","unresolved":false,"context_lines":[{"line_number":927,"context_line":"        # 2. Heal operation(\"all\"\u003dTrue)"},{"line_number":928,"context_line":"        # VDU1-0 to heal"},{"line_number":929,"context_line":"        vnfc_info_id \u003d self._get_vnfc_info_id(inst_1, \u0027VDU1\u0027, 0)"},{"line_number":930,"context_line":"        heal_req \u003d paramgen.sample7_heal(vnfc_info_id)"},{"line_number":931,"context_line":"        resp, body \u003d self.heal_vnf_instance(inst_id, heal_req)"},{"line_number":932,"context_line":"        self.assertEqual(202, resp.status_code)"},{"line_number":933,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3b6aed56_fe85f3f4","line":930,"in_reply_to":"49509ead_b34f7e6c","updated":"2023-07-06 05:07:20.000000000","message":"Done","commit_id":"a60ae747c7f5a491d34dd868ce9ec4c4d834065e"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"43a2da2fa335d16d79fa7b3bdb15e43c793d72dd","unresolved":true,"context_lines":[{"line_number":927,"context_line":"        # 2. Heal operation(\"all\"\u003dTrue)"},{"line_number":928,"context_line":"        # VDU1-0 to heal"},{"line_number":929,"context_line":"        vnfc_info_id \u003d self._get_vnfc_info_id(inst_1, \u0027VDU1\u0027, 0)"},{"line_number":930,"context_line":"        heal_req \u003d paramgen.sample7_heal(vnfc_info_id)"},{"line_number":931,"context_line":"        resp, body \u003d self.heal_vnf_instance(inst_id, heal_req)"},{"line_number":932,"context_line":"        self.assertEqual(202, resp.status_code)"},{"line_number":933,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"49509ead_b34f7e6c","line":930,"in_reply_to":"df572553_b1b95fba","updated":"2023-07-06 01:40:52.000000000","message":"I understand. I will fix.","commit_id":"a60ae747c7f5a491d34dd868ce9ec4c4d834065e"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"d6d534ff1f64c02657d7e2ec1b50a1b167abfced","unresolved":true,"context_lines":[{"line_number":950,"context_line":"        # 3. Heal operation(\"all\" is not specified)"},{"line_number":951,"context_line":"        # VDU1-0 to heal"},{"line_number":952,"context_line":"        vnfc_info_id \u003d self._get_vnfc_info_id(inst_2, \u0027VDU1\u0027, 0)"},{"line_number":953,"context_line":"        heal_req[\u0027vnfcInstanceId\u0027] \u003d [vnfc_info_id]"},{"line_number":954,"context_line":"        del heal_req[\u0027additionalParams\u0027][\u0027all\u0027]"},{"line_number":955,"context_line":"        resp, body \u003d self.heal_vnf_instance(inst_id, heal_req)"},{"line_number":956,"context_line":"        self.assertEqual(202, resp.status_code)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fbb3d165_5f47e084","line":953,"updated":"2023-07-05 08:11:13.000000000","message":"ditto","commit_id":"a60ae747c7f5a491d34dd868ce9ec4c4d834065e"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"e67d06789d41be8cbceae4b52baf3199cc1482cc","unresolved":false,"context_lines":[{"line_number":950,"context_line":"        # 3. Heal operation(\"all\" is not specified)"},{"line_number":951,"context_line":"        # VDU1-0 to heal"},{"line_number":952,"context_line":"        vnfc_info_id \u003d self._get_vnfc_info_id(inst_2, \u0027VDU1\u0027, 0)"},{"line_number":953,"context_line":"        heal_req[\u0027vnfcInstanceId\u0027] \u003d [vnfc_info_id]"},{"line_number":954,"context_line":"        del heal_req[\u0027additionalParams\u0027][\u0027all\u0027]"},{"line_number":955,"context_line":"        resp, body \u003d self.heal_vnf_instance(inst_id, heal_req)"},{"line_number":956,"context_line":"        self.assertEqual(202, resp.status_code)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bcad8dc7_d29dcb73","line":953,"in_reply_to":"a0c9375d_b3c01c45","updated":"2023-07-06 05:07:20.000000000","message":"Done","commit_id":"a60ae747c7f5a491d34dd868ce9ec4c4d834065e"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"43a2da2fa335d16d79fa7b3bdb15e43c793d72dd","unresolved":true,"context_lines":[{"line_number":950,"context_line":"        # 3. Heal operation(\"all\" is not specified)"},{"line_number":951,"context_line":"        # VDU1-0 to heal"},{"line_number":952,"context_line":"        vnfc_info_id \u003d self._get_vnfc_info_id(inst_2, \u0027VDU1\u0027, 0)"},{"line_number":953,"context_line":"        heal_req[\u0027vnfcInstanceId\u0027] \u003d [vnfc_info_id]"},{"line_number":954,"context_line":"        del heal_req[\u0027additionalParams\u0027][\u0027all\u0027]"},{"line_number":955,"context_line":"        resp, body \u003d self.heal_vnf_instance(inst_id, heal_req)"},{"line_number":956,"context_line":"        self.assertEqual(202, resp.status_code)"}],"source_content_type":"text/x-python","patch_set":4,"id":"a0c9375d_b3c01c45","line":953,"in_reply_to":"fbb3d165_5f47e084","updated":"2023-07-06 01:40:52.000000000","message":"I will fix.","commit_id":"a60ae747c7f5a491d34dd868ce9ec4c4d834065e"}],"tacker/tests/functional/sol_v2_common/paramgen.py":[{"author":{"_account_id":31668,"deleted":true},"change_message_id":"810751861e55e65a7afe167a84befa33f81cb640","unresolved":true,"context_lines":[{"line_number":1762,"context_line":"    }"},{"line_number":1763,"context_line":""},{"line_number":1764,"context_line":""},{"line_number":1765,"context_line":"def sample7_heal():"},{"line_number":1766,"context_line":"    return {"},{"line_number":1767,"context_line":"        \"vnfcInstanceId\": [],  # should be filled"},{"line_number":1768,"context_line":"        \"additionalParams\": {"}],"source_content_type":"text/x-python","patch_set":2,"id":"d8bd9457_6a6ce8db","line":1765,"updated":"2023-06-15 06:38:25.000000000","message":"How about making it possible to set vnfc_id as an argument as L.604?\nhttps://review.opendev.org/c/openstack/tacker/+/885007/2/tacker/tests/functional/sol_v2_common/paramgen.py#604","commit_id":"0cc569569a8423982f09c95b2378a2f68b5eff45"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"a000ab6767003f5e0fd8e83addeb0420517af020","unresolved":false,"context_lines":[{"line_number":1762,"context_line":"    }"},{"line_number":1763,"context_line":""},{"line_number":1764,"context_line":""},{"line_number":1765,"context_line":"def sample7_heal():"},{"line_number":1766,"context_line":"    return {"},{"line_number":1767,"context_line":"        \"vnfcInstanceId\": [],  # should be filled"},{"line_number":1768,"context_line":"        \"additionalParams\": {"}],"source_content_type":"text/x-python","patch_set":2,"id":"22710f0d_f78c2842","line":1765,"in_reply_to":"80297fb8_9214e7ed","updated":"2023-06-20 07:01:42.000000000","message":"Done","commit_id":"0cc569569a8423982f09c95b2378a2f68b5eff45"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"19d38ad54ba51cb9f1a0c018d1bf54beb919c513","unresolved":true,"context_lines":[{"line_number":1762,"context_line":"    }"},{"line_number":1763,"context_line":""},{"line_number":1764,"context_line":""},{"line_number":1765,"context_line":"def sample7_heal():"},{"line_number":1766,"context_line":"    return {"},{"line_number":1767,"context_line":"        \"vnfcInstanceId\": [],  # should be filled"},{"line_number":1768,"context_line":"        \"additionalParams\": {"}],"source_content_type":"text/x-python","patch_set":2,"id":"80297fb8_9214e7ed","line":1765,"in_reply_to":"d8bd9457_6a6ce8db","updated":"2023-06-15 09:15:23.000000000","message":"I understand. I will add the vnfc_id as an argument.","commit_id":"0cc569569a8423982f09c95b2378a2f68b5eff45"}],"tacker/tests/functional/sol_v2_common/samples/userdata_standard_with_non_boot_volume/contents/Definitions/v2_sample7_types.yaml":[{"author":{"_account_id":31668,"deleted":true},"change_message_id":"810751861e55e65a7afe167a84befa33f81cb640","unresolved":true,"context_lines":[{"line_number":52,"context_line":"          capability: tosca.capabilities.nfv.VirtualLinkable"},{"line_number":53,"context_line":"    interfaces:"},{"line_number":54,"context_line":"      Vnflcm:"},{"line_number":55,"context_line":"        type: tosca.interfaces.nfv.Vnflcm"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ac86d1a9_3f05ceb1","line":55,"updated":"2023-06-15 06:38:25.000000000","message":"Adding a blank line is better.","commit_id":"0cc569569a8423982f09c95b2378a2f68b5eff45"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"19d38ad54ba51cb9f1a0c018d1bf54beb919c513","unresolved":true,"context_lines":[{"line_number":52,"context_line":"          capability: tosca.capabilities.nfv.VirtualLinkable"},{"line_number":53,"context_line":"    interfaces:"},{"line_number":54,"context_line":"      Vnflcm:"},{"line_number":55,"context_line":"        type: tosca.interfaces.nfv.Vnflcm"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"e84a3239_f725bd73","line":55,"in_reply_to":"ac86d1a9_3f05ceb1","updated":"2023-06-15 09:15:23.000000000","message":"I will fix.","commit_id":"0cc569569a8423982f09c95b2378a2f68b5eff45"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"a000ab6767003f5e0fd8e83addeb0420517af020","unresolved":false,"context_lines":[{"line_number":52,"context_line":"          capability: tosca.capabilities.nfv.VirtualLinkable"},{"line_number":53,"context_line":"    interfaces:"},{"line_number":54,"context_line":"      Vnflcm:"},{"line_number":55,"context_line":"        type: tosca.interfaces.nfv.Vnflcm"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"c42a28cc_a3317950","line":55,"in_reply_to":"e84a3239_f725bd73","updated":"2023-06-20 07:01:42.000000000","message":"Done","commit_id":"0cc569569a8423982f09c95b2378a2f68b5eff45"}],"tacker/tests/functional/sol_v2_common/samples/userdata_standard_with_non_boot_volume/contents/Scripts/coordinate_vnf.py":[{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"d57ffd0fe78fc501823cb3653f565bd409e23e92","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2022 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"7b2b8a0b_9e707c7c","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"updated":"2023-06-12 06:29:52.000000000","message":"nits: 2022 -\u003e 2023","commit_id":"50c60d70feef90007147040a86c34d0bf37b8b65"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"b9646718dce6caeca8ffc3a69613b98232f2af89","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2022 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"8a233d07_9ec6bf1a","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"in_reply_to":"7b2b8a0b_9e707c7c","updated":"2023-06-13 00:30:49.000000000","message":"I will fix.","commit_id":"50c60d70feef90007147040a86c34d0bf37b8b65"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"93b00cdbc63ff1a98a3dab5765f3d87e535f109a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2022 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"4d1c80b5_71aead74","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"in_reply_to":"8a233d07_9ec6bf1a","updated":"2023-06-15 19:16:54.000000000","message":"Done","commit_id":"50c60d70feef90007147040a86c34d0bf37b8b65"}],"tacker/tests/functional/sol_v2_common/samples/userdata_standard_with_non_boot_volume/contents/Scripts/sample_script.py":[{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"d57ffd0fe78fc501823cb3653f565bd409e23e92","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2022 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"8a067700_0c2610f7","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"updated":"2023-06-12 06:29:52.000000000","message":"nits: 2022 -\u003e 2023","commit_id":"50c60d70feef90007147040a86c34d0bf37b8b65"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"93b00cdbc63ff1a98a3dab5765f3d87e535f109a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2022 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"c7e47173_01bb0c92","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"in_reply_to":"053c2b17_561f442f","updated":"2023-06-15 19:16:54.000000000","message":"Done","commit_id":"50c60d70feef90007147040a86c34d0bf37b8b65"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"b9646718dce6caeca8ffc3a69613b98232f2af89","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2022 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"053c2b17_561f442f","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"in_reply_to":"8a067700_0c2610f7","updated":"2023-06-13 00:30:49.000000000","message":"I will fix.","commit_id":"50c60d70feef90007147040a86c34d0bf37b8b65"}],"tacker/tests/functional/sol_v2_common/samples/userdata_standard_with_non_boot_volume/pkggen.py":[{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"d57ffd0fe78fc501823cb3653f565bd409e23e92","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2022 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"cd84bd46_74e1564d","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"updated":"2023-06-12 06:29:52.000000000","message":"nits: 2022 -\u003e 2023","commit_id":"50c60d70feef90007147040a86c34d0bf37b8b65"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"b9646718dce6caeca8ffc3a69613b98232f2af89","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2022 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"f916970b_5092405c","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"in_reply_to":"cd84bd46_74e1564d","updated":"2023-06-13 00:30:49.000000000","message":"I will fix.","commit_id":"50c60d70feef90007147040a86c34d0bf37b8b65"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"93b00cdbc63ff1a98a3dab5765f3d87e535f109a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2022 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"8f67b771_eaca1aba","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"in_reply_to":"f916970b_5092405c","updated":"2023-06-15 19:16:54.000000000","message":"Done","commit_id":"50c60d70feef90007147040a86c34d0bf37b8b65"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"810751861e55e65a7afe167a84befa33f81cb640","unresolved":true,"context_lines":[{"line_number":56,"context_line":"    net_ids, subnet_ids, \"http://localhost/identity/v3\")"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"heal_req \u003d paramgen.sample7_heal()"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"with open(\"create_req\", \"w\") as f:"},{"line_number":61,"context_line":"    f.write(json.dumps(create_req, indent\u003d2))"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"afd73470_0157aca2","line":59,"updated":"2023-06-15 06:38:25.000000000","message":"How about displaying the contents about changing the vnfc id like below?\nhttps://opendev.org/openstack/tacker/src/branch/stable/2023.1/tacker/tests/functional/sol_v2_common/samples/basic_lcms_min/pkggen.py#L46-L48","commit_id":"0cc569569a8423982f09c95b2378a2f68b5eff45"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"a000ab6767003f5e0fd8e83addeb0420517af020","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    net_ids, subnet_ids, \"http://localhost/identity/v3\")"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"heal_req \u003d paramgen.sample7_heal()"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"with open(\"create_req\", \"w\") as f:"},{"line_number":61,"context_line":"    f.write(json.dumps(create_req, indent\u003d2))"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"0d539626_77338049","line":59,"in_reply_to":"4302735d_54e41ef6","updated":"2023-06-20 07:01:42.000000000","message":"Done","commit_id":"0cc569569a8423982f09c95b2378a2f68b5eff45"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"19d38ad54ba51cb9f1a0c018d1bf54beb919c513","unresolved":true,"context_lines":[{"line_number":56,"context_line":"    net_ids, subnet_ids, \"http://localhost/identity/v3\")"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"heal_req \u003d paramgen.sample7_heal()"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"with open(\"create_req\", \"w\") as f:"},{"line_number":61,"context_line":"    f.write(json.dumps(create_req, indent\u003d2))"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"4302735d_54e41ef6","line":59,"in_reply_to":"afd73470_0157aca2","updated":"2023-06-15 09:15:23.000000000","message":"I understand. I will add it.","commit_id":"0cc569569a8423982f09c95b2378a2f68b5eff45"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"a000ab6767003f5e0fd8e83addeb0420517af020","unresolved":true,"context_lines":[{"line_number":56,"context_line":"    net_ids, subnet_ids, \"http://localhost/identity/v3\")"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"# fake vnfc id, should be get from show vnf"},{"line_number":59,"context_line":"VNFC_ID \u003d \"VDU1-5a529de6-2d84-4dfb-8c61-3b4781af4d42\""},{"line_number":60,"context_line":"heal_req \u003d paramgen.sample7_heal(VNFC_ID)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"print(\u0027#####################################################################\\n\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"36fc393b_7759a47e","line":59,"updated":"2023-06-20 07:01:42.000000000","message":"I feel that \"a-001\" is better for the default.\nhttps://review.opendev.org/c/openstack/tacker/+/885007/3/tacker/tests/functional/sol_v2_common/paramgen.py#1699\nWhat do you think?","commit_id":"d3f3d5cf29ce2e7113dc2187a1634d99e8ac6012"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"f3b2048ea260c8ab9176441edbe6037696796968","unresolved":true,"context_lines":[{"line_number":56,"context_line":"    net_ids, subnet_ids, \"http://localhost/identity/v3\")"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"# fake vnfc id, should be get from show vnf"},{"line_number":59,"context_line":"VNFC_ID \u003d \"VDU1-5a529de6-2d84-4dfb-8c61-3b4781af4d42\""},{"line_number":60,"context_line":"heal_req \u003d paramgen.sample7_heal(VNFC_ID)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"print(\u0027#####################################################################\\n\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"91f4dc10_599c519b","line":59,"in_reply_to":"36fc393b_7759a47e","updated":"2023-06-20 09:13:12.000000000","message":"\"VDU_VNFc_mapping\" is set in this sample, so \"a-001\" is better. I will fix.","commit_id":"d3f3d5cf29ce2e7113dc2187a1634d99e8ac6012"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"d6d534ff1f64c02657d7e2ec1b50a1b167abfced","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    net_ids, subnet_ids, \"http://localhost/identity/v3\")"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"# fake vnfc id, should be get from show vnf"},{"line_number":59,"context_line":"VNFC_ID \u003d \"VDU1-5a529de6-2d84-4dfb-8c61-3b4781af4d42\""},{"line_number":60,"context_line":"heal_req \u003d paramgen.sample7_heal(VNFC_ID)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"print(\u0027#####################################################################\\n\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"0f802ac0_c9382893","line":59,"in_reply_to":"91f4dc10_599c519b","updated":"2023-07-05 08:11:13.000000000","message":"Done","commit_id":"d3f3d5cf29ce2e7113dc2187a1634d99e8ac6012"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"a000ab6767003f5e0fd8e83addeb0420517af020","unresolved":true,"context_lines":[{"line_number":72,"context_line":"with open(\"instantiate_req\", \"w\") as f:"},{"line_number":73,"context_line":"    f.write(json.dumps(instantiate_req, indent\u003d2))"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"# NOTE: vnfcInstanceId should be filled by hand"},{"line_number":76,"context_line":"with open(\"heal_req\", \"w\") as f:"},{"line_number":77,"context_line":"    f.write(json.dumps(heal_req, indent\u003d2))"}],"source_content_type":"text/x-python","patch_set":3,"id":"d5b1c24a_ac7ced3b","line":75,"updated":"2023-06-20 07:01:42.000000000","message":"Is it okay to leave this comment as is?","commit_id":"d3f3d5cf29ce2e7113dc2187a1634d99e8ac6012"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"f3b2048ea260c8ab9176441edbe6037696796968","unresolved":true,"context_lines":[{"line_number":72,"context_line":"with open(\"instantiate_req\", \"w\") as f:"},{"line_number":73,"context_line":"    f.write(json.dumps(instantiate_req, indent\u003d2))"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"# NOTE: vnfcInstanceId should be filled by hand"},{"line_number":76,"context_line":"with open(\"heal_req\", \"w\") as f:"},{"line_number":77,"context_line":"    f.write(json.dumps(heal_req, indent\u003d2))"}],"source_content_type":"text/x-python","patch_set":3,"id":"d8abc84f_597b6ae1","line":75,"in_reply_to":"d5b1c24a_ac7ced3b","updated":"2023-06-20 09:13:12.000000000","message":"It is not necessary. I will delete the comment.","commit_id":"d3f3d5cf29ce2e7113dc2187a1634d99e8ac6012"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"d6d534ff1f64c02657d7e2ec1b50a1b167abfced","unresolved":false,"context_lines":[{"line_number":72,"context_line":"with open(\"instantiate_req\", \"w\") as f:"},{"line_number":73,"context_line":"    f.write(json.dumps(instantiate_req, indent\u003d2))"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"# NOTE: vnfcInstanceId should be filled by hand"},{"line_number":76,"context_line":"with open(\"heal_req\", \"w\") as f:"},{"line_number":77,"context_line":"    f.write(json.dumps(heal_req, indent\u003d2))"}],"source_content_type":"text/x-python","patch_set":3,"id":"17156e1a_54714959","line":75,"in_reply_to":"d8abc84f_597b6ae1","updated":"2023-07-05 08:11:13.000000000","message":"Done","commit_id":"d3f3d5cf29ce2e7113dc2187a1634d99e8ac6012"}]}
