)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":31668,"deleted":true},"change_message_id":"f0c74ffa36dba9faaa7e7c202e8d6ca2144d1e44","unresolved":true,"context_lines":[{"line_number":11,"context_line":"Also refactor the functions related to"},{"line_number":12,"context_line":"SubscriptionAuthentication in common_script_utils."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Implements: blueprint support-oauth2-mtls"},{"line_number":15,"context_line":"Change-Id: I9bcf4957ac8b173695e416fd56a0c3f3065e0c9f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"71b028b6_bfc07d79","line":14,"updated":"2023-07-13 05:47:27.000000000","message":"Why are the Blueprints different for Topic and CommitMeseage?","commit_id":"c4a4a7c4f575c00418358e66c06c24abd6bf4f58"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"9f4803b0463b8f56b82cb6eb13173111d8cae96a","unresolved":false,"context_lines":[{"line_number":11,"context_line":"Also refactor the functions related to"},{"line_number":12,"context_line":"SubscriptionAuthentication in common_script_utils."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Implements: blueprint support-oauth2-mtls"},{"line_number":15,"context_line":"Change-Id: I9bcf4957ac8b173695e416fd56a0c3f3065e0c9f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ade12cd6_dbb068db","line":14,"in_reply_to":"3118ee0a_c8d29357","updated":"2023-08-09 06:48:51.000000000","message":"Done","commit_id":"c4a4a7c4f575c00418358e66c06c24abd6bf4f58"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"1c9f1f7510f6c2d7caa150daf23c7e319fb6f7b7","unresolved":true,"context_lines":[{"line_number":11,"context_line":"Also refactor the functions related to"},{"line_number":12,"context_line":"SubscriptionAuthentication in common_script_utils."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Implements: blueprint support-oauth2-mtls"},{"line_number":15,"context_line":"Change-Id: I9bcf4957ac8b173695e416fd56a0c3f3065e0c9f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"cf3692ba_1bee1360","line":14,"in_reply_to":"71b028b6_bfc07d79","updated":"2023-07-19 08:59:20.000000000","message":"The TOPIC name matches the following patch.\n\nhttps://review.opendev.org/c/openstack/tacker/+/861323","commit_id":"c4a4a7c4f575c00418358e66c06c24abd6bf4f58"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"443c465cb83141d412621f8e524c48fd98769617","unresolved":true,"context_lines":[{"line_number":11,"context_line":"Also refactor the functions related to"},{"line_number":12,"context_line":"SubscriptionAuthentication in common_script_utils."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Implements: blueprint support-oauth2-mtls"},{"line_number":15,"context_line":"Change-Id: I9bcf4957ac8b173695e416fd56a0c3f3065e0c9f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"dafc9c52_b67dfb45","line":14,"in_reply_to":"cf3692ba_1bee1360","updated":"2023-08-08 05:34:18.000000000","message":"Thank you for your explanation.\nCould you add the following to CommitMessage?\n* Implements: blueprint enhance-http-client","commit_id":"c4a4a7c4f575c00418358e66c06c24abd6bf4f58"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"18bed69451b7d9cc067c78ed842c569b9b1f8e44","unresolved":true,"context_lines":[{"line_number":11,"context_line":"Also refactor the functions related to"},{"line_number":12,"context_line":"SubscriptionAuthentication in common_script_utils."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Implements: blueprint support-oauth2-mtls"},{"line_number":15,"context_line":"Change-Id: I9bcf4957ac8b173695e416fd56a0c3f3065e0c9f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3118ee0a_c8d29357","line":14,"in_reply_to":"dafc9c52_b67dfb45","updated":"2023-08-08 06:25:47.000000000","message":"OK, I will add.","commit_id":"c4a4a7c4f575c00418358e66c06c24abd6bf4f58"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"777d13456da0e90f51da1395d29014cbdf0d0ee0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e32a37ff_d266a93d","updated":"2023-07-04 01:38:33.000000000","message":"Please kindly review the patch.","commit_id":"77babfb242fc87a6ebe81ff9dd269644d0ac1f69"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"a30a0a590f0606d4ffffd72aed45af506ea1e3cd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"247fe230_8820da8c","updated":"2023-07-04 08:05:49.000000000","message":"Thank you for the review.","commit_id":"77babfb242fc87a6ebe81ff9dd269644d0ac1f69"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"eed90633aca9682315d53bd00bc3711cb40e74a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"acde4518_25aaab13","updated":"2023-07-04 01:37:32.000000000","message":"Thanks for your patch. Please kindly check my comments.","commit_id":"77babfb242fc87a6ebe81ff9dd269644d0ac1f69"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"1c9f1f7510f6c2d7caa150daf23c7e319fb6f7b7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c5d12bb5_eb5f8939","updated":"2023-07-19 08:59:20.000000000","message":"Thank you for review.","commit_id":"c4a4a7c4f575c00418358e66c06c24abd6bf4f58"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"82936eb67ff98ed8e102fad692f220ffe873cc26","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8e5db2d7_c4448baf","updated":"2023-07-05 12:54:51.000000000","message":"Thanks for your re-work!","commit_id":"c4a4a7c4f575c00418358e66c06c24abd6bf4f58"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"eba1acc7bb46491924ed0c4e0bb2804237b383ed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"07b81870_5dd50877","updated":"2023-07-25 03:17:16.000000000","message":"Thank you for the review.","commit_id":"369c77649be9485763fa196b2f30f16fc68683a8"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"18bed69451b7d9cc067c78ed842c569b9b1f8e44","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"fa78d70a_fa8d620f","updated":"2023-08-08 06:25:47.000000000","message":"Thank you for the review.","commit_id":"654242b3a33d13ceca1dcdc94dece2966d88a949"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"b7350efd3d623e264defddf60f8caa8d0b694c42","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"6a098155_fb0c4924","updated":"2023-08-03 22:08:32.000000000","message":"recheck infra-failure","commit_id":"654242b3a33d13ceca1dcdc94dece2966d88a949"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"1954bdf07f896004b58f89451808461b00cb0869","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"bd51106a_c94a6b0a","updated":"2023-08-03 04:08:47.000000000","message":"recheck infra-failure","commit_id":"654242b3a33d13ceca1dcdc94dece2966d88a949"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"430b99674e1c6dab44e76a109e1c902a039132ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"0451287a_8ac0a0f8","updated":"2023-08-09 07:21:41.000000000","message":"Thank you for the review.","commit_id":"1f4be9dd7963389c95f8d392bea65b50fef65138"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"8b1435aaa6f1d5d374c972b52ee7573c11f0b210","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"3f585490_693a0e4a","updated":"2023-08-09 03:05:06.000000000","message":"recheck infra-failure","commit_id":"1f4be9dd7963389c95f8d392bea65b50fef65138"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"937055fbcf02b3463116185d80332bff8075ef7a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"5e5f5019_847ca362","updated":"2023-08-09 00:45:11.000000000","message":"recheck infra-failure","commit_id":"1f4be9dd7963389c95f8d392bea65b50fef65138"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"4d9740b9195c208487217bff22bc7a3c2a69ff3d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"7f31c82b_b31c82fb","updated":"2023-08-08 21:59:38.000000000","message":"recheck infra-failure","commit_id":"1f4be9dd7963389c95f8d392bea65b50fef65138"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"dbc94fb0753e960e6f486217c7eaa31e68378a7f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"6ebaf792_81596e70","updated":"2023-08-28 23:32:02.000000000","message":"LGTM","commit_id":"73d3273ba98d400da9eb0df276e0abf736f83d3b"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"d0faca57047ce3e9bbbebb7964987202d8c75c27","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"38d00fb1_d02bdc39","updated":"2023-09-05 01:03:38.000000000","message":"Thank you for the review.","commit_id":"73d3273ba98d400da9eb0df276e0abf736f83d3b"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"f2822940880c086fb07887a428fc4ebfc638d8dc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"e707bba2_cc4f0202","updated":"2023-09-04 12:49:47.000000000","message":"Thanks for your patch, please kindly find my comment.","commit_id":"73d3273ba98d400da9eb0df276e0abf736f83d3b"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"51a28f65a76db20c5394e9af7675c8ebd77f4900","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"ab0d0022_f058d55a","updated":"2023-09-06 04:24:28.000000000","message":"Thanks for your rework, LGTM.","commit_id":"2455d3f720bb8f5788e0f5b5311abba30a9f8359"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"b1194f73c4dea4d73d22ceb9b1e0b82827afa2a2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"24633880_e04c2262","updated":"2023-09-06 01:35:24.000000000","message":"recheck infra-failure","commit_id":"2455d3f720bb8f5788e0f5b5311abba30a9f8359"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"a71d75822a11d33e606c89b87c4c03b87f37b241","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"ec4cf222_88104d49","updated":"2023-09-05 12:14:01.000000000","message":"recheck infra-failure","commit_id":"2455d3f720bb8f5788e0f5b5311abba30a9f8359"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"c5b5b12fb5aa8d6b9dc2f86e423a6320c33ba39d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"f8c9eecd_084ef0a7","updated":"2023-09-05 23:01:10.000000000","message":"recheck infra-failure","commit_id":"2455d3f720bb8f5788e0f5b5311abba30a9f8359"}],"tacker/sol_refactored/common/common_script_utils.py":[{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"eed90633aca9682315d53bd00bc3711cb40e74a8","unresolved":true,"context_lines":[{"line_number":339,"context_line":""},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"def get_http_auth_handle(auth_req):"},{"line_number":342,"context_line":"    # NOTE: this method use tacker configration. script should do"},{"line_number":343,"context_line":"    # following before calling this method."},{"line_number":344,"context_line":"    # ---"},{"line_number":345,"context_line":"    # from tacker.common import config"}],"source_content_type":"text/x-python","patch_set":3,"id":"e326f63b_e8956bd7","line":342,"range":{"start_line":342,"start_character":63,"end_line":342,"end_character":65},"updated":"2023-07-04 01:37:32.000000000","message":"Use `set` instead of `do`?","commit_id":"77babfb242fc87a6ebe81ff9dd269644d0ac1f69"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"eed90633aca9682315d53bd00bc3711cb40e74a8","unresolved":true,"context_lines":[{"line_number":339,"context_line":""},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"def get_http_auth_handle(auth_req):"},{"line_number":342,"context_line":"    # NOTE: this method use tacker configration. script should do"},{"line_number":343,"context_line":"    # following before calling this method."},{"line_number":344,"context_line":"    # ---"},{"line_number":345,"context_line":"    # from tacker.common import config"}],"source_content_type":"text/x-python","patch_set":3,"id":"10692c1b_77bfe11a","line":342,"range":{"start_line":342,"start_character":24,"end_line":342,"end_character":27},"updated":"2023-07-04 01:37:32.000000000","message":"nits: use -\u003e uses","commit_id":"77babfb242fc87a6ebe81ff9dd269644d0ac1f69"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"a30a0a590f0606d4ffffd72aed45af506ea1e3cd","unresolved":true,"context_lines":[{"line_number":339,"context_line":""},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"def get_http_auth_handle(auth_req):"},{"line_number":342,"context_line":"    # NOTE: this method use tacker configration. script should do"},{"line_number":343,"context_line":"    # following before calling this method."},{"line_number":344,"context_line":"    # ---"},{"line_number":345,"context_line":"    # from tacker.common import config"}],"source_content_type":"text/x-python","patch_set":3,"id":"53dd3024_e5d6e8f6","line":342,"range":{"start_line":342,"start_character":24,"end_line":342,"end_character":27},"in_reply_to":"10692c1b_77bfe11a","updated":"2023-07-04 08:05:49.000000000","message":"I will fix.","commit_id":"77babfb242fc87a6ebe81ff9dd269644d0ac1f69"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"82936eb67ff98ed8e102fad692f220ffe873cc26","unresolved":false,"context_lines":[{"line_number":339,"context_line":""},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"def get_http_auth_handle(auth_req):"},{"line_number":342,"context_line":"    # NOTE: this method use tacker configration. script should do"},{"line_number":343,"context_line":"    # following before calling this method."},{"line_number":344,"context_line":"    # ---"},{"line_number":345,"context_line":"    # from tacker.common import config"}],"source_content_type":"text/x-python","patch_set":3,"id":"17c4144f_1c3b9fac","line":342,"range":{"start_line":342,"start_character":24,"end_line":342,"end_character":27},"in_reply_to":"53dd3024_e5d6e8f6","updated":"2023-07-05 12:54:51.000000000","message":"Done","commit_id":"77babfb242fc87a6ebe81ff9dd269644d0ac1f69"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"82936eb67ff98ed8e102fad692f220ffe873cc26","unresolved":false,"context_lines":[{"line_number":339,"context_line":""},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"def get_http_auth_handle(auth_req):"},{"line_number":342,"context_line":"    # NOTE: this method use tacker configration. script should do"},{"line_number":343,"context_line":"    # following before calling this method."},{"line_number":344,"context_line":"    # ---"},{"line_number":345,"context_line":"    # from tacker.common import config"}],"source_content_type":"text/x-python","patch_set":3,"id":"ecbcecb9_b98d16b1","line":342,"range":{"start_line":342,"start_character":63,"end_line":342,"end_character":65},"in_reply_to":"af726a2c_b5801008","updated":"2023-07-05 12:54:51.000000000","message":"Done","commit_id":"77babfb242fc87a6ebe81ff9dd269644d0ac1f69"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"a30a0a590f0606d4ffffd72aed45af506ea1e3cd","unresolved":true,"context_lines":[{"line_number":339,"context_line":""},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"def get_http_auth_handle(auth_req):"},{"line_number":342,"context_line":"    # NOTE: this method use tacker configration. script should do"},{"line_number":343,"context_line":"    # following before calling this method."},{"line_number":344,"context_line":"    # ---"},{"line_number":345,"context_line":"    # from tacker.common import config"}],"source_content_type":"text/x-python","patch_set":3,"id":"af726a2c_b5801008","line":342,"range":{"start_line":342,"start_character":63,"end_line":342,"end_character":65},"in_reply_to":"e326f63b_e8956bd7","updated":"2023-07-04 08:05:49.000000000","message":"I will fix.","commit_id":"77babfb242fc87a6ebe81ff9dd269644d0ac1f69"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"eed90633aca9682315d53bd00bc3711cb40e74a8","unresolved":true,"context_lines":[{"line_number":340,"context_line":""},{"line_number":341,"context_line":"def get_http_auth_handle(auth_req):"},{"line_number":342,"context_line":"    # NOTE: this method use tacker configration. script should do"},{"line_number":343,"context_line":"    # following before calling this method."},{"line_number":344,"context_line":"    # ---"},{"line_number":345,"context_line":"    # from tacker.common import config"},{"line_number":346,"context_line":"    # args \u003d [\"--config-file\", \"/etc/tacker/tacker.conf\"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"8ec3ba2a_550d6619","line":343,"range":{"start_line":343,"start_character":6,"end_line":343,"end_character":15},"updated":"2023-07-04 01:37:32.000000000","message":"nits: following -\u003e the following parameters","commit_id":"77babfb242fc87a6ebe81ff9dd269644d0ac1f69"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"82936eb67ff98ed8e102fad692f220ffe873cc26","unresolved":false,"context_lines":[{"line_number":340,"context_line":""},{"line_number":341,"context_line":"def get_http_auth_handle(auth_req):"},{"line_number":342,"context_line":"    # NOTE: this method use tacker configration. script should do"},{"line_number":343,"context_line":"    # following before calling this method."},{"line_number":344,"context_line":"    # ---"},{"line_number":345,"context_line":"    # from tacker.common import config"},{"line_number":346,"context_line":"    # args \u003d [\"--config-file\", \"/etc/tacker/tacker.conf\"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"edd7ca51_53f55101","line":343,"range":{"start_line":343,"start_character":6,"end_line":343,"end_character":15},"in_reply_to":"535897be_e461c670","updated":"2023-07-05 12:54:51.000000000","message":"Done","commit_id":"77babfb242fc87a6ebe81ff9dd269644d0ac1f69"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"a30a0a590f0606d4ffffd72aed45af506ea1e3cd","unresolved":true,"context_lines":[{"line_number":340,"context_line":""},{"line_number":341,"context_line":"def get_http_auth_handle(auth_req):"},{"line_number":342,"context_line":"    # NOTE: this method use tacker configration. script should do"},{"line_number":343,"context_line":"    # following before calling this method."},{"line_number":344,"context_line":"    # ---"},{"line_number":345,"context_line":"    # from tacker.common import config"},{"line_number":346,"context_line":"    # args \u003d [\"--config-file\", \"/etc/tacker/tacker.conf\"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"535897be_e461c670","line":343,"range":{"start_line":343,"start_character":6,"end_line":343,"end_character":15},"in_reply_to":"8ec3ba2a_550d6619","updated":"2023-07-04 08:05:49.000000000","message":"I will fix.","commit_id":"77babfb242fc87a6ebe81ff9dd269644d0ac1f69"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"f0c74ffa36dba9faaa7e7c202e8d6ca2144d1e44","unresolved":true,"context_lines":[{"line_number":309,"context_line":"            msg \u003d \"paramsOauth2ClientCert must be specified.\""},{"line_number":310,"context_line":"            raise sol_ex.InvalidSubscription(sol_detail\u003dmsg)"},{"line_number":311,"context_line":"        client_cert_file \u003d CONF.v2_vnfm.notification_mtls_client_cert_file"},{"line_number":312,"context_line":"        cert_ref \u003d oauth2_mtls_req.get(\u0027certificateRef\u0027, {})"},{"line_number":313,"context_line":"        if cert_ref.get(\u0027type\u0027) \u003d\u003d \u0027x5t#S256\u0027:"},{"line_number":314,"context_line":"            hash_type \u003d hashes.SHA256()"},{"line_number":315,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"105cb34f_c654f3c5","line":312,"updated":"2023-07-13 05:47:27.000000000","message":"Could you please correct the object?\n* typo: cerficateRef -\u003e certificateRef\n* https://opendev.org/openstack/tacker/src/branch/master/tacker/sol_refactored/objects/common/subscription_authentication.py#L88\n\nThe version of SOL is also wrong, so please correct the comment.\n* v3.4.1 -\u003e v3.5.1\n* https://opendev.org/openstack/tacker/src/branch/master/tacker/sol_refactored/objects/common/subscription_authentication.py#L21","commit_id":"c4a4a7c4f575c00418358e66c06c24abd6bf4f58"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"1c9f1f7510f6c2d7caa150daf23c7e319fb6f7b7","unresolved":true,"context_lines":[{"line_number":309,"context_line":"            msg \u003d \"paramsOauth2ClientCert must be specified.\""},{"line_number":310,"context_line":"            raise sol_ex.InvalidSubscription(sol_detail\u003dmsg)"},{"line_number":311,"context_line":"        client_cert_file \u003d CONF.v2_vnfm.notification_mtls_client_cert_file"},{"line_number":312,"context_line":"        cert_ref \u003d oauth2_mtls_req.get(\u0027certificateRef\u0027, {})"},{"line_number":313,"context_line":"        if cert_ref.get(\u0027type\u0027) \u003d\u003d \u0027x5t#S256\u0027:"},{"line_number":314,"context_line":"            hash_type \u003d hashes.SHA256()"},{"line_number":315,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"bc8dfc01_a97c24b8","line":312,"in_reply_to":"105cb34f_c654f3c5","updated":"2023-07-19 08:59:20.000000000","message":"Okay. I will fix.","commit_id":"c4a4a7c4f575c00418358e66c06c24abd6bf4f58"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"5e61c8d45cd56288e45d6e3186147217b713c2ed","unresolved":false,"context_lines":[{"line_number":309,"context_line":"            msg \u003d \"paramsOauth2ClientCert must be specified.\""},{"line_number":310,"context_line":"            raise sol_ex.InvalidSubscription(sol_detail\u003dmsg)"},{"line_number":311,"context_line":"        client_cert_file \u003d CONF.v2_vnfm.notification_mtls_client_cert_file"},{"line_number":312,"context_line":"        cert_ref \u003d oauth2_mtls_req.get(\u0027certificateRef\u0027, {})"},{"line_number":313,"context_line":"        if cert_ref.get(\u0027type\u0027) \u003d\u003d \u0027x5t#S256\u0027:"},{"line_number":314,"context_line":"            hash_type \u003d hashes.SHA256()"},{"line_number":315,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"ab69ebf0_7ba8a1b0","line":312,"in_reply_to":"bc8dfc01_a97c24b8","updated":"2023-07-21 04:28:13.000000000","message":"Done","commit_id":"c4a4a7c4f575c00418358e66c06c24abd6bf4f58"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"9f4803b0463b8f56b82cb6eb13173111d8cae96a","unresolved":true,"context_lines":[{"line_number":339,"context_line":""},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"def get_http_auth_handle(auth_req):"},{"line_number":342,"context_line":"    # NOTE: this method uses tacker configration. script should set"},{"line_number":343,"context_line":"    # the following parameters before calling this method."},{"line_number":344,"context_line":"    # ---"},{"line_number":345,"context_line":"    # from tacker.common import config"}],"source_content_type":"text/x-python","patch_set":7,"id":"09418789_109ca65e","line":342,"updated":"2023-08-09 06:48:51.000000000","message":"typo: configration -\u003e configuration","commit_id":"1f4be9dd7963389c95f8d392bea65b50fef65138"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"430b99674e1c6dab44e76a109e1c902a039132ab","unresolved":true,"context_lines":[{"line_number":339,"context_line":""},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"def get_http_auth_handle(auth_req):"},{"line_number":342,"context_line":"    # NOTE: this method uses tacker configration. script should set"},{"line_number":343,"context_line":"    # the following parameters before calling this method."},{"line_number":344,"context_line":"    # ---"},{"line_number":345,"context_line":"    # from tacker.common import config"}],"source_content_type":"text/x-python","patch_set":7,"id":"d8b8bcfb_264010a3","line":342,"in_reply_to":"09418789_109ca65e","updated":"2023-08-09 07:21:41.000000000","message":"I will fix.","commit_id":"1f4be9dd7963389c95f8d392bea65b50fef65138"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"71126ea942be36054054ee2ab54de13ba9456d6e","unresolved":false,"context_lines":[{"line_number":339,"context_line":""},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"def get_http_auth_handle(auth_req):"},{"line_number":342,"context_line":"    # NOTE: this method uses tacker configration. script should set"},{"line_number":343,"context_line":"    # the following parameters before calling this method."},{"line_number":344,"context_line":"    # ---"},{"line_number":345,"context_line":"    # from tacker.common import config"}],"source_content_type":"text/x-python","patch_set":7,"id":"167a881e_938c110d","line":342,"in_reply_to":"d8b8bcfb_264010a3","updated":"2023-08-09 07:52:21.000000000","message":"Done","commit_id":"1f4be9dd7963389c95f8d392bea65b50fef65138"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"f2822940880c086fb07887a428fc4ebfc638d8dc","unresolved":true,"context_lines":[{"line_number":334,"context_line":"    if \u0027BASIC\u0027 in auth_type:"},{"line_number":335,"context_line":"        basic_req \u003d auth_req.get(\u0027paramsBasic\u0027)"},{"line_number":336,"context_line":"        if basic_req is None:"},{"line_number":337,"context_line":"            msg \u003d \"ParamsBasic must be specified.\""},{"line_number":338,"context_line":"            raise sol_ex.InvalidSubscription(sol_detail\u003dmsg)"},{"line_number":339,"context_line":""},{"line_number":340,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"1f2f3d67_dd3eb556","line":337,"range":{"start_line":337,"start_character":19,"end_line":337,"end_character":30},"updated":"2023-09-04 12:49:47.000000000","message":"Could you change to `paramsBasic`?","commit_id":"73d3273ba98d400da9eb0df276e0abf736f83d3b"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"d0faca57047ce3e9bbbebb7964987202d8c75c27","unresolved":true,"context_lines":[{"line_number":334,"context_line":"    if \u0027BASIC\u0027 in auth_type:"},{"line_number":335,"context_line":"        basic_req \u003d auth_req.get(\u0027paramsBasic\u0027)"},{"line_number":336,"context_line":"        if basic_req is None:"},{"line_number":337,"context_line":"            msg \u003d \"ParamsBasic must be specified.\""},{"line_number":338,"context_line":"            raise sol_ex.InvalidSubscription(sol_detail\u003dmsg)"},{"line_number":339,"context_line":""},{"line_number":340,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"5a6afe83_3e4724ff","line":337,"range":{"start_line":337,"start_character":19,"end_line":337,"end_character":30},"in_reply_to":"1f2f3d67_dd3eb556","updated":"2023-09-05 01:03:38.000000000","message":"I understand. I will fix it.","commit_id":"73d3273ba98d400da9eb0df276e0abf736f83d3b"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"51a28f65a76db20c5394e9af7675c8ebd77f4900","unresolved":false,"context_lines":[{"line_number":334,"context_line":"    if \u0027BASIC\u0027 in auth_type:"},{"line_number":335,"context_line":"        basic_req \u003d auth_req.get(\u0027paramsBasic\u0027)"},{"line_number":336,"context_line":"        if basic_req is None:"},{"line_number":337,"context_line":"            msg \u003d \"ParamsBasic must be specified.\""},{"line_number":338,"context_line":"            raise sol_ex.InvalidSubscription(sol_detail\u003dmsg)"},{"line_number":339,"context_line":""},{"line_number":340,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"8789daae_fbba111b","line":337,"range":{"start_line":337,"start_character":19,"end_line":337,"end_character":30},"in_reply_to":"5a6afe83_3e4724ff","updated":"2023-09-06 04:24:28.000000000","message":"Ack","commit_id":"73d3273ba98d400da9eb0df276e0abf736f83d3b"}],"tacker/tests/unit/sol_refactored/common/test_subscription_utils.py":[{"author":{"_account_id":31668,"deleted":true},"change_message_id":"f0c74ffa36dba9faaa7e7c202e8d6ca2144d1e44","unresolved":true,"context_lines":[{"line_number":338,"context_line":"            id\u003duuidutils.generate_uuid()"},{"line_number":339,"context_line":"        )"},{"line_number":340,"context_line":"        resp_no_auth \u003d requests.Response()"},{"line_number":341,"context_line":"        resp_no_auth.status_code \u003d 200"},{"line_number":342,"context_line":"        mock_resp.return_value \u003d (resp_no_auth, None)"},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"        # execute no_auth"}],"source_content_type":"text/x-python","patch_set":4,"id":"5184d363_65fe0cf0","line":341,"updated":"2023-07-13 05:47:27.000000000","message":"Isn\u0027t the status code 204 instead of 200?","commit_id":"c4a4a7c4f575c00418358e66c06c24abd6bf4f58"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"1c9f1f7510f6c2d7caa150daf23c7e319fb6f7b7","unresolved":true,"context_lines":[{"line_number":338,"context_line":"            id\u003duuidutils.generate_uuid()"},{"line_number":339,"context_line":"        )"},{"line_number":340,"context_line":"        resp_no_auth \u003d requests.Response()"},{"line_number":341,"context_line":"        resp_no_auth.status_code \u003d 200"},{"line_number":342,"context_line":"        mock_resp.return_value \u003d (resp_no_auth, None)"},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"        # execute no_auth"}],"source_content_type":"text/x-python","patch_set":4,"id":"f7a6cb56_2df5c5dd","line":341,"in_reply_to":"5184d363_65fe0cf0","updated":"2023-07-19 08:59:20.000000000","message":"It is incorrect. The Status will be corrected to 204.","commit_id":"c4a4a7c4f575c00418358e66c06c24abd6bf4f58"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"c66b56e800e14703c9e58454e6e812f63b465c0c","unresolved":false,"context_lines":[{"line_number":338,"context_line":"            id\u003duuidutils.generate_uuid()"},{"line_number":339,"context_line":"        )"},{"line_number":340,"context_line":"        resp_no_auth \u003d requests.Response()"},{"line_number":341,"context_line":"        resp_no_auth.status_code \u003d 200"},{"line_number":342,"context_line":"        mock_resp.return_value \u003d (resp_no_auth, None)"},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"        # execute no_auth"}],"source_content_type":"text/x-python","patch_set":4,"id":"b09e098d_2ac08062","line":341,"in_reply_to":"f7a6cb56_2df5c5dd","updated":"2023-07-25 09:39:46.000000000","message":"I have confirmed that the test has been removed on PS5.","commit_id":"c4a4a7c4f575c00418358e66c06c24abd6bf4f58"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"f0c74ffa36dba9faaa7e7c202e8d6ca2144d1e44","unresolved":true,"context_lines":[{"line_number":342,"context_line":"        mock_resp.return_value \u003d (resp_no_auth, None)"},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"        # execute no_auth"},{"line_number":345,"context_line":"        subsc_utils.send_notification(subsc_no_auth, notif_data_no_auth)"},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"        subsc_basic_auth \u003d objects.LccnSubscriptionV2("},{"line_number":348,"context_line":"            id\u003d\u0027sub-2\u0027, verbosity\u003d\u0027SHORT\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"8f79c957_49cb20e0","line":345,"updated":"2023-07-13 05:47:27.000000000","message":"Is it okay to not check whether the notification has been sent?","commit_id":"c4a4a7c4f575c00418358e66c06c24abd6bf4f58"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"c66b56e800e14703c9e58454e6e812f63b465c0c","unresolved":false,"context_lines":[{"line_number":342,"context_line":"        mock_resp.return_value \u003d (resp_no_auth, None)"},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"        # execute no_auth"},{"line_number":345,"context_line":"        subsc_utils.send_notification(subsc_no_auth, notif_data_no_auth)"},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"        subsc_basic_auth \u003d objects.LccnSubscriptionV2("},{"line_number":348,"context_line":"            id\u003d\u0027sub-2\u0027, verbosity\u003d\u0027SHORT\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3c3b8cc5_d8ebbb12","line":345,"in_reply_to":"08eb5bae_3016be0c","updated":"2023-07-25 09:39:46.000000000","message":"Ack","commit_id":"c4a4a7c4f575c00418358e66c06c24abd6bf4f58"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"1c9f1f7510f6c2d7caa150daf23c7e319fb6f7b7","unresolved":true,"context_lines":[{"line_number":342,"context_line":"        mock_resp.return_value \u003d (resp_no_auth, None)"},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"        # execute no_auth"},{"line_number":345,"context_line":"        subsc_utils.send_notification(subsc_no_auth, notif_data_no_auth)"},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"        subsc_basic_auth \u003d objects.LccnSubscriptionV2("},{"line_number":348,"context_line":"            id\u003d\u0027sub-2\u0027, verbosity\u003d\u0027SHORT\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"08eb5bae_3016be0c","line":345,"in_reply_to":"8f79c957_49cb20e0","updated":"2023-07-19 08:59:20.000000000","message":"Add a check that the request sending(\u0027do_request\u0027) is called.\nAlso, since the auth_handle check is tested in test_common_script_utils \"test_get_http_auth_handle\", this test will be changed to test only one case.","commit_id":"c4a4a7c4f575c00418358e66c06c24abd6bf4f58"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"f0c74ffa36dba9faaa7e7c202e8d6ca2144d1e44","unresolved":true,"context_lines":[{"line_number":353,"context_line":"                    userName\u003d\u0027test\u0027, password\u003d\u0027test\u0027)))"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"        # execute basic_auth"},{"line_number":356,"context_line":"        subsc_utils.send_notification(subsc_basic_auth, notif_data_no_auth)"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"        subsc_oauth2 \u003d objects.LccnSubscriptionV2("},{"line_number":359,"context_line":"            id\u003d\u0027sub-3\u0027, verbosity\u003d\u0027SHORT\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"c8e7eb2e_f1196dd3","line":356,"updated":"2023-07-13 05:47:27.000000000","message":"ditto","commit_id":"c4a4a7c4f575c00418358e66c06c24abd6bf4f58"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"c66b56e800e14703c9e58454e6e812f63b465c0c","unresolved":false,"context_lines":[{"line_number":353,"context_line":"                    userName\u003d\u0027test\u0027, password\u003d\u0027test\u0027)))"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"        # execute basic_auth"},{"line_number":356,"context_line":"        subsc_utils.send_notification(subsc_basic_auth, notif_data_no_auth)"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"        subsc_oauth2 \u003d objects.LccnSubscriptionV2("},{"line_number":359,"context_line":"            id\u003d\u0027sub-3\u0027, verbosity\u003d\u0027SHORT\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"8a176096_dd54db39","line":356,"in_reply_to":"7d95cc98_c7841177","updated":"2023-07-25 09:39:46.000000000","message":"I have confirmed that the test has been removed on PS5.","commit_id":"c4a4a7c4f575c00418358e66c06c24abd6bf4f58"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"1c9f1f7510f6c2d7caa150daf23c7e319fb6f7b7","unresolved":true,"context_lines":[{"line_number":353,"context_line":"                    userName\u003d\u0027test\u0027, password\u003d\u0027test\u0027)))"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"        # execute basic_auth"},{"line_number":356,"context_line":"        subsc_utils.send_notification(subsc_basic_auth, notif_data_no_auth)"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"        subsc_oauth2 \u003d objects.LccnSubscriptionV2("},{"line_number":359,"context_line":"            id\u003d\u0027sub-3\u0027, verbosity\u003d\u0027SHORT\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7d95cc98_c7841177","line":356,"in_reply_to":"c8e7eb2e_f1196dd3","updated":"2023-07-19 08:59:20.000000000","message":"ditto","commit_id":"c4a4a7c4f575c00418358e66c06c24abd6bf4f58"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"f0c74ffa36dba9faaa7e7c202e8d6ca2144d1e44","unresolved":true,"context_lines":[{"line_number":366,"context_line":"                        tokenEndpoint\u003d\u0027http://127.0.0.1/token\u0027))))"},{"line_number":367,"context_line":""},{"line_number":368,"context_line":"        # execute oauth2"},{"line_number":369,"context_line":"        subsc_utils.send_notification(subsc_oauth2, notif_data_no_auth)"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"        subsc_oauth2_mtls \u003d objects.LccnSubscriptionV2("},{"line_number":372,"context_line":"            id\u003d\u0027sub-4\u0027, verbosity\u003d\u0027SHORT\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7dcc1fee_67b07c1c","line":369,"updated":"2023-07-13 05:47:27.000000000","message":"ditto","commit_id":"c4a4a7c4f575c00418358e66c06c24abd6bf4f58"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"1c9f1f7510f6c2d7caa150daf23c7e319fb6f7b7","unresolved":true,"context_lines":[{"line_number":366,"context_line":"                        tokenEndpoint\u003d\u0027http://127.0.0.1/token\u0027))))"},{"line_number":367,"context_line":""},{"line_number":368,"context_line":"        # execute oauth2"},{"line_number":369,"context_line":"        subsc_utils.send_notification(subsc_oauth2, notif_data_no_auth)"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"        subsc_oauth2_mtls \u003d objects.LccnSubscriptionV2("},{"line_number":372,"context_line":"            id\u003d\u0027sub-4\u0027, verbosity\u003d\u0027SHORT\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"d7e27866_87064300","line":369,"in_reply_to":"7dcc1fee_67b07c1c","updated":"2023-07-19 08:59:20.000000000","message":"ditto","commit_id":"c4a4a7c4f575c00418358e66c06c24abd6bf4f58"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"c66b56e800e14703c9e58454e6e812f63b465c0c","unresolved":false,"context_lines":[{"line_number":366,"context_line":"                        tokenEndpoint\u003d\u0027http://127.0.0.1/token\u0027))))"},{"line_number":367,"context_line":""},{"line_number":368,"context_line":"        # execute oauth2"},{"line_number":369,"context_line":"        subsc_utils.send_notification(subsc_oauth2, notif_data_no_auth)"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"        subsc_oauth2_mtls \u003d objects.LccnSubscriptionV2("},{"line_number":372,"context_line":"            id\u003d\u0027sub-4\u0027, verbosity\u003d\u0027SHORT\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"58691668_858b3201","line":369,"in_reply_to":"d7e27866_87064300","updated":"2023-07-25 09:39:46.000000000","message":"ditto","commit_id":"c4a4a7c4f575c00418358e66c06c24abd6bf4f58"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"f0c74ffa36dba9faaa7e7c202e8d6ca2144d1e44","unresolved":true,"context_lines":[{"line_number":388,"context_line":"        )"},{"line_number":389,"context_line":""},{"line_number":390,"context_line":"        # execute oauth2 mtls"},{"line_number":391,"context_line":"        subsc_utils.send_notification(subsc_oauth2_mtls, notif_data_no_auth)"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"        CONF.v2_vnfm.notification_verify_cert \u003d True"},{"line_number":394,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bf90b770_3d6d0e41","line":391,"updated":"2023-07-13 05:47:27.000000000","message":"ditto","commit_id":"c4a4a7c4f575c00418358e66c06c24abd6bf4f58"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"c66b56e800e14703c9e58454e6e812f63b465c0c","unresolved":false,"context_lines":[{"line_number":388,"context_line":"        )"},{"line_number":389,"context_line":""},{"line_number":390,"context_line":"        # execute oauth2 mtls"},{"line_number":391,"context_line":"        subsc_utils.send_notification(subsc_oauth2_mtls, notif_data_no_auth)"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"        CONF.v2_vnfm.notification_verify_cert \u003d True"},{"line_number":394,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"a63039b8_87de9872","line":391,"in_reply_to":"6d53876e_f7c09b18","updated":"2023-07-25 09:39:46.000000000","message":"ditto","commit_id":"c4a4a7c4f575c00418358e66c06c24abd6bf4f58"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"1c9f1f7510f6c2d7caa150daf23c7e319fb6f7b7","unresolved":true,"context_lines":[{"line_number":388,"context_line":"        )"},{"line_number":389,"context_line":""},{"line_number":390,"context_line":"        # execute oauth2 mtls"},{"line_number":391,"context_line":"        subsc_utils.send_notification(subsc_oauth2_mtls, notif_data_no_auth)"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"        CONF.v2_vnfm.notification_verify_cert \u003d True"},{"line_number":394,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"6d53876e_f7c09b18","line":391,"in_reply_to":"bf90b770_3d6d0e41","updated":"2023-07-19 08:59:20.000000000","message":"ditto","commit_id":"c4a4a7c4f575c00418358e66c06c24abd6bf4f58"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"f0c74ffa36dba9faaa7e7c202e8d6ca2144d1e44","unresolved":true,"context_lines":[{"line_number":403,"context_line":"        mock_resp.return_value \u003d (resp_no_auth, None)"},{"line_number":404,"context_line":""},{"line_number":405,"context_line":"        # execute no_auth"},{"line_number":406,"context_line":"        subsc_utils.send_notification(subsc_no_auth, notif_data_no_auth)"},{"line_number":407,"context_line":""},{"line_number":408,"context_line":"        subsc_basic_auth \u003d objects.LccnSubscriptionV2("},{"line_number":409,"context_line":"            id\u003d\u0027sub-6\u0027, verbosity\u003d\u0027SHORT\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"b6277707_b82d136b","line":406,"updated":"2023-07-13 05:47:27.000000000","message":"ditto","commit_id":"c4a4a7c4f575c00418358e66c06c24abd6bf4f58"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"1c9f1f7510f6c2d7caa150daf23c7e319fb6f7b7","unresolved":true,"context_lines":[{"line_number":403,"context_line":"        mock_resp.return_value \u003d (resp_no_auth, None)"},{"line_number":404,"context_line":""},{"line_number":405,"context_line":"        # execute no_auth"},{"line_number":406,"context_line":"        subsc_utils.send_notification(subsc_no_auth, notif_data_no_auth)"},{"line_number":407,"context_line":""},{"line_number":408,"context_line":"        subsc_basic_auth \u003d objects.LccnSubscriptionV2("},{"line_number":409,"context_line":"            id\u003d\u0027sub-6\u0027, verbosity\u003d\u0027SHORT\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ebaea25c_b0d55e42","line":406,"in_reply_to":"b6277707_b82d136b","updated":"2023-07-19 08:59:20.000000000","message":"ditto","commit_id":"c4a4a7c4f575c00418358e66c06c24abd6bf4f58"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"c66b56e800e14703c9e58454e6e812f63b465c0c","unresolved":false,"context_lines":[{"line_number":403,"context_line":"        mock_resp.return_value \u003d (resp_no_auth, None)"},{"line_number":404,"context_line":""},{"line_number":405,"context_line":"        # execute no_auth"},{"line_number":406,"context_line":"        subsc_utils.send_notification(subsc_no_auth, notif_data_no_auth)"},{"line_number":407,"context_line":""},{"line_number":408,"context_line":"        subsc_basic_auth \u003d objects.LccnSubscriptionV2("},{"line_number":409,"context_line":"            id\u003d\u0027sub-6\u0027, verbosity\u003d\u0027SHORT\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f02e036_86b2b917","line":406,"in_reply_to":"ebaea25c_b0d55e42","updated":"2023-07-25 09:39:46.000000000","message":"ditto","commit_id":"c4a4a7c4f575c00418358e66c06c24abd6bf4f58"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"f0c74ffa36dba9faaa7e7c202e8d6ca2144d1e44","unresolved":true,"context_lines":[{"line_number":416,"context_line":"        )"},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"        # execute basic_auth"},{"line_number":419,"context_line":"        subsc_utils.send_notification(subsc_basic_auth, notif_data_no_auth)"},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"        subsc_oauth2 \u003d objects.LccnSubscriptionV2("},{"line_number":422,"context_line":"            id\u003d\u0027sub-7\u0027, verbosity\u003d\u0027SHORT\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"0450290c_82076f8c","line":419,"updated":"2023-07-13 05:47:27.000000000","message":"ditto","commit_id":"c4a4a7c4f575c00418358e66c06c24abd6bf4f58"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"1c9f1f7510f6c2d7caa150daf23c7e319fb6f7b7","unresolved":true,"context_lines":[{"line_number":416,"context_line":"        )"},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"        # execute basic_auth"},{"line_number":419,"context_line":"        subsc_utils.send_notification(subsc_basic_auth, notif_data_no_auth)"},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"        subsc_oauth2 \u003d objects.LccnSubscriptionV2("},{"line_number":422,"context_line":"            id\u003d\u0027sub-7\u0027, verbosity\u003d\u0027SHORT\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"c3710402_b5199d34","line":419,"in_reply_to":"0450290c_82076f8c","updated":"2023-07-19 08:59:20.000000000","message":"ditto","commit_id":"c4a4a7c4f575c00418358e66c06c24abd6bf4f58"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"c66b56e800e14703c9e58454e6e812f63b465c0c","unresolved":false,"context_lines":[{"line_number":416,"context_line":"        )"},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"        # execute basic_auth"},{"line_number":419,"context_line":"        subsc_utils.send_notification(subsc_basic_auth, notif_data_no_auth)"},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"        subsc_oauth2 \u003d objects.LccnSubscriptionV2("},{"line_number":422,"context_line":"            id\u003d\u0027sub-7\u0027, verbosity\u003d\u0027SHORT\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"f20f18f4_30b507aa","line":419,"in_reply_to":"c3710402_b5199d34","updated":"2023-07-25 09:39:46.000000000","message":"ditto","commit_id":"c4a4a7c4f575c00418358e66c06c24abd6bf4f58"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"f0c74ffa36dba9faaa7e7c202e8d6ca2144d1e44","unresolved":true,"context_lines":[{"line_number":432,"context_line":"        )"},{"line_number":433,"context_line":""},{"line_number":434,"context_line":"        # execute oauth2"},{"line_number":435,"context_line":"        subsc_utils.send_notification(subsc_oauth2, notif_data_no_auth)"},{"line_number":436,"context_line":""},{"line_number":437,"context_line":"    @mock.patch.object(http_client.HttpClient, \u0027do_request\u0027)"},{"line_number":438,"context_line":"    def test_send_notification_not_expected_status_code(self, mock_resp):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1328e18e_5e2546e0","line":435,"updated":"2023-07-13 05:47:27.000000000","message":"ditto","commit_id":"c4a4a7c4f575c00418358e66c06c24abd6bf4f58"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"c66b56e800e14703c9e58454e6e812f63b465c0c","unresolved":false,"context_lines":[{"line_number":432,"context_line":"        )"},{"line_number":433,"context_line":""},{"line_number":434,"context_line":"        # execute oauth2"},{"line_number":435,"context_line":"        subsc_utils.send_notification(subsc_oauth2, notif_data_no_auth)"},{"line_number":436,"context_line":""},{"line_number":437,"context_line":"    @mock.patch.object(http_client.HttpClient, \u0027do_request\u0027)"},{"line_number":438,"context_line":"    def test_send_notification_not_expected_status_code(self, mock_resp):"}],"source_content_type":"text/x-python","patch_set":4,"id":"a6202132_02a8e6cc","line":435,"in_reply_to":"11d19dd6_8c8ff01d","updated":"2023-07-25 09:39:46.000000000","message":"dito","commit_id":"c4a4a7c4f575c00418358e66c06c24abd6bf4f58"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"1c9f1f7510f6c2d7caa150daf23c7e319fb6f7b7","unresolved":true,"context_lines":[{"line_number":432,"context_line":"        )"},{"line_number":433,"context_line":""},{"line_number":434,"context_line":"        # execute oauth2"},{"line_number":435,"context_line":"        subsc_utils.send_notification(subsc_oauth2, notif_data_no_auth)"},{"line_number":436,"context_line":""},{"line_number":437,"context_line":"    @mock.patch.object(http_client.HttpClient, \u0027do_request\u0027)"},{"line_number":438,"context_line":"    def test_send_notification_not_expected_status_code(self, mock_resp):"}],"source_content_type":"text/x-python","patch_set":4,"id":"11d19dd6_8c8ff01d","line":435,"in_reply_to":"1328e18e_5e2546e0","updated":"2023-07-19 08:59:20.000000000","message":"ditto","commit_id":"c4a4a7c4f575c00418358e66c06c24abd6bf4f58"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"f0c74ffa36dba9faaa7e7c202e8d6ca2144d1e44","unresolved":true,"context_lines":[{"line_number":450,"context_line":"            sol_detail\u003d\"unit test\")"},{"line_number":451,"context_line":""},{"line_number":452,"context_line":"        # execute no_auth"},{"line_number":453,"context_line":"        subsc_utils.send_notification(subsc_no_auth, notif_data_no_auth)"},{"line_number":454,"context_line":""},{"line_number":455,"context_line":"    @mock.patch.object(http_client.HttpClient, \u0027do_request\u0027)"},{"line_number":456,"context_line":"    def test_send_notification_fm_subscription(self, mock_resp):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3351ebf8_4d449830","line":453,"updated":"2023-07-13 05:47:27.000000000","message":"ditto","commit_id":"c4a4a7c4f575c00418358e66c06c24abd6bf4f58"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"1c9f1f7510f6c2d7caa150daf23c7e319fb6f7b7","unresolved":true,"context_lines":[{"line_number":450,"context_line":"            sol_detail\u003d\"unit test\")"},{"line_number":451,"context_line":""},{"line_number":452,"context_line":"        # execute no_auth"},{"line_number":453,"context_line":"        subsc_utils.send_notification(subsc_no_auth, notif_data_no_auth)"},{"line_number":454,"context_line":""},{"line_number":455,"context_line":"    @mock.patch.object(http_client.HttpClient, \u0027do_request\u0027)"},{"line_number":456,"context_line":"    def test_send_notification_fm_subscription(self, mock_resp):"}],"source_content_type":"text/x-python","patch_set":4,"id":"edf90ac5_446f4ee3","line":453,"in_reply_to":"3351ebf8_4d449830","updated":"2023-07-19 08:59:20.000000000","message":"Add a check in the log message if sol_ex.SolException occurs.","commit_id":"c4a4a7c4f575c00418358e66c06c24abd6bf4f58"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"c66b56e800e14703c9e58454e6e812f63b465c0c","unresolved":false,"context_lines":[{"line_number":450,"context_line":"            sol_detail\u003d\"unit test\")"},{"line_number":451,"context_line":""},{"line_number":452,"context_line":"        # execute no_auth"},{"line_number":453,"context_line":"        subsc_utils.send_notification(subsc_no_auth, notif_data_no_auth)"},{"line_number":454,"context_line":""},{"line_number":455,"context_line":"    @mock.patch.object(http_client.HttpClient, \u0027do_request\u0027)"},{"line_number":456,"context_line":"    def test_send_notification_fm_subscription(self, mock_resp):"}],"source_content_type":"text/x-python","patch_set":4,"id":"4ce34b87_c598e2e2","line":453,"in_reply_to":"edf90ac5_446f4ee3","updated":"2023-07-25 09:39:46.000000000","message":"Done","commit_id":"c4a4a7c4f575c00418358e66c06c24abd6bf4f58"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"f0c74ffa36dba9faaa7e7c202e8d6ca2144d1e44","unresolved":true,"context_lines":[{"line_number":500,"context_line":"        resp_no_auth \u003d requests.Response()"},{"line_number":501,"context_line":"        resp_no_auth.status_code \u003d 204"},{"line_number":502,"context_line":"        mock_resp.return_value \u003d (resp_no_auth, None)"},{"line_number":503,"context_line":"        subsc_utils.send_notification("},{"line_number":504,"context_line":"            pm_job, notif_data, subsc_utils.NOTIFY_TYPE_PM)"},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"    @mock.patch.object(http_client.HttpClient, \u0027do_request\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"6dfd7fc0_ebecc832","line":503,"updated":"2023-07-13 05:47:27.000000000","message":"ditto","commit_id":"c4a4a7c4f575c00418358e66c06c24abd6bf4f58"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"5e61c8d45cd56288e45d6e3186147217b713c2ed","unresolved":false,"context_lines":[{"line_number":500,"context_line":"        resp_no_auth \u003d requests.Response()"},{"line_number":501,"context_line":"        resp_no_auth.status_code \u003d 204"},{"line_number":502,"context_line":"        mock_resp.return_value \u003d (resp_no_auth, None)"},{"line_number":503,"context_line":"        subsc_utils.send_notification("},{"line_number":504,"context_line":"            pm_job, notif_data, subsc_utils.NOTIFY_TYPE_PM)"},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"    @mock.patch.object(http_client.HttpClient, \u0027do_request\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"c6dc2ca3_51fb2b79","line":503,"in_reply_to":"5ad74321_c522291b","updated":"2023-07-21 04:28:13.000000000","message":"Done","commit_id":"c4a4a7c4f575c00418358e66c06c24abd6bf4f58"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"1c9f1f7510f6c2d7caa150daf23c7e319fb6f7b7","unresolved":true,"context_lines":[{"line_number":500,"context_line":"        resp_no_auth \u003d requests.Response()"},{"line_number":501,"context_line":"        resp_no_auth.status_code \u003d 204"},{"line_number":502,"context_line":"        mock_resp.return_value \u003d (resp_no_auth, None)"},{"line_number":503,"context_line":"        subsc_utils.send_notification("},{"line_number":504,"context_line":"            pm_job, notif_data, subsc_utils.NOTIFY_TYPE_PM)"},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"    @mock.patch.object(http_client.HttpClient, \u0027do_request\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5ad74321_c522291b","line":503,"in_reply_to":"6dfd7fc0_ebecc832","updated":"2023-07-19 08:59:20.000000000","message":"I will fix.","commit_id":"c4a4a7c4f575c00418358e66c06c24abd6bf4f58"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"f0c74ffa36dba9faaa7e7c202e8d6ca2144d1e44","unresolved":true,"context_lines":[{"line_number":514,"context_line":"        mock_resp.return_value \u003d (resp_no_auth, None)"},{"line_number":515,"context_line":""},{"line_number":516,"context_line":"        # execute no_auth"},{"line_number":517,"context_line":"        subsc_utils.test_notification(subsc_no_auth)"},{"line_number":518,"context_line":""},{"line_number":519,"context_line":"    @mock.patch.object(http_client.HttpClient, \u0027do_request\u0027)"},{"line_number":520,"context_line":"    def test_test_notification_error_code(self, mock_resp):"}],"source_content_type":"text/x-python","patch_set":4,"id":"6d6e2384_0c20eb87","line":517,"updated":"2023-07-13 05:47:27.000000000","message":"ditto","commit_id":"c4a4a7c4f575c00418358e66c06c24abd6bf4f58"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"1c9f1f7510f6c2d7caa150daf23c7e319fb6f7b7","unresolved":true,"context_lines":[{"line_number":514,"context_line":"        mock_resp.return_value \u003d (resp_no_auth, None)"},{"line_number":515,"context_line":""},{"line_number":516,"context_line":"        # execute no_auth"},{"line_number":517,"context_line":"        subsc_utils.test_notification(subsc_no_auth)"},{"line_number":518,"context_line":""},{"line_number":519,"context_line":"    @mock.patch.object(http_client.HttpClient, \u0027do_request\u0027)"},{"line_number":520,"context_line":"    def test_test_notification_error_code(self, mock_resp):"}],"source_content_type":"text/x-python","patch_set":4,"id":"deef9323_915eaf0c","line":517,"in_reply_to":"6d6e2384_0c20eb87","updated":"2023-07-19 08:59:20.000000000","message":"I will fix.","commit_id":"c4a4a7c4f575c00418358e66c06c24abd6bf4f58"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"5e61c8d45cd56288e45d6e3186147217b713c2ed","unresolved":false,"context_lines":[{"line_number":514,"context_line":"        mock_resp.return_value \u003d (resp_no_auth, None)"},{"line_number":515,"context_line":""},{"line_number":516,"context_line":"        # execute no_auth"},{"line_number":517,"context_line":"        subsc_utils.test_notification(subsc_no_auth)"},{"line_number":518,"context_line":""},{"line_number":519,"context_line":"    @mock.patch.object(http_client.HttpClient, \u0027do_request\u0027)"},{"line_number":520,"context_line":"    def test_test_notification_error_code(self, mock_resp):"}],"source_content_type":"text/x-python","patch_set":4,"id":"4c14fc6a_98a1ba7f","line":517,"in_reply_to":"deef9323_915eaf0c","updated":"2023-07-21 04:28:13.000000000","message":"Done","commit_id":"c4a4a7c4f575c00418358e66c06c24abd6bf4f58"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"f0c74ffa36dba9faaa7e7c202e8d6ca2144d1e44","unresolved":true,"context_lines":[{"line_number":522,"context_line":"            id\u003d\u0027sub-1\u0027, verbosity\u003d\u0027SHORT\u0027,"},{"line_number":523,"context_line":"            callbackUri\u003d\u0027http://127.0.0.1/callback\u0027)"},{"line_number":524,"context_line":"        mock_resp.side_effect \u003d sol_ex.SolException("},{"line_number":525,"context_line":"            sol_status\u003d200,"},{"line_number":526,"context_line":"            sol_detail\u003d\"unit test\")"},{"line_number":527,"context_line":""},{"line_number":528,"context_line":"        # execute no_auth"}],"source_content_type":"text/x-python","patch_set":4,"id":"36571f12_a414a491","line":525,"updated":"2023-07-13 05:47:27.000000000","message":"The test name is \"test_test_notification_error_code\", but I have a feeling that 200 is not an error code.","commit_id":"c4a4a7c4f575c00418358e66c06c24abd6bf4f58"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"1c9f1f7510f6c2d7caa150daf23c7e319fb6f7b7","unresolved":true,"context_lines":[{"line_number":522,"context_line":"            id\u003d\u0027sub-1\u0027, verbosity\u003d\u0027SHORT\u0027,"},{"line_number":523,"context_line":"            callbackUri\u003d\u0027http://127.0.0.1/callback\u0027)"},{"line_number":524,"context_line":"        mock_resp.side_effect \u003d sol_ex.SolException("},{"line_number":525,"context_line":"            sol_status\u003d200,"},{"line_number":526,"context_line":"            sol_detail\u003d\"unit test\")"},{"line_number":527,"context_line":""},{"line_number":528,"context_line":"        # execute no_auth"}],"source_content_type":"text/x-python","patch_set":4,"id":"f363da7a_e79d500b","line":525,"in_reply_to":"36571f12_a414a491","updated":"2023-07-19 08:59:20.000000000","message":"I will change the status code or test name.","commit_id":"c4a4a7c4f575c00418358e66c06c24abd6bf4f58"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"c66b56e800e14703c9e58454e6e812f63b465c0c","unresolved":false,"context_lines":[{"line_number":522,"context_line":"            id\u003d\u0027sub-1\u0027, verbosity\u003d\u0027SHORT\u0027,"},{"line_number":523,"context_line":"            callbackUri\u003d\u0027http://127.0.0.1/callback\u0027)"},{"line_number":524,"context_line":"        mock_resp.side_effect \u003d sol_ex.SolException("},{"line_number":525,"context_line":"            sol_status\u003d200,"},{"line_number":526,"context_line":"            sol_detail\u003d\"unit test\")"},{"line_number":527,"context_line":""},{"line_number":528,"context_line":"        # execute no_auth"}],"source_content_type":"text/x-python","patch_set":4,"id":"5155dbed_bf480b80","line":525,"in_reply_to":"81028e85_36c4f59a","updated":"2023-07-25 09:39:46.000000000","message":"Ack","commit_id":"c4a4a7c4f575c00418358e66c06c24abd6bf4f58"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"1c2bedb28088d3f09d89a7b9ad534c26bf8aff14","unresolved":true,"context_lines":[{"line_number":522,"context_line":"            id\u003d\u0027sub-1\u0027, verbosity\u003d\u0027SHORT\u0027,"},{"line_number":523,"context_line":"            callbackUri\u003d\u0027http://127.0.0.1/callback\u0027)"},{"line_number":524,"context_line":"        mock_resp.side_effect \u003d sol_ex.SolException("},{"line_number":525,"context_line":"            sol_status\u003d200,"},{"line_number":526,"context_line":"            sol_detail\u003d\"unit test\")"},{"line_number":527,"context_line":""},{"line_number":528,"context_line":"        # execute no_auth"}],"source_content_type":"text/x-python","patch_set":4,"id":"81028e85_36c4f59a","line":525,"in_reply_to":"f363da7a_e79d500b","updated":"2023-07-20 09:14:20.000000000","message":"This test case checks that the return from send request is sol_ex.SolException, so it is included in the test for \"test_test_notification_error\", so it is removed.","commit_id":"c4a4a7c4f575c00418358e66c06c24abd6bf4f58"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"f0c74ffa36dba9faaa7e7c202e8d6ca2144d1e44","unresolved":true,"context_lines":[{"line_number":563,"context_line":"            paramsBasic\u003dobjects.SubscriptionAuthentication_ParamsBasic("},{"line_number":564,"context_line":"                userName\u003d\u0027test\u0027, password\u003d\u0027test\u0027))"},{"line_number":565,"context_line":""},{"line_number":566,"context_line":"        subsc_utils.test_notification(subsc_basic_auth,"},{"line_number":567,"context_line":"                                      subsc_utils.NOTIFY_TYPE_FM)"},{"line_number":568,"context_line":""},{"line_number":569,"context_line":"    @mock.patch.object(http_client.HttpClient, \u0027do_request\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"68c143a8_e3d59b65","line":566,"updated":"2023-07-13 05:47:27.000000000","message":"Is it okay to not check whether the notification has been sent?","commit_id":"c4a4a7c4f575c00418358e66c06c24abd6bf4f58"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"5e61c8d45cd56288e45d6e3186147217b713c2ed","unresolved":false,"context_lines":[{"line_number":563,"context_line":"            paramsBasic\u003dobjects.SubscriptionAuthentication_ParamsBasic("},{"line_number":564,"context_line":"                userName\u003d\u0027test\u0027, password\u003d\u0027test\u0027))"},{"line_number":565,"context_line":""},{"line_number":566,"context_line":"        subsc_utils.test_notification(subsc_basic_auth,"},{"line_number":567,"context_line":"                                      subsc_utils.NOTIFY_TYPE_FM)"},{"line_number":568,"context_line":""},{"line_number":569,"context_line":"    @mock.patch.object(http_client.HttpClient, \u0027do_request\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3b87e826_d80d5103","line":566,"in_reply_to":"03da206a_b54ef6f2","updated":"2023-07-21 04:28:13.000000000","message":"Done","commit_id":"c4a4a7c4f575c00418358e66c06c24abd6bf4f58"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"1c9f1f7510f6c2d7caa150daf23c7e319fb6f7b7","unresolved":true,"context_lines":[{"line_number":563,"context_line":"            paramsBasic\u003dobjects.SubscriptionAuthentication_ParamsBasic("},{"line_number":564,"context_line":"                userName\u003d\u0027test\u0027, password\u003d\u0027test\u0027))"},{"line_number":565,"context_line":""},{"line_number":566,"context_line":"        subsc_utils.test_notification(subsc_basic_auth,"},{"line_number":567,"context_line":"                                      subsc_utils.NOTIFY_TYPE_FM)"},{"line_number":568,"context_line":""},{"line_number":569,"context_line":"    @mock.patch.object(http_client.HttpClient, \u0027do_request\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"03da206a_b54ef6f2","line":566,"in_reply_to":"68c143a8_e3d59b65","updated":"2023-07-19 08:59:20.000000000","message":"Add a check that the request sending(\u0027do_request\u0027) is called.","commit_id":"c4a4a7c4f575c00418358e66c06c24abd6bf4f58"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"f0c74ffa36dba9faaa7e7c202e8d6ca2144d1e44","unresolved":true,"context_lines":[{"line_number":582,"context_line":"            ),"},{"line_number":583,"context_line":"            callbackUri\u003d\u0027http://127.0.0.1/callback\u0027"},{"line_number":584,"context_line":"        )"},{"line_number":585,"context_line":"        subsc_utils.test_notification(pm_job, subsc_utils.NOTIFY_TYPE_PM)"}],"source_content_type":"text/x-python","patch_set":4,"id":"122f5f19_84475ef6","line":585,"updated":"2023-07-13 05:47:27.000000000","message":"ditto","commit_id":"c4a4a7c4f575c00418358e66c06c24abd6bf4f58"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"1c9f1f7510f6c2d7caa150daf23c7e319fb6f7b7","unresolved":true,"context_lines":[{"line_number":582,"context_line":"            ),"},{"line_number":583,"context_line":"            callbackUri\u003d\u0027http://127.0.0.1/callback\u0027"},{"line_number":584,"context_line":"        )"},{"line_number":585,"context_line":"        subsc_utils.test_notification(pm_job, subsc_utils.NOTIFY_TYPE_PM)"}],"source_content_type":"text/x-python","patch_set":4,"id":"94900c61_27159131","line":585,"in_reply_to":"122f5f19_84475ef6","updated":"2023-07-19 08:59:20.000000000","message":"ditto","commit_id":"c4a4a7c4f575c00418358e66c06c24abd6bf4f58"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"5e61c8d45cd56288e45d6e3186147217b713c2ed","unresolved":false,"context_lines":[{"line_number":582,"context_line":"            ),"},{"line_number":583,"context_line":"            callbackUri\u003d\u0027http://127.0.0.1/callback\u0027"},{"line_number":584,"context_line":"        )"},{"line_number":585,"context_line":"        subsc_utils.test_notification(pm_job, subsc_utils.NOTIFY_TYPE_PM)"}],"source_content_type":"text/x-python","patch_set":4,"id":"e8a690de_0a2fc677","line":585,"in_reply_to":"94900c61_27159131","updated":"2023-07-21 04:28:13.000000000","message":"Done","commit_id":"c4a4a7c4f575c00418358e66c06c24abd6bf4f58"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"5e61c8d45cd56288e45d6e3186147217b713c2ed","unresolved":true,"context_lines":[{"line_number":330,"context_line":"        self.assertEqual([\u0027OAUTH2_CLIENT_CERT\u0027], result.authType)"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"    @mock.patch.object(http_client.HttpClient, \u0027do_request\u0027)"},{"line_number":333,"context_line":"    def test_send_notification(self, mock_resp):"},{"line_number":334,"context_line":"        subsc_no_auth \u003d objects.LccnSubscriptionV2("},{"line_number":335,"context_line":"            id\u003d\u0027sub-1\u0027, verbosity\u003d\u0027SHORT\u0027,"},{"line_number":336,"context_line":"            callbackUri\u003d\u0027http://127.0.0.1/callback\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1d91cfce_e13361de","line":333,"updated":"2023-07-21 04:28:13.000000000","message":"Is it intentional that tests other than no_auth are removed?\nIf it\u0027s better to have only one test, I think it\u0027s better to leave the OAUTH2_CLIENT_CERT test, which has the highest security and priority.","commit_id":"369c77649be9485763fa196b2f30f16fc68683a8"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"c66b56e800e14703c9e58454e6e812f63b465c0c","unresolved":false,"context_lines":[{"line_number":330,"context_line":"        self.assertEqual([\u0027OAUTH2_CLIENT_CERT\u0027], result.authType)"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"    @mock.patch.object(http_client.HttpClient, \u0027do_request\u0027)"},{"line_number":333,"context_line":"    def test_send_notification(self, mock_resp):"},{"line_number":334,"context_line":"        subsc_no_auth \u003d objects.LccnSubscriptionV2("},{"line_number":335,"context_line":"            id\u003d\u0027sub-1\u0027, verbosity\u003d\u0027SHORT\u0027,"},{"line_number":336,"context_line":"            callbackUri\u003d\u0027http://127.0.0.1/callback\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"281e4f72_49f6aff1","line":333,"in_reply_to":"176c8157_76dc9922","updated":"2023-07-25 09:39:46.000000000","message":"Done","commit_id":"369c77649be9485763fa196b2f30f16fc68683a8"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"eba1acc7bb46491924ed0c4e0bb2804237b383ed","unresolved":true,"context_lines":[{"line_number":330,"context_line":"        self.assertEqual([\u0027OAUTH2_CLIENT_CERT\u0027], result.authType)"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"    @mock.patch.object(http_client.HttpClient, \u0027do_request\u0027)"},{"line_number":333,"context_line":"    def test_send_notification(self, mock_resp):"},{"line_number":334,"context_line":"        subsc_no_auth \u003d objects.LccnSubscriptionV2("},{"line_number":335,"context_line":"            id\u003d\u0027sub-1\u0027, verbosity\u003d\u0027SHORT\u0027,"},{"line_number":336,"context_line":"            callbackUri\u003d\u0027http://127.0.0.1/callback\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"176c8157_76dc9922","line":333,"in_reply_to":"1d91cfce_e13361de","updated":"2023-07-25 03:17:16.000000000","message":"I intentionally removed all but no_auth. As I commented in #345, the auth_handle is checked in other tests, so I think that one test case of authentication should pass here.\nIf it is one test case, then chage to OAUTH2_CLIENT_CERT test.","commit_id":"369c77649be9485763fa196b2f30f16fc68683a8"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"5e61c8d45cd56288e45d6e3186147217b713c2ed","unresolved":true,"context_lines":[{"line_number":347,"context_line":""},{"line_number":348,"context_line":"    @mock.patch(\u0027tacker.sol_refactored.common.subscription_utils.LOG\u0027)"},{"line_number":349,"context_line":"    @mock.patch.object(http_client.HttpClient, \u0027do_request\u0027)"},{"line_number":350,"context_line":"    def test_send_notification_error(self, mock_resp,"},{"line_number":351,"context_line":"            mock_log):"},{"line_number":352,"context_line":"        subsc_no_auth \u003d objects.LccnSubscriptionV2("},{"line_number":353,"context_line":"            id\u003d\u0027sub-1\u0027, verbosity\u003d\u0027SHORT\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"cd550c54_12978ac3","line":350,"updated":"2023-07-21 04:28:13.000000000","message":"There will be no test for case with an unexpected status code(200) that is not an error.\nIs there any problem if the test with the unexpected status code(200) is deleted?","commit_id":"369c77649be9485763fa196b2f30f16fc68683a8"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"c66b56e800e14703c9e58454e6e812f63b465c0c","unresolved":false,"context_lines":[{"line_number":347,"context_line":""},{"line_number":348,"context_line":"    @mock.patch(\u0027tacker.sol_refactored.common.subscription_utils.LOG\u0027)"},{"line_number":349,"context_line":"    @mock.patch.object(http_client.HttpClient, \u0027do_request\u0027)"},{"line_number":350,"context_line":"    def test_send_notification_error(self, mock_resp,"},{"line_number":351,"context_line":"            mock_log):"},{"line_number":352,"context_line":"        subsc_no_auth \u003d objects.LccnSubscriptionV2("},{"line_number":353,"context_line":"            id\u003d\u0027sub-1\u0027, verbosity\u003d\u0027SHORT\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"c533f781_7d8cb799","line":350,"in_reply_to":"41a2d43c_a519a099","updated":"2023-07-25 09:39:46.000000000","message":"Ack","commit_id":"369c77649be9485763fa196b2f30f16fc68683a8"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"eba1acc7bb46491924ed0c4e0bb2804237b383ed","unresolved":true,"context_lines":[{"line_number":347,"context_line":""},{"line_number":348,"context_line":"    @mock.patch(\u0027tacker.sol_refactored.common.subscription_utils.LOG\u0027)"},{"line_number":349,"context_line":"    @mock.patch.object(http_client.HttpClient, \u0027do_request\u0027)"},{"line_number":350,"context_line":"    def test_send_notification_error(self, mock_resp,"},{"line_number":351,"context_line":"            mock_log):"},{"line_number":352,"context_line":"        subsc_no_auth \u003d objects.LccnSubscriptionV2("},{"line_number":353,"context_line":"            id\u003d\u0027sub-1\u0027, verbosity\u003d\u0027SHORT\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"41a2d43c_a519a099","line":350,"in_reply_to":"cd550c54_12978ac3","updated":"2023-07-25 03:17:16.000000000","message":"The \"do_request(http_client.HttpClient)\" returns \"sol_ex.SolException\" if the expected status_code is not returned. Therefore, this test should be enough to check if the \"sol_ex.SolException\" occurs.","commit_id":"369c77649be9485763fa196b2f30f16fc68683a8"}],"tacker/tests/unit/sol_refactored/controller/test_vnffm_v1.py":[{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"eed90633aca9682315d53bd00bc3711cb40e74a8","unresolved":true,"context_lines":[{"line_number":22,"context_line":"from tacker.sol_refactored.api import api_version"},{"line_number":23,"context_line":"from tacker.sol_refactored.common import config"},{"line_number":24,"context_line":"from tacker.sol_refactored.common import exceptions as sol_ex"},{"line_number":25,"context_line":"from tacker.sol_refactored.common import fm_alarm_utils as fm_alarm_utils"},{"line_number":26,"context_line":"from tacker.sol_refactored.common import fm_subscription_utils\\"},{"line_number":27,"context_line":"    as fm_subsc_utils"},{"line_number":28,"context_line":"from tacker.sol_refactored.common import subscription_utils as subsc_utils"}],"source_content_type":"text/x-python","patch_set":3,"id":"d2419cd6_798c21d1","line":25,"updated":"2023-07-04 01:37:32.000000000","message":"Is `as` needed?","commit_id":"77babfb242fc87a6ebe81ff9dd269644d0ac1f69"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"f31cc772adf0c74ed5b7514af99c0e047d8f92e1","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from tacker.sol_refactored.api import api_version"},{"line_number":23,"context_line":"from tacker.sol_refactored.common import config"},{"line_number":24,"context_line":"from tacker.sol_refactored.common import exceptions as sol_ex"},{"line_number":25,"context_line":"from tacker.sol_refactored.common import fm_alarm_utils as fm_alarm_utils"},{"line_number":26,"context_line":"from tacker.sol_refactored.common import fm_subscription_utils\\"},{"line_number":27,"context_line":"    as fm_subsc_utils"},{"line_number":28,"context_line":"from tacker.sol_refactored.common import subscription_utils as subsc_utils"}],"source_content_type":"text/x-python","patch_set":3,"id":"a2237200_60d39c5c","line":25,"in_reply_to":"8455349b_b1fd4b91","updated":"2023-07-05 12:55:03.000000000","message":"Done","commit_id":"77babfb242fc87a6ebe81ff9dd269644d0ac1f69"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"82936eb67ff98ed8e102fad692f220ffe873cc26","unresolved":true,"context_lines":[{"line_number":22,"context_line":"from tacker.sol_refactored.api import api_version"},{"line_number":23,"context_line":"from tacker.sol_refactored.common import config"},{"line_number":24,"context_line":"from tacker.sol_refactored.common import exceptions as sol_ex"},{"line_number":25,"context_line":"from tacker.sol_refactored.common import fm_alarm_utils as fm_alarm_utils"},{"line_number":26,"context_line":"from tacker.sol_refactored.common import fm_subscription_utils\\"},{"line_number":27,"context_line":"    as fm_subsc_utils"},{"line_number":28,"context_line":"from tacker.sol_refactored.common import subscription_utils as subsc_utils"}],"source_content_type":"text/x-python","patch_set":3,"id":"8455349b_b1fd4b91","line":25,"in_reply_to":"c0b9cc5d_6ad4f291","updated":"2023-07-05 12:54:51.000000000","message":"Thank you for replies. I understood.\nDone.","commit_id":"77babfb242fc87a6ebe81ff9dd269644d0ac1f69"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"a30a0a590f0606d4ffffd72aed45af506ea1e3cd","unresolved":true,"context_lines":[{"line_number":22,"context_line":"from tacker.sol_refactored.api import api_version"},{"line_number":23,"context_line":"from tacker.sol_refactored.common import config"},{"line_number":24,"context_line":"from tacker.sol_refactored.common import exceptions as sol_ex"},{"line_number":25,"context_line":"from tacker.sol_refactored.common import fm_alarm_utils as fm_alarm_utils"},{"line_number":26,"context_line":"from tacker.sol_refactored.common import fm_subscription_utils\\"},{"line_number":27,"context_line":"    as fm_subsc_utils"},{"line_number":28,"context_line":"from tacker.sol_refactored.common import subscription_utils as subsc_utils"}],"source_content_type":"text/x-python","patch_set":3,"id":"c0b9cc5d_6ad4f291","line":25,"in_reply_to":"d2419cd6_798c21d1","updated":"2023-07-04 08:05:49.000000000","message":"It is not necessary. No need to change it, so I put it back.","commit_id":"77babfb242fc87a6ebe81ff9dd269644d0ac1f69"}]}