)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"09f62a4a9e450b0726727b55aca2c5490839bb44","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Add timeout setting to VNF LCM Coordination IF"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch changes the following for VNF LCM Coordination IF."},{"line_number":10,"context_line":"* Add timeout setting to VNF LCM Coordination IF."},{"line_number":11,"context_line":"* Change auth_handle creation process to use common auth_handle"},{"line_number":12,"context_line":"  creation process in common_script_utils."},{"line_number":13,"context_line":"* Add processing to notify vnfc_id by mgmt driver script"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"c5f47c8f_54a80ed0","line":10,"range":{"start_line":10,"start_character":2,"end_line":10,"end_character":48},"updated":"2023-09-07 13:02:58.000000000","message":"How about applying it to the userguide of this feature[1]?\n* Add `timeout` parameter to additionalParams table and example.\n* Update `CoordScript` sample class\n\n[1] https://docs.openstack.org/tacker/latest/user/coordinate_api_client_in_coordinatevnf_script.html","commit_id":"5dfe82819e4f0f6813b028a316338358a5b5c422"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"03748508f72e806bb270076503e030e5631ddda0","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Add timeout setting to VNF LCM Coordination IF"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch changes the following for VNF LCM Coordination IF."},{"line_number":10,"context_line":"* Add timeout setting to VNF LCM Coordination IF."},{"line_number":11,"context_line":"* Change auth_handle creation process to use common auth_handle"},{"line_number":12,"context_line":"  creation process in common_script_utils."},{"line_number":13,"context_line":"* Add processing to notify vnfc_id by mgmt driver script"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"23aba9ef_2c3ae149","line":10,"range":{"start_line":10,"start_character":2,"end_line":10,"end_character":48},"in_reply_to":"9ffe2fbf_f49e179e","updated":"2023-09-08 02:33:28.000000000","message":"Thanks for your comment, I understood you will update with another patch.","commit_id":"5dfe82819e4f0f6813b028a316338358a5b5c422"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"52ed4c17efff7b9b073d0d6ae9dfe13c4dcd6138","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Add timeout setting to VNF LCM Coordination IF"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch changes the following for VNF LCM Coordination IF."},{"line_number":10,"context_line":"* Add timeout setting to VNF LCM Coordination IF."},{"line_number":11,"context_line":"* Change auth_handle creation process to use common auth_handle"},{"line_number":12,"context_line":"  creation process in common_script_utils."},{"line_number":13,"context_line":"* Add processing to notify vnfc_id by mgmt driver script"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"9ffe2fbf_f49e179e","line":10,"range":{"start_line":10,"start_character":2,"end_line":10,"end_character":48},"in_reply_to":"c5f47c8f_54a80ed0","updated":"2023-09-08 00:20:34.000000000","message":"Thank you for your suggestion.\nUserguide will be updated later in the patch below.\nhttps://review.opendev.org/c/openstack/tacker/+/892630","commit_id":"5dfe82819e4f0f6813b028a316338358a5b5c422"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"3541c73c2da402b919e140633784d28e7f6782c0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"a3125784_1980b87d","updated":"2023-08-10 02:49:10.000000000","message":"Thank you for the review.","commit_id":"4a6c280cebb978e4d87477a72520ec5463f53252"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"c30d96a957b32fe672c1d8ae25f9e15135f7209e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"cf6e9f34_71b54f88","updated":"2023-08-17 04:44:16.000000000","message":"Thank you for the review.","commit_id":"4a6c280cebb978e4d87477a72520ec5463f53252"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"0a5299a384cfeb114f7b1c156b3497ad4941091d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"e3f1f254_540c8e00","updated":"2023-08-28 07:32:13.000000000","message":"Thank you for the review.","commit_id":"90ecd4ecb3d8a3ac4424030314f911fef1fe377e"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"8d075c8b6ed01ad82792cd52c2b9b4cedfeea7c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"df97702e_ec9e9d0d","updated":"2023-08-29 01:48:26.000000000","message":"LGTM","commit_id":"63e0cbd82f6fc3df04b986f3729c75e42969d4bc"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"03748508f72e806bb270076503e030e5631ddda0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"ba3d05c3_2ed6f316","updated":"2023-09-08 02:33:28.000000000","message":"LGTM","commit_id":"5dfe82819e4f0f6813b028a316338358a5b5c422"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"09f62a4a9e450b0726727b55aca2c5490839bb44","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"cef6b0c8_d758791b","updated":"2023-09-07 13:02:58.000000000","message":"Thanks for your patch, please kindly find my comment.","commit_id":"5dfe82819e4f0f6813b028a316338358a5b5c422"}],"tacker/sol_refactored/common/coord_client.py":[{"author":{"_account_id":31668,"deleted":true},"change_message_id":"638e7940916c5b2481fca314515f1df9f6ce5bdc","unresolved":true,"context_lines":[{"line_number":74,"context_line":"                      \"Use DEFAULT_INTERVAL.\")"},{"line_number":75,"context_line":"            return DEFAULT_INTERVAL"},{"line_number":76,"context_line":"        try:"},{"line_number":77,"context_line":"            return int(resp.headers.get(\u0027Retry-After\u0027))"},{"line_number":78,"context_line":"        except ValueError:"},{"line_number":79,"context_line":"            # may be HTTP-date format. it is not supported."},{"line_number":80,"context_line":"            # use DEFAULT_INTERVAL"}],"source_content_type":"text/x-python","patch_set":8,"id":"e2438160_507b5d67","line":77,"updated":"2023-08-24 02:21:32.000000000","message":"Is there no problem even if a negative value is set for Retry-After?\nAccording to RFC7231, Retry-After \"delay-seconds\" is a non-negative decimal integer, so it\u0027s better to check that it\u0027s not a negative value if it can cause system problems.","commit_id":"90ecd4ecb3d8a3ac4424030314f911fef1fe377e"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"8d075c8b6ed01ad82792cd52c2b9b4cedfeea7c9","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                      \"Use DEFAULT_INTERVAL.\")"},{"line_number":75,"context_line":"            return DEFAULT_INTERVAL"},{"line_number":76,"context_line":"        try:"},{"line_number":77,"context_line":"            return int(resp.headers.get(\u0027Retry-After\u0027))"},{"line_number":78,"context_line":"        except ValueError:"},{"line_number":79,"context_line":"            # may be HTTP-date format. it is not supported."},{"line_number":80,"context_line":"            # use DEFAULT_INTERVAL"}],"source_content_type":"text/x-python","patch_set":8,"id":"f515aaaa_9b7d17bd","line":77,"in_reply_to":"cc914003_0853973f","updated":"2023-08-29 01:48:26.000000000","message":"Done","commit_id":"90ecd4ecb3d8a3ac4424030314f911fef1fe377e"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"0a5299a384cfeb114f7b1c156b3497ad4941091d","unresolved":true,"context_lines":[{"line_number":74,"context_line":"                      \"Use DEFAULT_INTERVAL.\")"},{"line_number":75,"context_line":"            return DEFAULT_INTERVAL"},{"line_number":76,"context_line":"        try:"},{"line_number":77,"context_line":"            return int(resp.headers.get(\u0027Retry-After\u0027))"},{"line_number":78,"context_line":"        except ValueError:"},{"line_number":79,"context_line":"            # may be HTTP-date format. it is not supported."},{"line_number":80,"context_line":"            # use DEFAULT_INTERVAL"}],"source_content_type":"text/x-python","patch_set":8,"id":"cc914003_0853973f","line":77,"in_reply_to":"e2438160_507b5d67","updated":"2023-08-28 07:32:13.000000000","message":"According to RFC7231, \"delay-seconds\" is not a negative number, so I don\u0027t think the check is necessary. However, I will add a check if \"Retry-After\" contains a negative number so that errors do not occur. If it is a negative number, use DEFAULT_INTERVAL.","commit_id":"90ecd4ecb3d8a3ac4424030314f911fef1fe377e"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"638e7940916c5b2481fca314515f1df9f6ce5bdc","unresolved":true,"context_lines":[{"line_number":83,"context_line":"                        \"use DEFAULT_INTERVAL.\")"},{"line_number":84,"context_line":"            return DEFAULT_INTERVAL"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def _check_timeout(timeout, interval):"},{"line_number":87,"context_line":"        timeout -\u003d interval"},{"line_number":88,"context_line":"        if timeout \u003c 0:"},{"line_number":89,"context_line":"            msg \u003d (\"coordinationVNF script did not complete within \""}],"source_content_type":"text/x-python","patch_set":8,"id":"893c3d8c_f48b2be9","line":86,"updated":"2023-08-24 02:21:32.000000000","message":"I find it a little confusing to update the timeout in the check function.\nHow about changing the logic to \"get sleep time\"-\u003e\"execute sleep\"-\u003e\"update timeout\" as follows? What dou you think?\n* coord_client.py　L.86-L.92\n```\n    def _execute_sleep(timeout, interval):\n        if timeout \u003c interval:\n            msg \u003d (\"coordinationVNF script did not complete within \"\n                   \"the timeout period.\")\n            raise sol_ex.SolException(sol_detail\u003dmsg)\n        return time.sleep(interval)\n```\n* coord_client.py　L.103-L.105、L.115-L.117\n```\n        interval \u003d _get_retry_after(resp)\n        _execute_sleep(timeout, interval)\n        timeout -\u003d interval\n```","commit_id":"90ecd4ecb3d8a3ac4424030314f911fef1fe377e"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"bccef9feb573740db9924b4793ed8f207bfdd681","unresolved":true,"context_lines":[{"line_number":83,"context_line":"                        \"use DEFAULT_INTERVAL.\")"},{"line_number":84,"context_line":"            return DEFAULT_INTERVAL"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def _check_timeout(timeout, interval):"},{"line_number":87,"context_line":"        timeout -\u003d interval"},{"line_number":88,"context_line":"        if timeout \u003c 0:"},{"line_number":89,"context_line":"            msg \u003d (\"coordinationVNF script did not complete within \""}],"source_content_type":"text/x-python","patch_set":8,"id":"ae7400f7_22c41942","line":86,"in_reply_to":"893c3d8c_f48b2be9","updated":"2023-08-24 15:17:46.000000000","message":"Or it\u0027s might be enough to change the name `_check_timeout` to `_giveup_or_wait_for` to explain the behavior of the method is conditional.","commit_id":"90ecd4ecb3d8a3ac4424030314f911fef1fe377e"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"0a5299a384cfeb114f7b1c156b3497ad4941091d","unresolved":true,"context_lines":[{"line_number":83,"context_line":"                        \"use DEFAULT_INTERVAL.\")"},{"line_number":84,"context_line":"            return DEFAULT_INTERVAL"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def _check_timeout(timeout, interval):"},{"line_number":87,"context_line":"        timeout -\u003d interval"},{"line_number":88,"context_line":"        if timeout \u003c 0:"},{"line_number":89,"context_line":"            msg \u003d (\"coordinationVNF script did not complete within \""}],"source_content_type":"text/x-python","patch_set":8,"id":"cba8f5d0_a0133f2a","line":86,"in_reply_to":"ae7400f7_22c41942","updated":"2023-08-28 07:32:13.000000000","message":"Thank you for the advice. That is better, I will fix it.","commit_id":"90ecd4ecb3d8a3ac4424030314f911fef1fe377e"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"8d075c8b6ed01ad82792cd52c2b9b4cedfeea7c9","unresolved":false,"context_lines":[{"line_number":83,"context_line":"                        \"use DEFAULT_INTERVAL.\")"},{"line_number":84,"context_line":"            return DEFAULT_INTERVAL"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def _check_timeout(timeout, interval):"},{"line_number":87,"context_line":"        timeout -\u003d interval"},{"line_number":88,"context_line":"        if timeout \u003c 0:"},{"line_number":89,"context_line":"            msg \u003d (\"coordinationVNF script did not complete within \""}],"source_content_type":"text/x-python","patch_set":8,"id":"a238ee99_99d28109","line":86,"in_reply_to":"cba8f5d0_a0133f2a","updated":"2023-08-29 01:48:26.000000000","message":"Done","commit_id":"90ecd4ecb3d8a3ac4424030314f911fef1fe377e"}],"tacker/tests/functional/sol_v2/test_individual_vnfc_mgmt.py":[{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"4374f3766b14aeb77a558e6894bf73ed2f8d2dc5","unresolved":true,"context_lines":[{"line_number":73,"context_line":"            pkg_path_2, image_path\u003dimage_path, userdata_path\u003duserdata_path)"},{"line_number":74,"context_line":"        # replace file for notify vnfc_id with mgmt_driver_script"},{"line_number":75,"context_line":"        csar_dir \u003d os.path.join(CONF.vnf_package.vnf_package_csar_path,"},{"line_number":76,"context_line":"                                cls.vnf_pkg_2)"},{"line_number":77,"context_line":"        source_path \u003d \"contents/Scripts/v2_sample4_df_simple.yaml\""},{"line_number":78,"context_line":"        dest_path \u003d \"Definitions/v2_sample4_df_simple.yaml\""},{"line_number":79,"context_line":"        shutil.copy(os.path.join(pkg_path_2, source_path),"}],"source_content_type":"text/x-python","patch_set":1,"id":"0abc2c48_cdc85537","line":76,"updated":"2023-06-29 22:28:51.000000000","message":"cls.vnf_pkg_2 is wrong. cls.new_pkg is right.","commit_id":"b41120f80b4e533ce56974ae04e008eecd913432"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"fbeefd6e0d32899d233e237ed8d05c7703554213","unresolved":false,"context_lines":[{"line_number":73,"context_line":"            pkg_path_2, image_path\u003dimage_path, userdata_path\u003duserdata_path)"},{"line_number":74,"context_line":"        # replace file for notify vnfc_id with mgmt_driver_script"},{"line_number":75,"context_line":"        csar_dir \u003d os.path.join(CONF.vnf_package.vnf_package_csar_path,"},{"line_number":76,"context_line":"                                cls.vnf_pkg_2)"},{"line_number":77,"context_line":"        source_path \u003d \"contents/Scripts/v2_sample4_df_simple.yaml\""},{"line_number":78,"context_line":"        dest_path \u003d \"Definitions/v2_sample4_df_simple.yaml\""},{"line_number":79,"context_line":"        shutil.copy(os.path.join(pkg_path_2, source_path),"}],"source_content_type":"text/x-python","patch_set":1,"id":"f1567985_6a787b48","line":76,"in_reply_to":"0abc2c48_cdc85537","updated":"2023-07-10 22:31:05.000000000","message":"Done","commit_id":"b41120f80b4e533ce56974ae04e008eecd913432"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"76b5a51198bca2a986182e67aedd0ac325a57c1a","unresolved":true,"context_lines":[{"line_number":71,"context_line":"            \"../sol_v2_common/samples/userdata_standard_change_vnfpkg\")"},{"line_number":72,"context_line":"        cls.new_pkg, cls.new_vnfd_id \u003d cls.create_vnf_package("},{"line_number":73,"context_line":"            pkg_path_2, image_path\u003dimage_path, userdata_path\u003duserdata_path)"},{"line_number":74,"context_line":"        # replace file for notify vnfc_id with mgmt_driver_script"},{"line_number":75,"context_line":"        csar_dir \u003d os.path.join(CONF.vnf_package.vnf_package_csar_path,"},{"line_number":76,"context_line":"                                cls.new_pkg)"},{"line_number":77,"context_line":"        source_path \u003d \"contents/Scripts/v2_sample4_df_simple.yaml\""}],"source_content_type":"text/x-python","patch_set":7,"id":"82c60ea1_fb042922","line":74,"updated":"2023-08-09 07:50:48.000000000","message":"Please add the purpose of replacing the file in the comment.","commit_id":"4a6c280cebb978e4d87477a72520ec5463f53252"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"1143f030e8717e0baaeb25b710e419c88e7a40f0","unresolved":true,"context_lines":[{"line_number":71,"context_line":"            \"../sol_v2_common/samples/userdata_standard_change_vnfpkg\")"},{"line_number":72,"context_line":"        cls.new_pkg, cls.new_vnfd_id \u003d cls.create_vnf_package("},{"line_number":73,"context_line":"            pkg_path_2, image_path\u003dimage_path, userdata_path\u003duserdata_path)"},{"line_number":74,"context_line":"        # replace file for notify vnfc_id with mgmt_driver_script"},{"line_number":75,"context_line":"        csar_dir \u003d os.path.join(CONF.vnf_package.vnf_package_csar_path,"},{"line_number":76,"context_line":"                                cls.new_pkg)"},{"line_number":77,"context_line":"        source_path \u003d \"contents/Scripts/v2_sample4_df_simple.yaml\""}],"source_content_type":"text/x-python","patch_set":7,"id":"585f24cc_03c5edde","line":74,"in_reply_to":"043d2ab0_cbf6a38d","updated":"2023-08-21 08:56:56.000000000","message":"Thank you for the fix.\nTo match SOL003 v2.6.1, I think that \"the VNF Package Management\" or \"the vnfpkgm\" is better than \"the vnfpkg\".","commit_id":"4a6c280cebb978e4d87477a72520ec5463f53252"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"0a5299a384cfeb114f7b1c156b3497ad4941091d","unresolved":true,"context_lines":[{"line_number":71,"context_line":"            \"../sol_v2_common/samples/userdata_standard_change_vnfpkg\")"},{"line_number":72,"context_line":"        cls.new_pkg, cls.new_vnfd_id \u003d cls.create_vnf_package("},{"line_number":73,"context_line":"            pkg_path_2, image_path\u003dimage_path, userdata_path\u003duserdata_path)"},{"line_number":74,"context_line":"        # replace file for notify vnfc_id with mgmt_driver_script"},{"line_number":75,"context_line":"        csar_dir \u003d os.path.join(CONF.vnf_package.vnf_package_csar_path,"},{"line_number":76,"context_line":"                                cls.new_pkg)"},{"line_number":77,"context_line":"        source_path \u003d \"contents/Scripts/v2_sample4_df_simple.yaml\""}],"source_content_type":"text/x-python","patch_set":7,"id":"5967c627_a2c21402","line":74,"in_reply_to":"585f24cc_03c5edde","updated":"2023-08-28 07:32:13.000000000","message":"I understand. I will fix it.","commit_id":"4a6c280cebb978e4d87477a72520ec5463f53252"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"8d075c8b6ed01ad82792cd52c2b9b4cedfeea7c9","unresolved":false,"context_lines":[{"line_number":71,"context_line":"            \"../sol_v2_common/samples/userdata_standard_change_vnfpkg\")"},{"line_number":72,"context_line":"        cls.new_pkg, cls.new_vnfd_id \u003d cls.create_vnf_package("},{"line_number":73,"context_line":"            pkg_path_2, image_path\u003dimage_path, userdata_path\u003duserdata_path)"},{"line_number":74,"context_line":"        # replace file for notify vnfc_id with mgmt_driver_script"},{"line_number":75,"context_line":"        csar_dir \u003d os.path.join(CONF.vnf_package.vnf_package_csar_path,"},{"line_number":76,"context_line":"                                cls.new_pkg)"},{"line_number":77,"context_line":"        source_path \u003d \"contents/Scripts/v2_sample4_df_simple.yaml\""}],"source_content_type":"text/x-python","patch_set":7,"id":"b2550327_84f4695d","line":74,"in_reply_to":"5967c627_a2c21402","updated":"2023-08-29 01:48:26.000000000","message":"Done","commit_id":"4a6c280cebb978e4d87477a72520ec5463f53252"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"3541c73c2da402b919e140633784d28e7f6782c0","unresolved":true,"context_lines":[{"line_number":71,"context_line":"            \"../sol_v2_common/samples/userdata_standard_change_vnfpkg\")"},{"line_number":72,"context_line":"        cls.new_pkg, cls.new_vnfd_id \u003d cls.create_vnf_package("},{"line_number":73,"context_line":"            pkg_path_2, image_path\u003dimage_path, userdata_path\u003duserdata_path)"},{"line_number":74,"context_line":"        # replace file for notify vnfc_id with mgmt_driver_script"},{"line_number":75,"context_line":"        csar_dir \u003d os.path.join(CONF.vnf_package.vnf_package_csar_path,"},{"line_number":76,"context_line":"                                cls.new_pkg)"},{"line_number":77,"context_line":"        source_path \u003d \"contents/Scripts/v2_sample4_df_simple.yaml\""}],"source_content_type":"text/x-python","patch_set":7,"id":"043d2ab0_cbf6a38d","line":74,"in_reply_to":"82c60ea1_fb042922","updated":"2023-08-10 02:49:10.000000000","message":"I will fix.","commit_id":"4a6c280cebb978e4d87477a72520ec5463f53252"}],"tacker/tests/functional/sol_v2_common/samples/userdata_standard/contents/Scripts/coordinate_vnf.py":[{"author":{"_account_id":31668,"deleted":true},"change_message_id":"76b5a51198bca2a986182e67aedd0ac325a57c1a","unresolved":true,"context_lines":[{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import os"},{"line_number":17,"context_line":"import pickle"},{"line_number":18,"context_line":"import sys"}],"source_content_type":"text/x-python","patch_set":7,"id":"af0844ea_9d793e86","line":15,"updated":"2023-08-09 07:50:48.000000000","message":"Could you please add a comment stating that this file is temporarily placed in the \"Scripts\" directory for use in IndividualVnfcMgmtTest?\nThe situation where files that should be in \"Definitions\" are in \"Scripts\" may give rise to wrong interpretations.","commit_id":"4a6c280cebb978e4d87477a72520ec5463f53252"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"1143f030e8717e0baaeb25b710e419c88e7a40f0","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import os"},{"line_number":17,"context_line":"import pickle"},{"line_number":18,"context_line":"import sys"}],"source_content_type":"text/x-python","patch_set":7,"id":"dbc72b41_59f065a8","line":15,"in_reply_to":"7e7af31c_31dc1410","updated":"2023-08-21 08:56:56.000000000","message":"Done","commit_id":"4a6c280cebb978e4d87477a72520ec5463f53252"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"c30d96a957b32fe672c1d8ae25f9e15135f7209e","unresolved":true,"context_lines":[{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import os"},{"line_number":17,"context_line":"import pickle"},{"line_number":18,"context_line":"import sys"}],"source_content_type":"text/x-python","patch_set":7,"id":"7e7af31c_31dc1410","line":15,"in_reply_to":"81031a28_dcaca6cf","updated":"2023-08-17 04:44:16.000000000","message":"Thank you for your response. I will add a comment to \"Scripts/v2_sample4_df_simple.yaml\".","commit_id":"4a6c280cebb978e4d87477a72520ec5463f53252"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"3541c73c2da402b919e140633784d28e7f6782c0","unresolved":true,"context_lines":[{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import os"},{"line_number":17,"context_line":"import pickle"},{"line_number":18,"context_line":"import sys"}],"source_content_type":"text/x-python","patch_set":7,"id":"d36105f0_e867da6e","line":15,"in_reply_to":"af0844ea_9d793e86","updated":"2023-08-10 02:49:10.000000000","message":"Just too confirm, is it file \u0027Scripts/v2_sample4_df_simple.yaml\u0027? Or shouod I add a comment to that file(Scripts/coordinate_vnf.py).","commit_id":"4a6c280cebb978e4d87477a72520ec5463f53252"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"dae7b4f31ab93963c3bf2ce1a752be4f4554819c","unresolved":true,"context_lines":[{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import os"},{"line_number":17,"context_line":"import pickle"},{"line_number":18,"context_line":"import sys"}],"source_content_type":"text/x-python","patch_set":7,"id":"81031a28_dcaca6cf","line":15,"in_reply_to":"d36105f0_e867da6e","updated":"2023-08-17 02:36:25.000000000","message":"This comment was intended to add a comment to \"Scripts/v2_sample4_df_simple.yaml\".\n(Sorry, I put this comment in the wrong file...)\nCould you please add a comment to \"Scripts/v2_sample4_df_simple.yaml\"?","commit_id":"4a6c280cebb978e4d87477a72520ec5463f53252"}],"tacker/tests/functional/sol_v2_common/samples/userdata_standard_change_vnfpkg/contents/Scripts/coordinate_vnf.py":[{"author":{"_account_id":31668,"deleted":true},"change_message_id":"76b5a51198bca2a986182e67aedd0ac325a57c1a","unresolved":true,"context_lines":[{"line_number":46,"context_line":"            \"prv.tacker_organization.coordination_test\")"},{"line_number":47,"context_line":"        endpoint \u003d self.vnfc_param.get(\u0027endpoint\u0027)"},{"line_number":48,"context_line":"        authentication \u003d self.vnfc_param.get(\u0027authentication\u0027)"},{"line_number":49,"context_line":"        timeout \u003d self.vnfc_param.get(\u0027timeout\u0027)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        input_params \u003d self.vnfc_param.get(\u0027inputParams\u0027)"},{"line_number":52,"context_line":"        if input_params is not None:"}],"source_content_type":"text/x-python","patch_set":7,"id":"db701597_b6df46fb","line":49,"updated":"2023-08-09 07:50:48.000000000","message":"Is it okay to not check whether the timeout setting value is a number?\n\nIf timeout is not a valid number, I would prefer the default value to be used.\nWhat do you think?","commit_id":"4a6c280cebb978e4d87477a72520ec5463f53252"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"638e7940916c5b2481fca314515f1df9f6ce5bdc","unresolved":false,"context_lines":[{"line_number":46,"context_line":"            \"prv.tacker_organization.coordination_test\")"},{"line_number":47,"context_line":"        endpoint \u003d self.vnfc_param.get(\u0027endpoint\u0027)"},{"line_number":48,"context_line":"        authentication \u003d self.vnfc_param.get(\u0027authentication\u0027)"},{"line_number":49,"context_line":"        timeout \u003d self.vnfc_param.get(\u0027timeout\u0027)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        input_params \u003d self.vnfc_param.get(\u0027inputParams\u0027)"},{"line_number":52,"context_line":"        if input_params is not None:"}],"source_content_type":"text/x-python","patch_set":7,"id":"ffba1882_91befe85","line":49,"in_reply_to":"2b5c9841_d7a6ceae","updated":"2023-08-24 02:21:32.000000000","message":"The above comment was concerned about the possibility of setting a negative value to sleep.\nI think it is more suitable to check if interval is not a negative value instead of timeout.\nI withdraw the above comment and add a another comment.","commit_id":"4a6c280cebb978e4d87477a72520ec5463f53252"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"1143f030e8717e0baaeb25b710e419c88e7a40f0","unresolved":true,"context_lines":[{"line_number":46,"context_line":"            \"prv.tacker_organization.coordination_test\")"},{"line_number":47,"context_line":"        endpoint \u003d self.vnfc_param.get(\u0027endpoint\u0027)"},{"line_number":48,"context_line":"        authentication \u003d self.vnfc_param.get(\u0027authentication\u0027)"},{"line_number":49,"context_line":"        timeout \u003d self.vnfc_param.get(\u0027timeout\u0027)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        input_params \u003d self.vnfc_param.get(\u0027inputParams\u0027)"},{"line_number":52,"context_line":"        if input_params is not None:"}],"source_content_type":"text/x-python","patch_set":7,"id":"2b5c9841_d7a6ceae","line":49,"in_reply_to":"cedd7959_4111b284","updated":"2023-08-21 08:56:56.000000000","message":"Thank you for the fix.\nIs it unnecessary to check whether the number is greater than 0?","commit_id":"4a6c280cebb978e4d87477a72520ec5463f53252"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"3541c73c2da402b919e140633784d28e7f6782c0","unresolved":true,"context_lines":[{"line_number":46,"context_line":"            \"prv.tacker_organization.coordination_test\")"},{"line_number":47,"context_line":"        endpoint \u003d self.vnfc_param.get(\u0027endpoint\u0027)"},{"line_number":48,"context_line":"        authentication \u003d self.vnfc_param.get(\u0027authentication\u0027)"},{"line_number":49,"context_line":"        timeout \u003d self.vnfc_param.get(\u0027timeout\u0027)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        input_params \u003d self.vnfc_param.get(\u0027inputParams\u0027)"},{"line_number":52,"context_line":"        if input_params is not None:"}],"source_content_type":"text/x-python","patch_set":7,"id":"cedd7959_4111b284","line":49,"in_reply_to":"db701597_b6df46fb","updated":"2023-08-10 02:49:10.000000000","message":"I think it is necessary to check if it is numeric or not too. I would add it to the create_coordination method(common/coord_client.py) as I think it would be better to check it at the create_coordination method.","commit_id":"4a6c280cebb978e4d87477a72520ec5463f53252"}],"tacker/tests/functional/sol_v2_common/samples/userdata_standard_change_vnfpkg/contents/Scripts/sample_script.py":[{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"42874cdc307dc74e82c1857670d4859f3605a461","unresolved":true,"context_lines":[{"line_number":71,"context_line":"                 in self.inst[\u0027instantiatedVnfInfo\u0027][\u0027vnfcResourceInfo\u0027]"},{"line_number":72,"context_line":"                 if vnfc[\u0027computeResource\u0027][\u0027resourceId\u0027] in vnfc_res_ids]"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        input_params \u003d {}"},{"line_number":75,"context_line":"        input_params[\u0027vnfc_id\u0027] \u003d ("},{"line_number":76,"context_line":"            f\"{vnfcs[0][\u0027vduId\u0027]}-{vnfcs[0][\u0027metadata\u0027][\u0027vdu_idx\u0027]}\")"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"18bd4c76_d6dcc452","line":74,"updated":"2023-07-09 23:08:48.000000000","message":"should be coordinate request.","commit_id":"5cb18ea94e7b7e3684d9d6c990f77f4c78ff7a5e"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"fbeefd6e0d32899d233e237ed8d05c7703554213","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                 in self.inst[\u0027instantiatedVnfInfo\u0027][\u0027vnfcResourceInfo\u0027]"},{"line_number":72,"context_line":"                 if vnfc[\u0027computeResource\u0027][\u0027resourceId\u0027] in vnfc_res_ids]"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        input_params \u003d {}"},{"line_number":75,"context_line":"        input_params[\u0027vnfc_id\u0027] \u003d ("},{"line_number":76,"context_line":"            f\"{vnfcs[0][\u0027vduId\u0027]}-{vnfcs[0][\u0027metadata\u0027][\u0027vdu_idx\u0027]}\")"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"8ba2fa21_c3e8fa2a","line":74,"in_reply_to":"18bd4c76_d6dcc452","updated":"2023-07-10 22:31:05.000000000","message":"Done","commit_id":"5cb18ea94e7b7e3684d9d6c990f77f4c78ff7a5e"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"42874cdc307dc74e82c1857670d4859f3605a461","unresolved":true,"context_lines":[{"line_number":72,"context_line":"                 if vnfc[\u0027computeResource\u0027][\u0027resourceId\u0027] in vnfc_res_ids]"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        input_params \u003d {}"},{"line_number":75,"context_line":"        input_params[\u0027vnfc_id\u0027] \u003d ("},{"line_number":76,"context_line":"            f\"{vnfcs[0][\u0027vduId\u0027]}-{vnfcs[0][\u0027metadata\u0027][\u0027vdu_idx\u0027]}\")"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        for vdu_param in self.req[\u0027additionalParams\u0027][\u0027vdu_params\u0027]:"}],"source_content_type":"text/x-python","patch_set":3,"id":"28e4b7d7_6690a727","line":75,"updated":"2023-07-09 23:08:48.000000000","message":"vnfc_id should be get from inst[\u0027instantiatedVnfInfo\u0027][\u0027vnfcInfo\u0027].","commit_id":"5cb18ea94e7b7e3684d9d6c990f77f4c78ff7a5e"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"fbeefd6e0d32899d233e237ed8d05c7703554213","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                 if vnfc[\u0027computeResource\u0027][\u0027resourceId\u0027] in vnfc_res_ids]"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        input_params \u003d {}"},{"line_number":75,"context_line":"        input_params[\u0027vnfc_id\u0027] \u003d ("},{"line_number":76,"context_line":"            f\"{vnfcs[0][\u0027vduId\u0027]}-{vnfcs[0][\u0027metadata\u0027][\u0027vdu_idx\u0027]}\")"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        for vdu_param in self.req[\u0027additionalParams\u0027][\u0027vdu_params\u0027]:"}],"source_content_type":"text/x-python","patch_set":3,"id":"4ad26d28_6b281e51","line":75,"in_reply_to":"28e4b7d7_6690a727","updated":"2023-07-10 22:31:05.000000000","message":"Done","commit_id":"5cb18ea94e7b7e3684d9d6c990f77f4c78ff7a5e"}],"tacker/tests/unit/sol_refactored/common/test_coord_client.py":[{"author":{"_account_id":31668,"deleted":true},"change_message_id":"76b5a51198bca2a986182e67aedd0ac325a57c1a","unresolved":true,"context_lines":[{"line_number":22,"context_line":"from tacker.tests import base"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"endpoint \u003d \u0027http://127.0.0.1:6789\u0027"},{"line_number":26,"context_line":"timeout \u003d 30"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"coord_req_example \u003d {"},{"line_number":29,"context_line":"    \u0027vnfInstanceId\u0027: \u0027b18a8a15-8973-4202-a2f0-a67a109fc461\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"52ed1b05_80d3395f","line":26,"range":{"start_line":25,"start_character":0,"end_line":26,"end_character":12},"updated":"2023-08-09 07:50:48.000000000","message":"Constants are better in upper case.\n* ENDPOINT \u003d \u0027http://127.0.0.1:6789\u0027\n* TIMEOUT \u003d 30","commit_id":"4a6c280cebb978e4d87477a72520ec5463f53252"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"1143f030e8717e0baaeb25b710e419c88e7a40f0","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from tacker.tests import base"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"endpoint \u003d \u0027http://127.0.0.1:6789\u0027"},{"line_number":26,"context_line":"timeout \u003d 30"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"coord_req_example \u003d {"},{"line_number":29,"context_line":"    \u0027vnfInstanceId\u0027: \u0027b18a8a15-8973-4202-a2f0-a67a109fc461\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"9740505a_7a11ab99","line":26,"range":{"start_line":25,"start_character":0,"end_line":26,"end_character":12},"in_reply_to":"4f956ede_9176d3f2","updated":"2023-08-21 08:56:56.000000000","message":"Done","commit_id":"4a6c280cebb978e4d87477a72520ec5463f53252"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"3541c73c2da402b919e140633784d28e7f6782c0","unresolved":true,"context_lines":[{"line_number":22,"context_line":"from tacker.tests import base"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"endpoint \u003d \u0027http://127.0.0.1:6789\u0027"},{"line_number":26,"context_line":"timeout \u003d 30"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"coord_req_example \u003d {"},{"line_number":29,"context_line":"    \u0027vnfInstanceId\u0027: \u0027b18a8a15-8973-4202-a2f0-a67a109fc461\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"4f956ede_9176d3f2","line":26,"range":{"start_line":25,"start_character":0,"end_line":26,"end_character":12},"in_reply_to":"52ed1b05_80d3395f","updated":"2023-08-10 02:49:10.000000000","message":"I will fix.","commit_id":"4a6c280cebb978e4d87477a72520ec5463f53252"}]}