)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":31668},"change_message_id":"6123f0b6cd0f881c1863ba08e659c92beef9fa9c","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch supports Container Update MgmtDriver in the operation"},{"line_number":10,"context_line":"of modifying VNF in v2 API."},{"line_number":11,"context_line":"It provides a sample script MgmtDriver, when modifying CNF,"},{"line_number":12,"context_line":"If the ConfigMap and Secret are updated, the Pod, Deployment,"},{"line_number":13,"context_line":"ReplicaSet, DaemonSet will also be updated (image only)."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"96b3d036_71a5a131","line":11,"updated":"2023-09-06 08:07:35.000000000","message":"nit: CNF, -\u003e CNF.","commit_id":"e6f7649f78b3fad11879c017825f3d2beb7ac1fa"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"ce8ce8d07e0ce5013f5492c1c1461006ed86c69a","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch supports Container Update MgmtDriver in the operation"},{"line_number":10,"context_line":"of modifying VNF in v2 API."},{"line_number":11,"context_line":"It provides a sample script MgmtDriver, when modifying CNF,"},{"line_number":12,"context_line":"If the ConfigMap and Secret are updated, the Pod, Deployment,"},{"line_number":13,"context_line":"ReplicaSet, DaemonSet will also be updated (image only)."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9b55c34e_19c26e06","line":11,"in_reply_to":"96b3d036_71a5a131","updated":"2023-09-07 01:50:06.000000000","message":"I fixed it in patchset 10.","commit_id":"e6f7649f78b3fad11879c017825f3d2beb7ac1fa"},{"author":{"_account_id":31668},"change_message_id":"d1c59dbb36de30747474fd12672d5f3aec6e5327","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch supports Container Update MgmtDriver in the operation"},{"line_number":10,"context_line":"of modifying VNF in v2 API."},{"line_number":11,"context_line":"It provides a sample script MgmtDriver, when modifying CNF,"},{"line_number":12,"context_line":"If the ConfigMap and Secret are updated, the Pod, Deployment,"},{"line_number":13,"context_line":"ReplicaSet, DaemonSet will also be updated (image only)."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"b84c6e5c_68afd722","line":11,"in_reply_to":"9b55c34e_19c26e06","updated":"2023-09-07 08:13:51.000000000","message":"Done","commit_id":"e6f7649f78b3fad11879c017825f3d2beb7ac1fa"},{"author":{"_account_id":31668},"change_message_id":"6123f0b6cd0f881c1863ba08e659c92beef9fa9c","unresolved":true,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This patch also updated the user guide for how to use Container"},{"line_number":16,"context_line":"Update MgmtDriver, adding the usage method in v2 API."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Idf7aeff010f0a4329315f75a7e4574485f1f2efc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"667c99f5_340a8c24","line":17,"updated":"2023-09-06 08:07:35.000000000","message":"Please add related Blueprint.\nCould you please modify the topic accordingly?","commit_id":"e6f7649f78b3fad11879c017825f3d2beb7ac1fa"},{"author":{"_account_id":31668},"change_message_id":"d1c59dbb36de30747474fd12672d5f3aec6e5327","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This patch also updated the user guide for how to use Container"},{"line_number":16,"context_line":"Update MgmtDriver, adding the usage method in v2 API."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Idf7aeff010f0a4329315f75a7e4574485f1f2efc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"09d92987_a235435f","line":17,"in_reply_to":"32e65f99_2b6bc932","updated":"2023-09-07 08:13:51.000000000","message":"Done","commit_id":"e6f7649f78b3fad11879c017825f3d2beb7ac1fa"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"ce8ce8d07e0ce5013f5492c1c1461006ed86c69a","unresolved":true,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This patch also updated the user guide for how to use Container"},{"line_number":16,"context_line":"Update MgmtDriver, adding the usage method in v2 API."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Idf7aeff010f0a4329315f75a7e4574485f1f2efc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"32e65f99_2b6bc932","line":17,"in_reply_to":"667c99f5_340a8c24","updated":"2023-09-07 01:50:06.000000000","message":"I fixed it in patchset 10.","commit_id":"e6f7649f78b3fad11879c017825f3d2beb7ac1fa"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"a892339b44c233f62cec483147ff6bcee428df04","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"28f1d6ed_c4090321","updated":"2023-08-04 13:32:27.000000000","message":"Thanks for your patch, please kindly find my comment.","commit_id":"7f27176080b09e312dea1744db832746c3f96fcd"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"7e13989517b26312b510646d28be78ae467e6b92","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"924d7d6f_880e1042","updated":"2023-08-24 07:59:10.000000000","message":"recheck, infra failure in sol-separated-nfvo-v2 job","commit_id":"fdc1f4ebb73969b76a51133de4a69cc712d37dd2"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"b8da172e16d6e1920c0541c5e270df8f3b2b4b90","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"62ae50ad_118f6db0","updated":"2023-08-24 04:43:20.000000000","message":"recheck, infra failure in sol-v2-ubuntu-focal, sol-kubernetes-v2 job","commit_id":"fdc1f4ebb73969b76a51133de4a69cc712d37dd2"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"88d520e8b293835e8a6fe29b8a8f81fad64e3570","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"61d93b2e_fba9c2d4","updated":"2023-08-30 14:58:59.000000000","message":"Thanks for your updating, LGTM.","commit_id":"78739c1a935e3d6dbe108f1670a7b1923f2fa8d3"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"1edd707ea23e7614ff343c32264d739deece17cc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"60dd8737_2f49492b","updated":"2023-08-29 00:41:59.000000000","message":"recheck, infra failure in sol-v2-ubuntu-focal and sol-kubernetes-v2 job","commit_id":"78739c1a935e3d6dbe108f1670a7b1923f2fa8d3"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"5f3384ef6fadf7ff4c188e5ad1ad513a18994e2b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"a4f8f32f_acc8d975","updated":"2023-08-28 08:45:02.000000000","message":"recheck, tox failure in tox-py39 job","commit_id":"78739c1a935e3d6dbe108f1670a7b1923f2fa8d3"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"c4741e78b97392e8f2d7e434a2954fc55c1a71d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"44a66fcd_493ba70f","updated":"2023-09-07 04:40:12.000000000","message":"recheck, infra failure in sol-v2 job","commit_id":"600aabe8341d972dc92a370c4a5e936774bcf629"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"2693a30b630499860a81205acbe2d5a8976aca83","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"b4b44aab_f0b919dc","updated":"2023-09-15 01:15:56.000000000","message":"To: Hamano-san, Fukaya-san\nIf you have confirmed the fixes, would you please put CR+1?\n\nHi, cores.\nThis patch is set to be the parent patch of another unmerged patch, so we want to merge it ASAP.\nIf there are no problems, I would like to request a merge.","commit_id":"7090af052303bee771b37caea3aa99a3b3be2730"},{"author":{"_account_id":31668},"change_message_id":"ac3ddd860d411f4a3219609fa35909c563b532e8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"784f9a48_97af92c8","updated":"2023-09-15 01:20:29.000000000","message":"Ueha-san, thank you for confirming. LGTM","commit_id":"7090af052303bee771b37caea3aa99a3b3be2730"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"40f1af3df4a9a71f3d7e46522595618c60019f1d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"1d5d2adb_65f040f2","updated":"2023-09-14 09:30:21.000000000","message":"recheck - infra failure in sol-kubernetes job","commit_id":"7090af052303bee771b37caea3aa99a3b3be2730"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"ac3e00833f23c10c6fb4575c8bcaee41722b395b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"2e54ee91_6454ac38","updated":"2023-09-14 06:44:12.000000000","message":"recheck, infra failure in sol-v2 job","commit_id":"7090af052303bee771b37caea3aa99a3b3be2730"}],"doc/source/user/mgmt_driver_for_container_update.rst":[{"author":{"_account_id":31668},"change_message_id":"6123f0b6cd0f881c1863ba08e659c92beef9fa9c","unresolved":true,"context_lines":[{"line_number":29,"context_line":".. figure:: ../_images/mgmt_driver_for_container_update.png"},{"line_number":30,"context_line":"    :align: left"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Mgmt Driver Introduction"},{"line_number":33,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Mgmt Driver enables Users to configure their VNF before and/or after"}],"source_content_type":"text/x-rst","patch_set":9,"id":"b8a91d98_bda82c53","line":32,"updated":"2023-09-06 08:07:35.000000000","message":"In the html file, this chapter is on the right side of the diagram.\nI think the bottom one is better, what do you think?","commit_id":"e6f7649f78b3fad11879c017825f3d2beb7ac1fa"},{"author":{"_account_id":31668},"change_message_id":"d1c59dbb36de30747474fd12672d5f3aec6e5327","unresolved":false,"context_lines":[{"line_number":29,"context_line":".. figure:: ../_images/mgmt_driver_for_container_update.png"},{"line_number":30,"context_line":"    :align: left"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Mgmt Driver Introduction"},{"line_number":33,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Mgmt Driver enables Users to configure their VNF before and/or after"}],"source_content_type":"text/x-rst","patch_set":9,"id":"cb274127_5c35f28e","line":32,"in_reply_to":"af36b6fd_8a66d234","updated":"2023-09-07 08:13:51.000000000","message":"Done","commit_id":"e6f7649f78b3fad11879c017825f3d2beb7ac1fa"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"ce8ce8d07e0ce5013f5492c1c1461006ed86c69a","unresolved":true,"context_lines":[{"line_number":29,"context_line":".. figure:: ../_images/mgmt_driver_for_container_update.png"},{"line_number":30,"context_line":"    :align: left"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Mgmt Driver Introduction"},{"line_number":33,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Mgmt Driver enables Users to configure their VNF before and/or after"}],"source_content_type":"text/x-rst","patch_set":9,"id":"af36b6fd_8a66d234","line":32,"in_reply_to":"b8a91d98_bda82c53","updated":"2023-09-07 01:50:06.000000000","message":"I moved this part to the bottom.","commit_id":"e6f7649f78b3fad11879c017825f3d2beb7ac1fa"},{"author":{"_account_id":31668},"change_message_id":"6123f0b6cd0f881c1863ba08e659c92beef9fa9c","unresolved":true,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":".. note::"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    In this document, ``TACKER_ROOT`` is the root of tacker’s repository on"},{"line_number":92,"context_line":"    the server."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"When Use v1 API"}],"source_content_type":"text/x-rst","patch_set":9,"id":"9c79b21f_dabb6fb4","line":91,"updated":"2023-09-06 08:07:35.000000000","message":"nit: tacker’s -\u003e tacker\u0027s\nIt looks like the single quote is full-width.","commit_id":"e6f7649f78b3fad11879c017825f3d2beb7ac1fa"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"ce8ce8d07e0ce5013f5492c1c1461006ed86c69a","unresolved":true,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":".. note::"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    In this document, ``TACKER_ROOT`` is the root of tacker’s repository on"},{"line_number":92,"context_line":"    the server."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"When Use v1 API"}],"source_content_type":"text/x-rst","patch_set":9,"id":"aa73ce01_fb70211b","line":91,"in_reply_to":"9c79b21f_dabb6fb4","updated":"2023-09-07 01:50:06.000000000","message":"I fixed it in patchset 10.","commit_id":"e6f7649f78b3fad11879c017825f3d2beb7ac1fa"},{"author":{"_account_id":31668},"change_message_id":"d1c59dbb36de30747474fd12672d5f3aec6e5327","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":".. note::"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    In this document, ``TACKER_ROOT`` is the root of tacker’s repository on"},{"line_number":92,"context_line":"    the server."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"When Use v1 API"}],"source_content_type":"text/x-rst","patch_set":9,"id":"d29d4ce2_f90cc37b","line":91,"in_reply_to":"aa73ce01_fb70211b","updated":"2023-09-07 08:13:51.000000000","message":"Done","commit_id":"e6f7649f78b3fad11879c017825f3d2beb7ac1fa"},{"author":{"_account_id":31668},"change_message_id":"6123f0b6cd0f881c1863ba08e659c92beef9fa9c","unresolved":true,"context_lines":[{"line_number":215,"context_line":""},{"line_number":216,"context_line":".. note::"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    If you need to use the v2 API, You can add `--os-tacker-api-version 2`"},{"line_number":219,"context_line":"    to the end of all commands related to `openstack vnflcm`."},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    Or you can modify environment variables. `export OS_TACKER_API_VERSION\u003d2`"}],"source_content_type":"text/x-rst","patch_set":9,"id":"c040e7da_241a8012","line":218,"updated":"2023-09-06 08:07:35.000000000","message":"nit: You -\u003e you","commit_id":"e6f7649f78b3fad11879c017825f3d2beb7ac1fa"},{"author":{"_account_id":31668},"change_message_id":"d1c59dbb36de30747474fd12672d5f3aec6e5327","unresolved":false,"context_lines":[{"line_number":215,"context_line":""},{"line_number":216,"context_line":".. note::"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    If you need to use the v2 API, You can add `--os-tacker-api-version 2`"},{"line_number":219,"context_line":"    to the end of all commands related to `openstack vnflcm`."},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    Or you can modify environment variables. `export OS_TACKER_API_VERSION\u003d2`"}],"source_content_type":"text/x-rst","patch_set":9,"id":"36d7cb36_cfeca483","line":218,"in_reply_to":"29db83c7_a6aa5b5d","updated":"2023-09-07 08:13:51.000000000","message":"Done","commit_id":"e6f7649f78b3fad11879c017825f3d2beb7ac1fa"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"ce8ce8d07e0ce5013f5492c1c1461006ed86c69a","unresolved":true,"context_lines":[{"line_number":215,"context_line":""},{"line_number":216,"context_line":".. note::"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    If you need to use the v2 API, You can add `--os-tacker-api-version 2`"},{"line_number":219,"context_line":"    to the end of all commands related to `openstack vnflcm`."},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    Or you can modify environment variables. `export OS_TACKER_API_VERSION\u003d2`"}],"source_content_type":"text/x-rst","patch_set":9,"id":"29db83c7_a6aa5b5d","line":218,"in_reply_to":"c040e7da_241a8012","updated":"2023-09-07 01:50:06.000000000","message":"I fixed it in patchset 10.","commit_id":"e6f7649f78b3fad11879c017825f3d2beb7ac1fa"},{"author":{"_account_id":31668},"change_message_id":"6123f0b6cd0f881c1863ba08e659c92beef9fa9c","unresolved":true,"context_lines":[{"line_number":284,"context_line":"CNF Updating Procedure"},{"line_number":285,"context_line":"-----------------------"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"As mentioned in Prerequisites, the VNF must be instantiated before performing"},{"line_number":288,"context_line":"updating."},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"Next, the user can use the original vnf package as a template to make a new"}],"source_content_type":"text/x-rst","patch_set":9,"id":"f889d9af_98888d49","line":287,"updated":"2023-09-06 08:07:35.000000000","message":"How about adding an internal link to the \"Prerequisites\"?","commit_id":"e6f7649f78b3fad11879c017825f3d2beb7ac1fa"},{"author":{"_account_id":31668},"change_message_id":"d1c59dbb36de30747474fd12672d5f3aec6e5327","unresolved":false,"context_lines":[{"line_number":284,"context_line":"CNF Updating Procedure"},{"line_number":285,"context_line":"-----------------------"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"As mentioned in Prerequisites, the VNF must be instantiated before performing"},{"line_number":288,"context_line":"updating."},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"Next, the user can use the original vnf package as a template to make a new"}],"source_content_type":"text/x-rst","patch_set":9,"id":"0e1af557_22d30b57","line":287,"in_reply_to":"1d218e0a_5eb6a6a6","updated":"2023-09-07 08:13:51.000000000","message":"Done","commit_id":"e6f7649f78b3fad11879c017825f3d2beb7ac1fa"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"ce8ce8d07e0ce5013f5492c1c1461006ed86c69a","unresolved":true,"context_lines":[{"line_number":284,"context_line":"CNF Updating Procedure"},{"line_number":285,"context_line":"-----------------------"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"As mentioned in Prerequisites, the VNF must be instantiated before performing"},{"line_number":288,"context_line":"updating."},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"Next, the user can use the original vnf package as a template to make a new"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1d218e0a_5eb6a6a6","line":287,"in_reply_to":"f889d9af_98888d49","updated":"2023-09-07 01:50:06.000000000","message":"I appended an internal link.","commit_id":"e6f7649f78b3fad11879c017825f3d2beb7ac1fa"}],"tacker/sol_refactored/mgmt_drivers/container_update_mgmt_v2.py":[{"author":{"_account_id":32707,"name":"Kenta Fukaya","email":"kenta.fukaya.xv@hco.ntt.co.jp","username":"fukayan"},"change_message_id":"75ea1c20d9b21816d12e414daa9814b81fd5d92d","unresolved":true,"context_lines":[{"line_number":374,"context_line":"    try:"},{"line_number":375,"context_line":"        main()"},{"line_number":376,"context_line":"        os._exit(0)"},{"line_number":377,"context_line":"    except Exception as ex:"},{"line_number":378,"context_line":"        sys.stderr.write(str(ex))"},{"line_number":379,"context_line":"        sys.stderr.flush()"},{"line_number":380,"context_line":"        os._exit(1)"}],"source_content_type":"text/x-python","patch_set":9,"id":"e01666de_6b6a2d11","line":377,"updated":"2023-09-13 08:35:14.000000000","message":"This is too general exception.\ncan you Limit the cause of the error","commit_id":"e6f7649f78b3fad11879c017825f3d2beb7ac1fa"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"ae9a963ad5f88ba80b9666fa35b9d204bb785125","unresolved":true,"context_lines":[{"line_number":374,"context_line":"    try:"},{"line_number":375,"context_line":"        main()"},{"line_number":376,"context_line":"        os._exit(0)"},{"line_number":377,"context_line":"    except Exception as ex:"},{"line_number":378,"context_line":"        sys.stderr.write(str(ex))"},{"line_number":379,"context_line":"        sys.stderr.flush()"},{"line_number":380,"context_line":"        os._exit(1)"}],"source_content_type":"text/x-python","patch_set":9,"id":"d62b92b3_e95010ad","line":377,"in_reply_to":"e01666de_6b6a2d11","updated":"2023-09-14 03:18:41.000000000","message":"I will change `Exception` to `MgmtDriverOtherError` in patchset 14.","commit_id":"e6f7649f78b3fad11879c017825f3d2beb7ac1fa"},{"author":{"_account_id":31668},"change_message_id":"d1c59dbb36de30747474fd12672d5f3aec6e5327","unresolved":true,"context_lines":[{"line_number":40,"context_line":"        self.inst \u003d inst"},{"line_number":41,"context_line":"        self.grant_req \u003d grant_req"},{"line_number":42,"context_line":"        self.grant \u003d grant"},{"line_number":43,"context_line":"        self.csar_dir \u003d new_csar_dir"},{"line_number":44,"context_line":"        self.old_csar_dir \u003d csar_dir"},{"line_number":45,"context_line":"        # NOTE: In this script, vimConnectionInfo in the form of object is"},{"line_number":46,"context_line":"        # needed to initialize k8s_client, but the input parameter is in the"},{"line_number":47,"context_line":"        # form of dict and needs to be converted. However, the script is"}],"source_content_type":"text/x-python","patch_set":10,"id":"dd76cb05_948998a0","line":44,"range":{"start_line":43,"start_character":0,"end_line":44,"end_character":36},"updated":"2023-09-07 08:13:51.000000000","message":"How about using `old_csar_dir` and `new_csar_dir`?\n```\n        self.new_csar_dir \u003d new_csar_dir\n        self.old_csar_dir \u003d old_csar_dir\n```","commit_id":"600aabe8341d972dc92a370c4a5e936774bcf629"},{"author":{"_account_id":31668},"change_message_id":"4b3a5ca684cc9decb7603cd5c1ff29b759e50b12","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        self.inst \u003d inst"},{"line_number":41,"context_line":"        self.grant_req \u003d grant_req"},{"line_number":42,"context_line":"        self.grant \u003d grant"},{"line_number":43,"context_line":"        self.csar_dir \u003d new_csar_dir"},{"line_number":44,"context_line":"        self.old_csar_dir \u003d csar_dir"},{"line_number":45,"context_line":"        # NOTE: In this script, vimConnectionInfo in the form of object is"},{"line_number":46,"context_line":"        # needed to initialize k8s_client, but the input parameter is in the"},{"line_number":47,"context_line":"        # form of dict and needs to be converted. However, the script is"}],"source_content_type":"text/x-python","patch_set":10,"id":"ce2f6293_911024f5","line":44,"range":{"start_line":43,"start_character":0,"end_line":44,"end_character":36},"in_reply_to":"be9146d3_f563f920","updated":"2023-09-11 01:18:10.000000000","message":"Done","commit_id":"600aabe8341d972dc92a370c4a5e936774bcf629"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"00162f7f86001154eca769756079cce077f73e5d","unresolved":true,"context_lines":[{"line_number":40,"context_line":"        self.inst \u003d inst"},{"line_number":41,"context_line":"        self.grant_req \u003d grant_req"},{"line_number":42,"context_line":"        self.grant \u003d grant"},{"line_number":43,"context_line":"        self.csar_dir \u003d new_csar_dir"},{"line_number":44,"context_line":"        self.old_csar_dir \u003d csar_dir"},{"line_number":45,"context_line":"        # NOTE: In this script, vimConnectionInfo in the form of object is"},{"line_number":46,"context_line":"        # needed to initialize k8s_client, but the input parameter is in the"},{"line_number":47,"context_line":"        # form of dict and needs to be converted. However, the script is"}],"source_content_type":"text/x-python","patch_set":10,"id":"be9146d3_f563f920","line":44,"range":{"start_line":43,"start_character":0,"end_line":44,"end_character":36},"in_reply_to":"dd76cb05_948998a0","updated":"2023-09-08 06:37:50.000000000","message":"I fixed it in patchset 11.","commit_id":"600aabe8341d972dc92a370c4a5e936774bcf629"},{"author":{"_account_id":31668},"change_message_id":"d1c59dbb36de30747474fd12672d5f3aec6e5327","unresolved":true,"context_lines":[{"line_number":50,"context_line":"        objects.register_all()"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def _get_kind_and_name(self, file, vnf_package_path):"},{"line_number":53,"context_line":"        # kind_and_names ----\u003e configmap_secrets list or resources list"},{"line_number":54,"context_line":"        kind_and_names \u003d []"},{"line_number":55,"context_line":"        # Read the contents of the manifest file and get the name and kind"},{"line_number":56,"context_line":"        if ((urlparse(file).scheme \u003d\u003d \u0027file\u0027) or"}],"source_content_type":"text/x-python","patch_set":10,"id":"e7d67d8e_65f20fc1","line":53,"updated":"2023-09-07 08:13:51.000000000","message":"What does this comment mean?","commit_id":"600aabe8341d972dc92a370c4a5e936774bcf629"},{"author":{"_account_id":31668},"change_message_id":"4b3a5ca684cc9decb7603cd5c1ff29b759e50b12","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        objects.register_all()"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def _get_kind_and_name(self, file, vnf_package_path):"},{"line_number":53,"context_line":"        # kind_and_names ----\u003e configmap_secrets list or resources list"},{"line_number":54,"context_line":"        kind_and_names \u003d []"},{"line_number":55,"context_line":"        # Read the contents of the manifest file and get the name and kind"},{"line_number":56,"context_line":"        if ((urlparse(file).scheme \u003d\u003d \u0027file\u0027) or"}],"source_content_type":"text/x-python","patch_set":10,"id":"9bda031e_34b09cae","line":53,"in_reply_to":"8a91d05c_e8ab96e1","updated":"2023-09-11 01:18:10.000000000","message":"Done","commit_id":"600aabe8341d972dc92a370c4a5e936774bcf629"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"00162f7f86001154eca769756079cce077f73e5d","unresolved":true,"context_lines":[{"line_number":50,"context_line":"        objects.register_all()"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def _get_kind_and_name(self, file, vnf_package_path):"},{"line_number":53,"context_line":"        # kind_and_names ----\u003e configmap_secrets list or resources list"},{"line_number":54,"context_line":"        kind_and_names \u003d []"},{"line_number":55,"context_line":"        # Read the contents of the manifest file and get the name and kind"},{"line_number":56,"context_line":"        if ((urlparse(file).scheme \u003d\u003d \u0027file\u0027) or"}],"source_content_type":"text/x-python","patch_set":10,"id":"8a91d05c_e8ab96e1","line":53,"in_reply_to":"e7d67d8e_65f20fc1","updated":"2023-09-08 06:37:50.000000000","message":"I removed this comment, it doesn\u0027t make sense.","commit_id":"600aabe8341d972dc92a370c4a5e936774bcf629"},{"author":{"_account_id":31668},"change_message_id":"d1c59dbb36de30747474fd12672d5f3aec6e5327","unresolved":true,"context_lines":[{"line_number":68,"context_line":"            kind_and_names.append({\u0027kind\u0027: kind, \u0027name\u0027: name})"},{"line_number":69,"context_line":"        return kind_and_names"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def _modify_container_img(self, old_containers, new_containers):"},{"line_number":72,"context_line":"        flag \u003d False"},{"line_number":73,"context_line":"        for old_container in old_containers:"},{"line_number":74,"context_line":"            for new_container in new_containers:"}],"source_content_type":"text/x-python","patch_set":10,"id":"666c0bce_439024f2","line":71,"updated":"2023-09-07 08:13:51.000000000","message":"`old_containers` is a list of V1Container and `new_containers` is a list of dict, which is confusing.\nHow about changing it like below?\n```\n    def _modify_container_img(self, containers, new_values):\n```","commit_id":"600aabe8341d972dc92a370c4a5e936774bcf629"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"00162f7f86001154eca769756079cce077f73e5d","unresolved":true,"context_lines":[{"line_number":68,"context_line":"            kind_and_names.append({\u0027kind\u0027: kind, \u0027name\u0027: name})"},{"line_number":69,"context_line":"        return kind_and_names"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def _modify_container_img(self, old_containers, new_containers):"},{"line_number":72,"context_line":"        flag \u003d False"},{"line_number":73,"context_line":"        for old_container in old_containers:"},{"line_number":74,"context_line":"            for new_container in new_containers:"}],"source_content_type":"text/x-python","patch_set":10,"id":"b12eef67_b295fc0f","line":71,"in_reply_to":"666c0bce_439024f2","updated":"2023-09-08 06:37:50.000000000","message":"I fixed it in patchset 11.","commit_id":"600aabe8341d972dc92a370c4a5e936774bcf629"},{"author":{"_account_id":31668},"change_message_id":"4b3a5ca684cc9decb7603cd5c1ff29b759e50b12","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            kind_and_names.append({\u0027kind\u0027: kind, \u0027name\u0027: name})"},{"line_number":69,"context_line":"        return kind_and_names"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def _modify_container_img(self, old_containers, new_containers):"},{"line_number":72,"context_line":"        flag \u003d False"},{"line_number":73,"context_line":"        for old_container in old_containers:"},{"line_number":74,"context_line":"            for new_container in new_containers:"}],"source_content_type":"text/x-python","patch_set":10,"id":"a6f4a6da_10bfe483","line":71,"in_reply_to":"b12eef67_b295fc0f","updated":"2023-09-11 01:18:10.000000000","message":"Done","commit_id":"600aabe8341d972dc92a370c4a5e936774bcf629"},{"author":{"_account_id":31668},"change_message_id":"d1c59dbb36de30747474fd12672d5f3aec6e5327","unresolved":true,"context_lines":[{"line_number":170,"context_line":"        # get configmap_secret_paths"},{"line_number":171,"context_line":"        configmap_secret_paths \u003d self.req.get(\u0027metadata\u0027, {}).get("},{"line_number":172,"context_line":"            \u0027configmap_secret_paths\u0027, [])"},{"line_number":173,"context_line":"        # Get the path of the VNF Package according to vnf_instance.vnfd_id"},{"line_number":174,"context_line":"        new_vnf_package_path \u003d self.csar_dir"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        # Get instantiatedVnfInfo from vnf_instance"}],"source_content_type":"text/x-python","patch_set":10,"id":"b5ed0058_c04d5c49","line":173,"updated":"2023-09-07 08:13:51.000000000","message":"nit: vnfd_id -\u003e vnfdId","commit_id":"600aabe8341d972dc92a370c4a5e936774bcf629"},{"author":{"_account_id":31668},"change_message_id":"4b3a5ca684cc9decb7603cd5c1ff29b759e50b12","unresolved":false,"context_lines":[{"line_number":170,"context_line":"        # get configmap_secret_paths"},{"line_number":171,"context_line":"        configmap_secret_paths \u003d self.req.get(\u0027metadata\u0027, {}).get("},{"line_number":172,"context_line":"            \u0027configmap_secret_paths\u0027, [])"},{"line_number":173,"context_line":"        # Get the path of the VNF Package according to vnf_instance.vnfd_id"},{"line_number":174,"context_line":"        new_vnf_package_path \u003d self.csar_dir"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        # Get instantiatedVnfInfo from vnf_instance"}],"source_content_type":"text/x-python","patch_set":10,"id":"4a2870e3_fbdce2c9","line":173,"in_reply_to":"7f287cb3_5a938fbb","updated":"2023-09-11 01:18:10.000000000","message":"Done","commit_id":"600aabe8341d972dc92a370c4a5e936774bcf629"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"00162f7f86001154eca769756079cce077f73e5d","unresolved":true,"context_lines":[{"line_number":170,"context_line":"        # get configmap_secret_paths"},{"line_number":171,"context_line":"        configmap_secret_paths \u003d self.req.get(\u0027metadata\u0027, {}).get("},{"line_number":172,"context_line":"            \u0027configmap_secret_paths\u0027, [])"},{"line_number":173,"context_line":"        # Get the path of the VNF Package according to vnf_instance.vnfd_id"},{"line_number":174,"context_line":"        new_vnf_package_path \u003d self.csar_dir"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        # Get instantiatedVnfInfo from vnf_instance"}],"source_content_type":"text/x-python","patch_set":10,"id":"7f287cb3_5a938fbb","line":173,"in_reply_to":"b5ed0058_c04d5c49","updated":"2023-09-08 06:37:50.000000000","message":"I fixed it in patchset 11.","commit_id":"600aabe8341d972dc92a370c4a5e936774bcf629"},{"author":{"_account_id":31668},"change_message_id":"d1c59dbb36de30747474fd12672d5f3aec6e5327","unresolved":true,"context_lines":[{"line_number":203,"context_line":"                            \u0027lcm-kubernetes-def-files\u0027]["},{"line_number":204,"context_line":"                            index] \u003d configmap_secret_path"},{"line_number":205,"context_line":"                        for obj in resource:"},{"line_number":206,"context_line":"                            modify_config_names.add(obj[\u0027name\u0027])"},{"line_number":207,"context_line":"                        break"},{"line_number":208,"context_line":"                    raise exceptions.MgmtDriverOtherError("},{"line_number":209,"context_line":"                        error_message\u003d\u0027The number of resources in the \u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"aef72949_5e852b99","line":206,"updated":"2023-09-07 08:13:51.000000000","message":"Is there no problem if Secret and ConfigMap have the same name?\nIf there is only a change in the Secret, there is a concern that it will be judged that the ConfigMap with the same name has also changed.","commit_id":"600aabe8341d972dc92a370c4a5e936774bcf629"},{"author":{"_account_id":31668},"change_message_id":"17c0432e1d1330e5f4cef93e603376ad6672796c","unresolved":false,"context_lines":[{"line_number":203,"context_line":"                            \u0027lcm-kubernetes-def-files\u0027]["},{"line_number":204,"context_line":"                            index] \u003d configmap_secret_path"},{"line_number":205,"context_line":"                        for obj in resource:"},{"line_number":206,"context_line":"                            modify_config_names.add(obj[\u0027name\u0027])"},{"line_number":207,"context_line":"                        break"},{"line_number":208,"context_line":"                    raise exceptions.MgmtDriverOtherError("},{"line_number":209,"context_line":"                        error_message\u003d\u0027The number of resources in the \u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"c8024e0b_3fcc9913","line":206,"in_reply_to":"1a1812d9_7abc79c6","updated":"2023-09-12 04:51:55.000000000","message":"Done","commit_id":"600aabe8341d972dc92a370c4a5e936774bcf629"},{"author":{"_account_id":31668},"change_message_id":"4b3a5ca684cc9decb7603cd5c1ff29b759e50b12","unresolved":true,"context_lines":[{"line_number":203,"context_line":"                            \u0027lcm-kubernetes-def-files\u0027]["},{"line_number":204,"context_line":"                            index] \u003d configmap_secret_path"},{"line_number":205,"context_line":"                        for obj in resource:"},{"line_number":206,"context_line":"                            modify_config_names.add(obj[\u0027name\u0027])"},{"line_number":207,"context_line":"                        break"},{"line_number":208,"context_line":"                    raise exceptions.MgmtDriverOtherError("},{"line_number":209,"context_line":"                        error_message\u003d\u0027The number of resources in the \u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"fbce469d_5e01c7b7","line":206,"in_reply_to":"a299237a_8f86f31c","updated":"2023-09-11 01:18:10.000000000","message":"Thank you for the fix.\nHow about changing it as below to remove the conditional judgment?\n* L.187: modify_config_names \u003d {\"ConfigMap\": [], \"Secret\": []}\n* L.206: modify_config_names[obj[\"kind\"]].append(obj[\"name\"])","commit_id":"600aabe8341d972dc92a370c4a5e936774bcf629"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"00162f7f86001154eca769756079cce077f73e5d","unresolved":true,"context_lines":[{"line_number":203,"context_line":"                            \u0027lcm-kubernetes-def-files\u0027]["},{"line_number":204,"context_line":"                            index] \u003d configmap_secret_path"},{"line_number":205,"context_line":"                        for obj in resource:"},{"line_number":206,"context_line":"                            modify_config_names.add(obj[\u0027name\u0027])"},{"line_number":207,"context_line":"                        break"},{"line_number":208,"context_line":"                    raise exceptions.MgmtDriverOtherError("},{"line_number":209,"context_line":"                        error_message\u003d\u0027The number of resources in the \u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"a299237a_8f86f31c","line":206,"in_reply_to":"aef72949_5e852b99","updated":"2023-09-08 06:37:50.000000000","message":"I appended `kind` to differentiate.","commit_id":"600aabe8341d972dc92a370c4a5e936774bcf629"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"7b803d902b5e3913e977204314df05eb6788cb30","unresolved":true,"context_lines":[{"line_number":203,"context_line":"                            \u0027lcm-kubernetes-def-files\u0027]["},{"line_number":204,"context_line":"                            index] \u003d configmap_secret_path"},{"line_number":205,"context_line":"                        for obj in resource:"},{"line_number":206,"context_line":"                            modify_config_names.add(obj[\u0027name\u0027])"},{"line_number":207,"context_line":"                        break"},{"line_number":208,"context_line":"                    raise exceptions.MgmtDriverOtherError("},{"line_number":209,"context_line":"                        error_message\u003d\u0027The number of resources in the \u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a1812d9_7abc79c6","line":206,"in_reply_to":"fbce469d_5e01c7b7","updated":"2023-09-12 01:45:07.000000000","message":"I fixed it in patchset 12.","commit_id":"600aabe8341d972dc92a370c4a5e936774bcf629"},{"author":{"_account_id":31668},"change_message_id":"d1c59dbb36de30747474fd12672d5f3aec6e5327","unresolved":true,"context_lines":[{"line_number":290,"context_line":"                    if old_k8s_obj_kind \u003d\u003d new_k8s_obj_kind and ("},{"line_number":291,"context_line":"                            old_k8s_obj_name \u003d\u003d new_k8s_obj_name):"},{"line_number":292,"context_line":"                        # Append new_k8s_obj to k8s_config_objs"},{"line_number":293,"context_line":"                        k8s_config_objs.append(new_k8s_obj)"},{"line_number":294,"context_line":"                        break"},{"line_number":295,"context_line":"        for k8s_config_obj in k8s_config_objs:"},{"line_number":296,"context_line":"            # Call the replace API"}],"source_content_type":"text/x-python","patch_set":10,"id":"fed9b4a1_54b4211d","line":293,"updated":"2023-09-07 08:13:51.000000000","message":"For ConfigMap and Secret, is it intentional not to check for changes?","commit_id":"600aabe8341d972dc92a370c4a5e936774bcf629"},{"author":{"_account_id":31668},"change_message_id":"4b3a5ca684cc9decb7603cd5c1ff29b759e50b12","unresolved":false,"context_lines":[{"line_number":290,"context_line":"                    if old_k8s_obj_kind \u003d\u003d new_k8s_obj_kind and ("},{"line_number":291,"context_line":"                            old_k8s_obj_name \u003d\u003d new_k8s_obj_name):"},{"line_number":292,"context_line":"                        # Append new_k8s_obj to k8s_config_objs"},{"line_number":293,"context_line":"                        k8s_config_objs.append(new_k8s_obj)"},{"line_number":294,"context_line":"                        break"},{"line_number":295,"context_line":"        for k8s_config_obj in k8s_config_objs:"},{"line_number":296,"context_line":"            # Call the replace API"}],"source_content_type":"text/x-python","patch_set":10,"id":"f7e3329d_04599a59","line":293,"in_reply_to":"66a7f823_6fbedb6b","updated":"2023-09-11 01:18:10.000000000","message":"Ack","commit_id":"600aabe8341d972dc92a370c4a5e936774bcf629"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"00162f7f86001154eca769756079cce077f73e5d","unresolved":true,"context_lines":[{"line_number":290,"context_line":"                    if old_k8s_obj_kind \u003d\u003d new_k8s_obj_kind and ("},{"line_number":291,"context_line":"                            old_k8s_obj_name \u003d\u003d new_k8s_obj_name):"},{"line_number":292,"context_line":"                        # Append new_k8s_obj to k8s_config_objs"},{"line_number":293,"context_line":"                        k8s_config_objs.append(new_k8s_obj)"},{"line_number":294,"context_line":"                        break"},{"line_number":295,"context_line":"        for k8s_config_obj in k8s_config_objs:"},{"line_number":296,"context_line":"            # Call the replace API"}],"source_content_type":"text/x-python","patch_set":10,"id":"66a7f823_6fbedb6b","line":293,"in_reply_to":"fed9b4a1_54b4211d","updated":"2023-09-08 06:37:50.000000000","message":"Yes. In the input parameters, if their yaml is set, it is considered to need to be updated.","commit_id":"600aabe8341d972dc92a370c4a5e936774bcf629"},{"author":{"_account_id":31668},"change_message_id":"d1c59dbb36de30747474fd12672d5f3aec6e5327","unresolved":true,"context_lines":[{"line_number":316,"context_line":"                    # the pod to make the new configuration take effect."},{"line_number":317,"context_line":"                    if k8s_pod_obj.kind \u003d\u003d \u0027ReplicaSet\u0027:"},{"line_number":318,"context_line":"                        k8s_pod_obj.delete_pod(pod.metadata.name)"},{"line_number":319,"context_line":"                    old_pods_names.add(pod.metadata.name)"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"        # _replace_wait_k8s"},{"line_number":322,"context_line":"        self._wait_k8s_reses_updated("}],"source_content_type":"text/x-python","patch_set":10,"id":"b04b7ada_b237b52c","line":319,"updated":"2023-09-07 08:13:51.000000000","message":"I feel that deleting the matched \"pod\" from \"pods\" speeds up the process, what do you think?","commit_id":"600aabe8341d972dc92a370c4a5e936774bcf629"},{"author":{"_account_id":31668},"change_message_id":"4b3a5ca684cc9decb7603cd5c1ff29b759e50b12","unresolved":false,"context_lines":[{"line_number":316,"context_line":"                    # the pod to make the new configuration take effect."},{"line_number":317,"context_line":"                    if k8s_pod_obj.kind \u003d\u003d \u0027ReplicaSet\u0027:"},{"line_number":318,"context_line":"                        k8s_pod_obj.delete_pod(pod.metadata.name)"},{"line_number":319,"context_line":"                    old_pods_names.add(pod.metadata.name)"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"        # _replace_wait_k8s"},{"line_number":322,"context_line":"        self._wait_k8s_reses_updated("}],"source_content_type":"text/x-python","patch_set":10,"id":"e3f4f9f7_0f7d2866","line":319,"in_reply_to":"7839d51f_ef01952e","updated":"2023-09-11 01:18:10.000000000","message":"Done","commit_id":"600aabe8341d972dc92a370c4a5e936774bcf629"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"00162f7f86001154eca769756079cce077f73e5d","unresolved":true,"context_lines":[{"line_number":316,"context_line":"                    # the pod to make the new configuration take effect."},{"line_number":317,"context_line":"                    if k8s_pod_obj.kind \u003d\u003d \u0027ReplicaSet\u0027:"},{"line_number":318,"context_line":"                        k8s_pod_obj.delete_pod(pod.metadata.name)"},{"line_number":319,"context_line":"                    old_pods_names.add(pod.metadata.name)"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"        # _replace_wait_k8s"},{"line_number":322,"context_line":"        self._wait_k8s_reses_updated("}],"source_content_type":"text/x-python","patch_set":10,"id":"7839d51f_ef01952e","line":319,"in_reply_to":"b04b7ada_b237b52c","updated":"2023-09-08 06:37:50.000000000","message":"I added deletion processing.","commit_id":"600aabe8341d972dc92a370c4a5e936774bcf629"},{"author":{"_account_id":31668},"change_message_id":"4b3a5ca684cc9decb7603cd5c1ff29b759e50b12","unresolved":true,"context_lines":[{"line_number":303,"context_line":"            # Call the replace API"},{"line_number":304,"context_line":"            k8s_config_obj.replace()"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"        pods \u003d kubernetes_utils.list_namespaced_pods("},{"line_number":307,"context_line":"            k8s_api_client, namespace\u003dnamespace)"},{"line_number":308,"context_line":"        old_pods_names \u003d set()"},{"line_number":309,"context_line":"        for k8s_pod_obj in k8s_pod_objs:"}],"source_content_type":"text/x-python","patch_set":11,"id":"6ffc1287_e0fc62b4","line":306,"updated":"2023-09-11 01:18:10.000000000","message":"This process also retrieves pods from other VNF Instances that use the same namespace, so the amount of data retrieved may become enormous.\nIs it possible to reduce the amount of data acquired or reduce the data before starting the iterative process?\nFor example, for list_namespaced_pod, it is possible to reduce the retrieved data using field_selector and label_selector.\n* https://github.com/kubernetes-client/python/blob/v26.1.0/kubernetes/docs/CoreV1Api.md#list_namespaced_pod\n* https://opendev.org/openstack/tacker/src/branch/stable/2023.1/tacker/sol_refactored/infra_drivers/kubernetes/kubernetes_utils.py#L110\n\nI don\u0027t know if this is the best method, but I think it would be better to reconsider the process of obtaining the ReplicaSet\u0027s pod name.","commit_id":"7f7c04fcd3793a911bad4fb829911e86a4c54d2e"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"860bfc7a6067bcd213cd29ff418a9442445958f3","unresolved":true,"context_lines":[{"line_number":303,"context_line":"            # Call the replace API"},{"line_number":304,"context_line":"            k8s_config_obj.replace()"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"        pods \u003d kubernetes_utils.list_namespaced_pods("},{"line_number":307,"context_line":"            k8s_api_client, namespace\u003dnamespace)"},{"line_number":308,"context_line":"        old_pods_names \u003d set()"},{"line_number":309,"context_line":"        for k8s_pod_obj in k8s_pod_objs:"}],"source_content_type":"text/x-python","patch_set":11,"id":"d993bbd7_565a0fe3","line":306,"in_reply_to":"3e727860_c8d9a10a","updated":"2023-09-13 05:01:04.000000000","message":"It seems that it should not be possible to filter out some pods in advance. \nBecause the function of `is_match_pod_naming` is to filter the pods corresponding to CNF from kubernetes. If filtering can be done in advance, there is no need to execute `is_match_pod_naming`.\nIf we only want to filter the pods that obtain ReplicaSet, we can use `pod.metadata.owner_references[index].kind\u003d\u003d\u0027ReplicaSet\u0027`. However, in this branch, not only ReplicaSet is processed, but also Pod, Deployment, and DaemonSet are processed.\nDo you have any better way?","commit_id":"7f7c04fcd3793a911bad4fb829911e86a4c54d2e"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"7b803d902b5e3913e977204314df05eb6788cb30","unresolved":true,"context_lines":[{"line_number":303,"context_line":"            # Call the replace API"},{"line_number":304,"context_line":"            k8s_config_obj.replace()"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"        pods \u003d kubernetes_utils.list_namespaced_pods("},{"line_number":307,"context_line":"            k8s_api_client, namespace\u003dnamespace)"},{"line_number":308,"context_line":"        old_pods_names \u003d set()"},{"line_number":309,"context_line":"        for k8s_pod_obj in k8s_pod_objs:"}],"source_content_type":"text/x-python","patch_set":11,"id":"ee787001_1a5f63f9","line":306,"in_reply_to":"6ffc1287_e0fc62b4","updated":"2023-09-12 01:45:07.000000000","message":"There is currently no good filtering method.\nI investigated the use of `field_selector` and `label_selector`, but neither of them worked well.\n\n`field_selector`: only supports limited fields. \nhttps://kubernetes.io/docs/concepts/overview/working-with-objects/field-selectors/#supported-fields\nFor example, it can be effectively known that the pod belongs to the field `metadata.ownerReferences[0].kind` of ReplicaSet, but it does not support filtering. Change to `metadata.name`, but it does not support fuzzy matching.\n\n`label_selector`: supports filtering `metadata.labels`.\nhttps://kubernetes.io/docs/concepts/overview/working-with-objects/labels/\nFor example, if there are multiple ReplicaSets, they have labels of `app\u003da1` and `app\u003da2` respectively. When filtering, there can only be one set of conditions with `app` as the key-value pair, so it is impossible to filter the two ReplicaSets at the same time by using the `app` label.","commit_id":"7f7c04fcd3793a911bad4fb829911e86a4c54d2e"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"eec2ef2246667811180d4374068171943892ddcf","unresolved":true,"context_lines":[{"line_number":303,"context_line":"            # Call the replace API"},{"line_number":304,"context_line":"            k8s_config_obj.replace()"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"        pods \u003d kubernetes_utils.list_namespaced_pods("},{"line_number":307,"context_line":"            k8s_api_client, namespace\u003dnamespace)"},{"line_number":308,"context_line":"        old_pods_names \u003d set()"},{"line_number":309,"context_line":"        for k8s_pod_obj in k8s_pod_objs:"}],"source_content_type":"text/x-python","patch_set":11,"id":"ce7b0e3b_98a3730f","line":306,"in_reply_to":"9b2736de_78e7c171","updated":"2023-09-12 07:10:02.000000000","message":"In the example, `list_namespaced_pod` obtains all pods without any filtering. It is the `jq` command that filters the returned results.\nDo you mean that we want to filter the pods before performing the following processing,\n* https://review.opendev.org/c/openstack/tacker/+/888015/11..13/tacker/sol_refactored/mgmt_drivers/container_update_mgmt_v2.py#308\n\nrather than necessarily filtering in `list_namespaced_pod`?\nOr do you want to use the `jq` command through `subprocess.run`?","commit_id":"7f7c04fcd3793a911bad4fb829911e86a4c54d2e"},{"author":{"_account_id":31668},"change_message_id":"302808cb754cd9a0f323918a77281be0e987f25d","unresolved":true,"context_lines":[{"line_number":303,"context_line":"            # Call the replace API"},{"line_number":304,"context_line":"            k8s_config_obj.replace()"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"        pods \u003d kubernetes_utils.list_namespaced_pods("},{"line_number":307,"context_line":"            k8s_api_client, namespace\u003dnamespace)"},{"line_number":308,"context_line":"        old_pods_names \u003d set()"},{"line_number":309,"context_line":"        for k8s_pod_obj in k8s_pod_objs:"}],"source_content_type":"text/x-python","patch_set":11,"id":"3e727860_c8d9a10a","line":306,"in_reply_to":"ce7b0e3b_98a3730f","updated":"2023-09-12 07:46:46.000000000","message":"I think the problem is that is_match_pod_naming is executed an enormous number of times.\nThere are following methods to solve this problem.\n1. Reduce the number of pods to be acquired by filtering when acquiring from k8s\n2. Reduce the number of pods used for iteration by filtering all pods obtained from k8s\n\nRegarding 1, it is possible to use field_selector, but it is not suitable for this patch because regular expressions cannot be used.\nRegarding 2, it is possible to use `jq`, so I have commented on the idea of using it in this patch.\n\nI was thinking of using `jq` with `pyjq` as shown in the issue below, but it seems that this is also not suitable for this patch?\n* https://github.com/kubernetes-client/python/issues/1275","commit_id":"7f7c04fcd3793a911bad4fb829911e86a4c54d2e"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"ae9a963ad5f88ba80b9666fa35b9d204bb785125","unresolved":true,"context_lines":[{"line_number":303,"context_line":"            # Call the replace API"},{"line_number":304,"context_line":"            k8s_config_obj.replace()"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"        pods \u003d kubernetes_utils.list_namespaced_pods("},{"line_number":307,"context_line":"            k8s_api_client, namespace\u003dnamespace)"},{"line_number":308,"context_line":"        old_pods_names \u003d set()"},{"line_number":309,"context_line":"        for k8s_pod_obj in k8s_pod_objs:"}],"source_content_type":"text/x-python","patch_set":11,"id":"fc94f879_760307a0","line":306,"in_reply_to":"d498f892_aa53926a","updated":"2023-09-14 03:18:41.000000000","message":"\u003e Is it easy to set VNF Instance id in pod label?\n\u003e If it is possible to set an id in the label, it is possible to retrieve only the target pod using label_selector.\n\u003e If this is a complicated fix, we don\u0027t have enough time, so I think it would be better to refactor it in the future along with reviewing the logic.\n\nThis should be possible, but further investigation into the implications is needed. I\u0027m adding a `TODO` in patchset 14 and will refactor it in the future.","commit_id":"7f7c04fcd3793a911bad4fb829911e86a4c54d2e"},{"author":{"_account_id":31668},"change_message_id":"794004f4bfb773f918adc0d0441e8c7b5a6c9285","unresolved":true,"context_lines":[{"line_number":303,"context_line":"            # Call the replace API"},{"line_number":304,"context_line":"            k8s_config_obj.replace()"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"        pods \u003d kubernetes_utils.list_namespaced_pods("},{"line_number":307,"context_line":"            k8s_api_client, namespace\u003dnamespace)"},{"line_number":308,"context_line":"        old_pods_names \u003d set()"},{"line_number":309,"context_line":"        for k8s_pod_obj in k8s_pod_objs:"}],"source_content_type":"text/x-python","patch_set":11,"id":"d498f892_aa53926a","line":306,"in_reply_to":"d993bbd7_565a0fe3","updated":"2023-09-13 10:10:58.000000000","message":"Even when filtered by ReplicaSet, there is a possibility that pods of ReplicaSet belonging to other VNF Instances are included, so I think it is necessary to execute `is_match_pod_naming`.\nAnd I don\u0027t think it\u0027s a good idea to execute jq for each resource type...\n\nIs it easy to set VNF Instance id in pod label?\nIf it is possible to set an id in the label, it is possible to retrieve only the target pod using label_selector.\nIf this is a complicated fix, we don\u0027t have enough time, so I think it would be better to refactor it in the future along with reviewing the logic.","commit_id":"7f7c04fcd3793a911bad4fb829911e86a4c54d2e"},{"author":{"_account_id":31668},"change_message_id":"17c0432e1d1330e5f4cef93e603376ad6672796c","unresolved":true,"context_lines":[{"line_number":303,"context_line":"            # Call the replace API"},{"line_number":304,"context_line":"            k8s_config_obj.replace()"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"        pods \u003d kubernetes_utils.list_namespaced_pods("},{"line_number":307,"context_line":"            k8s_api_client, namespace\u003dnamespace)"},{"line_number":308,"context_line":"        old_pods_names \u003d set()"},{"line_number":309,"context_line":"        for k8s_pod_obj in k8s_pod_objs:"}],"source_content_type":"text/x-python","patch_set":11,"id":"9b2736de_78e7c171","line":306,"in_reply_to":"ee787001_1a5f63f9","updated":"2023-09-12 04:51:55.000000000","message":"Thank you for confirmation.\nIt seems that regular expression support for field_selector has been decided not to be implemented on the server side due to resource costs...\n* https://github.com/kubernetes/kubernetes/issues/72196\n\nIn the above issue, `jq` is mentioned as one of the filtering methods on the client side.\nIs it possible to reduce the cost of iterative processing by applying a filter using `jq` after acquiring pods with this patch?\nThe following issue may be helpful.\n* https://github.com/kubernetes-client/python/issues/1275","commit_id":"7f7c04fcd3793a911bad4fb829911e86a4c54d2e"},{"author":{"_account_id":31668},"change_message_id":"9df5ade2da2dfcaf83267674f1995f789776fece","unresolved":false,"context_lines":[{"line_number":303,"context_line":"            # Call the replace API"},{"line_number":304,"context_line":"            k8s_config_obj.replace()"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"        pods \u003d kubernetes_utils.list_namespaced_pods("},{"line_number":307,"context_line":"            k8s_api_client, namespace\u003dnamespace)"},{"line_number":308,"context_line":"        old_pods_names \u003d set()"},{"line_number":309,"context_line":"        for k8s_pod_obj in k8s_pod_objs:"}],"source_content_type":"text/x-python","patch_set":11,"id":"71544612_01d0aa28","line":306,"in_reply_to":"fc94f879_760307a0","updated":"2023-09-14 04:44:26.000000000","message":"Ack","commit_id":"7f7c04fcd3793a911bad4fb829911e86a4c54d2e"}],"tacker/tests/functional/sol_kubernetes_v2/samples/test_cnf_container_update_after/contents/TOSCA-Metadata/TOSCA.meta":[{"author":{"_account_id":31668},"change_message_id":"6123f0b6cd0f881c1863ba08e659c92beef9fa9c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":9,"id":"946e78ee_7d22425c","line":66,"updated":"2023-09-06 08:07:35.000000000","message":"This is an unnecessary line.","commit_id":"e6f7649f78b3fad11879c017825f3d2beb7ac1fa"},{"author":{"_account_id":31668},"change_message_id":"d1c59dbb36de30747474fd12672d5f3aec6e5327","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"a2f30942_b641b250","line":66,"in_reply_to":"50841d41_a0508047","updated":"2023-09-07 08:13:51.000000000","message":"Done","commit_id":"e6f7649f78b3fad11879c017825f3d2beb7ac1fa"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"ce8ce8d07e0ce5013f5492c1c1461006ed86c69a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":9,"id":"50841d41_a0508047","line":66,"in_reply_to":"946e78ee_7d22425c","updated":"2023-09-07 01:50:06.000000000","message":"I removed this line.","commit_id":"e6f7649f78b3fad11879c017825f3d2beb7ac1fa"}],"tacker/tests/functional/sol_kubernetes_v2/test_kubernetes_container_update.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"a892339b44c233f62cec483147ff6bcee428df04","unresolved":true,"context_lines":[{"line_number":116,"context_line":"        lcmocc_id \u003d os.path.basename(resp.headers[\u0027Location\u0027])"},{"line_number":117,"context_line":"        self.wait_lcmocc_complete(lcmocc_id)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        # wait a bit because there is a bit time lag between lcmocc DB"},{"line_number":120,"context_line":"        # update and terminate completion."},{"line_number":121,"context_line":"        time.sleep(3)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        # delete"},{"line_number":124,"context_line":"        resp, body \u003d self.delete_vnf_instance(inst_id)"},{"line_number":125,"context_line":"        self.assertEqual(204, resp.status_code)"}],"source_content_type":"text/x-python","patch_set":4,"id":"a353697c_c349861a","line":124,"range":{"start_line":119,"start_character":0,"end_line":124,"end_character":54},"updated":"2023-08-04 13:32:27.000000000","message":"Could you delete `time.sleep` after terminate, and use `exec_lcm_operation()` instead of `delete_vnf_instance()`?\n\nrefer: https://review.opendev.org/c/openstack/tacker/+/881181","commit_id":"7f27176080b09e312dea1744db832746c3f96fcd"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"4f84a9aa799d202bad0e28da834537c92ace3a0d","unresolved":true,"context_lines":[{"line_number":116,"context_line":"        lcmocc_id \u003d os.path.basename(resp.headers[\u0027Location\u0027])"},{"line_number":117,"context_line":"        self.wait_lcmocc_complete(lcmocc_id)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        # wait a bit because there is a bit time lag between lcmocc DB"},{"line_number":120,"context_line":"        # update and terminate completion."},{"line_number":121,"context_line":"        time.sleep(3)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        # delete"},{"line_number":124,"context_line":"        resp, body \u003d self.delete_vnf_instance(inst_id)"},{"line_number":125,"context_line":"        self.assertEqual(204, resp.status_code)"}],"source_content_type":"text/x-python","patch_set":4,"id":"aca59104_0db728e1","line":124,"range":{"start_line":119,"start_character":0,"end_line":124,"end_character":54},"in_reply_to":"a353697c_c349861a","updated":"2023-08-15 02:08:07.000000000","message":"I fixed it in patchset 5.","commit_id":"7f27176080b09e312dea1744db832746c3f96fcd"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"88d520e8b293835e8a6fe29b8a8f81fad64e3570","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        lcmocc_id \u003d os.path.basename(resp.headers[\u0027Location\u0027])"},{"line_number":117,"context_line":"        self.wait_lcmocc_complete(lcmocc_id)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        # wait a bit because there is a bit time lag between lcmocc DB"},{"line_number":120,"context_line":"        # update and terminate completion."},{"line_number":121,"context_line":"        time.sleep(3)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        # delete"},{"line_number":124,"context_line":"        resp, body \u003d self.delete_vnf_instance(inst_id)"},{"line_number":125,"context_line":"        self.assertEqual(204, resp.status_code)"}],"source_content_type":"text/x-python","patch_set":4,"id":"f897f02d_a27c2f3f","line":124,"range":{"start_line":119,"start_character":0,"end_line":124,"end_character":54},"in_reply_to":"aca59104_0db728e1","updated":"2023-08-30 14:58:59.000000000","message":"Ack","commit_id":"7f27176080b09e312dea1744db832746c3f96fcd"},{"author":{"_account_id":31668},"change_message_id":"6123f0b6cd0f881c1863ba08e659c92beef9fa9c","unresolved":true,"context_lines":[{"line_number":47,"context_line":"        cls.delete_vnf_package(cls.vnf_package_id_before)"},{"line_number":48,"context_line":"        cls.delete_vnf_package(cls.vnf_package_id_after)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def test_container_update_multi_kinds(self):"},{"line_number":51,"context_line":"        # create"},{"line_number":52,"context_line":"        create_req \u003d paramgen.test_cnf_update_create(self.vnfd_id_before)"},{"line_number":53,"context_line":"        resp, body \u003d self.create_vnf_instance(create_req)"}],"source_content_type":"text/x-python","patch_set":9,"id":"cbb2acc6_49c63cc3","line":50,"updated":"2023-09-06 08:07:35.000000000","message":"Please describe the details in the same way as other tests.\nhttps://opendev.org/openstack/tacker/src/branch/stable/2023.1/tacker/tests/functional/sol_kubernetes_v2/test_vnflcm_basic.py#L48-L71","commit_id":"e6f7649f78b3fad11879c017825f3d2beb7ac1fa"},{"author":{"_account_id":31668},"change_message_id":"d1c59dbb36de30747474fd12672d5f3aec6e5327","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        cls.delete_vnf_package(cls.vnf_package_id_before)"},{"line_number":48,"context_line":"        cls.delete_vnf_package(cls.vnf_package_id_after)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def test_container_update_multi_kinds(self):"},{"line_number":51,"context_line":"        # create"},{"line_number":52,"context_line":"        create_req \u003d paramgen.test_cnf_update_create(self.vnfd_id_before)"},{"line_number":53,"context_line":"        resp, body \u003d self.create_vnf_instance(create_req)"}],"source_content_type":"text/x-python","patch_set":9,"id":"674e533e_a0be7ba9","line":50,"in_reply_to":"1dc01b2f_506bfeef","updated":"2023-09-07 08:13:51.000000000","message":"Done","commit_id":"e6f7649f78b3fad11879c017825f3d2beb7ac1fa"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"ce8ce8d07e0ce5013f5492c1c1461006ed86c69a","unresolved":true,"context_lines":[{"line_number":47,"context_line":"        cls.delete_vnf_package(cls.vnf_package_id_before)"},{"line_number":48,"context_line":"        cls.delete_vnf_package(cls.vnf_package_id_after)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def test_container_update_multi_kinds(self):"},{"line_number":51,"context_line":"        # create"},{"line_number":52,"context_line":"        create_req \u003d paramgen.test_cnf_update_create(self.vnfd_id_before)"},{"line_number":53,"context_line":"        resp, body \u003d self.create_vnf_instance(create_req)"}],"source_content_type":"text/x-python","patch_set":9,"id":"1dc01b2f_506bfeef","line":50,"in_reply_to":"cbb2acc6_49c63cc3","updated":"2023-09-07 01:50:06.000000000","message":"I\u0027ve added a comment here.","commit_id":"e6f7649f78b3fad11879c017825f3d2beb7ac1fa"},{"author":{"_account_id":31668},"change_message_id":"d1c59dbb36de30747474fd12672d5f3aec6e5327","unresolved":true,"context_lines":[{"line_number":61,"context_line":"          - 7. Delete a VNF instance"},{"line_number":62,"context_line":"        \"\"\""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        # create"},{"line_number":65,"context_line":"        create_req \u003d paramgen.test_cnf_update_create(self.vnfd_id_before)"},{"line_number":66,"context_line":"        resp, body \u003d self.create_vnf_instance(create_req)"},{"line_number":67,"context_line":"        self.assertEqual(201, resp.status_code)"}],"source_content_type":"text/x-python","patch_set":10,"id":"96b98497_6c074a32","line":64,"updated":"2023-09-07 08:13:51.000000000","message":"nit: create -\u003e 1. Create a new VNF instance resource","commit_id":"600aabe8341d972dc92a370c4a5e936774bcf629"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"00162f7f86001154eca769756079cce077f73e5d","unresolved":true,"context_lines":[{"line_number":61,"context_line":"          - 7. Delete a VNF instance"},{"line_number":62,"context_line":"        \"\"\""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        # create"},{"line_number":65,"context_line":"        create_req \u003d paramgen.test_cnf_update_create(self.vnfd_id_before)"},{"line_number":66,"context_line":"        resp, body \u003d self.create_vnf_instance(create_req)"},{"line_number":67,"context_line":"        self.assertEqual(201, resp.status_code)"}],"source_content_type":"text/x-python","patch_set":10,"id":"dbf04f68_90c62fbb","line":64,"in_reply_to":"96b98497_6c074a32","updated":"2023-09-08 06:37:50.000000000","message":"I fixed it in patchset 11.","commit_id":"600aabe8341d972dc92a370c4a5e936774bcf629"},{"author":{"_account_id":31668},"change_message_id":"4b3a5ca684cc9decb7603cd5c1ff29b759e50b12","unresolved":false,"context_lines":[{"line_number":61,"context_line":"          - 7. Delete a VNF instance"},{"line_number":62,"context_line":"        \"\"\""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        # create"},{"line_number":65,"context_line":"        create_req \u003d paramgen.test_cnf_update_create(self.vnfd_id_before)"},{"line_number":66,"context_line":"        resp, body \u003d self.create_vnf_instance(create_req)"},{"line_number":67,"context_line":"        self.assertEqual(201, resp.status_code)"}],"source_content_type":"text/x-python","patch_set":10,"id":"b02c5848_00e6b423","line":64,"in_reply_to":"dbf04f68_90c62fbb","updated":"2023-09-11 01:18:10.000000000","message":"Done","commit_id":"600aabe8341d972dc92a370c4a5e936774bcf629"},{"author":{"_account_id":31668},"change_message_id":"d1c59dbb36de30747474fd12672d5f3aec6e5327","unresolved":true,"context_lines":[{"line_number":67,"context_line":"        self.assertEqual(201, resp.status_code)"},{"line_number":68,"context_line":"        inst_id \u003d body[\u0027id\u0027]"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        # instantiate"},{"line_number":71,"context_line":"        vim_id \u003d self.get_k8s_vim_id()"},{"line_number":72,"context_line":"        instantiate_req \u003d paramgen.test_cnf_update_instantiate(vim_id)"},{"line_number":73,"context_line":"        resp, body \u003d self.instantiate_vnf_instance(inst_id, instantiate_req)"}],"source_content_type":"text/x-python","patch_set":10,"id":"4f148166_bca3111c","line":70,"updated":"2023-09-07 08:13:51.000000000","message":"nit: instantiate -\u003e 2. Instantiate a VNF instance","commit_id":"600aabe8341d972dc92a370c4a5e936774bcf629"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"00162f7f86001154eca769756079cce077f73e5d","unresolved":true,"context_lines":[{"line_number":67,"context_line":"        self.assertEqual(201, resp.status_code)"},{"line_number":68,"context_line":"        inst_id \u003d body[\u0027id\u0027]"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        # instantiate"},{"line_number":71,"context_line":"        vim_id \u003d self.get_k8s_vim_id()"},{"line_number":72,"context_line":"        instantiate_req \u003d paramgen.test_cnf_update_instantiate(vim_id)"},{"line_number":73,"context_line":"        resp, body \u003d self.instantiate_vnf_instance(inst_id, instantiate_req)"}],"source_content_type":"text/x-python","patch_set":10,"id":"8ef14731_ee7719b2","line":70,"in_reply_to":"4f148166_bca3111c","updated":"2023-09-08 06:37:50.000000000","message":"I fixed it in patchset 11.","commit_id":"600aabe8341d972dc92a370c4a5e936774bcf629"},{"author":{"_account_id":31668},"change_message_id":"4b3a5ca684cc9decb7603cd5c1ff29b759e50b12","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        self.assertEqual(201, resp.status_code)"},{"line_number":68,"context_line":"        inst_id \u003d body[\u0027id\u0027]"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        # instantiate"},{"line_number":71,"context_line":"        vim_id \u003d self.get_k8s_vim_id()"},{"line_number":72,"context_line":"        instantiate_req \u003d paramgen.test_cnf_update_instantiate(vim_id)"},{"line_number":73,"context_line":"        resp, body \u003d self.instantiate_vnf_instance(inst_id, instantiate_req)"}],"source_content_type":"text/x-python","patch_set":10,"id":"4c3a127e_97708229","line":70,"in_reply_to":"8ef14731_ee7719b2","updated":"2023-09-11 01:18:10.000000000","message":"Done","commit_id":"600aabe8341d972dc92a370c4a5e936774bcf629"},{"author":{"_account_id":31668},"change_message_id":"d1c59dbb36de30747474fd12672d5f3aec6e5327","unresolved":true,"context_lines":[{"line_number":77,"context_line":"        lcmocc_id \u003d os.path.basename(resp.headers[\u0027Location\u0027])"},{"line_number":78,"context_line":"        self.wait_lcmocc_complete(lcmocc_id)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        # show VNF"},{"line_number":81,"context_line":"        _, vnf_instance_before \u003d self.show_vnf_instance(inst_id)"},{"line_number":82,"context_line":"        before_vnfc_rscs \u003d vnf_instance_before[\u0027instantiatedVnfInfo\u0027]["},{"line_number":83,"context_line":"            \u0027vnfcResourceInfo\u0027]"}],"source_content_type":"text/x-python","patch_set":10,"id":"a57b58e6_445e0c82","line":80,"updated":"2023-09-07 08:13:51.000000000","message":"nit: show VNF -\u003e 3. Show VNF instance","commit_id":"600aabe8341d972dc92a370c4a5e936774bcf629"},{"author":{"_account_id":31668},"change_message_id":"4b3a5ca684cc9decb7603cd5c1ff29b759e50b12","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        lcmocc_id \u003d os.path.basename(resp.headers[\u0027Location\u0027])"},{"line_number":78,"context_line":"        self.wait_lcmocc_complete(lcmocc_id)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        # show VNF"},{"line_number":81,"context_line":"        _, vnf_instance_before \u003d self.show_vnf_instance(inst_id)"},{"line_number":82,"context_line":"        before_vnfc_rscs \u003d vnf_instance_before[\u0027instantiatedVnfInfo\u0027]["},{"line_number":83,"context_line":"            \u0027vnfcResourceInfo\u0027]"}],"source_content_type":"text/x-python","patch_set":10,"id":"d4ca70bb_dc0fb1cd","line":80,"in_reply_to":"1efc3a14_833e79c0","updated":"2023-09-11 01:18:10.000000000","message":"Done","commit_id":"600aabe8341d972dc92a370c4a5e936774bcf629"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"00162f7f86001154eca769756079cce077f73e5d","unresolved":true,"context_lines":[{"line_number":77,"context_line":"        lcmocc_id \u003d os.path.basename(resp.headers[\u0027Location\u0027])"},{"line_number":78,"context_line":"        self.wait_lcmocc_complete(lcmocc_id)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        # show VNF"},{"line_number":81,"context_line":"        _, vnf_instance_before \u003d self.show_vnf_instance(inst_id)"},{"line_number":82,"context_line":"        before_vnfc_rscs \u003d vnf_instance_before[\u0027instantiatedVnfInfo\u0027]["},{"line_number":83,"context_line":"            \u0027vnfcResourceInfo\u0027]"}],"source_content_type":"text/x-python","patch_set":10,"id":"1efc3a14_833e79c0","line":80,"in_reply_to":"a57b58e6_445e0c82","updated":"2023-09-08 06:37:50.000000000","message":"I fixed it in patchset 11.","commit_id":"600aabe8341d972dc92a370c4a5e936774bcf629"},{"author":{"_account_id":31668},"change_message_id":"d1c59dbb36de30747474fd12672d5f3aec6e5327","unresolved":true,"context_lines":[{"line_number":83,"context_line":"            \u0027vnfcResourceInfo\u0027]"},{"line_number":84,"context_line":"        self.assertEqual(8, len(before_vnfc_rscs))"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        # modify"},{"line_number":87,"context_line":"        update_req \u003d paramgen.test_cnf_update_modify(self.vnfd_id_after)"},{"line_number":88,"context_line":"        resp, body \u003d self.update_vnf_instance(inst_id, update_req)"},{"line_number":89,"context_line":"        self.assertEqual(202, resp.status_code)"}],"source_content_type":"text/x-python","patch_set":10,"id":"12ad8ddd_81a3ae7f","line":86,"updated":"2023-09-07 08:13:51.000000000","message":"nit: modify -\u003e 4. Update a VNF instance","commit_id":"600aabe8341d972dc92a370c4a5e936774bcf629"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"00162f7f86001154eca769756079cce077f73e5d","unresolved":true,"context_lines":[{"line_number":83,"context_line":"            \u0027vnfcResourceInfo\u0027]"},{"line_number":84,"context_line":"        self.assertEqual(8, len(before_vnfc_rscs))"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        # modify"},{"line_number":87,"context_line":"        update_req \u003d paramgen.test_cnf_update_modify(self.vnfd_id_after)"},{"line_number":88,"context_line":"        resp, body \u003d self.update_vnf_instance(inst_id, update_req)"},{"line_number":89,"context_line":"        self.assertEqual(202, resp.status_code)"}],"source_content_type":"text/x-python","patch_set":10,"id":"d7009b8d_bdd1cb67","line":86,"in_reply_to":"12ad8ddd_81a3ae7f","updated":"2023-09-08 06:37:50.000000000","message":"I fixed it in patchset 11.","commit_id":"600aabe8341d972dc92a370c4a5e936774bcf629"},{"author":{"_account_id":31668},"change_message_id":"4b3a5ca684cc9decb7603cd5c1ff29b759e50b12","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            \u0027vnfcResourceInfo\u0027]"},{"line_number":84,"context_line":"        self.assertEqual(8, len(before_vnfc_rscs))"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        # modify"},{"line_number":87,"context_line":"        update_req \u003d paramgen.test_cnf_update_modify(self.vnfd_id_after)"},{"line_number":88,"context_line":"        resp, body \u003d self.update_vnf_instance(inst_id, update_req)"},{"line_number":89,"context_line":"        self.assertEqual(202, resp.status_code)"}],"source_content_type":"text/x-python","patch_set":10,"id":"ddf40ed9_0896c35f","line":86,"in_reply_to":"d7009b8d_bdd1cb67","updated":"2023-09-11 01:18:10.000000000","message":"Done","commit_id":"600aabe8341d972dc92a370c4a5e936774bcf629"},{"author":{"_account_id":31668},"change_message_id":"d1c59dbb36de30747474fd12672d5f3aec6e5327","unresolved":true,"context_lines":[{"line_number":92,"context_line":"        lcmocc_id \u003d os.path.basename(resp.headers[\u0027Location\u0027])"},{"line_number":93,"context_line":"        self.wait_lcmocc_complete(lcmocc_id)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        # check"},{"line_number":96,"context_line":"        _, vnf_instance_after \u003d self.show_vnf_instance(inst_id)"},{"line_number":97,"context_line":"        after_vnfc_rscs \u003d vnf_instance_after[\u0027instantiatedVnfInfo\u0027]["},{"line_number":98,"context_line":"            \u0027vnfcResourceInfo\u0027]"}],"source_content_type":"text/x-python","patch_set":10,"id":"a363e766_2ab77948","line":95,"updated":"2023-09-07 08:13:51.000000000","message":"nit: check -\u003e 5. Show VNF instance","commit_id":"600aabe8341d972dc92a370c4a5e936774bcf629"},{"author":{"_account_id":31668},"change_message_id":"4b3a5ca684cc9decb7603cd5c1ff29b759e50b12","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        lcmocc_id \u003d os.path.basename(resp.headers[\u0027Location\u0027])"},{"line_number":93,"context_line":"        self.wait_lcmocc_complete(lcmocc_id)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        # check"},{"line_number":96,"context_line":"        _, vnf_instance_after \u003d self.show_vnf_instance(inst_id)"},{"line_number":97,"context_line":"        after_vnfc_rscs \u003d vnf_instance_after[\u0027instantiatedVnfInfo\u0027]["},{"line_number":98,"context_line":"            \u0027vnfcResourceInfo\u0027]"}],"source_content_type":"text/x-python","patch_set":10,"id":"7d1cea88_46f26dfa","line":95,"in_reply_to":"33d71ebd_2c0eb1e7","updated":"2023-09-11 01:18:10.000000000","message":"Done","commit_id":"600aabe8341d972dc92a370c4a5e936774bcf629"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"00162f7f86001154eca769756079cce077f73e5d","unresolved":true,"context_lines":[{"line_number":92,"context_line":"        lcmocc_id \u003d os.path.basename(resp.headers[\u0027Location\u0027])"},{"line_number":93,"context_line":"        self.wait_lcmocc_complete(lcmocc_id)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        # check"},{"line_number":96,"context_line":"        _, vnf_instance_after \u003d self.show_vnf_instance(inst_id)"},{"line_number":97,"context_line":"        after_vnfc_rscs \u003d vnf_instance_after[\u0027instantiatedVnfInfo\u0027]["},{"line_number":98,"context_line":"            \u0027vnfcResourceInfo\u0027]"}],"source_content_type":"text/x-python","patch_set":10,"id":"33d71ebd_2c0eb1e7","line":95,"in_reply_to":"a363e766_2ab77948","updated":"2023-09-08 06:37:50.000000000","message":"I fixed it in patchset 11.","commit_id":"600aabe8341d972dc92a370c4a5e936774bcf629"},{"author":{"_account_id":31668},"change_message_id":"d1c59dbb36de30747474fd12672d5f3aec6e5327","unresolved":true,"context_lines":[{"line_number":121,"context_line":"        self.assertEqual("},{"line_number":122,"context_line":"            \u0027modify_vnf_after\u0027, vnf_instance_after[\u0027vnfInstanceName\u0027])"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        # terminate"},{"line_number":125,"context_line":"        terminate_req \u003d paramgen.terminate_vnf_min()"},{"line_number":126,"context_line":"        resp, body \u003d self.terminate_vnf_instance(inst_id, terminate_req)"},{"line_number":127,"context_line":"        self.assertEqual(202, resp.status_code)"}],"source_content_type":"text/x-python","patch_set":10,"id":"6a67661d_5976f406","line":124,"updated":"2023-09-07 08:13:51.000000000","message":"nit: terminate -\u003e 6. Terminate a VNF instance","commit_id":"600aabe8341d972dc92a370c4a5e936774bcf629"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"00162f7f86001154eca769756079cce077f73e5d","unresolved":true,"context_lines":[{"line_number":121,"context_line":"        self.assertEqual("},{"line_number":122,"context_line":"            \u0027modify_vnf_after\u0027, vnf_instance_after[\u0027vnfInstanceName\u0027])"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        # terminate"},{"line_number":125,"context_line":"        terminate_req \u003d paramgen.terminate_vnf_min()"},{"line_number":126,"context_line":"        resp, body \u003d self.terminate_vnf_instance(inst_id, terminate_req)"},{"line_number":127,"context_line":"        self.assertEqual(202, resp.status_code)"}],"source_content_type":"text/x-python","patch_set":10,"id":"90e2c307_c4a4813e","line":124,"in_reply_to":"6a67661d_5976f406","updated":"2023-09-08 06:37:50.000000000","message":"I fixed it in patchset 11.","commit_id":"600aabe8341d972dc92a370c4a5e936774bcf629"},{"author":{"_account_id":31668},"change_message_id":"4b3a5ca684cc9decb7603cd5c1ff29b759e50b12","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        self.assertEqual("},{"line_number":122,"context_line":"            \u0027modify_vnf_after\u0027, vnf_instance_after[\u0027vnfInstanceName\u0027])"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        # terminate"},{"line_number":125,"context_line":"        terminate_req \u003d paramgen.terminate_vnf_min()"},{"line_number":126,"context_line":"        resp, body \u003d self.terminate_vnf_instance(inst_id, terminate_req)"},{"line_number":127,"context_line":"        self.assertEqual(202, resp.status_code)"}],"source_content_type":"text/x-python","patch_set":10,"id":"ad180a7e_c96b1621","line":124,"in_reply_to":"90e2c307_c4a4813e","updated":"2023-09-11 01:18:10.000000000","message":"Done","commit_id":"600aabe8341d972dc92a370c4a5e936774bcf629"},{"author":{"_account_id":31668},"change_message_id":"d1c59dbb36de30747474fd12672d5f3aec6e5327","unresolved":true,"context_lines":[{"line_number":129,"context_line":"        lcmocc_id \u003d os.path.basename(resp.headers[\u0027Location\u0027])"},{"line_number":130,"context_line":"        self.wait_lcmocc_complete(lcmocc_id)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        # delete"},{"line_number":133,"context_line":"        resp, body \u003d self.exec_lcm_operation(self.delete_vnf_instance, inst_id)"},{"line_number":134,"context_line":"        self.assertEqual(204, resp.status_code)"}],"source_content_type":"text/x-python","patch_set":10,"id":"60fd2c53_bd7a4bd1","line":132,"updated":"2023-09-07 08:13:51.000000000","message":"nit: delete -\u003e 7. Delete a VNF instance","commit_id":"600aabe8341d972dc92a370c4a5e936774bcf629"},{"author":{"_account_id":31668},"change_message_id":"4b3a5ca684cc9decb7603cd5c1ff29b759e50b12","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        lcmocc_id \u003d os.path.basename(resp.headers[\u0027Location\u0027])"},{"line_number":130,"context_line":"        self.wait_lcmocc_complete(lcmocc_id)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        # delete"},{"line_number":133,"context_line":"        resp, body \u003d self.exec_lcm_operation(self.delete_vnf_instance, inst_id)"},{"line_number":134,"context_line":"        self.assertEqual(204, resp.status_code)"}],"source_content_type":"text/x-python","patch_set":10,"id":"6c5eb0cb_5c49172f","line":132,"in_reply_to":"5584a6ac_56442f01","updated":"2023-09-11 01:18:10.000000000","message":"Done","commit_id":"600aabe8341d972dc92a370c4a5e936774bcf629"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"00162f7f86001154eca769756079cce077f73e5d","unresolved":true,"context_lines":[{"line_number":129,"context_line":"        lcmocc_id \u003d os.path.basename(resp.headers[\u0027Location\u0027])"},{"line_number":130,"context_line":"        self.wait_lcmocc_complete(lcmocc_id)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        # delete"},{"line_number":133,"context_line":"        resp, body \u003d self.exec_lcm_operation(self.delete_vnf_instance, inst_id)"},{"line_number":134,"context_line":"        self.assertEqual(204, resp.status_code)"}],"source_content_type":"text/x-python","patch_set":10,"id":"5584a6ac_56442f01","line":132,"in_reply_to":"60fd2c53_bd7a4bd1","updated":"2023-09-08 06:37:50.000000000","message":"I fixed it in patchset 11.","commit_id":"600aabe8341d972dc92a370c4a5e936774bcf629"}],"tacker/tests/unit/sol_refactored/mgmt_drivers/fakes.py":[{"author":{"_account_id":31668},"change_message_id":"d1c59dbb36de30747474fd12672d5f3aec6e5327","unresolved":true,"context_lines":[{"line_number":17,"context_line":"from kubernetes import client"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"_inst_info_example_before \u003d {"},{"line_number":21,"context_line":"    \"id\": \"c80f7afa-65f3-4be6-94ae-fdf438ac2d61\","},{"line_number":22,"context_line":"    \"vnfInstanceName\": \"modify_vnf_before\","},{"line_number":23,"context_line":"    \"vnfdId\": \"16ca1a07-2453-47f1-9f00-7ca2dce0a5ea\","}],"source_content_type":"text/x-python","patch_set":10,"id":"7c3f5293_ef468a85","line":20,"updated":"2023-09-07 08:13:51.000000000","message":"This seems to be used only in TestContainerUpdate, so I think it\u0027s better to move it to test_container_update_mgmt.py.\nWhat do you think?","commit_id":"600aabe8341d972dc92a370c4a5e936774bcf629"},{"author":{"_account_id":31668},"change_message_id":"4b3a5ca684cc9decb7603cd5c1ff29b759e50b12","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from kubernetes import client"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"_inst_info_example_before \u003d {"},{"line_number":21,"context_line":"    \"id\": \"c80f7afa-65f3-4be6-94ae-fdf438ac2d61\","},{"line_number":22,"context_line":"    \"vnfInstanceName\": \"modify_vnf_before\","},{"line_number":23,"context_line":"    \"vnfdId\": \"16ca1a07-2453-47f1-9f00-7ca2dce0a5ea\","}],"source_content_type":"text/x-python","patch_set":10,"id":"c62834e9_fb9db0ed","line":20,"in_reply_to":"3ba292e8_100d5be5","updated":"2023-09-11 01:18:10.000000000","message":"Done","commit_id":"600aabe8341d972dc92a370c4a5e936774bcf629"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"00162f7f86001154eca769756079cce077f73e5d","unresolved":true,"context_lines":[{"line_number":17,"context_line":"from kubernetes import client"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"_inst_info_example_before \u003d {"},{"line_number":21,"context_line":"    \"id\": \"c80f7afa-65f3-4be6-94ae-fdf438ac2d61\","},{"line_number":22,"context_line":"    \"vnfInstanceName\": \"modify_vnf_before\","},{"line_number":23,"context_line":"    \"vnfdId\": \"16ca1a07-2453-47f1-9f00-7ca2dce0a5ea\","}],"source_content_type":"text/x-python","patch_set":10,"id":"3ba292e8_100d5be5","line":20,"in_reply_to":"7c3f5293_ef468a85","updated":"2023-09-08 06:37:50.000000000","message":"I moved it to `test_container_update_mgmt.py`.","commit_id":"600aabe8341d972dc92a370c4a5e936774bcf629"}],"tacker/tests/unit/sol_refactored/mgmt_drivers/test_container_update_mgmt.py":[{"author":{"_account_id":31668},"change_message_id":"d1c59dbb36de30747474fd12672d5f3aec6e5327","unresolved":true,"context_lines":[{"line_number":29,"context_line":"from tacker.tests.unit.sol_refactored.mgmt_drivers import fakes"},{"line_number":30,"context_line":"from unittest import mock"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"SAMPLE_VNFD_ID \u003d \"16ca1a07-2453-47f1-9f00-7ca2dce0a5ea\""},{"line_number":33,"context_line":"SAMPLE_NEW_VNFD_ID \u003d \"5484de3b-ff51-4c1a-b54c-4215a8130078\""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"0e250d82_e001c482","line":32,"updated":"2023-09-07 08:13:51.000000000","message":"Currently, SAMPLE_VNFD_ID is used to set the default value of VNFD ID (b1bb0ce7-ebca-4fa7-95ed-4840d7000000).\nIt doesn\u0027t affect this test, but how about changing it to SAMPLE_OLD_VNFD_ID.","commit_id":"600aabe8341d972dc92a370c4a5e936774bcf629"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"00162f7f86001154eca769756079cce077f73e5d","unresolved":true,"context_lines":[{"line_number":29,"context_line":"from tacker.tests.unit.sol_refactored.mgmt_drivers import fakes"},{"line_number":30,"context_line":"from unittest import mock"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"SAMPLE_VNFD_ID \u003d \"16ca1a07-2453-47f1-9f00-7ca2dce0a5ea\""},{"line_number":33,"context_line":"SAMPLE_NEW_VNFD_ID \u003d \"5484de3b-ff51-4c1a-b54c-4215a8130078\""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"f6d045f7_6ec5d76f","line":32,"in_reply_to":"0e250d82_e001c482","updated":"2023-09-08 06:37:50.000000000","message":"I changed `SAMPLE_VNFD_ID` to `SAMPLE_OLD_VNFD_ID`.","commit_id":"600aabe8341d972dc92a370c4a5e936774bcf629"},{"author":{"_account_id":31668},"change_message_id":"4b3a5ca684cc9decb7603cd5c1ff29b759e50b12","unresolved":false,"context_lines":[{"line_number":29,"context_line":"from tacker.tests.unit.sol_refactored.mgmt_drivers import fakes"},{"line_number":30,"context_line":"from unittest import mock"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"SAMPLE_VNFD_ID \u003d \"16ca1a07-2453-47f1-9f00-7ca2dce0a5ea\""},{"line_number":33,"context_line":"SAMPLE_NEW_VNFD_ID \u003d \"5484de3b-ff51-4c1a-b54c-4215a8130078\""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"bf9aa751_4438f074","line":32,"in_reply_to":"f6d045f7_6ec5d76f","updated":"2023-09-11 01:18:10.000000000","message":"Done","commit_id":"600aabe8341d972dc92a370c4a5e936774bcf629"},{"author":{"_account_id":31668},"change_message_id":"d1c59dbb36de30747474fd12672d5f3aec6e5327","unresolved":true,"context_lines":[{"line_number":48,"context_line":"        self.new_vnfd.init_from_csar_dir(os.path.join("},{"line_number":49,"context_line":"            sample_dir, \"test_cnf_container_update_after/contents\"))"},{"line_number":50,"context_line":"        self.req \u003d {"},{"line_number":51,"context_line":"            \"vnfdId\": \"4a7563d5-95c6-42f7-be8a-aed225c2e970\","},{"line_number":52,"context_line":"            \"vnfInstanceName\": \"modify_vnf_after\","},{"line_number":53,"context_line":"            \"metadata\": {"},{"line_number":54,"context_line":"                \"configmap_secret_paths\": ["}],"source_content_type":"text/x-python","patch_set":10,"id":"b7751e50_a3d0de06","line":51,"updated":"2023-09-07 08:13:51.000000000","message":"Why not use SAMPLE_NEW_VNFD_ID?","commit_id":"600aabe8341d972dc92a370c4a5e936774bcf629"},{"author":{"_account_id":31668},"change_message_id":"4b3a5ca684cc9decb7603cd5c1ff29b759e50b12","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        self.new_vnfd.init_from_csar_dir(os.path.join("},{"line_number":49,"context_line":"            sample_dir, \"test_cnf_container_update_after/contents\"))"},{"line_number":50,"context_line":"        self.req \u003d {"},{"line_number":51,"context_line":"            \"vnfdId\": \"4a7563d5-95c6-42f7-be8a-aed225c2e970\","},{"line_number":52,"context_line":"            \"vnfInstanceName\": \"modify_vnf_after\","},{"line_number":53,"context_line":"            \"metadata\": {"},{"line_number":54,"context_line":"                \"configmap_secret_paths\": ["}],"source_content_type":"text/x-python","patch_set":10,"id":"b684f35f_04d7f29c","line":51,"in_reply_to":"325267d2_be5a2c7c","updated":"2023-09-11 01:18:10.000000000","message":"Done","commit_id":"600aabe8341d972dc92a370c4a5e936774bcf629"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"00162f7f86001154eca769756079cce077f73e5d","unresolved":true,"context_lines":[{"line_number":48,"context_line":"        self.new_vnfd.init_from_csar_dir(os.path.join("},{"line_number":49,"context_line":"            sample_dir, \"test_cnf_container_update_after/contents\"))"},{"line_number":50,"context_line":"        self.req \u003d {"},{"line_number":51,"context_line":"            \"vnfdId\": \"4a7563d5-95c6-42f7-be8a-aed225c2e970\","},{"line_number":52,"context_line":"            \"vnfInstanceName\": \"modify_vnf_after\","},{"line_number":53,"context_line":"            \"metadata\": {"},{"line_number":54,"context_line":"                \"configmap_secret_paths\": ["}],"source_content_type":"text/x-python","patch_set":10,"id":"325267d2_be5a2c7c","line":51,"in_reply_to":"b7751e50_a3d0de06","updated":"2023-09-08 06:37:50.000000000","message":"I fixed it in patchset 11.","commit_id":"600aabe8341d972dc92a370c4a5e936774bcf629"},{"author":{"_account_id":31668},"change_message_id":"d1c59dbb36de30747474fd12672d5f3aec6e5327","unresolved":true,"context_lines":[{"line_number":60,"context_line":"        self.inst \u003d copy.deepcopy(fakes._inst_info_example_before)"},{"line_number":61,"context_line":"        grant_req \u003d None"},{"line_number":62,"context_line":"        grant \u003d None"},{"line_number":63,"context_line":"        self.csar_dir \u003d self.old_vnfd.make_tmp_csar_dir()"},{"line_number":64,"context_line":"        self.new_csar_dir \u003d self.new_vnfd.make_tmp_csar_dir()"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        self.cntr_update_mgmt \u003d mgmt_driver.ContainerUpdateMgmtDriver("}],"source_content_type":"text/x-python","patch_set":10,"id":"433388c0_3dfd6958","line":63,"updated":"2023-09-07 08:13:51.000000000","message":"`old_csar_dir` is easier to understand.\n```\nself.old_csar_dir \u003d self.old_vnfd.make_tmp_csar_dir()\n```","commit_id":"600aabe8341d972dc92a370c4a5e936774bcf629"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"00162f7f86001154eca769756079cce077f73e5d","unresolved":true,"context_lines":[{"line_number":60,"context_line":"        self.inst \u003d copy.deepcopy(fakes._inst_info_example_before)"},{"line_number":61,"context_line":"        grant_req \u003d None"},{"line_number":62,"context_line":"        grant \u003d None"},{"line_number":63,"context_line":"        self.csar_dir \u003d self.old_vnfd.make_tmp_csar_dir()"},{"line_number":64,"context_line":"        self.new_csar_dir \u003d self.new_vnfd.make_tmp_csar_dir()"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        self.cntr_update_mgmt \u003d mgmt_driver.ContainerUpdateMgmtDriver("}],"source_content_type":"text/x-python","patch_set":10,"id":"f3dcd4a5_219f059b","line":63,"in_reply_to":"433388c0_3dfd6958","updated":"2023-09-08 06:37:50.000000000","message":"I fixed it in patchset 11.","commit_id":"600aabe8341d972dc92a370c4a5e936774bcf629"},{"author":{"_account_id":31668},"change_message_id":"4b3a5ca684cc9decb7603cd5c1ff29b759e50b12","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        self.inst \u003d copy.deepcopy(fakes._inst_info_example_before)"},{"line_number":61,"context_line":"        grant_req \u003d None"},{"line_number":62,"context_line":"        grant \u003d None"},{"line_number":63,"context_line":"        self.csar_dir \u003d self.old_vnfd.make_tmp_csar_dir()"},{"line_number":64,"context_line":"        self.new_csar_dir \u003d self.new_vnfd.make_tmp_csar_dir()"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        self.cntr_update_mgmt \u003d mgmt_driver.ContainerUpdateMgmtDriver("}],"source_content_type":"text/x-python","patch_set":10,"id":"84ef6115_3ac42bea","line":63,"in_reply_to":"f3dcd4a5_219f059b","updated":"2023-09-11 01:18:10.000000000","message":"Done","commit_id":"600aabe8341d972dc92a370c4a5e936774bcf629"},{"author":{"_account_id":31668},"change_message_id":"d1c59dbb36de30747474fd12672d5f3aec6e5327","unresolved":true,"context_lines":[{"line_number":89,"context_line":"            \"tmp_csar_dir\": self.csar_dir,"},{"line_number":90,"context_line":"            \"new_csar_dir\": self.new_csar_dir"},{"line_number":91,"context_line":"        }"},{"line_number":92,"context_line":"        mgmt_driver.main()"},{"line_number":93,"context_line":"        mock_script.return_value[\u0027operation\u0027] \u003d \u0027fake\u0027"},{"line_number":94,"context_line":"        self.assertRaises(AttributeError, mgmt_driver.main)"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"82482c2b_e370371c","line":92,"updated":"2023-09-07 08:13:51.000000000","message":"I think it would be better to add a check to see if the modify_information_start method was called.","commit_id":"600aabe8341d972dc92a370c4a5e936774bcf629"},{"author":{"_account_id":31668},"change_message_id":"4b3a5ca684cc9decb7603cd5c1ff29b759e50b12","unresolved":false,"context_lines":[{"line_number":89,"context_line":"            \"tmp_csar_dir\": self.csar_dir,"},{"line_number":90,"context_line":"            \"new_csar_dir\": self.new_csar_dir"},{"line_number":91,"context_line":"        }"},{"line_number":92,"context_line":"        mgmt_driver.main()"},{"line_number":93,"context_line":"        mock_script.return_value[\u0027operation\u0027] \u003d \u0027fake\u0027"},{"line_number":94,"context_line":"        self.assertRaises(AttributeError, mgmt_driver.main)"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"27ea5cf9_ef3cbc40","line":92,"in_reply_to":"43a1b63a_6f72315d","updated":"2023-09-11 01:18:10.000000000","message":"Done","commit_id":"600aabe8341d972dc92a370c4a5e936774bcf629"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"00162f7f86001154eca769756079cce077f73e5d","unresolved":true,"context_lines":[{"line_number":89,"context_line":"            \"tmp_csar_dir\": self.csar_dir,"},{"line_number":90,"context_line":"            \"new_csar_dir\": self.new_csar_dir"},{"line_number":91,"context_line":"        }"},{"line_number":92,"context_line":"        mgmt_driver.main()"},{"line_number":93,"context_line":"        mock_script.return_value[\u0027operation\u0027] \u003d \u0027fake\u0027"},{"line_number":94,"context_line":"        self.assertRaises(AttributeError, mgmt_driver.main)"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"43a1b63a_6f72315d","line":92,"in_reply_to":"82482c2b_e370371c","updated":"2023-09-08 06:37:50.000000000","message":"I added the assertion.","commit_id":"600aabe8341d972dc92a370c4a5e936774bcf629"},{"author":{"_account_id":31668},"change_message_id":"d1c59dbb36de30747474fd12672d5f3aec6e5327","unresolved":true,"context_lines":[{"line_number":97,"context_line":"    def test_container_update_modify_information_end_error("},{"line_number":98,"context_line":"            self, mock_urlopen):"},{"line_number":99,"context_line":"        req \u003d {"},{"line_number":100,"context_line":"            \"vnfdId\": \"4a7563d5-95c6-42f7-be8a-aed225c2e970\","},{"line_number":101,"context_line":"            \"vnfInstanceName\": \"modify_vnf_after\","},{"line_number":102,"context_line":"            \"metadata\": {"},{"line_number":103,"context_line":"                \"configmap_secret_paths\": ["}],"source_content_type":"text/x-python","patch_set":10,"id":"bb4b593d_8c77eef9","line":100,"updated":"2023-09-07 08:13:51.000000000","message":"Why not use SAMPLE_NEW_VNFD_ID?","commit_id":"600aabe8341d972dc92a370c4a5e936774bcf629"},{"author":{"_account_id":31668},"change_message_id":"4b3a5ca684cc9decb7603cd5c1ff29b759e50b12","unresolved":false,"context_lines":[{"line_number":97,"context_line":"    def test_container_update_modify_information_end_error("},{"line_number":98,"context_line":"            self, mock_urlopen):"},{"line_number":99,"context_line":"        req \u003d {"},{"line_number":100,"context_line":"            \"vnfdId\": \"4a7563d5-95c6-42f7-be8a-aed225c2e970\","},{"line_number":101,"context_line":"            \"vnfInstanceName\": \"modify_vnf_after\","},{"line_number":102,"context_line":"            \"metadata\": {"},{"line_number":103,"context_line":"                \"configmap_secret_paths\": ["}],"source_content_type":"text/x-python","patch_set":10,"id":"1675ce17_a650e37c","line":100,"in_reply_to":"097d1b97_4da342d5","updated":"2023-09-11 01:18:10.000000000","message":"Done","commit_id":"600aabe8341d972dc92a370c4a5e936774bcf629"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"00162f7f86001154eca769756079cce077f73e5d","unresolved":true,"context_lines":[{"line_number":97,"context_line":"    def test_container_update_modify_information_end_error("},{"line_number":98,"context_line":"            self, mock_urlopen):"},{"line_number":99,"context_line":"        req \u003d {"},{"line_number":100,"context_line":"            \"vnfdId\": \"4a7563d5-95c6-42f7-be8a-aed225c2e970\","},{"line_number":101,"context_line":"            \"vnfInstanceName\": \"modify_vnf_after\","},{"line_number":102,"context_line":"            \"metadata\": {"},{"line_number":103,"context_line":"                \"configmap_secret_paths\": ["}],"source_content_type":"text/x-python","patch_set":10,"id":"097d1b97_4da342d5","line":100,"in_reply_to":"bb4b593d_8c77eef9","updated":"2023-09-08 06:37:50.000000000","message":"I fixed it in patchset 11.","commit_id":"600aabe8341d972dc92a370c4a5e936774bcf629"},{"author":{"_account_id":31668},"change_message_id":"4b3a5ca684cc9decb7603cd5c1ff29b759e50b12","unresolved":true,"context_lines":[{"line_number":35,"context_line":"_inst_info_example_before \u003d {"},{"line_number":36,"context_line":"    \"id\": \"c80f7afa-65f3-4be6-94ae-fdf438ac2d61\","},{"line_number":37,"context_line":"    \"vnfInstanceName\": \"modify_vnf_before\","},{"line_number":38,"context_line":"    \"vnfdId\": \"16ca1a07-2453-47f1-9f00-7ca2dce0a5ea\","},{"line_number":39,"context_line":"    \"vnfProvider\": \"Company\","},{"line_number":40,"context_line":"    \"vnfProductName\": \"Sample VNF\","},{"line_number":41,"context_line":"    \"vnfSoftwareVersion\": \"1.0\","}],"source_content_type":"text/x-python","patch_set":11,"id":"4153bccd_d0bff7d8","line":38,"updated":"2023-09-11 01:18:10.000000000","message":"It is better to use SAMPLE_OLD_VNFD_ID.","commit_id":"7f7c04fcd3793a911bad4fb829911e86a4c54d2e"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"7b803d902b5e3913e977204314df05eb6788cb30","unresolved":true,"context_lines":[{"line_number":35,"context_line":"_inst_info_example_before \u003d {"},{"line_number":36,"context_line":"    \"id\": \"c80f7afa-65f3-4be6-94ae-fdf438ac2d61\","},{"line_number":37,"context_line":"    \"vnfInstanceName\": \"modify_vnf_before\","},{"line_number":38,"context_line":"    \"vnfdId\": \"16ca1a07-2453-47f1-9f00-7ca2dce0a5ea\","},{"line_number":39,"context_line":"    \"vnfProvider\": \"Company\","},{"line_number":40,"context_line":"    \"vnfProductName\": \"Sample VNF\","},{"line_number":41,"context_line":"    \"vnfSoftwareVersion\": \"1.0\","}],"source_content_type":"text/x-python","patch_set":11,"id":"cba28224_9b0eb684","line":38,"in_reply_to":"4153bccd_d0bff7d8","updated":"2023-09-12 01:45:07.000000000","message":"I fixed it in patchset 12.","commit_id":"7f7c04fcd3793a911bad4fb829911e86a4c54d2e"},{"author":{"_account_id":31668},"change_message_id":"09376f5260c6975a64b901cc4c3a2f08b1eefac2","unresolved":false,"context_lines":[{"line_number":35,"context_line":"_inst_info_example_before \u003d {"},{"line_number":36,"context_line":"    \"id\": \"c80f7afa-65f3-4be6-94ae-fdf438ac2d61\","},{"line_number":37,"context_line":"    \"vnfInstanceName\": \"modify_vnf_before\","},{"line_number":38,"context_line":"    \"vnfdId\": \"16ca1a07-2453-47f1-9f00-7ca2dce0a5ea\","},{"line_number":39,"context_line":"    \"vnfProvider\": \"Company\","},{"line_number":40,"context_line":"    \"vnfProductName\": \"Sample VNF\","},{"line_number":41,"context_line":"    \"vnfSoftwareVersion\": \"1.0\","}],"source_content_type":"text/x-python","patch_set":11,"id":"6a18db2b_b1bf24fc","line":38,"in_reply_to":"cba28224_9b0eb684","updated":"2023-09-14 04:47:07.000000000","message":"Done","commit_id":"7f7c04fcd3793a911bad4fb829911e86a4c54d2e"}]}