)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"5ebdc9211765681c357a65456bb41aeef8d9ae9d","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Terraform Infra-Driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch is build an environment for terraform."},{"line_number":10,"context_line":"To build the terraform environment that"},{"line_number":11,"context_line":"need to install as follow componets:"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":" - awscli"},{"line_number":14,"context_line":" - docker"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":31,"id":"0548a05b_f469885d","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":36},"updated":"2023-09-11 12:55:34.000000000","message":"This patch seems to be more than just building an environment for Terraform. Could you update the commit message to match the current patch content?","commit_id":"da137f3b34c0a5b424788f7aec61ce20eb2d9245"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"f48cc904424282ccfafba382416a4ac01182ed84","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Terraform Infra-Driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch is build an environment for terraform."},{"line_number":10,"context_line":"To build the terraform environment that"},{"line_number":11,"context_line":"need to install as follow componets:"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":" - awscli"},{"line_number":14,"context_line":" - docker"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":31,"id":"ae21b48a_59c3505a","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":36},"in_reply_to":"0548a05b_f469885d","updated":"2023-09-12 15:22:41.000000000","message":"It\u0027s not wrong actually but the term \"environment\" is so ambiguous. So, I\u0027ll clarify this update provides a infra driver and several tests for. Thanks.","commit_id":"da137f3b34c0a5b424788f7aec61ce20eb2d9245"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"14ea7e3763a747d894b3efe2ee77950c685cfeac","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Terraform Infra-Driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch is build an environment for terraform."},{"line_number":10,"context_line":"To build the terraform environment that"},{"line_number":11,"context_line":"need to install as follow componets:"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":" - awscli"},{"line_number":14,"context_line":" - docker"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":31,"id":"d6af083b_b3199f39","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":36},"in_reply_to":"ae21b48a_59c3505a","updated":"2023-09-12 22:00:07.000000000","message":"Ack","commit_id":"da137f3b34c0a5b424788f7aec61ce20eb2d9245"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"5ebdc9211765681c357a65456bb41aeef8d9ae9d","unresolved":true,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":" - awscli"},{"line_number":14,"context_line":" - docker"},{"line_number":15,"context_line":" - localstack or moto server"},{"line_number":16,"context_line":" - terraform"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Implements: blueprint terraform-infra-driver"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":31,"id":"f9e816a7_c21bfef0","line":15,"range":{"start_line":15,"start_character":14,"end_line":15,"end_character":28},"updated":"2023-09-11 12:55:34.000000000","message":"`moto server` has not installed in this patch, but should you write this description?","commit_id":"da137f3b34c0a5b424788f7aec61ce20eb2d9245"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"14ea7e3763a747d894b3efe2ee77950c685cfeac","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":" - awscli"},{"line_number":14,"context_line":" - docker"},{"line_number":15,"context_line":" - localstack or moto server"},{"line_number":16,"context_line":" - terraform"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Implements: blueprint terraform-infra-driver"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":31,"id":"f678106d_9142d2c9","line":15,"range":{"start_line":15,"start_character":14,"end_line":15,"end_character":28},"in_reply_to":"0c15090c_6e7ff07b","updated":"2023-09-12 22:00:07.000000000","message":"Okay, I understood.","commit_id":"da137f3b34c0a5b424788f7aec61ce20eb2d9245"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"f48cc904424282ccfafba382416a4ac01182ed84","unresolved":true,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":" - awscli"},{"line_number":14,"context_line":" - docker"},{"line_number":15,"context_line":" - localstack or moto server"},{"line_number":16,"context_line":" - terraform"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Implements: blueprint terraform-infra-driver"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":31,"id":"0c15090c_6e7ff07b","line":15,"range":{"start_line":15,"start_character":14,"end_line":15,"end_character":28},"in_reply_to":"f9e816a7_c21bfef0","updated":"2023-09-12 15:22:41.000000000","message":"It\u0027s just saying you have a choice.","commit_id":"da137f3b34c0a5b424788f7aec61ce20eb2d9245"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"5ebdc9211765681c357a65456bb41aeef8d9ae9d","unresolved":true,"context_lines":[{"line_number":14,"context_line":" - docker"},{"line_number":15,"context_line":" - localstack or moto server"},{"line_number":16,"context_line":" - terraform"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Implements: blueprint terraform-infra-driver"},{"line_number":19,"context_line":"Change-Id: I14414c42229dcdb8e0083d7c51d6be6b5f2fc841"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":31,"id":"ea128eed_2e622910","line":17,"updated":"2023-09-11 12:55:34.000000000","message":"Could you add a release note for this feature?","commit_id":"da137f3b34c0a5b424788f7aec61ce20eb2d9245"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"5ebdc9211765681c357a65456bb41aeef8d9ae9d","unresolved":true,"context_lines":[{"line_number":14,"context_line":" - docker"},{"line_number":15,"context_line":" - localstack or moto server"},{"line_number":16,"context_line":" - terraform"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Implements: blueprint terraform-infra-driver"},{"line_number":19,"context_line":"Change-Id: I14414c42229dcdb8e0083d7c51d6be6b5f2fc841"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":31,"id":"e9df10bb_7c405bff","line":17,"updated":"2023-09-11 12:55:34.000000000","message":"Will the document be posted with another patch in Bobcat cycle?\n\nSpec states:\n```\nDocumentation Impact\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n\nNeed to explain the use cases of Terraform infra-driver.\n```","commit_id":"da137f3b34c0a5b424788f7aec61ce20eb2d9245"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"14ea7e3763a747d894b3efe2ee77950c685cfeac","unresolved":false,"context_lines":[{"line_number":14,"context_line":" - docker"},{"line_number":15,"context_line":" - localstack or moto server"},{"line_number":16,"context_line":" - terraform"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Implements: blueprint terraform-infra-driver"},{"line_number":19,"context_line":"Change-Id: I14414c42229dcdb8e0083d7c51d6be6b5f2fc841"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":31,"id":"48ee7e52_4062e57b","line":17,"in_reply_to":"235834fa_3ccf59c2","updated":"2023-09-12 22:00:07.000000000","message":"Ack","commit_id":"da137f3b34c0a5b424788f7aec61ce20eb2d9245"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"874c5b82ec901def8550557b966943853ae4284c","unresolved":false,"context_lines":[{"line_number":14,"context_line":" - docker"},{"line_number":15,"context_line":" - localstack or moto server"},{"line_number":16,"context_line":" - terraform"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Implements: blueprint terraform-infra-driver"},{"line_number":19,"context_line":"Change-Id: I14414c42229dcdb8e0083d7c51d6be6b5f2fc841"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":31,"id":"070b9004_94755421","line":17,"in_reply_to":"89ce5524_ef6d86a1","updated":"2023-09-13 09:40:33.000000000","message":"Done","commit_id":"da137f3b34c0a5b424788f7aec61ce20eb2d9245"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"b1528a590b2134cc6b55575c0573cbecfa347644","unresolved":true,"context_lines":[{"line_number":14,"context_line":" - docker"},{"line_number":15,"context_line":" - localstack or moto server"},{"line_number":16,"context_line":" - terraform"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Implements: blueprint terraform-infra-driver"},{"line_number":19,"context_line":"Change-Id: I14414c42229dcdb8e0083d7c51d6be6b5f2fc841"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":31,"id":"89ce5524_ef6d86a1","line":17,"in_reply_to":"a43d5308_10619f2e","updated":"2023-09-13 02:53:10.000000000","message":"another one","commit_id":"da137f3b34c0a5b424788f7aec61ce20eb2d9245"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"14ea7e3763a747d894b3efe2ee77950c685cfeac","unresolved":true,"context_lines":[{"line_number":14,"context_line":" - docker"},{"line_number":15,"context_line":" - localstack or moto server"},{"line_number":16,"context_line":" - terraform"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Implements: blueprint terraform-infra-driver"},{"line_number":19,"context_line":"Change-Id: I14414c42229dcdb8e0083d7c51d6be6b5f2fc841"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":31,"id":"a43d5308_10619f2e","line":17,"in_reply_to":"bfbe383f_4678a557","updated":"2023-09-12 22:00:07.000000000","message":"Will you upload another patch? or into this patch?","commit_id":"da137f3b34c0a5b424788f7aec61ce20eb2d9245"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"f48cc904424282ccfafba382416a4ac01182ed84","unresolved":true,"context_lines":[{"line_number":14,"context_line":" - docker"},{"line_number":15,"context_line":" - localstack or moto server"},{"line_number":16,"context_line":" - terraform"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Implements: blueprint terraform-infra-driver"},{"line_number":19,"context_line":"Change-Id: I14414c42229dcdb8e0083d7c51d6be6b5f2fc841"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":31,"id":"bfbe383f_4678a557","line":17,"in_reply_to":"e9df10bb_7c405bff","updated":"2023-09-12 15:22:41.000000000","message":"It going to be dropped actually, but uploaded soon :)","commit_id":"da137f3b34c0a5b424788f7aec61ce20eb2d9245"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"f48cc904424282ccfafba382416a4ac01182ed84","unresolved":true,"context_lines":[{"line_number":14,"context_line":" - docker"},{"line_number":15,"context_line":" - localstack or moto server"},{"line_number":16,"context_line":" - terraform"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Implements: blueprint terraform-infra-driver"},{"line_number":19,"context_line":"Change-Id: I14414c42229dcdb8e0083d7c51d6be6b5f2fc841"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":31,"id":"235834fa_3ccf59c2","line":17,"in_reply_to":"ea128eed_2e622910","updated":"2023-09-12 15:22:41.000000000","message":"yap, done.","commit_id":"da137f3b34c0a5b424788f7aec61ce20eb2d9245"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":36013,"name":"Henry van Dyck","email":"henrycd11@gmail.com","username":"henryvandyck","status":"NTT"},"change_message_id":"5bde2c219886f104a7678fc39072ab7845aa2afb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"862d67f1_764ba7e6","updated":"2023-08-14 02:58:12.000000000","message":"recheck, RETRY_LIMIT","commit_id":"ee057ca16965d623fb902c06ed51b517db84180e"},{"author":{"_account_id":36013,"name":"Henry van Dyck","email":"henrycd11@gmail.com","username":"henryvandyck","status":"NTT"},"change_message_id":"e3eec3f86a9a005d63f24bbda8a027b82e063af9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"70f25237_0d5625e2","updated":"2023-08-14 02:56:59.000000000","message":"recheck, failed test","commit_id":"ee057ca16965d623fb902c06ed51b517db84180e"},{"author":{"_account_id":36013,"name":"Henry van Dyck","email":"henrycd11@gmail.com","username":"henryvandyck","status":"NTT"},"change_message_id":"dcf654770909689492d08ca636d72245223035eb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"d016d813_7d25be30","updated":"2023-08-16 02:07:53.000000000","message":"recheck, failed_retry","commit_id":"656eeab91034f5b3bd4816def835e2aebd954f37"},{"author":{"_account_id":36013,"name":"Henry van Dyck","email":"henrycd11@gmail.com","username":"henryvandyck","status":"NTT"},"change_message_id":"5561528607e0c1a96786610b1a43bc2ba22b78f7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"34eb68ec_690153b2","updated":"2023-08-15 02:19:54.000000000","message":"recheck, retry_limit","commit_id":"656eeab91034f5b3bd4816def835e2aebd954f37"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"d2ea844bec3aebe2b0a5392b23898c6f787d8b6c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":31,"id":"1398690d_ccea3d5e","updated":"2023-09-12 05:00:37.000000000","message":"I\u0027m sorry for multiple comments. Please kindly find additional comments.","commit_id":"da137f3b34c0a5b424788f7aec61ce20eb2d9245"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"f48cc904424282ccfafba382416a4ac01182ed84","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":31,"id":"32f30980_e7eee8cf","updated":"2023-09-12 15:22:41.000000000","message":"Thanks for the comments!","commit_id":"da137f3b34c0a5b424788f7aec61ce20eb2d9245"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"5ebdc9211765681c357a65456bb41aeef8d9ae9d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":31,"id":"c4b21afb_855f6c21","updated":"2023-09-11 12:55:34.000000000","message":"Thanks for your patch, please kindly find my comments.","commit_id":"da137f3b34c0a5b424788f7aec61ce20eb2d9245"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"8a6d3fc57f1fe8f1f45cbabbd4710aa5356cf50f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":31,"id":"b779a2f3_6ffbff94","in_reply_to":"c4b21afb_855f6c21","updated":"2023-09-15 07:10:10.000000000","message":"Done","commit_id":"da137f3b34c0a5b424788f7aec61ce20eb2d9245"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"14ea7e3763a747d894b3efe2ee77950c685cfeac","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":32,"id":"eb8cc98e_8e5c35f3","updated":"2023-09-12 22:00:07.000000000","message":"Thanks for your rework,\n\nAnd I’m sorry that some comments have been mistakenly commented on PS 29. Please kindly confirm them.\n* https://review.opendev.org/c/openstack/tacker/+/890611/31..32#message-7bcf6cbc463ab65b3b815af53c4f97feac559f0a\n* https://review.opendev.org/c/openstack/tacker/+/890611/31..32#message-d2ea844bec3aebe2b0a5392b23898c6f787d8b6c","commit_id":"49f2f88fdea0d1d3ff999b66d8e31bb540e670f7"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"b1528a590b2134cc6b55575c0573cbecfa347644","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":32,"id":"fadff292_6f34ae51","in_reply_to":"eb8cc98e_8e5c35f3","updated":"2023-09-13 02:53:10.000000000","message":"Yap, I\u0027m preparing them now. Thanks.","commit_id":"49f2f88fdea0d1d3ff999b66d8e31bb540e670f7"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"874c5b82ec901def8550557b966943853ae4284c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":32,"id":"3541db49_7f74cb65","in_reply_to":"fadff292_6f34ae51","updated":"2023-09-13 09:40:33.000000000","message":"Done","commit_id":"49f2f88fdea0d1d3ff999b66d8e31bb540e670f7"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"3b9387fd727ebd67de13234a78724951d0816ec9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":34,"id":"377ce2b0_7c9562bd","updated":"2023-09-14 05:13:06.000000000","message":"recheck - for unexpected system failure","commit_id":"f51b01a3c971e9d7d50956828abf5be29eeffe11"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"c58e4c2191493c73a635154d4b31edf7a4cf233b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":34,"id":"79e4803e_39d32a91","updated":"2023-09-13 21:32:53.000000000","message":"recheck - for unexpected system failure","commit_id":"f51b01a3c971e9d7d50956828abf5be29eeffe11"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"54dba3296976f986c0d7e7954ae195d11e869d7a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":35,"id":"d77ebf0d_2edc2687","updated":"2023-09-14 11:33:03.000000000","message":"recheck - for unexpected system failure","commit_id":"2a0ab65d4a75605fc499695b8bdb0e5cf778035e"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"25c1847e8157162fa6c98ed19dd202734ea6e898","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":41,"id":"2dddc418_e04a5c9f","updated":"2023-09-15 12:19:22.000000000","message":"LGTM, I will put CR+2 after zuul test passed.","commit_id":"5d59833b201c1deadf7053d4dfa99f0cd0fc35f6"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"5d371b493d038d797b9567db7aaa1682a8cc2b71","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":41,"id":"f716f558_170939c1","updated":"2023-09-15 12:49:56.000000000","message":"Thank you for your review so kindly!","commit_id":"5d59833b201c1deadf7053d4dfa99f0cd0fc35f6"}],"roles/setup-terraform/tasks/main.yaml":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"5ebdc9211765681c357a65456bb41aeef8d9ae9d","unresolved":true,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"  - name: Install terraform"},{"line_number":31,"context_line":"    apt:"},{"line_number":32,"context_line":"      name: terraform"},{"line_number":33,"context_line":"      state: present"},{"line_number":34,"context_line":"      update_cache: yes"},{"line_number":35,"context_line":"    become: yes"}],"source_content_type":"text/x-yaml","patch_set":31,"id":"d0378392_093293c0","line":32,"range":{"start_line":32,"start_character":12,"end_line":32,"end_character":21},"updated":"2023-09-11 12:55:34.000000000","message":"The Spec listed the following dependencies, do you need to specify the version?\n```\nDependencies\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n\n* Terraform v1.4.0 or later\n```","commit_id":"da137f3b34c0a5b424788f7aec61ce20eb2d9245"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"4101581752c173781f2c8aa91d05225051fc4f5b","unresolved":true,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"  - name: Install terraform"},{"line_number":31,"context_line":"    apt:"},{"line_number":32,"context_line":"      name: terraform"},{"line_number":33,"context_line":"      state: present"},{"line_number":34,"context_line":"      update_cache: yes"},{"line_number":35,"context_line":"    become: yes"}],"source_content_type":"text/x-yaml","patch_set":31,"id":"f67f4d46_49a838b8","line":32,"range":{"start_line":32,"start_character":12,"end_line":32,"end_character":21},"in_reply_to":"337bd234_5b92b2db","updated":"2023-09-14 06:13:55.000000000","message":"ping,\n\u003e it\u0027s enough to say it also in commit message specifically. So, I\u0027ll do in the next PS.\n\nIt doesn\u0027t seem to be responded yet, will it do in the next PS?","commit_id":"da137f3b34c0a5b424788f7aec61ce20eb2d9245"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"14ea7e3763a747d894b3efe2ee77950c685cfeac","unresolved":true,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"  - name: Install terraform"},{"line_number":31,"context_line":"    apt:"},{"line_number":32,"context_line":"      name: terraform"},{"line_number":33,"context_line":"      state: present"},{"line_number":34,"context_line":"      update_cache: yes"},{"line_number":35,"context_line":"    become: yes"}],"source_content_type":"text/x-yaml","patch_set":31,"id":"ed7dd0ae_a9f8e152","line":32,"range":{"start_line":32,"start_character":12,"end_line":32,"end_character":21},"in_reply_to":"6f68efd1_94427d58","updated":"2023-09-12 22:00:07.000000000","message":"I got, it would be nice if the document could state the minimum version (or supported version) that should be installed.","commit_id":"da137f3b34c0a5b424788f7aec61ce20eb2d9245"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"f48cc904424282ccfafba382416a4ac01182ed84","unresolved":true,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"  - name: Install terraform"},{"line_number":31,"context_line":"    apt:"},{"line_number":32,"context_line":"      name: terraform"},{"line_number":33,"context_line":"      state: present"},{"line_number":34,"context_line":"      update_cache: yes"},{"line_number":35,"context_line":"    become: yes"}],"source_content_type":"text/x-yaml","patch_set":31,"id":"6f68efd1_94427d58","line":32,"range":{"start_line":32,"start_character":12,"end_line":32,"end_character":21},"in_reply_to":"d0378392_093293c0","updated":"2023-09-12 15:22:41.000000000","message":"I think we don\u0027t need to fix the version here in the playbook because installing older version cannot be happened usually, so we don\u0027t need to be so carefully.","commit_id":"da137f3b34c0a5b424788f7aec61ce20eb2d9245"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"8a6d3fc57f1fe8f1f45cbabbd4710aa5356cf50f","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"  - name: Install terraform"},{"line_number":31,"context_line":"    apt:"},{"line_number":32,"context_line":"      name: terraform"},{"line_number":33,"context_line":"      state: present"},{"line_number":34,"context_line":"      update_cache: yes"},{"line_number":35,"context_line":"    become: yes"}],"source_content_type":"text/x-yaml","patch_set":31,"id":"9294cdfc_3b525889","line":32,"range":{"start_line":32,"start_character":12,"end_line":32,"end_character":21},"in_reply_to":"d12fa4d9_8dcf8e84","updated":"2023-09-15 07:10:10.000000000","message":"Ack","commit_id":"da137f3b34c0a5b424788f7aec61ce20eb2d9245"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"b1528a590b2134cc6b55575c0573cbecfa347644","unresolved":true,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"  - name: Install terraform"},{"line_number":31,"context_line":"    apt:"},{"line_number":32,"context_line":"      name: terraform"},{"line_number":33,"context_line":"      state: present"},{"line_number":34,"context_line":"      update_cache: yes"},{"line_number":35,"context_line":"    become: yes"}],"source_content_type":"text/x-yaml","patch_set":31,"id":"337bd234_5b92b2db","line":32,"range":{"start_line":32,"start_character":12,"end_line":32,"end_character":21},"in_reply_to":"ed7dd0ae_a9f8e152","updated":"2023-09-13 02:53:10.000000000","message":"OK, and it\u0027s enough to say it also in commit message specifically. So, I\u0027ll do in the next PS.","commit_id":"da137f3b34c0a5b424788f7aec61ce20eb2d9245"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"d1102d3b280e62fa8fda4d5e33bba38243fb34b0","unresolved":true,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"  - name: Install terraform"},{"line_number":31,"context_line":"    apt:"},{"line_number":32,"context_line":"      name: terraform"},{"line_number":33,"context_line":"      state: present"},{"line_number":34,"context_line":"      update_cache: yes"},{"line_number":35,"context_line":"    become: yes"}],"source_content_type":"text/x-yaml","patch_set":31,"id":"d12fa4d9_8dcf8e84","line":32,"range":{"start_line":32,"start_character":12,"end_line":32,"end_character":21},"in_reply_to":"f67f4d46_49a838b8","updated":"2023-09-14 06:52:17.000000000","message":"I\u0027ve uploaded just now, so it must be the previous one.","commit_id":"da137f3b34c0a5b424788f7aec61ce20eb2d9245"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"5ebdc9211765681c357a65456bb41aeef8d9ae9d","unresolved":true,"context_lines":[{"line_number":34,"context_line":"      update_cache: yes"},{"line_number":35,"context_line":"    become: yes"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"  - name: Install awscli, LocalStack CLI and terraform"},{"line_number":38,"context_line":"    pip:"},{"line_number":39,"context_line":"      name:"},{"line_number":40,"context_line":"      - awscli\u003e\u003d1.29.0"}],"source_content_type":"text/x-yaml","patch_set":31,"id":"2a125d10_6138223a","line":37,"range":{"start_line":37,"start_character":40,"end_line":37,"end_character":54},"updated":"2023-09-11 12:55:34.000000000","message":"terraform is already installed in the task above. Could you delete it?","commit_id":"da137f3b34c0a5b424788f7aec61ce20eb2d9245"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"f48cc904424282ccfafba382416a4ac01182ed84","unresolved":true,"context_lines":[{"line_number":34,"context_line":"      update_cache: yes"},{"line_number":35,"context_line":"    become: yes"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"  - name: Install awscli, LocalStack CLI and terraform"},{"line_number":38,"context_line":"    pip:"},{"line_number":39,"context_line":"      name:"},{"line_number":40,"context_line":"      - awscli\u003e\u003d1.29.0"}],"source_content_type":"text/x-yaml","patch_set":31,"id":"6fa844fb_6f9fdf8d","line":37,"range":{"start_line":37,"start_character":40,"end_line":37,"end_character":54},"in_reply_to":"2a125d10_6138223a","updated":"2023-09-12 15:22:41.000000000","message":"sure","commit_id":"da137f3b34c0a5b424788f7aec61ce20eb2d9245"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"14ea7e3763a747d894b3efe2ee77950c685cfeac","unresolved":false,"context_lines":[{"line_number":34,"context_line":"      update_cache: yes"},{"line_number":35,"context_line":"    become: yes"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"  - name: Install awscli, LocalStack CLI and terraform"},{"line_number":38,"context_line":"    pip:"},{"line_number":39,"context_line":"      name:"},{"line_number":40,"context_line":"      - awscli\u003e\u003d1.29.0"}],"source_content_type":"text/x-yaml","patch_set":31,"id":"1c25369d_6f74f4e3","line":37,"range":{"start_line":37,"start_character":40,"end_line":37,"end_character":54},"in_reply_to":"6fa844fb_6f9fdf8d","updated":"2023-09-12 22:00:07.000000000","message":"Ack","commit_id":"da137f3b34c0a5b424788f7aec61ce20eb2d9245"}],"tacker/sol_refactored/common/config.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"5ebdc9211765681c357a65456bb41aeef8d9ae9d","unresolved":true,"context_lines":[{"line_number":130,"context_line":"    cfg.StrOpt(\u0027tf_file_dir\u0027,"},{"line_number":131,"context_line":"             default\u003d\u0027/var/lib/tacker/terraform/\u0027,"},{"line_number":132,"context_line":"             help\u003d_(\u0027Temporary directory for Terraform infra-driver to \u0027"},{"line_number":133,"context_line":"                     \u0027store terraform config files\u0027))"},{"line_number":134,"context_line":"]"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"CONF.register_opts(VNFM_OPTS, \u0027v2_vnfm\u0027)"}],"source_content_type":"text/x-python","patch_set":31,"id":"27547e2c_be0bbd9d","line":133,"range":{"start_line":133,"start_character":20,"end_line":133,"end_character":21},"updated":"2023-09-11 12:55:34.000000000","message":"nit: Could you delete a space character?","commit_id":"da137f3b34c0a5b424788f7aec61ce20eb2d9245"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"f48cc904424282ccfafba382416a4ac01182ed84","unresolved":true,"context_lines":[{"line_number":130,"context_line":"    cfg.StrOpt(\u0027tf_file_dir\u0027,"},{"line_number":131,"context_line":"             default\u003d\u0027/var/lib/tacker/terraform/\u0027,"},{"line_number":132,"context_line":"             help\u003d_(\u0027Temporary directory for Terraform infra-driver to \u0027"},{"line_number":133,"context_line":"                     \u0027store terraform config files\u0027))"},{"line_number":134,"context_line":"]"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"CONF.register_opts(VNFM_OPTS, \u0027v2_vnfm\u0027)"}],"source_content_type":"text/x-python","patch_set":31,"id":"9db1e11d_0b1f6cbc","line":133,"range":{"start_line":133,"start_character":20,"end_line":133,"end_character":21},"in_reply_to":"27547e2c_be0bbd9d","updated":"2023-09-12 15:22:41.000000000","message":"fixed","commit_id":"da137f3b34c0a5b424788f7aec61ce20eb2d9245"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"14ea7e3763a747d894b3efe2ee77950c685cfeac","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    cfg.StrOpt(\u0027tf_file_dir\u0027,"},{"line_number":131,"context_line":"             default\u003d\u0027/var/lib/tacker/terraform/\u0027,"},{"line_number":132,"context_line":"             help\u003d_(\u0027Temporary directory for Terraform infra-driver to \u0027"},{"line_number":133,"context_line":"                     \u0027store terraform config files\u0027))"},{"line_number":134,"context_line":"]"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"CONF.register_opts(VNFM_OPTS, \u0027v2_vnfm\u0027)"}],"source_content_type":"text/x-python","patch_set":31,"id":"fd9bd94a_c9a93028","line":133,"range":{"start_line":133,"start_character":20,"end_line":133,"end_character":21},"in_reply_to":"9db1e11d_0b1f6cbc","updated":"2023-09-12 22:00:07.000000000","message":"Ack","commit_id":"da137f3b34c0a5b424788f7aec61ce20eb2d9245"}],"tacker/sol_refactored/infra_drivers/terraform/terraform.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"7bcf6cbc463ab65b3b815af53c4f97feac559f0a","unresolved":true,"context_lines":[{"line_number":56,"context_line":"    def _instantiate(self, vim_info, working_dir, tf_var_path):"},{"line_number":57,"context_line":"        \u0027\u0027\u0027Executes terraform init, terraform plan, and terraform apply\u0027\u0027\u0027"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        access_info \u003d vim_info.get(\u0027vim1\u0027, {}).get(\u0027accessInfo\u0027, {})"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        try:"},{"line_number":62,"context_line":"            # Execute the terraform init command"}],"source_content_type":"text/x-python","patch_set":29,"id":"c91a1c74_b5e4c77f","line":59,"range":{"start_line":59,"start_character":36,"end_line":59,"end_character":40},"updated":"2023-09-12 04:15:09.000000000","message":"Could you fix it to use `inst_utils.select_vim_info` instead of specifying it in `vim1`, like other infraDrivers [1].\n\n[1] https://opendev.org/openstack/tacker/src/branch/stable/2023.1/tacker/sol_refactored/infra_drivers/openstack/openstack.py#L98","commit_id":"a8e311147e674bb038af15e418f8816f59802f38"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c65ee7bd69bc6b2d9867b78943e869fe4de14b18","unresolved":true,"context_lines":[{"line_number":56,"context_line":"    def _instantiate(self, vim_info, working_dir, tf_var_path):"},{"line_number":57,"context_line":"        \u0027\u0027\u0027Executes terraform init, terraform plan, and terraform apply\u0027\u0027\u0027"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        access_info \u003d vim_info.get(\u0027vim1\u0027, {}).get(\u0027accessInfo\u0027, {})"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        try:"},{"line_number":62,"context_line":"            # Execute the terraform init command"}],"source_content_type":"text/x-python","patch_set":29,"id":"d6385113_f6d304a6","line":59,"range":{"start_line":59,"start_character":36,"end_line":59,"end_character":40},"in_reply_to":"205c734f_7c5bbd1d","updated":"2023-09-14 07:16:53.000000000","message":"In my understandng that `vim1` is a key of the vimConnectionInfo map that can be given arbitrary by the user\u0027s instantiateRequest or Grant, and of course, other names could be specified.\n\nMy point is, is it correct to specify the name by `vim1` here?\nOr is there a rule that terraform must use `vim1`?\n\nI will just suggest to replace L44 to the following code:\n```\n        vim_connection_info \u003d inst_utils.select_vim_info(inst.vimConnectionInfo)\n```\nand fix this line(L59) to the following:\n```\n        access_info \u003d vim_conn_info.get(\u0027accessInfo\u0027, {})\n```\n\nIt is the same for other similarly pointed out comment such as `terminate`.\nWhat do you think?","commit_id":"a8e311147e674bb038af15e418f8816f59802f38"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"d1102d3b280e62fa8fda4d5e33bba38243fb34b0","unresolved":true,"context_lines":[{"line_number":56,"context_line":"    def _instantiate(self, vim_info, working_dir, tf_var_path):"},{"line_number":57,"context_line":"        \u0027\u0027\u0027Executes terraform init, terraform plan, and terraform apply\u0027\u0027\u0027"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        access_info \u003d vim_info.get(\u0027vim1\u0027, {}).get(\u0027accessInfo\u0027, {})"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        try:"},{"line_number":62,"context_line":"            # Execute the terraform init command"}],"source_content_type":"text/x-python","patch_set":29,"id":"205c734f_7c5bbd1d","line":59,"range":{"start_line":59,"start_character":36,"end_line":59,"end_character":40},"in_reply_to":"56bfe0b4_4ff43ea7","updated":"2023-09-14 06:52:17.000000000","message":"I\u0027m not sure your point actually because \"vim_info\" is a vim connection info actually although the name is not appropriate.","commit_id":"a8e311147e674bb038af15e418f8816f59802f38"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"71c370c7488b0bce2e39ce6345b1eaf75bd26533","unresolved":true,"context_lines":[{"line_number":56,"context_line":"    def _instantiate(self, vim_info, working_dir, tf_var_path):"},{"line_number":57,"context_line":"        \u0027\u0027\u0027Executes terraform init, terraform plan, and terraform apply\u0027\u0027\u0027"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        access_info \u003d vim_info.get(\u0027vim1\u0027, {}).get(\u0027accessInfo\u0027, {})"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        try:"},{"line_number":62,"context_line":"            # Execute the terraform init command"}],"source_content_type":"text/x-python","patch_set":29,"id":"eb7060f1_edb99906","line":59,"range":{"start_line":59,"start_character":36,"end_line":59,"end_character":40},"in_reply_to":"890b43ec_e96d0ab5","updated":"2023-09-15 02:07:40.000000000","message":"I\u0027ve just update PS for fixing a merge conflict in tox.ini at once, but your comment is not fixed yet.","commit_id":"a8e311147e674bb038af15e418f8816f59802f38"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"8a6d3fc57f1fe8f1f45cbabbd4710aa5356cf50f","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    def _instantiate(self, vim_info, working_dir, tf_var_path):"},{"line_number":57,"context_line":"        \u0027\u0027\u0027Executes terraform init, terraform plan, and terraform apply\u0027\u0027\u0027"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        access_info \u003d vim_info.get(\u0027vim1\u0027, {}).get(\u0027accessInfo\u0027, {})"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        try:"},{"line_number":62,"context_line":"            # Execute the terraform init command"}],"source_content_type":"text/x-python","patch_set":29,"id":"c4524d9f_bec91bd0","line":59,"range":{"start_line":59,"start_character":36,"end_line":59,"end_character":40},"in_reply_to":"99c56058_7ecdc019","updated":"2023-09-15 07:10:10.000000000","message":"Ack","commit_id":"a8e311147e674bb038af15e418f8816f59802f38"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"4101581752c173781f2c8aa91d05225051fc4f5b","unresolved":true,"context_lines":[{"line_number":56,"context_line":"    def _instantiate(self, vim_info, working_dir, tf_var_path):"},{"line_number":57,"context_line":"        \u0027\u0027\u0027Executes terraform init, terraform plan, and terraform apply\u0027\u0027\u0027"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        access_info \u003d vim_info.get(\u0027vim1\u0027, {}).get(\u0027accessInfo\u0027, {})"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        try:"},{"line_number":62,"context_line":"            # Execute the terraform init command"}],"source_content_type":"text/x-python","patch_set":29,"id":"56bfe0b4_4ff43ea7","line":59,"range":{"start_line":59,"start_character":36,"end_line":59,"end_character":40},"in_reply_to":"c91a1c74_b5e4c77f","updated":"2023-09-14 06:13:55.000000000","message":"ping, I am concerned that you may have forgotten to respond to comments.","commit_id":"a8e311147e674bb038af15e418f8816f59802f38"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"10a2f14afb319fd79a10f18e28b1cc887f2d7fbf","unresolved":true,"context_lines":[{"line_number":56,"context_line":"    def _instantiate(self, vim_info, working_dir, tf_var_path):"},{"line_number":57,"context_line":"        \u0027\u0027\u0027Executes terraform init, terraform plan, and terraform apply\u0027\u0027\u0027"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        access_info \u003d vim_info.get(\u0027vim1\u0027, {}).get(\u0027accessInfo\u0027, {})"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        try:"},{"line_number":62,"context_line":"            # Execute the terraform init command"}],"source_content_type":"text/x-python","patch_set":29,"id":"890b43ec_e96d0ab5","line":59,"range":{"start_line":59,"start_character":36,"end_line":59,"end_character":40},"in_reply_to":"d6385113_f6d304a6","updated":"2023-09-14 08:36:39.000000000","message":"Thanks, roughly understand. I\u0027d like to check it.","commit_id":"a8e311147e674bb038af15e418f8816f59802f38"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"9bfc2e0c869d6b3d6405600fcb9efc5c75a40ed8","unresolved":true,"context_lines":[{"line_number":56,"context_line":"    def _instantiate(self, vim_info, working_dir, tf_var_path):"},{"line_number":57,"context_line":"        \u0027\u0027\u0027Executes terraform init, terraform plan, and terraform apply\u0027\u0027\u0027"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        access_info \u003d vim_info.get(\u0027vim1\u0027, {}).get(\u0027accessInfo\u0027, {})"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        try:"},{"line_number":62,"context_line":"            # Execute the terraform init command"}],"source_content_type":"text/x-python","patch_set":29,"id":"99c56058_7ecdc019","line":59,"range":{"start_line":59,"start_character":36,"end_line":59,"end_character":40},"in_reply_to":"eb7060f1_edb99906","updated":"2023-09-15 06:52:48.000000000","message":"fixed","commit_id":"a8e311147e674bb038af15e418f8816f59802f38"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"d2ea844bec3aebe2b0a5392b23898c6f787d8b6c","unresolved":true,"context_lines":[{"line_number":72,"context_line":"            LOG.info(\"Terraform plan completed successfully.\")"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"            # Execute the terraform apply command"},{"line_number":75,"context_line":"            apply_command \u003d self._generate_apply_command("},{"line_number":76,"context_line":"                access_info, tf_var_path)"},{"line_number":77,"context_line":"            subprocess.run(apply_command, cwd\u003dworking_dir,"},{"line_number":78,"context_line":"                           check\u003dTrue, text\u003dTrue)"},{"line_number":79,"context_line":"            LOG.info(\"Terraform apply completed successfully.\")"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        except subprocess.CalledProcessError as error:"}],"source_content_type":"text/x-python","patch_set":29,"id":"be345faa_d24c8e9e","line":78,"range":{"start_line":75,"start_character":0,"end_line":78,"end_character":49},"updated":"2023-09-12 05:00:37.000000000","message":"Just a confirmation.\nDoes the `terraform apply` command not require the wait process like other infraDrivers in particular, since all resources are successfully generated and returned response?","commit_id":"a8e311147e674bb038af15e418f8816f59802f38"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"8a6d3fc57f1fe8f1f45cbabbd4710aa5356cf50f","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            LOG.info(\"Terraform plan completed successfully.\")"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"            # Execute the terraform apply command"},{"line_number":75,"context_line":"            apply_command \u003d self._generate_apply_command("},{"line_number":76,"context_line":"                access_info, tf_var_path)"},{"line_number":77,"context_line":"            subprocess.run(apply_command, cwd\u003dworking_dir,"},{"line_number":78,"context_line":"                           check\u003dTrue, text\u003dTrue)"},{"line_number":79,"context_line":"            LOG.info(\"Terraform apply completed successfully.\")"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        except subprocess.CalledProcessError as error:"}],"source_content_type":"text/x-python","patch_set":29,"id":"b76cfab4_997209ab","line":78,"range":{"start_line":75,"start_character":0,"end_line":78,"end_character":49},"in_reply_to":"472bb229_8bc0c892","updated":"2023-09-15 07:10:10.000000000","message":"It remains to be seen if the response will be returned with the resource generation in progress, but since the FT is going well, I assume it is not a problem.\n\nThanks for good discussion. I’ve confirmed.","commit_id":"a8e311147e674bb038af15e418f8816f59802f38"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"01ec9582265e5ab4728a253a56e83f64c10fac00","unresolved":true,"context_lines":[{"line_number":72,"context_line":"            LOG.info(\"Terraform plan completed successfully.\")"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"            # Execute the terraform apply command"},{"line_number":75,"context_line":"            apply_command \u003d self._generate_apply_command("},{"line_number":76,"context_line":"                access_info, tf_var_path)"},{"line_number":77,"context_line":"            subprocess.run(apply_command, cwd\u003dworking_dir,"},{"line_number":78,"context_line":"                           check\u003dTrue, text\u003dTrue)"},{"line_number":79,"context_line":"            LOG.info(\"Terraform apply completed successfully.\")"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        except subprocess.CalledProcessError as error:"}],"source_content_type":"text/x-python","patch_set":29,"id":"9ec7d505_2273f38f","line":78,"range":{"start_line":75,"start_character":0,"end_line":78,"end_character":49},"in_reply_to":"9c70193c_269571f5","updated":"2023-09-13 13:50:12.000000000","message":"I\u0027m also not a guru of terraform actually, but your point might be worth considering in my opinion. Anyway, this series of calling terraform commands can be revised, so I\u0027d like to consider which we should do or not shortly. Thanks.","commit_id":"a8e311147e674bb038af15e418f8816f59802f38"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"10a2f14afb319fd79a10f18e28b1cc887f2d7fbf","unresolved":true,"context_lines":[{"line_number":72,"context_line":"            LOG.info(\"Terraform plan completed successfully.\")"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"            # Execute the terraform apply command"},{"line_number":75,"context_line":"            apply_command \u003d self._generate_apply_command("},{"line_number":76,"context_line":"                access_info, tf_var_path)"},{"line_number":77,"context_line":"            subprocess.run(apply_command, cwd\u003dworking_dir,"},{"line_number":78,"context_line":"                           check\u003dTrue, text\u003dTrue)"},{"line_number":79,"context_line":"            LOG.info(\"Terraform apply completed successfully.\")"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        except subprocess.CalledProcessError as error:"}],"source_content_type":"text/x-python","patch_set":29,"id":"472bb229_8bc0c892","line":78,"range":{"start_line":75,"start_character":0,"end_line":78,"end_character":49},"in_reply_to":"9ec7d505_2273f38f","updated":"2023-09-14 08:36:39.000000000","message":"Although any result from terraform command isn\u0027t used and no need to care failures for such a waiting timeout without a few exceptions already covered in this patch, I\u0027ve refactored around calling the commands a little including usage of subprocess to become easy maintained. Thanks.","commit_id":"a8e311147e674bb038af15e418f8816f59802f38"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"5c353e605d0253b5e695083306291676cb3a3e7e","unresolved":true,"context_lines":[{"line_number":72,"context_line":"            LOG.info(\"Terraform plan completed successfully.\")"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"            # Execute the terraform apply command"},{"line_number":75,"context_line":"            apply_command \u003d self._generate_apply_command("},{"line_number":76,"context_line":"                access_info, tf_var_path)"},{"line_number":77,"context_line":"            subprocess.run(apply_command, cwd\u003dworking_dir,"},{"line_number":78,"context_line":"                           check\u003dTrue, text\u003dTrue)"},{"line_number":79,"context_line":"            LOG.info(\"Terraform apply completed successfully.\")"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        except subprocess.CalledProcessError as error:"}],"source_content_type":"text/x-python","patch_set":29,"id":"e1011004_9d7e5368","line":78,"range":{"start_line":75,"start_character":0,"end_line":78,"end_character":49},"in_reply_to":"be345faa_d24c8e9e","updated":"2023-09-13 08:09:23.000000000","message":"Do you mean it\u0027s better to have stdout and stderr args, and check the result exactly as similar to other infra drivers in tacker repo?","commit_id":"a8e311147e674bb038af15e418f8816f59802f38"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"874c5b82ec901def8550557b966943853ae4284c","unresolved":true,"context_lines":[{"line_number":72,"context_line":"            LOG.info(\"Terraform plan completed successfully.\")"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"            # Execute the terraform apply command"},{"line_number":75,"context_line":"            apply_command \u003d self._generate_apply_command("},{"line_number":76,"context_line":"                access_info, tf_var_path)"},{"line_number":77,"context_line":"            subprocess.run(apply_command, cwd\u003dworking_dir,"},{"line_number":78,"context_line":"                           check\u003dTrue, text\u003dTrue)"},{"line_number":79,"context_line":"            LOG.info(\"Terraform apply completed successfully.\")"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        except subprocess.CalledProcessError as error:"}],"source_content_type":"text/x-python","patch_set":29,"id":"9c70193c_269571f5","line":78,"range":{"start_line":75,"start_character":0,"end_line":78,"end_character":49},"in_reply_to":"e1011004_9d7e5368","updated":"2023-09-13 09:40:33.000000000","message":"No, I don\u0027t think it\u0027s necessary if you know terraform infra-driver will get a response after all the commands are done.\nIf the response comes back without the resource being created completely, subsequent LCM operations able to be performed while the resource is being generated.\n\nIn my understanding, openstack(heat) and kubernetes are perceptions that require waiting because they continue to create and delete resources in the background after a response.\n\nWhat do you think?","commit_id":"a8e311147e674bb038af15e418f8816f59802f38"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"7bcf6cbc463ab65b3b815af53c4f97feac559f0a","unresolved":true,"context_lines":[{"line_number":92,"context_line":"    def _terminate(self, vim_info, working_dir, tf_var_path):"},{"line_number":93,"context_line":"        \u0027\u0027\u0027Executes Terraform Destroy and removes the working_dir\u0027\u0027\u0027"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        access_info \u003d vim_info.get(\u0027vim1\u0027, {}).get(\u0027accessInfo\u0027, {})"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        try:"},{"line_number":98,"context_line":"            # Execute the terraform destroy command (auto-approve)"}],"source_content_type":"text/x-python","patch_set":29,"id":"c167e4ad_2f5ca111","line":95,"range":{"start_line":95,"start_character":36,"end_line":95,"end_character":40},"updated":"2023-09-12 04:15:09.000000000","message":"Could you fix it to use `inst_utils.select_vim_info` instead of specifying it in `vim1`, like other infraDrivers [1].\n\n[1] https://opendev.org/openstack/tacker/src/branch/stable/2023.1/tacker/sol_refactored/infra_drivers/openstack/openstack.py#L98","commit_id":"a8e311147e674bb038af15e418f8816f59802f38"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"4101581752c173781f2c8aa91d05225051fc4f5b","unresolved":true,"context_lines":[{"line_number":92,"context_line":"    def _terminate(self, vim_info, working_dir, tf_var_path):"},{"line_number":93,"context_line":"        \u0027\u0027\u0027Executes Terraform Destroy and removes the working_dir\u0027\u0027\u0027"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        access_info \u003d vim_info.get(\u0027vim1\u0027, {}).get(\u0027accessInfo\u0027, {})"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        try:"},{"line_number":98,"context_line":"            # Execute the terraform destroy command (auto-approve)"}],"source_content_type":"text/x-python","patch_set":29,"id":"c9b74775_1d76a95e","line":95,"range":{"start_line":95,"start_character":36,"end_line":95,"end_character":40},"in_reply_to":"c167e4ad_2f5ca111","updated":"2023-09-14 06:13:55.000000000","message":"ping","commit_id":"a8e311147e674bb038af15e418f8816f59802f38"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"8a6d3fc57f1fe8f1f45cbabbd4710aa5356cf50f","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    def _terminate(self, vim_info, working_dir, tf_var_path):"},{"line_number":93,"context_line":"        \u0027\u0027\u0027Executes Terraform Destroy and removes the working_dir\u0027\u0027\u0027"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        access_info \u003d vim_info.get(\u0027vim1\u0027, {}).get(\u0027accessInfo\u0027, {})"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        try:"},{"line_number":98,"context_line":"            # Execute the terraform destroy command (auto-approve)"}],"source_content_type":"text/x-python","patch_set":29,"id":"e0eddcf7_ac2bf1ee","line":95,"range":{"start_line":95,"start_character":36,"end_line":95,"end_character":40},"in_reply_to":"c9b74775_1d76a95e","updated":"2023-09-15 07:10:10.000000000","message":"Ack","commit_id":"a8e311147e674bb038af15e418f8816f59802f38"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"d2ea844bec3aebe2b0a5392b23898c6f787d8b6c","unresolved":true,"context_lines":[{"line_number":97,"context_line":"        try:"},{"line_number":98,"context_line":"            # Execute the terraform destroy command (auto-approve)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"            destroy_command \u003d self._generate_destroy_command("},{"line_number":101,"context_line":"                access_info, tf_var_path)"},{"line_number":102,"context_line":"            subprocess.run(destroy_command, cwd\u003dworking_dir,"},{"line_number":103,"context_line":"                           check\u003dTrue, text\u003dTrue)"},{"line_number":104,"context_line":"            LOG.info(\"Terraform destroy completed successfully.\")"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        except subprocess.CalledProcessError as error:"}],"source_content_type":"text/x-python","patch_set":29,"id":"cadbc4b7_c2f5dcf8","line":103,"range":{"start_line":100,"start_character":0,"end_line":103,"end_character":49},"updated":"2023-09-12 05:00:37.000000000","message":"Just a confirmation.\nDoes the `terraform destroy` command not require the wait process like other infraDrivers in particular, since all resources are successfully removed and returned response?","commit_id":"a8e311147e674bb038af15e418f8816f59802f38"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"8a6d3fc57f1fe8f1f45cbabbd4710aa5356cf50f","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        try:"},{"line_number":98,"context_line":"            # Execute the terraform destroy command (auto-approve)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"            destroy_command \u003d self._generate_destroy_command("},{"line_number":101,"context_line":"                access_info, tf_var_path)"},{"line_number":102,"context_line":"            subprocess.run(destroy_command, cwd\u003dworking_dir,"},{"line_number":103,"context_line":"                           check\u003dTrue, text\u003dTrue)"},{"line_number":104,"context_line":"            LOG.info(\"Terraform destroy completed successfully.\")"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        except subprocess.CalledProcessError as error:"}],"source_content_type":"text/x-python","patch_set":29,"id":"404353f1_8ec97497","line":103,"range":{"start_line":100,"start_character":0,"end_line":103,"end_character":49},"in_reply_to":"cadbc4b7_c2f5dcf8","updated":"2023-09-15 07:10:10.000000000","message":"Ack","commit_id":"a8e311147e674bb038af15e418f8816f59802f38"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"7bcf6cbc463ab65b3b815af53c4f97feac559f0a","unresolved":true,"context_lines":[{"line_number":107,"context_line":"            failed_process \u003d error.cmd[0].capitalize()"},{"line_number":108,"context_line":"            LOG.error(f\"Error running {failed_process}: {error}\")"},{"line_number":109,"context_line":"            # raise error and leave working_dir for retry"},{"line_number":110,"context_line":"            raise"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        try:"},{"line_number":113,"context_line":"            # Remove the working directory and its contents"}],"source_content_type":"text/x-python","patch_set":29,"id":"b29d43cb_2e894cff","line":110,"range":{"start_line":110,"start_character":12,"end_line":110,"end_character":17},"updated":"2023-09-12 04:15:09.000000000","message":"Why don\u0027t you use `sol_ex.TerraformOperationFailed`?","commit_id":"a8e311147e674bb038af15e418f8816f59802f38"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"25c1847e8157162fa6c98ed19dd202734ea6e898","unresolved":false,"context_lines":[{"line_number":107,"context_line":"            failed_process \u003d error.cmd[0].capitalize()"},{"line_number":108,"context_line":"            LOG.error(f\"Error running {failed_process}: {error}\")"},{"line_number":109,"context_line":"            # raise error and leave working_dir for retry"},{"line_number":110,"context_line":"            raise"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        try:"},{"line_number":113,"context_line":"            # Remove the working directory and its contents"}],"source_content_type":"text/x-python","patch_set":29,"id":"a643ddff_01d59c62","line":110,"range":{"start_line":110,"start_character":12,"end_line":110,"end_character":17},"in_reply_to":"0222daa2_48daf787","updated":"2023-09-15 12:19:22.000000000","message":"Done","commit_id":"a8e311147e674bb038af15e418f8816f59802f38"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"7ca5aac8c732898f09d2221eba5eb37e5ab2f191","unresolved":true,"context_lines":[{"line_number":107,"context_line":"            failed_process \u003d error.cmd[0].capitalize()"},{"line_number":108,"context_line":"            LOG.error(f\"Error running {failed_process}: {error}\")"},{"line_number":109,"context_line":"            # raise error and leave working_dir for retry"},{"line_number":110,"context_line":"            raise"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        try:"},{"line_number":113,"context_line":"            # Remove the working directory and its contents"}],"source_content_type":"text/x-python","patch_set":29,"id":"92148faf_68671439","line":110,"range":{"start_line":110,"start_character":12,"end_line":110,"end_character":17},"in_reply_to":"53f6ae37_53b3cbed","updated":"2023-09-15 08:19:21.000000000","message":"Oops, I revised.","commit_id":"a8e311147e674bb038af15e418f8816f59802f38"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"887435e42c2892dc424e9cfb3c01648aef034d03","unresolved":true,"context_lines":[{"line_number":107,"context_line":"            failed_process \u003d error.cmd[0].capitalize()"},{"line_number":108,"context_line":"            LOG.error(f\"Error running {failed_process}: {error}\")"},{"line_number":109,"context_line":"            # raise error and leave working_dir for retry"},{"line_number":110,"context_line":"            raise"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        try:"},{"line_number":113,"context_line":"            # Remove the working directory and its contents"}],"source_content_type":"text/x-python","patch_set":29,"id":"d6b89ced_4ffa9524","line":110,"range":{"start_line":110,"start_character":12,"end_line":110,"end_character":17},"in_reply_to":"6d62e134_3e23ee81","updated":"2023-09-15 11:15:22.000000000","message":"Sorry to keep repeating myself, but did you check this comment?","commit_id":"a8e311147e674bb038af15e418f8816f59802f38"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"2edc4efe8a3bb74f5f36baa6d94b6e342a4aaa90","unresolved":true,"context_lines":[{"line_number":107,"context_line":"            failed_process \u003d error.cmd[0].capitalize()"},{"line_number":108,"context_line":"            LOG.error(f\"Error running {failed_process}: {error}\")"},{"line_number":109,"context_line":"            # raise error and leave working_dir for retry"},{"line_number":110,"context_line":"            raise"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        try:"},{"line_number":113,"context_line":"            # Remove the working directory and its contents"}],"source_content_type":"text/x-python","patch_set":29,"id":"0222daa2_48daf787","line":110,"range":{"start_line":110,"start_character":12,"end_line":110,"end_character":17},"in_reply_to":"6eabacaa_e38d4816","updated":"2023-09-15 11:45:35.000000000","message":"Sorry, I confused you because I had listed it in the Line number.\nYes, it is OK to change just return back `raise` for `rmtree`.\nBut for `destroy command`, I think it should be `sol_ex.TerraformOperationFailed`.\n\nI will comment again on the relevant section.","commit_id":"a8e311147e674bb038af15e418f8816f59802f38"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"106473e8b3b39c4a5ecc91b6345b3eeee95398ed","unresolved":true,"context_lines":[{"line_number":107,"context_line":"            failed_process \u003d error.cmd[0].capitalize()"},{"line_number":108,"context_line":"            LOG.error(f\"Error running {failed_process}: {error}\")"},{"line_number":109,"context_line":"            # raise error and leave working_dir for retry"},{"line_number":110,"context_line":"            raise"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        try:"},{"line_number":113,"context_line":"            # Remove the working directory and its contents"}],"source_content_type":"text/x-python","patch_set":29,"id":"6d62e134_3e23ee81","line":110,"range":{"start_line":110,"start_character":12,"end_line":110,"end_character":17},"in_reply_to":"92148faf_68671439","updated":"2023-09-15 09:54:32.000000000","message":"Sorry, it seems that you have modified another line.\nAdding the specific exception to Line110 is fine, but I feel that `TerraformOperationFailed` is inappropriate since it fails to delete the directory.\nWhat do you think?","commit_id":"a8e311147e674bb038af15e418f8816f59802f38"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"4101581752c173781f2c8aa91d05225051fc4f5b","unresolved":true,"context_lines":[{"line_number":107,"context_line":"            failed_process \u003d error.cmd[0].capitalize()"},{"line_number":108,"context_line":"            LOG.error(f\"Error running {failed_process}: {error}\")"},{"line_number":109,"context_line":"            # raise error and leave working_dir for retry"},{"line_number":110,"context_line":"            raise"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        try:"},{"line_number":113,"context_line":"            # Remove the working directory and its contents"}],"source_content_type":"text/x-python","patch_set":29,"id":"ee53a4b3_180fbf62","line":110,"range":{"start_line":110,"start_character":12,"end_line":110,"end_character":17},"in_reply_to":"b29d43cb_2e894cff","updated":"2023-09-14 06:13:55.000000000","message":"ping","commit_id":"a8e311147e674bb038af15e418f8816f59802f38"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"de88aa30f32db2d47cda0b1e3c082ec38328c6b7","unresolved":true,"context_lines":[{"line_number":107,"context_line":"            failed_process \u003d error.cmd[0].capitalize()"},{"line_number":108,"context_line":"            LOG.error(f\"Error running {failed_process}: {error}\")"},{"line_number":109,"context_line":"            # raise error and leave working_dir for retry"},{"line_number":110,"context_line":"            raise"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        try:"},{"line_number":113,"context_line":"            # Remove the working directory and its contents"}],"source_content_type":"text/x-python","patch_set":29,"id":"6eabacaa_e38d4816","line":110,"range":{"start_line":110,"start_character":12,"end_line":110,"end_character":17},"in_reply_to":"d6b89ced_4ffa9524","updated":"2023-09-15 11:34:36.000000000","message":"Do you mean it should be returned back to just `raise`? It\u0027s OK.","commit_id":"a8e311147e674bb038af15e418f8816f59802f38"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"8a6d3fc57f1fe8f1f45cbabbd4710aa5356cf50f","unresolved":true,"context_lines":[{"line_number":107,"context_line":"            failed_process \u003d error.cmd[0].capitalize()"},{"line_number":108,"context_line":"            LOG.error(f\"Error running {failed_process}: {error}\")"},{"line_number":109,"context_line":"            # raise error and leave working_dir for retry"},{"line_number":110,"context_line":"            raise"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        try:"},{"line_number":113,"context_line":"            # Remove the working directory and its contents"}],"source_content_type":"text/x-python","patch_set":29,"id":"53f6ae37_53b3cbed","line":110,"range":{"start_line":110,"start_character":12,"end_line":110,"end_character":17},"in_reply_to":"ee53a4b3_180fbf62","updated":"2023-09-15 07:10:10.000000000","message":"Is no fixing necessary for this comment?","commit_id":"a8e311147e674bb038af15e418f8816f59802f38"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"d2ea844bec3aebe2b0a5392b23898c6f787d8b6c","unresolved":true,"context_lines":[{"line_number":179,"context_line":"        inst.instantiatedVnfInfo.vnfcInfo \u003d vnfc_info_list"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    def _replicate_tf_files(self, vnf_instance_id, vnfd_id, tf_dir_path):"},{"line_number":182,"context_line":"        \u0027\u0027\u0027Moves the vnf package\u0027\u0027\u0027"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        # Define variables"},{"line_number":185,"context_line":"        context \u003d tacker.context.get_admin_context()"}],"source_content_type":"text/x-python","patch_set":29,"id":"1b2fed91_c2c89cd9","line":182,"range":{"start_line":182,"start_character":11,"end_line":182,"end_character":32},"updated":"2023-09-12 05:00:37.000000000","message":"Is the description of this docstring correct? It looks like creating directory for terraform and copying vnf package into the directory in the process.\nIs my understanding correct?","commit_id":"a8e311147e674bb038af15e418f8816f59802f38"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"5c353e605d0253b5e695083306291676cb3a3e7e","unresolved":true,"context_lines":[{"line_number":179,"context_line":"        inst.instantiatedVnfInfo.vnfcInfo \u003d vnfc_info_list"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    def _replicate_tf_files(self, vnf_instance_id, vnfd_id, tf_dir_path):"},{"line_number":182,"context_line":"        \u0027\u0027\u0027Moves the vnf package\u0027\u0027\u0027"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        # Define variables"},{"line_number":185,"context_line":"        context \u003d tacker.context.get_admin_context()"}],"source_content_type":"text/x-python","patch_set":29,"id":"da40ded1_73406d29","line":182,"range":{"start_line":182,"start_character":11,"end_line":182,"end_character":32},"in_reply_to":"1b2fed91_c2c89cd9","updated":"2023-09-13 08:09:23.000000000","message":"I\u0027ve revised also the name of function because the term \"replicate\" explains the internal behavior of this function and useless as a part of func name. What\u0027s expected from by developers is just explain that this function creates a new package with given args and return the path of the created package. So, I think \"_get_tf_vnfpkg\" is enough for the name. Thanks.","commit_id":"a8e311147e674bb038af15e418f8816f59802f38"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"874c5b82ec901def8550557b966943853ae4284c","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        inst.instantiatedVnfInfo.vnfcInfo \u003d vnfc_info_list"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    def _replicate_tf_files(self, vnf_instance_id, vnfd_id, tf_dir_path):"},{"line_number":182,"context_line":"        \u0027\u0027\u0027Moves the vnf package\u0027\u0027\u0027"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        # Define variables"},{"line_number":185,"context_line":"        context \u003d tacker.context.get_admin_context()"}],"source_content_type":"text/x-python","patch_set":29,"id":"a21eb3fa_808606d2","line":182,"range":{"start_line":182,"start_character":11,"end_line":182,"end_character":32},"in_reply_to":"da40ded1_73406d29","updated":"2023-09-13 09:40:33.000000000","message":"Thanks for your revising, I think it looks better.","commit_id":"a8e311147e674bb038af15e418f8816f59802f38"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"d2ea844bec3aebe2b0a5392b23898c6f787d8b6c","unresolved":true,"context_lines":[{"line_number":189,"context_line":"        except exceptions.VnfPackageVnfdNotFound as exc:"},{"line_number":190,"context_line":"            raise sol_ex.VnfdIdNotFound(vnfd_id\u003dvnfd_id) from exc"},{"line_number":191,"context_line":"        csar_path \u003d os.path.join(CONF.vnf_package.vnf_package_csar_path,"},{"line_number":192,"context_line":"                                pkg_vnfd.package_uuid)"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"        # Assemble paths and copy recursively"},{"line_number":195,"context_line":"        vnf_package_path \u003d f\"{csar_path}/{tf_dir_path}\""}],"source_content_type":"text/x-python","patch_set":29,"id":"8cf1500b_7f851a32","line":192,"range":{"start_line":192,"start_character":31,"end_line":192,"end_character":32},"updated":"2023-09-12 05:00:37.000000000","message":"nit: Could you add a space character to match the indentation?","commit_id":"a8e311147e674bb038af15e418f8816f59802f38"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"5c353e605d0253b5e695083306291676cb3a3e7e","unresolved":true,"context_lines":[{"line_number":189,"context_line":"        except exceptions.VnfPackageVnfdNotFound as exc:"},{"line_number":190,"context_line":"            raise sol_ex.VnfdIdNotFound(vnfd_id\u003dvnfd_id) from exc"},{"line_number":191,"context_line":"        csar_path \u003d os.path.join(CONF.vnf_package.vnf_package_csar_path,"},{"line_number":192,"context_line":"                                pkg_vnfd.package_uuid)"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"        # Assemble paths and copy recursively"},{"line_number":195,"context_line":"        vnf_package_path \u003d f\"{csar_path}/{tf_dir_path}\""}],"source_content_type":"text/x-python","patch_set":29,"id":"a5abf3a0_bf07144c","line":192,"range":{"start_line":192,"start_character":31,"end_line":192,"end_character":32},"in_reply_to":"8cf1500b_7f851a32","updated":"2023-09-13 08:09:23.000000000","message":"fixed","commit_id":"a8e311147e674bb038af15e418f8816f59802f38"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"874c5b82ec901def8550557b966943853ae4284c","unresolved":false,"context_lines":[{"line_number":189,"context_line":"        except exceptions.VnfPackageVnfdNotFound as exc:"},{"line_number":190,"context_line":"            raise sol_ex.VnfdIdNotFound(vnfd_id\u003dvnfd_id) from exc"},{"line_number":191,"context_line":"        csar_path \u003d os.path.join(CONF.vnf_package.vnf_package_csar_path,"},{"line_number":192,"context_line":"                                pkg_vnfd.package_uuid)"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"        # Assemble paths and copy recursively"},{"line_number":195,"context_line":"        vnf_package_path \u003d f\"{csar_path}/{tf_dir_path}\""}],"source_content_type":"text/x-python","patch_set":29,"id":"831fd0bf_ca17b559","line":192,"range":{"start_line":192,"start_character":31,"end_line":192,"end_character":32},"in_reply_to":"a5abf3a0_bf07144c","updated":"2023-09-13 09:40:33.000000000","message":"Ack","commit_id":"a8e311147e674bb038af15e418f8816f59802f38"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"7bcf6cbc463ab65b3b815af53c4f97feac559f0a","unresolved":true,"context_lines":[{"line_number":205,"context_line":"        \u0027\u0027\u0027Creates provider.tf beside main.tf\u0027\u0027\u0027"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        # Read vimConnectionInfo for information"},{"line_number":208,"context_line":"        vim_info \u003d vim_connection_info.get(\u0027vim1\u0027, {})"},{"line_number":209,"context_line":"        interface_info \u003d vim_info.get(\u0027interfaceInfo\u0027, {})"},{"line_number":210,"context_line":"        provider_type \u003d interface_info.get(\u0027providerType\u0027)"},{"line_number":211,"context_line":"        provider_version \u003d interface_info.get(\u0027providerVersion\u0027)"}],"source_content_type":"text/x-python","patch_set":29,"id":"a7ccca22_bc8e3862","line":208,"range":{"start_line":208,"start_character":44,"end_line":208,"end_character":48},"updated":"2023-09-12 04:15:09.000000000","message":"Could you fix it to use `inst_utils.select_vim_info` instead of specifying it in `vim1`, like other infraDrivers [1].\n\n[1] https://opendev.org/openstack/tacker/src/branch/stable/2023.1/tacker/sol_refactored/infra_drivers/openstack/openstack.py#L98","commit_id":"a8e311147e674bb038af15e418f8816f59802f38"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"8a6d3fc57f1fe8f1f45cbabbd4710aa5356cf50f","unresolved":false,"context_lines":[{"line_number":205,"context_line":"        \u0027\u0027\u0027Creates provider.tf beside main.tf\u0027\u0027\u0027"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        # Read vimConnectionInfo for information"},{"line_number":208,"context_line":"        vim_info \u003d vim_connection_info.get(\u0027vim1\u0027, {})"},{"line_number":209,"context_line":"        interface_info \u003d vim_info.get(\u0027interfaceInfo\u0027, {})"},{"line_number":210,"context_line":"        provider_type \u003d interface_info.get(\u0027providerType\u0027)"},{"line_number":211,"context_line":"        provider_version \u003d interface_info.get(\u0027providerVersion\u0027)"}],"source_content_type":"text/x-python","patch_set":29,"id":"e24e30dc_adb1e286","line":208,"range":{"start_line":208,"start_character":44,"end_line":208,"end_character":48},"in_reply_to":"01891d8d_80c14c91","updated":"2023-09-15 07:10:10.000000000","message":"Ack","commit_id":"a8e311147e674bb038af15e418f8816f59802f38"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"4101581752c173781f2c8aa91d05225051fc4f5b","unresolved":true,"context_lines":[{"line_number":205,"context_line":"        \u0027\u0027\u0027Creates provider.tf beside main.tf\u0027\u0027\u0027"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        # Read vimConnectionInfo for information"},{"line_number":208,"context_line":"        vim_info \u003d vim_connection_info.get(\u0027vim1\u0027, {})"},{"line_number":209,"context_line":"        interface_info \u003d vim_info.get(\u0027interfaceInfo\u0027, {})"},{"line_number":210,"context_line":"        provider_type \u003d interface_info.get(\u0027providerType\u0027)"},{"line_number":211,"context_line":"        provider_version \u003d interface_info.get(\u0027providerVersion\u0027)"}],"source_content_type":"text/x-python","patch_set":29,"id":"01891d8d_80c14c91","line":208,"range":{"start_line":208,"start_character":44,"end_line":208,"end_character":48},"in_reply_to":"a7ccca22_bc8e3862","updated":"2023-09-14 06:13:55.000000000","message":"ping","commit_id":"a8e311147e674bb038af15e418f8816f59802f38"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"5ebdc9211765681c357a65456bb41aeef8d9ae9d","unresolved":true,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        try:"},{"line_number":98,"context_line":"            # Execute the terraform destroy command (auto-approve)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"            destroy_command \u003d self._generate_destroy_command("},{"line_number":101,"context_line":"                access_info, tf_var_path)"},{"line_number":102,"context_line":"            subprocess.run(destroy_command, cwd\u003dworking_dir,"}],"source_content_type":"text/x-python","patch_set":31,"id":"f9e25d8e_b61d8a36","line":99,"updated":"2023-09-11 12:55:34.000000000","message":"Could you delete unnecessary blank line?","commit_id":"da137f3b34c0a5b424788f7aec61ce20eb2d9245"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"14ea7e3763a747d894b3efe2ee77950c685cfeac","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        try:"},{"line_number":98,"context_line":"            # Execute the terraform destroy command (auto-approve)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"            destroy_command \u003d self._generate_destroy_command("},{"line_number":101,"context_line":"                access_info, tf_var_path)"},{"line_number":102,"context_line":"            subprocess.run(destroy_command, cwd\u003dworking_dir,"}],"source_content_type":"text/x-python","patch_set":31,"id":"6d09c225_fe3c5f7e","line":99,"in_reply_to":"bcc54247_0c890f81","updated":"2023-09-12 22:00:07.000000000","message":"Ack","commit_id":"da137f3b34c0a5b424788f7aec61ce20eb2d9245"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"f48cc904424282ccfafba382416a4ac01182ed84","unresolved":true,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        try:"},{"line_number":98,"context_line":"            # Execute the terraform destroy command (auto-approve)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"            destroy_command \u003d self._generate_destroy_command("},{"line_number":101,"context_line":"                access_info, tf_var_path)"},{"line_number":102,"context_line":"            subprocess.run(destroy_command, cwd\u003dworking_dir,"}],"source_content_type":"text/x-python","patch_set":31,"id":"bcc54247_0c890f81","line":99,"in_reply_to":"f9e25d8e_b61d8a36","updated":"2023-09-12 15:22:41.000000000","message":"fixed","commit_id":"da137f3b34c0a5b424788f7aec61ce20eb2d9245"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"5ebdc9211765681c357a65456bb41aeef8d9ae9d","unresolved":true,"context_lines":[{"line_number":150,"context_line":"        resources \u003d tfstate_data[\"resources\"]"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        # Define vnfcResourceInfo and vnfcInfo in a single iteration"},{"line_number":153,"context_line":"        vnfc_resource_info_list \u003d ["},{"line_number":154,"context_line":"            objects.VnfcResourceInfoV2("},{"line_number":155,"context_line":"                id\u003dresource[\u0027name\u0027],"},{"line_number":156,"context_line":"                vduId\u003dvdu_ids.get(resource[\u0027name\u0027]),"}],"source_content_type":"text/x-python","patch_set":31,"id":"81449269_23e527af","line":153,"range":{"start_line":153,"start_character":8,"end_line":153,"end_character":31},"updated":"2023-09-11 12:55:34.000000000","message":"Could you change to `vnfc_resource_infos`?","commit_id":"da137f3b34c0a5b424788f7aec61ce20eb2d9245"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"b1528a590b2134cc6b55575c0573cbecfa347644","unresolved":true,"context_lines":[{"line_number":150,"context_line":"        resources \u003d tfstate_data[\"resources\"]"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        # Define vnfcResourceInfo and vnfcInfo in a single iteration"},{"line_number":153,"context_line":"        vnfc_resource_info_list \u003d ["},{"line_number":154,"context_line":"            objects.VnfcResourceInfoV2("},{"line_number":155,"context_line":"                id\u003dresource[\u0027name\u0027],"},{"line_number":156,"context_line":"                vduId\u003dvdu_ids.get(resource[\u0027name\u0027]),"}],"source_content_type":"text/x-python","patch_set":31,"id":"e369d8ff_1a8cebf1","line":153,"range":{"start_line":153,"start_character":8,"end_line":153,"end_character":31},"in_reply_to":"091dfd14_66ebdd08","updated":"2023-09-13 02:53:10.000000000","message":"My point is just \"info\" or \"information\" cannot be plural form with \"s\".","commit_id":"da137f3b34c0a5b424788f7aec61ce20eb2d9245"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"f48cc904424282ccfafba382416a4ac01182ed84","unresolved":true,"context_lines":[{"line_number":150,"context_line":"        resources \u003d tfstate_data[\"resources\"]"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        # Define vnfcResourceInfo and vnfcInfo in a single iteration"},{"line_number":153,"context_line":"        vnfc_resource_info_list \u003d ["},{"line_number":154,"context_line":"            objects.VnfcResourceInfoV2("},{"line_number":155,"context_line":"                id\u003dresource[\u0027name\u0027],"},{"line_number":156,"context_line":"                vduId\u003dvdu_ids.get(resource[\u0027name\u0027]),"}],"source_content_type":"text/x-python","patch_set":31,"id":"d6aceff8_f199b49d","line":153,"range":{"start_line":153,"start_character":8,"end_line":153,"end_character":31},"in_reply_to":"81449269_23e527af","updated":"2023-09-12 15:22:41.000000000","message":"Someone introduced var\u0027s name \"...infos\", but it\u0027s not correct in grammar;) So, It is OK for me. What do you think?","commit_id":"da137f3b34c0a5b424788f7aec61ce20eb2d9245"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"14ea7e3763a747d894b3efe2ee77950c685cfeac","unresolved":true,"context_lines":[{"line_number":150,"context_line":"        resources \u003d tfstate_data[\"resources\"]"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        # Define vnfcResourceInfo and vnfcInfo in a single iteration"},{"line_number":153,"context_line":"        vnfc_resource_info_list \u003d ["},{"line_number":154,"context_line":"            objects.VnfcResourceInfoV2("},{"line_number":155,"context_line":"                id\u003dresource[\u0027name\u0027],"},{"line_number":156,"context_line":"                vduId\u003dvdu_ids.get(resource[\u0027name\u0027]),"}],"source_content_type":"text/x-python","patch_set":31,"id":"091dfd14_66ebdd08","line":153,"range":{"start_line":153,"start_character":8,"end_line":153,"end_character":31},"in_reply_to":"d6aceff8_f199b49d","updated":"2023-09-12 22:00:07.000000000","message":"Someone once pointed out that the naming convention of giving type names to variables (so-called Hungarian notation) is not recommended generally [1].\n\nDoes that mean that the point is not correct?\n\n[1] https://learn.microsoft.com/en-us/dotnet/standard/design-guidelines/general-naming-conventions#word-choice","commit_id":"da137f3b34c0a5b424788f7aec61ce20eb2d9245"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"874c5b82ec901def8550557b966943853ae4284c","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        resources \u003d tfstate_data[\"resources\"]"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        # Define vnfcResourceInfo and vnfcInfo in a single iteration"},{"line_number":153,"context_line":"        vnfc_resource_info_list \u003d ["},{"line_number":154,"context_line":"            objects.VnfcResourceInfoV2("},{"line_number":155,"context_line":"                id\u003dresource[\u0027name\u0027],"},{"line_number":156,"context_line":"                vduId\u003dvdu_ids.get(resource[\u0027name\u0027]),"}],"source_content_type":"text/x-python","patch_set":31,"id":"08bed968_0ddfbea1","line":153,"range":{"start_line":153,"start_character":8,"end_line":153,"end_character":31},"in_reply_to":"e369d8ff_1a8cebf1","updated":"2023-09-13 09:40:33.000000000","message":"I got you point, information is uncountable nouns.\nIt\u0027s okay as it is.","commit_id":"da137f3b34c0a5b424788f7aec61ce20eb2d9245"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"5ebdc9211765681c357a65456bb41aeef8d9ae9d","unresolved":true,"context_lines":[{"line_number":165,"context_line":"                vdu_ids.get(resource[\u0027name\u0027]))"},{"line_number":166,"context_line":"        ]"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        vnfc_info_list \u003d ["},{"line_number":169,"context_line":"            objects.VnfcInfoV2("},{"line_number":170,"context_line":"                id\u003df\"{vnfc_res_info.vduId}-{vnfc_res_info.id}\","},{"line_number":171,"context_line":"                vduId\u003dvnfc_res_info.vduId,"}],"source_content_type":"text/x-python","patch_set":31,"id":"c9c91356_948ace30","line":168,"range":{"start_line":168,"start_character":8,"end_line":168,"end_character":22},"updated":"2023-09-11 12:55:34.000000000","message":"Could you change to `vnfc_infos`?","commit_id":"da137f3b34c0a5b424788f7aec61ce20eb2d9245"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"874c5b82ec901def8550557b966943853ae4284c","unresolved":false,"context_lines":[{"line_number":165,"context_line":"                vdu_ids.get(resource[\u0027name\u0027]))"},{"line_number":166,"context_line":"        ]"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        vnfc_info_list \u003d ["},{"line_number":169,"context_line":"            objects.VnfcInfoV2("},{"line_number":170,"context_line":"                id\u003df\"{vnfc_res_info.vduId}-{vnfc_res_info.id}\","},{"line_number":171,"context_line":"                vduId\u003dvnfc_res_info.vduId,"}],"source_content_type":"text/x-python","patch_set":31,"id":"7b643134_05fa86c6","line":168,"range":{"start_line":168,"start_character":8,"end_line":168,"end_character":22},"in_reply_to":"6c15fe68_1c989c58","updated":"2023-09-13 09:40:33.000000000","message":"Done","commit_id":"da137f3b34c0a5b424788f7aec61ce20eb2d9245"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"f48cc904424282ccfafba382416a4ac01182ed84","unresolved":true,"context_lines":[{"line_number":165,"context_line":"                vdu_ids.get(resource[\u0027name\u0027]))"},{"line_number":166,"context_line":"        ]"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        vnfc_info_list \u003d ["},{"line_number":169,"context_line":"            objects.VnfcInfoV2("},{"line_number":170,"context_line":"                id\u003df\"{vnfc_res_info.vduId}-{vnfc_res_info.id}\","},{"line_number":171,"context_line":"                vduId\u003dvnfc_res_info.vduId,"}],"source_content_type":"text/x-python","patch_set":31,"id":"6c15fe68_1c989c58","line":168,"range":{"start_line":168,"start_character":8,"end_line":168,"end_character":22},"in_reply_to":"c9c91356_948ace30","updated":"2023-09-12 15:22:41.000000000","message":"ditto","commit_id":"da137f3b34c0a5b424788f7aec61ce20eb2d9245"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"8a6d3fc57f1fe8f1f45cbabbd4710aa5356cf50f","unresolved":true,"context_lines":[{"line_number":201,"context_line":""},{"line_number":202,"context_line":"        # Read vimConnectionInfo for information"},{"line_number":203,"context_line":"        access_info \u003d vim_conn_info.get(\u0027accessInfo\u0027, {})"},{"line_number":204,"context_line":"        interface_info \u003d access_info.get(\u0027interfaceInfo\u0027, {})"},{"line_number":205,"context_line":"        provider_type \u003d interface_info.get(\u0027providerType\u0027)"},{"line_number":206,"context_line":"        provider_version \u003d interface_info.get(\u0027providerVersion\u0027)"},{"line_number":207,"context_line":"        access_info \u003d access_info.get(\u0027accessInfo\u0027, {})"}],"source_content_type":"text/x-python","patch_set":37,"id":"9db8d3f3_785124b7","line":204,"range":{"start_line":204,"start_character":25,"end_line":204,"end_character":36},"updated":"2023-09-15 07:10:10.000000000","message":"`interfaceInfo` is the attribute under `vim_conn_info`.\nSo please revise to the following:\n```\ninterface_info \u003d vim_conn_info.get(\u0027interfaceInfo\u0027, {})\n```","commit_id":"22a2cd9ed8a01b0dbfa0ca020ac574a433e44e48"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"7ca5aac8c732898f09d2221eba5eb37e5ab2f191","unresolved":true,"context_lines":[{"line_number":201,"context_line":""},{"line_number":202,"context_line":"        # Read vimConnectionInfo for information"},{"line_number":203,"context_line":"        access_info \u003d vim_conn_info.get(\u0027accessInfo\u0027, {})"},{"line_number":204,"context_line":"        interface_info \u003d access_info.get(\u0027interfaceInfo\u0027, {})"},{"line_number":205,"context_line":"        provider_type \u003d interface_info.get(\u0027providerType\u0027)"},{"line_number":206,"context_line":"        provider_version \u003d interface_info.get(\u0027providerVersion\u0027)"},{"line_number":207,"context_line":"        access_info \u003d access_info.get(\u0027accessInfo\u0027, {})"}],"source_content_type":"text/x-python","patch_set":37,"id":"bcd8bab7_08c04080","line":204,"range":{"start_line":204,"start_character":25,"end_line":204,"end_character":36},"in_reply_to":"9db8d3f3_785124b7","updated":"2023-09-15 08:19:21.000000000","message":"fixed","commit_id":"22a2cd9ed8a01b0dbfa0ca020ac574a433e44e48"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"106473e8b3b39c4a5ecc91b6345b3eeee95398ed","unresolved":false,"context_lines":[{"line_number":201,"context_line":""},{"line_number":202,"context_line":"        # Read vimConnectionInfo for information"},{"line_number":203,"context_line":"        access_info \u003d vim_conn_info.get(\u0027accessInfo\u0027, {})"},{"line_number":204,"context_line":"        interface_info \u003d access_info.get(\u0027interfaceInfo\u0027, {})"},{"line_number":205,"context_line":"        provider_type \u003d interface_info.get(\u0027providerType\u0027)"},{"line_number":206,"context_line":"        provider_version \u003d interface_info.get(\u0027providerVersion\u0027)"},{"line_number":207,"context_line":"        access_info \u003d access_info.get(\u0027accessInfo\u0027, {})"}],"source_content_type":"text/x-python","patch_set":37,"id":"915d4a57_8b355c0b","line":204,"range":{"start_line":204,"start_character":25,"end_line":204,"end_character":36},"in_reply_to":"bcd8bab7_08c04080","updated":"2023-09-15 09:54:32.000000000","message":"Ack","commit_id":"22a2cd9ed8a01b0dbfa0ca020ac574a433e44e48"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"8a6d3fc57f1fe8f1f45cbabbd4710aa5356cf50f","unresolved":true,"context_lines":[{"line_number":204,"context_line":"        interface_info \u003d access_info.get(\u0027interfaceInfo\u0027, {})"},{"line_number":205,"context_line":"        provider_type \u003d interface_info.get(\u0027providerType\u0027)"},{"line_number":206,"context_line":"        provider_version \u003d interface_info.get(\u0027providerVersion\u0027)"},{"line_number":207,"context_line":"        access_info \u003d access_info.get(\u0027accessInfo\u0027, {})"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"        # Create provider.tf content using the above information"},{"line_number":210,"context_line":"        content \u003d {"}],"source_content_type":"text/x-python","patch_set":37,"id":"0f54fa49_301fa5a0","line":207,"range":{"start_line":207,"start_character":8,"end_line":207,"end_character":55},"updated":"2023-09-15 07:10:10.000000000","message":"This line is unnecessary because `access_info` has already been got.","commit_id":"22a2cd9ed8a01b0dbfa0ca020ac574a433e44e48"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"7ca5aac8c732898f09d2221eba5eb37e5ab2f191","unresolved":true,"context_lines":[{"line_number":204,"context_line":"        interface_info \u003d access_info.get(\u0027interfaceInfo\u0027, {})"},{"line_number":205,"context_line":"        provider_type \u003d interface_info.get(\u0027providerType\u0027)"},{"line_number":206,"context_line":"        provider_version \u003d interface_info.get(\u0027providerVersion\u0027)"},{"line_number":207,"context_line":"        access_info \u003d access_info.get(\u0027accessInfo\u0027, {})"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"        # Create provider.tf content using the above information"},{"line_number":210,"context_line":"        content \u003d {"}],"source_content_type":"text/x-python","patch_set":37,"id":"13f53112_dc9c75fe","line":207,"range":{"start_line":207,"start_character":8,"end_line":207,"end_character":55},"in_reply_to":"0f54fa49_301fa5a0","updated":"2023-09-15 08:19:21.000000000","message":"sure, fixed.","commit_id":"22a2cd9ed8a01b0dbfa0ca020ac574a433e44e48"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"106473e8b3b39c4a5ecc91b6345b3eeee95398ed","unresolved":false,"context_lines":[{"line_number":204,"context_line":"        interface_info \u003d access_info.get(\u0027interfaceInfo\u0027, {})"},{"line_number":205,"context_line":"        provider_type \u003d interface_info.get(\u0027providerType\u0027)"},{"line_number":206,"context_line":"        provider_version \u003d interface_info.get(\u0027providerVersion\u0027)"},{"line_number":207,"context_line":"        access_info \u003d access_info.get(\u0027accessInfo\u0027, {})"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"        # Create provider.tf content using the above information"},{"line_number":210,"context_line":"        content \u003d {"}],"source_content_type":"text/x-python","patch_set":37,"id":"7b1d937c_462a852d","line":207,"range":{"start_line":207,"start_character":8,"end_line":207,"end_character":55},"in_reply_to":"13f53112_dc9c75fe","updated":"2023-09-15 09:54:32.000000000","message":"Ack","commit_id":"22a2cd9ed8a01b0dbfa0ca020ac574a433e44e48"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"2edc4efe8a3bb74f5f36baa6d94b6e342a4aaa90","unresolved":true,"context_lines":[{"line_number":99,"context_line":"            failed_process \u003d error.cmd[0].capitalize()"},{"line_number":100,"context_line":"            LOG.error(f\"Error running {failed_process}: {error}\")"},{"line_number":101,"context_line":"            # raise error and leave working_dir for retry"},{"line_number":102,"context_line":"            raise"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        try:"},{"line_number":105,"context_line":"            # Remove the working directory and its contents"}],"source_content_type":"text/x-python","patch_set":40,"id":"18027f86_9ea93d17","line":102,"range":{"start_line":102,"start_character":12,"end_line":102,"end_character":17},"updated":"2023-09-15 11:45:35.000000000","message":"How about you raise `sol_ex.TerraformOperationFailed` for error of `terraform destroy` command?","commit_id":"e7747993475d1890ff5f3ebc9d0e3ea1c017b3c3"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"98553f65bff4f62e0527f672060717c65184c1ad","unresolved":true,"context_lines":[{"line_number":99,"context_line":"            failed_process \u003d error.cmd[0].capitalize()"},{"line_number":100,"context_line":"            LOG.error(f\"Error running {failed_process}: {error}\")"},{"line_number":101,"context_line":"            # raise error and leave working_dir for retry"},{"line_number":102,"context_line":"            raise"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        try:"},{"line_number":105,"context_line":"            # Remove the working directory and its contents"}],"source_content_type":"text/x-python","patch_set":40,"id":"50fb4987_cb960059","line":102,"range":{"start_line":102,"start_character":12,"end_line":102,"end_character":17},"in_reply_to":"18027f86_9ea93d17","updated":"2023-09-15 11:52:01.000000000","message":"To add more information, when `subprocess.CalledProcessError` raised in `_instantiate()`(L76 in PS40), it is raised as `sol_ex.TerraformOperationFailed`.\nI think the it is better to match the behavior.","commit_id":"e7747993475d1890ff5f3ebc9d0e3ea1c017b3c3"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"31e3127a3dfbd1fa5bd155ffc482f47763c4cf36","unresolved":true,"context_lines":[{"line_number":99,"context_line":"            failed_process \u003d error.cmd[0].capitalize()"},{"line_number":100,"context_line":"            LOG.error(f\"Error running {failed_process}: {error}\")"},{"line_number":101,"context_line":"            # raise error and leave working_dir for retry"},{"line_number":102,"context_line":"            raise"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        try:"},{"line_number":105,"context_line":"            # Remove the working directory and its contents"}],"source_content_type":"text/x-python","patch_set":40,"id":"7eb489bb_751e4fa8","line":102,"range":{"start_line":102,"start_character":12,"end_line":102,"end_character":17},"in_reply_to":"50fb4987_cb960059","updated":"2023-09-15 12:13:01.000000000","message":"Hmm... I\u0027m not sure it\u0027s appropriate change because for the previous. However, both might not be so different by looking around the codes, nothing to catch the exception, and I don\u0027t opposite your suggestion.","commit_id":"e7747993475d1890ff5f3ebc9d0e3ea1c017b3c3"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"25c1847e8157162fa6c98ed19dd202734ea6e898","unresolved":false,"context_lines":[{"line_number":99,"context_line":"            failed_process \u003d error.cmd[0].capitalize()"},{"line_number":100,"context_line":"            LOG.error(f\"Error running {failed_process}: {error}\")"},{"line_number":101,"context_line":"            # raise error and leave working_dir for retry"},{"line_number":102,"context_line":"            raise"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        try:"},{"line_number":105,"context_line":"            # Remove the working directory and its contents"}],"source_content_type":"text/x-python","patch_set":40,"id":"10143a80_02a83afe","line":102,"range":{"start_line":102,"start_character":12,"end_line":102,"end_character":17},"in_reply_to":"7eb489bb_751e4fa8","updated":"2023-09-15 12:19:22.000000000","message":"Thanks for your rework, I\u0027ve confirmed.","commit_id":"e7747993475d1890ff5f3ebc9d0e3ea1c017b3c3"}],"tacker/tests/functional/sol_terraform_v2/paramgen.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"5ebdc9211765681c357a65456bb41aeef8d9ae9d","unresolved":true,"context_lines":[{"line_number":16,"context_line":"from oslo_utils import uuidutils"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"def test_terraform_instantiate_create(vnfd_id):"},{"line_number":20,"context_line":"    return {"},{"line_number":21,"context_line":"        \"vnfdId\": vnfd_id,"},{"line_number":22,"context_line":"        \"vnfInstanceName\": \"test_terraform_instantiate\","}],"source_content_type":"text/x-python","patch_set":31,"id":"33a6accf_d55ede0b","line":19,"range":{"start_line":19,"start_character":4,"end_line":19,"end_character":37},"updated":"2023-09-11 12:55:34.000000000","message":"Why not `terraform_create`?","commit_id":"da137f3b34c0a5b424788f7aec61ce20eb2d9245"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"f48cc904424282ccfafba382416a4ac01182ed84","unresolved":true,"context_lines":[{"line_number":16,"context_line":"from oslo_utils import uuidutils"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"def test_terraform_instantiate_create(vnfd_id):"},{"line_number":20,"context_line":"    return {"},{"line_number":21,"context_line":"        \"vnfdId\": vnfd_id,"},{"line_number":22,"context_line":"        \"vnfInstanceName\": \"test_terraform_instantiate\","}],"source_content_type":"text/x-python","patch_set":31,"id":"6b08a436_488f8916","line":19,"range":{"start_line":19,"start_character":4,"end_line":19,"end_character":37},"in_reply_to":"33a6accf_d55ede0b","updated":"2023-09-12 15:22:41.000000000","message":"Revised as create_req_by_vnfd_id() simply.","commit_id":"da137f3b34c0a5b424788f7aec61ce20eb2d9245"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"14ea7e3763a747d894b3efe2ee77950c685cfeac","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from oslo_utils import uuidutils"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"def test_terraform_instantiate_create(vnfd_id):"},{"line_number":20,"context_line":"    return {"},{"line_number":21,"context_line":"        \"vnfdId\": vnfd_id,"},{"line_number":22,"context_line":"        \"vnfInstanceName\": \"test_terraform_instantiate\","}],"source_content_type":"text/x-python","patch_set":31,"id":"2dd522f5_722ecc22","line":19,"range":{"start_line":19,"start_character":4,"end_line":19,"end_character":37},"in_reply_to":"6b08a436_488f8916","updated":"2023-09-12 22:00:07.000000000","message":"Ack","commit_id":"da137f3b34c0a5b424788f7aec61ce20eb2d9245"}],"tacker/tests/functional/sol_terraform_v2/samples/test_terraform_instantiate/contents/Scripts/sample_script.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"5ebdc9211765681c357a65456bb41aeef8d9ae9d","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2021 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":31,"id":"fbc37d51_32f2d167","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"updated":"2023-09-11 12:55:34.000000000","message":"Could you change to `2023`?","commit_id":"da137f3b34c0a5b424788f7aec61ce20eb2d9245"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"14ea7e3763a747d894b3efe2ee77950c685cfeac","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2021 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":31,"id":"4d34d077_8f625611","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"in_reply_to":"c9ea918d_052ed551","updated":"2023-09-12 22:00:07.000000000","message":"Ack","commit_id":"da137f3b34c0a5b424788f7aec61ce20eb2d9245"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"f48cc904424282ccfafba382416a4ac01182ed84","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2021 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":31,"id":"c9ea918d_052ed551","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"in_reply_to":"fbc37d51_32f2d167","updated":"2023-09-12 15:22:41.000000000","message":"fixed","commit_id":"da137f3b34c0a5b424788f7aec61ce20eb2d9245"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"5ebdc9211765681c357a65456bb41aeef8d9ae9d","unresolved":true,"context_lines":[{"line_number":39,"context_line":"    def terminate_end(self):"},{"line_number":40,"context_line":"        pass"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def change_external_connectivity_start(self):"},{"line_number":43,"context_line":"        if os.path.exists(\u0027/tmp/change_external_connectivity_start\u0027):"},{"line_number":44,"context_line":"            raise Exception(\"test change_external_connectivity_start error\")"},{"line_number":45,"context_line":"        pass"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def modify_information_start(self):"},{"line_number":48,"context_line":"        if os.path.exists(\u0027/tmp/modify_information_start\u0027):"},{"line_number":49,"context_line":"            raise Exception(\"test modify_information_start error\")"},{"line_number":50,"context_line":"        pass"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"def main():"}],"source_content_type":"text/x-python","patch_set":31,"id":"641283c5_9271e7b3","line":50,"range":{"start_line":42,"start_character":0,"end_line":50,"end_character":12},"updated":"2023-09-11 12:55:34.000000000","message":"This patch only supports instantiate/terminate/instantiate_rollback, so I don\u0027t think these definitions are necessary, but is there any intention to define them?","commit_id":"da137f3b34c0a5b424788f7aec61ce20eb2d9245"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"f48cc904424282ccfafba382416a4ac01182ed84","unresolved":true,"context_lines":[{"line_number":39,"context_line":"    def terminate_end(self):"},{"line_number":40,"context_line":"        pass"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def change_external_connectivity_start(self):"},{"line_number":43,"context_line":"        if os.path.exists(\u0027/tmp/change_external_connectivity_start\u0027):"},{"line_number":44,"context_line":"            raise Exception(\"test change_external_connectivity_start error\")"},{"line_number":45,"context_line":"        pass"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def modify_information_start(self):"},{"line_number":48,"context_line":"        if os.path.exists(\u0027/tmp/modify_information_start\u0027):"},{"line_number":49,"context_line":"            raise Exception(\"test modify_information_start error\")"},{"line_number":50,"context_line":"        pass"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"def main():"}],"source_content_type":"text/x-python","patch_set":31,"id":"885d19c4_b6aba692","line":50,"range":{"start_line":42,"start_character":0,"end_line":50,"end_character":12},"in_reply_to":"641283c5_9271e7b3","updated":"2023-09-12 15:22:41.000000000","message":"OK, remove them according to YAGNI principle.","commit_id":"da137f3b34c0a5b424788f7aec61ce20eb2d9245"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"14ea7e3763a747d894b3efe2ee77950c685cfeac","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    def terminate_end(self):"},{"line_number":40,"context_line":"        pass"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def change_external_connectivity_start(self):"},{"line_number":43,"context_line":"        if os.path.exists(\u0027/tmp/change_external_connectivity_start\u0027):"},{"line_number":44,"context_line":"            raise Exception(\"test change_external_connectivity_start error\")"},{"line_number":45,"context_line":"        pass"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def modify_information_start(self):"},{"line_number":48,"context_line":"        if os.path.exists(\u0027/tmp/modify_information_start\u0027):"},{"line_number":49,"context_line":"            raise Exception(\"test modify_information_start error\")"},{"line_number":50,"context_line":"        pass"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"def main():"}],"source_content_type":"text/x-python","patch_set":31,"id":"bb3fe080_cae19981","line":50,"range":{"start_line":42,"start_character":0,"end_line":50,"end_character":12},"in_reply_to":"885d19c4_b6aba692","updated":"2023-09-12 22:00:07.000000000","message":"Ack","commit_id":"da137f3b34c0a5b424788f7aec61ce20eb2d9245"}],"tacker/tests/functional/sol_terraform_v2/samples/test_terraform_instantiate/pkggen.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"5ebdc9211765681c357a65456bb41aeef8d9ae9d","unresolved":true,"context_lines":[{"line_number":34,"context_line":"shutil.move(os.path.join(tmp_dir, zip_file_name), \".\")"},{"line_number":35,"context_line":"shutil.rmtree(tmp_dir)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"create_req \u003d paramgen.test_terraform_instantiate_create(vnfd_id)"},{"line_number":38,"context_line":"instantiate_req \u003d paramgen.terraform_instantiate()"},{"line_number":39,"context_line":"terminate_req \u003d paramgen.terraform_terminate()"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":31,"id":"d1843067_81e7b42c","line":37,"range":{"start_line":37,"start_character":22,"end_line":37,"end_character":55},"updated":"2023-09-11 12:55:34.000000000","message":"Why not `terraform_create`?","commit_id":"da137f3b34c0a5b424788f7aec61ce20eb2d9245"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"14ea7e3763a747d894b3efe2ee77950c685cfeac","unresolved":false,"context_lines":[{"line_number":34,"context_line":"shutil.move(os.path.join(tmp_dir, zip_file_name), \".\")"},{"line_number":35,"context_line":"shutil.rmtree(tmp_dir)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"create_req \u003d paramgen.test_terraform_instantiate_create(vnfd_id)"},{"line_number":38,"context_line":"instantiate_req \u003d paramgen.terraform_instantiate()"},{"line_number":39,"context_line":"terminate_req \u003d paramgen.terraform_terminate()"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":31,"id":"76f6902a_1f47b704","line":37,"range":{"start_line":37,"start_character":22,"end_line":37,"end_character":55},"in_reply_to":"c8b0ab4d_1e7853fa","updated":"2023-09-12 22:00:07.000000000","message":"If multiple tests exist and each with different package/request, function for creating req in the `paramgen.py` would need to be increased accordingly.\nI think the VNF Instance name is included to distinguish each.\n\nAnyway, since this time it is to create a basic request, I think your modification is good.","commit_id":"da137f3b34c0a5b424788f7aec61ce20eb2d9245"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"f48cc904424282ccfafba382416a4ac01182ed84","unresolved":true,"context_lines":[{"line_number":34,"context_line":"shutil.move(os.path.join(tmp_dir, zip_file_name), \".\")"},{"line_number":35,"context_line":"shutil.rmtree(tmp_dir)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"create_req \u003d paramgen.test_terraform_instantiate_create(vnfd_id)"},{"line_number":38,"context_line":"instantiate_req \u003d paramgen.terraform_instantiate()"},{"line_number":39,"context_line":"terminate_req \u003d paramgen.terraform_terminate()"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":31,"id":"c8b0ab4d_1e7853fa","line":37,"range":{"start_line":37,"start_character":22,"end_line":37,"end_character":55},"in_reply_to":"d1843067_81e7b42c","updated":"2023-09-12 15:22:41.000000000","message":"Although it might be the name of VNF instance name is used as a func name, I\u0027m agree anyway with you it\u0027s not so understandable for the usage. And more, it\u0027s the same for other names in the package. So, I\u0027ve changed to more direct function names all in tacker/tests/functional/sol_terraform_v2/paramgen.py. What do you think?","commit_id":"da137f3b34c0a5b424788f7aec61ce20eb2d9245"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"5ebdc9211765681c357a65456bb41aeef8d9ae9d","unresolved":true,"context_lines":[{"line_number":44,"context_line":"with open(\"instantiate_req\", \"w\", encoding\u003d\u0027utf-8\u0027) as f:"},{"line_number":45,"context_line":"    f.write(json.dumps(instantiate_req, indent\u003d2))"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"with open(\"create_req\", \"w\", encoding\u003d\u0027utf-8\u0027) as f:"},{"line_number":48,"context_line":"    f.write(json.dumps(terminate_req, indent\u003d2))"}],"source_content_type":"text/x-python","patch_set":31,"id":"921ae2bf_287fbbea","line":47,"range":{"start_line":47,"start_character":11,"end_line":47,"end_character":21},"updated":"2023-09-11 12:55:34.000000000","message":"Could you correct to `terminate_req`?","commit_id":"da137f3b34c0a5b424788f7aec61ce20eb2d9245"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"f48cc904424282ccfafba382416a4ac01182ed84","unresolved":true,"context_lines":[{"line_number":44,"context_line":"with open(\"instantiate_req\", \"w\", encoding\u003d\u0027utf-8\u0027) as f:"},{"line_number":45,"context_line":"    f.write(json.dumps(instantiate_req, indent\u003d2))"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"with open(\"create_req\", \"w\", encoding\u003d\u0027utf-8\u0027) as f:"},{"line_number":48,"context_line":"    f.write(json.dumps(terminate_req, indent\u003d2))"}],"source_content_type":"text/x-python","patch_set":31,"id":"c8db421e_416854d7","line":47,"range":{"start_line":47,"start_character":11,"end_line":47,"end_character":21},"in_reply_to":"921ae2bf_287fbbea","updated":"2023-09-12 15:22:41.000000000","message":"sure, fixed","commit_id":"da137f3b34c0a5b424788f7aec61ce20eb2d9245"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"14ea7e3763a747d894b3efe2ee77950c685cfeac","unresolved":false,"context_lines":[{"line_number":44,"context_line":"with open(\"instantiate_req\", \"w\", encoding\u003d\u0027utf-8\u0027) as f:"},{"line_number":45,"context_line":"    f.write(json.dumps(instantiate_req, indent\u003d2))"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"with open(\"create_req\", \"w\", encoding\u003d\u0027utf-8\u0027) as f:"},{"line_number":48,"context_line":"    f.write(json.dumps(terminate_req, indent\u003d2))"}],"source_content_type":"text/x-python","patch_set":31,"id":"c9daef14_6cee7e4b","line":47,"range":{"start_line":47,"start_character":11,"end_line":47,"end_character":21},"in_reply_to":"c8db421e_416854d7","updated":"2023-09-12 22:00:07.000000000","message":"Ack","commit_id":"da137f3b34c0a5b424788f7aec61ce20eb2d9245"}],"tacker/tests/functional/sol_terraform_v2/test_terraform.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"5ebdc9211765681c357a65456bb41aeef8d9ae9d","unresolved":true,"context_lines":[{"line_number":33,"context_line":"        cur_dir \u003d os.path.dirname(__file__)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        test_terraform_instantiate_path \u003d os.path.join("},{"line_number":36,"context_line":"            cur_dir, \"samples/test_terraform_instantiate\")"},{"line_number":37,"context_line":"        cls.vnf_pkg_1, cls.vnfd_id_1 \u003d cls.create_vnf_package("},{"line_number":38,"context_line":"            test_terraform_instantiate_path)"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":31,"id":"6454e136_405595ac","line":36,"range":{"start_line":36,"start_character":45,"end_line":36,"end_character":56},"updated":"2023-09-11 12:55:34.000000000","message":"If you plan to add other LCMs to the `test_basic_lcms` tests in the future, wouldn\u0027t it be better to name the folder `test_terraform_basic`?","commit_id":"da137f3b34c0a5b424788f7aec61ce20eb2d9245"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"14ea7e3763a747d894b3efe2ee77950c685cfeac","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        cur_dir \u003d os.path.dirname(__file__)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        test_terraform_instantiate_path \u003d os.path.join("},{"line_number":36,"context_line":"            cur_dir, \"samples/test_terraform_instantiate\")"},{"line_number":37,"context_line":"        cls.vnf_pkg_1, cls.vnfd_id_1 \u003d cls.create_vnf_package("},{"line_number":38,"context_line":"            test_terraform_instantiate_path)"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":31,"id":"a3c968fc_8aa8d057","line":36,"range":{"start_line":36,"start_character":45,"end_line":36,"end_character":56},"in_reply_to":"23fce2e5_fe030fd8","updated":"2023-09-12 22:00:07.000000000","message":"Ack","commit_id":"da137f3b34c0a5b424788f7aec61ce20eb2d9245"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"f48cc904424282ccfafba382416a4ac01182ed84","unresolved":true,"context_lines":[{"line_number":33,"context_line":"        cur_dir \u003d os.path.dirname(__file__)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        test_terraform_instantiate_path \u003d os.path.join("},{"line_number":36,"context_line":"            cur_dir, \"samples/test_terraform_instantiate\")"},{"line_number":37,"context_line":"        cls.vnf_pkg_1, cls.vnfd_id_1 \u003d cls.create_vnf_package("},{"line_number":38,"context_line":"            test_terraform_instantiate_path)"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":31,"id":"23fce2e5_fe030fd8","line":36,"range":{"start_line":36,"start_character":45,"end_line":36,"end_character":56},"in_reply_to":"6454e136_405595ac","updated":"2023-09-12 15:22:41.000000000","message":"worth considering, I\u0027ll follow the comment.","commit_id":"da137f3b34c0a5b424788f7aec61ce20eb2d9245"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"5ebdc9211765681c357a65456bb41aeef8d9ae9d","unresolved":true,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        test_terraform_instantiate_path \u003d os.path.join("},{"line_number":36,"context_line":"            cur_dir, \"samples/test_terraform_instantiate\")"},{"line_number":37,"context_line":"        cls.vnf_pkg_1, cls.vnfd_id_1 \u003d cls.create_vnf_package("},{"line_number":38,"context_line":"            test_terraform_instantiate_path)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":31,"id":"bb9d9f15_4d9af839","line":37,"range":{"start_line":37,"start_character":20,"end_line":37,"end_character":21},"updated":"2023-09-11 12:55:34.000000000","message":"Instead of `1`, how about a name that recognizes pkg?\nIf you address the above comment, how about `basic_pkg`?","commit_id":"da137f3b34c0a5b424788f7aec61ce20eb2d9245"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"5ebdc9211765681c357a65456bb41aeef8d9ae9d","unresolved":true,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        test_terraform_instantiate_path \u003d os.path.join("},{"line_number":36,"context_line":"            cur_dir, \"samples/test_terraform_instantiate\")"},{"line_number":37,"context_line":"        cls.vnf_pkg_1, cls.vnfd_id_1 \u003d cls.create_vnf_package("},{"line_number":38,"context_line":"            test_terraform_instantiate_path)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":31,"id":"75d62058_cfa8d156","line":37,"range":{"start_line":37,"start_character":35,"end_line":37,"end_character":36},"updated":"2023-09-11 12:55:34.000000000","message":"ditto. `basic_vnfd_id`","commit_id":"da137f3b34c0a5b424788f7aec61ce20eb2d9245"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"14ea7e3763a747d894b3efe2ee77950c685cfeac","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        test_terraform_instantiate_path \u003d os.path.join("},{"line_number":36,"context_line":"            cur_dir, \"samples/test_terraform_instantiate\")"},{"line_number":37,"context_line":"        cls.vnf_pkg_1, cls.vnfd_id_1 \u003d cls.create_vnf_package("},{"line_number":38,"context_line":"            test_terraform_instantiate_path)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":31,"id":"bb655703_94549ab5","line":37,"range":{"start_line":37,"start_character":35,"end_line":37,"end_character":36},"in_reply_to":"4df946d6_18995dfe","updated":"2023-09-12 22:00:07.000000000","message":"Ack","commit_id":"da137f3b34c0a5b424788f7aec61ce20eb2d9245"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"f48cc904424282ccfafba382416a4ac01182ed84","unresolved":true,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        test_terraform_instantiate_path \u003d os.path.join("},{"line_number":36,"context_line":"            cur_dir, \"samples/test_terraform_instantiate\")"},{"line_number":37,"context_line":"        cls.vnf_pkg_1, cls.vnfd_id_1 \u003d cls.create_vnf_package("},{"line_number":38,"context_line":"            test_terraform_instantiate_path)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":31,"id":"4df946d6_18995dfe","line":37,"range":{"start_line":37,"start_character":35,"end_line":37,"end_character":36},"in_reply_to":"75d62058_cfa8d156","updated":"2023-09-12 15:22:41.000000000","message":"ditto","commit_id":"da137f3b34c0a5b424788f7aec61ce20eb2d9245"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"14ea7e3763a747d894b3efe2ee77950c685cfeac","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        test_terraform_instantiate_path \u003d os.path.join("},{"line_number":36,"context_line":"            cur_dir, \"samples/test_terraform_instantiate\")"},{"line_number":37,"context_line":"        cls.vnf_pkg_1, cls.vnfd_id_1 \u003d cls.create_vnf_package("},{"line_number":38,"context_line":"            test_terraform_instantiate_path)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":31,"id":"88c86106_66d2c2ff","line":37,"range":{"start_line":37,"start_character":20,"end_line":37,"end_character":21},"in_reply_to":"a3f567dc_72f46d9e","updated":"2023-09-12 22:00:07.000000000","message":"Ack","commit_id":"da137f3b34c0a5b424788f7aec61ce20eb2d9245"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"f48cc904424282ccfafba382416a4ac01182ed84","unresolved":true,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        test_terraform_instantiate_path \u003d os.path.join("},{"line_number":36,"context_line":"            cur_dir, \"samples/test_terraform_instantiate\")"},{"line_number":37,"context_line":"        cls.vnf_pkg_1, cls.vnfd_id_1 \u003d cls.create_vnf_package("},{"line_number":38,"context_line":"            test_terraform_instantiate_path)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":31,"id":"a3f567dc_72f46d9e","line":37,"range":{"start_line":37,"start_character":20,"end_line":37,"end_character":21},"in_reply_to":"bb9d9f15_4d9af839","updated":"2023-09-12 15:22:41.000000000","message":"ditto","commit_id":"da137f3b34c0a5b424788f7aec61ce20eb2d9245"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"5ebdc9211765681c357a65456bb41aeef8d9ae9d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":31,"id":"8f02c445_db381e81","line":155,"updated":"2023-09-11 12:55:34.000000000","message":"How about you implement tests for `instantiate_rollback`?","commit_id":"da137f3b34c0a5b424788f7aec61ce20eb2d9245"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"f48cc904424282ccfafba382416a4ac01182ed84","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":31,"id":"e12a7acb_69257631","line":155,"in_reply_to":"8f02c445_db381e81","updated":"2023-09-12 15:22:41.000000000","message":"I\u0027m not sure, but remind it as a TODO.","commit_id":"da137f3b34c0a5b424788f7aec61ce20eb2d9245"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"14ea7e3763a747d894b3efe2ee77950c685cfeac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":31,"id":"8cc64e4b_e7f40131","line":155,"in_reply_to":"e12a7acb_69257631","updated":"2023-09-12 22:00:07.000000000","message":"Ack","commit_id":"da137f3b34c0a5b424788f7aec61ce20eb2d9245"}],"tacker/tests/unit/sol_refactored/infra_drivers/terraform/test_terraform.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"5ebdc9211765681c357a65456bb41aeef8d9ae9d","unresolved":true,"context_lines":[{"line_number":107,"context_line":"        # Execute"},{"line_number":108,"context_line":"        self.driver.instantiate(req, inst, grant_req, grant, self.vnfd_2)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        # TODO(890611) Test _instantiate mock subprocess"},{"line_number":111,"context_line":"        # Verify _instantiate is called once"},{"line_number":112,"context_line":"        mock_instantiate.assert_called_once_with("},{"line_number":113,"context_line":"            req.vimConnectionInfo,"}],"source_content_type":"text/x-python","patch_set":31,"id":"e9680341_1595e641","line":110,"range":{"start_line":110,"start_character":15,"end_line":110,"end_character":21},"updated":"2023-09-11 12:55:34.000000000","message":"What do this number mean?","commit_id":"da137f3b34c0a5b424788f7aec61ce20eb2d9245"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"14ea7e3763a747d894b3efe2ee77950c685cfeac","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        # Execute"},{"line_number":108,"context_line":"        self.driver.instantiate(req, inst, grant_req, grant, self.vnfd_2)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        # TODO(890611) Test _instantiate mock subprocess"},{"line_number":111,"context_line":"        # Verify _instantiate is called once"},{"line_number":112,"context_line":"        mock_instantiate.assert_called_once_with("},{"line_number":113,"context_line":"            req.vimConnectionInfo,"}],"source_content_type":"text/x-python","patch_set":31,"id":"7bb6f4aa_e9deb45b","line":110,"range":{"start_line":110,"start_character":15,"end_line":110,"end_character":21},"in_reply_to":"def1d82c_16cfed67","updated":"2023-09-12 22:00:07.000000000","message":"Ack","commit_id":"da137f3b34c0a5b424788f7aec61ce20eb2d9245"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"f48cc904424282ccfafba382416a4ac01182ed84","unresolved":true,"context_lines":[{"line_number":107,"context_line":"        # Execute"},{"line_number":108,"context_line":"        self.driver.instantiate(req, inst, grant_req, grant, self.vnfd_2)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        # TODO(890611) Test _instantiate mock subprocess"},{"line_number":111,"context_line":"        # Verify _instantiate is called once"},{"line_number":112,"context_line":"        mock_instantiate.assert_called_once_with("},{"line_number":113,"context_line":"            req.vimConnectionInfo,"}],"source_content_type":"text/x-python","patch_set":31,"id":"def1d82c_16cfed67","line":110,"range":{"start_line":110,"start_character":15,"end_line":110,"end_character":21},"in_reply_to":"e9680341_1595e641","updated":"2023-09-12 15:22:41.000000000","message":"fixed","commit_id":"da137f3b34c0a5b424788f7aec61ce20eb2d9245"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"5ebdc9211765681c357a65456bb41aeef8d9ae9d","unresolved":true,"context_lines":[{"line_number":115,"context_line":"            req.additionalParams.get(\u0027tf_var_path\u0027))"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def test_make_instantiated_vnf_info(self):"},{"line_number":118,"context_line":"        \u0027\u0027\u0027Verifies instantiated info is correct\u0027\u0027\u0027"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        req \u003d objects.InstantiateVnfRequest.from_dict(_instantiate_req_example)"},{"line_number":121,"context_line":""}],"source_content_type":"text/x-python","patch_set":31,"id":"5800bd3d_bc3cefe2","line":118,"range":{"start_line":118,"start_character":20,"end_line":118,"end_character":37},"updated":"2023-09-11 12:55:34.000000000","message":"How about you write `instantiated vnf info` exactly?","commit_id":"da137f3b34c0a5b424788f7aec61ce20eb2d9245"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"14ea7e3763a747d894b3efe2ee77950c685cfeac","unresolved":false,"context_lines":[{"line_number":115,"context_line":"            req.additionalParams.get(\u0027tf_var_path\u0027))"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def test_make_instantiated_vnf_info(self):"},{"line_number":118,"context_line":"        \u0027\u0027\u0027Verifies instantiated info is correct\u0027\u0027\u0027"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        req \u003d objects.InstantiateVnfRequest.from_dict(_instantiate_req_example)"},{"line_number":121,"context_line":""}],"source_content_type":"text/x-python","patch_set":31,"id":"5260bbfd_f0313b78","line":118,"range":{"start_line":118,"start_character":20,"end_line":118,"end_character":37},"in_reply_to":"4b782907_52fa7296","updated":"2023-09-12 22:00:07.000000000","message":"Ack","commit_id":"da137f3b34c0a5b424788f7aec61ce20eb2d9245"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"f48cc904424282ccfafba382416a4ac01182ed84","unresolved":true,"context_lines":[{"line_number":115,"context_line":"            req.additionalParams.get(\u0027tf_var_path\u0027))"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def test_make_instantiated_vnf_info(self):"},{"line_number":118,"context_line":"        \u0027\u0027\u0027Verifies instantiated info is correct\u0027\u0027\u0027"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        req \u003d objects.InstantiateVnfRequest.from_dict(_instantiate_req_example)"},{"line_number":121,"context_line":""}],"source_content_type":"text/x-python","patch_set":31,"id":"4b782907_52fa7296","line":118,"range":{"start_line":118,"start_character":20,"end_line":118,"end_character":37},"in_reply_to":"5800bd3d_bc3cefe2","updated":"2023-09-12 15:22:41.000000000","message":"fixed","commit_id":"da137f3b34c0a5b424788f7aec61ce20eb2d9245"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"106473e8b3b39c4a5ecc91b6345b3eeee95398ed","unresolved":true,"context_lines":[{"line_number":110,"context_line":"        # TODO(yasufum) Test _instantiate mock subprocess"},{"line_number":111,"context_line":"        # Verify _instantiate is called once"},{"line_number":112,"context_line":"        mock_instantiate.assert_called_once_with("},{"line_number":113,"context_line":"            req.vimConnectionInfo,"},{"line_number":114,"context_line":"            f\"/var/lib/tacker/terraform/{inst.id}\","},{"line_number":115,"context_line":"            req.additionalParams.get(\u0027tf_var_path\u0027))"},{"line_number":116,"context_line":""}],"source_content_type":"text/x-python","patch_set":38,"id":"d096d317_5a878536","line":113,"range":{"start_line":113,"start_character":12,"end_line":113,"end_character":33},"updated":"2023-09-15 09:54:32.000000000","message":"An error is occurring in UT.\nCould you fix this here to `req.vimConnectionInfo[\u0027vim1\u0027]` due to a correction in PS37.","commit_id":"266236e022d899c2800252bca1cbf7f69dfa9fb1"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"887435e42c2892dc424e9cfb3c01648aef034d03","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        # TODO(yasufum) Test _instantiate mock subprocess"},{"line_number":111,"context_line":"        # Verify _instantiate is called once"},{"line_number":112,"context_line":"        mock_instantiate.assert_called_once_with("},{"line_number":113,"context_line":"            req.vimConnectionInfo,"},{"line_number":114,"context_line":"            f\"/var/lib/tacker/terraform/{inst.id}\","},{"line_number":115,"context_line":"            req.additionalParams.get(\u0027tf_var_path\u0027))"},{"line_number":116,"context_line":""}],"source_content_type":"text/x-python","patch_set":38,"id":"27914e21_0471fcb6","line":113,"range":{"start_line":113,"start_character":12,"end_line":113,"end_character":33},"in_reply_to":"6f9152a1_8a0af937","updated":"2023-09-15 11:15:22.000000000","message":"Ack","commit_id":"266236e022d899c2800252bca1cbf7f69dfa9fb1"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"e7b8b097cddfdc0d78c715ae7de2860498bbfac1","unresolved":true,"context_lines":[{"line_number":110,"context_line":"        # TODO(yasufum) Test _instantiate mock subprocess"},{"line_number":111,"context_line":"        # Verify _instantiate is called once"},{"line_number":112,"context_line":"        mock_instantiate.assert_called_once_with("},{"line_number":113,"context_line":"            req.vimConnectionInfo,"},{"line_number":114,"context_line":"            f\"/var/lib/tacker/terraform/{inst.id}\","},{"line_number":115,"context_line":"            req.additionalParams.get(\u0027tf_var_path\u0027))"},{"line_number":116,"context_line":""}],"source_content_type":"text/x-python","patch_set":38,"id":"6f9152a1_8a0af937","line":113,"range":{"start_line":113,"start_character":12,"end_line":113,"end_character":33},"in_reply_to":"d096d317_5a878536","updated":"2023-09-15 10:55:33.000000000","message":"Ah, I\u0027ve just found that all unit tests are skipped in my local env because proper version of python isn\u0027t installed... Anyway, I\u0027ll fix it soon. Thanks.","commit_id":"266236e022d899c2800252bca1cbf7f69dfa9fb1"}]}