)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"613aa2aa16d8d221c56079a7c0c8b26d6d4b19b5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1a46dfc6_0358f7ca","updated":"2023-08-08 06:22:01.000000000","message":"Thanks for your patch, please kindly find my comments.","commit_id":"f4af0b683675c8b18feac2961ddc68b600cc893f"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"0cdd06a74c3eef05ebaad1a3261f66a6e5b38a10","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d6098f30_dfc069d9","updated":"2023-08-08 00:37:44.000000000","message":"recheck, infra failure in sol-v2-ubuntu-focal job","commit_id":"f4af0b683675c8b18feac2961ddc68b600cc893f"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"9fb1fcf99e2a2874b3743db96321685ac2c3a414","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3477a33d_7b1810a5","updated":"2023-08-25 04:53:22.000000000","message":"recheck, infra failure in sol-v2 job","commit_id":"0029976d1d9bad71b75f2b67876db9bcc6026ef8"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"af7e9a64d70783ed9d21466a33643365678857a1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f5b7cf01_c42ab2a2","updated":"2023-08-25 07:32:20.000000000","message":"recheck, infra failure in sol-v2 job","commit_id":"0029976d1d9bad71b75f2b67876db9bcc6026ef8"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"f620059ee5f63c8042081a275cd1247f1fe23a11","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8f6b18e2_d6489695","updated":"2023-08-28 00:42:44.000000000","message":"recheck, infra failure in sol-v2-individual-vnfc-mgmt job","commit_id":"0029976d1d9bad71b75f2b67876db9bcc6026ef8"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"7aef4f8993ef158286b0663b0ee7c2555815c7c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1f8b0d48_3c70d019","updated":"2023-08-29 04:35:45.000000000","message":"recheck, infra failure in sol-v2-ubuntu-focal job","commit_id":"ed3e80942578b764c913ddbe7af3c27f50f8107d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"4e9384360807042571082cb5f137ea2998dc76a2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"4a9fde4b_082c5dd2","updated":"2023-08-30 00:22:18.000000000","message":"recheck, infra failure in sol-v2-ubuntu-focal job","commit_id":"ed3e80942578b764c913ddbe7af3c27f50f8107d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"f0e2600386f5fe68e045fe16c6801bc4742ddda4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"3a141114_e7dc4286","updated":"2023-08-29 00:41:22.000000000","message":"recheck, tox failure in tox-cover job","commit_id":"ed3e80942578b764c913ddbe7af3c27f50f8107d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"04fb9ac33316e736aa0a279a64f020d2ed385382","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"5e96a223_266c55d6","updated":"2023-08-29 08:27:05.000000000","message":"recheck, tox failure in tox-cover job","commit_id":"ed3e80942578b764c913ddbe7af3c27f50f8107d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"e49a423db33934eddfee46cadca12efb64b2c4a7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"48265d51_327711b8","updated":"2023-08-31 05:47:40.000000000","message":"recheck, tox failure in tox-cover job","commit_id":"6a3615f14bfc01e8ceba763d4b23892a390d4d4a"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b10225feeb007fcc17c022767c4f4457649f3166","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"aa197550_e61dbd08","updated":"2023-09-06 01:38:46.000000000","message":"Thanks for your rework, LGTM.","commit_id":"f88685e31b2716ea806c62a911eafc0f4a5947fa"}],"tacker/tests/functional/sol_v2/test_server_notification.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"613aa2aa16d8d221c56079a7c0c8b26d6d4b19b5","unresolved":true,"context_lines":[{"line_number":558,"context_line":"        self.assertEqual(\u0027INSTANTIATE\u0027, body[\u0027operation\u0027])"},{"line_number":559,"context_line":""},{"line_number":560,"context_line":"        vm_infos \u003d self.get_server_details(None)"},{"line_number":561,"context_line":"        vm_ids \u003d ["},{"line_number":562,"context_line":"            vm_info.get(\u0027id\u0027) for vm_info in vm_infos"},{"line_number":563,"context_line":"            if vm_info[\u0027name\u0027] in [\u0027VDU1\u0027, \u0027VDU2\u0027]]"},{"line_number":564,"context_line":"        alarm_ids \u003d [\u0027alarm_id_1\u0027, \u0027alarm_id_2\u0027]"},{"line_number":565,"context_line":"        for data in (body[\u0027error\u0027][\u0027userScriptErrHandlingData\u0027]"},{"line_number":566,"context_line":"        [\u0027serverNotification\u0027]):"},{"line_number":567,"context_line":"            self.assertIn(data[\u0027serverId\u0027], vm_ids)"}],"source_content_type":"text/x-python","patch_set":1,"id":"176781a7_83654d5c","line":564,"range":{"start_line":561,"start_character":0,"end_line":564,"end_character":48},"updated":"2023-08-08 06:22:01.000000000","message":"Could you change `list` to `set` like follow?\n```\n        vm_ids \u003d {vm_info.get(\u0027id\u0027) for vm_info in vm_infos\n                  if vm_info[\u0027name\u0027] in [\u0027VDU1\u0027, \u0027VDU2\u0027]}\n        alarm_ids \u003d {\u0027alarm_id_1\u0027, \u0027alarm_id_2\u0027}\n```\nIf you revise it, please do the same revising for subsequent implementations.","commit_id":"f4af0b683675c8b18feac2961ddc68b600cc893f"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"f00ffa3ef801c694e259f4b52aa1c857ba39240b","unresolved":true,"context_lines":[{"line_number":558,"context_line":"        self.assertEqual(\u0027INSTANTIATE\u0027, body[\u0027operation\u0027])"},{"line_number":559,"context_line":""},{"line_number":560,"context_line":"        vm_infos \u003d self.get_server_details(None)"},{"line_number":561,"context_line":"        vm_ids \u003d ["},{"line_number":562,"context_line":"            vm_info.get(\u0027id\u0027) for vm_info in vm_infos"},{"line_number":563,"context_line":"            if vm_info[\u0027name\u0027] in [\u0027VDU1\u0027, \u0027VDU2\u0027]]"},{"line_number":564,"context_line":"        alarm_ids \u003d [\u0027alarm_id_1\u0027, \u0027alarm_id_2\u0027]"},{"line_number":565,"context_line":"        for data in (body[\u0027error\u0027][\u0027userScriptErrHandlingData\u0027]"},{"line_number":566,"context_line":"        [\u0027serverNotification\u0027]):"},{"line_number":567,"context_line":"            self.assertIn(data[\u0027serverId\u0027], vm_ids)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3751c7a6_604bae8c","line":564,"range":{"start_line":561,"start_character":0,"end_line":564,"end_character":48},"in_reply_to":"176781a7_83654d5c","updated":"2023-08-17 02:18:16.000000000","message":"I fixed it in patchset 2.","commit_id":"f4af0b683675c8b18feac2961ddc68b600cc893f"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b10225feeb007fcc17c022767c4f4457649f3166","unresolved":false,"context_lines":[{"line_number":558,"context_line":"        self.assertEqual(\u0027INSTANTIATE\u0027, body[\u0027operation\u0027])"},{"line_number":559,"context_line":""},{"line_number":560,"context_line":"        vm_infos \u003d self.get_server_details(None)"},{"line_number":561,"context_line":"        vm_ids \u003d ["},{"line_number":562,"context_line":"            vm_info.get(\u0027id\u0027) for vm_info in vm_infos"},{"line_number":563,"context_line":"            if vm_info[\u0027name\u0027] in [\u0027VDU1\u0027, \u0027VDU2\u0027]]"},{"line_number":564,"context_line":"        alarm_ids \u003d [\u0027alarm_id_1\u0027, \u0027alarm_id_2\u0027]"},{"line_number":565,"context_line":"        for data in (body[\u0027error\u0027][\u0027userScriptErrHandlingData\u0027]"},{"line_number":566,"context_line":"        [\u0027serverNotification\u0027]):"},{"line_number":567,"context_line":"            self.assertIn(data[\u0027serverId\u0027], vm_ids)"}],"source_content_type":"text/x-python","patch_set":1,"id":"e07380a4_60d96e28","line":564,"range":{"start_line":561,"start_character":0,"end_line":564,"end_character":48},"in_reply_to":"3751c7a6_604bae8c","updated":"2023-09-06 01:38:46.000000000","message":"Ack","commit_id":"f4af0b683675c8b18feac2961ddc68b600cc893f"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"613aa2aa16d8d221c56079a7c0c8b26d6d4b19b5","unresolved":true,"context_lines":[{"line_number":562,"context_line":"            vm_info.get(\u0027id\u0027) for vm_info in vm_infos"},{"line_number":563,"context_line":"            if vm_info[\u0027name\u0027] in [\u0027VDU1\u0027, \u0027VDU2\u0027]]"},{"line_number":564,"context_line":"        alarm_ids \u003d [\u0027alarm_id_1\u0027, \u0027alarm_id_2\u0027]"},{"line_number":565,"context_line":"        for data in (body[\u0027error\u0027][\u0027userScriptErrHandlingData\u0027]"},{"line_number":566,"context_line":"        [\u0027serverNotification\u0027]):"},{"line_number":567,"context_line":"            self.assertIn(data[\u0027serverId\u0027], vm_ids)"},{"line_number":568,"context_line":"            vm_ids.remove(data[\u0027serverId\u0027])"},{"line_number":569,"context_line":"            self.assertIn(data[\u0027alarmId\u0027], alarm_ids)"}],"source_content_type":"text/x-python","patch_set":1,"id":"91ab61fd_e7028d02","line":566,"range":{"start_line":565,"start_character":0,"end_line":566,"end_character":32},"updated":"2023-08-08 06:22:01.000000000","message":"Could you change this branch to add indentation as follow?\n```\n        for data in (body[\u0027error\u0027][\u0027userScriptErrHandlingData\u0027]\n                         [\u0027serverNotification\u0027]):\n```\nIf you revise it, please do the same revising for subsequent implementations.","commit_id":"f4af0b683675c8b18feac2961ddc68b600cc893f"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"f00ffa3ef801c694e259f4b52aa1c857ba39240b","unresolved":true,"context_lines":[{"line_number":562,"context_line":"            vm_info.get(\u0027id\u0027) for vm_info in vm_infos"},{"line_number":563,"context_line":"            if vm_info[\u0027name\u0027] in [\u0027VDU1\u0027, \u0027VDU2\u0027]]"},{"line_number":564,"context_line":"        alarm_ids \u003d [\u0027alarm_id_1\u0027, \u0027alarm_id_2\u0027]"},{"line_number":565,"context_line":"        for data in (body[\u0027error\u0027][\u0027userScriptErrHandlingData\u0027]"},{"line_number":566,"context_line":"        [\u0027serverNotification\u0027]):"},{"line_number":567,"context_line":"            self.assertIn(data[\u0027serverId\u0027], vm_ids)"},{"line_number":568,"context_line":"            vm_ids.remove(data[\u0027serverId\u0027])"},{"line_number":569,"context_line":"            self.assertIn(data[\u0027alarmId\u0027], alarm_ids)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ef5168d0_6044a15e","line":566,"range":{"start_line":565,"start_character":0,"end_line":566,"end_character":32},"in_reply_to":"91ab61fd_e7028d02","updated":"2023-08-17 02:18:16.000000000","message":"I fixed it in patchset 2.","commit_id":"f4af0b683675c8b18feac2961ddc68b600cc893f"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b10225feeb007fcc17c022767c4f4457649f3166","unresolved":false,"context_lines":[{"line_number":562,"context_line":"            vm_info.get(\u0027id\u0027) for vm_info in vm_infos"},{"line_number":563,"context_line":"            if vm_info[\u0027name\u0027] in [\u0027VDU1\u0027, \u0027VDU2\u0027]]"},{"line_number":564,"context_line":"        alarm_ids \u003d [\u0027alarm_id_1\u0027, \u0027alarm_id_2\u0027]"},{"line_number":565,"context_line":"        for data in (body[\u0027error\u0027][\u0027userScriptErrHandlingData\u0027]"},{"line_number":566,"context_line":"        [\u0027serverNotification\u0027]):"},{"line_number":567,"context_line":"            self.assertIn(data[\u0027serverId\u0027], vm_ids)"},{"line_number":568,"context_line":"            vm_ids.remove(data[\u0027serverId\u0027])"},{"line_number":569,"context_line":"            self.assertIn(data[\u0027alarmId\u0027], alarm_ids)"}],"source_content_type":"text/x-python","patch_set":1,"id":"58c3df4a_3d0801f3","line":566,"range":{"start_line":565,"start_character":0,"end_line":566,"end_character":32},"in_reply_to":"ef5168d0_6044a15e","updated":"2023-09-06 01:38:46.000000000","message":"Ack","commit_id":"f4af0b683675c8b18feac2961ddc68b600cc893f"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"613aa2aa16d8d221c56079a7c0c8b26d6d4b19b5","unresolved":true,"context_lines":[{"line_number":565,"context_line":"        for data in (body[\u0027error\u0027][\u0027userScriptErrHandlingData\u0027]"},{"line_number":566,"context_line":"        [\u0027serverNotification\u0027]):"},{"line_number":567,"context_line":"            self.assertIn(data[\u0027serverId\u0027], vm_ids)"},{"line_number":568,"context_line":"            vm_ids.remove(data[\u0027serverId\u0027])"},{"line_number":569,"context_line":"            self.assertIn(data[\u0027alarmId\u0027], alarm_ids)"},{"line_number":570,"context_line":"            alarm_ids.remove(data[\u0027alarmId\u0027])"},{"line_number":571,"context_line":"        self.assertEqual(2, len("}],"source_content_type":"text/x-python","patch_set":1,"id":"7d133339_7035fef9","line":568,"range":{"start_line":568,"start_character":12,"end_line":568,"end_character":43},"updated":"2023-08-08 06:22:01.000000000","message":"Removing from vm_ids seems pointless.\nIs this line necessary?\n\nIf you revise it, please do the same revising for subsequent implementations.","commit_id":"f4af0b683675c8b18feac2961ddc68b600cc893f"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b10225feeb007fcc17c022767c4f4457649f3166","unresolved":false,"context_lines":[{"line_number":565,"context_line":"        for data in (body[\u0027error\u0027][\u0027userScriptErrHandlingData\u0027]"},{"line_number":566,"context_line":"        [\u0027serverNotification\u0027]):"},{"line_number":567,"context_line":"            self.assertIn(data[\u0027serverId\u0027], vm_ids)"},{"line_number":568,"context_line":"            vm_ids.remove(data[\u0027serverId\u0027])"},{"line_number":569,"context_line":"            self.assertIn(data[\u0027alarmId\u0027], alarm_ids)"},{"line_number":570,"context_line":"            alarm_ids.remove(data[\u0027alarmId\u0027])"},{"line_number":571,"context_line":"        self.assertEqual(2, len("}],"source_content_type":"text/x-python","patch_set":1,"id":"b0e31056_ed400287","line":568,"range":{"start_line":568,"start_character":12,"end_line":568,"end_character":43},"in_reply_to":"6c82db2b_d2728bfa","updated":"2023-09-06 01:38:46.000000000","message":"Ack","commit_id":"f4af0b683675c8b18feac2961ddc68b600cc893f"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"f00ffa3ef801c694e259f4b52aa1c857ba39240b","unresolved":true,"context_lines":[{"line_number":565,"context_line":"        for data in (body[\u0027error\u0027][\u0027userScriptErrHandlingData\u0027]"},{"line_number":566,"context_line":"        [\u0027serverNotification\u0027]):"},{"line_number":567,"context_line":"            self.assertIn(data[\u0027serverId\u0027], vm_ids)"},{"line_number":568,"context_line":"            vm_ids.remove(data[\u0027serverId\u0027])"},{"line_number":569,"context_line":"            self.assertIn(data[\u0027alarmId\u0027], alarm_ids)"},{"line_number":570,"context_line":"            alarm_ids.remove(data[\u0027alarmId\u0027])"},{"line_number":571,"context_line":"        self.assertEqual(2, len("}],"source_content_type":"text/x-python","patch_set":1,"id":"6c82db2b_d2728bfa","line":568,"range":{"start_line":568,"start_character":12,"end_line":568,"end_character":43},"in_reply_to":"7d133339_7035fef9","updated":"2023-08-17 02:18:16.000000000","message":"I removed it in patchset 2.","commit_id":"f4af0b683675c8b18feac2961ddc68b600cc893f"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"613aa2aa16d8d221c56079a7c0c8b26d6d4b19b5","unresolved":true,"context_lines":[{"line_number":567,"context_line":"            self.assertIn(data[\u0027serverId\u0027], vm_ids)"},{"line_number":568,"context_line":"            vm_ids.remove(data[\u0027serverId\u0027])"},{"line_number":569,"context_line":"            self.assertIn(data[\u0027alarmId\u0027], alarm_ids)"},{"line_number":570,"context_line":"            alarm_ids.remove(data[\u0027alarmId\u0027])"},{"line_number":571,"context_line":"        self.assertEqual(2, len("},{"line_number":572,"context_line":"            body[\u0027error\u0027][\u0027userScriptErrHandlingData\u0027][\u0027serverNotification\u0027]))"},{"line_number":573,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"cf9bd7d1_2e451995","line":570,"range":{"start_line":570,"start_character":12,"end_line":570,"end_character":45},"updated":"2023-08-08 06:22:01.000000000","message":"Removing from alarm_ids seems pointless.\nIs this line necessary?\n\nIf you revise it, please do the same revising for subsequent implementations.","commit_id":"f4af0b683675c8b18feac2961ddc68b600cc893f"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b10225feeb007fcc17c022767c4f4457649f3166","unresolved":false,"context_lines":[{"line_number":567,"context_line":"            self.assertIn(data[\u0027serverId\u0027], vm_ids)"},{"line_number":568,"context_line":"            vm_ids.remove(data[\u0027serverId\u0027])"},{"line_number":569,"context_line":"            self.assertIn(data[\u0027alarmId\u0027], alarm_ids)"},{"line_number":570,"context_line":"            alarm_ids.remove(data[\u0027alarmId\u0027])"},{"line_number":571,"context_line":"        self.assertEqual(2, len("},{"line_number":572,"context_line":"            body[\u0027error\u0027][\u0027userScriptErrHandlingData\u0027][\u0027serverNotification\u0027]))"},{"line_number":573,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"810d9e7d_6d6ea1b7","line":570,"range":{"start_line":570,"start_character":12,"end_line":570,"end_character":45},"in_reply_to":"c0976906_69455a8b","updated":"2023-09-06 01:38:46.000000000","message":"Ack","commit_id":"f4af0b683675c8b18feac2961ddc68b600cc893f"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"f00ffa3ef801c694e259f4b52aa1c857ba39240b","unresolved":true,"context_lines":[{"line_number":567,"context_line":"            self.assertIn(data[\u0027serverId\u0027], vm_ids)"},{"line_number":568,"context_line":"            vm_ids.remove(data[\u0027serverId\u0027])"},{"line_number":569,"context_line":"            self.assertIn(data[\u0027alarmId\u0027], alarm_ids)"},{"line_number":570,"context_line":"            alarm_ids.remove(data[\u0027alarmId\u0027])"},{"line_number":571,"context_line":"        self.assertEqual(2, len("},{"line_number":572,"context_line":"            body[\u0027error\u0027][\u0027userScriptErrHandlingData\u0027][\u0027serverNotification\u0027]))"},{"line_number":573,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"c0976906_69455a8b","line":570,"range":{"start_line":570,"start_character":12,"end_line":570,"end_character":45},"in_reply_to":"cf9bd7d1_2e451995","updated":"2023-08-17 02:18:16.000000000","message":"I removed it in patchset 2.","commit_id":"f4af0b683675c8b18feac2961ddc68b600cc893f"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"613aa2aa16d8d221c56079a7c0c8b26d6d4b19b5","unresolved":true,"context_lines":[{"line_number":689,"context_line":"                           \u0027alarmId\u0027: res[\u0027metadata\u0027][\u0027server_notification\u0027]["},{"line_number":690,"context_line":"                               \u0027alarmId\u0027]} for res in"},{"line_number":691,"context_line":"                          body[\u0027instantiatedVnfInfo\u0027][\u0027vnfcResourceInfo\u0027]]"},{"line_number":692,"context_line":"        alarm_ids \u003d [data[\u0027alarmId\u0027] for data in metadata_infos]"},{"line_number":693,"context_line":"        expect_alarm_ids \u003d [\u0027alarm_id_1\u0027, \u0027alarm_id_2\u0027,"},{"line_number":694,"context_line":"                            \u0027alarm_id_3\u0027, \u0027alarm_id_4\u0027]"},{"line_number":695,"context_line":"        self.assertListEqual(alarm_ids, expect_alarm_ids)"},{"line_number":696,"context_line":""},{"line_number":697,"context_line":"        # 4. LCM-ScaleV2(in)(error)"},{"line_number":698,"context_line":"        self.put_fail_file(\u0027scale_start\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"4b2b8237_cc2a0164","line":695,"range":{"start_line":692,"start_character":0,"end_line":695,"end_character":57},"updated":"2023-08-08 06:22:01.000000000","message":"If the order in the list is different, assert will fail, so I think it\u0027s better to compare by set. What do you think?\n```\n        alarm_ids \u003d {data[\u0027alarmId\u0027] for data in metadata_infos}\n        expect_alarm_ids \u003d {\u0027alarm_id_1\u0027, \u0027alarm_id_2\u0027,\n                            \u0027alarm_id_3\u0027, \u0027alarm_id_4\u0027}\n        self.assertSetEqual(alarm_ids, expect_alarm_ids)\n```\nIf you need to assert them in order, leave it as List is better.\nAnd if you revise it, please do the same revising for subsequent implementations.","commit_id":"f4af0b683675c8b18feac2961ddc68b600cc893f"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"f00ffa3ef801c694e259f4b52aa1c857ba39240b","unresolved":true,"context_lines":[{"line_number":689,"context_line":"                           \u0027alarmId\u0027: res[\u0027metadata\u0027][\u0027server_notification\u0027]["},{"line_number":690,"context_line":"                               \u0027alarmId\u0027]} for res in"},{"line_number":691,"context_line":"                          body[\u0027instantiatedVnfInfo\u0027][\u0027vnfcResourceInfo\u0027]]"},{"line_number":692,"context_line":"        alarm_ids \u003d [data[\u0027alarmId\u0027] for data in metadata_infos]"},{"line_number":693,"context_line":"        expect_alarm_ids \u003d [\u0027alarm_id_1\u0027, \u0027alarm_id_2\u0027,"},{"line_number":694,"context_line":"                            \u0027alarm_id_3\u0027, \u0027alarm_id_4\u0027]"},{"line_number":695,"context_line":"        self.assertListEqual(alarm_ids, expect_alarm_ids)"},{"line_number":696,"context_line":""},{"line_number":697,"context_line":"        # 4. LCM-ScaleV2(in)(error)"},{"line_number":698,"context_line":"        self.put_fail_file(\u0027scale_start\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"f9f7d599_206a4b63","line":695,"range":{"start_line":692,"start_character":0,"end_line":695,"end_character":57},"in_reply_to":"4b2b8237_cc2a0164","updated":"2023-08-17 02:18:16.000000000","message":"I fixed it in patchset 2.","commit_id":"f4af0b683675c8b18feac2961ddc68b600cc893f"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b10225feeb007fcc17c022767c4f4457649f3166","unresolved":false,"context_lines":[{"line_number":689,"context_line":"                           \u0027alarmId\u0027: res[\u0027metadata\u0027][\u0027server_notification\u0027]["},{"line_number":690,"context_line":"                               \u0027alarmId\u0027]} for res in"},{"line_number":691,"context_line":"                          body[\u0027instantiatedVnfInfo\u0027][\u0027vnfcResourceInfo\u0027]]"},{"line_number":692,"context_line":"        alarm_ids \u003d [data[\u0027alarmId\u0027] for data in metadata_infos]"},{"line_number":693,"context_line":"        expect_alarm_ids \u003d [\u0027alarm_id_1\u0027, \u0027alarm_id_2\u0027,"},{"line_number":694,"context_line":"                            \u0027alarm_id_3\u0027, \u0027alarm_id_4\u0027]"},{"line_number":695,"context_line":"        self.assertListEqual(alarm_ids, expect_alarm_ids)"},{"line_number":696,"context_line":""},{"line_number":697,"context_line":"        # 4. LCM-ScaleV2(in)(error)"},{"line_number":698,"context_line":"        self.put_fail_file(\u0027scale_start\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9164cf17_1f568559","line":695,"range":{"start_line":692,"start_character":0,"end_line":695,"end_character":57},"in_reply_to":"f9f7d599_206a4b63","updated":"2023-09-06 01:38:46.000000000","message":"Ack","commit_id":"f4af0b683675c8b18feac2961ddc68b600cc893f"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"613aa2aa16d8d221c56079a7c0c8b26d6d4b19b5","unresolved":true,"context_lines":[{"line_number":725,"context_line":"        self.assertEqual(\u0027SCALE\u0027, body[\u0027operation\u0027])"},{"line_number":726,"context_line":""},{"line_number":727,"context_line":"        vm_infos \u003d self.get_server_details(None)"},{"line_number":728,"context_line":"        vm_ids \u003d ["},{"line_number":729,"context_line":"            vm_info.get(\u0027id\u0027) for vm_info in vm_infos"},{"line_number":730,"context_line":"            if vm_info[\u0027name\u0027] in [\u0027VDU1\u0027]]"},{"line_number":731,"context_line":"        for data in (body[\u0027error\u0027][\u0027userScriptErrHandlingData\u0027]"},{"line_number":732,"context_line":"        [\u0027serverNotification\u0027]):"},{"line_number":733,"context_line":"            self.assertIn(data[\u0027serverId\u0027], vm_ids)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfffcf50_6069feda","line":730,"range":{"start_line":728,"start_character":0,"end_line":730,"end_character":43},"updated":"2023-08-08 06:22:01.000000000","message":"Could you change `list` to `set` like follow? and I think there is no need to use `in` because there is only one element.\n```\n        vm_ids \u003d {vm_info.get(\u0027id\u0027) for vm_info in vm_infos\n                  if vm_info[\u0027name\u0027] \u003d\u003d \u0027VDU1\u0027}\n```\n\nIf you revise it, please do the same revising for subsequent implementations.","commit_id":"f4af0b683675c8b18feac2961ddc68b600cc893f"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b10225feeb007fcc17c022767c4f4457649f3166","unresolved":false,"context_lines":[{"line_number":725,"context_line":"        self.assertEqual(\u0027SCALE\u0027, body[\u0027operation\u0027])"},{"line_number":726,"context_line":""},{"line_number":727,"context_line":"        vm_infos \u003d self.get_server_details(None)"},{"line_number":728,"context_line":"        vm_ids \u003d ["},{"line_number":729,"context_line":"            vm_info.get(\u0027id\u0027) for vm_info in vm_infos"},{"line_number":730,"context_line":"            if vm_info[\u0027name\u0027] in [\u0027VDU1\u0027]]"},{"line_number":731,"context_line":"        for data in (body[\u0027error\u0027][\u0027userScriptErrHandlingData\u0027]"},{"line_number":732,"context_line":"        [\u0027serverNotification\u0027]):"},{"line_number":733,"context_line":"            self.assertIn(data[\u0027serverId\u0027], vm_ids)"}],"source_content_type":"text/x-python","patch_set":1,"id":"4033488b_d4456fb6","line":730,"range":{"start_line":728,"start_character":0,"end_line":730,"end_character":43},"in_reply_to":"c92486ea_cae28afe","updated":"2023-09-06 01:38:46.000000000","message":"Ack","commit_id":"f4af0b683675c8b18feac2961ddc68b600cc893f"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"f00ffa3ef801c694e259f4b52aa1c857ba39240b","unresolved":true,"context_lines":[{"line_number":725,"context_line":"        self.assertEqual(\u0027SCALE\u0027, body[\u0027operation\u0027])"},{"line_number":726,"context_line":""},{"line_number":727,"context_line":"        vm_infos \u003d self.get_server_details(None)"},{"line_number":728,"context_line":"        vm_ids \u003d ["},{"line_number":729,"context_line":"            vm_info.get(\u0027id\u0027) for vm_info in vm_infos"},{"line_number":730,"context_line":"            if vm_info[\u0027name\u0027] in [\u0027VDU1\u0027]]"},{"line_number":731,"context_line":"        for data in (body[\u0027error\u0027][\u0027userScriptErrHandlingData\u0027]"},{"line_number":732,"context_line":"        [\u0027serverNotification\u0027]):"},{"line_number":733,"context_line":"            self.assertIn(data[\u0027serverId\u0027], vm_ids)"}],"source_content_type":"text/x-python","patch_set":1,"id":"c92486ea_cae28afe","line":730,"range":{"start_line":728,"start_character":0,"end_line":730,"end_character":43},"in_reply_to":"dfffcf50_6069feda","updated":"2023-08-17 02:18:16.000000000","message":"I fixed it in patchset 2.","commit_id":"f4af0b683675c8b18feac2961ddc68b600cc893f"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"613aa2aa16d8d221c56079a7c0c8b26d6d4b19b5","unresolved":true,"context_lines":[{"line_number":909,"context_line":"                           \u0027alarmId\u0027: res[\u0027metadata\u0027][\u0027server_notification\u0027]["},{"line_number":910,"context_line":"                               \u0027alarmId\u0027]} for res in"},{"line_number":911,"context_line":"                          body[\u0027instantiatedVnfInfo\u0027][\u0027vnfcResourceInfo\u0027]]"},{"line_number":912,"context_line":"        alarm_ids \u003d [data[\u0027alarmId\u0027] for data in metadata_infos]"},{"line_number":913,"context_line":"        server_ids \u003d [data[\u0027serverId\u0027] for data in metadata_infos]"},{"line_number":914,"context_line":"        expect_alarm_ids \u003d [\u0027alarm_id_1\u0027, \u0027alarm_id_2\u0027]"},{"line_number":915,"context_line":"        self.assertListEqual(alarm_ids, expect_alarm_ids)"},{"line_number":916,"context_line":""},{"line_number":917,"context_line":"        # 6. LCM-Show-OpOccV2"},{"line_number":918,"context_line":"        resp, body \u003d self.show_lcmocc(lcmocc_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ca3e001c_1fcec8c8","line":915,"range":{"start_line":912,"start_character":0,"end_line":915,"end_character":57},"updated":"2023-08-08 06:22:01.000000000","message":"Could you change `list` to `set` like follow?\n```\n        alarm_ids \u003d {data[\u0027alarmId\u0027] for data in metadata_infos}\n        server_ids \u003d {data[\u0027serverId\u0027] for data in metadata_infos}\n        expect_alarm_ids \u003d {\u0027alarm_id_1\u0027, \u0027alarm_id_2\u0027}\n        self.assertSetEqual(alarm_ids, expect_alarm_ids)\n```\n\nIf you revise it, please do the same revising for subsequent implementations.","commit_id":"f4af0b683675c8b18feac2961ddc68b600cc893f"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b10225feeb007fcc17c022767c4f4457649f3166","unresolved":false,"context_lines":[{"line_number":909,"context_line":"                           \u0027alarmId\u0027: res[\u0027metadata\u0027][\u0027server_notification\u0027]["},{"line_number":910,"context_line":"                               \u0027alarmId\u0027]} for res in"},{"line_number":911,"context_line":"                          body[\u0027instantiatedVnfInfo\u0027][\u0027vnfcResourceInfo\u0027]]"},{"line_number":912,"context_line":"        alarm_ids \u003d [data[\u0027alarmId\u0027] for data in metadata_infos]"},{"line_number":913,"context_line":"        server_ids \u003d [data[\u0027serverId\u0027] for data in metadata_infos]"},{"line_number":914,"context_line":"        expect_alarm_ids \u003d [\u0027alarm_id_1\u0027, \u0027alarm_id_2\u0027]"},{"line_number":915,"context_line":"        self.assertListEqual(alarm_ids, expect_alarm_ids)"},{"line_number":916,"context_line":""},{"line_number":917,"context_line":"        # 6. LCM-Show-OpOccV2"},{"line_number":918,"context_line":"        resp, body \u003d self.show_lcmocc(lcmocc_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7d0aa913_910bf1e8","line":915,"range":{"start_line":912,"start_character":0,"end_line":915,"end_character":57},"in_reply_to":"4b71dd54_ce2964da","updated":"2023-09-06 01:38:46.000000000","message":"Ack","commit_id":"f4af0b683675c8b18feac2961ddc68b600cc893f"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"f00ffa3ef801c694e259f4b52aa1c857ba39240b","unresolved":true,"context_lines":[{"line_number":909,"context_line":"                           \u0027alarmId\u0027: res[\u0027metadata\u0027][\u0027server_notification\u0027]["},{"line_number":910,"context_line":"                               \u0027alarmId\u0027]} for res in"},{"line_number":911,"context_line":"                          body[\u0027instantiatedVnfInfo\u0027][\u0027vnfcResourceInfo\u0027]]"},{"line_number":912,"context_line":"        alarm_ids \u003d [data[\u0027alarmId\u0027] for data in metadata_infos]"},{"line_number":913,"context_line":"        server_ids \u003d [data[\u0027serverId\u0027] for data in metadata_infos]"},{"line_number":914,"context_line":"        expect_alarm_ids \u003d [\u0027alarm_id_1\u0027, \u0027alarm_id_2\u0027]"},{"line_number":915,"context_line":"        self.assertListEqual(alarm_ids, expect_alarm_ids)"},{"line_number":916,"context_line":""},{"line_number":917,"context_line":"        # 6. LCM-Show-OpOccV2"},{"line_number":918,"context_line":"        resp, body \u003d self.show_lcmocc(lcmocc_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"4b71dd54_ce2964da","line":915,"range":{"start_line":912,"start_character":0,"end_line":915,"end_character":57},"in_reply_to":"ca3e001c_1fcec8c8","updated":"2023-08-17 02:18:16.000000000","message":"I fixed it in patchset 2.","commit_id":"f4af0b683675c8b18feac2961ddc68b600cc893f"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"613aa2aa16d8d221c56079a7c0c8b26d6d4b19b5","unresolved":true,"context_lines":[{"line_number":1356,"context_line":"                expect_alarm_ids.remove(data[\u0027alarmId\u0027])"},{"line_number":1357,"context_line":"        self.assertEqual(2, len("},{"line_number":1358,"context_line":"            body[\u0027error\u0027][\u0027userScriptErrHandlingData\u0027][\u0027serverNotification\u0027]))"},{"line_number":1359,"context_line":"        self.assertEqual(0, len(vm_ids))"},{"line_number":1360,"context_line":"        self.assertEqual(1, len(server_ids))"},{"line_number":1361,"context_line":"        self.assertEqual(0, len(expect_alarm_ids))"},{"line_number":1362,"context_line":""},{"line_number":1363,"context_line":"        # 7. LCM-RetryV2"},{"line_number":1364,"context_line":"        resp, body \u003d self.retry_lcmocc(lcmocc_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"4614fdd1_637a9e62","line":1361,"range":{"start_line":1359,"start_character":0,"end_line":1361,"end_character":50},"updated":"2023-08-08 06:22:01.000000000","message":"Other tests don\u0027t implement this assertion. Why are you asserting only this test method?","commit_id":"f4af0b683675c8b18feac2961ddc68b600cc893f"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b10225feeb007fcc17c022767c4f4457649f3166","unresolved":false,"context_lines":[{"line_number":1356,"context_line":"                expect_alarm_ids.remove(data[\u0027alarmId\u0027])"},{"line_number":1357,"context_line":"        self.assertEqual(2, len("},{"line_number":1358,"context_line":"            body[\u0027error\u0027][\u0027userScriptErrHandlingData\u0027][\u0027serverNotification\u0027]))"},{"line_number":1359,"context_line":"        self.assertEqual(0, len(vm_ids))"},{"line_number":1360,"context_line":"        self.assertEqual(1, len(server_ids))"},{"line_number":1361,"context_line":"        self.assertEqual(0, len(expect_alarm_ids))"},{"line_number":1362,"context_line":""},{"line_number":1363,"context_line":"        # 7. LCM-RetryV2"},{"line_number":1364,"context_line":"        resp, body \u003d self.retry_lcmocc(lcmocc_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"d4030da8_0bfbe1f3","line":1361,"range":{"start_line":1359,"start_character":0,"end_line":1361,"end_character":50},"in_reply_to":"22f09ab5_738d6acc","updated":"2023-09-06 01:38:46.000000000","message":"Ack","commit_id":"f4af0b683675c8b18feac2961ddc68b600cc893f"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"f00ffa3ef801c694e259f4b52aa1c857ba39240b","unresolved":true,"context_lines":[{"line_number":1356,"context_line":"                expect_alarm_ids.remove(data[\u0027alarmId\u0027])"},{"line_number":1357,"context_line":"        self.assertEqual(2, len("},{"line_number":1358,"context_line":"            body[\u0027error\u0027][\u0027userScriptErrHandlingData\u0027][\u0027serverNotification\u0027]))"},{"line_number":1359,"context_line":"        self.assertEqual(0, len(vm_ids))"},{"line_number":1360,"context_line":"        self.assertEqual(1, len(server_ids))"},{"line_number":1361,"context_line":"        self.assertEqual(0, len(expect_alarm_ids))"},{"line_number":1362,"context_line":""},{"line_number":1363,"context_line":"        # 7. LCM-RetryV2"},{"line_number":1364,"context_line":"        resp, body \u003d self.retry_lcmocc(lcmocc_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"22f09ab5_738d6acc","line":1361,"range":{"start_line":1359,"start_character":0,"end_line":1361,"end_character":50},"in_reply_to":"4614fdd1_637a9e62","updated":"2023-08-17 02:18:16.000000000","message":"I forgot to delete the assertions here.","commit_id":"f4af0b683675c8b18feac2961ddc68b600cc893f"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"613aa2aa16d8d221c56079a7c0c8b26d6d4b19b5","unresolved":true,"context_lines":[{"line_number":1405,"context_line":"                expect_alarm_ids.remove(data[\u0027alarmId\u0027])"},{"line_number":1406,"context_line":"        self.assertEqual(2, len("},{"line_number":1407,"context_line":"            body[\u0027error\u0027][\u0027userScriptErrHandlingData\u0027][\u0027serverNotification\u0027]))"},{"line_number":1408,"context_line":"        self.assertEqual(0, len(vm_ids))"},{"line_number":1409,"context_line":"        self.assertEqual(1, len(server_ids))"},{"line_number":1410,"context_line":"        self.assertEqual(0, len(expect_alarm_ids))"},{"line_number":1411,"context_line":""},{"line_number":1412,"context_line":"        # 10. LCM-FailV2"},{"line_number":1413,"context_line":"        resp, body \u003d self.fail_lcmocc(lcmocc_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf8b8c50_12d0cf64","line":1410,"range":{"start_line":1408,"start_character":0,"end_line":1410,"end_character":50},"updated":"2023-08-08 06:22:01.000000000","message":"ditto.","commit_id":"f4af0b683675c8b18feac2961ddc68b600cc893f"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b10225feeb007fcc17c022767c4f4457649f3166","unresolved":false,"context_lines":[{"line_number":1405,"context_line":"                expect_alarm_ids.remove(data[\u0027alarmId\u0027])"},{"line_number":1406,"context_line":"        self.assertEqual(2, len("},{"line_number":1407,"context_line":"            body[\u0027error\u0027][\u0027userScriptErrHandlingData\u0027][\u0027serverNotification\u0027]))"},{"line_number":1408,"context_line":"        self.assertEqual(0, len(vm_ids))"},{"line_number":1409,"context_line":"        self.assertEqual(1, len(server_ids))"},{"line_number":1410,"context_line":"        self.assertEqual(0, len(expect_alarm_ids))"},{"line_number":1411,"context_line":""},{"line_number":1412,"context_line":"        # 10. LCM-FailV2"},{"line_number":1413,"context_line":"        resp, body \u003d self.fail_lcmocc(lcmocc_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"58860525_80ad55e2","line":1410,"range":{"start_line":1408,"start_character":0,"end_line":1410,"end_character":50},"in_reply_to":"252b3dfd_bc55949b","updated":"2023-09-06 01:38:46.000000000","message":"Ack","commit_id":"f4af0b683675c8b18feac2961ddc68b600cc893f"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"f00ffa3ef801c694e259f4b52aa1c857ba39240b","unresolved":true,"context_lines":[{"line_number":1405,"context_line":"                expect_alarm_ids.remove(data[\u0027alarmId\u0027])"},{"line_number":1406,"context_line":"        self.assertEqual(2, len("},{"line_number":1407,"context_line":"            body[\u0027error\u0027][\u0027userScriptErrHandlingData\u0027][\u0027serverNotification\u0027]))"},{"line_number":1408,"context_line":"        self.assertEqual(0, len(vm_ids))"},{"line_number":1409,"context_line":"        self.assertEqual(1, len(server_ids))"},{"line_number":1410,"context_line":"        self.assertEqual(0, len(expect_alarm_ids))"},{"line_number":1411,"context_line":""},{"line_number":1412,"context_line":"        # 10. LCM-FailV2"},{"line_number":1413,"context_line":"        resp, body \u003d self.fail_lcmocc(lcmocc_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"252b3dfd_bc55949b","line":1410,"range":{"start_line":1408,"start_character":0,"end_line":1410,"end_character":50},"in_reply_to":"bf8b8c50_12d0cf64","updated":"2023-08-17 02:18:16.000000000","message":"I forgot to delete the assertions here.","commit_id":"f4af0b683675c8b18feac2961ddc68b600cc893f"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"613aa2aa16d8d221c56079a7c0c8b26d6d4b19b5","unresolved":true,"context_lines":[{"line_number":1438,"context_line":"                expect_alarm_ids.remove(data[\u0027alarmId\u0027])"},{"line_number":1439,"context_line":"        self.assertEqual(2, len("},{"line_number":1440,"context_line":"            body[\u0027error\u0027][\u0027userScriptErrHandlingData\u0027][\u0027serverNotification\u0027]))"},{"line_number":1441,"context_line":"        self.assertEqual(0, len(vm_ids))"},{"line_number":1442,"context_line":"        self.assertEqual(1, len(server_ids))"},{"line_number":1443,"context_line":"        self.assertEqual(0, len(expect_alarm_ids))"},{"line_number":1444,"context_line":""},{"line_number":1445,"context_line":"        # 12. LCM-TerminateV2"},{"line_number":1446,"context_line":"        terminate_req \u003d paramgen.terminate_vnf_min()"}],"source_content_type":"text/x-python","patch_set":1,"id":"3843da09_7762c536","line":1443,"range":{"start_line":1441,"start_character":0,"end_line":1443,"end_character":50},"updated":"2023-08-08 06:22:01.000000000","message":"ditto.","commit_id":"f4af0b683675c8b18feac2961ddc68b600cc893f"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"f00ffa3ef801c694e259f4b52aa1c857ba39240b","unresolved":true,"context_lines":[{"line_number":1438,"context_line":"                expect_alarm_ids.remove(data[\u0027alarmId\u0027])"},{"line_number":1439,"context_line":"        self.assertEqual(2, len("},{"line_number":1440,"context_line":"            body[\u0027error\u0027][\u0027userScriptErrHandlingData\u0027][\u0027serverNotification\u0027]))"},{"line_number":1441,"context_line":"        self.assertEqual(0, len(vm_ids))"},{"line_number":1442,"context_line":"        self.assertEqual(1, len(server_ids))"},{"line_number":1443,"context_line":"        self.assertEqual(0, len(expect_alarm_ids))"},{"line_number":1444,"context_line":""},{"line_number":1445,"context_line":"        # 12. LCM-TerminateV2"},{"line_number":1446,"context_line":"        terminate_req \u003d paramgen.terminate_vnf_min()"}],"source_content_type":"text/x-python","patch_set":1,"id":"91b87f6f_4661dd2f","line":1443,"range":{"start_line":1441,"start_character":0,"end_line":1443,"end_character":50},"in_reply_to":"3843da09_7762c536","updated":"2023-08-17 02:18:16.000000000","message":"I forgot to delete the assertions here.","commit_id":"f4af0b683675c8b18feac2961ddc68b600cc893f"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b10225feeb007fcc17c022767c4f4457649f3166","unresolved":false,"context_lines":[{"line_number":1438,"context_line":"                expect_alarm_ids.remove(data[\u0027alarmId\u0027])"},{"line_number":1439,"context_line":"        self.assertEqual(2, len("},{"line_number":1440,"context_line":"            body[\u0027error\u0027][\u0027userScriptErrHandlingData\u0027][\u0027serverNotification\u0027]))"},{"line_number":1441,"context_line":"        self.assertEqual(0, len(vm_ids))"},{"line_number":1442,"context_line":"        self.assertEqual(1, len(server_ids))"},{"line_number":1443,"context_line":"        self.assertEqual(0, len(expect_alarm_ids))"},{"line_number":1444,"context_line":""},{"line_number":1445,"context_line":"        # 12. LCM-TerminateV2"},{"line_number":1446,"context_line":"        terminate_req \u003d paramgen.terminate_vnf_min()"}],"source_content_type":"text/x-python","patch_set":1,"id":"6c89500d_52db9179","line":1443,"range":{"start_line":1441,"start_character":0,"end_line":1443,"end_character":50},"in_reply_to":"91b87f6f_4661dd2f","updated":"2023-09-06 01:38:46.000000000","message":"Ack","commit_id":"f4af0b683675c8b18feac2961ddc68b600cc893f"}],"tacker/tests/functional/sol_v2_common/base_v2.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"613aa2aa16d8d221c56079a7c0c8b26d6d4b19b5","unresolved":true,"context_lines":[{"line_number":166,"context_line":"        for server in resp_body.get(\u0027servers\u0027):"},{"line_number":167,"context_line":"            if server_name \u003d\u003d server[\u0027name\u0027]:"},{"line_number":168,"context_line":"                server_details \u003d server"},{"line_number":169,"context_line":"        if server_name:"},{"line_number":170,"context_line":"            return server_details"},{"line_number":171,"context_line":"        return resp_body.get(\u0027servers\u0027)"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    def get_zone_list(self):"},{"line_number":174,"context_line":"        path \u003d \"/os-services\""}],"source_content_type":"text/x-python","patch_set":1,"id":"af9ab5e6_ba786b0e","line":171,"range":{"start_line":169,"start_character":0,"end_line":171,"end_character":39},"updated":"2023-08-08 06:22:01.000000000","message":"I think it is better to put the following lines to L164 instead of this change. What do you think?\n\n```\nif server_name is None:\n    return resp_body.get(\u0027servers\u0027)\n```","commit_id":"f4af0b683675c8b18feac2961ddc68b600cc893f"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b10225feeb007fcc17c022767c4f4457649f3166","unresolved":false,"context_lines":[{"line_number":166,"context_line":"        for server in resp_body.get(\u0027servers\u0027):"},{"line_number":167,"context_line":"            if server_name \u003d\u003d server[\u0027name\u0027]:"},{"line_number":168,"context_line":"                server_details \u003d server"},{"line_number":169,"context_line":"        if server_name:"},{"line_number":170,"context_line":"            return server_details"},{"line_number":171,"context_line":"        return resp_body.get(\u0027servers\u0027)"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    def get_zone_list(self):"},{"line_number":174,"context_line":"        path \u003d \"/os-services\""}],"source_content_type":"text/x-python","patch_set":1,"id":"23529136_69c88911","line":171,"range":{"start_line":169,"start_character":0,"end_line":171,"end_character":39},"in_reply_to":"ae42f9ca_71aba663","updated":"2023-09-06 01:38:46.000000000","message":"Ack","commit_id":"f4af0b683675c8b18feac2961ddc68b600cc893f"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"f00ffa3ef801c694e259f4b52aa1c857ba39240b","unresolved":true,"context_lines":[{"line_number":166,"context_line":"        for server in resp_body.get(\u0027servers\u0027):"},{"line_number":167,"context_line":"            if server_name \u003d\u003d server[\u0027name\u0027]:"},{"line_number":168,"context_line":"                server_details \u003d server"},{"line_number":169,"context_line":"        if server_name:"},{"line_number":170,"context_line":"            return server_details"},{"line_number":171,"context_line":"        return resp_body.get(\u0027servers\u0027)"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    def get_zone_list(self):"},{"line_number":174,"context_line":"        path \u003d \"/os-services\""}],"source_content_type":"text/x-python","patch_set":1,"id":"ae42f9ca_71aba663","line":171,"range":{"start_line":169,"start_character":0,"end_line":171,"end_character":39},"in_reply_to":"af9ab5e6_ba786b0e","updated":"2023-08-17 02:18:16.000000000","message":"I fixed it in patchset 2.","commit_id":"f4af0b683675c8b18feac2961ddc68b600cc893f"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"613aa2aa16d8d221c56079a7c0c8b26d6d4b19b5","unresolved":true,"context_lines":[{"line_number":233,"context_line":"        for image_id in image_ids:"},{"line_number":234,"context_line":"            glance_client.delete_image(image_id)"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"    def update_vnf_instance(self, inst_id, req_body):"},{"line_number":237,"context_line":"        path \u003d f\"/vnflcm/v2/vnf_instances/{inst_id}\""},{"line_number":238,"context_line":"        return self.tacker_client.do_request("},{"line_number":239,"context_line":"            path, \"PATCH\", body\u003dreq_body, version\u003dVNFLCM_V2_VERSION)"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    def change_ext_conn(self, inst_id, req_body):"},{"line_number":242,"context_line":"        path \u003d f\"/vnflcm/v2/vnf_instances/{inst_id}/change_ext_conn\""}],"source_content_type":"text/x-python","patch_set":1,"id":"39709c51_2150b764","line":239,"range":{"start_line":236,"start_character":0,"end_line":239,"end_character":68},"updated":"2023-08-08 06:22:01.000000000","message":"This method has been moved to tacker/tests/functional/base_v2.py in the parent patch.\nI think there is no need to add this method to this file, what do you think?","commit_id":"f4af0b683675c8b18feac2961ddc68b600cc893f"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"f00ffa3ef801c694e259f4b52aa1c857ba39240b","unresolved":true,"context_lines":[{"line_number":233,"context_line":"        for image_id in image_ids:"},{"line_number":234,"context_line":"            glance_client.delete_image(image_id)"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"    def update_vnf_instance(self, inst_id, req_body):"},{"line_number":237,"context_line":"        path \u003d f\"/vnflcm/v2/vnf_instances/{inst_id}\""},{"line_number":238,"context_line":"        return self.tacker_client.do_request("},{"line_number":239,"context_line":"            path, \"PATCH\", body\u003dreq_body, version\u003dVNFLCM_V2_VERSION)"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    def change_ext_conn(self, inst_id, req_body):"},{"line_number":242,"context_line":"        path \u003d f\"/vnflcm/v2/vnf_instances/{inst_id}/change_ext_conn\""}],"source_content_type":"text/x-python","patch_set":1,"id":"d6b3316b_888cd07b","line":239,"range":{"start_line":236,"start_character":0,"end_line":239,"end_character":68},"in_reply_to":"39709c51_2150b764","updated":"2023-08-17 02:18:16.000000000","message":"Sorry, when merging the parent patch, I forgot to delete the code here.\nI fixed it in patchset 2.","commit_id":"f4af0b683675c8b18feac2961ddc68b600cc893f"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b10225feeb007fcc17c022767c4f4457649f3166","unresolved":false,"context_lines":[{"line_number":233,"context_line":"        for image_id in image_ids:"},{"line_number":234,"context_line":"            glance_client.delete_image(image_id)"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"    def update_vnf_instance(self, inst_id, req_body):"},{"line_number":237,"context_line":"        path \u003d f\"/vnflcm/v2/vnf_instances/{inst_id}\""},{"line_number":238,"context_line":"        return self.tacker_client.do_request("},{"line_number":239,"context_line":"            path, \"PATCH\", body\u003dreq_body, version\u003dVNFLCM_V2_VERSION)"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    def change_ext_conn(self, inst_id, req_body):"},{"line_number":242,"context_line":"        path \u003d f\"/vnflcm/v2/vnf_instances/{inst_id}/change_ext_conn\""}],"source_content_type":"text/x-python","patch_set":1,"id":"84834fa8_cb0ad53e","line":239,"range":{"start_line":236,"start_character":0,"end_line":239,"end_character":68},"in_reply_to":"d6b3316b_888cd07b","updated":"2023-09-06 01:38:46.000000000","message":"Ack","commit_id":"f4af0b683675c8b18feac2961ddc68b600cc893f"}]}