)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"f9a9c1ec90c285d73a30e7ce7da628658a4a7986","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Naoaki Horie \u003chorie.naoaki@ntt-tx.co.jp\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-10-26 08:27:16 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Terraform Infra-Driver Change VNF Package"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch provides Change current VNF package API and"},{"line_number":10,"context_line":"Rollback of its operation for the Terraform infra-driver."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"ecbc1753_d7070831","line":7,"updated":"2023-11-09 08:36:46.000000000","message":"Could you add a releasenote for this feature?","commit_id":"cb166f817ac95f17c5e6ed3846ef7b1a026eee6e"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"f9a9c1ec90c285d73a30e7ce7da628658a4a7986","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Naoaki Horie \u003chorie.naoaki@ntt-tx.co.jp\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-10-26 08:27:16 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Terraform Infra-Driver Change VNF Package"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch provides Change current VNF package API and"},{"line_number":10,"context_line":"Rollback of its operation for the Terraform infra-driver."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"a3e0be16_16e02d80","line":7,"updated":"2023-11-09 08:36:46.000000000","message":"Just a confirmation,\n\nThe previously posted terraform Spec [1] does not mention the functionality of the Change current vnf package.\nIs it agreed that Spec is not needed for this feature?\n\n[1] https://specs.openstack.org/openstack/tacker-specs/specs/2023.2/tf-infra-driver/index.html","commit_id":"cb166f817ac95f17c5e6ed3846ef7b1a026eee6e"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"3ab779ba089559e8528de94f7913f3d7aa1cbeea","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Naoaki Horie \u003chorie.naoaki@ntt-tx.co.jp\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-10-26 08:27:16 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Terraform Infra-Driver Change VNF Package"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch provides Change current VNF package API and"},{"line_number":10,"context_line":"Rollback of its operation for the Terraform infra-driver."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"c6f7543b_30be0598","line":7,"in_reply_to":"71412c5a_3579cc89","updated":"2023-11-15 02:23:40.000000000","message":"Ack","commit_id":"cb166f817ac95f17c5e6ed3846ef7b1a026eee6e"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"dca9c90473c5838b1f8a01ec36bce6982f28633b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Naoaki Horie \u003chorie.naoaki@ntt-tx.co.jp\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-10-26 08:27:16 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Terraform Infra-Driver Change VNF Package"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch provides Change current VNF package API and"},{"line_number":10,"context_line":"Rollback of its operation for the Terraform infra-driver."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"1f7cacab_6e39400c","line":7,"in_reply_to":"91e9d5fb_92db352d","updated":"2023-11-14 01:19:55.000000000","message":"Thanks for your answer, I understood.","commit_id":"cb166f817ac95f17c5e6ed3846ef7b1a026eee6e"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"bf19e5eb17a7fd02b9994abfa436d8c04f021c2f","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Naoaki Horie \u003chorie.naoaki@ntt-tx.co.jp\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-10-26 08:27:16 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Terraform Infra-Driver Change VNF Package"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch provides Change current VNF package API and"},{"line_number":10,"context_line":"Rollback of its operation for the Terraform infra-driver."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"91e9d5fb_92db352d","line":7,"in_reply_to":"a3e0be16_16e02d80","updated":"2023-11-13 12:10:55.000000000","message":"Hi, we have had a similar comment in our internal discussion and we don\u0027t need to do so because the change is just adding a feature has no impact on the current implementation, so blueprint is enough for the change instead.\n\nYasufumi","commit_id":"cb166f817ac95f17c5e6ed3846ef7b1a026eee6e"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"99b69dfe8b001cafb075ac852b5eec081ac479b1","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Naoaki Horie \u003chorie.naoaki@ntt-tx.co.jp\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-10-26 08:27:16 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Terraform Infra-Driver Change VNF Package"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch provides Change current VNF package API and"},{"line_number":10,"context_line":"Rollback of its operation for the Terraform infra-driver."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"71412c5a_3579cc89","line":7,"in_reply_to":"ecbc1753_d7070831","updated":"2023-11-14 05:19:29.000000000","message":"Add a new release note in Patchset 15.","commit_id":"cb166f817ac95f17c5e6ed3846ef7b1a026eee6e"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"f9a9c1ec90c285d73a30e7ce7da628658a4a7986","unresolved":true,"context_lines":[{"line_number":14,"context_line":"(Rollback is the opposite of this)."},{"line_number":15,"context_line":"Therefore, there are no limitation in tf file."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This patche also includes tiny refactoring of"},{"line_number":18,"context_line":"tacker/sol_refactored/infra_drivers/terraform/terraform.py"},{"line_number":19,"context_line":"as follows:"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"d8a4171e_cfcc234f","line":17,"range":{"start_line":17,"start_character":5,"end_line":17,"end_character":11},"updated":"2023-11-09 08:36:46.000000000","message":"typo: patch","commit_id":"cb166f817ac95f17c5e6ed3846ef7b1a026eee6e"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"3ab779ba089559e8528de94f7913f3d7aa1cbeea","unresolved":false,"context_lines":[{"line_number":14,"context_line":"(Rollback is the opposite of this)."},{"line_number":15,"context_line":"Therefore, there are no limitation in tf file."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This patche also includes tiny refactoring of"},{"line_number":18,"context_line":"tacker/sol_refactored/infra_drivers/terraform/terraform.py"},{"line_number":19,"context_line":"as follows:"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"e08b7484_4898487c","line":17,"range":{"start_line":17,"start_character":5,"end_line":17,"end_character":11},"in_reply_to":"bde31508_3f4a77cf","updated":"2023-11-15 02:23:40.000000000","message":"Ack","commit_id":"cb166f817ac95f17c5e6ed3846ef7b1a026eee6e"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"99b69dfe8b001cafb075ac852b5eec081ac479b1","unresolved":true,"context_lines":[{"line_number":14,"context_line":"(Rollback is the opposite of this)."},{"line_number":15,"context_line":"Therefore, there are no limitation in tf file."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This patche also includes tiny refactoring of"},{"line_number":18,"context_line":"tacker/sol_refactored/infra_drivers/terraform/terraform.py"},{"line_number":19,"context_line":"as follows:"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"bde31508_3f4a77cf","line":17,"range":{"start_line":17,"start_character":5,"end_line":17,"end_character":11},"in_reply_to":"d8a4171e_cfcc234f","updated":"2023-11-14 05:19:29.000000000","message":"Correct in Patchset 15.","commit_id":"cb166f817ac95f17c5e6ed3846ef7b1a026eee6e"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"f9a9c1ec90c285d73a30e7ce7da628658a4a7986","unresolved":true,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"[1] https://docs.python.org/ja/3/library/subprocess.html"},{"line_number":30,"context_line":"[2] https://github.com/openstack/tacker/blob/master/tacker/sol_refactored/infra_drivers/kubernetes/helm_utils.py#L33C1-L41C22"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Change-Id: I00d883f879d9e4a0d72d4e78cb4d0071649fb5ad"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"17908b34_2acb0be7","line":31,"updated":"2023-11-09 08:36:46.000000000","message":"Could you add a Implements tag?\nImplements: blueprint terraform-infra-driver-ccvp","commit_id":"cb166f817ac95f17c5e6ed3846ef7b1a026eee6e"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"99b69dfe8b001cafb075ac852b5eec081ac479b1","unresolved":true,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"[1] https://docs.python.org/ja/3/library/subprocess.html"},{"line_number":30,"context_line":"[2] https://github.com/openstack/tacker/blob/master/tacker/sol_refactored/infra_drivers/kubernetes/helm_utils.py#L33C1-L41C22"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Change-Id: I00d883f879d9e4a0d72d4e78cb4d0071649fb5ad"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"8748685a_3dff6a5c","line":31,"in_reply_to":"17908b34_2acb0be7","updated":"2023-11-14 05:19:29.000000000","message":"Add a Implements tag in Patchset 15.","commit_id":"cb166f817ac95f17c5e6ed3846ef7b1a026eee6e"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"3ab779ba089559e8528de94f7913f3d7aa1cbeea","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"[1] https://docs.python.org/ja/3/library/subprocess.html"},{"line_number":30,"context_line":"[2] https://github.com/openstack/tacker/blob/master/tacker/sol_refactored/infra_drivers/kubernetes/helm_utils.py#L33C1-L41C22"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Change-Id: I00d883f879d9e4a0d72d4e78cb4d0071649fb5ad"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"93c048e8_9ed42274","line":31,"in_reply_to":"8748685a_3dff6a5c","updated":"2023-11-15 02:23:40.000000000","message":"Ack","commit_id":"cb166f817ac95f17c5e6ed3846ef7b1a026eee6e"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"f1a7016d2e44ddc634e4f84bebda34b04838aaf6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5af041d8_243bc253","updated":"2023-09-12 09:12:31.000000000","message":"Thanks for your patch. I\u0027d like to confirm that is this patch WIP?\nThe spec [1] didn\u0027t mention `ChangeCurrentVnfPackage`, so is it a pre-implementation and doesn\u0027t need to be merged in Bobcat cycles?\n\n[1] https://review.opendev.org/c/openstack/tacker-specs/+/878824","commit_id":"efc7525910d1ab7ea409c86aa473559c3747de0f"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"0403a5d2c68895425f0778cc4094106fd47e9a5b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c6338b66_66a2964d","in_reply_to":"5af041d8_243bc253","updated":"2023-09-19 04:25:03.000000000","message":"Sorry for the late reply\n\n\u003e  doesn\u0027t need to be merged in Bobcat cycles?\n\nYes. \n\n\u003e  is this patch WIP\n\nI\u0027d say it\u0027s not WIP as the development of codes and UT are completed although FTs haven\u0027t been implemented. \nI think it can be merged, but it might be better to merge it after implementing FTs.","commit_id":"efc7525910d1ab7ea409c86aa473559c3747de0f"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"f9a9c1ec90c285d73a30e7ce7da628658a4a7986","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b3276fa0_31b9b3f6","in_reply_to":"aa0c92c3_372268dc","updated":"2023-11-09 08:36:46.000000000","message":"Done","commit_id":"efc7525910d1ab7ea409c86aa473559c3747de0f"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"06e18275259638cbdcfd78421e944d46e4fc8291","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"aa0c92c3_372268dc","in_reply_to":"c6338b66_66a2964d","updated":"2023-09-29 00:53:57.000000000","message":"Thanks for your reply, \n\n\u003e I\u0027d say it\u0027s not WIP as the development of codes and UT are completed although FTs haven\u0027t been implemented.\n\nThere are some fixes in the base Terraform driver patch [1], so it should be fixed after the rebase, and there are some errors in pep8, so it should be fixed too.\n\n[1] https://review.opendev.org/c/openstack/tacker/+/890611\n\n\u003e it might be better to merge it after implementing FTs.\n\nI agree, it is strange that only the VNF Package is added and the FT code itself that use the VNF Package is not implemented.","commit_id":"efc7525910d1ab7ea409c86aa473559c3747de0f"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"efeef96be5531c085c4e60d80bc73397e40d44a1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"77515f14_2da2f07c","updated":"2023-10-23 23:59:43.000000000","message":"recheck","commit_id":"4ef4a5f96f472bd888b06dd5f6e04a2560dda8a0"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"f222324d117f1e6076e0521ce411bd424dd37749","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"b1506641_d6269e6f","updated":"2023-11-08 06:55:03.000000000","message":"Could you change the topic to `terraform-infra-driver-ccvp` [1]?\n[1] https://blueprints.launchpad.net/tacker/+spec/terraform-infra-driver-ccvp","commit_id":"cb166f817ac95f17c5e6ed3846ef7b1a026eee6e"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"a1481663ca633fdf4bbc6596697f7ca18bd4e806","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"529cf070_f90436a2","updated":"2023-11-08 06:49:19.000000000","message":"LGTM","commit_id":"cb166f817ac95f17c5e6ed3846ef7b1a026eee6e"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"f9a9c1ec90c285d73a30e7ce7da628658a4a7986","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"81f019d9_344265f1","updated":"2023-11-09 08:36:46.000000000","message":"Thanks for your update, please find my comments.","commit_id":"cb166f817ac95f17c5e6ed3846ef7b1a026eee6e"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"d3742034eb9c0fc08ee443c622e5445cc35fd0e7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"7061f1c0_06afe098","updated":"2023-11-15 05:42:54.000000000","message":"LGTM, thanks!","commit_id":"821e1ecd8d72a404f0cde9ed42031832b132b311"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"99b69dfe8b001cafb075ac852b5eec081ac479b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"b0d2c4b9_18e6d60a","updated":"2023-11-14 05:19:29.000000000","message":"Thank you for your review. I reflect your comment, kindly take a confirm.","commit_id":"821e1ecd8d72a404f0cde9ed42031832b132b311"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"3ab779ba089559e8528de94f7913f3d7aa1cbeea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"4f8106bd_200a2e2a","updated":"2023-11-15 02:23:40.000000000","message":"Thanks for your update, LGTM.","commit_id":"821e1ecd8d72a404f0cde9ed42031832b132b311"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"ceaefd30b248220a40d62bc4bbf1e4d9f9e03a1a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"c91f24c6_bd386e0d","updated":"2023-11-14 08:57:38.000000000","message":"recheck","commit_id":"821e1ecd8d72a404f0cde9ed42031832b132b311"}],"tacker/sol_refactored/infra_drivers/terraform/terraform.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"f9a9c1ec90c285d73a30e7ce7da628658a4a7986","unresolved":true,"context_lines":[{"line_number":260,"context_line":"            inst_vnf_info.metadata.update(inst.instantiatedVnfInfo.metadata)"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"        # Store tf_dir_path"},{"line_number":263,"context_line":"        if op \u003d\u003d v2fields.LcmOperationType.INSTANTIATE or tf_var_path:"},{"line_number":264,"context_line":"            inst_vnf_info.metadata[\u0027tf_dir_path\u0027] \u003d tf_dir_path"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"        # Store tf_var_path"}],"source_content_type":"text/x-python","patch_set":14,"id":"5ef211f8_61b58af5","line":263,"range":{"start_line":263,"start_character":58,"end_line":263,"end_character":69},"updated":"2023-11-09 08:36:46.000000000","message":"Is this `tf_var_path` correct? Based on the processing and comments, `tf_dir_path` seems to be correct.","commit_id":"cb166f817ac95f17c5e6ed3846ef7b1a026eee6e"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"3ab779ba089559e8528de94f7913f3d7aa1cbeea","unresolved":false,"context_lines":[{"line_number":260,"context_line":"            inst_vnf_info.metadata.update(inst.instantiatedVnfInfo.metadata)"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"        # Store tf_dir_path"},{"line_number":263,"context_line":"        if op \u003d\u003d v2fields.LcmOperationType.INSTANTIATE or tf_var_path:"},{"line_number":264,"context_line":"            inst_vnf_info.metadata[\u0027tf_dir_path\u0027] \u003d tf_dir_path"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"        # Store tf_var_path"}],"source_content_type":"text/x-python","patch_set":14,"id":"90eb5787_4c2b8dc1","line":263,"range":{"start_line":263,"start_character":58,"end_line":263,"end_character":69},"in_reply_to":"5405bfcc_f30feba1","updated":"2023-11-15 02:23:40.000000000","message":"Ack","commit_id":"cb166f817ac95f17c5e6ed3846ef7b1a026eee6e"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"99b69dfe8b001cafb075ac852b5eec081ac479b1","unresolved":true,"context_lines":[{"line_number":260,"context_line":"            inst_vnf_info.metadata.update(inst.instantiatedVnfInfo.metadata)"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"        # Store tf_dir_path"},{"line_number":263,"context_line":"        if op \u003d\u003d v2fields.LcmOperationType.INSTANTIATE or tf_var_path:"},{"line_number":264,"context_line":"            inst_vnf_info.metadata[\u0027tf_dir_path\u0027] \u003d tf_dir_path"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"        # Store tf_var_path"}],"source_content_type":"text/x-python","patch_set":14,"id":"5405bfcc_f30feba1","line":263,"range":{"start_line":263,"start_character":58,"end_line":263,"end_character":69},"in_reply_to":"5ef211f8_61b58af5","updated":"2023-11-14 05:19:29.000000000","message":"Fixed in Patchset 15.","commit_id":"cb166f817ac95f17c5e6ed3846ef7b1a026eee6e"}],"tacker/tests/functional/sol_terraform_v2/base_v2.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"f9a9c1ec90c285d73a30e7ce7da628658a4a7986","unresolved":true,"context_lines":[{"line_number":31,"context_line":"                 version\u003d\u0027%%prog %s\u0027 % version.version_info.release_string())"},{"line_number":32,"context_line":"        objects.register_all()"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @classmethod"},{"line_number":35,"context_line":"    def create_vnf_package(cls, sample_path, user_data\u003d{},"},{"line_number":36,"context_line":"                           image_path\u003dNone, nfvo\u003dFalse, userdata_path\u003dNone,"},{"line_number":37,"context_line":"                           provider\u003dNone, vnfd_id\u003dNone):"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        return super().create_vnf_package(sample_path, user_data\u003duser_data,"},{"line_number":40,"context_line":"                                          image_path\u003dimage_path, nfvo\u003dnfvo,"},{"line_number":41,"context_line":"                                          userdata_path\u003duserdata_path,"},{"line_number":42,"context_line":"                                          provider\u003dprovider, vnfd_id\u003dvnfd_id)"}],"source_content_type":"text/x-python","patch_set":14,"id":"b83d012b_9e220341","line":42,"range":{"start_line":34,"start_character":0,"end_line":42,"end_character":77},"updated":"2023-11-09 08:36:46.000000000","message":"If you just call create_vnf_package on BaseClass, this definition doesn\u0027t seem necessary.\nIs there any reason why this override is necessary?","commit_id":"cb166f817ac95f17c5e6ed3846ef7b1a026eee6e"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"99b69dfe8b001cafb075ac852b5eec081ac479b1","unresolved":true,"context_lines":[{"line_number":31,"context_line":"                 version\u003d\u0027%%prog %s\u0027 % version.version_info.release_string())"},{"line_number":32,"context_line":"        objects.register_all()"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @classmethod"},{"line_number":35,"context_line":"    def create_vnf_package(cls, sample_path, user_data\u003d{},"},{"line_number":36,"context_line":"                           image_path\u003dNone, nfvo\u003dFalse, userdata_path\u003dNone,"},{"line_number":37,"context_line":"                           provider\u003dNone, vnfd_id\u003dNone):"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        return super().create_vnf_package(sample_path, user_data\u003duser_data,"},{"line_number":40,"context_line":"                                          image_path\u003dimage_path, nfvo\u003dnfvo,"},{"line_number":41,"context_line":"                                          userdata_path\u003duserdata_path,"},{"line_number":42,"context_line":"                                          provider\u003dprovider, vnfd_id\u003dvnfd_id)"}],"source_content_type":"text/x-python","patch_set":14,"id":"dbd15cf4_27f59d0c","line":42,"range":{"start_line":34,"start_character":0,"end_line":42,"end_character":77},"in_reply_to":"b83d012b_9e220341","updated":"2023-11-14 05:19:29.000000000","message":"It\u0027s exactly as you said. I delete it.","commit_id":"cb166f817ac95f17c5e6ed3846ef7b1a026eee6e"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"3ab779ba089559e8528de94f7913f3d7aa1cbeea","unresolved":false,"context_lines":[{"line_number":31,"context_line":"                 version\u003d\u0027%%prog %s\u0027 % version.version_info.release_string())"},{"line_number":32,"context_line":"        objects.register_all()"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @classmethod"},{"line_number":35,"context_line":"    def create_vnf_package(cls, sample_path, user_data\u003d{},"},{"line_number":36,"context_line":"                           image_path\u003dNone, nfvo\u003dFalse, userdata_path\u003dNone,"},{"line_number":37,"context_line":"                           provider\u003dNone, vnfd_id\u003dNone):"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        return super().create_vnf_package(sample_path, user_data\u003duser_data,"},{"line_number":40,"context_line":"                                          image_path\u003dimage_path, nfvo\u003dnfvo,"},{"line_number":41,"context_line":"                                          userdata_path\u003duserdata_path,"},{"line_number":42,"context_line":"                                          provider\u003dprovider, vnfd_id\u003dvnfd_id)"}],"source_content_type":"text/x-python","patch_set":14,"id":"68ae654a_00152777","line":42,"range":{"start_line":34,"start_character":0,"end_line":42,"end_character":77},"in_reply_to":"dbd15cf4_27f59d0c","updated":"2023-11-15 02:23:40.000000000","message":"Ack","commit_id":"cb166f817ac95f17c5e6ed3846ef7b1a026eee6e"}],"tacker/tests/functional/sol_terraform_v2/samples/test_terraform_change_vnf_package/contents/Definitions/sample_tf_types.yaml":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"f9a9c1ec90c285d73a30e7ce7da628658a4a7986","unresolved":true,"context_lines":[{"line_number":38,"context_line":"        default: [ Tacker ]"},{"line_number":39,"context_line":"      flavour_id:"},{"line_number":40,"context_line":"        type: string"},{"line_number":41,"context_line":"        constraints: [ valid_values: [ simple,complex ] ]"},{"line_number":42,"context_line":"        default: simple"},{"line_number":43,"context_line":"      flavour_description:"},{"line_number":44,"context_line":"        type: string"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"c81f743d_64924f25","line":41,"range":{"start_line":41,"start_character":45,"end_line":41,"end_character":53},"updated":"2023-11-09 08:36:46.000000000","message":"nit: Is flavour_id\u003d`complex` needed to define?","commit_id":"cb166f817ac95f17c5e6ed3846ef7b1a026eee6e"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"3ab779ba089559e8528de94f7913f3d7aa1cbeea","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        default: [ Tacker ]"},{"line_number":39,"context_line":"      flavour_id:"},{"line_number":40,"context_line":"        type: string"},{"line_number":41,"context_line":"        constraints: [ valid_values: [ simple,complex ] ]"},{"line_number":42,"context_line":"        default: simple"},{"line_number":43,"context_line":"      flavour_description:"},{"line_number":44,"context_line":"        type: string"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"38ac38ae_4237d519","line":41,"range":{"start_line":41,"start_character":45,"end_line":41,"end_character":53},"in_reply_to":"6b66eb26_f74a8a09","updated":"2023-11-15 02:23:40.000000000","message":"Ack","commit_id":"cb166f817ac95f17c5e6ed3846ef7b1a026eee6e"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"99b69dfe8b001cafb075ac852b5eec081ac479b1","unresolved":true,"context_lines":[{"line_number":38,"context_line":"        default: [ Tacker ]"},{"line_number":39,"context_line":"      flavour_id:"},{"line_number":40,"context_line":"        type: string"},{"line_number":41,"context_line":"        constraints: [ valid_values: [ simple,complex ] ]"},{"line_number":42,"context_line":"        default: simple"},{"line_number":43,"context_line":"      flavour_description:"},{"line_number":44,"context_line":"        type: string"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"6b66eb26_f74a8a09","line":41,"range":{"start_line":41,"start_character":45,"end_line":41,"end_character":53},"in_reply_to":"c81f743d_64924f25","updated":"2023-11-14 05:19:29.000000000","message":"`complex` is unnecessary, so delete it.","commit_id":"cb166f817ac95f17c5e6ed3846ef7b1a026eee6e"}],"tacker/tests/functional/sol_terraform_v2/test_terraform.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"f9a9c1ec90c285d73a30e7ce7da628658a4a7986","unresolved":true,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        lcmocc_id \u003d os.path.basename(resp.headers[\u0027Location\u0027])"},{"line_number":141,"context_line":"        self.wait_lcmocc_complete(lcmocc_id)"},{"line_number":142,"context_line":"        time.sleep(WAIT_LCMOCC_UPDATE_TIME)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        # check usageState of VNF Package"},{"line_number":145,"context_line":"        self.check_package_usage(self.basic_pkg, \u0027NOT_IN_USE\u0027)"}],"source_content_type":"text/x-python","patch_set":14,"id":"59341810_6c04b308","line":142,"range":{"start_line":142,"start_character":8,"end_line":142,"end_character":43},"updated":"2023-11-09 08:36:46.000000000","message":"How about you comment on why additional sleep is needed?","commit_id":"cb166f817ac95f17c5e6ed3846ef7b1a026eee6e"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"99b69dfe8b001cafb075ac852b5eec081ac479b1","unresolved":true,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        lcmocc_id \u003d os.path.basename(resp.headers[\u0027Location\u0027])"},{"line_number":141,"context_line":"        self.wait_lcmocc_complete(lcmocc_id)"},{"line_number":142,"context_line":"        time.sleep(WAIT_LCMOCC_UPDATE_TIME)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        # check usageState of VNF Package"},{"line_number":145,"context_line":"        self.check_package_usage(self.basic_pkg, \u0027NOT_IN_USE\u0027)"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a51615c_d68b1d1e","line":142,"range":{"start_line":142,"start_character":8,"end_line":142,"end_character":43},"in_reply_to":"59341810_6c04b308","updated":"2023-11-14 05:19:29.000000000","message":"Add a commentin Patchset 15.","commit_id":"cb166f817ac95f17c5e6ed3846ef7b1a026eee6e"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"3ab779ba089559e8528de94f7913f3d7aa1cbeea","unresolved":false,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        lcmocc_id \u003d os.path.basename(resp.headers[\u0027Location\u0027])"},{"line_number":141,"context_line":"        self.wait_lcmocc_complete(lcmocc_id)"},{"line_number":142,"context_line":"        time.sleep(WAIT_LCMOCC_UPDATE_TIME)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        # check usageState of VNF Package"},{"line_number":145,"context_line":"        self.check_package_usage(self.basic_pkg, \u0027NOT_IN_USE\u0027)"}],"source_content_type":"text/x-python","patch_set":14,"id":"9ca5d41f_99b0c0d7","line":142,"range":{"start_line":142,"start_character":8,"end_line":142,"end_character":43},"in_reply_to":"5a51615c_d68b1d1e","updated":"2023-11-15 02:23:40.000000000","message":"Ack","commit_id":"cb166f817ac95f17c5e6ed3846ef7b1a026eee6e"}]}