)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"e9cb381fe388de174cd2ed4d64d2bda5bb853cb8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2c21c7d1_0b4506aa","updated":"2023-09-06 03:59:10.000000000","message":"Thank you for the review.","commit_id":"1537706567ac1c77c8429ff0e18d7b724b49d9f8"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c8a16d752ca4724bb3ff65d371d0bc8155b2ec30","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e3e0accd_06d9ccf5","updated":"2023-09-04 09:55:55.000000000","message":"Thanks for your patch, please kindly find my comments.","commit_id":"1537706567ac1c77c8429ff0e18d7b724b49d9f8"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"4410ab7e8c2e3ba01ad246fda2c6d4814f1babd8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ec19d48e_eebe0efa","updated":"2023-09-03 23:11:40.000000000","message":"recheck infra-failure","commit_id":"1537706567ac1c77c8429ff0e18d7b724b49d9f8"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"ce489302ec620a2b55df4ae3e6b32ca9cba85f52","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6219ee22_0f21b300","updated":"2023-09-08 11:14:37.000000000","message":"Thanks for your rework, LGTM.","commit_id":"8e489dc382124f9f2a26acaf37e2feab94c57ac6"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"3a4f81cc88024c9442b534b8281170a7faa9dbed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"19e9656b_24e04b10","updated":"2023-09-07 08:28:16.000000000","message":"recheck infra-failure","commit_id":"8e489dc382124f9f2a26acaf37e2feab94c57ac6"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"c1e4d72333db944b522e8fa05e8fe29179a1d283","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"55e064b0_e217a7e4","updated":"2023-09-07 04:50:53.000000000","message":"recheck infra-failure","commit_id":"8e489dc382124f9f2a26acaf37e2feab94c57ac6"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"223c5e9bbf564112afed5cc74b2dd2099abf5817","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b7db894f_cda56a86","updated":"2023-09-08 07:31:10.000000000","message":"recheck infra-failure","commit_id":"8e489dc382124f9f2a26acaf37e2feab94c57ac6"}],"tacker/sol_refactored/infra_drivers/kubernetes/kubernetes_resource.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c8a16d752ca4724bb3ff65d371d0bc8155b2ec30","unresolved":true,"context_lines":[{"line_number":309,"context_line":"                return False"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"        service_info \u003d self.read()"},{"line_number":312,"context_line":"        if (service_info.spec.cluster_ip \u003d\u003d \"None\""},{"line_number":313,"context_line":"                or _check_is_ip(service_info.spec.cluster_ip)):"},{"line_number":314,"context_line":"            try:"},{"line_number":315,"context_line":"                endpoint_info \u003d self.k8s_client.read_namespaced_endpoints("}],"source_content_type":"text/x-python","patch_set":2,"id":"a6e1d778_4e0e0034","line":312,"range":{"start_line":312,"start_character":12,"end_line":312,"end_character":50},"updated":"2023-09-04 09:55:55.000000000","message":"Don\u0027t you need the same fix for the v1 API [1]?\nOr does same problem not occur in v1 API?\n\n[1] https://opendev.org/openstack/tacker/src/branch/master/tacker/vnfm/infra_drivers/kubernetes/kubernetes_driver.py#L378","commit_id":"1537706567ac1c77c8429ff0e18d7b724b49d9f8"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"84c1f728b02eeee45eff069c956eaab57978330c","unresolved":true,"context_lines":[{"line_number":309,"context_line":"                return False"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"        service_info \u003d self.read()"},{"line_number":312,"context_line":"        if (service_info.spec.cluster_ip \u003d\u003d \"None\""},{"line_number":313,"context_line":"                or _check_is_ip(service_info.spec.cluster_ip)):"},{"line_number":314,"context_line":"            try:"},{"line_number":315,"context_line":"                endpoint_info \u003d self.k8s_client.read_namespaced_endpoints("}],"source_content_type":"text/x-python","patch_set":2,"id":"3167bf8e_6d027706","line":312,"range":{"start_line":312,"start_character":12,"end_line":312,"end_character":50},"in_reply_to":"1bc3a7ab_43c2521e","updated":"2023-09-06 08:45:27.000000000","message":"I understand, I will fix v1 API as well.","commit_id":"1537706567ac1c77c8429ff0e18d7b724b49d9f8"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"ce489302ec620a2b55df4ae3e6b32ca9cba85f52","unresolved":false,"context_lines":[{"line_number":309,"context_line":"                return False"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"        service_info \u003d self.read()"},{"line_number":312,"context_line":"        if (service_info.spec.cluster_ip \u003d\u003d \"None\""},{"line_number":313,"context_line":"                or _check_is_ip(service_info.spec.cluster_ip)):"},{"line_number":314,"context_line":"            try:"},{"line_number":315,"context_line":"                endpoint_info \u003d self.k8s_client.read_namespaced_endpoints("}],"source_content_type":"text/x-python","patch_set":2,"id":"dad8932f_06545b2b","line":312,"range":{"start_line":312,"start_character":12,"end_line":312,"end_character":50},"in_reply_to":"3167bf8e_6d027706","updated":"2023-09-08 11:14:37.000000000","message":"Ack","commit_id":"1537706567ac1c77c8429ff0e18d7b724b49d9f8"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"5e38deb3d6bccf5435853851078ebe4346d090e4","unresolved":true,"context_lines":[{"line_number":309,"context_line":"                return False"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"        service_info \u003d self.read()"},{"line_number":312,"context_line":"        if (service_info.spec.cluster_ip \u003d\u003d \"None\""},{"line_number":313,"context_line":"                or _check_is_ip(service_info.spec.cluster_ip)):"},{"line_number":314,"context_line":"            try:"},{"line_number":315,"context_line":"                endpoint_info \u003d self.k8s_client.read_namespaced_endpoints("}],"source_content_type":"text/x-python","patch_set":2,"id":"1bc3a7ab_43c2521e","line":312,"range":{"start_line":312,"start_character":12,"end_line":312,"end_character":50},"in_reply_to":"91b1acbe_4d5fecd8","updated":"2023-09-06 04:06:24.000000000","message":"If you know it will make an error, I think it is better to fix it. Do you have any concerns about fixing it in V1?","commit_id":"1537706567ac1c77c8429ff0e18d7b724b49d9f8"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"e9cb381fe388de174cd2ed4d64d2bda5bb853cb8","unresolved":true,"context_lines":[{"line_number":309,"context_line":"                return False"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"        service_info \u003d self.read()"},{"line_number":312,"context_line":"        if (service_info.spec.cluster_ip \u003d\u003d \"None\""},{"line_number":313,"context_line":"                or _check_is_ip(service_info.spec.cluster_ip)):"},{"line_number":314,"context_line":"            try:"},{"line_number":315,"context_line":"                endpoint_info \u003d self.k8s_client.read_namespaced_endpoints("}],"source_content_type":"text/x-python","patch_set":2,"id":"91b1acbe_4d5fecd8","line":312,"range":{"start_line":312,"start_character":12,"end_line":312,"end_character":50},"in_reply_to":"a6e1d778_4e0e0034","updated":"2023-09-06 03:59:10.000000000","message":"I think the same fix is needed for the v1 API since the \"service.spec.cluster_ip\" check is the same. Should I fix it in the v1 API too?","commit_id":"1537706567ac1c77c8429ff0e18d7b724b49d9f8"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c8a16d752ca4724bb3ff65d371d0bc8155b2ec30","unresolved":true,"context_lines":[{"line_number":463,"context_line":"        statefulset_info \u003d self.read()"},{"line_number":464,"context_line":"        replicas \u003d statefulset_info.status.replicas"},{"line_number":465,"context_line":"        if replicas \u003d\u003d statefulset_info.status.ready_replicas:"},{"line_number":466,"context_line":"            volume_claim_templates \u003d ("},{"line_number":467,"context_line":"                statefulset_info.spec.volume_claim_templates)"},{"line_number":468,"context_line":"            if volume_claim_templates is None:"},{"line_number":469,"context_line":"                return True"},{"line_number":470,"context_line":"            for i in range(0, statefulset_info.spec.replicas):"},{"line_number":471,"context_line":"                for volume_claim_template in volume_claim_templates:"},{"line_number":472,"context_line":"                    pvc_name \u003d \"-\".join("},{"line_number":473,"context_line":"                        [volume_claim_template.metadata.name,"}],"source_content_type":"text/x-python","patch_set":2,"id":"525f6c90_645b6553","line":470,"range":{"start_line":466,"start_character":12,"end_line":470,"end_character":62},"updated":"2023-09-04 09:55:55.000000000","message":"ditto.\n\nhttps://opendev.org/openstack/tacker/src/branch/master/tacker/vnfm/infra_drivers/kubernetes/kubernetes_driver.py#L339-L341","commit_id":"1537706567ac1c77c8429ff0e18d7b724b49d9f8"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"ce489302ec620a2b55df4ae3e6b32ca9cba85f52","unresolved":false,"context_lines":[{"line_number":463,"context_line":"        statefulset_info \u003d self.read()"},{"line_number":464,"context_line":"        replicas \u003d statefulset_info.status.replicas"},{"line_number":465,"context_line":"        if replicas \u003d\u003d statefulset_info.status.ready_replicas:"},{"line_number":466,"context_line":"            volume_claim_templates \u003d ("},{"line_number":467,"context_line":"                statefulset_info.spec.volume_claim_templates)"},{"line_number":468,"context_line":"            if volume_claim_templates is None:"},{"line_number":469,"context_line":"                return True"},{"line_number":470,"context_line":"            for i in range(0, statefulset_info.spec.replicas):"},{"line_number":471,"context_line":"                for volume_claim_template in volume_claim_templates:"},{"line_number":472,"context_line":"                    pvc_name \u003d \"-\".join("},{"line_number":473,"context_line":"                        [volume_claim_template.metadata.name,"}],"source_content_type":"text/x-python","patch_set":2,"id":"4fec3103_4479ab71","line":470,"range":{"start_line":466,"start_character":12,"end_line":470,"end_character":62},"in_reply_to":"10310659_5c81f2b8","updated":"2023-09-08 11:14:37.000000000","message":"Ack","commit_id":"1537706567ac1c77c8429ff0e18d7b724b49d9f8"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"e9cb381fe388de174cd2ed4d64d2bda5bb853cb8","unresolved":true,"context_lines":[{"line_number":463,"context_line":"        statefulset_info \u003d self.read()"},{"line_number":464,"context_line":"        replicas \u003d statefulset_info.status.replicas"},{"line_number":465,"context_line":"        if replicas \u003d\u003d statefulset_info.status.ready_replicas:"},{"line_number":466,"context_line":"            volume_claim_templates \u003d ("},{"line_number":467,"context_line":"                statefulset_info.spec.volume_claim_templates)"},{"line_number":468,"context_line":"            if volume_claim_templates is None:"},{"line_number":469,"context_line":"                return True"},{"line_number":470,"context_line":"            for i in range(0, statefulset_info.spec.replicas):"},{"line_number":471,"context_line":"                for volume_claim_template in volume_claim_templates:"},{"line_number":472,"context_line":"                    pvc_name \u003d \"-\".join("},{"line_number":473,"context_line":"                        [volume_claim_template.metadata.name,"}],"source_content_type":"text/x-python","patch_set":2,"id":"10310659_5c81f2b8","line":470,"range":{"start_line":466,"start_character":12,"end_line":470,"end_character":62},"in_reply_to":"525f6c90_645b6553","updated":"2023-09-06 03:59:10.000000000","message":"I think the same fix is needed, since \"volume_claim_templates\" would be None if \"volume_claim_templates\" is not used in the v1 API too.","commit_id":"1537706567ac1c77c8429ff0e18d7b724b49d9f8"}]}