)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c95f5cb6d9c5f437cc71cad19c149a2c9b77182f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ab0dd8e4_5eef4ece","updated":"2024-01-16 00:02:38.000000000","message":"Ogawa-san,\nThanks for your comments, I will reply instead of Feng.\nPlease kindly check my answer.","commit_id":"07908e7739c9e5077f0423b6a3a6c50e6c1f019e"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"f9e71194b708cece181de66afda23d13903353f7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"06629737_afb25402","updated":"2024-01-11 11:30:07.000000000","message":"Please find my tiny comments. Thanks.","commit_id":"07908e7739c9e5077f0423b6a3a6c50e6c1f019e"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"7c8d2985592096dbb285b76962911bbe88de07e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e38cb7fd_76f1bb9d","updated":"2023-12-22 02:16:08.000000000","message":"Thanks for your patch, LGTM","commit_id":"07908e7739c9e5077f0423b6a3a6c50e6c1f019e"}],"tacker/db/migration/migrate_to_v2.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"f9e71194b708cece181de66afda23d13903353f7","unresolved":true,"context_lines":[{"line_number":1010,"context_line":""},{"line_number":1011,"context_line":""},{"line_number":1012,"context_line":"def _get_vim_key_by_id(vim_id, vim_connection_info):"},{"line_number":1013,"context_line":"    if not vim_id:"},{"line_number":1014,"context_line":"        return vim_id"},{"line_number":1015,"context_line":"    # Note: If no vimId matching vim_id is found in vim_connection_info,"},{"line_number":1016,"context_line":"    # \"vim_0\" is returned as vim_connection_id."},{"line_number":1017,"context_line":"    vim_connection_id \u003d \"vim_0\""}],"source_content_type":"text/x-python","patch_set":1,"id":"44252bd4_e552eee1","line":1014,"range":{"start_line":1013,"start_character":0,"end_line":1014,"end_character":21},"updated":"2024-01-11 11:30:07.000000000","message":"What is the reason to return vim_id is not True instead of the default \"vim_0\"?","commit_id":"07908e7739c9e5077f0423b6a3a6c50e6c1f019e"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c95f5cb6d9c5f437cc71cad19c149a2c9b77182f","unresolved":true,"context_lines":[{"line_number":1010,"context_line":""},{"line_number":1011,"context_line":""},{"line_number":1012,"context_line":"def _get_vim_key_by_id(vim_id, vim_connection_info):"},{"line_number":1013,"context_line":"    if not vim_id:"},{"line_number":1014,"context_line":"        return vim_id"},{"line_number":1015,"context_line":"    # Note: If no vimId matching vim_id is found in vim_connection_info,"},{"line_number":1016,"context_line":"    # \"vim_0\" is returned as vim_connection_id."},{"line_number":1017,"context_line":"    vim_connection_id \u003d \"vim_0\""}],"source_content_type":"text/x-python","patch_set":1,"id":"8761a68a_8612a69b","line":1014,"range":{"start_line":1013,"start_character":0,"end_line":1014,"end_character":21},"in_reply_to":"44252bd4_e552eee1","updated":"2024-01-16 00:02:38.000000000","message":"To avoid changing existing implementation, if the value of vimConnectionId was not originally set, the value is returned as is.","commit_id":"07908e7739c9e5077f0423b6a3a6c50e6c1f019e"}],"tacker/sol_refactored/common/vnf_instance_utils.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"f9e71194b708cece181de66afda23d13903353f7","unresolved":true,"context_lines":[{"line_number":73,"context_line":"        return patch"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"def select_vim_info(vim_connection_info, return_key\u003dFalse):"},{"line_number":77,"context_line":"    # NOTE: It is assumed that vimConnectionInfo has only one item"},{"line_number":78,"context_line":"    # at the moment. If there are multiple items, it is uncertain"},{"line_number":79,"context_line":"    # which item is selected."}],"source_content_type":"text/x-python","patch_set":1,"id":"90c728d2_2f4d87be","line":76,"range":{"start_line":76,"start_character":41,"end_line":76,"end_character":57},"updated":"2024-01-11 11:30:07.000000000","message":"I don\u0027t know why this option is required actually because we can just return None and the caller can ignore if the key is not needed like as below.\n\n_k, v \u003d select_vim_info(vim_conn_info)  # it returns (None, val)","commit_id":"07908e7739c9e5077f0423b6a3a6c50e6c1f019e"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c95f5cb6d9c5f437cc71cad19c149a2c9b77182f","unresolved":true,"context_lines":[{"line_number":73,"context_line":"        return patch"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"def select_vim_info(vim_connection_info, return_key\u003dFalse):"},{"line_number":77,"context_line":"    # NOTE: It is assumed that vimConnectionInfo has only one item"},{"line_number":78,"context_line":"    # at the moment. If there are multiple items, it is uncertain"},{"line_number":79,"context_line":"    # which item is selected."}],"source_content_type":"text/x-python","patch_set":1,"id":"dc34ee47_6b043452","line":76,"range":{"start_line":76,"start_character":41,"end_line":76,"end_character":57},"in_reply_to":"90c728d2_2f4d87be","updated":"2024-01-16 00:02:38.000000000","message":"Because `select_vim_info()` is called in many places and making changes to all of them would have had a large impact, so the use of an optional argument (return_key) reduces the impact.","commit_id":"07908e7739c9e5077f0423b6a3a6c50e6c1f019e"}]}