)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"5fa560ac22b97811c00bd1e403e8af95ffc34b47","unresolved":true,"context_lines":[{"line_number":11,"context_line":"Backward compatibility:"},{"line_number":12,"context_line":"- Old Rules and Defaults will keep working as it is because they"},{"line_number":13,"context_line":"  are added as deprecated rules and not removed. They are enabled"},{"line_number":14,"context_line":"  by default. This means existing deployement will continue working"},{"line_number":15,"context_line":"  in same way till deprecated rules are there and enabled by default."},{"line_number":16,"context_line":"- Legacy/current admin stays same and no change in their access permission"},{"line_number":17,"context_line":"- Deprecation warning is added for old defaults so that operators will"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"dad4fddc_3bfd780a","line":14,"range":{"start_line":14,"start_character":34,"end_line":14,"end_character":45},"updated":"2024-03-08 13:20:18.000000000","message":"typo: deployment","commit_id":"31fcc445a470f97fe61f68fd65c32e30409b6daa"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"12f8112b01aa347b51955358ec1e33eee12552db","unresolved":false,"context_lines":[{"line_number":11,"context_line":"Backward compatibility:"},{"line_number":12,"context_line":"- Old Rules and Defaults will keep working as it is because they"},{"line_number":13,"context_line":"  are added as deprecated rules and not removed. They are enabled"},{"line_number":14,"context_line":"  by default. This means existing deployement will continue working"},{"line_number":15,"context_line":"  in same way till deprecated rules are there and enabled by default."},{"line_number":16,"context_line":"- Legacy/current admin stays same and no change in their access permission"},{"line_number":17,"context_line":"- Deprecation warning is added for old defaults so that operators will"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"c51e9415_79ba97f0","line":14,"range":{"start_line":14,"start_character":34,"end_line":14,"end_character":45},"in_reply_to":"dad4fddc_3bfd780a","updated":"2024-03-08 22:03:17.000000000","message":"Done","commit_id":"31fcc445a470f97fe61f68fd65c32e30409b6daa"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7a82ad8a227cd74efbb27320bdb4ec1296b86bb1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"e4de09c0_6d5092ab","updated":"2024-02-21 05:30:26.000000000","message":"recheck failure not related to this change","commit_id":"9fd9c1b409cef132018cdc16bdc24a6bc76e5ed1"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"fb105c13a47c127fa8faf4ef3349c8eb2843ec5a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"29065526_711510d3","updated":"2024-02-22 06:58:36.000000000","message":"recheck timeout in tacker-functional-devstack-enhanced-policy-sol","commit_id":"9fd9c1b409cef132018cdc16bdc24a6bc76e5ed1"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"81d9433981a2bdb3ab9ecbd43ade108f555aec08","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"d9f9d64e_cccfcc77","updated":"2024-02-21 21:00:14.000000000","message":"recheck unrelated failure in tox cover job","commit_id":"9fd9c1b409cef132018cdc16bdc24a6bc76e5ed1"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"5fa560ac22b97811c00bd1e403e8af95ffc34b47","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"6ce92ed4_c1fa6888","updated":"2024-03-08 13:20:18.000000000","message":"Thanks for your patch, please kindly find my comments.","commit_id":"31fcc445a470f97fe61f68fd65c32e30409b6daa"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"67c06d78011eebe14494daa08bd5d4eb4d1df1f3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"dc069f9f_db58d117","updated":"2024-03-11 08:50:01.000000000","message":"Thanks for your updating, LGTM.","commit_id":"afd55154cbcc1db706f1c89620681409629c02a6"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3389f24db4fac12ff072e86f32abb145e358f5ad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"e1cdd4bd_1e79bed3","updated":"2024-03-11 03:21:09.000000000","message":"recheck test timeout in tacker-functional-devstack-multinode-sol-kubernetes","commit_id":"afd55154cbcc1db706f1c89620681409629c02a6"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"874bdab8fcb12f924b9c19a5b1ecf5738a9ce09a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"df1d21d9_eb1fa420","updated":"2024-03-17 04:08:32.000000000","message":"recheck - failure might be because of external server wasn\u0027t working temporarily.","commit_id":"2de67c771b1f3e195febf6f85155b219340e5312"}],"tacker/tests/unit/policies/base.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"5fa560ac22b97811c00bd1e403e8af95ffc34b47","unresolved":true,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class BasePolicyTest(base.TestCase):"},{"line_number":32,"context_line":"    # NOTE(gmann): Set this flag to True if you would like to tests the"},{"line_number":33,"context_line":"    # new behaviour of policy without deprecated rules"},{"line_number":34,"context_line":"    # This means you can simulate the phase when policies completely"},{"line_number":35,"context_line":"    # switch to new behaviour by removing the support of old rules."},{"line_number":36,"context_line":"    enforce_new_defaults \u003d False"}],"source_content_type":"text/x-python","patch_set":12,"id":"4afd7a5c_61aa1d6c","line":33,"range":{"start_line":33,"start_character":53,"end_line":33,"end_character":54},"updated":"2024-03-08 13:20:18.000000000","message":"Could you add period character to end of line?","commit_id":"31fcc445a470f97fe61f68fd65c32e30409b6daa"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"12f8112b01aa347b51955358ec1e33eee12552db","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class BasePolicyTest(base.TestCase):"},{"line_number":32,"context_line":"    # NOTE(gmann): Set this flag to True if you would like to tests the"},{"line_number":33,"context_line":"    # new behaviour of policy without deprecated rules"},{"line_number":34,"context_line":"    # This means you can simulate the phase when policies completely"},{"line_number":35,"context_line":"    # switch to new behaviour by removing the support of old rules."},{"line_number":36,"context_line":"    enforce_new_defaults \u003d False"}],"source_content_type":"text/x-python","patch_set":12,"id":"55c6eda0_a2c97bdf","line":33,"range":{"start_line":33,"start_character":53,"end_line":33,"end_character":54},"in_reply_to":"4afd7a5c_61aa1d6c","updated":"2024-03-08 22:03:17.000000000","message":"Done","commit_id":"31fcc445a470f97fe61f68fd65c32e30409b6daa"}],"tacker/tests/unit/policies/test_vnf_lcm.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"5fa560ac22b97811c00bd1e403e8af95ffc34b47","unresolved":true,"context_lines":[{"line_number":410,"context_line":"            \u0027/vnf_lcm_op_occs/%s\u0027 % uuidsentinel.instance_id)"},{"line_number":411,"context_line":"        mock_lcm_by_id.return_value \u003d fakes.return_vnf_lcm_opoccs_obj()"},{"line_number":412,"context_line":"        rule_name \u003d policies.VNFLCM % \u0027show_lcm_op_occs\u0027"},{"line_number":413,"context_line":"        self.common_policy_check(self.get_authorized_contexts,"},{"line_number":414,"context_line":"                                 self.get_unauthorized_contexts,"},{"line_number":415,"context_line":"                                 rule_name,"},{"line_number":416,"context_line":"                                 self.controller.show_lcm_op_occs,"}],"source_content_type":"text/x-python","patch_set":12,"id":"cba5373a_565db806","line":413,"range":{"start_line":413,"start_character":38,"end_line":413,"end_character":61},"updated":"2024-03-08 13:20:18.000000000","message":"Why don\u0027t you set `project_reader_authorized_contexts` when `show_lcm_op_occs`?\n\nDo you need to set `project_id` to target of `context.can` in `show_lcm_op_occs` like rollback [1] in Patch#908559?\n\n[1] https://review.opendev.org/c/openstack/tacker/+/908559/7/tacker/api/vnflcm/v1/controller.py#933\n[2] https://review.opendev.org/c/openstack/tacker/+/908559/7/tacker/api/vnflcm/v1/controller.py#1500","commit_id":"31fcc445a470f97fe61f68fd65c32e30409b6daa"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"12f8112b01aa347b51955358ec1e33eee12552db","unresolved":false,"context_lines":[{"line_number":410,"context_line":"            \u0027/vnf_lcm_op_occs/%s\u0027 % uuidsentinel.instance_id)"},{"line_number":411,"context_line":"        mock_lcm_by_id.return_value \u003d fakes.return_vnf_lcm_opoccs_obj()"},{"line_number":412,"context_line":"        rule_name \u003d policies.VNFLCM % \u0027show_lcm_op_occs\u0027"},{"line_number":413,"context_line":"        self.common_policy_check(self.get_authorized_contexts,"},{"line_number":414,"context_line":"                                 self.get_unauthorized_contexts,"},{"line_number":415,"context_line":"                                 rule_name,"},{"line_number":416,"context_line":"                                 self.controller.show_lcm_op_occs,"}],"source_content_type":"text/x-python","patch_set":12,"id":"7c5ed0a6_e42322ed","line":413,"range":{"start_line":413,"start_character":38,"end_line":413,"end_character":61},"in_reply_to":"cba5373a_565db806","updated":"2024-03-08 22:03:17.000000000","message":"nice catch. thanks\n\nYou are right, i forgot to pass the project_id in policy target. Updated that and project_reader_authorized_contexts works as expected in this test.","commit_id":"31fcc445a470f97fe61f68fd65c32e30409b6daa"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"5fa560ac22b97811c00bd1e403e8af95ffc34b47","unresolved":true,"context_lines":[{"line_number":411,"context_line":"        mock_lcm_by_id.return_value \u003d fakes.return_vnf_lcm_opoccs_obj()"},{"line_number":412,"context_line":"        rule_name \u003d policies.VNFLCM % \u0027show_lcm_op_occs\u0027"},{"line_number":413,"context_line":"        self.common_policy_check(self.get_authorized_contexts,"},{"line_number":414,"context_line":"                                 self.get_unauthorized_contexts,"},{"line_number":415,"context_line":"                                 rule_name,"},{"line_number":416,"context_line":"                                 self.controller.show_lcm_op_occs,"},{"line_number":417,"context_line":"                                 req, uuidsentinel.instance_id)"}],"source_content_type":"text/x-python","patch_set":12,"id":"ec377ae8_2dfdf022","line":414,"range":{"start_line":414,"start_character":38,"end_line":414,"end_character":63},"updated":"2024-03-08 13:20:18.000000000","message":"ditto,\nI think `project_reader_unauthorized_contexts` is more suitable for ideal operation.","commit_id":"31fcc445a470f97fe61f68fd65c32e30409b6daa"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"12f8112b01aa347b51955358ec1e33eee12552db","unresolved":false,"context_lines":[{"line_number":411,"context_line":"        mock_lcm_by_id.return_value \u003d fakes.return_vnf_lcm_opoccs_obj()"},{"line_number":412,"context_line":"        rule_name \u003d policies.VNFLCM % \u0027show_lcm_op_occs\u0027"},{"line_number":413,"context_line":"        self.common_policy_check(self.get_authorized_contexts,"},{"line_number":414,"context_line":"                                 self.get_unauthorized_contexts,"},{"line_number":415,"context_line":"                                 rule_name,"},{"line_number":416,"context_line":"                                 self.controller.show_lcm_op_occs,"},{"line_number":417,"context_line":"                                 req, uuidsentinel.instance_id)"}],"source_content_type":"text/x-python","patch_set":12,"id":"55ea1ca6_7f90dcb4","line":414,"range":{"start_line":414,"start_character":38,"end_line":414,"end_character":63},"in_reply_to":"ec377ae8_2dfdf022","updated":"2024-03-08 22:03:17.000000000","message":"Done","commit_id":"31fcc445a470f97fe61f68fd65c32e30409b6daa"}]}