)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9d7c6a17da7afad11b04e3ab1838a0ba404bcb93","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Move test samples to reduce setuptools warnings"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Previously there are a lot of warning messsages of setuptools"},{"line_number":10,"context_line":"in the log files of tox jobs. This is mainly caused by test"},{"line_number":11,"context_line":"samples because these are in python codes directories."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"c7085e79_292ad009","line":9,"range":{"start_line":9,"start_character":38,"end_line":9,"end_character":47},"updated":"2024-02-15 04:29:15.000000000","message":"typo: messages","commit_id":"ca9177269743c87ea9e1c2c7d722de2c359aa55b"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"a293b551306478f1a07477497ac861cb14495874","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Move test samples to reduce setuptools warnings"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Previously there are a lot of warning messsages of setuptools"},{"line_number":10,"context_line":"in the log files of tox jobs. This is mainly caused by test"},{"line_number":11,"context_line":"samples because these are in python codes directories."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"d3d8f44a_02666843","line":9,"range":{"start_line":9,"start_character":38,"end_line":9,"end_character":47},"in_reply_to":"822e4c40_fdd0bf4c","updated":"2024-02-15 09:06:12.000000000","message":"Acknowledged","commit_id":"ca9177269743c87ea9e1c2c7d722de2c359aa55b"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"8686c1645586a209cd7aaaf3894b7dd07d0a8efd","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Move test samples to reduce setuptools warnings"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Previously there are a lot of warning messsages of setuptools"},{"line_number":10,"context_line":"in the log files of tox jobs. This is mainly caused by test"},{"line_number":11,"context_line":"samples because these are in python codes directories."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"822e4c40_fdd0bf4c","line":9,"range":{"start_line":9,"start_character":38,"end_line":9,"end_character":47},"in_reply_to":"c7085e79_292ad009","updated":"2024-02-15 05:10:28.000000000","message":"I will fix.","commit_id":"ca9177269743c87ea9e1c2c7d722de2c359aa55b"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9d7c6a17da7afad11b04e3ab1838a0ba404bcb93","unresolved":true,"context_lines":[{"line_number":10,"context_line":"in the log files of tox jobs. This is mainly caused by test"},{"line_number":11,"context_line":"samples because these are in python codes directories."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch moves test samples from under {taker-root}/tacker/"},{"line_number":14,"context_line":"to under {taker-root}/samples/."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This patch reduces log messages drastically. For example,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"08857002_e4ef08b5","line":13,"range":{"start_line":13,"start_character":42,"end_line":13,"end_character":47},"updated":"2024-02-15 04:29:15.000000000","message":"typo: tacker\n\nand how about you change to `{tacker_root}` instead of `{taker-root}` like the comment in `tacker/tests/utils.py` [1]\n\n[1] https://review.opendev.org/c/openstack/tacker/+/907170/12/tacker/tests/utils.py#40","commit_id":"ca9177269743c87ea9e1c2c7d722de2c359aa55b"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"8686c1645586a209cd7aaaf3894b7dd07d0a8efd","unresolved":true,"context_lines":[{"line_number":10,"context_line":"in the log files of tox jobs. This is mainly caused by test"},{"line_number":11,"context_line":"samples because these are in python codes directories."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch moves test samples from under {taker-root}/tacker/"},{"line_number":14,"context_line":"to under {taker-root}/samples/."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This patch reduces log messages drastically. For example,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"e5a765bc_a6300830","line":13,"range":{"start_line":13,"start_character":42,"end_line":13,"end_character":47},"in_reply_to":"08857002_e4ef08b5","updated":"2024-02-15 05:10:28.000000000","message":"I will fix.","commit_id":"ca9177269743c87ea9e1c2c7d722de2c359aa55b"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"a293b551306478f1a07477497ac861cb14495874","unresolved":false,"context_lines":[{"line_number":10,"context_line":"in the log files of tox jobs. This is mainly caused by test"},{"line_number":11,"context_line":"samples because these are in python codes directories."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch moves test samples from under {taker-root}/tacker/"},{"line_number":14,"context_line":"to under {taker-root}/samples/."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This patch reduces log messages drastically. For example,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"89a26775_d961919d","line":13,"range":{"start_line":13,"start_character":42,"end_line":13,"end_character":47},"in_reply_to":"e5a765bc_a6300830","updated":"2024-02-15 09:06:12.000000000","message":"Acknowledged","commit_id":"ca9177269743c87ea9e1c2c7d722de2c359aa55b"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9d7c6a17da7afad11b04e3ab1838a0ba404bcb93","unresolved":true,"context_lines":[{"line_number":11,"context_line":"samples because these are in python codes directories."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch moves test samples from under {taker-root}/tacker/"},{"line_number":14,"context_line":"to under {taker-root}/samples/."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This patch reduces log messages drastically. For example,"},{"line_number":17,"context_line":"the log file of py38 tox job decreased about 34,000 lines."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"271b9afd_36cfc1c9","line":14,"range":{"start_line":14,"start_character":10,"end_line":14,"end_character":15},"updated":"2024-02-15 04:29:15.000000000","message":"ditto.","commit_id":"ca9177269743c87ea9e1c2c7d722de2c359aa55b"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"a293b551306478f1a07477497ac861cb14495874","unresolved":false,"context_lines":[{"line_number":11,"context_line":"samples because these are in python codes directories."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch moves test samples from under {taker-root}/tacker/"},{"line_number":14,"context_line":"to under {taker-root}/samples/."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This patch reduces log messages drastically. For example,"},{"line_number":17,"context_line":"the log file of py38 tox job decreased about 34,000 lines."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"46cda43a_d793d9d6","line":14,"range":{"start_line":14,"start_character":10,"end_line":14,"end_character":15},"in_reply_to":"16b0658b_62d82573","updated":"2024-02-15 09:06:12.000000000","message":"Acknowledged","commit_id":"ca9177269743c87ea9e1c2c7d722de2c359aa55b"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"8686c1645586a209cd7aaaf3894b7dd07d0a8efd","unresolved":true,"context_lines":[{"line_number":11,"context_line":"samples because these are in python codes directories."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch moves test samples from under {taker-root}/tacker/"},{"line_number":14,"context_line":"to under {taker-root}/samples/."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This patch reduces log messages drastically. For example,"},{"line_number":17,"context_line":"the log file of py38 tox job decreased about 34,000 lines."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"16b0658b_62d82573","line":14,"range":{"start_line":14,"start_character":10,"end_line":14,"end_character":15},"in_reply_to":"271b9afd_36cfc1c9","updated":"2024-02-15 05:10:28.000000000","message":"I will fix.","commit_id":"ca9177269743c87ea9e1c2c7d722de2c359aa55b"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"8686c1645586a209cd7aaaf3894b7dd07d0a8efd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"f3c7aa41_952bfb3b","updated":"2024-02-15 05:10:28.000000000","message":"Thank you for the review.","commit_id":"ca9177269743c87ea9e1c2c7d722de2c359aa55b"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9d7c6a17da7afad11b04e3ab1838a0ba404bcb93","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"08ee6dcf_fd4e0f39","updated":"2024-02-15 04:29:15.000000000","message":"Thanks for your patch, please kindly find my comments.","commit_id":"ca9177269743c87ea9e1c2c7d722de2c359aa55b"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"e04f46e8f67e2c934d0060cad5044a74bd492487","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"aab25fa5_080db130","updated":"2024-02-13 23:05:03.000000000","message":"recheck infra-failure","commit_id":"ca9177269743c87ea9e1c2c7d722de2c359aa55b"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"a4f904043596f3397abcc7fc2b67d37fb8759c4d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"c4c02d47_71fa68d8","updated":"2024-02-13 05:07:28.000000000","message":"recheck infra-failure","commit_id":"ca9177269743c87ea9e1c2c7d722de2c359aa55b"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"a293b551306478f1a07477497ac861cb14495874","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"e995da1a_646e091b","updated":"2024-02-15 09:06:12.000000000","message":"Thanks for your rework! LGTM.","commit_id":"c056e248b24e2c3e2f3d20d69c7c29e0734a9577"}],"tacker/tests/utils.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9d7c6a17da7afad11b04e3ab1838a0ba404bcb93","unresolved":true,"context_lines":[{"line_number":36,"context_line":"                                        \u0027../../samples\u0027))"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"def test_sample_root():"},{"line_number":40,"context_line":"    # {tacker_root}/samples/tests"},{"line_number":41,"context_line":"    return os.path.join(sample_root(), \u0027tests\u0027)"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"b97fcbfd_3c4a78be","line":39,"range":{"start_line":39,"start_character":4,"end_line":39,"end_character":20},"updated":"2024-02-15 04:29:15.000000000","message":"It seems that it is currently called only by the `test_sample()` method in this file, so how about change to the internal method with _ at the beginning like `_test_sample_root`?","commit_id":"ca9177269743c87ea9e1c2c7d722de2c359aa55b"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"a293b551306478f1a07477497ac861cb14495874","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                                        \u0027../../samples\u0027))"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"def test_sample_root():"},{"line_number":40,"context_line":"    # {tacker_root}/samples/tests"},{"line_number":41,"context_line":"    return os.path.join(sample_root(), \u0027tests\u0027)"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"53f7191d_0f057f79","line":39,"range":{"start_line":39,"start_character":4,"end_line":39,"end_character":20},"in_reply_to":"8636a06a_e0c67f1b","updated":"2024-02-15 09:06:12.000000000","message":"Acknowledged","commit_id":"ca9177269743c87ea9e1c2c7d722de2c359aa55b"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"8686c1645586a209cd7aaaf3894b7dd07d0a8efd","unresolved":true,"context_lines":[{"line_number":36,"context_line":"                                        \u0027../../samples\u0027))"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"def test_sample_root():"},{"line_number":40,"context_line":"    # {tacker_root}/samples/tests"},{"line_number":41,"context_line":"    return os.path.join(sample_root(), \u0027tests\u0027)"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"8636a06a_e0c67f1b","line":39,"range":{"start_line":39,"start_character":4,"end_line":39,"end_character":20},"in_reply_to":"b97fcbfd_3c4a78be","updated":"2024-02-15 05:10:28.000000000","message":"I see. I will fix.","commit_id":"ca9177269743c87ea9e1c2c7d722de2c359aa55b"}]}
