)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"4a54b266d9de0252bc0e2e7807eda81a0de1f6b9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"35fde50c_3a5f4588","updated":"2024-03-11 23:15:59.000000000","message":"Thank you for the review.","commit_id":"30629f871cedaa116dbc5ae0e298ee567af1ca35"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"66c0a8e355257e4e358b15ea11b8bb6f3b3624fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"6be48c2d_33877b1f","updated":"2024-02-20 21:58:55.000000000","message":"recheck infra-failure","commit_id":"30629f871cedaa116dbc5ae0e298ee567af1ca35"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"8617675dc41f7127e2cef43b14c6fdaf3c313f24","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"9815de43_8ca6f921","updated":"2024-03-12 23:28:01.000000000","message":"LGTM","commit_id":"39648b454b2b864e64ee1963cc6c061da6129d26"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"4583a4246aacf466d008d380d044520652813953","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"66af23ce_a8959405","updated":"2024-03-13 22:26:57.000000000","message":"Thank you for the review.","commit_id":"39648b454b2b864e64ee1963cc6c061da6129d26"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"cbe4033c1d71b2b33061f5402437248f51265176","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"6212da28_353db991","updated":"2024-03-13 06:06:31.000000000","message":"Thanks for your patch, LGTM.","commit_id":"39648b454b2b864e64ee1963cc6c061da6129d26"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"eb4199848526331c29150eec2f615cbf60ac4106","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"13bdf40f_43378889","updated":"2024-03-12 04:59:06.000000000","message":"recheck infra-failure","commit_id":"39648b454b2b864e64ee1963cc6c061da6129d26"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"d84e769cf63bd2dd69e621107684320ac3005d69","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"c8f0c94d_1177b243","updated":"2024-03-17 14:29:55.000000000","message":"recheck - for an unexpected failure.","commit_id":"ef30b1d7e87ee1b97779b02a7490ab794cd9974e"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"afb8df40ed59b67e08835eca983c41c9f8f1f2f6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"9b59504d_5d277aec","updated":"2024-03-15 08:52:16.000000000","message":"recheck - unexpected failure in gate unit test","commit_id":"ef30b1d7e87ee1b97779b02a7490ab794cd9974e"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"f71851f591db33fc8df2610fb53a5097ef0e4e69","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"a9e141a2_ad0760e6","updated":"2024-03-15 05:07:17.000000000","message":"recheck - unexpected failure in gate unit test","commit_id":"ef30b1d7e87ee1b97779b02a7490ab794cd9974e"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"80b5298c63325873cea06539591b7e0f8a798121","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"40299371_d9716e46","updated":"2024-03-15 01:25:59.000000000","message":"recheck infra-failure","commit_id":"ef30b1d7e87ee1b97779b02a7490ab794cd9974e"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"37ec29fa72c73bccb6ad1283ddfafcbe2a544ed0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"a63af4e5_4ccce4ad","updated":"2024-03-14 22:05:31.000000000","message":"recheck infra-failure","commit_id":"ef30b1d7e87ee1b97779b02a7490ab794cd9974e"}],"tacker/sol_refactored/api/router.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"b125f99d15e28788565c7e79d32fa0d295c17e75","unresolved":true,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"# The definitions after here are of tacker original APIs."},{"line_number":98,"context_line":"# Although these APIs are not included in ESTi SOL specification,"},{"line_number":99,"context_line":"# these APIs are (should be) designed as same as SOL APIs and"},{"line_number":100,"context_line":"# use same API frameworks (i.e. modules in this directory)."},{"line_number":101,"context_line":"class PmEventRouter(sol_wsgi.SolAPIRouter):"}],"source_content_type":"text/x-python","patch_set":12,"id":"221446d7_24dd2c3f","line":98,"range":{"start_line":98,"start_character":42,"end_line":98,"end_character":46},"updated":"2024-03-13 18:07:26.000000000","message":"nit: ETSI","commit_id":"39648b454b2b864e64ee1963cc6c061da6129d26"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"4583a4246aacf466d008d380d044520652813953","unresolved":true,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"# The definitions after here are of tacker original APIs."},{"line_number":98,"context_line":"# Although these APIs are not included in ESTi SOL specification,"},{"line_number":99,"context_line":"# these APIs are (should be) designed as same as SOL APIs and"},{"line_number":100,"context_line":"# use same API frameworks (i.e. modules in this directory)."},{"line_number":101,"context_line":"class PmEventRouter(sol_wsgi.SolAPIRouter):"}],"source_content_type":"text/x-python","patch_set":12,"id":"2171ff76_300e17a8","line":98,"range":{"start_line":98,"start_character":42,"end_line":98,"end_character":46},"in_reply_to":"221446d7_24dd2c3f","updated":"2024-03-13 22:26:57.000000000","message":"I will fix.","commit_id":"39648b454b2b864e64ee1963cc6c061da6129d26"}],"tacker/sol_refactored/api/wsgi.py":[{"author":{"_account_id":31668,"deleted":true},"change_message_id":"6a3dfa7d2bae4d555e38b411de23ae24731f6830","unresolved":true,"context_lines":[{"line_number":271,"context_line":"        raise sol_ex.MethodNotAllowed(method\u003drequest.method)"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"    def supported_api_versions(self, action):"},{"line_number":274,"context_line":"        # NOTE: if a contorller supports versions header, overrride"},{"line_number":275,"context_line":"        # override this method in the subclass. return None means"},{"line_number":276,"context_line":"        # version is not checked."},{"line_number":277,"context_line":"        return None"}],"source_content_type":"text/x-python","patch_set":10,"id":"247ef701_15b06d8f","line":274,"updated":"2024-03-11 09:52:11.000000000","message":"typo: overrride override this method -\u003e override this method","commit_id":"30629f871cedaa116dbc5ae0e298ee567af1ca35"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"4a54b266d9de0252bc0e2e7807eda81a0de1f6b9","unresolved":true,"context_lines":[{"line_number":271,"context_line":"        raise sol_ex.MethodNotAllowed(method\u003drequest.method)"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"    def supported_api_versions(self, action):"},{"line_number":274,"context_line":"        # NOTE: if a contorller supports versions header, overrride"},{"line_number":275,"context_line":"        # override this method in the subclass. return None means"},{"line_number":276,"context_line":"        # version is not checked."},{"line_number":277,"context_line":"        return None"}],"source_content_type":"text/x-python","patch_set":10,"id":"455f6bf1_c3e7d1d5","line":274,"in_reply_to":"247ef701_15b06d8f","updated":"2024-03-11 23:15:59.000000000","message":"I will fix.","commit_id":"30629f871cedaa116dbc5ae0e298ee567af1ca35"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"8617675dc41f7127e2cef43b14c6fdaf3c313f24","unresolved":false,"context_lines":[{"line_number":271,"context_line":"        raise sol_ex.MethodNotAllowed(method\u003drequest.method)"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"    def supported_api_versions(self, action):"},{"line_number":274,"context_line":"        # NOTE: if a contorller supports versions header, overrride"},{"line_number":275,"context_line":"        # override this method in the subclass. return None means"},{"line_number":276,"context_line":"        # version is not checked."},{"line_number":277,"context_line":"        return None"}],"source_content_type":"text/x-python","patch_set":10,"id":"0daec541_9e4a88a8","line":274,"in_reply_to":"455f6bf1_c3e7d1d5","updated":"2024-03-12 23:28:01.000000000","message":"Done","commit_id":"30629f871cedaa116dbc5ae0e298ee567af1ca35"}],"tacker/tests/unit/sol_refactored/common/test_prometheus_plugin.py":[{"author":{"_account_id":31668,"deleted":true},"change_message_id":"6a3dfa7d2bae4d555e38b411de23ae24731f6830","unresolved":true,"context_lines":[{"line_number":1425,"context_line":"            prometheus_plugin.PrometheusPluginFm)"},{"line_number":1426,"context_line":"        self.assertIsInstance(pp._instance, mon_base.MonitoringPluginStub)"},{"line_number":1427,"context_line":""},{"line_number":1428,"context_line":"    def test_pm_no_body(self):"},{"line_number":1429,"context_line":"        self.config_fixture.config("},{"line_number":1430,"context_line":"            group\u003d\u0027prometheus_plugin\u0027, performance_management\u003dTrue)"},{"line_number":1431,"context_line":"        pp \u003d mon_base.MonitoringPlugin.get_instance("}],"source_content_type":"text/x-python","patch_set":10,"id":"d132c0df_d11c14da","line":1428,"updated":"2024-03-11 09:52:11.000000000","message":"Since this is a test in the TestPrometheusPluginFm class, I think it would be better to change \"test_pm_no_body\" to \"test_fm_no_body\".\nHow about using the class \"PrometheusPluginFm\" instead of \"PrometheusPluginPm\" and testing that SolValidationError occurs?","commit_id":"30629f871cedaa116dbc5ae0e298ee567af1ca35"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"8617675dc41f7127e2cef43b14c6fdaf3c313f24","unresolved":false,"context_lines":[{"line_number":1425,"context_line":"            prometheus_plugin.PrometheusPluginFm)"},{"line_number":1426,"context_line":"        self.assertIsInstance(pp._instance, mon_base.MonitoringPluginStub)"},{"line_number":1427,"context_line":""},{"line_number":1428,"context_line":"    def test_pm_no_body(self):"},{"line_number":1429,"context_line":"        self.config_fixture.config("},{"line_number":1430,"context_line":"            group\u003d\u0027prometheus_plugin\u0027, performance_management\u003dTrue)"},{"line_number":1431,"context_line":"        pp \u003d mon_base.MonitoringPlugin.get_instance("}],"source_content_type":"text/x-python","patch_set":10,"id":"01989241_3923ecb9","line":1428,"in_reply_to":"4351c0bb_d256436e","updated":"2024-03-12 23:28:01.000000000","message":"Done","commit_id":"30629f871cedaa116dbc5ae0e298ee567af1ca35"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"4a54b266d9de0252bc0e2e7807eda81a0de1f6b9","unresolved":true,"context_lines":[{"line_number":1425,"context_line":"            prometheus_plugin.PrometheusPluginFm)"},{"line_number":1426,"context_line":"        self.assertIsInstance(pp._instance, mon_base.MonitoringPluginStub)"},{"line_number":1427,"context_line":""},{"line_number":1428,"context_line":"    def test_pm_no_body(self):"},{"line_number":1429,"context_line":"        self.config_fixture.config("},{"line_number":1430,"context_line":"            group\u003d\u0027prometheus_plugin\u0027, performance_management\u003dTrue)"},{"line_number":1431,"context_line":"        pp \u003d mon_base.MonitoringPlugin.get_instance("}],"source_content_type":"text/x-python","patch_set":10,"id":"4351c0bb_d256436e","line":1428,"in_reply_to":"d132c0df_d11c14da","updated":"2024-03-11 23:15:59.000000000","message":"I see. I will fix.","commit_id":"30629f871cedaa116dbc5ae0e298ee567af1ca35"}]}