)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"ff5be6a3e5c21d8a5f2fd6c30192037fd713233e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d2889faa_d8c1a1ff","updated":"2024-02-27 05:42:24.000000000","message":"Thank you for the review.","commit_id":"da980e46ab155709637bcd7d467eceb80b488132"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"e2f562f6f5d67ea7b8d61d0dec8b5735ebc14b8f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f279f3ff_849153aa","updated":"2024-02-28 06:43:35.000000000","message":"Thank you for the review.","commit_id":"1ec4a730b8c9c6ad0dcf5bb6d81522b6d968b519"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"8408e457d547771f9fd4f2915637d8932c54e303","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"24587ab4_d9bdc087","updated":"2024-02-29 07:42:49.000000000","message":"Thank you for the review.","commit_id":"e340da94d719cc1ee90b08a75b8fe7b0f6309c4e"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"e98a809cb5d35e4984729c4f7f5d83cc66d3e7e9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"db588dbe_e548af26","updated":"2024-03-05 05:53:36.000000000","message":"Thank you for the review.","commit_id":"44dde9819b4ba3bbf4a68305b7f0751f1511ccc6"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"77c943a8636b42f7c0a6ecded6d82797f6ded720","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2f0584ef_5af14475","updated":"2024-02-29 22:04:02.000000000","message":"recheck infra-failure","commit_id":"44dde9819b4ba3bbf4a68305b7f0751f1511ccc6"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"e701e65570fdace990f94cbdfb0f46696c7f396e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"136a4dc1_f1980448","updated":"2024-03-07 02:59:07.000000000","message":"LGTM","commit_id":"03b3fe6f981ff130e08c15c0a0cf92d7d71f5c10"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"18536b42e83da15c5370a0b6893101fe4dae10e4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"dce78845_26666d75","updated":"2024-03-13 13:24:56.000000000","message":"LGTM, thanks for your patch.","commit_id":"03b3fe6f981ff130e08c15c0a0cf92d7d71f5c10"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"30d97815a359cd9f28a0e11c0ce83bd301796b00","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"10f2469b_a876dacc","updated":"2024-03-06 22:58:28.000000000","message":"recheck infra-failure","commit_id":"03b3fe6f981ff130e08c15c0a0cf92d7d71f5c10"}],"doc/source/user/etsi_containerized_vnf_usage_guide.rst":[{"author":{"_account_id":31668,"deleted":true},"change_message_id":"66178e47dda4f139af9cfcfc6b40837bfde42dca","unresolved":true,"context_lines":[{"line_number":312,"context_line":"          ``topology_template.node_templates.VDU1.properties.name``"},{"line_number":313,"context_line":"          in the helloworld3_df_simple.yaml file."},{"line_number":314,"context_line":""},{"line_number":315,"context_line":".. note:: In version 2 API, the ``tacker_vnf_instance`` key and"},{"line_number":316,"context_line":"          VNF instance ID value are added to the ``metadata.labels`` to"},{"line_number":317,"context_line":"          identify which VNF instance created the resource."},{"line_number":318,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"85eb3126_105b8672","line":315,"updated":"2024-02-28 02:25:21.000000000","message":"\"tacker_vnf_instance_id\" is correct.","commit_id":"1ec4a730b8c9c6ad0dcf5bb6d81522b6d968b519"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"0c0ba9ae68cc3e8cab953c46d375e9a46ce0a1a8","unresolved":false,"context_lines":[{"line_number":312,"context_line":"          ``topology_template.node_templates.VDU1.properties.name``"},{"line_number":313,"context_line":"          in the helloworld3_df_simple.yaml file."},{"line_number":314,"context_line":""},{"line_number":315,"context_line":".. note:: In version 2 API, the ``tacker_vnf_instance`` key and"},{"line_number":316,"context_line":"          VNF instance ID value are added to the ``metadata.labels`` to"},{"line_number":317,"context_line":"          identify which VNF instance created the resource."},{"line_number":318,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"51e022eb_e1b36e8c","line":315,"in_reply_to":"50bc66f6_b78ff19f","updated":"2024-02-29 04:40:56.000000000","message":"Done","commit_id":"1ec4a730b8c9c6ad0dcf5bb6d81522b6d968b519"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"e2f562f6f5d67ea7b8d61d0dec8b5735ebc14b8f","unresolved":true,"context_lines":[{"line_number":312,"context_line":"          ``topology_template.node_templates.VDU1.properties.name``"},{"line_number":313,"context_line":"          in the helloworld3_df_simple.yaml file."},{"line_number":314,"context_line":""},{"line_number":315,"context_line":".. note:: In version 2 API, the ``tacker_vnf_instance`` key and"},{"line_number":316,"context_line":"          VNF instance ID value are added to the ``metadata.labels`` to"},{"line_number":317,"context_line":"          identify which VNF instance created the resource."},{"line_number":318,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"50bc66f6_b78ff19f","line":315,"in_reply_to":"85eb3126_105b8672","updated":"2024-02-28 06:43:35.000000000","message":"I will fix.","commit_id":"1ec4a730b8c9c6ad0dcf5bb6d81522b6d968b519"}],"tacker/sol_refactored/infra_drivers/kubernetes/kubernetes_resource.py":[{"author":{"_account_id":31668,"deleted":true},"change_message_id":"66178e47dda4f139af9cfcfc6b40837bfde42dca","unresolved":true,"context_lines":[{"line_number":66,"context_line":"            if info is None:"},{"line_number":67,"context_line":"                return False"},{"line_number":68,"context_line":"            if (self.inst_id is not None and"},{"line_number":69,"context_line":"                    info.metadata.labels.get("},{"line_number":70,"context_line":"                        VNF_INSTANCE_ID_LABEL) !\u003d self.inst_id):"},{"line_number":71,"context_line":"                return False"},{"line_number":72,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":2,"id":"606d9509_74eb85e3","line":69,"updated":"2024-02-28 02:25:21.000000000","message":"If an existing resource with the same name does not have \"labels\", the following error will occur and 500 will be returned.\n* \u0027NoneType\u0027 object has no attribute \u0027get\u0027\n\nI think it is better to return False even if \"labels\" is not defined.","commit_id":"1ec4a730b8c9c6ad0dcf5bb6d81522b6d968b519"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"8408e457d547771f9fd4f2915637d8932c54e303","unresolved":true,"context_lines":[{"line_number":66,"context_line":"            if info is None:"},{"line_number":67,"context_line":"                return False"},{"line_number":68,"context_line":"            if (self.inst_id is not None and"},{"line_number":69,"context_line":"                    info.metadata.labels.get("},{"line_number":70,"context_line":"                        VNF_INSTANCE_ID_LABEL) !\u003d self.inst_id):"},{"line_number":71,"context_line":"                return False"},{"line_number":72,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":2,"id":"53cbb38d_0c8909d3","line":69,"in_reply_to":"0410ad0d_3ca7f792","updated":"2024-02-29 07:42:49.000000000","message":"Thank you for the proposed modification.\nI think the conditions are wrong. Please check the code so I will fix it.","commit_id":"1ec4a730b8c9c6ad0dcf5bb6d81522b6d968b519"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"e701e65570fdace990f94cbdfb0f46696c7f396e","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            if info is None:"},{"line_number":67,"context_line":"                return False"},{"line_number":68,"context_line":"            if (self.inst_id is not None and"},{"line_number":69,"context_line":"                    info.metadata.labels.get("},{"line_number":70,"context_line":"                        VNF_INSTANCE_ID_LABEL) !\u003d self.inst_id):"},{"line_number":71,"context_line":"                return False"},{"line_number":72,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":2,"id":"88641f94_2f719a52","line":69,"in_reply_to":"3aea461d_7e8e4716","updated":"2024-03-07 02:59:07.000000000","message":"Done","commit_id":"1ec4a730b8c9c6ad0dcf5bb6d81522b6d968b519"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"6192675a344136b93ca2b6c470babd8d796f2cbf","unresolved":true,"context_lines":[{"line_number":66,"context_line":"            if info is None:"},{"line_number":67,"context_line":"                return False"},{"line_number":68,"context_line":"            if (self.inst_id is not None and"},{"line_number":69,"context_line":"                    info.metadata.labels.get("},{"line_number":70,"context_line":"                        VNF_INSTANCE_ID_LABEL) !\u003d self.inst_id):"},{"line_number":71,"context_line":"                return False"},{"line_number":72,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":2,"id":"71681d01_f144d99b","line":69,"in_reply_to":"53cbb38d_0c8909d3","updated":"2024-03-05 02:02:44.000000000","message":"Thank you for the fix.\nI understand that inst_id is None when using helm.\nL.69-L.72 is the route when using helm, so could you please add that to the comment?","commit_id":"1ec4a730b8c9c6ad0dcf5bb6d81522b6d968b519"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"e2f562f6f5d67ea7b8d61d0dec8b5735ebc14b8f","unresolved":true,"context_lines":[{"line_number":66,"context_line":"            if info is None:"},{"line_number":67,"context_line":"                return False"},{"line_number":68,"context_line":"            if (self.inst_id is not None and"},{"line_number":69,"context_line":"                    info.metadata.labels.get("},{"line_number":70,"context_line":"                        VNF_INSTANCE_ID_LABEL) !\u003d self.inst_id):"},{"line_number":71,"context_line":"                return False"},{"line_number":72,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":2,"id":"ec99fc32_881c2781","line":69,"in_reply_to":"606d9509_74eb85e3","updated":"2024-02-28 06:43:35.000000000","message":"I will fix.","commit_id":"1ec4a730b8c9c6ad0dcf5bb6d81522b6d968b519"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"e98a809cb5d35e4984729c4f7f5d83cc66d3e7e9","unresolved":true,"context_lines":[{"line_number":66,"context_line":"            if info is None:"},{"line_number":67,"context_line":"                return False"},{"line_number":68,"context_line":"            if (self.inst_id is not None and"},{"line_number":69,"context_line":"                    info.metadata.labels.get("},{"line_number":70,"context_line":"                        VNF_INSTANCE_ID_LABEL) !\u003d self.inst_id):"},{"line_number":71,"context_line":"                return False"},{"line_number":72,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aea461d_7e8e4716","line":69,"in_reply_to":"71681d01_f144d99b","updated":"2024-03-05 05:53:36.000000000","message":"Ok, I will add a comment that it is a case of using helm.","commit_id":"1ec4a730b8c9c6ad0dcf5bb6d81522b6d968b519"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"0c0ba9ae68cc3e8cab953c46d375e9a46ce0a1a8","unresolved":true,"context_lines":[{"line_number":66,"context_line":"            if info is None:"},{"line_number":67,"context_line":"                return False"},{"line_number":68,"context_line":"            if (self.inst_id is not None and"},{"line_number":69,"context_line":"                    info.metadata.labels.get("},{"line_number":70,"context_line":"                        VNF_INSTANCE_ID_LABEL) !\u003d self.inst_id):"},{"line_number":71,"context_line":"                return False"},{"line_number":72,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":2,"id":"0410ad0d_3ca7f792","line":69,"in_reply_to":"ec99fc32_881c2781","updated":"2024-02-29 04:40:56.000000000","message":"Since the \"if\" condition is complicated, how about doing it like this?\n```\ndef is_exists(self):\n    try:\n        info \u003d self.read()\n        return (\n            info is not None\n            and info.metadata.labels is not None\n            and self.inst_id is not None\n            and info.metadata.labels.get(\n                VNF_INSTANCE_ID_LABEL) \u003d\u003d self.inst_id\n        )\n    except sol_ex.K8sResourceNotFound:\n        return False\n```","commit_id":"1ec4a730b8c9c6ad0dcf5bb6d81522b6d968b519"}],"tacker/sol_refactored/infra_drivers/kubernetes/kubernetes_utils.py":[{"author":{"_account_id":31668,"deleted":true},"change_message_id":"9f8253cfae1316eaa04e46f57c1db2558a58a30a","unresolved":true,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"SUPPORTED_NAMESPACE_KINDS \u003d {"},{"line_number":35,"context_line":"    \"Binding\","},{"line_number":36,"context_line":"    \"ConfigMap\","},{"line_number":37,"context_line":"    \"ControllerRevision\","}],"source_content_type":"text/x-python","patch_set":1,"id":"65a65cb0_25dfe507","line":34,"updated":"2024-02-26 10:28:32.000000000","message":"Currently, KIND grouping definitions are as follows.\n* kubernetes.SCALABLE_KIND\n* kubernetes_common.TARGET_KIND\n* kubernetes_utils.SUPPORTED_NAMESPACE_KINDS\n* kubernetes_utils.UNLABELED_KIND\n\nIt is better to change `SUPPORTED_NAMESPACE_KINDS` to `SUPPORTED_NAMESPACE_KIND` along with others.\n\nConsidering future maintenance, I felt that it would be better to have these KIND grouping definitions in the same place. What do you think?\nFor example, I think one way is to move `SCALABLE_KIND` and `TARGET_KIND` to kubernetes_utils.","commit_id":"da980e46ab155709637bcd7d467eceb80b488132"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"ff5be6a3e5c21d8a5f2fd6c30192037fd713233e","unresolved":true,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"SUPPORTED_NAMESPACE_KINDS \u003d {"},{"line_number":35,"context_line":"    \"Binding\","},{"line_number":36,"context_line":"    \"ConfigMap\","},{"line_number":37,"context_line":"    \"ControllerRevision\","}],"source_content_type":"text/x-python","patch_set":1,"id":"d25c84fa_e40d24b5","line":34,"in_reply_to":"65a65cb0_25dfe507","updated":"2024-02-27 05:42:24.000000000","message":"`SUPPORTED_NAMESPACE_KINDS` will be modified along with the others.\n\nI think it would be better to have the configuration in the same file. `SCALABLE_KIND` and `TARGET_KIND` will be moved to kubernetes_utils.","commit_id":"da980e46ab155709637bcd7d467eceb80b488132"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"66178e47dda4f139af9cfcfc6b40837bfde42dca","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"SUPPORTED_NAMESPACE_KINDS \u003d {"},{"line_number":35,"context_line":"    \"Binding\","},{"line_number":36,"context_line":"    \"ConfigMap\","},{"line_number":37,"context_line":"    \"ControllerRevision\","}],"source_content_type":"text/x-python","patch_set":1,"id":"921a0092_5921fc60","line":34,"in_reply_to":"d25c84fa_e40d24b5","updated":"2024-02-28 02:25:21.000000000","message":"Done","commit_id":"da980e46ab155709637bcd7d467eceb80b488132"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"9f8253cfae1316eaa04e46f57c1db2558a58a30a","unresolved":true,"context_lines":[{"line_number":92,"context_line":"            k8s_res.setdefault(\u0027metadata\u0027, {})"},{"line_number":93,"context_line":"            k8s_res[\u0027metadata\u0027].setdefault(\u0027labels\u0027, {})"},{"line_number":94,"context_line":"            k8s_res[\u0027metadata\u0027][\u0027labels\u0027]["},{"line_number":95,"context_line":"                kubernetes_resource.VNF_INSTANCE_ID_LABEL] \u003d inst_id"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    # check namespace"},{"line_number":98,"context_line":"    if namespace is None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"c6cfe47f_62f1e39b","line":95,"updated":"2024-02-26 10:28:32.000000000","message":"Is it not necessary to write in the user guide that `tacker_vnf_instance_id` is a special label?","commit_id":"da980e46ab155709637bcd7d467eceb80b488132"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"e2f562f6f5d67ea7b8d61d0dec8b5735ebc14b8f","unresolved":true,"context_lines":[{"line_number":92,"context_line":"            k8s_res.setdefault(\u0027metadata\u0027, {})"},{"line_number":93,"context_line":"            k8s_res[\u0027metadata\u0027].setdefault(\u0027labels\u0027, {})"},{"line_number":94,"context_line":"            k8s_res[\u0027metadata\u0027][\u0027labels\u0027]["},{"line_number":95,"context_line":"                kubernetes_resource.VNF_INSTANCE_ID_LABEL] \u003d inst_id"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    # check namespace"},{"line_number":98,"context_line":"    if namespace is None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"cd380134_adf11b33","line":95,"in_reply_to":"1419f27a_6cd8a075","updated":"2024-02-28 06:43:35.000000000","message":"Thank you for the confirmation, I will add it to the note.\nOnly \"VNF Instance ID\" will be changed to \"VNF instance ID\" along with the others.","commit_id":"da980e46ab155709637bcd7d467eceb80b488132"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"8408e457d547771f9fd4f2915637d8932c54e303","unresolved":true,"context_lines":[{"line_number":92,"context_line":"            k8s_res.setdefault(\u0027metadata\u0027, {})"},{"line_number":93,"context_line":"            k8s_res[\u0027metadata\u0027].setdefault(\u0027labels\u0027, {})"},{"line_number":94,"context_line":"            k8s_res[\u0027metadata\u0027][\u0027labels\u0027]["},{"line_number":95,"context_line":"                kubernetes_resource.VNF_INSTANCE_ID_LABEL] \u003d inst_id"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    # check namespace"},{"line_number":98,"context_line":"    if namespace is None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"df62520c_44e832f8","line":95,"in_reply_to":"5975a8c0_789d847f","updated":"2024-02-29 07:42:49.000000000","message":"I think \"by\" is fine, but \"with\" is also fine.\nI will change it to \"with\".","commit_id":"da980e46ab155709637bcd7d467eceb80b488132"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"ff5be6a3e5c21d8a5f2fd6c30192037fd713233e","unresolved":true,"context_lines":[{"line_number":92,"context_line":"            k8s_res.setdefault(\u0027metadata\u0027, {})"},{"line_number":93,"context_line":"            k8s_res[\u0027metadata\u0027].setdefault(\u0027labels\u0027, {})"},{"line_number":94,"context_line":"            k8s_res[\u0027metadata\u0027][\u0027labels\u0027]["},{"line_number":95,"context_line":"                kubernetes_resource.VNF_INSTANCE_ID_LABEL] \u003d inst_id"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    # check namespace"},{"line_number":98,"context_line":"    if namespace is None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"b170d6cd_c6f5a1cb","line":95,"in_reply_to":"977d07c2_02667864","updated":"2024-02-27 05:42:24.000000000","message":"Thank you for the instructions on how to correct the documentation.\nI will add about the `tacker_vnf_instance_id` label.","commit_id":"da980e46ab155709637bcd7d467eceb80b488132"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"66178e47dda4f139af9cfcfc6b40837bfde42dca","unresolved":true,"context_lines":[{"line_number":92,"context_line":"            k8s_res.setdefault(\u0027metadata\u0027, {})"},{"line_number":93,"context_line":"            k8s_res[\u0027metadata\u0027].setdefault(\u0027labels\u0027, {})"},{"line_number":94,"context_line":"            k8s_res[\u0027metadata\u0027][\u0027labels\u0027]["},{"line_number":95,"context_line":"                kubernetes_resource.VNF_INSTANCE_ID_LABEL] \u003d inst_id"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    # check namespace"},{"line_number":98,"context_line":"    if namespace is None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1419f27a_6cd8a075","line":95,"in_reply_to":"b170d6cd_c6f5a1cb","updated":"2024-02-28 02:25:21.000000000","message":"Thank you for the additional note.\nCould you also add the following?\n````\nPlease note that if you have defined the \"tacker_vnf_instance_id\" label in advance, the value will be overwritten by the VNF Instance ID.\n````","commit_id":"da980e46ab155709637bcd7d467eceb80b488132"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"835877c1b396f9c5063b953812f49709063be2d6","unresolved":true,"context_lines":[{"line_number":92,"context_line":"            k8s_res.setdefault(\u0027metadata\u0027, {})"},{"line_number":93,"context_line":"            k8s_res[\u0027metadata\u0027].setdefault(\u0027labels\u0027, {})"},{"line_number":94,"context_line":"            k8s_res[\u0027metadata\u0027][\u0027labels\u0027]["},{"line_number":95,"context_line":"                kubernetes_resource.VNF_INSTANCE_ID_LABEL] \u003d inst_id"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    # check namespace"},{"line_number":98,"context_line":"    if namespace is None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"977d07c2_02667864","line":95,"in_reply_to":"c6cfe47f_62f1e39b","updated":"2024-02-27 02:42:27.000000000","message":"How about adding a Note for v2 regarding the `tacker_vnf_instance_id` label to the \"2. Create a Kubernetes Object File\" section of `ETSI NFV-SOL CNF (Containerized VNF) Deployment`?\n* https://opendev.org/openstack/tacker/src/branch/master/doc/source/user/etsi_containerized_vnf_usage_guide.rst?display\u003dsource#L258","commit_id":"da980e46ab155709637bcd7d467eceb80b488132"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"0c0ba9ae68cc3e8cab953c46d375e9a46ce0a1a8","unresolved":true,"context_lines":[{"line_number":92,"context_line":"            k8s_res.setdefault(\u0027metadata\u0027, {})"},{"line_number":93,"context_line":"            k8s_res[\u0027metadata\u0027].setdefault(\u0027labels\u0027, {})"},{"line_number":94,"context_line":"            k8s_res[\u0027metadata\u0027][\u0027labels\u0027]["},{"line_number":95,"context_line":"                kubernetes_resource.VNF_INSTANCE_ID_LABEL] \u003d inst_id"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    # check namespace"},{"line_number":98,"context_line":"    if namespace is None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5975a8c0_789d847f","line":95,"in_reply_to":"cd380134_adf11b33","updated":"2024-02-29 04:40:56.000000000","message":"Yes, I also think \"VNF instance ID\" is better.\nAnd it seems that \"with\" is more appropriate than \"by\".\nWhat do you think?\n```\nPlease note that if you have defined the ``tacker_vnf_instance_id``\nlabel in advance, the value will be overwritten with\nthe VNF instance ID.\n```","commit_id":"da980e46ab155709637bcd7d467eceb80b488132"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"6192675a344136b93ca2b6c470babd8d796f2cbf","unresolved":false,"context_lines":[{"line_number":92,"context_line":"            k8s_res.setdefault(\u0027metadata\u0027, {})"},{"line_number":93,"context_line":"            k8s_res[\u0027metadata\u0027].setdefault(\u0027labels\u0027, {})"},{"line_number":94,"context_line":"            k8s_res[\u0027metadata\u0027][\u0027labels\u0027]["},{"line_number":95,"context_line":"                kubernetes_resource.VNF_INSTANCE_ID_LABEL] \u003d inst_id"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    # check namespace"},{"line_number":98,"context_line":"    if namespace is None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"bc1c6065_ec03ce48","line":95,"in_reply_to":"df62520c_44e832f8","updated":"2024-03-05 02:02:44.000000000","message":"Done","commit_id":"da980e46ab155709637bcd7d467eceb80b488132"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"9f8253cfae1316eaa04e46f57c1db2558a58a30a","unresolved":true,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"def list_namespaced_pods(k8s_api_client, namespace):"},{"line_number":118,"context_line":"    k8s_client \u003d client.CoreV1Api(api_client\u003dk8s_api_client)"},{"line_number":119,"context_line":"    return k8s_client.list_namespaced_pod(namespace\u003dnamespace).items"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"class AuthContextManager:"}],"source_content_type":"text/x-python","patch_set":1,"id":"26fea54a_1370de9a","line":119,"updated":"2024-02-26 10:28:32.000000000","message":"Will support for label_selector of list_namespaced_pod be implemented in another patch in the future?\n* https://github.com/kubernetes-client/python/blob/release-26.0/kubernetes/docs/CoreV1Api.md#list_namespaced_pod\n\nI think it would be more efficient to be able to get a list of resources for each VNF Instance using label_selector.","commit_id":"da980e46ab155709637bcd7d467eceb80b488132"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"ff5be6a3e5c21d8a5f2fd6c30192037fd713233e","unresolved":true,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"def list_namespaced_pods(k8s_api_client, namespace):"},{"line_number":118,"context_line":"    k8s_client \u003d client.CoreV1Api(api_client\u003dk8s_api_client)"},{"line_number":119,"context_line":"    return k8s_client.list_namespaced_pod(namespace\u003dnamespace).items"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"class AuthContextManager:"}],"source_content_type":"text/x-python","patch_set":1,"id":"df0934cf_bcc69a50","line":119,"in_reply_to":"26fea54a_1370de9a","updated":"2024-02-27 05:42:24.000000000","message":"I don\u0027t intend to fix it in this patch, but it would be nice to support label_selector for `list_namespaced_pod` in the future.\nIs that okay?","commit_id":"da980e46ab155709637bcd7d467eceb80b488132"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"66178e47dda4f139af9cfcfc6b40837bfde42dca","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"def list_namespaced_pods(k8s_api_client, namespace):"},{"line_number":118,"context_line":"    k8s_client \u003d client.CoreV1Api(api_client\u003dk8s_api_client)"},{"line_number":119,"context_line":"    return k8s_client.list_namespaced_pod(namespace\u003dnamespace).items"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"class AuthContextManager:"}],"source_content_type":"text/x-python","patch_set":1,"id":"df2b10b8_861c7a99","line":119,"in_reply_to":"df0934cf_bcc69a50","updated":"2024-02-28 02:25:21.000000000","message":"Yes, I think it would be a good idea to fix this in another patch in the future.\nIt would be easy to just support label_selector in list_namespaced_pod, but in order to actually improve the efficiency of resource search, some considerations and modifications are required.","commit_id":"da980e46ab155709637bcd7d467eceb80b488132"}]}