)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"69a86b1d5ab16ba8edae6d430736bb04fb566113","unresolved":true,"context_lines":[{"line_number":3,"context_line":"AuthorDate: 2024-06-18 12:19:12 +0900"},{"line_number":4,"context_line":"Commit:     Tatsuji Miyamoto \u003ctt-miyamoto@kddi.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-06-18 12:19:12 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"`cert_verify` parameter included in the request body when executing the register vim API does not support the bool type."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If a bool type is specified for the `cert_verify` parameter included in the request body when executing the register vim API, it is not judged whether it is a string of \"True\" or \"False\" and an error occurs.Therefore, we would like to make it so that it is judged whether it is a bool type or not."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"8b820a8b_1cfde25a","line":6,"updated":"2024-06-18 09:02:10.000000000","message":"You should start from a title of this commit message and it must be lower than 50 chars.","commit_id":"f2f527ec1bd52c5ad297e5ab95d50f62e4566649"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"8aa1ff0ca766fe2cfe7321f671601a9ba9dfc0eb","unresolved":false,"context_lines":[{"line_number":3,"context_line":"AuthorDate: 2024-06-18 12:19:12 +0900"},{"line_number":4,"context_line":"Commit:     Tatsuji Miyamoto \u003ctt-miyamoto@kddi.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-06-18 12:19:12 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"`cert_verify` parameter included in the request body when executing the register vim API does not support the bool type."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If a bool type is specified for the `cert_verify` parameter included in the request body when executing the register vim API, it is not judged whether it is a string of \"True\" or \"False\" and an error occurs.Therefore, we would like to make it so that it is judged whether it is a bool type or not."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7df10ae9_68ac50fc","line":6,"in_reply_to":"03371a21_d3f938fd","updated":"2024-09-11 21:55:47.000000000","message":"Acknowledged","commit_id":"f2f527ec1bd52c5ad297e5ab95d50f62e4566649"},{"author":{"_account_id":37108,"name":"Hitomi Koba","email":"hi-koba@kddi.com","username":"hitomikoba"},"change_message_id":"a6b74ae7b113ed80f21c10a6a727c34b84896b2a","unresolved":true,"context_lines":[{"line_number":3,"context_line":"AuthorDate: 2024-06-18 12:19:12 +0900"},{"line_number":4,"context_line":"Commit:     Tatsuji Miyamoto \u003ctt-miyamoto@kddi.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-06-18 12:19:12 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"`cert_verify` parameter included in the request body when executing the register vim API does not support the bool type."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If a bool type is specified for the `cert_verify` parameter included in the request body when executing the register vim API, it is not judged whether it is a string of \"True\" or \"False\" and an error occurs.Therefore, we would like to make it so that it is judged whether it is a bool type or not."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da26f50a_30e50d4e","line":6,"in_reply_to":"8b820a8b_1cfde25a","updated":"2024-07-09 11:57:28.000000000","message":"Fixed the issues you pointed out.","commit_id":"f2f527ec1bd52c5ad297e5ab95d50f62e4566649"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"76f6a3e299f4b2b7eab9650606cccea6642bb7d7","unresolved":true,"context_lines":[{"line_number":3,"context_line":"AuthorDate: 2024-06-18 12:19:12 +0900"},{"line_number":4,"context_line":"Commit:     Tatsuji Miyamoto \u003ctt-miyamoto@kddi.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-06-18 12:19:12 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"`cert_verify` parameter included in the request body when executing the register vim API does not support the bool type."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If a bool type is specified for the `cert_verify` parameter included in the request body when executing the register vim API, it is not judged whether it is a string of \"True\" or \"False\" and an error occurs.Therefore, we would like to make it so that it is judged whether it is a bool type or not."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"eca0a42b_925bdd3d","line":6,"in_reply_to":"da26f50a_30e50d4e","updated":"2024-09-09 10:35:19.000000000","message":"The title line is still over 50 characters.\nIn addition, could you write the subsequent line wrapped at 72 characters?\n\n[1] https://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure\n\u003e * The first line should be limited to 50 characters and should not end with a period.\n\u003e * Subsequent lines should be wrapped at 72 characters.","commit_id":"f2f527ec1bd52c5ad297e5ab95d50f62e4566649"},{"author":{"_account_id":37108,"name":"Hitomi Koba","email":"hi-koba@kddi.com","username":"hitomikoba"},"change_message_id":"e0656c9af9af42aee4a296fbadfc63f126a2e30e","unresolved":true,"context_lines":[{"line_number":3,"context_line":"AuthorDate: 2024-06-18 12:19:12 +0900"},{"line_number":4,"context_line":"Commit:     Tatsuji Miyamoto \u003ctt-miyamoto@kddi.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-06-18 12:19:12 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"`cert_verify` parameter included in the request body when executing the register vim API does not support the bool type."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If a bool type is specified for the `cert_verify` parameter included in the request body when executing the register vim API, it is not judged whether it is a string of \"True\" or \"False\" and an error occurs.Therefore, we would like to make it so that it is judged whether it is a bool type or not."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"03371a21_d3f938fd","line":6,"in_reply_to":"eca0a42b_925bdd3d","updated":"2024-09-09 10:47:29.000000000","message":"Sorry again and again. I\u0027ve addressed the comments.","commit_id":"f2f527ec1bd52c5ad297e5ab95d50f62e4566649"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"a90ac317338eb2350d24ec99029b23a54f2154af","unresolved":true,"context_lines":[{"line_number":10,"context_line":"supports the string values \"True\" or \"False\"."},{"line_number":11,"context_line":"Considering the meaning of the variable, it will be updated to also support"},{"line_number":12,"context_line":"boolean values."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I63a19704f5e7ae4ce0b912907f61a877a9dcbaad"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"f53615e8_f0031666","line":13,"updated":"2024-09-09 07:33:53.000000000","message":"Could you add a `Closes-Bug` tag as below?\n```\nCloses-Bug: #2069549\n```","commit_id":"72401c3f01e8fb200a991abffa58d67cf9499bf0"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"76f6a3e299f4b2b7eab9650606cccea6642bb7d7","unresolved":false,"context_lines":[{"line_number":10,"context_line":"supports the string values \"True\" or \"False\"."},{"line_number":11,"context_line":"Considering the meaning of the variable, it will be updated to also support"},{"line_number":12,"context_line":"boolean values."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I63a19704f5e7ae4ce0b912907f61a877a9dcbaad"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"bfddc62c_d66db93a","line":13,"in_reply_to":"31159430_85f1758b","updated":"2024-09-09 10:35:19.000000000","message":"Acknowledged","commit_id":"72401c3f01e8fb200a991abffa58d67cf9499bf0"},{"author":{"_account_id":37108,"name":"Hitomi Koba","email":"hi-koba@kddi.com","username":"hitomikoba"},"change_message_id":"92d17ab0c3cce4955fe978e370cadf28af1e19a1","unresolved":true,"context_lines":[{"line_number":10,"context_line":"supports the string values \"True\" or \"False\"."},{"line_number":11,"context_line":"Considering the meaning of the variable, it will be updated to also support"},{"line_number":12,"context_line":"boolean values."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I63a19704f5e7ae4ce0b912907f61a877a9dcbaad"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"31159430_85f1758b","line":13,"in_reply_to":"f53615e8_f0031666","updated":"2024-09-09 10:23:27.000000000","message":"Fixed the issues you pointed out.","commit_id":"72401c3f01e8fb200a991abffa58d67cf9499bf0"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"e26778b484ca2de796663ef7ed4ff843a8c61a27","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"42148aed_87433e6c","updated":"2024-06-18 09:00:30.000000000","message":"Please find my tiny comment and some notices from zuul for invalid coding style. Thanks.","commit_id":"f2f527ec1bd52c5ad297e5ab95d50f62e4566649"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"a90ac317338eb2350d24ec99029b23a54f2154af","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"0f470fff_2d0157be","updated":"2024-09-09 07:33:53.000000000","message":"Thanks for your patch, please kindly find my comment.","commit_id":"72401c3f01e8fb200a991abffa58d67cf9499bf0"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"76f6a3e299f4b2b7eab9650606cccea6642bb7d7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e7da1ac3_7d058afd","updated":"2024-09-09 10:35:19.000000000","message":"Sorry in addition, please kindly find my comment.","commit_id":"09de6e68d69ca4b58f3efe7308afc2a09b809548"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"7a7db5c3265a517c2f26102144f47d6e9035251c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"b5ef66ea_b895938b","updated":"2024-09-11 21:54:44.000000000","message":"Thanks for your rework, LGTM.","commit_id":"dbbdf67c9d06e39266478851eeae21fff9c2ed10"}],"tacker/common/utils.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"e26778b484ca2de796663ef7ed4ff843a8c61a27","unresolved":true,"context_lines":[{"line_number":706,"context_line":"    elif value.lower() not in (\u0027true\u0027, \u0027false\u0027):"},{"line_number":707,"context_line":"        msg \u003d _(\u0027Can\\\u0027t convert \"{}\" to Bool\u0027.format(value))"},{"line_number":708,"context_line":"        raise ValueError(msg)"},{"line_number":709,"context_line":"    return value.lower() \u003d\u003d \u0027true\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"4a518ed2_fc869ee8","line":709,"updated":"2024-06-18 09:00:30.000000000","message":"It allows even if the value is such as \"tRue\" or \"faLSE\" which might be unexpected behavior. Although I\u0027m not sure why you prefer to allow lower cases from your commit message or bug report, I think we don\u0027t need to so without any specific requirement. Here is my suggestion.\n\n```\nif value in (\"True\", \"False\"):\n  return eval(value)\nelif isinstance(value, bool):\n  return value\n```","commit_id":"f2f527ec1bd52c5ad297e5ab95d50f62e4566649"},{"author":{"_account_id":37108,"name":"Hitomi Koba","email":"hi-koba@kddi.com","username":"hitomikoba"},"change_message_id":"324318be86a5cf3ef0518e14c754d9e7c83313c6","unresolved":true,"context_lines":[{"line_number":706,"context_line":"    elif value.lower() not in (\u0027true\u0027, \u0027false\u0027):"},{"line_number":707,"context_line":"        msg \u003d _(\u0027Can\\\u0027t convert \"{}\" to Bool\u0027.format(value))"},{"line_number":708,"context_line":"        raise ValueError(msg)"},{"line_number":709,"context_line":"    return value.lower() \u003d\u003d \u0027true\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"a897441b_efb6bfa5","line":709,"in_reply_to":"4a518ed2_fc869ee8","updated":"2024-07-09 12:01:15.000000000","message":"Fixed the issues you pointed out.","commit_id":"f2f527ec1bd52c5ad297e5ab95d50f62e4566649"}]}