)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"e133831dd2dcfa9ddbe886c660a429debe7e68a9","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add default option of vim_keys as common key"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When a Tacker is made redundant for load balancing, there is a problem that deleting a resource instantiated by another Tacker fails. (For example, if you have a tracker-0/1, instantiate on tracker-0, and try to terminate on tracker-1, it will fail.)"},{"line_number":10,"context_line":"This fails because the Tacker\u0027s fernet_key is randomly generated at each VIM registration. However, there is no function implemented to share/synchronize keys between Tackers, and the keys must be copied manually. To solve this problem, we request the addition of an optional feature that allows Tackers to specify a common key to each other. Specifically, we would like to be able to specify the use of a default-key pre-created in `tacker.conf`."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Id5633b916118af144f9116da732ac3b79cfe5daf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7d0a005b_88806885","line":9,"range":{"start_line":9,"start_character":162,"end_line":9,"end_character":169},"updated":"2024-09-09 05:39:11.000000000","message":"Is `tracker` correct?","commit_id":"b75ffb65104d216187e9b38be431f20538acbbb4"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"e133831dd2dcfa9ddbe886c660a429debe7e68a9","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add default option of vim_keys as common key"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When a Tacker is made redundant for load balancing, there is a problem that deleting a resource instantiated by another Tacker fails. (For example, if you have a tracker-0/1, instantiate on tracker-0, and try to terminate on tracker-1, it will fail.)"},{"line_number":10,"context_line":"This fails because the Tacker\u0027s fernet_key is randomly generated at each VIM registration. However, there is no function implemented to share/synchronize keys between Tackers, and the keys must be copied manually. To solve this problem, we request the addition of an optional feature that allows Tackers to specify a common key to each other. Specifically, we would like to be able to specify the use of a default-key pre-created in `tacker.conf`."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Id5633b916118af144f9116da732ac3b79cfe5daf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"e29b25c4_9a3c8cc3","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":250},"updated":"2024-09-09 05:39:11.000000000","message":"Is it not good to use barbican?\nDo you get the same error when you use barbican to manage keys?\nIf not, it is better to write clearly state that this is a problem when using fernet instead of barbican.","commit_id":"b75ffb65104d216187e9b38be431f20538acbbb4"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"e133831dd2dcfa9ddbe886c660a429debe7e68a9","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add default option of vim_keys as common key"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When a Tacker is made redundant for load balancing, there is a problem that deleting a resource instantiated by another Tacker fails. (For example, if you have a tracker-0/1, instantiate on tracker-0, and try to terminate on tracker-1, it will fail.)"},{"line_number":10,"context_line":"This fails because the Tacker\u0027s fernet_key is randomly generated at each VIM registration. However, there is no function implemented to share/synchronize keys between Tackers, and the keys must be copied manually. To solve this problem, we request the addition of an optional feature that allows Tackers to specify a common key to each other. Specifically, we would like to be able to specify the use of a default-key pre-created in `tacker.conf`."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Id5633b916118af144f9116da732ac3b79cfe5daf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"d042d9ae_1bbbc1dd","line":9,"range":{"start_line":9,"start_character":190,"end_line":9,"end_character":197},"updated":"2024-09-09 05:39:11.000000000","message":"ditto","commit_id":"b75ffb65104d216187e9b38be431f20538acbbb4"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"e133831dd2dcfa9ddbe886c660a429debe7e68a9","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add default option of vim_keys as common key"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When a Tacker is made redundant for load balancing, there is a problem that deleting a resource instantiated by another Tacker fails. (For example, if you have a tracker-0/1, instantiate on tracker-0, and try to terminate on tracker-1, it will fail.)"},{"line_number":10,"context_line":"This fails because the Tacker\u0027s fernet_key is randomly generated at each VIM registration. However, there is no function implemented to share/synchronize keys between Tackers, and the keys must be copied manually. To solve this problem, we request the addition of an optional feature that allows Tackers to specify a common key to each other. Specifically, we would like to be able to specify the use of a default-key pre-created in `tacker.conf`."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Id5633b916118af144f9116da732ac3b79cfe5daf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"17e14547_193bc74c","line":9,"range":{"start_line":9,"start_character":225,"end_line":9,"end_character":232},"updated":"2024-09-09 05:39:11.000000000","message":"ditto.","commit_id":"b75ffb65104d216187e9b38be431f20538acbbb4"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"e133831dd2dcfa9ddbe886c660a429debe7e68a9","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add default option of vim_keys as common key"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When a Tacker is made redundant for load balancing, there is a problem that deleting a resource instantiated by another Tacker fails. (For example, if you have a tracker-0/1, instantiate on tracker-0, and try to terminate on tracker-1, it will fail.)"},{"line_number":10,"context_line":"This fails because the Tacker\u0027s fernet_key is randomly generated at each VIM registration. However, there is no function implemented to share/synchronize keys between Tackers, and the keys must be copied manually. To solve this problem, we request the addition of an optional feature that allows Tackers to specify a common key to each other. Specifically, we would like to be able to specify the use of a default-key pre-created in `tacker.conf`."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Id5633b916118af144f9116da732ac3b79cfe5daf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"b4260d24_6dbaee8c","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":447},"updated":"2024-09-09 05:39:11.000000000","message":"Could you follow the guideline of Commit message [1].\n\n[1] https://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure\n```\nSubsequent lines should be wrapped at 72 characters.\n```","commit_id":"b75ffb65104d216187e9b38be431f20538acbbb4"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"e133831dd2dcfa9ddbe886c660a429debe7e68a9","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When a Tacker is made redundant for load balancing, there is a problem that deleting a resource instantiated by another Tacker fails. (For example, if you have a tracker-0/1, instantiate on tracker-0, and try to terminate on tracker-1, it will fail.)"},{"line_number":10,"context_line":"This fails because the Tacker\u0027s fernet_key is randomly generated at each VIM registration. However, there is no function implemented to share/synchronize keys between Tackers, and the keys must be copied manually. To solve this problem, we request the addition of an optional feature that allows Tackers to specify a common key to each other. Specifically, we would like to be able to specify the use of a default-key pre-created in `tacker.conf`."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Id5633b916118af144f9116da732ac3b79cfe5daf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"a6f29aa7_36a481b2","line":11,"updated":"2024-09-09 05:39:11.000000000","message":"Could you add `Closed-Bug` tag as below:\n```\nCloses-Bug: #2067351\n```","commit_id":"b75ffb65104d216187e9b38be431f20538acbbb4"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"e133831dd2dcfa9ddbe886c660a429debe7e68a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6a44a343_9d29980f","updated":"2024-09-09 05:39:11.000000000","message":"Thanks for your patch, please kindly find my comment.","commit_id":"b75ffb65104d216187e9b38be431f20538acbbb4"}],"tacker/db/migration/cli.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"e133831dd2dcfa9ddbe886c660a429debe7e68a9","unresolved":true,"context_lines":[{"line_number":206,"context_line":"        \u0027--vnf-id\u0027,"},{"line_number":207,"context_line":"        help\u003d_(\u0027The specific VNF will be migrated.\u0027))"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    parser \u003d subparsers.add_parser(\u0027generate_secret_key\u0027)"},{"line_number":210,"context_line":"    parser.add_argument("},{"line_number":211,"context_line":"        \u0027--file\u0027, default\u003d\u0027/dev/stdout\u0027,"},{"line_number":212,"context_line":"        help\u003d_(\u0027output file path of generated key\u0027))"},{"line_number":213,"context_line":"    parser.set_defaults(func\u003dgenerate_secret_key)"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"command_opt \u003d cfg.SubCommandOpt(\u0027command\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"e8a3e457_0915ae10","line":213,"range":{"start_line":209,"start_character":0,"end_line":213,"end_character":49},"updated":"2024-09-09 05:39:11.000000000","message":"The generation of fernet-key is not about DB, so it is not clear whether it is appropriate to include it in the tacker-db-manage command.\nI think it is better to create a other file such as `gen_secret_key.py` under the tools directory.\nWhat do you think?","commit_id":"b75ffb65104d216187e9b38be431f20538acbbb4"}],"tacker/nfvo/drivers/vim/openstack_driver.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"e133831dd2dcfa9ddbe886c660a429debe7e68a9","unresolved":true,"context_lines":[{"line_number":226,"context_line":""},{"line_number":227,"context_line":"         Store VIM auth using fernet key encryption"},{"line_number":228,"context_line":"         \"\"\""},{"line_number":229,"context_line":"        fernet_key, fernet_obj \u003d self.keystone.create_fernet_key()"},{"line_number":230,"context_line":"        # if using default_secret_key, update the existing key"},{"line_number":231,"context_line":"        if CONF.vim_keys.default_secret_key !\u003d \u0027\u0027:"},{"line_number":232,"context_line":"            key_file \u003d os.path.join(CONF.vim_keys.openstack,"}],"source_content_type":"text/x-python","patch_set":2,"id":"540e0b98_75dcecc2","line":229,"range":{"start_line":229,"start_character":8,"end_line":229,"end_character":66},"updated":"2024-09-09 05:39:11.000000000","message":"The case of `CONF.vim_keys.default_secret_ key! \u003d \u0027\u0027`, does this call need to be done once before?","commit_id":"b75ffb65104d216187e9b38be431f20538acbbb4"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"e133831dd2dcfa9ddbe886c660a429debe7e68a9","unresolved":true,"context_lines":[{"line_number":231,"context_line":"        if CONF.vim_keys.default_secret_key !\u003d \u0027\u0027:"},{"line_number":232,"context_line":"            key_file \u003d os.path.join(CONF.vim_keys.openstack,"},{"line_number":233,"context_line":"                                    CONF.vim_keys.default_secret_key)"},{"line_number":234,"context_line":"            with open(key_file, \u0027rb\u0027) as f:"},{"line_number":235,"context_line":"                fernet_key \u003d f.read()"},{"line_number":236,"context_line":"                fernet_obj \u003d self.keystone.create_fernet_object(fernet_key)"},{"line_number":237,"context_line":"            LOG.debug(\u0027Default key loaded successfully\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"4d090b91_050de93b","line":234,"range":{"start_line":234,"start_character":12,"end_line":234,"end_character":43},"updated":"2024-09-09 05:39:11.000000000","message":"Is there no error handling if the `keyfile` does not exist?","commit_id":"b75ffb65104d216187e9b38be431f20538acbbb4"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"e133831dd2dcfa9ddbe886c660a429debe7e68a9","unresolved":true,"context_lines":[{"line_number":234,"context_line":"            with open(key_file, \u0027rb\u0027) as f:"},{"line_number":235,"context_line":"                fernet_key \u003d f.read()"},{"line_number":236,"context_line":"                fernet_obj \u003d self.keystone.create_fernet_object(fernet_key)"},{"line_number":237,"context_line":"            LOG.debug(\u0027Default key loaded successfully\u0027)"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"        encoded_auth \u003d fernet_obj.encrypt(auth[\u0027password\u0027].encode(\u0027utf-8\u0027))"},{"line_number":240,"context_line":"        auth[\u0027password\u0027] \u003d encoded_auth"}],"source_content_type":"text/x-python","patch_set":2,"id":"e4422eb9_59e8b9d9","line":237,"range":{"start_line":237,"start_character":23,"end_line":237,"end_character":34},"updated":"2024-09-09 05:39:11.000000000","message":"I think the `Default key` is ambiguous for debug log. How about you specify that it is for VIM credential?","commit_id":"b75ffb65104d216187e9b38be431f20538acbbb4"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"e133831dd2dcfa9ddbe886c660a429debe7e68a9","unresolved":true,"context_lines":[{"line_number":269,"context_line":"            except IOError:"},{"line_number":270,"context_line":"                raise nfvo.VimKeyNotFoundException(vim_id\u003dvim_id)"},{"line_number":271,"context_line":"        else:"},{"line_number":272,"context_line":"            LOG.debug(\u0027Use default secret key\u0027)"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"    @log.log"},{"line_number":275,"context_line":"    def get_vim_resource_id(self, vim_obj, resource_type, resource_name):"}],"source_content_type":"text/x-python","patch_set":2,"id":"c1aa5bee_fcee8842","line":272,"range":{"start_line":272,"start_character":27,"end_line":272,"end_character":45},"updated":"2024-09-09 05:39:11.000000000","message":"ditto.","commit_id":"b75ffb65104d216187e9b38be431f20538acbbb4"}]}