)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"813edb5998cf7355c5a84197f40764abcc7e38af","unresolved":true,"context_lines":[{"line_number":14,"context_line":"userdata_dir \u003d"},{"line_number":15,"context_line":"\"../../../../../tacker/sol_refactored/infra_drivers/openstack/\""},{"line_number":16,"context_line":"```"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Closes-Bug: #2074332"},{"line_number":19,"context_line":"Change-Id: Iea5d417bba0e1f9a6518df59ced77d6e50ba34de"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"2b27df62_c3a0278c","line":17,"updated":"2024-07-30 00:48:34.000000000","message":"This isn\u0027t a userdata file, but the same issue exists in the following codes in pkggen.py [1][2].\nI think it is better to fix it together with this patch. What do you think?\n\n```\nmgmt_driver_path \u003d os.path.join(\n    cur_dir, \u0027../../../../tacker/sol_refactored\u0027,\n    \u0027mgmt_drivers/container_update_mgmt_v2.py\u0027)\n```\n\n[1] https://opendev.org/openstack/tacker/src/branch/master/samples/tests/functional/sol_kubernetes_v2/test_cnf_container_update_before/pkggen.py#L33-L35\n[2] https://opendev.org/openstack/tacker/src/branch/master/samples/tests/functional/sol_kubernetes_v2/test_cnf_container_update_after/pkggen.py#L33-L35","commit_id":"75f76645974abd41f8d348d9566a791a04272190"},{"author":{"_account_id":31668},"change_message_id":"7dd26f661aa86be313281b71d0e635882741d73a","unresolved":true,"context_lines":[{"line_number":14,"context_line":"userdata_dir \u003d"},{"line_number":15,"context_line":"\"../../../../../tacker/sol_refactored/infra_drivers/openstack/\""},{"line_number":16,"context_line":"```"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Closes-Bug: #2074332"},{"line_number":19,"context_line":"Change-Id: Iea5d417bba0e1f9a6518df59ced77d6e50ba34de"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"8a4cf78c_cc030976","line":17,"in_reply_to":"2b27df62_c3a0278c","updated":"2024-07-30 04:41:54.000000000","message":"I agree with you. Thank you for pointing it out.\nI fixed it on PS2.","commit_id":"75f76645974abd41f8d348d9566a791a04272190"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"a9de160fb143a27b4f44f8a7962c3839a1f8c5b6","unresolved":false,"context_lines":[{"line_number":14,"context_line":"userdata_dir \u003d"},{"line_number":15,"context_line":"\"../../../../../tacker/sol_refactored/infra_drivers/openstack/\""},{"line_number":16,"context_line":"```"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Closes-Bug: #2074332"},{"line_number":19,"context_line":"Change-Id: Iea5d417bba0e1f9a6518df59ced77d6e50ba34de"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"0bd37f95_22296500","line":17,"in_reply_to":"8a4cf78c_cc030976","updated":"2024-07-30 05:15:00.000000000","message":"Acknowledged","commit_id":"75f76645974abd41f8d348d9566a791a04272190"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"813edb5998cf7355c5a84197f40764abcc7e38af","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e94f9c1a_9d67972f","updated":"2024-07-30 00:48:34.000000000","message":"Thanks for your patch, please kindly find my comment.","commit_id":"75f76645974abd41f8d348d9566a791a04272190"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"4c8aad99d4b1e51e8421c04231479aad87870f4e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"73b9656b_cf88c2e8","updated":"2024-07-30 10:20:02.000000000","message":"Please refer my tiny comment, thanks.","commit_id":"6e9bfa93c7d737aca0e954dae468027e85ad673d"},{"author":{"_account_id":31668},"change_message_id":"7dd26f661aa86be313281b71d0e635882741d73a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5b79e69c_3b4d4698","updated":"2024-07-30 04:41:54.000000000","message":"Thank you for the review.","commit_id":"6e9bfa93c7d737aca0e954dae468027e85ad673d"},{"author":{"_account_id":31668},"change_message_id":"8c4fa70ca8bc3893b9eacdd24248bd855d7a057c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"99adac5e_dd34b584","updated":"2024-07-30 10:36:11.000000000","message":"Thank you for the review.","commit_id":"6e9bfa93c7d737aca0e954dae468027e85ad673d"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"a9de160fb143a27b4f44f8a7962c3839a1f8c5b6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fb80319c_60215d0d","updated":"2024-07-30 05:15:00.000000000","message":"Thanks for your rework, LGTM.","commit_id":"6e9bfa93c7d737aca0e954dae468027e85ad673d"}],"samples/mgmt_driver/kubernetes/sol_v2_kubernetes_vnf_package/pkggen.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"4c8aad99d4b1e51e8421c04231479aad87870f4e","unresolved":true,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"# add userdata script"},{"line_number":44,"context_line":"# tacker/tests/sol_refactored/infra_drivers/openstack/userdata_standard.py"},{"line_number":45,"context_line":"userdata_dir \u003d \"../../../../../tacker/sol_refactored/infra_drivers/openstack/\""},{"line_number":46,"context_line":"userdata_file \u003d \"userdata_standard.py\""},{"line_number":47,"context_line":"userdata_path \u003d os.path.abspath(userdata_dir + userdata_file)"},{"line_number":48,"context_line":"# mkdir UserData/ and copy userdata_path into it"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abf6365_14b0f87c","line":45,"updated":"2024-07-30 10:20:02.000000000","message":"It must be correct path, but isn\u0027t easy to understand the path is really correct for developers. We\u0027ve already had similar fixes several times because of just a mistake, unexpected move of a file or so. So, please consider to avoid using relative path, but an anchor directory such as project root, for example, can be referred with `proj_root()` in `tacker/common/utils.py`.","commit_id":"6e9bfa93c7d737aca0e954dae468027e85ad673d"},{"author":{"_account_id":31668},"change_message_id":"8c4fa70ca8bc3893b9eacdd24248bd855d7a057c","unresolved":true,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"# add userdata script"},{"line_number":44,"context_line":"# tacker/tests/sol_refactored/infra_drivers/openstack/userdata_standard.py"},{"line_number":45,"context_line":"userdata_dir \u003d \"../../../../../tacker/sol_refactored/infra_drivers/openstack/\""},{"line_number":46,"context_line":"userdata_file \u003d \"userdata_standard.py\""},{"line_number":47,"context_line":"userdata_path \u003d os.path.abspath(userdata_dir + userdata_file)"},{"line_number":48,"context_line":"# mkdir UserData/ and copy userdata_path into it"}],"source_content_type":"text/x-python","patch_set":2,"id":"22667fc6_e2671d5e","line":45,"in_reply_to":"1abf6365_14b0f87c","updated":"2024-07-30 10:36:11.000000000","message":"Thanks for your comment.\nI plan to fix this in another patch, so is it okay to postpone it in this patch?","commit_id":"6e9bfa93c7d737aca0e954dae468027e85ad673d"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"0ec0b433f812f3c3e84addee7ee95c435f8286f8","unresolved":true,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"# add userdata script"},{"line_number":44,"context_line":"# tacker/tests/sol_refactored/infra_drivers/openstack/userdata_standard.py"},{"line_number":45,"context_line":"userdata_dir \u003d \"../../../../../tacker/sol_refactored/infra_drivers/openstack/\""},{"line_number":46,"context_line":"userdata_file \u003d \"userdata_standard.py\""},{"line_number":47,"context_line":"userdata_path \u003d os.path.abspath(userdata_dir + userdata_file)"},{"line_number":48,"context_line":"# mkdir UserData/ and copy userdata_path into it"}],"source_content_type":"text/x-python","patch_set":2,"id":"4f543f77_6277145c","line":45,"in_reply_to":"22667fc6_e2671d5e","updated":"2024-07-30 11:04:22.000000000","message":"OK, fine.","commit_id":"6e9bfa93c7d737aca0e954dae468027e85ad673d"}]}