)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"c4fb8d1b63dbcdf450a2644cce310a719cbfbe28","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"43d70fa1_9d8bbfd7","updated":"2024-09-03 23:44:17.000000000","message":"Thank you for the review.","commit_id":"4bf3d4fd79587f0c9a2c3d3cf5d29b4dfd160adc"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"6157aa617e952294d521dc1c156f8f8c93672bac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"92d9b42a_ede62d77","updated":"2024-09-03 12:24:21.000000000","message":"Thanks for your patch, please kindly find my comments.","commit_id":"4bf3d4fd79587f0c9a2c3d3cf5d29b4dfd160adc"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"08bb39aa1be32133d1a3fe2fd12984ae59674ca0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"82567cc6_ba89e8dc","updated":"2024-09-04 23:07:33.000000000","message":"memo: need to rebase after https://review.opendev.org/c/openstack/tacker/+/926089 is merged.","commit_id":"e6d522f3f811622bc459aaf9cfea8fd196e7e47f"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"8984302913401ab26d58b6eddb5a0c2cf46c5e94","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b0b740c0_f8798618","updated":"2024-09-04 05:37:16.000000000","message":"recheck infra-failure","commit_id":"e6d522f3f811622bc459aaf9cfea8fd196e7e47f"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"aab54c2c73cf1acfdf2929b12f08f6018e51870e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"22f5f2fd_6b41980a","updated":"2024-09-09 17:15:16.000000000","message":"LGTM, thanks!","commit_id":"6b0aec634cb14a9e033daf43ce43a665d4fb2b3a"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c1c2f4dc7aa385da0b573c47bc7db4c513bb1bf9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8f1268b3_c689d94b","updated":"2024-09-09 01:21:04.000000000","message":"Thanks for your rework, LGTM.","commit_id":"6b0aec634cb14a9e033daf43ce43a665d4fb2b3a"}],"tacker/sol_refactored/common/vnf_instance_utils.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"6157aa617e952294d521dc1c156f8f8c93672bac","unresolved":true,"context_lines":[{"line_number":50,"context_line":"        links[\u0027scale\u0027] \u003d {\u0027href\u0027: self_href + \"/scale\"}"},{"line_number":51,"context_line":"        links[\u0027heal\u0027] \u003d {\u0027href\u0027: self_href + \"/heal\"}"},{"line_number":52,"context_line":"        links[\u0027changeExtConn\u0027] \u003d {\u0027href\u0027: self_href + \"/change_ext_conn\"}"},{"line_number":53,"context_line":"        links[\u0027change_vnfpkg\u0027] \u003d {\u0027href\u0027: self_href + \"/change_vnfpkg\"}"},{"line_number":54,"context_line":"        # NOTE: add when the operation supported"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    return links"}],"source_content_type":"text/x-python","patch_set":2,"id":"381152de_46eab5c7","line":53,"range":{"start_line":53,"start_character":15,"end_line":53,"end_character":28},"updated":"2024-09-03 12:24:21.000000000","message":"Is it intentional that this place is changed to a snake case?\nlinks for `Change current VNF package` is not defined in SOL003 v3.3.1, but it\u0027s defined as `changeCurrentVnfPkg` in SOL003 v4 [1].\n\nI think it is better to change it to that. What do you think?\n\n[1] https://www.etsi.org/deliver/etsi_gs/NFV-SOL/001_099/003/04.05.01_60/gs_nfv-sol003v040501p.pdf","commit_id":"4bf3d4fd79587f0c9a2c3d3cf5d29b4dfd160adc"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"6157aa617e952294d521dc1c156f8f8c93672bac","unresolved":true,"context_lines":[{"line_number":50,"context_line":"        links[\u0027scale\u0027] \u003d {\u0027href\u0027: self_href + \"/scale\"}"},{"line_number":51,"context_line":"        links[\u0027heal\u0027] \u003d {\u0027href\u0027: self_href + \"/heal\"}"},{"line_number":52,"context_line":"        links[\u0027changeExtConn\u0027] \u003d {\u0027href\u0027: self_href + \"/change_ext_conn\"}"},{"line_number":53,"context_line":"        links[\u0027change_vnfpkg\u0027] \u003d {\u0027href\u0027: self_href + \"/change_vnfpkg\"}"},{"line_number":54,"context_line":"        # NOTE: add when the operation supported"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    return links"}],"source_content_type":"text/x-python","patch_set":2,"id":"5e5ed9e7_11e8b789","line":53,"range":{"start_line":53,"start_character":8,"end_line":53,"end_character":71},"updated":"2024-09-03 12:24:21.000000000","message":"The current document does not seem to contain \"Change current VNF package\" Links [1], but with this patch it is visible.\n```\n| Links   | {                                                                                                                  |\n|         |     \"self\": {                                                                                                      |\n|         |         \"href\": \"http://127.0.0.1:9890/vnflcm/v2/vnf_instances/f7d7e2be-15c7-473f-a93f-548fd7809938\"               |\n|         |     },                                                                                                             |\n...\n|         |     \"change_vnfpkg\": {                                                                                             |\n|         |         \"href\": \"http://127.0.0.1:9890/vnflcm/v2/vnf_instances/f7d7e2be-15c7-473f-a93f-548fd7809938/change_vnfpkg\" |\n|         |     }                                                                                                              |\n|         | } \n```\n\nDo you need to modify the document?\n\n[1] https://docs.openstack.org/tacker/latest/cli/v2/vnflcm.html#show-vnf","commit_id":"4bf3d4fd79587f0c9a2c3d3cf5d29b4dfd160adc"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"c4fb8d1b63dbcdf450a2644cce310a719cbfbe28","unresolved":true,"context_lines":[{"line_number":50,"context_line":"        links[\u0027scale\u0027] \u003d {\u0027href\u0027: self_href + \"/scale\"}"},{"line_number":51,"context_line":"        links[\u0027heal\u0027] \u003d {\u0027href\u0027: self_href + \"/heal\"}"},{"line_number":52,"context_line":"        links[\u0027changeExtConn\u0027] \u003d {\u0027href\u0027: self_href + \"/change_ext_conn\"}"},{"line_number":53,"context_line":"        links[\u0027change_vnfpkg\u0027] \u003d {\u0027href\u0027: self_href + \"/change_vnfpkg\"}"},{"line_number":54,"context_line":"        # NOTE: add when the operation supported"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    return links"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a9abc96_65eea1eb","line":53,"range":{"start_line":53,"start_character":15,"end_line":53,"end_character":28},"in_reply_to":"381152de_46eab5c7","updated":"2024-09-03 23:44:17.000000000","message":"I noticed L.54 of original code is meaningless because \u0027changeVnfPkg\u0027 member is not defined in \u0027Links\u0027 object.\nThis patch does not intend to add the new _links field. So I will delete L.53 to keep _links fields unchanged.","commit_id":"4bf3d4fd79587f0c9a2c3d3cf5d29b4dfd160adc"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"c4fb8d1b63dbcdf450a2644cce310a719cbfbe28","unresolved":true,"context_lines":[{"line_number":50,"context_line":"        links[\u0027scale\u0027] \u003d {\u0027href\u0027: self_href + \"/scale\"}"},{"line_number":51,"context_line":"        links[\u0027heal\u0027] \u003d {\u0027href\u0027: self_href + \"/heal\"}"},{"line_number":52,"context_line":"        links[\u0027changeExtConn\u0027] \u003d {\u0027href\u0027: self_href + \"/change_ext_conn\"}"},{"line_number":53,"context_line":"        links[\u0027change_vnfpkg\u0027] \u003d {\u0027href\u0027: self_href + \"/change_vnfpkg\"}"},{"line_number":54,"context_line":"        # NOTE: add when the operation supported"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    return links"}],"source_content_type":"text/x-python","patch_set":2,"id":"a11e95b2_4bb3f53b","line":53,"range":{"start_line":53,"start_character":8,"end_line":53,"end_character":71},"in_reply_to":"5e5ed9e7_11e8b789","updated":"2024-09-03 23:44:17.000000000","message":"See above comment. I think it is not necessary to fix document.","commit_id":"4bf3d4fd79587f0c9a2c3d3cf5d29b4dfd160adc"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c1c2f4dc7aa385da0b573c47bc7db4c513bb1bf9","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        links[\u0027scale\u0027] \u003d {\u0027href\u0027: self_href + \"/scale\"}"},{"line_number":51,"context_line":"        links[\u0027heal\u0027] \u003d {\u0027href\u0027: self_href + \"/heal\"}"},{"line_number":52,"context_line":"        links[\u0027changeExtConn\u0027] \u003d {\u0027href\u0027: self_href + \"/change_ext_conn\"}"},{"line_number":53,"context_line":"        links[\u0027change_vnfpkg\u0027] \u003d {\u0027href\u0027: self_href + \"/change_vnfpkg\"}"},{"line_number":54,"context_line":"        # NOTE: add when the operation supported"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    return links"}],"source_content_type":"text/x-python","patch_set":2,"id":"c17eaf8a_aa81e135","line":53,"range":{"start_line":53,"start_character":15,"end_line":53,"end_character":28},"in_reply_to":"9a9abc96_65eea1eb","updated":"2024-09-09 01:21:04.000000000","message":"Thanks, since this patch is a performance improvement patch, I agreed that the addition of a new link is not necessary.","commit_id":"4bf3d4fd79587f0c9a2c3d3cf5d29b4dfd160adc"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c1c2f4dc7aa385da0b573c47bc7db4c513bb1bf9","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        links[\u0027scale\u0027] \u003d {\u0027href\u0027: self_href + \"/scale\"}"},{"line_number":51,"context_line":"        links[\u0027heal\u0027] \u003d {\u0027href\u0027: self_href + \"/heal\"}"},{"line_number":52,"context_line":"        links[\u0027changeExtConn\u0027] \u003d {\u0027href\u0027: self_href + \"/change_ext_conn\"}"},{"line_number":53,"context_line":"        links[\u0027change_vnfpkg\u0027] \u003d {\u0027href\u0027: self_href + \"/change_vnfpkg\"}"},{"line_number":54,"context_line":"        # NOTE: add when the operation supported"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    return links"}],"source_content_type":"text/x-python","patch_set":2,"id":"8ccb7dc8_df4c25ac","line":53,"range":{"start_line":53,"start_character":8,"end_line":53,"end_character":71},"in_reply_to":"a11e95b2_4bb3f53b","updated":"2024-09-09 01:21:04.000000000","message":"Acknowledged","commit_id":"4bf3d4fd79587f0c9a2c3d3cf5d29b4dfd160adc"}]}