)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"a2be8255558628b41ce3e69efe528e42f0f6f287","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix infinite loop when enhanced policy check"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- Fix so that infinite loop don\u0027t occured in _pre_enhanced_policy_check"},{"line_number":10,"context_line":"  when targets and credentials is set to special role."},{"line_number":11,"context_line":"- And add check whether targets is set to special role"},{"line_number":12,"context_line":"  in _pre_enhanced_policy_check"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"184860e6_fa273966","line":9,"range":{"start_line":9,"start_character":34,"end_line":9,"end_character":42},"updated":"2024-09-04 09:25:17.000000000","message":"typo: occurred","commit_id":"93279d4aa09b176e8fdc10a7834df7bcef090f8c"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"e280f62accd24d159b93b9052b811711d33ca5b6","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix infinite loop when enhanced policy check"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- Fix so that infinite loop don\u0027t occured in _pre_enhanced_policy_check"},{"line_number":10,"context_line":"  when targets and credentials is set to special role."},{"line_number":11,"context_line":"- And add check whether targets is set to special role"},{"line_number":12,"context_line":"  in _pre_enhanced_policy_check"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"c6bd1944_a7b1ebb3","line":9,"range":{"start_line":9,"start_character":34,"end_line":9,"end_character":42},"in_reply_to":"184860e6_fa273966","updated":"2024-09-09 00:16:51.000000000","message":"Thanks, I\u0027ve confirmed.","commit_id":"93279d4aa09b176e8fdc10a7834df7bcef090f8c"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"5638a1c9eb9e3fc4a4015eff759f8e7e735e6ffc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d5b8099b_a2a243fb","updated":"2024-09-10 01:10:24.000000000","message":"Thank you for the patch. Just quick review for coding styles","commit_id":"93279d4aa09b176e8fdc10a7834df7bcef090f8c"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"a2be8255558628b41ce3e69efe528e42f0f6f287","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5e0b391d_55a91e5a","updated":"2024-09-04 09:25:17.000000000","message":"Thanks for your patch, almost good for me, but there is tiny comment for commit message. Please kindly confirm it.","commit_id":"93279d4aa09b176e8fdc10a7834df7bcef090f8c"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"e280f62accd24d159b93b9052b811711d33ca5b6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"95a7b5e0_3bfd6b93","updated":"2024-09-09 00:16:51.000000000","message":"Thanks for your rework, LGTM.","commit_id":"373dad2e86f30d8e2797a5f4a56f1d63ae368898"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"90f69f0df6bea97b075429d6f3ca87d7e68e91f6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"376d1f9b_1bb347b0","updated":"2024-09-12 12:34:07.000000000","message":"LGTM, thanks!","commit_id":"a2760db6062678b2ff9724163570aca5876c8f02"},{"author":{"_account_id":36997,"name":"Takahiro Miyajima","display_name":"f-miyajima","email":"fj6257jz@fujitsu.com","username":"f-miyajima"},"change_message_id":"12d26b4c2c018078e8c237dfd472b6267820c063","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4edb161b_4f224a6d","updated":"2024-09-11 04:34:48.000000000","message":"Thank you for your review. Please kindly confirm.","commit_id":"a2760db6062678b2ff9724163570aca5876c8f02"},{"author":{"_account_id":36997,"name":"Takahiro Miyajima","display_name":"f-miyajima","email":"fj6257jz@fujitsu.com","username":"f-miyajima"},"change_message_id":"ada56cdf97fbdfd5b6031c2629b89d9efa8a3dd1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"85bf33c6_8dc6508d","updated":"2024-09-10 10:20:08.000000000","message":"recheck - infra failure  in `openstack-tox-py311` job, not failure in local environment","commit_id":"a2760db6062678b2ff9724163570aca5876c8f02"},{"author":{"_account_id":36997,"name":"Takahiro Miyajima","display_name":"f-miyajima","email":"fj6257jz@fujitsu.com","username":"f-miyajima"},"change_message_id":"1be5fca7a614288dd13010b25ad39afe948c017e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fb9c5f2c_d59ef6c9","updated":"2024-09-10 23:26:31.000000000","message":"recheck - timing failure in `tacker-functional-devstack-multinode-sol-kubernetes-v2` job, not failure last time","commit_id":"a2760db6062678b2ff9724163570aca5876c8f02"}],"tacker/policy.py":[{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"5638a1c9eb9e3fc4a4015eff759f8e7e735e6ffc","unresolved":true,"context_lines":[{"line_number":144,"context_line":"                    user_attrs[key].append(attr)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    # 2) Check whether using special role(ex: `all`) in target,"},{"line_number":147,"context_line":"    if target_chk is True and credentials.get(\u0027is_admin\u0027, False) is False:"},{"line_number":148,"context_line":"        for k, v in tgt.items():"},{"line_number":149,"context_line":"            if (k in special_roles and"},{"line_number":150,"context_line":"                    re.match(special_roles[k], v) is not None):"}],"source_content_type":"text/x-python","patch_set":1,"id":"b9640c97_ed512a39","line":147,"updated":"2024-09-10 01:10:24.000000000","message":"Please see https://peps.python.org/pep-0008/#programming-recommendations\n\nThis line should be \n\n\n```suggestion\n    if target_chk and not credentials.get(\u0027is_admin\u0027, False):\n```","commit_id":"93279d4aa09b176e8fdc10a7834df7bcef090f8c"},{"author":{"_account_id":36997,"name":"Takahiro Miyajima","display_name":"f-miyajima","email":"fj6257jz@fujitsu.com","username":"f-miyajima"},"change_message_id":"12d26b4c2c018078e8c237dfd472b6267820c063","unresolved":true,"context_lines":[{"line_number":144,"context_line":"                    user_attrs[key].append(attr)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    # 2) Check whether using special role(ex: `all`) in target,"},{"line_number":147,"context_line":"    if target_chk is True and credentials.get(\u0027is_admin\u0027, False) is False:"},{"line_number":148,"context_line":"        for k, v in tgt.items():"},{"line_number":149,"context_line":"            if (k in special_roles and"},{"line_number":150,"context_line":"                    re.match(special_roles[k], v) is not None):"}],"source_content_type":"text/x-python","patch_set":1,"id":"0e800245_1d9e014d","line":147,"in_reply_to":"b9640c97_ed512a39","updated":"2024-09-11 04:34:48.000000000","message":"I fixed as you suggest. Please kindly confirm.","commit_id":"93279d4aa09b176e8fdc10a7834df7bcef090f8c"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"5638a1c9eb9e3fc4a4015eff759f8e7e735e6ffc","unresolved":true,"context_lines":[{"line_number":147,"context_line":"    if target_chk is True and credentials.get(\u0027is_admin\u0027, False) is False:"},{"line_number":148,"context_line":"        for k, v in tgt.items():"},{"line_number":149,"context_line":"            if (k in special_roles and"},{"line_number":150,"context_line":"                    re.match(special_roles[k], v) is not None):"},{"line_number":151,"context_line":"                chk_all \u003d False"},{"line_number":152,"context_line":"                # Not NG in case credentials has special role"},{"line_number":153,"context_line":"                for uv in user_attrs[k]:"}],"source_content_type":"text/x-python","patch_set":1,"id":"a23fc195_46f15766","line":150,"updated":"2024-09-10 01:10:24.000000000","message":"```suggestion\n                    re.match(special_roles[k], v)):\n```","commit_id":"93279d4aa09b176e8fdc10a7834df7bcef090f8c"},{"author":{"_account_id":36997,"name":"Takahiro Miyajima","display_name":"f-miyajima","email":"fj6257jz@fujitsu.com","username":"f-miyajima"},"change_message_id":"12d26b4c2c018078e8c237dfd472b6267820c063","unresolved":true,"context_lines":[{"line_number":147,"context_line":"    if target_chk is True and credentials.get(\u0027is_admin\u0027, False) is False:"},{"line_number":148,"context_line":"        for k, v in tgt.items():"},{"line_number":149,"context_line":"            if (k in special_roles and"},{"line_number":150,"context_line":"                    re.match(special_roles[k], v) is not None):"},{"line_number":151,"context_line":"                chk_all \u003d False"},{"line_number":152,"context_line":"                # Not NG in case credentials has special role"},{"line_number":153,"context_line":"                for uv in user_attrs[k]:"}],"source_content_type":"text/x-python","patch_set":1,"id":"fac98ddc_28d9fc99","line":150,"in_reply_to":"a23fc195_46f15766","updated":"2024-09-11 04:34:48.000000000","message":"I fixed as you suggest. Please kindly confirm.","commit_id":"93279d4aa09b176e8fdc10a7834df7bcef090f8c"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"5638a1c9eb9e3fc4a4015eff759f8e7e735e6ffc","unresolved":true,"context_lines":[{"line_number":177,"context_line":"        if tgt.get(key) \u003d\u003d \u0027*\u0027:"},{"line_number":178,"context_line":"            continue"},{"line_number":179,"context_line":"        to_remove \u003d []"},{"line_number":180,"context_line":"        attrs_tmp \u003d copy.deepcopy(attrs)"},{"line_number":181,"context_line":"        if \u0027area\u0027 \u003d\u003d key:"},{"line_number":182,"context_line":"            if not is_valid_area(tgt.get(key)):"},{"line_number":183,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":1,"id":"1b99517e_822ad5b0","line":180,"updated":"2024-09-10 01:10:24.000000000","message":"```suggestion\n        orig_attrs \u003d copy.deepcopy(attrs)\n```\n\nif that makes sense","commit_id":"93279d4aa09b176e8fdc10a7834df7bcef090f8c"},{"author":{"_account_id":36997,"name":"Takahiro Miyajima","display_name":"f-miyajima","email":"fj6257jz@fujitsu.com","username":"f-miyajima"},"change_message_id":"12d26b4c2c018078e8c237dfd472b6267820c063","unresolved":true,"context_lines":[{"line_number":177,"context_line":"        if tgt.get(key) \u003d\u003d \u0027*\u0027:"},{"line_number":178,"context_line":"            continue"},{"line_number":179,"context_line":"        to_remove \u003d []"},{"line_number":180,"context_line":"        attrs_tmp \u003d copy.deepcopy(attrs)"},{"line_number":181,"context_line":"        if \u0027area\u0027 \u003d\u003d key:"},{"line_number":182,"context_line":"            if not is_valid_area(tgt.get(key)):"},{"line_number":183,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":1,"id":"c35a1f72_a3a8b4c9","line":180,"in_reply_to":"1b99517e_822ad5b0","updated":"2024-09-11 04:34:48.000000000","message":"I fixed as you suggest. Please kindly confirm.","commit_id":"93279d4aa09b176e8fdc10a7834df7bcef090f8c"}]}