)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"8c6cb26669b2747d086124b9fb11fb2248b5c1a8","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Takahiro Miyajima \u003cfj6257jz@fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-12-16 05:58:10 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix about response with checksum from nfvo"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch is:"},{"line_number":10,"context_line":"- About the tacker v2 objects, define the type of checksum as \u0027dict\u0027,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"fae5d2cd_c88a9483","line":7,"updated":"2024-12-16 08:35:33.000000000","message":"Chould you elaborate on the problem for the reviewers and future maintainer? Just explaining that the type of checksum was wrongly defined as String and this patch fix it to Dict according to SOL013 is enough.","commit_id":"3a0e5f26f1251df796eae515bc975179067adec7"},{"author":{"_account_id":36997,"name":"Takahiro Miyajima","display_name":"f-miyajima","email":"fj6257jz@fujitsu.com","username":"f-miyajima"},"change_message_id":"f28f4405e8f5613f518c432f8f5e53eccc845abe","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Takahiro Miyajima \u003cfj6257jz@fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-12-16 05:58:10 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix about response with checksum from nfvo"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch is:"},{"line_number":10,"context_line":"- About the tacker v2 objects, define the type of checksum as \u0027dict\u0027,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"33938e6c_3749e605","line":7,"in_reply_to":"fae5d2cd_c88a9483","updated":"2024-12-17 08:33:19.000000000","message":"As your comment, I fixed commit title and message.","commit_id":"3a0e5f26f1251df796eae515bc975179067adec7"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"8c6cb26669b2747d086124b9fb11fb2248b5c1a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1ef1b30b_3f0a80dd","updated":"2024-12-16 08:35:33.000000000","message":"Thank you for the patch. Please kindly find my comments.","commit_id":"3a0e5f26f1251df796eae515bc975179067adec7"},{"author":{"_account_id":36997,"name":"Takahiro Miyajima","display_name":"f-miyajima","email":"fj6257jz@fujitsu.com","username":"f-miyajima"},"change_message_id":"f28f4405e8f5613f518c432f8f5e53eccc845abe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"9b847f39_1090db26","updated":"2024-12-17 08:33:19.000000000","message":"Thank you for your review.\nPlease kindly confirm.","commit_id":"8884849913d1cec457093b38b53948fb8bc4c96a"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"ceb699e1fed58936b262edf01199090799c03828","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"0632637a_1c6040db","updated":"2024-12-17 08:19:48.000000000","message":"Thanks for your patch, LGTM.","commit_id":"8884849913d1cec457093b38b53948fb8bc4c96a"}],"tacker/tests/unit/sol_refactored/nfvo/test_nfvo_client.py":[{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"8c6cb26669b2747d086124b9fb11fb2248b5c1a8","unresolved":true,"context_lines":[{"line_number":391,"context_line":"        self.assertEqual(SAMPLE_VNFD_ID, result.vnfdId)"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"    @mock.patch.object(http_client.HttpClient, \u0027do_request\u0027)"},{"line_number":394,"context_line":"    def test_get_vnf_package_info_vnfd_external_with_checksum("},{"line_number":395,"context_line":"            self, mock_request):"},{"line_number":396,"context_line":"        # external nfvo oath2"},{"line_number":397,"context_line":"        cfg.CONF.clear_override(\"mtls_client_cert_file\", group\u003d\"v2_nfvo\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"870004c8_c0a27bd7","line":394,"updated":"2024-12-16 08:35:33.000000000","message":"Why don\u0027t you just update the existing test case from l.371? I suppose this case includes the existing one. If I\u0027m wrong please ignore this comment.","commit_id":"3a0e5f26f1251df796eae515bc975179067adec7"},{"author":{"_account_id":36997,"name":"Takahiro Miyajima","display_name":"f-miyajima","email":"fj6257jz@fujitsu.com","username":"f-miyajima"},"change_message_id":"f28f4405e8f5613f518c432f8f5e53eccc845abe","unresolved":true,"context_lines":[{"line_number":391,"context_line":"        self.assertEqual(SAMPLE_VNFD_ID, result.vnfdId)"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"    @mock.patch.object(http_client.HttpClient, \u0027do_request\u0027)"},{"line_number":394,"context_line":"    def test_get_vnf_package_info_vnfd_external_with_checksum("},{"line_number":395,"context_line":"            self, mock_request):"},{"line_number":396,"context_line":"        # external nfvo oath2"},{"line_number":397,"context_line":"        cfg.CONF.clear_override(\"mtls_client_cert_file\", group\u003d\"v2_nfvo\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"cc5cdf77_757bbb88","line":394,"in_reply_to":"870004c8_c0a27bd7","updated":"2024-12-17 08:33:19.000000000","message":"As your comment, I fixed to include this test to existing test case.","commit_id":"3a0e5f26f1251df796eae515bc975179067adec7"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"8c6cb26669b2747d086124b9fb11fb2248b5c1a8","unresolved":true,"context_lines":[{"line_number":402,"context_line":"        result \u003d self.nfvo_client.get_vnf_package_info_vnfd("},{"line_number":403,"context_line":"            self.context, SAMPLE_VNFD_ID)"},{"line_number":404,"context_line":"        self.assertEqual(SAMPLE_VNFD_ID, result.vnfdId)"},{"line_number":405,"context_line":"        self.assertEqual(objects.Checksum, type(result.checksum))"},{"line_number":406,"context_line":"        self.assertEqual(objects.Checksum,"},{"line_number":407,"context_line":"                        type(result.softwareImages[0].checksum))"},{"line_number":408,"context_line":"        self.assertEqual(objects.Checksum,"}],"source_content_type":"text/x-python","patch_set":6,"id":"668a019a_ee80fcf4","line":405,"updated":"2024-12-16 08:35:33.000000000","message":"Are these three assertions from this line (ll. 405-409) really necessary? I think if checksums in the response is wrong, this test fails, and if it\u0027s correct and TackerObject works correctly, other types will not appear.","commit_id":"3a0e5f26f1251df796eae515bc975179067adec7"},{"author":{"_account_id":36997,"name":"Takahiro Miyajima","display_name":"f-miyajima","email":"fj6257jz@fujitsu.com","username":"f-miyajima"},"change_message_id":"f28f4405e8f5613f518c432f8f5e53eccc845abe","unresolved":true,"context_lines":[{"line_number":402,"context_line":"        result \u003d self.nfvo_client.get_vnf_package_info_vnfd("},{"line_number":403,"context_line":"            self.context, SAMPLE_VNFD_ID)"},{"line_number":404,"context_line":"        self.assertEqual(SAMPLE_VNFD_ID, result.vnfdId)"},{"line_number":405,"context_line":"        self.assertEqual(objects.Checksum, type(result.checksum))"},{"line_number":406,"context_line":"        self.assertEqual(objects.Checksum,"},{"line_number":407,"context_line":"                        type(result.softwareImages[0].checksum))"},{"line_number":408,"context_line":"        self.assertEqual(objects.Checksum,"}],"source_content_type":"text/x-python","patch_set":6,"id":"c6e4fbbb_720e532a","line":405,"in_reply_to":"668a019a_ee80fcf4","updated":"2024-12-17 08:33:19.000000000","message":"Your comment is correct, so I removed these three assertions.","commit_id":"3a0e5f26f1251df796eae515bc975179067adec7"}]}