)]}'
{"neutron_taas/services/taas/agents/common/taas_agent.py":[{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"edfcb363898b13b016b22c1a1507e1c46ca97139","unresolved":true,"context_lines":[{"line_number":120,"context_line":"                \u0027fail_status\u0027: constants.PENDING_DELETE,"},{"line_number":121,"context_line":"                \u0027succ_status\u0027: constants.INACTIVE},"},{"line_number":122,"context_line":"            \u0027periodic_tasks\u0027: {"},{"line_number":123,"context_line":"                \u0027msg_name\u0027: \u0027periodic_task\u0027,"},{"line_number":124,"context_line":"            }"},{"line_number":125,"context_line":"        }"},{"line_number":126,"context_line":"        self.portbind_drivers_map \u003d {portbindings.VNIC_DIRECT: \u0027sriov\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"e6263a22_2b50b66d","line":123,"range":{"start_line":123,"start_character":29,"end_line":123,"end_character":42},"updated":"2022-02-15 13:14:53.000000000","message":"Is this intentionally singular when the functions was plural?","commit_id":"8271fe7105526923906a4c3d87a0f1c9f31063c3"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"eea2d13b631f9fcd3b44d897b863e6e41a2bb3fe","unresolved":true,"context_lines":[{"line_number":120,"context_line":"                \u0027fail_status\u0027: constants.PENDING_DELETE,"},{"line_number":121,"context_line":"                \u0027succ_status\u0027: constants.INACTIVE},"},{"line_number":122,"context_line":"            \u0027periodic_tasks\u0027: {"},{"line_number":123,"context_line":"                \u0027msg_name\u0027: \u0027periodic_task\u0027,"},{"line_number":124,"context_line":"            }"},{"line_number":125,"context_line":"        }"},{"line_number":126,"context_line":"        self.portbind_drivers_map \u003d {portbindings.VNIC_DIRECT: \u0027sriov\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a4a6ab9_2a89dc3e","line":123,"range":{"start_line":123,"start_character":29,"end_line":123,"end_character":42},"in_reply_to":"e6263a22_2b50b66d","updated":"2022-02-16 08:40:49.000000000","message":"no it is accidental, thanks.","commit_id":"8271fe7105526923906a4c3d87a0f1c9f31063c3"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"edfcb363898b13b016b22c1a1507e1c46ca97139","unresolved":true,"context_lines":[{"line_number":135,"context_line":"        LOG.debug(\"Invoking Driver for %(func_name)s from agent\","},{"line_number":136,"context_line":"                  {\u0027func_name\u0027: func_name})"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        if \u0027periodic\u0027 not in func_name:"},{"line_number":139,"context_line":"            func_dict \u003d self.func_dict[func_name]"},{"line_number":140,"context_line":"            status_msg \u003d {\u0027id\u0027: args[func_dict[\u0027msg_name\u0027]][\u0027id\u0027]}"},{"line_number":141,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"cbcbae10_edf0d3b1","line":138,"range":{"start_line":138,"start_character":11,"end_line":138,"end_character":38},"updated":"2022-02-15 13:14:53.000000000","message":"Do you expect other function with names starting  with \u0027periodic\u0027?\n\nIf not, then func_name !\u003d \u0027periodic_tasks\u0027 would be cleaner.","commit_id":"8271fe7105526923906a4c3d87a0f1c9f31063c3"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"eea2d13b631f9fcd3b44d897b863e6e41a2bb3fe","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        LOG.debug(\"Invoking Driver for %(func_name)s from agent\","},{"line_number":136,"context_line":"                  {\u0027func_name\u0027: func_name})"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        if \u0027periodic\u0027 not in func_name:"},{"line_number":139,"context_line":"            func_dict \u003d self.func_dict[func_name]"},{"line_number":140,"context_line":"            status_msg \u003d {\u0027id\u0027: args[func_dict[\u0027msg_name\u0027]][\u0027id\u0027]}"},{"line_number":141,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"c76a8a7c_70922b12","line":138,"range":{"start_line":138,"start_character":11,"end_line":138,"end_character":38},"in_reply_to":"cbcbae10_edf0d3b1","updated":"2022-02-16 08:40:49.000000000","message":"Done, thanks","commit_id":"8271fe7105526923906a4c3d87a0f1c9f31063c3"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"edfcb363898b13b016b22c1a1507e1c46ca97139","unresolved":true,"context_lines":[{"line_number":151,"context_line":"                    self.conf.host)"},{"line_number":152,"context_line":"            return"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"        if \u0027periodic\u0027 not in func_name:"},{"line_number":155,"context_line":"            self.taas_plugin_rpc.__getattribute__("},{"line_number":156,"context_line":"                self.func_dict[func_name][\u0027set_status_func_name\u0027])("},{"line_number":157,"context_line":"                    status_msg,"}],"source_content_type":"text/x-python","patch_set":2,"id":"c665cfd3_aebbb325","line":154,"range":{"start_line":154,"start_character":11,"end_line":154,"end_character":38},"updated":"2022-02-15 13:14:53.000000000","message":"as in line 138","commit_id":"8271fe7105526923906a4c3d87a0f1c9f31063c3"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"eea2d13b631f9fcd3b44d897b863e6e41a2bb3fe","unresolved":false,"context_lines":[{"line_number":151,"context_line":"                    self.conf.host)"},{"line_number":152,"context_line":"            return"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"        if \u0027periodic\u0027 not in func_name:"},{"line_number":155,"context_line":"            self.taas_plugin_rpc.__getattribute__("},{"line_number":156,"context_line":"                self.func_dict[func_name][\u0027set_status_func_name\u0027])("},{"line_number":157,"context_line":"                    status_msg,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9d49c553_48572524","line":154,"range":{"start_line":154,"start_character":11,"end_line":154,"end_character":38},"in_reply_to":"c665cfd3_aebbb325","updated":"2022-02-16 08:40:49.000000000","message":"Done","commit_id":"8271fe7105526923906a4c3d87a0f1c9f31063c3"}]}