)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"5aff0073e68a30b3471b77dec01b5a154e57a531","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5ed931a2_ee1eeb6a","updated":"2022-03-17 10:09:06.000000000","message":"Good idea to make the code easier to read.","commit_id":"9e9dab1e2b8c298b019d9dab1e4d9091f5d15c3d"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"69035e9175fb720dbfe6a4c65f5da8b67148e1ea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f5e8c6fe_de038298","updated":"2022-03-21 14:00:30.000000000","message":"Almost there.","commit_id":"f586a9dddc2baf726f8a19f58ebf55a5a6c03dee"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"5b994279e4ad560928bc79dcc11da6b64bd9d38c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"299e643e_c145d191","updated":"2022-03-22 12:10:22.000000000","message":"recheck\ntap-as-a-service-tempest \u003d\u003e cinder related issue\ntap-as-a-service-tempest-plugin \u003d\u003e ssh issue I have to check it if it happens frequently","commit_id":"8cc9d55f4815fc6e45cbaf0e3b8f4e88f673f84b"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"a09c923eee33a0714eaa20dae85507e4e5d7a8fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"60196b44_8ffc941f","updated":"2022-05-27 13:54:52.000000000","message":"recheck\nrecent issues with taas tempest jobs now fixed, and the job again is voting","commit_id":"002de246957f954e666ba873130d53d2ebf50de5"}],"neutron_taas/services/taas/agents/common/taas_agent.py":[{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"69035e9175fb720dbfe6a4c65f5da8b67148e1ea","unresolved":true,"context_lines":[{"line_number":155,"context_line":"    def create_tap_service(self, context, tap_service, host):"},{"line_number":156,"context_line":"        \"\"\"Handle Rpc from plugin to create a tap_service.\"\"\""},{"line_number":157,"context_line":"        if not self._driver_and_host_verification(host,"},{"line_number":158,"context_line":"                                                  tap_service[\u0027port\u0027]):"},{"line_number":159,"context_line":"            LOG.debug(\"RPC Call for Create Tap Serv. Either Host value [%s]\""},{"line_number":160,"context_line":"                      \"(received in RPC) doesn\u0027t match the host value \""},{"line_number":161,"context_line":"                      \"stored in agent [%s], or incompatible driver type. \""}],"source_content_type":"text/x-python","patch_set":2,"id":"4c006779_6ccc9f28","line":158,"updated":"2022-03-21 14:00:30.000000000","message":"Now changes in this file became pure whitespace changes, which are probably better to avoid to keep the version control history cleaner.","commit_id":"f586a9dddc2baf726f8a19f58ebf55a5a6c03dee"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"8d4f347a778c15ff1d52220238fccb6cc4e096e2","unresolved":true,"context_lines":[{"line_number":155,"context_line":"    def create_tap_service(self, context, tap_service, host):"},{"line_number":156,"context_line":"        \"\"\"Handle Rpc from plugin to create a tap_service.\"\"\""},{"line_number":157,"context_line":"        if not self._driver_and_host_verification(host,"},{"line_number":158,"context_line":"                                                  tap_service[\u0027port\u0027]):"},{"line_number":159,"context_line":"            LOG.debug(\"RPC Call for Create Tap Serv. Either Host value [%s]\""},{"line_number":160,"context_line":"                      \"(received in RPC) doesn\u0027t match the host value \""},{"line_number":161,"context_line":"                      \"stored in agent [%s], or incompatible driver type. \""}],"source_content_type":"text/x-python","patch_set":2,"id":"90f8d8b5_a089b599","line":158,"in_reply_to":"4c006779_6ccc9f28","updated":"2022-03-21 17:22:22.000000000","message":"huuh, thanks, I should have checked it","commit_id":"f586a9dddc2baf726f8a19f58ebf55a5a6c03dee"}],"neutron_taas/services/taas/drivers/linux/ovs_taas.py":[{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"5aff0073e68a30b3471b77dec01b5a154e57a531","unresolved":true,"context_lines":[{"line_number":209,"context_line":"                                taas_id which is the VLAN Id reserved for"},{"line_number":210,"context_line":"                                mirroring for this tap-service and the neutron"},{"line_number":211,"context_line":"                                port of the tap-service:"},{"line_number":212,"context_line":"                                {tap_service: {}, taas_id: \u0027\u0027, port: {}}"},{"line_number":213,"context_line":"        \"\"\""},{"line_number":214,"context_line":"        taas_id \u003d tap_service_msg[\u0027taas_id\u0027]"},{"line_number":215,"context_line":"        port \u003d tap_service_msg[\u0027port\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"df15e46e_736d7927","line":212,"range":{"start_line":212,"start_character":59,"end_line":212,"end_character":61},"updated":"2022-03-17 10:09:06.000000000","message":"Are you sure that taas_id is a string and not an int?","commit_id":"9e9dab1e2b8c298b019d9dab1e4d9091f5d15c3d"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"60e8d4e07bbe50dab8d2300a462f9b153606a79a","unresolved":true,"context_lines":[{"line_number":209,"context_line":"                                taas_id which is the VLAN Id reserved for"},{"line_number":210,"context_line":"                                mirroring for this tap-service and the neutron"},{"line_number":211,"context_line":"                                port of the tap-service:"},{"line_number":212,"context_line":"                                {tap_service: {}, taas_id: \u0027\u0027, port: {}}"},{"line_number":213,"context_line":"        \"\"\""},{"line_number":214,"context_line":"        taas_id \u003d tap_service_msg[\u0027taas_id\u0027]"},{"line_number":215,"context_line":"        port \u003d tap_service_msg[\u0027port\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"fedc0eb7_8e2329e0","line":212,"updated":"2022-03-13 08:54:58.000000000","message":"Dict filled : https://opendev.org/openstack/tap-as-a-service/src/branch/master/neutron_taas/services/taas/service_drivers/taas_rpc.py#L194-L196","commit_id":"9e9dab1e2b8c298b019d9dab1e4d9091f5d15c3d"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"b500ea1e41777e79f3767c2fdb543bab4b5d0132","unresolved":true,"context_lines":[{"line_number":209,"context_line":"                                taas_id which is the VLAN Id reserved for"},{"line_number":210,"context_line":"                                mirroring for this tap-service and the neutron"},{"line_number":211,"context_line":"                                port of the tap-service:"},{"line_number":212,"context_line":"                                {tap_service: {}, taas_id: \u0027\u0027, port: {}}"},{"line_number":213,"context_line":"        \"\"\""},{"line_number":214,"context_line":"        taas_id \u003d tap_service_msg[\u0027taas_id\u0027]"},{"line_number":215,"context_line":"        port \u003d tap_service_msg[\u0027port\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"275bd3c6_d799db5b","line":212,"range":{"start_line":212,"start_character":59,"end_line":212,"end_character":61},"in_reply_to":"df15e46e_736d7927","updated":"2022-03-18 16:16:57.000000000","message":"it\u0027s an int, thanks","commit_id":"9e9dab1e2b8c298b019d9dab1e4d9091f5d15c3d"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"60e8d4e07bbe50dab8d2300a462f9b153606a79a","unresolved":true,"context_lines":[{"line_number":293,"context_line":"                                taas_id which is the VLAN Id reserved for"},{"line_number":294,"context_line":"                                mirroring for this tap-service and the neutron"},{"line_number":295,"context_line":"                                port of the tap-service:"},{"line_number":296,"context_line":"                                {tap_service: {}, taas_id: \u0027\u0027, port: {}}"},{"line_number":297,"context_line":"        \"\"\""},{"line_number":298,"context_line":"        taas_id \u003d tap_service_msg[\u0027taas_id\u0027]"},{"line_number":299,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"58e6239f_9f8e1ad1","line":296,"updated":"2022-03-13 08:54:58.000000000","message":"Dict filled: https://opendev.org/openstack/tap-as-a-service/src/branch/master/neutron_taas/services/taas/service_drivers/taas_rpc.py#L222-L224","commit_id":"9e9dab1e2b8c298b019d9dab1e4d9091f5d15c3d"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"60e8d4e07bbe50dab8d2300a462f9b153606a79a","unresolved":true,"context_lines":[{"line_number":335,"context_line":"                             associated with this tap-flow, the neutron port"},{"line_number":336,"context_line":"                             of the tap-flow, and the port of the"},{"line_number":337,"context_line":"                             tap-service:"},{"line_number":338,"context_line":"                             {tap_flow: {}, port_mac: \u0027\u0027, taas_id: \u0027\u0027,"},{"line_number":339,"context_line":"                             port: {}, tap_service_port: {}}"},{"line_number":340,"context_line":"        \"\"\""},{"line_number":341,"context_line":"        taas_id \u003d tap_flow_msg[\u0027taas_id\u0027]"},{"line_number":342,"context_line":"        port \u003d tap_flow_msg[\u0027port\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"194c5d3f_ff2800d9","line":339,"range":{"start_line":338,"start_character":29,"end_line":339,"end_character":60},"updated":"2022-03-13 08:54:58.000000000","message":"dict filled: https://opendev.org/openstack/tap-as-a-service/src/branch/master/neutron_taas/services/taas/service_drivers/taas_rpc.py#L253-L257","commit_id":"9e9dab1e2b8c298b019d9dab1e4d9091f5d15c3d"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"60e8d4e07bbe50dab8d2300a462f9b153606a79a","unresolved":true,"context_lines":[{"line_number":424,"context_line":"                             of the tap-flow, the port of the"},{"line_number":425,"context_line":"                             tap-service, the list of source VLAN IDs, and"},{"line_number":426,"context_line":"                             VLAN filter list."},{"line_number":427,"context_line":"                             {tap_flow: {}, port_mac: \u0027\u0027, taas_id: \u0027\u0027,"},{"line_number":428,"context_line":"                             port: {}, tap_service_port: {},"},{"line_number":429,"context_line":"                             source_vlans_list: [], vlan_filter_list: []}"},{"line_number":430,"context_line":"        \"\"\""},{"line_number":431,"context_line":"        port \u003d tap_flow_msg[\u0027port\u0027]"},{"line_number":432,"context_line":"        direction \u003d tap_flow_msg[\u0027tap_flow\u0027][\u0027direction\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"a0420f37_c4a8c1d5","line":429,"range":{"start_line":427,"start_character":29,"end_line":429,"end_character":73},"updated":"2022-03-13 08:54:58.000000000","message":"Dict filled: https://opendev.org/openstack/tap-as-a-service/src/branch/master/neutron_taas/services/taas/service_drivers/taas_rpc.py#L317-L323","commit_id":"9e9dab1e2b8c298b019d9dab1e4d9091f5d15c3d"}],"neutron_taas/services/taas/service_drivers/taas_agent_api.py":[{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"5aff0073e68a30b3471b77dec01b5a154e57a531","unresolved":true,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        cctxt \u003d self.client.prepare(fanout\u003dTrue)"},{"line_number":38,"context_line":"        cctxt.cast(context, \u0027create_tap_service\u0027,"},{"line_number":39,"context_line":"                   tap_service_msg\u003dtap_service_msg, host\u003dhost)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        return"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"6c0d2602_39d30023","line":39,"range":{"start_line":39,"start_character":30,"end_line":39,"end_character":34},"updated":"2022-03-17 10:09:06.000000000","message":"Here we are changing the message format on the wire. Which leads to an rpc upgrade issue. For example when the server is upgraded but the agent is not yet, we\u0027ll get something like:\n\n ERROR oslo_messaging.rpc.server TypeError: create_tap_service() got an unexpected keyword argument \u0027tap_service_msg\u0027\n\nWe either need to leave the wire-format unchanged, or bump the rpc version and handle the version upgrade gracefully. I believe the code refactor you proposed here can work without changing the wire-format.","commit_id":"9e9dab1e2b8c298b019d9dab1e4d9091f5d15c3d"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"b500ea1e41777e79f3767c2fdb543bab4b5d0132","unresolved":true,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        cctxt \u003d self.client.prepare(fanout\u003dTrue)"},{"line_number":38,"context_line":"        cctxt.cast(context, \u0027create_tap_service\u0027,"},{"line_number":39,"context_line":"                   tap_service_msg\u003dtap_service_msg, host\u003dhost)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        return"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"e1623790_938721cf","line":39,"range":{"start_line":39,"start_character":30,"end_line":39,"end_character":34},"in_reply_to":"6c0d2602_39d30023","updated":"2022-03-18 16:16:57.000000000","message":"thanks, good catch, before I destroy something....","commit_id":"9e9dab1e2b8c298b019d9dab1e4d9091f5d15c3d"}]}