)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"831f9834466b1d614ba5bb84548c0bb82641f38c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"358d9d8d_00165ac4","updated":"2023-10-04 12:56:25.000000000","message":"I tested, and it works as expected, thanks.\nI will advertise it anyway on neutron channel and meetings, but please do the same.\nConsider my nit if you have to push another patchset.","commit_id":"a1c8fb842b9f5aa308116c4c7b5243d7189ae879"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"38b03c8b690bbc49f6257186699f43d7c425f8ca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"9f74a836_e3408d73","updated":"2023-12-07 12:35:27.000000000","message":"Thanks","commit_id":"2df58e7ebb8d15ad7579230e3e03966f2f332a83"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"dcfc2bb49900596cb9d26be06838be0a27cf7212","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"99cf73f9_a9095321","updated":"2024-01-23 09:30:59.000000000","message":"Thanks","commit_id":"b6eaef52ab4c21040ab3927053320851954da860"}],"neutron_taas/db/taas_db.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"0dd0192977fc767cef40c073106a29b131f9f893","unresolved":true,"context_lines":[{"line_number":148,"context_line":"    def get_port_network_data(self, context, port):"},{"line_number":149,"context_line":"        ns \u003d context.session.query(NetworkSegment).filter("},{"line_number":150,"context_line":"            NetworkSegment.network_id \u003d\u003d port[\u0027network_id\u0027]"},{"line_number":151,"context_line":"        ).first()"},{"line_number":152,"context_line":"        ns_data \u003d {"},{"line_number":153,"context_line":"            \u0027physical_network\u0027: ns[\u0027physical_network\u0027],"},{"line_number":154,"context_line":"            \u0027network_type\u0027: ns[\u0027network_type\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"88e7880b_dc27b4da","line":151,"updated":"2023-11-14 17:31:45.000000000","message":"If this fails or doesn\u0027t find the segment will it just throw an exception? if not it will below","commit_id":"a1c8fb842b9f5aa308116c4c7b5243d7189ae879"},{"author":{"_account_id":35765,"name":"Felipe Figueroa Vergara","display_name":"Felipe Figueroa","email":"ffigueroa@whitestack.com","username":"felipeafv","status":"Whitestack"},"change_message_id":"628507cfc36359f12fdd3307d50137be5f9be4c1","unresolved":false,"context_lines":[{"line_number":148,"context_line":"    def get_port_network_data(self, context, port):"},{"line_number":149,"context_line":"        ns \u003d context.session.query(NetworkSegment).filter("},{"line_number":150,"context_line":"            NetworkSegment.network_id \u003d\u003d port[\u0027network_id\u0027]"},{"line_number":151,"context_line":"        ).first()"},{"line_number":152,"context_line":"        ns_data \u003d {"},{"line_number":153,"context_line":"            \u0027physical_network\u0027: ns[\u0027physical_network\u0027],"},{"line_number":154,"context_line":"            \u0027network_type\u0027: ns[\u0027network_type\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"21907170_8866a90f","line":151,"in_reply_to":"0983832d_d248eb40","updated":"2023-12-19 14:28:27.000000000","message":"Done","commit_id":"a1c8fb842b9f5aa308116c4c7b5243d7189ae879"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"c5c74996a3dad1fb0b3da6636183ba67d09aa560","unresolved":true,"context_lines":[{"line_number":148,"context_line":"    def get_port_network_data(self, context, port):"},{"line_number":149,"context_line":"        ns \u003d context.session.query(NetworkSegment).filter("},{"line_number":150,"context_line":"            NetworkSegment.network_id \u003d\u003d port[\u0027network_id\u0027]"},{"line_number":151,"context_line":"        ).first()"},{"line_number":152,"context_line":"        ns_data \u003d {"},{"line_number":153,"context_line":"            \u0027physical_network\u0027: ns[\u0027physical_network\u0027],"},{"line_number":154,"context_line":"            \u0027network_type\u0027: ns[\u0027network_type\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"0983832d_d248eb40","line":151,"in_reply_to":"7f0bee14_52c5c541","updated":"2023-11-30 10:01:58.000000000","message":"Could you please add the extra check?\nlike:\nif not ns:\n    LOG.warning(\u0027Perhaps debug is enough?\u0027)\n    return","commit_id":"a1c8fb842b9f5aa308116c4c7b5243d7189ae879"},{"author":{"_account_id":35765,"name":"Felipe Figueroa Vergara","display_name":"Felipe Figueroa","email":"ffigueroa@whitestack.com","username":"felipeafv","status":"Whitestack"},"change_message_id":"19b223c4c4188cfb723719aeab00ce1460b4e853","unresolved":true,"context_lines":[{"line_number":148,"context_line":"    def get_port_network_data(self, context, port):"},{"line_number":149,"context_line":"        ns \u003d context.session.query(NetworkSegment).filter("},{"line_number":150,"context_line":"            NetworkSegment.network_id \u003d\u003d port[\u0027network_id\u0027]"},{"line_number":151,"context_line":"        ).first()"},{"line_number":152,"context_line":"        ns_data \u003d {"},{"line_number":153,"context_line":"            \u0027physical_network\u0027: ns[\u0027physical_network\u0027],"},{"line_number":154,"context_line":"            \u0027network_type\u0027: ns[\u0027network_type\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f0bee14_52c5c541","line":151,"in_reply_to":"88e7880b_dc27b4da","updated":"2023-11-27 19:06:41.000000000","message":"I can add a catch for the error to allow leaving the physical_network and network_type parameters null, which would subsequently lead to a misconfiguration in the driver, but we handle the error.","commit_id":"a1c8fb842b9f5aa308116c4c7b5243d7189ae879"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b6f31c0c9d4e957f635bdfee492e10b62cbbf0ba","unresolved":true,"context_lines":[{"line_number":19,"context_line":"from sqlalchemy import orm"},{"line_number":20,"context_line":"from sqlalchemy.orm import exc"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from neutron.db.models.segment import NetworkSegment"},{"line_number":23,"context_line":"from neutron_lib import constants"},{"line_number":24,"context_line":"from neutron_lib.db import api as db_api"},{"line_number":25,"context_line":"from neutron_lib.db import model_base"}],"source_content_type":"text/x-python","patch_set":18,"id":"48abe890_cfc84594","line":22,"range":{"start_line":22,"start_character":38,"end_line":22,"end_character":52},"updated":"2023-12-20 08:21:59.000000000","message":"Do not import a single class/variable, import the whole module.","commit_id":"408a735cc53fdd73839c619addd445c4582d2093"},{"author":{"_account_id":35765,"name":"Felipe Figueroa Vergara","display_name":"Felipe Figueroa","email":"ffigueroa@whitestack.com","username":"felipeafv","status":"Whitestack"},"change_message_id":"b4a972707f880c7ba80361c5920eed4c9917dcec","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from sqlalchemy import orm"},{"line_number":20,"context_line":"from sqlalchemy.orm import exc"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from neutron.db.models.segment import NetworkSegment"},{"line_number":23,"context_line":"from neutron_lib import constants"},{"line_number":24,"context_line":"from neutron_lib.db import api as db_api"},{"line_number":25,"context_line":"from neutron_lib.db import model_base"}],"source_content_type":"text/x-python","patch_set":18,"id":"07a51889_1af0c21f","line":22,"range":{"start_line":22,"start_character":38,"end_line":22,"end_character":52},"in_reply_to":"48abe890_cfc84594","updated":"2024-01-05 12:51:10.000000000","message":"Done","commit_id":"408a735cc53fdd73839c619addd445c4582d2093"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b6f31c0c9d4e957f635bdfee492e10b62cbbf0ba","unresolved":true,"context_lines":[{"line_number":143,"context_line":"               \u0027vlan_filter\u0027: tap_flow[\u0027vlan_filter\u0027]}"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        return db_utils.resource_fields(res, fields)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    @db_api.CONTEXT_READER"},{"line_number":148,"context_line":"    def get_port_network_data(self, context, port):"},{"line_number":149,"context_line":"        ns \u003d context.session.query(NetworkSegment).filter("}],"source_content_type":"text/x-python","patch_set":18,"id":"b2477822_ad99a0f2","line":146,"updated":"2023-12-20 08:21:59.000000000","message":"Why not \"@db_api.retry_if_session_inactive()\" decorator?","commit_id":"408a735cc53fdd73839c619addd445c4582d2093"},{"author":{"_account_id":35765,"name":"Felipe Figueroa Vergara","display_name":"Felipe Figueroa","email":"ffigueroa@whitestack.com","username":"felipeafv","status":"Whitestack"},"change_message_id":"b4a972707f880c7ba80361c5920eed4c9917dcec","unresolved":false,"context_lines":[{"line_number":143,"context_line":"               \u0027vlan_filter\u0027: tap_flow[\u0027vlan_filter\u0027]}"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        return db_utils.resource_fields(res, fields)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    @db_api.CONTEXT_READER"},{"line_number":148,"context_line":"    def get_port_network_data(self, context, port):"},{"line_number":149,"context_line":"        ns \u003d context.session.query(NetworkSegment).filter("}],"source_content_type":"text/x-python","patch_set":18,"id":"de7a0d67_380e114d","line":146,"in_reply_to":"b2477822_ad99a0f2","updated":"2024-01-05 12:51:10.000000000","message":"Done","commit_id":"408a735cc53fdd73839c619addd445c4582d2093"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b6f31c0c9d4e957f635bdfee492e10b62cbbf0ba","unresolved":true,"context_lines":[{"line_number":156,"context_line":"            return"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        ns_data \u003d {"},{"line_number":159,"context_line":"            \u0027physical_network\u0027: ns[\u0027physical_network\u0027],"},{"line_number":160,"context_line":"            \u0027network_type\u0027: ns[\u0027network_type\u0027]"},{"line_number":161,"context_line":"        }"},{"line_number":162,"context_line":"        return ns_data"},{"line_number":163,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"954bb858_1c581bcc","line":160,"range":{"start_line":159,"start_character":12,"end_line":160,"end_character":46},"updated":"2023-12-20 08:21:59.000000000","message":"If you only need two parameters, be more specific in the query:\n```\n  context.session.query(NetworkSegment.network_id,\n                        NetworkSegment.physical_network,\n                        NetworkSegment.network_type)\n```","commit_id":"408a735cc53fdd73839c619addd445c4582d2093"},{"author":{"_account_id":35765,"name":"Felipe Figueroa Vergara","display_name":"Felipe Figueroa","email":"ffigueroa@whitestack.com","username":"felipeafv","status":"Whitestack"},"change_message_id":"b4a972707f880c7ba80361c5920eed4c9917dcec","unresolved":false,"context_lines":[{"line_number":156,"context_line":"            return"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        ns_data \u003d {"},{"line_number":159,"context_line":"            \u0027physical_network\u0027: ns[\u0027physical_network\u0027],"},{"line_number":160,"context_line":"            \u0027network_type\u0027: ns[\u0027network_type\u0027]"},{"line_number":161,"context_line":"        }"},{"line_number":162,"context_line":"        return ns_data"},{"line_number":163,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"87f1d5c6_c422c766","line":160,"range":{"start_line":159,"start_character":12,"end_line":160,"end_character":46},"in_reply_to":"954bb858_1c581bcc","updated":"2024-01-05 12:51:10.000000000","message":"Done","commit_id":"408a735cc53fdd73839c619addd445c4582d2093"}],"neutron_taas/services/taas/drivers/linux/ovs_taas.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"831f9834466b1d614ba5bb84548c0bb82641f38c","unresolved":true,"context_lines":[{"line_number":392,"context_line":"                self.int_br.add_flow("},{"line_number":393,"context_line":"                    table\u003d0,"},{"line_number":394,"context_line":"                    priority\u003d20,"},{"line_number":395,"context_line":"                    # dl_vlan\u003dport_vlan_id,"},{"line_number":396,"context_line":"                    dl_dst\u003dport_mac,"},{"line_number":397,"context_line":"                    actions\u003d\"strip_vlan,output:%s,mod_vlan_vid:%s,output:%s\" %"},{"line_number":398,"context_line":"                    (str(ovs_port_id), str(taas_id), str(patch_int_tap_id))"}],"source_content_type":"text/x-python","patch_set":4,"id":"1dba776e_9108991c","line":395,"range":{"start_line":395,"start_character":0,"end_line":395,"end_character":43},"updated":"2023-10-04 12:56:25.000000000","message":"nit: You can safely remove these commented filters","commit_id":"a1c8fb842b9f5aa308116c4c7b5243d7189ae879"},{"author":{"_account_id":35765,"name":"Felipe Figueroa Vergara","display_name":"Felipe Figueroa","email":"ffigueroa@whitestack.com","username":"felipeafv","status":"Whitestack"},"change_message_id":"628507cfc36359f12fdd3307d50137be5f9be4c1","unresolved":false,"context_lines":[{"line_number":392,"context_line":"                self.int_br.add_flow("},{"line_number":393,"context_line":"                    table\u003d0,"},{"line_number":394,"context_line":"                    priority\u003d20,"},{"line_number":395,"context_line":"                    # dl_vlan\u003dport_vlan_id,"},{"line_number":396,"context_line":"                    dl_dst\u003dport_mac,"},{"line_number":397,"context_line":"                    actions\u003d\"strip_vlan,output:%s,mod_vlan_vid:%s,output:%s\" %"},{"line_number":398,"context_line":"                    (str(ovs_port_id), str(taas_id), str(patch_int_tap_id))"}],"source_content_type":"text/x-python","patch_set":4,"id":"dfe5fd3b_5da7fb21","line":395,"range":{"start_line":395,"start_character":0,"end_line":395,"end_character":43},"in_reply_to":"1dba776e_9108991c","updated":"2023-12-19 14:28:27.000000000","message":"Done","commit_id":"a1c8fb842b9f5aa308116c4c7b5243d7189ae879"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"831f9834466b1d614ba5bb84548c0bb82641f38c","unresolved":true,"context_lines":[{"line_number":473,"context_line":"            # Get patch port ID"},{"line_number":474,"context_line":"            # patch_int_tap_id \u003d self.int_br.get_port_ofport(\u0027patch-int-tap\u0027)"},{"line_number":475,"context_line":""},{"line_number":476,"context_line":"            self.int_br.delete_flows(table\u003d0,"},{"line_number":477,"context_line":"                                     # dl_vlan\u003dport_vlan_id,"},{"line_number":478,"context_line":"                                     dl_dst\u003dport_mac)"},{"line_number":479,"context_line":""},{"line_number":480,"context_line":"            # self._del_update_ingress_bcmc_flow(port_vlan_id,"},{"line_number":481,"context_line":"            #                                    taas_id,"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9b25_a10f1b02","line":478,"range":{"start_line":476,"start_character":12,"end_line":478,"end_character":53},"updated":"2023-10-04 12:56:25.000000000","message":"this will anyway delete the flow from br-int, as dl_dst is filter in all new cases also","commit_id":"a1c8fb842b9f5aa308116c4c7b5243d7189ae879"},{"author":{"_account_id":35765,"name":"Felipe Figueroa Vergara","display_name":"Felipe Figueroa","email":"ffigueroa@whitestack.com","username":"felipeafv","status":"Whitestack"},"change_message_id":"628507cfc36359f12fdd3307d50137be5f9be4c1","unresolved":false,"context_lines":[{"line_number":473,"context_line":"            # Get patch port ID"},{"line_number":474,"context_line":"            # patch_int_tap_id \u003d self.int_br.get_port_ofport(\u0027patch-int-tap\u0027)"},{"line_number":475,"context_line":""},{"line_number":476,"context_line":"            self.int_br.delete_flows(table\u003d0,"},{"line_number":477,"context_line":"                                     # dl_vlan\u003dport_vlan_id,"},{"line_number":478,"context_line":"                                     dl_dst\u003dport_mac)"},{"line_number":479,"context_line":""},{"line_number":480,"context_line":"            # self._del_update_ingress_bcmc_flow(port_vlan_id,"},{"line_number":481,"context_line":"            #                                    taas_id,"}],"source_content_type":"text/x-python","patch_set":4,"id":"c77d4522_47cd54cb","line":478,"range":{"start_line":476,"start_character":12,"end_line":478,"end_character":53},"in_reply_to":"fa1b9b25_a10f1b02","updated":"2023-12-19 14:28:27.000000000","message":"Done","commit_id":"a1c8fb842b9f5aa308116c4c7b5243d7189ae879"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b6f31c0c9d4e957f635bdfee492e10b62cbbf0ba","unresolved":true,"context_lines":[{"line_number":336,"context_line":"        taas_id \u003d tap_flow_msg[\u0027taas_id\u0027]"},{"line_number":337,"context_line":"        port \u003d tap_flow_msg[\u0027port\u0027]"},{"line_number":338,"context_line":"        direction \u003d tap_flow_msg[\u0027tap_flow\u0027][\u0027direction\u0027]"},{"line_number":339,"context_line":"        physical_network \u003d tap_flow_msg[\u0027tf_nw\u0027][\u0027physical_network\u0027]"},{"line_number":340,"context_line":"        network_type \u003d tap_flow_msg[\u0027tf_nw\u0027][\u0027network_type\u0027]"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"        # Get OVS port id for tap flow port"},{"line_number":343,"context_line":"        ovs_port \u003d self.int_br.get_vif_port_by_id(port[\u0027id\u0027])"},{"line_number":344,"context_line":"        ovs_port_id \u003d ovs_port.ofport"}],"source_content_type":"text/x-python","patch_set":18,"id":"240c0a0c_1db05cb6","line":341,"range":{"start_line":339,"start_character":8,"end_line":341,"end_character":1},"updated":"2023-12-20 08:21:59.000000000","message":"The \"tf_nw\" value is a new RPC parameter provided by the server. Because you don\u0027t have any RPC version revision, you should consider that this parameter could not be present [1]. Please make this code more robust.\n\n[1] In a well deployed upgrade, the server is always updated first. But we should consider the possibility of upgrading the agent before the server.","commit_id":"408a735cc53fdd73839c619addd445c4582d2093"},{"author":{"_account_id":35765,"name":"Felipe Figueroa Vergara","display_name":"Felipe Figueroa","email":"ffigueroa@whitestack.com","username":"felipeafv","status":"Whitestack"},"change_message_id":"b4a972707f880c7ba80361c5920eed4c9917dcec","unresolved":true,"context_lines":[{"line_number":336,"context_line":"        taas_id \u003d tap_flow_msg[\u0027taas_id\u0027]"},{"line_number":337,"context_line":"        port \u003d tap_flow_msg[\u0027port\u0027]"},{"line_number":338,"context_line":"        direction \u003d tap_flow_msg[\u0027tap_flow\u0027][\u0027direction\u0027]"},{"line_number":339,"context_line":"        physical_network \u003d tap_flow_msg[\u0027tf_nw\u0027][\u0027physical_network\u0027]"},{"line_number":340,"context_line":"        network_type \u003d tap_flow_msg[\u0027tf_nw\u0027][\u0027network_type\u0027]"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"        # Get OVS port id for tap flow port"},{"line_number":343,"context_line":"        ovs_port \u003d self.int_br.get_vif_port_by_id(port[\u0027id\u0027])"},{"line_number":344,"context_line":"        ovs_port_id \u003d ovs_port.ofport"}],"source_content_type":"text/x-python","patch_set":18,"id":"89825c7f_23107531","line":341,"range":{"start_line":339,"start_character":8,"end_line":341,"end_character":1},"in_reply_to":"240c0a0c_1db05cb6","updated":"2024-01-05 12:51:10.000000000","message":"But the \u0027tf_nw\u0027 attribute is part of the RPC message; there shouldn\u0027t be a dependency on the RPC version, as it\u0027s just part of the message, right?","commit_id":"408a735cc53fdd73839c619addd445c4582d2093"},{"author":{"_account_id":35765,"name":"Felipe Figueroa Vergara","display_name":"Felipe Figueroa","email":"ffigueroa@whitestack.com","username":"felipeafv","status":"Whitestack"},"change_message_id":"3a54ee5674f3fc840d793248753e080f0432957d","unresolved":false,"context_lines":[{"line_number":336,"context_line":"        taas_id \u003d tap_flow_msg[\u0027taas_id\u0027]"},{"line_number":337,"context_line":"        port \u003d tap_flow_msg[\u0027port\u0027]"},{"line_number":338,"context_line":"        direction \u003d tap_flow_msg[\u0027tap_flow\u0027][\u0027direction\u0027]"},{"line_number":339,"context_line":"        physical_network \u003d tap_flow_msg[\u0027tf_nw\u0027][\u0027physical_network\u0027]"},{"line_number":340,"context_line":"        network_type \u003d tap_flow_msg[\u0027tf_nw\u0027][\u0027network_type\u0027]"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"        # Get OVS port id for tap flow port"},{"line_number":343,"context_line":"        ovs_port \u003d self.int_br.get_vif_port_by_id(port[\u0027id\u0027])"},{"line_number":344,"context_line":"        ovs_port_id \u003d ovs_port.ofport"}],"source_content_type":"text/x-python","patch_set":18,"id":"5b146708_380f5c2e","line":341,"range":{"start_line":339,"start_character":8,"end_line":341,"end_character":1},"in_reply_to":"63bea1e7_79eea544","updated":"2024-01-17 11:22:37.000000000","message":"Done","commit_id":"408a735cc53fdd73839c619addd445c4582d2093"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"99f9c5b2579c3bb1b1c51d8bf0a039b43d914080","unresolved":true,"context_lines":[{"line_number":336,"context_line":"        taas_id \u003d tap_flow_msg[\u0027taas_id\u0027]"},{"line_number":337,"context_line":"        port \u003d tap_flow_msg[\u0027port\u0027]"},{"line_number":338,"context_line":"        direction \u003d tap_flow_msg[\u0027tap_flow\u0027][\u0027direction\u0027]"},{"line_number":339,"context_line":"        physical_network \u003d tap_flow_msg[\u0027tf_nw\u0027][\u0027physical_network\u0027]"},{"line_number":340,"context_line":"        network_type \u003d tap_flow_msg[\u0027tf_nw\u0027][\u0027network_type\u0027]"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"        # Get OVS port id for tap flow port"},{"line_number":343,"context_line":"        ovs_port \u003d self.int_br.get_vif_port_by_id(port[\u0027id\u0027])"},{"line_number":344,"context_line":"        ovs_port_id \u003d ovs_port.ofport"}],"source_content_type":"text/x-python","patch_set":18,"id":"63bea1e7_79eea544","line":341,"range":{"start_line":339,"start_character":8,"end_line":341,"end_character":1},"in_reply_to":"89825c7f_23107531","updated":"2024-01-11 07:49:03.000000000","message":"Rodolfo means that during upgrade it an happen that the server and the agent speaks different version of the RPC.\nSadly taas has no rpc versioning","commit_id":"408a735cc53fdd73839c619addd445c4582d2093"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b6f31c0c9d4e957f635bdfee492e10b62cbbf0ba","unresolved":true,"context_lines":[{"line_number":388,"context_line":"                    (str(taas_id), str(patch_int_tap_id))"},{"line_number":389,"context_line":"                )"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"            elif network_type \u003d\u003d \u0027vlan\u0027:"},{"line_number":392,"context_line":"                self.int_br.add_flow("},{"line_number":393,"context_line":"                    table\u003d0,"},{"line_number":394,"context_line":"                    priority\u003d20,"}],"source_content_type":"text/x-python","patch_set":18,"id":"7a6f6a7f_32887b2f","line":391,"range":{"start_line":391,"start_character":34,"end_line":391,"end_character":38},"updated":"2023-12-20 08:21:59.000000000","message":"neutron_lib.constants.TYPE_VLAN \u003d \u0027vlan\u0027\n\nIn any case, please don\u0027t duplicate code. These two branches (VLAN, flat) could be:\n```\nelse:\n   actions \u003d \"output:%s,mod_vlan_vid:%s,output:%s\" %\n             (str(ovs_port_id), str(taas_id), str(patch_int_tap_id)\n   if network_type \u003d\u003d neutron_lib.constants.TYPE_VLAN:\n       actions +\u003d \"strip_vlan,\" + actions\n   self.int_br.add_flow( ... )\n\n```","commit_id":"408a735cc53fdd73839c619addd445c4582d2093"},{"author":{"_account_id":35765,"name":"Felipe Figueroa Vergara","display_name":"Felipe Figueroa","email":"ffigueroa@whitestack.com","username":"felipeafv","status":"Whitestack"},"change_message_id":"b4a972707f880c7ba80361c5920eed4c9917dcec","unresolved":false,"context_lines":[{"line_number":388,"context_line":"                    (str(taas_id), str(patch_int_tap_id))"},{"line_number":389,"context_line":"                )"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"            elif network_type \u003d\u003d \u0027vlan\u0027:"},{"line_number":392,"context_line":"                self.int_br.add_flow("},{"line_number":393,"context_line":"                    table\u003d0,"},{"line_number":394,"context_line":"                    priority\u003d20,"}],"source_content_type":"text/x-python","patch_set":18,"id":"6090cc31_ee8fbaa0","line":391,"range":{"start_line":391,"start_character":34,"end_line":391,"end_character":38},"in_reply_to":"7a6f6a7f_32887b2f","updated":"2024-01-05 12:51:10.000000000","message":"Done","commit_id":"408a735cc53fdd73839c619addd445c4582d2093"}],"neutron_taas/services/taas/service_drivers/taas_rpc.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b6f31c0c9d4e957f635bdfee492e10b62cbbf0ba","unresolved":true,"context_lines":[{"line_number":251,"context_line":"            context._plugin_context, port)"},{"line_number":252,"context_line":"        # Send RPC message to both the source port host and"},{"line_number":253,"context_line":"        # tap service(destination) port host"},{"line_number":254,"context_line":"        rpc_msg \u003d {\u0027tap_flow\u0027: tf,"},{"line_number":255,"context_line":"                   \u0027port_mac\u0027: port_mac,"},{"line_number":256,"context_line":"                   \u0027taas_id\u0027: taas_id,"},{"line_number":257,"context_line":"                   \u0027port\u0027: port,"},{"line_number":258,"context_line":"                   \u0027tap_service_port\u0027: ts_port,"},{"line_number":259,"context_line":"                   \u0027tf_nw\u0027: tf_nw}"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"        self.agent_rpc.create_tap_flow(context._plugin_context, rpc_msg, host)"},{"line_number":262,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"4835accf_2cad6431","line":259,"range":{"start_line":254,"start_character":8,"end_line":259,"end_character":34},"updated":"2023-12-20 08:21:59.000000000","message":"nit: in order to keep the git history, add a new line at the end. That will allow to add a new line, if needed, keeping your change.\n```\n                   \u0027tap_service_port\u0027: ts_port,\n                   \u0027tf_nw\u0027: tf_nw,\n                   }\n```","commit_id":"408a735cc53fdd73839c619addd445c4582d2093"},{"author":{"_account_id":35765,"name":"Felipe Figueroa Vergara","display_name":"Felipe Figueroa","email":"ffigueroa@whitestack.com","username":"felipeafv","status":"Whitestack"},"change_message_id":"b4a972707f880c7ba80361c5920eed4c9917dcec","unresolved":false,"context_lines":[{"line_number":251,"context_line":"            context._plugin_context, port)"},{"line_number":252,"context_line":"        # Send RPC message to both the source port host and"},{"line_number":253,"context_line":"        # tap service(destination) port host"},{"line_number":254,"context_line":"        rpc_msg \u003d {\u0027tap_flow\u0027: tf,"},{"line_number":255,"context_line":"                   \u0027port_mac\u0027: port_mac,"},{"line_number":256,"context_line":"                   \u0027taas_id\u0027: taas_id,"},{"line_number":257,"context_line":"                   \u0027port\u0027: port,"},{"line_number":258,"context_line":"                   \u0027tap_service_port\u0027: ts_port,"},{"line_number":259,"context_line":"                   \u0027tf_nw\u0027: tf_nw}"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"        self.agent_rpc.create_tap_flow(context._plugin_context, rpc_msg, host)"},{"line_number":262,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"af0ef7c1_7a517019","line":259,"range":{"start_line":254,"start_character":8,"end_line":259,"end_character":34},"in_reply_to":"4835accf_2cad6431","updated":"2024-01-05 12:51:10.000000000","message":"Done","commit_id":"408a735cc53fdd73839c619addd445c4582d2093"}]}