)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"b98702932aa53e720d218f4502df42976fc88087","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3cfc0e9a_a891c27d","updated":"2023-10-19 19:00:56.000000000","message":"please see my comments inline.","commit_id":"42557498acd5e382c0a4e5539dfa407d3f401838"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"43554d70b4e833939e4fa79096f13ed5d157f66c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"961996ca_714239c6","updated":"2023-10-19 18:51:24.000000000","message":"recheck - stable/stein is fixed","commit_id":"42557498acd5e382c0a4e5539dfa407d3f401838"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"0e38e6bb8ed3ac1520598b31d5b2d01011b0b0e8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1e855ef5_5da0046c","updated":"2023-10-25 12:58:54.000000000","message":"Thanks for the updates! Zuul is happy \\o/\nnits: for me for local testing the following changes seemed to be unnecessary:\n- doc/requirements change\n- in releasenotes/source/conf.py only the oslosphinx to openstackdocstheme was necessary\n\n+1: I\u0027d still add \u0027-r{toxinidir}/requirements.txt\u0027 to tox.ini in releasenotes target\u0027s \u0027deps\u0027 section to avoid future gate issues.\n\nAnyway, zuul is happy, so am I, let\u0027s merge this.","commit_id":"30323fb7a43326993154bfe1960dd8def67477e0"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"4491f53c5f55925b8c49aef81041b82163cdffcc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"be16fa5a_b96bc332","updated":"2023-10-26 09:11:23.000000000","message":"it\u0027s ok for me but I think You should address Elod\u0027s comments first","commit_id":"30323fb7a43326993154bfe1960dd8def67477e0"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"a1253e46f710ff2e63e1eb87f9af99bd187f3071","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"99d37f70_befcdea7","updated":"2023-10-24 11:43:53.000000000","message":"recheck\nstein should be ok now","commit_id":"30323fb7a43326993154bfe1960dd8def67477e0"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"d1761e432c2e3a097a4f23905f7bbb9769c0554d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"6952068b_4add7351","in_reply_to":"1e855ef5_5da0046c","updated":"2023-10-26 10:17:40.000000000","message":"done","commit_id":"30323fb7a43326993154bfe1960dd8def67477e0"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"0dba5c5512f61e079656e31f8602023252a26c10","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"fee8bbef_4ffd69da","updated":"2023-10-27 12:46:13.000000000","message":"Thanks","commit_id":"2dfb41ffcf23b6e4aeb15a1fb8ebd664c234d024"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"a3de1143fc486aa435c76b2fb4cc6a322d1dc241","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"d93319ea_afe8e7f8","updated":"2023-10-30 11:49:00.000000000","message":"Thanks, now it really looks green in zuul (waiting for tempest 🤞)","commit_id":"e7977090f3251a3b81e8b26f710ce88d05125196"}],"releasenotes/notes/bp-port-mirroring-sriov-vf-879bc2aa53c2c8d4.yaml":[{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"b98702932aa53e720d218f4502df42976fc88087","unresolved":true,"context_lines":[{"line_number":5,"context_line":"features:"},{"line_number":6,"context_line":"  - |"},{"line_number":7,"context_line":"    https://blueprints.launchpad.net/neutron/+spec/port-mirroring-sriov-vf"},{"line_number":8,"context_line":"    "},{"line_number":9,"context_line":"    * Adds a new TaaS Agent driver (i.e. SRIOV) for Intel i40e driver backend."},{"line_number":10,"context_line":"    "},{"line_number":11,"context_line":"    * Neutron TaaS Agent is refactored to decouple its tight binding with ovs"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dc2737b2_089a630c","line":8,"updated":"2023-10-19 19:00:56.000000000","message":"note: this new line is the only needed change.","commit_id":"42557498acd5e382c0a4e5539dfa407d3f401838"}],"releasenotes/notes/clear-tap-resources-on-port-delete-9583cdd7cd6098ea.yaml":[{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"b98702932aa53e720d218f4502df42976fc88087","unresolved":true,"context_lines":[{"line_number":6,"context_line":"    that earlier deleting a port did not clear the associated tap resources."},{"line_number":7,"context_line":"issues:"},{"line_number":8,"context_line":"  - |"},{"line_number":9,"context_line":"    Fixes bug https://bugs.launchpad.net/tap-as-a-service/+bug/1814937"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"8636b531_fa01f0f7","line":9,"updated":"2023-10-19 19:00:56.000000000","message":"this change is not needed at all","commit_id":"42557498acd5e382c0a4e5539dfa407d3f401838"}],"releasenotes/source/index.rst":[{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"758fc060aea76aa493b99fe76214f3c11a47a520","unresolved":true,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"Tap-as-a-service Release Notes"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"ce388d85_e0543222","line":1,"updated":"2023-10-26 09:20:21.000000000","message":"this looks little odd as train reference removed but some older releases stein/queens are there.","commit_id":"30323fb7a43326993154bfe1960dd8def67477e0"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"d1761e432c2e3a097a4f23905f7bbb9769c0554d","unresolved":true,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"Tap-as-a-service Release Notes"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"ecc66b62_260aeff6","line":1,"in_reply_to":"ce388d85_e0543222","updated":"2023-10-26 10:17:40.000000000","message":"I think it is due to that taas was under x/ for some releases","commit_id":"30323fb7a43326993154bfe1960dd8def67477e0"}],"tox.ini":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"441b7e5acc5d988b1acd7662f45812697f31e257","unresolved":true,"context_lines":[{"line_number":52,"context_line":"commands \u003d sphinx-build -W -d doc/build/doctrees -b html doc/source doc/build/html"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"[testenv:releasenotes]"},{"line_number":55,"context_line":"commands \u003d sphinx-build -a -E -W -d releasenotes/build/doctrees -b html releasenotes/source releasenotes/build/html"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"[testenv:genpolicy]"},{"line_number":58,"context_line":"commands \u003d oslopolicy-sample-generator --config-file etc/policy-generator.conf"}],"source_content_type":"text/x-properties","patch_set":3,"id":"e918592d_f80e9b54","side":"PARENT","line":55,"range":{"start_line":55,"start_character":30,"end_line":55,"end_character":33},"updated":"2023-10-02 13:18:39.000000000","message":"with newer sphinx there is a warning that is changed to Error, due to bad indentation in stein (https://opendev.org/openstack/tap-as-a-service/src/branch/master/releasenotes/notes/bp-port-mirroring-sriov-vf-879bc2aa53c2c8d4.yaml ), and it is failing even if I fix the indentation issue.","commit_id":"c9f147b56ff8c368a10d79d1b6aa453e1139dc3d"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"b98702932aa53e720d218f4502df42976fc88087","unresolved":false,"context_lines":[{"line_number":52,"context_line":"commands \u003d sphinx-build -W -d doc/build/doctrees -b html doc/source doc/build/html"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"[testenv:releasenotes]"},{"line_number":55,"context_line":"commands \u003d sphinx-build -a -E -W -d releasenotes/build/doctrees -b html releasenotes/source releasenotes/build/html"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"[testenv:genpolicy]"},{"line_number":58,"context_line":"commands \u003d oslopolicy-sample-generator --config-file etc/policy-generator.conf"}],"source_content_type":"text/x-properties","patch_set":3,"id":"f7a0334b_3004c383","side":"PARENT","line":55,"range":{"start_line":55,"start_character":30,"end_line":55,"end_character":33},"in_reply_to":"e918592d_f80e9b54","updated":"2023-10-19 19:00:56.000000000","message":"This fix has landed: https://review.opendev.org/c/openstack/tap-as-a-service/+/897147","commit_id":"c9f147b56ff8c368a10d79d1b6aa453e1139dc3d"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"b98702932aa53e720d218f4502df42976fc88087","unresolved":true,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"[testenv:releasenotes]"},{"line_number":55,"context_line":"deps \u003d -c{env:TOX_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}"},{"line_number":56,"context_line":"       -r{toxinidir}/doc/requirements.txt"},{"line_number":57,"context_line":"commands \u003d sphinx-build -a -E -d releasenotes/build/doctrees -b html releasenotes/source releasenotes/build/html"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"[testenv:genpolicy]"}],"source_content_type":"text/x-properties","patch_set":3,"id":"85ee6eb5_13fb6876","line":56,"updated":"2023-10-19 19:00:56.000000000","message":"please don\u0027t remove the -W, it is not needed with the stein fix.\nalso add here:\n\n-r{toxinidir}/requirements.txt\n\nto install all requirements in advance with the proper constraints, otherwise dependencies will be installed without constraints in another tox phase, which could result errors sooner or later.","commit_id":"42557498acd5e382c0a4e5539dfa407d3f401838"}]}