)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"26406bb193dba46457e3fb83208d867235f32a98","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f3faabbc_37bee1fc","updated":"2024-07-18 10:23:46.000000000","message":"-1 just for the question","commit_id":"cf08c4ed605cf6bc587036b5bccb5f88c55f43ab"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"1844f2ff20c5f5d4476cb5d23b93d8ad7a805460","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6b4b9454_8eecfe86","updated":"2024-07-22 11:31:33.000000000","message":"thanks for reviewing, I added some lines to the commit msg","commit_id":"cf08c4ed605cf6bc587036b5bccb5f88c55f43ab"}],"neutron_taas/services/taas/drivers/linux/ovs_taas.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"26406bb193dba46457e3fb83208d867235f32a98","unresolved":true,"context_lines":[{"line_number":282,"context_line":"        vif_details \u003d port.get(\u0027binding:vif_details\u0027)"},{"line_number":283,"context_line":"        is_hybrid_plug \u003d vif_details.get(\u0027ovs_hybrid_plug\u0027)"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"        if is_hybrid_plug:"},{"line_number":286,"context_line":"            ovs_port_name \u003d ovs_port.port_name"},{"line_number":287,"context_line":"            linux_br_name \u003d ovs_port_name.replace(\u0027qvo\u0027, \u0027qbr\u0027)"},{"line_number":288,"context_line":"            utils.execute([\u0027ip\u0027, \u0027link\u0027, \u0027set\u0027, linux_br_name,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ed6e623_30a67e48","line":285,"range":{"start_line":285,"start_character":11,"end_line":285,"end_character":25},"updated":"2024-07-18 10:23:46.000000000","message":"I think your patch is correct and what was added in [1] not, but can you explain why?\n\n[1]https://review.opendev.org/c/openstack/tap-as-a-service/+/884239","commit_id":"cf08c4ed605cf6bc587036b5bccb5f88c55f43ab"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"1844f2ff20c5f5d4476cb5d23b93d8ad7a805460","unresolved":true,"context_lines":[{"line_number":282,"context_line":"        vif_details \u003d port.get(\u0027binding:vif_details\u0027)"},{"line_number":283,"context_line":"        is_hybrid_plug \u003d vif_details.get(\u0027ovs_hybrid_plug\u0027)"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"        if is_hybrid_plug:"},{"line_number":286,"context_line":"            ovs_port_name \u003d ovs_port.port_name"},{"line_number":287,"context_line":"            linux_br_name \u003d ovs_port_name.replace(\u0027qvo\u0027, \u0027qbr\u0027)"},{"line_number":288,"context_line":"            utils.execute([\u0027ip\u0027, \u0027link\u0027, \u0027set\u0027, linux_br_name,"}],"source_content_type":"text/x-python","patch_set":2,"id":"86dda6a9_b056ce34","line":285,"range":{"start_line":285,"start_character":11,"end_line":285,"end_character":25},"in_reply_to":"9ed6e623_30a67e48","updated":"2024-07-22 11:31:33.000000000","message":"The ageing setting is necessary only if taas is in a setup where the hybrid firewall driver is used, to make it worse it will fail with exception as the bridge is not there to do any changes on it (originally the command used here was brctl: https://review.opendev.org/c/openstack/tap-as-a-service/+/886532/1/neutron_taas/services/taas/drivers/linux/ovs_taas.py and in case of pure OVS agent with OVS fw that will clearly fail as no bridge-utils is on the host in a nice deployment).\nSo widening this condition to anything that is not hybrid fw driver setup is wrong.","commit_id":"cf08c4ed605cf6bc587036b5bccb5f88c55f43ab"}]}