)]}'
{"neutron_taas/extensions/tap_mirror_both_direction.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e3d9ac734b24900e2be07f67e93a30aefe50dbbd","unresolved":true,"context_lines":[{"line_number":18,"context_line":"from neutron_lib.api.definitions import tap_mirror"},{"line_number":19,"context_line":"from neutron_lib.api import extensions as api_extensions"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"ALIAS \u003d \u0027tap-mirror-both-direction\u0027"},{"line_number":22,"context_line":"IS_SHIM_EXTENSION \u003d False"},{"line_number":23,"context_line":"IS_STANDARD_ATTR_EXTENSION \u003d False"},{"line_number":24,"context_line":"NAME \u003d \"Tap as a Service mirror with BOTH direction support\""}],"source_content_type":"text/x-python","patch_set":3,"id":"7de5910a_c9d338af","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":5},"updated":"2025-12-17 11:24:06.000000000","message":"nit: we will merge the n-lib soon and make a new release. Please add a comment here or wait for the n-lib release","commit_id":"227476f66e0ab2b72565e18cc95c0f74f501907c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e5f04eddc880f687071d03e5c2bc743e1f258304","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from neutron_lib.api.definitions import tap_mirror"},{"line_number":19,"context_line":"from neutron_lib.api import extensions as api_extensions"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"ALIAS \u003d \u0027tap-mirror-both-direction\u0027"},{"line_number":22,"context_line":"IS_SHIM_EXTENSION \u003d False"},{"line_number":23,"context_line":"IS_STANDARD_ATTR_EXTENSION \u003d False"},{"line_number":24,"context_line":"NAME \u003d \"Tap as a Service mirror with BOTH direction support\""}],"source_content_type":"text/x-python","patch_set":3,"id":"8e6f7024_ef3c57eb","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":5},"in_reply_to":"6e650362_2f4c7840","updated":"2025-12-19 07:26:00.000000000","message":"My bad, I didn\u0027t see comment in L46","commit_id":"227476f66e0ab2b72565e18cc95c0f74f501907c"},{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"6b5128ce0a93ccb3865deaffa5f7f130e08a1e55","unresolved":true,"context_lines":[{"line_number":18,"context_line":"from neutron_lib.api.definitions import tap_mirror"},{"line_number":19,"context_line":"from neutron_lib.api import extensions as api_extensions"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"ALIAS \u003d \u0027tap-mirror-both-direction\u0027"},{"line_number":22,"context_line":"IS_SHIM_EXTENSION \u003d False"},{"line_number":23,"context_line":"IS_STANDARD_ATTR_EXTENSION \u003d False"},{"line_number":24,"context_line":"NAME \u003d \"Tap as a Service mirror with BOTH direction support\""}],"source_content_type":"text/x-python","patch_set":3,"id":"b645bf5a_1166f4d8","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":5},"in_reply_to":"7de5910a_c9d338af","updated":"2025-12-17 13:55:44.000000000","message":"There is a comment on L46 about this but I guess we can wait for the new package if it will be there soon","commit_id":"227476f66e0ab2b72565e18cc95c0f74f501907c"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"31c6784a2903a42e364a86c18a874641fa25da0b","unresolved":true,"context_lines":[{"line_number":18,"context_line":"from neutron_lib.api.definitions import tap_mirror"},{"line_number":19,"context_line":"from neutron_lib.api import extensions as api_extensions"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"ALIAS \u003d \u0027tap-mirror-both-direction\u0027"},{"line_number":22,"context_line":"IS_SHIM_EXTENSION \u003d False"},{"line_number":23,"context_line":"IS_STANDARD_ATTR_EXTENSION \u003d False"},{"line_number":24,"context_line":"NAME \u003d \"Tap as a Service mirror with BOTH direction support\""}],"source_content_type":"text/x-python","patch_set":3,"id":"6e650362_2f4c7840","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":5},"in_reply_to":"b645bf5a_1166f4d8","updated":"2025-12-17 14:47:37.000000000","message":"I would not wait with this one for the neutron-lib patch. IMHO it will be easier for d/s backport to merge this one and then propose new patch in master branch to use api definition from neutron_lib","commit_id":"227476f66e0ab2b72565e18cc95c0f74f501907c"}],"neutron_taas/services/taas/tap_mirror_plugin.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e3d9ac734b24900e2be07f67e93a30aefe50dbbd","unresolved":true,"context_lines":[{"line_number":38,"context_line":"class TapMirrorPlugin(tap_mirror_db.Taas_mirror_db_mixin):"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    supported_extension_aliases \u003d [t_m_api_def.ALIAS,"},{"line_number":41,"context_line":"                                   t_m_b_api_def.ALIAS]"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    path_prefix \u003d \"/taas\""},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"860d4938_9755102e","line":41,"range":{"start_line":41,"start_character":53,"end_line":41,"end_character":55},"updated":"2025-12-17 11:24:06.000000000","message":"nit: in order to keep the git history, is better to add an extra line:\n```\n    supported_extension_aliases \u003d [t_m_api_def.ALIAS,\n                                   t_m_b_api_def.ALIAS,\n                                   ]\n```","commit_id":"227476f66e0ab2b72565e18cc95c0f74f501907c"},{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"7059fea802797519ffc43d16d9bc4f5ea15491c5","unresolved":false,"context_lines":[{"line_number":38,"context_line":"class TapMirrorPlugin(tap_mirror_db.Taas_mirror_db_mixin):"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    supported_extension_aliases \u003d [t_m_api_def.ALIAS,"},{"line_number":41,"context_line":"                                   t_m_b_api_def.ALIAS]"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    path_prefix \u003d \"/taas\""},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1bfd8047_a3131ef1","line":41,"range":{"start_line":41,"start_character":53,"end_line":41,"end_character":55},"in_reply_to":"860d4938_9755102e","updated":"2025-12-17 14:25:36.000000000","message":"Done","commit_id":"227476f66e0ab2b72565e18cc95c0f74f501907c"}]}
