)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"121eb1ad5bc223c850c0bbc01ad7dcb35556cf43","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"44dce8af_cdc6ff3c","updated":"2026-02-10 16:22:24.000000000","message":"Just one question","commit_id":"0ae13a85c41b2e099fa6c2f509688d17c8965d71"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"17ce2c2dd3d6ff6b5763b9d38be4ca0339c11fc3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c9eecd72_683b7de9","updated":"2026-02-26 17:51:12.000000000","message":"This same job failed in the other open TaaS change as well, not sure if that was a coincidence?\n\nLooking around I did see some tracebacks in the logs, opened https://bugs.launchpad.net/tap-as-a-service/+bug/2142779 but not sure it actually is causing the failure here.","commit_id":"0ae13a85c41b2e099fa6c2f509688d17c8965d71"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d7aeffa8651eeec24e8b6161b238b50089a17e73","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ad2ee74a_40f79154","updated":"2026-03-03 07:45:34.000000000","message":"recheck neutron-tempest-plugin-tap-as-a-service","commit_id":"0ae13a85c41b2e099fa6c2f509688d17c8965d71"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"3031d6878525939dbcfa98a544d00e5bcda9d4dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6dd5ee5d_566cf00d","updated":"2026-02-06 08:53:04.000000000","message":"yeah, makes sense to have clear http response","commit_id":"0ae13a85c41b2e099fa6c2f509688d17c8965d71"}],"neutron_taas/services/taas/taas_plugin.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"121eb1ad5bc223c850c0bbc01ad7dcb35556cf43","unresolved":true,"context_lines":[{"line_number":107,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":108,"context_line":"                LOG.error(\"Failed to create tap service on driver,\""},{"line_number":109,"context_line":"                          \"deleting tap_service %s\", ts[\u0027id\u0027])"},{"line_number":110,"context_line":"                super().delete_tap_service(context, ts[\u0027id\u0027])"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        return ts"},{"line_number":113,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"664a4570_6720efe0","side":"PARENT","line":110,"updated":"2026-02-10 16:22:24.000000000","message":"The only difference I see here and one place below is the cleanup is removed, is that not required if just a precommit has happened?","commit_id":"e83c8fafa924953aa0a944c91de51b7ca3375a62"},{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"7ef7b5c2efea73ac9e237e938be39da541d3bb19","unresolved":true,"context_lines":[{"line_number":107,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":108,"context_line":"                LOG.error(\"Failed to create tap service on driver,\""},{"line_number":109,"context_line":"                          \"deleting tap_service %s\", ts[\u0027id\u0027])"},{"line_number":110,"context_line":"                super().delete_tap_service(context, ts[\u0027id\u0027])"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        return ts"},{"line_number":113,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fe2b720f_97755913","side":"PARENT","line":110,"in_reply_to":"664a4570_6720efe0","updated":"2026-02-12 14:07:25.000000000","message":"the `super().delete_tap_service` will call the Neutron DB to delete the service. But I dont see a need to do that since any exception in this method will cause DB context manager to roll back the commit. \nOr maybe I am misunderstanding your comment :)","commit_id":"e83c8fafa924953aa0a944c91de51b7ca3375a62"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b9e23d085c3dbd6d1b9ab41085d00e856a874d4a","unresolved":false,"context_lines":[{"line_number":107,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":108,"context_line":"                LOG.error(\"Failed to create tap service on driver,\""},{"line_number":109,"context_line":"                          \"deleting tap_service %s\", ts[\u0027id\u0027])"},{"line_number":110,"context_line":"                super().delete_tap_service(context, ts[\u0027id\u0027])"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        return ts"},{"line_number":113,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"8c3212f1_acdb58a6","side":"PARENT","line":110,"in_reply_to":"fe2b720f_97755913","updated":"2026-02-26 15:38:23.000000000","message":"No, that answered my question, forgot about the context manager, guess these cleanups here were not necessary.","commit_id":"e83c8fafa924953aa0a944c91de51b7ca3375a62"}]}