)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"0c69eaf3c1691201dfd8bf37084d27c7f64c2879","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d303edc0_c140578d","updated":"2026-09-01 12:19:00.000000000","message":"it didn\u0027t work in my test change https://review.opendev.org/c/openstack/octavia/+/1002621\n\nbut it looks like the depends-on didn\u0027t work, it pulled taskflow master, I\u0027ll test it manually","commit_id":"d5ceeec594130d21d33a7b3e4e541ac0a3050211"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"3926362f0bce0f27c990b9cee3736b27d3421186","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d4b8e694_3c84435c","in_reply_to":"d303edc0_c140578d","updated":"2026-09-01 12:40:04.000000000","message":"it works in my env","commit_id":"d5ceeec594130d21d33a7b3e4e541ac0a3050211"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0f79efa4d9209c828f22871459375b1663ebc916","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"668ed455_14446482","updated":"2026-09-15 03:34:21.000000000","message":"The change looks almost good to me. jut one uggestion inline.","commit_id":"8c9be7a4f62979b97ac4b2a935e2be3fe00cba25"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"8828aaae9bcee293bdf1287ab1a70a8f63c89f9b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"7b0031b4_a25c30a3","updated":"2026-10-05 06:47:53.000000000","message":"Thanks for updating the patch! LGTM","commit_id":"9f4767be0c04fd4c899ff23f1811c9ffa4764991"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"acfebbf3410377fec93689bd91fb1a127ead98a4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"d34ce3bb_5a6161ee","updated":"2026-10-03 18:09:41.000000000","message":"recheck","commit_id":"9f4767be0c04fd4c899ff23f1811c9ffa4764991"}],"taskflow/jobs/backends/impl_redis.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"63d2147937dd0ae7a9058f9c7bc0e98b3cf4ac36","unresolved":true,"context_lines":[{"line_number":614,"context_line":"        # notifications (it has its own reconnection logic), so"},{"line_number":615,"context_line":"        # disable the probe entirely to avoid flooding logs."},{"line_number":616,"context_line":"        # See: https://bugs.launchpad.net/taskflow/+bug/2155236"},{"line_number":617,"context_line":"        try:"},{"line_number":618,"context_line":"            from redis.maint_notifications import MaintNotificationsConfig"},{"line_number":619,"context_line":""},{"line_number":620,"context_line":"            client_conf.setdefault("}],"source_content_type":"text/x-python","patch_set":4,"id":"ca6e0d9d_f6f6fbcd","line":617,"updated":"2026-08-31 09:11:27.000000000","message":"8.0.0 is out since May and supports Python 3.10+ (meaning it\u0027s fully compatible with us). Would it make to just bump our minimum and drop this try-except logic?","commit_id":"56a811b52e3a5649424a0713d157959b94144de7"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"a6e9a919fe5cafd1bab58a1308ead6a17898c31f","unresolved":false,"context_lines":[{"line_number":614,"context_line":"        # notifications (it has its own reconnection logic), so"},{"line_number":615,"context_line":"        # disable the probe entirely to avoid flooding logs."},{"line_number":616,"context_line":"        # See: https://bugs.launchpad.net/taskflow/+bug/2155236"},{"line_number":617,"context_line":"        try:"},{"line_number":618,"context_line":"            from redis.maint_notifications import MaintNotificationsConfig"},{"line_number":619,"context_line":""},{"line_number":620,"context_line":"            client_conf.setdefault("}],"source_content_type":"text/x-python","patch_set":4,"id":"0bdc1ca4_3738ef42","line":617,"in_reply_to":"ca6e0d9d_f6f6fbcd","updated":"2026-09-01 09:00:55.000000000","message":"Done","commit_id":"56a811b52e3a5649424a0713d157959b94144de7"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0f79efa4d9209c828f22871459375b1663ebc916","unresolved":true,"context_lines":[{"line_number":619,"context_line":"        # notifications (it has its own reconnection logic), so"},{"line_number":620,"context_line":"        # disable the probe entirely to avoid flooding logs."},{"line_number":621,"context_line":"        # See: https://bugs.launchpad.net/taskflow/+bug/2155236"},{"line_number":622,"context_line":"        from redis.maint_notifications import MaintNotificationsConfig"},{"line_number":623,"context_line":""},{"line_number":624,"context_line":"        client_conf.setdefault("},{"line_number":625,"context_line":"            \u0027maint_notifications_config\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3c8f7bbf_40db7085","line":622,"range":{"start_line":622,"start_character":8,"end_line":622,"end_character":70},"updated":"2026-09-15 03:34:21.000000000","message":"Can we import this at top-level now because import is not conditional now ?","commit_id":"8c9be7a4f62979b97ac4b2a935e2be3fe00cba25"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"acfebbf3410377fec93689bd91fb1a127ead98a4","unresolved":false,"context_lines":[{"line_number":619,"context_line":"        # notifications (it has its own reconnection logic), so"},{"line_number":620,"context_line":"        # disable the probe entirely to avoid flooding logs."},{"line_number":621,"context_line":"        # See: https://bugs.launchpad.net/taskflow/+bug/2155236"},{"line_number":622,"context_line":"        from redis.maint_notifications import MaintNotificationsConfig"},{"line_number":623,"context_line":""},{"line_number":624,"context_line":"        client_conf.setdefault("},{"line_number":625,"context_line":"            \u0027maint_notifications_config\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"15180139_511115ab","line":622,"range":{"start_line":622,"start_character":8,"end_line":622,"end_character":70},"in_reply_to":"2accb515_b5d957ce","updated":"2026-10-03 18:09:41.000000000","message":"Done","commit_id":"8c9be7a4f62979b97ac4b2a935e2be3fe00cba25"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0a3d512c3b07e8d8f04cc72ef0e0e57a1b8daf41","unresolved":true,"context_lines":[{"line_number":619,"context_line":"        # notifications (it has its own reconnection logic), so"},{"line_number":620,"context_line":"        # disable the probe entirely to avoid flooding logs."},{"line_number":621,"context_line":"        # See: https://bugs.launchpad.net/taskflow/+bug/2155236"},{"line_number":622,"context_line":"        from redis.maint_notifications import MaintNotificationsConfig"},{"line_number":623,"context_line":""},{"line_number":624,"context_line":"        client_conf.setdefault("},{"line_number":625,"context_line":"            \u0027maint_notifications_config\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"2accb515_b5d957ce","line":622,"range":{"start_line":622,"start_character":8,"end_line":622,"end_character":70},"in_reply_to":"3c8f7bbf_40db7085","updated":"2026-09-15 21:06:08.000000000","message":"Agreed. Also, let\u0027s import the module, not the object.","commit_id":"8c9be7a4f62979b97ac4b2a935e2be3fe00cba25"}],"taskflow/tests/unit/jobs/test_redis_job.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"63d2147937dd0ae7a9058f9c7bc0e98b3cf4ac36","unresolved":true,"context_lines":[{"line_number":27,"context_line":"from taskflow.utils import persistence_utils as p_utils"},{"line_number":28,"context_line":"from taskflow.utils import redis_utils as ru"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# redis-py 8.0+ support for maintenance notifications config"},{"line_number":31,"context_line":"try:"},{"line_number":32,"context_line":"    from redis.maint_notifications import MaintNotificationsConfig"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7c788cd8_4a48c312","line":30,"updated":"2026-08-31 09:11:27.000000000","message":"Same comment around bumping the `redis` dep","commit_id":"56a811b52e3a5649424a0713d157959b94144de7"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"a6e9a919fe5cafd1bab58a1308ead6a17898c31f","unresolved":false,"context_lines":[{"line_number":27,"context_line":"from taskflow.utils import persistence_utils as p_utils"},{"line_number":28,"context_line":"from taskflow.utils import redis_utils as ru"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# redis-py 8.0+ support for maintenance notifications config"},{"line_number":31,"context_line":"try:"},{"line_number":32,"context_line":"    from redis.maint_notifications import MaintNotificationsConfig"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"24a1da45_37844bb0","line":30,"in_reply_to":"7c788cd8_4a48c312","updated":"2026-09-01 09:00:55.000000000","message":"Done","commit_id":"56a811b52e3a5649424a0713d157959b94144de7"}]}