)]}'
{"taskflow/engines/action_engine/task_action.py":[{"author":{"_account_id":7366,"name":"Ivan Melnikov","email":"imelnikov@griddynamics.com","username":"imelnikov"},"change_message_id":"d44b6c4b554e6bd55d36a780eca24a9586b2eda1","unresolved":false,"context_lines":[{"line_number":39,"context_line":"            if state \u003d\u003d old_state:"},{"line_number":40,"context_line":"                if progress is None:"},{"line_number":41,"context_line":"                    return"},{"line_number":42,"context_line":"                old_progress \u003d self._storage.get_task_progress(task.name)"},{"line_number":43,"context_line":"                if old_progress \u003d\u003d progress:"},{"line_number":44,"context_line":"                    return"},{"line_number":45,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_7e2eb7a6","line":42,"updated":"2014-06-18 07:56:53.000000000","message":"I don\u0027t exactly like what I have done with progress here, but I believe this is what should be done: clients should not get spurious notification of changing state from PENDING to PENDING about tasks we did not ever touched.","commit_id":"ef97638a06cf3e6512a317c2469cab57cf70daa0"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"ccd7c45bd7feed956fa2775e9ac16454641f6986","unresolved":false,"context_lines":[{"line_number":39,"context_line":"            if state \u003d\u003d old_state:"},{"line_number":40,"context_line":"                if progress is None:"},{"line_number":41,"context_line":"                    return"},{"line_number":42,"context_line":"                old_progress \u003d self._storage.get_task_progress(task.name)"},{"line_number":43,"context_line":"                if old_progress \u003d\u003d progress:"},{"line_number":44,"context_line":"                    return"},{"line_number":45,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_e374d89d","line":42,"in_reply_to":"1ae5cdf2_7e2eb7a6","updated":"2014-06-18 17:54:37.000000000","message":"That\u0027s fair, do u want to add a comment that contains the above test just so future readers can understand your thinking there.","commit_id":"ef97638a06cf3e6512a317c2469cab57cf70daa0"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"ccd7c45bd7feed956fa2775e9ac16454641f6986","unresolved":false,"context_lines":[{"line_number":42,"context_line":"                old_progress \u003d self._storage.get_task_progress(task.name)"},{"line_number":43,"context_line":"                if old_progress \u003d\u003d progress:"},{"line_number":44,"context_line":"                    return"},{"line_number":45,"context_line":"                return"},{"line_number":46,"context_line":"            self._storage.set_atom_state(task.name, state)"},{"line_number":47,"context_line":"        if progress is not None:"},{"line_number":48,"context_line":"            self._storage.set_task_progress(task.name, progress)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_0388e46f","line":45,"updated":"2014-06-18 17:54:37.000000000","message":"Do we need the above progress checks if we always return anyway? A little bit confused by that, so many returns :-P","commit_id":"ef97638a06cf3e6512a317c2469cab57cf70daa0"},{"author":{"_account_id":7366,"name":"Ivan Melnikov","email":"imelnikov@griddynamics.com","username":"imelnikov"},"change_message_id":"fac8f4eecd22881bfc1f7cf921988f2264a8855c","unresolved":false,"context_lines":[{"line_number":42,"context_line":"                old_progress \u003d self._storage.get_task_progress(task.name)"},{"line_number":43,"context_line":"                if old_progress \u003d\u003d progress:"},{"line_number":44,"context_line":"                    return"},{"line_number":45,"context_line":"                return"},{"line_number":46,"context_line":"            self._storage.set_atom_state(task.name, state)"},{"line_number":47,"context_line":"        if progress is not None:"},{"line_number":48,"context_line":"            self._storage.set_task_progress(task.name, progress)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_1b603234","line":45,"in_reply_to":"1ae5cdf2_0388e46f","updated":"2014-06-19 07:17:32.000000000","message":"oops... Yes, too many returns, this one should be removed.","commit_id":"ef97638a06cf3e6512a317c2469cab57cf70daa0"}]}