)]}'
{"taskflow/engines/worker_based/dispatcher.py":[{"author":{"_account_id":9648,"name":"Greg Hill","email":"greg.hill@rackspace.com","username":"jimbobhickville"},"change_message_id":"b151077735d13768715b0e33cfa079730e607ee8","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        self._handlers \u003d dict(type_handlers)"},{"line_number":30,"context_line":"        self._requeue_callbacks \u003d []"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def add_requeue_callback(self, callback):"},{"line_number":33,"context_line":"        \"\"\"Add a callback that can force message requeuing."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        The callback will be activated before the message has been acked and"}],"source_content_type":"text/x-python","patch_set":12,"id":"1ae5cdf2_3e0a6f27","line":32,"updated":"2014-06-25 18:20:00.000000000","message":"Maybe it\u0027s just me, but \u0027requeue_callback\u0027 sounds like something that will be called if something is requeued, not to determine whether to requeue it. Maybe \u0027requeue_filter\u0027?","commit_id":"5da9f6df52152732690a53de7dc46f6e4c25ec9d"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"d4d9d900d727f88b031134e8e113cfc5fae096d4","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        self._handlers \u003d dict(type_handlers)"},{"line_number":30,"context_line":"        self._requeue_callbacks \u003d []"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def add_requeue_callback(self, callback):"},{"line_number":33,"context_line":"        \"\"\"Add a callback that can force message requeuing."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        The callback will be activated before the message has been acked and"}],"source_content_type":"text/x-python","patch_set":12,"id":"1ae5cdf2_aab9caed","line":32,"in_reply_to":"1ae5cdf2_3e0a6f27","updated":"2014-06-26 04:18:23.000000000","message":"Agreed, lets do that. Good idea.","commit_id":"5da9f6df52152732690a53de7dc46f6e4c25ec9d"},{"author":{"_account_id":8895,"name":"Stanislav Kudriashev","email":"stas.kudriashev@gmail.com","username":"skudriashev"},"change_message_id":"1be8394c2dd7e065cd56d03466f7e0c6e9f09796","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        self._requeue_callbacks.append(callback)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def _should_requeue(self, data, message):"},{"line_number":43,"context_line":"        if not self._requeue_callbacks:"},{"line_number":44,"context_line":"            return False"},{"line_number":45,"context_line":"        for callback in self._requeue_callbacks:"},{"line_number":46,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":12,"id":"1ae5cdf2_937be2f3","line":43,"updated":"2014-06-23 14:30:06.000000000","message":"Do you really need this check?","commit_id":"5da9f6df52152732690a53de7dc46f6e4c25ec9d"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"d4d9d900d727f88b031134e8e113cfc5fae096d4","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        self._requeue_callbacks.append(callback)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def _should_requeue(self, data, message):"},{"line_number":43,"context_line":"        if not self._requeue_callbacks:"},{"line_number":44,"context_line":"            return False"},{"line_number":45,"context_line":"        for callback in self._requeue_callbacks:"},{"line_number":46,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":12,"id":"1ae5cdf2_eaaf529b","line":43,"in_reply_to":"1ae5cdf2_937be2f3","updated":"2014-06-26 04:18:23.000000000","message":"Likely not, was a micro-optimization, can just remove.","commit_id":"5da9f6df52152732690a53de7dc46f6e4c25ec9d"},{"author":{"_account_id":9648,"name":"Greg Hill","email":"greg.hill@rackspace.com","username":"jimbobhickville"},"change_message_id":"b151077735d13768715b0e33cfa079730e607ee8","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        for callback in self._requeue_callbacks:"},{"line_number":46,"context_line":"            try:"},{"line_number":47,"context_line":"                if callback(data, message):"},{"line_number":48,"context_line":"                    return True"},{"line_number":49,"context_line":"            except Exception:"},{"line_number":50,"context_line":"                LOG.exception(\"Failed calling requeue check to determine\""},{"line_number":51,"context_line":"                              \" if message %r should be requeued.\","}],"source_content_type":"text/x-python","patch_set":12,"id":"1ae5cdf2_1e5a13f2","line":48,"updated":"2014-06-25 18:20:00.000000000","message":"I don\u0027t think you meant to short-circuit the loop here, as that would limit you to a single requeue check.","commit_id":"5da9f6df52152732690a53de7dc46f6e4c25ec9d"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"d4d9d900d727f88b031134e8e113cfc5fae096d4","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        for callback in self._requeue_callbacks:"},{"line_number":46,"context_line":"            try:"},{"line_number":47,"context_line":"                if callback(data, message):"},{"line_number":48,"context_line":"                    return True"},{"line_number":49,"context_line":"            except Exception:"},{"line_number":50,"context_line":"                LOG.exception(\"Failed calling requeue check to determine\""},{"line_number":51,"context_line":"                              \" if message %r should be requeued.\","}],"source_content_type":"text/x-python","patch_set":12,"id":"1ae5cdf2_aaa0eaa5","line":48,"in_reply_to":"1ae5cdf2_1e5a13f2","updated":"2014-06-26 04:18:23.000000000","message":"The first requed filter that says yes \u0027the message should be requeued\u0027  would make it not so useful to call additional ones. We can call all the others but as long as 1 callback said to requeue it activating the others doesn\u0027t seem so useful (?).","commit_id":"5da9f6df52152732690a53de7dc46f6e4c25ec9d"}]}