)]}'
{"taskflow/utils/deprecation.py":[{"author":{"_account_id":7366,"name":"Ivan Melnikov","email":"imelnikov@griddynamics.com","username":"imelnikov"},"change_message_id":"9eac1e9dbee10ba7a5c3e9810ae1bd86657b0f7f","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    # location."},{"line_number":63,"context_line":"    old_type \u003d type(old_class_name, (new_class,), {})"},{"line_number":64,"context_line":"    old_type.__module__ \u003d old_module_name"},{"line_number":65,"context_line":"    old_type.__init__ \u003d notifier(old_type.__init__)"},{"line_number":66,"context_line":"    return old_type"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ae5cdf2_57f0f990","line":65,"updated":"2014-06-25 21:24:27.000000000","message":"One of important (and almost only known) usage of misc.Failure outside of taskflow is \n\n    isinstance(result, misc.Failure)\n\nSo I\u0027m wondering if we could warn in this case, too, e.g. by overridding __subclasscheck__ and __instancecheck__, without making code too scary. Did you try something like that?","commit_id":"034b09a7215dd4a4fbdd05adbb5c4c8802cf8438"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"8af141d0dd29bd940d51d5fdad61c499021ce329","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    # location."},{"line_number":63,"context_line":"    old_type \u003d type(old_class_name, (new_class,), {})"},{"line_number":64,"context_line":"    old_type.__module__ \u003d old_module_name"},{"line_number":65,"context_line":"    old_type.__init__ \u003d notifier(old_type.__init__)"},{"line_number":66,"context_line":"    return old_type"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ae5cdf2_eb35a145","line":65,"in_reply_to":"1ae5cdf2_57f0f990","updated":"2014-06-25 22:12:03.000000000","message":"I thought about it; it doesn\u0027t make it to scary, just may cause a lot of messages being emitted. Lets try it and see how it goes (actually let me make it optional and only use it in the misc.Failure case).\n\nWe probably need to make people aware of the usage of:\n\n  import warnings\n  warnings.simplefilter(\u0027once\u0027, DeprecationWarning)\n\nThis will make sure cinder (or other) doesn\u0027t start dumping tons of messages due to taskflow usage.","commit_id":"034b09a7215dd4a4fbdd05adbb5c4c8802cf8438"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"4abddcc4ef7ff892284ea0e6ccf5e6328c714899","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    # location."},{"line_number":63,"context_line":"    old_type \u003d type(old_class_name, (new_class,), {})"},{"line_number":64,"context_line":"    old_type.__module__ \u003d old_module_name"},{"line_number":65,"context_line":"    old_type.__init__ \u003d notifier(old_type.__init__)"},{"line_number":66,"context_line":"    return old_type"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ae5cdf2_9f81b34f","line":65,"in_reply_to":"1ae5cdf2_eb35a145","updated":"2014-06-25 23:52:49.000000000","message":"Sooo I tried this, it seems like u can only override those 2 methods if we inject a metaclass into the class hierarchy, so I tried that, but was unable to make it actually work. \n\nWhat I tried (and a few other variations that tried doing something similar to what six is doing for its add_metaclass/with_metaclass methods),\n\nhttp://paste.openstack.org/show/84934/\n\nIt still seems to be calling the base types __instancecheck__ and not the one I defined, maybe we can add this in later, if can get it to work.","commit_id":"034b09a7215dd4a4fbdd05adbb5c4c8802cf8438"}]}
