)]}'
{"id":"openstack%2Ftaskflow~105633","triplet_id":"openstack%2Ftaskflow~master~I441d9767ea3005bb105958664a42e22c3f274d06","project":"openstack/taskflow","branch":"master","topic":"bug/1339406","hashtags":[],"change_id":"I441d9767ea3005bb105958664a42e22c3f274d06","subject":"Avoid comparison to active qsize when spawning new green workers","status":"ABANDONED","created":"2014-07-08 23:52:39.000000000","updated":"2014-07-10 00:00:27.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"88e596824ad582ecf63d689fa542447f24e3ac16","_number":105633,"virtual_id_number":105633,"owner":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":1,"date":"2014-07-09 00:54:29.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":8136,"name":"Viswa Vutharkar","email":"vpvutharkar@ebaysf.com","username":"vvutharkar"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"recommended":{"_account_id":8136,"name":"Viswa Vutharkar","email":"vpvutharkar@ebaysf.com","username":"vvutharkar"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2014-07-09 00:00:14.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":8136,"name":"Viswa Vutharkar","email":"vpvutharkar@ebaysf.com","username":"vvutharkar"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":8136,"name":"Viswa Vutharkar","email":"vpvutharkar@ebaysf.com","username":"vvutharkar"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":8136,"name":"Viswa Vutharkar","email":"vpvutharkar@ebaysf.com","username":"vvutharkar"}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":8136,"name":"Viswa Vutharkar","email":"vpvutharkar@ebaysf.com","username":"vvutharkar"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-07-09 00:00:14.000000000","updated_by":{"_account_id":8136,"name":"Viswa Vutharkar","email":"vpvutharkar@ebaysf.com","username":"vvutharkar"},"reviewer":{"_account_id":8136,"name":"Viswa Vutharkar","email":"vpvutharkar@ebaysf.com","username":"vvutharkar"},"state":"REVIEWER"},{"updated":"2014-07-09 00:54:29.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"954a9d838044a5a930e18d49ac76a9dda7d10124","author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"date":"2014-07-08 23:52:39.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"de1fc8255e876dad56a3a0eccef14f2ebb0135c2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-07-08 23:52:40.000000000","message":"Patch Set 1:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"a111a9f244747c45c9f63d3bf1876843ea86b437","author":{"_account_id":8136,"name":"Viswa Vutharkar","email":"vpvutharkar@ebaysf.com","username":"vvutharkar"},"date":"2014-07-08 23:58:19.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"c086adf444811af19dcd0f6fff8c4553e9b21d43","author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"date":"2014-07-08 23:58:59.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"6625e42b774a000e6b553e2d51a2d04e98c9c338","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-07-08 23:59:01.000000000","message":"Patch Set 2:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"cf3236c52a6a23f5b1763e8011e6a2990fc6b8c8","author":{"_account_id":8136,"name":"Viswa Vutharkar","email":"vpvutharkar@ebaysf.com","username":"vvutharkar"},"date":"2014-07-09 00:00:14.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"b39c33ae48b2d89e921cd2713e6bf008fd9ca479","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-07-09 00:54:29.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded.\n\n- gate-taskflow-pep8 http://logs.openstack.org/33/105633/2/check/gate-taskflow-pep8/26176c1 : SUCCESS in 1m 08s\n- gate-taskflow-docs http://docs-draft.openstack.org/33/105633/2/check/gate-taskflow-docs/4a0b413/doc/build/html/ : SUCCESS in 2m 07s\n- gate-taskflow-python26 http://logs.openstack.org/33/105633/2/check/gate-taskflow-python26/4c5b824 : SUCCESS in 3m 14s\n- gate-taskflow-python27 http://logs.openstack.org/33/105633/2/check/gate-taskflow-python27/de9d6e9 : SUCCESS in 2m 13s\n- gate-taskflow-python33 http://logs.openstack.org/33/105633/2/check/gate-taskflow-python33/be72dd6 : SUCCESS in 4m 30s\n- check-tempest-dsvm-full http://logs.openstack.org/33/105633/2/check/check-tempest-dsvm-full/2b1b53b : SUCCESS in 43m 50s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/33/105633/2/check/check-tempest-dsvm-postgres-full/0f48187 : SUCCESS in 37m 57s\n- check-tempest-dsvm-neutron http://logs.openstack.org/33/105633/2/check/check-tempest-dsvm-neutron/2b89316 : SUCCESS in 55m 24s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/33/105633/2/check/check-tempest-dsvm-neutron-heat-slow/721a23c : SUCCESS in 23m 38s\n- check-grenade-dsvm http://logs.openstack.org/33/105633/2/check/check-grenade-dsvm/c1ad719 : SUCCESS in 40m 34s\n- gate-taskflow-tox-py26-sa7-mysql http://logs.openstack.org/33/105633/2/check/gate-taskflow-tox-py26-sa7-mysql/85b4d3d : SUCCESS in 2m 32s\n- gate-taskflow-tox-py27-sa8-mysql http://logs.openstack.org/33/105633/2/check/gate-taskflow-tox-py27-sa8-mysql/5418c72 : SUCCESS in 1m 37s","accounts_in_message":[],"_revision_number":2},{"id":"ce0e8507a36cb8aaf97e228961a7e75528691391","author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"date":"2014-07-10 00:00:27.000000000","message":"Abandoned\n\nFixing in https://review.openstack.org/#/c/105922/ which is a better solution and better usage of greenthreads (and a needed adjustment anyway).","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"16c0890c100e76608fa276888c675dc3a4435e53","revisions":{"6b816051bb78ea6f516b5686a2e12d1bc9af3767":{"kind":"REWORK","_number":1,"created":"2014-07-08 23:52:39.000000000","uploader":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"ref":"refs/changes/33/105633/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/taskflow","ref":"refs/changes/33/105633/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/33/105633/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/33/105633/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/33/105633/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/taskflow refs/changes/33/105633/1"}}},"commit":{"parents":[{"commit":"e4810f0d3129a07d116f21136fe8f504fb922b1c","subject":"Merge \"Remove pbr as a runtime dependency\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/e4810f0d3129a07d116f21136fe8f504fb922b1c"}]}],"author":{"name":"Joshua harlow","email":"harlowja@buildingbuild.corp.yahoo.com","date":"2014-07-08 23:48:08.000000000","tz":-420},"committer":{"name":"Joshua Harlow","email":"harlowja@yahoo-inc.com","date":"2014-07-08 23:52:06.000000000","tz":-420},"subject":"Avoid comparison to active qsize when spawning new green workers","message":"Avoid comparison to active qsize when spawning new green workers\n\nWe should not be comparing to the current queue size when spawning\nup new workers as the comparision doesn\u0027t make logical sense and\ndegrades performance.\n\nFixes bug 1339406\n\nChange-Id: I441d9767ea3005bb105958664a42e22c3f274d06\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/6b816051bb78ea6f516b5686a2e12d1bc9af3767"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/6b816051bb78ea6f516b5686a2e12d1bc9af3767"}]},"branch":"refs/heads/master"},"16c0890c100e76608fa276888c675dc3a4435e53":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2014-07-08 23:58:59.000000000","uploader":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"ref":"refs/changes/33/105633/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/taskflow","ref":"refs/changes/33/105633/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/33/105633/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/33/105633/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/33/105633/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/taskflow refs/changes/33/105633/2"}}},"commit":{"parents":[{"commit":"e4810f0d3129a07d116f21136fe8f504fb922b1c","subject":"Merge \"Remove pbr as a runtime dependency\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/e4810f0d3129a07d116f21136fe8f504fb922b1c"}]}],"author":{"name":"Joshua harlow","email":"harlowja@yahoo-inc.com","date":"2014-07-08 23:48:08.000000000","tz":-420},"committer":{"name":"Joshua Harlow","email":"harlowja@yahoo-inc.com","date":"2014-07-08 23:58:54.000000000","tz":-420},"subject":"Avoid comparison to active qsize when spawning new green workers","message":"Avoid comparison to active qsize when spawning new green workers\n\nWe should not be comparing to the current queue size when spawning\nup new workers as the comparision doesn\u0027t make logical sense and\ndegrades performance (since it restricts the amount of workers\nadditions by the queue size, which is the reverse of what should\nactually be happening).\n\nFixes bug 1339406\n\nChange-Id: I441d9767ea3005bb105958664a42e22c3f274d06\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/16c0890c100e76608fa276888c675dc3a4435e53"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/16c0890c100e76608fa276888c675dc3a4435e53"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}