)]}'
{"taskflow/engines/action_engine/runner.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"85e40adf15527176e7b1ba969985df3151f49170","unresolved":false,"context_lines":[{"line_number":43,"context_line":"class _MachineBuilder(object):"},{"line_number":44,"context_line":"    \"\"\"State machine *builder* that the runner uses."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    NOTE(harlowja): the machine states that this build will for are::"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        +--------------+-----------+------------+----------+---------+"},{"line_number":49,"context_line":"        |    Start     |   Event   |    End     | On Enter | On Exit |"}],"source_content_type":"text/x-python","patch_set":20,"id":"1abeadc6_386b5d1f","line":46,"updated":"2014-08-27 20:49:06.000000000","message":"I think there\u0027s an extra or missing word in that sentence. It\u0027s not clear what you mean.","commit_id":"dc5061e2da7d41b9048270cd3d6eab951936c29c"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"85e40adf15527176e7b1ba969985df3151f49170","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        self._storage \u003d runtime.storage"},{"line_number":78,"context_line":"        self._waiter \u003d waiter"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def build(self, timeout\u003dNone):"},{"line_number":81,"context_line":"        memory \u003d _MachineMemory()"},{"line_number":82,"context_line":"        if timeout is None:"},{"line_number":83,"context_line":"            timeout \u003d _WAITING_TIMEOUT"}],"source_content_type":"text/x-python","patch_set":20,"id":"1abeadc6_4c669eee","line":80,"updated":"2014-08-27 20:49:06.000000000","message":"Why not just make the default for timeout\u003d_WAITING_TIMEOUT?","commit_id":"dc5061e2da7d41b9048270cd3d6eab951936c29c"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"13c74dd41884e4eee49ae24edc369051401faa42","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        self._storage \u003d runtime.storage"},{"line_number":78,"context_line":"        self._waiter \u003d waiter"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def build(self, timeout\u003dNone):"},{"line_number":81,"context_line":"        memory \u003d _MachineMemory()"},{"line_number":82,"context_line":"        if timeout is None:"},{"line_number":83,"context_line":"            timeout \u003d _WAITING_TIMEOUT"}],"source_content_type":"text/x-python","patch_set":20,"id":"1abeadc6_bb483db4","line":80,"in_reply_to":"1abeadc6_4c669eee","updated":"2014-08-28 05:01:08.000000000","message":"Isn\u0027t that logically different than checking if timeout is none.\n\nAka someone passes in timeout\u003dNone, expecting this code to work fine using the default timeout, now they just have overridden the default _WAITING_TIMEOUT with something invalid and we won\u0027t replace it with _WAITING_TIMEOUT due to that.","commit_id":"dc5061e2da7d41b9048270cd3d6eab951936c29c"}],"taskflow/types/fsm.py":[{"author":{"_account_id":9608,"name":"Pranesh Pandurangan","email":"praneshpg@gmail.com","username":"pran1990"},"change_message_id":"1508964260e87b06adad2ef58d7b740ffd7fa80f","unresolved":false,"context_lines":[{"line_number":109,"context_line":"                                \" undefined state \u0027%s\u0027\" % (event, state))"},{"line_number":110,"context_line":"        assert six.callable(reaction), \"Reaction callback must be callable\""},{"line_number":111,"context_line":"        if event not in self._states[state][\u0027reactions\u0027]:"},{"line_number":112,"context_line":"            self._states[state][\u0027reactions\u0027][event] \u003d (reaction, args, kwargs)"},{"line_number":113,"context_line":"        else:"},{"line_number":114,"context_line":"            raise excp.Duplicate(\"State \u0027%s\u0027 reaction to event \u0027%s\u0027\""},{"line_number":115,"context_line":"                                 \" already defined\" % (state, event))"}],"source_content_type":"text/x-python","patch_set":14,"id":"baada198_3037e3ff","line":112,"updated":"2014-07-25 07:08:18.000000000","message":"Maybe check args for the 3 params? Something like arg[0] in self.states, arg[1] ni self._states, etc","commit_id":"c28110faf85a928fd6b5a4c358b8e1b3a4264e85"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"3dfebd11ab9103acb61ad8841fe33d69639ea9a9","unresolved":false,"context_lines":[{"line_number":109,"context_line":"                                \" undefined state \u0027%s\u0027\" % (event, state))"},{"line_number":110,"context_line":"        assert six.callable(reaction), \"Reaction callback must be callable\""},{"line_number":111,"context_line":"        if event not in self._states[state][\u0027reactions\u0027]:"},{"line_number":112,"context_line":"            self._states[state][\u0027reactions\u0027][event] \u003d (reaction, args, kwargs)"},{"line_number":113,"context_line":"        else:"},{"line_number":114,"context_line":"            raise excp.Duplicate(\"State \u0027%s\u0027 reaction to event \u0027%s\u0027\""},{"line_number":115,"context_line":"                                 \" already defined\" % (state, event))"}],"source_content_type":"text/x-python","patch_set":14,"id":"baada198_b3bf5ac9","line":112,"in_reply_to":"baada198_3037e3ff","updated":"2014-07-25 23:23:11.000000000","message":"Sorry, likely something I should better reword, the reaction callback should expect to be provided 3 parameter, the extra *args and **kwargs will also be passed to the reaction callback (allow that callback to take additional parameters by default/automatically). Let me update the comment here to make that more clear since it will likely be a common confusion.","commit_id":"c28110faf85a928fd6b5a4c358b8e1b3a4264e85"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"85e40adf15527176e7b1ba969985df3151f49170","unresolved":false,"context_lines":[{"line_number":225,"context_line":"    @property"},{"line_number":226,"context_line":"    def states(self):"},{"line_number":227,"context_line":"        \"\"\"Returns the state names.\"\"\""},{"line_number":228,"context_line":"        return list(six.iterkeys(self._states))"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"    @property"},{"line_number":231,"context_line":"    def events(self):"}],"source_content_type":"text/x-python","patch_set":20,"id":"1abeadc6_4c113e51","line":228,"updated":"2014-08-27 20:49:06.000000000","message":"Should this be ordered?","commit_id":"dc5061e2da7d41b9048270cd3d6eab951936c29c"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"13c74dd41884e4eee49ae24edc369051401faa42","unresolved":false,"context_lines":[{"line_number":225,"context_line":"    @property"},{"line_number":226,"context_line":"    def states(self):"},{"line_number":227,"context_line":"        \"\"\"Returns the state names.\"\"\""},{"line_number":228,"context_line":"        return list(six.iterkeys(self._states))"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"    @property"},{"line_number":231,"context_line":"    def events(self):"}],"source_content_type":"text/x-python","patch_set":20,"id":"1abeadc6_7baea52f","line":228,"in_reply_to":"1abeadc6_4c113e51","updated":"2014-08-28 05:01:08.000000000","message":"Isn\u0027t it? (or is the question around should it be ordered, as in why is it ordered).","commit_id":"dc5061e2da7d41b9048270cd3d6eab951936c29c"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"85e40adf15527176e7b1ba969985df3151f49170","unresolved":false,"context_lines":[{"line_number":237,"context_line":""},{"line_number":238,"context_line":"    def __iter__(self):"},{"line_number":239,"context_line":"        \"\"\"Iterates over (start, event, end) transition tuples.\"\"\""},{"line_number":240,"context_line":"        for state in six.iterkeys(self._states):"},{"line_number":241,"context_line":"            for event, target in six.iteritems(self._transitions[state]):"},{"line_number":242,"context_line":"                yield (state, event, target.name)"},{"line_number":243,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"1abeadc6_4c385ed3","line":240,"updated":"2014-08-27 20:49:06.000000000","message":"Depending on how many items are being processed, itertools.product() could be more efficient here.","commit_id":"dc5061e2da7d41b9048270cd3d6eab951936c29c"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"13c74dd41884e4eee49ae24edc369051401faa42","unresolved":false,"context_lines":[{"line_number":237,"context_line":""},{"line_number":238,"context_line":"    def __iter__(self):"},{"line_number":239,"context_line":"        \"\"\"Iterates over (start, event, end) transition tuples.\"\"\""},{"line_number":240,"context_line":"        for state in six.iterkeys(self._states):"},{"line_number":241,"context_line":"            for event, target in six.iteritems(self._transitions[state]):"},{"line_number":242,"context_line":"                yield (state, event, target.name)"},{"line_number":243,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"1abeadc6_7b006534","line":240,"in_reply_to":"1abeadc6_4c385ed3","updated":"2014-08-28 05:01:08.000000000","message":"Cool, maybe a later change then for that.","commit_id":"dc5061e2da7d41b9048270cd3d6eab951936c29c"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"85e40adf15527176e7b1ba969985df3151f49170","unresolved":false,"context_lines":[{"line_number":241,"context_line":"            for event, target in six.iteritems(self._transitions[state]):"},{"line_number":242,"context_line":"                yield (state, event, target.name)"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"    def pformat(self, sort\u003dTrue):"},{"line_number":245,"context_line":"        \"\"\"Pretty formats the state + transition table into a string."},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"        NOTE(harlowja): the sort parameter can be provided to sort the states"}],"source_content_type":"text/x-python","patch_set":20,"id":"1abeadc6_38235dbe","line":244,"updated":"2014-08-27 20:49:06.000000000","message":"This looks useful for debugging. I wonder if it needs to be built into the class, making prettytable a runtime dependency.","commit_id":"dc5061e2da7d41b9048270cd3d6eab951936c29c"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"13c74dd41884e4eee49ae24edc369051401faa42","unresolved":false,"context_lines":[{"line_number":241,"context_line":"            for event, target in six.iteritems(self._transitions[state]):"},{"line_number":242,"context_line":"                yield (state, event, target.name)"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"    def pformat(self, sort\u003dTrue):"},{"line_number":245,"context_line":"        \"\"\"Pretty formats the state + transition table into a string."},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"        NOTE(harlowja): the sort parameter can be provided to sort the states"}],"source_content_type":"text/x-python","patch_set":20,"id":"1abeadc6_9b90e1ee","line":244,"in_reply_to":"1abeadc6_38235dbe","updated":"2014-08-28 05:01:08.000000000","message":"Hard to say what it will be used for, likely primarily debugging, of course could conditionally import prettytable and barf if it isn\u0027t found. What do u think?","commit_id":"dc5061e2da7d41b9048270cd3d6eab951936c29c"}]}
