)]}'
{"taskflow/tests/unit/persistence/test_sql_persistence.py":[{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"9b3f3b6aa6ed0cd6afad249b76d062826d97eb89","unresolved":false,"context_lines":[{"line_number":161,"context_line":"            conf \u003d {"},{"line_number":162,"context_line":"                \u0027connection\u0027: self.db_uri"},{"line_number":163,"context_line":"            }"},{"line_number":164,"context_line":"        except Exception as e:"},{"line_number":165,"context_line":"            self.skipTest(\"Failed to reset your database;\""},{"line_number":166,"context_line":"                          \" testing being skipped due to: %s\" % (e))"},{"line_number":167,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_d63f6e84","line":164,"updated":"2014-08-10 21:13:53.000000000","message":"Should this except block go away? It doesn\u0027t seem applicable anymore (or the messaging at least doesn\u0027t seem applicable).","commit_id":"27b544cab518ca653ed2d4313c6df0694d716c39"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"1ca0d615533fe0e8a694b9d2f806e5968b0d9e99","unresolved":false,"context_lines":[{"line_number":161,"context_line":"            conf \u003d {"},{"line_number":162,"context_line":"                \u0027connection\u0027: self.db_uri"},{"line_number":163,"context_line":"            }"},{"line_number":164,"context_line":"        except Exception as e:"},{"line_number":165,"context_line":"            self.skipTest(\"Failed to reset your database;\""},{"line_number":166,"context_line":"                          \" testing being skipped due to: %s\" % (e))"},{"line_number":167,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_f9d9c584","line":164,"in_reply_to":"baada198_3647caa5","updated":"2014-08-11 00:03:34.000000000","message":"Sounds good to me.","commit_id":"27b544cab518ca653ed2d4313c6df0694d716c39"},{"author":{"_account_id":11913,"name":"Brian Jarrett","email":"celttechie@gmail.com","username":"celttechie"},"change_message_id":"da4293b1eb124419d11283af06d78428f5edc4f3","unresolved":false,"context_lines":[{"line_number":161,"context_line":"            conf \u003d {"},{"line_number":162,"context_line":"                \u0027connection\u0027: self.db_uri"},{"line_number":163,"context_line":"            }"},{"line_number":164,"context_line":"        except Exception as e:"},{"line_number":165,"context_line":"            self.skipTest(\"Failed to reset your database;\""},{"line_number":166,"context_line":"                          \" testing being skipped due to: %s\" % (e))"},{"line_number":167,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_3647caa5","line":164,"in_reply_to":"baada198_d63f6e84","updated":"2014-08-10 22:56:50.000000000","message":"_init_db for mysql will throw an error and skip the test if it can\u0027t find a working connection, but init_db for postgres does not.  I\u0027m thinking I should change this message to read \"Failed to create database;\" and then make sure _init_db for both cases raises an appropriate exception.","commit_id":"27b544cab518ca653ed2d4313c6df0694d716c39"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"9b3f3b6aa6ed0cd6afad249b76d062826d97eb89","unresolved":false,"context_lines":[{"line_number":219,"context_line":"            with contextlib.closing(engine.connect()) as conn:"},{"line_number":220,"context_line":"                conn.execute(\"DROP DATABASE IF EXISTS %s\" % DATABASE)"},{"line_number":221,"context_line":"        except Exception:"},{"line_number":222,"context_line":"            pass"},{"line_number":223,"context_line":"        finally:"},{"line_number":224,"context_line":"            if engine is not None:"},{"line_number":225,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_f647121c","line":222,"updated":"2014-08-10 21:13:53.000000000","message":"Should we log something here instead of silently dropping, what do u think?","commit_id":"27b544cab518ca653ed2d4313c6df0694d716c39"},{"author":{"_account_id":11913,"name":"Brian Jarrett","email":"celttechie@gmail.com","username":"celttechie"},"change_message_id":"da4293b1eb124419d11283af06d78428f5edc4f3","unresolved":false,"context_lines":[{"line_number":219,"context_line":"            with contextlib.closing(engine.connect()) as conn:"},{"line_number":220,"context_line":"                conn.execute(\"DROP DATABASE IF EXISTS %s\" % DATABASE)"},{"line_number":221,"context_line":"        except Exception:"},{"line_number":222,"context_line":"            pass"},{"line_number":223,"context_line":"        finally:"},{"line_number":224,"context_line":"            if engine is not None:"},{"line_number":225,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_f6d712be","line":222,"in_reply_to":"baada198_f647121c","updated":"2014-08-10 22:56:50.000000000","message":"Hmmm...  I can think of only one reason why we\u0027d get an exception at this point and that is if there is something seriously wrong with the sql server.\n\nAt this point what logging mechanism is appropriate?  Something testr provides?","commit_id":"27b544cab518ca653ed2d4313c6df0694d716c39"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"1ca0d615533fe0e8a694b9d2f806e5968b0d9e99","unresolved":false,"context_lines":[{"line_number":219,"context_line":"            with contextlib.closing(engine.connect()) as conn:"},{"line_number":220,"context_line":"                conn.execute(\"DROP DATABASE IF EXISTS %s\" % DATABASE)"},{"line_number":221,"context_line":"        except Exception:"},{"line_number":222,"context_line":"            pass"},{"line_number":223,"context_line":"        finally:"},{"line_number":224,"context_line":"            if engine is not None:"},{"line_number":225,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_f9c0e57e","line":222,"in_reply_to":"baada198_f6d712be","updated":"2014-08-11 00:03:34.000000000","message":"Maybe then we should just let the exception propagate to testr and then it will have a nice log of whatever it provides... Sound ok?","commit_id":"27b544cab518ca653ed2d4313c6df0694d716c39"}]}