)]}'
{"taskflow/engines/worker_based/protocol.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"c7e74449f66453307e147e90f53283e5f790a3ef","unresolved":false,"context_lines":[{"line_number":294,"context_line":"    def on_progress(self, event_data, progress):"},{"line_number":295,"context_line":"        self._progress_callback(self._task, event_data, progress)"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"    def transition_log_error(self, new_state, logger\u003dNone):"},{"line_number":298,"context_line":"        if logger is None:"},{"line_number":299,"context_line":"            logger \u003d LOG"},{"line_number":300,"context_line":"        moved \u003d False"}],"source_content_type":"text/x-python","patch_set":4,"id":"1abeadc6_3770d071","line":297,"updated":"2014-08-27 19:08:22.000000000","message":"Looking at the other file where this method is called, the name of the method didn\u0027t really tell me what it does. I thought it was transitioning a log or something. That\u0027s probably just me coming new to this code, but maybe transition_and_log_error() or transition_and_ignore_error() would be better names?","commit_id":"93de2260f12251069ae5c2b7b84a0805fe26941a"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"8b41d2e46481732c01402bf02cecd57b87568eb1","unresolved":false,"context_lines":[{"line_number":294,"context_line":"    def on_progress(self, event_data, progress):"},{"line_number":295,"context_line":"        self._progress_callback(self._task, event_data, progress)"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"    def transition_log_error(self, new_state, logger\u003dNone):"},{"line_number":298,"context_line":"        if logger is None:"},{"line_number":299,"context_line":"            logger \u003d LOG"},{"line_number":300,"context_line":"        moved \u003d False"}],"source_content_type":"text/x-python","patch_set":4,"id":"1abeadc6_db325ea6","line":297,"in_reply_to":"1abeadc6_3770d071","updated":"2014-08-28 00:15:00.000000000","message":"Good point, will followup with a better name.","commit_id":"93de2260f12251069ae5c2b7b84a0805fe26941a"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"c7e74449f66453307e147e90f53283e5f790a3ef","unresolved":false,"context_lines":[{"line_number":310,"context_line":"        \"\"\"Transitions the request to a new state."},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"        If transition was performed, it returns True. If transition"},{"line_number":313,"context_line":"        should was ignored, it returns False. If transition is not"},{"line_number":314,"context_line":"        valid (and will not be performed), it raises an InvalidState"},{"line_number":315,"context_line":"        exception."},{"line_number":316,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"1abeadc6_d796bc3d","line":313,"updated":"2014-08-27 19:08:22.000000000","message":"\"should be\" or just \"was\"?","commit_id":"93de2260f12251069ae5c2b7b84a0805fe26941a"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"8b41d2e46481732c01402bf02cecd57b87568eb1","unresolved":false,"context_lines":[{"line_number":310,"context_line":"        \"\"\"Transitions the request to a new state."},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"        If transition was performed, it returns True. If transition"},{"line_number":313,"context_line":"        should was ignored, it returns False. If transition is not"},{"line_number":314,"context_line":"        valid (and will not be performed), it raises an InvalidState"},{"line_number":315,"context_line":"        exception."},{"line_number":316,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"1abeadc6_fb239a55","line":313,"in_reply_to":"1abeadc6_d796bc3d","updated":"2014-08-28 00:15:00.000000000","message":"Done","commit_id":"93de2260f12251069ae5c2b7b84a0805fe26941a"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"03fcdac196abb720471493ca281ead721c23d693","unresolved":false,"context_lines":[{"line_number":310,"context_line":"        \"\"\"Transitions the request to a new state."},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"        If transition was performed, it returns True. If transition"},{"line_number":313,"context_line":"        should was ignored, it returns False. If transition is not"},{"line_number":314,"context_line":"        valid (and will not be performed), it raises an InvalidState"},{"line_number":315,"context_line":"        exception."},{"line_number":316,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"1abeadc6_7bc14a2e","line":313,"in_reply_to":"1abeadc6_d796bc3d","updated":"2014-08-28 00:25:46.000000000","message":"Think was is ok now that I look it over in more depth. Since this will tell check if its a valid transition and then perform it if it is ok to be done.","commit_id":"93de2260f12251069ae5c2b7b84a0805fe26941a"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"c7e74449f66453307e147e90f53283e5f790a3ef","unresolved":false,"context_lines":[{"line_number":312,"context_line":"        If transition was performed, it returns True. If transition"},{"line_number":313,"context_line":"        should was ignored, it returns False. If transition is not"},{"line_number":314,"context_line":"        valid (and will not be performed), it raises an InvalidState"},{"line_number":315,"context_line":"        exception."},{"line_number":316,"context_line":"        \"\"\""},{"line_number":317,"context_line":"        old_state \u003d self._state"},{"line_number":318,"context_line":"        if old_state \u003d\u003d new_state:"}],"source_content_type":"text/x-python","patch_set":4,"id":"1abeadc6_571d4cbd","line":315,"updated":"2014-08-27 19:08:22.000000000","message":"There are a lot of good docs for task flow. We should talk about the best way to add API reference docs (separate from this review, but thinking about the docstring for this method made me think of it).","commit_id":"93de2260f12251069ae5c2b7b84a0805fe26941a"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"8b41d2e46481732c01402bf02cecd57b87568eb1","unresolved":false,"context_lines":[{"line_number":312,"context_line":"        If transition was performed, it returns True. If transition"},{"line_number":313,"context_line":"        should was ignored, it returns False. If transition is not"},{"line_number":314,"context_line":"        valid (and will not be performed), it raises an InvalidState"},{"line_number":315,"context_line":"        exception."},{"line_number":316,"context_line":"        \"\"\""},{"line_number":317,"context_line":"        old_state \u003d self._state"},{"line_number":318,"context_line":"        if old_state \u003d\u003d new_state:"}],"source_content_type":"text/x-python","patch_set":4,"id":"1abeadc6_7b178aee","line":315,"in_reply_to":"1abeadc6_571d4cbd","updated":"2014-08-28 00:15:00.000000000","message":"Sure, let\u0027s chat. \n\nMore standard documenting params and such?","commit_id":"93de2260f12251069ae5c2b7b84a0805fe26941a"}]}