)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9608,"name":"Pranesh Pandurangan","email":"praneshpg@gmail.com","username":"pran1990"},"change_message_id":"20f3a6449c546a2e46a2938cd10b4302b9c000b7","unresolved":false,"context_lines":[{"line_number":15,"context_line":"   stop the action engines task executor (teenie niceness...)"},{"line_number":16,"context_line":"3. When the engine run_iter() is used and the generator that is"},{"line_number":17,"context_line":"   returned is closed, instead of breaking from the run loop, which"},{"line_number":18,"context_line":"   can leave running tasks uncompleted instead continue running and"},{"line_number":19,"context_line":"   signal to the runner that the engine has suspended itself. This"},{"line_number":20,"context_line":"   ensures that the running atoms are not lost when the generator from"},{"line_number":21,"context_line":"   run_iter() is closed (for whatever reason) before finishing."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1abeadc6_66c03c7d","line":18,"updated":"2014-08-25 20:19:23.000000000","message":"uncompleted -\u003e incomplete. Not important.","commit_id":"db378eb65b60d3ff5ac7de73dd6acee4d43b3b1a"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"f17f3b7974001305ffeea1321626d4e3ead07781","unresolved":false,"context_lines":[{"line_number":15,"context_line":"   stop the action engines task executor (teenie niceness...)"},{"line_number":16,"context_line":"3. When the engine run_iter() is used and the generator that is"},{"line_number":17,"context_line":"   returned is closed, instead of breaking from the run loop, which"},{"line_number":18,"context_line":"   can leave running tasks uncompleted instead continue running and"},{"line_number":19,"context_line":"   signal to the runner that the engine has suspended itself. This"},{"line_number":20,"context_line":"   ensures that the running atoms are not lost when the generator from"},{"line_number":21,"context_line":"   run_iter() is closed (for whatever reason) before finishing."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1abeadc6_189a7314","line":18,"in_reply_to":"1abeadc6_66c03c7d","updated":"2014-08-26 07:08:10.000000000","message":"Done","commit_id":"db378eb65b60d3ff5ac7de73dd6acee4d43b3b1a"}],"taskflow/engines/action_engine/engine.py":[{"author":{"_account_id":9608,"name":"Pranesh Pandurangan","email":"praneshpg@gmail.com","username":"pran1990"},"change_message_id":"20f3a6449c546a2e46a2938cd10b4302b9c000b7","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"@contextlib.contextmanager"},{"line_number":35,"context_line":"def _start_stop(executor):"},{"line_number":36,"context_line":"    # A teenie helper context manager to safely start/stop a executor..."},{"line_number":37,"context_line":"    executor.start()"},{"line_number":38,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"1abeadc6_866b9884","line":35,"updated":"2014-08-25 20:19:23.000000000","message":"There might be value in renaming this executor_start_stop, since this is ina  amodule called engine. Though I suspect that the only arg being executor makes it prettyu clear.","commit_id":"db378eb65b60d3ff5ac7de73dd6acee4d43b3b1a"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"f17f3b7974001305ffeea1321626d4e3ead07781","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"@contextlib.contextmanager"},{"line_number":35,"context_line":"def _start_stop(executor):"},{"line_number":36,"context_line":"    # A teenie helper context manager to safely start/stop a executor..."},{"line_number":37,"context_line":"    executor.start()"},{"line_number":38,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"1abeadc6_7888c7c6","line":35,"in_reply_to":"1abeadc6_866b9884","updated":"2014-08-26 07:08:10.000000000","message":"Ya, I\u0027m not sure the benefit of naming the function that and then also having an argument named that. Its meant to be a function not used elsewhere anyway (since it starts with a \u0027_\u0027) so I\u0027m not to worried about that name.","commit_id":"db378eb65b60d3ff5ac7de73dd6acee4d43b3b1a"}]}