)]}'
{"id":"openstack%2Ftaskflow~124242","triplet_id":"openstack%2Ftaskflow~master~I9eeb674f7064aaa02a99418ca2b33c99debcf6e1","project":"openstack/taskflow","branch":"master","topic":"bug/1365830","hashtags":[],"change_id":"I9eeb674f7064aaa02a99418ca2b33c99debcf6e1","subject":"Always return copies from memory backend","status":"ABANDONED","created":"2014-09-26 01:32:06.000000000","updated":"2014-09-27 01:11:38.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"eca97e5c6de33cd9aaa54ee33b6958a478b89504","_number":124242,"virtual_id_number":124242,"owner":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":1,"date":"2014-09-27 00:28:15.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-09-27 00:28:15.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"a2ced0a81f3b06fe2ae4182584dec0327ccc46c4","author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"date":"2014-09-26 01:32:06.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"eb21d7bf127683f439091fd5e2d9118ab4f40206","author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"date":"2014-09-26 01:35:14.000000000","message":"Patch Set 2: Commit message was updated","accounts_in_message":[],"_revision_number":2},{"id":"71502b5c4829fb919366abb065dfa55000a4fd48","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-09-26 03:15:51.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded.\n\n- gate-taskflow-pep8 http://logs.openstack.org/42/124242/2/check/gate-taskflow-pep8/996ffe3 : SUCCESS in 1m 12s\n- gate-taskflow-docs http://docs-draft.openstack.org/42/124242/2/check/gate-taskflow-docs/1f7fe3d/doc/build/html/ : SUCCESS in 1m 39s\n- gate-taskflow-python26 http://logs.openstack.org/42/124242/2/check/gate-taskflow-python26/313aac3 : SUCCESS in 2m 23s\n- gate-taskflow-python27 http://logs.openstack.org/42/124242/2/check/gate-taskflow-python27/4a00a6d : SUCCESS in 2m 17s\n- gate-taskflow-python33 http://logs.openstack.org/42/124242/2/check/gate-taskflow-python33/0671210 : SUCCESS in 3m 40s\n- check-tempest-dsvm-full http://logs.openstack.org/42/124242/2/check/check-tempest-dsvm-full/c584d02 : SUCCESS in 1h 01m 50s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/42/124242/2/check/check-tempest-dsvm-postgres-full/9eff656 : SUCCESS in 54m 04s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/42/124242/2/check/check-tempest-dsvm-neutron-full/924f95a : SUCCESS in 1h 12m 09s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/42/124242/2/check/check-tempest-dsvm-neutron-heat-slow/37f8a43 : SUCCESS in 25m 57s\n- check-grenade-dsvm http://logs.openstack.org/42/124242/2/check/check-grenade-dsvm/2c5fe9b : SUCCESS in 47m 02s\n- gate-taskflow-unittests-26-sa7-mysql http://logs.openstack.org/42/124242/2/check/gate-taskflow-unittests-26-sa7-mysql/9fdfccb : SUCCESS in 2m 18s\n- gate-taskflow-unittests-27-sa8-mysql http://logs.openstack.org/42/124242/2/check/gate-taskflow-unittests-27-sa8-mysql/9e3ae66 : SUCCESS in 1m 37s","accounts_in_message":[],"_revision_number":2},{"id":"d4cb637fa8f39536a17615b4ce94d6a0893b815d","author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"date":"2014-09-26 05:45:13.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"ac59f1e577f6252c8c5a0910cd64e5d7f4968d64","author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"date":"2014-09-26 06:40:54.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"4b5211ba6056ab7fc75b9b2fff85c95f63204c4b","author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"date":"2014-09-26 07:05:23.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"4faad0e72dbf91dd340c63d0501cd26a35a94b20","author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"date":"2014-09-26 07:26:20.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"40c9076b29eaceaaca86dc23af017d75b259f56d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-09-26 09:11:05.000000000","message":"Patch Set 6: Verified+1\n\nBuild succeeded.\n\n- gate-taskflow-pep8 http://logs.openstack.org/42/124242/6/check/gate-taskflow-pep8/a46c3f7 : SUCCESS in 1m 06s\n- gate-taskflow-docs http://docs-draft.openstack.org/42/124242/6/check/gate-taskflow-docs/15c1940/doc/build/html/ : SUCCESS in 1m 21s\n- gate-taskflow-python26 http://logs.openstack.org/42/124242/6/check/gate-taskflow-python26/727e489 : SUCCESS in 10m 11s\n- gate-taskflow-python27 http://logs.openstack.org/42/124242/6/check/gate-taskflow-python27/7b3db94 : SUCCESS in 1m 57s\n- gate-taskflow-python33 http://logs.openstack.org/42/124242/6/check/gate-taskflow-python33/ce02214 : SUCCESS in 3m 33s\n- check-tempest-dsvm-full http://logs.openstack.org/42/124242/6/check/check-tempest-dsvm-full/5424764 : SUCCESS in 44m 57s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/42/124242/6/check/check-tempest-dsvm-postgres-full/08e9348 : SUCCESS in 43m 15s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/42/124242/6/check/check-tempest-dsvm-neutron-full/6d23111 : SUCCESS in 1h 11m 21s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/42/124242/6/check/check-tempest-dsvm-neutron-heat-slow/e2d81ae : SUCCESS in 25m 31s\n- check-grenade-dsvm http://logs.openstack.org/42/124242/6/check/check-grenade-dsvm/59eb5c8 : SUCCESS in 49m 24s\n- gate-taskflow-unittests-26-sa7-mysql http://logs.openstack.org/42/124242/6/check/gate-taskflow-unittests-26-sa7-mysql/6fe396b : SUCCESS in 2m 11s\n- gate-taskflow-unittests-27-sa8-mysql http://logs.openstack.org/42/124242/6/check/gate-taskflow-unittests-27-sa8-mysql/9afb15c : SUCCESS in 2m 00s","accounts_in_message":[],"_revision_number":6},{"id":"fdfa2312a9d366bee9809faca1ecde0a1aa674ea","author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"date":"2014-09-26 21:28:07.000000000","message":"Uploaded patch set 7.","accounts_in_message":[],"_revision_number":7},{"id":"8cf51915bb7882dfcfe7f235f1693a1e1e14ab44","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-09-27 00:28:15.000000000","message":"Patch Set 7: Verified+1\n\nBuild succeeded.\n\n- gate-taskflow-pep8 http://logs.openstack.org/42/124242/7/check/gate-taskflow-pep8/5814cf2 : SUCCESS in 2m 11s\n- gate-taskflow-docs http://docs-draft.openstack.org/42/124242/7/check/gate-taskflow-docs/9e4416a/doc/build/html/ : SUCCESS in 3m 03s\n- gate-taskflow-python26 http://logs.openstack.org/42/124242/7/check/gate-taskflow-python26/a179223 : SUCCESS in 2m 11s\n- gate-taskflow-python27 http://logs.openstack.org/42/124242/7/check/gate-taskflow-python27/605dfe0 : SUCCESS in 1m 50s\n- gate-taskflow-python33 http://logs.openstack.org/42/124242/7/check/gate-taskflow-python33/72266c3 : SUCCESS in 3m 36s\n- check-tempest-dsvm-full http://logs.openstack.org/42/124242/7/check/check-tempest-dsvm-full/c525266 : SUCCESS in 56m 10s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/42/124242/7/check/check-tempest-dsvm-postgres-full/b534246 : SUCCESS in 57m 40s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/42/124242/7/check/check-tempest-dsvm-neutron-full/a2c8229 : SUCCESS in 59m 11s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/42/124242/7/check/check-tempest-dsvm-neutron-heat-slow/f3f398b : SUCCESS in 21m 28s\n- check-grenade-dsvm http://logs.openstack.org/42/124242/7/check/check-grenade-dsvm/7e9f718 : SUCCESS in 50m 34s\n- gate-taskflow-unittests-26-sa7-mysql http://logs.openstack.org/42/124242/7/check/gate-taskflow-unittests-26-sa7-mysql/78c5003 : SUCCESS in 2m 15s\n- gate-taskflow-unittests-27-sa8-mysql http://logs.openstack.org/42/124242/7/check/gate-taskflow-unittests-27-sa8-mysql/658f488 : SUCCESS in 1m 45s","accounts_in_message":[],"_revision_number":7},{"id":"cbbc9cdcb947764244e351bc75c28bdf3e811429","author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"date":"2014-09-27 01:11:38.000000000","message":"Abandoned\n\nMoved to https://review.openstack.org/#/c/124552/ which is nicer.","accounts_in_message":[],"_revision_number":7}],"current_revision_number":7,"current_revision":"b6d923991ca4e61e2da34ab4d82072b353b748c1","revisions":{"88273f57664d5409bcc4bfcb246320274f83f42c":{"kind":"REWORK","_number":1,"created":"2014-09-26 01:32:06.000000000","uploader":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"ref":"refs/changes/42/124242/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/taskflow","ref":"refs/changes/42/124242/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/42/124242/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/42/124242/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/42/124242/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/taskflow refs/changes/42/124242/1"}}},"commit":{"parents":[{"commit":"dbf117aaf5eaf59a8b5d3c0516add2b708ce3e73","subject":"Documentation cleanups and tweaks","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/dbf117aaf5eaf59a8b5d3c0516add2b708ce3e73"}]}],"author":{"name":"Joshua Harlow","email":"harlowja@yahoo-inc.com","date":"2014-09-26 01:27:05.000000000","tz":-420},"committer":{"name":"Joshua Harlow","email":"harlowja@yahoo-inc.com","date":"2014-09-26 01:30:44.000000000","tz":-420},"subject":"Always return copies from memory backend","message":"Always return copies from memory backend\n\nTo avoid the issue with conductors having raw access to the logbook\nor flow details and atom details in the memory backend, and this causing\nperiodic inconsistencies with stored results ensure that we *always* return\ncopies from the memory backend instead to prevent this.\n\nThis matches the behavior of other backends which always return copies\nof there underlying objects as well (partially because they do not\nstore the objects in a compatible format).\n\nFixes bug 1365830\n\nAlso fixes a retry test case issue that was discovered due to this more\nrobust copy usage.\n\nChange-Id: I9eeb674f7064aaa02a99418ca2b33c99debcf6e1\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/88273f57664d5409bcc4bfcb246320274f83f42c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/88273f57664d5409bcc4bfcb246320274f83f42c"}]},"branch":"refs/heads/master"},"6e3181f58a39ff5d69ae25dc579800d74c2281a9":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2014-09-26 01:35:14.000000000","uploader":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"ref":"refs/changes/42/124242/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/taskflow","ref":"refs/changes/42/124242/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/42/124242/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/42/124242/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/42/124242/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/taskflow refs/changes/42/124242/2"}}},"commit":{"parents":[{"commit":"dbf117aaf5eaf59a8b5d3c0516add2b708ce3e73","subject":"Documentation cleanups and tweaks","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/dbf117aaf5eaf59a8b5d3c0516add2b708ce3e73"}]}],"author":{"name":"Joshua Harlow","email":"harlowja@yahoo-inc.com","date":"2014-09-26 01:27:05.000000000","tz":-420},"committer":{"name":"Joshua Harlow","email":"harlowja@yahoo-inc.com","date":"2014-09-26 01:35:14.000000000","tz":0},"subject":"Always return copies from memory backend","message":"Always return copies from memory backend\n\nTo avoid the issue with conductors having raw access to the logbook\nor flow details and atom details in the memory backend, and this causing\nperiodic inconsistencies with stored data ensure that we *always* return\ncopies from the memory backend instead to prevent this.\n\nThis matches the behavior of other backends which always return copies\nof there underlying objects as well (partially because they do not\nstore the objects in a compatible format, ie in a database for the\ndatabase backend, or on a filesystem for the dir/file backend...).\n\nFixes bug 1365830\n\nAlso fixes a retry test case issue that was discovered due to this more\nrobust memory backend copy usage.\n\nChange-Id: I9eeb674f7064aaa02a99418ca2b33c99debcf6e1\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/6e3181f58a39ff5d69ae25dc579800d74c2281a9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/6e3181f58a39ff5d69ae25dc579800d74c2281a9"}]},"branch":"refs/heads/master"},"255c3cafc07571527efe9d3de01cdf32cc25455e":{"kind":"REWORK","_number":3,"created":"2014-09-26 05:45:13.000000000","uploader":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"ref":"refs/changes/42/124242/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/taskflow","ref":"refs/changes/42/124242/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/42/124242/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/42/124242/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/42/124242/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/taskflow refs/changes/42/124242/3"}}},"commit":{"parents":[{"commit":"dbf117aaf5eaf59a8b5d3c0516add2b708ce3e73","subject":"Documentation cleanups and tweaks","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/dbf117aaf5eaf59a8b5d3c0516add2b708ce3e73"}]}],"author":{"name":"Joshua Harlow","email":"harlowja@yahoo-inc.com","date":"2014-09-26 01:27:05.000000000","tz":-420},"committer":{"name":"Joshua Harlow","email":"harlowja@gmail.com","date":"2014-09-26 05:43:29.000000000","tz":-420},"subject":"Always return copies from memory backend","message":"Always return copies from memory backend\n\nTo avoid the issue with conductors having raw access to the logbook\nor flow details and atom details in the memory backend, and this causing\nperiodic inconsistencies with stored data ensure that we *always* return\ncopies from the memory backend instead to prevent this.\n\nThis matches the behavior of other backends which always return copies\nof there underlying objects as well (partially because they do not\nstore the objects in a compatible format, ie in a database for the\ndatabase backend, or on a filesystem for the dir/file backend...).\n\nFixes bug 1365830\n\nAlso fixes a retry test case issue that was discovered due to this more\nrobust memory backend copy usage.\n\nChange-Id: I9eeb674f7064aaa02a99418ca2b33c99debcf6e1\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/255c3cafc07571527efe9d3de01cdf32cc25455e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/255c3cafc07571527efe9d3de01cdf32cc25455e"}]},"branch":"refs/heads/master"},"27575d365d500a080f35d1e3c33a29499dfaa53b":{"kind":"REWORK","_number":4,"created":"2014-09-26 06:40:54.000000000","uploader":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"ref":"refs/changes/42/124242/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/taskflow","ref":"refs/changes/42/124242/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/42/124242/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/42/124242/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/42/124242/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/taskflow refs/changes/42/124242/4"}}},"commit":{"parents":[{"commit":"dbf117aaf5eaf59a8b5d3c0516add2b708ce3e73","subject":"Documentation cleanups and tweaks","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/dbf117aaf5eaf59a8b5d3c0516add2b708ce3e73"}]}],"author":{"name":"Joshua Harlow","email":"harlowja@yahoo-inc.com","date":"2014-09-26 01:27:05.000000000","tz":-420},"committer":{"name":"Joshua Harlow","email":"harlowja@gmail.com","date":"2014-09-26 06:40:41.000000000","tz":-420},"subject":"Always return copies from memory backend","message":"Always return copies from memory backend\n\nTo avoid the issue with conductors having raw access to the logbook\nor flow details and atom details in the memory backend, and this causing\nperiodic inconsistencies with stored data ensure that we *always* return\ncopies from the memory backend instead to prevent this.\n\nThis matches the behavior of other backends which always return copies\nof there underlying objects as well (partially because they do not\nstore the objects in a compatible format, ie in a database for the\ndatabase backend, or on a filesystem for the dir/file backend...).\n\nFixes bug 1365830\n\nAlso fixes a retry test case issue that was discovered due to this more\nrobust memory backend copy usage.\n\nChange-Id: I9eeb674f7064aaa02a99418ca2b33c99debcf6e1\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/27575d365d500a080f35d1e3c33a29499dfaa53b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/27575d365d500a080f35d1e3c33a29499dfaa53b"}]},"branch":"refs/heads/master"},"be834bc0992dcc618ef44a6e0f868550230234e7":{"kind":"REWORK","_number":5,"created":"2014-09-26 07:05:23.000000000","uploader":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"ref":"refs/changes/42/124242/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/taskflow","ref":"refs/changes/42/124242/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/42/124242/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/42/124242/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/42/124242/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/taskflow refs/changes/42/124242/5"}}},"commit":{"parents":[{"commit":"dbf117aaf5eaf59a8b5d3c0516add2b708ce3e73","subject":"Documentation cleanups and tweaks","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/dbf117aaf5eaf59a8b5d3c0516add2b708ce3e73"}]}],"author":{"name":"Joshua Harlow","email":"harlowja@yahoo-inc.com","date":"2014-09-26 01:27:05.000000000","tz":-420},"committer":{"name":"Joshua Harlow","email":"harlowja@gmail.com","date":"2014-09-26 07:02:17.000000000","tz":-420},"subject":"Always return copies from memory backend","message":"Always return copies from memory backend\n\nTo avoid the issue with conductors having raw access to the logbook\nor flow details and atom details in the memory backend, and this causing\nperiodic inconsistencies with stored data ensure that we *always* return\ncopies from the memory backend instead to prevent this.\n\nThis matches the behavior of other backends which always return copies\nof there underlying objects as well (partially because they do not\nstore the objects in a compatible format, ie in a database for the\ndatabase backend, or on a filesystem for the dir/file backend...).\n\nFixes bug 1365830\n\nAlso fixes a retry test case issue that was discovered due to this more\nrobust memory backend copy usage.\n\nChange-Id: I9eeb674f7064aaa02a99418ca2b33c99debcf6e1\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/be834bc0992dcc618ef44a6e0f868550230234e7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/be834bc0992dcc618ef44a6e0f868550230234e7"}]},"branch":"refs/heads/master"},"bb569ce4889bd38e02d7040439247ed014cefbbb":{"kind":"REWORK","_number":6,"created":"2014-09-26 07:26:20.000000000","uploader":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"ref":"refs/changes/42/124242/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/taskflow","ref":"refs/changes/42/124242/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/42/124242/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/42/124242/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/42/124242/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/taskflow refs/changes/42/124242/6"}}},"commit":{"parents":[{"commit":"dbf117aaf5eaf59a8b5d3c0516add2b708ce3e73","subject":"Documentation cleanups and tweaks","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/dbf117aaf5eaf59a8b5d3c0516add2b708ce3e73"}]}],"author":{"name":"Joshua Harlow","email":"harlowja@yahoo-inc.com","date":"2014-09-26 01:27:05.000000000","tz":-420},"committer":{"name":"Joshua Harlow","email":"harlowja@gmail.com","date":"2014-09-26 07:25:12.000000000","tz":-420},"subject":"Always return copies from memory backend","message":"Always return copies from memory backend\n\nTo avoid the issue with conductors having raw access to the logbook\nor flow details and atom details in the memory backend, and this causing\nperiodic inconsistencies with stored data ensure that we *always* return\ncopies from the memory backend instead to prevent this.\n\nThis matches the behavior of other backends which always return copies\nof there underlying objects as well (partially because they do not\nstore the objects in a compatible format, ie in a database for the\ndatabase backend, or on a filesystem for the dir/file backend...).\n\nFixes bug 1365830\n\nAlso fixes a retry test case issue that was discovered due to this more\nrobust memory backend copy usage.\n\nChange-Id: I9eeb674f7064aaa02a99418ca2b33c99debcf6e1\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/bb569ce4889bd38e02d7040439247ed014cefbbb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/bb569ce4889bd38e02d7040439247ed014cefbbb"}]},"branch":"refs/heads/master"},"b6d923991ca4e61e2da34ab4d82072b353b748c1":{"kind":"REWORK","_number":7,"created":"2014-09-26 21:28:07.000000000","uploader":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"ref":"refs/changes/42/124242/7","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/taskflow","ref":"refs/changes/42/124242/7","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/42/124242/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/42/124242/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/42/124242/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/taskflow refs/changes/42/124242/7"}}},"commit":{"parents":[{"commit":"dbf117aaf5eaf59a8b5d3c0516add2b708ce3e73","subject":"Documentation cleanups and tweaks","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/dbf117aaf5eaf59a8b5d3c0516add2b708ce3e73"}]}],"author":{"name":"Joshua Harlow","email":"harlowja@yahoo-inc.com","date":"2014-09-26 01:27:05.000000000","tz":-420},"committer":{"name":"Joshua Harlow","email":"harlowja@yahoo-inc.com","date":"2014-09-26 21:23:24.000000000","tz":-420},"subject":"Always return copies from memory backend","message":"Always return copies from memory backend\n\nTo avoid the issue with conductors having raw access to the logbook\nor flow details and atom details in the memory backend, and this causing\nperiodic inconsistencies with stored data ensure that we *always* return\ncopies from the memory backend instead to prevent this.\n\nThis matches the behavior of other backends which always return copies\nof there underlying objects as well (partially because they do not\nstore the objects in a compatible format, ie in a database for the\ndatabase backend, or on a filesystem for the dir/file backend...).\n\nFixes bug 1365830\n\nAlso fixes a retry test case issue that was discovered due to this more\nrobust memory backend copy usage.\n\nChange-Id: I9eeb674f7064aaa02a99418ca2b33c99debcf6e1\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/b6d923991ca4e61e2da34ab4d82072b353b748c1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/b6d923991ca4e61e2da34ab4d82072b353b748c1"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
