)]}'
{"taskflow/tests/unit/test_engines.py":[{"author":{"_account_id":7366,"name":"Ivan Melnikov","email":"imelnikov@griddynamics.com","username":"imelnikov"},"change_message_id":"544a95733c53e30f360d8d11c74d22cbd06d65e5","unresolved":false,"context_lines":[{"line_number":645,"context_line":"    def tearDown(self):"},{"line_number":646,"context_line":"        super(WorkerBasedEngineTest, self).tearDown()"},{"line_number":647,"context_line":"        self.worker.stop()"},{"line_number":648,"context_line":"        self.runner.join()"},{"line_number":649,"context_line":""},{"line_number":650,"context_line":"    def _make_engine(self, flow, flow_detail\u003dNone):"},{"line_number":651,"context_line":"        return taskflow.engines.load(flow, flow_detail\u003dflow_detail,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a8c0949_b8c35689","line":648,"updated":"2014-10-30 08:14:58.000000000","message":"Why do you reverse the order here? I thought that calling super(...).tearDown() at the end of the overriding method is among best practices, because it looks natural to tear down things in order inverse to set up order, and also it saves us from leaking threads when parent\u0027s tearDown() raises.","commit_id":"12bba567c04caa6e1d7260c8baa01573207dcdd5"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"a63114ad4aea22bfa8ad607008f30d4b6d4933e7","unresolved":false,"context_lines":[{"line_number":645,"context_line":"    def tearDown(self):"},{"line_number":646,"context_line":"        super(WorkerBasedEngineTest, self).tearDown()"},{"line_number":647,"context_line":"        self.worker.stop()"},{"line_number":648,"context_line":"        self.runner.join()"},{"line_number":649,"context_line":""},{"line_number":650,"context_line":"    def _make_engine(self, flow, flow_detail\u003dNone):"},{"line_number":651,"context_line":"        return taskflow.engines.load(flow, flow_detail\u003dflow_detail,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a8c0949_19ad3e32","line":648,"in_reply_to":"7a8c0949_b8c35689","updated":"2014-10-30 18:25:31.000000000","message":"Ya, forgot why I changed this order. Let me adjust that, lol.","commit_id":"12bba567c04caa6e1d7260c8baa01573207dcdd5"},{"author":{"_account_id":7366,"name":"Ivan Melnikov","email":"imelnikov@griddynamics.com","username":"imelnikov"},"change_message_id":"779da827364b646b8244942249b9b210c805ad60","unresolved":false,"context_lines":[{"line_number":624,"context_line":"                # considerable win in tests run time; reducing polling interval"},{"line_number":625,"context_line":"                # too much (AFAIR below 0.0005) affected stability -- I was"},{"line_number":626,"context_line":"                # seeing timeouts. So, 0.01 looks like the most balanced for"},{"line_number":627,"context_line":"                # local transports (for now)."},{"line_number":628,"context_line":"                \u0027polling_interval\u0027: 0.01,"},{"line_number":629,"context_line":"            },"},{"line_number":630,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a8c0949_26880a1f","line":627,"updated":"2014-10-31 08:04:51.000000000","message":"Well, I don\u0027t remember adding this note ))","commit_id":"c8b0f25d816bfd00a93134567cb5e0f313bfe9f2"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"ecae259fd0b958e1e849981f3aa2404778cbead0","unresolved":false,"context_lines":[{"line_number":624,"context_line":"                # considerable win in tests run time; reducing polling interval"},{"line_number":625,"context_line":"                # too much (AFAIR below 0.0005) affected stability -- I was"},{"line_number":626,"context_line":"                # seeing timeouts. So, 0.01 looks like the most balanced for"},{"line_number":627,"context_line":"                # local transports (for now)."},{"line_number":628,"context_line":"                \u0027polling_interval\u0027: 0.01,"},{"line_number":629,"context_line":"            },"},{"line_number":630,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a8c0949_2fb52fee","line":627,"in_reply_to":"7a8c0949_26880a1f","updated":"2014-10-31 23:30:39.000000000","message":"U added it to code-review, I just moved it here ;)","commit_id":"c8b0f25d816bfd00a93134567cb5e0f313bfe9f2"}]}