)]}'
{"taskflow/listeners/logging.py":[{"author":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"change_message_id":"5e7c0c6497237289c50bcdf17cd7f4dbf0a730c5","unresolved":false,"context_lines":[{"line_number":160,"context_line":"                self._logger.log(self._failure_level,"},{"line_number":161,"context_line":"                                 \"Task \u0027%s\u0027 (%s) transitioned into state\""},{"line_number":162,"context_line":"                                 \" \u0027%s\u0027%s\", details[\u0027task_name\u0027],"},{"line_number":163,"context_line":"                                 details[\u0027task_uuid\u0027], state, exc_details,"},{"line_number":164,"context_line":"                                 exc_info\u003dexc_info)"},{"line_number":165,"context_line":"            else:"},{"line_number":166,"context_line":"                # Otherwise, depending on the enabled logging level/state we"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa7fdbe_2b3e62da","line":163,"updated":"2014-10-27 21:36:30.000000000","message":"Since it looks like we can either have exc_info or exc_details filled in, if we have such kind of logging statement won\u0027t we display empty string (\u0027\u0027) or \u0027None\u0027 as part of logging. Is this expected ? If not can we have the logging statement also conditional depending on which value in the tuple gets filled in ? If we want both then can the _format_failure be modified to take care of it ?","commit_id":"8f9dc1f611187afde2620cd55a0865e39f44d77f"},{"author":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"change_message_id":"f460843ac8e62eac0ad072666c70a73831737dfe","unresolved":false,"context_lines":[{"line_number":160,"context_line":"                self._logger.log(self._failure_level,"},{"line_number":161,"context_line":"                                 \"Task \u0027%s\u0027 (%s) transitioned into state\""},{"line_number":162,"context_line":"                                 \" \u0027%s\u0027%s\", details[\u0027task_name\u0027],"},{"line_number":163,"context_line":"                                 details[\u0027task_uuid\u0027], state, exc_details,"},{"line_number":164,"context_line":"                                 exc_info\u003dexc_info)"},{"line_number":165,"context_line":"            else:"},{"line_number":166,"context_line":"                # Otherwise, depending on the enabled logging level/state we"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa7fdbe_8119ef23","line":163,"in_reply_to":"9aa7fdbe_268699db","updated":"2014-10-27 22:46:43.000000000","message":"Ok makes sense.","commit_id":"8f9dc1f611187afde2620cd55a0865e39f44d77f"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"8bd43631aa9ea0e09cdf3d5c9c9a10b5861fc9f1","unresolved":false,"context_lines":[{"line_number":160,"context_line":"                self._logger.log(self._failure_level,"},{"line_number":161,"context_line":"                                 \"Task \u0027%s\u0027 (%s) transitioned into state\""},{"line_number":162,"context_line":"                                 \" \u0027%s\u0027%s\", details[\u0027task_name\u0027],"},{"line_number":163,"context_line":"                                 details[\u0027task_uuid\u0027], state, exc_details,"},{"line_number":164,"context_line":"                                 exc_info\u003dexc_info)"},{"line_number":165,"context_line":"            else:"},{"line_number":166,"context_line":"                # Otherwise, depending on the enabled logging level/state we"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa7fdbe_268699db","line":163,"in_reply_to":"9aa7fdbe_2b3e62da","updated":"2014-10-27 22:04:36.000000000","message":"I\u0027m confused. You can have both.\n\nThe \u0027exc_info\u0027 tuple is sort of special. In that its used internally to the logger itself to display traceback information.\n\nSee details @ https://docs.python.org/2/library/logging.html#logging.Logger.debug\n\n\u0027\u0027\u0027There are two keyword arguments in kwargs which are inspected: exc_info which, if it does not evaluate as false, causes exception information to be added to the logging message. If an exception tuple (in the format returned by sys.exc_info()) is provided, it is used; otherwise, sys.exc_info() is called to get the exception information.\u0027\u0027\u0027\n\nIf none is provided for \u0027exc_info\u0027 that activates the \u0027false\u0027 path from above (which means the logger won\u0027t add additional exception information automatically).","commit_id":"8f9dc1f611187afde2620cd55a0865e39f44d77f"}]}