)]}'
{"id":"openstack%2Ftaskflow~149803","triplet_id":"openstack%2Ftaskflow~master~Id84b0e7ce684a543cc407b15016e77804e6f03ed","project":"openstack/taskflow","branch":"master","topic":"exceptions-cleanup","hashtags":[],"change_id":"Id84b0e7ce684a543cc407b15016e77804e6f03ed","subject":"Make all/most usage of type errors follow a similar pattern","status":"MERGED","created":"2015-01-24 02:26:36.000000000","updated":"2015-01-24 04:31:50.000000000","submitted":"2015-01-24 04:31:49.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"32e866a7824240848cf5f47b9e1afcf9f7380acd","_number":149803,"virtual_id_number":149803,"owner":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"value":2,"date":"2015-01-24 04:31:49.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"all":[{"value":2,"date":"2015-01-24 03:53:37.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"all":[{"value":1,"date":"2015-01-24 03:53:37.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-01-24 04:31:49.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"ff45b32493e9a974367ff9710ba7b05e4510c0cd","author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"date":"2015-01-24 02:26:36.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1da947452d8a1a85fc5e687c6996ffcaa4fdce83","author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"date":"2015-01-24 02:27:02.000000000","message":"Topic set to exceptions-cleanup","accounts_in_message":[],"_revision_number":1},{"id":"983a54beaaad17935852ee31ddb58e9700092dbf","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-01-24 03:03:16.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-taskflow-python26 http://logs.openstack.org/03/149803/1/check/gate-taskflow-python26/3dee2f6/ : SUCCESS in 1m 27s\n- gate-taskflow-pep8 http://logs.openstack.org/03/149803/1/check/gate-taskflow-pep8/d5adf3a/ : SUCCESS in 45s\n- gate-taskflow-docs http://docs-draft.openstack.org/03/149803/1/check/gate-taskflow-docs/f8d9267//doc/build/html/ : SUCCESS in 55s\n- gate-taskflow-python27 http://logs.openstack.org/03/149803/1/check/gate-taskflow-python27/2c39589/ : SUCCESS in 1m 28s\n- gate-tempest-dsvm-neutron-src-taskflow http://logs.openstack.org/03/149803/1/check/gate-tempest-dsvm-neutron-src-taskflow/b6f9dfe/ : SUCCESS in 36m 37s\n- gate-tempest-dsvm-neutron-src-taskflow-icehouse http://logs.openstack.org/03/149803/1/check/gate-tempest-dsvm-neutron-src-taskflow-icehouse/006af6d/ : SUCCESS in 29m 36s\n- gate-tempest-dsvm-neutron-src-taskflow-juno http://logs.openstack.org/03/149803/1/check/gate-tempest-dsvm-neutron-src-taskflow-juno/f2a9b61/ : SUCCESS in 26m 46s\n- gate-taskflow-python34 http://logs.openstack.org/03/149803/1/check/gate-taskflow-python34/14a19f8/ : SUCCESS in 2m 57s\n- gate-taskflow-tox-py26-sa7-mysql http://logs.openstack.org/03/149803/1/check/gate-taskflow-tox-py26-sa7-mysql/9eed172/ : SUCCESS in 1m 26s\n- gate-taskflow-tox-py27-sa8-mysql http://logs.openstack.org/03/149803/1/check/gate-taskflow-tox-py27-sa8-mysql/5d7f6ba/ : SUCCESS in 1m 24s","accounts_in_message":[],"_revision_number":1},{"id":"9532c1f66484286566752bb95c7cfd5d3eeddb8f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-01-24 03:53:37.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"4333fa4ea3d18e15588c6b624c8ee47378e34e21","author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"date":"2015-01-24 03:53:37.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"02488cb644818fba1caafa5a86ac26d8c14bb6ee","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-01-24 04:31:49.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-taskflow-python26 http://logs.openstack.org/03/149803/1/gate/gate-taskflow-python26/770dfc3/ : SUCCESS in 1m 30s\n- gate-taskflow-docs http://docs-draft.openstack.org/03/149803/1/gate/gate-taskflow-docs/3899494//doc/build/html/ : SUCCESS in 1m 16s\n- gate-taskflow-pep8 http://logs.openstack.org/03/149803/1/gate/gate-taskflow-pep8/23ba5e2/ : SUCCESS in 50s\n- gate-taskflow-python27 http://logs.openstack.org/03/149803/1/gate/gate-taskflow-python27/54910be/ : SUCCESS in 1m 37s\n- gate-tempest-dsvm-neutron-src-taskflow http://logs.openstack.org/03/149803/1/gate/gate-tempest-dsvm-neutron-src-taskflow/a9b87ff/ : SUCCESS in 38m 10s\n- gate-taskflow-tox-py26-sa7-mysql http://logs.openstack.org/03/149803/1/gate/gate-taskflow-tox-py26-sa7-mysql/1308532/ : SUCCESS in 1m 36s\n- gate-taskflow-tox-py27-sa8-mysql http://logs.openstack.org/03/149803/1/gate/gate-taskflow-tox-py27-sa8-mysql/30a81fa/ : SUCCESS in 1m 39s\n- gate-taskflow-python34 http://logs.openstack.org/03/149803/1/gate/gate-taskflow-python34/de9536e/ : SUCCESS in 3m 02s","accounts_in_message":[],"_revision_number":1},{"id":"32e866a7824240848cf5f47b9e1afcf9f7380acd","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-01-24 04:31:50.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"e417914d49458a4f0fd231497f6a4c1200cfecb2","revisions":{"e417914d49458a4f0fd231497f6a4c1200cfecb2":{"kind":"REWORK","_number":1,"created":"2015-01-24 02:26:36.000000000","uploader":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"ref":"refs/changes/03/149803/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/taskflow","ref":"refs/changes/03/149803/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/03/149803/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/03/149803/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/03/149803/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/taskflow refs/changes/03/149803/1"}}},"commit":{"parents":[{"commit":"cfe478a2bc96ed9576e6f88b268731058747acf4","subject":"Merge \"Show the failure discarded (and the future intention)\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/cfe478a2bc96ed9576e6f88b268731058747acf4"}]}],"author":{"name":"Joshua Harlow","email":"harlowja@yahoo-inc.com","date":"2015-01-24 02:05:02.000000000","tz":-480},"committer":{"name":"Joshua Harlow","email":"harlowja@yahoo-inc.com","date":"2015-01-24 02:25:01.000000000","tz":-480},"subject":"Make all/most usage of type errors follow a similar pattern","message":"Make all/most usage of type errors follow a similar pattern\n\nTo make it easy to add new type errors and to make the existing\nones have a common string pattern adjust the current type errors\nto contain at least the following string format: \u0027%s\u0027 (%s) where\nthese two places will be filled in with the object of the wrong\ntype and the type of that object. This information is useful when\nanalyzing the exception (by the user) to know exactly what they\npassed in and what type it was.\n\nThis convention is not maintained where it would interpolate large\ntext blobs (such as in binary encoding/decoding and json decoding).\n\nChange-Id: Id84b0e7ce684a543cc407b15016e77804e6f03ed\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/e417914d49458a4f0fd231497f6a4c1200cfecb2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/e417914d49458a4f0fd231497f6a4c1200cfecb2"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
