)]}'
{"taskflow/atom.py":[{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"7d90ec894e8183c3463323d18b6507fa60d252d7","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    well as verify that the final argument mapping does not have missing or"},{"line_number":83,"context_line":"    extra arguments (where applicable)."},{"line_number":84,"context_line":"    \"\"\""},{"line_number":85,"context_line":"    req_args \u003d reflection.get_callable_args(function, required_only\u003dTrue)"},{"line_number":86,"context_line":"    all_args \u003d reflection.get_callable_args(function, required_only\u003dFalse)"},{"line_number":87,"context_line":"    opt_args \u003d set(all_args) - set(req_args)"},{"line_number":88,"context_line":"    if ignore_list:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_e26cfe9e","line":85,"updated":"2015-02-03 01:17:54.000000000","message":"I def could see it useful to have a reflection.get_callable_args that returns both of these as a pair, something like... Maybe something for later....","commit_id":"9d911389ac4111118ab06b1639f1745433ed6054"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"7d90ec894e8183c3463323d18b6507fa60d252d7","unresolved":false,"context_lines":[{"line_number":98,"context_line":"    required.update(_build_rebind_dict(req_args, rebind_args))"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    optional \u003d {}"},{"line_number":101,"context_line":"    if do_infer and opt_args and len(required):"},{"line_number":102,"context_line":"        opt_args -\u003d set(required)"},{"line_number":103,"context_line":"        optional.update((a, a) for a in opt_args)"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_62ac8ea1","line":101,"updated":"2015-02-03 01:17:54.000000000","message":"I wonder if u should also do the following line(s) from above here (to avoid doing it in the first place?):\n\n  opt_args \u003d set(all_args) - set(req_args)\n\nThen only if ``if do_infer and len(required)`` do u even bother calculating these items, what do u think?","commit_id":"9d911389ac4111118ab06b1639f1745433ed6054"},{"author":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"change_message_id":"6b67714f6cba31ceb85d6d1823f62a0f8b0fa86c","unresolved":false,"context_lines":[{"line_number":98,"context_line":"    required.update(_build_rebind_dict(req_args, rebind_args))"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    optional \u003d {}"},{"line_number":101,"context_line":"    if do_infer and opt_args and len(required):"},{"line_number":102,"context_line":"        opt_args -\u003d set(required)"},{"line_number":103,"context_line":"        optional.update((a, a) for a in opt_args)"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_37756d98","line":101,"in_reply_to":"da86d52c_62ac8ea1","updated":"2015-02-03 09:28:10.000000000","message":"Done","commit_id":"9d911389ac4111118ab06b1639f1745433ed6054"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"7d90ec894e8183c3463323d18b6507fa60d252d7","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    optional \u003d {}"},{"line_number":101,"context_line":"    if do_infer and opt_args and len(required):"},{"line_number":102,"context_line":"        opt_args -\u003d set(required)"},{"line_number":103,"context_line":"        optional.update((a, a) for a in opt_args)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    if not reflection.accepts_kwargs(function):"},{"line_number":106,"context_line":"        extra_args \u003d set(required) - set(all_args)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_a2f926ca","line":103,"updated":"2015-02-03 01:17:54.000000000","message":"Do u want to apply the same rebinding info to the optional ones?\n\nWould seem like both optional/required should be affected by the same rebinding mechanism?","commit_id":"9d911389ac4111118ab06b1639f1745433ed6054"},{"author":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"change_message_id":"6b67714f6cba31ceb85d6d1823f62a0f8b0fa86c","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    optional \u003d {}"},{"line_number":101,"context_line":"    if do_infer and opt_args and len(required):"},{"line_number":102,"context_line":"        opt_args -\u003d set(required)"},{"line_number":103,"context_line":"        optional.update((a, a) for a in opt_args)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    if not reflection.accepts_kwargs(function):"},{"line_number":106,"context_line":"        extra_args \u003d set(required) - set(all_args)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_579f41b4","line":103,"in_reply_to":"da86d52c_a2f926ca","updated":"2015-02-03 09:28:10.000000000","message":"rebinds are already included in required","commit_id":"9d911389ac4111118ab06b1639f1745433ed6054"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"7d90ec894e8183c3463323d18b6507fa60d252d7","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        self.requires \u003d set(req_arg.values())"},{"line_number":175,"context_line":"        if self.inject:"},{"line_number":176,"context_line":"            self.requires -\u003d set(six.iterkeys(self.inject))"},{"line_number":177,"context_line":"        self.optional \u003d set(opt_arg.values())"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"        out_of_order \u003d self.provides.intersection(self.requires)"},{"line_number":180,"context_line":"        if out_of_order:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_e2f15ece","line":177,"updated":"2015-02-03 01:17:54.000000000","message":"Can optional values be affected by the inject items?","commit_id":"9d911389ac4111118ab06b1639f1745433ed6054"},{"author":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"change_message_id":"6b67714f6cba31ceb85d6d1823f62a0f8b0fa86c","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        self.requires \u003d set(req_arg.values())"},{"line_number":175,"context_line":"        if self.inject:"},{"line_number":176,"context_line":"            self.requires -\u003d set(six.iterkeys(self.inject))"},{"line_number":177,"context_line":"        self.optional \u003d set(opt_arg.values())"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"        out_of_order \u003d self.provides.intersection(self.requires)"},{"line_number":180,"context_line":"        if out_of_order:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_7758c532","line":177,"in_reply_to":"da86d52c_65581833","updated":"2015-02-03 09:28:10.000000000","message":"Done","commit_id":"9d911389ac4111118ab06b1639f1745433ed6054"},{"author":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"change_message_id":"6b67714f6cba31ceb85d6d1823f62a0f8b0fa86c","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        self.requires \u003d set(req_arg.values())"},{"line_number":175,"context_line":"        if self.inject:"},{"line_number":176,"context_line":"            self.requires -\u003d set(six.iterkeys(self.inject))"},{"line_number":177,"context_line":"        self.optional \u003d set(opt_arg.values())"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"        out_of_order \u003d self.provides.intersection(self.requires)"},{"line_number":180,"context_line":"        if out_of_order:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_01c5873b","line":177,"in_reply_to":"da86d52c_e2f15ece","updated":"2015-02-03 09:28:10.000000000","message":"From my testing, with the currently released version of taskflow optional values are not populated with inject.  With these changes optional values are populated with inject.  Injected values also override engine \u0027store\u0027 values, which is consistent with injected values overriding engine \u0027store\u0027 values for required values","commit_id":"9d911389ac4111118ab06b1639f1745433ed6054"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"23acdc30f0fd692b1a1cb9309150b3434b8013b5","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        self.requires \u003d set(req_arg.values())"},{"line_number":175,"context_line":"        if self.inject:"},{"line_number":176,"context_line":"            self.requires -\u003d set(six.iterkeys(self.inject))"},{"line_number":177,"context_line":"        self.optional \u003d set(opt_arg.values())"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"        out_of_order \u003d self.provides.intersection(self.requires)"},{"line_number":180,"context_line":"        if out_of_order:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_65581833","line":177,"in_reply_to":"da86d52c_e2f15ece","updated":"2015-02-03 01:38:00.000000000","message":"Ie should this be:\n  \n  self.optional \u003d set(opt_arg.values())\n  self.optional -\u003d set(six.iterkeys(self.inject))","commit_id":"9d911389ac4111118ab06b1639f1745433ed6054"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"4c5adda1919405a51ed853f1fe5bbf8e1ece383c","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    optional \u003d {}"},{"line_number":102,"context_line":"    if do_infer and (len(all_args) \u003e len(required)):"},{"line_number":103,"context_line":"        opt_args \u003d set(all_args) - set(required)"},{"line_number":104,"context_line":"        optional.update((a, a) for a in opt_args)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    if not reflection.accepts_kwargs(function):"},{"line_number":107,"context_line":"        extra_args \u003d set(required) - set(all_args) - set(ignore_list)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_29924e9f","line":104,"updated":"2015-02-03 20:39:54.000000000","message":"Should the \u0027ignore_list\u0027 also affect the optional args?","commit_id":"869589b05769bb55dcd428202fd5f73fc59a3315"},{"author":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"change_message_id":"106126a64b11eb4341e91aac88e4b34a17bd2054","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    optional \u003d {}"},{"line_number":102,"context_line":"    if do_infer and (len(all_args) \u003e len(required)):"},{"line_number":103,"context_line":"        opt_args \u003d set(all_args) - set(required)"},{"line_number":104,"context_line":"        optional.update((a, a) for a in opt_args)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    if not reflection.accepts_kwargs(function):"},{"line_number":107,"context_line":"        extra_args \u003d set(required) - set(all_args) - set(ignore_list)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_7cec05f4","line":104,"in_reply_to":"da86d52c_29924e9f","updated":"2015-02-03 21:47:01.000000000","message":"good catch, I put the \"- set (ignore_list)\" in the wrong line, it\u0027s in line 107 when it should be in line 103","commit_id":"869589b05769bb55dcd428202fd5f73fc59a3315"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"180aa92a1abe44bfbc7e75cd94ed67d80ceb2f13","unresolved":false,"context_lines":[{"line_number":205,"context_line":"        requires and what it produces (since this would be an impossible"},{"line_number":206,"context_line":"        dependency to satisfy)."},{"line_number":207,"context_line":"        \"\"\""},{"line_number":208,"context_line":"        return set(self.save_as)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_e9a916e0","line":208,"updated":"2015-02-03 20:38:31.000000000","message":"Can u move this documentation that is now gone about what requires are into the class level documentation (I guess a new :ivar requires section?) so that people don\u0027t lose the ability to know what these are (probably have a similar doc for :ivar  optional so that people know what its for also. Sound ok?","commit_id":"869589b05769bb55dcd428202fd5f73fc59a3315"},{"author":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"change_message_id":"106126a64b11eb4341e91aac88e4b34a17bd2054","unresolved":false,"context_lines":[{"line_number":205,"context_line":"        requires and what it produces (since this would be an impossible"},{"line_number":206,"context_line":"        dependency to satisfy)."},{"line_number":207,"context_line":"        \"\"\""},{"line_number":208,"context_line":"        return set(self.save_as)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_fc12b507","line":208,"in_reply_to":"da86d52c_e9a916e0","updated":"2015-02-03 21:47:01.000000000","message":"Done","commit_id":"869589b05769bb55dcd428202fd5f73fc59a3315"},{"author":{"_account_id":7366,"name":"Ivan Melnikov","email":"imelnikov@griddynamics.com","username":"imelnikov"},"change_message_id":"56b5be2944f719f8290ed6cfe291ca01d918a643","unresolved":false,"context_lines":[{"line_number":89,"context_line":"            if arg in req_args:"},{"line_number":90,"context_line":"                req_args.remove(arg)"},{"line_number":91,"context_line":"    else:"},{"line_number":92,"context_line":"        ignore_list \u003d []"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    required \u003d {}"},{"line_number":95,"context_line":"    if reqs:"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_3980448b","line":92,"updated":"2015-02-08 10:59:51.000000000","message":"If you transform ignore_list to set anyway, you can do it before and just use set minus operation here, too.","commit_id":"32effb43e5d2357e04f1ea2e5e4ed35613ed7542"},{"author":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"change_message_id":"76f286790d98fe47058564cedf21afa603ae2ddd","unresolved":false,"context_lines":[{"line_number":89,"context_line":"            if arg in req_args:"},{"line_number":90,"context_line":"                req_args.remove(arg)"},{"line_number":91,"context_line":"    else:"},{"line_number":92,"context_line":"        ignore_list \u003d []"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    required \u003d {}"},{"line_number":95,"context_line":"    if reqs:"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_8c17baed","line":92,"in_reply_to":"da86d52c_3980448b","updated":"2015-02-11 04:38:36.000000000","message":"tried this, it turns out that preserving order is important because of need to map rebind arguments in line 99.  If this is turned in to a set operation, order is not preserved as python sets do not preserve order.","commit_id":"32effb43e5d2357e04f1ea2e5e4ed35613ed7542"},{"author":{"_account_id":7366,"name":"Ivan Melnikov","email":"imelnikov@griddynamics.com","username":"imelnikov"},"change_message_id":"56b5be2944f719f8290ed6cfe291ca01d918a643","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    optional \u003d {}"},{"line_number":102,"context_line":"    if do_infer and (len(all_args) \u003e len(required)):"},{"line_number":103,"context_line":"        opt_args \u003d set(all_args) - set(required) - set(ignore_list)"},{"line_number":104,"context_line":"        optional.update((a, a) for a in opt_args)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    if not reflection.accepts_kwargs(function):"},{"line_number":107,"context_line":"        extra_args \u003d set(required) - set(all_args)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_597df8b0","line":104,"updated":"2015-02-08 10:59:51.000000000","message":"Why not just create optional here, instead of creating empty dict above and then updating?","commit_id":"32effb43e5d2357e04f1ea2e5e4ed35613ed7542"},{"author":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"change_message_id":"76f286790d98fe47058564cedf21afa603ae2ddd","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    optional \u003d {}"},{"line_number":102,"context_line":"    if do_infer and (len(all_args) \u003e len(required)):"},{"line_number":103,"context_line":"        opt_args \u003d set(all_args) - set(required) - set(ignore_list)"},{"line_number":104,"context_line":"        optional.update((a, a) for a in opt_args)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    if not reflection.accepts_kwargs(function):"},{"line_number":107,"context_line":"        extra_args \u003d set(required) - set(all_args)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_c2834354","line":104,"in_reply_to":"da86d52c_597df8b0","updated":"2015-02-11 04:38:36.000000000","message":"C++ background...  I thought scoping rules would make it inaccessible outside the if black, I guess not :)\n\nalthough, we still need to initialize optional to an empty dictionary if do_infer is not set, either that or we need to check for optional while returning.","commit_id":"32effb43e5d2357e04f1ea2e5e4ed35613ed7542"},{"author":{"_account_id":7366,"name":"Ivan Melnikov","email":"imelnikov@griddynamics.com","username":"imelnikov"},"change_message_id":"56b5be2944f719f8290ed6cfe291ca01d918a643","unresolved":false,"context_lines":[{"line_number":217,"context_line":"        this atom requires and what it produces (since this would"},{"line_number":218,"context_line":"        be an impossible dependency to satisfy)."},{"line_number":219,"context_line":"        \"\"\""},{"line_number":220,"context_line":"        return self._requires.copy()"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    @property"},{"line_number":223,"context_line":"    def optional(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_b943546b","line":220,"updated":"2015-02-08 10:59:51.000000000","message":"You can convert self._requires to frozenset in constructor and avoid copying here.","commit_id":"32effb43e5d2357e04f1ea2e5e4ed35613ed7542"},{"author":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"change_message_id":"76f286790d98fe47058564cedf21afa603ae2ddd","unresolved":false,"context_lines":[{"line_number":217,"context_line":"        this atom requires and what it produces (since this would"},{"line_number":218,"context_line":"        be an impossible dependency to satisfy)."},{"line_number":219,"context_line":"        \"\"\""},{"line_number":220,"context_line":"        return self._requires.copy()"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    @property"},{"line_number":223,"context_line":"    def optional(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_6ce52608","line":220,"in_reply_to":"da86d52c_b943546b","updated":"2015-02-11 04:38:36.000000000","message":"agreed, will turn in to a frozenset","commit_id":"32effb43e5d2357e04f1ea2e5e4ed35613ed7542"},{"author":{"_account_id":7366,"name":"Ivan Melnikov","email":"imelnikov@griddynamics.com","username":"imelnikov"},"change_message_id":"56b5be2944f719f8290ed6cfe291ca01d918a643","unresolved":false,"context_lines":[{"line_number":222,"context_line":"    @property"},{"line_number":223,"context_line":"    def optional(self):"},{"line_number":224,"context_line":"        \"\"\"Any inputs that are optional for this atom\u0027s execute method.\"\"\""},{"line_number":225,"context_line":"        return self._optional.copy()"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_d948088a","line":225,"updated":"2015-02-08 10:59:51.000000000","message":"ditto for self._optional","commit_id":"32effb43e5d2357e04f1ea2e5e4ed35613ed7542"},{"author":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"change_message_id":"76f286790d98fe47058564cedf21afa603ae2ddd","unresolved":false,"context_lines":[{"line_number":222,"context_line":"    @property"},{"line_number":223,"context_line":"    def optional(self):"},{"line_number":224,"context_line":"        \"\"\"Any inputs that are optional for this atom\u0027s execute method.\"\"\""},{"line_number":225,"context_line":"        return self._optional.copy()"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_8ceedaeb","line":225,"in_reply_to":"da86d52c_d948088a","updated":"2015-02-11 04:38:36.000000000","message":"same","commit_id":"32effb43e5d2357e04f1ea2e5e4ed35613ed7542"}],"taskflow/examples/optional_arguments.py":[{"author":{"_account_id":7366,"name":"Ivan Melnikov","email":"imelnikov@griddynamics.com","username":"imelnikov"},"change_message_id":"56b5be2944f719f8290ed6cfe291ca01d918a643","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"class MyTest(unittest.TestCase):"},{"line_number":38,"context_line":"    def setUp(self):"},{"line_number":39,"context_line":"        pass"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def test_my_test(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_39576428","line":38,"updated":"2015-02-08 10:59:51.000000000","message":"You don\u0027t need this  empty method.","commit_id":"32effb43e5d2357e04f1ea2e5e4ed35613ed7542"},{"author":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"change_message_id":"76f286790d98fe47058564cedf21afa603ae2ddd","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"class MyTest(unittest.TestCase):"},{"line_number":38,"context_line":"    def setUp(self):"},{"line_number":39,"context_line":"        pass"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def test_my_test(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_8cc5fa5d","line":38,"in_reply_to":"da86d52c_39576428","updated":"2015-02-11 04:38:36.000000000","message":"agreed, will remove","commit_id":"32effb43e5d2357e04f1ea2e5e4ed35613ed7542"}],"taskflow/storage.py":[{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"7d90ec894e8183c3463323d18b6507fa60d252d7","unresolved":false,"context_lines":[{"line_number":636,"context_line":""},{"line_number":637,"context_line":"    def fetch_mapped_args(self, args_mapping,"},{"line_number":638,"context_line":"                          atom_name\u003dNone, scope_walker\u003dNone,"},{"line_number":639,"context_line":"                          optional_args\u003d[]):"},{"line_number":640,"context_line":"        \"\"\"Fetch arguments for an atom using an atoms argument mapping.\"\"\""},{"line_number":641,"context_line":""},{"line_number":642,"context_line":"        def _get_results(looking_for, provider):"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_22d1b657","line":639,"updated":"2015-02-03 01:17:54.000000000","message":"Just a python thing, avoid mutable arguments as default keyword arguments (since python retains that mutability here); likely just assign to None and then initialize it in the function if u need to a empty array.","commit_id":"9d911389ac4111118ab06b1639f1745433ed6054"},{"author":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"change_message_id":"6b67714f6cba31ceb85d6d1823f62a0f8b0fa86c","unresolved":false,"context_lines":[{"line_number":636,"context_line":""},{"line_number":637,"context_line":"    def fetch_mapped_args(self, args_mapping,"},{"line_number":638,"context_line":"                          atom_name\u003dNone, scope_walker\u003dNone,"},{"line_number":639,"context_line":"                          optional_args\u003d[]):"},{"line_number":640,"context_line":"        \"\"\"Fetch arguments for an atom using an atoms argument mapping.\"\"\""},{"line_number":641,"context_line":""},{"line_number":642,"context_line":"        def _get_results(looking_for, provider):"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_d7909150","line":639,"in_reply_to":"da86d52c_22d1b657","updated":"2015-02-03 09:28:10.000000000","message":"Done","commit_id":"9d911389ac4111118ab06b1639f1745433ed6054"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"5943cbf1f35dc4ef4bea5524d8c6ee162115e389","unresolved":false,"context_lines":[{"line_number":636,"context_line":""},{"line_number":637,"context_line":"    def fetch_mapped_args(self, args_mapping,"},{"line_number":638,"context_line":"                          atom_name\u003dNone, scope_walker\u003dNone,"},{"line_number":639,"context_line":"                          optional_args\u003d[]):"},{"line_number":640,"context_line":"        \"\"\"Fetch arguments for an atom using an atoms argument mapping.\"\"\""},{"line_number":641,"context_line":""},{"line_number":642,"context_line":"        def _get_results(looking_for, provider):"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_a2ca064d","line":639,"in_reply_to":"da86d52c_22d1b657","updated":"2015-02-03 01:18:27.000000000","message":"http://docs.python-guide.org/en/latest/writing/gotchas/#mutable-default-arguments has a nice little overview of this..","commit_id":"9d911389ac4111118ab06b1639f1745433ed6054"},{"author":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"change_message_id":"6b67714f6cba31ceb85d6d1823f62a0f8b0fa86c","unresolved":false,"context_lines":[{"line_number":636,"context_line":""},{"line_number":637,"context_line":"    def fetch_mapped_args(self, args_mapping,"},{"line_number":638,"context_line":"                          atom_name\u003dNone, scope_walker\u003dNone,"},{"line_number":639,"context_line":"                          optional_args\u003d[]):"},{"line_number":640,"context_line":"        \"\"\"Fetch arguments for an atom using an atoms argument mapping.\"\"\""},{"line_number":641,"context_line":""},{"line_number":642,"context_line":"        def _get_results(looking_for, provider):"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_b77cfd21","line":639,"in_reply_to":"da86d52c_a2ca064d","updated":"2015-02-03 09:28:10.000000000","message":"Done","commit_id":"9d911389ac4111118ab06b1639f1745433ed6054"}]}
