)]}'
{"id":"openstack%2Ftaskflow~151972","triplet_id":"openstack%2Ftaskflow~master~I440c02dcd901a563df512e33754b13e3c05d4155","project":"openstack/taskflow","branch":"master","topic":"map_optional_args","hashtags":[],"change_id":"I440c02dcd901a563df512e33754b13e3c05d4155","subject":"Map optional arguments as well as required arguments","status":"MERGED","created":"2015-02-02 01:46:53.000000000","updated":"2015-02-11 08:39:51.000000000","submitted":"2015-02-11 08:39:50.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":27,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"ed56e6de506c194752c19687475ba4ad265b5b44","_number":151972,"virtual_id_number":151972,"owner":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"value":2,"date":"2015-02-11 08:39:50.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14084,"name":"Einst Crazy","email":"yu.changcai@99cloud.net","username":"Einst"},{"value":0,"_account_id":7366,"name":"Ivan Melnikov","email":"imelnikov@griddynamics.com","username":"imelnikov"},{"value":0,"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"all":[{"value":2,"date":"2015-02-11 06:33:31.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2015-02-11 07:36:19.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":14084,"name":"Einst Crazy","email":"yu.changcai@99cloud.net","username":"Einst"},{"value":2,"date":"2015-02-11 07:56:05.000000000","_account_id":7366,"name":"Ivan Melnikov","email":"imelnikov@griddynamics.com","username":"imelnikov"},{"value":0,"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7366,"name":"Ivan Melnikov","email":"imelnikov@griddynamics.com","username":"imelnikov"},"all":[{"value":0,"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14084,"name":"Einst Crazy","email":"yu.changcai@99cloud.net","username":"Einst"},{"value":1,"date":"2015-02-11 07:56:05.000000000","_account_id":7366,"name":"Ivan Melnikov","email":"imelnikov@griddynamics.com","username":"imelnikov"},{"value":0,"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14084,"name":"Einst Crazy","email":"yu.changcai@99cloud.net","username":"Einst"},{"value":0,"_account_id":7366,"name":"Ivan Melnikov","email":"imelnikov@griddynamics.com","username":"imelnikov"},{"value":0,"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"_account_id":7366,"name":"Ivan Melnikov","email":"imelnikov@griddynamics.com","username":"imelnikov"},{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},{"_account_id":14084,"name":"Einst Crazy","email":"yu.changcai@99cloud.net","username":"Einst"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-02-11 06:33:31.000000000","updated_by":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"reviewer":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"state":"REVIEWER"},{"updated":"2015-02-11 07:36:19.000000000","updated_by":{"_account_id":14084,"name":"Einst Crazy","email":"yu.changcai@99cloud.net","username":"Einst"},"reviewer":{"_account_id":14084,"name":"Einst Crazy","email":"yu.changcai@99cloud.net","username":"Einst"},"state":"REVIEWER"},{"updated":"2015-02-11 07:56:05.000000000","updated_by":{"_account_id":7366,"name":"Ivan Melnikov","email":"imelnikov@griddynamics.com","username":"imelnikov"},"reviewer":{"_account_id":7366,"name":"Ivan Melnikov","email":"imelnikov@griddynamics.com","username":"imelnikov"},"state":"REVIEWER"},{"updated":"2015-02-11 08:39:50.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"de85b6836b684653f10515cd9a3836821e23d897","author":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"date":"2015-02-02 01:46:53.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"cd77cd639d1ced46f8c673215782628294639720","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-02-02 02:21:26.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-taskflow-python26 http://logs.openstack.org/72/151972/1/check/gate-taskflow-python26/aac6b53/ : SUCCESS in 1m 49s\n- gate-taskflow-pep8 http://logs.openstack.org/72/151972/1/check/gate-taskflow-pep8/c0024f8/ : FAILURE in 58s\n- gate-taskflow-docs http://docs-draft.openstack.org/72/151972/1/check/gate-taskflow-docs/1f9abc6//doc/build/html/ : SUCCESS in 1m 24s\n- gate-taskflow-python27 http://logs.openstack.org/72/151972/1/check/gate-taskflow-python27/cea77db/ : SUCCESS in 1m 46s\n- gate-tempest-dsvm-neutron-src-taskflow http://logs.openstack.org/72/151972/1/check/gate-tempest-dsvm-neutron-src-taskflow/64c24c0/ : SUCCESS in 34m 28s\n- gate-tempest-dsvm-neutron-src-taskflow-icehouse http://logs.openstack.org/72/151972/1/check/gate-tempest-dsvm-neutron-src-taskflow-icehouse/deedef1/ : SUCCESS in 23m 24s\n- gate-tempest-dsvm-neutron-src-taskflow-juno http://logs.openstack.org/72/151972/1/check/gate-tempest-dsvm-neutron-src-taskflow-juno/35f3580/ : SUCCESS in 27m 28s\n- gate-taskflow-python34 http://logs.openstack.org/72/151972/1/check/gate-taskflow-python34/00c1747/ : SUCCESS in 3m 23s\n- gate-taskflow-tox-py26-sa7-mysql http://logs.openstack.org/72/151972/1/check/gate-taskflow-tox-py26-sa7-mysql/f5134f2/ : SUCCESS in 1m 44s\n- gate-taskflow-tox-py27-sa8-mysql http://logs.openstack.org/72/151972/1/check/gate-taskflow-tox-py27-sa8-mysql/aad656d/ : SUCCESS in 1m 10s","accounts_in_message":[],"_revision_number":1},{"id":"38e298595459a6b28a40f98d16ccbdc676502357","author":{"_account_id":7366,"name":"Ivan Melnikov","email":"imelnikov@griddynamics.com","username":"imelnikov"},"date":"2015-02-02 15:43:15.000000000","message":"Patch Set 1: Code-Review-1\n\nMin,\n\nThank you for your contribution. I can\u0027t remember why exactly optional arguments are ignored when deriving, maybe I thought that adding them in would make our overly complex code even more complex. But, as you show here, it can be done without dramatically increasing code complexity.\n\nWhat I am strongly against in your patch is how you change the Atom interface. First, it is not backward-compatible. Second, after your change it is *required* to use isinstance to use the value of atom.rebind correctly.\n\nI would like to insist on avoiding ambiguity in types whenever you can, especially in return types of functions and methods. Instead, you can make atom.rebind to be a combined dictionary (which would include both required and optional args after your change), and provide a way to check if argument is required -- something as simple as atom.is_required_argument(argument_name) method -- to allow Storage to determine if it needs to raise on KeyError.\n\nIt also looks like a good idea to add a function to get optional arguments (only) to oslo.utils.reflection.","accounts_in_message":[],"_revision_number":1},{"id":"5f9a9aa526e4edaa0f0c2d111ab290611c04218c","author":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"date":"2015-02-02 20:37:42.000000000","message":"Patch Set 1: Workflow-1\n\nThank you for the feedback, what do you think about the following?\n\nCurrently rebind is stored and \"requires\" is the list of keys extracted from rebind.  Rather than store required and optional parameters as separate dictionaries, how about we merge the two to a single dictionary mapped to \"rebind\", and also generate two lists during Atom._build_arg_mapping \"required\" and \"optional\", the former being the list of keys from the required argument dictionary, and the latter being the list of keys from the optional argument dictionary?\n\nCode might be a little easier to follow than descriptions, here\u0027s a paste of the new Atom code I\u0027m suggesting, I will implement and fix anything that breaks prior to submitting a new patch.\n\nhttp://paste.openstack.org/show/165768/","accounts_in_message":[],"_revision_number":1},{"id":"ce031a04fc70478c62c8b6ecd77808e5ce5e2405","author":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"date":"2015-02-03 00:07:29.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"a608e47797cfa7fd8d81700a9285ed6919087954","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-02-03 01:03:20.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-taskflow-python26 http://logs.openstack.org/72/151972/2/check/gate-taskflow-python26/01c4fd1/ : SUCCESS in 1m 24s\n- gate-taskflow-pep8 http://logs.openstack.org/72/151972/2/check/gate-taskflow-pep8/56488c9/ : SUCCESS in 1m 05s\n- gate-taskflow-docs http://docs-draft.openstack.org/72/151972/2/check/gate-taskflow-docs/cb54d0b//doc/build/html/ : SUCCESS in 1m 14s\n- gate-taskflow-python27 http://logs.openstack.org/72/151972/2/check/gate-taskflow-python27/3668b8e/ : SUCCESS in 1m 14s\n- gate-tempest-dsvm-neutron-src-taskflow http://logs.openstack.org/72/151972/2/check/gate-tempest-dsvm-neutron-src-taskflow/580f04d/ : SUCCESS in 43m 17s\n- gate-tempest-dsvm-neutron-src-taskflow-icehouse http://logs.openstack.org/72/151972/2/check/gate-tempest-dsvm-neutron-src-taskflow-icehouse/6a9c2b8/ : SUCCESS in 23m 56s\n- gate-tempest-dsvm-neutron-src-taskflow-juno http://logs.openstack.org/72/151972/2/check/gate-tempest-dsvm-neutron-src-taskflow-juno/589d99d/ : SUCCESS in 33m 38s\n- gate-taskflow-python34 http://logs.openstack.org/72/151972/2/check/gate-taskflow-python34/b790f00/ : SUCCESS in 3m 26s\n- gate-taskflow-tox-py26-sa7-mysql http://logs.openstack.org/72/151972/2/check/gate-taskflow-tox-py26-sa7-mysql/8703c13/ : SUCCESS in 1m 57s\n- gate-taskflow-tox-py27-sa8-mysql http://logs.openstack.org/72/151972/2/check/gate-taskflow-tox-py27-sa8-mysql/04e6740/ : SUCCESS in 1m 24s","accounts_in_message":[],"_revision_number":2},{"id":"7d90ec894e8183c3463323d18b6507fa60d252d7","author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"date":"2015-02-03 01:17:54.000000000","message":"Patch Set 2:\n\n(5 comments)\n\nAdded a few comments/ideas/questions.","accounts_in_message":[],"_revision_number":2},{"id":"5943cbf1f35dc4ef4bea5524d8c6ee162115e389","author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"date":"2015-02-03 01:18:27.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"23acdc30f0fd692b1a1cb9309150b3434b8013b5","author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"date":"2015-02-03 01:38:00.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"24e037f90bef1992c93d87c6cdf7eb1e70243a70","author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"date":"2015-02-03 06:15:34.000000000","message":"Patch Set 2:\n\nAnother thing that would be nice (but could be done in a follow-up commit) would be to update the docs that generate http://docs.openstack.org/developer/taskflow/arguments_and_results.html with this new adjustment/addition.","accounts_in_message":[],"_revision_number":2},{"id":"6b67714f6cba31ceb85d6d1823f62a0f8b0fa86c","author":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"date":"2015-02-03 09:28:10.000000000","message":"Patch Set 2:\n\n(6 comments)","accounts_in_message":[],"_revision_number":2},{"id":"9e7a6f9c839fd05145c345d5b320ad9ead365e63","author":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"date":"2015-02-03 09:28:35.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"da1165e74bb44759c545cc98e78ef54f4430a17b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-02-03 09:59:45.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-taskflow-python26 http://logs.openstack.org/72/151972/3/check/gate-taskflow-python26/8fd4868/ : SUCCESS in 1m 31s\n- gate-taskflow-pep8 http://logs.openstack.org/72/151972/3/check/gate-taskflow-pep8/1640786/ : SUCCESS in 44s\n- gate-taskflow-docs http://docs-draft.openstack.org/72/151972/3/check/gate-taskflow-docs/dd04c41//doc/build/html/ : SUCCESS in 1m 14s\n- gate-taskflow-python27 http://logs.openstack.org/72/151972/3/check/gate-taskflow-python27/12806ee/ : SUCCESS in 1m 41s\n- gate-tempest-dsvm-neutron-src-taskflow http://logs.openstack.org/72/151972/3/check/gate-tempest-dsvm-neutron-src-taskflow/009b343/ : SUCCESS in 30m 59s\n- gate-tempest-dsvm-neutron-src-taskflow-icehouse http://logs.openstack.org/72/151972/3/check/gate-tempest-dsvm-neutron-src-taskflow-icehouse/474b715/ : SUCCESS in 28m 09s\n- gate-tempest-dsvm-neutron-src-taskflow-juno http://logs.openstack.org/72/151972/3/check/gate-tempest-dsvm-neutron-src-taskflow-juno/8923846/ : SUCCESS in 31m 08s\n- gate-taskflow-python34 http://logs.openstack.org/72/151972/3/check/gate-taskflow-python34/1d94d84/ : SUCCESS in 2m 54s\n- gate-taskflow-tox-py26-sa7-mysql http://logs.openstack.org/72/151972/3/check/gate-taskflow-tox-py26-sa7-mysql/7718cf0/ : SUCCESS in 1m 23s\n- gate-taskflow-tox-py27-sa8-mysql http://logs.openstack.org/72/151972/3/check/gate-taskflow-tox-py27-sa8-mysql/f4bb99b/ : SUCCESS in 1m 17s","accounts_in_message":[],"_revision_number":3},{"id":"180aa92a1abe44bfbc7e75cd94ed67d80ceb2f13","author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"date":"2015-02-03 20:38:31.000000000","message":"Patch Set 3:\n\n(1 comment)\n\nSeems ok to me (with a few more changes + docs about it) + some unit tests that test this addition would be great to have; also would like to know what ivan thinks about this...","accounts_in_message":[],"_revision_number":3},{"id":"4c5adda1919405a51ed853f1fe5bbf8e1ece383c","author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"date":"2015-02-03 20:39:54.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"106126a64b11eb4341e91aac88e4b34a17bd2054","author":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"date":"2015-02-03 21:47:01.000000000","message":"Patch Set 3:\n\n(2 comments)","accounts_in_message":[],"_revision_number":3},{"id":"7b7855048ec5e343a0f14bea29649b9b26a5e25f","author":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"date":"2015-02-05 06:21:50.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"203d547f9e7043c9ea7a280245bfeb202622a8bb","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-02-05 07:13:32.000000000","message":"Patch Set 4: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-taskflow-python26 http://logs.openstack.org/72/151972/4/check/gate-taskflow-python26/6c04b1e/ : SUCCESS in 1m 33s\n- gate-taskflow-pep8 http://logs.openstack.org/72/151972/4/check/gate-taskflow-pep8/c354625/ : FAILURE in 1m 02s\n- gate-taskflow-docs http://docs-draft.openstack.org/72/151972/4/check/gate-taskflow-docs/f290d43//doc/build/html/ : SUCCESS in 1m 27s\n- gate-taskflow-python27 http://logs.openstack.org/72/151972/4/check/gate-taskflow-python27/74bffc3/ : SUCCESS in 1m 26s\n- gate-tempest-dsvm-neutron-src-taskflow http://logs.openstack.org/72/151972/4/check/gate-tempest-dsvm-neutron-src-taskflow/d052cc8/ : SUCCESS in 43m 10s\n- gate-tempest-dsvm-neutron-src-taskflow-icehouse http://logs.openstack.org/72/151972/4/check/gate-tempest-dsvm-neutron-src-taskflow-icehouse/c6f6c09/ : SUCCESS in 26m 29s\n- gate-tempest-dsvm-neutron-src-taskflow-juno http://logs.openstack.org/72/151972/4/check/gate-tempest-dsvm-neutron-src-taskflow-juno/35c8a27/ : SUCCESS in 32m 48s\n- gate-taskflow-python34 http://logs.openstack.org/72/151972/4/check/gate-taskflow-python34/94be576/ : FAILURE in 2m 34s\n- gate-taskflow-tox-py26-sa7-mysql http://logs.openstack.org/72/151972/4/check/gate-taskflow-tox-py26-sa7-mysql/2f3ae0d/ : SUCCESS in 1m 48s\n- gate-taskflow-tox-py27-sa8-mysql http://logs.openstack.org/72/151972/4/check/gate-taskflow-tox-py27-sa8-mysql/e5fb199/ : SUCCESS in 1m 22s","accounts_in_message":[],"_revision_number":4},{"id":"6f4bbf0121783ea89184ad081ad27655f9814982","author":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"date":"2015-02-05 10:44:00.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"66c9f0b9c72cdb14d78c3f40ebb7c67a98a42bde","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-02-05 11:23:38.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-taskflow-python26 http://logs.openstack.org/72/151972/5/check/gate-taskflow-python26/c999ed3/ : SUCCESS in 1m 44s\n- gate-taskflow-pep8 http://logs.openstack.org/72/151972/5/check/gate-taskflow-pep8/a3f8fc5/ : SUCCESS in 57s\n- gate-taskflow-docs http://docs-draft.openstack.org/72/151972/5/check/gate-taskflow-docs/bc71c09//doc/build/html/ : SUCCESS in 1m 53s\n- gate-taskflow-python27 http://logs.openstack.org/72/151972/5/check/gate-taskflow-python27/9b62451/ : SUCCESS in 1m 37s\n- gate-tempest-dsvm-neutron-src-taskflow http://logs.openstack.org/72/151972/5/check/gate-tempest-dsvm-neutron-src-taskflow/d21b287/ : SUCCESS in 36m 14s\n- gate-tempest-dsvm-neutron-src-taskflow-icehouse http://logs.openstack.org/72/151972/5/check/gate-tempest-dsvm-neutron-src-taskflow-icehouse/6da9ab2/ : SUCCESS in 25m 04s\n- gate-tempest-dsvm-neutron-src-taskflow-juno http://logs.openstack.org/72/151972/5/check/gate-tempest-dsvm-neutron-src-taskflow-juno/0822f3d/ : SUCCESS in 29m 46s\n- gate-taskflow-python34 http://logs.openstack.org/72/151972/5/check/gate-taskflow-python34/37897aa/ : SUCCESS in 3m 26s\n- gate-taskflow-tox-py26-sa7-mysql http://logs.openstack.org/72/151972/5/check/gate-taskflow-tox-py26-sa7-mysql/9cee4f1/ : SUCCESS in 1m 37s\n- gate-taskflow-tox-py27-sa8-mysql http://logs.openstack.org/72/151972/5/check/gate-taskflow-tox-py27-sa8-mysql/27ba806/ : SUCCESS in 1m 36s","accounts_in_message":[],"_revision_number":5},{"id":"ecfafda59324de4de075bcb350c6b406325eb96d","author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"date":"2015-02-05 18:59:04.000000000","message":"Patch Set 5: Code-Review+1\n\nLooks good to me. Thanks much :)","accounts_in_message":[],"_revision_number":5},{"id":"3b9782256ea1db428ae77db009c551056d33175b","author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"date":"2015-02-05 19:09:14.000000000","message":"Patch Set 5: Code-Review+2","accounts_in_message":[],"_revision_number":5},{"id":"56b5be2944f719f8290ed6cfe291ca01d918a643","author":{"_account_id":7366,"name":"Ivan Melnikov","email":"imelnikov@griddynamics.com","username":"imelnikov"},"date":"2015-02-08 10:59:51.000000000","message":"Patch Set 5: Code-Review+1\n\n(5 comments)\n\nThank you for your work, looks really good.\n\nI\u0027ve thrown in few suggestions inline in atom.py. It would also be great to see more unit tests for the new functionality in test_task.py or somewhere, e.g. along the lines of your example. But all this can be done in future changes, if you want. Or not done at all if you don\u0027t agree with me \u003d)","accounts_in_message":[],"_revision_number":5},{"id":"ad50ffe388772fcfa37bb2ab5bb30136db9004e0","author":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"date":"2015-02-10 23:20:38.000000000","message":"Patch Set 5: Code-Review+1\n\nThanks Ivan, can you please approve the merge if you\u0027re OK with the change?  If you\u0027d like more done before this can be merged please let me know.  Also, with respect to additional tests, I\u0027m happy to add them, I just couldn\u0027t think of any beyond the ones I already added/modified.","accounts_in_message":[],"_revision_number":5},{"id":"76f286790d98fe47058564cedf21afa603ae2ddd","author":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"date":"2015-02-11 04:38:36.000000000","message":"Patch Set 5: Code-Review-1\n\n(5 comments)","accounts_in_message":[],"_revision_number":5},{"id":"05cbf61b80cdff1b91e7ceb07f0acbd350fb6742","author":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"date":"2015-02-11 05:27:51.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"b81555ad0638fcba234a0b6d923722adf2bdc1e1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-02-11 06:16:54.000000000","message":"Patch Set 6: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-taskflow-python26 http://logs.openstack.org/72/151972/6/check/gate-taskflow-python26/f25cd54/ : SUCCESS in 1m 20s\n- gate-taskflow-pep8 http://logs.openstack.org/72/151972/6/check/gate-taskflow-pep8/d8d9a5c/ : SUCCESS in 1m 02s\n- gate-taskflow-docs http://docs-draft.openstack.org/72/151972/6/check/gate-taskflow-docs/bb79ceb//doc/build/html/ : SUCCESS in 1m 47s\n- gate-taskflow-python27 http://logs.openstack.org/72/151972/6/check/gate-taskflow-python27/f2f22ee/ : SUCCESS in 1m 25s\n- gate-tempest-dsvm-neutron-src-taskflow http://logs.openstack.org/72/151972/6/check/gate-tempest-dsvm-neutron-src-taskflow/3026f72/ : SUCCESS in 46m 18s\n- gate-taskflow-python34 http://logs.openstack.org/72/151972/6/check/gate-taskflow-python34/9e0bb5c/ : SUCCESS in 2m 44s\n- gate-taskflow-tox-py26-sa7-mysql http://logs.openstack.org/72/151972/6/check/gate-taskflow-tox-py26-sa7-mysql/3e71e15/ : SUCCESS in 1m 34s\n- gate-taskflow-tox-py27-sa8-mysql http://logs.openstack.org/72/151972/6/check/gate-taskflow-tox-py27-sa8-mysql/2322c70/ : SUCCESS in 1m 22s","accounts_in_message":[],"_revision_number":6},{"id":"64e46725ec9c44ee6f9729ec9ca80e9ad32bf76e","author":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"date":"2015-02-11 06:32:52.000000000","message":"Uploaded patch set 7.","accounts_in_message":[],"_revision_number":7},{"id":"2253c4483ccf862fc0c01e880aef68468245d9c9","author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"date":"2015-02-11 06:33:31.000000000","message":"Patch Set 7: Code-Review+2\n\nThanks, should be useful for folks :)","accounts_in_message":[],"_revision_number":7},{"id":"96ebed39560fd80c57bbb978db5b1945516fae70","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-02-11 07:21:05.000000000","message":"Patch Set 7: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-taskflow-python26 http://logs.openstack.org/72/151972/7/check/gate-taskflow-python26/44b8be0/ : SUCCESS in 1m 43s\n- gate-taskflow-pep8 http://logs.openstack.org/72/151972/7/check/gate-taskflow-pep8/e47e4c0/ : SUCCESS in 1m 03s\n- gate-taskflow-docs http://docs-draft.openstack.org/72/151972/7/check/gate-taskflow-docs/fa44ddd//doc/build/html/ : SUCCESS in 1m 06s\n- gate-taskflow-python27 http://logs.openstack.org/72/151972/7/check/gate-taskflow-python27/a189193/ : SUCCESS in 1m 49s\n- gate-tempest-dsvm-neutron-src-taskflow http://logs.openstack.org/72/151972/7/check/gate-tempest-dsvm-neutron-src-taskflow/5f160af/ : SUCCESS in 39m 33s\n- gate-taskflow-python34 http://logs.openstack.org/72/151972/7/check/gate-taskflow-python34/eb61d65/ : SUCCESS in 2m 24s\n- gate-taskflow-tox-py26-sa7-mysql http://logs.openstack.org/72/151972/7/check/gate-taskflow-tox-py26-sa7-mysql/e8776e8/ : SUCCESS in 1m 24s\n- gate-taskflow-tox-py27-sa8-mysql http://logs.openstack.org/72/151972/7/check/gate-taskflow-tox-py27-sa8-mysql/68dd898/ : SUCCESS in 1m 22s","accounts_in_message":[],"_revision_number":7},{"id":"ce29ee229b6498c0fe29371a5642d9214c6e47f1","author":{"_account_id":14084,"name":"Einst Crazy","email":"yu.changcai@99cloud.net","username":"Einst"},"date":"2015-02-11 07:36:19.000000000","message":"Patch Set 7: Code-Review+1","accounts_in_message":[],"_revision_number":7},{"id":"ff56415d3b626c57ebd762317ab5b81a8960afc2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-02-11 07:56:05.000000000","message":"Patch Set 7: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":7},{"id":"df9ba913380e614d95275de55d85a882e50b9911","author":{"_account_id":7366,"name":"Ivan Melnikov","email":"imelnikov@griddynamics.com","username":"imelnikov"},"date":"2015-02-11 07:56:05.000000000","message":"Patch Set 7: Code-Review+2 Workflow+1\n\nMin, thank you for your work!","accounts_in_message":[],"_revision_number":7},{"id":"01b2db818b326a1ec4ab376a435145ca5940dae6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-02-11 08:39:50.000000000","message":"Patch Set 7: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-taskflow-python26 http://logs.openstack.org/72/151972/7/gate/gate-taskflow-python26/4e60560/ : SUCCESS in 1m 27s\n- gate-taskflow-docs http://docs-draft.openstack.org/72/151972/7/gate/gate-taskflow-docs/65735f9//doc/build/html/ : SUCCESS in 59s\n- gate-taskflow-pep8 http://logs.openstack.org/72/151972/7/gate/gate-taskflow-pep8/59b09a5/ : SUCCESS in 1m 04s\n- gate-taskflow-python27 http://logs.openstack.org/72/151972/7/gate/gate-taskflow-python27/618f2ee/ : SUCCESS in 1m 48s\n- gate-tempest-dsvm-neutron-src-taskflow http://logs.openstack.org/72/151972/7/gate/gate-tempest-dsvm-neutron-src-taskflow/d1763c5/ : SUCCESS in 43m 42s\n- gate-taskflow-tox-py26-sa7-mysql http://logs.openstack.org/72/151972/7/gate/gate-taskflow-tox-py26-sa7-mysql/c7e1740/ : SUCCESS in 1m 34s\n- gate-taskflow-tox-py27-sa8-mysql http://logs.openstack.org/72/151972/7/gate/gate-taskflow-tox-py27-sa8-mysql/2876647/ : SUCCESS in 1m 35s\n- gate-taskflow-python34 http://logs.openstack.org/72/151972/7/gate/gate-taskflow-python34/9ffa737/ : SUCCESS in 3m 25s","accounts_in_message":[],"_revision_number":7},{"id":"d81045e7c03888b17186b0d617203562e137fc2e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-02-11 08:39:51.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":7}],"current_revision_number":7,"current_revision":"7f0c457e72a8946a01ff7a93c67e3d35e383728c","revisions":{"fcb72f7ffefe4caa77d75cb87142a6ec5575c6df":{"kind":"REWORK","_number":1,"created":"2015-02-02 01:46:53.000000000","uploader":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"ref":"refs/changes/72/151972/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/taskflow","ref":"refs/changes/72/151972/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/72/151972/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/72/151972/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/72/151972/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/taskflow refs/changes/72/151972/1"}}},"commit":{"parents":[{"commit":"eae693406ef3205d33c3bc712e19041d0a19f3bc","subject":"Merge \"Remove duplicated \u0027do\u0027 in types documentation\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/eae693406ef3205d33c3bc712e19041d0a19f3bc"}]}],"author":{"name":"Min Pae","email":"sputnik13@gmail.com","date":"2015-01-31 06:49:28.000000000","tz":-480},"committer":{"name":"Min Pae","email":"sputnik13@gmail.com","date":"2015-02-01 10:49:41.000000000","tz":-480},"subject":"Map optional arguments as well as required arguments","message":"Map optional arguments as well as required arguments\n\nOptional arguments that are not explicitly required are being ignored\nwhen arguments are being mapped based on inference from atoms\u0027 execute\nmethod signatures.  This patch adds support for mapping optional\narguments in addition to required arguments.\n\nChange-Id: I440c02dcd901a563df512e33754b13e3c05d4155\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/fcb72f7ffefe4caa77d75cb87142a6ec5575c6df"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/fcb72f7ffefe4caa77d75cb87142a6ec5575c6df"}]},"branch":"refs/heads/master"},"9d911389ac4111118ab06b1639f1745433ed6054":{"kind":"REWORK","_number":2,"created":"2015-02-03 00:07:29.000000000","uploader":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"ref":"refs/changes/72/151972/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/taskflow","ref":"refs/changes/72/151972/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/72/151972/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/72/151972/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/72/151972/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/taskflow refs/changes/72/151972/2"}}},"commit":{"parents":[{"commit":"eae693406ef3205d33c3bc712e19041d0a19f3bc","subject":"Merge \"Remove duplicated \u0027do\u0027 in types documentation\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/eae693406ef3205d33c3bc712e19041d0a19f3bc"}]}],"author":{"name":"Min Pae","email":"sputnik13@gmail.com","date":"2015-01-31 06:49:28.000000000","tz":-480},"committer":{"name":"Min Pae","email":"sputnik13@gmail.com","date":"2015-02-03 00:05:25.000000000","tz":-480},"subject":"Map optional arguments as well as required arguments","message":"Map optional arguments as well as required arguments\n\nOptional arguments that are not explicitly required are being ignored\nwhen arguments are being mapped based on inference from atoms\u0027 execute\nmethod signatures.  This patch adds support for mapping optional\narguments in addition to required arguments.\n\nChange-Id: I440c02dcd901a563df512e33754b13e3c05d4155\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/9d911389ac4111118ab06b1639f1745433ed6054"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/9d911389ac4111118ab06b1639f1745433ed6054"}]},"branch":"refs/heads/master"},"869589b05769bb55dcd428202fd5f73fc59a3315":{"kind":"REWORK","_number":3,"created":"2015-02-03 09:28:35.000000000","uploader":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"ref":"refs/changes/72/151972/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/taskflow","ref":"refs/changes/72/151972/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/72/151972/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/72/151972/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/72/151972/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/taskflow refs/changes/72/151972/3"}}},"commit":{"parents":[{"commit":"eae693406ef3205d33c3bc712e19041d0a19f3bc","subject":"Merge \"Remove duplicated \u0027do\u0027 in types documentation\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/eae693406ef3205d33c3bc712e19041d0a19f3bc"}]}],"author":{"name":"Min Pae","email":"sputnik13@gmail.com","date":"2015-01-31 06:49:28.000000000","tz":-480},"committer":{"name":"Min Pae","email":"sputnik13@gmail.com","date":"2015-02-03 09:25:15.000000000","tz":-480},"subject":"Map optional arguments as well as required arguments","message":"Map optional arguments as well as required arguments\n\nOptional arguments that are not explicitly required are being ignored\nwhen arguments are being mapped based on inference from atoms\u0027 execute\nmethod signatures.  This patch adds support for mapping optional\narguments in addition to required arguments.\n\nChange-Id: I440c02dcd901a563df512e33754b13e3c05d4155\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/869589b05769bb55dcd428202fd5f73fc59a3315"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/869589b05769bb55dcd428202fd5f73fc59a3315"}]},"branch":"refs/heads/master"},"2bf3d8d9962e6841fe22eaa3510098ad88896fd2":{"kind":"REWORK","_number":4,"created":"2015-02-05 06:21:50.000000000","uploader":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"ref":"refs/changes/72/151972/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/taskflow","ref":"refs/changes/72/151972/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/72/151972/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/72/151972/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/72/151972/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/taskflow refs/changes/72/151972/4"}}},"commit":{"parents":[{"commit":"eae693406ef3205d33c3bc712e19041d0a19f3bc","subject":"Merge \"Remove duplicated \u0027do\u0027 in types documentation\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/eae693406ef3205d33c3bc712e19041d0a19f3bc"}]}],"author":{"name":"Min Pae","email":"sputnik13@gmail.com","date":"2015-01-31 06:49:28.000000000","tz":-480},"committer":{"name":"Min Pae","email":"sputnik13@gmail.com","date":"2015-02-05 06:21:38.000000000","tz":-480},"subject":"Map optional arguments as well as required arguments","message":"Map optional arguments as well as required arguments\n\nOptional arguments that are not explicitly required are being ignored\nwhen arguments are being mapped based on inference from atoms\u0027 execute\nmethod signatures.  This patch adds support for mapping optional\narguments in addition to required arguments.\n\nChange-Id: I440c02dcd901a563df512e33754b13e3c05d4155\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/2bf3d8d9962e6841fe22eaa3510098ad88896fd2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/2bf3d8d9962e6841fe22eaa3510098ad88896fd2"}]},"branch":"refs/heads/master"},"32effb43e5d2357e04f1ea2e5e4ed35613ed7542":{"kind":"REWORK","_number":5,"created":"2015-02-05 10:44:00.000000000","uploader":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"ref":"refs/changes/72/151972/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/taskflow","ref":"refs/changes/72/151972/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/72/151972/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/72/151972/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/72/151972/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/taskflow refs/changes/72/151972/5"}}},"commit":{"parents":[{"commit":"eae693406ef3205d33c3bc712e19041d0a19f3bc","subject":"Merge \"Remove duplicated \u0027do\u0027 in types documentation\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/eae693406ef3205d33c3bc712e19041d0a19f3bc"}]}],"author":{"name":"Min Pae","email":"sputnik13@gmail.com","date":"2015-01-31 06:49:28.000000000","tz":-480},"committer":{"name":"Min Pae","email":"sputnik13@gmail.com","date":"2015-02-05 10:43:50.000000000","tz":-480},"subject":"Map optional arguments as well as required arguments","message":"Map optional arguments as well as required arguments\n\nOptional arguments that are not explicitly required are being ignored\nwhen arguments are being mapped based on inference from atoms\u0027 execute\nmethod signatures.  This patch adds support for mapping optional\narguments in addition to required arguments.\n\nChange-Id: I440c02dcd901a563df512e33754b13e3c05d4155\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/32effb43e5d2357e04f1ea2e5e4ed35613ed7542"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/32effb43e5d2357e04f1ea2e5e4ed35613ed7542"}]},"branch":"refs/heads/master"},"d7ccd3c416ae90fb1deed2a4161c13732a108383":{"kind":"REWORK","_number":6,"created":"2015-02-11 05:27:51.000000000","uploader":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"ref":"refs/changes/72/151972/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/taskflow","ref":"refs/changes/72/151972/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/72/151972/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/72/151972/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/72/151972/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/taskflow refs/changes/72/151972/6"}}},"commit":{"parents":[{"commit":"eae693406ef3205d33c3bc712e19041d0a19f3bc","subject":"Merge \"Remove duplicated \u0027do\u0027 in types documentation\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/eae693406ef3205d33c3bc712e19041d0a19f3bc"}]}],"author":{"name":"Min Pae","email":"sputnik13@gmail.com","date":"2015-01-31 06:49:28.000000000","tz":-480},"committer":{"name":"Min Pae","email":"sputnik13@gmail.com","date":"2015-02-11 05:27:38.000000000","tz":-480},"subject":"Map optional arguments as well as required arguments","message":"Map optional arguments as well as required arguments\n\nOptional arguments that are not explicitly required are being ignored\nwhen arguments are being mapped based on inference from atoms\u0027 execute\nmethod signatures.  This patch adds support for mapping optional\narguments in addition to required arguments.\n\nChange-Id: I440c02dcd901a563df512e33754b13e3c05d4155\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/d7ccd3c416ae90fb1deed2a4161c13732a108383"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/d7ccd3c416ae90fb1deed2a4161c13732a108383"}]},"branch":"refs/heads/master"},"7f0c457e72a8946a01ff7a93c67e3d35e383728c":{"kind":"REWORK","_number":7,"created":"2015-02-11 06:32:52.000000000","uploader":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"ref":"refs/changes/72/151972/7","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/taskflow","ref":"refs/changes/72/151972/7","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/72/151972/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/72/151972/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/72/151972/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/taskflow refs/changes/72/151972/7"}}},"commit":{"parents":[{"commit":"eae693406ef3205d33c3bc712e19041d0a19f3bc","subject":"Merge \"Remove duplicated \u0027do\u0027 in types documentation\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/eae693406ef3205d33c3bc712e19041d0a19f3bc"}]}],"author":{"name":"Min Pae","email":"sputnik13@gmail.com","date":"2015-01-31 06:49:28.000000000","tz":-480},"committer":{"name":"Min Pae","email":"sputnik13@gmail.com","date":"2015-02-11 06:32:38.000000000","tz":-480},"subject":"Map optional arguments as well as required arguments","message":"Map optional arguments as well as required arguments\n\nOptional arguments that are not explicitly required are being ignored\nwhen arguments are being mapped based on inference from atoms\u0027 execute\nmethod signatures.  This patch adds support for mapping optional\narguments in addition to required arguments.\n\nChange-Id: I440c02dcd901a563df512e33754b13e3c05d4155\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/7f0c457e72a8946a01ff7a93c67e3d35e383728c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/7f0c457e72a8946a01ff7a93c67e3d35e383728c"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
