)]}'
{"id":"openstack%2Ftaskflow~154281","triplet_id":"openstack%2Ftaskflow~master~Ic74dab22b09100c5b653d12c2518f83a1bf8e859","project":"openstack/taskflow","branch":"master","topic":"conductor_stop_locking","hashtags":[],"change_id":"Ic74dab22b09100c5b653d12c2518f83a1bf8e859","subject":"Modify stop and add wait on conductor to prevent lockups","status":"MERGED","created":"2015-02-09 22:57:40.000000000","updated":"2015-02-12 07:08:10.000000000","submitted":"2015-02-12 07:08:09.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"7c4dfb54c9d476464443d13d1ddb9081b58c8842","_number":154281,"virtual_id_number":154281,"owner":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"value":2,"date":"2015-02-12 07:08:09.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"all":[{"value":2,"date":"2015-02-09 23:37:49.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"all":[{"value":1,"date":"2015-02-12 06:14:19.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-02-12 06:14:19.000000000","updated_by":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"reviewer":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"state":"REVIEWER"},{"updated":"2015-02-12 07:08:09.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"ad9c7e382b7b43252c7921b0a83dfd201278b7ea","author":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"date":"2015-02-09 22:57:40.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9d936dde172d65f2344ceec2c0e49993c23482a0","author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"date":"2015-02-09 23:01:12.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"bba1fa56b21570c982a28eaa2d0a848ba4e57cdd","author":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"date":"2015-02-09 23:32:01.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"3dd5c1746072d83005d74926ef0e9eb60e45008d","author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"date":"2015-02-09 23:37:49.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"ebed0b49495b73f5dbe100a3a91501b261e7af58","author":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"date":"2015-02-09 23:37:56.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"afdaf63daa519e4386474eec91621f22b46a1f12","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-02-10 00:24:51.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-taskflow-python26 http://logs.openstack.org/81/154281/2/check/gate-taskflow-python26/a25a41a/ : SUCCESS in 1m 24s\n- gate-taskflow-pep8 http://logs.openstack.org/81/154281/2/check/gate-taskflow-pep8/4da667c/ : SUCCESS in 1m 04s\n- gate-taskflow-docs http://docs-draft.openstack.org/81/154281/2/check/gate-taskflow-docs/29db858//doc/build/html/ : SUCCESS in 1m 34s\n- gate-taskflow-python27 http://logs.openstack.org/81/154281/2/check/gate-taskflow-python27/382d921/ : SUCCESS in 1m 40s\n- gate-tempest-dsvm-neutron-src-taskflow http://logs.openstack.org/81/154281/2/check/gate-tempest-dsvm-neutron-src-taskflow/74da478/ : SUCCESS in 46m 14s\n- gate-taskflow-python34 http://logs.openstack.org/81/154281/2/check/gate-taskflow-python34/c447dfb/ : SUCCESS in 3m 16s\n- gate-taskflow-tox-py26-sa7-mysql http://logs.openstack.org/81/154281/2/check/gate-taskflow-tox-py26-sa7-mysql/2fb077a/ : SUCCESS in 1m 32s\n- gate-taskflow-tox-py27-sa8-mysql http://logs.openstack.org/81/154281/2/check/gate-taskflow-tox-py27-sa8-mysql/3d64140/ : SUCCESS in 1m 33s","accounts_in_message":[],"_revision_number":2},{"id":"89df0dd63fa7094dd8666b7fefb6f40b7d9452d1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-02-12 06:14:19.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"9396d63fb89be7ccebc4239f67312998017156d6","author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"date":"2015-02-12 06:14:19.000000000","message":"Patch Set 2: Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"06294cf63b6cec3305ae5bd6f6311c9b78dd1f26","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-02-12 07:08:09.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-taskflow-python26 http://logs.openstack.org/81/154281/2/gate/gate-taskflow-python26/e13aab4/ : SUCCESS in 1m 31s\n- gate-taskflow-docs http://docs-draft.openstack.org/81/154281/2/gate/gate-taskflow-docs/07a3641//doc/build/html/ : SUCCESS in 1m 18s\n- gate-taskflow-pep8 http://logs.openstack.org/81/154281/2/gate/gate-taskflow-pep8/80286c4/ : SUCCESS in 1m 27s\n- gate-taskflow-python27 http://logs.openstack.org/81/154281/2/gate/gate-taskflow-python27/e2774ef/ : SUCCESS in 2m 00s\n- gate-tempest-dsvm-neutron-src-taskflow http://logs.openstack.org/81/154281/2/gate/gate-tempest-dsvm-neutron-src-taskflow/65d4f8c/ : SUCCESS in 52m 02s\n- gate-taskflow-tox-py26-sa7-mysql http://logs.openstack.org/81/154281/2/gate/gate-taskflow-tox-py26-sa7-mysql/0b5d358/ : SUCCESS in 1m 54s\n- gate-taskflow-tox-py27-sa8-mysql http://logs.openstack.org/81/154281/2/gate/gate-taskflow-tox-py27-sa8-mysql/71bac03/ : SUCCESS in 1m 23s\n- gate-taskflow-python34 http://logs.openstack.org/81/154281/2/gate/gate-taskflow-python34/f7452c5/ : SUCCESS in 3m 22s","accounts_in_message":[],"_revision_number":2},{"id":"a2ed9835a65eea07ad6e777668b23ee9ec8d0974","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-02-12 07:08:10.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"e7df6c66f041218b204a8b0785da0ee1b728dbda","revisions":{"677fc36cb6470ba43e7e1bda71f096f270a790d4":{"kind":"REWORK","_number":1,"created":"2015-02-09 22:57:40.000000000","uploader":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"ref":"refs/changes/81/154281/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/taskflow","ref":"refs/changes/81/154281/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/81/154281/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/81/154281/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/81/154281/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/taskflow refs/changes/81/154281/1"}}},"commit":{"parents":[{"commit":"6924b3622a0b62ee27c5b4e6a00745b04fedf0c1","subject":"Merge \"Add warning to sqlalchemy backend size limit docs\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/6924b3622a0b62ee27c5b4e6a00745b04fedf0c1"}]}],"author":{"name":"Min Pae","email":"sputnik13@gmail.com","date":"2015-02-09 22:50:41.000000000","tz":-480},"committer":{"name":"Min Pae","email":"sputnik13@gmail.com","date":"2015-02-09 22:50:41.000000000","tz":-480},"subject":"Modify stop and add wait on conductor to prevent lockups","message":"Modify stop and add wait on conductor to prevent lockups\n\nRemoved _dead.wait from the stop method and added a wait method to\nexplicitly wait for graceful shutdown.  Implicitly waiting for\ngraceful shutdown in the stop method is leading to potential\ndeadlock situations when conductor is running in the main thread\nand a signal handler is used to kick off stop/shutdown.\n\nAlso in larger systems, it is desirable to be able to initiate\nshutdown on all running services then wait/join everything together\nso as not to force a serial shutdown pattern.\n\nChange-Id: Ic74dab22b09100c5b653d12c2518f83a1bf8e859\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/677fc36cb6470ba43e7e1bda71f096f270a790d4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/677fc36cb6470ba43e7e1bda71f096f270a790d4"}]},"branch":"refs/heads/master"},"e7df6c66f041218b204a8b0785da0ee1b728dbda":{"kind":"REWORK","_number":2,"created":"2015-02-09 23:32:01.000000000","uploader":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"ref":"refs/changes/81/154281/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/taskflow","ref":"refs/changes/81/154281/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/81/154281/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/81/154281/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/81/154281/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/taskflow refs/changes/81/154281/2"}}},"commit":{"parents":[{"commit":"6924b3622a0b62ee27c5b4e6a00745b04fedf0c1","subject":"Merge \"Add warning to sqlalchemy backend size limit docs\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/6924b3622a0b62ee27c5b4e6a00745b04fedf0c1"}]}],"author":{"name":"Min Pae","email":"sputnik13@gmail.com","date":"2015-02-09 22:50:41.000000000","tz":-480},"committer":{"name":"Min Pae","email":"sputnik13@gmail.com","date":"2015-02-09 23:30:27.000000000","tz":-480},"subject":"Modify stop and add wait on conductor to prevent lockups","message":"Modify stop and add wait on conductor to prevent lockups\n\nRemoved _dead.wait from the stop method and added a wait method to\nexplicitly wait for graceful shutdown.  Implicitly waiting for\ngraceful shutdown in the stop method is leading to potential\ndeadlock situations when conductor is running in the main thread\nand a signal handler is used to kick off stop/shutdown.\n\nAlso in larger systems, it is desirable to be able to initiate\nshutdown on all running services then wait/join everything together\nso as not to force a serial shutdown pattern.\n\nChange-Id: Ic74dab22b09100c5b653d12c2518f83a1bf8e859\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/e7df6c66f041218b204a8b0785da0ee1b728dbda"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/e7df6c66f041218b204a8b0785da0ee1b728dbda"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
